repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
FreeRDP/FreeRDP | 12,812 | comment_to_fix | [client,android] add .rdp file import and share support | * there is also the `.rdpw` extension used nowadays | 9b04e3b26f11208a8450d748850ce017e9a9f7eb | 73aed8cc21c098141f83afbea00782b74da3fae6 | diff --git a/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/BookmarkViewModel.java b/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/BookmarkViewModel.java
index f96573d43455..aff96a871fe2 100644
--- a/client/Android/Studio/freeRDPCore/src/main/... | [
"client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/BookmarkViewModel.java"
] | [
{
"comment": "* there is also the `.rdpw` extension used nowadays",
"path": "client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/BookmarkViewModel.java",
"hunk": "@@ -121,20 +122,23 @@ else if (ConnectionReference.isHostnameReference(refStr))\n \t\t\t\t}\n \t\t\t\telse i... | true | ||
FreeRDP/FreeRDP | 12,812 | comment_to_fix | [client,android] add .rdp file import and share support | file might use different encodings, specifically `ucs2/utf-16`
check https://commons.apache.org/proper/commons-io/apidocs/org/apache/commons/io/input/BOMInputStream.html | 9b04e3b26f11208a8450d748850ce017e9a9f7eb | 73aed8cc21c098141f83afbea00782b74da3fae6 | diff --git a/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/utils/RDPFileHelper.java b/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/utils/RDPFileHelper.java
new file mode 100644
index 000000000000..c10732b91c2b
--- /dev/null
+++ b/client/Android/Studio/freeRDPCore/src... | [
"client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/utils/RDPFileHelper.java"
] | [
{
"comment": "file might use different encodings, specifically `ucs2/utf-16` \ncheck https://commons.apache.org/proper/commons-io/apidocs/org/apache/commons/io/input/BOMInputStream.html",
"path": "client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/utils/RDPFileHelper.java",
"hunk": ... | true | ||
FreeRDP/FreeRDP | 12,812 | comment_to_fix | [client,android] add .rdp file import and share support | might be a good idea to use a wrapper function to write a single line.
```
void writeStringEntry(@NonNull StringBuilder sb, @NonNull String key, @NonNull String value) {
sb.append(key).append(":s:").append(value).append("\r\n");
}
writeStringEntry(sb, "address", host + ":" + port);
``` | 9b04e3b26f11208a8450d748850ce017e9a9f7eb | 73aed8cc21c098141f83afbea00782b74da3fae6 | diff --git a/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/utils/RDPFileHelper.java b/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/utils/RDPFileHelper.java
new file mode 100644
index 000000000000..c10732b91c2b
--- /dev/null
+++ b/client/Android/Studio/freeRDPCore/src... | [
"client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/utils/RDPFileHelper.java"
] | [
{
"comment": "might be a good idea to use a wrapper function to write a single line. \n```\nvoid writeStringEntry(@NonNull StringBuilder sb, @NonNull String key, @NonNull String value) {\n sb.append(key).append(\":s:\").append(value).append(\"\\r\\n\");\n}\n\nwriteStringEntry(sb, \"address\", host + \":\" + po... | true | ||
FreeRDP/FreeRDP | 12,807 | issue_to_patch | aFreeRDP: several simultaneous connections
Please add support for several simultaneous connections for. Right now trying to open the app again after connection just shows this connection. Expected behaviour is to have a separate window for each connection.
aFreeRDP DisplayLink multi monitor support
**Describe the so... | [client,android] Add multi-session and external display support | ## [client,android] Add multi-session and external display support
### Description
This pull request introduces concurrent multi-session RDP connections as the primary feature, along with independent support for external displays on Android.
Users can now open and run multiple RDP sessions at the same time in se... | 3cd6cf0e24130185c05be63846ebcc85b7fe0ea4 | 7b049a56acf4504b64042435b2638e49b1a27109 | diff --git a/client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml b/client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml
index d6c8b700e610..58d0fe5bb7e7 100644
--- a/client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml
+++ b/client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml
@... | [
"client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml",
"client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/ExternalDisplayManager.java",
"client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/HomeActivity.java",
"client/Android/Studio... | [] | true | |
FreeRTOS/FreeRTOS | 1,401 | issue_to_patch | [Feature Request] Enable use of the TaskNotificationArray.c test file on 16-bit devices
**Is your feature request related to a problem? Please describe.**
The TaskNotificationArray.c demo/test file contains a file scope function named [prvRand() that uses size_t types](https://github.com/FreeRTOS/FreeRTOS/blob/master... | Fix: Replace size_t with uint32_t in TaskNotifyArray.c for 16-bit dev… | Description
-----------
Replace `size_t` with `uint32_t` in the `prvRand()` pseudo-random number
generator function and related variables in both `TaskNotifyArray.c` and
`TaskNotify.c` demo/test files.
The `prvRand()` implementation assumes `size_t` is at least 32 bits
(e.g., it uses the constant `0x015a4e35` a... | b72aef2d316c0571eaf6a9e528e759b8e2ba107b | 3756bd2f3ffab2f9c420920d9634054d7dd83040 | diff --git a/FreeRTOS/Demo/Common/Minimal/TaskNotify.c b/FreeRTOS/Demo/Common/Minimal/TaskNotify.c
index 67a3d8b1a0f..5226b15ad7d 100644
--- a/FreeRTOS/Demo/Common/Minimal/TaskNotify.c
+++ b/FreeRTOS/Demo/Common/Minimal/TaskNotify.c
@@ -105,7 +105,7 @@ static uint32_t ulTimerNotificationsReceived = 0UL, ulTimerNotifica... | [
"FreeRTOS/Demo/Common/Minimal/TaskNotify.c",
"FreeRTOS/Demo/Common/Minimal/TaskNotifyArray.c"
] | [
{
"comment": "Why is this added?",
"path": ".vscode/tasks.json",
"hunk": "@@ -0,0 +1,28 @@\n+{\n+ \"tasks\": [",
"resolving_sha": "3756bd2f3ffab2f9c420920d9634054d7dd83040",
"resolving_diff": ""
},
{
"comment": "```suggestion\n const uint32_t uxMultiplier = ( uint32_t ) 0x015a4e35,... | true | |
FreeRTOS/FreeRTOS | 1,406 | issue_to_patch | Fix undefined behavior in mbedTLS transport log format specifiers | Description
-----------
Fix three undefined behavior bugs in the mbedTLS transport logging code.
1. `transport_mbedtls.c` and `transport_mbedtls_pkcs11.c`: `psa_crypto_init()`
returns `psa_status_t`, which is an integer error code. Both files logged
this value with `%s`, causing the runtime to treat the in... | e6af9f22e568c93416e509b6c4d12cb8e82c13c4 | 83d7c003c7970d68255afc6f086c5911e9135b5a | diff --git a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c
index e6350e56d7b..f75dcafeb4b 100644
--- a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c
+++ b/FreeRTOS-Plu... | [
"FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c",
"FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls_pkcs11.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,400 | issue_to_patch | [BUG] FreeRTOS_Plus_TCP_Echo_Posix console.c is broken
**Describe the bug**
The FreeRTOS_Plus_TCP_Echo_Posix [console.c](https://github.com/FreeRTOS/FreeRTOS/blob/main/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Posix/console.c) file appears to be a modified copy of the Posix_GCC [console.c](https://github.com/FreeRTOS/... | Fix: Add missing xSemaphoreGive in TCP Echo Posix console.c | The console_print() function in the FreeRTOS_Plus_TCP_Echo_Posix demo takes the stdio mutex but never releases it, causing a deadlock after the first call to console_print().
This commit syncs the file with Posix_GCC/console.c by:
Adding missing xSemaphoreGive() call
Adding missing #include console.h
Making... | 1495a812e4676e291bf787ba02ee988f9dfe25ec | 419b9ab5abcbbb17241056a7f7892c6f78f3f912 | diff --git a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Posix/console.c b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Posix/console.c
index ec6a047baef..d9bff9485e6 100644
--- a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Posix/console.c
+++ b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Posix/console.c
@@ -34,12 +34,22 @@
#i... | [
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Posix/console.c"
] | [] | true | |
FreeRTOS/FreeRTOS | 1,405 | issue_to_patch | Added timeout to SSL handshake in transport_mbedtls.c | <!--- Title -->
Possible endless loop in case of a server hanging during the SSL handshake.
-----------
It is merely a guard against FreeRTOS hanging in case of a server not responding during SSL handshake, but still maintaining the connection.
At least theoretically, it could be used for denial-of-service.... | 675335bf6a90dad4f67d23561768f959f41783bb | 9648805000215ede1f6660799dd11359d5707aef | diff --git a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c
index b668ea11dce..e6350e56d7b 100644
--- a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c
+++ b/FreeRTOS-Plu... | [
"FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c"
] | [
{
"comment": "Fix formatting\r\n```suggestion\r\n TickType_t handshakeTimeoutTicks = pdMS_TO_TICKS( 10000 );\r\n TimeOut_t handshakeStart;\r\n vTaskSetTimeOutState( &handshakeStart );\r\n\r\n```",
"path": "FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c"... | true | ||
FreeRTOS/FreeRTOS | 1,405 | comment_to_fix | Added timeout to SSL handshake in transport_mbedtls.c | Fix formatting
```suggestion
TickType_t handshakeTimeoutTicks = pdMS_TO_TICKS( 10000 );
TimeOut_t handshakeStart;
vTaskSetTimeOutState( &handshakeStart );
``` | 675335bf6a90dad4f67d23561768f959f41783bb | 9648805000215ede1f6660799dd11359d5707aef | diff --git a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c
index b668ea11dce..e6350e56d7b 100644
--- a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c
+++ b/FreeRTOS-Plu... | [
"FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c"
] | [
{
"comment": "Fix formatting\r\n```suggestion\r\n TickType_t handshakeTimeoutTicks = pdMS_TO_TICKS( 10000 );\r\n TimeOut_t handshakeStart;\r\n vTaskSetTimeOutState( &handshakeStart );\r\n\r\n```",
"path": "FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c"... | true | ||
FreeRTOS/FreeRTOS | 1,405 | comment_to_fix | Added timeout to SSL handshake in transport_mbedtls.c | ```suggestion
} while( ( ( mbedtlsError == MBEDTLS_ERR_SSL_WANT_READ ) ||
( mbedtlsError == MBEDTLS_ERR_SSL_WANT_WRITE ) ) &&
( xTaskCheckForTimeOut( &handshakeStart, &handshakeTimeoutTicks ) == pdFALSE ) );
``` | 675335bf6a90dad4f67d23561768f959f41783bb | 9648805000215ede1f6660799dd11359d5707aef | diff --git a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c
index b668ea11dce..e6350e56d7b 100644
--- a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c
+++ b/FreeRTOS-Plu... | [
"FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c"
] | [
{
"comment": "```suggestion\r\n } while( ( ( mbedtlsError == MBEDTLS_ERR_SSL_WANT_READ ) ||\r\n ( mbedtlsError == MBEDTLS_ERR_SSL_WANT_WRITE ) ) &&\r\n ( xTaskCheckForTimeOut( &handshakeStart, &handshakeTimeoutTicks ) == pdFALSE ) );\r\n```",
"path": "FreeRTOS-Plus/S... | true | ||
FreeRTOS/FreeRTOS | 1,398 | issue_to_patch | Update demos to use MQTTv5 APIs and code | <!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Checklist:
----------
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don... | 99cf475718d499934e04c7a969154168beff6cdc | 33c6547825e26bc49fcfe489168119bbfe6e19e7 | diff --git a/.github/workflows/freertos_plus_demos.yml b/.github/workflows/freertos_plus_demos.yml
index 14c66584508..e3105bc904f 100644
--- a/.github/workflows/freertos_plus_demos.yml
+++ b/.github/workflows/freertos_plus_demos.yml
@@ -449,23 +449,63 @@ jobs:
- name: Query CI host IP address
id: get-ip... | [
".github/workflows/freertos_plus_demos.yml",
"FreeRTOS-Plus/Demo/AWS/Device_Defender_Windows_Simulator/Device_Defender_Demo/DemoTasks/DefenderDemoExample.c",
"FreeRTOS-Plus/Demo/AWS/Device_Defender_Windows_Simulator/Device_Defender_Demo/Device_Defender_Demo.vcxproj",
"FreeRTOS-Plus/Demo/AWS/Device_Defender_Wi... | [
{
"comment": "Why is this being increased 10x?",
"path": "FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c",
"hunk": "@@ -104,7 +104,7 @@\n /**\n * @brief Timeout for receiving CONNACK packet in milliseconds.\n */\n-#define mqttexampleCONNACK_RECV_TIMEOUT_MS ( 1000U )\n+#define m... | true | ||
FreeRTOS/FreeRTOS | 1,398 | comment_to_fix | Update demos to use MQTTv5 APIs and code | Why is this being increased 10x? | 99cf475718d499934e04c7a969154168beff6cdc | 33c6547825e26bc49fcfe489168119bbfe6e19e7 | diff --git a/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c b/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c
index 144d180a96e..5b2bb88f6eb 100644
--- a/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c
+++ b/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c
@@ -104,7 +... | [
"FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c"
] | [
{
"comment": "Why is this being increased 10x?",
"path": "FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c",
"hunk": "@@ -104,7 +104,7 @@\n /**\n * @brief Timeout for receiving CONNACK packet in milliseconds.\n */\n-#define mqttexampleCONNACK_RECV_TIMEOUT_MS ( 1000U )\n+#define m... | true | ||
FreeRTOS/FreeRTOS | 1,398 | comment_to_fix | Update demos to use MQTTv5 APIs and code | Same here - why the increase? | 99cf475718d499934e04c7a969154168beff6cdc | 33c6547825e26bc49fcfe489168119bbfe6e19e7 | diff --git a/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c b/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c
index 170e35758ef..617f0e916ce 100644
--- a/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c
+++ b/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs1... | [
"FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c"
] | [
{
"comment": "Same here - why the increase?",
"path": "FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c",
"hunk": "@@ -98,7 +98,7 @@\n /**\n * @brief Timeout for receiving CONNACK packet in milliseconds.\n */\n-#define mqttexampleCONNACK_RECV_TIMEOUT_MS ( 1000U )\n+#define... | true | ||
FreeRTOS/FreeRTOS | 1,403 | issue_to_patch | Update community and partner supported demos | Description
-----------
Update the community and partner demos to the latest available commits.
Submodule hashes:
* https://github.com/FreeRTOS/FreeRTOS-Partner-Supported-Demos/tree/fcb807d7591ba459a7fb254e85ca6108e5fe32b6
* https://github.com/FreeRTOS/FreeRTOS-Community-Supported-Demos/tree/2ff0ab79d6c3c0dc79f2... | b5e17ae32f7a100a1947cf21d636fe409a24fe8b | ebab917baab1e45de6098547654aaab9d4f5fe1b | diff --git a/FreeRTOS/Demo/ThirdParty/Community-Supported-Demos b/FreeRTOS/Demo/ThirdParty/Community-Supported-Demos
index 272ca5bfbe0..2ff0ab79d6c 160000
--- a/FreeRTOS/Demo/ThirdParty/Community-Supported-Demos
+++ b/FreeRTOS/Demo/ThirdParty/Community-Supported-Demos
@@ -1,1 +1,1 @@
-Subproject commit 272ca5bfbe0ea8a5... | [
"FreeRTOS/Demo/ThirdParty/Community-Supported-Demos",
"FreeRTOS/Demo/ThirdParty/Partner-Supported-Demos",
"manifest.yml"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,395 | issue_to_patch | Update the Kernel and TCP submodule, fix build failures | <!--- Title -->
Description
-----------
Using this PR to lazily check CBMC execution, build checks.
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Checklist:
----------
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about ... | 862f6bf9516c2610b0fc28c4d22b1ed1269d517e | be77fddd2df8f9492fb59fb2153b1dede0f24124 | diff --git a/FreeRTOS-Plus/Demo/Common/Logging/windows/Logging_WinSim.c b/FreeRTOS-Plus/Demo/Common/Logging/windows/Logging_WinSim.c
index c2e2881ccd1..1892933911b 100644
--- a/FreeRTOS-Plus/Demo/Common/Logging/windows/Logging_WinSim.c
+++ b/FreeRTOS-Plus/Demo/Common/Logging/windows/Logging_WinSim.c
@@ -42,6 +42,9 @@
... | [
"FreeRTOS-Plus/Demo/Common/Logging/windows/Logging_WinSim.c",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_CLI_with_Trace_Windows_Simulator/Run-time-stats-utils.c",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_Reliance_Edge_and_CLI_Windows_Simulator/Run-time-stats-utils.c",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_Reliance_Edge_and_CLI_W... | [] | true | ||
FreeRTOS/FreeRTOS | 1,396 | issue_to_patch | Fix spelling error | <!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
Correct the spelling of 'therefor' to the proper spelling of 'therefore'
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Leveraging CI check for spelling
Checklist:
----------
<!--- Go over all the follo... | 827044f804bcae8794c29e709b96b764c5182384 | 62fbccf65c599e819128ce38fca72bcb35955e01 | diff --git a/FreeRTOS-Plus/Demo/AWS/Device_Shadow_Windows_Simulator/Device_Shadow_Demo/DemoTasks/ShadowDemoMainExample.c b/FreeRTOS-Plus/Demo/AWS/Device_Shadow_Windows_Simulator/Device_Shadow_Demo/DemoTasks/ShadowDemoMainExample.c
index a611d3f175f..f8c1523377a 100644
--- a/FreeRTOS-Plus/Demo/AWS/Device_Shadow_Windows_... | [
"FreeRTOS-Plus/Demo/AWS/Device_Shadow_Windows_Simulator/Device_Shadow_Demo/DemoTasks/ShadowDemoMainExample.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,393 | issue_to_patch | Fixed a bug in the HTTP server sample where the browser would not respond when a 404 error occurred. | Fixed a bug in the HTTP server sample where the browser would not respond when a 404 error occurred.
Description
-----------
Fixed a bug that caused the browser to keep waiting for a response when a file was not found on the HTTP server.
The Content-Length header is missing only in the 404 case, so I added it, li... | ff5a96c5017f8bee8399a4a04a360273fdc8cbad | b06152e209399f4972fae27a69ecbbd422393b7d | diff --git a/FreeRTOS-Plus/Demo/Common/Demo_IP_Protocols/HTTP_Server/FreeRTOS_HTTP_server.c b/FreeRTOS-Plus/Demo/Common/Demo_IP_Protocols/HTTP_Server/FreeRTOS_HTTP_server.c
index d61f241ec78..93d62d8b9f0 100644
--- a/FreeRTOS-Plus/Demo/Common/Demo_IP_Protocols/HTTP_Server/FreeRTOS_HTTP_server.c
+++ b/FreeRTOS-Plus/Demo... | [
"FreeRTOS-Plus/Demo/Common/Demo_IP_Protocols/HTTP_Server/FreeRTOS_HTTP_server.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,392 | issue_to_patch | Fix timeout type from BaseType_t to TickType_t | Fix timeout type from BaseType_t to TickType_t
Description
-----------
Fixed a bug where the timeout value was not reflected correctly in FreeRTOS_TCP_Server when TickType_t was set to 64-bit.
Test Steps
-----------
In portmacro.h, change TickType_t to uint64_t.
Set xNoTimeout to 1000.
Verify that the loop ... | 30b61e5503cf31710172582720929173db500b4e | 8aee7241f9ac898d475497768c548266a78eaf16 | diff --git a/FreeRTOS-Plus/Demo/Common/Demo_IP_Protocols/Common/FreeRTOS_TCP_server.c b/FreeRTOS-Plus/Demo/Common/Demo_IP_Protocols/Common/FreeRTOS_TCP_server.c
index 39e6b3e4e9f..3b287f41e3b 100644
--- a/FreeRTOS-Plus/Demo/Common/Demo_IP_Protocols/Common/FreeRTOS_TCP_server.c
+++ b/FreeRTOS-Plus/Demo/Common/Demo_IP_Pr... | [
"FreeRTOS-Plus/Demo/Common/Demo_IP_Protocols/Common/FreeRTOS_TCP_server.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,391 | issue_to_patch | remove stray semicolons | Remove stray semicolons from demo code.
<!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Checklist:
----------
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!-... | e83f1402d53635abb2bd178dfa6db157e10edd1c | 32eb94f6302ecb79993b0fbb76fd26a7b5976d93 | diff --git a/FreeRTOS/Demo/CORTEX_A53_64-bit_UltraScale_MPSoC/RTOSDemo_A53_bsp/psu_cortexa53_0/libsrc/sdps_v3_4/src/xsdps_options.c b/FreeRTOS/Demo/CORTEX_A53_64-bit_UltraScale_MPSoC/RTOSDemo_A53_bsp/psu_cortexa53_0/libsrc/sdps_v3_4/src/xsdps_options.c
index bcd7c689b8b..6478b95aaf1 100644
--- a/FreeRTOS/Demo/CORTEX_A5... | [
"FreeRTOS/Demo/CORTEX_A53_64-bit_UltraScale_MPSoC/RTOSDemo_A53_bsp/psu_cortexa53_0/libsrc/sdps_v3_4/src/xsdps_options.c",
"FreeRTOS/Demo/CORTEX_A5_SAMA5D2x_Xplained_IAR/AtmelFiles/utils/lcd_draw.c",
"FreeRTOS/Demo/CORTEX_A9_Cyclone_V_SoC_DK/Altera_Code/HardwareLibrary/alt_dma_program.c",
"FreeRTOS/Demo/CORTEX... | [] | true | ||
FreeRTOS/FreeRTOS | 1,385 | issue_to_patch | Fix Fleet Provisioning demo flow issues | <!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
- Updated the flow of Fleet Provisioning demo reference code to avoid closing PKCS11 session prematurely.
- Updated the function `xPkcs11CloseSession` to avoid deinitializing PKCS#11 library prematurely.
Test Steps
---------... | 81a6503deeb73592a5624330c9a9af4346af2622 | f2116aaf524e2393306d53aa1a6435d68645ceda | diff --git a/FreeRTOS-Plus/Demo/AWS/Fleet_Provisioning_Windows_Simulator/CSR_Demo/FleetProvisioningDemoExample.c b/FreeRTOS-Plus/Demo/AWS/Fleet_Provisioning_Windows_Simulator/CSR_Demo/FleetProvisioningDemoExample.c
index c8e75dd0a6c..c796ca6f4c2 100644
--- a/FreeRTOS-Plus/Demo/AWS/Fleet_Provisioning_Windows_Simulator/C... | [
"FreeRTOS-Plus/Demo/AWS/Fleet_Provisioning_Windows_Simulator/CSR_Demo/FleetProvisioningDemoExample.c",
"FreeRTOS-Plus/Demo/AWS/Fleet_Provisioning_Windows_Simulator/CSR_Demo/pkcs11_operations.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,390 | issue_to_patch | Fix wrong condition in mqtt_pkcs11_demo_helpers.c | <!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
Fix the wrong condition as pointed out in https://github.com/FreeRTOS/FreeRTOS/issues/1206 and https://github.com/FreeRTOS/FreeRTOS/issues/1389
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Checklist:
-... | 22d02e9fe4d28cf555d69ee09204ef527625a4a9 | f9a891e6cb50d66feb4853ecc502b35cb6ab97eb | diff --git a/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c b/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c
index 77520b9c545..144d180a96e 100644
--- a/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c
+++ b/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c
@@ -809,7 +... | [
"FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_demo_helpers.c",
"FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,382 | issue_to_patch | Add unit test coverage for vTaskPriorityDisinheritAfterTimeout | <!--- Title -->
Description
-----------
vTaskPriorityDisinheritAfterTimeout has been tweaked to reset
the original priority upon entry. This change
modifies unit tests to verify this
This tests changes made in https://github.com/FreeRTOS/FreeRTOS-Kernel/pull/1338
Test Steps
-----------
Updated unit tests... | 4879cfd2089af620a2eb495cc8532937c2a29670 | b89c8003f3a62ad2e0dd6b17f3a39920b59a3610 | diff --git a/FreeRTOS/Source b/FreeRTOS/Source
index 0030d609a4b..1dbc77697f4 160000
--- a/FreeRTOS/Source
+++ b/FreeRTOS/Source
@@ -1,1 +1,1 @@
-Subproject commit 0030d609a4b99118d9a400340d88c3c3c4816f2b
+Subproject commit 1dbc77697f4c63e1b18a2c7f7a15aad4ae14af7e
diff --git a/manifest.yml b/manifest.yml
index d7b47e27... | [
"FreeRTOS/Source",
"FreeRTOS/Test/CMock/tasks/tasks_1_utest.c",
"manifest.yml"
] | [
{
"comment": "Could yhou write this as bit shifts to make it more clear what priorities are being set to ready e.g. 1 << 1 | 1 << 2 | 1 << 3?",
"path": "FreeRTOS/Test/CMock/tasks/tasks_1_utest.c",
"hunk": "@@ -4813,35 +4813,67 @@ void test_vTaskPriorityDisinheritAfterTimeout_fail_null_handle()\n void te... | diff --git a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
index 529224ad3de..19a9fb92ce2 100644
--- a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
+++ b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
@@ -50,7 +50,6 @@
#include <string.h>
#include <stdlib.h>
-
/* ===================... | true | |
FreeRTOS/FreeRTOS | 1,382 | comment_to_fix | Add unit test coverage for vTaskPriorityDisinheritAfterTimeout | Could yhou write this as bit shifts to make it more clear what priorities are being set to ready e.g. 1 << 1 | 1 << 2 | 1 << 3? | 4879cfd2089af620a2eb495cc8532937c2a29670 | b89c8003f3a62ad2e0dd6b17f3a39920b59a3610 | diff --git a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
index 529224ad3de..19a9fb92ce2 100644
--- a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
+++ b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
@@ -50,7 +50,6 @@
#include <string.h>
#include <stdlib.h>
-
/* ===================... | [
"FreeRTOS/Test/CMock/tasks/tasks_1_utest.c"
] | [
{
"comment": "Could yhou write this as bit shifts to make it more clear what priorities are being set to ready e.g. 1 << 1 | 1 << 2 | 1 << 3?",
"path": "FreeRTOS/Test/CMock/tasks/tasks_1_utest.c",
"hunk": "@@ -4813,35 +4813,67 @@ void test_vTaskPriorityDisinheritAfterTimeout_fail_null_handle()\n void te... | true | ||
FreeRTOS/FreeRTOS | 1,382 | comment_to_fix | Add unit test coverage for vTaskPriorityDisinheritAfterTimeout | What is 0x80000...UL supposed to represent? Could you name this value? | 4879cfd2089af620a2eb495cc8532937c2a29670 | b89c8003f3a62ad2e0dd6b17f3a39920b59a3610 | diff --git a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
index 529224ad3de..19a9fb92ce2 100644
--- a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
+++ b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
@@ -50,7 +50,6 @@
#include <string.h>
#include <stdlib.h>
-
/* ===================... | [
"FreeRTOS/Test/CMock/tasks/tasks_1_utest.c"
] | [
{
"comment": "What is 0x80000...UL supposed to represent? Could you name this value?",
"path": "FreeRTOS/Test/CMock/tasks/tasks_1_utest.c",
"hunk": "@@ -4813,35 +4813,67 @@ void test_vTaskPriorityDisinheritAfterTimeout_fail_null_handle()\n void test_vTaskPriorityDisinheritAfterTimeout_success()\n {\n ... | true | ||
FreeRTOS/FreeRTOS | 1,382 | comment_to_fix | Add unit test coverage for vTaskPriorityDisinheritAfterTimeout | Again write as bit shift for clarity. | 4879cfd2089af620a2eb495cc8532937c2a29670 | b89c8003f3a62ad2e0dd6b17f3a39920b59a3610 | diff --git a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
index 529224ad3de..19a9fb92ce2 100644
--- a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
+++ b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
@@ -50,7 +50,6 @@
#include <string.h>
#include <stdlib.h>
-
/* ===================... | [
"FreeRTOS/Test/CMock/tasks/tasks_1_utest.c"
] | [
{
"comment": "Again write as bit shift for clarity.",
"path": "FreeRTOS/Test/CMock/tasks/tasks_1_utest.c",
"hunk": "@@ -4813,35 +4813,67 @@ void test_vTaskPriorityDisinheritAfterTimeout_fail_null_handle()\n void test_vTaskPriorityDisinheritAfterTimeout_success()\n {\n TaskHandle_t mutex_holder;\n+ ... | true | ||
FreeRTOS/FreeRTOS | 1,382 | comment_to_fix | Add unit test coverage for vTaskPriorityDisinheritAfterTimeout | Again not sure what the 0x8000..UL value is supposed to be and why we expect it. | 4879cfd2089af620a2eb495cc8532937c2a29670 | b89c8003f3a62ad2e0dd6b17f3a39920b59a3610 | diff --git a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
index 529224ad3de..19a9fb92ce2 100644
--- a/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
+++ b/FreeRTOS/Test/CMock/tasks/tasks_1_utest.c
@@ -50,7 +50,6 @@
#include <string.h>
#include <stdlib.h>
-
/* ===================... | [
"FreeRTOS/Test/CMock/tasks/tasks_1_utest.c"
] | [
{
"comment": "Again not sure what the 0x8000..UL value is supposed to be and why we expect it.",
"path": "FreeRTOS/Test/CMock/tasks/tasks_1_utest.c",
"hunk": "@@ -4813,35 +4813,67 @@ void test_vTaskPriorityDisinheritAfterTimeout_fail_null_handle()\n void test_vTaskPriorityDisinheritAfterTimeout_success(... | true | ||
FreeRTOS/FreeRTOS | 1,381 | issue_to_patch | docs: add beginner-friendly FreeRTOS overview | Added a short beginner-focused overview explaining basic FreeRTOS concepts
such as tasks, scheduler, and tick, to improve accessibility for new users.
| df34d1f9a1d8d0eec774721873cc48de9d4b4bd1 | 59b08f9d5799afd8fa36b8d55281d5a4ca7e2e23 | diff --git a/README.md b/README.md
index 737d6ccb67e..d467899130e 100644
--- a/README.md
+++ b/README.md
@@ -50,6 +50,11 @@ This repository contains the FreeRTOS Kernel, a number of supplementary librarie
[Releases](https://github.com/FreeRTOS/FreeRTOS/releases) contains older FreeRTOS releases.
+## Learning FreeR... | [
"README.md"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,380 | issue_to_patch | Demo: allow overriding toolchain prefix in RISC-V QEMU virt GCC demo | Description
-----------
This change makes the RISC-V QEMU virt GCC demo Makefile more portable by allowing
the toolchain prefix to be overridden via `make CROSS=...`.
The default behavior remains unchanged (`riscv64-unknown-elf-` is still used when
no override is provided), but this allows users to build the dem... | 5424d9d36a364ba9c73955c500d16773f543bb9c | 7d6c30f895543462f1eae3d5a08a782470c5a6cf | diff --git a/FreeRTOS/Demo/RISC-V-Qemu-virt_GCC/Makefile b/FreeRTOS/Demo/RISC-V-Qemu-virt_GCC/Makefile
index 4fe130b8e86..bc4cd0edb38 100644
--- a/FreeRTOS/Demo/RISC-V-Qemu-virt_GCC/Makefile
+++ b/FreeRTOS/Demo/RISC-V-Qemu-virt_GCC/Makefile
@@ -1,4 +1,6 @@
-CROSS = riscv64-unknown-elf-
+# Toolchain prefix can be over... | [
"FreeRTOS/Demo/RISC-V-Qemu-virt_GCC/Makefile"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,374 | issue_to_patch | Downgrade return-mismatch error to warning | Description
-----------
`portYIELD_FROM_ISR(x)` is defined as `return x` in the Windows port which causes compilation failures in the WIN32-MinGW demo when using GCC 14.
Test Steps
-----------
Successful build - https://github.com/aggarg/FreeRTOS/actions/runs/18273477974/job/52020218185.
Checklist:
---------... | bcef9d066a61c6d1e3a39acb8875dcc5d810443f | dd7b2a2001dba89ba04cd84e6336e83d871a8781 | diff --git a/FreeRTOS/Demo/WIN32-MingW/Makefile b/FreeRTOS/Demo/WIN32-MingW/Makefile
index dc3a1feb2bc..c58711d4d1e 100644
--- a/FreeRTOS/Demo/WIN32-MingW/Makefile
+++ b/FreeRTOS/Demo/WIN32-MingW/Makefile
@@ -3,7 +3,7 @@ BUILD_DIR := ./build
# Compiler - Note this expects you are using MinGW version of GCC
CC := gc... | [
"FreeRTOS/Demo/WIN32-MingW/Makefile"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,373 | issue_to_patch | Demo code: add static modifiers | Add "static" modifier to demo code to reduce global vars.
<!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Checklist:
----------
<!--- Go over all the following points, and put an `x` in all the boxes th... | 62195136d106d8ba42c5a432b9995ddf1ae0d729 | 2d201caf9f462687ed4084c8e2dfe375c9cadcd6 | diff --git a/FreeRTOS/Demo/Common/Full/dynamic.c b/FreeRTOS/Demo/Common/Full/dynamic.c
index ee295869d8d..5618cc25a86 100644
--- a/FreeRTOS/Demo/Common/Full/dynamic.c
+++ b/FreeRTOS/Demo/Common/Full/dynamic.c
@@ -168,7 +168,7 @@ static portBASE_TYPE xSuspendedQueueReceiveError = pdFALSE;
static portBASE_TYPE xPriority... | [
"FreeRTOS/Demo/Common/Full/dynamic.c",
"FreeRTOS/Demo/Common/Minimal/AbortDelay.c",
"FreeRTOS/Demo/Common/Minimal/EventGroupsDemo.c",
"FreeRTOS/Demo/Common/Minimal/IntSemTest.c",
"FreeRTOS/Demo/Common/Minimal/MessageBufferAMP.c",
"FreeRTOS/Demo/Common/Minimal/QPeek.c",
"FreeRTOS/Demo/Common/Minimal/Queu... | [] | true | ||
FreeRTOS/FreeRTOS | 1,370 | issue_to_patch | Demo/Common: fix divide by zero possibility and non-used return values | - In TimerDemo.c fix possible divide by zero in "xMaxBlockTimeUsedByTheseTests / xCycleFrequency".
- Move this code in TimerDemo.c into if-clause where it is actually used.
- In Minimal/StreamBufferDemo.c and Minimal/TaskNotify.c avoid unused return values.
<!--- Title -->
Description
-----------
<!--- Descri... | e933faf3ee5dc529edd06e53c59415a8a2e92cac | 2abe0e04f186223ef9e81bf119ba3b475b2b58ca | diff --git a/FreeRTOS/Demo/Common/Minimal/StreamBufferDemo.c b/FreeRTOS/Demo/Common/Minimal/StreamBufferDemo.c
index 17214f104ff..e940f2b60a4 100644
--- a/FreeRTOS/Demo/Common/Minimal/StreamBufferDemo.c
+++ b/FreeRTOS/Demo/Common/Minimal/StreamBufferDemo.c
@@ -560,7 +560,7 @@ static void prvSingleTaskTests( StreamBuffe... | [
"FreeRTOS/Demo/Common/Minimal/StreamBufferDemo.c",
"FreeRTOS/Demo/Common/Minimal/TaskNotify.c",
"FreeRTOS/Demo/Common/Minimal/TimerDemo.c"
] | [
{
"comment": "Would you be open to an assertion instead of this conditional? A cycle frequency of 0 doesn't make sense in the context of these tests.",
"path": "FreeRTOS/Demo/Common/Minimal/TimerDemo.c",
"hunk": "@@ -241,17 +241,22 @@ BaseType_t xAreTimerDemoTasksStillRunning( TickType_t xCycleFrequency... | true | ||
FreeRTOS/FreeRTOS | 1,364 | issue_to_patch | Various Qemu Cortex M3 ports now support picolibc | Allow various Qemu Cortex M3 ports to compile against picolibc. Also support "-flto" to work correctly.
Tested with picolibc in current Debian 13.
Just use "PICOLIBC=1 make" to switch over from default newlib.
<!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
Test Steps
--... | 51467d89e0756a9c8e41939135a9fb5b4f22d404 | d6b2450efbb83361750219d3838a96ada937abb2 | diff --git a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/Makefile b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/Makefile
index eb248d9a51a..93d73435e54 100644
--- a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/Makefile
+++ b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/Makefile
@@ -51,31 +... | [
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/Makefile",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main_networking.c",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/mps2_m3.ld",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/syscalls.c",
"FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC... | [
{
"comment": "This commented line can be removed?",
"path": "FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/Makefile",
"hunk": "@@ -51,31 +51,38 @@ SOURCE_FILES += ${FREERTOS_TCP}/source/portable/BufferManagement/BufferAllocatio\n SOURCE_FILES += ${FREERTOS_TCP}/source/portable/NetworkInterface/MPS... | true | ||
FreeRTOS/FreeRTOS | 1,368 | issue_to_patch | Fix build of & add CMake to LM3S Qemu Demo | <!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
I wanted to build the Qemu demo to play around with it, and also build it without Eclipse if possible (just personal preference). I currently haven't added the FreeRTOS+Trace bits to the CMake, as they aren't used by default.
Te... | 1aa47857a0b51c6304976491c711d75a731f8cb8 | 39be190e3f530a748f69fda6835680a6abd15696 | diff --git a/FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/.cproject b/FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/.cproject
index 11906a4e119..c5d9797242a 100644
--- a/FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/.cproject
+++ b/FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/.cproject
@@ -202,7 +202,7 @@
</tool>
</fileInfo>
... | [
"FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/.cproject",
"FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/CMakeLists.txt",
"FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/CMakePresets.json",
"FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/FreeRTOSConfig.h",
"FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/StartQEMU.bat",
"FreeRTOS/Demo/CORTEX_... | [
{
"comment": "What is the reason for this change?",
"path": "FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/FreeRTOSConfig.h",
"hunk": "@@ -95,7 +95,7 @@ FreeRTOS/Source/tasks.c for limitations. */\n #define configKERNEL_INTERRUPT_PRIORITY \t\t( 255 )\t/* All eight bits as QEMU doesn't model the priority bits. ... | true | ||
FreeRTOS/FreeRTOS | 1,368 | comment_to_fix | Fix build of & add CMake to LM3S Qemu Demo | What is the reason for this change? | 1aa47857a0b51c6304976491c711d75a731f8cb8 | 39be190e3f530a748f69fda6835680a6abd15696 | diff --git a/FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/FreeRTOSConfig.h b/FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/FreeRTOSConfig.h
index ab1923b6c60..3267b6de0a9 100644
--- a/FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/FreeRTOSConfig.h
+++ b/FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/FreeRTOSConfig.h
@@ -95,7 +95,7 @@ FreeRTOS/Sour... | [
"FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/FreeRTOSConfig.h"
] | [
{
"comment": "What is the reason for this change?",
"path": "FreeRTOS/Demo/CORTEX_LM3S6965_GCC_QEMU/FreeRTOSConfig.h",
"hunk": "@@ -95,7 +95,7 @@ FreeRTOS/Source/tasks.c for limitations. */\n #define configKERNEL_INTERRUPT_PRIORITY \t\t( 255 )\t/* All eight bits as QEMU doesn't model the priority bits. ... | true | ||
FreeRTOS/FreeRTOS | 1,366 | issue_to_patch | Update code to correct function pointer casting | <!--- Title -->
Description
-----------
Describe in #1365
Test Steps
-----------
Checklist:
----------
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- [x] I have tested ... | 5cf13754a5547789e4f9a0a14f130a06642cc3f2 | 61232c69d83d75d568d381958e90d994601d8f98 | diff --git a/.github/workflows/freertos_plus_demos.yml b/.github/workflows/freertos_plus_demos.yml
index 95e819b8e1b..14c66584508 100644
--- a/.github/workflows/freertos_plus_demos.yml
+++ b/.github/workflows/freertos_plus_demos.yml
@@ -20,7 +20,7 @@ env:
jobs:
winsim_cellular:
name: Windows Simulator Cellular... | [
".github/workflows/freertos_plus_demos.yml",
"FreeRTOS-Plus/Source/Application-Protocols/network_transport/mbedtls_pk_pkcs11.c",
"FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls_pkcs11.c"
] | [
{
"comment": "Why did you rename the variable. It won't compile. ",
"path": "FreeRTOS-Plus/Demo/Common/FreeRTOS_Plus_CLI_Demos/UARTCommandConsole.c",
"hunk": "@@ -106,7 +106,7 @@ void vUARTCommandConsoleStart( uint16_t usStackSize,\n \n static void prvUARTCommandConsoleTask( void * pvParameters )\n {\n-... | true | ||
FreeRTOS/FreeRTOS | 1,362 | issue_to_patch | Add artifact backup action | This PR updates the release workflow to use artifact backup action for storing release artifacts. | e0aa5eac7449995847f72b007cd2ca1505bfd89b | 25d66db47b6d3151e449be70fcfe4526782dddfb | diff --git a/.github/workflows/auto-release.yml b/.github/workflows/auto-release.yml
index 7f7ce165558..996ea1053dc 100644
--- a/.github/workflows/auto-release.yml
+++ b/.github/workflows/auto-release.yml
@@ -13,6 +13,8 @@ on:
jobs:
auto-release:
+ permissions:
+ id-token: write
name: Auto Release
... | [
".github/workflows/auto-release.yml"
] | [] | true | ||
FreeRTOS/FreeRTOS | 781 | issue_to_patch | Remove deprecated macro (ipconfigRAND32) references | <!--- Title -->
Description
-----------
ipconfigRAND32/ipconfigRAND64 macros were deprecated/removed from the FreeRTOS+TCp library. However, some demos still call the macros to get random numbers.
This PR removes the references of those macros from the demo sources.
Test Steps
-----------
<!-- Describe the... | 4629138a4208b7068e068b22ea69947aeed7a51e | eaf4a568a031c3bba632cc4f766fb6d939fa89a9 | diff --git a/FreeRTOS-Plus/Demo/AWS/Device_Defender_Windows_Simulator/Device_Defender_Demo/main.c b/FreeRTOS-Plus/Demo/AWS/Device_Defender_Windows_Simulator/Device_Defender_Demo/main.c
index d2c1272bc0d..c98b3316c2f 100644
--- a/FreeRTOS-Plus/Demo/AWS/Device_Defender_Windows_Simulator/Device_Defender_Demo/main.c
+++ b/... | [
"FreeRTOS-Plus/Demo/AWS/Device_Defender_Windows_Simulator/Device_Defender_Demo/main.c",
"FreeRTOS-Plus/Demo/AWS/Device_Shadow_Windows_Simulator/Common/main.c",
"FreeRTOS-Plus/Demo/AWS/Fleet_Provisioning_Windows_Simulator/Fleet_Provisioning_With_CSR_Demo/main.c",
"FreeRTOS-Plus/Demo/AWS/Jobs_Windows_Simulator/... | [] | true | ||
FreeRTOS/FreeRTOS | 801 | issue_to_patch | Update readme file with latest instructions to run CBMC proofs | <!--- Title -->
Description
-----------
The current instructions to run CBMC proofs using CMake are out of date. This PR updates the readme file to fix that. It also modifies the python based instructions.
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Related Issue
-----------
<!-- If ... | 7f049a4277ce36a967b84d5172b965197eb6fc9d | e40ce8cd5de6b6f5de7e5b1e1656030a930b04d5 | [
"FreeRTOS/Test/CBMC/README.md"
] | [
{
"comment": "```suggestion\r\nBuilding and running proofs\r\n```",
"path": "FreeRTOS/Test/CBMC/README.md",
"hunk": "@@ -16,53 +16,12 @@ how to run the proofs on your local clone of a:FR.\n Bulding and running proofs",
"resolving_sha": "e40ce8cd5de6b6f5de7e5b1e1656030a930b04d5",
"resolving_diff"... | diff --git a/FreeRTOS/Test/CBMC/README.md b/FreeRTOS/Test/CBMC/README.md
index 09d5e14810b..00baa4423a4 100644
--- a/FreeRTOS/Test/CBMC/README.md
+++ b/FreeRTOS/Test/CBMC/README.md
@@ -10,118 +10,73 @@ The proofs are checked using the
[C Bounded Model Checker](http://www.cprover.org/cbmc/), an open-source static
anal... | true | ||
FreeRTOS/FreeRTOS | 801 | comment_to_fix | Update readme file with latest instructions to run CBMC proofs | ```suggestion
Building and running proofs
``` | 7f049a4277ce36a967b84d5172b965197eb6fc9d | e40ce8cd5de6b6f5de7e5b1e1656030a930b04d5 | diff --git a/FreeRTOS/Test/CBMC/README.md b/FreeRTOS/Test/CBMC/README.md
index 09d5e14810b..00baa4423a4 100644
--- a/FreeRTOS/Test/CBMC/README.md
+++ b/FreeRTOS/Test/CBMC/README.md
@@ -10,118 +10,73 @@ The proofs are checked using the
[C Bounded Model Checker](http://www.cprover.org/cbmc/), an open-source static
anal... | [
"FreeRTOS/Test/CBMC/README.md"
] | [
{
"comment": "```suggestion\r\nBuilding and running proofs\r\n```",
"path": "FreeRTOS/Test/CBMC/README.md",
"hunk": "@@ -16,53 +16,12 @@ how to run the proofs on your local clone of a:FR.\n Bulding and running proofs",
"resolving_sha": "e40ce8cd5de6b6f5de7e5b1e1656030a930b04d5",
"resolving_diff"... | true | ||
FreeRTOS/FreeRTOS | 801 | comment_to_fix | Update readme file with latest instructions to run CBMC proofs | Is the heading still relevant? | 7f049a4277ce36a967b84d5172b965197eb6fc9d | e40ce8cd5de6b6f5de7e5b1e1656030a930b04d5 | diff --git a/FreeRTOS/Test/CBMC/README.md b/FreeRTOS/Test/CBMC/README.md
index 09d5e14810b..00baa4423a4 100644
--- a/FreeRTOS/Test/CBMC/README.md
+++ b/FreeRTOS/Test/CBMC/README.md
@@ -10,118 +10,73 @@ The proofs are checked using the
[C Bounded Model Checker](http://www.cprover.org/cbmc/), an open-source static
anal... | [
"FreeRTOS/Test/CBMC/README.md"
] | [
{
"comment": "Is the heading still relevant?",
"path": "FreeRTOS/Test/CBMC/README.md",
"hunk": "@@ -16,53 +16,12 @@ how to run the proofs on your local clone of a:FR.\n Bulding and running proofs\n --------------------------\n \n-For historical reasons, some of the proofs are built and run using CMake\n... | true | ||
FreeRTOS/FreeRTOS | 1,363 | issue_to_patch | fix optimization bug and cleanup | - Compiling Demo/Common/Minimal/TimerDemo.c with "gcc -flto" breaks the tests, so add "volatile" modifier to "ucOneShotTimerCounter" to fix this.
- In Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main_networking.c print the network configuration even more visible.
- In MessageBufferDemo.c and Demo/Posix_GCC/main_full.c fix ... | 722d17b13a99f18b0bb6e6af3761ef441b1ad2cc | 6c58320e1077997990bc8230521a6d9b298e0331 | diff --git a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main_networking.c b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main_networking.c
index 5e8835558fc..b1b5600118d 100644
--- a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main_networking.c
+++ b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qem... | [
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main_networking.c",
"FreeRTOS/Demo/Common/Minimal/MessageBufferDemo.c",
"FreeRTOS/Demo/Common/Minimal/TimerDemo.c",
"FreeRTOS/Demo/Posix_GCC/main_full.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,359 | issue_to_patch | POSIX Demo: clang warnings cleanup | Cleanup for clang compiler warnings:
- add "#include" to proper header files
- add "static" modifier to some vars
- if tracing is disabled, do not compile helper functions
- remove unused macro "mainFLASH_TASK_PRIORITY"
<!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
Te... | 9b5e277a6f44061b2b4956637eb05bc3a8848e8d | 141ebc6a8673617bdb33e52c632ffad200986f93 | diff --git a/FreeRTOS/Demo/Posix_GCC/console.c b/FreeRTOS/Demo/Posix_GCC/console.c
index fb3d869bb1c..31e96ead806 100644
--- a/FreeRTOS/Demo/Posix_GCC/console.c
+++ b/FreeRTOS/Demo/Posix_GCC/console.c
@@ -34,8 +34,10 @@
#include <FreeRTOS.h>
#include <semphr.h>
-SemaphoreHandle_t xStdioMutex;
-StaticSemaphore_t xSt... | [
"FreeRTOS/Demo/Posix_GCC/console.c",
"FreeRTOS/Demo/Posix_GCC/main.c",
"FreeRTOS/Demo/Posix_GCC/main_full.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,224 | issue_to_patch | Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/syscall.c: remove unused g_ulBase | <!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
In FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/syscall.c the extern definition of g_ulBase ist not used, so remove it. Also move _heap_bottom and _heap_top to where they are used in syscall.c.
Test Steps
-----------
<!-- Describ... | 6518cb153df20a72947f9b9110fa3d09feecc2d3 | 7589589ed127d4e0e00b7cd74fec80032671feef | diff --git a/FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/syscall.c b/FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/syscall.c
index d12a7dec8d4..4d0ef93aaab 100644
--- a/FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/syscall.c
+++ b/FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/syscall.c
@@ -45,11 +45,6 @@ typedef struct UART_t
#defi... | [
"FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/syscall.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,223 | issue_to_patch | Demo/CORTEX_MPS2_QEMU_IAR_GCC add path to IMAGE and remove mapfile | <!--- Title -->
Description
-----------
For Demo/CORTEX_MPS2_QEMU_IAR_GCC gcc Makefile:
- simplify IMAGE var to already include full path
- clean target also removes mapfile
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Checklist:
----------
<!--- Go over all the following points, ... | 8e54579341b286d415512d7990977dfd66755997 | eeb0d0a67356923718c0f456b4d3da9a1baa00a8 | diff --git a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/build/gcc/Makefile b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/build/gcc/Makefile
index c79414fe948..eec39ba2957 100644
--- a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/build/gcc/Makefile
+++ b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/build/gcc/Makefile
@@ -1,5 +1,5 @@
OUTPUT... | [
"FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/build/gcc/Makefile"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,343 | issue_to_patch | FreeRTOS_Plus_TCP_Echo_Qemu_mps2: fix compile with "gcc -flto" | FreeRTOS_Plus_TCP_Echo_Qemu_mps2: fix compile with "gcc -flto" by adding "__attribute__( used )" to isr_vector and _fstat().
<!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Checklist:
----------
<!--- G... | 0cbfaab47d612511686afc91ee0b9c02a604c6a0 | 751cd5a503b02ea24dccc0866b391d1e86543af9 | diff --git a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/startup.c b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/startup.c
index 92446a0d8cb..ad64b06f2f4 100644
--- a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/startup.c
+++ b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/startup.c
@@ -167... | [
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/startup.c",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/syscalls.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,344 | issue_to_patch | clean up warnings from "gcc -Wconversion" | clean up warnings from "gcc -Wconversion"
<!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Checklist:
----------
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<... | 0d2a5ae534bf773f1d75a1932af24ebe5f1369e5 | a7b12334593de402f44d379223a16363e7c60df7 | diff --git a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/TCPEchoClient_SingleTasks.c b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/TCPEchoClient_SingleTasks.c
index f4c5b809bfb..886c9d782a9 100644
--- a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/TCPEchoClient_SingleTasks.c
+++ b/FreeRTOS-Plus/D... | [
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/TCPEchoClient_SingleTasks.c",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main_networking.c",
"FreeRTOS/Demo/Common/Minimal/StreamBufferInterrupt.c",
"FreeRTOS/Demo/Common/Minimal/TaskNotifyArray.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,353 | issue_to_patch | Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC: support "gcc -flto" and fixes | * Fix compiler warning "gcc -Wmissing-prototypes" in startup.c.
* For "gcc -flto" fix duplicate labels in asm (startup.c) and mark some functions as "used" in startup.c and syscalls.c.
* Fix "gcc -Wredundant-decls" in main.c.
<!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
... | 9b50dc160bf68567ada6151bb24b8b4fad91cb81 | 45f05f348d2323375cade8c0518218916341f496 | diff --git a/FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/init/startup.c b/FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/init/startup.c
index b5b1a45cd08..2e0760b8108 100644
--- a/FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/init/startup.c
+++ b/FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/init/startup.c
@@ -66,7 +66,7 @@ void Rese... | [
"FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/init/startup.c",
"FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/main.c",
"FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/syscall.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,351 | issue_to_patch | Demo/Posix_GCC: fix compiler flags and compiler warnings | - Change CMakeLists.txt to set the C compiler flags instead of the C++ compiler flags.
- Change to compiler warnings from "gcc -Wconversion" in main_full.c.
Description
-----------
<!--- Describe your changes in detail. -->
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Checklist:
-----... | 9d9bbd0e6157c3a4147fe88b49fb20f454266e2f | 89fbfeeba1208cc6a56a768235f779b16b58c731 | diff --git a/FreeRTOS/Demo/Posix_GCC/CMakeLists.txt b/FreeRTOS/Demo/Posix_GCC/CMakeLists.txt
index 6131634b6c0..2dc147d172b 100644
--- a/FreeRTOS/Demo/Posix_GCC/CMakeLists.txt
+++ b/FreeRTOS/Demo/Posix_GCC/CMakeLists.txt
@@ -35,8 +35,8 @@ else()
set( CMAKE_BUILD_TYPE "debug" )
endif()
-set(CMAKE_CXX_FLAGS_RELEA... | [
"FreeRTOS/Demo/Posix_GCC/CMakeLists.txt",
"FreeRTOS/Demo/Posix_GCC/main_full.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,356 | issue_to_patch | Demo/Common/Minimal/StreamBufferInterrupt.c: more strict result checking | From looking at the code, I think this more strict error checking was intended in xIsInterruptStreamBufferDemoStillRunning(). If not, then the else part and var could be completely removed as dead code.
<!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
Test Steps
-----------... | c4da4ef1a7c469b55070d63a0cfd68255ff09e65 | 9dfc436d713e557fa43b1e6368f68471a6bfd22c | diff --git a/FreeRTOS/Demo/Common/Minimal/StreamBufferInterrupt.c b/FreeRTOS/Demo/Common/Minimal/StreamBufferInterrupt.c
index 760e2a81174..03e9e60be26 100644
--- a/FreeRTOS/Demo/Common/Minimal/StreamBufferInterrupt.c
+++ b/FreeRTOS/Demo/Common/Minimal/StreamBufferInterrupt.c
@@ -213,7 +213,7 @@ void vBasicStreamBuffer... | [
"FreeRTOS/Demo/Common/Minimal/StreamBufferInterrupt.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,352 | issue_to_patch | Demo/CORTEX_MPS2_QEMU_IAR_GCC: fix warnings | * fix compiler warning "gcc -Wmissing-prototypes" in startup_gcc.c
* fix compiler warning "gcc -Wredundant-decls" in main.c
* remove malloc()-implementation, not needed anymore for a long time
* hange stack size from 88 to 96 (is now a multiple of 16)
<!--- Title -->
Description
-----------
<!--- Describe yo... | 1fb5ee4dadd326fec79e25811aac36eb99e3dfd9 | 884070a871df133c35e124ac65dcf5d3dee27f0c | diff --git a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h
index 3c67e2edde2..b6c0130becd 100644
--- a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h
+++ b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h
@@ -46,8 +46,8 @@
#define conf... | [
"FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h",
"FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/build/gcc/startup_gcc.c",
"FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/main.c"
] | [
{
"comment": "This looks odd. How about changing it to 128?",
"path": "FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h",
"hunk": "@@ -46,7 +46,7 @@\n #define configUSE_TICK_HOOK 1\n #define configCPU_CLOCK_HZ ( ( unsigned long ) 25000000 )\n #define con... | true | ||
FreeRTOS/FreeRTOS | 1,352 | comment_to_fix | Demo/CORTEX_MPS2_QEMU_IAR_GCC: fix warnings | This looks odd. How about changing it to 128? | 1fb5ee4dadd326fec79e25811aac36eb99e3dfd9 | 884070a871df133c35e124ac65dcf5d3dee27f0c | diff --git a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h
index 3c67e2edde2..b6c0130becd 100644
--- a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h
+++ b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h
@@ -46,8 +46,8 @@
#define conf... | [
"FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h"
] | [
{
"comment": "This looks odd. How about changing it to 128?",
"path": "FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h",
"hunk": "@@ -46,7 +46,7 @@\n #define configUSE_TICK_HOOK 1\n #define configCPU_CLOCK_HZ ( ( unsigned long ) 25000000 )\n #define con... | true | ||
FreeRTOS/FreeRTOS | 1,352 | comment_to_fix | Demo/CORTEX_MPS2_QEMU_IAR_GCC: fix warnings | I think this implementation is here to catch accidental calls to malloc. What is the reason to remove this? | 1fb5ee4dadd326fec79e25811aac36eb99e3dfd9 | 884070a871df133c35e124ac65dcf5d3dee27f0c | diff --git a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/main.c b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/main.c
index 3798c9d5978..3dbfbd48db4 100644
--- a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/main.c
+++ b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/main.c
@@ -210,8 +210,6 @@ void vApplicationTickHook( void )
#if ( main... | [
"FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/main.c"
] | [
{
"comment": "I think this implementation is here to catch accidental calls to malloc. What is the reason to remove this?",
"path": "FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/main.c",
"hunk": "@@ -337,19 +335,3 @@ int __write( int iFile,\n \n return iStringLength;\n }\n-/*------------------------------... | true | ||
FreeRTOS/FreeRTOS | 1,357 | issue_to_patch | Fix 64b misalignment in RISC-V-spike-htif_GCC linker | <!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
This PR updates the alignment in RISC-V-spike-htif_GCC to handle 32/64b cases. Before, even if XLEN=64, sections could be 32b aligned which causes an error on systems that don't support misaligned load / store. With 64b alignment... | d1136b485752e9c0c50df64a2d887ef7f52b1989 | e683d67d921f2cfadd7e69532c273fb49487daf3 | diff --git a/FreeRTOS/Demo/RISC-V-spike-htif_GCC/fake_rom.lds b/FreeRTOS/Demo/RISC-V-spike-htif_GCC/fake_rom.lds
index ea9e9d0ad3f..01fb74e6043 100644
--- a/FreeRTOS/Demo/RISC-V-spike-htif_GCC/fake_rom.lds
+++ b/FreeRTOS/Demo/RISC-V-spike-htif_GCC/fake_rom.lds
@@ -31,7 +31,7 @@ SECTIONS
_etext = .;
} >rom AT>rom
... | [
"FreeRTOS/Demo/RISC-V-spike-htif_GCC/fake_rom.lds"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,355 | issue_to_patch | Update download locations to outside repository content | Description
-----------
This PR updates all download commands (such as curl) to download files outside the repository content.
Test Steps
-----------
NA
Checklist:
----------
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, d... | 67bc5a930dca40e1eca4a1ef9bc7778863496658 | e50b8e5aef571a6aa2340f44300a30d21fc87f57 | diff --git a/.github/workflows/freertos_demos.yml b/.github/workflows/freertos_demos.yml
index 36730d8a4bc..db136d7e003 100644
--- a/.github/workflows/freertos_demos.yml
+++ b/.github/workflows/freertos_demos.yml
@@ -406,20 +406,34 @@ jobs:
# ${{ env.stepName }}
echo -e "::group::${{ env.s... | [
".github/workflows/freertos_demos.yml"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,348 | issue_to_patch | Remove formatting bot workflow | 1ca9fd442f93b00ce00f0cae747ccaf15031710b | 2513eed55b49b6fb99c4d97147f9a27cf3a47771 | diff --git a/.github/workflows/formatting.yml b/.github/workflows/formatting.yml
deleted file mode 100644
index b2279145259..00000000000
--- a/.github/workflows/formatting.yml
+++ /dev/null
@@ -1,34 +0,0 @@
-name: Format Pull Request Files
-
-on:
- issue_comment:
- types: [created]
-
-env:
- bashPass: \033[32;1mPA... | [
".github/workflows/formatting.yml"
] | [] | true | |||
FreeRTOS/FreeRTOS | 1,225 | issue_to_patch | MPS2_AN385 improvements | Description
-----------
Sync various MPS2_AN385 CORTEX-M3 QEMU targets and improve their Makefiles and cleanup gcc support:
- FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2:
- Makefile - output image size after linking - move -nostartfiles from compiler to linker flags - modernize compiler warning flags - ... | 49bbe71166409d35bede694ef9f4e2055c84c977 | 261a573c917df1987df5f8ffa4d1c92fc4dacd18 | diff --git a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/Makefile b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/Makefile
index fdfe7c74103..e51a46f79da 100644
--- a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/Makefile
+++ b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/Makefile
@@ -1,4 +1,... | [
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/Makefile",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/TCPEchoClient_SingleTasks.c",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main_networking.c",
"FreeRTOS-Plus/Demo/FreeRT... | [
{
"comment": "Flags in both if and else branch look the same. You probably do not want `-g3` in the else branch? ",
"path": "FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/Makefile",
"hunk": "@@ -51,30 +52,33 @@ SOURCE_FILES += ${FREERTOS_TCP}/source/portable/BufferManagement/BufferAllocatio\n SOUR... | true | ||
FreeRTOS/FreeRTOS | 1,227 | issue_to_patch | Posix_GCC: update compiler options | <!--- Title -->
Description
-----------
1. Add to CFLAGS
- add `-O0` optimization for debug builds.
- add `-O3` optimization for release builds.
2. Update signal handler `handle_sigint()` to use
`_exit()` instead of `exit()`. Normal exit() is not allowed
within a signal handler.
Test Steps
--... | 995a030a92f8dccdf78ad0f4bbe3884cd15aa345 | ebad5ad9a027198e3cadfb1e970d7bf44d95fb07 | diff --git a/FreeRTOS/Demo/Posix_GCC/CMakeLists.txt b/FreeRTOS/Demo/Posix_GCC/CMakeLists.txt
index 199de7508b5..6131634b6c0 100644
--- a/FreeRTOS/Demo/Posix_GCC/CMakeLists.txt
+++ b/FreeRTOS/Demo/Posix_GCC/CMakeLists.txt
@@ -4,6 +4,8 @@ project( posix_demo )
add_compile_options( -D_WINDOWS_ )
+add_compile_options(... | [
"FreeRTOS/Demo/Posix_GCC/CMakeLists.txt",
"FreeRTOS/Demo/Posix_GCC/main.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,266 | issue_to_patch | Cortex M3 MPS2: fix alignment warning from assembler | Fix assembler alignment warnings for Cortex M3 MPS2:
Warning: section does not have enough alignment to ensure safe PC-relative loads
Description
-----------
<!--- Describe your changes in detail. -->
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Checklist:
----------
<!--- Go over al... | b0c9468ad617e7ee82645ddb9e7c640b8bc5fd6a | 3a17e4887e35f7754c5366ba901c19095913fec4 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 8c50e566902..b9efe893562 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -94,7 +94,7 @@ jobs:
if: success() && ( github.ref == 'refs/heads/main' || github.ref == 'refs/heads/release-candidate' )
env:
... | [
".github/workflows/ci.yml",
".github/workflows/kernel-unit-tests.yml",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/startup.c",
"FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/build/gcc/startup_gcc.c",
"FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/init/startup.c"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,268 | issue_to_patch | Cortex M3 MPS2: modernize assembler syntax and also add .ltorg | Cortex M3 MPS2: modernize assembler syntax and also add .ltorg
<!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
Test Steps
-----------
<!-- Describe the steps to reproduce. -->
Checklist:
----------
<!--- Go over all the following points, and put an `x` in all the box... | 2067506cc1b1374233183017690ab027c728d44f | 9a36e4afb5a766d1b0a584e9aaadc1b731654faf | diff --git a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/startup.c b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/startup.c
index fc9e2547880..f1495d6e6a7 100644
--- a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/startup.c
+++ b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/startup.c
@@ -111... | [
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/startup.c",
"FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/build/gcc/startup_gcc.c",
"FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/init/startup.c"
] | [
{
"comment": "Are you facing any problem because of which you are using these `ltorg`? If not, we should omit those and let the compiler create literal pools as needed. ",
"path": "FreeRTOS/Demo/CORTEX_MPU_M3_MPS2_QEMU_GCC/init/startup.c",
"hunk": "@@ -189,6 +192,7 @@ void Debug_Handler( void )\n ... | true | ||
FreeRTOS/FreeRTOS | 1,332 | issue_to_patch | Demo/CORTEX_MPS2_QEMU_IAR_GCC: increase min stack size from 80 to 88 | Description
-----------
Compiling this demo with picolibc 1.8.9 (as packaged with Debian trixie) results in a stack overflow. Increasing the minimal stack size from 80 to 88 bytes resolves this. (Debian trixie arm crosscompiler defaults to compile/link against picolibc and not newlib anymore.)
<!--- Describe you... | fda472bbd69f54bb230533ae7b0e36e3b0692b78 | d74794539b0eda99fb6a530251248a1503c7a69d | diff --git a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h
index e92499b5811..3c67e2edde2 100644
--- a/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h
+++ b/FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h
@@ -46,7 +46,7 @@
#define conf... | [
"FreeRTOS/Demo/CORTEX_MPS2_QEMU_IAR_GCC/FreeRTOSConfig.h"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,340 | issue_to_patch | Update network_transport files based on MbedTLSv3.6.3 | Description
-----------
For MBbedTLS-[v3.6.3](https://github.com/Mbed-TLS/mbedtls/releases/tag/mbedtls-3.6.3) , in TLS clients, if `mbedtls_ssl_set_hostname()` has not been called, `mbedtls_ssl_handshake()` now fails with
`MBEDTLS_ERR_SSL_CERTIFICATE_VERIFICATION_WITHOUT_HOSTNAME`. As a result, the `mbedtls_ssl_han... | 1325aaaad664d18222cfe88e4ec54b6f1ee45313 | 0a97f9956fccffe47abfa00ab60ac7651f527c03 | diff --git a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c
index a0798e9e444..b668ea11dce 100644
--- a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c
+++ b/FreeRTOS-Plu... | [
"FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c",
"FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls_pkcs11.c"
] | [
{
"comment": "Should we wrap this code in `#if ( MBEDTLS_VERSION_NUMBER >= 0x03060300 )`? \r\n\r\nhttps://github.com/Mbed-TLS/mbedtls/blob/22098d41c6620ce07cf8a0134d37302355e1e5ef/include/mbedtls/build_info.h#L36C40-L36C50",
"path": "FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbe... | true | ||
FreeRTOS/FreeRTOS | 1,340 | comment_to_fix | Update network_transport files based on MbedTLSv3.6.3 | Should we wrap this code in `#if ( MBEDTLS_VERSION_NUMBER >= 0x03060300 )`?
https://github.com/Mbed-TLS/mbedtls/blob/22098d41c6620ce07cf8a0134d37302355e1e5ef/include/mbedtls/build_info.h#L36C40-L36C50 | 1325aaaad664d18222cfe88e4ec54b6f1ee45313 | 0a97f9956fccffe47abfa00ab60ac7651f527c03 | diff --git a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c b/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c
index a0798e9e444..b668ea11dce 100644
--- a/FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c
+++ b/FreeRTOS-Plu... | [
"FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbedtls.c"
] | [
{
"comment": "Should we wrap this code in `#if ( MBEDTLS_VERSION_NUMBER >= 0x03060300 )`? \r\n\r\nhttps://github.com/Mbed-TLS/mbedtls/blob/22098d41c6620ce07cf8a0134d37302355e1e5ef/include/mbedtls/build_info.h#L36C40-L36C50",
"path": "FreeRTOS-Plus/Source/Application-Protocols/network_transport/transport_mbe... | true | ||
FreeRTOS/FreeRTOS | 1,336 | issue_to_patch | FreeRTOS_Plus_TCP_Echo_Qemu_mps2: cleanup | FreeRTOS_Plus_TCP_Echo_Qemu_mps2:
- Add missing include for header files.
- Remove redundant function declarations.
- Add "static" modifier if possible.
- No need to use "weak" for EthernetISR().
<!--- Title -->
Description
-----------
<!--- Describe your changes in detail. -->
Test Steps
-----------
<... | 91659446648a00f24b0b8af6327230658cc65c07 | 4f6e73fd43f9b09286b21063d618169f9464a227 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 384e926436d..fbd325cbe44 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -32,7 +32,7 @@ jobs:
git-secrets --scan
formatting:
- runs-on: ubuntu-20.04
+ runs-on: ubuntu-latest
steps:
- uses: ... | [
".github/workflows/ci.yml",
".github/workflows/core-checks.yml",
".github/workflows/formatting.yml",
".github/workflows/kernel-unit-tests.yml",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Posix/main_networking.c",
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/TCPEchoClient_SingleTasks.c",
"FreeRTO... | [
{
"comment": "Why was this function declaration removed ? ",
"path": "FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c",
"hunk": "@@ -28,14 +28,14 @@\n #include <task.h>\n \n #include <FreeRTOSConfig.h>\n+#include <FreeRTOSIPConfig.h>\n \n #include <string.h>\n #include <stdarg.h>\n #include <... | diff --git a/FreeRTOS-Plus/Test/FreeRTOS-Cellular-Interface/Integration/main.c b/FreeRTOS-Plus/Test/FreeRTOS-Cellular-Interface/Integration/main.c
index f86723c1433..355a63dfa7a 100644
--- a/FreeRTOS-Plus/Test/FreeRTOS-Cellular-Interface/Integration/main.c
+++ b/FreeRTOS-Plus/Test/FreeRTOS-Cellular-Interface/Integratio... | true | |
FreeRTOS/FreeRTOS | 1,336 | comment_to_fix | FreeRTOS_Plus_TCP_Echo_Qemu_mps2: cleanup | Why was this function declaration removed ? | 91659446648a00f24b0b8af6327230658cc65c07 | 4f6e73fd43f9b09286b21063d618169f9464a227 | diff --git a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c
index ec5f5650c85..53a05d6a2df 100644
--- a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c
+++ b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c
@@ -28,15 +28,16 @@... | [
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c"
] | [
{
"comment": "Why was this function declaration removed ? ",
"path": "FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c",
"hunk": "@@ -28,14 +28,14 @@\n #include <task.h>\n \n #include <FreeRTOSConfig.h>\n+#include <FreeRTOSIPConfig.h>\n \n #include <string.h>\n #include <stdarg.h>\n #include <... | true | ||
FreeRTOS/FreeRTOS | 1,336 | comment_to_fix | FreeRTOS_Plus_TCP_Echo_Qemu_mps2: cleanup | Is there any compilation warning , due to which this header file needed to be included ? | 91659446648a00f24b0b8af6327230658cc65c07 | 4f6e73fd43f9b09286b21063d618169f9464a227 | diff --git a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c
index ec5f5650c85..53a05d6a2df 100644
--- a/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c
+++ b/FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c
@@ -28,15 +28,16 @@... | [
"FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c"
] | [
{
"comment": "Is there any compilation warning , due to which this header file needed to be included ?",
"path": "FreeRTOS-Plus/Demo/FreeRTOS_Plus_TCP_Echo_Qemu_mps2/main.c",
"hunk": "@@ -28,14 +28,14 @@\n #include <task.h>\n \n #include <FreeRTOSConfig.h>\n+#include <FreeRTOSIPConfig.h>",
"resolvin... | true | ||
FreeRTOS/FreeRTOS | 1,308 | issue_to_patch | Update readme for v202411.00 release | Description
-----------
This PR updates README.md for P3 release v202411.00 .
Test Steps
-----------
NA
Checklist:
----------
<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
- ... | 6aa244f6fefd50efdd04b8e9ff773b30c23e68e9 | 2ff0520211f2c2755bdaeeac865e2190d893b870 | diff --git a/README.md b/README.md
index 9a78012dbba..737d6ccb67e 100644
--- a/README.md
+++ b/README.md
@@ -1,3 +1,5 @@
+The [FreeRTOS 202411.00](https://github.com/FreeRTOS/FreeRTOS/tree/202411.00) release updates FreeRTOS Kernel, FreeRTOS+TCP, coreMQTT, corePKCS11, coreHTTP, coreJSON, AWS IoT Over-the-air-Updates (O... | [
"README.md"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,335 | issue_to_patch | Align stack size to 16-byte boundary by changing `__stack_size` from … | …350 to 352
# Align stack size to 16-byte boundary by changing __stack_size from 350 to 352
## Description
-----------
This pull request updates the `__stack_size` definition in the linker flags, changing its value from 350 to 352. This change ensures that the stack size is a multiple of 16, aligning the stac... | 2625a12c04a2ed0b88d63f2f3114d1de1593af0a | 34db152dfff8c7e3862eeea920659af6970fecc3 | diff --git a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile
index d8be9f7e4e7..6a2073e7efa 100644
--- a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile
+++ b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile
@@ -45,7 +45,7 @@ e... | [
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile"
] | [] | true | ||
FreeRTOS/FreeRTOS | 1,334 | issue_to_patch | Update demo RISCV qemu demo to check the vector context save | Improve the `RISC-V_RV32_QEMU_VIRT_GCC`'s RegTest so it checks the vector registers
Description
-----------
* Include the FPU test only when `configENABLE_FPU` is `1`
* Update the used ISA to include the vector extensions
* Define `configENABLE_VPU` is `1` so the vector context save is enabled
* Update the `Reg... | 881305dcb813c93bd71e0ec2d3374cc741dec2bd | 4694a84ce1541975c57a441799dca68d10f53b26 | diff --git a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md
index 045d60eaba3..fd9fe5abead 100644
--- a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md
+++ b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md
@@ -63,7 +63,7 @@ For the RVA23 build:
```
$ qemu-sys... | [
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md",
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile",
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S",
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/start.S",
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/main_full.c",
"FreeRTOS/So... | [
{
"comment": "What are the meaning of the `v=true`, `rvv_ta_all_1s=true`, and `rvv_ma_all_1s=true` flags?",
"path": "FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md",
"hunk": "@@ -63,7 +63,7 @@ For the RVA23 build:\n ```\n $ qemu-system-riscv64 -nographic -machine virt -net none -chardev stdio,id=con,... | true | ||
FreeRTOS/FreeRTOS | 1,334 | comment_to_fix | Update demo RISCV qemu demo to check the vector context save | What are the meaning of the `v=true`, `rvv_ta_all_1s=true`, and `rvv_ma_all_1s=true` flags? | 881305dcb813c93bd71e0ec2d3374cc741dec2bd | 4694a84ce1541975c57a441799dca68d10f53b26 | diff --git a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md
index 045d60eaba3..fd9fe5abead 100644
--- a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md
+++ b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md
@@ -63,7 +63,7 @@ For the RVA23 build:
```
$ qemu-sys... | [
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md"
] | [
{
"comment": "What are the meaning of the `v=true`, `rvv_ta_all_1s=true`, and `rvv_ma_all_1s=true` flags?",
"path": "FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md",
"hunk": "@@ -63,7 +63,7 @@ For the RVA23 build:\n ```\n $ qemu-system-riscv64 -nographic -machine virt -net none -chardev stdio,id=con,... | true | ||
FreeRTOS/FreeRTOS | 1,334 | comment_to_fix | Update demo RISCV qemu demo to check the vector context save | Just for my own knowledge - does the order of the extensions matter here? I see you placed `zvfhmin_zvbb_zvkt` before `zihintntl_zawrs`. | 881305dcb813c93bd71e0ec2d3374cc741dec2bd | 4694a84ce1541975c57a441799dca68d10f53b26 | diff --git a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile
index d23da92603c..d8be9f7e4e7 100644
--- a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile
+++ b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile
@@ -14,11 +14,10 @@... | [
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile"
] | [
{
"comment": "Just for my own knowledge - does the order of the extensions matter here? I see you placed `zvfhmin_zvbb_zvkt` before `zihintntl_zawrs`.",
"path": "FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile",
"hunk": "@@ -14,11 +14,10 @@ GCC_VERSION = $(shell $(CC) --version | grep ^$(CC) ... | true | ||
FreeRTOS/FreeRTOS | 1,334 | comment_to_fix | Update demo RISCV qemu demo to check the vector context save | Double checking - we don't want to modify the `vcsr` register here? Makes sense to met to leave it as is. I can't think of a case where FreeRTOS tasks would want to change their rounding mode. | 881305dcb813c93bd71e0ec2d3374cc741dec2bd | 4694a84ce1541975c57a441799dca68d10f53b26 | diff --git a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/start.S b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/start.S
index 61deae8d9f8..e415f1ef236 100644
--- a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/start.S
+++ b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/start.S
@@ -74,6 +74,11 @@ _sta... | [
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/start.S"
] | [
{
"comment": "Double checking - we don't want to modify the `vcsr` register here? Makes sense to met to leave it as is. I can't think of a case where FreeRTOS tasks would want to change their rounding mode.",
"path": "FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/start.S",
"hunk": "@@ -74,6 +74,11 @... | true | ||
FreeRTOS/FreeRTOS | 1,334 | comment_to_fix | Update demo RISCV qemu demo to check the vector context save | How did you get an increase in 180 words? I must be missing something - I'm only considering the additional space required by the vector registers (32) which are 256 bits wide (so either 4 (64-bit words) words wide or 8 words wide (32-bit words). | 881305dcb813c93bd71e0ec2d3374cc741dec2bd | 4694a84ce1541975c57a441799dca68d10f53b26 | diff --git a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/main_full.c b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/main_full.c
index f66506328e9..90bdbb25e7b 100644
--- a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/main_full.c
+++ b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/main_full.c
@@ -108,7 +108,11 @@
* constant is different ... | [
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/main_full.c"
] | [
{
"comment": "How did you get an increase in 180 words? I must be missing something - I'm only considering the additional space required by the vector registers (32) which are 256 bits wide (so either 4 (64-bit words) words wide or 8 words wide (32-bit words). ",
"path": "FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT... | true | ||
FreeRTOS/FreeRTOS | 1,334 | comment_to_fix | Update demo RISCV qemu demo to check the vector context save | 1. I'm not sure I understand the comment formatting. For example `// v1 = [-15, -14, -13, -12...]`. Is the idea that the vector is storing -15 through -8 as 8 bit values in the register?
2. Why is v31 =[ 15, 16, 17, 18...]? Aren't you adding the immediate `0` to `v0` which was earlier set up to be [0, 1, 2, 3,...]? | 881305dcb813c93bd71e0ec2d3374cc741dec2bd | 4694a84ce1541975c57a441799dca68d10f53b26 | diff --git a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S
index a740163b07c..5c22ca5afab 100644
--- a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S
+++ b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S
@@ -69,7 +69,7 ... | [
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S"
] | [
{
"comment": "1. I'm not sure I understand the comment formatting. For example `// v1 = [-15, -14, -13, -12...]`. Is the idea that the vector is storing -15 through -8 as 8 bit values in the register?\r\n\r\n2. Why is v31 =[ 15, 16, 17, 18...]? Aren't you adding the immediate `0` to `v0` which was earlier set u... | true | ||
FreeRTOS/FreeRTOS | 1,334 | comment_to_fix | Update demo RISCV qemu demo to check the vector context save | `vl` and `vtype` are set at the start of the task. Given that the context save and restore code saves and restores these registers correctly, do we need to reprogram them here? | 881305dcb813c93bd71e0ec2d3374cc741dec2bd | 4694a84ce1541975c57a441799dca68d10f53b26 | diff --git a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S
index a740163b07c..5c22ca5afab 100644
--- a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S
+++ b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S
@@ -69,7 +69,7 ... | [
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S"
] | [
{
"comment": "`vl` and `vtype` are set at the start of the task. Given that the context save and restore code saves and restores these registers correctly, do we need to reprogram them here?",
"path": "FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S",
"hunk": "@@ -319,6 +357,228 @@ reg1_loop... | true | ||
FreeRTOS/FreeRTOS | 1,329 | issue_to_patch | Update RV32 qemu Demo to support RVA23 | Update RV32 qemu Demo to support RVA23
Description
-----------
This PR modifies the already existing `RISC-V_RV32_QEMU_VIRT_GCC` demo, so at compilation time it can be configured as an RV32 system or (what will be) a [RISC-V RVA23](https://github.com/riscv/riscv-profiles/blob/main/src/rva23-profile.adoc) QEMU syst... | 2abeb3e52f68eb0da051fa6f7275401da4d60e5e | ad55901d3c6a89dcf4351ce2ad090672dda23732 | diff --git a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/FreeRTOSConfig.h b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/FreeRTOSConfig.h
index 21a2938648c..5b2201ddc75 100644
--- a/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/FreeRTOSConfig.h
+++ b/FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/FreeRTOSConfig.h
@@ -51,8 +51,13 @@
#define... | [
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/FreeRTOSConfig.h",
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md",
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/Makefile",
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/RegTest.S",
"FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/build/gcc/fake_rom.ld",
"Fr... | [
{
"comment": "```suggestion\r\n1. GNU RISC-V toolchains. Tested on:\r\n```",
"path": "FreeRTOS/Demo/RISC-V_RV32_QEMU_VIRT_GCC/Readme.md",
"hunk": "@@ -2,11 +2,14 @@\n \n ## Requirements\n \n-1. GNU RISC-V toolchains (tested on pre-built Sifive GNU Embedded Toolchain — v2020.12.8)\n- - https://www.sifiv... | true | ||
FreeRTOS/FreeRTOS | 1,331 | issue_to_patch | Update the coreMQTT submodule pointer | Description
-----------
This PR:
- Updates the submodule pointer of the coreMQTT library
- Updates the submodule pointer of the corePKCS11 library
- Makes some updates to the demos for running on the new versions of these libraries
Test Steps
-----------
- Demos are building and running succesfully.
Checkl... | 8eba8b5c9f21269acb21afa6134b0d132aba4b10 | 4e6f7fe8bb22459c304843ec67b0374fcbf78453 | diff --git a/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c b/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c
index e284a5df028..9458b3dabc0 100644
--- a/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c
+++ b/FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs1... | [
"FreeRTOS-Plus/Demo/AWS/Mqtt_Demo_Helpers/mqtt_pkcs11_demo_helpers.c",
"FreeRTOS-Plus/Demo/AWS/Ota_Windows_Simulator/README.md",
"FreeRTOS-Plus/Source/Application-Protocols/coreMQTT",
"FreeRTOS-Plus/Source/Application-Protocols/coreMQTT-Agent",
"FreeRTOS-Plus/Source/corePKCS11",
"manifest.yml"
] | [] | true | ||
FuelLabs/fuels-rs | 1,710 | issue_to_patch | chore(version): bump to v0.77.0 | # Checklist
- [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **changes** are **documented** (or not applicable)
- [x] I **reviewed** the **entire PR** myself (preferably, on GH UI)
- [x] I **described** all **Breaking Changes** (or there's none) | a12583268412527540027ab7e4f14ed9e09d7178 | 8615852d635f2b6cc0abd5e100eeea656b8d98df | diff --git a/Cargo.toml b/Cargo.toml
index bafdc4e8c..97e9fe2b3 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -39,7 +39,7 @@ readme = "README.md"
license = "Apache-2.0"
repository = "https://github.com/FuelLabs/fuels-rs"
rust-version = "1.93.0"
-version = "0.76.0"
+version = "0.77.0"
[workspace.dependencies]
Infle... | [
"Cargo.toml",
"docs/src/connecting/short-lived.md"
] | [] | true | ||
FuelLabs/fuels-rs | 1,702 | issue_to_patch | Add multi-URL client connect method. | <!--
List the issues this PR closes (if any) in a bullet list format, e.g.:
- Closes #ABCD
- Closes #EFGH
-->
# Summary
Add multi-URL client connect method.
# Breaking Changes
<!--
If the PR has breaking changes, please detail them in this section
and remove this comment.
Remove this section if the... | b4ecd0c0418477a106dced036c24701aaed27d98 | 7c7c74d5d1548a06e602cd21e3dbc1fa66aaf54d | diff --git a/Cargo.toml b/Cargo.toml
index e3d4081a5..bafdc4e8c 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -56,7 +56,6 @@ fuel-abi-types = "0.15.3"
futures = "0.3.29"
hex = { version = "0.4.3", default-features = false }
itertools = "0.12.0"
-portpicker = "0.1.1"
pretty_assertions = { version = "1.4", default-feat... | [
"Cargo.toml",
"e2e/tests/contracts.rs",
"packages/fuels-accounts/src/provider.rs",
"packages/fuels-accounts/src/provider/retryable_client.rs",
"packages/fuels-programs/src/calls/call_handler.rs",
"packages/fuels-test-helpers/Cargo.toml",
"packages/fuels-test-helpers/src/fuel_bin_service.rs",
"packages... | [
{
"comment": "### Git dependencies block crate publishing to crates.io\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nAll `fuel-core-*` dependencies were switched from versioned crates (`0.47.1`) to git dependencies pinned to a specific commit. Git dependencies are not allowed when publishing to crates.i... | diff --git a/e2e/tests/contracts.rs b/e2e/tests/contracts.rs
index 39bd6d61d..8cb07c685 100644
--- a/e2e/tests/contracts.rs
+++ b/e2e/tests/contracts.rs
@@ -224,6 +224,44 @@ async fn test_multi_call_beginner() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn test_multi_call_simulate_vec() -> Result<()> {
+ ... | true | |
FuelLabs/fuels-rs | 1,702 | comment_to_fix | Add multi-URL client connect method. | ### Git dependencies block crate publishing to crates.io
**Medium Severity**
<!-- DESCRIPTION START -->
All `fuel-core-*` dependencies were switched from versioned crates (`0.47.1`) to git dependencies pinned to a specific commit. Git dependencies are not allowed when publishing to crates.io. This looks like a tempor... | b4ecd0c0418477a106dced036c24701aaed27d98 | 7c7c74d5d1548a06e602cd21e3dbc1fa66aaf54d | diff --git a/Cargo.toml b/Cargo.toml
index e3d4081a5..bafdc4e8c 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -56,7 +56,6 @@ fuel-abi-types = "0.15.3"
futures = "0.3.29"
hex = { version = "0.4.3", default-features = false }
itertools = "0.12.0"
-portpicker = "0.1.1"
pretty_assertions = { version = "1.4", default-feat... | [
"Cargo.toml"
] | [
{
"comment": "### Git dependencies block crate publishing to crates.io\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nAll `fuel-core-*` dependencies were switched from versioned crates (`0.47.1`) to git dependencies pinned to a specific commit. Git dependencies are not allowed when publishing to crates.i... | true | ||
FuelLabs/fuels-rs | 1,702 | comment_to_fix | Add multi-URL client connect method. | ### Duplicated simulation logic between `simulate` and `simulate_vec`
**Low Severity**
<!-- DESCRIPTION START -->
The `simulate_vec` method is a near-exact copy of `simulate` — the entire transaction-building and dry-run execution block is duplicated, differing only in the final response-parsing call (`get_response_v... | b4ecd0c0418477a106dced036c24701aaed27d98 | 7c7c74d5d1548a06e602cd21e3dbc1fa66aaf54d | diff --git a/packages/fuels-programs/src/calls/call_handler.rs b/packages/fuels-programs/src/calls/call_handler.rs
index 96f696587..109b79f75 100644
--- a/packages/fuels-programs/src/calls/call_handler.rs
+++ b/packages/fuels-programs/src/calls/call_handler.rs
@@ -528,6 +528,34 @@ where
self.get_response(tx_st... | [
"packages/fuels-programs/src/calls/call_handler.rs"
] | [
{
"comment": "### Duplicated simulation logic between `simulate` and `simulate_vec`\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `simulate_vec` method is a near-exact copy of `simulate` — the entire transaction-building and dry-run execution block is duplicated, differing only in the final response-pa... | true | ||
FuelLabs/fuels-rs | 1,702 | comment_to_fix | Add multi-URL client connect method. | ### `url()` now returns normalized URL, breaking consumers
**High Severity**
<!-- DESCRIPTION START -->
The `url()` method previously returned the raw user-provided URL string (stored in the now-removed `url` field). It now delegates to `self.client.get_default_url().as_str()`, which returns a normalized URL with `/v... | b4ecd0c0418477a106dced036c24701aaed27d98 | 7c7c74d5d1548a06e602cd21e3dbc1fa66aaf54d | diff --git a/packages/fuels-accounts/src/provider/retryable_client.rs b/packages/fuels-accounts/src/provider/retryable_client.rs
index 55531b6fe..5a58d96a3 100644
--- a/packages/fuels-accounts/src/provider/retryable_client.rs
+++ b/packages/fuels-accounts/src/provider/retryable_client.rs
@@ -43,7 +43,6 @@ impl From<Req... | [
"packages/fuels-accounts/src/provider/retryable_client.rs"
] | [
{
"comment": "### `url()` now returns normalized URL, breaking consumers\n\n**High Severity**\n\n<!-- DESCRIPTION START -->\nThe `url()` method previously returned the raw user-provided URL string (stored in the now-removed `url` field). It now delegates to `self.client.get_default_url().as_str()`, which return... | true | ||
FuelLabs/fuels-rs | 1,702 | comment_to_fix | Add multi-URL client connect method. | nit: I don't think we need to explain rust syntax in the comments
```suggestion
``` | b4ecd0c0418477a106dced036c24701aaed27d98 | 7c7c74d5d1548a06e602cd21e3dbc1fa66aaf54d | diff --git a/packages/fuels-programs/src/calls/call_handler.rs b/packages/fuels-programs/src/calls/call_handler.rs
index 96f696587..109b79f75 100644
--- a/packages/fuels-programs/src/calls/call_handler.rs
+++ b/packages/fuels-programs/src/calls/call_handler.rs
@@ -528,6 +528,34 @@ where
self.get_response(tx_st... | [
"packages/fuels-programs/src/calls/call_handler.rs"
] | [
{
"comment": "nit: I don't think we need to explain rust syntax in the comments\n```suggestion\n```",
"path": "packages/fuels-programs/src/calls/call_handler.rs",
"hunk": "@@ -528,6 +528,35 @@ where\n self.get_response(tx_status)\n }\n \n+ /// Call contract methods on the node, in a simul... | true | ||
FuelLabs/fuels-rs | 1,702 | comment_to_fix | Add multi-URL client connect method. | ```suggestion
```
Same here. | b4ecd0c0418477a106dced036c24701aaed27d98 | 7c7c74d5d1548a06e602cd21e3dbc1fa66aaf54d | diff --git a/packages/fuels-programs/src/calls/call_handler.rs b/packages/fuels-programs/src/calls/call_handler.rs
index 96f696587..109b79f75 100644
--- a/packages/fuels-programs/src/calls/call_handler.rs
+++ b/packages/fuels-programs/src/calls/call_handler.rs
@@ -528,6 +528,34 @@ where
self.get_response(tx_st... | [
"packages/fuels-programs/src/calls/call_handler.rs"
] | [
{
"comment": "```suggestion\n```\n\nSame here.",
"path": "packages/fuels-programs/src/calls/call_handler.rs",
"hunk": "@@ -562,6 +591,32 @@ where\n })\n }\n \n+ /// Create a [`CallResponse`] from `TxStatus` returning a Vec of values.\n+ /// All calls must return the same type `T`.",
... | true | ||
FuelLabs/fuels-rs | 1,702 | comment_to_fix | Add multi-URL client connect method. | ### Piped stdout never read risks process deadlock
**Medium Severity**
<!-- DESCRIPTION START -->
The child process is spawned with `stdout(Stdio::piped())`, but `child.stdout` is never taken or read anywhere — only `child.stderr` is consumed. If `fuel-core` writes enough data to stdout to fill the OS pipe buffer (ty... | b4ecd0c0418477a106dced036c24701aaed27d98 | 7c7c74d5d1548a06e602cd21e3dbc1fa66aaf54d | diff --git a/packages/fuels-test-helpers/src/fuel_bin_service.rs b/packages/fuels-test-helpers/src/fuel_bin_service.rs
index cb6f1b109..8e9c5767b 100644
--- a/packages/fuels-test-helpers/src/fuel_bin_service.rs
+++ b/packages/fuels-test-helpers/src/fuel_bin_service.rs
@@ -1,17 +1,18 @@
-use std::{
- net::{IpAddr, So... | [
"packages/fuels-test-helpers/src/fuel_bin_service.rs"
] | [
{
"comment": "### Piped stdout never read risks process deadlock\n\n**Medium Severity**\n\n<!-- DESCRIPTION START -->\nThe child process is spawned with `stdout(Stdio::piped())`, but `child.stdout` is never taken or read anywhere — only `child.stderr` is consumed. If `fuel-core` writes enough data to stdout to ... | true | ||
FuelLabs/fuels-rs | 1,707 | issue_to_patch | chore(deps): Bump `fuel-vm` to 0.66.2 and `fuel-core` to 0.48.0 | # Summary
This PR:
- bumps `fuel-vm` to v0.66.2
- bumps `fuel-core` to v0.48.0
- replaces Buildjet CI runners with Warp
- updates `checkout` CI action from v3 to v6
- pins `localstack/localstack` docker image to tag 4.14.0 to circumvent [LocalStack licensing change](https://blog.localstack.cloud/2026-upcoming-p... | 137fa28aa6305cf8da5a11501c586742546f6e8c | 0291ec39e7f520ffe0b36bf022a5f04266d258ac | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 3b106edcc3..c5bae3995e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ env:
CARGO_TERM_COLOR: always
DASEL_VERSION: https://github.com/TomWright/dasel/releases/download/v2.3.6/dasel_linux_amd64
RUSTFLA... | [
".github/workflows/ci.yml",
"Cargo.toml",
"e2e/src/aws_kms.rs",
"e2e/tests/contracts.rs",
"examples/contracts/src/lib.rs",
"packages/fuels-accounts/src/provider/supported_fuel_core_version.rs",
"packages/fuels-accounts/src/schema/schema.sdl"
] | [
{
"comment": "### Invalid `path` input passed to `Swatinem/rust-cache`\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `path` input is a leftover from `buildjet/cache@v3` (which wraps `actions/cache`) and is not a valid input for `Swatinem/rust-cache@v2`. GitHub Actions silently ignores unknown inputs, s... | diff --git a/e2e/tests/contracts.rs b/e2e/tests/contracts.rs
index e01f3a75c5..39bd6d61d0 100644
--- a/e2e/tests/contracts.rs
+++ b/e2e/tests/contracts.rs
@@ -294,11 +294,11 @@ async fn test_contract_call_fee_estimation() -> Result<()> {
),
);
- let gas_limit = 800;
+ let gas_limit = 651;
let... | true | |
FuelLabs/fuels-rs | 1,707 | comment_to_fix | chore(deps): Bump `fuel-vm` to 0.66.2 and `fuel-core` to 0.48.0 | ### Invalid `path` input passed to `Swatinem/rust-cache`
**Low Severity**
<!-- DESCRIPTION START -->
The `path` input is a leftover from `buildjet/cache@v3` (which wraps `actions/cache`) and is not a valid input for `Swatinem/rust-cache@v2`. GitHub Actions silently ignores unknown inputs, so this configuration has no... | 137fa28aa6305cf8da5a11501c586742546f6e8c | 0291ec39e7f520ffe0b36bf022a5f04266d258ac | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 3b106edcc3..c5bae3995e 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ env:
CARGO_TERM_COLOR: always
DASEL_VERSION: https://github.com/TomWright/dasel/releases/download/v2.3.6/dasel_linux_amd64
RUSTFLA... | [
".github/workflows/ci.yml"
] | [
{
"comment": "### Invalid `path` input passed to `Swatinem/rust-cache`\n\n**Low Severity**\n\n<!-- DESCRIPTION START -->\nThe `path` input is a leftover from `buildjet/cache@v3` (which wraps `actions/cache`) and is not a valid input for `Swatinem/rust-cache@v2`. GitHub Actions silently ignores unknown inputs, s... | true | ||
FuelLabs/fuels-rs | 1,605 | issue_to_patch | chore: remove `script_needs_custom_decoder_logging` sway project | Went through my opened issues and saw the TODO and removed the additional sway project.
# Checklist
- [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **changes** are **documented** (or not applicable)
- [x] I **reviewed** the **entire PR** myself (preferably, on GH UI)
- [x] I **... | 8ac1ce9923c80ceb61d5532fd5dc503c40b395a0 | e9f3c7f36f298dbb78d8584955c044192878e2bb | diff --git a/e2e/Forc.toml b/e2e/Forc.toml
index 365dc9e567..4a4322c8ae 100644
--- a/e2e/Forc.toml
+++ b/e2e/Forc.toml
@@ -35,7 +35,6 @@ members = [
'sway/logs/contract_with_contract_logs',
'sway/logs/script_heap_logs',
'sway/logs/script_logs',
- 'sway/logs/script_needs_custom_decoder_logging',
'sway/logs/... | [
"e2e/Forc.toml",
"e2e/sway/logs/script_needs_custom_decoder_logging/Forc.toml",
"e2e/sway/logs/script_needs_custom_decoder_logging/src/main.sw",
"e2e/sway/scripts/script_needs_custom_decoder/src/main.sw",
"e2e/tests/logs.rs",
"e2e/tests/scripts.rs"
] | [] | diff --git a/e2e/tests/logs.rs b/e2e/tests/logs.rs
index 676b674fb0..e995abb5c4 100644
--- a/e2e/tests/logs.rs
+++ b/e2e/tests/logs.rs
@@ -1698,7 +1698,7 @@ async fn can_configure_decoder_for_script_log_decoding() -> Result<()> {
Wallets("wallet"),
Abigen(Script(
name = "LogScript",
- ... | true | |
FuelLabs/fuels-rs | 1,706 | issue_to_patch | chore: bump MSRV to 1.93 | Bumps MSRV to 1.93.
Pins `cynic` to `<3.13.0` to avoid the `reqwest` 0.12/0.13 version conflict introduced by `cynic 3.13.1` (which switched its `http-reqwest` feature to `reqwest 0.13`, incompatible with `fuel-core-client`'s `reqwest 0.12` dependency).
Verified with `cargo check --workspace` on Rust 1.93. | e13e5fc73bcc895eed15882dfe2fd526a9823d97 | aef07159b841f631b222097945d56dc721b6f09d | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index c8f576f81..3b106edcc 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -19,7 +19,7 @@ env:
FUEL_CORE_VERSION: 0.47.1
FUEL_CORE_PATCH_BRANCH: ""
FUEL_CORE_PATCH_REVISION: ""
- RUST_VERSION: 1.90.0
+ RUST_VERSION: 1.93... | [
".github/workflows/ci.yml",
"Cargo.toml",
"packages/fuels-accounts/src/provider.rs"
] | [] | true | ||
FuelLabs/fuels-rs | 1,704 | issue_to_patch | feat(multicall): enable multicall response as Vec if all return types are the same | b42bcdac6d236c44572a47bd86c0ef024fdaeab8 | 42d7afdf1efb396b2da8dd68b9a43690de90d61f | diff --git a/packages/fuels-accounts/src/provider/retryable_client.rs b/packages/fuels-accounts/src/provider/retryable_client.rs
index c9d460330..339c962a3 100644
--- a/packages/fuels-accounts/src/provider/retryable_client.rs
+++ b/packages/fuels-accounts/src/provider/retryable_client.rs
@@ -59,7 +59,10 @@ impl Cacheab... | [
"e2e/tests/contracts.rs",
"packages/fuels-accounts/src/provider/retryable_client.rs",
"packages/fuels-programs/src/calls/call_handler.rs"
] | [] | diff --git a/e2e/tests/contracts.rs b/e2e/tests/contracts.rs
index e01f3a75c..2c4e9020a 100644
--- a/e2e/tests/contracts.rs
+++ b/e2e/tests/contracts.rs
@@ -224,6 +224,44 @@ async fn test_multi_call_beginner() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn test_multi_call_simulate_vec() -> Result<()> {
+ ... | true | ||
FuelLabs/fuels-rs | 1,705 | issue_to_patch | Make `IsUserAccountVariables` cloneable | # Summary
This PR makes adds `Clone` derive for `IsUserAccountVariables`. `IsUserAccountVariables` must implement `Clone` in order to be able to be used in the upcoming version of `fuels-accounts` where the `query` function requires `Vars` generic parameter to be `Clone`able.
```
error[E0277]: the trait bound `I... | 865e00c295de8b4a0a1ef7ac926c3c8266d5151b | 292073078b6077cf36c3ce3a9bbf7df48a6661a2 | diff --git a/packages/fuels-accounts/src/provider/retryable_client.rs b/packages/fuels-accounts/src/provider/retryable_client.rs
index 1401de100..55531b6fe 100644
--- a/packages/fuels-accounts/src/provider/retryable_client.rs
+++ b/packages/fuels-accounts/src/provider/retryable_client.rs
@@ -407,7 +407,7 @@ mod custom_... | [
"packages/fuels-accounts/src/provider/retryable_client.rs"
] | [] | true | ||
FuelLabs/fuels-rs | 1,699 | issue_to_patch | Feature/log id expose | Example of usage: https://github.com/FuelLabs/fuel-rust-indexer/blob/main/crates/indexer/processors/receipt_parser.rs#L17
<!--
List the issues this PR closes (if any) in a bullet list format, e.g.:
- Closes #ABCD
- Closes #EFGH
-->
# Release notes
<!--
Use this only if this PR requires a mention in the Re... | f2afc5f516349d2ff302c248d37b95116fd9c707 | f79ad1ce62a91c8a7da928af2e3b3c3916254643 | diff --git a/packages/fuels-code-gen/src/program_bindings/abigen.rs b/packages/fuels-code-gen/src/program_bindings/abigen.rs
index de87eb2e4..e4fccbdbd 100644
--- a/packages/fuels-code-gen/src/program_bindings/abigen.rs
+++ b/packages/fuels-code-gen/src/program_bindings/abigen.rs
@@ -1,7 +1,7 @@
use std::{collections:... | [
"packages/fuels-code-gen/src/program_bindings/abigen.rs",
"packages/fuels-code-gen/src/program_bindings/custom_types.rs",
"packages/fuels-code-gen/src/program_bindings/custom_types/enums.rs",
"packages/fuels-code-gen/src/program_bindings/custom_types/structs.rs",
"packages/fuels-core/src/codec/logs.rs"
] | [] | true | ||
FuelLabs/fuels-rs | 1,698 | issue_to_patch | chore(version): bump version to 0.76.0 and make test clearer | <!--
List the issues this PR closes (if any) in a bullet list format, e.g.:
- Closes #ABCD
- Closes #EFGH
-->
# Release notes
<!--
Use this only if this PR requires a mention in the Release
Notes Summary. Valuable features and critical fixes are good
examples. For everything else, please delete the whole section.
-->... | 0278079673c30f848009f8d79f82b1a436015c1e | 399aa504d93c5fb3df987ce028f8867e50fe194d | diff --git a/Cargo.toml b/Cargo.toml
index d66a8598d..c863b419b 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -39,7 +39,7 @@ readme = "README.md"
license = "Apache-2.0"
repository = "https://github.com/FuelLabs/fuels-rs"
rust-version = "1.90.0"
-version = "0.75.1"
+version = "0.76.0"
[workspace.dependencies]
Infle... | [
"Cargo.toml",
"docs/src/connecting/short-lived.md",
"e2e/tests/providers.rs"
] | [] | diff --git a/e2e/tests/providers.rs b/e2e/tests/providers.rs
index adaf6153f..d47770c95 100644
--- a/e2e/tests/providers.rs
+++ b/e2e/tests/providers.rs
@@ -1458,40 +1458,40 @@ async fn script_tx_get_owner_returns_owner_when_policy_set_multiple_inputs() ->
use fuel_asm::{GMArgs, op};
let amount = 1000;
- ... | true | |
FuelLabs/fuels-rs | 1,697 | issue_to_patch | chore(deps): bump fuel-core and fuel-vm deps, add owner TxPolicy |
has tests for -
1. multiple inputs, different owners, owner policy set, returned
2. multiple inputs, same owner, owner policy unset, returned
3. multiple inputs, different owners, owner policy unset, panics
| 7f397ef1993ffddf1f2737976fce9969105e8fd8 | a3ee4bede8bc1b9547e2852e20418a64a47480cd | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 4660e20338..c8f576f817 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ env:
CARGO_TERM_COLOR: always
DASEL_VERSION: https://github.com/TomWright/dasel/releases/download/v2.3.6/dasel_linux_amd64
RUSTFLA... | [
".github/workflows/ci.yml",
"Cargo.toml",
"e2e/tests/providers.rs",
"e2e/tests/scripts.rs",
"packages/fuels-accounts/src/provider/supported_fuel_core_version.rs",
"packages/fuels-core/src/codec/logs.rs",
"packages/fuels-core/src/types/errors.rs",
"packages/fuels-core/src/types/transaction_builders.rs"... | [] | diff --git a/e2e/tests/providers.rs b/e2e/tests/providers.rs
index 160dd51655..adaf6153fe 100644
--- a/e2e/tests/providers.rs
+++ b/e2e/tests/providers.rs
@@ -15,7 +15,7 @@ use fuels::{
coin_type::CoinType,
message::Message,
transaction_builders::{BuildableTransaction, ScriptTransactionBuilde... | true | |
FuelLabs/fuels-rs | 1,694 | issue_to_patch | Bump rust to 1.90 | ## Description
- Bumps stable rust `1.86.0` -> `1.90.0`
- Also aligns with sway repo (essentially making local patches easier)
- Minor code changes (cargo clippy) required by rust `1.90.0` toolchain
Required for https://github.com/FuelLabs/fuel-core/pull/3110#issuecomment-3376910614
# Checklist
- [x] Al... | 63e1fe7ec2f466eed5a0b180fc8c2435a2304283 | 225074ee1921a84fef3e668a21f633d7c70037f6 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 097b2217df..4660e20338 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -19,7 +19,7 @@ env:
FUEL_CORE_VERSION: 0.46.0
FUEL_CORE_PATCH_BRANCH: ""
FUEL_CORE_PATCH_REVISION: ""
- RUST_VERSION: 1.86.0
+ RUST_VERSION: 1.... | [
".github/workflows/ci.yml",
"Cargo.toml",
"examples/macros/src/lib.rs",
"packages/fuels-accounts/src/provider/cache.rs",
"packages/fuels-core/src/types/token.rs",
"packages/fuels-core/src/types/tx_status.rs",
"packages/fuels-test-helpers/src/lib.rs"
] | [] | true | ||
FuelLabs/fuels-rs | 1,693 | issue_to_patch | chore: remove patch branch from e2e `Cargo.toml` | # Summary
This PR removes the obsolete patch branch from the `e2e` test's `Forc.toml`. The `#[patch]` section is left in the `Forc.toml` for expected future use.
# Checklist
- [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **changes** are **documented** (or not applicable)
- [... | 001466be2b25b4dec28a98da352646e2b2465493 | 8d312f99613fdcbc02bd5129d713f5da62c461ff | diff --git a/e2e/Forc.toml b/e2e/Forc.toml
index 78548928f..a2e708056 100644
--- a/e2e/Forc.toml
+++ b/e2e/Forc.toml
@@ -120,4 +120,4 @@ members = [
]
[patch.'https://github.com/fuellabs/sway']
-std = { git = "https://github.com/fuellabs/sway", branch = "ironcev/error-codes-in-abi-json" }
+std = { git = "https://gi... | [
"e2e/Forc.toml"
] | [
{
"comment": "### Bug: CI Mismatch: `std` Library Branch Update\n\n<!-- **High Severity** -->\n\n<!-- DESCRIPTION START -->\nThe `std` library patch in `e2e/Forc.toml` now points to the default `sway` branch instead of a specific one. This creates a version mismatch with the specific `forc` branch used in CI, w... | true | ||
FuelLabs/fuels-rs | 1,693 | comment_to_fix | chore: remove patch branch from e2e `Cargo.toml` | ### Bug: CI Mismatch: `std` Library Branch Update
<!-- **High Severity** -->
<!-- DESCRIPTION START -->
The `std` library patch in `e2e/Forc.toml` now points to the default `sway` branch instead of a specific one. This creates a version mismatch with the specific `forc` branch used in CI, which could lead to compilat... | 001466be2b25b4dec28a98da352646e2b2465493 | 8d312f99613fdcbc02bd5129d713f5da62c461ff | diff --git a/e2e/Forc.toml b/e2e/Forc.toml
index 78548928f..a2e708056 100644
--- a/e2e/Forc.toml
+++ b/e2e/Forc.toml
@@ -120,4 +120,4 @@ members = [
]
[patch.'https://github.com/fuellabs/sway']
-std = { git = "https://github.com/fuellabs/sway", branch = "ironcev/error-codes-in-abi-json" }
+std = { git = "https://gi... | [
"e2e/Forc.toml"
] | [
{
"comment": "### Bug: CI Mismatch: `std` Library Branch Update\n\n<!-- **High Severity** -->\n\n<!-- DESCRIPTION START -->\nThe `std` library patch in `e2e/Forc.toml` now points to the default `sway` branch instead of a specific one. This creates a version mismatch with the specific `forc` branch used in CI, w... | true | ||
FuelLabs/fuels-rs | 1,692 | issue_to_patch | Version bump yo `v0.75.1` due to `fuel-abi-types` dependency update | This pull request updates the `fuels` crate and related workspace packages from version `0.75.0` to `0.75.1`, ensuring consistency across dependencies and documentation.
It also updates the `fuel-abi-types` dependency to a newer patch version.
Pre-requisite for PR: https://github.com/FuelLabs/sway/pull/7445#issueco... | 48f3c437394207ce8c37342ad2ce6bb6cc8076ba | 0fae9b1793d2e2c806ee01a792124f2ae1664875 | diff --git a/Cargo.toml b/Cargo.toml
index 94e47dbfc5..531d9123df 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -39,7 +39,7 @@ readme = "README.md"
license = "Apache-2.0"
repository = "https://github.com/FuelLabs/fuels-rs"
rust-version = "1.86.0"
-version = "0.75.0"
+version = "0.75.1"
[workspace.dependencies]
Inf... | [
"Cargo.toml",
"docs/src/connecting/short-lived.md"
] | [] | true | ||
FuelLabs/fuels-rs | 1,688 | issue_to_patch | chore(release): prepare for release 0.75.0 | looks like some documentation was already updated to use 0.75.0, its not on crates.io or gh releases though
| dd575b290dde3adb7de2e5373364050ef0d7c456 | 35f5b5910c624f8bb54948d9dd7f15d5ba88bf1d | diff --git a/Cargo.toml b/Cargo.toml
index 1993da6a4..94e47dbfc 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -39,7 +39,7 @@ readme = "README.md"
license = "Apache-2.0"
repository = "https://github.com/FuelLabs/fuels-rs"
rust-version = "1.86.0"
-version = "0.74.0"
+version = "0.75.0"
[workspace.dependencies]
Infle... | [
"Cargo.toml"
] | [] | true | ||
FuelLabs/fuels-rs | 1,686 | issue_to_patch | chore: add method to get fn selector | use can use it like this
```rs
abigen!(Contract(
name = "MyContract",
abi = "e2e/sway/contracts/contract_name/out/release/contract_name-abi.json"
));
fn main() {
let methods = MyContract::METHODS;
let burn_coins_fn_selector = methods.burn_coins().fn_selector();
}
```
... | 3eb9458b3d031bae8d3c6ee06dba3af6b9243f6f | d82f241eec2a2092cfe148f731e8b70e1d36e828 | diff --git a/packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs b/packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs
index 449d66762..784b80903 100644
--- a/packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs
+++ b/packages/fuels-code-gen/src/program_bind... | [
"e2e/tests/contracts.rs",
"packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs",
"packages/fuels-code-gen/src/utils.rs",
"packages/fuels-core/Cargo.toml",
"packages/fuels-core/src/codec/function_selector.rs",
"packages/fuels-core/src/types.rs",
"packages/fuels-core/src/types/method_... | [] | diff --git a/e2e/tests/contracts.rs b/e2e/tests/contracts.rs
index 9269d500c..e01f3a75c 100644
--- a/e2e/tests/contracts.rs
+++ b/e2e/tests/contracts.rs
@@ -2839,3 +2839,44 @@ async fn multicall_tx_input_output() -> Result<()> {
Ok(())
}
+
+#[tokio::test]
+async fn test_returned_method_descriptors_are_valid() -... | true | |
FuelLabs/fuels-rs | 1,685 | issue_to_patch | feat: expose offsets_with_data on configurables | - Expose offsets_with_data on Configurables this allows for better DX when interacting with the Standard SRC12 that requires configurable to be provided as `Vec<(u64, Vec<u8>)>`.
Note: I have made `offsets_with_data` public and also implement `Into`. I'm not sure what is the best solution here, so once reviewed it... | d0a0ce733a71388fbf257b2e766347c97b06abb7 | 182334eb4ab880f61b742640b61c6be0b991fb53 | diff --git a/docs/src/codec/index.md b/docs/src/codec/index.md
index 69fa1762ee..1eba25cfde 100644
--- a/docs/src/codec/index.md
+++ b/docs/src/codec/index.md
@@ -12,8 +12,8 @@ All types generated by the [`abigen!`](../abigen/index.md) macro implement both
`fuels` also contains implementations for:
-- [`Tokenizabl... | [
"docs/src/codec/index.md",
"packages/fuels-code-gen/src/program_bindings/abigen/configurables.rs",
"packages/fuels-core/src/lib.rs",
"packages/fuels-programs/src/executable.rs",
"packages/fuels-test-helpers/src/service.rs",
"packages/fuels/src/lib.rs"
] | [
{
"comment": "If you want to implement `From` for internal components, then `(u64, Vec<u8>)` should be replaced with proper structure with fields and comments.",
"path": "packages/fuels-core/src/lib.rs",
"hunk": "@@ -52,6 +52,12 @@ impl Configurables {\n }\n }\n \n+impl From<Configurables> for Vec<(... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.