repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
FoundationAgents/OpenManus | 1,145 | issue_to_patch | run_mcp.py can not work correct ,OpenAI API error: Error code: 400 - Invalid 'tools[0].function.name': string does not match pattern.
### Bug Description
Hello, thank you for your work!
I deployed the OpenManus project on my Ubuntu 22.04 server today. When I installed the environment according to the documentation a... | fix: sanitize MCP tool names for OpenAI API compliance | Tool names with invalid characters (slashes, dots) from server paths were causing OpenAI API 400 errors. Added sanitization to ensure names match required pattern ^[a-zA-Z0-9_-]{1,64}$.
Fixes #1143
**Result**
it no longer fails at the tool calling step
<img width="1003" alt="Screenshot 2025-05-29 at 11 00 12 PM... | 7cd3057ddab94989ec02f17060b1c7ed13b0bf92 | 8597ef49258d4625bc19b70edf6a92b1b816e743 | diff --git a/app/tool/mcp.py b/app/tool/mcp.py
index c05b4183e..32fa8249e 100644
--- a/app/tool/mcp.py
+++ b/app/tool/mcp.py
@@ -1,6 +1,7 @@
from contextlib import AsyncExitStack
from typing import Dict, List, Optional
+from mcp import ClientSession, StdioServerParameters
from mcp.client.sse import sse_client
fro... | [
"app/tool/mcp.py"
] | [] | true | |
FoundationAgents/OpenManus | 1,153 | issue_to_patch | Add prompt input parser into main.py | Add prompt input parser into main.py
So user can be calling like
`python3 main.py --prompt "thins is an example prompt"`
the prompt parser is designed to be optional | 7cd3057ddab94989ec02f17060b1c7ed13b0bf92 | e1499ee1f65f4ce7d3a20fd6bdd9568cb72e3041 | diff --git a/app/tool/mcp.py b/app/tool/mcp.py
index c05b4183e..91ce82d9c 100644
--- a/app/tool/mcp.py
+++ b/app/tool/mcp.py
@@ -1,6 +1,7 @@
from contextlib import AsyncExitStack
from typing import Dict, List, Optional
+from mcp import ClientSession, StdioServerParameters
from mcp.client.sse import sse_client
fro... | [
"app/tool/mcp.py",
"main.py"
] | [] | true | ||
FoundationAgents/OpenManus | 1,107 | issue_to_patch | fix: fix wrong resolved url in pacakge-lock.json | **Fix**
Fix wrong resolved url in package-lock.json. Transfer to npmjs url.
**Features**
<!-- Describe the features or bug fixes in this PR. For bug fixes, link to the issue. -->
**Feature Docs**
<!-- Provide RFC, tutorial, or use case links for significant updates. Optional for minor changes. -->
**Influen... | b9f65343154055d41ba03f608183b065875451d1 | 0158c7233e8d1295a690d3905302048d9f1ce9e7 | diff --git a/app/tool/chart_visualization/package-lock.json b/app/tool/chart_visualization/package-lock.json
index 5b9e04357..384fd8dfc 100644
--- a/app/tool/chart_visualization/package-lock.json
+++ b/app/tool/chart_visualization/package-lock.json
@@ -98,36 +98,6 @@
"@resvg/resvg-js-win32-x64-msvc": "2.4.1"
... | [
"app/tool/chart_visualization/package-lock.json"
] | [] | true | ||
FoundationAgents/OpenManus | 1,139 | issue_to_patch | Feat/add agent in runflow | **Features**
<!-- Describe the features or bug fixes in this PR. For bug fixes, link to the issue. -->
- Feature 1 Add data analysis agent into run_flow
**Feature Docs**
<!-- Provide RFC, tutorial, or use case links for significant updates. Optional for minor changes. -->
**Influence**
<!-- Explain the impa... | d901a980647e21c23e28bdebf88039677e1a90d3 | 6c8948569403f1648daead07380f536c246d5fa9 | diff --git a/README.md b/README.md
index 7ecf861ef..214396b7c 100644
--- a/README.md
+++ b/README.md
@@ -137,6 +137,17 @@ For unstable multi-agent version, you also can run:
python run_flow.py
```
+### Custom Adding Multiple Agents
+
+Currently, besides the general OpenManus Agent, we have also integrated the DataA... | [
"README.md",
"README_ja.md",
"README_ko.md",
"README_zh.md",
"app/agent/data_analysis.py",
"app/config.py",
"app/flow/planning.py",
"app/tool/chart_visualization/README.md",
"app/tool/chart_visualization/README_ja.md",
"app/tool/chart_visualization/README_ko.md",
"app/tool/chart_visualization/RE... | [] | true | ||
FoundationAgents/OpenManus | 1,127 | issue_to_patch | Flow auto validate | # Pull Request Summary
This PR introduces a **new agent** and **two new tools** to the codebase, enhancing the system's capabilities for **multi-step reasoning**, **tool-based task execution**, and **input validation**.
---
## Key Changes
### New Agent: `fixToolCallAgent` (in `ppt.py`)
- Enhances the origi... | c3de3ad6f71a288ba479f985ecc5e70fe987ec85 | e2335877a8ffcbe20b64265c76d88c16766a7db0 | diff --git a/README.md b/README.md
index 9e757b676..d92c4e648 100644
--- a/README.md
+++ b/README.md
@@ -1,176 +1,176 @@
-<p align="center">
- <img src="assets/logo.jpg" width="200"/>
-</p>
-
-English | [中文](README_zh.md) | [한국어](README_ko.md) | [日本語](README_ja.md)
-
-[![GitHub stars](https://img.shields.io/gith... | [
"README.md",
"app/agent/ppt.py",
"app/bedrock.py",
"app/llm.py",
"app/prompt/latex_generator.py",
"app/prompt/validator.py",
"app/schema.py",
"app/tool/__init__.py",
"app/tool/latex_generator.py",
"app/tool/validator.py",
"examples/use-cases/generatePPT.py",
"examples/use-cases/japan-travel-pl... | [] | true | ||
FoundationAgents/OpenManus | 1,114 | issue_to_patch | BUGFIX: FIX MCPAgent Bug | **Features**
About McpAgent session bug
| b9f65343154055d41ba03f608183b065875451d1 | 0810b28d9d3450131293ad90292493b5057e7677 | diff --git a/app/agent/mcp.py b/app/agent/mcp.py
index 01a48b094..9c6da6aaa 100644
--- a/app/agent/mcp.py
+++ b/app/agent/mcp.py
@@ -90,11 +90,11 @@ async def _refresh_tools(self) -> Tuple[List[str], List[str]]:
Returns:
A tuple of (added_tools, removed_tools)
"""
- if not self.mcp... | [
"app/agent/mcp.py",
"app/tool/mcp.py"
] | [] | true | ||
FoundationAgents/OpenManus | 1,104 | issue_to_patch | Simplify return statement in count_image by removing redundant comments | This PR makes a small cleanup in the `count_image` method:
- Removes unnecessary comments
- Simplifies the return statement for better readability
- No change in logic or behavior
Pre-commit checks have been run successfully to ensure code quality.
| 8593116982c21d0e98569df2fdf171b659d60449 | a77823636f4792a1c0c7238d0d9f6afc448ecb6d | diff --git a/app/llm.py b/app/llm.py
index 37d493b76..82ebe8857 100644
--- a/app/llm.py
+++ b/app/llm.py
@@ -88,16 +88,9 @@ def count_image(self, image_item: dict) -> int:
width, height = image_item["dimensions"]
return self._calculate_high_detail_tokens(width, height)
- # Def... | [
"app/llm.py"
] | [] | true | ||
FoundationAgents/OpenManus | 1,085 | issue_to_patch | delete duplicate code | 
| f760ebfb15af17b4749f29a217084050f5a04293 | fe56b80c8e9bfeb053bda0af1e2496d70c7ea2b0 | diff --git a/app/agent/toolcall.py b/app/agent/toolcall.py
index 7db14f19f..65f31d988 100644
--- a/app/agent/toolcall.py
+++ b/app/agent/toolcall.py
@@ -188,14 +188,6 @@ async def execute_tool(self, command: ToolCall) -> str:
# Store the base64_image for later use in tool_message
self.... | [
"app/agent/toolcall.py"
] | [] | true | ||
FoundationAgents/OpenManus | 1,097 | issue_to_patch | feat: add data analysis agent to do data process / data report / chart generation / ... tasks | **Features**
<!-- Describe the features or bug fixes in this PR. For bug fixes, link to the issue. -->
- Feature 1: Add data analysis agent to do data analysis task includes: data process / data report / chart generation / ...
- Feature 2: Add chart prepare && chart visualization tools to generate chart / generat... | f760ebfb15af17b4749f29a217084050f5a04293 | f162d629a6a5f15be7f5bc3a53aa579deb355cd9 | diff --git a/.gitignore b/.gitignore
index 857ec7e7f..41dbbf2d8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -197,3 +197,6 @@ cython_debug/
# OSX
.DS_Store
+
+# node
+node_modules
diff --git a/app/agent/data_analysis.py b/app/agent/data_analysis.py
new file mode 100644
index 000000000..774a5cffd
--- /dev/null
+++ b/... | [
".gitignore",
"app/agent/data_analysis.py",
"app/prompt/visualization.py",
"app/tool/chart_visualization/README.md",
"app/tool/chart_visualization/README_zh.md",
"app/tool/chart_visualization/__init__.py",
"app/tool/chart_visualization/chart_prepare.py",
"app/tool/chart_visualization/data_visualizatio... | [] | diff --git a/app/tool/chart_visualization/test/chart_demo.py b/app/tool/chart_visualization/test/chart_demo.py
new file mode 100644
index 000000000..d89d993f2
--- /dev/null
+++ b/app/tool/chart_visualization/test/chart_demo.py
@@ -0,0 +1,191 @@
+import asyncio
+
+from app.agent.data_analysis import DataAnalysis
+from a... | true | |
FoundationAgents/OpenManus | 116 | issue_to_patch | feat: Adding human interaction functionality to Manus | Add a tool call method to ask human.
Optimize Manus's prompt to avoid dead loops. | a54182235002b366a3858de54fb201487e8cf7fd | 628aaf00d1d3ac6d05b09478db22569ae5069386 | diff --git a/app/agent/manus.py b/app/agent/manus.py
index d7ec2f9a6..6a42860c5 100644
--- a/app/agent/manus.py
+++ b/app/agent/manus.py
@@ -5,6 +5,7 @@
from app.prompt.browser import NEXT_STEP_PROMPT as BROWSER_NEXT_STEP_PROMPT
from app.prompt.manus import NEXT_STEP_PROMPT, SYSTEM_PROMPT
from app.tool import Termin... | [
"app/agent/manus.py",
"app/prompt/manus.py",
"app/tool/ask_human.py"
] | [] | true | ||
FoundationAgents/OpenManus | 1,061 | issue_to_patch | Manus Agent to include MCP tools | 1. mcp clients to support multiple mcp servers instead of one
2. allow manus agent to connect to mcp servers whilst keeping the local tool set
3. include automatic mcp config loading
| 1a12b67e4b3476ca285a68a830d59388be57f068 | df9312dfca17d4cdbbcd193f8fde571602211ea7 | diff --git a/app/agent/manus.py b/app/agent/manus.py
index 253e0408d..0f8dcec4c 100644
--- a/app/agent/manus.py
+++ b/app/agent/manus.py
@@ -1,24 +1,24 @@
-from typing import Optional
+from typing import Dict, List, Optional
from pydantic import Field, model_validator
from app.agent.browser import BrowserContextH... | [
"app/agent/manus.py",
"app/config.py",
"app/tool/mcp.py",
"app/tool/tool_collection.py",
"config/mcp.example.json",
"main.py"
] | [] | true | ||
FoundationAgents/OpenManus | 1,067 | issue_to_patch | feat: add config example for PPIO | **Features**
- Add config example for PPIO
| 1a12b67e4b3476ca285a68a830d59388be57f068 | 82838bd3b4c783b7beaf9b929eadb4e6a56392a7 | diff --git a/config/config.example-model-ppio.toml b/config/config.example-model-ppio.toml
new file mode 100644
index 000000000..64c633508
--- /dev/null
+++ b/config/config.example-model-ppio.toml
@@ -0,0 +1,17 @@
+# Global LLM configuration
+[llm] #PPIO:
+api_type = 'ppio'
+model = "deepseek/deepseek-v3-0324" ... | [
"config/config.example-model-ppio.toml"
] | [] | true | ||
FoundationAgents/OpenManus | 1,050 | issue_to_patch | add terminate for NEXT_STEP_PROMPT in browser & manus | **Features**
<!-- Describe the features or bug fixes in this PR. For bug fixes, link to the issue. -->
- Feature 1
- Feature 2
**Feature Docs**
<!-- Provide RFC, tutorial, or use case links for significant updates. Optional for minor changes. -->
**Influence**
<!-- Explain the impact of these changes for r... | a54182235002b366a3858de54fb201487e8cf7fd | 0e7f5ee0f98fc7df94a43e8e6d6198b2b4bc932b | diff --git a/app/prompt/browser.py b/app/prompt/browser.py
index 70fed300b..b27714d5f 100644
--- a/app/prompt/browser.py
+++ b/app/prompt/browser.py
@@ -89,4 +89,6 @@
Consider both what's visible and what might be beyond the current viewport.
Be methodical - remember your progress and what you've learned so far.
+
... | [
"app/prompt/browser.py",
"app/prompt/manus.py"
] | [] | true | ||
FoundationAgents/OpenManus | 635 | issue_to_patch | gemini api 运行报这个错误是什么原因呢？
2025-03-08 09:47:19.741 | INFO | app.agent.toolcall:think:54 - 🛠️ Manus selected 0 tools to use
2025-03-08 09:47:19.741 | INFO | app.agent.base:run:137 - Executing step 9/30
2025-03-08 09:47:21.021 | INFO | app.agent.toolcall:think:53 - ✨ Manus's thoughts: None
2025-03-08 09:47:2... | fix(llm): improve message handling to support LLMs without content/tool_calls | **Features**
- Improved message handling in the `LLM` class to gracefully handle messages without `content` or `tool_calls` fields.
- Reordered message processing to check for `Message` objects first.
- Changed validation approach to silently skip malformed messages instead of raising a `ValueError`.
- Remo... | 3671e1d866084dbcb775ef5c11e751b5b5ba7fe0 | 60268f16961eac615519f2c6387994bfc5cb8980 | diff --git a/app/llm.py b/app/llm.py
index 8c085aed0..24a50e0ca 100644
--- a/app/llm.py
+++ b/app/llm.py
@@ -84,14 +84,15 @@ def format_messages(messages: List[Union[dict, Message]]) -> List[dict]:
formatted_messages = []
for message in messages:
+ if isinstance(message, Message):
+ ... | [
"app/llm.py"
] | [] | true | |
FoundationAgents/OpenManus | 1,034 | issue_to_patch | Desktop: Improve home page and task page | **Features**
<!-- Describe the features or bug fixes in this PR. For bug fixes, link to the issue. -->
- Improve home page
- Improve task page
**Feature Docs**
<!-- Provide RFC, tutorial, or use case links for significant updates. Optional for minor changes. -->
**Influence**
<!-- Explain the impact of the... | 4e3738cf78a3808208fa4dec701aa9483acb2c71 | beb52b4f36e48b854ed53083fd3e94dc6703cf2f | diff --git a/desktop/frontend/src/assets/css/main.css b/desktop/frontend/src/assets/css/main.css
index c14d09185..f3f7ac70c 100644
--- a/desktop/frontend/src/assets/css/main.css
+++ b/desktop/frontend/src/assets/css/main.css
@@ -451,6 +451,10 @@ div.el-divider {
align-items: center;
}
+.fr {
+ display: flex;
+}
... | [
"desktop/frontend/src/assets/css/main.css",
"desktop/frontend/src/components/TopHeader.vue",
"desktop/frontend/src/locales/en.js",
"desktop/frontend/src/locales/zh-cn.js",
"desktop/frontend/src/views/Home.vue",
"desktop/frontend/src/views/config/Init.vue",
"desktop/frontend/src/views/task/TaskIndex.vue"... | [] | true | ||
FoundationAgents/OpenManus | 963 | issue_to_patch | fix: infinite loop in simple question until max_step is reached | **Features**
- issue 1: 修复Manus即使任务已完成也会一直循环到max_steps才停止的问题
- issue 2: 修复Manus没有使用`browse-use`工具，但Masus.next_step_prompt被意外设置成`app.prompt.browser.NEXT_STEP_PROMPT`的问题
**Feature Docs**
问题分析：
**问题1**:
类的继承关系：`Manus` -> `BrowserAgent` -> `ToolCallAgent` -> `ReActAgent`
在`ToolCallAgent.think()`的实现https://gith... | a10b9734944db54c55c4befd3c9b7b56fdddab46 | 34c610857f2d194dff98f02a972274f64ed1e39d | diff --git a/app/agent/browser.py b/app/agent/browser.py
index ae0ce2fa1..ec1b5738b 100644
--- a/app/agent/browser.py
+++ b/app/agent/browser.py
@@ -111,14 +111,14 @@ async def think(self) -> bool:
)
self.memory.add_message(image_message)
- # Replace placeholders with actual b... | [
"app/agent/browser.py"
] | [] | true | ||
FoundationAgents/OpenManus | 917 | issue_to_patch | Desktop: Improve task page | **Features**
<!-- Describe the features or bug fixes in this PR. For bug fixes, link to the issue. -->
- Improve task page, make the page more vivid and beautiful.
**Feature Docs**
<!-- Provide RFC, tutorial, or use case links for significant updates. Optional for minor changes. -->
**Influence**
<!-- Expla... | 7e18c97a2fb25c60176ac95ece7b7e42e06b2411 | e7bdfe123dade9017e162dc3fb019580ba8165bf | diff --git a/.gitignore b/.gitignore
index 0e7a59bc8..d7593d6d5 100644
--- a/.gitignore
+++ b/.gitignore
@@ -181,3 +181,6 @@ workspace/
# Private Config
config/config.toml
+
+# Desktop runtime
+desktop/frontend/wailsjs/runtime/
diff --git a/desktop/app.go b/desktop/app.go
index e796dcc71..5ea6f46b0 100644
--- a/des... | [
".gitignore",
"desktop/app.go",
"desktop/frontend/index.html",
"desktop/frontend/package-lock.json",
"desktop/frontend/package.json",
"desktop/frontend/src/assets/css/main.css",
"desktop/frontend/src/assets/img/logo-b-sm.png",
"desktop/frontend/src/assets/img/logo-b.png",
"desktop/frontend/src/asset... | [] | true | ||
FoundationAgents/OpenManus | 996 | issue_to_patch | Add multilingual switchingFront end | 456868c01c6e602d8a48aebed944300a94f7a3b1 | f9b36d84060817975daf8a54a6adc189bbe2aef6 | diff --git a/static/i18n.js b/static/i18n.js
new file mode 100644
index 000000000..9e5ef796f
--- /dev/null
+++ b/static/i18n.js
@@ -0,0 +1,221 @@
+const i18n = {
+ en: {
+ welcome: {
+ title: "Welcome to OpenManus Local Version",
+ subtitle: "Please enter a task prompt to start a new tas... | [
"static/i18n.js",
"static/style.css",
"templates/index.html"
] | [] | true | |||
FoundationAgents/OpenManus | 951 | issue_to_patch | typing 'exit' to quit generates the following error
2025-03-09 16:09:19.145 | INFO | app.agent.toolcall:think:53 - ✨ Manus's thoughts:
2025-03-09 16:09:19.146 | INFO | app.agent.toolcall:think:54 - 🛠️ Manus selected 1 tools to use
2025-03-09 16:09:19.146 | INFO | app.agent.toolcall:think:58 - 🧰 Tools bei... | Fix asyncio resource leaks by implementing agent cleanup hierarchy | **Description**:
**Features**
- Fixes #814 and fixes #329 by addressing I/O operation on closed pipe errors
- Implements proper resource cleanup for agent hierarchy (ToolCallAgent → BrowserAgent → Manus)
- Adds `try...finally` block in main.py to ensure cleanup executes on normal/error exits
**Featur... | ebe9602fbe2fd185c0991fe89ab6535958ce5856 | af46bfada20abca12c512259cc3e0532d3206325 | diff --git a/app/agent/browser.py b/app/agent/browser.py
index ec1b5738b..ae1df9754 100644
--- a/app/agent/browser.py
+++ b/app/agent/browser.py
@@ -127,3 +127,7 @@ async def think(self) -> bool:
self.next_step_prompt = NEXT_STEP_PROMPT
return result
+
+ async def cleanup(self):
+ """Clean... | [
"app/agent/browser.py",
"app/agent/manus.py",
"app/agent/toolcall.py",
"main.py"
] | [] | true | |
FoundationAgents/OpenManus | 954 | issue_to_patch | Fix manus agent's next step prompt accidentally overwritten by browser agent | **Features**
In the Manus.think () method: the code checks whether the recent message contains "browser_use" If so, set self.next_step_prompt to BROWSER_NEXT_STEP_PROMPT and then call await super ().think () (which is BrowserAgent.think ())
<img width="642" alt="image" src="https://github.com/user-attachments/assets... | 3f3d262ebe035a5761c2f53c04683cd4c7fd016b | 7d3b10ef839761ce5b6ac77cb2b2c386c3f759db | diff --git a/app/agent/browser.py b/app/agent/browser.py
index ae0ce2fa1..ec1b5738b 100644
--- a/app/agent/browser.py
+++ b/app/agent/browser.py
@@ -111,14 +111,14 @@ async def think(self) -> bool:
)
self.memory.add_message(image_message)
- # Replace placeholders with actual b... | [
"app/agent/browser.py"
] | [] | true | ||
FoundationAgents/OpenManus | 980 | issue_to_patch | update readme | update readme for adding hf space | c28d036ee34694955719917381af3e0792f84c71 | 346666d9463273f818d0ef69db657d0cd7ccc822 | diff --git a/README.md b/README.md
index 9e757b676..f62454057 100644
--- a/README.md
+++ b/README.md
@@ -1,176 +1,179 @@
-<p align="center">
- <img src="assets/logo.jpg" width="200"/>
-</p>
-
-English | [中文](README_zh.md) | [한국어](README_ko.md) | [日本語](README_ja.md)
-
-[![GitHub stars](https://img.shields.io/gith... | [
"README.md",
"README_ja.md",
"README_ko.md",
"README_zh.md"
] | [] | true | ||
FoundationAgents/OpenManus | 984 | issue_to_patch | update WebSearch and SearchSettings | Add type hint for WebSearch and update SearchSettings | 782687f3b778e2f09b3497982a9095287d66cb77 | 55015797c6d841afdfeda8e29636e4e0f91c9e3c | diff --git a/app/config.py b/app/config.py
index bd7886330..eb91cf432 100644
--- a/app/config.py
+++ b/app/config.py
@@ -38,7 +38,7 @@ class ProxySettings(BaseModel):
class SearchSettings(BaseModel):
engine: str = Field(default="Google", description="Search engine the llm to use")
fallback_engines: List[str]... | [
"app/config.py",
"app/tool/search/baidu_search.py",
"app/tool/search/base.py",
"app/tool/search/bing_search.py",
"app/tool/search/duckduckgo_search.py",
"app/tool/search/google_search.py",
"app/tool/web_search.py",
"config/config.example.toml",
"requirements.txt"
] | [] | true | ||
FoundationAgents/OpenManus | 810 | issue_to_patch | make separate settings examples for different models.
@aleks-mariusz in https://github.com/mannaandpoem/OpenManus/issues/766#issuecomment-2730717658_
said something smart,
> "having one giant example toml with multiple sections that need to be commented/uncommented can be a bit unwieldly.. another idea [w... | Separate config file examples for each LLM API provider | Fixes #785
People often ask how to make this or that model work, and having examples of every type can be unwieldy. So I separate examples into each type that is supported. In the future we can update each ones with information that applies directly to the relevant provider as well without making an enormous exampl... | f25ed7d49ec1bd710d3ef71a7da2c74f2c3136b0 | baf439f6c3f2a1015a70216ba01a627c6f7b31fa | diff --git a/config/config.example-model-anthropic.toml b/config/config.example-model-anthropic.toml
new file mode 100644
index 000000000..21136f62b
--- /dev/null
+++ b/config/config.example-model-anthropic.toml
@@ -0,0 +1,44 @@
+# Global LLM configuration
+[llm]
+model = "claude-3-7-sonnet-latest" # The LLM mod... | [
"config/config.example-model-anthropic.toml",
"config/config.example-model-google.toml",
"config/config.example-model-ollama.toml",
"config/config.example-model-openai.toml",
"config/config.example.toml"
] | [] | true | |
FoundationAgents/OpenManus | 794 | issue_to_patch | Added message limit to the function "add_messages" to ensure that the… |
**Features**
add the max message limitation to function "add_messages". the previous version only "add_message" function has this feature.
<img width="491" alt="image" src="https://github.com/user-attachments/assets/4fa4cb49-04eb-4a35-a8e0-0e49c64741e3" />
| 7703ea2cf7e67c0913440af3f53621cb2a592ff9 | e39046d175c4a2ae0b33a13dbab21bc339adc25f | diff --git a/app/schema.py b/app/schema.py
index de18c4fdd..5f743f92f 100644
--- a/app/schema.py
+++ b/app/schema.py
@@ -170,6 +170,9 @@ def add_message(self, message: Message) -> None:
def add_messages(self, messages: List[Message]) -> None:
"""Add multiple messages to memory"""
self.messages.ex... | [
"app/schema.py"
] | [] | true | ||
FoundationAgents/OpenManus | 864 | issue_to_patch | OpenAI API error: Error code: 400
**Bug description**
When using OpenAI models (specifically gpt-4o-mini), the application fails with the following API error:
OpenAI API error: Error code: 400 - {'error': {'message': "Invalid 'tools[1].function.description': string too long. Expected a string with maximum length 1024,... | fix: simple browser use tool desc for gpt4o max len close #787 | **Features**
<!-- Describe the features or bug fixes in this PR. For bug fixes, link to the issue. -->
as title the gpt4o and claude3 maybe max token desc this patch simple the prompt
close #787 | d4358ef53792be46697c9178e93873198ee55bed | 8567344eb3a3e425fcad0c02a3cceb1814c8bf9b | diff --git a/app/tool/browser_use_tool.py b/app/tool/browser_use_tool.py
index 0158e0753..602474a17 100644
--- a/app/tool/browser_use_tool.py
+++ b/app/tool/browser_use_tool.py
@@ -17,33 +17,34 @@
_BROWSER_DESCRIPTION = """
-Interact with a web browser to perform various actions such as navigation, element interac... | [
"app/tool/browser_use_tool.py"
] | [] | true | |
FoundationAgents/OpenManus | 923 | issue_to_patch | chore(deps): update playwright requirement from ~=1.50.0 to ~=1.51.0 in the browsergym-related group | Updates the requirements on [playwright](https://github.com/microsoft/playwright-python) to permit the latest version.
Updates `playwright` to 1.51.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/microsoft/playwright-python/releases">playwright's releases</a>.</em></p>
<bloc... | c7a3f465da52f1fa10f74e4e24d065c4a7b89d5e | ccfde08fcb592c2fa9541e971008c984f4b53f1b | diff --git a/requirements.txt b/requirements.txt
index 9bac8a2cd..568c7527d 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -22,7 +22,7 @@ duckduckgo_search~=7.5.1
aiofiles~=24.1.0
pydantic_core~=2.27.2
colorama~=0.4.6
-playwright~=1.50.0
+playwright~=1.51.0
docker~=7.1.0
pytest~=8.3.5
| [
"requirements.txt"
] | [] | true | ||
FoundationAgents/OpenManus | 924 | issue_to_patch | chore(deps): bump the version-all group across 1 directory with 6 updates | Updates the requirements on [datasets](https://github.com/huggingface/datasets), [gymnasium](https://github.com/Farama-Foundation/Gymnasium), [pillow](https://github.com/python-pillow/Pillow), [duckduckgo-search](https://github.com/deedy5/duckduckgo_search), [mcp](https://github.com/modelcontextprotocol/python-sdk) and... | c7a3f465da52f1fa10f74e4e24d065c4a7b89d5e | ac3bc1e061534693cd193703b41470437affc265 | diff --git a/requirements.txt b/requirements.txt
index 9bac8a2cd..817eebba7 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -4,20 +4,20 @@ tenacity~=9.0.0
pyyaml~=6.0.2
loguru~=0.7.3
numpy
-datasets~=3.2.0
+datasets~=3.4.1
fastapi~=0.115.11
tiktoken~=0.9.0
html2text~=2024.2.26
-gymnasium~=1.0.0
-pillow~... | [
"requirements.txt",
"setup.py"
] | [] | true | ||
FoundationAgents/OpenManus | 964 | issue_to_patch | Update the MCP configuration, replace the hardcoding value with serve… | **Features**
add a mcp server configuration to config.toml.
[https://github.com/mannaandpoem/OpenManus/issues/926](url)
<img width="566" alt="image" src="https://github.com/user-attachments/assets/9d20abfc-f11e-4c7a-bb36-20392bc4a94c" />
| a10b9734944db54c55c4befd3c9b7b56fdddab46 | e10aa08013b7717262fbd38b39c10daf64771004 | diff --git a/app/config.py b/app/config.py
index 7088c42a4..bd7886330 100644
--- a/app/config.py
+++ b/app/config.py
@@ -90,6 +90,14 @@ class SandboxSettings(BaseModel):
)
+class MCPSettings(BaseModel):
+ """Configuration for MCP (Model Context Protocol)"""
+
+ server_reference: str = Field(
+ "ap... | [
"app/config.py",
"config/config.example.toml",
"run_mcp.py"
] | [] | true | ||
FoundationAgents/OpenManus | 974 | issue_to_patch | Set configuration button for Front end | 6160a5d05b6f155aea79f9ba21ff2d915dad3d5a | 594b38f905c976989b4fa054234c9a18cce33d4d | diff --git a/app.py b/app.py
index 059600fcc..5e823535d 100644
--- a/app.py
+++ b/app.py
@@ -259,7 +259,12 @@ async def check_config_status():
example_config_path = Path(__file__).parent / "config" / "config.example.toml"
if config_path.exists():
- return {"status": "exists"}
+ try:
+ ... | [
"app.py",
"static/main.js",
"static/style.css",
"templates/index.html"
] | [] | true | |||
FoundationAgents/OpenManus | 859 | issue_to_patch | fix/extracted content properties | **Features**
<!-- Describe the features or bug fixes in this PR. For bug fixes, link to the issue. -->
- Fix OpenAI API schema validation error in browser_use_tool.py
- Add required properties to extracted_content object type to comply with OpenAI's function declaration requirements
**Influence**
<!-- Explain... | 74f438bde38a47da884ba5de2d20960aa9a57990 | eef10607e14a6bc349b22725e970c685f2a9f67f | diff --git a/app/tool/browser_use_tool.py b/app/tool/browser_use_tool.py
index 0158e0753..8ac2b013a 100644
--- a/app/tool/browser_use_tool.py
+++ b/app/tool/browser_use_tool.py
@@ -448,6 +448,22 @@ async def execute(
"extracted_content": {
... | [
"app/tool/browser_use_tool.py"
] | [] | true | ||
FoundationAgents/OpenManus | 893 | issue_to_patch | feat: feature cot agent | **Features**
- Structured thought process with clear format (Thinking/Answer sections)
- Simple one-step reasoning process optimized for complex problem solving
- Support for multi-turn conversations
- Integration with existing agent architecture
**Feature Docs**
CoT mode is particularly useful for:
- Math... | c432ec9286d4b1f47e137d4149e94e833b98d633 | cdbefb5fc77cc6ed87c370fd139be2a232ee3ac3 | diff --git a/app/agent/__init__.py b/app/agent/__init__.py
index 082d91d28..23f26f4c6 100644
--- a/app/agent/__init__.py
+++ b/app/agent/__init__.py
@@ -1,5 +1,6 @@
from app.agent.base import BaseAgent
from app.agent.browser import BrowserAgent
+from app.agent.cot import CoTAgent
from app.agent.mcp import MCPAgent
... | [
"app/agent/__init__.py",
"app/agent/cot.py",
"app/prompt/cot.py"
] | [] | true | ||
FoundationAgents/OpenManus | 861 | issue_to_patch | feat: add chart visualization tools which support png/html output | **Features**
<!-- Describe the features or bug fixes in this PR. For bug fixes, link to the issue. -->
- Feature: Add chart visualization tools to generate chart in png / html type.
**Feature Docs**
<!-- Provide RFC, tutorial, or use case links for significant updates. Optional for minor changes. -->
`app/to... | 8c85ea16a2b5e73820c605d56ce9330f23109159 | 14bf016134c47d696263966597e450f93e781cb3 | diff --git a/.gitignore b/.gitignore
index 857ec7e7f..41dbbf2d8 100644
--- a/.gitignore
+++ b/.gitignore
@@ -197,3 +197,6 @@ cython_debug/
# OSX
.DS_Store
+
+# node
+node_modules
diff --git a/app/agent/data_analysis.py b/app/agent/data_analysis.py
new file mode 100644
index 000000000..8bd28292d
--- /dev/null
+++ b/... | [
".gitignore",
"app/agent/data_analysis.py",
"app/prompt/visualization.py",
"app/tool/chart_visualization/README.md",
"app/tool/chart_visualization/README_zh.md",
"app/tool/chart_visualization/__init__.py",
"app/tool/chart_visualization/chart_visualization.py",
"app/tool/chart_visualization/data_analys... | [
{
"comment": "Please inherit the ToolCallAgent and create a new Agent for using ChartVisualization",
"path": "app/agent/manus.py",
"hunk": "@@ -8,6 +8,7 @@\n from app.tool.browser_use_tool import BrowserUseTool\n from app.tool.python_execute import PythonExecute\n from app.tool.str_replace_editor import... | diff --git a/app/tool/chart_visualization/test/__init__.py b/app/tool/chart_visualization/test/__init__.py
new file mode 100644
index 000000000..e69de29bb
diff --git a/app/tool/chart_visualization/test/simple_chart.py b/app/tool/chart_visualization/test/simple_chart.py
new file mode 100644
index 000000000..66f954733
--... | true | |
FoundationAgents/OpenManus | 861 | comment_to_fix | feat: add chart visualization tools which support png/html output | Examples is not required | 8c85ea16a2b5e73820c605d56ce9330f23109159 | 14bf016134c47d696263966597e450f93e781cb3 | diff --git a/app/tool/chart_visualization/chart_visualization.py b/app/tool/chart_visualization/chart_visualization.py
new file mode 100644
index 000000000..8905c0580
--- /dev/null
+++ b/app/tool/chart_visualization/chart_visualization.py
@@ -0,0 +1,117 @@
+import subprocess
+import json
+import base64
+import pandas a... | [
"app/tool/chart_visualization/chart_visualization.py"
] | [
{
"comment": "Examples is not required ",
"path": "app/tool/chart_visualization/chart_visualization.py",
"hunk": "@@ -0,0 +1,230 @@\n+import subprocess\n+import json\n+import threading\n+import base64\n+import pandas as pd\n+import aiofiles\n+import os\n+from typing import Any, Dict, Hashable\n+from app... | true | ||
FoundationAgents/OpenManus | 861 | comment_to_fix | feat: add chart visualization tools which support png/html output | Examples is not required | 8c85ea16a2b5e73820c605d56ce9330f23109159 | 14bf016134c47d696263966597e450f93e781cb3 | diff --git a/app/tool/chart_visualization/chart_visualization.py b/app/tool/chart_visualization/chart_visualization.py
new file mode 100644
index 000000000..8905c0580
--- /dev/null
+++ b/app/tool/chart_visualization/chart_visualization.py
@@ -0,0 +1,117 @@
+import subprocess
+import json
+import base64
+import pandas a... | [
"app/tool/chart_visualization/chart_visualization.py"
] | [
{
"comment": "Examples is not required",
"path": "app/tool/chart_visualization/chart_visualization.py",
"hunk": "@@ -0,0 +1,230 @@\n+import subprocess\n+import json\n+import threading\n+import base64\n+import pandas as pd\n+import aiofiles\n+import os\n+from typing import Any, Dict, Hashable\n+from app.... | true | ||
FoundationAgents/OpenManus | 861 | comment_to_fix | feat: add chart visualization tools which support png/html output | It's okay to put it here for now, it's best to put it under utils.py | 8c85ea16a2b5e73820c605d56ce9330f23109159 | 14bf016134c47d696263966597e450f93e781cb3 | diff --git a/app/tool/chart_visualization/chart_visualization.py b/app/tool/chart_visualization/chart_visualization.py
new file mode 100644
index 000000000..8905c0580
--- /dev/null
+++ b/app/tool/chart_visualization/chart_visualization.py
@@ -0,0 +1,117 @@
+import subprocess
+import json
+import base64
+import pandas a... | [
"app/tool/chart_visualization/chart_visualization.py"
] | [
{
"comment": "It's okay to put it here for now, it's best to put it under utils.py",
"path": "app/tool/chart_visualization/chart_visualization.py",
"hunk": "@@ -0,0 +1,230 @@\n+import subprocess\n+import json\n+import threading\n+import base64\n+import pandas as pd\n+import aiofiles\n+import os\n+from t... | true | ||
FoundationAgents/OpenManus | 883 | issue_to_patch | 删除合并冲突提示代码 | **Features**
<!-- Describe the features or bug fixes in this PR. For bug fixes, link to the issue. -->
- Feature 1
- Feature 2
**Feature Docs**
<!-- Provide RFC, tutorial, or use case links for significant updates. Optional for minor changes. -->
**Influence**
<!-- Explain the impact of these changes for r... | e218c0655fd6327365eac12ec9440f886a59c529 | 3dd990e554b30475777e4e15bfd18464895d40dd | diff --git a/config/config.example.toml b/config/config.example.toml
index db8045dbc..106279fb4 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -90,4 +90,3 @@ temperature = 0.0 # Controls randomness for vision mod
#cpu_limit = 2.0
#timeout = 300
#network_enabled ... | [
"config/config.example.toml"
] | [] | true | ||
FoundationAgents/OpenManus | 882 | issue_to_patch | Patch/mcp server | d63e88f0892437a6d63e92c4fba1d941d237fcae | 5d18b5dc69142e24383395022815e0d70bdc51b3 | diff --git a/app/bedrock.py b/app/bedrock.py
index 6572a5634..280632931 100644
--- a/app/bedrock.py
+++ b/app/bedrock.py
@@ -1,15 +1,18 @@
-from typing import Dict, List, Literal, Optional, Union
-import boto3
import json
+import sys
import time
import uuid
from datetime import datetime
-import sys
+from typing imp... | [
"app/bedrock.py",
"app/llm.py",
"app/mcp/server.py",
"run_mcp.py"
] | [] | true | |||
FoundationAgents/OpenManus | 772 | issue_to_patch | feat(search): Add configurable fallback engines and retry logic for robust web search | I have some long-running projects, I like to have plenty of steps (a lot more than default) and therefore I need robust web search because they keep failing. I am also unsure about Baidu since I never used it before so I wanted the option to decide what search providers to use and in what order. It will also keep track... | f25ed7d49ec1bd710d3ef71a7da2c74f2c3136b0 | 59a92257be159e252977550c2bc7cdde2fa1f4e7 | diff --git a/app/config.py b/app/config.py
index 011ceb1c1..d2e7e64b0 100644
--- a/app/config.py
+++ b/app/config.py
@@ -37,6 +37,18 @@ class ProxySettings(BaseModel):
class SearchSettings(BaseModel):
engine: str = Field(default="Google", description="Search engine the llm to use")
+ fallback_engines: List[s... | [
"app/config.py",
"app/tool/web_search.py",
"config/config.example.toml"
] | [] | true | ||
FoundationAgents/OpenManus | 862 | issue_to_patch | Add Amazon Bedrock support modular non-intrusive | **Features**
- Added modular and non-intrusive Amazon Bedrock support
- Maintained compatibility with existing codebase through non-intrusive design pattern
- Fix this https://github.com/mannaandpoem/OpenManus/issues/215
**Feature Docs**
https://docs.aws.amazon.com/bedrock/latest/APIReference/welcome.html
*... | d4358ef53792be46697c9178e93873198ee55bed | 2a13cb49f34ab8772ea967c50fca916bdc15f546 | diff --git a/app/bedrock.py b/app/bedrock.py
new file mode 100644
index 000000000..6572a5634
--- /dev/null
+++ b/app/bedrock.py
@@ -0,0 +1,275 @@
+from typing import Dict, List, Literal, Optional, Union
+import boto3
+import json
+import time
+import uuid
+from datetime import datetime
+import sys
+
+# Global variables... | [
"app/bedrock.py",
"app/llm.py",
"config/config.example.toml",
"requirements.txt"
] | [] | true | ||
FoundationAgents/OpenManus | 839 | issue_to_patch | fix(browser_use_tool): reimplement screenshot logics to get JPEG data | **Features**
- reimplement screenshot logics to get JPEG data
| 3c7e378969eba35f17a7547c04c99f366344b7bf | 44243a1b979ed5ee11a4d88085aea439494b611e | diff --git a/app/tool/browser_use_tool.py b/app/tool/browser_use_tool.py
index 7fe8f165f..0158e0753 100644
--- a/app/tool/browser_use_tool.py
+++ b/app/tool/browser_use_tool.py
@@ -1,4 +1,5 @@
import asyncio
+import base64
import json
from typing import Generic, Optional, TypeVar
@@ -552,7 +553,16 @@ async def get... | [
"app/tool/browser_use_tool.py"
] | [] | true | ||
FoundationAgents/OpenManus | 782 | issue_to_patch | Front endAdd page LLM configuration settings | Add page LLM configuration settings
| 38e34219d3109c8704b8d131d7902da7cf64e613 | b63a0301dc2d34cc913156b5486b77aac60c5375 | diff --git a/app.py b/app.py
index d31450872..059600fcc 100644
--- a/app.py
+++ b/app.py
@@ -253,6 +253,61 @@ async def get_task(task_id: str):
return task_manager.tasks[task_id]
+@app.get("/config/status")
+async def check_config_status():
+ config_path = Path(__file__).parent / "config" / "config.toml"
+ ... | [
"app.py",
"static/main.js",
"static/style.css",
"templates/index.html"
] | [] | true | ||
FoundationAgents/OpenManus | 797 | issue_to_patch | Several improvements | **Features**
<!-- Describe the features or bug fixes in this PR. For bug fixes, link to the issue. -->
- Feature 1
- Feature 2
**Feature Docs**
<!-- Provide RFC, tutorial, or use case links for significant updates. Optional for minor changes. -->
**Influence**
<!-- Explain the impact of these changes for r... | b7dcbfecb3f38fb7aa87453acde557209f35d653 | b9df45bc68e8cb995b47ba9d40d75e3d47db2f8c | diff --git a/.github/ISSUE_TEMPLATE/request_new_features.md b/.github/ISSUE_TEMPLATE/request_new_features.md
deleted file mode 100644
index c191adb23..000000000
--- a/.github/ISSUE_TEMPLATE/request_new_features.md
+++ /dev/null
@@ -1,14 +0,0 @@
----
-name: "🤔 Request new features"
-about: Suggest ideas or features you... | [
".github/ISSUE_TEMPLATE/request_new_features.md",
".github/ISSUE_TEMPLATE/request_new_features.yaml",
".github/ISSUE_TEMPLATE/show_me_the_bug.md",
".github/ISSUE_TEMPLATE/show_me_the_bug.yaml",
".github/workflows/pr-autodiff.yaml",
"app/agent/toolcall.py",
"app/llm.py",
"app/tool/file_operators.py"
] | [
{
"comment": "Do not use __init__, use encoding directly as a property of LocalFileOperator\r\nclass LocalFileOperator(FileOperator):\r\n \"\"\"File operations implementation for local filesystem.\"\"\"\r\n encoding: str = \"utf-8\"\r\n",
"path": "app/tool/file_operators.py",
"hunk": "@@ -42,17 +4... | true | ||
FreeRDP/FreeRDP | 12,885 | issue_to_patch | [cache,glyph] tighten bounds checks | 7f5ae2b030500e89dfd346ce6825043f79194062 | c29324750e3cbcba8761f147b7a5235cc686930f | diff --git a/libfreerdp/cache/glyph.c b/libfreerdp/cache/glyph.c
index 1cd5c00cdda7..8bc351ea994f 100644
--- a/libfreerdp/cache/glyph.c
+++ b/libfreerdp/cache/glyph.c
@@ -572,7 +572,7 @@ rdpGlyph* glyph_cache_get(rdpGlyphCache* glyphCache, UINT32 id, UINT32 index)
}
GLYPH_CACHE* cache = &glyphCache->glyphCache[id... | [
"libfreerdp/cache/glyph.c"
] | [] | true | |||
FreeRDP/FreeRDP | 12,884 | issue_to_patch | [codec,color] bound icon alpha mask read to mask size | **Heap over-read in freerdp_image_copy_from_icon_data**
The alpha mask branch bounds `cbBitsMask` against `stride * (nHeight - 1)`, but the per-row walk reads a further `ceil(nWidth / 8)` bytes from that offset, so the last row runs off the end of the mask buffer (allocated to exactly `cbBitsMask` in `update_read_icon... | 51aa80f9e66ebe9703ac2efbc6d0cd1f49472ea5 | 3886a53f8f910986845dcd2022f36c46638ee146 | diff --git a/libfreerdp/codec/color.c b/libfreerdp/codec/color.c
index 5b250c811262..b5a5956b3af1 100644
--- a/libfreerdp/codec/color.c
+++ b/libfreerdp/codec/color.c
@@ -477,11 +477,11 @@ BOOL freerdp_image_copy_from_icon_data(BYTE* WINPR_RESTRICT pDstData, UINT32 Dst
* a multiple of 4 bytes.
*/
const size_... | [
"libfreerdp/codec/color.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,868 | issue_to_patch | xfreerdp switch local window keybaord focus issue
# **To Reproduce**
Steps to reproduce the behavior:
1. under local Gnome, run `xfreerdp` connecting to remote Windows
2. in remote , open a `notepad` in the front
3. click on `xfreerdp`'s title bar ( local side ) , otherwise step 4's alt +tab will be triggered remo... | [client,x11] release normal keys before modifiers | 5bf7c2b50c612bd5fbab7c711f3a415fe88434fb | 84c9ddc7100653354f1ea6b382b6d96de68ace72 | diff --git a/client/X11/xf_keyboard.c b/client/X11/xf_keyboard.c
index 410cc409cd84..5729009a6b0b 100644
--- a/client/X11/xf_keyboard.c
+++ b/client/X11/xf_keyboard.c
@@ -934,7 +934,22 @@ static DWORD get_rdp_scancode_from_x11_keycode(xfContext* xfc, DWORD keycode)
return scancode;
}
-void xf_keyboard_release_all_... | [
"client/X11/xf_keyboard.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,883 | issue_to_patch | Prerelease cleanups | 51aa80f9e66ebe9703ac2efbc6d0cd1f49472ea5 | 2bc5399bc6346d48f735466c01ea9fe5e7d249d1 | diff --git a/include/freerdp/codec/color.h b/include/freerdp/codec/color.h
index e1fad439ca1b..527efedc6e6e 100644
--- a/include/freerdp/codec/color.h
+++ b/include/freerdp/codec/color.h
@@ -352,13 +352,17 @@ FREERDP_API DWORD FreeRDPAreColorFormatsEqualNoAlpha(DWORD first, DWORD second);
/***
*
- * @param pDst... | [
"include/freerdp/codec/color.h",
"libfreerdp/codec/color.c",
"libfreerdp/codec/color.h",
"libfreerdp/core/credssp_auth.c",
"winpr/libwinpr/sspi/NTLM/ntlm.c",
"winpr/libwinpr/sspi/Negotiate/negotiate.c"
] | [] | true | |||
FreeRDP/FreeRDP | 12,877 | issue_to_patch | Allow per-session NTLM workstation name override via rdpSettings
# Is your feature request related to a problem? Please describe.
When using FreeRDP in a proxy, gateway, or containerized environment, the NTLM workstation name sent in the `NTLMSSP_AUTH` message is always derived from `gethostname()` via `GetComputerNa... | Ntlm hostname | d3d46b07bcc126be43a59aeb2598935c83d67e81 | 39a0a4f5706b952d99a42ce697d32ff375b10114 | diff --git a/channels/rdpgfx/rdpgfx_common.h b/channels/rdpgfx/rdpgfx_common.h
index 49f84826607b..3541dee00dd0 100644
--- a/channels/rdpgfx/rdpgfx_common.h
+++ b/channels/rdpgfx/rdpgfx_common.h
@@ -32,7 +32,7 @@
WINPR_ATTR_NODISCARD
FREERDP_LOCAL UINT rdpgfx_read_header(wLog* log, wStream* s, RDPGFX_HEADER* header... | [
"channels/rdpgfx/rdpgfx_common.h",
"include/freerdp/settings_types_private.h",
"libfreerdp/codec/color.c",
"libfreerdp/common/settings_getters.c",
"libfreerdp/common/settings_str.h",
"libfreerdp/core/credssp_auth.c",
"libfreerdp/core/credssp_auth.h",
"libfreerdp/core/test/settings_property_lists.h",
... | [] | diff --git a/libfreerdp/core/test/settings_property_lists.h b/libfreerdp/core/test/settings_property_lists.h
index 7aa3819741bd..8975325c0064 100644
--- a/libfreerdp/core/test/settings_property_lists.h
+++ b/libfreerdp/core/test/settings_property_lists.h
@@ -461,6 +461,7 @@ static const size_t string_list_indices[] = {... | true | |
FreeRDP/FreeRDP | 12,882 | issue_to_patch | [winpr,wtypes] fix WINPR_C23_ENUM_TYPE | Previously erroneously attributed being available with C11. Rename and guard with C23 support | 5117c6360720f18864b1d7da1c3aae14f63ab29a | d4c1bea3cc542f4ba0f2c5d69b4912fc3474381c | diff --git a/include/freerdp/channels/rdpgfx.h b/include/freerdp/channels/rdpgfx.h
index 2dd24409e6e5..2cdd429194fe 100644
--- a/include/freerdp/channels/rdpgfx.h
+++ b/include/freerdp/channels/rdpgfx.h
@@ -103,7 +103,7 @@ typedef struct
/**
* Capability Sets [MS-RDPEGFX] 2.2.3
*/
-typedef enum WINPR_C11_ENUM_TYPE... | [
"include/freerdp/channels/rdpgfx.h",
"winpr/include/winpr/wtypes.h"
] | [] | true | ||
FreeRDP/FreeRDP | 12,879 | issue_to_patch | Expose the correlationId in settings | Before this patch a random correlationId was generated stored locally for RD gateway connections, but sometime you may want to reuse it for some other component. So these changes make it stored in settings. | 0f2b091c960a2bb5aaa8aec01cd6726ea37d9d9f | 9a371bccd053ad7b708031fcbd2c6e85137ee968 | diff --git a/include/freerdp/settings_types_private.h b/include/freerdp/settings_types_private.h
index b7400df5782c..331203189008 100644
--- a/include/freerdp/settings_types_private.h
+++ b/include/freerdp/settings_types_private.h
@@ -78,7 +78,10 @@ struct rdp_settings
SETTINGS_DEPRECATED(ALIGN64 char* AadServerHostn... | [
"include/freerdp/settings_types_private.h",
"libfreerdp/common/settings_getters.c",
"libfreerdp/common/settings_str.h",
"libfreerdp/core/gateway/http.c",
"libfreerdp/core/gateway/rdg.c",
"libfreerdp/core/gateway/rpc.c",
"libfreerdp/core/gateway/rts.c",
"libfreerdp/core/gateway/rts.h",
"libfreerdp/co... | [] | diff --git a/libfreerdp/core/test/settings_property_lists.h b/libfreerdp/core/test/settings_property_lists.h
index 127a6b0aa186..7aa3819741bd 100644
--- a/libfreerdp/core/test/settings_property_lists.h
+++ b/libfreerdp/core/test/settings_property_lists.h
@@ -19,7 +19,6 @@ static const size_t bool_list_indices[] = {
F... | true | |
FreeRDP/FreeRDP | 12,881 | issue_to_patch | [cache,glyph] bound offset read to buffer length | **Out-of-bounds read in update_glyph_offset**
The first glyph offset byte is taken from `data[index]` before `index` is compared against the buffer length; only the following extended-offset read is bounded. When a glyph fragment ends on a glyph op, `update_process_glyph_fragments` calls the helper with `index == leng... | 0cc666099387baf1de1664727ee99f7bfacbb809 | 429ff2ca859926c085eb1b3080a888bf8e62382c | diff --git a/libfreerdp/cache/glyph.c b/libfreerdp/cache/glyph.c
index 374c6151f00a..1cd5c00cdda7 100644
--- a/libfreerdp/cache/glyph.c
+++ b/libfreerdp/cache/glyph.c
@@ -47,6 +47,13 @@ static UINT32 update_glyph_offset(const BYTE* data, size_t length, UINT32 index,
{
if ((ulCharInc == 0) && (!(flAccel & SO_CHAR_INC... | [
"libfreerdp/cache/glyph.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,876 | issue_to_patch | Error while processing GFX cmdId: RDPGFX_CMDID_UNKNOWN (0x0019)
# **Describe the bug**
sdl-freerdp3 connects to a remote desktop but showing black window. The log contains the following errors:
```
[11:57:37:433] [4804:000012f1] [ERROR][com.freerdp.channels.rdpgfx.client] - [rdpgfx_recv_pdu]: Error while processing... | [channels,gfx] extract remaining header length | * extract remaining header length from rdpgfx_read_header
* use that to skip unimplemented cmdid packets | 0f2b091c960a2bb5aaa8aec01cd6726ea37d9d9f | 2b81c4663f43914a82cce56dd91ab9ebfbecc653 | diff --git a/channels/rdpgfx/client/rdpgfx_main.c b/channels/rdpgfx/client/rdpgfx_main.c
index 642f7baddb5c..bb2c145bfea7 100644
--- a/channels/rdpgfx/client/rdpgfx_main.c
+++ b/channels/rdpgfx/client/rdpgfx_main.c
@@ -2071,14 +2071,14 @@ static UINT rdpgfx_recv_pdu(GENERIC_CHANNEL_CALLBACK* callback, wStream* s)
W... | [
"channels/rdpgfx/client/rdpgfx_main.c",
"channels/rdpgfx/rdpgfx_common.c",
"channels/rdpgfx/rdpgfx_common.h",
"channels/rdpgfx/server/rdpgfx_main.c"
] | [
{
"comment": "I think the name is a bit misleading. The returned value is not the remaining *header* length. It is the remaining PDU length.",
"path": "channels/rdpgfx/rdpgfx_common.c",
"hunk": "@@ -32,11 +32,15 @@\n *\n * @return 0 on success, otherwise a Win32 error code\n */\n-UINT rdpgfx_read_hea... | true | |
FreeRDP/FreeRDP | 12,876 | comment_to_fix | [channels,gfx] extract remaining header length | I think the name is a bit misleading. The returned value is not the remaining *header* length. It is the remaining PDU length. | 0f2b091c960a2bb5aaa8aec01cd6726ea37d9d9f | 2b81c4663f43914a82cce56dd91ab9ebfbecc653 | diff --git a/channels/rdpgfx/rdpgfx_common.c b/channels/rdpgfx/rdpgfx_common.c
index 12a4e42cf3ec..480d0419ecbc 100644
--- a/channels/rdpgfx/rdpgfx_common.c
+++ b/channels/rdpgfx/rdpgfx_common.c
@@ -32,11 +32,14 @@
*
* @return 0 on success, otherwise a Win32 error code
*/
-UINT rdpgfx_read_header(wLog* log, wStre... | [
"channels/rdpgfx/rdpgfx_common.c"
] | [
{
"comment": "I think the name is a bit misleading. The returned value is not the remaining *header* length. It is the remaining PDU length.",
"path": "channels/rdpgfx/rdpgfx_common.c",
"hunk": "@@ -32,11 +32,15 @@\n *\n * @return 0 on success, otherwise a Win32 error code\n */\n-UINT rdpgfx_read_hea... | true | ||
FreeRDP/FreeRDP | 12,876 | comment_to_fix | [channels,gfx] extract remaining header length | same here, better names would be `remainingPduLength` or `pduBodyLength` | 0f2b091c960a2bb5aaa8aec01cd6726ea37d9d9f | 2b81c4663f43914a82cce56dd91ab9ebfbecc653 | diff --git a/channels/rdpgfx/client/rdpgfx_main.c b/channels/rdpgfx/client/rdpgfx_main.c
index 642f7baddb5c..bb2c145bfea7 100644
--- a/channels/rdpgfx/client/rdpgfx_main.c
+++ b/channels/rdpgfx/client/rdpgfx_main.c
@@ -2071,14 +2071,14 @@ static UINT rdpgfx_recv_pdu(GENERIC_CHANNEL_CALLBACK* callback, wStream* s)
W... | [
"channels/rdpgfx/client/rdpgfx_main.c"
] | [
{
"comment": "same here, better names would be `remainingPduLength` or `pduBodyLength`",
"path": "channels/rdpgfx/client/rdpgfx_main.c",
"hunk": "@@ -2071,14 +2071,14 @@ static UINT rdpgfx_recv_pdu(GENERIC_CHANNEL_CALLBACK* callback, wStream* s)\n \n \tWINPR_ASSERT(gfx);\n \n-\tUINT error = rdpgfx_read_... | true | ||
FreeRDP/FreeRDP | 12,872 | issue_to_patch | Error while processing GFX cmdId: RDPGFX_CMDID_UNKNOWN (0x0019)
# **Describe the bug**
sdl-freerdp3 connects to a remote desktop but showing black window. The log contains the following errors:
```
[11:57:37:433] [4804:000012f1] [ERROR][com.freerdp.channels.rdpgfx.client] - [rdpgfx_recv_pdu]: Error while processing... | [channels,gfx] add RDPGFX_CMDID_PROTECT_SURFACE and RDPGFX_CMDID_WATE… | …RMARK | aed276db1bfc7a46b6c4afc7ca9d1f4fe6a68e16 | 46cd28735ecd00952394cfedaff51475548368f7 | diff --git a/channels/rdpgfx/client/rdpgfx_main.c b/channels/rdpgfx/client/rdpgfx_main.c
index 834bb1819043..642f7baddb5c 100644
--- a/channels/rdpgfx/client/rdpgfx_main.c
+++ b/channels/rdpgfx/client/rdpgfx_main.c
@@ -2078,6 +2078,7 @@ static UINT rdpgfx_recv_pdu(GENERIC_CHANNEL_CALLBACK* callback, wStream* s)
... | [
"channels/rdpgfx/client/rdpgfx_main.c",
"include/freerdp/channels/rdpgfx.h",
"libfreerdp/utils/gfx.c"
] | [
{
"comment": "`header.pduLength - start` is incorrect. Should be `header.pduLength - (start-beg)` or maybe event better: `if (!Stream_SetPosition(s, (beg + header.pduLength)))` (as used below already)",
"path": "channels/rdpgfx/client/rdpgfx_main.c",
"hunk": "@@ -2238,6 +2239,14 @@ static UINT rdpgfx_re... | true | |
FreeRDP/FreeRDP | 12,875 | issue_to_patch | Ci update qa | 5044d5390035c6fd9a36ad885192d97d21e8a92d | 8ede6545803e3332969ebdb800777ca1e471d136 | diff --git a/ci/cmake-preloads/config-qa-static.cmake b/ci/cmake-preloads/config-qa-static.cmake
index 109cc2d82650..58982eb76eab 100644
--- a/ci/cmake-preloads/config-qa-static.cmake
+++ b/ci/cmake-preloads/config-qa-static.cmake
@@ -1,6 +1,7 @@
message("PRELOADING cache")
set(CMAKE_C_STANDARD 23 CACHE STRING "prelo... | [
"ci/cmake-preloads/config-qa-static.cmake",
"ci/cmake-preloads/config-qa.cmake",
"include/freerdp/channels/rdpgfx.h",
"winpr/include/winpr/wtypes.h",
"winpr/libwinpr/sspi/Schannel/schannel.c"
] | [] | true | |||
FreeRDP/FreeRDP | 12,874 | issue_to_patch | Sspi separate ansi unicode | bd2a9a90cbdd8a0a18f470ac7d1b261ebc1892fc | 19d5ba01544c8a6a6d19b9aeb3791038579925fb | diff --git a/.github/workflows/timezone-update.yml b/.github/workflows/timezone-update.yml
index 8be7e4d4706e..a326a98ffe71 100644
--- a/.github/workflows/timezone-update.yml
+++ b/.github/workflows/timezone-update.yml
@@ -24,7 +24,7 @@ jobs:
with:
dotnet-version: 8.0.x
- name: Configure CMake
- ... | [
".github/workflows/timezone-update.yml",
"winpr/include/winpr/sspi.h",
"winpr/libwinpr/crypto/test/TestCryptoCipher.c",
"winpr/libwinpr/sspi/Kerberos/kerberos.c",
"winpr/libwinpr/sspi/NTLM/ntlm.c",
"winpr/libwinpr/sspi/NTLM/ntlm.h",
"winpr/libwinpr/sspi/NTLM/ntlm_av_pairs.c",
"winpr/libwinpr/sspi/NTLM... | [] | diff --git a/winpr/libwinpr/crypto/test/TestCryptoCipher.c b/winpr/libwinpr/crypto/test/TestCryptoCipher.c
index b55ecba68766..6057d2c0f57d 100644
--- a/winpr/libwinpr/crypto/test/TestCryptoCipher.c
+++ b/winpr/libwinpr/crypto/test/TestCryptoCipher.c
@@ -23,10 +23,17 @@ static BOOL test_crypto_cipher_aes_128_cbc(BOOL e... | true | ||
FreeRDP/FreeRDP | 12,873 | issue_to_patch | Bounds fixes | 3248c0c029eb2b7a89666a452a0dbe0630787341 | f5df5263dc164d5bc8cb1ac2c44cb57201d2fe94 | diff --git a/libfreerdp/codec/h264.c b/libfreerdp/codec/h264.c
index 3b837601cc45..ce7776b406cd 100644
--- a/libfreerdp/codec/h264.c
+++ b/libfreerdp/codec/h264.c
@@ -495,14 +495,24 @@ static BOOL avc444_ensure_buffer(H264_CONTEXT* h264, DWORD nDstHeight)
if (pad != 0)
padDstHeight += 16 - pad;
- if ((piMainStri... | [
"libfreerdp/codec/h264.c",
"libfreerdp/codec/h264_ffmpeg.c",
"libfreerdp/codec/h264_mediacodec.c",
"libfreerdp/codec/h264_mf.c",
"libfreerdp/codec/h264_openh264.c",
"libfreerdp/core/gateway/rpc.c",
"libfreerdp/core/gateway/rpc_bind.c",
"libfreerdp/core/gateway/rpc_client.c",
"libfreerdp/utils/gfx.c"... | [] | true | |||
FreeRDP/FreeRDP | 12,871 | issue_to_patch | Azure undocumented stuff | @hardening did some refactoring with gfx channel and added some of the undocumented capabilities.
might help you with https://github.com/FreeRDP/FreeRDP/issues/12846 | dde4b074610b6fdcd4500f6e540e9b4babc4c1c2 | a57a1749fb9671e2e8d97afaf2c39f7436a361f9 | diff --git a/channels/rdpgfx/client/rdpgfx_main.c b/channels/rdpgfx/client/rdpgfx_main.c
index 7114405a4d39..834bb1819043 100644
--- a/channels/rdpgfx/client/rdpgfx_main.c
+++ b/channels/rdpgfx/client/rdpgfx_main.c
@@ -263,10 +263,23 @@ static BOOL rdpgfx_is_capability_filtered(RDPGFX_PLUGIN* gfx, UINT32 caps)
#if def... | [
"channels/rdpgfx/client/rdpgfx_main.c",
"cmake/ConfigOptions.cmake",
"include/freerdp/channels/rdpgfx.h",
"include/freerdp/utils/gfx.h",
"libfreerdp/gdi/gfx.c",
"libfreerdp/gdi/test/CMakeLists.txt",
"libfreerdp/gdi/test/TestGdiGfx.c",
"libfreerdp/utils/gfx.c",
"packaging/deb/freerdp-nightly/rules",
... | [] | diff --git a/libfreerdp/gdi/test/CMakeLists.txt b/libfreerdp/gdi/test/CMakeLists.txt
index 8ae813f0e60c..136a1be09a18 100644
--- a/libfreerdp/gdi/test/CMakeLists.txt
+++ b/libfreerdp/gdi/test/CMakeLists.txt
@@ -14,6 +14,7 @@ set(${MODULE_PREFIX}_TESTS
TestGdiCreate.c
TestGdiEllipse.c
TestGdiClip.c
+ T... | true | |
FreeRDP/FreeRDP | 12,870 | issue_to_patch | [core,update] filter out unused/unknown | update_dump_stats dumps a lot of variables on termination, many of which are not used by most. Filter these out unless the operation was actually used during the connection. | 1e090667465df8f5be6a03bda68a4a98e79a0295 | ea860f92077eae1920cddc704a42a61d5f212e3b | diff --git a/libfreerdp/core/update.c b/libfreerdp/core/update.c
index 984105824a51..f962d2dc9065 100644
--- a/libfreerdp/core/update.c
+++ b/libfreerdp/core/update.c
@@ -3680,6 +3680,10 @@ void update_dump_stats(rdpUpdate* update)
const char* name = rdp_stats_name_for_index(x);
const uint64_t val = rdp_stats_val... | [
"libfreerdp/core/update.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,865 | issue_to_patch | Proxy client context | b7135a9a01b78ebb9763117c4991235f9cfcd5da | 9def8830006aa60b1c8c29fc59e8a68e2a3a6b06 | diff --git a/include/freerdp/server/proxy/proxy_context.h b/include/freerdp/server/proxy/proxy_context.h
index 62235edb0506..835416df3d05 100644
--- a/include/freerdp/server/proxy/proxy_context.h
+++ b/include/freerdp/server/proxy/proxy_context.h
@@ -75,19 +75,6 @@ extern "C"
/**
* Wraps rdpContext and holds the s... | [
"include/freerdp/server/proxy/proxy_context.h",
"server/proxy/channels/pf_channel_drdynvc.c",
"server/proxy/channels/pf_channel_rdpdr.c",
"server/proxy/modules/bitmap-filter/bitmap-filter.cpp",
"server/proxy/pf_channel.c",
"server/proxy/pf_client.c",
"server/proxy/pf_client.h",
"server/proxy/pf_contex... | [] | true | |||
FreeRDP/FreeRDP | 12,866 | issue_to_patch | Warning fixes | b7135a9a01b78ebb9763117c4991235f9cfcd5da | 2137845abaef1a8140c63d36ed139f13f984ed49 | diff --git a/channels/rdpgfx/client/rdpgfx_main.c b/channels/rdpgfx/client/rdpgfx_main.c
index a80d5b46bc7a..7114405a4d39 100644
--- a/channels/rdpgfx/client/rdpgfx_main.c
+++ b/channels/rdpgfx/client/rdpgfx_main.c
@@ -91,14 +91,14 @@ uint64_t rdpgfx_stats_value_for_index(RdpgfxClientContext* context, size_t index
re... | [
"channels/rdpgfx/client/rdpgfx_main.c",
"libfreerdp/codec/dsp.c",
"libfreerdp/core/update.c",
"winpr/libwinpr/crypto/md4.c",
"winpr/libwinpr/crypto/md5.c"
] | [] | true | |||
FreeRDP/FreeRDP | 12,860 | issue_to_patch | codec stats | add statistics counters to client decoding engine. | 28492c7e0bd1f41c9fb3e4c7857a4ad2892514df | 18dd1bbace7f38a599c8e03f89176ff5aaf62fc5 | diff --git a/channels/rdpgfx/client/rdpgfx_codec.c b/channels/rdpgfx/client/rdpgfx_codec.c
index 1260c7321fbb..cfc619bab339 100644
--- a/channels/rdpgfx/client/rdpgfx_codec.c
+++ b/channels/rdpgfx/client/rdpgfx_codec.c
@@ -118,65 +118,6 @@ static UINT rdpgfx_read_h264_metablock(WINPR_ATTR_UNUSED RDPGFX_PLUGIN* gfx, wSt... | [
"channels/rdpgfx/client/rdpgfx_codec.c",
"channels/rdpgfx/client/rdpgfx_main.c",
"channels/rdpgfx/client/rdpgfx_main.h",
"include/freerdp/channels/rdpgfx.h",
"include/freerdp/client/rdpgfx.h",
"include/freerdp/update.h",
"libfreerdp/core/connection.c",
"libfreerdp/core/fastpath.c",
"libfreerdp/core/... | [] | true | ||
FreeRDP/FreeRDP | 12,864 | issue_to_patch | [channels,audin] fix iOS and mac backends | Fix misleading log messages | 10a002d1d6ae904a6ffd6debf1630f1278908d99 | 62dd30da2e3a492d651efa81f600a4365c84b56a | diff --git a/channels/audin/client/ios/audin_ios.m b/channels/audin/client/ios/audin_ios.m
index e0682c6f79d2..138b94992b95 100644
--- a/channels/audin/client/ios/audin_ios.m
+++ b/channels/audin/client/ios/audin_ios.m
@@ -181,7 +181,10 @@ static UINT audin_ios_close(IAudinDevice *device)
AudinIosDevice *ios = (Audin... | [
"channels/audin/client/ios/audin_ios.m",
"channels/audin/client/mac/audin_mac.m"
] | [] | true | ||
FreeRDP/FreeRDP | 12,862 | issue_to_patch | [core,nego] bound cookie tag check to remaining length | **Out-of-bounds read in nego_read_request_token_or_cookie**
When a server parses the optional routing token or cookie of an X.224 Connection Request, the only guard guarantees 15 remaining bytes, but the first `memcmp` against `"Cookie: mstshash="` reads 17, so a request whose token region is 15 or 16 bytes long reads... | f0763688b1c9c6fc315c71467f6c42a42e250c6d | 68183b460d125972be22e7cac3b06e6f9ee83077 | diff --git a/libfreerdp/core/nego.c b/libfreerdp/core/nego.c
index 1dd385276e27..25fd8a0f2464 100644
--- a/libfreerdp/core/nego.c
+++ b/libfreerdp/core/nego.c
@@ -902,7 +902,7 @@ static BOOL nego_read_request_token_or_cookie(rdpNego* nego, wStream* s)
if (remain < 15)
return TRUE;
- if (memcmp(Stream_ConstPointe... | [
"libfreerdp/core/nego.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,834 | issue_to_patch | Fix copying multiple items of the same type between xfreerdp sessions | # What is broken?
With two xfreerdp sessions running, copying text from one to the other always pastes the first copied text, ignoring any text that is copied after it. It also happens on other media types.
# Reproducing
- Open 2 xfreerdp sessions
- open text editors in both sessions
- in the first session, writ... | 5ea7306dd4875cf1f52cef65fbd30936c626973a | 36342a5f7e4757a699921fbbbc816173bea5e173 | diff --git a/client/X11/xf_cliprdr.c b/client/X11/xf_cliprdr.c
index 033a2bf0778e..cede0d3df96d 100644
--- a/client/X11/xf_cliprdr.c
+++ b/client/X11/xf_cliprdr.c
@@ -135,9 +135,6 @@ struct xf_clipboard
int xfixes_error_base;
BOOL xfixes_supported;
- /* last sent data */
- CLIPRDR_FORMAT* lastSentFormats;
- UINT3... | [
"client/X11/xf_cliprdr.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,858 | issue_to_patch | [core,event] add StateChanged event | * Define new StateChanged event type
* Trigger new event whenever the connection state changes | 8649e5e462bf1949312e2245996a255e3a407aa8 | d6f4da22c54d9d578fe020fea7b5d291af9d5c01 | diff --git a/include/freerdp/event.h b/include/freerdp/event.h
index a0f331378822..f1cd9bd663c8 100644
--- a/include/freerdp/event.h
+++ b/include/freerdp/event.h
@@ -145,6 +145,15 @@ extern "C"
\ref messageID */
DEFINE_EVENT_END(UserNotification)
+ DEFINE_EVENT_BEGIN(StateChan... | [
"include/freerdp/event.h",
"libfreerdp/core/connection.c",
"libfreerdp/core/freerdp.c",
"winpr/include/winpr/input.h",
"winpr/libwinpr/input/keycode.c",
"winpr/libwinpr/input/scancode.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,848 | issue_to_patch | Fix(wfreerdp): Refresh Windows frame after fullscreen restore | ### Problem
Run wfreerdp with /f and /floatbar, /smart-sizing, and leave the full screen with the floatbar restore button, it will not refresh the window frame, so you can only switch through the taskbar to brush the frame.
```cmdline: .\wfreerdp.exe /v:[host]:[port] /p:[password] /u:[username] /f /floatbar /smar... | d0af18df6a8f37b4a7e6c271cea0fd2273d14a68 | 5615b8d174290f2dafcc1bd5997d3e118b6814d1 | diff --git a/client/Windows/wf_gdi.c b/client/Windows/wf_gdi.c
index 5aa756f5163d..337d355912d9 100644
--- a/client/Windows/wf_gdi.c
+++ b/client/Windows/wf_gdi.c
@@ -421,7 +421,7 @@ void wf_resize_window(wfContext* wfc)
xpos = wfc->client_x;
ypos = wfc->client_y;
}
- SetWindowPos(wfc->hwnd, HWND_TOP, xpos,... | [
"client/Windows/wf_gdi.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,849 | issue_to_patch | Restore fullscreen when maximizing a toggled fullscreen window | ### Full screen experience
When a Windows client session starts in fullscreen mode and is toggled back to
windowed mode, pressing the window maximize button should restore fullscreen
instead of only maximizing the decorated window (like mstsc). | d0af18df6a8f37b4a7e6c271cea0fd2273d14a68 | 17903784bc22ecda241031a0d9fbe0aac31d3f62 | diff --git a/client/Windows/wf_event.c b/client/Windows/wf_event.c
index 0bda81c38220..fb08a93edb45 100644
--- a/client/Windows/wf_event.c
+++ b/client/Windows/wf_event.c
@@ -753,6 +753,12 @@ LRESULT CALLBACK wf_event_proc(HWND hWnd, UINT Msg, WPARAM wParam, LPARAM lParam
{
freerdp_client_encomsp_set_control... | [
"client/Windows/wf_event.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,857 | issue_to_patch | Codec checks | 937713cd0c925b4f8e169b95b11c690b9419b5c7 | dcba567468f7266b3b520274376c2b5b500ac444 | diff --git a/libfreerdp/codec/sse/nsc_sse2.c b/libfreerdp/codec/sse/nsc_sse2.c
index d72579800d3b..5480ab1917da 100644
--- a/libfreerdp/codec/sse/nsc_sse2.c
+++ b/libfreerdp/codec/sse/nsc_sse2.c
@@ -380,53 +380,54 @@ static BOOL nsc_encode_argb_to_aycocg_sse2(NSC_CONTEXT* context, const BYTE* dat
return TRUE;
}
-s... | [
"libfreerdp/codec/sse/nsc_sse2.c"
] | [] | true | |||
FreeRDP/FreeRDP | 12,856 | issue_to_patch | [core,gateway] validate auth blob length in rdg_process_extauth_sspi | **Missing length check in rdg_process_extauth_sspi**
A malicious or intermediary RDG gateway can send a PKT_TYPE_EXTENDED_AUTH_MSG whose declared `authBlobLen` is larger than the data actually received, and the handler then `malloc`s that size and `Stream_Read`s it straight from the packet buffer with no validation, r... | 937713cd0c925b4f8e169b95b11c690b9419b5c7 | b92d9112577513ac139854e39b89d1ac1988739d | diff --git a/libfreerdp/core/gateway/rdg.c b/libfreerdp/core/gateway/rdg.c
index 38caa5094c47..f786b7768ee2 100644
--- a/libfreerdp/core/gateway/rdg.c
+++ b/libfreerdp/core/gateway/rdg.c
@@ -1011,6 +1011,9 @@ static BOOL rdg_process_extauth_sspi(rdpRdg* rdg, wStream* s)
WINPR_ASSERT(rdg);
+ if (!Stream_CheckAndLo... | [
"libfreerdp/core/gateway/rdg.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,855 | issue_to_patch | cliprdr server: infinite PDU reprocessing loop / 100% CPU after 07e717d23
# **Describe the bug**
The cliprdr server channel enters an infinite loop after handling a single clipboard PDU. cliprdr_server_read() (channels/cliprdr/server/cliprdr_main.c) processes one PDU and sets cliprdr->totalExpectedBytes = 0, but neve... | [channels,cliprdr] reset stream after use | 4c522cb9bcd6ec9cb7d521f3c5fd0b345f669664 | 95ce157b1fa98f8b1631efffa6d2cfdb266d4b26 | diff --git a/channels/cliprdr/server/cliprdr_main.c b/channels/cliprdr/server/cliprdr_main.c
index e8344d601f93..ede43ac80b5f 100644
--- a/channels/cliprdr/server/cliprdr_main.c
+++ b/channels/cliprdr/server/cliprdr_main.c
@@ -1216,6 +1216,10 @@ static UINT cliprdr_server_read(CliprdrServerContext* context)
return ... | [
"channels/cliprdr/server/cliprdr_main.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,847 | issue_to_patch | fix(client/SDL): do not treat an unrecognized mouse button as fatal | ## Summary
`sdl_run()` treats *any* `handleEvent()` returning `false` as fatal and aborts
the connection:
```cpp
if (!sdl->handleEvent(windowEvent))
throw ErrorMsg{ -1, windowEvent.type, "sdl->handleEvent" };
```
The mouse-button handler returns `FALSE` for any button outside 1–5. SDL maps
unrecognized buttons a... | d0af18df6a8f37b4a7e6c271cea0fd2273d14a68 | 7818674b637cf0671c7bbcf88f9c16669fe28d0a | diff --git a/client/SDL/SDL2/sdl_touch.cpp b/client/SDL/SDL2/sdl_touch.cpp
index d9e4fd210bf2..5130fcaa1e51 100644
--- a/client/SDL/SDL2/sdl_touch.cpp
+++ b/client/SDL/SDL2/sdl_touch.cpp
@@ -279,5 +279,5 @@ BOOL sdl_handle_mouse_button(SdlContext* sdl, const SDL_MouseButtonEvent* ev)
else if ((xflags & (~PTR_XFLAGS_D... | [
"client/SDL/SDL2/sdl_touch.cpp",
"client/SDL/SDL3/sdl_touch.cpp"
] | [] | true | ||
FreeRDP/FreeRDP | 12,830 | issue_to_patch | [channels,rdpsnd] skip unusable playback backend during selection | ## What this does
On a Linux host without OSS (no `/dev/dsp`), the `oss` rdpsnd client backend still registered a playback device. `rdpsnd_process_connect` selects the first backend that registers a device, so `oss` got selected even though it can't open one. The failure only surfaced later: the first audio the server... | 6ba1b2da02fa560c2f8f0305d55e7d1d1730c0a2 | 72c7ef01210f12e82e3a429461334214e874ea13 | diff --git a/channels/rdpsnd/client/oss/rdpsnd_oss.c b/channels/rdpsnd/client/oss/rdpsnd_oss.c
index 2c872ad0b5ac..229260cfccdb 100644
--- a/channels/rdpsnd/client/oss/rdpsnd_oss.c
+++ b/channels/rdpsnd/client/oss/rdpsnd_oss.c
@@ -207,16 +207,24 @@ static void rdpsnd_oss_open_mixer(rdpsndOssPlugin* oss)
}
}
+/* Bu... | [
"channels/rdpsnd/client/oss/rdpsnd_oss.c",
"channels/rdpsnd/client/rdpsnd_main.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,845 | issue_to_patch | winpr/input: Fix numpad mapping for japanese keyboards | ```
Currently, when pressing any numpad key on japanese keyboards with
gnome-remote-desktop, no number is entered regardless of the numlock
setting. The reason seems to be that those keys are hard coded to
VK_HOME, VK_UP, VK_LEFT, etc..
To fix this issue, use the dedicated virtual keycode values for the
numpad, l... | 96512bfc18b27497ffa19e28dda6ff5c29bae56e | af9900bf2f9af626a3405b4ed09e8a223a278ae0 | diff --git a/winpr/include/winpr/input.h b/winpr/include/winpr/input.h
index fd13ce6cf49a..f926c9dea676 100644
--- a/winpr/include/winpr/input.h
+++ b/winpr/include/winpr/input.h
@@ -621,19 +621,19 @@
#define KBD7_T44 VK_F10
#define KBD7_T45 VK_NUMLOCK
#define KBD7_T46 VK_SCROLL
-#define KBD7_T47 VK_HOME
-#define KB... | [
"winpr/include/winpr/input.h"
] | [] | true | ||
FreeRDP/FreeRDP | 12,836 | issue_to_patch | Japanese pipe "|" key not working on gnome-remote-desktop
# **Describe the bug**
On my japanese laptop keyboard, I have a pipe/JPY/dash key next the backspace key ([which is pretty common in Japan](https://www.bing.com/images/search?q=japanese+keyboard&form=HDRSC3&first=1)):
<img width="803" height="400" alt="Image"... | [winpr,input] complete japanese keyboard mapping | 1c1f2c48d569865eda36f572a13bcc54902ed484 | 0f7e49a78ab1b6f9bbcb18a5a67d9c8076d9a891 | diff --git a/client/Android/cmake/ExternalUriparser.cmake b/client/Android/cmake/ExternalUriparser.cmake
index 5c44174c4f25..4a7688760adb 100644
--- a/client/Android/cmake/ExternalUriparser.cmake
+++ b/client/Android/cmake/ExternalUriparser.cmake
@@ -1,13 +1,13 @@
include(ExternalProject)
-set(URIPARSER_VERSION "1.0... | [
"client/Android/cmake/ExternalUriparser.cmake",
"packaging/flatpak/modules/uriparser.json",
"scripts/bundle-mac-os.sh",
"scripts/mingw.sh",
"winpr/include/winpr/input.h",
"winpr/libwinpr/input/CMakeLists.txt",
"winpr/libwinpr/input/keycode.c",
"winpr/libwinpr/input/scancode.c",
"winpr/libwinpr/input... | [] | diff --git a/winpr/libwinpr/input/test/CMakeLists.txt b/winpr/libwinpr/input/test/CMakeLists.txt
new file mode 100644
index 000000000000..2b22e766cd3a
--- /dev/null
+++ b/winpr/libwinpr/input/test/CMakeLists.txt
@@ -0,0 +1,27 @@
+set(MODULE_NAME "TestWinPRInput")
+set(MODULE_PREFIX "TEST_WINPR_INPUT")
+
+disable_warnin... | true | |
FreeRDP/FreeRDP | 12,838 | issue_to_patch | [cmake] fix use of pkg_check_module | * Use PkgConf::<prefix> imported targets
* Use IMPORTED_TARGET GLOBAL | 0a941da09f05ac81da13d3a7492bf71bab8f3a6f | 562688276e02380e711446d64844df5c6bdcd85c | diff --git a/client/common/CMakeLists.txt b/client/common/CMakeLists.txt
index dab4e5d3d763..79b2700cf3d5 100644
--- a/client/common/CMakeLists.txt
+++ b/client/common/CMakeLists.txt
@@ -54,12 +54,11 @@ option(WITH_FUSE "Build clipboard with FUSE file copy support" ${OPT_FUSE_DEFAUL
if(WITH_FUSE)
find_package(PkgCo... | [
"client/common/CMakeLists.txt",
"libfreerdp/CMakeLists.txt",
"winpr/libwinpr/CMakeLists.txt",
"winpr/libwinpr/utils/CMakeLists.txt"
] | [] | true | ||
FreeRDP/FreeRDP | 12,837 | issue_to_patch | [cmake] replace find_package(GLOBAL) | The feature requires CMake >= 3.24.0
Use set_target_properties(target PROPERTIES IMPORTED_GLOBAL TRUE) instead | 5ea7306dd4875cf1f52cef65fbd30936c626973a | 1cc7951138d50b8b153242a88376ea81ed732435 | diff --git a/libfreerdp/CMakeLists.txt b/libfreerdp/CMakeLists.txt
index 568a2daf1ac7..75186d216941 100644
--- a/libfreerdp/CMakeLists.txt
+++ b/libfreerdp/CMakeLists.txt
@@ -158,8 +158,9 @@ endif()
option(WITH_OPUS "compile with opus codec support" ${OPUS_DEFAULT})
if(WITH_OPUS)
- find_package(Opus GLOBAL)
+ fin... | [
"libfreerdp/CMakeLists.txt",
"winpr/libwinpr/utils/CMakeLists.txt"
] | [] | true | ||
FreeRDP/FreeRDP | 12,831 | issue_to_patch | Tidy | 887f7304802c308661546fe720817e0fd5f6d433 | e8ff42d26a4a9778e9acf450e641e2e1800b5d39 | diff --git a/client/SDL/SDL3/sdl_context.hpp b/client/SDL/SDL3/sdl_context.hpp
index 482d84b0e3ed..ab67f4736d14 100644
--- a/client/SDL/SDL3/sdl_context.hpp
+++ b/client/SDL/SDL3/sdl_context.hpp
@@ -20,7 +20,6 @@
#include <map>
#include <memory>
-#include <mutex>
#include <sstream>
#include <vector>
#include <mu... | [
"client/SDL/SDL3/sdl_context.hpp",
"libfreerdp/codec/h264_ffmpeg.c"
] | [] | true | |||
FreeRDP/FreeRDP | 12,828 | issue_to_patch | [channels,rdpgfx] fix server frame command returning success on write failure | ## Summary
`rdpgfx_send_surface_frame_command()` (channels/rdpgfx/server/rdpgfx_main.c) can return `CHANNEL_RC_OK` (success) to its caller even when serializing the frame PDU failed.
`error` is initialized to `CHANNEL_RC_OK` and is only ever assigned a meaningful value by `rdpgfx_server_packet_init_header()` and `rdp... | 6ba1b2da02fa560c2f8f0305d55e7d1d1730c0a2 | 8d991639a6cebcfdf572d9346d464989c1df765e | diff --git a/channels/rdpgfx/server/rdpgfx_main.c b/channels/rdpgfx/server/rdpgfx_main.c
index 6dade2c31d6f..21e4501b79c6 100644
--- a/channels/rdpgfx/server/rdpgfx_main.c
+++ b/channels/rdpgfx/server/rdpgfx_main.c
@@ -952,7 +952,10 @@ rdpgfx_send_surface_frame_command(RdpgfxServerContext* context, const RDPGFX_SUR
... | [
"channels/rdpgfx/server/rdpgfx_main.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,821 | issue_to_patch | [client,windows] honor /from-stdin in wfreerdp | ## Summary
`wfreerdp.exe /from-stdin` has silently ignored piped credentials since 1e63d8c49 (Mar 2023). `echo pw | wfreerdp.exe /v:host /u:user /from-stdin` drops the password and pops the GUI
login dialog instead. This restores the behavior originally added in 07ea60e96.
Three stacked issues:
1. `free... | 6ba1b2da02fa560c2f8f0305d55e7d1d1730c0a2 | 9e409d199023813a89f317e717b8ae43783a6298 | diff --git a/client/Windows/wf_client.c b/client/Windows/wf_client.c
index 346fea56c568..97f69175fdf7 100644
--- a/client/Windows/wf_client.c
+++ b/client/Windows/wf_client.c
@@ -52,6 +52,7 @@
#include <freerdp/locale/locale.h>
#include <freerdp/locale/keyboard.h>
#include <freerdp/codec/region.h>
+#include <freerdp... | [
"client/Windows/wf_client.c",
"libfreerdp/utils/passphrase.c"
] | [
{
"comment": "why move this block here?",
"path": "client/Windows/wf_client.c",
"hunk": "@@ -237,6 +250,34 @@ static BOOL wf_pre_connect(freerdp* instance)\n \trdpContext* context = instance->context;\n \twfContext* wfc = (wfContext*)instance->context;\n \trdpSettings* settings = context->settings;\n+\n... | true | ||
FreeRDP/FreeRDP | 12,821 | comment_to_fix | [client,windows] honor /from-stdin in wfreerdp | why move this block here? | 6ba1b2da02fa560c2f8f0305d55e7d1d1730c0a2 | 9e409d199023813a89f317e717b8ae43783a6298 | diff --git a/client/Windows/wf_client.c b/client/Windows/wf_client.c
index 346fea56c568..97f69175fdf7 100644
--- a/client/Windows/wf_client.c
+++ b/client/Windows/wf_client.c
@@ -52,6 +52,7 @@
#include <freerdp/locale/locale.h>
#include <freerdp/locale/keyboard.h>
#include <freerdp/codec/region.h>
+#include <freerdp... | [
"client/Windows/wf_client.c"
] | [
{
"comment": "why move this block here?",
"path": "client/Windows/wf_client.c",
"hunk": "@@ -237,6 +250,34 @@ static BOOL wf_pre_connect(freerdp* instance)\n \trdpContext* context = instance->context;\n \twfContext* wfc = (wfContext*)instance->context;\n \trdpSettings* settings = context->settings;\n+\n... | true | ||
FreeRDP/FreeRDP | 12,821 | comment_to_fix | [client,windows] honor /from-stdin in wfreerdp | certificate options are not related to `/from-stdin` | 6ba1b2da02fa560c2f8f0305d55e7d1d1730c0a2 | 9e409d199023813a89f317e717b8ae43783a6298 | diff --git a/client/Windows/wf_client.c b/client/Windows/wf_client.c
index 346fea56c568..97f69175fdf7 100644
--- a/client/Windows/wf_client.c
+++ b/client/Windows/wf_client.c
@@ -52,6 +52,7 @@
#include <freerdp/locale/locale.h>
#include <freerdp/locale/keyboard.h>
#include <freerdp/codec/region.h>
+#include <freerdp... | [
"client/Windows/wf_client.c"
] | [
{
"comment": "certificate options are not related to `/from-stdin`",
"path": "client/Windows/wf_client.c",
"hunk": "@@ -982,6 +993,11 @@ static DWORD wf_verify_changed_certificate_ex(freerdp* instance, const char* hos\n \tWCHAR* caption;\n \tint what = IDCANCEL;\n \n+\tif (freerdp_settings_get_bool(inst... | true | ||
FreeRDP/FreeRDP | 12,821 | comment_to_fix | [client,windows] honor /from-stdin in wfreerdp | gateway message options are not related to `/from-stdin` | 6ba1b2da02fa560c2f8f0305d55e7d1d1730c0a2 | 9e409d199023813a89f317e717b8ae43783a6298 | diff --git a/client/Windows/wf_client.c b/client/Windows/wf_client.c
index 346fea56c568..97f69175fdf7 100644
--- a/client/Windows/wf_client.c
+++ b/client/Windows/wf_client.c
@@ -52,6 +52,7 @@
#include <freerdp/locale/locale.h>
#include <freerdp/locale/keyboard.h>
#include <freerdp/codec/region.h>
+#include <freerdp... | [
"client/Windows/wf_client.c"
] | [
{
"comment": "gateway message options are not related to `/from-stdin`",
"path": "client/Windows/wf_client.c",
"hunk": "@@ -1030,6 +1046,10 @@ static DWORD wf_verify_changed_certificate_ex(freerdp* instance, const char* hos\n static BOOL wf_present_gateway_message(freerdp* instance, UINT32 type, BOOL is... | true | ||
FreeRDP/FreeRDP | 12,829 | issue_to_patch | [channels,rdpsnd] reject client audio formats with zero nChannels/nBlockAlign (server-side DoS) | ## Summary
A malicious RDP client can crash a FreeRDP-based RDP **server** (SIGFPE / division by zero) by sending a Client Audio Formats PDU containing an audio format whose `nChannels` or `nBlockAlign` is `0`.
`rdpsnd_server_recv_formats()` reads each `AUDIO_FORMAT` straight from the wire without validating these tw... | 6ba1b2da02fa560c2f8f0305d55e7d1d1730c0a2 | 7304d725c07b0aec0ceee77439aadf12a33159c3 | diff --git a/channels/rdpsnd/server/rdpsnd_main.c b/channels/rdpsnd/server/rdpsnd_main.c
index 8322704ffa9e..4ea33e595175 100644
--- a/channels/rdpsnd/server/rdpsnd_main.c
+++ b/channels/rdpsnd/server/rdpsnd_main.c
@@ -241,6 +241,18 @@ static UINT rdpsnd_server_recv_formats(RdpsndServerContext* context, wStream* s)
... | [
"channels/rdpsnd/server/rdpsnd_main.c"
] | [] | true | ||
FreeRDP/FreeRDP | 12,825 | issue_to_patch | [ci,freebsd] drop openssl 111 build | d94ff4dba394fb0cd4c8419f6355952a79c502bd | a466a88fb6e168897c35a9790069a6c11d905314 | diff --git a/.github/workflows/freebsd.yml b/.github/workflows/freebsd.yml
index 11e60ea47fcb..7991a86c42f8 100644
--- a/.github/workflows/freebsd.yml
+++ b/.github/workflows/freebsd.yml
@@ -11,10 +11,7 @@ jobs:
strategy:
matrix:
freebsd-version: ["15.0", "14.4"]
- ssl: ["openssl111", "opens... | [
".github/workflows/freebsd.yml"
] | [] | true | |||
FreeRDP/FreeRDP | 12,824 | issue_to_patch | [ci,freebsd] fix wrong indentation | 8c1911b30ad1ab15b52db2abde2b7552031ade40 | 01a88364708c0db679f6c1e5cdb548c56dcf4ea6 | diff --git a/.github/workflows/freebsd.yml b/.github/workflows/freebsd.yml
index 929366672e0a..11e60ea47fcb 100644
--- a/.github/workflows/freebsd.yml
+++ b/.github/workflows/freebsd.yml
@@ -12,9 +12,9 @@ jobs:
matrix:
freebsd-version: ["15.0", "14.4"]
ssl: ["openssl111", "openssl36", "openssl4... | [
".github/workflows/freebsd.yml"
] | [] | true | |||
FreeRDP/FreeRDP | 12,823 | issue_to_patch | [ci,freebsd] exclude openssl111 from freebsd 15 | 4362325aa21eb0d8e76af793acb9d0a907a68106 | 73d35f08bf02c3ac2c13fa2e8c5b7fbd9f69b13d | diff --git a/.github/workflows/freebsd.yml b/.github/workflows/freebsd.yml
index 7ee1c1e8e039..929366672e0a 100644
--- a/.github/workflows/freebsd.yml
+++ b/.github/workflows/freebsd.yml
@@ -12,6 +12,9 @@ jobs:
matrix:
freebsd-version: ["15.0", "14.4"]
ssl: ["openssl111", "openssl36", "openssl4... | [
".github/workflows/freebsd.yml"
] | [] | true | |||
FreeRDP/FreeRDP | 12,822 | issue_to_patch | Android splits | @svncibrahim might be of interest for you as well. | 69660584df2d48ef31bb163240ba0ff42c786f75 | 7a55249d1e7f6dd28db51eb70a8658ab4eb50bbc | diff --git a/channels/cliprdr/server/cliprdr_main.c b/channels/cliprdr/server/cliprdr_main.c
index 3b857acd2bfd..e8344d601f93 100644
--- a/channels/cliprdr/server/cliprdr_main.c
+++ b/channels/cliprdr/server/cliprdr_main.c
@@ -1147,7 +1147,7 @@ static UINT cliprdr_server_read(CliprdrServerContext* context)
if (noHead... | [
"channels/cliprdr/server/cliprdr_main.c",
"client/Android/Studio/.gitignore",
"client/Android/Studio/aFreeRDP/build.gradle",
"client/Android/Studio/freeRDPCore/build.gradle",
"client/Android/Studio/freeRDPCore/src/main/cpp/CMakeLists.txt",
"client/Android/cmake/0001-openh264-pkgconfig-patch.patch",
"cli... | [] | true | ||
FreeRDP/FreeRDP | 12,820 | issue_to_patch | Android physical keyboard to resolve win keyboard conflicts
When using shortcuts such as win+tab, win+r, etc. when remotely connecting with a tablet, it always triggers the tablet's voice assistant function, rather than triggering an action on the remote host. Including the handling of the middle mouse button In th... | [client,android] Add accessibility service for physical keyboard shortcuts | ## [client,android] Add accessibility service for physical keyboard shortcuts
- Fixes #10646
### Description
Physical keyboard shortcuts (Win key combos) now reach the remote desktop
instead of triggering Android system actions.
- **Win+key combos:** Win key is buffered on press and delivered as a tap on
re... | a06543d5508669d7ae4368fb2b8c9f914d1acb8b | 2f027af5d76d21145c43e08e5e0d5d93434c3b5e | diff --git a/client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml b/client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml
index 1589a7683ed0..b6b5167d55de 100644
--- a/client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml
+++ b/client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml
@... | [
"client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml",
"client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/KeyboardAccessibilityService.java",
"client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/SessionActivity.java",
"client/Andro... | [] | true | |
FreeRDP/FreeRDP | 12,819 | issue_to_patch | Review Android Clipboard Image Transfer Features
Android clipboards only support text when using the clipboard feature. But can I also send images? Why not send images? | [client,android] Add bidirectional clipboard image transfer | ## [client,android] Add bidirectional clipboard image transfer
- Fixes #10713
### Description
Clipboard image transfer support for aFreeRDP:
- **Server -> Android:** Incoming CF_DIB / CF_DIBV5 clipboard data is converted
to PNG via winpr and placed on the Android clipboard using a ContentProvider.
- **... | 21e1db4848de32d67b3729daf1475f8f87bd5fe7 | ee004a0733c898ebbca35148bc2a306052ea99d4 | diff --git a/client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml b/client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml
index c34de595b064..1589a7683ed0 100644
--- a/client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml
+++ b/client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml
@... | [
"client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml",
"client/Android/Studio/freeRDPCore/src/main/cpp/android_cliprdr.c",
"client/Android/Studio/freeRDPCore/src/main/cpp/android_event.c",
"client/Android/Studio/freeRDPCore/src/main/cpp/android_event.h",
"client/Android/Studio/freeRDPCore/src/mai... | [
{
"comment": "is this change intended or an accident?",
"path": "client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/SessionActivity.java",
"hunk": "@@ -297,8 +297,10 @@ private void hideSystemBars()\n \t{\n \t\tsuper.onWindowFocusChanged(hasFocus);\n \t\tif (hasFocus)\n... | true | |
FreeRDP/FreeRDP | 12,819 | comment_to_fix | [client,android] Add bidirectional clipboard image transfer | is this change intended or an accident? | 21e1db4848de32d67b3729daf1475f8f87bd5fe7 | ee004a0733c898ebbca35148bc2a306052ea99d4 | diff --git a/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/SessionActivity.java b/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/SessionActivity.java
index 80353e9c1972..479b52a80c1f 100644
--- a/client/Android/Studio/freeRDPCore/src/main/java... | [
"client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/SessionActivity.java"
] | [
{
"comment": "is this change intended or an accident?",
"path": "client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/SessionActivity.java",
"hunk": "@@ -297,8 +297,10 @@ private void hideSystemBars()\n \t{\n \t\tsuper.onWindowFocusChanged(hasFocus);\n \t\tif (hasFocus)\n... | true | ||
FreeRDP/FreeRDP | 12,817 | issue_to_patch | `InterlockedPushEntrySList` returns `nullptr` on Android ARM64 causing crash
# **Describe the bug**
FreeRDP crashes on Android ARM64 when printer redirection is enabled. The crash
occurs in the printer channel's async worker thread immediately after the first
IRP is queued.
# **To Reproduce**
1. Build FreeRDP for A... | Refactor printer queue | a71aa0b418fdd258b8ebdeb5b0e08c597552b1fa | 227c5a37cc33769069d1772315c4bf6313549834 | diff --git a/channels/printer/client/printer_main.c b/channels/printer/client/printer_main.c
index 610307171385..f7f6061865a3 100644
--- a/channels/printer/client/printer_main.c
+++ b/channels/printer/client/printer_main.c
@@ -56,7 +56,7 @@ typedef struct
rdpPrinter* printer;
- WINPR_PSLIST_HEADER pIrpList;
+ wQu... | [
"channels/printer/client/printer_main.c",
"ci/cmake-preloads/config-android.txt",
"client/Android/cmake/ExternalFreeRDP.cmake",
"include/freerdp/channels/rdpdr.h",
"libfreerdp/common/settings.c",
"packaging/flatpak/com.freerdp.FreeRDP.json",
"scripts/mingw.sh",
"winpr/CMakeLists.txt",
"winpr/include... | [] | diff --git a/winpr/libwinpr/crypto/test/TestCryptoCipher.c b/winpr/libwinpr/crypto/test/TestCryptoCipher.c
index bd6548f06fc0..b55ecba68766 100644
--- a/winpr/libwinpr/crypto/test/TestCryptoCipher.c
+++ b/winpr/libwinpr/crypto/test/TestCryptoCipher.c
@@ -23,7 +23,7 @@ static BOOL test_crypto_cipher_aes_128_cbc(BOOL ex)... | true | |
FreeRDP/FreeRDP | 12,818 | issue_to_patch | [client,android] Code cleanup: remove dead code, fix lint warnings, add license headers | ## [client,android] Cleanup
Most changes in this PR were identified using Android Studio's **Inspect Code** tool.
**Note:** Inspect Code reports many more issues; these are the ones I verified as genuine problems rather than false positives. Further cleanups may follow in separate PRs.
### License headers
- ... | 3e8f91cc0e2fc88527d90fcd0ab61f572dc50a57 | 30166164a5d230d4e0ceb47468365224905a090c | diff --git a/client/Android/Studio/aFreeRDP/src/main/res/values-de/strings.xml b/client/Android/Studio/aFreeRDP/src/main/res/values-de/strings.xml
deleted file mode 100644
index 16fc2babc72e..000000000000
--- a/client/Android/Studio/aFreeRDP/src/main/res/values-de/strings.xml
+++ /dev/null
@@ -1,4 +0,0 @@
-<?xml versio... | [
"client/Android/Studio/aFreeRDP/src/main/res/values-de/strings.xml",
"client/Android/Studio/aFreeRDP/src/main/res/values-es/strings.xml",
"client/Android/Studio/aFreeRDP/src/main/res/values-fr/strings.xml",
"client/Android/Studio/aFreeRDP/src/main/res/values-ko/strings.xml",
"client/Android/Studio/aFreeRDP/... | [] | true | ||
FreeRDP/FreeRDP | 12,810 | issue_to_patch | [channels,cliprdr] refactor server channel | * Use dynamic logger in CliprdrServerPrivate
* Simplify reading in data
* Harden parser, warn on excess bytes received | 3cd6cf0e24130185c05be63846ebcc85b7fe0ea4 | 07e717d23eb175a18c773dbdc17c92be9147cd97 | diff --git a/channels/cliprdr/cliprdr_common.c b/channels/cliprdr/cliprdr_common.c
index cd35fbe6674c..153d98dd7877 100644
--- a/channels/cliprdr/cliprdr_common.c
+++ b/channels/cliprdr/cliprdr_common.c
@@ -334,9 +334,12 @@ UINT cliprdr_read_format_data_response(wStream* s, CLIPRDR_FORMAT_DATA_RESPONSE*
if (!Stream_C... | [
"channels/cliprdr/cliprdr_common.c",
"channels/cliprdr/server/cliprdr_main.c",
"channels/cliprdr/server/cliprdr_main.h"
] | [] | true | ||
FreeRDP/FreeRDP | 12,813 | issue_to_patch | [warnings] fix build warnings | 67efed0ce0974f583708d0c739ce57cdf5ac73e8 | 28278829a3cdd1c268609aa0abfde8c284c98f59 | diff --git a/libfreerdp/codec/h264_ffmpeg.c b/libfreerdp/codec/h264_ffmpeg.c
index 6b94ca1a9245..aec56b0c7bb1 100644
--- a/libfreerdp/codec/h264_ffmpeg.c
+++ b/libfreerdp/codec/h264_ffmpeg.c
@@ -83,6 +83,7 @@ static const char* get_vaapi_device(void)
if (!initialized)
{
initialized = true;
+ // NOLINTNEXTLINE(c... | [
"libfreerdp/codec/h264_ffmpeg.c",
"libfreerdp/common/settings.c"
] | [] | true | |||
FreeRDP/FreeRDP | 12,815 | issue_to_patch | Printer redirection on Android ?
Hi,
Would like to know if FreeRDP has support for printer redirection on Android. I went through various posts and here are my observations.
1) We need to build with -DWITH_CUPS=ON while generating make files using cmake.
2) We need to populate the printer name and printer driver to ... | [client,android] Add printer channel support for Android | ## [client,android] Add printer channel support for Android
- Fixes #2882
### Description
End-to-end RDP printer redirection for aFreeRDP:
- **Backend:** New `printer_android` subsystem saves incoming print data as PDF to
`/sdcard/Download/`. Uses `Microsoft Print to PDF:android` driver to request
PDF out... | 67efed0ce0974f583708d0c739ce57cdf5ac73e8 | c23d971462ac53f78cc50cd53d366060aec92e27 | diff --git a/channels/printer/client/CMakeLists.txt b/channels/printer/client/CMakeLists.txt
index c3769a781106..f40f6039b3fa 100644
--- a/channels/printer/client/CMakeLists.txt
+++ b/channels/printer/client/CMakeLists.txt
@@ -29,3 +29,7 @@ endif()
if(WIN32 AND NOT UWP)
add_channel_client_subsystem(${MODULE_PREFIX}... | [
"channels/printer/client/CMakeLists.txt",
"channels/printer/client/android/CMakeLists.txt",
"channels/printer/client/android/printer_android.c",
"client/Android/Studio/aFreeRDP/src/main/res/xml/file_provider_paths.xml",
"client/Android/Studio/freeRDPCore/src/main/AndroidManifest.xml",
"client/Android/Stud... | [
{
"comment": "missing `aj->file = nullptr` set",
"path": "channels/printer/client/android/printer_android.c",
"hunk": "@@ -0,0 +1,281 @@\n+/**\n+ * FreeRDP: A Remote Desktop Protocol Implementation\n+ * Print Virtual Channel - Android backend\n+ *\n+ * Copyright 2026 Ibrahim Sevinc <ibrahim.sevinc.mail@... | true | |
FreeRDP/FreeRDP | 12,815 | comment_to_fix | [client,android] Add printer channel support for Android | missing `aj->file = nullptr` set | 67efed0ce0974f583708d0c739ce57cdf5ac73e8 | c23d971462ac53f78cc50cd53d366060aec92e27 | diff --git a/channels/printer/client/android/printer_android.c b/channels/printer/client/android/printer_android.c
new file mode 100644
index 000000000000..c6fb6f4f862c
--- /dev/null
+++ b/channels/printer/client/android/printer_android.c
@@ -0,0 +1,282 @@
+/**
+ * FreeRDP: A Remote Desktop Protocol Implementation
+ * ... | [
"channels/printer/client/android/printer_android.c"
] | [
{
"comment": "missing `aj->file = nullptr` set",
"path": "channels/printer/client/android/printer_android.c",
"hunk": "@@ -0,0 +1,281 @@\n+/**\n+ * FreeRDP: A Remote Desktop Protocol Implementation\n+ * Print Virtual Channel - Android backend\n+ *\n+ * Copyright 2026 Ibrahim Sevinc <ibrahim.sevinc.mail@... | true | ||
FreeRDP/FreeRDP | 12,815 | comment_to_fix | [client,android] Add printer channel support for Android | the `:android` part should not be required, it is the only backend available on android | 67efed0ce0974f583708d0c739ce57cdf5ac73e8 | c23d971462ac53f78cc50cd53d366060aec92e27 | diff --git a/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/services/LibFreeRDP.java b/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/services/LibFreeRDP.java
index 0fbb91460fdd..a651e46845b1 100644
--- a/client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freer... | [
"client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/services/LibFreeRDP.java"
] | [
{
"comment": "the `:android` part should not be required, it is the only backend available on android ",
"path": "client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/services/LibFreeRDP.java",
"hunk": "@@ -404,6 +404,9 @@ public static boolean setConnectionInfo(Context context, long ... | true | ||
FreeRDP/FreeRDP | 12,812 | issue_to_patch | *.rdp file does not load the connection settings properly for aFreeRDP [android-client]
When using the android client apk installed on an android device,upon clicking the rdp file it opens our app connection settings.
But the following are not detected:
```
redirectclipboard:i:1
redirectposdevices:i:0
redirectprinter... | [client,android] add .rdp file import and share support | ## [client,android] Add .rdp file import and share support
- Fixes #2053
- Fixes #12663
### Description
`.rdp` file support for aFreeRDP:
- **Import:** Opening a `.rdp` file launches the bookmark editor pre-filled with connection
settings. Extends the existing parser to support over 20 fields including gat... | 9b04e3b26f11208a8450d748850ce017e9a9f7eb | 73aed8cc21c098141f83afbea00782b74da3fae6 | diff --git a/client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml b/client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml
index 3cf9650abe7f..d7e9c2513454 100644
--- a/client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml
+++ b/client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml
@@ -52,10 +52... | [
"client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml",
"client/Android/Studio/aFreeRDP/src/main/res/xml/file_provider_paths.xml",
"client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/presentation/BookmarkViewModel.java",
"client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/... | [
{
"comment": "maybe @NonNull?",
"path": "client/Android/Studio/freeRDPCore/src/main/java/com/freerdp/freerdpcore/services/LibFreeRDP.java",
"hunk": "@@ -555,6 +558,11 @@ public static boolean sendMonitorLayout(long inst, int width, int height)\n \t\treturn freerdp_send_monitor_layout(inst, width, height... | true | |
FreeRDP/FreeRDP | 12,812 | comment_to_fix | [client,android] add .rdp file import and share support | nice, finally 😁 | 9b04e3b26f11208a8450d748850ce017e9a9f7eb | 73aed8cc21c098141f83afbea00782b74da3fae6 | diff --git a/client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml b/client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml
index 3cf9650abe7f..d7e9c2513454 100644
--- a/client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml
+++ b/client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml
@@ -52,10 +52... | [
"client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml"
] | [
{
"comment": "nice, finally 😁 ",
"path": "client/Android/Studio/aFreeRDP/src/main/AndroidManifest.xml",
"hunk": "@@ -52,10 +52,10 @@\n <data android:scheme=\"content\" />\n <data android:host=\"*\" />\n \n- <!-- Ugly hack to match all files with a dot in i... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.