repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
FuelLabs/fuels-rs | 1,685 | comment_to_fix | feat: expose offsets_with_data on configurables | If you want to implement `From` for internal components, then `(u64, Vec<u8>)` should be replaced with proper structure with fields and comments. | d0a0ce733a71388fbf257b2e766347c97b06abb7 | 182334eb4ab880f61b742640b61c6be0b991fb53 | diff --git a/packages/fuels-core/src/lib.rs b/packages/fuels-core/src/lib.rs
index 1723a91702..13d3414e46 100644
--- a/packages/fuels-core/src/lib.rs
+++ b/packages/fuels-core/src/lib.rs
@@ -7,13 +7,21 @@ pub use utils::*;
use crate::types::errors::Result;
+#[derive(Debug, Clone, Default, PartialEq)]
+pub struct C... | [
"packages/fuels-core/src/lib.rs"
] | [
{
"comment": "If you want to implement `From` for internal components, then `(u64, Vec<u8>)` should be replaced with proper structure with fields and comments.",
"path": "packages/fuels-core/src/lib.rs",
"hunk": "@@ -52,6 +52,12 @@ impl Configurables {\n }\n }\n \n+impl From<Configurables> for Vec<(... | true | ||
FuelLabs/fuels-rs | 1,683 | issue_to_patch | Additional functionality to allow custom sync calls for contracts and scripts | This pull request introduces several improvements and refactors to how transactions are built and assets are managed in the `fuels-programs` and related crates. The main focus is on separating the concerns of asset calculation and transaction building, making the code more modular and easier to maintain. Additionally, ... | 4e0fab95b99f0e49adf88f7560395f1c0021ff2b | 052ebead47d24dd3e375ccc430beb756ebd7a815 | diff --git a/packages/fuels-accounts/src/provider.rs b/packages/fuels-accounts/src/provider.rs
index 66013c221b..89e2d91656 100644
--- a/packages/fuels-accounts/src/provider.rs
+++ b/packages/fuels-accounts/src/provider.rs
@@ -12,6 +12,7 @@ pub use cache::TtlConfig;
use cache::{CachedClient, SystemClock};
use chrono:... | [
"packages/fuels-accounts/src/provider.rs",
"packages/fuels-accounts/src/provider/retryable_client.rs",
"packages/fuels-accounts/src/signers/private_key.rs",
"packages/fuels-core/src/codec/logs.rs",
"packages/fuels-programs/src/calls/call_handler.rs",
"packages/fuels-programs/src/calls/traits/transaction_t... | [] | true | ||
FuelLabs/fuels-rs | 1,684 | issue_to_patch | chore(log_id): lazy data decode | This pull request introduces a new lazy log decoding feature to the `fuels-core` log codec, enabling more efficient and flexible extraction and decoding of logs from receipts. The main changes focus on adding a lazy decoding API, supporting type-specific log extraction, and implementing the necessary traits and iterato... | 693d4fbb8d96374cde02340cc0521bc069e71860 | 11d27e72f1226bcdf3c21f5e0dc40a6d5888e119 | diff --git a/packages/fuels-accounts/src/provider.rs b/packages/fuels-accounts/src/provider.rs
index 512b35cd6..89e2d9165 100644
--- a/packages/fuels-accounts/src/provider.rs
+++ b/packages/fuels-accounts/src/provider.rs
@@ -134,7 +134,7 @@ impl Provider {
/// Returns the underlying uncached client.
pub fn ... | [
"packages/fuels-accounts/src/provider.rs",
"packages/fuels-core/src/codec/logs.rs"
] | [] | true | ||
FuelLabs/fuels-rs | 1,682 | issue_to_patch | feat: bump fuel-core to 0.46 | Bumped `fuel-core` to `0.46.0` | afd71a57e072c090187f88b3933eee12aa827d5c | f155af793f32a2d0ef7fc8de23cdee2bdcd34e05 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7e14dad0bc..097b2217df 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -6,7 +6,7 @@ on:
- master
pull_request:
release:
- types: [published]
+ types: [ published ]
concurrency:
group: ${{ github.workf... | [
".github/workflows/ci.yml",
"Cargo.toml",
"ci_checks.sh",
"e2e/sway/types/contracts/generics/src/main.sw",
"e2e/sway/types/contracts/tuples/src/main.sw",
"e2e/tests/providers.rs",
"e2e/tests/types_scripts.rs",
"examples/contracts/src/lib.rs",
"packages/fuels-accounts/src/provider/supported_fuel_core... | [] | diff --git a/e2e/tests/providers.rs b/e2e/tests/providers.rs
index 6dba4bc0f0..160dd51655 100644
--- a/e2e/tests/providers.rs
+++ b/e2e/tests/providers.rs
@@ -355,7 +355,7 @@ async fn test_gas_forwarded_defaults_to_tx_limit() -> Result<()> {
);
// The gas used by the script to call a contract and forward re... | true | |
FuelLabs/fuels-rs | 1,679 | issue_to_patch | Bump fuel-abi-types to 0.15.0 | This stubs out a few things due to interdependency issues with Sway, the next PR for alias will properly implement these out.
| 51fce1d89706b020952819512a4619ac1858d182 | 449bcf499d0036510679095a4fdfdcd32f8425b2 | diff --git a/Cargo.toml b/Cargo.toml
index 045515278a..d987fac5e6 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -52,7 +52,7 @@ cynic = { version = "3.1.0", default-features = false }
test-case = { version = "3.3", default-features = false }
eth-keystore = "0.5.0"
flate2 = { version = "1.0", default-features = false }
... | [
"Cargo.toml",
"packages/fuels-code-gen/src/program_bindings/abigen.rs",
"packages/fuels-code-gen/src/program_bindings/abigen/bindings/function_generator.rs",
"packages/fuels-code-gen/src/program_bindings/abigen/bindings/utils.rs",
"packages/fuels-code-gen/src/program_bindings/custom_types.rs",
"packages/f... | [] | true | ||
FuelLabs/fuels-rs | 1,678 | issue_to_patch | Fix `force_transfer_to_contract` to work properly with non-based assets | # Release notes
Fixed the `force_transfer_to_contract` to work with non-based assets.
| aed2d97bdb8ec3177596020c8e2795d62e3ff433 | fc6b54903970ec879491ad3cc637c53b9f039f45 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 8e547460e4..7e14dad0bc 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -19,7 +19,7 @@ env:
FUEL_CORE_VERSION: 0.44.0
FUEL_CORE_PATCH_BRANCH: ""
FUEL_CORE_PATCH_REVISION: ""
- RUST_VERSION: 1.85.0
+ RUST_VERSION: 1.... | [
".github/workflows/ci.yml",
"Cargo.toml",
"ci_checks.sh",
"e2e/tests/providers.rs",
"examples/providers/src/lib.rs",
"packages/fuels-accounts/src/account.rs",
"packages/fuels-code-gen/src/program_bindings/custom_types.rs",
"packages/fuels-core/src/codec/abi_decoder.rs",
"packages/fuels-core/src/code... | [] | diff --git a/e2e/tests/providers.rs b/e2e/tests/providers.rs
index 52bc7954d2..6dba4bc0f0 100644
--- a/e2e/tests/providers.rs
+++ b/e2e/tests/providers.rs
@@ -1036,7 +1036,7 @@ async fn send_transaction_and_await_status() -> Result<()> {
assert!(status.iter().enumerate().all(|(i, tx_status)| {
matches!(
... | true | |
FuelLabs/fuels-rs | 1,674 | issue_to_patch | Update `fuel-abi-types` to 0.13.0 | See https://github.com/FuelLabs/fuel-abi-types/pull/34 for more information.
Also updates the version to 0.75.0 so we can publish a new release. | 76f2a2bb86fd1e49d9cbf0f809652498dc84d189 | 97d565ebcb3cc4df3b459207cfbf280fe5bb6ff2 | diff --git a/Cargo.toml b/Cargo.toml
index f5e0d451c4..fb73d4c0c2 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -39,7 +39,7 @@ readme = "README.md"
license = "Apache-2.0"
repository = "https://github.com/FuelLabs/fuels-rs"
rust-version = "1.85.0"
-version = "0.74.0"
+version = "0.75.0"
[workspace.dependencies]
Inf... | [
"Cargo.toml",
"docs/src/connecting/short-lived.md"
] | [] | true | ||
FuelLabs/fuels-rs | 1,672 | issue_to_patch | Prepare for 0.74.0 release | Bump crate versions, prepare for new release.
# Checklist
- [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **changes** are **documented** (or not applicable)
- [x] I **reviewed** the **entire PR** myself (preferably, on GH UI)
- [x] I **described** all **Breaking Changes** (or t... | 5d860ff0083a28221ee62b2c4331caff3781ca95 | 2dd29c3e44d2e6de163cea61215d0d1766746069 | diff --git a/Cargo.toml b/Cargo.toml
index 337f301b6f..f5e0d451c4 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -39,7 +39,7 @@ readme = "README.md"
license = "Apache-2.0"
repository = "https://github.com/FuelLabs/fuels-rs"
rust-version = "1.85.0"
-version = "0.73.0"
+version = "0.74.0"
[workspace.dependencies]
Inf... | [
"Cargo.toml",
"docs/src/connecting/short-lived.md"
] | [] | true | ||
FuelLabs/fuels-rs | 1,670 | issue_to_patch | Update to latest fuel-core and fuel-vm | # Summary
Updates fuel-vm and fuel-core to latest versions.
# Breaking Changes
Balances are now represented as u128.
# Checklist
- [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **changes** are **documented** (or not applicable)
- [x] I **reviewed** the **entire PR** my... | e510eab463c190600bd8b5f004bd5544b3ffc8cd | 7235e7c226b8b2925079a18e51bf1151378e7aed | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index e871ab05af..8e547460e4 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -16,11 +16,11 @@ env:
CARGO_TERM_COLOR: always
DASEL_VERSION: https://github.com/TomWright/dasel/releases/download/v2.3.6/dasel_linux_amd64
RUSTF... | [
".github/workflows/ci.yml",
"Cargo.toml",
"e2e/tests/aws.rs",
"e2e/tests/contracts.rs",
"e2e/tests/logs.rs",
"e2e/tests/predicates.rs",
"e2e/tests/providers.rs",
"e2e/tests/scripts.rs",
"e2e/tests/types_predicates.rs",
"e2e/tests/wallets.rs",
"examples/contracts/src/lib.rs",
"examples/cookbook... | [] | diff --git a/e2e/tests/aws.rs b/e2e/tests/aws.rs
index aab18c5828..85d61f030c 100644
--- a/e2e/tests/aws.rs
+++ b/e2e/tests/aws.rs
@@ -35,7 +35,7 @@ mod tests {
// ANCHOR_END: use_kms_wallet
let total_base_balance = wallet.get_asset_balance(&AssetId::zeroed()).await?;
- assert_eq!(total_base_... | true | |
FuelLabs/fuels-rs | 1,669 | issue_to_patch | remove `Bech32` addresses and contract ids
Throughout the sdk we have used and converted `Address` and `ContractId` into `Bech32Address` and `Bech32Contract` id. Remove the `bech32` implementation completely.
Make sure that the `abigen` does not create code for conversion from `bech32` | chore!: remove `bech32` `ContractId` and `Address` | closes: https://github.com/FuelLabs/fuels-rs/issues/1660
# Release notes
In this release, we:
- Removed `Bech32Address` and `Bech32ContractId`
# Breaking Changes
- Removed `Bech32Address` and `Bech32ContractId` and all related APIs
# Checklist
- [x] All **changes** are **covered** by **tests** (or no... | 3422bcc8b408a4e4a80e46830e91e0c6f2be94bb | 485dd73654bdf2eaf2a80f77ff66ae0e60830073 | diff --git a/Cargo.toml b/Cargo.toml
index d2704574ef..f05308f7d2 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -46,7 +46,6 @@ Inflector = "0.11.4"
anyhow = { version = "1.0", default-features = false }
dialoguer = { version = "0.11", default-features = false }
async-trait = { version = "0.1.74", default-features = fa... | [
"Cargo.toml",
"docs/src/SUMMARY.md",
"docs/src/accounts.md",
"docs/src/deploying/interacting-with-contracts.md",
"docs/src/types/bech32.md",
"docs/src/types/conversion.md",
"e2e/tests/aws.rs",
"e2e/tests/bindings.rs",
"e2e/tests/contracts.rs",
"e2e/tests/from_token.rs",
"e2e/tests/logs.rs",
"e... | [
{
"comment": "Unrelated:\r\nJust noticing the `with_OWNER` non-idiomatic function name. Curious what that's about. Can't find it in the source code either, so maybe it's a generated function?",
"path": "e2e/tests/contracts.rs",
"hunk": "@@ -2730,12 +2730,11 @@ async fn multicall_tx_input_output() -> Res... | diff --git a/e2e/tests/aws.rs b/e2e/tests/aws.rs
index 43280e415a..aab18c5828 100644
--- a/e2e/tests/aws.rs
+++ b/e2e/tests/aws.rs
@@ -18,10 +18,10 @@ mod tests {
let amount = 500000000;
let key = kms.create_signer().await?;
- let address = key.address().clone();
+ let address = key.ad... | true |
FuelLabs/fuels-rs | 1,669 | comment_to_fix | chore!: remove `bech32` `ContractId` and `Address` | Unrelated:
Just noticing the `with_OWNER` non-idiomatic function name. Curious what that's about. Can't find it in the source code either, so maybe it's a generated function? | 3422bcc8b408a4e4a80e46830e91e0c6f2be94bb | 485dd73654bdf2eaf2a80f77ff66ae0e60830073 | diff --git a/e2e/tests/contracts.rs b/e2e/tests/contracts.rs
index 0a38d02516..e2129f1929 100644
--- a/e2e/tests/contracts.rs
+++ b/e2e/tests/contracts.rs
@@ -1,16 +1,18 @@
use std::time::Duration;
-use fuel_tx::{
- ConsensusParameters, FeeParameters, Output,
- consensus_parameters::{ConsensusParametersV1, Fee... | [
"e2e/tests/contracts.rs"
] | [
{
"comment": "Unrelated:\r\nJust noticing the `with_OWNER` non-idiomatic function name. Curious what that's about. Can't find it in the source code either, so maybe it's a generated function?",
"path": "e2e/tests/contracts.rs",
"hunk": "@@ -2730,12 +2730,11 @@ async fn multicall_tx_input_output() -> Res... | true | ||
FuelLabs/fuels-rs | 1,669 | comment_to_fix | chore!: remove `bech32` `ContractId` and `Address` | It's weird to see this change seeing as the change doesn't impact execution.
Did you maybe use a different compiler version from the one we have in CI? | 3422bcc8b408a4e4a80e46830e91e0c6f2be94bb | 485dd73654bdf2eaf2a80f77ff66ae0e60830073 | diff --git a/examples/contracts/src/lib.rs b/examples/contracts/src/lib.rs
index 47211c9e65..7cc655fef0 100644
--- a/examples/contracts/src/lib.rs
+++ b/examples/contracts/src/lib.rs
@@ -8,8 +8,9 @@ mod tests {
prelude::{LoadConfiguration, NodeConfig, StorageConfiguration},
programs::debug::ScriptType... | [
"examples/contracts/src/lib.rs"
] | [
{
"comment": "It's weird to see this change seeing as the change doesn't impact execution. \r\n\r\nDid you maybe use a different compiler version from the one we have in CI? ",
"path": "examples/contracts/src/lib.rs",
"hunk": "@@ -120,8 +121,8 @@ mod tests {\n .await?;\n // ANCHOR_EN... | true | ||
FuelLabs/fuels-rs | 1,664 | issue_to_patch | remove `CoinStatus` and `block_created` from `Coin` | chore!: remove `CoinStatus` and `block_created` from `Coin` | closes: https://github.com/FuelLabs/fuels-rs/issues/1663
# Breaking Changes
removed `CoinStatus` and `created_at` from `Coin`
```rust
//old
pub struct Coin {
pub amount: u64,
pub block_created: u32,
pub asset_id: AssetId,
pub utxo_id: UtxoId,
pub owner: Bech32Address,
pub status... | 1bb6b69e7cd864a337df04d0ae5575c1eea6c2f1 | 958798ecbe6063a040fc32f41cd66ab3906841c8 | diff --git a/packages/fuels-core/src/types/wrappers/coin.rs b/packages/fuels-core/src/types/wrappers/coin.rs
index c1daeed1ae..76b1b62c5b 100644
--- a/packages/fuels-core/src/types/wrappers/coin.rs
+++ b/packages/fuels-core/src/types/wrappers/coin.rs
@@ -8,32 +8,21 @@ use fuel_core_client::client::types::{
use crate... | [
"packages/fuels-core/src/types/wrappers/coin.rs",
"packages/fuels-programs/src/calls/utils.rs",
"packages/fuels-test-helpers/src/lib.rs"
] | [] | true | |
FuelLabs/fuels-rs | 1,657 | issue_to_patch | chore: bump version to `0.73.0` | Bumping to 0.73.0 to get a fuels-rs version with fuel-core v0.43.2 as supported version, mainly to keep the version parity between sway <-> forc-wallet <-> fuels-rs <-> fuel-core
# Checklist
- [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **changes** are **documented** (or not ap... | 69ce346bd6bde36bd7b44fa556a7cda4c8fce24e | 602a2340b720d1ec42f1cfde8e824f67539a3760 | diff --git a/Cargo.toml b/Cargo.toml
index dd46e20801..d2704574ef 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -39,7 +39,7 @@ readme = "README.md"
license = "Apache-2.0"
repository = "https://github.com/FuelLabs/fuels-rs"
rust-version = "1.85.0"
-version = "0.72.0"
+version = "0.73.0"
[workspace.dependencies]
Inf... | [
"Cargo.toml",
"docs/src/connecting/short-lived.md"
] | [] | true | ||
FuelLabs/fuels-rs | 1,651 | issue_to_patch | Support for new abi errors
Abi errors are introduced in the following RFC: https://github.com/FuelLabs/sway-rfcs/blob/master/rfcs/0014-abi-errors.md
Compiler progress is tracked on:
- https://github.com/FuelLabs/sway/issues/6765
Tooling progress is tracked on:
- https://github.com/FuelLabs/sway/issues/7089 | feat!: add support for abi errors | closes: https://github.com/FuelLabs/fuels-rs/issues/1648
# Release notes
In this release, we:
- Added support for the new abi errors. See the [RFC](https://github.com/FuelLabs/sway-rfcs/blob/master/rfcs/0014-abi-errors.md) for more information.
# Summary
- Updated `fuel-abi-types` to `v0.12.0`. This vers... | 07a171d8dfa31175b39fe09f9582d937d81ba62f | 5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 729d1057fe..e871ab05af 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -21,7 +21,7 @@ env:
FUEL_CORE_PATCH_REVISION: ""
RUST_VERSION: 1.85.0
FORC_VERSION: 0.68.0
- FORC_PATCH_BRANCH: ""
+ FORC_PATCH_BRANCH: "ironce... | [
".github/workflows/ci.yml",
"Cargo.toml",
"e2e/Forc.toml",
"e2e/sway/logs/contract_logs/src/main.sw",
"e2e/sway/logs/contract_logs_abi/src/main.sw",
"e2e/sway/logs/contract_revert_logs/Forc.toml",
"e2e/sway/logs/contract_revert_logs/src/main.sw",
"e2e/sway/logs/contract_with_contract_logs/src/main.sw"... | [
{
"comment": "This sway projects was just moved to the `logs` folder",
"path": "e2e/sway/logs/script_revert_logs/src/main.sw",
"hunk": "@@ -0,0 +1,96 @@\n+script;",
"resolving_sha": "5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e",
"resolving_diff": "diff --git a/e2e/sway/logs/script_revert_logs/src/m... | diff --git a/e2e/tests/logs.rs b/e2e/tests/logs.rs
index 1dd729db87..aceba07ed9 100644
--- a/e2e/tests/logs.rs
+++ b/e2e/tests/logs.rs
@@ -5,7 +5,7 @@ use fuels::{
};
#[tokio::test]
-async fn test_parse_logged_variables() -> Result<()> {
+async fn parse_logged_variables() -> Result<()> {
setup_program_test!(
... | true |
FuelLabs/fuels-rs | 1,651 | comment_to_fix | feat!: add support for abi errors | This sway projects was just moved to the `logs` folder | 07a171d8dfa31175b39fe09f9582d937d81ba62f | 5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e | diff --git a/e2e/sway/logs/script_revert_logs/src/main.sw b/e2e/sway/logs/script_revert_logs/src/main.sw
new file mode 100644
index 0000000000..5d38afcf6e
--- /dev/null
+++ b/e2e/sway/logs/script_revert_logs/src/main.sw
@@ -0,0 +1,96 @@
+script;
+
+use std::logging::log;
+
+#[allow(dead_code)]
+enum EnumWithGeneric<D> ... | [
"e2e/sway/logs/script_revert_logs/src/main.sw"
] | [
{
"comment": "This sway projects was just moved to the `logs` folder",
"path": "e2e/sway/logs/script_revert_logs/src/main.sw",
"hunk": "@@ -0,0 +1,96 @@\n+script;",
"resolving_sha": "5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e",
"resolving_diff": "diff --git a/e2e/sway/logs/script_revert_logs/src/m... | true | ||
FuelLabs/fuels-rs | 1,651 | comment_to_fix | feat!: add support for abi errors | I think there is no substitution in the assert message here, you're just going to get a print of
```message: "{msg}" not container in reason: "{reason}"``` | 07a171d8dfa31175b39fe09f9582d937d81ba62f | 5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e | diff --git a/e2e/tests/logs.rs b/e2e/tests/logs.rs
index 1dd729db87..aceba07ed9 100644
--- a/e2e/tests/logs.rs
+++ b/e2e/tests/logs.rs
@@ -5,7 +5,7 @@ use fuels::{
};
#[tokio::test]
-async fn test_parse_logged_variables() -> Result<()> {
+async fn parse_logged_variables() -> Result<()> {
setup_program_test!(
... | [
"e2e/tests/logs.rs"
] | [
{
"comment": "I think there is no substitution in the assert message here, you're just going to get a print of \r\n```message: \"{msg}\" not container in reason: \"{reason}\"```",
"path": "e2e/tests/logs.rs",
"hunk": "@@ -425,22 +421,23 @@ async fn test_multi_call_contract_with_contract_logs() -> Result... | true | ||
FuelLabs/fuels-rs | 1,651 | comment_to_fix | feat!: add support for abi errors | Don't need a vector
```suggestion
let error_codes = quote! {::std::collections::HashMap::from([#(#error_codes),*])};
``` | 07a171d8dfa31175b39fe09f9582d937d81ba62f | 5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e | diff --git a/packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs b/packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs
index 37f5e0d6b4..17ecabd997 100644
--- a/packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs
+++ b/packages/fuels-code-gen/src/program_bi... | [
"packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs"
] | [
{
"comment": "Don't need a vector\r\n```suggestion\r\n let error_codes = quote! {::std::collections::HashMap::from([#(#error_codes),*])};\r\n```",
"path": "packages/fuels-code-gen/src/program_bindings/abigen/bindings/contract.rs",
"hunk": "@@ -28,6 +28,9 @@ pub(crate) fn contract_bindings(\n let ... | true | ||
FuelLabs/fuels-rs | 1,651 | comment_to_fix | feat!: add support for abi errors | Can the LogFormatter be used for formatting errors as well? | 07a171d8dfa31175b39fe09f9582d937d81ba62f | 5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e | diff --git a/packages/fuels-core/src/codec/logs.rs b/packages/fuels-core/src/codec/logs.rs
index c8c533f07a..274a45a184 100644
--- a/packages/fuels-core/src/codec/logs.rs
+++ b/packages/fuels-core/src/codec/logs.rs
@@ -5,6 +5,36 @@ use std::{
iter::FilterMap,
};
+#[derive(Debug, Clone)]
+pub struct ErrorDetails... | [
"packages/fuels-core/src/codec/logs.rs"
] | [
{
"comment": "Can the LogFormatter be used for formatting errors as well?",
"path": "packages/fuels-core/src/codec/logs.rs",
"hunk": "@@ -53,6 +99,38 @@ impl Debug for LogFormatter {\n }\n }\n \n+#[derive(Clone)]\n+pub struct ErrorFormatter {",
"resolving_sha": "5ef0025e6e14a982ae93d8bd36ba1adf1... | true | ||
FuelLabs/fuels-rs | 1,651 | comment_to_fix | feat!: add support for abi errors | TODO | 07a171d8dfa31175b39fe09f9582d937d81ba62f | 5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e | diff --git a/packages/fuels-core/src/codec/logs.rs b/packages/fuels-core/src/codec/logs.rs
index c8c533f07a..274a45a184 100644
--- a/packages/fuels-core/src/codec/logs.rs
+++ b/packages/fuels-core/src/codec/logs.rs
@@ -5,6 +5,36 @@ use std::{
iter::FilterMap,
};
+#[derive(Debug, Clone)]
+pub struct ErrorDetails... | [
"packages/fuels-core/src/codec/logs.rs"
] | [
{
"comment": "TODO",
"path": "packages/fuels-core/src/codec/logs.rs",
"hunk": "@@ -62,6 +140,8 @@ pub struct LogId(ContractId, String);\n pub struct LogDecoder {\n /// A mapping of LogId and param-type\n log_formatters: HashMap<LogId, LogFormatter>,\n+ //TODO: add error_formatters",
"reso... | true | ||
FuelLabs/fuels-rs | 1,651 | comment_to_fix | feat!: add support for abi errors | TODO | 07a171d8dfa31175b39fe09f9582d937d81ba62f | 5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e | diff --git a/packages/fuels-core/src/codec/logs.rs b/packages/fuels-core/src/codec/logs.rs
index c8c533f07a..274a45a184 100644
--- a/packages/fuels-core/src/codec/logs.rs
+++ b/packages/fuels-core/src/codec/logs.rs
@@ -5,6 +5,36 @@ use std::{
iter::FilterMap,
};
+#[derive(Debug, Clone)]
+pub struct ErrorDetails... | [
"packages/fuels-core/src/codec/logs.rs"
] | [
{
"comment": "TODO",
"path": "packages/fuels-core/src/codec/logs.rs",
"hunk": "@@ -184,6 +272,8 @@ impl LogDecoder {\n \n pub fn merge(&mut self, log_decoder: LogDecoder) {\n self.log_formatters.extend(log_decoder.log_formatters);\n+ self.error_codes.extend(log_decoder.error_codes);\n... | true | ||
FuelLabs/fuels-rs | 1,651 | comment_to_fix | feat!: add support for abi errors | ```suggestion
if let Some(error_detail) = log_decoder.get_error_codes(&revert_id) {
``` | 07a171d8dfa31175b39fe09f9582d937d81ba62f | 5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e | diff --git a/packages/fuels-core/src/types/tx_status.rs b/packages/fuels-core/src/types/tx_status.rs
index f8db6fe0df..7f3b7caafc 100644
--- a/packages/fuels-core/src/types/tx_status.rs
+++ b/packages/fuels-core/src/types/tx_status.rs
@@ -118,6 +118,35 @@ impl TxStatus {
revert_id: Option<u64>,
log_de... | [
"packages/fuels-core/src/types/tx_status.rs"
] | [
{
"comment": "```suggestion\r\n if let Some(error_detail) = log_decoder.get_error_codes(&revert_id) {\r\n```",
"path": "packages/fuels-core/src/types/tx_status.rs",
"hunk": "@@ -118,6 +118,35 @@ impl TxStatus {\n revert_id: Option<u64>,\n log_decoder: Option<&LogDecoder>,\n ... | true | ||
FuelLabs/fuels-rs | 1,651 | comment_to_fix | feat!: add support for abi errors | Should this be present even post merge? I'd assume we don't want to have a patch branch on master, but don't have enough context to know for sure. | 07a171d8dfa31175b39fe09f9582d937d81ba62f | 5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 729d1057fe..e871ab05af 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -21,7 +21,7 @@ env:
FUEL_CORE_PATCH_REVISION: ""
RUST_VERSION: 1.85.0
FORC_VERSION: 0.68.0
- FORC_PATCH_BRANCH: ""
+ FORC_PATCH_BRANCH: "ironce... | [
".github/workflows/ci.yml"
] | [
{
"comment": "Should this be present even post merge? I'd assume we don't want to have a patch branch on master, but don't have enough context to know for sure.",
"path": ".github/workflows/ci.yml",
"hunk": "@@ -21,7 +21,7 @@ env:\n FUEL_CORE_PATCH_REVISION: \"\"\n RUST_VERSION: 1.85.0\n FORC_VERS... | true | ||
FuelLabs/fuels-rs | 1,651 | comment_to_fix | feat!: add support for abi errors | This also feels like something that we should clean up before merging. | 07a171d8dfa31175b39fe09f9582d937d81ba62f | 5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e | diff --git a/e2e/Forc.toml b/e2e/Forc.toml
index 357aad5f8c..78548928f9 100644
--- a/e2e/Forc.toml
+++ b/e2e/Forc.toml
@@ -24,7 +24,6 @@ members = [
'sway/contracts/needs_custom_decoder',
'sway/contracts/payable_annotation',
'sway/contracts/proxy',
- 'sway/contracts/revert_logs',
'sway/contracts/revert_tra... | [
"e2e/Forc.toml"
] | [
{
"comment": "This also feels like something that we should clean up before merging.",
"path": "e2e/Forc.toml",
"hunk": "@@ -118,3 +118,6 @@ members = [\n 'sway/types/scripts/script_u256',\n 'sway/types/scripts/script_vectors',\n ]\n+\n+[patch.'https://github.com/fuellabs/sway']\n+std = { git = \"ht... | true | ||
FuelLabs/fuels-rs | 1,651 | comment_to_fix | feat!: add support for abi errors | Nit: I think we can return an iterator here, to allow the caller to decide if they want to collect the results or apply any other transformation on them.
Probably overkill here though. | 07a171d8dfa31175b39fe09f9582d937d81ba62f | 5ef0025e6e14a982ae93d8bd36ba1adf1219ff4e | diff --git a/packages/fuels-code-gen/src/program_bindings/abigen/logs.rs b/packages/fuels-code-gen/src/program_bindings/abigen/logs.rs
index 744134b789..f2cd54b803 100644
--- a/packages/fuels-code-gen/src/program_bindings/abigen/logs.rs
+++ b/packages/fuels-code-gen/src/program_bindings/abigen/logs.rs
@@ -28,26 +28,68 ... | [
"packages/fuels-code-gen/src/program_bindings/abigen/logs.rs"
] | [
{
"comment": "Nit: I think we can return an iterator here, to allow the caller to decide if they want to collect the results or apply any other transformation on them.\r\n\r\nProbably overkill here though.",
"path": "packages/fuels-code-gen/src/program_bindings/abigen/logs.rs",
"hunk": "@@ -51,3 +66,34 ... | true | ||
FuelLabs/fuels-rs | 1,656 | issue_to_patch | chore!: bump fuel-core to 0.43.2 | - [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **changes** are **documented** (or not applicable)
- [x] I **reviewed** the **entire PR** myself (preferably, on GH UI)
- [x] I **described** all **Breaking Changes** (or there's none)
| dbc896f97765f1db5a30ac1d51b0ba69baa448aa | a75924470fe8aed9ba3a80dad2a1a5d9c7da4041 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index eed3823358..729d1057fe 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ env:
CARGO_TERM_COLOR: always
DASEL_VERSION: https://github.com/TomWright/dasel/releases/download/v2.3.6/dasel_linux_amd64
RUSTFLA... | [
".github/workflows/ci.yml",
"Cargo.toml",
"packages/fuels-accounts/src/provider/supported_fuel_core_version.rs"
] | [] | true | ||
FuelLabs/fuels-rs | 1,653 | issue_to_patch | chore: bump versions | 5c820612fbe0dfa8b489ac34bdf7620389905dab | 24c9825b45d39fc616b17291b42300a612343248 | diff --git a/Cargo.toml b/Cargo.toml
index 71a58b772e..bf851669db 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -39,7 +39,7 @@ readme = "README.md"
license = "Apache-2.0"
repository = "https://github.com/FuelLabs/fuels-rs"
rust-version = "1.85.0"
-version = "0.71.0"
+version = "0.72.0"
[workspace.dependencies]
Inf... | [
"Cargo.toml",
"docs/src/connecting/short-lived.md"
] | [] | true | |||
FuelLabs/fuels-rs | 1,654 | issue_to_patch | chore: bump `forc` to `0.68.0` | 8da57918ca5035cf5227f756e67e824918ec2bf9 | c55ddad51f39ba0538ceb9da61ed97f4a5e2b295 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index bbdd5edc1d..eed3823358 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -20,7 +20,7 @@ env:
FUEL_CORE_PATCH_BRANCH: ""
FUEL_CORE_PATCH_REVISION: ""
RUST_VERSION: 1.85.0
- FORC_VERSION: 0.67.0
+ FORC_VERSION: 0.68.0
... | [
".github/workflows/ci.yml",
"e2e/sway/types/contracts/vectors/src/eq_impls.sw",
"e2e/sway/types/contracts/vectors/src/main.sw",
"e2e/sway/types/scripts/script_vectors/src/eq_impls.sw"
] | [] | true | |||
FuelLabs/fuels-rs | 1,652 | issue_to_patch | chore!: bump fuel core to 0 43 1 |
# Checklist
- [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **changes** are **documented** (or not applicable)
- [x] I **reviewed** the **entire PR** myself (preferably, on GH UI)
- [x] I **described** all **Breaking Changes** (or there's none)
| 45743727cc3d948f44f7fb85f323e92db338387d | 9ac46964b0a5e18978b415b6835f81c2d00e74d4 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0d5fc85718..bbdd5edc1d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ env:
CARGO_TERM_COLOR: always
DASEL_VERSION: https://github.com/TomWright/dasel/releases/download/v2.3.6/dasel_linux_amd64
RUSTFLA... | [
".github/workflows/ci.yml",
"Cargo.toml",
"packages/fuels-accounts/src/provider/supported_fuel_core_version.rs"
] | [] | true | ||
FuelLabs/fuels-rs | 1,646 | issue_to_patch | fix outstanding TODOs regarding transaction fees
I have found several TODOs referencing https://github.com/FuelLabs/fuels-rs/issues/1394 that can be easily fixed. | chore: fix some remaining todos regarding transaction fees | closes: https://github.com/FuelLabs/fuels-rs/issues/1645
# Checklist
- [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **changes** are **documented** (or not applicable)
- [x] I **reviewed** the **entire PR** myself (preferably, on GH UI)
- [x] I **described** all **Breaking Chan... | 2c09e6321e5a23801bd54a9698408f6c50779906 | a2937ab99f1b82272897dbc856a67b586dbe079a | [
"e2e/tests/predicates.rs",
"e2e/tests/wallets.rs"
] | [] | diff --git a/e2e/tests/predicates.rs b/e2e/tests/predicates.rs
index ac6d697532..33209c6b30 100644
--- a/e2e/tests/predicates.rs
+++ b/e2e/tests/predicates.rs
@@ -1141,14 +1141,13 @@ async fn predicate_blobs() -> Result<()> {
// gonna make later on
// ANCHOR: uploading_the_blob
loader.upload_blob(extra_w... | true | |
FuelLabs/fuels-rs | 1,644 | issue_to_patch | Add support for preconfirmation statuses
`fuel-core` `v0.43.0` adds support for preconfirmation statuses. The sdk should expose the new endpoints. | feat: add support for preconfirmations | Closes #1642
# Release notes
Add support of pre confirmations.
In this release, we:
- Added two need functions in the `Provider` to access preconfirmations `send_transaction_and_await_status` and `subscribe_transaction_status`
# Checklist
- [x] All **changes** are **covered** by **tests** (or not app... | 48edbfd1d6f686483a96b51df4c857b2174f4d20 | 24ceeb0d64fbec61e76fe8aa95a3e6404bad6e20 | diff --git a/e2e/Cargo.toml b/e2e/Cargo.toml
index 733856acd6..836dd4eb48 100644
--- a/e2e/Cargo.toml
+++ b/e2e/Cargo.toml
@@ -37,6 +37,7 @@ fuels = { workspace = true, features = [
"accounts-signer-aws-kms",
"test-helpers",
] }
+futures = { workspace = true }
testcontainers = { workspace = true }
tokio = { wo... | [
"e2e/Cargo.toml",
"e2e/tests/providers.rs",
"packages/fuels-accounts/Cargo.toml",
"packages/fuels-accounts/src/provider.rs",
"packages/fuels-accounts/src/provider/retryable_client.rs",
"packages/fuels-core/src/types/tx_status.rs",
"packages/fuels-test-helpers/src/fuel_bin_service.rs",
"packages/fuels-... | [
{
"comment": "If we do all steps from above we can use the same asserts as with subscribe:\r\n```suggestion\r\n assert!(matches!(\r\n status.next().await.unwrap().unwrap(),\r\n TxStatus::Submitted { .. }\r\n ));\r\n assert!(matches!(\r\n status.next().await.unwrap().unwrap(),\r\n ... | diff --git a/e2e/tests/providers.rs b/e2e/tests/providers.rs
index 7cd66bc87a..d47f12c2de 100644
--- a/e2e/tests/providers.rs
+++ b/e2e/tests/providers.rs
@@ -19,6 +19,7 @@ use fuels::{
tx_status::{Success, TxStatus},
},
};
+use futures::StreamExt;
use rand::thread_rng;
#[tokio::test]
@@ -1011,6 +101... | true |
FuelLabs/fuels-rs | 1,644 | comment_to_fix | feat: add support for preconfirmations | If we do all steps from above we can use the same asserts as with subscribe:
```suggestion
assert!(matches!(
status.next().await.unwrap().unwrap(),
TxStatus::Submitted { .. }
));
assert!(matches!(
status.next().await.unwrap().unwrap(),
TxStatus::PreconfirmationSuccess... | 48edbfd1d6f686483a96b51df4c857b2174f4d20 | 24ceeb0d64fbec61e76fe8aa95a3e6404bad6e20 | diff --git a/e2e/tests/providers.rs b/e2e/tests/providers.rs
index 7cd66bc87a..d47f12c2de 100644
--- a/e2e/tests/providers.rs
+++ b/e2e/tests/providers.rs
@@ -19,6 +19,7 @@ use fuels::{
tx_status::{Success, TxStatus},
},
};
+use futures::StreamExt;
use rand::thread_rng;
#[tokio::test]
@@ -1011,6 +101... | [
"e2e/tests/providers.rs"
] | [
{
"comment": "If we do all steps from above we can use the same asserts as with subscribe:\r\n```suggestion\r\n assert!(matches!(\r\n status.next().await.unwrap().unwrap(),\r\n TxStatus::Submitted { .. }\r\n ));\r\n assert!(matches!(\r\n status.next().await.unwrap().unwrap(),\r\n ... | true | ||
FuelLabs/fuels-rs | 1,644 | comment_to_fix | feat: add support for preconfirmations | Maybe we can eliminate the falkyness with a custom block production interval?
```suggestion
let block_time = 3u32;
let config = NodeConfig {
block_production: Trigger::Interval {
block_time: std::time::Duration::from_secs(block_time.into()),
},
..NodeConfig::default()... | 48edbfd1d6f686483a96b51df4c857b2174f4d20 | 24ceeb0d64fbec61e76fe8aa95a3e6404bad6e20 | diff --git a/e2e/tests/providers.rs b/e2e/tests/providers.rs
index 7cd66bc87a..d47f12c2de 100644
--- a/e2e/tests/providers.rs
+++ b/e2e/tests/providers.rs
@@ -19,6 +19,7 @@ use fuels::{
tx_status::{Success, TxStatus},
},
};
+use futures::StreamExt;
use rand::thread_rng;
#[tokio::test]
@@ -1011,6 +101... | [
"e2e/tests/providers.rs"
] | [
{
"comment": "Maybe we can eliminate the falkyness with a custom block production interval?\r\n```suggestion\r\n let block_time = 3u32;\r\n let config = NodeConfig {\r\n block_production: Trigger::Interval {\r\n block_time: std::time::Duration::from_secs(block_time.into()),\r\n }... | true | ||
FuelLabs/fuels-rs | 1,644 | comment_to_fix | feat: add support for preconfirmations | If the custom block production interval fixes flakyness we can return to the previous asserts.
```suggestion
assert!(matches!(
status.next().await.unwrap().unwrap(),
TxStatus::Submitted { .. }
));
assert!(matches!(
status.next().await.unwrap().unwrap(),
TxStatus::Prec... | 48edbfd1d6f686483a96b51df4c857b2174f4d20 | 24ceeb0d64fbec61e76fe8aa95a3e6404bad6e20 | diff --git a/e2e/tests/providers.rs b/e2e/tests/providers.rs
index 7cd66bc87a..d47f12c2de 100644
--- a/e2e/tests/providers.rs
+++ b/e2e/tests/providers.rs
@@ -19,6 +19,7 @@ use fuels::{
tx_status::{Success, TxStatus},
},
};
+use futures::StreamExt;
use rand::thread_rng;
#[tokio::test]
@@ -1011,6 +101... | [
"e2e/tests/providers.rs"
] | [
{
"comment": "If the custom block production interval fixes flakyness we can return to the previous asserts.\r\n```suggestion\r\n assert!(matches!(\r\n status.next().await.unwrap().unwrap(),\r\n TxStatus::Submitted { .. }\r\n ));\r\n assert!(matches!(\r\n status.next().await.unwrap... | true | ||
FuelLabs/fuels-rs | 1,644 | comment_to_fix | feat: add support for preconfirmations | If we change the fn signature in `fuel-core-client` we can simplify the fn:
```suggestion
pub async fn send_transaction_and_await_status<T: Transaction>(
&self,
tx: T,
include_preconfirmation: bool,
) -> Result<impl futures::Stream<Item = Result<TxStatus>>> {
#[cfg(feature... | 48edbfd1d6f686483a96b51df4c857b2174f4d20 | 24ceeb0d64fbec61e76fe8aa95a3e6404bad6e20 | diff --git a/packages/fuels-accounts/src/provider.rs b/packages/fuels-accounts/src/provider.rs
index 84bcf875a0..0d40ba5960 100644
--- a/packages/fuels-accounts/src/provider.rs
+++ b/packages/fuels-accounts/src/provider.rs
@@ -45,6 +45,7 @@ use fuels_core::{
tx_status::TxStatus,
},
};
+use futures::Strea... | [
"packages/fuels-accounts/src/provider.rs"
] | [
{
"comment": "If we change the fn signature in `fuel-core-client` we can simplify the fn:\r\n```suggestion\r\n pub async fn send_transaction_and_await_status<T: Transaction>(\r\n &self,\r\n tx: T,\r\n include_preconfirmation: bool,\r\n ) -> Result<impl futures::Stream<Item = Result<Tx... | true | ||
FuelLabs/fuels-rs | 1,644 | comment_to_fix | feat: add support for preconfirmations | If we change the fn signature in `fuel-core-client`:
```suggestion
pub async fn submit_and_await_status(
&self,
tx: Transaction,
include_preconfirmation: bool,
) -> RequestResult<impl Stream<Item = io::Result<TransactionStatus>>> {
self.wrap(|| {
self.client
... | 48edbfd1d6f686483a96b51df4c857b2174f4d20 | 24ceeb0d64fbec61e76fe8aa95a3e6404bad6e20 | diff --git a/packages/fuels-accounts/src/provider/retryable_client.rs b/packages/fuels-accounts/src/provider/retryable_client.rs
index 0ea568e884..056108bec0 100644
--- a/packages/fuels-accounts/src/provider/retryable_client.rs
+++ b/packages/fuels-accounts/src/provider/retryable_client.rs
@@ -18,6 +18,7 @@ use fuel_co... | [
"packages/fuels-accounts/src/provider/retryable_client.rs"
] | [
{
"comment": "If we change the fn signature in `fuel-core-client`:\r\n ```suggestion\r\n pub async fn submit_and_await_status(\r\n &self,\r\n tx: Transaction,\r\n include_preconfirmation: bool,\r\n ) -> RequestResult<impl Stream<Item = io::Result<TransactionStatus>>> {\r\n self... | true | ||
FuelLabs/fuels-rs | 1,644 | comment_to_fix | feat: add support for preconfirmations | If we do all above I would not add this. Less code to maintain :)
```suggestion
``` | 48edbfd1d6f686483a96b51df4c857b2174f4d20 | 24ceeb0d64fbec61e76fe8aa95a3e6404bad6e20 | diff --git a/packages/fuels-core/src/types/tx_status.rs b/packages/fuels-core/src/types/tx_status.rs
index ee9e9037c7..f8db6fe0df 100644
--- a/packages/fuels-core/src/types/tx_status.rs
+++ b/packages/fuels-core/src/types/tx_status.rs
@@ -170,6 +170,13 @@ impl TxStatus {
_ => vec![],
}
}
+
+ ... | [
"packages/fuels-core/src/types/tx_status.rs"
] | [
{
"comment": "If we do all above I would not add this. Less code to maintain :)\r\n```suggestion\r\n```",
"path": "packages/fuels-core/src/types/tx_status.rs",
"hunk": "@@ -170,6 +170,13 @@ impl TxStatus {\n _ => vec![],\n }\n }\n+\n+ pub fn is_final(&self) -> bool {\n+ ... | true | ||
FuelLabs/fuels-rs | 1,644 | comment_to_fix | feat: add support for preconfirmations | A slightly different approach:
```rust
#[cfg(feature = "coin-cache")]
let base_asset_id = *self.consensus_parameters().await?.base_asset_id();
#[cfg(feature = "coin-cache")]
let used_base_coins = tx.used_coins(&base_asset_id);
#[cfg(feature = "coin-cache")]
self.... | 48edbfd1d6f686483a96b51df4c857b2174f4d20 | 24ceeb0d64fbec61e76fe8aa95a3e6404bad6e20 | diff --git a/packages/fuels-accounts/src/provider.rs b/packages/fuels-accounts/src/provider.rs
index 84bcf875a0..0d40ba5960 100644
--- a/packages/fuels-accounts/src/provider.rs
+++ b/packages/fuels-accounts/src/provider.rs
@@ -45,6 +45,7 @@ use fuels_core::{
tx_status::TxStatus,
},
};
+use futures::Strea... | [
"packages/fuels-accounts/src/provider.rs"
] | [
{
"comment": "A slightly different approach:\r\n```rust\r\n #[cfg(feature = \"coin-cache\")]\r\n let base_asset_id = *self.consensus_parameters().await?.base_asset_id();\r\n #[cfg(feature = \"coin-cache\")]\r\n let used_base_coins = tx.used_coins(&base_asset_id);\r\n\r\n #[cfg... | true | ||
FuelLabs/fuels-rs | 1,644 | comment_to_fix | feat: add support for preconfirmations | I'd rather avoid having a sync::Mutex in async code if possible. Albeit most of the operations shouldn't block for too long. | 48edbfd1d6f686483a96b51df4c857b2174f4d20 | 24ceeb0d64fbec61e76fe8aa95a3e6404bad6e20 | diff --git a/packages/fuels-accounts/src/provider.rs b/packages/fuels-accounts/src/provider.rs
index 84bcf875a0..0d40ba5960 100644
--- a/packages/fuels-accounts/src/provider.rs
+++ b/packages/fuels-accounts/src/provider.rs
@@ -45,6 +45,7 @@ use fuels_core::{
tx_status::TxStatus,
},
};
+use futures::Strea... | [
"packages/fuels-accounts/src/provider.rs"
] | [
{
"comment": "I'd rather avoid having a sync::Mutex in async code if possible. Albeit most of the operations shouldn't block for too long.",
"path": "packages/fuels-accounts/src/provider.rs",
"hunk": "@@ -301,7 +366,10 @@ impl Provider {\n self.check_inputs_already_in_cache(&used_utxos).await?;\... | true | ||
FuelLabs/fuels-rs | 1,606 | issue_to_patch | `adjust_for_fee` will silently fail if the missing amount can not be covered with coins
`adjust_for_fee` will silently fail if the missing amount can not be covered with coins. We should error an appropriate error message to the user. | chore: return error when adjusting for fee | closes: https://github.com/FuelLabs/fuels-rs/issues/1587
# Summary
Currently we ignore an error (old behavior) if a query to get coins to adjust for fee fails.
This PR will return the error and add additional context.
The error we previously returned when requesting for resources failed:
```
io error: Res... | 6f6e864d265fa50a5a07df963583ee4e7a98dd97 | 985d1ca7c2f7939b3fd23f0d5187f3088b1e4e2e | diff --git a/packages/fuels-accounts/src/account.rs b/packages/fuels-accounts/src/account.rs
index 5e9b2aafeb..1ee6534e47 100644
--- a/packages/fuels-accounts/src/account.rs
+++ b/packages/fuels-accounts/src/account.rs
@@ -9,7 +9,7 @@ use fuels_core::types::{
coin::Coin,
coin_type::CoinType,
coin_type_id... | [
"e2e/tests/contracts.rs",
"packages/fuels-accounts/src/account.rs",
"packages/fuels-programs/src/calls/traits/transaction_tuner.rs",
"packages/fuels-programs/src/calls/utils.rs",
"packages/fuels-programs/src/contract/loader.rs",
"packages/fuels-programs/src/contract/regular.rs",
"packages/fuels-programs... | [] | diff --git a/e2e/tests/contracts.rs b/e2e/tests/contracts.rs
index 3450ddcf26..0a38d02516 100644
--- a/e2e/tests/contracts.rs
+++ b/e2e/tests/contracts.rs
@@ -2603,6 +2603,32 @@ async fn loader_storage_works_via_proxy() -> Result<()> {
Ok(())
}
+#[tokio::test]
+async fn adjust_for_fee_errors() -> Result<()> {
+... | true |
FuelLabs/fuels-rs | 1,640 | issue_to_patch | chore: bump `fuel-core` to `v0.43.0` | I would only bump `fuel-core` in this PR and make additional issues/PRs for preconfirmation support.
@rymnc do you need the feature flags that you have in this [PR](https://github.com/FuelLabs/fuels-rs/pull/1639)? | 9e93f0f0710fa23eee8f7ede569081dedd3a7e27 | 55084c2650b8466732dcdd2d2ef5527b73c13724 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 75e24eeda9..0d5fc85718 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ env:
CARGO_TERM_COLOR: always
DASEL_VERSION: https://github.com/TomWright/dasel/releases/download/v2.3.6/dasel_linux_amd64
RUSTFLA... | [
".github/workflows/ci.yml",
"Cargo.toml",
"packages/fuels-accounts/Cargo.toml",
"packages/fuels-accounts/src/provider/supported_fuel_core_version.rs",
"packages/fuels-accounts/src/schema/schema.sdl",
"packages/fuels-core/Cargo.toml",
"packages/fuels-programs/Cargo.toml",
"packages/fuels-test-helpers/C... | [] | true | ||
FuelLabs/fuels-rs | 1,638 | issue_to_patch | chore: update public key recovery example in docs | # Summary
<!--
Please write a summary of your changes and why you made them.
Not all PRs will be complex or substantial enough to require this
section, so you can remove it if you think it's unnecessary.
-->
When viewing the [docs hub example](https://docs.fuel.network/docs/fuels-rs/wallets/signing/#signing) ... | 966d34bf68db26ee1228be3d11558e002ea2aefc | 02aabbe776ae7e1f2019a6a5f5664a395b6dca99 | diff --git a/packages/fuels-accounts/src/signers/private_key.rs b/packages/fuels-accounts/src/signers/private_key.rs
index c321ee356b..7a3890ca34 100644
--- a/packages/fuels-accounts/src/signers/private_key.rs
+++ b/packages/fuels-accounts/src/signers/private_key.rs
@@ -109,13 +109,13 @@ mod tests {
)?
... | [
"packages/fuels-accounts/src/signers/private_key.rs"
] | [] | true | ||
FuelLabs/fuels-rs | 1,636 | issue_to_patch | chore: fix flaky `coin caching` test | The `coin caching` test was flaky as the node returns a random number of coins when requesting a certain amount. This led the test to fail when no more coins were available.
I have increased the initial amount of coins and did not change the the test logic.
# Checklist
- [x] All **changes** are **covered** by ... | c37ce72da25234d08eeca1b2774a82c014612423 | a3940bbb3d124cee68d7b9c44da4d8fae380c191 | [
"e2e/tests/providers.rs"
] | [] | diff --git a/e2e/tests/providers.rs b/e2e/tests/providers.rs
index 094fe506bb..7cd66bc87a 100644
--- a/e2e/tests/providers.rs
+++ b/e2e/tests/providers.rs
@@ -836,9 +836,9 @@ async fn transactions_with_the_same_utxo() -> Result<()> {
#[cfg(feature = "coin-cache")]
#[tokio::test]
-async fn test_caching() -> Result<(... | true | ||
FuelLabs/fuels-rs | 1,635 | issue_to_patch | chore: update codeowners | 336abcd14ca3c8045cc13daf8d8056596b93bebd | 23c593e08c91a6f47ff9d274756318e7d5e4306a | diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index ccbfa9d788..27aa96e8d0 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -1,1 +1,1 @@
-* @digorithm @hal3e @MujkicA @segfault-magnet @Salka1988 @Br1ght0ne
+* @FuelLabs/client
| [
".github/CODEOWNERS"
] | [
{
"comment": "could we just do \r\n```suggestion\r\n* @FuelLabs/client \r\n```\r\n?",
"path": ".github/CODEOWNERS",
"hunk": "@@ -1 +1 @@\n-* @digorithm @hal3e @MujkicA @segfault-magnet @Salka1988 @Br1ght0ne\n+* @hal3e @segfault-magnet @xgreenx @Dentosal @MitchTurner @netrome @AurelienFT @rymnc",
"re... | true | |||
FuelLabs/fuels-rs | 1,635 | comment_to_fix | chore: update codeowners | could we just do
```suggestion
* @FuelLabs/client
```
? | 336abcd14ca3c8045cc13daf8d8056596b93bebd | 23c593e08c91a6f47ff9d274756318e7d5e4306a | diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index ccbfa9d788..27aa96e8d0 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -1,1 +1,1 @@
-* @digorithm @hal3e @MujkicA @segfault-magnet @Salka1988 @Br1ght0ne
+* @FuelLabs/client
| [
".github/CODEOWNERS"
] | [
{
"comment": "could we just do \r\n```suggestion\r\n* @FuelLabs/client \r\n```\r\n?",
"path": ".github/CODEOWNERS",
"hunk": "@@ -1 +1 @@\n-* @digorithm @hal3e @MujkicA @segfault-magnet @Salka1988 @Br1ght0ne\n+* @hal3e @segfault-magnet @xgreenx @Dentosal @MitchTurner @netrome @AurelienFT @rymnc",
"re... | true | ||
FuelLabs/fuels-rs | 1,628 | issue_to_patch | feat: bump `fuel-core` to `0.42.0` | # Release notes
In this release, we:
- Bumped `fuel-core` to `0.42.0`
- Added support for simulating calls at specific block height
# Breaking Changes
- **Error Variant Renaming:**
- The transaction `Reason` error variant previously named `Reverted` in transaction errors is now renamed to `Failure`.
... | 3f84ea37d4dd4f4fe75397c967e107e7c716f825 | 599c8b6e143e79627815170ea42e6d79a59b1ecf | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index e043d59c52..75e24eeda9 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ env:
CARGO_TERM_COLOR: always
DASEL_VERSION: https://github.com/TomWright/dasel/releases/download/v2.3.6/dasel_linux_amd64
RUSTFLA... | [
".github/workflows/ci.yml",
"Cargo.toml",
"docs/src/calling-contracts/simulation.md",
"docs/src/calling-contracts/tx-dependency-estimation.md",
"e2e/tests/contracts.rs",
"e2e/tests/logs.rs",
"e2e/tests/predicates.rs",
"e2e/tests/providers.rs",
"e2e/tests/scripts.rs",
"e2e/tests/wallets.rs",
"exa... | [
{
"comment": "Nothing changed just added scope to separate the two tests",
"path": "e2e/tests/contracts.rs",
"hunk": "@@ -1270,77 +1268,75 @@ async fn low_level_call() -> Result<()> {\n random_salt = false,\n ),\n );\n+ {",
"resolving_sha": "599c8b6e143e79627815170ea42e6d7... | diff --git a/e2e/tests/contracts.rs b/e2e/tests/contracts.rs
index 9e20d26605..3450ddcf26 100644
--- a/e2e/tests/contracts.rs
+++ b/e2e/tests/contracts.rs
@@ -10,7 +10,7 @@ use fuels::{
prelude::*,
programs::DEFAULT_MAX_FEE_ESTIMATION_TOLERANCE,
tx::ContractParameters,
- types::{Bits256, Identity, err... | true | |
FuelLabs/fuels-rs | 1,628 | comment_to_fix | feat: bump `fuel-core` to `0.42.0` | Nothing changed just added scope to separate the two tests | 3f84ea37d4dd4f4fe75397c967e107e7c716f825 | 599c8b6e143e79627815170ea42e6d79a59b1ecf | diff --git a/e2e/tests/contracts.rs b/e2e/tests/contracts.rs
index 9e20d26605..3450ddcf26 100644
--- a/e2e/tests/contracts.rs
+++ b/e2e/tests/contracts.rs
@@ -10,7 +10,7 @@ use fuels::{
prelude::*,
programs::DEFAULT_MAX_FEE_ESTIMATION_TOLERANCE,
tx::ContractParameters,
- types::{Bits256, Identity, err... | [
"e2e/tests/contracts.rs"
] | [
{
"comment": "Nothing changed just added scope to separate the two tests",
"path": "e2e/tests/contracts.rs",
"hunk": "@@ -1270,77 +1268,75 @@ async fn low_level_call() -> Result<()> {\n random_salt = false,\n ),\n );\n+ {",
"resolving_sha": "599c8b6e143e79627815170ea42e6d7... | true | ||
FuelLabs/fuels-rs | 1,628 | comment_to_fix | feat: bump `fuel-core` to `0.42.0` | You can use setup program test if you wish, just make the wallets before the macro. | 3f84ea37d4dd4f4fe75397c967e107e7c716f825 | 599c8b6e143e79627815170ea42e6d79a59b1ecf | diff --git a/e2e/tests/contracts.rs b/e2e/tests/contracts.rs
index 9e20d26605..3450ddcf26 100644
--- a/e2e/tests/contracts.rs
+++ b/e2e/tests/contracts.rs
@@ -10,7 +10,7 @@ use fuels::{
prelude::*,
programs::DEFAULT_MAX_FEE_ESTIMATION_TOLERANCE,
tx::ContractParameters,
- types::{Bits256, Identity, err... | [
"e2e/tests/contracts.rs"
] | [
{
"comment": "You can use setup program test if you wish, just make the wallets before the macro.",
"path": "e2e/tests/contracts.rs",
"hunk": "@@ -1993,27 +1999,77 @@ async fn simulations_can_be_made_without_coins() -> Result<()> {\n .contract_id;\n \n let provider = wallet.provider().clone();\n... | true | ||
FuelLabs/fuels-rs | 1,628 | comment_to_fix | feat: bump `fuel-core` to `0.42.0` | Do we know the difference between `None` and `Some(false)`? | 3f84ea37d4dd4f4fe75397c967e107e7c716f825 | 599c8b6e143e79627815170ea42e6d79a59b1ecf | diff --git a/packages/fuels-accounts/src/provider.rs b/packages/fuels-accounts/src/provider.rs
index 8646c6cb79..84bcf875a0 100644
--- a/packages/fuels-accounts/src/provider.rs
+++ b/packages/fuels-accounts/src/provider.rs
@@ -72,7 +72,7 @@ pub(crate) struct ResourceQueries {
utxos: Vec<UtxoId>,
messages: Vec... | [
"packages/fuels-accounts/src/provider.rs"
] | [
{
"comment": "Do we know the difference between `None` and `Some(false)`?",
"path": "packages/fuels-accounts/src/provider.rs",
"hunk": "@@ -366,15 +366,17 @@ impl Provider {\n pub async fn dry_run_opt(\n &self,\n tx: impl Transaction,\n- utxo_validation: bool,\n+ utxo_v... | true | ||
FuelLabs/fuels-rs | 1,628 | comment_to_fix | feat: bump `fuel-core` to `0.42.0` | Why not have a preconfirmation failure as well on our side?
I'm wary of doing `unwrap_or_default` instead of keeping the receipts optional if that is the right way of modeling them. | 3f84ea37d4dd4f4fe75397c967e107e7c716f825 | 599c8b6e143e79627815170ea42e6d79a59b1ecf | diff --git a/packages/fuels-core/src/types/tx_status.rs b/packages/fuels-core/src/types/tx_status.rs
index d2389e3072..ee9e9037c7 100644
--- a/packages/fuels-core/src/types/tx_status.rs
+++ b/packages/fuels-core/src/types/tx_status.rs
@@ -28,10 +28,10 @@ pub struct SqueezedOut {
}
#[derive(Debug, Clone)]
-pub struc... | [
"packages/fuels-core/src/types/tx_status.rs"
] | [
{
"comment": "Why not have a preconfirmation failure as well on our side?\r\n\r\nI'm wary of doing `unwrap_or_default` instead of keeping the receipts optional if that is the right way of modeling them.",
"path": "packages/fuels-core/src/types/tx_status.rs",
"hunk": "@@ -177,20 +205,32 @@ impl From<Clie... | true | ||
FuelLabs/fuels-rs | 1,628 | comment_to_fix | feat: bump `fuel-core` to `0.42.0` | Perhaps it would be easier to reason about what is the default if we separate out the default impl to call `Execution::realistic`.
This way we have to know the default behavior of all of the fields of the struct. | 3f84ea37d4dd4f4fe75397c967e107e7c716f825 | 599c8b6e143e79627815170ea42e6d79a59b1ecf | diff --git a/packages/fuels-programs/src/calls.rs b/packages/fuels-programs/src/calls.rs
index 88fe631e2e..538c7c28ec 100644
--- a/packages/fuels-programs/src/calls.rs
+++ b/packages/fuels-programs/src/calls.rs
@@ -7,16 +7,50 @@ pub mod utils;
pub use call_handler::*;
pub use contract_call::*;
+use fuel_types::Bloc... | [
"packages/fuels-programs/src/calls.rs"
] | [
{
"comment": "Perhaps it would be easier to reason about what is the default if we separate out the default impl to call `Execution::realistic`. \r\n\r\nThis way we have to know the default behavior of all of the fields of the struct.",
"path": "packages/fuels-programs/src/calls.rs",
"hunk": "@@ -7,16 +... | true | ||
FuelLabs/fuels-rs | 1,628 | comment_to_fix | feat: bump `fuel-core` to `0.42.0` | Do we support historical execution when running the fuel core as a lib? | 3f84ea37d4dd4f4fe75397c967e107e7c716f825 | 599c8b6e143e79627815170ea42e6d79a59b1ecf | diff --git a/packages/fuels-test-helpers/src/service.rs b/packages/fuels-test-helpers/src/service.rs
index 45c0fbf375..df6b5ac093 100644
--- a/packages/fuels-test-helpers/src/service.rs
+++ b/packages/fuels-test-helpers/src/service.rs
@@ -69,7 +69,7 @@ impl FuelService {
use fuel_core::state::rocks_db::{Column... | [
"packages/fuels-test-helpers/src/service.rs"
] | [
{
"comment": "Do we support historical execution when running the fuel core as a lib?",
"path": "packages/fuels-test-helpers/src/service.rs",
"hunk": "@@ -102,10 +103,14 @@ impl FuelService {\n max_queries_resolver_recursive_depth: 1,\n max_queries_directives: 10,\n ... | true | ||
FuelLabs/fuels-rs | 1,628 | comment_to_fix | feat: bump `fuel-core` to `0.42.0` | Does a non-unique chain_name cause problems when running concurrent nodes?
I.e. maybe we should add a comment explaining why chain name needs to be set, how it is used, why does it need to be the name of a folder and whether it should be unique.
Also the tempdir will be deleted at the end of that scope. Maybe a c... | 3f84ea37d4dd4f4fe75397c967e107e7c716f825 | 599c8b6e143e79627815170ea42e6d79a59b1ecf | diff --git a/e2e/tests/contracts.rs b/e2e/tests/contracts.rs
index 9e20d26605..3450ddcf26 100644
--- a/e2e/tests/contracts.rs
+++ b/e2e/tests/contracts.rs
@@ -10,7 +10,7 @@ use fuels::{
prelude::*,
programs::DEFAULT_MAX_FEE_ESTIMATION_TOLERANCE,
tx::ContractParameters,
- types::{Bits256, Identity, err... | [
"e2e/tests/contracts.rs"
] | [
{
"comment": "Does a non-unique chain_name cause problems when running concurrent nodes?\r\n\r\nI.e. maybe we should add a comment explaining why chain name needs to be set, how it is used, why does it need to be the name of a folder and whether it should be unique.\r\n\r\nAlso the tempdir will be deleted at th... | true | ||
FuelLabs/fuels-rs | 1,628 | comment_to_fix | feat: bump `fuel-core` to `0.42.0` | perhaps you want to return the `temp_dir` as part of this function then? i'm curious why the tests are passing if the directory is dropped :? | 3f84ea37d4dd4f4fe75397c967e107e7c716f825 | 599c8b6e143e79627815170ea42e6d79a59b1ecf | diff --git a/e2e/tests/contracts.rs b/e2e/tests/contracts.rs
index 9e20d26605..3450ddcf26 100644
--- a/e2e/tests/contracts.rs
+++ b/e2e/tests/contracts.rs
@@ -10,7 +10,7 @@ use fuels::{
prelude::*,
programs::DEFAULT_MAX_FEE_ESTIMATION_TOLERANCE,
tx::ContractParameters,
- types::{Bits256, Identity, err... | [
"e2e/tests/contracts.rs"
] | [
{
"comment": "perhaps you want to return the `temp_dir` as part of this function then? i'm curious why the tests are passing if the directory is dropped :?",
"path": "e2e/tests/contracts.rs",
"hunk": "@@ -1959,17 +1948,33 @@ async fn setup_node_with_high_price() -> Result<Vec<Wallet>> {\n fee_pa... | true | ||
FuelLabs/fuels-rs | 1,628 | comment_to_fix | feat: bump `fuel-core` to `0.42.0` | curious, does get_balances return an amount which is not u64? | 3f84ea37d4dd4f4fe75397c967e107e7c716f825 | 599c8b6e143e79627815170ea42e6d79a59b1ecf | diff --git a/examples/cookbook/src/lib.rs b/examples/cookbook/src/lib.rs
index ff1fc56948..91296b479c 100644
--- a/examples/cookbook/src/lib.rs
+++ b/examples/cookbook/src/lib.rs
@@ -172,7 +172,6 @@ mod tests {
let mut outputs = vec![];
for (id_string, amount) in balances {
let id = Asset... | [
"examples/cookbook/src/lib.rs"
] | [
{
"comment": "curious, does get_balances return an amount which is not u64?",
"path": "examples/cookbook/src/lib.rs",
"hunk": "@@ -181,9 +180,9 @@ mod tests {\n \n // we don't transfer the full base asset so we can cover fees\n let output = if id == *consensus_parameters.base_ass... | true | ||
FuelLabs/fuels-rs | 1,628 | comment_to_fix | feat: bump `fuel-core` to `0.42.0` | Nice, didn't know about these until know: https://rust-lang.github.io/mdBook/format/mdbook.html#including-portions-of-a-file | 3f84ea37d4dd4f4fe75397c967e107e7c716f825 | 599c8b6e143e79627815170ea42e6d79a59b1ecf | diff --git a/examples/contracts/src/lib.rs b/examples/contracts/src/lib.rs
index c6b9a33b45..ead9b87546 100644
--- a/examples/contracts/src/lib.rs
+++ b/examples/contracts/src/lib.rs
@@ -349,6 +349,7 @@ mod tests {
#[tokio::test]
#[allow(unused_variables)]
+ #[cfg(any(not(feature = "fuel-core-lib"), feat... | [
"examples/contracts/src/lib.rs"
] | [
{
"comment": "Nice, didn't know about these until know: https://rust-lang.github.io/mdBook/format/mdbook.html#including-portions-of-a-file",
"path": "examples/contracts/src/lib.rs",
"hunk": "@@ -382,11 +409,25 @@ mod tests {\n // you don't need any funds to read state\n let balan... | true | ||
FuelLabs/fuels-rs | 1,628 | comment_to_fix | feat: bump `fuel-core` to `0.42.0` | Why do we take ownership of the receipts here? We only use references, and I see that this is causing redundant clone operations in the code. | 3f84ea37d4dd4f4fe75397c967e107e7c716f825 | 599c8b6e143e79627815170ea42e6d79a59b1ecf | diff --git a/packages/fuels-core/src/types/tx_status.rs b/packages/fuels-core/src/types/tx_status.rs
index d2389e3072..ee9e9037c7 100644
--- a/packages/fuels-core/src/types/tx_status.rs
+++ b/packages/fuels-core/src/types/tx_status.rs
@@ -28,10 +28,10 @@ pub struct SqueezedOut {
}
#[derive(Debug, Clone)]
-pub struc... | [
"packages/fuels-core/src/types/tx_status.rs"
] | [
{
"comment": "Why do we take ownership of the receipts here? We only use references, and I see that this is causing redundant clone operations in the code.",
"path": "packages/fuels-core/src/types/tx_status.rs",
"hunk": "@@ -65,50 +72,61 @@ impl TxStatus {\n Self::SqueezedOut(SqueezedOut { r... | true | ||
FuelLabs/fuels-rs | 1,630 | issue_to_patch | bump `rust` to `1.85.0` and the edition to `2024` | chore!: bump `rust` to `1.85.0` and edition to `2024` | Closes: https://github.com/FuelLabs/fuels-rs/issues/1629
# Breaking Changes
- bumped `rust` version to `1.85.0` and edition to `2024`
# Checklist
- [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **changes** are **documented** (or not applicable)
- [x] I **reviewed** the **... | ad7be570cc788e20f1a431b2fc631b47e62b2899 | 8e11b7bcd78db162163bbd5e236fbbf46ba39190 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 40b8f30771..e043d59c52 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -19,7 +19,7 @@ env:
FUEL_CORE_VERSION: 0.41.7
FUEL_CORE_PATCH_BRANCH: ""
FUEL_CORE_PATCH_REVISION: ""
- RUST_VERSION: 1.81.0
+ RUST_VERSION: 1.... | [
".github/workflows/ci.yml",
"Cargo.toml",
"e2e/src/aws_kms.rs",
"e2e/src/e2e_helpers.rs",
"e2e/tests/aws.rs",
"e2e/tests/binary_format.rs",
"e2e/tests/configurables.rs",
"e2e/tests/contracts.rs",
"e2e/tests/debug_utils.rs",
"e2e/tests/logs.rs",
"e2e/tests/predicates.rs",
"e2e/tests/providers.r... | [] | diff --git a/e2e/tests/aws.rs b/e2e/tests/aws.rs
index fc15e7a988..43280e415a 100644
--- a/e2e/tests/aws.rs
+++ b/e2e/tests/aws.rs
@@ -3,10 +3,10 @@ mod tests {
use anyhow::Result;
use e2e::e2e_helpers::start_aws_kms;
use fuels::{
- accounts::{signers::kms::aws::AwsKmsSigner, wallet::Wallet, Accou... | true |
FuelLabs/fuels-rs | 1,626 | issue_to_patch | chore: bump `forc` to `0.67.0` | 5c80a428bd13220036e5375461081bcf8ae7ddfe | 3251431fa4351a79fd4ea5a2063b51383caea216 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 6ca195c915..40b8f30771 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -20,7 +20,7 @@ env:
FUEL_CORE_PATCH_BRANCH: ""
FUEL_CORE_PATCH_REVISION: ""
RUST_VERSION: 1.81.0
- FORC_VERSION: 0.66.10
+ FORC_VERSION: 0.67.0... | [
".github/workflows/ci.yml",
"e2e/sway/contracts/asserts/src/main.sw",
"e2e/sway/predicates/predicate_configurables/src/main.sw",
"e2e/sway/scripts/script_asserts/src/main.sw",
"e2e/sway/types/contracts/vectors/src/eq_impls.sw",
"e2e/sway/types/scripts/script_vectors/src/eq_impls.sw",
"e2e/tests/storage.... | [] | diff --git a/e2e/tests/storage.rs b/e2e/tests/storage.rs
index 8dbf21c3d9..97999b644f 100644
--- a/e2e/tests/storage.rs
+++ b/e2e/tests/storage.rs
@@ -60,7 +60,7 @@ async fn test_init_storage_automatically() -> Result<()> {
let contract_methods = MyContract::new(contract_id, wallet.clone()).methods();
{
... | true | ||
FuelLabs/fuels-rs | 1,625 | issue_to_patch | docs: fix custom input output snippet | <!--
List the issues this PR closes (if any) in a bullet list format, e.g.:
- Closes #ABCD
- Closes #EFGH
-->
# Summary
Fixed snippets in docs.
<!--
Please write a summary of your changes and why you made them.
Not all PRs will be complex or substantial enough to require this
section, so you can remove it... | 9db786c799ef63922e5eba99f03dea4907c2a777 | 915216fde7266522149ea61698347f735d285bfb | diff --git a/docs/src/calling-contracts/custom-inputs-outputs.md b/docs/src/calling-contracts/custom-inputs-outputs.md
index 83deba75aa..c1bcad94c7 100644
--- a/docs/src/calling-contracts/custom-inputs-outputs.md
+++ b/docs/src/calling-contracts/custom-inputs-outputs.md
@@ -4,7 +4,6 @@ If you need to add specific input... | [
"docs/src/calling-contracts/custom-inputs-outputs.md",
"docs/src/running-scripts.md"
] | [] | true | ||
FuelLabs/fuels-rs | 1,624 | issue_to_patch | chore: bump versions to `v0.71.0` | 967245c86d8e194ff1d971ecd1f899d72b87d044 | 0366ee54650e2741caf649619ada72ebeeb9a4da | diff --git a/Cargo.toml b/Cargo.toml
index 10c489fa94..4ec31416d9 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -39,7 +39,7 @@ readme = "README.md"
license = "Apache-2.0"
repository = "https://github.com/FuelLabs/fuels-rs"
rust-version = "1.81.0"
-version = "0.70.0"
+version = "0.71.0"
[workspace.dependencies]
Inf... | [
"Cargo.toml",
"docs/src/connecting/short-lived.md"
] | [] | true | |||
FuelLabs/fuels-rs | 1,590 | issue_to_patch | Max fee estimation tolerance not set when uploading script/predicate blobs
We've been setting a max fee estimation tolerance on all higher-level APIs (anywhere a transaction is created by the SDK).
This hasn't been set on `upload_blob` from `Executable` and consequently on `ScriptCallHandler`'s `convert_into_loader`... | fix: script/predicate blob upload now uses the default max fee estimation tolerance | - Closes: #1589
# Release notes
In this release, we:
- Added max fee estimation tolerance to `ScriptCallHandler`'s `convert_into_loader` to reduce the occurrence of invalid max fees.
# Summary
`ScriptCallHandler::convert_into_loader` and `Executable::upload_blob` now use the default max fee estimation tol... | 482897e33a09e5b698463df0bc15f0c34656b3a7 | 359ece1fe6c67740a36cbf54346754b98cc72b14 | diff --git a/packages/fuels-accounts/src/provider.rs b/packages/fuels-accounts/src/provider.rs
index 31f053bba6..13668ed804 100644
--- a/packages/fuels-accounts/src/provider.rs
+++ b/packages/fuels-accounts/src/provider.rs
@@ -758,7 +758,7 @@ impl Provider {
let receipts = self.dry_run_opt(tx, false, None).awa... | [
"e2e/tests/contracts.rs",
"e2e/tests/scripts.rs",
"packages/fuels-accounts/src/provider.rs",
"packages/fuels-core/src/types/dry_runner.rs",
"packages/fuels-core/src/types/transaction_builders.rs",
"packages/fuels-programs/src/calls/traits/transaction_tuner.rs",
"packages/fuels-programs/src/calls/utils.r... | [] | diff --git a/e2e/tests/contracts.rs b/e2e/tests/contracts.rs
index 9e9e80c473..b41ce21bb8 100644
--- a/e2e/tests/contracts.rs
+++ b/e2e/tests/contracts.rs
@@ -7,6 +7,7 @@ use fuel_tx::{
use fuels::{
core::codec::{calldata, encode_fn_selector, DecoderConfig, EncoderConfig},
prelude::*,
+ programs::DEFAULT_... | true |
FuelLabs/fuels-rs | 1,616 | issue_to_patch | indexation support not checked when querying balances
We need to check whether the node supports indexation before we try and paginate through balances. If it doesn't then we should fallback to making a single large request. | fix: fallback to single large request if no indexation available | Closes: #1615
# Release notes
In this release, we:
- Added a fallback for querying balances when indexation is not supported
# Checklist
- [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **changes** are **documented** (or not applicable)
- [x] I **reviewed** the **entire... | a57c5d63488e55a806bc615b7e819a5fdde15600 | e40829940e06ad83dc9865b5b3361d625c800b7a | diff --git a/packages/fuels-accounts/src/provider.rs b/packages/fuels-accounts/src/provider.rs
index a283509fd3..ada64a4141 100644
--- a/packages/fuels-accounts/src/provider.rs
+++ b/packages/fuels-accounts/src/provider.rs
@@ -322,7 +322,7 @@ impl Provider {
}
pub async fn node_info(&self) -> Result<NodeInf... | [
"packages/fuels-accounts/src/provider.rs",
"packages/fuels-accounts/src/provider/cache.rs",
"packages/fuels-accounts/src/provider/retryable_client.rs"
] | [] | true | |
FuelLabs/fuels-rs | 1,612 | issue_to_patch | feat: add support for GOOGLE KMS | # Release notes
In this release, we:
- Added support for Google Key Management Service (KMS)
# Summary
Implements Google Key Management Service (KMS) integration for secure key management
in Fuel wallets.
# Checklist
- [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **chan... | e2d874fc62ff97aa993ff25885987b47742f778c | b792aef0d8eafebd88f31b041abeb92aba01bab6 | diff --git a/Cargo.toml b/Cargo.toml
index c5d5a2d359..28d5b40eec 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -88,6 +88,7 @@ octocrab = { version = "0.43", default-features = false }
dotenv = { version = "0.15", default-features = false }
toml = { version = "0.8", default-features = false }
mockall = { version = "0.... | [
"Cargo.toml",
"e2e/Cargo.toml",
"e2e/src/aws_kms.rs",
"e2e/tests/aws.rs",
"packages/fuels-accounts/Cargo.toml",
"packages/fuels-accounts/src/kms.rs",
"packages/fuels-accounts/src/kms/aws.rs",
"packages/fuels-accounts/src/kms/aws/wallet.rs",
"packages/fuels-accounts/src/kms/aws_signer.rs",
"package... | [
{
"comment": "I'd have two flags, one for aws and one for google.",
"path": "packages/fuels-accounts/Cargo.toml",
"hunk": "@@ -51,4 +52,4 @@ std = [\n \"dep:cynic\",\n ]\n test-helpers = []\n-kms-signer = [\"dep:aws-sdk-kms\", \"dep:aws-config\"]\n+kms-signer = [\"dep:aws-sdk-kms\", \"dep:aws-config\"... | diff --git a/e2e/tests/aws.rs b/e2e/tests/aws.rs
index 683c3bf103..c48b0deef9 100644
--- a/e2e/tests/aws.rs
+++ b/e2e/tests/aws.rs
@@ -2,10 +2,10 @@
mod tests {
use anyhow::Result;
use e2e::e2e_helpers::start_aws_kms;
- use fuels::accounts::kms::AwsWallet;
+ use fuels::accounts::kms::{AwsKmsSigner, Kms... | true | |
FuelLabs/fuels-rs | 1,612 | comment_to_fix | feat: add support for GOOGLE KMS | I'd have two flags, one for aws and one for google. | e2d874fc62ff97aa993ff25885987b47742f778c | b792aef0d8eafebd88f31b041abeb92aba01bab6 | diff --git a/packages/fuels-accounts/Cargo.toml b/packages/fuels-accounts/Cargo.toml
index 9948e36dfd..e082268c4b 100644
--- a/packages/fuels-accounts/Cargo.toml
+++ b/packages/fuels-accounts/Cargo.toml
@@ -9,6 +9,9 @@ repository = { workspace = true }
rust-version = { workspace = true }
description = "Fuel Rust SDK ... | [
"packages/fuels-accounts/Cargo.toml"
] | [
{
"comment": "I'd have two flags, one for aws and one for google.",
"path": "packages/fuels-accounts/Cargo.toml",
"hunk": "@@ -51,4 +52,4 @@ std = [\n \"dep:cynic\",\n ]\n test-helpers = []\n-kms-signer = [\"dep:aws-sdk-kms\", \"dep:aws-config\"]\n+kms-signer = [\"dep:aws-sdk-kms\", \"dep:aws-config\"... | true | ||
FuelLabs/fuels-rs | 1,612 | comment_to_fix | feat: add support for GOOGLE KMS | I'd remove the `accounts-*` prefix since we are in `accounts`.
Add it to the fuels package features as a sort of namespacing. | e2d874fc62ff97aa993ff25885987b47742f778c | b792aef0d8eafebd88f31b041abeb92aba01bab6 | diff --git a/packages/fuels-accounts/Cargo.toml b/packages/fuels-accounts/Cargo.toml
index 9948e36dfd..e082268c4b 100644
--- a/packages/fuels-accounts/Cargo.toml
+++ b/packages/fuels-accounts/Cargo.toml
@@ -9,6 +9,9 @@ repository = { workspace = true }
rust-version = { workspace = true }
description = "Fuel Rust SDK ... | [
"packages/fuels-accounts/Cargo.toml"
] | [
{
"comment": "I'd remove the `accounts-*` prefix since we are in `accounts`. \r\n\r\nAdd it to the fuels package features as a sort of namespacing.",
"path": "packages/fuels-accounts/Cargo.toml",
"hunk": "@@ -51,4 +55,5 @@ std = [\n \"dep:cynic\",\n ]\n test-helpers = []\n-kms-signer = [\"dep:aws-sdk-... | true | ||
FuelLabs/fuels-rs | 1,612 | comment_to_fix | feat: add support for GOOGLE KMS | I'd call it `accounts-*`
so we know that by enabling it we're effectively forwarding the feature to the `accounts` crate. | e2d874fc62ff97aa993ff25885987b47742f778c | b792aef0d8eafebd88f31b041abeb92aba01bab6 | diff --git a/packages/fuels/Cargo.toml b/packages/fuels/Cargo.toml
index 6c84c28442..4304844a5d 100644
--- a/packages/fuels/Cargo.toml
+++ b/packages/fuels/Cargo.toml
@@ -41,4 +41,5 @@ std = [
]
fuel-core-lib = ["fuels-test-helpers?/fuel-core-lib"]
rocksdb = ["fuels-test-helpers?/rocksdb"]
-kms-signer = ["fuels-acco... | [
"packages/fuels/Cargo.toml"
] | [
{
"comment": "I'd call it `accounts-*` \r\n\r\nso we know that by enabling it we're effectively forwarding the feature to the `accounts` crate.",
"path": "packages/fuels/Cargo.toml",
"hunk": "@@ -41,4 +41,5 @@ std = [\n ]\n fuel-core-lib = [\"fuels-test-helpers?/fuel-core-lib\"]\n rocksdb = [\"fuels-tes... | true | ||
FuelLabs/fuels-rs | 1,599 | issue_to_patch | feat: add support for AWS KMS | # Release notes
In this release, we:
- Added support for AWS Key Management Service (KMS)
# Summary
Implements AWS Key Management Service (KMS) integration for secure key management
in Fuel wallets.
# Checklist
- [x] All **changes** are **covered** by **tests** (or not applicable)
- [x] All **changes** ar... | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 17e9512769..9b813ca61d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -277,7 +277,7 @@ jobs:
- name: Check for typos
if: ${{ matrix.command == 'check_typos' }}
- uses: crate-ci/typos@v1.20.3
+ ... | [
".github/workflows/ci.yml",
"Cargo.toml",
"_typos.toml",
"docs/spell-check-custom-words.txt",
"docs/src/SUMMARY.md",
"docs/src/wallets/kms-wallets.md",
"e2e/Cargo.toml",
"e2e/src/aws_kms.rs",
"e2e/src/e2e_helpers.rs",
"e2e/src/lib.rs",
"e2e/tests/aws.rs",
"packages/fuels-accounts/Cargo.toml",
... | [
{
"comment": "Bump this to `1.29.5` and you won't have to specify KMS as a custom word. ",
"path": ".github/workflows/ci.yml",
"hunk": "@@ -278,6 +278,8 @@ jobs:\n - name: Check for typos\n if: ${{ matrix.command == 'check_typos' }}\n uses: crate-ci/typos@v1.20.3",
"resolving_s... | diff --git a/e2e/tests/aws.rs b/e2e/tests/aws.rs
new file mode 100644
index 0000000000..683c3bf103
--- /dev/null
+++ b/e2e/tests/aws.rs
@@ -0,0 +1,68 @@
+#[cfg(test)]
+mod tests {
+ use anyhow::Result;
+ use e2e::e2e_helpers::start_aws_kms;
+ use fuels::accounts::kms::AwsWallet;
+ use fuels::accounts::{Acco... | true | |
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | Bump this to `1.29.5` and you won't have to specify KMS as a custom word. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 17e9512769..9b813ca61d 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -277,7 +277,7 @@ jobs:
- name: Check for typos
if: ${{ matrix.command == 'check_typos' }}
- uses: crate-ci/typos@v1.20.3
+ ... | [
".github/workflows/ci.yml"
] | [
{
"comment": "Bump this to `1.29.5` and you won't have to specify KMS as a custom word. ",
"path": ".github/workflows/ci.yml",
"hunk": "@@ -278,6 +278,8 @@ jobs:\n - name: Check for typos\n if: ${{ matrix.command == 'check_typos' }}\n uses: crate-ci/typos@v1.20.3",
"resolving_s... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | ```suggestion
testcontainers = { version = "0.23", default-features = false }
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/Cargo.toml b/Cargo.toml
index 8b7167616b..c5d5a2d359 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -88,6 +88,10 @@ octocrab = { version = "0.43", default-features = false }
dotenv = { version = "0.15", default-features = false }
toml = { version = "0.8", default-features = false }
mockall = { version = "0... | [
"Cargo.toml"
] | [
{
"comment": "```suggestion\r\ntestcontainers = { version = \"0.23\", default-features = false }\r\n```",
"path": "Cargo.toml",
"hunk": "@@ -89,6 +89,11 @@ dotenv = { version = \"0.15\", default-features = false }\n toml = { version = \"0.8\", default-features = false }\n mockall = { version = \"0.13\",... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | To increase flexibility with users of `aws-config` out there.
```suggestion
aws-config = { version = "1", default-features = false }
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/Cargo.toml b/Cargo.toml
index 8b7167616b..c5d5a2d359 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -88,6 +88,10 @@ octocrab = { version = "0.43", default-features = false }
dotenv = { version = "0.15", default-features = false }
toml = { version = "0.8", default-features = false }
mockall = { version = "0... | [
"Cargo.toml"
] | [
{
"comment": "To increase flexibility with users of `aws-config` out there.\r\n```suggestion\r\naws-config = { version = \"1\", default-features = false }\r\n```",
"path": "Cargo.toml",
"hunk": "@@ -89,6 +89,11 @@ dotenv = { version = \"0.15\", default-features = false }\n toml = { version = \"0.8\", de... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | ```suggestion
aws-sdk-kms = { version = "1", default-features = false }
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/Cargo.toml b/Cargo.toml
index 8b7167616b..c5d5a2d359 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -88,6 +88,10 @@ octocrab = { version = "0.43", default-features = false }
dotenv = { version = "0.15", default-features = false }
toml = { version = "0.8", default-features = false }
mockall = { version = "0... | [
"Cargo.toml"
] | [
{
"comment": "```suggestion\r\naws-sdk-kms = { version = \"1\", default-features = false }\r\n```",
"path": "Cargo.toml",
"hunk": "@@ -89,6 +89,11 @@ dotenv = { version = \"0.15\", default-features = false }\n toml = { version = \"0.8\", default-features = false }\n mockall = { version = \"0.13\", defau... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | ```suggestion
k256 = { version = "0.13", default-features = false }
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/Cargo.toml b/Cargo.toml
index 8b7167616b..c5d5a2d359 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -88,6 +88,10 @@ octocrab = { version = "0.43", default-features = false }
dotenv = { version = "0.15", default-features = false }
toml = { version = "0.8", default-features = false }
mockall = { version = "0... | [
"Cargo.toml"
] | [
{
"comment": "```suggestion\r\nk256 = { version = \"0.13\", default-features = false }\r\n```",
"path": "Cargo.toml",
"hunk": "@@ -89,6 +89,11 @@ dotenv = { version = \"0.15\", default-features = false }\n toml = { version = \"0.8\", default-features = false }\n mockall = { version = \"0.13\", default-f... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | Why the extra newlines? `cargo sort` will not sort if you separate deps with new lines. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/Cargo.toml b/e2e/Cargo.toml
index 1dc6a71104..10fb0a1904 100644
--- a/e2e/Cargo.toml
+++ b/e2e/Cargo.toml
@@ -18,11 +18,9 @@ chrono = { workspace = true }
fuel-asm = { workspace = true }
# TODO: [issue](https://github.com/FuelLabs/fuels-rs/issues/1375) needs to be removed, `ScriptTransaction` and `Cr... | [
"e2e/Cargo.toml"
] | [
{
"comment": "Why the extra newlines? `cargo sort` will not sort if you separate deps with new lines.",
"path": "e2e/Cargo.toml",
"hunk": "@@ -24,10 +24,23 @@ tai64 = { workspace = true }\n tempfile = { workspace = true }\n tokio = { workspace = true, features = [\"test-util\"] }\n \n+portpicker = { wor... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | We should move this above `features` for consistency with other crates. Usually it is deps then features.
Also use `{workspace = true}`. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/Cargo.toml b/e2e/Cargo.toml
index 1dc6a71104..10fb0a1904 100644
--- a/e2e/Cargo.toml
+++ b/e2e/Cargo.toml
@@ -18,11 +18,9 @@ chrono = { workspace = true }
fuel-asm = { workspace = true }
# TODO: [issue](https://github.com/FuelLabs/fuels-rs/issues/1375) needs to be removed, `ScriptTransaction` and `Cr... | [
"e2e/Cargo.toml"
] | [
{
"comment": "We should move this above `features` for consistency with other crates. Usually it is deps then features.\r\n\r\nAlso use `{workspace = true}`.",
"path": "e2e/Cargo.toml",
"hunk": "@@ -37,3 +50,6 @@ default = [\"fuels/default\", \"coin-cache\"]\n fuel-core-lib = [\"fuels/fuel-core-lib\"]\n... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | Best to use `fuels::*` only whenever possible so we e2e test from the users' perspective.
```suggestion
use fuels::accounts::kms::{AwsClient, AwsConfig, KmsKey};
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/src/aws_kms.rs b/e2e/src/aws_kms.rs
new file mode 100644
index 0000000000..62a77ab052
--- /dev/null
+++ b/e2e/src/aws_kms.rs
@@ -0,0 +1,167 @@
+use fuels::accounts::kms::{
+ aws_config::{defaults, BehaviorVersion, Region},
+ aws_sdk_kms::{
+ config::Credentials,
+ types::{KeySpec, K... | [
"e2e/src/aws_kms.rs"
] | [
{
"comment": "Best to use `fuels::*` only whenever possible so we e2e test from the users' perspective.\r\n```suggestion\r\nuse fuels::accounts::kms::{AwsClient, AwsConfig, KmsKey};\r\n```",
"path": "e2e/src/aws_kms.rs",
"hunk": "@@ -0,0 +1,139 @@\n+use anyhow::Context;\n+use fuels::accounts::kms::{AwsC... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | This is leftover from the committer. We have no "prod behavior" with the sdk.
```suggestion
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/src/aws_kms.rs b/e2e/src/aws_kms.rs
new file mode 100644
index 0000000000..62a77ab052
--- /dev/null
+++ b/e2e/src/aws_kms.rs
@@ -0,0 +1,167 @@
+use fuels::accounts::kms::{
+ aws_config::{defaults, BehaviorVersion, Region},
+ aws_sdk_kms::{
+ config::Credentials,
+ types::{KeySpec, K... | [
"e2e/src/aws_kms.rs"
] | [
{
"comment": "This is leftover from the committer. We have no \"prod behavior\" with the sdk.\r\n```suggestion\r\n```",
"path": "e2e/src/aws_kms.rs",
"hunk": "@@ -0,0 +1,139 @@\n+use anyhow::Context;\n+use fuels::accounts::kms::{AwsClient, AwsConfig};\n+use fuels_accounts::kms::KmsKey;\n+use testcontain... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | ```suggestion
}
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/src/e2e_helpers.rs b/e2e/src/e2e_helpers.rs
new file mode 100644
index 0000000000..9e4415734f
--- /dev/null
+++ b/e2e/src/e2e_helpers.rs
@@ -0,0 +1,6 @@
+use crate::aws_kms::{AwsKms, AwsKmsProcess};
+use fuels::types::errors::Result;
+
+pub async fn start_aws_kms(logs: bool) -> Result<AwsKmsProcess> {
... | [
"e2e/src/e2e_helpers.rs"
] | [
{
"comment": "```suggestion\r\n}\r\n\r\n```",
"path": "e2e/src/e2e_helpers.rs",
"hunk": "@@ -0,0 +1,23 @@\n+use crate::{\n+ aws_kms::{AwsKms, AwsKmsProcess, KmsTestKey},\n+ fuel_node::{FuelNode, FuelNodeProcess},\n+};\n+\n+pub async fn start_aws_kms(logs: bool) -> anyhow::Result<AwsKmsProcess> {\n... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | Let's migrate this with the other tests over in `tests/*` maybe `tests/aws.rs` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/src/lib.rs b/e2e/src/lib.rs
new file mode 100644
index 0000000000..ea443026cf
--- /dev/null
+++ b/e2e/src/lib.rs
@@ -0,0 +1,2 @@
+mod aws_kms;
+pub mod e2e_helpers;
| [
"e2e/src/lib.rs"
] | [
{
"comment": "Let's migrate this with the other tests over in `tests/*` maybe `tests/aws.rs`",
"path": "e2e/src/lib.rs",
"hunk": "",
"resolving_sha": "a8c86ccbeff56a4a41cac703311ab6fb3baadf4f",
"resolving_diff": "diff --git a/e2e/src/lib.rs b/e2e/src/lib.rs\nnew file mode 100644\nindex 000000000... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | ```suggestion
use fuels::accounts::kms::AwsWallet;
use fuels::accounts::ViewOnlyAccount;
```
use `fuels::*` wherever you can, just so we catch when we haven't reexported something important. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/src/lib.rs b/e2e/src/lib.rs
new file mode 100644
index 0000000000..ea443026cf
--- /dev/null
+++ b/e2e/src/lib.rs
@@ -0,0 +1,2 @@
+mod aws_kms;
+pub mod e2e_helpers;
| [
"e2e/src/lib.rs"
] | [
{
"comment": "```suggestion\r\n use fuels::accounts::kms::AwsWallet;\r\n use fuels::accounts::ViewOnlyAccount;\r\n```\r\nuse `fuels::*` wherever you can, just so we catch when we haven't reexported something important.",
"path": "e2e/src/lib.rs",
"hunk": "@@ -0,0 +1,98 @@\n+#[cfg(test)]\n+mod aws_... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | This impacts the whole runner. It would be better if you configured the aws client with a static credentials provider. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/src/lib.rs b/e2e/src/lib.rs
new file mode 100644
index 0000000000..ea443026cf
--- /dev/null
+++ b/e2e/src/lib.rs
@@ -0,0 +1,2 @@
+mod aws_kms;
+pub mod e2e_helpers;
| [
"e2e/src/lib.rs"
] | [
{
"comment": "This impacts the whole runner. It would be better if you configured the aws client with a static credentials provider.",
"path": "e2e/src/lib.rs",
"hunk": "@@ -0,0 +1,98 @@\n+#[cfg(test)]\n+mod aws_kms;\n+#[cfg(test)]\n+mod client;\n+#[cfg(test)]\n+mod e2e_helpers;\n+#[cfg(test)]\n+mod fue... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | This asset id is duplicated, would be better, if it really has to be this one, that we define it in one place and reuse it. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/src/lib.rs b/e2e/src/lib.rs
new file mode 100644
index 0000000000..ea443026cf
--- /dev/null
+++ b/e2e/src/lib.rs
@@ -0,0 +1,2 @@
+mod aws_kms;
+pub mod e2e_helpers;
| [
"e2e/src/lib.rs"
] | [
{
"comment": "This asset id is duplicated, would be better, if it really has to be this one, that we define it in one place and reuse it.",
"path": "e2e/src/lib.rs",
"hunk": "@@ -0,0 +1,98 @@\n+#[cfg(test)]\n+mod aws_kms;\n+#[cfg(test)]\n+mod client;\n+#[cfg(test)]\n+mod e2e_helpers;\n+#[cfg(test)]\n+mo... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | A typo maybe, `funded` seems to fit or `found`. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/src/lib.rs b/e2e/src/lib.rs
new file mode 100644
index 0000000000..ea443026cf
--- /dev/null
+++ b/e2e/src/lib.rs
@@ -0,0 +1,2 @@
+mod aws_kms;
+pub mod e2e_helpers;
| [
"e2e/src/lib.rs"
] | [
{
"comment": "A typo maybe, `funded` seems to fit or `found`.",
"path": "e2e/src/lib.rs",
"hunk": "@@ -0,0 +1,98 @@\n+#[cfg(test)]\n+mod aws_kms;\n+#[cfg(test)]\n+mod client;\n+#[cfg(test)]\n+mod e2e_helpers;\n+#[cfg(test)]\n+mod fuel_node;\n+\n+#[cfg(test)]\n+mod tests {\n+ use crate::e2e_helpers::{... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | We should propagate the amount the wallet was funded with from the place we do the funding setup, just so we don't have it duplicated in two or more places. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/src/lib.rs b/e2e/src/lib.rs
new file mode 100644
index 0000000000..ea443026cf
--- /dev/null
+++ b/e2e/src/lib.rs
@@ -0,0 +1,2 @@
+mod aws_kms;
+pub mod e2e_helpers;
| [
"e2e/src/lib.rs"
] | [
{
"comment": "We should propagate the amount the wallet was funded with from the place we do the funding setup, just so we don't have it duplicated in two or more places.",
"path": "e2e/src/lib.rs",
"hunk": "@@ -0,0 +1,98 @@\n+#[cfg(test)]\n+mod aws_kms;\n+#[cfg(test)]\n+mod client;\n+#[cfg(test)]\n+mod... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | We've been removing these lately. If needed debug statements can be added once something goes wrong.
If the above statement passed we know the deployment did as well. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/src/lib.rs b/e2e/src/lib.rs
new file mode 100644
index 0000000000..ea443026cf
--- /dev/null
+++ b/e2e/src/lib.rs
@@ -0,0 +1,2 @@
+mod aws_kms;
+pub mod e2e_helpers;
| [
"e2e/src/lib.rs"
] | [
{
"comment": "We've been removing these lately. If needed debug statements can be added once something goes wrong.\r\n\r\nIf the above statement passed we know the deployment did as well.",
"path": "e2e/src/lib.rs",
"hunk": "@@ -0,0 +1,98 @@\n+#[cfg(test)]\n+mod aws_kms;\n+#[cfg(test)]\n+mod client;\n+#... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | The total fee is hardcoded here, not a good experience if the default gas prices change from one version of the fuel core to another. Or the size of the contract from one sway compiler to another.
[This](https://github.com/FuelLabs/fuels-rs/pull/1574) has landed, if you need the total fee you can get it from the dep... | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/src/lib.rs b/e2e/src/lib.rs
new file mode 100644
index 0000000000..ea443026cf
--- /dev/null
+++ b/e2e/src/lib.rs
@@ -0,0 +1,2 @@
+mod aws_kms;
+pub mod e2e_helpers;
| [
"e2e/src/lib.rs"
] | [
{
"comment": "The total fee is hardcoded here, not a good experience if the default gas prices change from one version of the fuel core to another. Or the size of the contract from one sway compiler to another.\r\n\r\n[This](https://github.com/FuelLabs/fuels-rs/pull/1574) has landed, if you need the total fee y... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | best not to make these line breaks. `cargo sort` won't sort all deps then. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/packages/fuels-accounts/Cargo.toml b/packages/fuels-accounts/Cargo.toml
index 069b04ac8e..9948e36dfd 100644
--- a/packages/fuels-accounts/Cargo.toml
+++ b/packages/fuels-accounts/Cargo.toml
@@ -11,6 +11,10 @@ description = "Fuel Rust SDK accounts."
[dependencies]
async-trait = { workspace = true, defau... | [
"packages/fuels-accounts/Cargo.toml"
] | [
{
"comment": "best not to make these line breaks. `cargo sort` won't sort all deps then.",
"path": "packages/fuels-accounts/Cargo.toml",
"hunk": "@@ -28,6 +28,13 @@ tai64 = { workspace = true, features = [\"serde\"] }\n thiserror = { workspace = true, default-features = false }\n tokio = { workspace = t... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | I'd feature gate it behind a `kms_signer` flag so we don't pull in a ton of `aws-*` deps by default. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/packages/fuels-accounts/src/lib.rs b/packages/fuels-accounts/src/lib.rs
index 7bd1b1316a..6d05ad423a 100644
--- a/packages/fuels-accounts/src/lib.rs
+++ b/packages/fuels-accounts/src/lib.rs
@@ -11,12 +11,13 @@ pub mod wallet;
#[cfg(feature = "std")]
pub use account::*;
+#[cfg(feature = "kms-signer")]
+... | [
"packages/fuels-accounts/src/lib.rs"
] | [
{
"comment": "I'd feature gate it behind a `kms_signer` flag so we don't pull in a ton of `aws-*` deps by default.",
"path": "packages/fuels-accounts/src/lib.rs",
"hunk": "@@ -11,12 +11,13 @@ pub mod wallet;\n \n #[cfg(feature = \"std\")]\n pub use account::*;\n+#[cfg(feature = \"std\")]\n+pub mod kms;"... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | Why nest it this deep? I'd inline it and have `client` and `wallet` on this level. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/packages/fuels-accounts/src/kms.rs b/packages/fuels-accounts/src/kms.rs
new file mode 100644
index 0000000000..886dde1061
--- /dev/null
+++ b/packages/fuels-accounts/src/kms.rs
@@ -0,0 +1,3 @@
+mod aws;
+
+pub use aws::*;
| [
"packages/fuels-accounts/src/kms.rs"
] | [
{
"comment": "Why nest it this deep? I'd inline it and have `client` and `wallet` on this level.",
"path": "packages/fuels-accounts/src/kms.rs",
"hunk": "@@ -0,0 +1,3 @@\n+mod aws;",
"resolving_sha": "a8c86ccbeff56a4a41cac703311ab6fb3baadf4f",
"resolving_diff": "diff --git a/packages/fuels-accou... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | We should make an abstraction for the client as well and pass it into this fn, from the aws client docs:
```
/// _Note:_ Client construction is expensive due to connection thread pool initialization, and should
/// be done once at application start-up.
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/packages/fuels-accounts/src/kms/aws/wallet.rs b/packages/fuels-accounts/src/kms/aws/wallet.rs
new file mode 100644
index 0000000000..90d9992d8b
--- /dev/null
+++ b/packages/fuels-accounts/src/kms/aws/wallet.rs
@@ -0,0 +1,281 @@
+use crate::accounts_utils::try_provider_error;
+use crate::provider::Provider;... | [
"packages/fuels-accounts/src/kms/aws/wallet.rs"
] | [
{
"comment": "We should make an abstraction for the client as well and pass it into this fn, from the aws client docs:\r\n```\r\n/// _Note:_ Client construction is expensive due to connection thread pool initialization, and should\r\n/// be done once at application start-up.\r\n```",
"path": "packages/fuels... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | Should be changed so that the credentials can be given via arg. But should fix itself if we abstract the aws client. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/packages/fuels-accounts/src/kms/aws/wallet.rs b/packages/fuels-accounts/src/kms/aws/wallet.rs
new file mode 100644
index 0000000000..90d9992d8b
--- /dev/null
+++ b/packages/fuels-accounts/src/kms/aws/wallet.rs
@@ -0,0 +1,281 @@
+use crate::accounts_utils::try_provider_error;
+use crate::provider::Provider;... | [
"packages/fuels-accounts/src/kms/aws/wallet.rs"
] | [
{
"comment": "Should be changed so that the credentials can be given via arg. But should fix itself if we abstract the aws client.",
"path": "packages/fuels-accounts/src/kms/aws/wallet.rs",
"hunk": "@@ -0,0 +1,256 @@\n+use crate::kms::aws::client::{AwsClient, AwsConfig};\n+use crate::provider::Provider;... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | ```suggestion
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/Cargo.toml b/e2e/Cargo.toml
index 1dc6a71104..10fb0a1904 100644
--- a/e2e/Cargo.toml
+++ b/e2e/Cargo.toml
@@ -18,11 +18,9 @@ chrono = { workspace = true }
fuel-asm = { workspace = true }
# TODO: [issue](https://github.com/FuelLabs/fuels-rs/issues/1375) needs to be removed, `ScriptTransaction` and `Cr... | [
"e2e/Cargo.toml"
] | [
{
"comment": "```suggestion\r\n```",
"path": "e2e/Cargo.toml",
"hunk": "@@ -18,22 +18,29 @@ chrono = { workspace = true }\n fuel-asm = { workspace = true }\n # TODO: [issue](https://github.com/FuelLabs/fuels-rs/issues/1375) needs to be removed, `ScriptTransaction` and `CreateTransaction` in `fuels` use ... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | ```suggestion
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/Cargo.toml b/e2e/Cargo.toml
index 1dc6a71104..10fb0a1904 100644
--- a/e2e/Cargo.toml
+++ b/e2e/Cargo.toml
@@ -18,11 +18,9 @@ chrono = { workspace = true }
fuel-asm = { workspace = true }
# TODO: [issue](https://github.com/FuelLabs/fuels-rs/issues/1375) needs to be removed, `ScriptTransaction` and `Cr... | [
"e2e/Cargo.toml"
] | [
{
"comment": "```suggestion\r\n```",
"path": "e2e/Cargo.toml",
"hunk": "@@ -18,22 +18,29 @@ chrono = { workspace = true }\n fuel-asm = { workspace = true }\n # TODO: [issue](https://github.com/FuelLabs/fuels-rs/issues/1375) needs to be removed, `ScriptTransaction` and `CreateTransaction` in `fuels` use ... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | ```suggestion
default = ["fuels/default", "coin-cache"]
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/Cargo.toml b/e2e/Cargo.toml
index 1dc6a71104..10fb0a1904 100644
--- a/e2e/Cargo.toml
+++ b/e2e/Cargo.toml
@@ -18,11 +18,9 @@ chrono = { workspace = true }
fuel-asm = { workspace = true }
# TODO: [issue](https://github.com/FuelLabs/fuels-rs/issues/1375) needs to be removed, `ScriptTransaction` and `Cr... | [
"e2e/Cargo.toml"
] | [
{
"comment": "```suggestion\r\ndefault = [\"fuels/default\", \"coin-cache\"]\r\n```",
"path": "e2e/Cargo.toml",
"hunk": "@@ -18,22 +18,29 @@ chrono = { workspace = true }\n fuel-asm = { workspace = true }\n # TODO: [issue](https://github.com/FuelLabs/fuels-rs/issues/1375) needs to be removed, `ScriptTra... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | It seems we've been preferring to use `-` instead of `_` in our features (e.g. `coin-cache`, `fuel-core-lib`, etc.)
Sorry for suggesting `kms_signer` [here](https://github.com/FuelLabs/fuels-rs/pull/1599#discussion_r1969254621). | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/packages/fuels-accounts/Cargo.toml b/packages/fuels-accounts/Cargo.toml
index 069b04ac8e..9948e36dfd 100644
--- a/packages/fuels-accounts/Cargo.toml
+++ b/packages/fuels-accounts/Cargo.toml
@@ -11,6 +11,10 @@ description = "Fuel Rust SDK accounts."
[dependencies]
async-trait = { workspace = true, defau... | [
"packages/fuels-accounts/Cargo.toml"
] | [
{
"comment": "It seems we've been preferring to use `-` instead of `_` in our features (e.g. `coin-cache`, `fuel-core-lib`, etc.)\r\n\r\nSorry for suggesting `kms_signer` [here](https://github.com/FuelLabs/fuels-rs/pull/1599#discussion_r1969254621).",
"path": "packages/fuels-accounts/Cargo.toml",
"hunk"... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | Same comment about `_` vs `-` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/packages/fuels/Cargo.toml b/packages/fuels/Cargo.toml
index 22df12e6bb..6c84c28442 100644
--- a/packages/fuels/Cargo.toml
+++ b/packages/fuels/Cargo.toml
@@ -41,3 +41,4 @@ std = [
]
fuel-core-lib = ["fuels-test-helpers?/fuel-core-lib"]
rocksdb = ["fuels-test-helpers?/rocksdb"]
+kms-signer = ["fuels-acco... | [
"packages/fuels/Cargo.toml"
] | [
{
"comment": "Same comment about `_` vs `-`",
"path": "packages/fuels/Cargo.toml",
"hunk": "@@ -41,3 +41,4 @@ std = [\n ]\n fuel-core-lib = [\"fuels-test-helpers?/fuel-core-lib\"]\n rocksdb = [\"fuels-test-helpers?/rocksdb\"]\n+kms_signer = [\"fuels-accounts/kms_signer\"]",
"resolving_sha": "a8c86cc... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | newline | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/Cargo.toml b/Cargo.toml
index 8b7167616b..c5d5a2d359 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -88,6 +88,10 @@ octocrab = { version = "0.43", default-features = false }
dotenv = { version = "0.15", default-features = false }
toml = { version = "0.8", default-features = false }
mockall = { version = "0... | [
"Cargo.toml"
] | [
{
"comment": "newline",
"path": "Cargo.toml",
"hunk": "@@ -89,6 +89,11 @@ dotenv = { version = \"0.15\", default-features = false }\n toml = { version = \"0.8\", default-features = false }\n mockall = { version = \"0.13\", default-features = false }\n \n+aws-config = { version = \"1\", default-features ... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | ```suggestion
assert_eq!(founded_coins, amount);
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/tests/aws.rs b/e2e/tests/aws.rs
new file mode 100644
index 0000000000..683c3bf103
--- /dev/null
+++ b/e2e/tests/aws.rs
@@ -0,0 +1,68 @@
+#[cfg(test)]
+mod tests {
+ use anyhow::Result;
+ use e2e::e2e_helpers::start_aws_kms;
+ use fuels::accounts::kms::AwsWallet;
+ use fuels::accounts::{Acco... | [
"e2e/tests/aws.rs"
] | [
{
"comment": "```suggestion\r\n assert_eq!(founded_coins, amount);\r\n```",
"path": "e2e/tests/aws.rs",
"hunk": "@@ -0,0 +1,90 @@\n+#[cfg(test)]\n+mod tests {\n+ use anyhow::Result;\n+ use e2e::e2e_helpers::start_aws_kms;\n+ use fuels::accounts::kms::AwsWallet;\n+ use fuels::accounts:... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | ```suggestion
assert_eq!(founded_coins, amount);
``` | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/tests/aws.rs b/e2e/tests/aws.rs
new file mode 100644
index 0000000000..683c3bf103
--- /dev/null
+++ b/e2e/tests/aws.rs
@@ -0,0 +1,68 @@
+#[cfg(test)]
+mod tests {
+ use anyhow::Result;
+ use e2e::e2e_helpers::start_aws_kms;
+ use fuels::accounts::kms::AwsWallet;
+ use fuels::accounts::{Acco... | [
"e2e/tests/aws.rs"
] | [
{
"comment": "```suggestion\r\n assert_eq!(founded_coins, amount);\r\n```",
"path": "e2e/tests/aws.rs",
"hunk": "@@ -0,0 +1,90 @@\n+#[cfg(test)]\n+mod tests {\n+ use anyhow::Result;\n+ use e2e::e2e_helpers::start_aws_kms;\n+ use fuels::accounts::kms::AwsWallet;\n+ use fuels::accounts:... | true | ||
FuelLabs/fuels-rs | 1,599 | comment_to_fix | feat: add support for AWS KMS | It's better if you don't hard code the total fee.
Get the `total_fee` from what you get back from `deploy`.
[This](https://github.com/FuelLabs/fuels-rs/pull/1574) has landed, if you need the total fee you can get it from the deployment response. | 57dd2e5a6d490ce67b282ddee7f59491e5e0aa0b | a8c86ccbeff56a4a41cac703311ab6fb3baadf4f | diff --git a/e2e/tests/aws.rs b/e2e/tests/aws.rs
new file mode 100644
index 0000000000..683c3bf103
--- /dev/null
+++ b/e2e/tests/aws.rs
@@ -0,0 +1,68 @@
+#[cfg(test)]
+mod tests {
+ use anyhow::Result;
+ use e2e::e2e_helpers::start_aws_kms;
+ use fuels::accounts::kms::AwsWallet;
+ use fuels::accounts::{Acco... | [
"e2e/tests/aws.rs"
] | [
{
"comment": "It's better if you don't hard code the total fee. \r\n\r\nGet the `total_fee` from what you get back from `deploy`.\r\n\r\n[This](https://github.com/FuelLabs/fuels-rs/pull/1574) has landed, if you need the total fee you can get it from the deployment response.",
"path": "e2e/tests/aws.rs",
... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.