repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
Genymobile/scrcpy | 6,777 | issue_to_patch | Add F11 as fullscreen shortcut | 3f7ecafc53dbd2ad3f4d2cf879bc14595396071f | 175134c0ca1d9018c14d10b467dbfcdff6d1c3be | diff --git a/app/scrcpy.1 b/app/scrcpy.1
index a3437019f8..a484de8487 100644
--- a/app/scrcpy.1
+++ b/app/scrcpy.1
@@ -696,7 +696,7 @@ In the following list, MOD is the shortcut modifier. By default, it's (left)
Alt or (left) Super, but it can be configured by \fB\-\-shortcut\-mod\fR (see above).
.TP
-.B MOD+f
+.B ... | [
"app/scrcpy.1",
"app/src/cli.c",
"app/src/input_manager.c",
"doc/shortcuts.md",
"doc/window.md"
] | [
{
"comment": "Am I correctly assuming that you want to forward the <kbd>F11</kbd> key to the device (as before) unless it corresponds to a toggle-fullscreen shortcut? There is a small inconsistency in the sense that <kbd>F11</kbd>-down is captured whereas <kbd>F11</kbd>-up is forwarded (surely harmless though).... | true | |||
Genymobile/scrcpy | 6,777 | comment_to_fix | Add F11 as fullscreen shortcut | Am I correctly assuming that you want to forward the <kbd>F11</kbd> key to the device (as before) unless it corresponds to a toggle-fullscreen shortcut? There is a small inconsistency in the sense that <kbd>F11</kbd>-down is captured whereas <kbd>F11</kbd>-up is forwarded (surely harmless though). I would have expected... | 3f7ecafc53dbd2ad3f4d2cf879bc14595396071f | 175134c0ca1d9018c14d10b467dbfcdff6d1c3be | diff --git a/app/src/input_manager.c b/app/src/input_manager.c
index 3ed26f11e8..b55ad591f4 100644
--- a/app/src/input_manager.c
+++ b/app/src/input_manager.c
@@ -447,6 +447,19 @@ sc_input_manager_process_key(struct sc_input_manager *im,
}
}
+ // Shortcuts that do not involve the MOD key
+ switch ... | [
"app/src/input_manager.c"
] | [
{
"comment": "Am I correctly assuming that you want to forward the <kbd>F11</kbd> key to the device (as before) unless it corresponds to a toggle-fullscreen shortcut? There is a small inconsistency in the sense that <kbd>F11</kbd>-down is captured whereas <kbd>F11</kbd>-up is forwarded (surely harmless though).... | true | ||
Genymobile/scrcpy | 6,777 | comment_to_fix | Add F11 as fullscreen shortcut | Maybe it's worth being documented as an alias in `doc/window.md#fullscreen`. | 3f7ecafc53dbd2ad3f4d2cf879bc14595396071f | 175134c0ca1d9018c14d10b467dbfcdff6d1c3be | diff --git a/doc/shortcuts.md b/doc/shortcuts.md
index 3a439d17ba..9fe1c0d28c 100644
--- a/doc/shortcuts.md
+++ b/doc/shortcuts.md
@@ -23,7 +23,7 @@ _<kbd>[Super]</kbd> is typically the <kbd>Windows</kbd> or <kbd>Cmd</kbd> key._
| Action | Shortcut
| ------------------------... | [
"doc/shortcuts.md"
] | [
{
"comment": "Maybe it's worth being documented as an alias in `doc/window.md#fullscreen`.",
"path": "doc/shortcuts.md",
"hunk": "@@ -23,7 +23,7 @@ _<kbd>[Super]</kbd> is typically the <kbd>Windows</kbd> or <kbd>Cmd</kbd> key._\n \n | Action | Shortcut\n | ------... | true | ||
Genymobile/scrcpy | 6,775 | issue_to_patch | Set default audio-output-buffer to 10ms | Change the default value of `--audio-output-buffer` from 5ms to 10ms.
In practice, the audio output backends do not support values below 10ms. When the setting is set to 5ms, several successive calls are made every 10ms or more.
Additionally, a 5ms output buffer can cause audio glitches on some computers.
Fixe... | f4a872bef4f048ea2bce0d273317dc93e30f881a | b5cc6f2be515e3d801e60e8d8de5dac99221a98c | diff --git a/app/scrcpy.1 b/app/scrcpy.1
index b6423c28c4..a3437019f8 100644
--- a/app/scrcpy.1
+++ b/app/scrcpy.1
@@ -87,9 +87,9 @@ Default is output.
.BI "\-\-audio\-output\-buffer " ms
Configure the size of the SDL audio output buffer (in milliseconds).
-If you get "robotic" audio playback, you should test with ... | [
"app/scrcpy.1",
"app/src/cli.c",
"app/src/options.c",
"doc/audio.md"
] | [] | true | ||
Genymobile/scrcpy | 6,774 | issue_to_patch | Fix aspect ratio accuracy | The window aspect ratio was previously enforced by calling `SDL_SetWindowAspectRatio()` before explicitly setting the window size, using the width/height ratio of the new size.
However, this size may already be a scaled version of the actual content size, subject to integer rounding. Using this derived size instead ... | 6034110140de63baf7dd89e4714cb95807c6bd66 | f4a872bef4f048ea2bce0d273317dc93e30f881a | diff --git a/app/src/screen.c b/app/src/screen.c
index b1bcdf3af8..683d3e5fa0 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -15,18 +15,16 @@
#define DOWNCAST(SINK) container_of(SINK, struct sc_screen, frame_sink)
static void
-set_window_size_ar(struct sc_screen *screen, struct sc_size window_size) {
- ... | [
"app/src/screen.c"
] | [] | true | ||
Genymobile/scrcpy | 6,770 | issue_to_patch | Reset capture on rotation (fix square displays) | `DisplayMonitor` previously only triggered a capture reset when the display size changed. In most cases, rotation also changes dimensions, so the behavior was correct… except for square displays where width and height remain unchanged.
However, rotation still requires a capture reset even when dimensions do not ... | b38ba2f6871e8601096521253f3da10c149d46c9 | 03878083fb8e5af806a78a3ad99f401edac47a95 | diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java
similarity index 70%
rename from server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java
rename to server/src/main/java/com/genymobile/scrcp... | [
"server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java",
"server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java",
"server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java",
"server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java"
] | [
{
"comment": "Two `Ln.v(\"DisplaySizeMonitor:` in `start()` that should be replaced with `DisplayMonitor`.",
"path": "server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java",
"hunk": "",
"resolving_sha": "03878083fb8e5af806a78a3ad99f401edac47a95",
"resolving_diff": "diff --git a/... | true | ||
Genymobile/scrcpy | 6,770 | comment_to_fix | Reset capture on rotation (fix square displays) | Two `Ln.v("DisplaySizeMonitor:` in `start()` that should be replaced with `DisplayMonitor`. | b38ba2f6871e8601096521253f3da10c149d46c9 | 03878083fb8e5af806a78a3ad99f401edac47a95 | diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java
similarity index 70%
rename from server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java
rename to server/src/main/java/com/genymobile/scrcp... | [
"server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java"
] | [
{
"comment": "Two `Ln.v(\"DisplaySizeMonitor:` in `start()` that should be replaced with `DisplayMonitor`.",
"path": "server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java",
"hunk": "",
"resolving_sha": "03878083fb8e5af806a78a3ad99f401edac47a95",
"resolving_diff": "diff --git a/... | true | ||
Genymobile/scrcpy | 6,770 | comment_to_fix | Reset capture on rotation (fix square displays) | ```suggestion
private void checkDisplayPropertiesChanged() {
``` | b38ba2f6871e8601096521253f3da10c149d46c9 | 03878083fb8e5af806a78a3ad99f401edac47a95 | diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java
similarity index 70%
rename from server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java
rename to server/src/main/java/com/genymobile/scrcp... | [
"server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java"
] | [
{
"comment": "```suggestion\n private void checkDisplayPropertiesChanged() {\n```",
"path": "server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java",
"hunk": "@@ -97,38 +96,38 @@ public void stopAndRelease() {\n }\n }\n \n- private synchronized Size getAndSetSessionDisp... | true | ||
Genymobile/scrcpy | 6,770 | comment_to_fix | Reset capture on rotation (fix square displays) | ```suggestion
void onDisplayPropertiesChanged();
``` | b38ba2f6871e8601096521253f3da10c149d46c9 | 03878083fb8e5af806a78a3ad99f401edac47a95 | diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java
similarity index 70%
rename from server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java
rename to server/src/main/java/com/genymobile/scrcp... | [
"server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java"
] | [
{
"comment": "```suggestion\n void onDisplayPropertiesChanged();\n```",
"path": "server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java",
"hunk": "@@ -14,7 +13,7 @@\n import android.os.HandlerThread;\n import android.view.IDisplayWindowListener;\n \n-public class DisplaySizeMonito... | true | ||
Genymobile/scrcpy | 6,770 | comment_to_fix | Reset capture on rotation (fix square displays) | ```suggestion
// We can't compare with the current properties, so reset unconditionally
``` | b38ba2f6871e8601096521253f3da10c149d46c9 | 03878083fb8e5af806a78a3ad99f401edac47a95 | diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java
similarity index 70%
rename from server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java
rename to server/src/main/java/com/genymobile/scrcp... | [
"server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java"
] | [
{
"comment": "```suggestion\n // We can't compare with the current properties, so reset unconditionally\n```",
"path": "server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java",
"hunk": "@@ -97,38 +96,38 @@ public void stopAndRelease() {\n }\n }\n \n- private syn... | true | ||
Genymobile/scrcpy | 6,770 | comment_to_fix | Reset capture on rotation (fix square displays) | ```suggestion
// Reset only if the properties are different
``` | b38ba2f6871e8601096521253f3da10c149d46c9 | 03878083fb8e5af806a78a3ad99f401edac47a95 | diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java
similarity index 70%
rename from server/src/main/java/com/genymobile/scrcpy/display/DisplaySizeMonitor.java
rename to server/src/main/java/com/genymobile/scrcp... | [
"server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java"
] | [
{
"comment": "```suggestion\n // Reset only if the properties are different\n```",
"path": "server/src/main/java/com/genymobile/scrcpy/display/DisplayMonitor.java",
"hunk": "@@ -97,38 +96,38 @@ public void stopAndRelease() {\n }\n }\n \n- private synchronized Size getAndSet... | true | ||
Genymobile/scrcpy | 6,770 | comment_to_fix | Reset capture on rotation (fix square displays) | ```suggestion
// Set the current display properties to avoid an unnecessary call to invalidate()
``` | b38ba2f6871e8601096521253f3da10c149d46c9 | 03878083fb8e5af806a78a3ad99f401edac47a95 | diff --git a/server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java b/server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java
index ae72877236..5608d13103 100644
--- a/server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java
+++ b/server/src/main/java/com/genymobile/scrcp... | [
"server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java"
] | [
{
"comment": "```suggestion\n // Set the current display properties to avoid an unnecessary call to invalidate()\n```",
"path": "server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java",
"hunk": "@@ -113,7 +114,7 @@ public void prepare() {\n \n displayRotation = 0;... | true | ||
Genymobile/scrcpy | 6,770 | comment_to_fix | Reset capture on rotation (fix square displays) | ```suggestion
private final DisplayMonitor displayMonitor = new DisplayMonitor();
``` | b38ba2f6871e8601096521253f3da10c149d46c9 | 03878083fb8e5af806a78a3ad99f401edac47a95 | diff --git a/server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java b/server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java
index ae72877236..5608d13103 100644
--- a/server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java
+++ b/server/src/main/java/com/genymobile/scrcp... | [
"server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java"
] | [
{
"comment": "```suggestion\n private final DisplayMonitor displayMonitor = new DisplayMonitor();\n```",
"path": "server/src/main/java/com/genymobile/scrcpy/video/NewDisplayCapture.java",
"hunk": "@@ -42,7 +43,7 @@ public class NewDisplayCapture extends SurfaceCapture {\n private final VirtualDis... | true | ||
Genymobile/scrcpy | 6,770 | comment_to_fix | Reset capture on rotation (fix square displays) | ```suggestion
private final DisplayMonitor displayMonitor = new DisplayMonitor();
``` | b38ba2f6871e8601096521253f3da10c149d46c9 | 03878083fb8e5af806a78a3ad99f401edac47a95 | diff --git a/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java b/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java
index 77d2eb1706..adabdfb09b 100644
--- a/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java
+++ b/server/src/main/java/com/genymobile/scrcpy/video/Scre... | [
"server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java"
] | [
{
"comment": "```suggestion\n private final DisplayMonitor displayMonitor = new DisplayMonitor();\n```",
"path": "server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java",
"hunk": "@@ -38,7 +39,7 @@ public class ScreenCapture extends SurfaceCapture {\n private DisplayInfo displayInfo;... | true | ||
Genymobile/scrcpy | 6,770 | comment_to_fix | Reset capture on rotation (fix square displays) | ```suggestion
int displayRotation = displayInfo.getRotation();
displayMonitor.setSessionDisplayProperties(new DisplayProperties(displaySize, displayRotation));
```
Then there are three more occurrences of `displayInfo.getRotation()` that can be replaced with `displayRotation` below in `prepare()`. | b38ba2f6871e8601096521253f3da10c149d46c9 | 03878083fb8e5af806a78a3ad99f401edac47a95 | diff --git a/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java b/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java
index 77d2eb1706..adabdfb09b 100644
--- a/server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java
+++ b/server/src/main/java/com/genymobile/scrcpy/video/Scre... | [
"server/src/main/java/com/genymobile/scrcpy/video/ScreenCapture.java"
] | [
{
"comment": "```suggestion\n int displayRotation = displayInfo.getRotation();\n displayMonitor.setSessionDisplayProperties(new DisplayProperties(displaySize, displayRotation));\n```\nThen there are three more occurrences of `displayInfo.getRotation()` that can be replaced with `displayRotation` b... | true | ||
Genymobile/scrcpy | 6,770 | comment_to_fix | Reset capture on rotation (fix square displays) | I think you have to override [`Object.equals()`](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Object.html#equals(java.lang.Object)) (used in `DisplayMonitor`), right? And `Object.hashCode()` too for good measure, like you did in `Size`. | b38ba2f6871e8601096521253f3da10c149d46c9 | 03878083fb8e5af806a78a3ad99f401edac47a95 | diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java
new file mode 100644
index 0000000000..d3658334e3
--- /dev/null
+++ b/server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java
@@ -0,0 +1,52... | [
"server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java"
] | [
{
"comment": "I think you have to override [`Object.equals()`](https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/lang/Object.html#equals(java.lang.Object)) (used in `DisplayMonitor`), right? And `Object.hashCode()` too for good measure, like you did in `Size`.",
"path": "server/src/main/java... | true | ||
Genymobile/scrcpy | 6,770 | comment_to_fix | Reset capture on rotation (fix square displays) | ```suggestion
return size + " [rotation=" + rotation + "]";
```
I don't know if using a char was intentional? For instance in `Size.toString()` you make a string literal for the character in the middle: `"x"` | b38ba2f6871e8601096521253f3da10c149d46c9 | 03878083fb8e5af806a78a3ad99f401edac47a95 | diff --git a/server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java b/server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java
new file mode 100644
index 0000000000..d3658334e3
--- /dev/null
+++ b/server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java
@@ -0,0 +1,52... | [
"server/src/main/java/com/genymobile/scrcpy/display/DisplayProperties.java"
] | [
{
"comment": "```suggestion\n return size + \" [rotation=\" + rotation + \"]\";\n```\nI don't know if using a char was intentional? For instance in `Size.toString()` you make a string literal for the character in the middle: `\"x\"`",
"path": "server/src/main/java/com/genymobile/scrcpy/display/Displa... | true | ||
Genymobile/scrcpy | 6,758 | issue_to_patch | Factorize resize event handling | Reuse the same code to handle resize events from the event loop or the event watcher., and avoid double-rendering on resize
On Windows and macOS, resizing the window with the mouse blocks the event loop until the click is released. To keep rendering during resizing, an event watcher is registered to handle resize ev... | 07f8eb0ec66c8a878874fcd095fe302a344c99fa | 523c820bfaa6b51498342107942ef9bb1c050e0d | diff --git a/app/src/screen.c b/app/src/screen.c
index 9f1876ed86..71eee81f69 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -261,6 +261,14 @@ sc_screen_render(struct sc_screen *screen, bool update_content_rect) {
sc_sdl_render_present(renderer);
}
+static void
+sc_screen_on_resize(struct sc_screen *sc... | [
"app/src/screen.c"
] | [] | true | ||
Genymobile/scrcpy | 6,746 | issue_to_patch | Use optimal size alignment | The video was always constrained to use a size that is a multiple of 8.
This was sometimes not necessary (recent codecs only require a video size that is a multiple of 2 or even 1) and sometimes insufficient (some codecs require a size that is multiple of 16).
Use the size alignment required by the codec.
Also... | 5fedc79530672ae2b0df6ac7654d75a6f2e18ce3 | de3db4299793450b6d28648852c70ba18ff7887c | diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy
index 956926ac83..dd8ea42432 100644
--- a/app/data/bash-completion/scrcpy
+++ b/app/data/bash-completion/scrcpy
@@ -45,6 +45,7 @@ _scrcpy() {
-m --max-size=
-M
--max-fps=
+ --min-size-alignment=
--m... | [
"app/data/bash-completion/scrcpy",
"app/data/zsh-completion/_scrcpy",
"app/scrcpy.1",
"app/src/cli.c",
"app/src/options.c",
"app/src/options.h",
"app/src/scrcpy.c",
"app/src/server.c",
"app/src/server.h",
"doc/video.md",
"server/src/main/java/com/genymobile/scrcpy/Options.java",
"server/src/ma... | [
{
"comment": "Documentation should be updated, e.g.:\n```diff\n /**\n- * Round both dimensions of this size to be a multiple of 8 (as required by many encoders).\n+ * Round both dimensions of this size to be a multiple of {@code alignment} (as required by many encoders).\n *\n+ * @param alignmen... | true | ||
Genymobile/scrcpy | 6,746 | comment_to_fix | Use optimal size alignment | Documentation should be updated, e.g.:
```diff
/**
- * Round both dimensions of this size to be a multiple of 8 (as required by many encoders).
+ * Round both dimensions of this size to be a multiple of {@code alignment} (as required by many encoders).
*
+ * @param alignment The required alignment.
... | 5fedc79530672ae2b0df6ac7654d75a6f2e18ce3 | de3db4299793450b6d28648852c70ba18ff7887c | diff --git a/server/src/main/java/com/genymobile/scrcpy/device/Size.java b/server/src/main/java/com/genymobile/scrcpy/device/Size.java
index b448273de6..b684a54e60 100644
--- a/server/src/main/java/com/genymobile/scrcpy/device/Size.java
+++ b/server/src/main/java/com/genymobile/scrcpy/device/Size.java
@@ -31,7 +31,6 @@... | [
"server/src/main/java/com/genymobile/scrcpy/device/Size.java"
] | [
{
"comment": "Documentation should be updated, e.g.:\n```diff\n /**\n- * Round both dimensions of this size to be a multiple of 8 (as required by many encoders).\n+ * Round both dimensions of this size to be a multiple of {@code alignment} (as required by many encoders).\n *\n+ * @param alignmen... | true | ||
Genymobile/scrcpy | 6,746 | comment_to_fix | Use optimal size alignment | To follow your recent changes:
```suggestion
* This a power-of-2 value that the video width and height must be multiples of.
``` | 5fedc79530672ae2b0df6ac7654d75a6f2e18ce3 | de3db4299793450b6d28648852c70ba18ff7887c | diff --git a/server/src/main/java/com/genymobile/scrcpy/video/SurfaceCapture.java b/server/src/main/java/com/genymobile/scrcpy/video/SurfaceCapture.java
index 3144dc511f..81da337b77 100644
--- a/server/src/main/java/com/genymobile/scrcpy/video/SurfaceCapture.java
+++ b/server/src/main/java/com/genymobile/scrcpy/video/S... | [
"server/src/main/java/com/genymobile/scrcpy/video/SurfaceCapture.java"
] | [
{
"comment": "To follow your recent changes:\n```suggestion\n * This a power-of-2 value that the video width and height must be multiples of.\n```",
"path": "server/src/main/java/com/genymobile/scrcpy/video/SurfaceCapture.java",
"hunk": "@@ -86,4 +88,15 @@ public void stop() {\n public boolean i... | true | ||
Genymobile/scrcpy | 6,746 | comment_to_fix | Use optimal size alignment | Like other code blocks:
```suggestion
```bash
``` | 5fedc79530672ae2b0df6ac7654d75a6f2e18ce3 | de3db4299793450b6d28648852c70ba18ff7887c | diff --git a/doc/video.md b/doc/video.md
index 4de6814a76..8cea0373e8 100644
--- a/doc/video.md
+++ b/doc/video.md
@@ -30,6 +30,17 @@ If encoding fails, scrcpy automatically tries again with a lower definition
For camera mirroring, the `--max-size` value is used to select the camera source
size instead (among the ava... | [
"doc/video.md"
] | [
{
"comment": "Like other code blocks:\n```suggestion\n```bash\n```",
"path": "doc/video.md",
"hunk": "@@ -30,6 +30,17 @@ If encoding fails, scrcpy automatically tries again with a lower definition\n For camera mirroring, the `--max-size` value is used to select the camera source\n size instead (among th... | true | ||
Genymobile/scrcpy | 6,694 | issue_to_patch | Open the scrcpy window earlier | Previously, the window was opened only once the first frame was available. Instead, open it as soon as the frame dimensions are known.
This is especially useful when the encoder does not produce an initial frame while the phone is turned off (e.g., with `--no-power-on`).
Fixes #6546 | 10e0c3226c3a3a9078c86a42c931d9b288e035f0 | e17a885f32fcc90337c9719ad3908cecaf03f8f1 | diff --git a/app/src/events.h b/app/src/events.h
index 8667bc5796..567268ab7f 100644
--- a/app/src/events.h
+++ b/app/src/events.h
@@ -9,6 +9,7 @@
enum {
SC_EVENT_NEW_FRAME = SDL_EVENT_USER,
+ SC_EVENT_OPEN_WINDOW,
SC_EVENT_RUN_ON_MAIN_THREAD,
SC_EVENT_DEVICE_DISCONNECTED,
SC_EVENT_SERVER_CONN... | [
"app/src/events.h",
"app/src/screen.c",
"app/src/screen.h"
] | [
{
"comment": "```suggestion\n struct sc_size render_size = sc_sdl_get_render_output_size(renderer);\n```",
"path": "app/src/screen.c",
"hunk": "@@ -198,19 +198,31 @@ sc_screen_update_content_rect(struct sc_screen *screen) {\n // changed, so that the content rectangle is recomputed\n static void\n... | true | ||
Genymobile/scrcpy | 6,694 | comment_to_fix | Open the scrcpy window earlier | ```suggestion
struct sc_size render_size = sc_sdl_get_render_output_size(renderer);
``` | 10e0c3226c3a3a9078c86a42c931d9b288e035f0 | e17a885f32fcc90337c9719ad3908cecaf03f8f1 | diff --git a/app/src/screen.c b/app/src/screen.c
index d78dff7bc5..d50b670f89 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -198,19 +198,30 @@ sc_screen_update_content_rect(struct sc_screen *screen) {
// changed, so that the content rectangle is recomputed
static void
sc_screen_render(struct sc_screen *scr... | [
"app/src/screen.c"
] | [
{
"comment": "```suggestion\n struct sc_size render_size = sc_sdl_get_render_output_size(renderer);\n```",
"path": "app/src/screen.c",
"hunk": "@@ -198,19 +198,31 @@ sc_screen_update_content_rect(struct sc_screen *screen) {\n // changed, so that the content rectangle is recomputed\n static void\n... | true | ||
Genymobile/scrcpy | 6,694 | comment_to_fix | Open the scrcpy window earlier | Casts to `(void)` for unused variables can be removed in this function since `ctx`, `session` and `screen` are now used. | 10e0c3226c3a3a9078c86a42c931d9b288e035f0 | e17a885f32fcc90337c9719ad3908cecaf03f8f1 | diff --git a/app/src/screen.c b/app/src/screen.c
index d78dff7bc5..d50b670f89 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -198,19 +198,30 @@ sc_screen_update_content_rect(struct sc_screen *screen) {
// changed, so that the content rectangle is recomputed
static void
sc_screen_render(struct sc_screen *scr... | [
"app/src/screen.c"
] | [
{
"comment": "Casts to `(void)` for unused variables can be removed in this function since `ctx`, `session` and `screen` are now used.",
"path": "app/src/screen.c",
"hunk": "@@ -292,6 +304,19 @@ sc_screen_frame_sink_open(struct sc_frame_sink *sink,\n return false;\n }\n \n+ // content_siz... | true | ||
Genymobile/scrcpy | 6,694 | comment_to_fix | Open the scrcpy window earlier | What if pushing the event fails? Will the app quit? Else, will the first frame (and next ones) be able to render or will there be just no window at all? | 10e0c3226c3a3a9078c86a42c931d9b288e035f0 | e17a885f32fcc90337c9719ad3908cecaf03f8f1 | diff --git a/app/src/screen.c b/app/src/screen.c
index d78dff7bc5..d50b670f89 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -198,19 +198,30 @@ sc_screen_update_content_rect(struct sc_screen *screen) {
// changed, so that the content rectangle is recomputed
static void
sc_screen_render(struct sc_screen *scr... | [
"app/src/screen.c"
] | [
{
"comment": "What if pushing the event fails? Will the app quit? Else, will the first frame (and next ones) be able to render or will there be just no window at all?",
"path": "app/src/screen.c",
"hunk": "@@ -292,6 +304,19 @@ sc_screen_frame_sink_open(struct sc_frame_sink *sink,\n return false;... | true | ||
Genymobile/scrcpy | 6,694 | comment_to_fix | Open the scrcpy window earlier | ```suggestion
return;
```
Don't know if input events should be handled after this; all other cases return from this switch. | 10e0c3226c3a3a9078c86a42c931d9b288e035f0 | e17a885f32fcc90337c9719ad3908cecaf03f8f1 | diff --git a/app/src/screen.c b/app/src/screen.c
index d78dff7bc5..d50b670f89 100644
--- a/app/src/screen.c
+++ b/app/src/screen.c
@@ -198,19 +198,30 @@ sc_screen_update_content_rect(struct sc_screen *screen) {
// changed, so that the content rectangle is recomputed
static void
sc_screen_render(struct sc_screen *scr... | [
"app/src/screen.c"
] | [
{
"comment": "```suggestion\n return;\n```\nDon't know if input events should be handled after this; all other cases return from this switch.",
"path": "app/src/screen.c",
"hunk": "@@ -854,9 +863,18 @@ sc_screen_resize_to_pixel_perfect(struct sc_screen *screen) {\n \n void\n sc_screen_handle_... | true | ||
Genymobile/scrcpy | 6,667 | issue_to_patch | Keep Windows terminal open on error by default | If scrcpy is launched by double-clicking `scrcpy.exe` in Windows Explorer, automatically set `--pause-on-exit=if-error`.
Without this, the terminal would close immediately, preventing the user from seeing the error.
Also remove `scrcpy-console.bat`, which is now useless.
---
Detecting whether it is launched... | f91fa56593ecf1b6b5355b000899fbcc465e845b | 8b0206f7bea4929829da09d1ebe0492bcb60e57f | diff --git a/app/data/scrcpy-console.bat b/app/data/scrcpy-console.bat
deleted file mode 100644
index 0ea7619f4a..0000000000
--- a/app/data/scrcpy-console.bat
+++ /dev/null
@@ -1,2 +0,0 @@
-@echo off
-scrcpy.exe --pause-on-exit=if-error %*
diff --git a/app/src/cli.c b/app/src/cli.c
index 9c955fb532..c3a955832d 100644... | [
"app/data/scrcpy-console.bat",
"app/src/cli.c",
"app/src/cli.h",
"app/src/main.c",
"doc/windows.md",
"release/build_windows.sh"
] | [
{
"comment": "```suggestion\n`scrcpy-noconsole.vbs` and add the desired arguments.\n```",
"path": "doc/windows.md",
"hunk": "@@ -92,9 +80,17 @@ example:\n scrcpy --prefer-text --turn-screen-off --stay-awake\n ```\n \n+Add `--pause-on-exit=if-error` if you want the console to remain open when\n+scrcpy fa... | true | ||
Genymobile/scrcpy | 6,667 | comment_to_fix | Keep Windows terminal open on error by default | ```suggestion
`scrcpy-noconsole.vbs` and add the desired arguments.
``` | f91fa56593ecf1b6b5355b000899fbcc465e845b | 8b0206f7bea4929829da09d1ebe0492bcb60e57f | diff --git a/doc/windows.md b/doc/windows.md
index cdc30bdce9..b0c4c5ca98 100644
--- a/doc/windows.md
+++ b/doc/windows.md
@@ -72,18 +72,6 @@ Documentation for command line arguments is available:
- `scrcpy --help`
- on [github](/README.md)
-To start scrcpy directly without opening a terminal, double-click on one... | [
"doc/windows.md"
] | [
{
"comment": "```suggestion\n`scrcpy-noconsole.vbs` and add the desired arguments.\n```",
"path": "doc/windows.md",
"hunk": "@@ -92,9 +80,17 @@ example:\n scrcpy --prefer-text --turn-screen-off --stay-awake\n ```\n \n+Add `--pause-on-exit=if-error` if you want the console to remain open when\n+scrcpy fa... | true | ||
Genymobile/scrcpy | 6,671 | issue_to_patch | Prevent build from falling back to system libs | Ensure that if a file or function is not found, the build does not attempt to use system libraries. Falling back could introduce incompatible versions or libraries compiles with different features. | 90d11810e3eaa2938459752ec2fdaf0b61395cca | 323549e82f0604400b487ec6cfa5d2640a20b6ee | diff --git a/release/build_linux.sh b/release/build_linux.sh
index 6bca6979d7..e83d355e00 100755
--- a/release/build_linux.sh
+++ b/release/build_linux.sh
@@ -22,9 +22,12 @@ app/deps/libusb.sh linux native static
DEPS_INSTALL_DIR="$PWD/app/deps/work/install/linux-native-static"
ADB_INSTALL_DIR="$PWD/app/deps/work/ins... | [
"release/build_linux.sh",
"release/build_macos.sh",
"release/build_windows.sh"
] | [] | true | ||
Genymobile/scrcpy | 6,670 | issue_to_patch | Set low-latency high-priority encoder hints by default | See https://github.com/Genymobile/scrcpy/issues/6238#issuecomment-3828402687
Doc:
- https://developer.android.com/reference/android/media/MediaFormat#KEY_PRIORITY
- https://developer.android.com/reference/android/media/MediaFormat#KEY_LATENCY | 8b0206f7bea4929829da09d1ebe0492bcb60e57f | 90d11810e3eaa2938459752ec2fdaf0b61395cca | diff --git a/server/src/main/java/com/genymobile/scrcpy/video/SurfaceEncoder.java b/server/src/main/java/com/genymobile/scrcpy/video/SurfaceEncoder.java
index 461ba4723d..0f7e9a210d 100644
--- a/server/src/main/java/com/genymobile/scrcpy/video/SurfaceEncoder.java
+++ b/server/src/main/java/com/genymobile/scrcpy/video/S... | [
"server/src/main/java/com/genymobile/scrcpy/video/SurfaceEncoder.java"
] | [] | true | ||
Genymobile/scrcpy | 6,665 | issue_to_patch | Detect TCP devices provided by mDNS | Their serial is not in the form ip:port, but rather a complex string containing "adb-tls-connect".
Fixes #6248 | 82e102e036c7b983ea8a1af418213fd0c31bd7d0 | 51cbd9a5bc26a028d9546efc8a8a2ac1881b300a | diff --git a/app/src/adb/adb_device.c b/app/src/adb/adb_device.c
index 5ea8eb44a6..2dc78c9f7a 100644
--- a/app/src/adb/adb_device.c
+++ b/app/src/adb/adb_device.c
@@ -39,5 +39,11 @@ sc_adb_device_get_type(const char *serial) {
return SC_ADB_DEVICE_TYPE_TCPIP;
}
+ // TCP/IP devices provided by mDNS co... | [
"app/src/adb/adb_device.c"
] | [] | true | ||
Genymobile/scrcpy | 6,664 | issue_to_patch | Improve adb devices parsing | `adb devices -l` prints one device per line, containing, separated by spaces:
- the device serial,
- the device state,
- a list of key:value pairs.
However, the device serial itself may contain spaces, making a simple split ambiguous.
To avoid ambiguity, parse the string backwards:
- first, parse all the ... | e39d7a06e461c5731dc0529dfa3240a2f5f1c13e | 82e102e036c7b983ea8a1af418213fd0c31bd7d0 | diff --git a/app/src/adb/adb_parser.c b/app/src/adb/adb_parser.c
index 90a1b30b9a..72fd141d60 100644
--- a/app/src/adb/adb_parser.c
+++ b/app/src/adb/adb_parser.c
@@ -8,6 +8,49 @@
#include "util/log.h"
#include "util/str.h"
+static size_t
+rstrip_len(const char *s, size_t len) {
+ size_t i = len;
+
+ // Ignor... | [
"app/src/adb/adb_parser.c",
"app/tests/test_adb_parser.c"
] | [
{
"comment": "When using libusb backend (`$ADB_LIBUSB=1` or default on some [older versions](https://developer.android.com/tools/releases/platform-tools#3500_february_2024)) the devpath doesn't have a colon:\n\n```txt\n$ adb devices -l\nList of devices attached\nbd9d00cc device 3-1 product:manet m... | diff --git a/app/tests/test_adb_parser.c b/app/tests/test_adb_parser.c
index 362b254fff..822ed798b2 100644
--- a/app/tests/test_adb_parser.c
+++ b/app/tests/test_adb_parser.c
@@ -163,6 +163,45 @@ static void test_adb_devices_spaces(void) {
sc_adb_devices_destroy(&vec);
}
+static void test_adb_devices_serial_wit... | true | |
Genymobile/scrcpy | 6,664 | comment_to_fix | Improve adb devices parsing | When using libusb backend (`$ADB_LIBUSB=1` or default on some [older versions](https://developer.android.com/tools/releases/platform-tools#3500_february_2024)) the devpath doesn't have a colon:
```txt
$ adb devices -l
List of devices attached
bd9d00cc device 3-1 product:manet model:23117RK66C device:mane... | e39d7a06e461c5731dc0529dfa3240a2f5f1c13e | 82e102e036c7b983ea8a1af418213fd0c31bd7d0 | diff --git a/app/src/adb/adb_parser.c b/app/src/adb/adb_parser.c
index 90a1b30b9a..72fd141d60 100644
--- a/app/src/adb/adb_parser.c
+++ b/app/src/adb/adb_parser.c
@@ -8,6 +8,49 @@
#include "util/log.h"
#include "util/str.h"
+static size_t
+rstrip_len(const char *s, size_t len) {
+ size_t i = len;
+
+ // Ignor... | [
"app/src/adb/adb_parser.c"
] | [
{
"comment": "When using libusb backend (`$ADB_LIBUSB=1` or default on some [older versions](https://developer.android.com/tools/releases/platform-tools#3500_february_2024)) the devpath doesn't have a colon:\n\n```txt\n$ adb devices -l\nList of devices attached\nbd9d00cc device 3-1 product:manet m... | true | ||
Genymobile/scrcpy | 6,663 | issue_to_patch | Properly serialize command line arguments for Windows | Scrcpy exposes a process API to execute commands:
https://github.com/Genymobile/scrcpy/blob/c8c1316db9adefca6aae054be936049c2f8e02f1/app/src/util/process.h#L72-L95
In practice, it is only used to execute simple `adb` commands, so the Windows implementation was very simple, but very incomplete:
https://github.c... | bb6d1c634834d6262d8daee6a162ce53311c976f | e39d7a06e461c5731dc0529dfa3240a2f5f1c13e | diff --git a/app/meson.build b/app/meson.build
index c730ce0755..35c2e3eac9 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -75,6 +75,7 @@ conf.set('_GNU_SOURCE', true)
if host_machine.system() == 'windows'
windows = import('windows')
src += [
+ 'src/util/command.c',
'src/sys/win/file.c... | [
"app/meson.build",
"app/src/adb/adb.c",
"app/src/sys/win/process.c",
"app/src/util/command.c",
"app/src/util/command.h",
"app/src/util/str.c",
"app/src/util/str.h",
"app/tests/test_command_windows.c",
"app/tests/test_str.c"
] | [] | diff --git a/app/tests/test_command_windows.c b/app/tests/test_command_windows.c
new file mode 100644
index 0000000000..e041250c87
--- /dev/null
+++ b/app/tests/test_command_windows.c
@@ -0,0 +1,61 @@
+#include "common.h"
+
+#include <assert.h>
+#include <stdlib.h>
+
+#include "util/command.h"
+
+static void test_comma... | true | |
Genymobile/scrcpy | 6,651 | issue_to_patch | Refactor: Move rendering to sc_screen and introduce sc_texture | Three components are involved in displaying device content on screen:
- a window
- a renderer
- a texture
Originally, all three were handled by `sc_screen`.
Commit 051b74c88338702508d98bd532057b343e0a177c later extracted the renderer and texture into a separate component, `sc_display`.
However, the split... | c497718a3e3617c60a2d7cc8decfa9adc32d05d2 | 77998f543f4b1dfb5e3c1863593190c2711253b0 | diff --git a/app/meson.build b/app/meson.build
index 36b72cfdbe..c730ce0755 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -15,7 +15,6 @@ src = [
'src/delay_buffer.c',
'src/demuxer.c',
'src/device_msg.c',
- 'src/display.c',
'src/events.c',
'src/icon.c',
'src/file_pusher.c',
@@ -3... | [
"app/meson.build",
"app/src/display.c",
"app/src/display.h",
"app/src/input_manager.c",
"app/src/screen.c",
"app/src/screen.h",
"app/src/texture.c",
"app/src/texture.h",
"app/src/util/sdl.c",
"app/src/util/sdl.h"
] | [] | true | ||
Genymobile/scrcpy | 6,649 | issue_to_patch | Refactor: Use common sc_screen for normal and OTG modes | Originally, the default scrcpy window always displayed the video stream. Since the OTG mode window only contains the scrcpy logo, it was implemented as a separate component (91418c79ab3b7056c21ef6c64f903704c8f00a52).
Later, the `--no-video` option was added (8c650e53cd37a53d5c3aa746c30a71c6b742a4e2) to control the d... | 1a99a46b574ff3beac20ec1cbc71ad9c24c90258 | 07f056353bf4295c3721dac066bd2cc1b9f7ae04 | diff --git a/app/meson.build b/app/meson.build
index 6f6f64c19d..36b72cfdbe 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -104,7 +104,6 @@ if usb_support
'src/usb/keyboard_aoa.c',
'src/usb/mouse_aoa.c',
'src/usb/scrcpy_otg.c',
- 'src/usb/screen_otg.c',
'src/usb/usb.c',... | [
"app/meson.build",
"app/src/input_manager.c",
"app/src/usb/scrcpy_otg.c",
"app/src/usb/screen_otg.c",
"app/src/usb/screen_otg.h"
] | [] | true | ||
Genymobile/scrcpy | 6,159 | issue_to_patch | Add session metadata for video stream | Introduce a new packet type, a "session" packet, containing metadata about the encoding session. It is used only for the video stream, and currently includes the video resolution.
For illustration, here is a sequence of packets on the video stream:
device rotation
... | f4cc07da24939890e546f6be972ca9ad15b7621e | 826076f753832789d3b879c4215efcf616e49e61 | diff --git a/app/src/audio_player.c b/app/src/audio_player.c
index 3e88ea453f..270e29d496 100644
--- a/app/src/audio_player.c
+++ b/app/src/audio_player.c
@@ -47,7 +47,10 @@ sc_audio_player_frame_sink_push(struct sc_frame_sink *sink,
static bool
sc_audio_player_frame_sink_open(struct sc_frame_sink *sink,
- ... | [
"app/src/audio_player.c",
"app/src/decoder.c",
"app/src/decoder.h",
"app/src/delay_buffer.c",
"app/src/delay_buffer.h",
"app/src/demuxer.c",
"app/src/recorder.c",
"app/src/screen.c",
"app/src/trait/frame_sink.h",
"app/src/trait/frame_source.c",
"app/src/trait/frame_source.h",
"app/src/trait/pa... | [] | true | ||
Genymobile/scrcpy | 5,870 | issue_to_patch | [Feature request] option to choose unprocessed microphone output of phone (and other processing options)
I would like to have an option to remove the processing applied by the phone to it's microphone before being send via scrcpy.
by selecting a flag
for example
--mic-processing process
... | Add many audio sources (including voice) | The existing audio sources were:
- `output` (default): forwards the whole audio output, and disables playback on the device (mapped to [`REMOTE_SUBMIX`](https://developer.android.com/reference/android/media/MediaRecorder.AudioSource#REMOTE_SUBMIX)).
- `playback`: captures the audio playback (Android apps can opt-... | c63d9e1803c658b29b067d5ea68baa38df7e1359 | bef2d8473b3426b1dd2ea9ed0cae3a243a999218 | diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy
index 8d149f9745..9918918c36 100644
--- a/app/data/bash-completion/scrcpy
+++ b/app/data/bash-completion/scrcpy
@@ -122,7 +122,7 @@ _scrcpy() {
return
;;
--audio-source)
- COMPREPLY=($(compgen -W... | [
"app/data/bash-completion/scrcpy",
"app/data/zsh-completion/_scrcpy",
"app/scrcpy.1",
"app/src/audio_regulator.c",
"app/src/audio_regulator.h",
"app/src/cli.c",
"app/src/options.h",
"app/src/server.c",
"app/src/util/audiobuf.c",
"app/src/util/audiobuf.h",
"app/tests/test_audiobuf.c",
"doc/audi... | [] | diff --git a/app/tests/test_audiobuf.c b/app/tests/test_audiobuf.c
index 94d0f07a2e..539ee23895 100644
--- a/app/tests/test_audiobuf.c
+++ b/app/tests/test_audiobuf.c
@@ -113,6 +113,14 @@ static void test_audiobuf_partial_read_write(void) {
uint32_t expected2[] = {4, 5, 6, 1, 2, 3, 4, 1, 2, 3};
assert(!memcmp... | true |
Genymobile/scrcpy | 6,172 | issue_to_patch | Improve/fix mouse scrolling support | Scrolling values reported by SDL can produce fractional values (like 0.05, when precise scrolling is enabled), and also values greater than 1 or less than -1.
Currently, the reported value was clamped to [-1, 1]. To support larger values, extend the range to [-16, 16] for SDK mouse (the default mode).
Over HID, o... | 98d30288f78b0dd40ae1aa1b285c45f5769f49fc | b81e0f92b59fe3d3e76fcd67b39d4d484e7f13ae | diff --git a/app/src/control_msg.c b/app/src/control_msg.c
index e78f0c573e..e46c61656d 100644
--- a/app/src/control_msg.c
+++ b/app/src/control_msg.c
@@ -127,10 +127,14 @@ sc_control_msg_serialize(const struct sc_control_msg *msg, uint8_t *buf) {
return 32;
case SC_CONTROL_MSG_TYPE_INJECT_SCROLL_... | [
"app/src/control_msg.c",
"app/src/hid/hid_mouse.c",
"app/src/hid/hid_mouse.h",
"app/src/input_events.h",
"app/src/input_manager.c",
"app/src/uhid/mouse_uhid.c",
"app/src/usb/mouse_aoa.c",
"app/src/usb/screen_otg.c",
"server/src/main/java/com/genymobile/scrcpy/control/ControlMessageReader.java"
] | [] | true | ||
Genymobile/scrcpy | 5,154 | issue_to_patch | Enable workarounds by default | Workarounds were disabled by default, and enabled only on some device or in specific conditions.
But it seems they are needed for more and more devices, so enable them by default. They could be disabled for specific devices if necessary in the future.
In the past, these workarounds caused a (harmless) exception t... | f691ebb1b4fde44789292d1e8ed41adaee8e6854 | 2b6089cbfc29c41643e0c0e8049bda3ede777b61 | diff --git a/server/src/main/java/com/genymobile/scrcpy/Server.java b/server/src/main/java/com/genymobile/scrcpy/Server.java
index 11429e6ce8..7817fdf5b9 100644
--- a/server/src/main/java/com/genymobile/scrcpy/Server.java
+++ b/server/src/main/java/com/genymobile/scrcpy/Server.java
@@ -144,7 +144,7 @@ private static vo... | [
"server/src/main/java/com/genymobile/scrcpy/Server.java",
"server/src/main/java/com/genymobile/scrcpy/Workarounds.java"
] | [] | true | ||
Genymobile/scrcpy | 5,102 | issue_to_patch | Add option to keep audio playing on device while mirroring | Add a new method to capture audio on the device, provided by @yume-chan in #4380. It is exposed as a separate audio source (in addition to `output` and `mic`):
```
scrcpy --audio-source=playback
```
There are pros and cons, as noted by @yume-chan:
> Pros:
>
> - Can choose to continue playing audio on devi... | 9d1d79b004ed7171f481225993d54c3b100411a7 | ed4066902d08e4abb91b4b6c7d828f190ab65bfb | diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy
index b35ea5e488..e0928cbd72 100644
--- a/app/data/bash-completion/scrcpy
+++ b/app/data/bash-completion/scrcpy
@@ -6,6 +6,7 @@ _scrcpy() {
--audio-buffer=
--audio-codec=
--audio-codec-options=
+ --audio-dup... | [
"app/data/bash-completion/scrcpy",
"app/data/zsh-completion/_scrcpy",
"app/scrcpy.1",
"app/src/cli.c",
"app/src/options.c",
"app/src/options.h",
"app/src/scrcpy.c",
"app/src/server.c",
"app/src/server.h",
"doc/audio.md",
"server/src/main/java/com/genymobile/scrcpy/Options.java",
"server/src/ma... | [] | true | ||
Genymobile/scrcpy | 5,076 | issue_to_patch | Feature Request: Keyboard Shortcut for Forwarding Clicks
A feature request posted on [reddit](https://www.reddit.com/r/scrcpy/comments/1dtwr1l/feature_request_keyboard_shortcut_for_forwarding/):
> So with the recent Scrcpy release, the forwarding clicks behavior changed. So I added this:
>
> --mouse-bind=bhsn... | Improve mouse events and add secondary bindings | On Android, a `MotionEvent` may use either a `MOUSE` or `FINGER` as source. Since scrcpy 1.0, it used a `FINGER`. But when `--forward-all-clicks` (now deprecated in favor of `--mouse-bind=++++`) was added, this caused a problem: it was not possible to press secondary clicks with a `FINGER`, so if this flag was set, it ... | b50f9eb41d1bd7b75a77e2c388b0144365e3cd5f | 9989668226f100534452e0af812807562ff5212f | diff --git a/app/scrcpy.1 b/app/scrcpy.1
index cf8dfa7fe4..1c0c0f7aff 100644
--- a/app/scrcpy.1
+++ b/app/scrcpy.1
@@ -258,10 +258,14 @@ LAlt, LSuper or RSuper toggle the capture mode, to give control of the mouse bac
Also see \fB\-\-keyboard\fR.
.TP
-.BI "\-\-mouse\-bind " xxxx
+.BI "\-\-mouse\-bind " xxxx[:xxxx]
... | [
"app/scrcpy.1",
"app/src/cli.c",
"app/src/control_msg.c",
"app/src/control_msg.h",
"app/src/input_events.h",
"app/src/input_manager.c",
"app/src/input_manager.h",
"app/src/options.c",
"app/src/options.h",
"app/src/usb/screen_otg.c",
"doc/mouse.md",
"server/src/main/java/com/genymobile/scrcpy/C... | [] | true | |
Genymobile/scrcpy | 5,044 | issue_to_patch | Do not report controller error on device disconnected | A device disconnection (when the adb connection is closed) makes the `read()` on the "receiver" socket fail.
Since commit 063a8339ed27b94a8fe1e53a284507eb2d044e15, this is reported as an error. As a consequence, scrcpy fails with:
ERROR: Controller error
instead of:
WARN: Device disconnected... | a4f8c025027964a9978925396459d36b8337623d | b419eef55e19a4700af3ea0a170d8d0a9ce6bd16 | diff --git a/app/src/controller.c b/app/src/controller.c
index edd767eb1b..d50e1921cb 100644
--- a/app/src/controller.c
+++ b/app/src/controller.c
@@ -7,12 +7,13 @@
#define SC_CONTROL_MSG_QUEUE_MAX 64
static void
-sc_controller_receiver_on_error(struct sc_receiver *receiver, void *userdata) {
+sc_controller_receive... | [
"app/src/controller.c",
"app/src/controller.h",
"app/src/receiver.c",
"app/src/receiver.h",
"app/src/scrcpy.c"
] | [] | true | ||
Genymobile/scrcpy | 5,039 | issue_to_patch | Forward mouse hover events | Also add an option `--no-mouse-hover` to get the old behavior.
Fixes #2743
Fixes #3070 | f5e6b8092afd82bab402e7c2c3d00b1719f9bb57 | 76332282783f72bc611dcb1b871f4baacd59de1d | diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy
index f00fadaeba..b35ea5e488 100644
--- a/app/data/bash-completion/scrcpy
+++ b/app/data/bash-completion/scrcpy
@@ -50,6 +50,7 @@ _scrcpy() {
--no-downsize-on-error
--no-key-repeat
--no-mipmaps
+ --no-mouse-... | [
"app/data/bash-completion/scrcpy",
"app/data/zsh-completion/_scrcpy",
"app/scrcpy.1",
"app/src/cli.c",
"app/src/mouse_sdk.c",
"app/src/mouse_sdk.h",
"app/src/options.c",
"app/src/options.h",
"app/src/scrcpy.c",
"doc/mouse.md"
] | [] | true | ||
Genymobile/scrcpy | 5,022 | issue_to_patch | Add option to configure mouse bindings | The argument must be exactly 4 characters, one for each secondary click:
--mouse-bind=xxxx
^^^^
||||
||| `- 5th click
|| `-- 4th click
| `--- middle click
`---- right click
Each character must be one ... | 40493dff608cda7f0f37c166a2d8fef92581acf0 | f5e6b8092afd82bab402e7c2c3d00b1719f9bb57 | diff --git a/app/data/bash-completion/scrcpy b/app/data/bash-completion/scrcpy
index e6b2c91a96..f00fadaeba 100644
--- a/app/data/bash-completion/scrcpy
+++ b/app/data/bash-completion/scrcpy
@@ -25,7 +25,6 @@ _scrcpy() {
-e --select-tcpip
-f --fullscreen
--force-adb-forward
- --forward... | [
"app/data/bash-completion/scrcpy",
"app/data/zsh-completion/_scrcpy",
"app/scrcpy.1",
"app/src/cli.c",
"app/src/input_events.h",
"app/src/input_manager.c",
"app/src/input_manager.h",
"app/src/options.c",
"app/src/options.h",
"app/src/scrcpy.c",
"app/src/screen.c",
"app/src/screen.h",
"app/sr... | [] | true | ||
Genymobile/scrcpy | 4,868 | issue_to_patch | Add scrcpy window without video playback | Add the possibility to solely control the device without screen mirroring:
scrcpy --no-video --no-audio
This is different from OTG mode, which does not require USB debugging at all. Here, it is just the standard mode but with the possibility to disable video playback.
By default, always open a wind... | 22d78e8a82bc3d6d1c18a1cc419be536201a003c | 063a8339ed27b94a8fe1e53a284507eb2d044e15 | diff --git a/app/scrcpy.1 b/app/scrcpy.1
index eb09f53081..f9ef3498af 100644
--- a/app/scrcpy.1
+++ b/app/scrcpy.1
@@ -316,6 +316,10 @@ Disable video forwarding.
.B \-\-no\-video\-playback
Disable video playback on the computer.
+.TP
+.B \-\-no\-window
+Disable scrcpy window. Implies --no-video-playback and --no-co... | [
"app/scrcpy.1",
"app/src/cli.c",
"app/src/controller.c",
"app/src/controller.h",
"app/src/display.c",
"app/src/display.h",
"app/src/events.h",
"app/src/input_manager.c",
"app/src/options.c",
"app/src/options.h",
"app/src/receiver.c",
"app/src/receiver.h",
"app/src/scrcpy.c",
"app/src/scree... | [] | true | ||
Genymobile/scrcpy | 4,748 | issue_to_patch | Pause and resume screen mirroring using a shortcut
- [X] I have checked that a similar [feature request](https://github.com/Genymobile/scrcpy/issues?q=is%3Aopen+is%3Aissue+label%3A%22feature+request%22) does not already exist.
**Is your feature request related to a problem? Please describe.**
Oftentimes, I find m... | Add a shortcut to pause/unpause display | Pause on <kbd>MOD</kbd>+<kbd>z</kbd>, unpause on <kbd>MOD</kbd>+<kbd>Shift</kbd>+<kbd>z</kbd>.
It only impacts rendering, the device is still captured, the video stream transmitted to the device, and recorded if recording is enabled.
Fixes #1632 | be3d357a6dcdf0f3fccabd795b869a30e1e5bee1 | 1c3801a0b1624258e5004e651c9dbcff7eafe324 | diff --git a/app/scrcpy.1 b/app/scrcpy.1
index 1e3c91b1ce..eb09f53081 100644
--- a/app/scrcpy.1
+++ b/app/scrcpy.1
@@ -577,6 +577,14 @@ Flip display horizontally
.B MOD+Shift+Up, MOD+Shift+Down
Flip display vertically
+.TP
+.B MOD+z
+Pause or re-pause display
+
+.TP
+.B MOD+Shift+z
+Unpause display
+
.TP
.B MOD+g... | [
"app/scrcpy.1",
"app/src/cli.c",
"app/src/input_manager.c",
"app/src/screen.c",
"app/src/screen.h",
"doc/shortcuts.md"
] | [] | true | |
Genymobile/scrcpy | 4,741 | issue_to_patch | Simplify/restrict shortcut mods | Restrict shortcut modifiers to be composed of only one item each.
Currently, it is possible to select a list of multiple combinations of modifier keys, like `--shortcut-mod='lctrl+lalt,rctrl+rsuper'`, meaning that shortcuts would be triggered either by <kbd>LCtrl</kbd>+<kbd>LAlt</kbd>+<kbd>key</kbd> or <kbd>RCtr... | 592ca0b59b3f57e6d721a57554e0efc5a52bb70f | 0b926922bc169eab704f9805e6d35f79f7a1aa95 | diff --git a/app/scrcpy.1 b/app/scrcpy.1
index f9ef3498af..2be9ef59d6 100644
--- a/app/scrcpy.1
+++ b/app/scrcpy.1
@@ -424,9 +424,9 @@ Turn the device screen off immediately.
.BI "\-\-shortcut\-mod " key\fR[+...]][,...]
Specify the modifiers to use for scrcpy shortcuts. Possible keys are "lctrl", "rctrl", "lalt", "ra... | [
"app/scrcpy.1",
"app/src/cli.c",
"app/src/cli.h",
"app/src/input_manager.c",
"app/src/input_manager.h",
"app/src/options.c",
"app/src/options.h",
"app/src/scrcpy.c",
"app/src/screen.h",
"app/tests/test_cli.c",
"doc/shortcuts.md"
] | [] | diff --git a/app/tests/test_cli.c b/app/tests/test_cli.c
index f2a17272bf..cef8df3e9e 100644
--- a/app/tests/test_cli.c
+++ b/app/tests/test_cli.c
@@ -124,32 +124,22 @@ static void test_options2(void) {
}
static void test_parse_shortcut_mods(void) {
- struct sc_shortcut_mods mods;
+ uint8_t mods;
bool ok... | true | |
Genymobile/scrcpy | 4,713 | issue_to_patch | Build all dependencies for Windows releases | Remove the mechanism to download (and link against) pre-built dependencies, and add a new mechanism to download the dependencies sources and build them.
Executing `./release.sh` builds everything.
Here are 32-bit and 64-bit Windows binaries for the current `dev` branch:
- [`scrcpy-win32-builtdeps.zip`](https://t... | 36189b90ea815d8fced961c36c80f146d5952324 | 8d87b91f692914ada1c146bd911ab4623552174b | diff --git a/app/deps/.gitignore b/app/deps/.gitignore
new file mode 100644
index 0000000000..ccf6a49e2d
--- /dev/null
+++ b/app/deps/.gitignore
@@ -0,0 +1,1 @@
+/work
diff --git a/app/deps/README b/app/deps/README
new file mode 100644
index 0000000000..9cfb5c06a1
--- /dev/null
+++ b/app/deps/README
@@ -0,0 +1,27 @@
+T... | [
"app/deps/.gitignore",
"app/deps/README",
"app/deps/adb.sh",
"app/deps/common",
"app/deps/ffmpeg.sh",
"app/deps/libusb.sh",
"app/deps/patches/ffmpeg-6.1-fix-build.patch",
"app/deps/sdl.sh",
"app/prebuilt-deps/.gitignore",
"app/prebuilt-deps/common",
"app/prebuilt-deps/prepare-adb.sh",
"app/pre... | [
{
"comment": "The source release is the .bz2 file, also available on SourceForge https://sourceforge.net/projects/libusb/files/libusb-1.0/",
"path": "app/deps/libusb.sh",
"hunk": "@@ -0,0 +1,45 @@\n+#!/usr/bin/env bash\n+set -ex\n+DEPS_DIR=$(dirname ${BASH_SOURCE[0]})\n+cd \"$DEPS_DIR\"\n+. common\n+\n+... | true | ||
Genymobile/scrcpy | 4,713 | comment_to_fix | Build all dependencies for Windows releases | The source release is the .bz2 file, also available on SourceForge https://sourceforge.net/projects/libusb/files/libusb-1.0/ | 36189b90ea815d8fced961c36c80f146d5952324 | 8d87b91f692914ada1c146bd911ab4623552174b | diff --git a/app/deps/libusb.sh b/app/deps/libusb.sh
new file mode 100755
index 0000000000..97fc3c72fb
--- /dev/null
+++ b/app/deps/libusb.sh
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
+set -ex
+DEPS_DIR=$(dirname ${BASH_SOURCE[0]})
+cd "$DEPS_DIR"
+. common
+
+VERSION=1.0.27
+FILENAME=libusb-$VERSION.tar.bz2
+PROJECT_DIR=l... | [
"app/deps/libusb.sh"
] | [
{
"comment": "The source release is the .bz2 file, also available on SourceForge https://sourceforge.net/projects/libusb/files/libusb-1.0/",
"path": "app/deps/libusb.sh",
"hunk": "@@ -0,0 +1,45 @@\n+#!/usr/bin/env bash\n+set -ex\n+DEPS_DIR=$(dirname ${BASH_SOURCE[0]})\n+cd \"$DEPS_DIR\"\n+. common\n+\n+... | true | ||
Genymobile/scrcpy | 4,713 | comment_to_fix | Build all dependencies for Windows releases | If using the source release tarball, the "bootstrap" is not neeed. | 36189b90ea815d8fced961c36c80f146d5952324 | 8d87b91f692914ada1c146bd911ab4623552174b | diff --git a/app/deps/libusb.sh b/app/deps/libusb.sh
new file mode 100755
index 0000000000..97fc3c72fb
--- /dev/null
+++ b/app/deps/libusb.sh
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
+set -ex
+DEPS_DIR=$(dirname ${BASH_SOURCE[0]})
+cd "$DEPS_DIR"
+. common
+
+VERSION=1.0.27
+FILENAME=libusb-$VERSION.tar.bz2
+PROJECT_DIR=l... | [
"app/deps/libusb.sh"
] | [
{
"comment": "If using the source release tarball, the \"bootstrap\" is not neeed.",
"path": "app/deps/libusb.sh",
"hunk": "@@ -0,0 +1,45 @@\n+#!/usr/bin/env bash\n+set -ex\n+DEPS_DIR=$(dirname ${BASH_SOURCE[0]})\n+cd \"$DEPS_DIR\"\n+. common\n+\n+VERSION=1.0.27\n+FILENAME=libusb-$VERSION.tar.gz\n+PROJE... | true | ||
Genymobile/scrcpy | 4,649 | issue_to_patch | Configure clean up actions dynamically | Some actions may be performed when scrcpy exits, currently:
- disable "show touches"
- restore "stay on while plugged in"
- power off screen
- restore "power mode" (to disable "turn screen off")
They are performed from a separate process so that they can be executed even when scrcpy-server is killed (e.g. if... | be3f949aa5c4dcad276ac0f2b36671a3309ce12f | 9efa162949c2a3e3e42564862ff390700270394d | diff --git a/server/src/main/java/com/genymobile/scrcpy/CleanUp.java b/server/src/main/java/com/genymobile/scrcpy/CleanUp.java
index c84e25bb89..f9b1efd6e1 100644
--- a/server/src/main/java/com/genymobile/scrcpy/CleanUp.java
+++ b/server/src/main/java/com/genymobile/scrcpy/CleanUp.java
@@ -1,11 +1,8 @@
package com.gen... | [
"server/src/main/java/com/genymobile/scrcpy/CleanUp.java",
"server/src/main/java/com/genymobile/scrcpy/Controller.java",
"server/src/main/java/com/genymobile/scrcpy/Server.java"
] | [] | true | ||
GoogleChrome/lighthouse | 17,073 | issue_to_patch | v13.4.0 | c0ac986843022ab015a0d6e7dbe8a69166ca7358 | 0dbad9a903b601d072e35651e8937bb96b4de738 | diff --git a/changelog.md b/changelog.md
index 60d8af64f401..810031092e08 100644
--- a/changelog.md
+++ b/changelog.md
@@ -1,3 +1,75 @@
+<a name="13.4.0"></a>
+# 13.4.0 (2026-06-09)
+[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v13.3.0...v13.4.0)
+
+We expect this release to ship in the DevTools ... | [
"changelog.md",
"core/test/fixtures/user-flows/reports/sample-flow-result.json",
"core/test/results/sample_v2.json",
"docs/plugins.md",
"docs/recipes/lighthouse-plugin-example/package.json",
"package.json",
"third-party/devtools-tests/e2e/lighthouse/navigation.test.ts"
] | [] | diff --git a/core/test/fixtures/user-flows/reports/sample-flow-result.json b/core/test/fixtures/user-flows/reports/sample-flow-result.json
index 3bccb00bd400..5031c4c0b7f2 100644
--- a/core/test/fixtures/user-flows/reports/sample-flow-result.json
+++ b/core/test/fixtures/user-flows/reports/sample-flow-result.json
@@ -2... | true | ||
GoogleChrome/lighthouse | 17,071 | issue_to_patch | i18n: import | 6894326a9ae5764e92d074a1748603b56f9668fd | be5d571677f2bdc2dea495eeb3b0d6ed95289e32 | diff --git a/shared/localization/locales/ar-XB.json b/shared/localization/locales/ar-XB.json
index 2c4650c2b472..e5a257558648 100644
--- a/shared/localization/locales/ar-XB.json
+++ b/shared/localization/locales/ar-XB.json
@@ -206,6 +206,15 @@
"core/audits/accessibility/aria-valid-attr.js | title": {
"message":... | [
"shared/localization/locales/ar-XB.json",
"shared/localization/locales/ar.json",
"shared/localization/locales/bg.json",
"shared/localization/locales/ca.json",
"shared/localization/locales/cs.json",
"shared/localization/locales/da.json",
"shared/localization/locales/de.json",
"shared/localization/local... | [] | true | |||
GoogleChrome/lighthouse | 17,072 | issue_to_patch | tests: exclude origin-isolation-coop-present smoke test | site is down https://csp.withgoogle.com/docs/index.html | 6c9c6ae9a3525be2f86932ea8e764a6affe5fba1 | 6dc1472fe94a332fff46078de7416ddfd045b213 | [
"cli/test/smokehouse/config/exclusions.js"
] | [] | diff --git a/cli/test/smokehouse/config/exclusions.js b/cli/test/smokehouse/config/exclusions.js
index 8da77d4ecf01..cc2a3bcd568a 100644
--- a/cli/test/smokehouse/config/exclusions.js
+++ b/cli/test/smokehouse/config/exclusions.js
@@ -84,6 +84,8 @@ for (const array of Object.values(exclusions)) {
array.push('issues-... | true | ||
GoogleChrome/lighthouse | 17,070 | issue_to_patch | deps: upgrade deps | ```diff
- "axe-core": "^4.11.4",
- "chrome-devtools-frontend": "1.0.1625854",
- "csp_evaluator": "1.1.5",
- "third-party-web": "^0.29.0",
- "tldts-icann": "^7.0.30",
- "web-features": "^3.26.0",
+ "axe-core": "^4.12.0",
+ "chrome-devtools-frontend": "1.0.1642845",
+ "csp_evaluator"... | 2a5241417d3e35ecb323a2388637b06ba27dc619 | 7c17d3ec825b220d4a3a922df44fba42bb4f2452 | diff --git a/core/audits/accessibility/accesskeys.js b/core/audits/accessibility/accesskeys.js
index 56f44fd25d54..8238d16909dd 100644
--- a/core/audits/accessibility/accesskeys.js
+++ b/core/audits/accessibility/accesskeys.js
@@ -20,7 +20,7 @@ const UIStrings = {
/** Description of a Lighthouse audit that tells the... | [
"core/audits/accessibility/accesskeys.js",
"core/audits/accessibility/aria-allowed-attr.js",
"core/audits/accessibility/aria-allowed-role.js",
"core/audits/accessibility/aria-command-name.js",
"core/audits/accessibility/aria-conditional-attr.js",
"core/audits/accessibility/aria-deprecated-role.js",
"cor... | [] | diff --git a/core/test/fixtures/user-flows/reports/sample-flow-result.json b/core/test/fixtures/user-flows/reports/sample-flow-result.json
index 01d632d84f7e..3bccb00bd400 100644
--- a/core/test/fixtures/user-flows/reports/sample-flow-result.json
+++ b/core/test/fixtures/user-flows/reports/sample-flow-result.json
@@ -1... | true | |
GoogleChrome/lighthouse | 17,069 | issue_to_patch | viewer flashes notification on load
https://googlechrome.github.io/lighthouse/viewer/
just for a couple 100ms | clients(viewer): prevent toast showing on load | fixes #14379 | 3a52f712b8b43ad40a4f7ded5c538ae7e112eb20 | 97e0761cd8d09bd9456ec1f8158cd31c1713b4df | diff --git a/report/renderer/logger.js b/report/renderer/logger.js
index 724fb82ac8f3..34b4627f6e8c 100644
--- a/report/renderer/logger.js
+++ b/report/renderer/logger.js
@@ -13,8 +13,18 @@ export class Logger {
*/
constructor(element) {
this.el = element;
+
const styleEl = document.createElement('styl... | [
"report/renderer/logger.js"
] | [] | true | |
GoogleChrome/lighthouse | 16,774 | issue_to_patch | core: match scripts to network requests using frameId | Fixes a reporting issue in byte-efficiency audits (such as "Remove unused JavaScript") where cached duplicate script requests were reported with full network transfer sizes.
### Impact
When a script is loaded in the main frame (network transfer) and subsequently in an iframe (cache hit), Lighthouse reported both in... | 85c711da09022748ec991ccfb6e019a0f50d7d7f | 93ea5c537e90df537fce3cacfdd41a4dda374c33 | diff --git a/core/audits/network-requests.js b/core/audits/network-requests.js
index c0296589d7c6..149dba518bea 100644
--- a/core/audits/network-requests.js
+++ b/core/audits/network-requests.js
@@ -70,6 +70,8 @@ class NetworkRequests extends Audit {
url: UrlUtils.elideDataURI(record.url),
sessionTarg... | [
"core/audits/network-requests.js",
"core/lib/script-helpers.js",
"core/test/fixtures/user-flows/reports/sample-flow-result.json",
"core/test/lib/script-helpers-test.js",
"core/test/results/sample_v2.json"
] | [] | diff --git a/core/test/fixtures/user-flows/reports/sample-flow-result.json b/core/test/fixtures/user-flows/reports/sample-flow-result.json
index 3a79507e2c88..01d632d84f7e 100644
--- a/core/test/fixtures/user-flows/reports/sample-flow-result.json
+++ b/core/test/fixtures/user-flows/reports/sample-flow-result.json
@@ -5... | true | |
GoogleChrome/lighthouse | 16,835 | issue_to_patch | core(geolocation-on-start): mention `geolocation` element | Added a suggestion to use the <geolocation> element for better user experience.
<!--
Thank you for submitting a pull request!
See CONTRIBUTING.MD for help in getting a change landed.
https://github.com/GoogleChrome/lighthouse/blob/main/CONTRIBUTING.md
-->
**Summary**
<!-- What kind of change does this PR i... | eb3d98ad56d93f271d3a674d20433d83b429c448 | 23118d5b950513b73733a14dd554089fd7d06461 | diff --git a/core/audits/dobetterweb/geolocation-on-start.js b/core/audits/dobetterweb/geolocation-on-start.js
index 7e6ce55b4832..aea3c98b51b4 100644
--- a/core/audits/dobetterweb/geolocation-on-start.js
+++ b/core/audits/dobetterweb/geolocation-on-start.js
@@ -21,7 +21,8 @@ const UIStrings = {
/** Description of a... | [
"core/audits/dobetterweb/geolocation-on-start.js",
"core/test/fixtures/user-flows/reports/sample-flow-result.json",
"core/test/results/sample_v2.json",
"shared/localization/locales/en-US.json",
"shared/localization/locales/en-XL.json"
] | [] | diff --git a/core/test/fixtures/user-flows/reports/sample-flow-result.json b/core/test/fixtures/user-flows/reports/sample-flow-result.json
index 0786921e3bd3..3a79507e2c88 100644
--- a/core/test/fixtures/user-flows/reports/sample-flow-result.json
+++ b/core/test/fixtures/user-flows/reports/sample-flow-result.json
@@ -2... | true | |
GoogleChrome/lighthouse | 17,057 | issue_to_patch | New llms.txt check fails for YOAST due to BOM
### FAQ
- [x] Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/main/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/main/docs/throttling.md).
- [x] Yes, my issue is not about a specific accessibi... | core(llms-txt): allow leading whitespace for header check | fixes #17051 | eb3d98ad56d93f271d3a674d20433d83b429c448 | 8c2f942d22e7aab8b135e2678cc19f24aaa1b50b | diff --git a/core/audits/agentic/llms-txt.js b/core/audits/agentic/llms-txt.js
index e19f031ede69..538481518650 100644
--- a/core/audits/agentic/llms-txt.js
+++ b/core/audits/agentic/llms-txt.js
@@ -84,7 +84,7 @@ class LlmsTxt extends Audit {
throw new Error(`Status ${status} was valid, but content was null`);
... | [
"core/audits/agentic/llms-txt.js",
"core/test/audits/agentic/llms-txt-test.js"
] | [] | diff --git a/core/test/audits/agentic/llms-txt-test.js b/core/test/audits/agentic/llms-txt-test.js
index 93aac158f6b3..6a6367ac16df 100644
--- a/core/test/audits/agentic/llms-txt-test.js
+++ b/core/test/audits/agentic/llms-txt-test.js
@@ -167,6 +167,13 @@ describe('Agentic: llms.txt audit', () => {
content: `
... | true |
GoogleChrome/lighthouse | 17,064 | issue_to_patch | Fail to load Github Gist URL in LH Viewer with 401 error.
### FAQ
- [X] Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/master/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/master/docs/throttling.md).
- [X] Yes, my issue is not about a... | clients(viewer): clear github auth token on 401 error | fixes #13698 | a218df7cf8d2c423cb252b99c29ddcffeac4410b | 298636d9e341ef20e2416825c6fb246894368eb2 | diff --git a/viewer/app/src/firebase-auth.js b/viewer/app/src/firebase-auth.js
index be9031dbbf48..9a5982c1fa20 100644
--- a/viewer/app/src/firebase-auth.js
+++ b/viewer/app/src/firebase-auth.js
@@ -5,7 +5,7 @@
*/
import {initializeApp} from 'firebase/app';
-import {getAuth, signInWithPopup, GithubAuthProvider} fr... | [
"viewer/app/src/firebase-auth.js",
"viewer/app/src/github-api.js"
] | [] | true | |
GoogleChrome/lighthouse | 17,063 | issue_to_patch | Dark mode preference reset when changing language
b/40818303 | report(viewer): persist dark mode when when changing langauge | fixes #16151 | a218df7cf8d2c423cb252b99c29ddcffeac4410b | 793c2d89e9a7ae79378af5bb62ea67eb00a740da | diff --git a/viewer/app/src/lighthouse-report-viewer.js b/viewer/app/src/lighthouse-report-viewer.js
index 56cf2a708db8..a0953d6124f3 100644
--- a/viewer/app/src/lighthouse-report-viewer.js
+++ b/viewer/app/src/lighthouse-report-viewer.js
@@ -261,6 +261,10 @@ export class LighthouseReportViewer {
_replaceReportHtml(... | [
"viewer/app/src/lighthouse-report-viewer.js"
] | [] | true | |
GoogleChrome/lighthouse | 17,062 | issue_to_patch | misc(ci): add Node 26 to unit matrix | 47c5bd649830ad4af3279238a19b42aad5cac23a | 61a1528cad9d84284978aab6a6845a7825fe0575 | diff --git a/.github/workflows/unit.yml b/.github/workflows/unit.yml
index 2c1199c83339..559868f6b0bb 100644
--- a/.github/workflows/unit.yml
+++ b/.github/workflows/unit.yml
@@ -13,13 +13,12 @@ jobs:
unit:
strategy:
matrix:
- node: ['22.19', '24']
+ node: ['22.19', '24', '26']
fail-... | [
".github/workflows/unit.yml"
] | [] | true | |||
GoogleChrome/lighthouse | 17,061 | issue_to_patch | misc: migrate typescript moduleResolution to bundler | To address the deprecation of `moduleResolution=node10` in TypeScript 6+, this
commit modernizes our configuration by moving to `"bundler"` resolution. This
strategy correctly enforces package `exports` maps.
Specific changes to support this strict resolution:
* Updated `firebase` to v12 and `@types/pg` to l... | 0bf723095aeb031f3a8a0dc63b1479f736686481 | cc6ab3fa27af4f5869b6074161387f4c5bfdfc38 | diff --git a/package.json b/package.json
index f47a8949bf4a..69a79a134d8f 100644
--- a/package.json
+++ b/package.json
@@ -124,6 +124,7 @@
"@types/mocha": "^9.0.0",
"@types/node": "*",
"@types/pako": "^1.0.1",
+ "@types/pg": "^8.20.0",
"@types/resize-observer-browser": "^0.1.1",
"@types/reso... | [
"package.json",
"tsconfig-base.json",
"types/internal/rxjs.d.ts",
"yarn.lock"
] | [] | true | ||
GoogleChrome/lighthouse | 17,060 | issue_to_patch | deps: upgrade typescript to 6.0.3 | https://www.typescriptlang.org/docs/handbook/release-notes/typescript-6-0.html
- Added "ignoreDeprecations": "6.0" to tsconfig-base.json to silence the moduleResolution=node10 deprecation warning.
- Updated deprecated global module declarations to use the namespace keyword across type definition files (e.g. module ... | 71f281b40f364a328cb6a17c2d3efa668c7791b7 | 252e89e8bae0d16bab2987b6a8c47a40c9886dad | diff --git a/clients/extension/scripts/popup.js b/clients/extension/scripts/popup.js
index 2cd5be865bd7..43a3b7608066 100644
--- a/clients/extension/scripts/popup.js
+++ b/clients/extension/scripts/popup.js
@@ -4,6 +4,9 @@
* SPDX-License-Identifier: Apache-2.0
*/
+// eslint-disable-next-line spaced-comment
+/// <... | [
"clients/extension/scripts/popup.js",
"clients/extension/scripts/settings-controller.js",
"core/scripts/roll-to-devtools.sh",
"flow-report/types/flow-report.d.ts",
"package.json",
"report/renderer/text-encoding.js",
"report/types/html-renderer.d.ts",
"shared/types/shared.d.ts",
"treemap/types/treema... | [] | true | ||
GoogleChrome/lighthouse | 17,059 | issue_to_patch | deps: upgrade terser to 5.48.0 | https://github.com/terser/terser/blob/master/CHANGELOG.md | 0337a1a6abc5ac3c75d249d7ec57e03214420dd8 | a6a9876e8d9dabfc9c66fd2301ae13c74e9a4635 | diff --git a/package.json b/package.json
index f3d3fecf5ddf..68da20645368 100644
--- a/package.json
+++ b/package.json
@@ -170,7 +170,7 @@
"resolve": "^1.22.10",
"rollup-plugin-polyfill-node": "^0.12.0",
"source-map-support": "^0.5.21",
- "terser": "^5.18.2",
+ "terser": "^5.48.0",
"testdouble... | [
"package.json",
"yarn.lock"
] | [] | true | ||
GoogleChrome/lighthouse | 17,058 | issue_to_patch | deps: upgrade esbuild to 0.28.0 | https://github.com/evanw/esbuild/blob/main/CHANGELOG.md | 7174701873b4168ff9cb0108f257564bd7f54a9c | 415327f9a8580943001b00e0a218c6e61aefcf9d | diff --git a/package.json b/package.json
index 2151d5c19c72..f3d3fecf5ddf 100644
--- a/package.json
+++ b/package.json
@@ -144,7 +144,7 @@
"core-js-compat": "^3.44.0",
"cpy": "^8.1.2",
"csv-validator": "^0.0.3",
- "esbuild": "0.25.9",
+ "esbuild": "0.28.0",
"eslint": "^9.28.0",
"eslint-co... | [
"package.json",
"yarn.lock"
] | [] | true | ||
GoogleChrome/lighthouse | 17,050 | issue_to_patch | core(driver): add ExecutionContext.evaluateOnObject | This adds `ExecutionContext.evaluateOnObject` to wrap the CDP `Runtime.callFunctionOn` command, providing the same ergonomics, dependency serialization, and robust error handling as `.evaluate()`.
Key benefits over raw `session.sendCommand` calls:
- Protects native objects from page polyfills via `_cachedNativesP... | b5efe05b452780e5aed0f34fe45f58a4bb9ac6f2 | 5563257cb11947773623bc2a8e73e97bfa5867ef | diff --git a/core/gather/driver/execution-context.js b/core/gather/driver/execution-context.js
index 225dc4b9160c..9f76227d85dc 100644
--- a/core/gather/driver/execution-context.js
+++ b/core/gather/driver/execution-context.js
@@ -223,6 +223,7 @@ class ExecutionContext {
const expression = `(() => {
${Exe... | [
"build/test/page-functions-test-case-computeBenchmarkIndex.js",
"build/test/page-functions-test-case-getElementsInDocument.js",
"build/test/page-functions-test-case-getNodeDetails.js",
"core/gather/driver/execution-context.js",
"core/gather/gatherers/trace-elements.js",
"core/gather/gatherers/webmcp-schem... | [
{
"comment": "This was only here because direct callers of `Runtime.callFunctionOn` needed it to prevent minification errors from bundling / name mangling - but better to inject in `_callFunctionOn`. It also was already being done for `_evaluateInContext` (so it was sent twice for `evaluate`; now it's sent just... | diff --git a/build/test/page-functions-test-case-computeBenchmarkIndex.js b/build/test/page-functions-test-case-computeBenchmarkIndex.js
index b102e40d954d..324109ca42ef 100644
--- a/build/test/page-functions-test-case-computeBenchmarkIndex.js
+++ b/build/test/page-functions-test-case-computeBenchmarkIndex.js
@@ -18,6 ... | true | |
GoogleChrome/lighthouse | 17,049 | issue_to_patch | Refactor _renderLink
@brendankenny https://github.com/GoogleChrome/lighthouse/pull/9354/files/d2c6b60d45bd5a2bbbcd4ea1361018fd3c9cb263#r319731512
> this is getting a little convoluted and makes any changes needed in _renderLink harder to reason about because it now controls renderTextURL and renderSourceLocation. We ... | report: decouple link creation from link details rendering | fixes #9631
this is a simple PR to address an old PR comment from Brendan. It's a trivial change, but just future-proofs the code in case we want to change how the link detail type is rendered without accidentally changing the other use cases of this function. | 187723425a648c16ddd13caf6db6ceb5632b74f8 | b9ebeac992e106eba0b1538565d2168f7ef36c8e | diff --git a/report/renderer/details-renderer.js b/report/renderer/details-renderer.js
index 074a2d8ef110..825596b61a51 100644
--- a/report/renderer/details-renderer.js
+++ b/report/renderer/details-renderer.js
@@ -115,7 +115,7 @@ export class DetailsRenderer {
}
const element = this._dom.createElement('div... | [
"report/renderer/details-renderer.js"
] | [] | true | |
GoogleChrome/lighthouse | 17,048 | issue_to_patch | lr-mobile-config.d.ts breaks TS builds: Cannot find namespace 'LH'
### FAQ
- [x] Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/main/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/main/docs/throttling.md).
- [x] Yes, my issue is not about... | core(config): import LH types | fixes #16503 | aef5a935f9ba467965e0c35f0f19c663b478e5b4 | 47d7149040cc0d8bbdeaddaf977d8845494f1b7d | diff --git a/core/config/agentic-browsing-config.js b/core/config/agentic-browsing-config.js
index fc26c9a75d8b..04772f842e1e 100644
--- a/core/config/agentic-browsing-config.js
+++ b/core/config/agentic-browsing-config.js
@@ -4,6 +4,7 @@
* SPDX-License-Identifier: Apache-2.0
*/
+import * as LH from '../../types/... | [
"core/config/agentic-browsing-config.js",
"core/config/config-helpers.js",
"core/config/config-plugin.js",
"core/config/config.js",
"core/config/constants.js",
"core/config/experimental-config.js",
"core/config/filters.js",
"core/config/full-config.js",
"core/config/lr-desktop-config.js",
"core/co... | [] | true | |
GoogleChrome/lighthouse | 17,047 | issue_to_patch | misc(build): generate subset of web-features data | The web-features/data.json file is 5.1 MB, heavily inflating the bundle
size. This commit introduces a build script to extract only the baseline
statuses needed by the baseline audit, and groups them by tier ('high',
'low', 'limited') to further reduce their size on disk.
This shrinks the data dependency down to ... | 25c7b888dbda67b7ba394bca2bb9fc35695911dd | 39fe9e1fd00300df2e356956a2b26bbe465cadd3 | diff --git a/build/build-baseline-data.js b/build/build-baseline-data.js
new file mode 100644
index 000000000000..046d6857dd51
--- /dev/null
+++ b/build/build-baseline-data.js
@@ -0,0 +1,40 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+/**
+ * @fileoverview Reduce th... | [
"build/build-baseline-data.js",
"core/audits/baseline.js",
"core/lib/baseline/web-features-data.json",
"docs/releasing.md",
"package.json",
"tsconfig.json"
] | [] | true | ||
GoogleChrome/lighthouse | 17,046 | issue_to_patch | Time to First Byte reported as 0 ms in LCP Breakdown
### FAQ
- [x] Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/main/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/main/docs/throttling.md).
- [x] Yes, my issue is not about a specific ac... | deps: upgrade trace_engine to 0.0.65 | 0.0.64 to 0.0.65 changelog (all of devtools): https://github.com/ChromeDevTools/devtools-frontend/compare/776967b00c...845cad7f273
`git log 776967b00c...845cad7f273 -- front_end/models/trace`:
<details>
<summary>Changelog (just front_end/models/trace, mostly relevant to our usage in LH)</summary>
```
commi... | d21355db3ddca29ad4e6157d93cfd20bd63ed871 | ec7d41a350d60e1b0ba09fbcb5efa8fad84cd2ad | diff --git a/package.json b/package.json
index c709b17bd785..c44838a7ff6d 100644
--- a/package.json
+++ b/package.json
@@ -177,7 +177,7 @@
"webtreemap-cdt": "^3.2.1"
},
"dependencies": {
- "@paulirish/trace_engine": "0.0.64",
+ "@paulirish/trace_engine": "0.0.65",
"@sentry/node": "^9.28.1",
"... | [
"package.json",
"shared/localization/locales/ar-XB.json",
"shared/localization/locales/ar.json",
"shared/localization/locales/bg.json",
"shared/localization/locales/ca.json",
"shared/localization/locales/cs.json",
"shared/localization/locales/da.json",
"shared/localization/locales/de.json",
"shared/... | [] | true | |
GoogleChrome/lighthouse | 17,040 | issue_to_patch | tests(llms-txt): add coverage for network failure and heading edge cases | <!--
Thank you for submitting a pull request!
See CONTRIBUTING.MD for help in getting a change landed.
https://github.com/GoogleChrome/lighthouse/blob/main/CONTRIBUTING.md
-->
<!--
Thank you for submitting a pull request!
See CONTRIBUTING.MD for help in getting a change landed.
https://github.com/GoogleCh... | 9977be6c6801cbaae81772f356e0aab900c297ae | 796fb319d762a97d7fb3d61f4c8edb80a71ae993 | [
"core/test/audits/agentic/llms-txt-test.js"
] | [] | diff --git a/core/test/audits/agentic/llms-txt-test.js b/core/test/audits/agentic/llms-txt-test.js
index 35fce16799b7..93aac158f6b3 100644
--- a/core/test/audits/agentic/llms-txt-test.js
+++ b/core/test/audits/agentic/llms-txt-test.js
@@ -9,6 +9,22 @@ import assert from 'assert/strict';
import LlmsTxtAudit from '../..... | true | ||
GoogleChrome/lighthouse | 16,765 | issue_to_patch | Canonical URL audit mistakes invalid URLs for relative ones
<!-- Before creating an issue please make sure you are using the latest version and have checked for duplicate issues. -->
<!-- Before creating an Accessibility issue please test that it is reproducible upstream with axe (https://www.deque.com/axe/) first ... | core(canonical): improve validation for invalid URLs | Closes #12008
**Summary**
This PR fixes a bug in the canonical audit where some syntactically invalid URLs (e.g., those with a space in the host like `https:// example.com`) were incorrectly being classified as relative URLs.
The previous validation logic was insufficient because it didn't correctly handle cas... | aed7dc5b3ce5ed85ff85117d0d2616c31b99af8f | 2e91947a64f6622f1c6f2ea5f43d65bd9b90418e | diff --git a/core/audits/seo/canonical.js b/core/audits/seo/canonical.js
index 1a1868188e4b..2c615422a355 100644
--- a/core/audits/seo/canonical.js
+++ b/core/audits/seo/canonical.js
@@ -5,7 +5,6 @@
*/
import {Audit} from '../audit.js';
-import UrlUtils from '../../lib/url-utils.js';
import {MainResource} from '.... | [
"core/audits/seo/canonical.js",
"core/test/audits/seo/canonical-test.js"
] | [
{
"comment": "(not yet considering the larger context but…)\r\n\r\nlet's use `URL.parse()` here (instead of `new URL()` so we can avoid the try/catch cascade",
"path": "core/audits/seo/canonical.js",
"hunk": "@@ -92,10 +91,26 @@ class Canonical extends Audit {\n \n // Links that had an hrefRaw b... | diff --git a/core/test/audits/seo/canonical-test.js b/core/test/audits/seo/canonical-test.js
index bf335317d7dc..86b293410f5b 100644
--- a/core/test/audits/seo/canonical-test.js
+++ b/core/test/audits/seo/canonical-test.js
@@ -63,7 +63,7 @@ describe('SEO: Document has valid canonical link', () => {
});
});
- ... | true |
GoogleChrome/lighthouse | 16,765 | comment_to_fix | core(canonical): improve validation for invalid URLs | (not yet considering the larger context but…)
let's use `URL.parse()` here (instead of `new URL()` so we can avoid the try/catch cascade | aed7dc5b3ce5ed85ff85117d0d2616c31b99af8f | 2e91947a64f6622f1c6f2ea5f43d65bd9b90418e | diff --git a/core/audits/seo/canonical.js b/core/audits/seo/canonical.js
index 1a1868188e4b..2c615422a355 100644
--- a/core/audits/seo/canonical.js
+++ b/core/audits/seo/canonical.js
@@ -5,7 +5,6 @@
*/
import {Audit} from '../audit.js';
-import UrlUtils from '../../lib/url-utils.js';
import {MainResource} from '.... | [
"core/audits/seo/canonical.js"
] | [
{
"comment": "(not yet considering the larger context but…)\r\n\r\nlet's use `URL.parse()` here (instead of `new URL()` so we can avoid the try/catch cascade",
"path": "core/audits/seo/canonical.js",
"hunk": "@@ -92,10 +91,26 @@ class Canonical extends Audit {\n \n // Links that had an hrefRaw b... | true | ||
GoogleChrome/lighthouse | 17,045 | issue_to_patch | Explodey performance gauge shows unstylized score for a few seconds
We added this ~3 years ago, and haven't changed it since. I confirmed that reports generated by earlier versions of Lighthouse still present this bug. So the issue is that Chrome / the web changed something, and we must have been relying on some unspe... | report: fix performance gauge label, improve load animation | fixes #17044
Before: see referenced issue
After:
https://github.com/user-attachments/assets/720d6937-ae72-494f-8e5e-8d0f9f0e84b4
* Fixes the phantom label shown during load
* Makes the outer arc transparent while the initial load animation plays | aed7dc5b3ce5ed85ff85117d0d2616c31b99af8f | 798aa0e039eb61b0602fc7ccd34ec77e8efbf217 | diff --git a/report/assets/styles.css b/report/assets/styles.css
index 72a9e50177b7..2ea501ade9a9 100644
--- a/report/assets/styles.css
+++ b/report/assets/styles.css
@@ -2282,10 +2282,7 @@ details[open] .lh-clump-toggletext--hide { display: block;}
animation-fill-mode: forwards;
}
.lh-exp-gauge-component .state--... | [
"report/assets/styles.css",
"report/renderer/components.js",
"report/renderer/explodey-gauge.js"
] | [] | true | |
GoogleChrome/lighthouse | 16,938 | issue_to_patch | misc(ci): bump actions/upload-artifact from 4 to 7 | Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p>
<blockquote>
<h2>v7.0.0</h2>
<h2>v7 What's new</h2>
<h3>D... | 5fca441bc1d205dab081ad53b7699eef3cd90645 | 927cb7c7c8f243b8f14f15fedb0fa7c8842d4cee | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7e67ce7ece7b..f35064d2ffba 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -82,7 +82,7 @@ jobs:
BT_API_AUTH_TOKEN: ${{ secrets.BT_API_AUTH_TOKEN }}
- name: Upload dist
- uses: actions/upload-artifact@v4
+... | [
".github/workflows/ci.yml",
".github/workflows/devtools.yml",
".github/workflows/smoke.yml",
".github/workflows/unit.yml"
] | [] | true | ||
GoogleChrome/lighthouse | 17,028 | issue_to_patch | Naming collision: Lighthouse exports Audit class and Audit namespace from the root
### FAQ
- [x] Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/main/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/main/docs/throttling.md).
- [x] Yes, my is... | core: add public Lighthouse types entrypoint | ## Problem
`core/index.js` exports both the `Audit` class and the LH namespace types from `types/lh.js`. TypeScript consumers who need the `LH.Audit` namespace currently have to deep-import `lighthouse/types/lh.js`, which looks like an implementation path.
Fixes #16923.
## Root cause
The package root has a name col... | 8d19778c314eae8ba5b30057e71589a56a9faeb0 | 81a63f1ac474ca3ace3590192fdcd64ff5eff96d | diff --git a/tsconfig.json b/tsconfig.json
index 1eb0e9531691..389acc7ec981 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -16,6 +16,7 @@
"core/index.cjs",
"clients/**/*.js",
"build/**/*.js",
+ "types.js",
"./types/**/*.d.ts",
"eslint-local-rules.cjs",
"third-party/axe/valid-langs.js... | [
"core/test/index-test.js",
"tsconfig.json",
"types.js"
] | [] | diff --git a/core/test/index-test.js b/core/test/index-test.js
index 8e603a1eb831..68a3032c8577 100644
--- a/core/test/index-test.js
+++ b/core/test/index-test.js
@@ -9,6 +9,7 @@ import assert from 'assert/strict';
import lighthouse, {getAuditList, traceCategories} from '../index.js';
import {LH_ROOT} from '../../sha... | true |
GoogleChrome/lighthouse | 17,042 | issue_to_patch | tests: remove accidental .only | oops :/ | 7a9e9e9abd064e998168535aab1c461cbc6bee36 | 30175b702c3c3e4e1d2f90c57ff394b31e701579 | [
"viewer/test/viewer-test-pptr.js"
] | [] | diff --git a/viewer/test/viewer-test-pptr.js b/viewer/test/viewer-test-pptr.js
index 65f18485d54f..f44755e5d117 100644
--- a/viewer/test/viewer-test-pptr.js
+++ b/viewer/test/viewer-test-pptr.js
@@ -385,7 +385,7 @@ describe('Lighthouse Viewer', () => {
psiResponse = undefined;
});
- it.only('should cal... | true | ||
GoogleChrome/lighthouse | 17,041 | issue_to_patch | clients(viewer): disable agentic-browsing in PSI api call | this is not enabled yet in PSI, so it fails atm: https://googlechrome.github.io/lighthouse/viewer/?psiurl=https://google.com
@lusayaa FYI | 9977be6c6801cbaae81772f356e0aab900c297ae | 1ace96d2bf8f6d71a523e268047f5b8f07b43fcb | diff --git a/viewer/app/src/psi-api.js b/viewer/app/src/psi-api.js
index ca55cbad512e..07831851a1fe 100644
--- a/viewer/app/src/psi-api.js
+++ b/viewer/app/src/psi-api.js
@@ -13,7 +13,8 @@ const PSI_DEFAULT_CATEGORIES = [
'accessibility',
'seo',
'best-practices',
- 'agentic-browsing',
+ // TODO: this is not ... | [
"viewer/app/src/psi-api.js",
"viewer/test/viewer-test-pptr.js"
] | [] | diff --git a/viewer/test/viewer-test-pptr.js b/viewer/test/viewer-test-pptr.js
index c2b11fc7cdcd..65f18485d54f 100644
--- a/viewer/test/viewer-test-pptr.js
+++ b/viewer/test/viewer-test-pptr.js
@@ -385,7 +385,7 @@ describe('Lighthouse Viewer', () => {
psiResponse = undefined;
});
- it('should call out... | true | |
GoogleChrome/lighthouse | 16,845 | issue_to_patch | tests: remove unused c8 | I removed `c8` and its related coverage configurations since we're not really using it anymore. This naturally resolves the security alerts caused by the older `cross-spawn` version that `c8` was pulling in, while also cleaning up some technical debt.
I've also kept the `cross-spawn` resolution just to be safe in cas... | 8b1978324b51947be2784c94b60f0ddddeb6ee8b | a828eda693a1eec9dc1324ddc14d50c7a143f4bb | diff --git a/.github/workflows/smoke.yml b/.github/workflows/smoke.yml
index 72776a40a7c5..8ee011306a29 100644
--- a/.github/workflows/smoke.yml
+++ b/.github/workflows/smoke.yml
@@ -56,8 +56,7 @@ jobs:
- name: Run smoke tests
run: |
- yarn c8 yarn smoke --debug -j=2 --retries=2 --shard=${{ matrix.... | [
".github/workflows/smoke.yml",
".github/workflows/unit.yml",
"core/scripts/c8.sh",
"package.json",
"yarn.lock"
] | [] | true | ||
GoogleChrome/lighthouse | 17,037 | issue_to_patch | tests(viewer): update psi key | 8b1ebda64aaacecc6805929b3e8e25deab9b457f | 2d23a26267cf2d83a9ce11b3fd9173768a0b442c | [
"viewer/test/viewer-test-pptr.js"
] | [] | diff --git a/viewer/test/viewer-test-pptr.js b/viewer/test/viewer-test-pptr.js
index 213df1075680..c2b11fc7cdcd 100644
--- a/viewer/test/viewer-test-pptr.js
+++ b/viewer/test/viewer-test-pptr.js
@@ -407,7 +407,7 @@ describe('Lighthouse Viewer', () => {
utm_source: interceptedUrl.searchParams.get('utm_source'),... | true | |||
GoogleChrome/lighthouse | 17,019 | issue_to_patch | deps: upgrade puppeteer to 25.0.2 | Addressing breaking changes in v25 https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md#2500-2026-05-12 | a0361753417b435d86ccd08c2aa44d2fa7c93645 | cb243914632769e48937e06630c7864b86e9b938 | diff --git a/clients/lightrider/lightrider-entry.js b/clients/lightrider/lightrider-entry.js
index 531f53ade3d4..4f6723d01f94 100644
--- a/clients/lightrider/lightrider-entry.js
+++ b/clients/lightrider/lightrider-entry.js
@@ -7,8 +7,8 @@
import {Buffer} from 'buffer';
import log from 'lighthouse-logger';
-import {... | [
"build/test/build-bundle-mcp-test.js",
"build/test/build-bundle-test.js",
"clients/lightrider/lightrider-entry.js",
"core/test/gather/driver/target-manager-test.js",
"core/test/gather/session-test.js",
"package.json",
"yarn.lock"
] | [] | diff --git a/build/test/build-bundle-mcp-test.js b/build/test/build-bundle-mcp-test.js
index 6f9a6ead8ca1..adecb6fd92c4 100644
--- a/build/test/build-bundle-mcp-test.js
+++ b/build/test/build-bundle-mcp-test.js
@@ -89,7 +89,8 @@ describe('MCP Bundle build', () => {
executablePath: getChromePath(),
});
... | true | |
GoogleChrome/lighthouse | 17,020 | issue_to_patch | docs: add agentic web issue template | <!--
Thank you for submitting a pull request!
See CONTRIBUTING.MD for help in getting a change landed.
https://github.com/GoogleChrome/lighthouse/blob/main/CONTRIBUTING.md
-->
**Summary**
<!-- What kind of change does this PR introduce? -->
<!-- Is this a bugfix, feature, refactoring, build related change, etc? -->
... | 7d8dcf5004950cad3faa20664e4a7cf2817bd653 | e3015fd36b74d62a333197c2fe21b67175d11cbc | diff --git a/.github/ISSUE_TEMPLATE/agentic-web.md b/.github/ISSUE_TEMPLATE/agentic-web.md
new file mode 100644
index 000000000000..75a0039b740e
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE/agentic-web.md
@@ -0,0 +1,29 @@
+---
+name: Agentic Web: Proposal & Feedback
+about: Propose a new quality signal or provide feedbac... | [
".github/ISSUE_TEMPLATE/agentic-web.md"
] | [] | true | ||
GoogleChrome/lighthouse | 17,033 | issue_to_patch | `Storage.getUsageAndQuota` returns bad response
### FAQ
- [x] Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/main/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/main/docs/throttling.md).
- [x] Yes, my issue is not about a specific accessi... | core(driver): check if usage data exists before using | fixes #17011 | 7d8dcf5004950cad3faa20664e4a7cf2817bd653 | d909737b4f2036e477205aa2979257b8014c256c | diff --git a/core/gather/driver/storage.js b/core/gather/driver/storage.js
index 7f3b659a3821..19bb00f18b80 100644
--- a/core/gather/driver/storage.js
+++ b/core/gather/driver/storage.js
@@ -7,6 +7,7 @@
import log from 'lighthouse-logger';
import * as i18n from '../../lib/i18n/i18n.js';
+import {Sentry} from '../..... | [
"core/gather/driver/storage.js"
] | [] | true | |
GoogleChrome/lighthouse | 17,035 | issue_to_patch | Quota exceeded for quota metric
### FAQ
- [x] Yes, my issue is not about [variability](https://github.com/GoogleChrome/lighthouse/blob/main/docs/variability.md) or [throttling](https://github.com/GoogleChrome/lighthouse/blob/main/docs/throttling.md).
- [x] Yes, my issue is not about a specific accessibility audit (fi... | clients(viewer): rotate PSI API key | fixes #16874 | 7d8dcf5004950cad3faa20664e4a7cf2817bd653 | e6818438b94551b4ea3b213240fdf5588ff3f132 | diff --git a/viewer/app/src/psi-api.js b/viewer/app/src/psi-api.js
index 0de53d96afda..ca55cbad512e 100644
--- a/viewer/app/src/psi-api.js
+++ b/viewer/app/src/psi-api.js
@@ -7,7 +7,7 @@
/** @typedef {{lighthouseResult?: LH.Result, error?: {message: string}}} PSIResponse */
const PSI_URL = 'https://www.googleapis.c... | [
"viewer/app/src/psi-api.js"
] | [] | true | |
GoogleChrome/lighthouse | 17,008 | issue_to_patch | v13.3.0 | f1460505034cb8c542fd09847a87e20cbf6f31b2 | 19b3564df5e127a5c0085927bc13557f4e14c333 | diff --git a/changelog.md b/changelog.md
index 2fd0eee08574..60d8af64f401 100644
--- a/changelog.md
+++ b/changelog.md
@@ -1,3 +1,31 @@
+ <a name="13.3.0"></a>
+# 13.3.0 (2026-05-07)
+[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v13.2.0...v13.3.0)
+
+We expect this release to ship in the DevTools... | [
"changelog.md",
"core/test/fixtures/user-flows/reports/sample-flow-result.json",
"core/test/results/sample_v2.json",
"docs/plugins.md",
"docs/recipes/lighthouse-plugin-example/package.json",
"package.json",
"third-party/devtools-tests/e2e/lighthouse/navigation.test.ts",
"yarn.lock"
] | [] | diff --git a/core/test/fixtures/user-flows/reports/sample-flow-result.json b/core/test/fixtures/user-flows/reports/sample-flow-result.json
index 3c1d0f1616e9..0786921e3bd3 100644
--- a/core/test/fixtures/user-flows/reports/sample-flow-result.json
+++ b/core/test/fixtures/user-flows/reports/sample-flow-result.json
@@ -2... | true | ||
GoogleChrome/lighthouse | 17,006 | issue_to_patch | deps: upgrade dependencies | ec66b4af8424d43901f956f3070aca1aa1e4c03b | 3076d36be5619e8219098264c6418b4fbd3dbef3 | diff --git a/core/lib/baseline/web-features-metadata.json b/core/lib/baseline/web-features-metadata.json
index f232b6f4ad56..802210db1daf 100644
--- a/core/lib/baseline/web-features-metadata.json
+++ b/core/lib/baseline/web-features-metadata.json
@@ -1,3 +1,3 @@
{
- "date": "2026-03-18"
+ "date": "2026-05-01"
}
dif... | [
"core/lib/baseline/web-features-metadata.json",
"core/lib/deprecations-strings.js",
"core/test/fixtures/user-flows/reports/sample-flow-result.json",
"core/test/results/sample_v2.json",
"package.json",
"yarn.lock"
] | [] | diff --git a/core/test/fixtures/user-flows/reports/sample-flow-result.json b/core/test/fixtures/user-flows/reports/sample-flow-result.json
index 3e7ad9a8236e..3c1d0f1616e9 100644
--- a/core/test/fixtures/user-flows/reports/sample-flow-result.json
+++ b/core/test/fixtures/user-flows/reports/sample-flow-result.json
@@ -2... | true | ||
GoogleChrome/lighthouse | 17,005 | issue_to_patch | core(llms-txt): adjust titles and descriptions and add smoketests | Trying to be more accurate in the title. also add smoketests. | 147d04cee1546d6ce93416495a3750e929224552 | 71901435684679c05d1a61f9bba0475d63b217dd | diff --git a/core/audits/agentic/llms-txt.js b/core/audits/agentic/llms-txt.js
index a4307b443038..e19f031ede69 100644
--- a/core/audits/agentic/llms-txt.js
+++ b/core/audits/agentic/llms-txt.js
@@ -11,15 +11,15 @@ const HTTP_CLIENT_ERROR_CODE_LOW = 400;
const HTTP_SERVER_ERROR_CODE_LOW = 500;
const UIStrings = {
-... | [
"cli/test/fixtures/agentic/llms_tester.html",
"cli/test/fixtures/llms.txt",
"cli/test/smokehouse/core-tests.js",
"cli/test/smokehouse/test-definitions/llms-txt.js",
"core/audits/agentic/llms-txt.js",
"core/test/fixtures/user-flows/reports/sample-flow-result.json",
"core/test/results/sample_v2.json",
"... | [] | diff --git a/cli/test/fixtures/agentic/llms_tester.html b/cli/test/fixtures/agentic/llms_tester.html
new file mode 100644
index 000000000000..758340e9f664
--- /dev/null
+++ b/cli/test/fixtures/agentic/llms_tester.html
@@ -0,0 +1,14 @@
+<!DOCTYPE html>
+<!--
+ Copyright 2026 Google LLC
+ SPDX-License-Identifier: Apach... | true | |
GoogleChrome/lighthouse | 16,999 | issue_to_patch | tests(webmcp): add webmcp smoketests | Add webmcp smoketests
This PR also add Chrome flags as a test runner options. This is to allow WebMCP tests to pass the WebMCPTesting feature flag, without which these audits are N/A. We don't want to turn on WebMCPTesting by default yet because we don't want to turn on WebMCP audits just yet for every agentic brows... | e120fadb6f58a31fb0cdebd30cd97aa9ab3c9c8f | 6de2800342787fdb098dfbd329d7ed2ec5f34ea0 | diff --git a/types/internal/smokehouse.d.ts b/types/internal/smokehouse.d.ts
index 66c65ea3c6f8..cabbad760723 100644
--- a/types/internal/smokehouse.d.ts
+++ b/types/internal/smokehouse.d.ts
@@ -42,6 +42,10 @@ declare global {
config?: Config;
/** If test is performance sensitive, set to true so that it w... | [
"cli/test/fixtures/webmcp/webmcp_tester.html",
"cli/test/smokehouse/core-tests.js",
"cli/test/smokehouse/lighthouse-runners/bundle.js",
"cli/test/smokehouse/lighthouse-runners/cli.js",
"cli/test/smokehouse/lighthouse-runners/devtools-mcp.js",
"cli/test/smokehouse/lighthouse-runners/devtools.js",
"cli/te... | [] | diff --git a/cli/test/fixtures/webmcp/webmcp_tester.html b/cli/test/fixtures/webmcp/webmcp_tester.html
new file mode 100644
index 000000000000..faa7ec626f2a
--- /dev/null
+++ b/cli/test/fixtures/webmcp/webmcp_tester.html
@@ -0,0 +1,42 @@
+<!DOCTYPE html>
+<html lang="en">
+<head>
+ <meta charset="UTF-8">
+ <title>Web... | true | |
GoogleChrome/lighthouse | 17,004 | issue_to_patch | Revert "clients(devtools): include agentic browsing config in devtools entry" | Reverts GoogleChrome/lighthouse#16998 | e796f1b6a790cb7af5ee9dae63fc495f386c3ba9 | b92c6cc5f90f5e05505ac8e133c37f2ade6485e0 | [] | [] | true | |||
GoogleChrome/lighthouse | 17,002 | issue_to_patch | core(agentic browsing): add agentic browsing category to default config | Also remove custom config from bundle.
<img width="1046" height="871" alt="image" src="https://github.com/user-attachments/assets/5dfa42d9-7579-4d6a-8d7d-c902af2beb5b" />
| e148cc6b9d6668aa878caac66b0f3dd14261e939 | 6bbb5a5b8bdeb0810472fcef0bf6feb798338680 | diff --git a/build/build-bundle-mcp.js b/build/build-bundle-mcp.js
index 31afacfda9f5..e88324b4edfd 100644
--- a/build/build-bundle-mcp.js
+++ b/build/build-bundle-mcp.js
@@ -18,7 +18,6 @@ import esbuild from 'esbuild';
import * as plugins from './esbuild-plugins.js';
import {Runner} from '../core/runner.js';
import... | [
"build/build-bundle-mcp.js",
"build/test/build-bundle-mcp-test.js",
"cli/cli-flags.js",
"clients/devtools-mcp/devtools-mcp-entry.js",
"clients/extension/scripts/settings-controller.js",
"clients/test/extension/popup-test-pptr.js",
"core/config/default-config.js",
"core/index.js",
"core/test/fixtures... | [] | diff --git a/build/test/build-bundle-mcp-test.js b/build/test/build-bundle-mcp-test.js
index 43a47eff0fee..6f9a6ead8ca1 100644
--- a/build/test/build-bundle-mcp-test.js
+++ b/build/test/build-bundle-mcp-test.js
@@ -48,19 +48,6 @@ describe('MCP Bundle build', () => {
expect(typeof mcpBundle.generateReport).toBe('fu... | true | |
GoogleChrome/lighthouse | 17,003 | issue_to_patch | Revert "clients(devtools): include agentic browsing config in devtools entry" | Reverts GoogleChrome/lighthouse#16998 | 081b1f26d31ea0d62550eea92f0d385e732b77d7 | f1a733c10cec1fd09dfd7b176d7c3f8c92c13b40 | diff --git a/clients/devtools/devtools-entry.js b/clients/devtools/devtools-entry.js
index 7c72816bcb54..b8909cc8acf2 100644
--- a/clients/devtools/devtools-entry.js
+++ b/clients/devtools/devtools-entry.js
@@ -8,7 +8,7 @@ import {Buffer} from 'buffer';
import log from 'lighthouse-logger';
-import lighthouse, {nav... | [
"build/test/build-bundle-test.js",
"clients/devtools/devtools-entry.js"
] | [] | diff --git a/build/test/build-bundle-test.js b/build/test/build-bundle-test.js
index af329f8bf2a1..3147c87a0969 100644
--- a/build/test/build-bundle-test.js
+++ b/build/test/build-bundle-test.js
@@ -65,28 +65,4 @@ describe('Main Bundle build', () => {
await browser.close();
expect(isLighthouseAvailable).toBe(... | true | |
GoogleChrome/lighthouse | 16,998 | issue_to_patch | clients(devtools): include agentic browsing config in devtools entry | 8c6a64e0776bd97f2dd1603b8fd0581a5a2c8b56 | 98b468217ad994d8ce123b3b44ffc0616015eaa2 | diff --git a/clients/devtools/devtools-entry.js b/clients/devtools/devtools-entry.js
index b8909cc8acf2..7c72816bcb54 100644
--- a/clients/devtools/devtools-entry.js
+++ b/clients/devtools/devtools-entry.js
@@ -8,7 +8,7 @@ import {Buffer} from 'buffer';
import log from 'lighthouse-logger';
-import lighthouse, {nav... | [
"build/test/build-bundle-test.js",
"clients/devtools/devtools-entry.js"
] | [] | diff --git a/build/test/build-bundle-test.js b/build/test/build-bundle-test.js
index 3147c87a0969..af329f8bf2a1 100644
--- a/build/test/build-bundle-test.js
+++ b/build/test/build-bundle-test.js
@@ -65,4 +65,28 @@ describe('Main Bundle build', () => {
await browser.close();
expect(isLighthouseAvailable).toBe(... | true | ||
GoogleChrome/lighthouse | 16,997 | issue_to_patch | core(agentic-web): add links to category and audit descriptions | 8c6a64e0776bd97f2dd1603b8fd0581a5a2c8b56 | 0cfeb44f1311175ae6a7d255971bcb3a71a13531 | diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js
index 52023ac50436..82e051acf4b0 100644
--- a/core/audits/agentic/agent-accessibility-tree.js
+++ b/core/audits/agentic/agent-accessibility-tree.js
@@ -13,7 +13,7 @@ const UIStrings = {
/** Title shown when... | [
"core/audits/agentic/agent-accessibility-tree.js",
"core/audits/webmcp-form-coverage.js",
"core/audits/webmcp-registered-tools.js",
"core/audits/webmcp-schema-validity.js",
"core/config/agentic-browsing-config.js",
"shared/localization/locales/en-US.json",
"shared/localization/locales/en-XL.json"
] | [] | true | |||
GoogleChrome/lighthouse | 16,995 | issue_to_patch | misc(bundle): update build-bundle-mcp | e8b309ad8c7fe0565256ec871c9ce2b889fe979a | 2d2592b6f613de4931087155f40d037266dceee1 | diff --git a/build/build-bundle-mcp.js b/build/build-bundle-mcp.js
index 9c4e6c891d15..31afacfda9f5 100644
--- a/build/build-bundle-mcp.js
+++ b/build/build-bundle-mcp.js
@@ -76,7 +76,7 @@ function getMcpRequiredGathererNames() {
'MainDocumentContent', 'MetaElements', 'Stacks', 'Trace',
];
const a11yArtifact... | [
"build/build-bundle-mcp.js",
"build/test/build-bundle-mcp-test.js"
] | [] | diff --git a/build/test/build-bundle-mcp-test.js b/build/test/build-bundle-mcp-test.js
index d0549db732b2..43a47eff0fee 100644
--- a/build/test/build-bundle-mcp-test.js
+++ b/build/test/build-bundle-mcp-test.js
@@ -48,6 +48,19 @@ describe('MCP Bundle build', () => {
expect(typeof mcpBundle.generateReport).toBe('fu... | true | ||
GoogleChrome/lighthouse | 16,996 | issue_to_patch | tests(smoke): widen byte efficiency wastedBytes range for ToT | a160d341f363acf2d99314214a6e0de7d0fead1f | 83806611c8297ad6640a11ea4f7f66a8c1541f82 | [
"cli/test/smokehouse/test-definitions/byte-efficiency.js"
] | [] | diff --git a/cli/test/smokehouse/test-definitions/byte-efficiency.js b/cli/test/smokehouse/test-definitions/byte-efficiency.js
index 9561cd7bee0e..2f1e914514f9 100644
--- a/cli/test/smokehouse/test-definitions/byte-efficiency.js
+++ b/cli/test/smokehouse/test-definitions/byte-efficiency.js
@@ -214,7 +214,7 @@ const exp... | true | |||
GoogleChrome/lighthouse | 16,994 | issue_to_patch | v13.2.0 | 2caf7c29acbf64ba1fa0a3e65713ed1ef3ea8963 | c006eac9b369120e7749a0f5d3baadc2d461d44c | diff --git a/changelog.md b/changelog.md
index 57ba5a3d2e3a..2fd0eee08574 100644
--- a/changelog.md
+++ b/changelog.md
@@ -1,3 +1,58 @@
+ <a name="13.2.0"></a>
+# 13.2.0 (2026-04-30)
+[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v13.1.0...v13.2.0)
+
+We expect this release to ship in the DevTools... | [
"changelog.md",
"core/test/fixtures/user-flows/reports/sample-flow-result.json",
"core/test/results/sample_v2.json",
"docs/plugins.md",
"docs/recipes/lighthouse-plugin-example/package.json",
"package.json",
"third-party/devtools-tests/e2e/lighthouse/navigation.test.ts"
] | [] | diff --git a/core/test/fixtures/user-flows/reports/sample-flow-result.json b/core/test/fixtures/user-flows/reports/sample-flow-result.json
index d05dfbd317f3..2f52332fb0ab 100644
--- a/core/test/fixtures/user-flows/reports/sample-flow-result.json
+++ b/core/test/fixtures/user-flows/reports/sample-flow-result.json
@@ -2... | true | ||
GoogleChrome/lighthouse | 16,992 | issue_to_patch | deps: upgrade deps | dd652bf1bf6b4df095c27d2ad321227522bba1ac | a3e7f70c37235a06ebba905b9f0b33c233a91dcf | diff --git a/package.json b/package.json
index f44cd5476632..cd0274907d4e 100644
--- a/package.json
+++ b/package.json
@@ -141,7 +141,7 @@
"builtin-modules": "^3.3.0",
"c8": "^7.11.3",
"chalk": "^2.4.1",
- "chrome-devtools-frontend": "1.0.1608453",
+ "chrome-devtools-frontend": "1.0.1621678",
... | [
"package.json",
"yarn.lock"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.