repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=319f97dc-4f24-4a21-84b4-77f5691eb8fa -->
<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->
<!-- metadata:{"confidence":9} -->
P2: Redo history is cleared even when no commit is produced. A no-op retire can silently disable redo after undo.
<details>
<summary>Prompt for AI agents</summary>
``... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/session.rs b/document/graph-storage/src/session.rs
new file mode 100644
index 0000000000..9e287c51ac
--- /dev/null
+++ b/document/graph-storage/src/session.rs
@@ -0,0 +1,545 @@
+use crate::from_runtime;
+use crate::{ApplyMode, AttributesWrite, Delta, Document, LamportClock, Netwo... | [
"document/graph-storage/src/session.rs"
] | [
{
"comment": "<!-- cubic:v=319f97dc-4f24-4a21-84b4-77f5691eb8fa -->\n<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->\n<!-- metadata:{\"confidence\":9} -->\nP2: Redo history is cleared even when no commit is produced. A no-op retire can silently disable redo after undo.\n\n<details>\n<summary>Prom... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=99ff374a-c66f-4567-a9e9-8ffb129839b3 -->
<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->
<!-- metadata:{"confidence":8} -->
P2: Export-list truncation is encoded as `SetExport(None)` but that op never shrinks `net.exports`, so diff-apply cannot fully reach target network shape when `to.expor... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/delta.rs b/document/graph-storage/src/delta.rs
new file mode 100644
index 0000000000..bcbe59a592
--- /dev/null
+++ b/document/graph-storage/src/delta.rs
@@ -0,0 +1,425 @@
+use std::collections::HashSet;
+
+use crate::{AttributeDelta, NetworkId, Node, NodeId, Registry, RegistryDel... | [
"document/graph-storage/src/delta.rs"
] | [
{
"comment": "<!-- cubic:v=99ff374a-c66f-4567-a9e9-8ffb129839b3 -->\n<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->\n<!-- metadata:{\"confidence\":8} -->\nP2: Export-list truncation is encoded as `SetExport(None)` but that op never shrinks `net.exports`, so diff-apply cannot fully reach target n... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=11f24da7-f83a-440f-b249-90f1f3e3b358 -->
<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->
<!-- metadata:{"confidence":7} -->
P2: Parallel `inputs`/`inputs_attributes` vectors make length mismatches representable. That invalid state is already handled as an error during runtime conversion, so ... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/model.rs b/document/graph-storage/src/model.rs
new file mode 100644
index 0000000000..6b9c1c4663
--- /dev/null
+++ b/document/graph-storage/src/model.rs
@@ -0,0 +1,189 @@
+use crate::{Attributes, NetworkId, NodeId, ResourceId, TimeStamp, attributes_value_equal};
+use serde::{Dese... | [
"document/graph-storage/src/model.rs"
] | [
{
"comment": "<!-- cubic:v=11f24da7-f83a-440f-b249-90f1f3e3b358 -->\n<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->\n<!-- metadata:{\"confidence\":7} -->\nP2: Parallel `inputs`/`inputs_attributes` vectors make length mismatches representable. That invalid state is already handled as an error dur... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=5768ea82-aebe-4a9f-a553-0bf2cf792932 -->
<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->
<!-- metadata:{"confidence":8} -->
P2: `Reflection` stores required metadata outside the enum, so required state is not atomic. A `ChangeNodeInput` to `Reflection` can leave the node in a conversion-fail... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/model.rs b/document/graph-storage/src/model.rs
new file mode 100644
index 0000000000..6b9c1c4663
--- /dev/null
+++ b/document/graph-storage/src/model.rs
@@ -0,0 +1,189 @@
+use crate::{Attributes, NetworkId, NodeId, ResourceId, TimeStamp, attributes_value_equal};
+use serde::{Dese... | [
"document/graph-storage/src/model.rs"
] | [
{
"comment": "<!-- cubic:v=5768ea82-aebe-4a9f-a553-0bf2cf792932 -->\n<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->\n<!-- metadata:{\"confidence\":8} -->\nP2: `Reflection` stores required metadata outside the enum, so required state is not atomic. A `ChangeNodeInput` to `Reflection` can leave th... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=b5f1bf0e-c9df-409e-a146-ae91f4e2b3a5 -->
<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->
<!-- metadata:{"confidence":9} -->
P3: Use `{ workspace = true }` instead of an inline version — blake3 is already managed in `[workspace.dependencies]` at line 178 of the root `Cargo.toml`. An inline ve... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/Cargo.toml b/document/graph-storage/Cargo.toml
new file mode 100644
index 0000000000..53d86b4b6f
--- /dev/null
+++ b/document/graph-storage/Cargo.toml
@@ -0,0 +1,26 @@
+[package]
+name = "graph-storage"
+description = "Provides a delta based graph representation used in the Graphite ... | [
"document/graph-storage/Cargo.toml"
] | [
{
"comment": "<!-- cubic:v=b5f1bf0e-c9df-409e-a146-ae91f4e2b3a5 -->\n<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->\n<!-- metadata:{\"confidence\":9} -->\nP3: Use `{ workspace = true }` instead of an inline version — blake3 is already managed in `[workspace.dependencies]` at line 178 of the root... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=235b7db3-a183-4a45-b26b-3f98e8fe3662 -->
<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->
<!-- metadata:{"confidence":9} -->
P3: Use `{ workspace = true }` instead of an inline version — rustc-hash is already managed in `[workspace.dependencies]` at line 102 of the root `Cargo.toml`. An inlin... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/Cargo.toml b/document/graph-storage/Cargo.toml
new file mode 100644
index 0000000000..53d86b4b6f
--- /dev/null
+++ b/document/graph-storage/Cargo.toml
@@ -0,0 +1,26 @@
+[package]
+name = "graph-storage"
+description = "Provides a delta based graph representation used in the Graphite ... | [
"document/graph-storage/Cargo.toml"
] | [
{
"comment": "<!-- cubic:v=235b7db3-a183-4a45-b26b-3f98e8fe3662 -->\n<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->\n<!-- metadata:{\"confidence\":9} -->\nP3: Use `{ workspace = true }` instead of an inline version — rustc-hash is already managed in `[workspace.dependencies]` at line 102 of the ... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=13ff7296-c99e-4b39-a345-ec23a78636a0 -->
<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->
<!-- metadata:{"confidence":9} -->
P3: Use `{ workspace = true }` instead of an inline version — thiserror is already managed in `[workspace.dependencies]` at line 120 of the root `Cargo.toml`. An inline... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/Cargo.toml b/document/graph-storage/Cargo.toml
new file mode 100644
index 0000000000..53d86b4b6f
--- /dev/null
+++ b/document/graph-storage/Cargo.toml
@@ -0,0 +1,26 @@
+[package]
+name = "graph-storage"
+description = "Provides a delta based graph representation used in the Graphite ... | [
"document/graph-storage/Cargo.toml"
] | [
{
"comment": "<!-- cubic:v=13ff7296-c99e-4b39-a345-ec23a78636a0 -->\n<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->\n<!-- metadata:{\"confidence\":9} -->\nP3: Use `{ workspace = true }` instead of an inline version — thiserror is already managed in `[workspace.dependencies]` at line 120 of the r... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=16ec85b5-2529-43c6-8340-db1959ed9227 -->
<!-- cubic:review-run=54f5098a-c713-4cff-8cd0-5e4a456fd369 -->
<!-- metadata:{"confidence":7} -->
P1: This unconditional registry reset can lose visible hot-zone edits and desynchronize working state from `hot_log` when called with unretired ops present. Rebuild wor... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/session.rs b/document/graph-storage/src/session.rs
new file mode 100644
index 0000000000..9e287c51ac
--- /dev/null
+++ b/document/graph-storage/src/session.rs
@@ -0,0 +1,545 @@
+use crate::from_runtime;
+use crate::{ApplyMode, AttributesWrite, Delta, Document, LamportClock, Netwo... | [
"document/graph-storage/src/session.rs"
] | [
{
"comment": "<!-- cubic:v=16ec85b5-2529-43c6-8340-db1959ed9227 -->\n<!-- cubic:review-run=54f5098a-c713-4cff-8cd0-5e4a456fd369 -->\n<!-- metadata:{\"confidence\":7} -->\nP1: This unconditional registry reset can lose visible hot-zone edits and desynchronize working state from `hot_log` when called with unretir... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=518d7c9a-2752-44a8-8b74-43f9f3ffba92 -->
<!-- cubic:review-run=54f5098a-c713-4cff-8cd0-5e4a456fd369 -->
<!-- metadata:{"confidence":7} -->
P2: `LamportClock` should not be default-constructible because it needs an explicit `PeerId`. Deriving `Default` makes an invalid/ambiguous state easy to create.
<deta... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/ids.rs b/document/graph-storage/src/ids.rs
new file mode 100644
index 0000000000..216af8c667
--- /dev/null
+++ b/document/graph-storage/src/ids.rs
@@ -0,0 +1,99 @@
+use crate::RegistryDelta;
+use serde::{Deserialize, Serialize};
+
+/// Stable, document-scoped identity for a node.... | [
"document/graph-storage/src/ids.rs"
] | [
{
"comment": "<!-- cubic:v=518d7c9a-2752-44a8-8b74-43f9f3ffba92 -->\n<!-- cubic:review-run=54f5098a-c713-4cff-8cd0-5e4a456fd369 -->\n<!-- metadata:{\"confidence\":7} -->\nP2: `LamportClock` should not be default-constructible because it needs an explicit `PeerId`. Deriving `Default` makes an invalid/ambiguous s... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=6aac260e-abc4-4be4-a606-e1f5406293c7 -->
<!-- cubic:review-run=54f5098a-c713-4cff-8cd0-5e4a456fd369 -->
<!-- metadata:{"confidence":8} -->
P2: `commit_ops` can panic on missing parent via `assert!`, crashing the app instead of returning an error from this fallible path.
(Based on your team's feedback abou... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/session.rs b/document/graph-storage/src/session.rs
new file mode 100644
index 0000000000..9e287c51ac
--- /dev/null
+++ b/document/graph-storage/src/session.rs
@@ -0,0 +1,545 @@
+use crate::from_runtime;
+use crate::{ApplyMode, AttributesWrite, Delta, Document, LamportClock, Netwo... | [
"document/graph-storage/src/session.rs"
] | [
{
"comment": "<!-- cubic:v=6aac260e-abc4-4be4-a606-e1f5406293c7 -->\n<!-- cubic:review-run=54f5098a-c713-4cff-8cd0-5e4a456fd369 -->\n<!-- metadata:{\"confidence\":8} -->\nP2: `commit_ops` can panic on missing parent via `assert!`, crashing the app instead of returning an error from this fallible path.\n\n(Based... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=6381ca17-dfcd-4364-8b0f-5252a234131c -->
<!-- cubic:review-run=ac33e2eb-2fbf-4814-a9fa-2b0061639e4c -->
<!-- metadata:{"confidence":9} -->
P1: History iterator drops the root delta because `?` short-circuits before `Some(delta)`. This breaks history-based restoration when the relevant removal is at the roo... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/document.rs b/document/graph-storage/src/document.rs
new file mode 100644
index 0000000000..d93bc9a032
--- /dev/null
+++ b/document/graph-storage/src/document.rs
@@ -0,0 +1,459 @@
+use crate::{
+ CrdtError, Delta, ExportSlot, HotOp, LamportClock, MAX_EXPORT_SLOTS, NetworkId, Node... | [
"document/graph-storage/src/document.rs"
] | [
{
"comment": "<!-- cubic:v=6381ca17-dfcd-4364-8b0f-5252a234131c -->\n<!-- cubic:review-run=ac33e2eb-2fbf-4814-a9fa-2b0061639e4c -->\n<!-- metadata:{\"confidence\":9} -->\nP1: History iterator drops the root delta because `?` short-circuits before `Some(delta)`. This breaks history-based restoration when the rel... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=a3ad9fb0-4a14-4be8-95ef-9497ec9d8272 -->
<!-- cubic:review-run=ac33e2eb-2fbf-4814-a9fa-2b0061639e4c -->
<!-- metadata:{"confidence":6} -->
P1: Node-reference remapping lacks a same-network validation guard. Cross-network references can be converted into wrong/dangling local runtime IDs instead of returning... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/to_runtime.rs b/document/graph-storage/src/to_runtime.rs
new file mode 100644
index 0000000000..d9f19852ae
--- /dev/null
+++ b/document/graph-storage/src/to_runtime.rs
@@ -0,0 +1,380 @@
+use std::borrow::Cow;
+use std::collections::HashMap;
+
+use core_types::memo::MemoHash;
+use... | [
"document/graph-storage/src/to_runtime.rs"
] | [
{
"comment": "<!-- cubic:v=a3ad9fb0-4a14-4be8-95ef-9497ec9d8272 -->\n<!-- cubic:review-run=ac33e2eb-2fbf-4814-a9fa-2b0061639e4c -->\n<!-- metadata:{\"confidence\":6} -->\nP1: Node-reference remapping lacks a same-network validation guard. Cross-network references can be converted into wrong/dangling local runti... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=b5e125b5-a3b6-4fc9-8c58-1773d027664e -->
<!-- cubic:review-run=ac33e2eb-2fbf-4814-a9fa-2b0061639e4c -->
<!-- metadata:{"confidence":8} -->
P2: `Priority` exposes its inner `f64`, so callers/deserialization can bypass the finite-value invariant enforced by `Priority::new`. Make invalid states unrepresentabl... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/attributes.rs b/document/graph-storage/src/attributes.rs
new file mode 100644
index 0000000000..aa7c7f221e
--- /dev/null
+++ b/document/graph-storage/src/attributes.rs
@@ -0,0 +1,71 @@
+use crate::TimeStamp;
+use serde::{Deserialize, Serialize};
+use std::collections::BTreeMap;
+... | [
"document/graph-storage/src/attributes.rs"
] | [
{
"comment": "<!-- cubic:v=b5e125b5-a3b6-4fc9-8c58-1773d027664e -->\n<!-- cubic:review-run=ac33e2eb-2fbf-4814-a9fa-2b0061639e4c -->\n<!-- metadata:{\"confidence\":8} -->\nP2: `Priority` exposes its inner `f64`, so callers/deserialization can bypass the finite-value invariant enforced by `Priority::new`. Make in... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=23e6d588-1ed6-44ae-a3f0-7a23bfa34284 -->
<!-- cubic:review-run=ac33e2eb-2fbf-4814-a9fa-2b0061639e4c -->
<!-- metadata:{"confidence":9} -->
P2: Diff generation is nondeterministic because it iterates `HashSet` differences/intersections. This makes identical state transitions produce different commit sequenc... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/delta.rs b/document/graph-storage/src/delta.rs
new file mode 100644
index 0000000000..bcbe59a592
--- /dev/null
+++ b/document/graph-storage/src/delta.rs
@@ -0,0 +1,425 @@
+use std::collections::HashSet;
+
+use crate::{AttributeDelta, NetworkId, Node, NodeId, Registry, RegistryDel... | [
"document/graph-storage/src/delta.rs"
] | [
{
"comment": "<!-- cubic:v=23e6d588-1ed6-44ae-a3f0-7a23bfa34284 -->\n<!-- cubic:review-run=ac33e2eb-2fbf-4814-a9fa-2b0061639e4c -->\n<!-- metadata:{\"confidence\":9} -->\nP2: Diff generation is nondeterministic because it iterates `HashSet` differences/intersections. This makes identical state transitions produ... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=8ca3a807-6dde-4714-b7f7-26fb5e9c56cc -->
<!-- cubic:review-run=ac33e2eb-2fbf-4814-a9fa-2b0061639e4c -->
<!-- metadata:{"confidence":8} -->
P2: Per-network conversion does repeated full-map scans of `node_instances`, causing avoidable quadratic work on nested/large graphs. This can noticeably slow full rebu... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/to_runtime.rs b/document/graph-storage/src/to_runtime.rs
new file mode 100644
index 0000000000..d9f19852ae
--- /dev/null
+++ b/document/graph-storage/src/to_runtime.rs
@@ -0,0 +1,380 @@
+use std::borrow::Cow;
+use std::collections::HashMap;
+
+use core_types::memo::MemoHash;
+use... | [
"document/graph-storage/src/to_runtime.rs"
] | [
{
"comment": "<!-- cubic:v=8ca3a807-6dde-4714-b7f7-26fb5e9c56cc -->\n<!-- cubic:review-run=ac33e2eb-2fbf-4814-a9fa-2b0061639e4c -->\n<!-- metadata:{\"confidence\":8} -->\nP2: Per-network conversion does repeated full-map scans of `node_instances`, causing avoidable quadratic work on nested/large graphs. This ca... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=e63b86a3-71db-4d44-952a-bc5fb2f78226 -->
<!-- cubic:review-run=5ed37803-8f5f-479e-be7d-de8e6761ede0 -->
<!-- metadata:{"confidence":9} -->
P1: `sources` sorted-order invariant is not enforced, but all core operations assume it via binary search. Unsorted external or deserialized data will silently corrupt ... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/resources.rs b/document/graph-storage/src/resources.rs
new file mode 100644
index 0000000000..a29a37e2b3
--- /dev/null
+++ b/document/graph-storage/src/resources.rs
@@ -0,0 +1,297 @@
+use crate::{PeerId, TimeStamp};
+use graphene_resource::{ResourceHash, ResourceId};
+use serde::... | [
"document/graph-storage/src/resources.rs"
] | [
{
"comment": "<!-- cubic:v=e63b86a3-71db-4d44-952a-bc5fb2f78226 -->\n<!-- cubic:review-run=5ed37803-8f5f-479e-be7d-de8e6761ede0 -->\n<!-- metadata:{\"confidence\":9} -->\nP1: `sources` sorted-order invariant is not enforced, but all core operations assume it via binary search. Unsorted external or deserialized ... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=64e6b716-883b-437c-bca4-207d80f5af49 -->
<!-- cubic:review-run=5ed37803-8f5f-479e-be7d-de8e6761ede0 -->
<!-- metadata:{"confidence":7} -->
P1: Attribute deletes drop their timestamp tombstone, so stale set ops can resurrect removed keys under out-of-order delivery. This breaks intended LWW convergence for ... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/crdt.rs b/document/graph-storage/src/crdt.rs
new file mode 100644
index 0000000000..d099086dc8
--- /dev/null
+++ b/document/graph-storage/src/crdt.rs
@@ -0,0 +1,189 @@
+use crate::{Attributes, AttributesWrite, Network, NetworkId, Node, NodeId, NodeInput, PeerId, ResourceEntry, Re... | [
"document/graph-storage/src/crdt.rs"
] | [
{
"comment": "<!-- cubic:v=64e6b716-883b-437c-bca4-207d80f5af49 -->\n<!-- cubic:review-run=5ed37803-8f5f-479e-be7d-de8e6761ede0 -->\n<!-- metadata:{\"confidence\":7} -->\nP1: Attribute deletes drop their timestamp tombstone, so stale set ops can resurrect removed keys under out-of-order delivery. This breaks in... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=53616773-4d2a-4394-8b06-e9573d8b2f14 -->
<!-- cubic:review-run=5ed37803-8f5f-479e-be7d-de8e6761ede0 -->
<!-- metadata:{"confidence":8} -->
P2: Node structural diff misses `inputs_attributes` length changes. This can drop required deltas because the later `zip` only compares the shared prefix.
<details>
<s... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/delta.rs b/document/graph-storage/src/delta.rs
new file mode 100644
index 0000000000..bcbe59a592
--- /dev/null
+++ b/document/graph-storage/src/delta.rs
@@ -0,0 +1,425 @@
+use std::collections::HashSet;
+
+use crate::{AttributeDelta, NetworkId, Node, NodeId, Registry, RegistryDel... | [
"document/graph-storage/src/delta.rs"
] | [
{
"comment": "<!-- cubic:v=53616773-4d2a-4394-8b06-e9573d8b2f14 -->\n<!-- cubic:review-run=5ed37803-8f5f-479e-be7d-de8e6761ede0 -->\n<!-- metadata:{\"confidence\":8} -->\nP2: Node structural diff misses `inputs_attributes` length changes. This can drop required deltas because the later `zip` only compares the s... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=3062d9cc-c9f9-41b0-9deb-f6c765fe3325 -->
<!-- cubic:review-run=5ed37803-8f5f-479e-be7d-de8e6761ede0 -->
<!-- metadata:{"confidence":7} -->
P3: `Network::value_equal` duplicates export-slot equivalence logic already encoded in delta computation. This is a drift risk: equality checks and emitted deltas can s... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/model.rs b/document/graph-storage/src/model.rs
new file mode 100644
index 0000000000..6b9c1c4663
--- /dev/null
+++ b/document/graph-storage/src/model.rs
@@ -0,0 +1,189 @@
+use crate::{Attributes, NetworkId, NodeId, ResourceId, TimeStamp, attributes_value_equal};
+use serde::{Dese... | [
"document/graph-storage/src/model.rs"
] | [
{
"comment": "<!-- cubic:v=3062d9cc-c9f9-41b0-9deb-f6c765fe3325 -->\n<!-- cubic:review-run=5ed37803-8f5f-479e-be7d-de8e6761ede0 -->\n<!-- metadata:{\"confidence\":7} -->\nP3: `Network::value_equal` duplicates export-slot equivalence logic already encoded in delta computation. This is a drift risk: equality chec... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=bc9f5a4d-e258-404f-93b3-8ac38e63f27f -->
<!-- cubic:review-run=0cce8589-0fd9-4ead-a9e2-283c9f74e09a -->
<!-- metadata:{"confidence":8} -->
P1: `Delta.id` is deserialized as trusted input but never validated against the content-addressed hash. This breaks the integrity guarantee of `Rev` and allows history-... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/crdt.rs b/document/graph-storage/src/crdt.rs
new file mode 100644
index 0000000000..d099086dc8
--- /dev/null
+++ b/document/graph-storage/src/crdt.rs
@@ -0,0 +1,189 @@
+use crate::{Attributes, AttributesWrite, Network, NetworkId, Node, NodeId, NodeInput, PeerId, ResourceEntry, Re... | [
"document/graph-storage/src/crdt.rs"
] | [
{
"comment": "<!-- cubic:v=bc9f5a4d-e258-404f-93b3-8ac38e63f27f -->\n<!-- cubic:review-run=0cce8589-0fd9-4ead-a9e2-283c9f74e09a -->\n<!-- metadata:{\"confidence\":8} -->\nP1: `Delta.id` is deserialized as trusted input but never validated against the content-addressed hash. This breaks the integrity guarantee o... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=b351f309-1dbd-47a9-9db6-1329bf8a3b76 -->
<!-- cubic:review-run=0cce8589-0fd9-4ead-a9e2-283c9f74e09a -->
<!-- metadata:{"confidence":8} -->
P2: Deserialization restores sort order but not key uniqueness, violating the binary-search invariant. Duplicate keys on disk can cause wrong source reads/updates/remov... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/resources.rs b/document/graph-storage/src/resources.rs
new file mode 100644
index 0000000000..a29a37e2b3
--- /dev/null
+++ b/document/graph-storage/src/resources.rs
@@ -0,0 +1,297 @@
+use crate::{PeerId, TimeStamp};
+use graphene_resource::{ResourceHash, ResourceId};
+use serde::... | [
"document/graph-storage/src/resources.rs"
] | [
{
"comment": "<!-- cubic:v=b351f309-1dbd-47a9-9db6-1329bf8a3b76 -->\n<!-- cubic:review-run=0cce8589-0fd9-4ead-a9e2-283c9f74e09a -->\n<!-- metadata:{\"confidence\":8} -->\nP2: Deserialization restores sort order but not key uniqueness, violating the binary-search invariant. Duplicate keys on disk can cause wrong... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=1f6963c3-9631-496f-9861-1148b27dd66a -->
<!-- cubic:review-run=0cce8589-0fd9-4ead-a9e2-283c9f74e09a -->
<!-- metadata:{"confidence":6} -->
P2: Deriving `ResourceId` from only the first 8 hash bytes makes distinct resources collide at 64-bit boundaries. A collision would merge declarations under one ID and ... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/node-graph/libraries/resources/src/lib.rs b/node-graph/libraries/resources/src/lib.rs
index 0fffabb324..516e186371 100644
--- a/node-graph/libraries/resources/src/lib.rs
+++ b/node-graph/libraries/resources/src/lib.rs
@@ -246,6 +246,16 @@ impl ResourceId {
pub fn new() -> Self {
Self(core_types::uuid:... | [
"node-graph/libraries/resources/src/lib.rs"
] | [
{
"comment": "<!-- cubic:v=1f6963c3-9631-496f-9861-1148b27dd66a -->\n<!-- cubic:review-run=0cce8589-0fd9-4ead-a9e2-283c9f74e09a -->\n<!-- metadata:{\"confidence\":6} -->\nP2: Deriving `ResourceId` from only the first 8 hash bytes makes distinct resources collide at 64-bit boundaries. A collision would merge dec... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=a111c2b2-f6e0-4d84-baf0-477400ca5e0b -->
<!-- cubic:review-run=0cce8589-0fd9-4ead-a9e2-283c9f74e09a -->
<!-- metadata:{"confidence":7} -->
P2: `compute_rev` can panic via `expect`, turning rev computation failures into process crashes.
(Based on your team's feedback about avoiding panics in application co... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/ids.rs b/document/graph-storage/src/ids.rs
new file mode 100644
index 0000000000..216af8c667
--- /dev/null
+++ b/document/graph-storage/src/ids.rs
@@ -0,0 +1,99 @@
+use crate::RegistryDelta;
+use serde::{Deserialize, Serialize};
+
+/// Stable, document-scoped identity for a node.... | [
"document/graph-storage/src/ids.rs"
] | [
{
"comment": "<!-- cubic:v=a111c2b2-f6e0-4d84-baf0-477400ca5e0b -->\n<!-- cubic:review-run=0cce8589-0fd9-4ead-a9e2-283c9f74e09a -->\n<!-- metadata:{\"confidence\":7} -->\nP2: `compute_rev` can panic via `expect`, turning rev computation failures into process crashes.\n\n(Based on your team's feedback about avoi... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=a3c5dbfa-b147-4c31-a384-06dc719fa998 -->
<!-- cubic:review-run=0cce8589-0fd9-4ead-a9e2-283c9f74e09a -->
<!-- metadata:{"confidence":7} -->
P2: `mint_node_id` can panic via `expect`, which is unsafe for application-path ID generation.
(Based on your team's feedback about avoiding panics in application code... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/ids.rs b/document/graph-storage/src/ids.rs
new file mode 100644
index 0000000000..216af8c667
--- /dev/null
+++ b/document/graph-storage/src/ids.rs
@@ -0,0 +1,99 @@
+use crate::RegistryDelta;
+use serde::{Deserialize, Serialize};
+
+/// Stable, document-scoped identity for a node.... | [
"document/graph-storage/src/ids.rs"
] | [
{
"comment": "<!-- cubic:v=a3c5dbfa-b147-4c31-a384-06dc719fa998 -->\n<!-- cubic:review-run=0cce8589-0fd9-4ead-a9e2-283c9f74e09a -->\n<!-- metadata:{\"confidence\":7} -->\nP2: `mint_node_id` can panic via `expect`, which is unsafe for application-path ID generation.\n\n(Based on your team's feedback about avoidi... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=e9fad44e-15d8-4229-bf11-283e88c964b2 -->
<!-- cubic:review-run=0cce8589-0fd9-4ead-a9e2-283c9f74e09a -->
<!-- metadata:{"confidence":9} -->
P3: Doc grammar: "Rebuild errors on length mismatch" reads awkwardly; clarify the subject.
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this iss... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/metadata_source.rs b/document/graph-storage/src/metadata_source.rs
new file mode 100644
index 0000000000..62bcde76a4
--- /dev/null
+++ b/document/graph-storage/src/metadata_source.rs
@@ -0,0 +1,130 @@
+//! Lets `from_runtime` read editor-side per-node metadata without depending o... | [
"document/graph-storage/src/metadata_source.rs"
] | [
{
"comment": "<!-- cubic:v=e9fad44e-15d8-4229-bf11-283e88c964b2 -->\n<!-- cubic:review-run=0cce8589-0fd9-4ead-a9e2-283c9f74e09a -->\n<!-- metadata:{\"confidence\":9} -->\nP3: Doc grammar: \"Rebuild errors on length mismatch\" reads awkwardly; clarify the subject.\n\n<details>\n<summary>Prompt for AI agents</sum... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=83d3028f-c68c-4bdb-a802-96806740e0f4 -->
<!-- cubic:review-run=174042ef-c9b6-4958-a71a-3faf7f76c6c5 -->
<!-- metadata:{"confidence":8} -->
P1: `scope_injections` are dropped during conversion instead of being preserved or rejected. This can silently lose graph behavior on runtime->storage->runtime round tr... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/from_runtime.rs b/document/graph-storage/src/from_runtime.rs
new file mode 100644
index 0000000000..0c2cd26f41
--- /dev/null
+++ b/document/graph-storage/src/from_runtime.rs
@@ -0,0 +1,573 @@
+use std::collections::HashMap;
+
+use core_types::Context;
+use core_types::context::Co... | [
"document/graph-storage/src/from_runtime.rs"
] | [
{
"comment": "<!-- cubic:v=83d3028f-c68c-4bdb-a802-96806740e0f4 -->\n<!-- cubic:review-run=174042ef-c9b6-4958-a71a-3faf7f76c6c5 -->\n<!-- metadata:{\"confidence\":8} -->\nP1: `scope_injections` are dropped during conversion instead of being preserved or rejected. This can silently lose graph behavior on runtime... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=48b41ad8-3598-480d-901b-2a151977e26d -->
<!-- cubic:review-run=174042ef-c9b6-4958-a71a-3faf7f76c6c5 -->
<!-- metadata:{"confidence":6} -->
P2: `ResourceEntry::embedded` contains panicking `expect(...)` calls on a non-test path, which can crash the editor instead of surfacing a handled error.
(Based on you... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/resources.rs b/document/graph-storage/src/resources.rs
new file mode 100644
index 0000000000..a29a37e2b3
--- /dev/null
+++ b/document/graph-storage/src/resources.rs
@@ -0,0 +1,297 @@
+use crate::{PeerId, TimeStamp};
+use graphene_resource::{ResourceHash, ResourceId};
+use serde::... | [
"document/graph-storage/src/resources.rs"
] | [
{
"comment": "<!-- cubic:v=48b41ad8-3598-480d-901b-2a151977e26d -->\n<!-- cubic:review-run=174042ef-c9b6-4958-a71a-3faf7f76c6c5 -->\n<!-- metadata:{\"confidence\":6} -->\nP2: `ResourceEntry::embedded` contains panicking `expect(...)` calls on a non-test path, which can crash the editor instead of surfacing a ha... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=32526ead-b47f-4b55-9b78-b48fb0a9b6a5 -->
<!-- cubic:review-run=174042ef-c9b6-4958-a71a-3faf7f76c6c5 -->
<!-- metadata:{"confidence":7} -->
P2: `has_embedded_source` uses raw JSON-value equality instead of semantic `DataSource` decoding, so format-shape changes can bypass embedded detection and add duplicat... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/resources.rs b/document/graph-storage/src/resources.rs
new file mode 100644
index 0000000000..a29a37e2b3
--- /dev/null
+++ b/document/graph-storage/src/resources.rs
@@ -0,0 +1,297 @@
+use crate::{PeerId, TimeStamp};
+use graphene_resource::{ResourceHash, ResourceId};
+use serde::... | [
"document/graph-storage/src/resources.rs"
] | [
{
"comment": "<!-- cubic:v=32526ead-b47f-4b55-9b78-b48fb0a9b6a5 -->\n<!-- cubic:review-run=174042ef-c9b6-4958-a71a-3faf7f76c6c5 -->\n<!-- metadata:{\"confidence\":7} -->\nP2: `has_embedded_source` uses raw JSON-value equality instead of semantic `DataSource` decoding, so format-shape changes can bypass embedded... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=b0660a8f-34a8-4b87-9759-1951e4e015f2 -->
<!-- cubic:review-run=174042ef-c9b6-4958-a71a-3faf7f76c6c5 -->
<!-- metadata:{"confidence":8} -->
P2: `is_gesture_end` ignores the marker value and treats any stored value as `true`. This can split undo gestures incorrectly when the annotation is present but false/m... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/crdt.rs b/document/graph-storage/src/crdt.rs
new file mode 100644
index 0000000000..d099086dc8
--- /dev/null
+++ b/document/graph-storage/src/crdt.rs
@@ -0,0 +1,189 @@
+use crate::{Attributes, AttributesWrite, Network, NetworkId, Node, NodeId, NodeInput, PeerId, ResourceEntry, Re... | [
"document/graph-storage/src/crdt.rs"
] | [
{
"comment": "<!-- cubic:v=b0660a8f-34a8-4b87-9759-1951e4e015f2 -->\n<!-- cubic:review-run=174042ef-c9b6-4958-a71a-3faf7f76c6c5 -->\n<!-- metadata:{\"confidence\":8} -->\nP2: `is_gesture_end` ignores the marker value and treats any stored value as `true`. This can split undo gestures incorrectly when the annota... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=59cd3611-e375-44d7-973b-5ee08a5dc687 -->
<!-- cubic:review-run=534964ba-7b79-40e1-8179-630624ebe73e -->
<!-- metadata:{"confidence":6} -->
P1: Network conversion has no cycle detection for nested `Implementation::Network` references. Cyclic references can recurse indefinitely and crash with stack overflow.... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/to_runtime.rs b/document/graph-storage/src/to_runtime.rs
new file mode 100644
index 0000000000..d9f19852ae
--- /dev/null
+++ b/document/graph-storage/src/to_runtime.rs
@@ -0,0 +1,380 @@
+use std::borrow::Cow;
+use std::collections::HashMap;
+
+use core_types::memo::MemoHash;
+use... | [
"document/graph-storage/src/to_runtime.rs"
] | [
{
"comment": "<!-- cubic:v=59cd3611-e375-44d7-973b-5ee08a5dc687 -->\n<!-- cubic:review-run=534964ba-7b79-40e1-8179-630624ebe73e -->\n<!-- metadata:{\"confidence\":6} -->\nP1: Network conversion has no cycle detection for nested `Implementation::Network` references. Cyclic references can recurse indefinitely and... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=ae49d7d5-745b-436e-933d-20413f43b4fe -->
<!-- cubic:review-run=534964ba-7b79-40e1-8179-630624ebe73e -->
<!-- metadata:{"confidence":8} -->
P2: Unchecked `usize -> u32` cast can truncate import indices and bind to the wrong import slot. Convert with `try_into()` and fail conversion on overflow.
<details>
<... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/from_runtime.rs b/document/graph-storage/src/from_runtime.rs
new file mode 100644
index 0000000000..0c2cd26f41
--- /dev/null
+++ b/document/graph-storage/src/from_runtime.rs
@@ -0,0 +1,573 @@
+use std::collections::HashMap;
+
+use core_types::Context;
+use core_types::context::Co... | [
"document/graph-storage/src/from_runtime.rs"
] | [
{
"comment": "<!-- cubic:v=ae49d7d5-745b-436e-933d-20413f43b4fe -->\n<!-- cubic:review-run=534964ba-7b79-40e1-8179-630624ebe73e -->\n<!-- metadata:{\"confidence\":8} -->\nP2: Unchecked `usize -> u32` cast can truncate import indices and bind to the wrong import slot. Convert with `try_into()` and fail conversio... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=b1d33d77-0e95-4589-b353-0998cf1a46a8 -->
<!-- cubic:review-run=534964ba-7b79-40e1-8179-630624ebe73e -->
<!-- metadata:{"confidence":8} -->
P2: Unchecked `usize -> u32` cast can truncate large output indices and corrupt node wiring. Use checked conversion and return `ConversionError` on overflow.
<details>... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/from_runtime.rs b/document/graph-storage/src/from_runtime.rs
new file mode 100644
index 0000000000..0c2cd26f41
--- /dev/null
+++ b/document/graph-storage/src/from_runtime.rs
@@ -0,0 +1,573 @@
+use std::collections::HashMap;
+
+use core_types::Context;
+use core_types::context::Co... | [
"document/graph-storage/src/from_runtime.rs"
] | [
{
"comment": "<!-- cubic:v=b1d33d77-0e95-4589-b353-0998cf1a46a8 -->\n<!-- cubic:review-run=534964ba-7b79-40e1-8179-630624ebe73e -->\n<!-- metadata:{\"confidence\":8} -->\nP2: Unchecked `usize -> u32` cast can truncate large output indices and corrupt node wiring. Use checked conversion and return `ConversionErr... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=fdd9c59b-51af-4303-98e9-30dbecd3208d -->
<!-- cubic:review-run=534964ba-7b79-40e1-8179-630624ebe73e -->
<!-- metadata:{"confidence":8} -->
P2: `unreachable!()` on `NodeInput::Other` can crash conversion on unexpected input. Return a `ConversionError` instead of panicking.
<details>
<summary>Prompt for AI ... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/to_runtime.rs b/document/graph-storage/src/to_runtime.rs
new file mode 100644
index 0000000000..d9f19852ae
--- /dev/null
+++ b/document/graph-storage/src/to_runtime.rs
@@ -0,0 +1,380 @@
+use std::borrow::Cow;
+use std::collections::HashMap;
+
+use core_types::memo::MemoHash;
+use... | [
"document/graph-storage/src/to_runtime.rs"
] | [
{
"comment": "<!-- cubic:v=fdd9c59b-51af-4303-98e9-30dbecd3208d -->\n<!-- cubic:review-run=534964ba-7b79-40e1-8179-630624ebe73e -->\n<!-- metadata:{\"confidence\":8} -->\nP2: `unreachable!()` on `NodeInput::Other` can crash conversion on unexpected input. Return a `ConversionError` instead of panicking.\n\n<det... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=ed1de671-1474-4c0e-91be-178bf1627202 -->
<!-- cubic:review-run=534964ba-7b79-40e1-8179-630624ebe73e -->
<!-- metadata:{"confidence":9} -->
P3: The `apply_op` doc comment says missing structural targets error, but remove ops currently no-op when absent. Update the comment (or behavior) so callers are not mi... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/document.rs b/document/graph-storage/src/document.rs
new file mode 100644
index 0000000000..d93bc9a032
--- /dev/null
+++ b/document/graph-storage/src/document.rs
@@ -0,0 +1,459 @@
+use crate::{
+ CrdtError, Delta, ExportSlot, HotOp, LamportClock, MAX_EXPORT_SLOTS, NetworkId, Node... | [
"document/graph-storage/src/document.rs"
] | [
{
"comment": "<!-- cubic:v=ed1de671-1474-4c0e-91be-178bf1627202 -->\n<!-- cubic:review-run=534964ba-7b79-40e1-8179-630624ebe73e -->\n<!-- metadata:{\"confidence\":9} -->\nP3: The `apply_op` doc comment says missing structural targets error, but remove ops currently no-op when absent. Update the comment (or beha... | true | ||
GraphiteEditor/Graphite | 1,623 | issue_to_patch | Fix Freehand tool extending after transforming the path | Closes https://github.com/GraphiteEditor/Graphite/pull/1594#issuecomment-1951450238
| 70dce1c2301effff7361d9f01f49b78402840f9c | ebc2d6cf7b5ab203ebd6aa20519faabda686e776 | diff --git a/editor/src/messages/tool/tool_messages/freehand_tool.rs b/editor/src/messages/tool/tool_messages/freehand_tool.rs
index 0908f5e60d..47a83d3ea7 100644
--- a/editor/src/messages/tool/tool_messages/freehand_tool.rs
+++ b/editor/src/messages/tool/tool_messages/freehand_tool.rs
@@ -216,17 +216,13 @@ impl Fsm fo... | [
"editor/src/messages/tool/tool_messages/freehand_tool.rs"
] | [] | true | ||
GraphiteEditor/Graphite | 1,479 | issue_to_patch | Add a View > Rulers toggle to disable rulers
You will store the rulers enabled/disabled status next to `pub view_mode: ViewMode,` in `document_message_handler.rs`, as a boolean called `rulers_visible: bool,`.
Then you need to add a `DocumentMessage` message and its handler which enables/disables that, you can call ... | Add option to toggle ruler visibility | Closes #1416
I added the menu, and made it send message to frontend to conditionally render the rulers element in svelte. I am using UpdateDocumentRuler and sending visible which is updated to rulersVisible. It works as intended but the markings and text is not being displayed. Here, as far as I know, the values nece... | 4fdf8410cf31e0a792d701e3c5c5153daeb0141c | 4cddea5682d64c0bf54492597c2faa35028a3011 | diff --git a/editor/src/messages/frontend/frontend_message.rs b/editor/src/messages/frontend/frontend_message.rs
index ea04e0ae20..30cff95c35 100644
--- a/editor/src/messages/frontend/frontend_message.rs
+++ b/editor/src/messages/frontend/frontend_message.rs
@@ -173,6 +173,7 @@ pub enum FrontendMessage {
origin: (f6... | [
"editor/src/messages/frontend/frontend_message.rs",
"editor/src/messages/input_mapper/default_mapping.rs",
"editor/src/messages/portfolio/document/document_message_handler.rs",
"editor/src/messages/portfolio/menu_bar/menu_bar_message_handler.rs",
"editor/src/messages/portfolio/portfolio_message.rs",
"edit... | [
{
"comment": "This file can be removed (I presume it was accidentally added).",
"path": "package-lock.json",
"hunk": "@@ -0,0 +1,6 @@\n+{\n+\t\"name\": \"Graphite\",\n+\t\"lockfileVersion\": 3,\n+\t\"requires\": true,\n+\t\"packages\": {}\n+}",
"resolving_sha": "4cddea5682d64c0bf54492597c2faa35028a3... | true | |
GraphiteEditor/Graphite | 1,052 | issue_to_patch | Fix file paths mentioned in website's Contribute page | ### File path updates
Rust translation layer:
Editor `FrontendMessage` handler:
Rust... | 8eeeb1893893861e393a963414f0830cab00b798 | 37a06745eca3821fc5c221984e41d260c5b50d07 | diff --git a/website/content/contribute/_index.md b/website/content/contribute/_index.md
index 06cdd22a79..4edd0f7c69 100644
--- a/website/content/contribute/_index.md
+++ b/website/content/contribute/_index.md
@@ -68,9 +68,9 @@ The Editor's frontend web code lives in `/frontend/src` and the backend Rust cod
### Fro... | [
"website/content/contribute/_index.md"
] | [
{
"comment": "```suggestion\r\nBackend (Rust) -> frontend (JS) communication happens by sending a queue of messages to the frontend message dispatcher. After the JS calls any wrapper API function to get into backend (Rust) code execution, the Editor's business logic runs and queues up `FrontendMessage`s (define... | true | ||
GraphiteEditor/Graphite | 1,052 | comment_to_fix | Fix file paths mentioned in website's Contribute page | ```suggestion
Backend (Rust) -> frontend (JS) communication happens by sending a queue of messages to the frontend message dispatcher. After the JS calls any wrapper API function to get into backend (Rust) code execution, the Editor's business logic runs and queues up `FrontendMessage`s (defined in `/editor/src/messag... | 8eeeb1893893861e393a963414f0830cab00b798 | 37a06745eca3821fc5c221984e41d260c5b50d07 | diff --git a/website/content/contribute/_index.md b/website/content/contribute/_index.md
index 06cdd22a79..4edd0f7c69 100644
--- a/website/content/contribute/_index.md
+++ b/website/content/contribute/_index.md
@@ -68,9 +68,9 @@ The Editor's frontend web code lives in `/frontend/src` and the backend Rust cod
### Fro... | [
"website/content/contribute/_index.md"
] | [
{
"comment": "```suggestion\r\nBackend (Rust) -> frontend (JS) communication happens by sending a queue of messages to the frontend message dispatcher. After the JS calls any wrapper API function to get into backend (Rust) code execution, the Editor's business logic runs and queues up `FrontendMessage`s (define... | true | ||
GraphiteEditor/Graphite | 3,568 | issue_to_patch | Tracking Issue: Code quality refactors
## Match statements
Some files contain a single match statement that are very long (e.g. portfolio 1356 lines, document 1335 lines, select 1070, path 799). This is rather hard to manage or debug.
- Split message handlers
- Move complex logic outside of the match statement
## Clo... | Clean up DocumentMessageHandler by breaking out several lengthy handlers into helper functions | Partly closes #2740
This PR addresses the "Match statements" section of the tracking issue by extracting three large match arms from `process_message()` into dedicated helper methods.
### Changes
Extracted the following helper methods in `DocumentMessageHandler`:
| Method | Lines Extracted | Purpose |
|--... | 3571c0d5772b22ec75d81cc3d0d7bc4e879a53a2 | 29636894a1991c777ae7ff6a6c6f3c2a3ea93dc4 | diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs
index 1d83c08809..461e443a35 100644
--- a/editor/src/messages/portfolio/document/document_message_handler.rs
+++ b/editor/src/messages/portfolio/document/document_message_... | [
"editor/src/messages/portfolio/document/document_message_handler.rs"
] | [] | true | |
GraphiteEditor/Graphite | 2,182 | issue_to_patch | Snake-like wires in the node graph
Wires between nodes currently follow bendy, angled curves:
We want to redesign this style of curvature so it follows only right-angle horizontal and vertical paths:
![capture](https:/... | Add the style of right-angle grid-aligned wires in the graph | This PR represents an initial attempt to address [closes #2170], specifically focusing implementing the first part of the issue :
The wires follow only right-angle horizontal and vertical paths.
The corners have been rounded.
Remaining work:
Producing a final algorithm that avoids overlapping nodes and other w... | 2d90bb0cbf6925ca23d344ca61b3b7605cd12a09 | f23f7ab283155a7b9322aeebd2bda47643530660 | diff --git a/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs b/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs
index a4b13e70fb..8c0df6d42c 100644
--- a/editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs
+++ b/edito... | [
"editor/src/messages/dialog/preferences_dialog/preferences_dialog_message_handler.rs",
"editor/src/messages/frontend/frontend_message.rs",
"editor/src/messages/portfolio/document/document_message_handler.rs",
"editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs",
"editor/src/mess... | [] | true | |
GraphiteEditor/Graphite | 1,731 | issue_to_patch | Add alpha to Extract Channel node and remove Extract Alpha node | <!-- Please reference any relevant issue number below, optionally with a "Closes"/"Resolves"/"Fixes" prefix -->
From `#code-todo-list` ([link](https://discord.com/channels/731730685944922173/881073965047636018/1214825672678309918)):
> `ExtractAlphaNode` shouldn't exist, it should be combined into `ExtractChannelN... | 438c45eb802e75e41aad5ce0ab055c006563a334 | fa5a2f87ffd830f9e3b5a5784a6edce777439220 | diff --git a/editor/src/messages/portfolio/document/node_graph/document_node_types.rs b/editor/src/messages/portfolio/document/node_graph/document_node_types.rs
index 93dcd47cd7..4a8ffc627e 100644
--- a/editor/src/messages/portfolio/document/node_graph/document_node_types.rs
+++ b/editor/src/messages/portfolio/document... | [
"editor/src/messages/portfolio/document/node_graph/document_node_types.rs",
"editor/src/messages/portfolio/document/node_graph/node_properties.rs",
"node-graph/gcore/src/raster/adjustments.rs",
"node-graph/graph-craft/src/document/value.rs",
"node-graph/interpreted-executor/src/node_registry.rs"
] | [] | true | ||
GraphiteEditor/Graphite | 1,691 | issue_to_patch | Refresh node graph when changing tabs
Currently if you open the node graph (node graph button in the top right) and then switch document tabs, the node graph will not update to reflect the new document until the document is interacted with. See `PortfolioMessage::SelectDocument` and `NodeGraphMessage::SendGraph`. | Refresh graph view overlay if it's open when switching documents |
Closes #1677
| 5bca931813e456e2f6035844c21e77ee590b7728 | 06a8e81c41e117aec74f00885cc674816c5f9bd0 | diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs
index 15c9958acb..b8873247a7 100644
--- a/editor/src/messages/portfolio/document/document_message_handler.rs
+++ b/editor/src/messages/portfolio/document/document_message_... | [
"editor/src/messages/portfolio/document/document_message_handler.rs",
"editor/src/messages/portfolio/portfolio_message_handler.rs"
] | [
{
"comment": "Small nitpick: please add a blank line above this.",
"path": "editor/src/messages/portfolio/document/document_message_handler.rs",
"hunk": "@@ -1125,6 +1125,9 @@ impl DocumentMessageHandler {\n \tpub fn is_saved(&self) -> bool {\n \t\tself.current_hash() == self.saved_hash\n \t}\n+\tpub fn... | true | |
GraphiteEditor/Graphite | 1,691 | comment_to_fix | Refresh graph view overlay if it's open when switching documents | Small nitpick: please add a blank line above this. | 5bca931813e456e2f6035844c21e77ee590b7728 | 06a8e81c41e117aec74f00885cc674816c5f9bd0 | diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs
index 15c9958acb..b8873247a7 100644
--- a/editor/src/messages/portfolio/document/document_message_handler.rs
+++ b/editor/src/messages/portfolio/document/document_message_... | [
"editor/src/messages/portfolio/document/document_message_handler.rs"
] | [
{
"comment": "Small nitpick: please add a blank line above this.",
"path": "editor/src/messages/portfolio/document/document_message_handler.rs",
"hunk": "@@ -1125,6 +1125,9 @@ impl DocumentMessageHandler {\n \tpub fn is_saved(&self) -> bool {\n \t\tself.current_hash() == self.saved_hash\n \t}\n+\tpub fn... | true | ||
GraphiteEditor/Graphite | 1,691 | comment_to_fix | Refresh graph view overlay if it's open when switching documents | This name is confusing, I'd recommend `node_graph_open`. | 5bca931813e456e2f6035844c21e77ee590b7728 | 06a8e81c41e117aec74f00885cc674816c5f9bd0 | diff --git a/editor/src/messages/portfolio/portfolio_message_handler.rs b/editor/src/messages/portfolio/portfolio_message_handler.rs
index 8c4d14e82d..5f166b8fb0 100644
--- a/editor/src/messages/portfolio/portfolio_message_handler.rs
+++ b/editor/src/messages/portfolio/portfolio_message_handler.rs
@@ -430,6 +430,7 @@ i... | [
"editor/src/messages/portfolio/portfolio_message_handler.rs"
] | [
{
"comment": "This name is confusing, I'd recommend `node_graph_open`.",
"path": "editor/src/messages/portfolio/portfolio_message_handler.rs",
"hunk": "@@ -430,13 +430,15 @@ impl MessageHandler<PortfolioMessage, (&InputPreprocessorMessageHandler, &Prefer\n \t\t\t}\n \t\t\tPortfolioMessage::SelectDocumen... | true | ||
GraphiteEditor/Graphite | 2,640 | issue_to_patch | Double-click selecting anchors in a filled region, with anchors disabled, crashes the editor
https://github.com/user-attachments/assets/4095e915-3dc7-4de4-8815-f528156046bc | Fix editor crash due to mismanaged selected points on layers | Fixes #2636
| 7a2144e31e8585c0dee22ace18f4dfbae6e9c507 | 7cae9372008d9d08e6694ed3501157aceb903285 | diff --git a/editor/src/messages/tool/common_functionality/shape_editor.rs b/editor/src/messages/tool/common_functionality/shape_editor.rs
index 62e7eb45e4..39053e93ac 100644
--- a/editor/src/messages/tool/common_functionality/shape_editor.rs
+++ b/editor/src/messages/tool/common_functionality/shape_editor.rs
@@ -44,46... | [
"editor/src/messages/tool/common_functionality/shape_editor.rs",
"editor/src/messages/tool/tool_messages/path_tool.rs"
] | [] | true | |
GraphiteEditor/Graphite | 3,285 | issue_to_patch | Exit sub network with escape
Pressing escape inside a sub network should move up one level instead of closing the node graph. | Exit sub-network via Escape key | Problem
Previously, pressing the Escape key while inside a sub-network would close the entire node graph overlay, forcing users to lose their navigation context and start over from the beginning. This was frustrating when working with deeply nested networks.
Solution
Modified the DocumentMessage::Escape handler in... | 717defb2bb08d54dbdfa84a42095fb851c454e9e | 24196aae7625e3f5bc07e719fc1fd6b544d460b6 | diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs
index 27a2d5c377..b8bb98ab6f 100644
--- a/editor/src/messages/portfolio/document/document_message_handler.rs
+++ b/editor/src/messages/portfolio/document/document_message_... | [
"editor/src/messages/portfolio/document/document_message_handler.rs"
] | [] | true | |
GraphiteEditor/Graphite | 1,078 | issue_to_patch | Crash with zero scale
# Steps
- Open latest build https://dev.graphite.rs/
- Draw a rectangle
- Set the scale or dimensions to 0 in the properties panel by typing in the input field
- Confirm with enter
- Type a new number into the dimensions or scale field and press enter.
- `panicked at 'tried to transform poi... | Fix crash when scaling something with 0 width or height | Avoided the crash and resolved NaN present in property panel when trying to change zero scale to some other value.
Closes #1043
| eac301d6f0e7ff2cf6808c291c52b963758a5d0c | 081953706e7d1e2b67679a9d399ff128634c3fee | diff --git a/document-legacy/src/layers/shape_layer.rs b/document-legacy/src/layers/shape_layer.rs
index 48873ba3d7..43236f7c37 100644
--- a/document-legacy/src/layers/shape_layer.rs
+++ b/document-legacy/src/layers/shape_layer.rs
@@ -59,7 +59,7 @@ impl LayerData for ShapeLayer {
fn bounding_box(&self, transform: g... | [
"document-legacy/src/layers/shape_layer.rs",
"editor/src/messages/portfolio/document/properties_panel/utility_functions.rs"
] | [] | true | |
GraphiteEditor/Graphite | 2,052 | issue_to_patch | When editing text in the viewport, hitting Escape seems to delete all the text
When editing text using the text tool, in the viewport, pressing Escape seems to delete the text and the text disappears.
Desired behavior is for the Escape button to function the same as rmb when using the text tool.
[Discord thread he... | Fix Text tool clearing text when hitting Escape by changing it to commit the edit instead | Closes #2051
Text tool escape input now sends CommitText instead of abort.
| 79408fc0ccb596ff6eb02c0fc19cf08431bd098d | ba654838d1ded026ef51053f0dd151333c26f2c6 | diff --git a/editor/src/messages/input_mapper/input_mappings.rs b/editor/src/messages/input_mapper/input_mappings.rs
index bccaadef53..5b2c759aeb 100644
--- a/editor/src/messages/input_mapper/input_mappings.rs
+++ b/editor/src/messages/input_mapper/input_mappings.rs
@@ -151,7 +151,7 @@ pub fn input_mappings() -> Mappin... | [
"editor/src/messages/input_mapper/input_mappings.rs",
"editor/src/messages/tool/tool_messages/text_tool.rs"
] | [] | true | |
GraphiteEditor/Graphite | 43 | issue_to_patch | Implement update_colors | 27e7332e3f77af6ffee74f9ca537e671bcfdaf40 | fdf9d2c11c8d3e48cf9c90ddf0a24ceb1dc0477c | diff --git a/client/web/wasm/src/viewport.rs b/client/web/wasm/src/viewport.rs
index 6deaa21505..2eaabbb98b 100644
--- a/client/web/wasm/src/viewport.rs
+++ b/client/web/wasm/src/viewport.rs
@@ -24,5 +24,7 @@ pub fn on_mouse_move(x: u32, y: u32) {
/// Update working colors
#[wasm_bindgen]
pub fn update_colors(primar... | [
"client/web/wasm/src/viewport.rs",
"client/web/wasm/src/wrappers.rs",
"core/editor/src/tools/mod.rs"
] | [] | true | |||
GraphiteEditor/Graphite | 2,307 | issue_to_patch | New node: Merge by Distance | Here's a patch that adds a new node to collapse segments with chord shorter than a distance (parameter to the node). It's not finished but this version works - I tried it out by drawing freehand then watching the segments collapse as the distance increases.
Things still to do:
- [x] Also move bezier control point... | 2d1837882355a84b2fe58d6c1991433856dd466a | 9a96551b6bd601b9f91249c611a44147350ae982 | diff --git a/Cargo.lock b/Cargo.lock
index df363e2164..830d8ac025 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1751,6 +1751,12 @@ version = "0.4.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "0ce7134b9999ecaf8bcd65542e436736ef32ddca1b3e06094cb6ec5755203b80"
+[[package]]
+name = "fix... | [
"Cargo.lock",
"Cargo.toml",
"node-graph/gcore/Cargo.toml",
"node-graph/gcore/src/vector/algorithms/merge_by_distance.rs",
"node-graph/gcore/src/vector/algorithms/mod.rs",
"node-graph/gcore/src/vector/mod.rs",
"node-graph/gcore/src/vector/vector_data.rs",
"node-graph/gcore/src/vector/vector_data/attrib... | [
{
"comment": "TODO this is dead and will be removed",
"path": "node-graph/gcore/src/vector/vector_data/attributes.rs",
"hunk": "@@ -149,6 +152,15 @@ impl PointDomain {\n \t\tself.positions[index] = position;\n \t}\n \n+\tpub fn set_position_by_id(&mut self, id: PointId, position: DVec2) {",
"resolvi... | true | ||
GraphiteEditor/Graphite | 2,307 | comment_to_fix | New node: Merge by Distance | TODO this is dead and will be removed | 2d1837882355a84b2fe58d6c1991433856dd466a | 9a96551b6bd601b9f91249c611a44147350ae982 | diff --git a/node-graph/gcore/src/vector/vector_data/attributes.rs b/node-graph/gcore/src/vector/vector_data/attributes.rs
index 57c5289f8a..bb7ed2ae88 100644
--- a/node-graph/gcore/src/vector/vector_data/attributes.rs
+++ b/node-graph/gcore/src/vector/vector_data/attributes.rs
@@ -1,4 +1,6 @@
use crate::vector::vecto... | [
"node-graph/gcore/src/vector/vector_data/attributes.rs"
] | [
{
"comment": "TODO this is dead and will be removed",
"path": "node-graph/gcore/src/vector/vector_data/attributes.rs",
"hunk": "@@ -149,6 +152,15 @@ impl PointDomain {\n \t\tself.positions[index] = position;\n \t}\n \n+\tpub fn set_position_by_id(&mut self, id: PointId, position: DVec2) {",
"resolvi... | true | ||
GraphiteEditor/Graphite | 2,307 | comment_to_fix | New node: Merge by Distance | TODO also remove this dead code | 2d1837882355a84b2fe58d6c1991433856dd466a | 9a96551b6bd601b9f91249c611a44147350ae982 | diff --git a/node-graph/gcore/src/vector/vector_data/attributes.rs b/node-graph/gcore/src/vector/vector_data/attributes.rs
index 57c5289f8a..bb7ed2ae88 100644
--- a/node-graph/gcore/src/vector/vector_data/attributes.rs
+++ b/node-graph/gcore/src/vector/vector_data/attributes.rs
@@ -1,4 +1,6 @@
use crate::vector::vecto... | [
"node-graph/gcore/src/vector/vector_data/attributes.rs"
] | [
{
"comment": "TODO also remove this dead code",
"path": "node-graph/gcore/src/vector/vector_data/attributes.rs",
"hunk": "@@ -504,6 +542,12 @@ impl RegionDomain {\n \t}\n }\n \n+pub struct Region {",
"resolving_sha": "9a96551b6bd601b9f91249c611a44147350ae982",
"resolving_diff": "diff --git a/nod... | true | ||
GraphiteEditor/Graphite | 2,307 | comment_to_fix | New node: Merge by Distance | TODO remove | 2d1837882355a84b2fe58d6c1991433856dd466a | 9a96551b6bd601b9f91249c611a44147350ae982 | diff --git a/node-graph/gcore/src/vector/vector_data/attributes.rs b/node-graph/gcore/src/vector/vector_data/attributes.rs
index 57c5289f8a..bb7ed2ae88 100644
--- a/node-graph/gcore/src/vector/vector_data/attributes.rs
+++ b/node-graph/gcore/src/vector/vector_data/attributes.rs
@@ -1,4 +1,6 @@
use crate::vector::vecto... | [
"node-graph/gcore/src/vector/vector_data/attributes.rs"
] | [
{
"comment": "TODO remove",
"path": "node-graph/gcore/src/vector/vector_data/attributes.rs",
"hunk": "@@ -653,6 +697,13 @@ impl VectorData {\n \t\tself.segment_domain.map_ids(&id_map);\n \t\tself.region_domain.map_ids(&id_map);\n \t}\n+",
"resolving_sha": "9a96551b6bd601b9f91249c611a44147350ae982",
... | true | ||
GraphiteEditor/Graphite | 2,307 | comment_to_fix | New node: Merge by Distance | Comment out of date | 2d1837882355a84b2fe58d6c1991433856dd466a | 9a96551b6bd601b9f91249c611a44147350ae982 | diff --git a/node-graph/gcore/src/vector/vector_data/indexed.rs b/node-graph/gcore/src/vector/vector_data/indexed.rs
new file mode 100644
index 0000000000..e3e1c3cdf9
--- /dev/null
+++ b/node-graph/gcore/src/vector/vector_data/indexed.rs
@@ -0,0 +1,90 @@
+use super::{PointId, SegmentId, VectorData};
+use glam::DVec2;
+... | [
"node-graph/gcore/src/vector/vector_data/indexed.rs"
] | [
{
"comment": "Comment out of date",
"path": "node-graph/gcore/src/vector/vector_data/indexed.rs",
"hunk": "@@ -0,0 +1,146 @@\n+use std::borrow::Cow;\n+\n+use bezier_rs::BezierHandles;\n+use glam::DVec2;\n+use petgraph::graph::{EdgeIndex, NodeIndex, UnGraph};\n+use rustc_hash::FxHashMap;\n+\n+use super::... | true | ||
GraphiteEditor/Graphite | 2,307 | comment_to_fix | New node: Merge by Distance | Not all fields are used here. They would be useful in other contexts - TODO consider whether to delete or not. | 2d1837882355a84b2fe58d6c1991433856dd466a | 9a96551b6bd601b9f91249c611a44147350ae982 | diff --git a/node-graph/gcore/src/vector/vector_data/indexed.rs b/node-graph/gcore/src/vector/vector_data/indexed.rs
new file mode 100644
index 0000000000..e3e1c3cdf9
--- /dev/null
+++ b/node-graph/gcore/src/vector/vector_data/indexed.rs
@@ -0,0 +1,90 @@
+use super::{PointId, SegmentId, VectorData};
+use glam::DVec2;
+... | [
"node-graph/gcore/src/vector/vector_data/indexed.rs"
] | [
{
"comment": "Not all fields are used here. They would be useful in other contexts - TODO consider whether to delete or not.",
"path": "node-graph/gcore/src/vector/vector_data/indexed.rs",
"hunk": "@@ -0,0 +1,146 @@\n+use std::borrow::Cow;\n+\n+use bezier_rs::BezierHandles;\n+use glam::DVec2;\n+use petg... | true | ||
GraphiteEditor/Graphite | 1,860 | issue_to_patch | Fix spelling in several code comments | e1df23c28e96907c57b6067c51153c512db6289e | e1c734a3bcb8afe0c1aa7aaa2e93f7f2d96f5a5b | diff --git a/node-graph/gcore/src/raster/adjustments.rs b/node-graph/gcore/src/raster/adjustments.rs
index 4b511d3ddd..968bccec82 100644
--- a/node-graph/gcore/src/raster/adjustments.rs
+++ b/node-graph/gcore/src/raster/adjustments.rs
@@ -1083,7 +1083,7 @@ fn selective_color_node(
.into_iter()
.fold((0., 0., 0.), |... | [
"node-graph/gcore/src/raster/adjustments.rs",
"node-graph/gcore/src/transform.rs",
"node-graph/gcore/src/vector/vector_data/attributes.rs",
"node-graph/gcore/src/vector/vector_nodes.rs"
] | [
{
"comment": "Revert",
"path": "website/content/features.md",
"hunk": "@@ -247,7 +247,7 @@ Always on the bleeding edge and built to last— Graphite is written on a robust\n \t\t</div>\n \t\t<div class=\"feature-icon\">\n \t\t\t<img class=\"atlas\" style=\"--atlas-index: 25\" src=\"https://static.graphite... | true | |||
GraphiteEditor/Graphite | 1,214 | issue_to_patch | Curves image adjustment node | cfe38c6413f6bb6e28bacf9a72d9fe2aad0b90a3 | a7d8bb108669c0bb64d78583a055d4058a42203b | diff --git a/editor/src/messages/layout/layout_message_handler.rs b/editor/src/messages/layout/layout_message_handler.rs
index 8b3d1fc28e..f32f3bc4b8 100644
--- a/editor/src/messages/layout/layout_message_handler.rs
+++ b/editor/src/messages/layout/layout_message_handler.rs
@@ -123,6 +123,12 @@ impl<F: Fn(&MessageDiscr... | [
"editor/src/messages/layout/layout_message_handler.rs",
"editor/src/messages/layout/utility_types/layout_widget.rs",
"editor/src/messages/layout/utility_types/widgets/input_widgets.rs",
"editor/src/messages/portfolio/document/node_graph/graph_operation_message_handler/transform_utils.rs",
"editor/src/messag... | [] | true | |||
GraphiteEditor/Graphite | 1,082 | issue_to_patch | Bezier-rs: Add lookup table function for subpath and make it support euclidean parameterization | <!-- Please reference any relevant issue number below, optionally with a "Closes"/"Resolves"/"Fixes" prefix -->
Added `compute_lookup_table` to subpath class.
Added `tvalue_type: Option<TValueType>` to `compute_lookup_table` in both bezier and subpath classes which allows computation based on euclidean distances rath... | 508726d73ffc53e544bea976f1b32a76a0a3399b | ad2b0f6eeb7bc0461116f5d424d45b580951d97a | diff --git a/editor/src/messages/tool/common_functionality/shape_editor.rs b/editor/src/messages/tool/common_functionality/shape_editor.rs
index 6407c8d68e..1034fae195 100644
--- a/editor/src/messages/tool/common_functionality/shape_editor.rs
+++ b/editor/src/messages/tool/common_functionality/shape_editor.rs
@@ -375,7... | [
"editor/src/messages/tool/common_functionality/shape_editor.rs",
"libraries/bezier-rs/src/bezier/lookup.rs",
"libraries/bezier-rs/src/bezier/transform.rs",
"libraries/bezier-rs/src/lib.rs",
"libraries/bezier-rs/src/subpath/lookup.rs",
"libraries/bezier-rs/src/utils.rs",
"website/other/bezier-rs-demos/sr... | [] | true | ||
GraphiteEditor/Graphite | 337 | issue_to_patch | Clicking on menu bar sub-menu entries doesn't work
In `MenuList.vue`, the `@click="handleEntryClick(entry)"` is never called on sub-menu entries (such as *File* > *Open Recent*). It instead gets stuck in a state where it thinks we have a floating menu open. | Fixes clicking on menu bar sub-menu entries | Previously the parent menu would close on MouseDown, before the Click event could trigger on submenu items. This fix involves ensuring that the parent menu stays open as long as the cursor remains on any of its sub-menus.
Fixes #280
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/revie... | 67dc9f57ba30af93d3f2689d8241ff304adf4bbc | a264d144253b4f47b1f5202d334057554021911e | diff --git a/frontend/src/components/widgets/floating-menus/FloatingMenu.vue b/frontend/src/components/widgets/floating-menus/FloatingMenu.vue
index 02218b3e18..322ee99821 100644
--- a/frontend/src/components/widgets/floating-menus/FloatingMenu.vue
+++ b/frontend/src/components/widgets/floating-menus/FloatingMenu.vue
@... | [
"frontend/src/components/widgets/floating-menus/FloatingMenu.vue"
] | [] | true | |
GraphiteEditor/Graphite | 1,650 | issue_to_patch | Solidify stroke node
Convert `outline` (from #1083) in bezier-rs into a node. And as a bonus, add a button to the options bar of the Select tool for this node to be inserted at the appropriate place in the graph for the selected vector layer(s) when clicked. | New node: Solidify Stroke | This node can be added after a stroke node in a set of vector data. Upon doing so, it will account for the stroke's shape and add it to the vector data. The stroke will be treated as a solid part of the shape or line segment. Both closed shapes and line segments are supported.
Closes #1092 | c3a886116aa3a17f205496a7928d207b938c9818 | 7eac88e2bc4fc2c71a600996edda3cba0714d3aa | diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs b/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs
index 037b1a917d..ea2e3b3d13 100644
--- a/editor/src/messages/portfolio/document/node_graph/node_graph_me... | [
"editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs",
"node-graph/gcore/src/vector/style.rs",
"node-graph/gcore/src/vector/vector_nodes.rs",
"node-graph/interpreted-executor/src/node_registry.rs"
] | [] | true | |
GraphiteEditor/Graphite | 2,110 | issue_to_patch | Smarter placement of layers into the artboards that bound them
Currently, new layers are drawn, they are placed into the last selected artboard.
To improve upon this, we want:
- [x] Placing layers in correct artboard based on its location within the bounds of any artboard (#2110)
- [ ] Transferring layers between ar... | Automatically place layers into the artboard they're drawn inside of | Partly closes #1507
| 337b8bad13cb7920bc9551bf872c651c45f77bd0 | 3bcefafe426f84381a435a7b239d3f9a9f995e8e | diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs
index 502438fc3b..9131341cee 100644
--- a/editor/src/messages/portfolio/document/document_message_handler.rs
+++ b/editor/src/messages/portfolio/document/document_message_... | [
"editor/src/messages/portfolio/document/document_message_handler.rs",
"editor/src/messages/tool/tool_messages/ellipse_tool.rs",
"editor/src/messages/tool/tool_messages/freehand_tool.rs",
"editor/src/messages/tool/tool_messages/line_tool.rs",
"editor/src/messages/tool/tool_messages/pen_tool.rs",
"editor/sr... | [] | true | |
GraphiteEditor/Graphite | 1,434 | issue_to_patch | Change Brightness/Contrast node implementation to reuse Curves node
Brightness/Contrast and Curves repeat a lot of code. This cleanup involves changing the Brightness/Contrast node so it acts as a document node wrapping the Brightness/Contrast node whilst providing it the necessary input parameters. Care should be tak... | Reimplement Brightness/Contrast node using the Curves node to reduce code | <!-- Please reference any relevant issue number below, optionally with a "Closes"/"Resolves"/"Fixes" prefix -->
Closes #1387
| 380bc19b09e3d13120a837804871237008289433 | 24f78cdf104d2fdbac01b5e6a876a2f176e0ad3f | diff --git a/node-graph/gcore/src/raster/brightness_contrast.rs b/node-graph/gcore/src/raster/brightness_contrast.rs
index 1be131daf6..cdcf886b92 100644
--- a/node-graph/gcore/src/raster/brightness_contrast.rs
+++ b/node-graph/gcore/src/raster/brightness_contrast.rs
@@ -1,3 +1,4 @@
+use crate::raster::curve::CubicSplin... | [
"node-graph/gcore/src/raster/brightness_contrast.rs"
] | [] | true | |
GraphiteEditor/Graphite | 1,399 | issue_to_patch | New nodes: Logical boolean operations (OR, AND, XOR, NOT) | Adds these boolean operator nodes:
- Not
- And
- OR
- XOR | 48fdaddc37b8123348d412ee67288bbaf81607bf | c5799da97b1518ee72dc9930b88e04df7f84cf4b | diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs b/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs
index f3d360e9eb..265219c687 100644
--- a/editor/src/messages/portfolio/document/node_graph/node_graph_me... | [
"editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs",
"editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/node_properties.rs",
"node-graph/gcore/src/logic.rs",
"node-graph/gcore/src/ops.rs",
"node-graph/interpreted-executor/src/node_... | [
{
"comment": "Thoughts on capitalisation @Keavon? They are often capitalised in logic but look slightly out of place with the other title case nodes.",
"path": "editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs",
"hunk": "@@ -1913,6 +1913,51 @@ fn static... | true | ||
GraphiteEditor/Graphite | 1,399 | comment_to_fix | New nodes: Logical boolean operations (OR, AND, XOR, NOT) | Thoughts on capitalisation @Keavon? They are often capitalised in logic but look slightly out of place with the other title case nodes. | 48fdaddc37b8123348d412ee67288bbaf81607bf | c5799da97b1518ee72dc9930b88e04df7f84cf4b | diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs b/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs
index f3d360e9eb..265219c687 100644
--- a/editor/src/messages/portfolio/document/node_graph/node_graph_me... | [
"editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs"
] | [
{
"comment": "Thoughts on capitalisation @Keavon? They are often capitalised in logic but look slightly out of place with the other title case nodes.",
"path": "editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs",
"hunk": "@@ -1913,6 +1913,51 @@ fn static... | true | ||
GraphiteEditor/Graphite | 1,399 | comment_to_fix | New nodes: Logical boolean operations (OR, AND, XOR, NOT) | We usually set the default exposed values of the second inputs to false (so the last boolean in the `DocumentInputType::value`). This means that they do not by default show up as dots in the node graph leading to reduced clutter. We probably should document this somewhere. | 48fdaddc37b8123348d412ee67288bbaf81607bf | c5799da97b1518ee72dc9930b88e04df7f84cf4b | diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs b/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs
index f3d360e9eb..265219c687 100644
--- a/editor/src/messages/portfolio/document/node_graph/node_graph_me... | [
"editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs"
] | [
{
"comment": "We usually set the default exposed values of the second inputs to false (so the last boolean in the `DocumentInputType::value`). This means that they do not by default show up as dots in the node graph leading to reduced clutter. We probably should document this somewhere.",
"path": "editor/sr... | true | ||
GraphiteEditor/Graphite | 1,399 | comment_to_fix | New nodes: Logical boolean operations (OR, AND, XOR, NOT) | Thoughts about naming "Second" here @Keavon? "Operator" is used in the properties for this and I'm wondering if we should try and be consistent with the naming? | 48fdaddc37b8123348d412ee67288bbaf81607bf | c5799da97b1518ee72dc9930b88e04df7f84cf4b | diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs b/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs
index f3d360e9eb..265219c687 100644
--- a/editor/src/messages/portfolio/document/node_graph/node_graph_me... | [
"editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs"
] | [
{
"comment": "Thoughts about naming \"Second\" here @Keavon? \"Operator\" is used in the properties for this and I'm wondering if we should try and be consistent with the naming?",
"path": "editor/src/messages/portfolio/document/node_graph/node_graph_message_handler/document_node_types.rs",
"hunk": "@@ ... | true | ||
GraphiteEditor/Graphite | 1,399 | comment_to_fix | New nodes: Logical boolean operations (OR, AND, XOR, NOT) | The function name should be `logic_xor` (it doesn't matter as it is not used anywhere - just to reduce confusion). | 48fdaddc37b8123348d412ee67288bbaf81607bf | c5799da97b1518ee72dc9930b88e04df7f84cf4b | diff --git a/node-graph/gcore/src/logic.rs b/node-graph/gcore/src/logic.rs
index 2d56e313fb..88619ae693 100644
--- a/node-graph/gcore/src/logic.rs
+++ b/node-graph/gcore/src/logic.rs
@@ -7,3 +7,37 @@ fn log_to_console<T: core::fmt::Debug>(value: T) -> T {
debug!("{:#?}", value);
value
}
+
+pub struct LogicOrNode<S... | [
"node-graph/gcore/src/logic.rs"
] | [
{
"comment": "The function name should be `logic_xor` (it doesn't matter as it is not used anywhere - just to reduce confusion).",
"path": "node-graph/gcore/src/logic.rs",
"hunk": "@@ -7,3 +7,38 @@ fn log_to_console<T: core::fmt::Debug>(value: T) -> T {\n \tdebug!(\"{:#?}\", value);\n \tvalue\n }\n+\n+p... | true | ||
GraphiteEditor/Graphite | 1,399 | comment_to_fix | New nodes: Logical boolean operations (OR, AND, XOR, NOT) | Did you mean to leave this comment in? If so, could you please add a space after the `//`? | 48fdaddc37b8123348d412ee67288bbaf81607bf | c5799da97b1518ee72dc9930b88e04df7f84cf4b | diff --git a/node-graph/gcore/src/logic.rs b/node-graph/gcore/src/logic.rs
index 2d56e313fb..88619ae693 100644
--- a/node-graph/gcore/src/logic.rs
+++ b/node-graph/gcore/src/logic.rs
@@ -7,3 +7,37 @@ fn log_to_console<T: core::fmt::Debug>(value: T) -> T {
debug!("{:#?}", value);
value
}
+
+pub struct LogicOrNode<S... | [
"node-graph/gcore/src/logic.rs"
] | [
{
"comment": "Did you mean to leave this comment in? If so, could you please add a space after the `//`?",
"path": "node-graph/gcore/src/logic.rs",
"hunk": "@@ -7,3 +7,38 @@ fn log_to_console<T: core::fmt::Debug>(value: T) -> T {\n \tdebug!(\"{:#?}\", value);\n \tvalue\n }\n+\n+pub struct LogicOrNode<Se... | true | ||
GraphiteEditor/Graphite | 1,726 | issue_to_patch | Insert duplicated layers directly above their selected source layers | Closes this message from [discord](https://discord.com/channels/731730685944922173/881073965047636018/1226707315499995156)
| e55578a01670854ed77941e84bc0f76aa9aedd1e | ee9e5ccb05a2e11385e936a4102ddc1bd544e08b | diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs
index cabadff703..8873720962 100644
--- a/editor/src/messages/portfolio/document/document_message_handler.rs
+++ b/editor/src/messages/portfolio/document/document_message_... | [
"editor/src/messages/portfolio/document/document_message_handler.rs"
] | [
{
"comment": "Since `-1` and `0` play the same role here, you may simply use `let insert_index = <...usize> as isize`.",
"path": "editor/src/messages/portfolio/document/document_message_handler.rs",
"hunk": "@@ -297,7 +297,8 @@ impl MessageHandler<DocumentMessage, DocumentMessageData<'_>> for DocumentMe... | true | ||
GraphiteEditor/Graphite | 1,726 | comment_to_fix | Insert duplicated layers directly above their selected source layers | Since `-1` and `0` play the same role here, you may simply use `let insert_index = <...usize> as isize`. | e55578a01670854ed77941e84bc0f76aa9aedd1e | ee9e5ccb05a2e11385e936a4102ddc1bd544e08b | diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs
index cabadff703..8873720962 100644
--- a/editor/src/messages/portfolio/document/document_message_handler.rs
+++ b/editor/src/messages/portfolio/document/document_message_... | [
"editor/src/messages/portfolio/document/document_message_handler.rs"
] | [
{
"comment": "Since `-1` and `0` play the same role here, you may simply use `let insert_index = <...usize> as isize`.",
"path": "editor/src/messages/portfolio/document/document_message_handler.rs",
"hunk": "@@ -297,7 +297,8 @@ impl MessageHandler<DocumentMessage, DocumentMessageData<'_>> for DocumentMe... | true | ||
GraphiteEditor/Graphite | 1,726 | comment_to_fix | Insert duplicated layers directly above their selected source layers | To insert correctly for multiple nodes in the same parent, the iterator for `layer_ancestors` should be `<...>.into_iter().rev()` in L281. | e55578a01670854ed77941e84bc0f76aa9aedd1e | ee9e5ccb05a2e11385e936a4102ddc1bd544e08b | diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs
index cabadff703..8873720962 100644
--- a/editor/src/messages/portfolio/document/document_message_handler.rs
+++ b/editor/src/messages/portfolio/document/document_message_... | [
"editor/src/messages/portfolio/document/document_message_handler.rs"
] | [
{
"comment": "To insert correctly for multiple nodes in the same parent, the iterator for `layer_ancestors` should be `<...>.into_iter().rev()` in L281.",
"path": "editor/src/messages/portfolio/document/document_message_handler.rs",
"hunk": "@@ -297,7 +297,8 @@ impl MessageHandler<DocumentMessage, Docum... | true | ||
GraphiteEditor/Graphite | 2,126 | issue_to_patch | New node: Dot Product | As mentioned by @0HyperCube on discord I have tried to write a dot product node,cross product node is left which I will write after getting feedback on mistakes I did in this one
| 1264ea8246cbb06e0602a93be983762ab17adf30 | ce3e19df322da069dcb3a2243b71269a4003e292 | diff --git a/node-graph/gcore/src/ops.rs b/node-graph/gcore/src/ops.rs
index 117053616d..807156664b 100644
--- a/node-graph/gcore/src/ops.rs
+++ b/node-graph/gcore/src/ops.rs
@@ -408,6 +408,11 @@ fn clone<'i, T: Clone + 'i>(_: (), #[implementations(&ImageFrame<Color>)] value:
value.clone()
}
+#[node_macro::node(ca... | [
"node-graph/gcore/src/ops.rs"
] | [
{
"comment": "This can be one line",
"path": "node-graph/gcore/src/ops.rs",
"hunk": "@@ -407,7 +407,11 @@ fn unwrap<T: Default>(_: (), #[implementations(Option<f64>, Option<f32>, Option<\n fn clone<'i, T: Clone + 'i>(_: (), #[implementations(&ImageFrame<Color>)] value: &'i T) -> T {\n \tvalue.clone()\n ... | true | ||
GraphiteEditor/Graphite | 2,126 | comment_to_fix | New node: Dot Product | This can be one line | 1264ea8246cbb06e0602a93be983762ab17adf30 | ce3e19df322da069dcb3a2243b71269a4003e292 | diff --git a/node-graph/gcore/src/ops.rs b/node-graph/gcore/src/ops.rs
index 117053616d..807156664b 100644
--- a/node-graph/gcore/src/ops.rs
+++ b/node-graph/gcore/src/ops.rs
@@ -408,6 +408,11 @@ fn clone<'i, T: Clone + 'i>(_: (), #[implementations(&ImageFrame<Color>)] value:
value.clone()
}
+#[node_macro::node(ca... | [
"node-graph/gcore/src/ops.rs"
] | [
{
"comment": "This can be one line",
"path": "node-graph/gcore/src/ops.rs",
"hunk": "@@ -407,7 +407,11 @@ fn unwrap<T: Default>(_: (), #[implementations(Option<f64>, Option<f32>, Option<\n fn clone<'i, T: Clone + 'i>(_: (), #[implementations(&ImageFrame<Color>)] value: &'i T) -> T {\n \tvalue.clone()\n ... | true | ||
GraphiteEditor/Graphite | 2,126 | comment_to_fix | New node: Dot Product | Please use `1.` instead of `1.0`, etc. | 1264ea8246cbb06e0602a93be983762ab17adf30 | ce3e19df322da069dcb3a2243b71269a4003e292 | diff --git a/node-graph/gcore/src/ops.rs b/node-graph/gcore/src/ops.rs
index 117053616d..807156664b 100644
--- a/node-graph/gcore/src/ops.rs
+++ b/node-graph/gcore/src/ops.rs
@@ -408,6 +408,11 @@ fn clone<'i, T: Clone + 'i>(_: (), #[implementations(&ImageFrame<Color>)] value:
value.clone()
}
+#[node_macro::node(ca... | [
"node-graph/gcore/src/ops.rs"
] | [
{
"comment": "Please use `1.` instead of `1.0`, etc.",
"path": "node-graph/gcore/src/ops.rs",
"hunk": "@@ -476,4 +480,11 @@ mod test {\n \t\tlet fnn = FnNode::new(|(a, b)| (b, a));\n \t\tassert_eq!(fnn.eval((1u32, 2u32)), (2, 1));\n \t}\n+\n+\t#[test]\n+\tpub fn dot_product_function() {\n+\t\tlet vector... | true | ||
GraphiteEditor/Graphite | 2,126 | comment_to_fix | New node: Dot Product | The cross product is not the same as the perpendicular dot product. The cross product is only defined for 3 and 7 dimensions. Would it be possible to rename the node? Thanks. | 1264ea8246cbb06e0602a93be983762ab17adf30 | ce3e19df322da069dcb3a2243b71269a4003e292 | diff --git a/node-graph/gcore/src/ops.rs b/node-graph/gcore/src/ops.rs
index 117053616d..807156664b 100644
--- a/node-graph/gcore/src/ops.rs
+++ b/node-graph/gcore/src/ops.rs
@@ -408,6 +408,11 @@ fn clone<'i, T: Clone + 'i>(_: (), #[implementations(&ImageFrame<Color>)] value:
value.clone()
}
+#[node_macro::node(ca... | [
"node-graph/gcore/src/ops.rs"
] | [
{
"comment": "The cross product is not the same as the perpendicular dot product. The cross product is only defined for 3 and 7 dimensions. Would it be possible to rename the node? Thanks.",
"path": "node-graph/gcore/src/ops.rs",
"hunk": "@@ -408,6 +408,16 @@ fn clone<'i, T: Clone + 'i>(_: (), #[impleme... | true | ||
GraphiteEditor/Graphite | 622 | issue_to_patch | Add a shortcut to pick a random color
This would be useful for testing and probably useful for actual art some of the time as well. Perhaps it could be added to, I'll just arbitrarily say, <kbd>Alt</kbd><kbd>C</kbd>. It would replace the primary color swatch with a randomly picked hue, saturation, and value. | Select random primary color | Hi @Keavon, I'm sorry to answer only now. I was quite busy with work lately. Here is the pull request for #549 which add the ability to select a random primary color with the shortcut Alt-c. Please tell with if anything is missing.
Closes #549
| 70ba704058f1bb9076f8c5ade69410348e62faed | b82c5721b3c2f4c4a38c59f1688f393dbf4f34cb | diff --git a/editor/src/input/input_mapper.rs b/editor/src/input/input_mapper.rs
index 715fd322c4..2bf39cfa52 100644
--- a/editor/src/input/input_mapper.rs
+++ b/editor/src/input/input_mapper.rs
@@ -142,7 +142,8 @@ impl Default for Mapping {
// Colors
entry! {action=ToolMessage::ResetColors, key_down=KeyX, modi... | [
"editor/src/input/input_mapper.rs",
"editor/src/viewport_tools/tool_message.rs",
"editor/src/viewport_tools/tool_message_handler.rs"
] | [
{
"comment": "This looks nice and clean! The one thing is that I think it would be more useful if it's always opaque, so can you please modify this so the alpha value is always 1? Thanks!",
"path": "editor/src/viewport_tools/tool_message_handler.rs",
"hunk": "@@ -103,6 +103,20 @@ impl MessageHandler<Too... | true | |
GraphiteEditor/Graphite | 1,417 | issue_to_patch | The Path tool's box selection crashes after a layer was deleted
## Describe the crash
Selecting rectangle in deleted folder causes panic
## Steps to reproduce
- Create a new document
- Create a rectangle
- Select path tool
- ~~Put rectangle in folder (CTRL-G)~~ (not necessary)
- Delete ~~folder~~ rectangle ... | Move DeleteLayer to come before SelectionChanged on DeletedSelectedLayers | Fixes #1393
Let me know if there is some other underlying issue that needs to be addressed. I'm just skipping most of the body of render_subpath_overlays if the document.generate_transform_relative_to_viewport errors (in this case, from its inability to find the deleted folder) | 5827e989dc32cd41768847ec844047cce22e4211 | fd8f5365ae60fdaa9ee3711a08686f3784e43d9d | diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs
index 2f26a8722b..bc7bd4b10f 100644
--- a/editor/src/messages/portfolio/document/document_message_handler.rs
+++ b/editor/src/messages/portfolio/document/document_message_... | [
"editor/src/messages/portfolio/document/document_message_handler.rs"
] | [
{
"comment": "This sort of works around the issue without really solving it. The core issue is that we appear to handle the `DeleteLayer` message after the `SelectionChanged` message when handling `DeleteSelectedLayers`. This means that the selection is updated before the layer is actually deleted.",
"path"... | true | |
GraphiteEditor/Graphite | 1,718 | issue_to_patch | Update contributor guide installation instructions for Fedora-based Linux OSs | bf81a31ff99ca0d71b896e4d7c98e381f875ed88 | 64a0e42af265a66fb90754a2c2ea9cc8721e8391 | diff --git a/website/content/volunteer/guide/getting-started/_index.md b/website/content/volunteer/guide/getting-started/_index.md
index 7e1ec7efd6..921e7c76f5 100644
--- a/website/content/volunteer/guide/getting-started/_index.md
+++ b/website/content/volunteer/guide/getting-started/_index.md
@@ -12,22 +12,31 @@ Graph... | [
"website/content/volunteer/guide/getting-started/_index.md"
] | [
{
"comment": "```suggestion\r\nOn Debian-based (Ubuntu, Mint, etc.) Linux distributions, you may need to install the following packages:\r\n```",
"path": "website/content/volunteer/guide/getting-started/_index.md",
"hunk": "@@ -12,22 +12,31 @@ Graphite is built with Rust and web technologies. Install th... | true | |||
GraphiteEditor/Graphite | 1,718 | comment_to_fix | Update contributor guide installation instructions for Fedora-based Linux OSs | ```suggestion
On Debian-based (Ubuntu, Mint, etc.) Linux distributions, you may need to install the following packages:
``` | bf81a31ff99ca0d71b896e4d7c98e381f875ed88 | 64a0e42af265a66fb90754a2c2ea9cc8721e8391 | diff --git a/website/content/volunteer/guide/getting-started/_index.md b/website/content/volunteer/guide/getting-started/_index.md
index 7e1ec7efd6..921e7c76f5 100644
--- a/website/content/volunteer/guide/getting-started/_index.md
+++ b/website/content/volunteer/guide/getting-started/_index.md
@@ -12,22 +12,31 @@ Graph... | [
"website/content/volunteer/guide/getting-started/_index.md"
] | [
{
"comment": "```suggestion\r\nOn Debian-based (Ubuntu, Mint, etc.) Linux distributions, you may need to install the following packages:\r\n```",
"path": "website/content/volunteer/guide/getting-started/_index.md",
"hunk": "@@ -12,22 +12,31 @@ Graphite is built with Rust and web technologies. Install th... | true | ||
GraphiteEditor/Graphite | 1,718 | comment_to_fix | Update contributor guide installation instructions for Fedora-based Linux OSs | ```suggestion
On Fedora-based (RHEL, CentOS, etc.) Linux distributions, you may need to install the following packages:
``` | bf81a31ff99ca0d71b896e4d7c98e381f875ed88 | 64a0e42af265a66fb90754a2c2ea9cc8721e8391 | diff --git a/website/content/volunteer/guide/getting-started/_index.md b/website/content/volunteer/guide/getting-started/_index.md
index 7e1ec7efd6..921e7c76f5 100644
--- a/website/content/volunteer/guide/getting-started/_index.md
+++ b/website/content/volunteer/guide/getting-started/_index.md
@@ -12,22 +12,31 @@ Graph... | [
"website/content/volunteer/guide/getting-started/_index.md"
] | [
{
"comment": "```suggestion\r\nOn Fedora-based (RHEL, CentOS, etc.) Linux distributions, you may need to install the following packages:\r\n```",
"path": "website/content/volunteer/guide/getting-started/_index.md",
"hunk": "@@ -12,22 +12,31 @@ Graphite is built with Rust and web technologies. Install th... | true | ||
GraphiteEditor/Graphite | 3,222 | issue_to_patch | Hints for G/R/S on the path tool don't show
## Reproduction
With the select tool, you can select a layer and press <kbd>G</kbd> to apply a translation to it (like in blender). At the bottom of the screen some hints show as to available operations
<img width="535" height="271" alt="Image" src="https://github.com/user... | Fix Path tool not displaying its hints during G/R/S modes | Closes #3537, also reported at https://discord.com/channels/731730685944922173/881073965047636018/1419968518086197269
Previously the path tool hints would override the hints from other operations (Eg GRS's hints would not show. This was the case for everything but the drag) It was just an order of operations issue. ... | f186465220b583606f1c5517f6c37d47e947470a | 2531ee750262a4d9123074e169ffcf3da2a47b13 | diff --git a/editor/src/messages/tool/common_functionality/shape_editor.rs b/editor/src/messages/tool/common_functionality/shape_editor.rs
index f102bbb56f..0183d65cc3 100644
--- a/editor/src/messages/tool/common_functionality/shape_editor.rs
+++ b/editor/src/messages/tool/common_functionality/shape_editor.rs
@@ -1879,... | [
"editor/src/messages/tool/common_functionality/shape_editor.rs",
"editor/src/messages/tool/tool_messages/path_tool.rs"
] | [] | true | |
GraphiteEditor/Graphite | 215 | issue_to_patch | Support for closing document tabs
Click the X button in a tab to close it. Also <kbd>Ctrl</kbd><kbd>W</kbd> closes the current tab (warning: you can't test this yet, it'll close your browser tab also). This needs a confirmation to prevent loss of work. It also needs to handle what happens when all tabs are closed, per... | Closing doc tabs | Few notes
1. Only the last tab can be cleanly closed. Because we are using tab indexes deleting from middle messes stuff up
2. Layer Panels are being updated
3. No confirmation dialog box up yet
4. Closing last tab crashes everything
Closes #211.
<!-- Reviewable:start -->
---
This change is [<img src="http... | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/client/web/src/components/workspace/Panel.vue b/client/web/src/components/workspace/Panel.vue
index dc167abf79..5b59705a3c 100644
--- a/client/web/src/components/workspace/Panel.vue
+++ b/client/web/src/components/workspace/Panel.vue
@@ -4,7 +4,7 @@
<div class="tab-group">
<div class="tab" :class=... | [
"client/web/src/components/workspace/Panel.vue",
"client/web/src/components/workspace/Workspace.vue",
"client/web/src/response-handler.ts",
"client/web/wasm/src/document.rs",
"core/editor/src/document/document_message_handler.rs",
"core/editor/src/frontend/frontend_message_handler.rs",
"core/editor/src/... | [
{
"comment": "atleat -> atleast (also we usually don't end comments with a period but that's an unimportant nitpick)\r\n\r\nI will review the rest of this later for you but I wanted to point out this typo in case I missed it on a later pass.",
"path": "core/editor/src/document/document_message_handler.rs",
... | true | |
GraphiteEditor/Graphite | 215 | comment_to_fix | Closing doc tabs | atleat -> atleast (also we usually don't end comments with a period but that's an unimportant nitpick)
I will review the rest of this later for you but I wanted to point out this typo in case I missed it on a later pass. | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/core/editor/src/document/document_message_handler.rs b/core/editor/src/document/document_message_handler.rs
index 269a1f9e4f..8247434bd8 100644
--- a/core/editor/src/document/document_message_handler.rs
+++ b/core/editor/src/document/document_message_handler.rs
@@ -17,6 +17,8 @@ pub enum DocumentMessage {
... | [
"core/editor/src/document/document_message_handler.rs"
] | [
{
"comment": "atleat -> atleast (also we usually don't end comments with a period but that's an unimportant nitpick)\r\n\r\nI will review the rest of this later for you but I wanted to point out this typo in case I missed it on a later pass.",
"path": "core/editor/src/document/document_message_handler.rs",
... | true | ||
GraphiteEditor/Graphite | 215 | comment_to_fix | Closing doc tabs | It should be safe to delete this now. | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/client/web/src/components/workspace/Panel.vue b/client/web/src/components/workspace/Panel.vue
index dc167abf79..5b59705a3c 100644
--- a/client/web/src/components/workspace/Panel.vue
+++ b/client/web/src/components/workspace/Panel.vue
@@ -4,7 +4,7 @@
<div class="tab-group">
<div class="tab" :class=... | [
"client/web/src/components/workspace/Panel.vue"
] | [
{
"comment": "It should be safe to delete this now.",
"path": "client/web/src/components/workspace/Panel.vue",
"hunk": "@@ -157,9 +158,21 @@ export default defineComponent({\n \t},\n \tmethods: {\n \t\tasync handleTabClick(tabIndex: number) {\n+\t\t\tconsole.log(`TAB IDX: ${tabIndex}`);",
"resolving... | true | ||
GraphiteEditor/Graphite | 215 | comment_to_fix | Closing doc tabs | Put this on the line above:
```
// eslint-disable-next-line no-alert
```
And let's reword the confirmation to say:
> "Closing this document will permanently discard all work. Continue?" | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/client/web/src/components/workspace/Panel.vue b/client/web/src/components/workspace/Panel.vue
index dc167abf79..5b59705a3c 100644
--- a/client/web/src/components/workspace/Panel.vue
+++ b/client/web/src/components/workspace/Panel.vue
@@ -4,7 +4,7 @@
<div class="tab-group">
<div class="tab" :class=... | [
"client/web/src/components/workspace/Panel.vue"
] | [
{
"comment": "Put this on the line above:\r\n```\r\n// eslint-disable-next-line no-alert\r\n```\r\n\r\nAnd let's reword the confirmation to say:\r\n> \"Closing this document will permanently discard all work. Continue?\"",
"path": "client/web/src/components/workspace/Panel.vue",
"hunk": "@@ -157,9 +158,... | true | ||
GraphiteEditor/Graphite | 215 | comment_to_fix | Closing doc tabs | Is this comment accurate? CI didn't include a warning here. | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/client/web/src/components/workspace/Panel.vue b/client/web/src/components/workspace/Panel.vue
index dc167abf79..5b59705a3c 100644
--- a/client/web/src/components/workspace/Panel.vue
+++ b/client/web/src/components/workspace/Panel.vue
@@ -4,7 +4,7 @@
<div class="tab-group">
<div class="tab" :class=... | [
"client/web/src/components/workspace/Panel.vue"
] | [
{
"comment": "Is this comment accurate? CI didn't include a warning here.",
"path": "client/web/src/components/workspace/Panel.vue",
"hunk": "@@ -157,9 +158,21 @@ export default defineComponent({\n \t},\n \tmethods: {\n \t\tasync handleTabClick(tabIndex: number) {\n+\t\t\tconsole.log(`TAB IDX: ${tabInde... | true | ||
GraphiteEditor/Graphite | 215 | comment_to_fix | Closing doc tabs | I think the name `PromptCloseConfirmationModal` would perhaps be clearer, but let me know if you feel otherwise. | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/client/web/src/response-handler.ts b/client/web/src/response-handler.ts
index 5f842644ad..11c05191b5 100644
--- a/client/web/src/response-handler.ts
+++ b/client/web/src/response-handler.ts
@@ -18,7 +18,9 @@ export enum ResponseType {
SetActiveTool = "SetActiveTool",
SetActiveDocument = "SetActiveDocum... | [
"client/web/src/response-handler.ts"
] | [
{
"comment": "I think the name `PromptCloseConfirmationModal` would perhaps be clearer, but let me know if you feel otherwise.",
"path": "client/web/src/response-handler.ts",
"hunk": "@@ -58,19 +60,30 @@ function parseResponse(responseType: string, data: any): Response {\n \t\t\treturn newSetActiveDocum... | true | ||
GraphiteEditor/Graphite | 215 | comment_to_fix | Closing doc tabs | Is "tool" the right name for selecting a document in this log message? You may also want to consider removing this if you're done with it, unless you think it will continue to serve a useful debugging purpose. | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/client/web/wasm/src/document.rs b/client/web/wasm/src/document.rs
index bf12008ee5..70cdf049db 100644
--- a/client/web/wasm/src/document.rs
+++ b/client/web/wasm/src/document.rs
@@ -26,6 +26,11 @@ pub fn select_document(document: usize) -> Result<(), JsValue> {
EDITOR_STATE.with(|editor| editor.borrow_mu... | [
"client/web/wasm/src/document.rs"
] | [
{
"comment": "Is \"tool\" the right name for selecting a document in this log message? You may also want to consider removing this if you're done with it, unless you think it will continue to serve a useful debugging purpose.",
"path": "client/web/wasm/src/document.rs",
"hunk": "@@ -23,9 +23,16 @@ pub f... | true | ||
GraphiteEditor/Graphite | 215 | comment_to_fix | Closing doc tabs | You may want to consider removing this if you're done with it, unless you think it will continue to serve a useful debugging purpose. | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/client/web/wasm/src/document.rs b/client/web/wasm/src/document.rs
index bf12008ee5..70cdf049db 100644
--- a/client/web/wasm/src/document.rs
+++ b/client/web/wasm/src/document.rs
@@ -26,6 +26,11 @@ pub fn select_document(document: usize) -> Result<(), JsValue> {
EDITOR_STATE.with(|editor| editor.borrow_mu... | [
"client/web/wasm/src/document.rs"
] | [
{
"comment": "You may want to consider removing this if you're done with it, unless you think it will continue to serve a useful debugging purpose.",
"path": "client/web/wasm/src/document.rs",
"hunk": "@@ -23,9 +23,16 @@ pub fn select_tool(tool: String) -> Result<(), JsValue> {\n \n #[wasm_bindgen]\n pu... | true | ||
GraphiteEditor/Graphite | 215 | comment_to_fix | Closing doc tabs | If this is old code, please remove it before committing. If it should stay for a very particular reason (such as its re-enablement at some point in time, like when something else unblocks it) then please write a descriptive comment for precisely why it's being saved and when it should be restored. | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/core/editor/src/document/document_message_handler.rs b/core/editor/src/document/document_message_handler.rs
index 269a1f9e4f..8247434bd8 100644
--- a/core/editor/src/document/document_message_handler.rs
+++ b/core/editor/src/document/document_message_handler.rs
@@ -17,6 +17,8 @@ pub enum DocumentMessage {
... | [
"core/editor/src/document/document_message_handler.rs"
] | [
{
"comment": "If this is old code, please remove it before committing. If it should stay for a very particular reason (such as its re-enablement at some point in time, like when something else unblocks it) then please write a descriptive comment for precisely why it's being saved and when it should be restored.... | true | ||
GraphiteEditor/Graphite | 215 | comment_to_fix | Closing doc tabs | Same comment as above regarding disabled code. | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/core/editor/src/document/document_message_handler.rs b/core/editor/src/document/document_message_handler.rs
index 269a1f9e4f..8247434bd8 100644
--- a/core/editor/src/document/document_message_handler.rs
+++ b/core/editor/src/document/document_message_handler.rs
@@ -17,6 +17,8 @@ pub enum DocumentMessage {
... | [
"core/editor/src/document/document_message_handler.rs"
] | [
{
"comment": "Same comment as above regarding disabled code.",
"path": "core/editor/src/document/document_message_handler.rs",
"hunk": "@@ -97,16 +99,116 @@ impl MessageHandler<DocumentMessage, ()> for DocumentMessageHandler {\n \t\t\t\t\t.into(),\n \t\t\t\t);\n \t\t\t}\n+\t\t\tCloseActiveDocument => {\... | true | ||
GraphiteEditor/Graphite | 215 | comment_to_fix | Closing doc tabs | Nitpick: "atleast" -> "at least" | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/core/editor/src/document/document_message_handler.rs b/core/editor/src/document/document_message_handler.rs
index 269a1f9e4f..8247434bd8 100644
--- a/core/editor/src/document/document_message_handler.rs
+++ b/core/editor/src/document/document_message_handler.rs
@@ -17,6 +17,8 @@ pub enum DocumentMessage {
... | [
"core/editor/src/document/document_message_handler.rs"
] | [
{
"comment": "Nitpick: \"atleast\" -> \"at least\"",
"path": "core/editor/src/document/document_message_handler.rs",
"hunk": "@@ -97,16 +99,116 @@ impl MessageHandler<DocumentMessage, ()> for DocumentMessageHandler {\n \t\t\t\t\t.into(),\n \t\t\t\t);\n \t\t\t}\n+\t\t\tCloseActiveDocument => {\n+\t\t\t\t... | true | ||
GraphiteEditor/Graphite | 215 | comment_to_fix | Closing doc tabs | I'm concerned about the three layers of `if/else` nesting. This whole section of conditional logic can be simplified and a level of depth can be removed like so:
```
if self.documents.len() == 0 {
// The two lines from the bottom else clause of your current code
} else if id == self.active_document {
// ... | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/core/editor/src/document/document_message_handler.rs b/core/editor/src/document/document_message_handler.rs
index 269a1f9e4f..8247434bd8 100644
--- a/core/editor/src/document/document_message_handler.rs
+++ b/core/editor/src/document/document_message_handler.rs
@@ -17,6 +17,8 @@ pub enum DocumentMessage {
... | [
"core/editor/src/document/document_message_handler.rs"
] | [
{
"comment": "I'm concerned about the three layers of `if/else` nesting. This whole section of conditional logic can be simplified and a level of depth can be removed like so:\r\n\r\n```\r\nif self.documents.len() == 0 {\r\n // The two lines from the bottom else clause of your current code\r\n} else if id ==... | true | ||
GraphiteEditor/Graphite | 215 | comment_to_fix | Closing doc tabs | There's a space after Untitled Document even when the 1 is omitted. | 8a56d6cf465928681594e2935bb642e81b921040 | 01cfc9ec739efd5fbe28cc7e469b20f63841eebe | diff --git a/core/editor/src/document/document_message_handler.rs b/core/editor/src/document/document_message_handler.rs
index 269a1f9e4f..8247434bd8 100644
--- a/core/editor/src/document/document_message_handler.rs
+++ b/core/editor/src/document/document_message_handler.rs
@@ -17,6 +17,8 @@ pub enum DocumentMessage {
... | [
"core/editor/src/document/document_message_handler.rs"
] | [
{
"comment": "There's a space after Untitled Document even when the 1 is omitted.",
"path": "core/editor/src/document/document_message_handler.rs",
"hunk": "@@ -163,37 +163,34 @@ impl MessageHandler<DocumentMessage, ()> for DocumentMessageHandler {\n \t\t\t\t}\n \t\t\t}\n \t\t\tNewDocument => {\n-\t\t\t... | true | ||
GraphiteEditor/Graphite | 3,565 | issue_to_patch | QR Code Node
Novelty QR Codes (rounded corners, graphic overlay in center, gradient mask..) are pretty common nowadays, and they seem well-suited to Graphite's render pipeline, and especially its ImageMagick-style cli workflow. I propose a QR Code Generator node that returns a vector QR Code when given a string, and p... | Introduce QR Code node | <!-- Please reference any relevant issue number below, optionally with a "Closes"/"Resolves"/"Fixes" prefix -->
Closes #3468
Do you have any suggestion ?
Current Implementation:
https://github.com/user-attachments/assets/d8c5d910-2f74-4d7e-a1d2-bc37258ac360
| 8b67840f0c24f83f461b1dfa348a8649113f3204 | fb4891207439be1dbef67bf61a477ae4ed3365ad | diff --git a/Cargo.lock b/Cargo.lock
index fc6ef1afe1..532c79277a 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -4659,6 +4659,12 @@ dependencies = [
"bytemuck",
]
+[[package]]
+name = "qrcodegen"
+version = "1.8.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "4339fc7a1021c9c1621d87f... | [
"Cargo.lock",
"Cargo.toml",
"node-graph/nodes/vector/Cargo.toml",
"node-graph/nodes/vector/src/generator_nodes.rs",
"node-graph/nodes/vector/src/lib.rs",
"node-graph/nodes/vector/src/merge_qr_squares.rs"
] | [
{
"comment": "```suggestion\n#[node_macro::node(category(\"Vector: Shape\"), name(\"QR Code\"))]\n```",
"path": "node-graph/nodes/vector/src/generator_nodes.rs",
"hunk": "@@ -186,6 +186,117 @@ fn star<T: AsU64>(\n \tTable::new_from_element(Vector::from_subpath(subpath::Subpath::new_star_polygon(DVec2::s... | true | |
GraphiteEditor/Graphite | 3,565 | comment_to_fix | Introduce QR Code node | ```suggestion
#[node_macro::node(category("Vector: Shape"), name("QR Code"))]
``` | 8b67840f0c24f83f461b1dfa348a8649113f3204 | fb4891207439be1dbef67bf61a477ae4ed3365ad | diff --git a/node-graph/nodes/vector/src/generator_nodes.rs b/node-graph/nodes/vector/src/generator_nodes.rs
index 098b1782ac..2d1b1a26de 100644
--- a/node-graph/nodes/vector/src/generator_nodes.rs
+++ b/node-graph/nodes/vector/src/generator_nodes.rs
@@ -186,6 +186,51 @@ fn star<T: AsU64>(
Table::new_from_element(Vec... | [
"node-graph/nodes/vector/src/generator_nodes.rs"
] | [
{
"comment": "```suggestion\n#[node_macro::node(category(\"Vector: Shape\"), name(\"QR Code\"))]\n```",
"path": "node-graph/nodes/vector/src/generator_nodes.rs",
"hunk": "@@ -186,6 +186,117 @@ fn star<T: AsU64>(\n \tTable::new_from_element(Vector::from_subpath(subpath::Subpath::new_star_polygon(DVec2::s... | true | ||
GraphiteEditor/Graphite | 3,565 | comment_to_fix | Introduce QR Code node | Don't use `#[name(...)]` here, it should be used only to fix capitalization issues which isn't needed in this case.
Let's call this `individual_squares` which is the inverse of the current `merge`. It should be `false` by default, meaning the `#[default(true)]` line should be removed, since we normally want the square... | 8b67840f0c24f83f461b1dfa348a8649113f3204 | fb4891207439be1dbef67bf61a477ae4ed3365ad | diff --git a/node-graph/nodes/vector/src/generator_nodes.rs b/node-graph/nodes/vector/src/generator_nodes.rs
index 098b1782ac..2d1b1a26de 100644
--- a/node-graph/nodes/vector/src/generator_nodes.rs
+++ b/node-graph/nodes/vector/src/generator_nodes.rs
@@ -186,6 +186,51 @@ fn star<T: AsU64>(
Table::new_from_element(Vec... | [
"node-graph/nodes/vector/src/generator_nodes.rs"
] | [
{
"comment": "Don't use `#[name(...)]` here, it should be used only to fix capitalization issues which isn't needed in this case.\n\nLet's call this `individual_squares` which is the inverse of the current `merge`. It should be `false` by default, meaning the `#[default(true)]` line should be removed, since we ... | true | ||
GraphiteEditor/Graphite | 3,565 | comment_to_fix | Introduce QR Code node | Please move this algorithm into a helper function outside the node. | 8b67840f0c24f83f461b1dfa348a8649113f3204 | fb4891207439be1dbef67bf61a477ae4ed3365ad | diff --git a/node-graph/nodes/vector/src/generator_nodes.rs b/node-graph/nodes/vector/src/generator_nodes.rs
index 098b1782ac..2d1b1a26de 100644
--- a/node-graph/nodes/vector/src/generator_nodes.rs
+++ b/node-graph/nodes/vector/src/generator_nodes.rs
@@ -186,6 +186,51 @@ fn star<T: AsU64>(
Table::new_from_element(Vec... | [
"node-graph/nodes/vector/src/generator_nodes.rs"
] | [
{
"comment": "Please move this algorithm into a helper function outside the node.",
"path": "node-graph/nodes/vector/src/generator_nodes.rs",
"hunk": "@@ -186,6 +186,117 @@ fn star<T: AsU64>(\n \tTable::new_from_element(Vector::from_subpath(subpath::Subpath::new_star_polygon(DVec2::splat(-diameter), poi... | true | ||
GraphiteEditor/Graphite | 3,565 | comment_to_fix | Introduce QR Code node | nit : consider adding constants here for directions
```
const DIR_TOP: u8 = 1 << 0;
const DIR_RIGHT: u8 = 1 << 1;
const DIR_BOTTOM: u8 = 1 << 2;
const DIR_LEFT: u8 = 1 << 3;
``` | 8b67840f0c24f83f461b1dfa348a8649113f3204 | fb4891207439be1dbef67bf61a477ae4ed3365ad | diff --git a/node-graph/nodes/vector/src/merge_qr_squares.rs b/node-graph/nodes/vector/src/merge_qr_squares.rs
new file mode 100644
index 0000000000..ea2ac61372
--- /dev/null
+++ b/node-graph/nodes/vector/src/merge_qr_squares.rs
@@ -0,0 +1,118 @@
+use glam::DVec2;
+use graphic_types::Vector;
+use std::collections::VecD... | [
"node-graph/nodes/vector/src/merge_qr_squares.rs"
] | [
{
"comment": "nit : consider adding constants here for directions\n\n```\nconst DIR_TOP: u8 = 1 << 0;\nconst DIR_RIGHT: u8 = 1 << 1;\nconst DIR_BOTTOM: u8 = 1 << 2;\nconst DIR_LEFT: u8 = 1 << 3;\n```",
"path": "node-graph/nodes/vector/src/merge_qr_squares.rs",
"hunk": "@@ -0,0 +1,118 @@\n+use glam::DVec... | true | ||
GraphiteEditor/Graphite | 3,565 | comment_to_fix | Introduce QR Code node | This should be
`let ecc = match error_correction.min(3)`
@TrueDoctor @timon-schelling @Keavon , let me know if I am wrong here , but since the intent here seems to be clamp the input to a valid range of 0 - 3 ,
by using max here , wouldn't it give wrong outputs
User Input: 0 (wants Low)
→ 0.max(3) = 3
... | 8b67840f0c24f83f461b1dfa348a8649113f3204 | fb4891207439be1dbef67bf61a477ae4ed3365ad | diff --git a/node-graph/nodes/vector/src/generator_nodes.rs b/node-graph/nodes/vector/src/generator_nodes.rs
index 098b1782ac..2d1b1a26de 100644
--- a/node-graph/nodes/vector/src/generator_nodes.rs
+++ b/node-graph/nodes/vector/src/generator_nodes.rs
@@ -186,6 +186,51 @@ fn star<T: AsU64>(
Table::new_from_element(Vec... | [
"node-graph/nodes/vector/src/generator_nodes.rs"
] | [
{
"comment": "This should be\r\n\r\n`let ecc = match error_correction.min(3)`\r\n\r\n@TrueDoctor @timon-schelling @Keavon , let me know if I am wrong here , but since the intent here seems to be clamp the input to a valid range of 0 - 3 , \r\n\r\nby using max here , wouldn't it give wrong outputs\r\n\r\nUser In... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.