repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
GoogleChrome/lighthouse | 16,987 | issue_to_patch | core(webmcp): adjust how webmcp audits handle lack of WebMCP support | WebMCP audits should only be applicable in these cases:
* WebMCP is supported, meaning `navigator.modelContext` is exposed. This is the case if `WebMCPForTesting` flag is enabled or the site is part of the origin trial.
* WebMCP.enable CDP call is supported. This is only the case if `DevToolsWebMCPSupport` flag is ... | 9f10dd45304955114973bcdaef01ab3e40c020a3 | a9f89d4d00c33e46ede89fb4d7c971916c3efb72 | diff --git a/cli/bin.js b/cli/bin.js
index be2428fba872..a7b7d90e9cd4 100644
--- a/cli/bin.js
+++ b/cli/bin.js
@@ -107,6 +107,11 @@ async function begin() {
cliFlags.precomputedLanternData = data;
}
+ if (!Array.isArray(cliFlags.chromeFlags)) {
+ cliFlags.chromeFlags = [cliFlags.chromeFlags];
+ }
+ cliF... | [
"cli/bin.js",
"core/audits/webmcp-form-coverage.js",
"core/audits/webmcp-registered-tools.js",
"core/audits/webmcp-schema-validity.js",
"core/config/agentic-browsing-config.js",
"core/gather/gatherers/webmcp.js",
"core/test/audits/webmcp-form-coverage-test.js",
"core/test/audits/webmcp-registered-tool... | [] | diff --git a/core/test/audits/webmcp-form-coverage-test.js b/core/test/audits/webmcp-form-coverage-test.js
index c5bbab36acbc..7582654bc307 100644
--- a/core/test/audits/webmcp-form-coverage-test.js
+++ b/core/test/audits/webmcp-form-coverage-test.js
@@ -9,6 +9,7 @@ import WebMcpFormCoverage from '../../audits/webmcp-f... | true | |
GoogleChrome/lighthouse | 16,990 | issue_to_patch | core(agentic_category): add disclaimer to category description | 9f10dd45304955114973bcdaef01ab3e40c020a3 | 3a37547a4c5ba3a38be03313149a5c1b045ee233 | diff --git a/core/config/agentic-browsing-config.js b/core/config/agentic-browsing-config.js
index 89cdd4765f2e..d48d6c170dd3 100644
--- a/core/config/agentic-browsing-config.js
+++ b/core/config/agentic-browsing-config.js
@@ -10,8 +10,9 @@ const UIStrings = {
/** Title of the Agentic Browsing category of audits. */... | [
"core/config/agentic-browsing-config.js",
"shared/localization/locales/en-US.json",
"shared/localization/locales/en-XL.json"
] | [] | true | |||
GoogleChrome/lighthouse | 16,989 | issue_to_patch | docs(release): fix heading style | ebddc17a4bdf7dc1702bdfe7d3a1264ab3f6ddea | 92780325db270a39fe43080d11bdb0795b49021a | diff --git a/docs/releasing.md b/docs/releasing.md
index 70fda13a877f..7c09e372f72e 100644
--- a/docs/releasing.md
+++ b/docs/releasing.md
@@ -95,7 +95,7 @@ yarn deploy-viewer
yarn deploy-treemap
```
-# Create a release on GitHub.
+### Create a release on GitHub
Go to https://github.com/GoogleChrome/lighthouse/rel... | [
"docs/releasing.md"
] | [] | true | |||
GoogleChrome/lighthouse | 16,982 | issue_to_patch | core(config): aggregate agent accessabilty audits |
<img width="877" height="659" alt="Screenshot 2026-04-24 at 2 06 44 PM" src="https://github.com/user-attachments/assets/d44d96ba-b0cf-41cb-bf06-69a8c8972e45" />
This PR aggregates the agent accessibility audits into a unified view. Introduces the agent-accessibility-tree audit, which gathers multiple underlying Ax... | ebddc17a4bdf7dc1702bdfe7d3a1264ab3f6ddea | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 | diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js
new file mode 100644
index 000000000000..52023ac50436
--- /dev/null
+++ b/core/audits/agentic/agent-accessibility-tree.js
@@ -0,0 +1,115 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Iden... | [
"core/audits/agentic/agent-accessibility-tree.js",
"core/config/agentic-browsing-config.js",
"core/gather/gatherers/accessibility.js",
"core/test/audits/agentic/agent-accessibility-tree-test.js",
"core/test/results/artifacts/artifacts.json",
"core/test/results/sample_v2.json",
"report/test/generator/rep... | [
{
"comment": "nit: I'd maybe drop the `Agentic` here and below. The accessibility tree isn't really specific to agents, it just happens to also help agents.",
"path": "core/audits/agentic/agent-accessibility-tree.js",
"hunk": "@@ -0,0 +1,111 @@\n+/**\n+ * @license\n+ * Copyright 2026 Google LLC\n+ * SPD... | diff --git a/core/test/audits/agentic/agent-accessibility-tree-test.js b/core/test/audits/agentic/agent-accessibility-tree-test.js
new file mode 100644
index 000000000000..9193fc6caa31
--- /dev/null
+++ b/core/test/audits/agentic/agent-accessibility-tree-test.js
@@ -0,0 +1,78 @@
+/**
+ * @license
+ * Copyright 2026 Goo... | true | |
GoogleChrome/lighthouse | 16,982 | comment_to_fix | core(config): aggregate agent accessabilty audits | nit: I'd maybe drop the `Agentic` here and below. The accessibility tree isn't really specific to agents, it just happens to also help agents. | ebddc17a4bdf7dc1702bdfe7d3a1264ab3f6ddea | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 | diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js
new file mode 100644
index 000000000000..52023ac50436
--- /dev/null
+++ b/core/audits/agentic/agent-accessibility-tree.js
@@ -0,0 +1,115 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Iden... | [
"core/audits/agentic/agent-accessibility-tree.js"
] | [
{
"comment": "nit: I'd maybe drop the `Agentic` here and below. The accessibility tree isn't really specific to agents, it just happens to also help agents.",
"path": "core/audits/agentic/agent-accessibility-tree.js",
"hunk": "@@ -0,0 +1,111 @@\n+/**\n+ * @license\n+ * Copyright 2026 Google LLC\n+ * SPD... | true | ||
GoogleChrome/lighthouse | 16,982 | comment_to_fix | core(config): aggregate agent accessabilty audits | nit: `helps AI agents` | ebddc17a4bdf7dc1702bdfe7d3a1264ab3f6ddea | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 | diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js
new file mode 100644
index 000000000000..52023ac50436
--- /dev/null
+++ b/core/audits/agentic/agent-accessibility-tree.js
@@ -0,0 +1,115 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Iden... | [
"core/audits/agentic/agent-accessibility-tree.js"
] | [
{
"comment": "nit: `helps AI agents`",
"path": "core/audits/agentic/agent-accessibility-tree.js",
"hunk": "@@ -0,0 +1,111 @@\n+/**\n+ * @license\n+ * Copyright 2026 Google LLC\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+import {Audit} from '../audit.js';\n+import * as i18n from '../../lib/i18n/i... | true | ||
GoogleChrome/lighthouse | 16,982 | comment_to_fix | core(config): aggregate agent accessabilty audits | I was teased for using 'has issues', so you probably want to rephrase this | ebddc17a4bdf7dc1702bdfe7d3a1264ab3f6ddea | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 | diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js
new file mode 100644
index 000000000000..52023ac50436
--- /dev/null
+++ b/core/audits/agentic/agent-accessibility-tree.js
@@ -0,0 +1,115 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Iden... | [
"core/audits/agentic/agent-accessibility-tree.js"
] | [
{
"comment": "I was teased for using 'has issues', so you probably want to rephrase this",
"path": "core/audits/agentic/agent-accessibility-tree.js",
"hunk": "@@ -0,0 +1,111 @@\n+/**\n+ * @license\n+ * Copyright 2026 Google LLC\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+import {Audit} from '../... | true | ||
GoogleChrome/lighthouse | 16,982 | comment_to_fix | core(config): aggregate agent accessabilty audits | I think we may want the actual node as well? or instead? It might look very cramped if we do all. | ebddc17a4bdf7dc1702bdfe7d3a1264ab3f6ddea | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 | diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js
new file mode 100644
index 000000000000..52023ac50436
--- /dev/null
+++ b/core/audits/agentic/agent-accessibility-tree.js
@@ -0,0 +1,115 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Iden... | [
"core/audits/agentic/agent-accessibility-tree.js"
] | [
{
"comment": "I think we may want the actual node as well? or instead? It might look very cramped if we do all.",
"path": "core/audits/agentic/agent-accessibility-tree.js",
"hunk": "@@ -0,0 +1,111 @@\n+/**\n+ * @license\n+ * Copyright 2026 Google LLC\n+ * SPDX-License-Identifier: Apache-2.0\n+ */\n+\n+i... | true | ||
GoogleChrome/lighthouse | 16,982 | comment_to_fix | core(config): aggregate agent accessabilty audits | kinda weird wording.
```sh
grep -r "failureTitle: '" core/audits/ | grep -o "'.*" | sort
```
here's all our failure titles. i can't come up with something better but... the "well-formed" concept seems relevant. maybe ask your neighborhood LLM for some wording ideas. | ebddc17a4bdf7dc1702bdfe7d3a1264ab3f6ddea | 51d3dcc20c947b7c06688d1b5651512b7d95feb0 | diff --git a/core/audits/agentic/agent-accessibility-tree.js b/core/audits/agentic/agent-accessibility-tree.js
new file mode 100644
index 000000000000..52023ac50436
--- /dev/null
+++ b/core/audits/agentic/agent-accessibility-tree.js
@@ -0,0 +1,115 @@
+/**
+ * @license
+ * Copyright 2026 Google LLC
+ * SPDX-License-Iden... | [
"core/audits/agentic/agent-accessibility-tree.js"
] | [
{
"comment": "kinda weird wording. \r\n\r\n```sh\r\ngrep -r \"failureTitle: '\" core/audits/ | grep -o \"'.*\" | sort\r\n```\r\n\r\nhere's all our failure titles. i can't come up with something better but... the \"well-formed\" concept seems relevant. maybe ask your neighborhood LLM for some wording ideas. ",... | true | ||
GoogleContainerTools/jib | 4,495 | issue_to_patch | Update Jackson BOM version to 2.21.1 | Issue described here:
https://github.com/GoogleContainerTools/jib/issues/4494
Thank you for your interest in contributing! For general guidelines, please refer to
the [contributing guide](https://github.com/GoogleContainerTools/jib/blob/master/CONTRIBUTING.md).
Please follow the guidelines below before opening ... | 49234a54bb5c43504e166468488aa8a8da47df8d | 0dbd93453f8ad32bc0af113631294e7aff08ba8d | diff --git a/build.gradle b/build.gradle
index e83cba6046..fadc71dd8c 100644
--- a/build.gradle
+++ b/build.gradle
@@ -31,7 +31,7 @@ project.ext.dependencyStrings = [
COMMONS_COMPRESS: 'org.apache.commons:commons-compress:1.26.0',
ZSTD_JNI: 'com.github.luben:zstd-jni:1.5.5-5',
COMMONS_TEXT: 'org.apache.commons... | [
"build.gradle"
] | [
{
"comment": "\n\nThe specified Jackson BOM version `2.21.1` does not appear to be a valid published version in Maven Central. This will cause dependency resolution to fail during the build. Please verify the correct version you intend to use. If ... | true | ||
GoogleContainerTools/jib | 4,495 | comment_to_fix | Update Jackson BOM version to 2.21.1 | 
The specified Jackson BOM version `2.21.1` does not appear to be a valid published version in Maven Central. This will cause dependency resolution to fail during the build. Please verify the correct version you intend to use. If the goal is to update to... | 49234a54bb5c43504e166468488aa8a8da47df8d | 0dbd93453f8ad32bc0af113631294e7aff08ba8d | diff --git a/build.gradle b/build.gradle
index e83cba6046..fadc71dd8c 100644
--- a/build.gradle
+++ b/build.gradle
@@ -31,7 +31,7 @@ project.ext.dependencyStrings = [
COMMONS_COMPRESS: 'org.apache.commons:commons-compress:1.26.0',
ZSTD_JNI: 'com.github.luben:zstd-jni:1.5.5-5',
COMMONS_TEXT: 'org.apache.commons... | [
"build.gradle"
] | [
{
"comment": "\n\nThe specified Jackson BOM version `2.21.1` does not appear to be a valid published version in Maven Central. This will cause dependency resolution to fail during the build. Please verify the correct version you intend to use. If ... | true | ||
GoogleContainerTools/jib | 4,495 | comment_to_fix | Update Jackson BOM version to 2.21.1 | 
The specified version `2.21.1` for `com.fasterxml.jackson:jackson-bom` does not exist in Maven Central. This will cause a build failure due to an unresolved dependency. The latest available version is `2.17.1`. Please update to a valid and existing vers... | 49234a54bb5c43504e166468488aa8a8da47df8d | 0dbd93453f8ad32bc0af113631294e7aff08ba8d | diff --git a/build.gradle b/build.gradle
index e83cba6046..fadc71dd8c 100644
--- a/build.gradle
+++ b/build.gradle
@@ -31,7 +31,7 @@ project.ext.dependencyStrings = [
COMMONS_COMPRESS: 'org.apache.commons:commons-compress:1.26.0',
ZSTD_JNI: 'com.github.luben:zstd-jni:1.5.5-5',
COMMONS_TEXT: 'org.apache.commons... | [
"build.gradle"
] | [
{
"comment": "\n\nThe specified version `2.21.1` for `com.fasterxml.jackson:jackson-bom` does not exist in Maven Central. This will cause a build failure due to an unresolved dependency. The latest available version is `2.17.1`. Please update to a... | true | ||
GoogleContainerTools/jib | 4,430 | issue_to_patch | Jib CLI proxy usage not documented
There is no documentation that we can configure JVM options (```You can also use JAVA_OPTS and JIB_OPTS to pass JVM options```) for jib cli. That's needed when we want to configure proxy that will be used by jib-core under the hood. But as soon there is a plan to make jib cli native ... | Issue #4231: jib cli: add doc about jvm options | Closes https://github.com/GoogleContainerTools/jib/issues/4231 | df23f9a447895a61eb9955f8d7e30cf207441118 | 6e2ca49d3d0c110badef3db4de01709676875ff6 | diff --git a/jib-cli/README.md b/jib-cli/README.md
index e23985cade..a81b1d58a4 100644
--- a/jib-cli/README.md
+++ b/jib-cli/README.md
@@ -28,6 +28,7 @@ The CLI tool is powered by [Jib Core](https://github.com/GoogleContainerTools/ji
* [Download a Java Application](#download-a-java-application)
* [Windows: Instal... | [
"jib-cli/README.md"
] | [
{
"comment": "\n\nThe linked FAQ section on proxy configuration is written for the Jib Maven/Gradle plugins and talks about configuring the build tool. This might be confusing for a Jib CLI user.\n\nTo improve clarity, I suggest removing the ... | true | |
GoogleContainerTools/jib | 4,430 | comment_to_fix | Issue #4231: jib cli: add doc about jvm options | 
The linked FAQ section on proxy configuration is written for the Jib Maven/Gradle plugins and talks about configuring the build tool. This might be confusing for a Jib CLI user.
To improve clarity, I suggest removing the link to the FAQ, providing... | df23f9a447895a61eb9955f8d7e30cf207441118 | 6e2ca49d3d0c110badef3db4de01709676875ff6 | diff --git a/jib-cli/README.md b/jib-cli/README.md
index e23985cade..a81b1d58a4 100644
--- a/jib-cli/README.md
+++ b/jib-cli/README.md
@@ -28,6 +28,7 @@ The CLI tool is powered by [Jib Core](https://github.com/GoogleContainerTools/ji
* [Download a Java Application](#download-a-java-application)
* [Windows: Instal... | [
"jib-cli/README.md"
] | [
{
"comment": "\n\nThe linked FAQ section on proxy configuration is written for the Jib Maven/Gradle plugins and talks about configuring the build tool. This might be confusing for a Jib CLI user.\n\nTo improve clarity, I suggest removing the ... | true | ||
GoogleContainerTools/jib | 4,493 | issue_to_patch | chore: Migrate gsutil usage to gcloud storage | Automated: Migrate {target_path} from gsutil to gcloud storage
This CL is part of the on going effort to migrate from the legacy `gsutil` tool to the new and improved `gcloud storage` command-line interface.
`gcloud storage` is the recommended and modern tool for interacting with Google Cloud Storage, offering better ... | 24b44450133f589584d7ee15caf0c85b20a119d0 | cef8a92b9fa8411184bb4006286b05b314498456 | diff --git a/jib-cli/scripts/update_gcs_latest.sh b/jib-cli/scripts/update_gcs_latest.sh
index 28aa42a6bc..6c0261b397 100755
--- a/jib-cli/scripts/update_gcs_latest.sh
+++ b/jib-cli/scripts/update_gcs_latest.sh
@@ -28,8 +28,8 @@ versionString="{\"latest\":\"$1\"}"
destination="gs://jib-versions/jib-cli"
echo $versi... | [
"jib-cli/scripts/update_gcs_latest.sh",
"jib-gradle-plugin/scripts/update_gcs_latest.sh",
"jib-maven-plugin/scripts/update_gcs_latest.sh"
] | [
{
"comment": "\n\nFor better efficiency and atomicity, you can combine the copy and ACL update into a single command by using the `--predefined-acl=public-read` flag. This avoids a second API call to update the object's ACLs after it has been... | true | ||
GoogleContainerTools/jib | 4,491 | issue_to_patch | Refactor Github Action per b/485167538 | This is a http://go/LSC run by http://go/ghss to automatically refactor your Github Actions per http://b/485167538.
This is a PR to help you upgrade to the latest standards in Github Actions.
Please merge this PR to accept the changes. NOTE: if you do not accept this PR, it may be force merged by the GHSS team. See h... | c43ab0773bccff38f5463d53d36af6daa82a3d8a | 41417f4abe1e59e760fa6fa109251e4c892eba27 | diff --git a/.github/workflows/jib-cli-release.yml b/.github/workflows/jib-cli-release.yml
index cdebc3eb69..cea1c54d30 100644
--- a/.github/workflows/jib-cli-release.yml
+++ b/.github/workflows/jib-cli-release.yml
@@ -30,32 +30,38 @@ jobs:
- name: Build project
run: |
- if [[ ! "${{ github.e... | [
".github/workflows/jib-cli-release.yml",
".github/workflows/prepare-release.yml"
] | [] | true | ||
GoogleContainerTools/jib | 4,486 | issue_to_patch | chore: update changelog and examples to use 3.5.3 jib-gradle-plugin | Update the changelog and examples to use latest jib-gradle-plugin release 3.5.3.
| cf25fbd9849e2cdd0a91d4ba0845e11f7b3d0682 | 6ef57b1d3e810a17a4b17f5ab7f6e4f371a033e7 | diff --git a/examples/helloworld/build.gradle b/examples/helloworld/build.gradle
index c4360803f5..b74b1e9270 100644
--- a/examples/helloworld/build.gradle
+++ b/examples/helloworld/build.gradle
@@ -1,6 +1,6 @@
plugins {
id 'java'
- id 'com.google.cloud.tools.jib' version '3.5.2'
+ id 'com.google.cloud.tools.jib'... | [
"examples/helloworld/build.gradle",
"examples/java-agent/build.gradle",
"examples/ktor/build.gradle.kts",
"examples/micronaut/build.gradle",
"examples/multi-module/build.gradle",
"examples/spring-boot/build.gradle",
"examples/vertx/build.gradle",
"jib-gradle-plugin/README.md"
] | [] | true | ||
GoogleContainerTools/jib | 4,484 | issue_to_patch | gradle release v3.5.3 | To be merged after the release is complete. | f07ee664d26582d9d38960e8d74c9c1de278c502 | 0d6e77984ad224b7c300bf082da522097a706df1 | diff --git a/jib-gradle-plugin/gradle.properties b/jib-gradle-plugin/gradle.properties
index f5645169c5..b453e55ba5 100644
--- a/jib-gradle-plugin/gradle.properties
+++ b/jib-gradle-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.5.2-SNAPSHOT
+version = 3.5.4-SNAPSHOT
| [
"jib-gradle-plugin/gradle.properties"
] | [
{
"comment": "\n\nThe version is being bumped from `3.5.2-SNAPSHOT` to `3.5.4-SNAPSHOT`, which skips the `3.5.3-SNAPSHOT` version. This is an unconventional version progression and likely a typo. After a development cycle on `3.5.2-SNAPSHOT`,... | true | ||
GoogleContainerTools/jib | 4,484 | comment_to_fix | gradle release v3.5.3 | 
The version is being bumped from `3.5.2-SNAPSHOT` to `3.5.4-SNAPSHOT`, which skips the `3.5.3-SNAPSHOT` version. This is an unconventional version progression and likely a typo. After a development cycle on `3.5.2-SNAPSHOT`, the next version should... | f07ee664d26582d9d38960e8d74c9c1de278c502 | 0d6e77984ad224b7c300bf082da522097a706df1 | diff --git a/jib-gradle-plugin/gradle.properties b/jib-gradle-plugin/gradle.properties
index f5645169c5..b453e55ba5 100644
--- a/jib-gradle-plugin/gradle.properties
+++ b/jib-gradle-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.5.2-SNAPSHOT
+version = 3.5.4-SNAPSHOT
| [
"jib-gradle-plugin/gradle.properties"
] | [
{
"comment": "\n\nThe version is being bumped from `3.5.2-SNAPSHOT` to `3.5.4-SNAPSHOT`, which skips the `3.5.3-SNAPSHOT` version. This is an unconventional version progression and likely a typo. After a development cycle on `3.5.2-SNAPSHOT`,... | true | ||
GoogleContainerTools/jib | 4,483 | issue_to_patch | chore: update CHANGELOG for jib-gradle-plugin version 3.5.3 | For jib-gradle-plugin 3.5.3 release | 7420c2b0b7f138317f3bba4d4d149c18b9c111d5 | 5f047751314741a7b73a42d4cd126529b0740088 | diff --git a/jib-gradle-plugin/CHANGELOG.md b/jib-gradle-plugin/CHANGELOG.md
index 1a85151213..eb38168488 100644
--- a/jib-gradle-plugin/CHANGELOG.md
+++ b/jib-gradle-plugin/CHANGELOG.md
@@ -9,6 +9,11 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 3.5.3
+
+### Fixed
+- fix: _... | [
"jib-gradle-plugin/CHANGELOG.md"
] | [
{
"comment": "\n\nFor consistency with the majority of other entries in this changelog, please wrap the issue link in parentheses.\n\n```suggestion\n- fix: _jibSkaffoldFilesV2 task fails on Gradle 9.0 ([#4469](https://github.com/GoogleContain... | true | ||
GoogleContainerTools/jib | 4,483 | comment_to_fix | chore: update CHANGELOG for jib-gradle-plugin version 3.5.3 | 
For consistency with the majority of other entries in this changelog, please wrap the issue link in parentheses.
```suggestion
- fix: _jibSkaffoldFilesV2 task fails on Gradle 9.0 ([#4469](https://github.com/GoogleContainerTools/jib/issues/4469))
`... | 7420c2b0b7f138317f3bba4d4d149c18b9c111d5 | 5f047751314741a7b73a42d4cd126529b0740088 | diff --git a/jib-gradle-plugin/CHANGELOG.md b/jib-gradle-plugin/CHANGELOG.md
index 1a85151213..eb38168488 100644
--- a/jib-gradle-plugin/CHANGELOG.md
+++ b/jib-gradle-plugin/CHANGELOG.md
@@ -9,6 +9,11 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 3.5.3
+
+### Fixed
+- fix: _... | [
"jib-gradle-plugin/CHANGELOG.md"
] | [
{
"comment": "\n\nFor consistency with the majority of other entries in this changelog, please wrap the issue link in parentheses.\n\n```suggestion\n- fix: _jibSkaffoldFilesV2 task fails on Gradle 9.0 ([#4469](https://github.com/GoogleContain... | true | ||
GoogleContainerTools/jib | 4,482 | issue_to_patch | Jib dependency refresh fails in gradle 9 multi module project when including dependency on other module
**Environment**:
- *Jib version:* 3.5.2
- *Build tool:* Gradle 9.2.1
- *OS:* MacOs 26.2
**Description of the issue**:
`Skaffold` fails to start with `Jib` in multi module project, because it tries to access non ex... | fix: make FilesTaskV2 gradle 9 compatible | Fix for _jibSkaffoldFilesV2 task fails on Gradle 9.0+ due to the removal of the [ProjectDependency.getDependencyProject](https://docs.gradle.org/8.11.1/userguide/upgrading_version_8.html#deprecate_get_dependency_project) method and [getSettingsFile](https://docs.gradle.org/current/userguide/upgrading_major_version_9.ht... | 349c809e958ec31e969be76fd66843104ac1fd30 | 8a52c51674a514984606259971d3b13c3a432661 | diff --git a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java b/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java
index e5e482d355..6a72637225 100644
--- a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/File... | [
"jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java"
] | [
{
"comment": "\n\nCatching the broad `ReflectiveOperationException` can mask issues. If `getDependencyProject()` exists but fails during invocation (for example, throwing an `InvocationTargetException`), this implementation will incorrectly fall ... | true | |
GoogleContainerTools/jib | 4,482 | comment_to_fix | fix: make FilesTaskV2 gradle 9 compatible | 
Catching the broad `ReflectiveOperationException` can mask issues. If `getDependencyProject()` exists but fails during invocation (for example, throwing an `InvocationTargetException`), this implementation will incorrectly fall through to the `getPath(... | 349c809e958ec31e969be76fd66843104ac1fd30 | 8a52c51674a514984606259971d3b13c3a432661 | diff --git a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java b/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java
index e5e482d355..6a72637225 100644
--- a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/File... | [
"jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java"
] | [
{
"comment": "\n\nCatching the broad `ReflectiveOperationException` can mask issues. If `getDependencyProject()` exists but fails during invocation (for example, throwing an `InvocationTargetException`), this implementation will incorrectly fall ... | true | ||
GoogleContainerTools/jib | 4,467 | issue_to_patch | Plugin Release v3.5.2-gradle
## Requirements
- [x] ⚠️ Ensure the release process has succeeded before proceeding
## GCS
- [x] Run `./jib-gradle-plugin/scripts/update_gcs_latest.sh 3.5.2` script to update GCS with the latest version number
## Github
- [x] Update [CHANGELOG.md](https://github.com/GoogleContainerTools/... | chore: gradle plugin 3.5.2 post-release cleanup | Fixes https://github.com/GoogleContainerTools/jib/issues/4464
| 7ca8957f22dbf8390ba3abf90223a2d51f719857 | 52446d3f0f6dc610ea543c0a66b6b389aff87d40 | diff --git a/examples/helloworld/build.gradle b/examples/helloworld/build.gradle
index 2ff9785662..c4360803f5 100644
--- a/examples/helloworld/build.gradle
+++ b/examples/helloworld/build.gradle
@@ -1,6 +1,6 @@
plugins {
id 'java'
- id 'com.google.cloud.tools.jib' version '3.5.1'
+ id 'com.google.cloud.tools.jib'... | [
"examples/helloworld/build.gradle",
"examples/java-agent/build.gradle",
"examples/ktor/build.gradle.kts",
"examples/micronaut/build.gradle",
"examples/multi-module/build.gradle",
"examples/spring-boot/build.gradle",
"examples/vertx/build.gradle",
"jib-gradle-plugin/CHANGELOG.md",
"jib-gradle-plugin/... | [] | true | |
GoogleContainerTools/jib | 4,462 | issue_to_patch | When skaffold invokes jib via gradle, a deprecated feature is used that will not work on gradle 9.0
**Environment**:
- jib gradle plugin: 3.3.2
- Build tool: Gradle 8.1.1
- OS: ubuntu 22.04
- skaffold: 2.5.1
**Description of the issue**:
The jib gradle plugin is using a deprecated feature that will make it inc... | Avoid use of StartParameter.getSettingsFile() in _jibSkaffoldFilesV2 when Gradle version is 9 or higher | This PR fixes #4052 for Gradle 9 and higher without breaking backwards compatibility with earlier versions.
Fixes #4052 🛠️
| 1cd849a0c143d14f75ab1a60cbd77546c9ca57c5 | 560b8c8e9dcb21c6500bf6b4d8828d12930a4db8 | diff --git a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java b/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java
index fc15b021cf..e5e482d355 100644
--- a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/File... | [
"jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java"
] | [
{
"comment": "\n\nTo improve readability and maintainability, it's a good practice to avoid 'magic strings' like \"9.0\". Consider extracting this version string into a `static final` constant.\n\nFor example, you could define a constant at t... | true | |
GoogleContainerTools/jib | 4,462 | comment_to_fix | Avoid use of StartParameter.getSettingsFile() in _jibSkaffoldFilesV2 when Gradle version is 9 or higher | 
To improve readability and maintainability, it's a good practice to avoid 'magic strings' like "9.0". Consider extracting this version string into a `static final` constant.
For example, you could define a constant at the class level:
```java
priv... | 1cd849a0c143d14f75ab1a60cbd77546c9ca57c5 | 560b8c8e9dcb21c6500bf6b4d8828d12930a4db8 | diff --git a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java b/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java
index fc15b021cf..e5e482d355 100644
--- a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/File... | [
"jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/skaffold/FilesTaskV2.java"
] | [
{
"comment": "\n\nTo improve readability and maintainability, it's a good practice to avoid 'magic strings' like \"9.0\". Consider extracting this version string into a `static final` constant.\n\nFor example, you could define a constant at t... | true | ||
GoogleContainerTools/jib | 2,999 | issue_to_patch | Add registry mirror config to jib-core API and Jib global config | Towards #1396.
* Jib Core
* Adds `Containerizer.withRegistryMirrors(...)` to the jib-core API.
* Jib Maven/Gradle plugins
* Adds the property `registryMirrors` to the global Jib config.
* Also see #3002 for the proposed public doc change.
```json
{
"disableUpdateCheck": false,
"registryMirrors":... | ee8519e88bda36f7e2f938d5bfb0862217820abd | e36544461b9a77022364100606e03ff067afcf59 | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java b/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java
index 1bd06d11a3..e2747d2a33 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java
+++ b/jib-core/src/main/java/com/google/clou... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java",
"jib-core/src/main/java/com/google/cloud/tools/jib/api/JibContainerBuilder.java",
"jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java",
"jib-core/src/test/java/com/google/cloud/tools/jib/api/Containerize... | [
{
"comment": "How about using `ImmutableListMultimap` instead of `ImmutableMap<String, ImmutableList<String>>` here? ",
"path": "jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java",
"hunk": "@@ -498,6 +520,15 @@ public boolean getAlwaysCacheBaseImage() {\n return laye... | diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/api/ContainerizerTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/api/ContainerizerTest.java
index 55299d7397..bda882cb44 100644
--- a/jib-core/src/test/java/com/google/cloud/tools/jib/api/ContainerizerTest.java
+++ b/jib-core/src/test/java/com... | true | |
GoogleContainerTools/jib | 2,999 | comment_to_fix | Add registry mirror config to jib-core API and Jib global config | How about using `ImmutableListMultimap` instead of `ImmutableMap<String, ImmutableList<String>>` here? | ee8519e88bda36f7e2f938d5bfb0862217820abd | e36544461b9a77022364100606e03ff067afcf59 | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java b/jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java
index eb53da3dfa..25ba6dab25 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java
+++ b/jib-core/sr... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java"
] | [
{
"comment": "How about using `ImmutableListMultimap` instead of `ImmutableMap<String, ImmutableList<String>>` here? ",
"path": "jib-core/src/main/java/com/google/cloud/tools/jib/configuration/BuildContext.java",
"hunk": "@@ -498,6 +520,15 @@ public boolean getAlwaysCacheBaseImage() {\n return laye... | true | ||
GoogleContainerTools/jib | 2,999 | comment_to_fix | Add registry mirror config to jib-core API and Jib global config | ```suggestion
private ImmutableListMultimap.Builder<String, String> registryMirrors = ImmutableListMultimap.builder();
``` | ee8519e88bda36f7e2f938d5bfb0862217820abd | e36544461b9a77022364100606e03ff067afcf59 | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java b/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java
index 1bd06d11a3..e2747d2a33 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java
+++ b/jib-core/src/main/java/com/google/clou... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java"
] | [
{
"comment": "```suggestion\r\n private ImmutableListMultimap.Builder<String, String> registryMirrors = ImmutableListMultimap.builder();\r\n```",
"path": "jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java",
"hunk": "@@ -136,6 +141,7 @@ public static Containerizer to(TarImage tarI... | true | ||
GoogleContainerTools/jib | 2,999 | comment_to_fix | Add registry mirror config to jib-core API and Jib global config | ```suggestion
ImmutableSet<Port> expectedExposedPorts = ImmutableSet.of(Port.tcp(1000), Port.tcp(2000));
``` | ee8519e88bda36f7e2f938d5bfb0862217820abd | e36544461b9a77022364100606e03ff067afcf59 | diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/configuration/BuildContextTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/configuration/BuildContextTest.java
index 5ee3359c41..98a365b013 100644
--- a/jib-core/src/test/java/com/google/cloud/tools/jib/configuration/BuildContextTest.java
+++ b... | [
"jib-core/src/test/java/com/google/cloud/tools/jib/configuration/BuildContextTest.java"
] | [
{
"comment": "```suggestion\r\n ImmutableSet<Port> expectedExposedPorts = ImmutableSet.of(Port.tcp(1000), Port.tcp(2000));\r\n```",
"path": "jib-core/src/test/java/com/google/cloud/tools/jib/configuration/BuildContextTest.java",
"hunk": "@@ -83,7 +84,7 @@ public void testBuilder() throws Exception {\... | true | ||
GoogleContainerTools/jib | 2,999 | comment_to_fix | Add registry mirror config to jib-core API and Jib global config | Naming wise, isn't this more "addRegistryMirrors" rather than "withRegistryMirrors"? | ee8519e88bda36f7e2f938d5bfb0862217820abd | e36544461b9a77022364100606e03ff067afcf59 | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java b/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java
index 1bd06d11a3..e2747d2a33 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java
+++ b/jib-core/src/main/java/com/google/clou... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java"
] | [
{
"comment": "Naming wise, isn't this more \"addRegistryMirrors\" rather than \"withRegistryMirrors\"?",
"path": "jib-core/src/main/java/com/google/cloud/tools/jib/api/Containerizer.java",
"hunk": "@@ -303,8 +309,25 @@ public Containerizer setAlwaysCacheBaseImage(boolean alwaysCacheBaseImage) {\n re... | true | ||
GoogleContainerTools/jib | 2,999 | comment_to_fix | Add registry mirror config to jib-core API and Jib global config | Should this change be rebased in? | ee8519e88bda36f7e2f938d5bfb0862217820abd | e36544461b9a77022364100606e03ff067afcf59 | diff --git a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/BuildImageTask.java b/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/BuildImageTask.java
index 2e9ac562a8..1527849cab 100644
--- a/jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/BuildImageTask.java
+++ b... | [
"jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/BuildImageTask.java"
] | [
{
"comment": "Should this change be rebased in?",
"path": "jib-gradle-plugin/src/main/java/com/google/cloud/tools/jib/gradle/BuildImageTask.java",
"hunk": "@@ -81,21 +83,24 @@ public void setTargetImage(String targetImage) {\n * @throws BuildStepsExecutionException if an error occurs while executing ... | true | ||
GoogleContainerTools/jib | 4,456 | issue_to_patch | core release v0.28.1 | To be merged after the release is complete. | afdfba9d1c10c3187d8cf8881c96574787d5a05b | b53ea8424ca7fa395e555b022f5c14a50bfdaaf1 | diff --git a/jib-core/gradle.properties b/jib-core/gradle.properties
index 0b145043ac..1cb6fd80b7 100644
--- a/jib-core/gradle.properties
+++ b/jib-core/gradle.properties
@@ -1,1 +1,1 @@
-version = 0.28.1-SNAPSHOT
+version = 0.28.2-SNAPSHOT
| [
"jib-core/gradle.properties"
] | [
{
"comment": "\n\nThis manual version bump appears to be a post-release task. The `net.researchgate.release` plugin, which is already configured in `jib-core/build.gradle`, can automate this process. Relying on manual version updates is error... | true | ||
GoogleContainerTools/jib | 4,458 | issue_to_patch | maven release v3.5.1 | To be merged after the release is complete. | afdfba9d1c10c3187d8cf8881c96574787d5a05b | b02c87c7ebe33afda0f69791a260576a8bea714b | diff --git a/jib-maven-plugin/gradle.properties b/jib-maven-plugin/gradle.properties
index 9f8c4c2dfa..f5645169c5 100644
--- a/jib-maven-plugin/gradle.properties
+++ b/jib-maven-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.5.1-SNAPSHOT
+version = 3.5.2-SNAPSHOT
| [
"jib-maven-plugin/gradle.properties"
] | [
{
"comment": "\n\nWhile you've updated the version for the Maven plugin, it appears the corresponding version in `jib-gradle-plugin/gradle.properties` is still `3.5.1-SNAPSHOT`. Since both plugins seem to share the same version number, the Gr... | true | ||
GoogleContainerTools/jib | 4,454 | issue_to_patch | gradle release v3.5.1 | To be merged after the release is complete. | afdfba9d1c10c3187d8cf8881c96574787d5a05b | 85d69ae1c3005600df1b7efc2c4bfd7c31a8d3fa | diff --git a/jib-gradle-plugin/gradle.properties b/jib-gradle-plugin/gradle.properties
index 9f8c4c2dfa..f5645169c5 100644
--- a/jib-gradle-plugin/gradle.properties
+++ b/jib-gradle-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.5.1-SNAPSHOT
+version = 3.5.2-SNAPSHOT
| [
"jib-gradle-plugin/gradle.properties"
] | [
{
"comment": "\n\nWhile this version bump is correct for the Gradle plugin, the corresponding Maven plugin's version in `jib-maven-plugin/gradle.properties` also needs to be updated from `3.5.1-SNAPSHOT` to `3.5.2-SNAPSHOT`. It appears the Maven ... | true | ||
GoogleContainerTools/jib | 4,460 | issue_to_patch | chore: 3.5.0 post release updates | afdfba9d1c10c3187d8cf8881c96574787d5a05b | b5c1f451e28529af15eb3d20ee572b3157d91f47 | diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml
index 9c4b4821e7..5a75180165 100644
--- a/examples/dropwizard/pom.xml
+++ b/examples/dropwizard/pom.xml
@@ -26,7 +26,7 @@
<dropwizard-template-config.version>1.5.0</dropwizard-template-config.version>
<jib.container.appRoot>/app<... | [
"examples/dropwizard/pom.xml",
"examples/helloworld/build.gradle",
"examples/helloworld/pom.xml",
"examples/java-agent/build.gradle",
"examples/java-agent/pom.xml",
"examples/ktor/build.gradle.kts",
"examples/micronaut/build.gradle",
"examples/multi-module/build.gradle",
"examples/multi-module/pom.x... | [
{
"comment": "\n\nThe `compile` dependency configuration is deprecated in Gradle. It's better to use `implementation` to align with modern Gradle practices and avoid confusion for users.\n\n```suggestion\n implementation 'com.google.cloud.to... | true | |||
GoogleContainerTools/jib | 4,452 | issue_to_patch | chore: 3.5.0 post release updates | - **docs: modify CHANGELOG.md**
- **docs: update README files**
- **docs: update examples**
| 0ca8ed07dbb8f94ddca6a2622bb482e831d2758d | 379587813f098905ae015c17e80accffd2df4254 | diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml
index 7d64dd82e3..9c4b4821e7 100644
--- a/examples/dropwizard/pom.xml
+++ b/examples/dropwizard/pom.xml
@@ -26,7 +26,7 @@
<dropwizard-template-config.version>1.5.0</dropwizard-template-config.version>
<jib.container.appRoot>/app<... | [
"examples/dropwizard/pom.xml",
"examples/helloworld/build.gradle",
"examples/helloworld/pom.xml",
"examples/java-agent/build.gradle",
"examples/java-agent/pom.xml",
"examples/ktor/build.gradle.kts",
"examples/micronaut/build.gradle",
"examples/multi-module/build.gradle",
"examples/multi-module/pom.x... | [
{
"comment": "\n\nThere's a small typo here with a duplicated 'deps:' prefix. Removing it will improve the changelog's clarity.\n\n```suggestion\n- deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support\n```",
"path": "jib-core... | true | ||
GoogleContainerTools/jib | 4,452 | comment_to_fix | chore: 3.5.0 post release updates | 
There's a small typo here with a duplicated 'deps:' prefix. Removing it will improve the changelog's clarity.
```suggestion
- deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support
``` | 0ca8ed07dbb8f94ddca6a2622bb482e831d2758d | 379587813f098905ae015c17e80accffd2df4254 | diff --git a/jib-core/CHANGELOG.md b/jib-core/CHANGELOG.md
index 40ddbd1f7d..2eb26154f5 100644
--- a/jib-core/CHANGELOG.md
+++ b/jib-core/CHANGELOG.md
@@ -9,6 +9,14 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 0.28.0
+
+### Added
+- feat: add default base image for Java 25 ... | [
"jib-core/CHANGELOG.md"
] | [
{
"comment": "\n\nThere's a small typo here with a duplicated 'deps:' prefix. Removing it will improve the changelog's clarity.\n\n```suggestion\n- deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support\n```",
"path": "jib-core... | true | ||
GoogleContainerTools/jib | 4,452 | comment_to_fix | chore: 3.5.0 post release updates | 
I noticed a minor typo in this changelog entry. The 'deps:' prefix is repeated.
```suggestion
- deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support
``` | 0ca8ed07dbb8f94ddca6a2622bb482e831d2758d | 379587813f098905ae015c17e80accffd2df4254 | diff --git a/jib-gradle-plugin/CHANGELOG.md b/jib-gradle-plugin/CHANGELOG.md
index bea060996b..8e371af50d 100644
--- a/jib-gradle-plugin/CHANGELOG.md
+++ b/jib-gradle-plugin/CHANGELOG.md
@@ -9,6 +9,14 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 3.5.0
+
+### Added
+- feat: ... | [
"jib-gradle-plugin/CHANGELOG.md"
] | [
{
"comment": "\n\nI noticed a minor typo in this changelog entry. The 'deps:' prefix is repeated.\n\n```suggestion\n- deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support\n```",
"path": "jib-gradle-plugin/CHANGELOG.md",
"... | true | ||
GoogleContainerTools/jib | 4,452 | comment_to_fix | chore: 3.5.0 post release updates | 
Just a small correction for the changelog: the 'deps:' prefix appears twice. The suggestion below fixes it.
```suggestion
- deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support
``` | 0ca8ed07dbb8f94ddca6a2622bb482e831d2758d | 379587813f098905ae015c17e80accffd2df4254 | diff --git a/jib-maven-plugin/CHANGELOG.md b/jib-maven-plugin/CHANGELOG.md
index 4a569e0289..be4a0caf62 100644
--- a/jib-maven-plugin/CHANGELOG.md
+++ b/jib-maven-plugin/CHANGELOG.md
@@ -9,6 +9,16 @@ All notable changes to this project will be documented in this file.
### Fixed
+## 3.5.0
+
+### Added
+- feat: add ... | [
"jib-maven-plugin/CHANGELOG.md"
] | [
{
"comment": "\n\nJust a small correction for the changelog: the 'deps:' prefix appears twice. The suggestion below fixes it.\n\n```suggestion\n- deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support\n```",
"path": "jib-maven-... | true | ||
GoogleContainerTools/jib | 4,432 | issue_to_patch | Fully support Java 25 and its flexible main methods
https://github.com/GoogleContainerTools/jib/pull/4418#issuecomment-3461109393 | feat: support Java 25 main methods | Fixes #4431
| d5b3e64afcb7510b4c5490c37f24c05de15cc125 | 1864c7f1727b1a26cfc05c697c6c0dc145278a25 | diff --git a/build.gradle b/build.gradle
index a6d76b491b..e83cba6046 100644
--- a/build.gradle
+++ b/build.gradle
@@ -35,7 +35,7 @@ project.ext.dependencyStrings = [
JACKSON_DATABIND: 'com.fasterxml.jackson.core:jackson-databind',
JACKSON_DATAFORMAT_YAML: 'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml... | [
"build.gradle",
"jib-core/src/main/java/com/google/cloud/tools/jib/api/MainClassFinder.java",
"jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java",
"jib-core/src/test/resources/core/class-finder-tests/java25-flexible-main/InstanceMainNoArgs.class",
"jib-core/src/test/resources/co... | [
{
"comment": "\n\nAccording to JEP 463 (Flexible Main Methods and Main Classes), a main method can be `synchronized` or `strictfp`. The current implementation does not account for these optional modifiers, which would cause valid main methods wit... | diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java
index e787a4b6f4..f61cfaf09d 100644
--- a/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java
+++ b/jib-core/src/test/ja... | true |
GoogleContainerTools/jib | 4,432 | comment_to_fix | feat: support Java 25 main methods | 
According to JEP 463 (Flexible Main Methods and Main Classes), a main method can be `synchronized` or `strictfp`. The current implementation does not account for these optional modifiers, which would cause valid main methods with these modifiers to be ... | d5b3e64afcb7510b4c5490c37f24c05de15cc125 | 1864c7f1727b1a26cfc05c697c6c0dc145278a25 | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/api/MainClassFinder.java b/jib-core/src/main/java/com/google/cloud/tools/jib/api/MainClassFinder.java
index edd452ef54..a3708b6307 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/api/MainClassFinder.java
+++ b/jib-core/src/main/java/com/googl... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/api/MainClassFinder.java"
] | [
{
"comment": "\n\nAccording to JEP 463 (Flexible Main Methods and Main Classes), a main method can be `synchronized` or `strictfp`. The current implementation does not account for these optional modifiers, which would cause valid main methods wit... | true | ||
GoogleContainerTools/jib | 4,432 | comment_to_fix | feat: support Java 25 main methods | 
There's a lot of duplicated code in the new tests for Java 25 main methods. You can refactor this to improve readability and maintainability. Consider extracting the common logic into a helper method and initializing the `rootDirectory` path in a `... | d5b3e64afcb7510b4c5490c37f24c05de15cc125 | 1864c7f1727b1a26cfc05c697c6c0dc145278a25 | diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java
index e787a4b6f4..f61cfaf09d 100644
--- a/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java
+++ b/jib-core/src/test/ja... | [
"jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java"
] | [
{
"comment": "\n\nThere's a lot of duplicated code in the new tests for Java 25 main methods. You can refactor this to improve readability and maintainability. Consider extracting the common logic into a helper method and initializing the `ro... | true | ||
GoogleContainerTools/jib | 4,432 | comment_to_fix | feat: support Java 25 main methods | 
The new tests cover many of the new flexible main method cases, which is great. However, tests for `synchronized` and `strictfp` main methods are missing. After addressing the issue with `OPTIONAL_MODIFIERS` in `MainClassFinder`, please add tests f... | d5b3e64afcb7510b4c5490c37f24c05de15cc125 | 1864c7f1727b1a26cfc05c697c6c0dc145278a25 | diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java
index e787a4b6f4..f61cfaf09d 100644
--- a/jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java
+++ b/jib-core/src/test/ja... | [
"jib-core/src/test/java/com/google/cloud/tools/jib/api/MainClassFinderTest.java"
] | [
{
"comment": "\n\nThe new tests cover many of the new flexible main method cases, which is great. However, tests for `synchronized` and `strictfp` main methods are missing. After addressing the issue with `OPTIONAL_MODIFIERS` in `MainClassFin... | true | ||
GoogleContainerTools/jib | 4,418 | issue_to_patch | Support java 25
Maven - 3.9.9
Liberica JDK - 25.0.0-37
jib-maven-plugin - 3.4.6
ASM ClassReader complains about unsupported version in the newest java jdk 25.
I have looked at https://github.com/GoogleContainerTools/jib/blob/master/docs/faq.md#i-am-seeing-unsupported-class-file-major-version-when-building and fix... | deps: update `org.ow2.asm:asm` to version 9.8 for java 25 support | Updated `org.ow2.asm:asm` to version 9.8 for java 25 support and replace deprecated `getNextTarEntry` with `getNextEntry`
BEGIN_COMMIT_OVERRIDE
deps: update org.ow2.asm:asm to version 9.8 for java 25 support
END_COMMIT_OVERRIDE
Fixes #4417🛠️
| 08a45eca1188dbbc114e1caf97ba79c19bb53c84 | 27127e9fa7de15b064582a98419eb769b09166bf | diff --git a/build.gradle b/build.gradle
index bfa4d3807e..a6d76b491b 100644
--- a/build.gradle
+++ b/build.gradle
@@ -35,7 +35,7 @@ project.ext.dependencyStrings = [
JACKSON_DATABIND: 'com.fasterxml.jackson.core:jackson-databind',
JACKSON_DATAFORMAT_YAML: 'com.fasterxml.jackson.dataformat:jackson-dataformat-yaml... | [
"build.gradle",
"jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/ReproducibleImageTest.java",
"jib-core/src/main/java/com/google/cloud/tools/jib/tar/TarExtractor.java",
"jib-core/src/test/java/com/google/cloud/tools/jib/image/ImageTarballTest.java",
"jib-core/src/test/java/com/google/cloud... | [
{
"comment": "\n\nFor consistency with other parts of the codebase and for better readability, this `for` loop can be converted to a `while` loop. The `while ((entry = ...getNextEntry()) != null)` pattern is more idiomatic for iterating throu... | diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/image/ImageTarballTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/image/ImageTarballTest.java
index 0ad3c8cafc..cf7d1f72ba 100644
--- a/jib-core/src/test/java/com/google/cloud/tools/jib/image/ImageTarballTest.java
+++ b/jib-core/src/test/java/... | true |
GoogleContainerTools/jib | 4,447 | issue_to_patch | maven release v3.5.0 | To be merged after the release is complete. | e36945a624425d3a846668005de26cdf34234730 | 9880e2477f94521e4b2ecfc48e705c96c037d074 | diff --git a/jib-maven-plugin/gradle.properties b/jib-maven-plugin/gradle.properties
index 661cf7dc97..9f8c4c2dfa 100644
--- a/jib-maven-plugin/gradle.properties
+++ b/jib-maven-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.4.7-SNAPSHOT
+version = 3.5.1-SNAPSHOT
| [
"jib-maven-plugin/gradle.properties"
] | [
{
"comment": "\n\nThis version bump to `3.5.1-SNAPSHOT` correctly prepares for the next development cycle after the `3.5.0` release. However, I noticed that `jib-maven-plugin/CHANGELOG.md` does not yet contain the entries for the `3.5.0` rele... | true | ||
GoogleContainerTools/jib | 4,445 | issue_to_patch | core release v0.28.0 | To be merged after the release is complete. | e36945a624425d3a846668005de26cdf34234730 | de08a7e66133c0907a4ec2d8f3e1d9e96c6c5659 | diff --git a/jib-core/gradle.properties b/jib-core/gradle.properties
index 087ca3a134..0b145043ac 100644
--- a/jib-core/gradle.properties
+++ b/jib-core/gradle.properties
@@ -1,1 +1,1 @@
-version = 0.27.4-SNAPSHOT
+version = 0.28.1-SNAPSHOT
| [
"jib-core/gradle.properties"
] | [
{
"comment": "\n\nWhile this version bump to `0.28.1-SNAPSHOT` is correct for the next development cycle after the `v0.28.0` release, it seems the `CHANGELOG.md` file has not been updated with the release notes for `v0.28.0`. It's a best prac... | true | ||
GoogleContainerTools/jib | 4,443 | issue_to_patch | gradle release v3.5.0 | To be merged after the release is complete. | e36945a624425d3a846668005de26cdf34234730 | 61b55fb7b15e0b7f470ae22349b6349e7769aa83 | diff --git a/jib-gradle-plugin/gradle.properties b/jib-gradle-plugin/gradle.properties
index e50b15214e..9f8c4c2dfa 100644
--- a/jib-gradle-plugin/gradle.properties
+++ b/jib-gradle-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.4.6-SNAPSHOT
+version = 3.5.1-SNAPSHOT
| [
"jib-gradle-plugin/gradle.properties"
] | [
{
"comment": "\n\nThe PR title suggests a release of `v3.5.0`, but the version is being bumped directly from `3.4.6-SNAPSHOT` to `3.5.1-SNAPSHOT`. This approach skips the `3.5.0` version in the commit history, which can be confusing. A more stand... | true | ||
GoogleContainerTools/jib | 4,436 | issue_to_patch | feat: add default base image for Java 25 | 87b4c0e1dd16419f7920a3b498ed1c4e310909a8 | e841ee229ed8f19a3bfe99858d3e583b49f70d62 | diff --git a/docs/google-cloud-build.md b/docs/google-cloud-build.md
index 71d779bdaa..d3996ce82c 100644
--- a/docs/google-cloud-build.md
+++ b/docs/google-cloud-build.md
@@ -13,7 +13,7 @@ Any Java container can be used for building, not only the `gcr.io/cloud-builders
```yaml
steps:
- - name: 'docker.io/library/e... | [
"docs/google-cloud-build.md",
"jib-cli/src/main/java/com/google/cloud/tools/jib/cli/jar/JarFiles.java",
"jib-cli/src/test/java/com/google/cloud/tools/jib/cli/jar/JarFilesTest.java",
"jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/ContainerizerIntegrationTest.java",
"jib-gradle-plugin/READ... | [] | diff --git a/jib-cli/src/test/java/com/google/cloud/tools/jib/cli/jar/JarFilesTest.java b/jib-cli/src/test/java/com/google/cloud/tools/jib/cli/jar/JarFilesTest.java
index 225d242ca0..7e7a597ef0 100644
--- a/jib-cli/src/test/java/com/google/cloud/tools/jib/cli/jar/JarFilesTest.java
+++ b/jib-cli/src/test/java/com/google... | true | ||
GoogleContainerTools/jib | 4,398 | issue_to_patch | Docs site redirection is down
The `docs/README.md` has a link to `https://googlecontainertools.github.io/jib/` which doesn't exist (404)
https://github.com/GoogleContainerTools/jib/blob/master/docs/README.md | chore: remove unused file related to wiki page | I believe these files are not used anymore as we mived the FAQ to the [docs folder](https://github.com/GoogleContainerTools/jib/blob/master/docs/faq.md) within the repository.
Fixes https://github.com/GoogleContainerTools/jib/issues/4380 | 586b4a6f57f208bb4128aa7286741a23bf9eda7b | 0a5184177118936f46f2f06a7af5043f2a9e9903 | diff --git a/docs/README.md b/docs/README.md
deleted file mode 100644
index 4f1a51ed9b..0000000000
--- a/docs/README.md
+++ /dev/null
@@ -1,1 +0,0 @@
-These docs generate [googlecontainertools.github.io/jib](https://googlecontainertools.github.io/jib/).
diff --git a/docs/_config.yml b/docs/_config.yml
deleted file mode... | [
"docs/README.md",
"docs/_config.yml"
] | [] | true | |
GoogleContainerTools/jib | 4,392 | issue_to_patch | maven release v3.4.6 | To be merged after the release is complete. | 45b95af0d08b61d831c11cbe3bdae74a74873fc7 | ea80a92916240c3a6b6814289aa57b55f7a36bca | diff --git a/jib-maven-plugin/gradle.properties b/jib-maven-plugin/gradle.properties
index e50b15214e..661cf7dc97 100644
--- a/jib-maven-plugin/gradle.properties
+++ b/jib-maven-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.4.6-SNAPSHOT
+version = 3.4.7-SNAPSHOT
| [
"jib-maven-plugin/gradle.properties"
] | [] | true | ||
GoogleContainerTools/jib | 4,394 | issue_to_patch | chore: update docs for jib-maven-plugin v3.4.6 release | fb6a9a120761a0a45c0657c6678ac3e46f83bf59 | db7543865339b6b7287119ea7257c77ae50708ae | diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml
index d11f63c0c6..7d64dd82e3 100644
--- a/examples/dropwizard/pom.xml
+++ b/examples/dropwizard/pom.xml
@@ -26,7 +26,7 @@
<dropwizard-template-config.version>1.5.0</dropwizard-template-config.version>
<jib.container.appRoot>/app<... | [
"examples/dropwizard/pom.xml",
"examples/helloworld/pom.xml",
"examples/java-agent/pom.xml",
"examples/multi-module/pom.xml",
"examples/spring-boot/pom.xml",
"jib-maven-plugin/CHANGELOG.md",
"jib-maven-plugin/README.md"
] | [] | true | |||
GoogleContainerTools/jib | 4,345 | issue_to_patch | Jib Maven Plugin 3.4.4 doesn't consider user properties properly (breaks on Maven 4)
**Environment**:
- *Jib version:* 3.4.4
- *Build tool:* Maven 4.0.0-rc-2
- *OS:* macOS 15.2 arm64
**Description of the issue**:
I have a working project with jib-maven-plugin 3.4.4 using Maven 3.9.9, but when I tried it wi... | Check Maven user properties with highest precedence when fetching a property value | Fixes #4344 🛠️
| ec548da749b4e7c9146c7db3207631bb64414cde | 0cca78c0eb445536cdaa166ab0e99df6132324cf | diff --git a/jib-maven-plugin/CHANGELOG.md b/jib-maven-plugin/CHANGELOG.md
index 94750aa3c2..367a6a6f66 100644
--- a/jib-maven-plugin/CHANGELOG.md
+++ b/jib-maven-plugin/CHANGELOG.md
@@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file.
### Added
### Changed
+- Update retrieval of Mav... | [
"jib-maven-plugin/CHANGELOG.md",
"jib-maven-plugin/README.md",
"jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenProjectProperties.java",
"jib-maven-plugin/src/test/java/com/google/cloud/tools/jib/maven/JibPluginConfigurationTest.java"
] | [
{
"comment": "can getUserProperties be null? if so can you please add null check too?",
"path": "jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenProjectProperties.java",
"hunk": "@@ -132,23 +132,27 @@ public static MavenProjectProperties getForProject(\n }\n \n /**\n- * Gets a... | diff --git a/jib-maven-plugin/src/test/java/com/google/cloud/tools/jib/maven/JibPluginConfigurationTest.java b/jib-maven-plugin/src/test/java/com/google/cloud/tools/jib/maven/JibPluginConfigurationTest.java
index e6d0b7bdef..b518fbc321 100644
--- a/jib-maven-plugin/src/test/java/com/google/cloud/tools/jib/maven/JibPlug... | true |
GoogleContainerTools/jib | 4,345 | comment_to_fix | Check Maven user properties with highest precedence when fetching a property value | can getUserProperties be null? if so can you please add null check too? | ec548da749b4e7c9146c7db3207631bb64414cde | 0cca78c0eb445536cdaa166ab0e99df6132324cf | diff --git a/jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenProjectProperties.java b/jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenProjectProperties.java
index 7b457951c6..1bc6cbe1b0 100644
--- a/jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenProjectPro... | [
"jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenProjectProperties.java"
] | [
{
"comment": "can getUserProperties be null? if so can you please add null check too?",
"path": "jib-maven-plugin/src/main/java/com/google/cloud/tools/jib/maven/MavenProjectProperties.java",
"hunk": "@@ -132,23 +132,27 @@ public static MavenProjectProperties getForProject(\n }\n \n /**\n- * Gets a... | true | ||
GoogleContainerTools/jib | 4,345 | comment_to_fix | Check Maven user properties with highest precedence when fetching a property value | please update to
"Update retrieval of maven properties to use the following order: user, project, system" | ec548da749b4e7c9146c7db3207631bb64414cde | 0cca78c0eb445536cdaa166ab0e99df6132324cf | diff --git a/jib-maven-plugin/CHANGELOG.md b/jib-maven-plugin/CHANGELOG.md
index 94750aa3c2..367a6a6f66 100644
--- a/jib-maven-plugin/CHANGELOG.md
+++ b/jib-maven-plugin/CHANGELOG.md
@@ -6,6 +6,7 @@ All notable changes to this project will be documented in this file.
### Added
### Changed
+- Update retrieval of Mav... | [
"jib-maven-plugin/CHANGELOG.md"
] | [
{
"comment": "please update to\r\n\r\n\"Update retrieval of maven properties to use the following order: user, project, system\"",
"path": "jib-maven-plugin/CHANGELOG.md",
"hunk": "@@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file.\n ## [unreleased]\n \n ### Added\n+- C... | true | ||
GoogleContainerTools/jib | 4,362 | issue_to_patch | core release v0.27.3 | To be merged after the release is complete. | 670aad5ae13382f262b69cdeb05abf61f446ab25 | 094843e5cbb21eca515653dc447287f283d21c24 | diff --git a/jib-core/gradle.properties b/jib-core/gradle.properties
index 1d352d7234..087ca3a134 100644
--- a/jib-core/gradle.properties
+++ b/jib-core/gradle.properties
@@ -1,1 +1,1 @@
-version = 0.27.3-SNAPSHOT
+version = 0.27.4-SNAPSHOT
| [
"jib-core/gradle.properties"
] | [] | true | ||
GoogleContainerTools/jib | 4,364 | issue_to_patch | gradle release v3.4.5 | To be merged after the release is complete. | 670aad5ae13382f262b69cdeb05abf61f446ab25 | 4e4211db595740c37d3ad0f7fdb579d2b372b9ed | diff --git a/jib-gradle-plugin/gradle.properties b/jib-gradle-plugin/gradle.properties
index f78665a194..e50b15214e 100644
--- a/jib-gradle-plugin/gradle.properties
+++ b/jib-gradle-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.4.5-SNAPSHOT
+version = 3.4.6-SNAPSHOT
| [
"jib-gradle-plugin/gradle.properties"
] | [] | true | ||
GoogleContainerTools/jib | 4,366 | issue_to_patch | maven release v3.4.5 | To be merged after the release is complete. | 670aad5ae13382f262b69cdeb05abf61f446ab25 | 3770d19801c96a80de575ec564fade154237f1ee | diff --git a/jib-maven-plugin/gradle.properties b/jib-maven-plugin/gradle.properties
index f78665a194..e50b15214e 100644
--- a/jib-maven-plugin/gradle.properties
+++ b/jib-maven-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.4.5-SNAPSHOT
+version = 3.4.6-SNAPSHOT
| [
"jib-maven-plugin/gradle.properties"
] | [] | true | ||
GoogleContainerTools/jib | 4,361 | issue_to_patch | chore: grant access for bots to push tags and create issues for release workflows | f3fa52e794ea10660a33265f3f7e2ab7e8252661 | d4a22d3f71af49ca2226abe571a3df2b0a9bbde8 | diff --git a/.github/workflows/jib-cli-release.yml b/.github/workflows/jib-cli-release.yml
index a6507f8a19..cdebc3eb69 100644
--- a/.github/workflows/jib-cli-release.yml
+++ b/.github/workflows/jib-cli-release.yml
@@ -7,6 +7,10 @@ on:
required: true
default: (for example, 0.1.0)
+permissions:
+ co... | [
".github/workflows/jib-cli-release.yml",
".github/workflows/prepare-release.yml"
] | [] | true | |||
GoogleContainerTools/jib | 4,356 | issue_to_patch | chore: explicitly state we should use java 8 in github prepare release action | c87a744c258f82d09517c83e2103afcedaf65b1e | 2bb58614c609bee58f6f96e4871e1f0255e8dfe5 | diff --git a/.github/workflows/jib-cli-release.yml b/.github/workflows/jib-cli-release.yml
index 2284e1f78e..a6507f8a19 100644
--- a/.github/workflows/jib-cli-release.yml
+++ b/.github/workflows/jib-cli-release.yml
@@ -18,6 +18,12 @@ jobs:
- name: Check out code
uses: actions/checkout@v4
+ - name... | [
".github/workflows/jib-cli-release.yml",
".github/workflows/prepare-release.yml"
] | [] | true | |||
GoogleContainerTools/jib | 4,355 | issue_to_patch | chore: update docs and examples for 3.4.5 and 0.27.3 releases | 390c175c95a4396ecb7c63e6bab8dec04050b63f | ef088641214753182c8271375e1b88b956f780ec | diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml
index ba520eec2d..d11f63c0c6 100644
--- a/examples/dropwizard/pom.xml
+++ b/examples/dropwizard/pom.xml
@@ -26,7 +26,7 @@
<dropwizard-template-config.version>1.5.0</dropwizard-template-config.version>
<jib.container.appRoot>/app<... | [
"examples/dropwizard/pom.xml",
"examples/helloworld/build.gradle",
"examples/helloworld/pom.xml",
"examples/java-agent/build.gradle",
"examples/java-agent/pom.xml",
"examples/ktor/build.gradle.kts",
"examples/micronaut/build.gradle",
"examples/multi-module/build.gradle",
"examples/multi-module/pom.x... | [] | true | |||
GoogleContainerTools/jib | 4,351 | issue_to_patch | No progress after "Container entrypoint set to" with jib-maven-plugin 3.4.3
<!--
Please follow the guidelines below before opening an issue:
1. Ensure the issue was not already reported.
2. Open a new issue if you are unable to find an existing issue addressing your problem. Make sure to include a title and clear ... | fix: windows deadlock while executing docker commands (#4267) | Fixes #4267 | 5d9beaee002e21fdeeb868edbc09e3727696937c | 9d2b9f7ea816400d3becb736562c8e30fea19d7f | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java b/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java
index 035c9316f3..37d0e3ef2d 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java
+++ b/jib-core/src/main/java/... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java",
"jib-core/src/test/java/com/google/cloud/tools/jib/docker/CliDockerClientTest.java"
] | [] | diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/docker/CliDockerClientTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/docker/CliDockerClientTest.java
index a88539f8c0..2b451ebe05 100644
--- a/jib-core/src/test/java/com/google/cloud/tools/jib/docker/CliDockerClientTest.java
+++ b/jib-core/sr... | true |
GoogleContainerTools/jib | 4,333 | issue_to_patch | Fix Link in CHANGELOG.md | The issue number is 4267, but the link is 4265.
| aac44d35da214e55cc2b98ed138b84737e061005 | 1642b83187345147ffbf65f669e25cfa857d6fe3 | diff --git a/jib-gradle-plugin/CHANGELOG.md b/jib-gradle-plugin/CHANGELOG.md
index c2364cd7a4..45d6741efd 100644
--- a/jib-gradle-plugin/CHANGELOG.md
+++ b/jib-gradle-plugin/CHANGELOG.md
@@ -11,7 +11,7 @@ All notable changes to this project will be documented in this file.
## 3.4.4
- fix: allow pushing images with ... | [
"jib-gradle-plugin/CHANGELOG.md"
] | [] | true | ||
GoogleContainerTools/jib | 4,319 | issue_to_patch | fix: add timeout for docker info read to prevent Jib from getting stuck indefinitely | #4311
1. Fixed gradle and maven integration tests to make mock docker executable output OSType and Architecture. As discovered in https://github.com/GoogleContainerTools/jib/issues/4311#issuecomment-2405793374, Jib ran successfully when the `docker` client was used but was getting stuck indefinitely when a custom d... | a3c0c5b31dfc813c88c5843641a0e2bd4c8ffa0f | 40572c45881e80a5ed75ca6045c163fa220a7fb3 | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java b/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java
index d3dcecd883..035c9316f3 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java
+++ b/jib-core/src/main/java/... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java",
"jib-gradle-plugin/src/integration-test/resources/gradle/projects/simple/mock-docker.sh",
"jib-maven-plugin/src/test/resources/maven/projects/simple/mock-docker.sh"
] | [] | diff --git a/jib-maven-plugin/src/test/resources/maven/projects/simple/mock-docker.sh b/jib-maven-plugin/src/test/resources/maven/projects/simple/mock-docker.sh
index e4b78a0f4c..84eafa19a8 100755
--- a/jib-maven-plugin/src/test/resources/maven/projects/simple/mock-docker.sh
+++ b/jib-maven-plugin/src/test/resources/ma... | true | |
GoogleContainerTools/jib | 4,321 | issue_to_patch | core release v0.27.2 | To be merged after the release is complete. | a3c0c5b31dfc813c88c5843641a0e2bd4c8ffa0f | f1a3920c9b2633e867ce2190c7545b14c8e34e21 | diff --git a/jib-core/gradle.properties b/jib-core/gradle.properties
index 67f1f13bde..1d352d7234 100644
--- a/jib-core/gradle.properties
+++ b/jib-core/gradle.properties
@@ -1,1 +1,1 @@
-version = 0.27.2-SNAPSHOT
+version = 0.27.3-SNAPSHOT
| [
"jib-core/gradle.properties"
] | [] | true | ||
GoogleContainerTools/jib | 4,323 | issue_to_patch | gradle release v3.4.4 | To be merged after the release is complete. | a3c0c5b31dfc813c88c5843641a0e2bd4c8ffa0f | 4a6711ba1039504d479a2c2041b3318853de17d3 | diff --git a/jib-gradle-plugin/gradle.properties b/jib-gradle-plugin/gradle.properties
index 882261a1db..f78665a194 100644
--- a/jib-gradle-plugin/gradle.properties
+++ b/jib-gradle-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.4.4-SNAPSHOT
+version = 3.4.5-SNAPSHOT
| [
"jib-gradle-plugin/gradle.properties"
] | [] | true | ||
GoogleContainerTools/jib | 4,325 | issue_to_patch | maven release v3.4.4 | To be merged after the release is complete. | a3c0c5b31dfc813c88c5843641a0e2bd4c8ffa0f | 0a9408a20e69047ed3d04f9dc5ff0d326533c46b | diff --git a/jib-maven-plugin/gradle.properties b/jib-maven-plugin/gradle.properties
index 882261a1db..f78665a194 100644
--- a/jib-maven-plugin/gradle.properties
+++ b/jib-maven-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.4.4-SNAPSHOT
+version = 3.4.5-SNAPSHOT
| [
"jib-maven-plugin/gradle.properties"
] | [] | true | ||
GoogleContainerTools/jib | 4,329 | issue_to_patch | chore: update docs and examples for 3.4.4 and 0.27.2 releases | a3c0c5b31dfc813c88c5843641a0e2bd4c8ffa0f | 4944d13cf53378dcd1b441f619b0aec6f31a42d9 | diff --git a/examples/dropwizard/pom.xml b/examples/dropwizard/pom.xml
index 1a0780ecde..ba520eec2d 100644
--- a/examples/dropwizard/pom.xml
+++ b/examples/dropwizard/pom.xml
@@ -26,7 +26,7 @@
<dropwizard-template-config.version>1.5.0</dropwizard-template-config.version>
<jib.container.appRoot>/app<... | [
"examples/dropwizard/pom.xml",
"examples/helloworld/build.gradle",
"examples/helloworld/pom.xml",
"examples/java-agent/build.gradle",
"examples/java-agent/pom.xml",
"examples/ktor/build.gradle.kts",
"examples/micronaut/build.gradle",
"examples/multi-module/build.gradle",
"examples/multi-module/pom.x... | [] | true | |||
GoogleContainerTools/jib | 4,307 | issue_to_patch | [jib cli] chore: remove duplicate test method for verifying --from argument | This test method was originally introduced to verify the `--from` parameter of the Jib CLI command in https://github.com/GoogleContainerTools/jib/pull/2972. However, this is already being verified by the other test methods in this class (see `testStandardJar_explodedMode_toDocker` for example).
As part of cleanup f... | ad27daf4aff48b680aa78b0fb85963fd913a75ea | 15726a7d0e4fcbb84e6d21df14f36862f48698b9 | diff --git a/jib-cli/src/integration-test/java/com/google/cloud/tools/jib/cli/JarCommandTest.java b/jib-cli/src/integration-test/java/com/google/cloud/tools/jib/cli/JarCommandTest.java
index d1c2bce75b..557b0ba703 100644
--- a/jib-cli/src/integration-test/java/com/google/cloud/tools/jib/cli/JarCommandTest.java
+++ b/ji... | [
"jib-cli/src/integration-test/java/com/google/cloud/tools/jib/cli/JarCommandTest.java"
] | [] | true | ||
GoogleContainerTools/jib | 4,290 | issue_to_patch | chore(deps): bump gradle/wrapper-validation-action from 3.3.2 to 3.5.0 | Bumps [gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action) from 3.3.2 to 3.5.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/gradle/wrapper-validation-action/releases">gradle/wrapper-validation-action's releases</a>.</em></p>
<blockquote>
... | 45610ea5e6e29b6feb93fea2e186db91be514002 | de953d87fbc9bba3460deeee25cc54a1f148d165 | diff --git a/.github/workflows/gradle-wrapper-validation.yml b/.github/workflows/gradle-wrapper-validation.yml
index 8b1220b701..1d76e03ecd 100644
--- a/.github/workflows/gradle-wrapper-validation.yml
+++ b/.github/workflows/gradle-wrapper-validation.yml
@@ -7,4 +7,4 @@ jobs:
runs-on: ubuntu-latest
steps:
... | [
".github/workflows/gradle-wrapper-validation.yml"
] | [] | true | ||
GoogleContainerTools/jib | 4,292 | issue_to_patch | chore: update release workflow | Thank you for your interest in contributing! For general guidelines, please refer to
the [contributing guide](https://github.com/GoogleContainerTools/jib/blob/master/CONTRIBUTING.md).
Please follow the guidelines below before opening an issue or a PR:
- [ ] Ensure the issue was not already reported.
- [ ] Create... | 18d5c77392964ee417ba563084fe8335cb90a11c | 9d6bc0ab5a77c70f58c49d59ec107abc5c13b959 | diff --git a/.github/workflows/jib-cli-release.yml b/.github/workflows/jib-cli-release.yml
index db857d627b..2284e1f78e 100644
--- a/.github/workflows/jib-cli-release.yml
+++ b/.github/workflows/jib-cli-release.yml
@@ -56,9 +56,7 @@ jobs:
uses: repo-sync/pull-request@v2.12.1
id: create-pr
wit... | [
".github/workflows/jib-cli-release.yml",
".github/workflows/prepare-release.yml"
] | [] | true | ||
GoogleContainerTools/jib | 4,249 | issue_to_patch | feat: determine platform details from local docker installation for jibDockerBuild | This code has been tested manually with `jib/examples/helloworld/`.
**Notes:**
- If manifest list found then the log picks the image that contains the same os and architecture as the local docker environment (derived through `docker info`). Otherwise, it throws an error when no matching os and architecture are ... | 8b13f0d1bd4d88d7b3503b570ae065e322daaf47 | 8eadc59b484b567cad1f32fc2a785a372f71fe9a | diff --git a/config/checkstyle/copyright-java.header b/config/checkstyle/copyright-java.header
index d15ad5912e..e60211cae3 100644
--- a/config/checkstyle/copyright-java.header
+++ b/config/checkstyle/copyright-java.header
@@ -1,5 +1,5 @@
^/\*$
-^ \* Copyright 20(17|18|19|20|21|22|23) Google LLC\.$
+^ \* Copyright 20(... | [
"config/checkstyle/copyright-java.header",
"jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java",
"jib-core/src/main/java/com/google/cloud/tools/jib/api/DockerClient.java",
"jib-core/src/main/java/com/google/cloud/tools/jib/api/DockerInfoDetails.java",
"jib-core/src/mai... | [
{
"comment": "Shall we error out if no matching found?",
"path": "jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java",
"hunk": "@@ -647,4 +649,28 @@ private void writeTarFile(\n private <E> List<Future<E>> scheduleCallables(ImmutableList<? extends Callable<E>> callables) ... | diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/StepsRunnerTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/StepsRunnerTest.java
index e8a60de2d5..9436c7df4a 100644
--- a/jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/StepsRunnerTest.java
+++ b/ji... | true | |
GoogleContainerTools/jib | 4,249 | comment_to_fix | feat: determine platform details from local docker installation for jibDockerBuild | Shall we error out if no matching found? | 8b13f0d1bd4d88d7b3503b570ae065e322daaf47 | 8eadc59b484b567cad1f32fc2a785a372f71fe9a | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java b/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java
index 46c63bfc9d..be760a13eb 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java
+++ b/jib-core/src/m... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java"
] | [
{
"comment": "Shall we error out if no matching found?",
"path": "jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java",
"hunk": "@@ -647,4 +649,28 @@ private void writeTarFile(\n private <E> List<Future<E>> scheduleCallables(ImmutableList<? extends Callable<E>> callables) ... | true | ||
GoogleContainerTools/jib | 4,249 | comment_to_fix | feat: determine platform details from local docker installation for jibDockerBuild | This could be just docker info details, `os and architecture` are implementation details of `DockerInfoDetails`, and we could add more attributes later. | 8b13f0d1bd4d88d7b3503b570ae065e322daaf47 | 8eadc59b484b567cad1f32fc2a785a372f71fe9a | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/api/DockerClient.java b/jib-core/src/main/java/com/google/cloud/tools/jib/api/DockerClient.java
index 50ce2f463f..7e08a79495 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/api/DockerClient.java
+++ b/jib-core/src/main/java/com/google/cloud/t... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/api/DockerClient.java"
] | [
{
"comment": "This could be just docker info details, `os and architecture` are implementation details of `DockerInfoDetails`, and we could add more attributes later.",
"path": "jib-core/src/main/java/com/google/cloud/tools/jib/api/DockerClient.java",
"hunk": "@@ -69,4 +69,15 @@ void save(ImageReference... | true | ||
GoogleContainerTools/jib | 4,249 | comment_to_fix | feat: determine platform details from local docker installation for jibDockerBuild | Maybe add `osType` and `architecture` to the log? | 8b13f0d1bd4d88d7b3503b570ae065e322daaf47 | 8eadc59b484b567cad1f32fc2a785a372f71fe9a | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java b/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java
index 46c63bfc9d..be760a13eb 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java
+++ b/jib-core/src/m... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java"
] | [
{
"comment": "Maybe add `osType` and `architecture` to the log?",
"path": "jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java",
"hunk": "@@ -647,4 +656,29 @@ private void writeTarFile(\n private <E> List<Future<E>> scheduleCallables(ImmutableList<? extends Callable<E>> ca... | true | ||
GoogleContainerTools/jib | 4,249 | comment_to_fix | feat: determine platform details from local docker installation for jibDockerBuild | Add unit tests for different scenarios, e.g. `OSType` does not exist etc. | 8b13f0d1bd4d88d7b3503b570ae065e322daaf47 | 8eadc59b484b567cad1f32fc2a785a372f71fe9a | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/api/DockerInfoDetails.java b/jib-core/src/main/java/com/google/cloud/tools/jib/api/DockerInfoDetails.java
new file mode 100644
index 0000000000..fa486c40f9
--- /dev/null
+++ b/jib-core/src/main/java/com/google/cloud/tools/jib/api/DockerInfoDetails.java
@@ -... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/api/DockerInfoDetails.java"
] | [
{
"comment": "Add unit tests for different scenarios, e.g. `OSType` does not exist etc.",
"path": "jib-core/src/main/java/com/google/cloud/tools/jib/api/DockerInfoDetails.java",
"hunk": "@@ -0,0 +1,40 @@\n+/*\n+ * Copyright 2024 Google LLC.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \... | true | ||
GoogleContainerTools/jib | 4,249 | comment_to_fix | feat: determine platform details from local docker installation for jibDockerBuild | I see that they are already tested in `JibIntegrationTest`, but ideally I think the different cases should be tested in `StepsRunnerTest` since we don't have to run docker engine. I'll leave it to you to decide if the refactoring it needed. | 8b13f0d1bd4d88d7b3503b570ae065e322daaf47 | 8eadc59b484b567cad1f32fc2a785a372f71fe9a | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java b/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java
index 46c63bfc9d..be760a13eb 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java
+++ b/jib-core/src/m... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java"
] | [
{
"comment": "I see that they are already tested in `JibIntegrationTest`, but ideally I think the different cases should be tested in `StepsRunnerTest` since we don't have to run docker engine. I'll leave it to you to decide if the refactoring it needed. ",
"path": "jib-core/src/main/java/com/google/cloud/t... | true | ||
GoogleContainerTools/jib | 4,288 | issue_to_patch | fix: address windows deadlock issue when determining docker environment info | For https://github.com/GoogleContainerTools/jib/issues/4267
Reproducer: https://github.com/mpeddada1/windows_deadlock (note that this reproducer doesn't using `docker` but showcases the same issue observed in https://github.com/GoogleContainerTools/jib/issues/4267). According to the official documentation:
```
B... | ff15988e5eb36c686e7db47abb31bdc15c88f44a | bbc87dcc9578572edbf4c13d885a2f6d523e870b | diff --git a/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java b/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java
index 1842a79de3..d3dcecd883 100644
--- a/jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java
+++ b/jib-core/src/main/java/... | [
"jib-core/src/main/java/com/google/cloud/tools/jib/docker/CliDockerClient.java"
] | [] | true | ||
GoogleContainerTools/jib | 4,268 | issue_to_patch | Impossible to build amd-64 docker on Mac M3 machine
Starting 3.4.3 version of `jib-maven-plugin` it is not possible to build amd-64 image on Mac with Mx chip (arm-64)
I didn't find a setting, that fix it. There is no problem with 3.4.2 version. | fix: allow pushing images with different arch/os to docker daemon | Fixes #4265
- Avoid throwing exception when building image with mismatched arch/os to the local docker daemon.
- Follow convention of using event handlers to log warning when building for matching os/arch. Example: https://github.com/GoogleContainerTools/jib/blob/b06b001ed26b6a1fedc1ac738f628513390433e9/jib-core/src/... | b06b001ed26b6a1fedc1ac738f628513390433e9 | 71772a6025cc0dfc84fcfb473e82f9217953d44d | diff --git a/jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java b/jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java
index 4e49d1e12d..bf60f5d025 100644
--- a/jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTes... | [
"jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java",
"jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibMultiPlatformIntegrationTest.java",
"jib-core/src/main/java/com/google/cloud/tools/jib/builder/steps/StepsRunner.java",
"jib-core/src/test/java/com... | [
{
"comment": "TODO(@mpeddada1): Add test for single image build with different os/arch. ",
"path": "jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java",
"hunk": "@@ -343,27 +342,38 @@ public void testBasicMultiPlatform_toDockerDaemon()\n }\n \n @Test\n- publi... | diff --git a/jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/StepsRunnerTest.java b/jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/StepsRunnerTest.java
index 9436c7df4a..6468ee051b 100644
--- a/jib-core/src/test/java/com/google/cloud/tools/jib/builder/steps/StepsRunnerTest.java
+++ b/ji... | true |
GoogleContainerTools/jib | 4,268 | comment_to_fix | fix: allow pushing images with different arch/os to docker daemon | TODO(@mpeddada1): Add test for single image build with different os/arch. | b06b001ed26b6a1fedc1ac738f628513390433e9 | 71772a6025cc0dfc84fcfb473e82f9217953d44d | diff --git a/jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java b/jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java
index 4e49d1e12d..bf60f5d025 100644
--- a/jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTes... | [
"jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java"
] | [
{
"comment": "TODO(@mpeddada1): Add test for single image build with different os/arch. ",
"path": "jib-core/src/integration-test/java/com/google/cloud/tools/jib/api/JibIntegrationTest.java",
"hunk": "@@ -343,27 +342,38 @@ public void testBasicMultiPlatform_toDockerDaemon()\n }\n \n @Test\n- publi... | true | ||
GoogleContainerTools/jib | 2,273 | issue_to_patch | Improve checkstyle config | - update checkstyle to 8.29
- improve config modification
- add temporary check suppressions so fixes can go in gradually
beginning of #2272 | 4f438d4c66775a34f433eacd5e3758d69ac00d03 | 84f8d508452696357280b5ef9faf43d321ceee02 | diff --git a/build.gradle b/build.gradle
index 259224fa70..2526826d5f 100644
--- a/build.gradle
+++ b/build.gradle
@@ -117,39 +117,27 @@ subprojects {
/* CHECKSTYLE */
checkstyle {
- toolVersion = '8.18'
+ toolVersion = '8.29'
- // use the google checks packaged with the jar
+ // use google checks... | [
"build.gradle",
"config/checkstyle/checkstyle-suppressions.xml"
] | [
{
"comment": "refrenced --> referenced",
"path": "build.gradle",
"hunk": "@@ -117,39 +117,27 @@ subprojects {\n \n /* CHECKSTYLE */\n checkstyle {\n- toolVersion = '8.18'\n+ toolVersion = '8.29'\n \n- // use the google checks packaged with the jar\n+ // use google checks from the jar\n ... | true | ||
GoogleContainerTools/jib | 2,273 | comment_to_fix | Improve checkstyle config | refrenced --> referenced | 4f438d4c66775a34f433eacd5e3758d69ac00d03 | 84f8d508452696357280b5ef9faf43d321ceee02 | diff --git a/build.gradle b/build.gradle
index 259224fa70..2526826d5f 100644
--- a/build.gradle
+++ b/build.gradle
@@ -117,39 +117,27 @@ subprojects {
/* CHECKSTYLE */
checkstyle {
- toolVersion = '8.18'
+ toolVersion = '8.29'
- // use the google checks packaged with the jar
+ // use google checks... | [
"build.gradle"
] | [
{
"comment": "refrenced --> referenced",
"path": "build.gradle",
"hunk": "@@ -117,39 +117,27 @@ subprojects {\n \n /* CHECKSTYLE */\n checkstyle {\n- toolVersion = '8.18'\n+ toolVersion = '8.29'\n \n- // use the google checks packaged with the jar\n+ // use google checks from the jar\n ... | true | ||
GoogleContainerTools/jib | 2,273 | comment_to_fix | Improve checkstyle config | So hopefully we will eventually fix these violations? | 4f438d4c66775a34f433eacd5e3758d69ac00d03 | 84f8d508452696357280b5ef9faf43d321ceee02 | diff --git a/config/checkstyle/checkstyle-suppressions.xml b/config/checkstyle/checkstyle-suppressions.xml
new file mode 100644
index 0000000000..dc3965226f
--- /dev/null
+++ b/config/checkstyle/checkstyle-suppressions.xml
@@ -0,0 +1,38 @@
+<?xml version="1.0"?>
+<!DOCTYPE suppressions PUBLIC
+ "-//Puppy Crawl//DTD Su... | [
"config/checkstyle/checkstyle-suppressions.xml"
] | [
{
"comment": "So hopefully we will eventually fix these violations?",
"path": "config/checkstyle/checkstyle-suppressions.xml",
"hunk": "@@ -0,0 +1,38 @@\n+<?xml version=\"1.0\"?>\n+<!DOCTYPE suppressions PUBLIC\n+ \"-//Puppy Crawl//DTD Suppressions 1.1//EN\"\n+ \"http://www.puppycrawl.com/dtds/suppres... | true | ||
GoogleContainerTools/jib | 4,243 | issue_to_patch | chore(deps): bump gradle/wrapper-validation-action from 2.1.2 to 3.3.2 | Bumps [gradle/wrapper-validation-action](https://github.com/gradle/wrapper-validation-action) from 2.1.2 to 3.3.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/gradle/wrapper-validation-action/releases">gradle/wrapper-validation-action's releases</a>.</em></p>
<blockquote>
... | 97ed78631c516117cc8fc837d76c58ad8e668e6e | 17d2b90f72e25d4dda5bd7438e38319a8f1086e1 | diff --git a/.github/workflows/gradle-wrapper-validation.yml b/.github/workflows/gradle-wrapper-validation.yml
index e2689d6661..8b1220b701 100644
--- a/.github/workflows/gradle-wrapper-validation.yml
+++ b/.github/workflows/gradle-wrapper-validation.yml
@@ -7,4 +7,4 @@ jobs:
runs-on: ubuntu-latest
steps:
... | [
".github/workflows/gradle-wrapper-validation.yml"
] | [] | true | ||
GoogleContainerTools/jib | 4,192 | issue_to_patch | Update CONTRIBUTING guidelines | b/323273546
| fb34ae43e614f228b62f355458f66a9d00640ce4 | 81da55ebe4c9530d1827aba1addb6ab4fb7040ea | diff --git a/.github/ISSUE_TEMPLATE/issue_report.md b/.github/ISSUE_TEMPLATE/issue_report.md
index 73c5bbeffe..804b3a3f1e 100644
--- a/.github/ISSUE_TEMPLATE/issue_report.md
+++ b/.github/ISSUE_TEMPLATE/issue_report.md
@@ -8,7 +8,13 @@ assignees: ''
---
<!--
-Before filing an issue, please reproduce with the latest... | [
".github/ISSUE_TEMPLATE/issue_report.md",
".github/PULL_REQUEST_TEMPLATE.md",
"CONTRIBUTING.md"
] | [
{
"comment": "I think these checkboxes are still very valid, can we keep them? I know people are not really following them right now but it still helps. ",
"path": ".github/PULL_REQUEST_TEMPLATE.md",
"hunk": "@@ -1,14 +1,10 @@\n Thank you for your interest in contributing! For general guidelines, please... | true | ||
GoogleContainerTools/jib | 4,205 | issue_to_patch | Security Policy violation Binary Artifacts
_This issue was automatically created by [Allstar](https://github.com/ossf/allstar/)._
**Security Policy Violation**
Project is out of compliance with Binary Artifacts policy: binaries present in source code
**Rule Description**
Binary Artifacts are an increased security ri... | chore: allstar ignore jars used for testing | Fixes: #4135.
| 9d1e3f1e51bc721cb25be021abda97c09517aa35 | 3579efe91177ab04cbacc5e57c2f4ee6b6ce5f2f | diff --git a/.allstar/binary_artifacts.yaml b/.allstar/binary_artifacts.yaml
new file mode 100644
index 0000000000..cf26dacfe8
--- /dev/null
+++ b/.allstar/binary_artifacts.yaml
@@ -0,0 +1,8 @@
+# Ignore reason: jars are used for testing purposes only
+ignorePaths:
+ - jib-cli/src/integration-test/resources/jarTest/st... | [
".allstar/binary_artifacts.yaml"
] | [] | true | |
GoogleContainerTools/jib | 4,256 | issue_to_patch | gradle release v3.4.3 | To be merged after the release is complete. | ec44330c1adbd0e1538fe01ffaa51b8233432635 | 1b86d3378e747d0a5df9abb86b4d93be270dded2 | diff --git a/jib-gradle-plugin/gradle.properties b/jib-gradle-plugin/gradle.properties
index 22c5f533ee..882261a1db 100644
--- a/jib-gradle-plugin/gradle.properties
+++ b/jib-gradle-plugin/gradle.properties
@@ -1,1 +1,1 @@
-version = 3.4.3-SNAPSHOT
+version = 3.4.4-SNAPSHOT
| [
"jib-gradle-plugin/gradle.properties"
] | [] | true | ||
GraphiteEditor/Graphite | 4,198 | issue_to_patch | Add graph-storage crate | <!--
Graphite has ZERO-TOLERANCE for contributing undisclosed AI-generated content.
If your PR involves AI, you must read our AI contribution policy (it's short):
https://graphite.art/volunteer/guide/starting-a-task/ai-contribution-policy
REMEMBER:
- You are responsible for thoroughly testing the successful impl... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/Cargo.lock b/Cargo.lock
index f3878680c1..88e882908e 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1921,6 +1921,21 @@ dependencies = [
"winit",
]
+[[package]]
+name = "graph-storage"
+version = "0.0.0"
+dependencies = [
+ "blake3",
+ "core-types",
+ "graph-craft",
+ "graphene-resource",
+ "rmp-serde",
... | [
"Cargo.lock",
"Cargo.toml",
"document/graph-storage/Cargo.toml",
"document/graph-storage/src/attributes.rs",
"document/graph-storage/src/attributes/attr.rs",
"document/graph-storage/src/crdt.rs",
"document/graph-storage/src/delta.rs",
"document/graph-storage/src/document.rs",
"document/graph-storage... | [
{
"comment": " \n\nTo prevent potential Denial of Service (DoS) or Out of Memory (OOM) vulnerabilities, we should validate the `slot` index before resizing the `e... | diff --git a/document/graph-storage/src/tests/crdt.rs b/document/graph-storage/src/tests/crdt.rs
new file mode 100644
index 0000000000..3469f5ac10
--- /dev/null
+++ b/document/graph-storage/src/tests/crdt.rs
@@ -0,0 +1,793 @@
+use core_types::uuid::NodeId as RuntimeNodeId;
+use graph_craft::ProtoNodeIdentifier;
+use gr... | true | |
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate |  
To prevent potential Denial of Service (DoS) or Out of Memory (OOM) vulnerabilities, we should validate the `slot` index before resizing the `exports` vector. A malici... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/lib.rs b/document/graph-storage/src/lib.rs
new file mode 100644
index 0000000000..0e811cd741
--- /dev/null
+++ b/document/graph-storage/src/lib.rs
@@ -0,0 +1,36 @@
+pub use graphene_resource::{ResourceHash, ResourceId};
+
+pub mod attributes;
+pub mod crdt;
+pub mod delta;
+pub m... | [
"document/graph-storage/src/lib.rs"
] | [
{
"comment": " \n\nTo prevent potential Denial of Service (DoS) or Out of Memory (OOM) vulnerabilities, we should validate the `slot` index before resizing the `e... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | 
The current implementation of `order_consistent` performs an $O(N^2)$ pairwise comparison over all shared timestamped slots. For larger documents with thousands of slots, this can cause significant performance degradation and potentially hang the U... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/lib.rs b/document/graph-storage/src/lib.rs
new file mode 100644
index 0000000000..0e811cd741
--- /dev/null
+++ b/document/graph-storage/src/lib.rs
@@ -0,0 +1,36 @@
+pub use graphene_resource::{ResourceHash, ResourceId};
+
+pub mod attributes;
+pub mod crdt;
+pub mod delta;
+pub m... | [
"document/graph-storage/src/lib.rs"
] | [
{
"comment": "\n\nThe current implementation of `order_consistent` performs an $O(N^2)$ pairwise comparison over all shared timestamped slots. For larger documents with thousands of slots, this can cause significant performance degradation an... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=33138495-5f00-4915-99ee-1de74ecb9f24 -->
<!-- cubic:review-run=57e46ace-4bc4-4820-b2d4-9f22054c7fe3 -->
<!-- metadata:{"confidence":9} -->
P1: `from_hash` uses only 64 bits of a 256-bit content hash, so distinct resources can deterministically collide to the same `ResourceId`. This can silently alias unrel... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/node-graph/libraries/resources/src/lib.rs b/node-graph/libraries/resources/src/lib.rs
index 0fffabb324..516e186371 100644
--- a/node-graph/libraries/resources/src/lib.rs
+++ b/node-graph/libraries/resources/src/lib.rs
@@ -246,6 +246,16 @@ impl ResourceId {
pub fn new() -> Self {
Self(core_types::uuid:... | [
"node-graph/libraries/resources/src/lib.rs"
] | [
{
"comment": "<!-- cubic:v=33138495-5f00-4915-99ee-1de74ecb9f24 -->\n<!-- cubic:review-run=57e46ace-4bc4-4820-b2d4-9f22054c7fe3 -->\n<!-- metadata:{\"confidence\":9} -->\nP1: `from_hash` uses only 64 bits of a 256-bit content hash, so distinct resources can deterministically collide to the same `ResourceId`. Th... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=8919ec88-d4cc-4171-8fb7-e1bb2e0885a9 -->
<!-- cubic:review-run=57e46ace-4bc4-4820-b2d4-9f22054c7fe3 -->
<!-- metadata:{"confidence":9} -->
P1: Resource references in network exports are ignored when collecting referenced resources. Export-only resources can be omitted from snapshot storage and fail to roun... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/from_runtime.rs b/document/graph-storage/src/from_runtime.rs
new file mode 100644
index 0000000000..0c2cd26f41
--- /dev/null
+++ b/document/graph-storage/src/from_runtime.rs
@@ -0,0 +1,573 @@
+use std::collections::HashMap;
+
+use core_types::Context;
+use core_types::context::Co... | [
"document/graph-storage/src/from_runtime.rs"
] | [
{
"comment": "<!-- cubic:v=8919ec88-d4cc-4171-8fb7-e1bb2e0885a9 -->\n<!-- cubic:review-run=57e46ace-4bc4-4820-b2d4-9f22054c7fe3 -->\n<!-- metadata:{\"confidence\":9} -->\nP1: Resource references in network exports are ignored when collecting referenced resources. Export-only resources can be omitted from snapsh... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=caded9e1-bf1f-4631-93b3-8e35e43474c1 -->
<!-- cubic:review-run=57e46ace-4bc4-4820-b2d4-9f22054c7fe3 -->
<!-- metadata:{"confidence":8} -->
P1: Input conversion silently truncates on `inputs`/`inputs_attributes` length mismatch due to `zip`. Return a `ConversionError` when lengths differ to avoid hidden dat... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/to_runtime.rs b/document/graph-storage/src/to_runtime.rs
new file mode 100644
index 0000000000..d9f19852ae
--- /dev/null
+++ b/document/graph-storage/src/to_runtime.rs
@@ -0,0 +1,380 @@
+use std::borrow::Cow;
+use std::collections::HashMap;
+
+use core_types::memo::MemoHash;
+use... | [
"document/graph-storage/src/to_runtime.rs"
] | [
{
"comment": "<!-- cubic:v=caded9e1-bf1f-4631-93b3-8e35e43474c1 -->\n<!-- cubic:review-run=57e46ace-4bc4-4820-b2d4-9f22054c7fe3 -->\n<!-- metadata:{\"confidence\":8} -->\nP1: Input conversion silently truncates on `inputs`/`inputs_attributes` length mismatch due to `zip`. Return a `ConversionError` when lengths... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=9f1eb50e-7d19-4b55-af96-2858e122b7d8 -->
<!-- cubic:review-run=57e46ace-4bc4-4820-b2d4-9f22054c7fe3 -->
<!-- metadata:{"confidence":9} -->
P1: `exported_nodes` changes are not diffed, so library export list updates are dropped. Emit `SetExportedNodes` when the vectors differ.
<details>
<summary>Prompt for... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/delta.rs b/document/graph-storage/src/delta.rs
new file mode 100644
index 0000000000..bcbe59a592
--- /dev/null
+++ b/document/graph-storage/src/delta.rs
@@ -0,0 +1,425 @@
+use std::collections::HashSet;
+
+use crate::{AttributeDelta, NetworkId, Node, NodeId, Registry, RegistryDel... | [
"document/graph-storage/src/delta.rs"
] | [
{
"comment": "<!-- cubic:v=9f1eb50e-7d19-4b55-af96-2858e122b7d8 -->\n<!-- cubic:review-run=57e46ace-4bc4-4820-b2d4-9f22054c7fe3 -->\n<!-- metadata:{\"confidence\":9} -->\nP1: `exported_nodes` changes are not diffed, so library export list updates are dropped. Emit `SetExportedNodes` when the vectors differ.\n\n... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=1e1ea384-17e4-4623-9c26-0067bb3b6ce5 -->
<!-- cubic:review-run=57e46ace-4bc4-4820-b2d4-9f22054c7fe3 -->
<!-- metadata:{"confidence":9} -->
P1: Node network changes are missed, so moved nodes are not updated. Include `from_node.network != to_node.network` in structural-change detection to force remove+add.
... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/delta.rs b/document/graph-storage/src/delta.rs
new file mode 100644
index 0000000000..bcbe59a592
--- /dev/null
+++ b/document/graph-storage/src/delta.rs
@@ -0,0 +1,425 @@
+use std::collections::HashSet;
+
+use crate::{AttributeDelta, NetworkId, Node, NodeId, Registry, RegistryDel... | [
"document/graph-storage/src/delta.rs"
] | [
{
"comment": "<!-- cubic:v=1e1ea384-17e4-4623-9c26-0067bb3b6ce5 -->\n<!-- cubic:review-run=57e46ace-4bc4-4820-b2d4-9f22054c7fe3 -->\n<!-- metadata:{\"confidence\":9} -->\nP1: Node network changes are missed, so moved nodes are not updated. Include `from_node.network != to_node.network` in structural-change dete... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=9a45faeb-d6bc-47ab-8fc8-ee0578f1b61a -->
<!-- cubic:review-run=57e46ace-4bc4-4820-b2d4-9f22054c7fe3 -->
<!-- metadata:{"confidence":9} -->
P2: `widget_override` does not apply the empty-string sentinel rule used by other input metadata fields. This stores unset runtime values as real overrides and changes ... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/from_runtime.rs b/document/graph-storage/src/from_runtime.rs
new file mode 100644
index 0000000000..0c2cd26f41
--- /dev/null
+++ b/document/graph-storage/src/from_runtime.rs
@@ -0,0 +1,573 @@
+use std::collections::HashMap;
+
+use core_types::Context;
+use core_types::context::Co... | [
"document/graph-storage/src/from_runtime.rs"
] | [
{
"comment": "<!-- cubic:v=9a45faeb-d6bc-47ab-8fc8-ee0578f1b61a -->\n<!-- cubic:review-run=57e46ace-4bc4-4820-b2d4-9f22054c7fe3 -->\n<!-- metadata:{\"confidence\":9} -->\nP2: `widget_override` does not apply the empty-string sentinel rule used by other input metadata fields. This stores unset runtime values as ... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=10d2cb45-8ff3-4343-b232-e65b3cc95705 -->
<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->
<!-- metadata:{"confidence":10} -->
P1: `Priority` has inconsistent `PartialEq`/`Eq`/`Ord`/`Hash` semantics. This can corrupt behavior in `HashMap`/`BTree*` when equal values hash or order differently.
... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/attributes.rs b/document/graph-storage/src/attributes.rs
new file mode 100644
index 0000000000..aa7c7f221e
--- /dev/null
+++ b/document/graph-storage/src/attributes.rs
@@ -0,0 +1,71 @@
+use crate::TimeStamp;
+use serde::{Deserialize, Serialize};
+use std::collections::BTreeMap;
+... | [
"document/graph-storage/src/attributes.rs"
] | [
{
"comment": "<!-- cubic:v=10d2cb45-8ff3-4343-b232-e65b3cc95705 -->\n<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->\n<!-- metadata:{\"confidence\":10} -->\nP1: `Priority` has inconsistent `PartialEq`/`Eq`/`Ord`/`Hash` semantics. This can corrupt behavior in `HashMap`/`BTree*` when equal values h... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=17490a18-7077-419b-9de5-4aa5bff601ca -->
<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->
<!-- metadata:{"confidence":8} -->
P1: Duplicate `ORIGINAL_NODE_ID` values in one network are not detected, causing silent node loss when collecting into `FxHashMap`. This can corrupt reconstructed graph... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/to_runtime.rs b/document/graph-storage/src/to_runtime.rs
new file mode 100644
index 0000000000..d9f19852ae
--- /dev/null
+++ b/document/graph-storage/src/to_runtime.rs
@@ -0,0 +1,380 @@
+use std::borrow::Cow;
+use std::collections::HashMap;
+
+use core_types::memo::MemoHash;
+use... | [
"document/graph-storage/src/to_runtime.rs"
] | [
{
"comment": "<!-- cubic:v=17490a18-7077-419b-9de5-4aa5bff601ca -->\n<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->\n<!-- metadata:{\"confidence\":8} -->\nP1: Duplicate `ORIGINAL_NODE_ID` values in one network are not detected, causing silent node loss when collecting into `FxHashMap`. This can ... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=62148969-26fe-40a0-995a-9451d6e359c4 -->
<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->
<!-- metadata:{"confidence":8} -->
P1: Attribute deletes are not tombstoned, so older adds can resurrect deleted keys. This breaks LWW behavior when ops arrive out of order.
<details>
<summary>Prompt fo... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/crdt.rs b/document/graph-storage/src/crdt.rs
new file mode 100644
index 0000000000..d099086dc8
--- /dev/null
+++ b/document/graph-storage/src/crdt.rs
@@ -0,0 +1,189 @@
+use crate::{Attributes, AttributesWrite, Network, NetworkId, Node, NodeId, NodeInput, PeerId, ResourceEntry, Re... | [
"document/graph-storage/src/crdt.rs"
] | [
{
"comment": "<!-- cubic:v=62148969-26fe-40a0-995a-9451d6e359c4 -->\n<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->\n<!-- metadata:{\"confidence\":8} -->\nP1: Attribute deletes are not tombstoned, so older adds can resurrect deleted keys. This breaks LWW behavior when ops arrive out of order.\n\... | true | ||
GraphiteEditor/Graphite | 4,198 | comment_to_fix | Add graph-storage crate | <!-- cubic:v=51f74255-6b2d-4339-8a04-11fb7ef19deb -->
<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->
<!-- metadata:{"confidence":8} -->
P1: `compute_rev` hashes non-canonical serialization of `RegistryDelta` that includes `HashMap` fields. Identical deltas can receive different `Rev` IDs, breaking stabl... | cde8dd78e69d30404bb9a784fb50a8e79a81382c | fdcd63d9db43cd8fef91b929d90740c835cf12f8 | diff --git a/document/graph-storage/src/ids.rs b/document/graph-storage/src/ids.rs
new file mode 100644
index 0000000000..216af8c667
--- /dev/null
+++ b/document/graph-storage/src/ids.rs
@@ -0,0 +1,99 @@
+use crate::RegistryDelta;
+use serde::{Deserialize, Serialize};
+
+/// Stable, document-scoped identity for a node.... | [
"document/graph-storage/src/ids.rs"
] | [
{
"comment": "<!-- cubic:v=51f74255-6b2d-4339-8a04-11fb7ef19deb -->\n<!-- cubic:review-run=49d28728-e031-44b0-ae16-a2d79e4318af -->\n<!-- metadata:{\"confidence\":8} -->\nP1: `compute_rev` hashes non-canonical serialization of `RegistryDelta` that includes `HashMap` fields. Identical deltas can receive differen... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.