repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
GraphiteEditor/Graphite | 2,727 | issue_to_patch | Sample Points should have option to sample by count (like in blender)
Currently can only set desired distance between points. | Rename 'Sample Points' node to 'Sample Polyline' and add a parameter spacing based on separation or quantity | Closes #2720
| 4a65ad290c1c4d5042a70e7f97fd440b79c3ca18 | 5be3a43037a05a946d4ca1fa4be43697a9ea8eb8 | diff --git a/demo-artwork/parametric-dunescape.graphite b/demo-artwork/parametric-dunescape.graphite
index 86ba52f545..0cc3a05d88 100644
--- a/demo-artwork/parametric-dunescape.graphite
+++ b/demo-artwork/parametric-dunescape.graphite
@@ -1,1 +1,1 @@
-{"network_interface":{"network":{"exports":[{"Node":{"node_id":44459... | [
"demo-artwork/parametric-dunescape.graphite",
"demo-artwork/procedural-string-lights.graphite",
"demo-artwork/red-dress.graphite",
"editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs",
"editor/src/messages/portfolio/document/node_graph/node_properties.rs",
"editor/src/messages/... | [
{
"comment": "Please be consistent with Title Case.",
"path": "editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs",
"hunk": "@@ -2397,6 +2399,7 @@ fn static_nodes() -> Vec<DocumentNodeDefinition> {\n \t\t\t\t\t\t\t}),\n \t\t\t\t\t\t),\n \t\t\t\t\t\tInto::<PropertiesRow>::into... | true | |
GraphiteEditor/Graphite | 2,727 | comment_to_fix | Rename 'Sample Points' node to 'Sample Polyline' and add a parameter spacing based on separation or quantity | Please be consistent with Title Case. | 4a65ad290c1c4d5042a70e7f97fd440b79c3ca18 | 5be3a43037a05a946d4ca1fa4be43697a9ea8eb8 | diff --git a/editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs b/editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs
index af8f6bd130..729334dc52 100644
--- a/editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs
+++ b/editor/src/messages/... | [
"editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs"
] | [
{
"comment": "Please be consistent with Title Case.",
"path": "editor/src/messages/portfolio/document/node_graph/document_node_definitions.rs",
"hunk": "@@ -2397,6 +2399,7 @@ fn static_nodes() -> Vec<DocumentNodeDefinition> {\n \t\t\t\t\t\t\t}),\n \t\t\t\t\t\t),\n \t\t\t\t\t\tInto::<PropertiesRow>::into... | true | ||
GraphiteEditor/Graphite | 2,727 | comment_to_fix | Rename 'Sample Points' node to 'Sample Polyline' and add a parameter spacing based on separation or quantity | You'll need to always run `rustfmt` before committing, if your editor isn't configured to do that on save. | 4a65ad290c1c4d5042a70e7f97fd440b79c3ca18 | 5be3a43037a05a946d4ca1fa4be43697a9ea8eb8 | diff --git a/node-graph/gcore/src/vector/algorithms/bezpath_algorithms.rs b/node-graph/gcore/src/vector/algorithms/bezpath_algorithms.rs
index fa7682e63b..fa8af0f6d5 100644
--- a/node-graph/gcore/src/vector/algorithms/bezpath_algorithms.rs
+++ b/node-graph/gcore/src/vector/algorithms/bezpath_algorithms.rs
@@ -1,5 +1,5 ... | [
"node-graph/gcore/src/vector/algorithms/bezpath_algorithms.rs"
] | [
{
"comment": "You'll need to always run `rustfmt` before committing, if your editor isn't configured to do that on save.",
"path": "node-graph/gcore/src/vector/algorithms/bezpath_algorithms.rs",
"hunk": "@@ -34,17 +34,21 @@ pub fn sample_points_on_bezpath(bezpath: BezPath, spacing: f64, start_offset: f6... | true | ||
GraphiteEditor/Graphite | 4,233 | issue_to_patch | Remove stray float literal .0 suffixes in lieu of just ending with a point | 2b8ef42086620322aa0f33362ca1635565e9837d | 18944f7badce2f0d4587aac87de48bf98699905c | diff --git a/desktop/src/app.rs b/desktop/src/app.rs
index 841780da18..1c0841d7c7 100644
--- a/desktop/src/app.rs
+++ b/desktop/src/app.rs
@@ -280,8 +280,8 @@ impl App {
let viewport_offset_y = y / window_size.height as f64;
render_state.set_viewport_offset([viewport_offset_x as f32, viewport_offset_y as f3... | [
"desktop/src/app.rs",
"desktop/src/cef/consts.rs",
"desktop/src/render/state.rs",
"editor/src/messages/portfolio/document/overlays/utility_functions.rs",
"editor/src/messages/portfolio/document/overlays/utility_types_native.rs",
"editor/src/messages/viewport/viewport_message_handler.rs",
"libraries/math... | [] | true | |||
GraphiteEditor/Graphite | 3,953 | issue_to_patch | Gradient spread methods
https://developer.mozilla.org/en-US/docs/Web/SVG/Reference/Attribute/spreadMethod
- Pad
- Reflect
- Repeat | Add support for setting the spread method for gradient fills | Partly closes #3991
## Demo
https://github.com/user-attachments/assets/10a702b0-555b-4e8a-8a58-128cac69ed2e
## Description
This PR adds support for selecting the spread method between Pad, Repeat, and Reflect.
At this moment, fix rendering `Table<GradientStops>` with the spread method is out of scope since... | da45ab2f87552eee9bd17ce1ec2e3eb744c85213 | 4d3eb14895716d4de90368e39975bb6e08a675cd | diff --git a/editor/src/messages/portfolio/document/graph_operation/graph_operation_message_handler.rs b/editor/src/messages/portfolio/document/graph_operation/graph_operation_message_handler.rs
index 851aa5c8d4..befb069156 100644
--- a/editor/src/messages/portfolio/document/graph_operation/graph_operation_message_hand... | [
"editor/src/messages/portfolio/document/graph_operation/graph_operation_message_handler.rs",
"editor/src/messages/portfolio/document/node_graph/node_properties.rs",
"editor/src/messages/tool/tool_messages/gradient_tool.rs",
"node-graph/libraries/rendering/src/render_ext.rs",
"node-graph/libraries/rendering/... | [
{
"comment": "This is not particularly clean to tie the fact that it's a default to omitting its SVG attribute value. It being omitted from the SVG render due to being the default should be separate logic in the renderer, as it is for the other default omissions in the renderer.",
"path": "node-graph/librar... | true | |
GraphiteEditor/Graphite | 3,953 | comment_to_fix | Add support for setting the spread method for gradient fills | This is not particularly clean to tie the fact that it's a default to omitting its SVG attribute value. It being omitted from the SVG render due to being the default should be separate logic in the renderer, as it is for the other default omissions in the renderer. | da45ab2f87552eee9bd17ce1ec2e3eb744c85213 | 4d3eb14895716d4de90368e39975bb6e08a675cd | diff --git a/node-graph/libraries/vector-types/src/gradient.rs b/node-graph/libraries/vector-types/src/gradient.rs
index 653ca6bc5d..f5c241c2f0 100644
--- a/node-graph/libraries/vector-types/src/gradient.rs
+++ b/node-graph/libraries/vector-types/src/gradient.rs
@@ -334,6 +334,27 @@ impl GradientStops {
}
}
+#[rep... | [
"node-graph/libraries/vector-types/src/gradient.rs"
] | [
{
"comment": "This is not particularly clean to tie the fact that it's a default to omitting its SVG attribute value. It being omitted from the SVG render due to being the default should be separate logic in the renderer, as it is for the other default omissions in the renderer.",
"path": "node-graph/librar... | true | ||
GraphiteEditor/Graphite | 3,953 | comment_to_fix | Add support for setting the spread method for gradient fills | `SetSpreadMethod` would be a better name for this variant. | da45ab2f87552eee9bd17ce1ec2e3eb744c85213 | 4d3eb14895716d4de90368e39975bb6e08a675cd | diff --git a/editor/src/messages/tool/tool_messages/gradient_tool.rs b/editor/src/messages/tool/tool_messages/gradient_tool.rs
index f1823618e5..f6b8f49be9 100644
--- a/editor/src/messages/tool/tool_messages/gradient_tool.rs
+++ b/editor/src/messages/tool/tool_messages/gradient_tool.rs
@@ -9,7 +9,7 @@ use crate::messag... | [
"editor/src/messages/tool/tool_messages/gradient_tool.rs"
] | [
{
"comment": "`SetSpreadMethod` would be a better name for this variant.",
"path": "editor/src/messages/tool/tool_messages/gradient_tool.rs",
"hunk": "@@ -53,6 +54,7 @@ pub enum GradientOptionsUpdate {\n \tType(GradientType),\n \tReverseStops,\n \tReverseDirection,\n+\tSpreadMethod(GradientSpreadMethod)... | true | ||
GraphiteEditor/Graphite | 3,953 | comment_to_fix | Add support for setting the spread method for gradient fills | By changing the node signature, it is necessary to add a migration to `document_migration.rs`. | da45ab2f87552eee9bd17ce1ec2e3eb744c85213 | 4d3eb14895716d4de90368e39975bb6e08a675cd | diff --git a/node-graph/libraries/vector-types/src/gradient.rs b/node-graph/libraries/vector-types/src/gradient.rs
index 653ca6bc5d..f5c241c2f0 100644
--- a/node-graph/libraries/vector-types/src/gradient.rs
+++ b/node-graph/libraries/vector-types/src/gradient.rs
@@ -334,6 +334,27 @@ impl GradientStops {
}
}
+#[rep... | [
"node-graph/libraries/vector-types/src/gradient.rs"
] | [
{
"comment": "By changing the node signature, it is necessary to add a migration to `document_migration.rs`.",
"path": "node-graph/libraries/vector-types/src/gradient.rs",
"hunk": "@@ -345,6 +366,8 @@ pub struct Gradient {\n \tpub gradient_type: GradientType,\n \tpub start: DVec2,\n \tpub end: DVec2,\n+... | true | ||
GraphiteEditor/Graphite | 4,111 | issue_to_patch | Paints as graphics
A **paint** is something that's graphical, which can be given to a Fill or Stroke node to be applied to the appearance of a vector path or stroke area.
For Graphite, we should use a model where a paint can be any graphical data:
1. As a layer, it shows up with finite or infinite bounds in the rende... | Add renderer support for painting vector with "fill" and "stroke" attributes with graphic List<T> types | Partly closes #2779
This PR adds foundation of the renderer to handle `List<Graphic>` as a paint source of fill and stroke.
## Demo
https://github.com/user-attachments/assets/ff0569c6-6ccf-4bc6-9659-e02c01f707b7
The demo file can be found in below.
[render-fill-and-stroke-via-list-graphic.graphite.zip](htt... | e524dff1a7a04de18e67fe7ae14f88cf24caacc9 | 46b987404452c427b9014d451d9c95af08dc18d9 | diff --git a/editor/src/messages/portfolio/document/document_message.rs b/editor/src/messages/portfolio/document/document_message.rs
index 22ef7c6385..0274a05db1 100644
--- a/editor/src/messages/portfolio/document/document_message.rs
+++ b/editor/src/messages/portfolio/document/document_message.rs
@@ -12,6 +12,8 @@ use... | [
"editor/src/messages/portfolio/document/document_message.rs",
"editor/src/messages/portfolio/document/document_message_handler.rs",
"editor/src/messages/portfolio/document/utility_types/document_metadata.rs",
"editor/src/messages/portfolio/document/utility_types/network_interface.rs",
"editor/src/node_graph... | [
{
"comment": "\n\nInstead of a standalone private function, consider implementing the `IntoGraphicTable` trait for `Fill`. This aligns with the existing patterns in this file for converting various types into a `Table<Graphic>` and makes the ... | true | |
GraphiteEditor/Graphite | 4,111 | comment_to_fix | Add renderer support for painting vector with "fill" and "stroke" attributes with graphic List<T> types | 
Instead of a standalone private function, consider implementing the `IntoGraphicTable` trait for `Fill`. This aligns with the existing patterns in this file for converting various types into a `Table<Graphic>` and makes the functionality public and... | e524dff1a7a04de18e67fe7ae14f88cf24caacc9 | 46b987404452c427b9014d451d9c95af08dc18d9 | diff --git a/node-graph/libraries/graphic-types/src/graphic.rs b/node-graph/libraries/graphic-types/src/graphic.rs
index 13bd8b7150..e70153a389 100644
--- a/node-graph/libraries/graphic-types/src/graphic.rs
+++ b/node-graph/libraries/graphic-types/src/graphic.rs
@@ -1,17 +1,17 @@
use core_types::bounds::{BoundingBox, ... | [
"node-graph/libraries/graphic-types/src/graphic.rs"
] | [
{
"comment": "\n\nInstead of a standalone private function, consider implementing the `IntoGraphicTable` trait for `Fill`. This aligns with the existing patterns in this file for converting various types into a `Table<Graphic>` and makes the ... | true | ||
GraphiteEditor/Graphite | 4,111 | comment_to_fix | Add renderer support for painting vector with "fill" and "stroke" attributes with graphic List<T> types | 
Cloning the List<Graphic> attribute here for every vector in the list can be quite expensive, especially for large documents or complex fill patterns. Since List is a deep-cloned structure, this adds significant overhead to every render frame. Consider... | e524dff1a7a04de18e67fe7ae14f88cf24caacc9 | 46b987404452c427b9014d451d9c95af08dc18d9 | diff --git a/node-graph/libraries/rendering/src/renderer.rs b/node-graph/libraries/rendering/src/renderer.rs
index 7cae299753..c04d787592 100644
--- a/node-graph/libraries/rendering/src/renderer.rs
+++ b/node-graph/libraries/rendering/src/renderer.rs
@@ -1,4 +1,4 @@
-use crate::render_ext::RenderExt;
+use crate::render... | [
"node-graph/libraries/rendering/src/renderer.rs"
] | [
{
"comment": "\n\nCloning the List<Graphic> attribute here for every vector in the list can be quite expensive, especially for large documents or complex fill patterns. Since List is a deep-cloned structure, this adds significant overhead to ever... | true | ||
GraphiteEditor/Graphite | 4,111 | comment_to_fix | Add renderer support for painting vector with "fill" and "stroke" attributes with graphic List<T> types | 
Similar to the SVG renderer, cloning the List<Graphic> here in the Vello render loop is a performance bottleneck. This happens for every vector item during every render pass. It would be better to handle the attribute reference and the fallback owned l... | e524dff1a7a04de18e67fe7ae14f88cf24caacc9 | 46b987404452c427b9014d451d9c95af08dc18d9 | diff --git a/node-graph/libraries/rendering/src/renderer.rs b/node-graph/libraries/rendering/src/renderer.rs
index 7cae299753..c04d787592 100644
--- a/node-graph/libraries/rendering/src/renderer.rs
+++ b/node-graph/libraries/rendering/src/renderer.rs
@@ -1,4 +1,4 @@
-use crate::render_ext::RenderExt;
+use crate::render... | [
"node-graph/libraries/rendering/src/renderer.rs"
] | [
{
"comment": "\n\nSimilar to the SVG renderer, cloning the List<Graphic> here in the Vello render loop is a performance bottleneck. This happens for every vector item during every render pass. It would be better to handle the attribute reference ... | true | ||
GraphiteEditor/Graphite | 4,111 | comment_to_fix | Add renderer support for painting vector with "fill" and "stroke" attributes with graphic List<T> types | 
The SVG implementation for aligned strokes currently only handles the first element of the fill_graphic_list. While the Vello implementation (line 1354) correctly iterates through all paints in the list, the SVG path-based rendering will ignore any... | e524dff1a7a04de18e67fe7ae14f88cf24caacc9 | 46b987404452c427b9014d451d9c95af08dc18d9 | diff --git a/node-graph/libraries/rendering/src/renderer.rs b/node-graph/libraries/rendering/src/renderer.rs
index 7cae299753..c04d787592 100644
--- a/node-graph/libraries/rendering/src/renderer.rs
+++ b/node-graph/libraries/rendering/src/renderer.rs
@@ -1,4 +1,4 @@
-use crate::render_ext::RenderExt;
+use crate::render... | [
"node-graph/libraries/rendering/src/renderer.rs"
] | [
{
"comment": "\n\nThe SVG implementation for aligned strokes currently only handles the first element of the fill_graphic_list. While the Vello implementation (line 1354) correctly iterates through all paints in the list, the SVG path-based r... | true | ||
GraphiteEditor/Graphite | 4,111 | comment_to_fix | Add renderer support for painting vector with "fill" and "stroke" attributes with graphic List<T> types | 
Generating a unique clipPath for every face in a branching vector (like a mesh grid) can lead to massive SVG bloat in the <defs> section. For complex meshes, this could result in thousands of redundant elements. Consider if there's a way to reuse c... | e524dff1a7a04de18e67fe7ae14f88cf24caacc9 | 46b987404452c427b9014d451d9c95af08dc18d9 | diff --git a/node-graph/libraries/rendering/src/renderer.rs b/node-graph/libraries/rendering/src/renderer.rs
index 7cae299753..c04d787592 100644
--- a/node-graph/libraries/rendering/src/renderer.rs
+++ b/node-graph/libraries/rendering/src/renderer.rs
@@ -1,4 +1,4 @@
-use crate::render_ext::RenderExt;
+use crate::render... | [
"node-graph/libraries/rendering/src/renderer.rs"
] | [
{
"comment": "\n\nGenerating a unique clipPath for every face in a branching vector (like a mesh grid) can lead to massive SVG bloat in the <defs> section. For complex meshes, this could result in thousands of redundant elements. Consider if ... | true | ||
GraphiteEditor/Graphite | 4,111 | comment_to_fix | Add renderer support for painting vector with "fill" and "stroke" attributes with graphic List<T> types | <!-- metadata:{"confidence":9} -->
P1: Empty `List<Color>` returns an empty string instead of `fill="none"`, which causes SVG elements to render as default black instead of transparent.
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if so, understand the root cause and fix it... | e524dff1a7a04de18e67fe7ae14f88cf24caacc9 | 46b987404452c427b9014d451d9c95af08dc18d9 | diff --git a/node-graph/libraries/rendering/src/render_ext.rs b/node-graph/libraries/rendering/src/render_ext.rs
index 883640d05d..197887add0 100644
--- a/node-graph/libraries/rendering/src/render_ext.rs
+++ b/node-graph/libraries/rendering/src/render_ext.rs
@@ -1,24 +1,104 @@
use crate::renderer::{RenderParams, forma... | [
"node-graph/libraries/rendering/src/render_ext.rs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":9} -->\nP1: Empty `List<Color>` returns an empty string instead of `fill=\"none\"`, which causes SVG elements to render as default black instead of transparent.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, und... | true | ||
GraphiteEditor/Graphite | 4,111 | comment_to_fix | Add renderer support for painting vector with "fill" and "stroke" attributes with graphic List<T> types | <!-- metadata:{"confidence":8} -->
P1: `Graphic::is_opaque` / `is_fully_transparent` ignore per-row opacity attributes (`ATTR_OPACITY`, `ATTR_OPACITY_FILL`), so a graphic with opaque paint but partial opacity is misclassified
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if ... | e524dff1a7a04de18e67fe7ae14f88cf24caacc9 | 46b987404452c427b9014d451d9c95af08dc18d9 | diff --git a/node-graph/libraries/graphic-types/src/graphic.rs b/node-graph/libraries/graphic-types/src/graphic.rs
index 13bd8b7150..e70153a389 100644
--- a/node-graph/libraries/graphic-types/src/graphic.rs
+++ b/node-graph/libraries/graphic-types/src/graphic.rs
@@ -1,17 +1,17 @@
use core_types::bounds::{BoundingBox, ... | [
"node-graph/libraries/graphic-types/src/graphic.rs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":8} -->\nP1: `Graphic::is_opaque` / `is_fully_transparent` ignore per-row opacity attributes (`ATTR_OPACITY`, `ATTR_OPACITY_FILL`), so a graphic with opaque paint but partial opacity is misclassified\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nChe... | true | ||
GraphiteEditor/Graphite | 4,111 | comment_to_fix | Add renderer support for painting vector with "fill" and "stroke" attributes with graphic List<T> types | <!-- cubic:review-run=9a9f9f32-4f94-46c5-bf77-713368e5d214 -->
<!-- cubic:v=6547bf4c-50c5-4121-b345-8bc6e65de0ae -->
<!-- metadata:{"confidence":7} -->
P2: Fill/stroke opacity helpers only check the first element of `List<Graphic>` paint lists, ignoring additional entries that could affect opacity/transparent decisions... | e524dff1a7a04de18e67fe7ae14f88cf24caacc9 | 46b987404452c427b9014d451d9c95af08dc18d9 | diff --git a/node-graph/libraries/graphic-types/src/graphic.rs b/node-graph/libraries/graphic-types/src/graphic.rs
index 13bd8b7150..e70153a389 100644
--- a/node-graph/libraries/graphic-types/src/graphic.rs
+++ b/node-graph/libraries/graphic-types/src/graphic.rs
@@ -1,17 +1,17 @@
use core_types::bounds::{BoundingBox, ... | [
"node-graph/libraries/graphic-types/src/graphic.rs"
] | [
{
"comment": "<!-- cubic:review-run=9a9f9f32-4f94-46c5-bf77-713368e5d214 -->\n<!-- cubic:v=6547bf4c-50c5-4121-b345-8bc6e65de0ae -->\n<!-- metadata:{\"confidence\":7} -->\nP2: Fill/stroke opacity helpers only check the first element of `List<Graphic>` paint lists, ignoring additional entries that could affect op... | true | ||
GraphiteEditor/Graphite | 4,111 | comment_to_fix | Add renderer support for painting vector with "fill" and "stroke" attributes with graphic List<T> types | <!-- metadata:{"confidence":9} -->
P2: Vello stroke gradients are still mapped from fill bounds instead of stroke-inclusive bounds, so gradient placement can diverge from SVG for thick strokes.
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if so, understand the root cause an... | e524dff1a7a04de18e67fe7ae14f88cf24caacc9 | 46b987404452c427b9014d451d9c95af08dc18d9 | diff --git a/node-graph/libraries/rendering/src/renderer.rs b/node-graph/libraries/rendering/src/renderer.rs
index 7cae299753..c04d787592 100644
--- a/node-graph/libraries/rendering/src/renderer.rs
+++ b/node-graph/libraries/rendering/src/renderer.rs
@@ -1,4 +1,4 @@
-use crate::render_ext::RenderExt;
+use crate::render... | [
"node-graph/libraries/rendering/src/renderer.rs"
] | [
{
"comment": "<!-- metadata:{\"confidence\":9} -->\nP2: Vello stroke gradients are still mapped from fill bounds instead of stroke-inclusive bounds, so gradient placement can diverge from SVG for thick strokes.\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if s... | true | ||
GraphiteEditor/Graphite | 4,221 | issue_to_patch | Add node macro support for injecting nodes into global scope | <!--
Graphite has ZERO-TOLERANCE for contributing undisclosed AI-generated content.
If your PR involves AI, you must read our AI contribution policy (it's short):
https://graphite.art/volunteer/guide/starting-a-task/ai-contribution-policy
REMEMBER:
- You are responsible for thoroughly testing the successful implementa... | 863b1f99938f079c13841210025f6c8781a8c2c4 | 2bc7bfdae4cba601871fa09ddb6b97578e8b2a19 | diff --git a/editor/src/messages/portfolio/document/node_graph/document_node_definitions/document_node_derive.rs b/editor/src/messages/portfolio/document/node_graph/document_node_definitions/document_node_derive.rs
index e18887880e..78098dc950 100644
--- a/editor/src/messages/portfolio/document/node_graph/document_node... | [
"editor/src/messages/portfolio/document/node_graph/document_node_definitions/document_node_derive.rs",
"editor/src/node_graph_executor/runtime.rs",
"node-graph/graph-craft/src/document.rs",
"node-graph/graphene-cli/src/main.rs",
"node-graph/interpreted-executor/benches/benchmark_util.rs",
"node-graph/libr... | [
{
"comment": "\n\nRemoving the scope injection from the parent network's `scope_injections` map will prevent any other consumer nodes at the parent level (or in other nested networks) from resolving this scope.\n\nSince the producer node (`produc... | true | ||
GraphiteEditor/Graphite | 4,221 | comment_to_fix | Add node macro support for injecting nodes into global scope | <!-- cubic:v=51d0c79e-a4e3-46a3-922c-1f3dfb72911f -->
<!-- cubic:review-run=7402cd0c-5a53-4c82-8785-8e1609383842 -->
<!-- metadata:{"confidence":9} -->
P1: `as_static_str()` panics for `Cow::Owned` variant, but `ProtoNodeIdentifier::with_owned_string()` allows constructing that variant. Callers have no way to staticall... | 863b1f99938f079c13841210025f6c8781a8c2c4 | 2bc7bfdae4cba601871fa09ddb6b97578e8b2a19 | diff --git a/node-graph/libraries/core-types/src/types.rs b/node-graph/libraries/core-types/src/types.rs
index cd4f6700e3..5e70dcbced 100644
--- a/node-graph/libraries/core-types/src/types.rs
+++ b/node-graph/libraries/core-types/src/types.rs
@@ -154,6 +154,13 @@ impl ProtoNodeIdentifier {
pub fn as_str(&self) -> &st... | [
"node-graph/libraries/core-types/src/types.rs"
] | [
{
"comment": "<!-- cubic:v=51d0c79e-a4e3-46a3-922c-1f3dfb72911f -->\n<!-- cubic:review-run=7402cd0c-5a53-4c82-8785-8e1609383842 -->\n<!-- metadata:{\"confidence\":9} -->\nP1: `as_static_str()` panics for `Cow::Owned` variant, but `ProtoNodeIdentifier::with_owned_string()` allows constructing that variant. Calle... | true | ||
GraphiteEditor/Graphite | 4,225 | issue_to_patch | Desktop: Block network requests in CEF that are not explicitly allowlisted | <!--
Graphite has ZERO-TOLERANCE for contributing undisclosed AI-generated content.
If your PR involves AI, you must read our AI contribution policy (it's short):
https://graphite.art/volunteer/guide/starting-a-task/ai-contribution-policy
REMEMBER:
- You are responsible for thoroughly testing the successful impl... | 26a0b901d44de94b36c4c5bec136540e3826db19 | 48f12882f0b1ec583f4619730c1e134a8f977834 | diff --git a/desktop/src/cef/internal.rs b/desktop/src/cef/internal.rs
index a71e3089c9..bb8a8ec37f 100644
--- a/desktop/src/cef/internal.rs
+++ b/desktop/src/cef/internal.rs
@@ -10,7 +10,9 @@ mod context_menu_handler;
mod display_handler;
mod life_span_handler;
mod load_handler;
+mod request_handler;
mod resource_... | [
"desktop/src/cef/internal.rs",
"desktop/src/cef/internal/browser_process_client.rs",
"desktop/src/cef/internal/request_handler.rs",
"desktop/src/cef/internal/resource_request_handler.rs"
] | [
{
"comment": "\n\nTo avoid allocating a new `String` via `format!` on every single resource request (which can be very frequent), we can use `std::sync::OnceLock` to cache the allowed prefix string.\n\n```rust\nfn is_allowed_url(url: &str) ->... | true | ||
GraphiteEditor/Graphite | 4,225 | comment_to_fix | Desktop: Block network requests in CEF that are not explicitly allowlisted | 
To avoid allocating a new `String` via `format!` on every single resource request (which can be very frequent), we can use `std::sync::OnceLock` to cache the allowed prefix string.
```rust
fn is_allowed_url(url: &str) -> bool {
static ALLOWED_PRE... | 26a0b901d44de94b36c4c5bec136540e3826db19 | 48f12882f0b1ec583f4619730c1e134a8f977834 | diff --git a/desktop/src/cef/internal/resource_request_handler.rs b/desktop/src/cef/internal/resource_request_handler.rs
new file mode 100644
index 0000000000..94d8ec47e3
--- /dev/null
+++ b/desktop/src/cef/internal/resource_request_handler.rs
@@ -0,0 +1,60 @@
+use cef::rc::{Rc, RcImpl};
+use cef::sys::{_cef_resource_r... | [
"desktop/src/cef/internal/resource_request_handler.rs"
] | [
{
"comment": "\n\nTo avoid allocating a new `String` via `format!` on every single resource request (which can be very frequent), we can use `std::sync::OnceLock` to cache the allowed prefix string.\n\n```rust\nfn is_allowed_url(url: &str) ->... | true | ||
GraphiteEditor/Graphite | 4,225 | comment_to_fix | Desktop: Block network requests in CEF that are not explicitly allowlisted | 
To avoid allocating a new `String` via `format!` on every navigation check, we can use `std::sync::OnceLock` to cache the allowed prefix string.
```rust
fn on_before_browse(&self, _browser: Option<&mut Browser>, _frame: Option<&mut Frame>, reques... | 26a0b901d44de94b36c4c5bec136540e3826db19 | 48f12882f0b1ec583f4619730c1e134a8f977834 | diff --git a/desktop/src/cef/internal/request_handler.rs b/desktop/src/cef/internal/request_handler.rs
new file mode 100644
index 0000000000..c77147ff15
--- /dev/null
+++ b/desktop/src/cef/internal/request_handler.rs
@@ -0,0 +1,84 @@
+use cef::rc::{Rc, RcImpl};
+use cef::sys::{_cef_request_handler_t, cef_base_ref_count... | [
"desktop/src/cef/internal/request_handler.rs"
] | [
{
"comment": "\n\nTo avoid allocating a new `String` via `format!` on every navigation check, we can use `std::sync::OnceLock` to cache the allowed prefix string.\n\n```rust\n\tfn on_before_browse(&self, _browser: Option<&mut Browser>, _frame... | true | ||
GraphiteEditor/Graphite | 4,225 | comment_to_fix | Desktop: Block network requests in CEF that are not explicitly allowlisted | 
Dereferencing a raw pointer `self.object` directly as `&mut *self.object` without checking if it is null is undefined behavior in Rust. We should use `self.object.as_mut()` to safely access the mutable reference only if it is non-null.
```rust
imp... | 26a0b901d44de94b36c4c5bec136540e3826db19 | 48f12882f0b1ec583f4619730c1e134a8f977834 | diff --git a/desktop/src/cef/internal/request_handler.rs b/desktop/src/cef/internal/request_handler.rs
new file mode 100644
index 0000000000..c77147ff15
--- /dev/null
+++ b/desktop/src/cef/internal/request_handler.rs
@@ -0,0 +1,84 @@
+use cef::rc::{Rc, RcImpl};
+use cef::sys::{_cef_request_handler_t, cef_base_ref_count... | [
"desktop/src/cef/internal/request_handler.rs"
] | [
{
"comment": "\n\nDereferencing a raw pointer `self.object` directly as `&mut *self.object` without checking if it is null is undefined behavior in Rust. We should use `self.object.as_mut()` to safely access the mutable reference only if it i... | true | ||
GraphiteEditor/Graphite | 4,225 | comment_to_fix | Desktop: Block network requests in CEF that are not explicitly allowlisted | 
Dereferencing a raw pointer `self.object` directly as `&mut *self.object` without checking if it is null is undefined behavior in Rust. We should use `self.object.as_mut()` to safely access the mutable reference only if it is non-null.
```rust
imp... | 26a0b901d44de94b36c4c5bec136540e3826db19 | 48f12882f0b1ec583f4619730c1e134a8f977834 | diff --git a/desktop/src/cef/internal/resource_request_handler.rs b/desktop/src/cef/internal/resource_request_handler.rs
new file mode 100644
index 0000000000..94d8ec47e3
--- /dev/null
+++ b/desktop/src/cef/internal/resource_request_handler.rs
@@ -0,0 +1,60 @@
+use cef::rc::{Rc, RcImpl};
+use cef::sys::{_cef_resource_r... | [
"desktop/src/cef/internal/resource_request_handler.rs"
] | [
{
"comment": "\n\nDereferencing a raw pointer `self.object` directly as `&mut *self.object` without checking if it is null is undefined behavior in Rust. We should use `self.object.as_mut()` to safely access the mutable reference only if it i... | true | ||
GraphiteEditor/Graphite | 4,225 | comment_to_fix | Desktop: Block network requests in CEF that are not explicitly allowlisted | <!-- cubic:v=433a1a84-91f6-4aff-bf5a-589957335dd3 -->
<!-- cubic:review-run=5734b91b-ca31-43eb-aa95-7e5220a4431e -->
<!-- metadata:{"confidence":6} -->
P2: `auth_credentials` always declines authentication, which can break otherwise-allowed requests in authenticated/proxy environments. Handle the callback or explicitly... | 26a0b901d44de94b36c4c5bec136540e3826db19 | 48f12882f0b1ec583f4619730c1e134a8f977834 | diff --git a/desktop/src/cef/internal/request_handler.rs b/desktop/src/cef/internal/request_handler.rs
new file mode 100644
index 0000000000..c77147ff15
--- /dev/null
+++ b/desktop/src/cef/internal/request_handler.rs
@@ -0,0 +1,84 @@
+use cef::rc::{Rc, RcImpl};
+use cef::sys::{_cef_request_handler_t, cef_base_ref_count... | [
"desktop/src/cef/internal/request_handler.rs"
] | [
{
"comment": "<!-- cubic:v=433a1a84-91f6-4aff-bf5a-589957335dd3 -->\n<!-- cubic:review-run=5734b91b-ca31-43eb-aa95-7e5220a4431e -->\n<!-- metadata:{\"confidence\":6} -->\nP2: `auth_credentials` always declines authentication, which can break otherwise-allowed requests in authenticated/proxy environments. Handle... | true | ||
GraphiteEditor/Graphite | 4,225 | comment_to_fix | Desktop: Block network requests in CEF that are not explicitly allowlisted | <!-- cubic:v=f2ebc44d-1115-48ff-80e5-0dafc2adacb4 -->
<!-- cubic:review-run=5734b91b-ca31-43eb-aa95-7e5220a4431e -->
<!-- metadata:{"confidence":7} -->
P2: `RequestHandlerImpl` starts with a null raw pointer that is later dereferenced unsafely. Representing this uninitialized state in the type allows UB/crash if invari... | 26a0b901d44de94b36c4c5bec136540e3826db19 | 48f12882f0b1ec583f4619730c1e134a8f977834 | diff --git a/desktop/src/cef/internal/request_handler.rs b/desktop/src/cef/internal/request_handler.rs
new file mode 100644
index 0000000000..c77147ff15
--- /dev/null
+++ b/desktop/src/cef/internal/request_handler.rs
@@ -0,0 +1,84 @@
+use cef::rc::{Rc, RcImpl};
+use cef::sys::{_cef_request_handler_t, cef_base_ref_count... | [
"desktop/src/cef/internal/request_handler.rs"
] | [
{
"comment": "<!-- cubic:v=f2ebc44d-1115-48ff-80e5-0dafc2adacb4 -->\n<!-- cubic:review-run=5734b91b-ca31-43eb-aa95-7e5220a4431e -->\n<!-- metadata:{\"confidence\":7} -->\nP2: `RequestHandlerImpl` starts with a null raw pointer that is later dereferenced unsafely. Representing this uninitialized state in the typ... | true | ||
GraphiteEditor/Graphite | 4,225 | comment_to_fix | Desktop: Block network requests in CEF that are not explicitly allowlisted | <!-- cubic:v=95f9939c-86a5-4302-ad70-af5386c3cf69 -->
<!-- cubic:review-run=5734b91b-ca31-43eb-aa95-7e5220a4431e -->
<!-- metadata:{"confidence":9} -->
P3: Blocked requests are expected policy enforcement, so logging each one as `error` will create noisy error telemetry.
(Based on your team's feedback about error leve... | 26a0b901d44de94b36c4c5bec136540e3826db19 | 48f12882f0b1ec583f4619730c1e134a8f977834 | diff --git a/desktop/src/cef/internal/resource_request_handler.rs b/desktop/src/cef/internal/resource_request_handler.rs
new file mode 100644
index 0000000000..94d8ec47e3
--- /dev/null
+++ b/desktop/src/cef/internal/resource_request_handler.rs
@@ -0,0 +1,60 @@
+use cef::rc::{Rc, RcImpl};
+use cef::sys::{_cef_resource_r... | [
"desktop/src/cef/internal/resource_request_handler.rs"
] | [
{
"comment": "<!-- cubic:v=95f9939c-86a5-4302-ad70-af5386c3cf69 -->\n<!-- cubic:review-run=5734b91b-ca31-43eb-aa95-7e5220a4431e -->\n<!-- metadata:{\"confidence\":9} -->\nP3: Blocked requests are expected policy enforcement, so logging each one as `error` will create noisy error telemetry.\n\n(Based on your tea... | true | ||
GraphiteEditor/Graphite | 4,223 | issue_to_patch | Unify the gradient chain lookup used by the stops and attribute reads | Fixes a bug introduced by #4177.
The node-finding logic for "Gradient Value" and other gradient-related attribute insertion nodes (e.g. "Gradient Type") was different, so the gradient tool could target the wrong Fill input in a case where there were multiple 'Fill' nodes. This PR unifies the logic for finding the Fi... | 97324cd852f85d79ce65a984ebb9d99f71088069 | 33dcec00934669a1baed719186f9e797da008409 | diff --git a/editor/src/messages/tool/common_functionality/graph_modification_utils.rs b/editor/src/messages/tool/common_functionality/graph_modification_utils.rs
index 709f3fa1da..266564c713 100644
--- a/editor/src/messages/tool/common_functionality/graph_modification_utils.rs
+++ b/editor/src/messages/tool/common_fun... | [
"editor/src/messages/tool/common_functionality/graph_modification_utils.rs"
] | [
{
"comment": "\n\nThis new logic for finding the upstream gradient node is a great improvement. To further enhance maintainability and code reuse, consider extracting this logic into a more generic helper function. This function could take th... | true | ||
GraphiteEditor/Graphite | 4,223 | comment_to_fix | Unify the gradient chain lookup used by the stops and attribute reads | 
This new logic for finding the upstream gradient node is a great improvement. To further enhance maintainability and code reuse, consider extracting this logic into a more generic helper function. This function could take the `DefinitionIdentifier`... | 97324cd852f85d79ce65a984ebb9d99f71088069 | 33dcec00934669a1baed719186f9e797da008409 | diff --git a/editor/src/messages/tool/common_functionality/graph_modification_utils.rs b/editor/src/messages/tool/common_functionality/graph_modification_utils.rs
index 709f3fa1da..266564c713 100644
--- a/editor/src/messages/tool/common_functionality/graph_modification_utils.rs
+++ b/editor/src/messages/tool/common_fun... | [
"editor/src/messages/tool/common_functionality/graph_modification_utils.rs"
] | [
{
"comment": "\n\nThis new logic for finding the upstream gradient node is a great improvement. To further enhance maintainability and code reuse, consider extracting this logic into a more generic helper function. This function could take th... | true | ||
GraphiteEditor/Graphite | 4,224 | issue_to_patch | Fix the Gradient tool breaking the layer deletion hotkey | f658665d4a6c970c94785bba1a3e1b1ac42232c3 | c7745298043ab413381fe79089b131017d43f624 | diff --git a/editor/src/messages/tool/tool_messages/gradient_tool.rs b/editor/src/messages/tool/tool_messages/gradient_tool.rs
index 32ce0c9e0b..fdb4aec4ae 100644
--- a/editor/src/messages/tool/tool_messages/gradient_tool.rs
+++ b/editor/src/messages/tool/tool_messages/gradient_tool.rs
@@ -192,14 +192,22 @@ impl<'a> Me... | [
"editor/src/messages/tool/tool_messages/gradient_tool.rs"
] | [
{
"comment": "\n\nWhen a new gradient is drawn, `selected_gradient` is set to `Some` with `GradientDragTarget::New`. Since `PointerUp` does not clear `selected_gradient` for `GradientDragTarget::New`, it remains `Some` even after the drag is ... | true | |||
GraphiteEditor/Graphite | 4,224 | comment_to_fix | Fix the Gradient tool breaking the layer deletion hotkey | 
When a new gradient is drawn, `selected_gradient` is set to `Some` with `GradientDragTarget::New`. Since `PointerUp` does not clear `selected_gradient` for `GradientDragTarget::New`, it remains `Some` even after the drag is finished. This causes `D... | f658665d4a6c970c94785bba1a3e1b1ac42232c3 | c7745298043ab413381fe79089b131017d43f624 | diff --git a/editor/src/messages/tool/tool_messages/gradient_tool.rs b/editor/src/messages/tool/tool_messages/gradient_tool.rs
index 32ce0c9e0b..fdb4aec4ae 100644
--- a/editor/src/messages/tool/tool_messages/gradient_tool.rs
+++ b/editor/src/messages/tool/tool_messages/gradient_tool.rs
@@ -192,14 +192,22 @@ impl<'a> Me... | [
"editor/src/messages/tool/tool_messages/gradient_tool.rs"
] | [
{
"comment": "\n\nWhen a new gradient is drawn, `selected_gradient` is set to `Some` with `GradientDragTarget::New`. Since `PointerUp` does not clear `selected_gradient` for `GradientDragTarget::New`, it remains `Some` even after the drag is ... | true | ||
GraphiteEditor/Graphite | 4,224 | comment_to_fix | Fix the Gradient tool breaking the layer deletion hotkey | <!-- cubic:v=4c357a34-a07e-4e1e-bcdd-8b4184bf714c -->
<!-- cubic:review-run=8fed8ff5-91ff-4d00-a868-1423d789fbc6 -->
<!-- metadata:{"confidence":7} -->
P2: This condition is too broad. After drawing a new gradient, `selected_gradient` is set to `Some` with `GradientDragTarget::New` and `PointerUp` does not clear it for... | f658665d4a6c970c94785bba1a3e1b1ac42232c3 | c7745298043ab413381fe79089b131017d43f624 | diff --git a/editor/src/messages/tool/tool_messages/gradient_tool.rs b/editor/src/messages/tool/tool_messages/gradient_tool.rs
index 32ce0c9e0b..fdb4aec4ae 100644
--- a/editor/src/messages/tool/tool_messages/gradient_tool.rs
+++ b/editor/src/messages/tool/tool_messages/gradient_tool.rs
@@ -192,14 +192,22 @@ impl<'a> Me... | [
"editor/src/messages/tool/tool_messages/gradient_tool.rs"
] | [
{
"comment": "<!-- cubic:v=4c357a34-a07e-4e1e-bcdd-8b4184bf714c -->\n<!-- cubic:review-run=8fed8ff5-91ff-4d00-a868-1423d789fbc6 -->\n<!-- metadata:{\"confidence\":7} -->\nP2: This condition is too broad. After drawing a new gradient, `selected_gradient` is set to `Some` with `GradientDragTarget::New` and `Point... | true | ||
GraphiteEditor/Graphite | 4,220 | issue_to_patch | Stop flatten_graphic_list() from adding unused attributes | After a node such as Flatten Vector, we don't have `transform`, `opacity`, `opacity_fill`, etc. being added as attributes that were not part of the input data. | f2c83d22784bd55e323531b78865fa896eaaf44c | 9e402d3f9e7dd26f191047942b113282b193955e | diff --git a/node-graph/libraries/graphic-types/src/graphic.rs b/node-graph/libraries/graphic-types/src/graphic.rs
index 0efade8880..13bd8b7150 100644
--- a/node-graph/libraries/graphic-types/src/graphic.rs
+++ b/node-graph/libraries/graphic-types/src/graphic.rs
@@ -108,53 +108,62 @@ impl From<List<GradientStops>> for ... | [
"node-graph/libraries/graphic-types/src/graphic.rs"
] | [] | true | ||
GraphiteEditor/Graphite | 3,940 | issue_to_patch | Double-clicking top bar doesn't toggle maximize (Linux)
Expected functionality:
With most apps, double-clicking the top bar will maximize the app (or, if it's already maximized, restore it to a smaller, floating window), including the Graphite PWA. However, Graphite doesn't do this (double-clicking does nothing).
It'... | Desktop: Fix double-clicking top bar not toggling maximize on Linux | ### Before
https://github.com/user-attachments/assets/f56f2ae5-4126-49fe-b55c-98d0ca6dc7eb
### After
https://github.com/user-attachments/assets/f45077e3-7774-4f4f-bfde-5d0e2512126f
Closes #3594 | b4e04e616a5cc5a8439049ee147fc02f520fb58a | a5383dbfc197b668c43558a642f28973da71bc5f | diff --git a/desktop/src/app.rs b/desktop/src/app.rs
index fc417afa00..841780da18 100644
--- a/desktop/src/app.rs
+++ b/desktop/src/app.rs
@@ -33,6 +33,7 @@ pub(crate) struct App {
window_size: PhysicalSize<u32>,
window_maximized: bool,
window_fullscreen: bool,
+ window_pending_drag: bool,
pointer_position: Phy... | [
"desktop/src/app.rs"
] | [
{
"comment": "move this down to the end of the match block",
"path": "desktop/src/app.rs",
"hunk": "@@ -567,6 +567,13 @@ impl ApplicationHandler for App {\n \t\t\tWindowEvent::SurfaceResized(_) | WindowEvent::ScaleFactorChanged { .. } => {\n \t\t\t\tself.resize();\n \t\t\t}\n+\t\t\tWindowEvent::PointerB... | true | |
GraphiteEditor/Graphite | 4,219 | issue_to_patch | Fix opacity attributes from defaulting to 0 rather than 1 | Fixes a regression introduced in 62203cb171f99930f960574d02ce3e4afa6d96a9 where the Painted Dreams demo artwork's "Top Right Black - Dots" and "Bottom Black - Dots" layers had a 0 opacity. | 02a40a860f68838e77d4579f072258e9041e3284 | 06903590bd4cbafda3847882cf09cf29cfa701ec | diff --git a/node-graph/libraries/core-types/src/list.rs b/node-graph/libraries/core-types/src/list.rs
index 61f54597b4..76d1b75ede 100644
--- a/node-graph/libraries/core-types/src/list.rs
+++ b/node-graph/libraries/core-types/src/list.rs
@@ -77,6 +77,30 @@ pub const ATTR_SPREAD_METHOD: &str = "spread_method";
/// Gra... | [
"node-graph/libraries/core-types/src/list.rs"
] | [
{
"comment": "\n\nThe current implementation of `pad_with_implicit_default` calls `implicit_default_value` which allocates a new `Box<dyn AnyAttributeValue>` on the heap for every single default value, and then clones it `count` times in a lo... | true | ||
GraphiteEditor/Graphite | 4,219 | comment_to_fix | Fix opacity attributes from defaulting to 0 rather than 1 | 
The current implementation of `pad_with_implicit_default` calls `implicit_default_value` which allocates a new `Box<dyn AnyAttributeValue>` on the heap for every single default value, and then clones it `count` times in a loop. This results in `cou... | 02a40a860f68838e77d4579f072258e9041e3284 | 06903590bd4cbafda3847882cf09cf29cfa701ec | diff --git a/node-graph/libraries/core-types/src/list.rs b/node-graph/libraries/core-types/src/list.rs
index 61f54597b4..76d1b75ede 100644
--- a/node-graph/libraries/core-types/src/list.rs
+++ b/node-graph/libraries/core-types/src/list.rs
@@ -77,6 +77,30 @@ pub const ATTR_SPREAD_METHOD: &str = "spread_method";
/// Gra... | [
"node-graph/libraries/core-types/src/list.rs"
] | [
{
"comment": "\n\nThe current implementation of `pad_with_implicit_default` calls `implicit_default_value` which allocates a new `Box<dyn AnyAttributeValue>` on the heap for every single default value, and then clones it `count` times in a lo... | true | ||
GraphiteEditor/Graphite | 4,219 | comment_to_fix | Fix opacity attributes from defaulting to 0 rather than 1 | 
Pre-allocating the vector with `preceding_defaults + 1` capacity avoids multiple reallocations when padding and pushing the final element.
```suggestion
let mut attribute: Box<dyn AnyAttribute> = Box::new(Attribute::<T>(Vec::with_capacity(preced... | 02a40a860f68838e77d4579f072258e9041e3284 | 06903590bd4cbafda3847882cf09cf29cfa701ec | diff --git a/node-graph/libraries/core-types/src/list.rs b/node-graph/libraries/core-types/src/list.rs
index 61f54597b4..76d1b75ede 100644
--- a/node-graph/libraries/core-types/src/list.rs
+++ b/node-graph/libraries/core-types/src/list.rs
@@ -77,6 +77,30 @@ pub const ATTR_SPREAD_METHOD: &str = "spread_method";
/// Gra... | [
"node-graph/libraries/core-types/src/list.rs"
] | [
{
"comment": "\n\nPre-allocating the vector with `preceding_defaults + 1` capacity avoids multiple reallocations when padding and pushing the final element.\n\n```suggestion\n\t\tlet mut attribute: Box<dyn AnyAttribute> = Box::new(Attribute::... | true | ||
GraphiteEditor/Graphite | 4,219 | comment_to_fix | Fix opacity attributes from defaulting to 0 rather than 1 | 
Pre-allocating the vector with `self.len` capacity avoids reallocations when padding the new attribute to match the list's length.
```suggestion
let mut attribute: Box<dyn AnyAttribute> = Box::new(Attribute::<T>(Vec::with_capacity(self.len)));
`... | 02a40a860f68838e77d4579f072258e9041e3284 | 06903590bd4cbafda3847882cf09cf29cfa701ec | diff --git a/node-graph/libraries/core-types/src/list.rs b/node-graph/libraries/core-types/src/list.rs
index 61f54597b4..76d1b75ede 100644
--- a/node-graph/libraries/core-types/src/list.rs
+++ b/node-graph/libraries/core-types/src/list.rs
@@ -77,6 +77,30 @@ pub const ATTR_SPREAD_METHOD: &str = "spread_method";
/// Gra... | [
"node-graph/libraries/core-types/src/list.rs"
] | [
{
"comment": "\n\nPre-allocating the vector with `self.len` capacity avoids reallocations when padding the new attribute to match the list's length.\n\n```suggestion\n\t\tlet mut attribute: Box<dyn AnyAttribute> = Box::new(Attribute::<T>(Vec:... | true | ||
GraphiteEditor/Graphite | 4,219 | comment_to_fix | Fix opacity attributes from defaulting to 0 rather than 1 | <!-- cubic:v=dacc2e1b-43d6-48cb-9598-f36feca27d09 -->
<!-- cubic:review-run=63e12855-7e7c-472b-ae6b-ada220c66abe -->
<!-- metadata:{"confidence":7} -->
P3: Use `Vec::with_capacity(preceding_defaults + 1)` instead of `Vec::new()` to avoid reallocations when the vector is subsequently padded and the final element is push... | 02a40a860f68838e77d4579f072258e9041e3284 | 06903590bd4cbafda3847882cf09cf29cfa701ec | diff --git a/node-graph/libraries/core-types/src/list.rs b/node-graph/libraries/core-types/src/list.rs
index 61f54597b4..76d1b75ede 100644
--- a/node-graph/libraries/core-types/src/list.rs
+++ b/node-graph/libraries/core-types/src/list.rs
@@ -77,6 +77,30 @@ pub const ATTR_SPREAD_METHOD: &str = "spread_method";
/// Gra... | [
"node-graph/libraries/core-types/src/list.rs"
] | [
{
"comment": "<!-- cubic:v=dacc2e1b-43d6-48cb-9598-f36feca27d09 -->\n<!-- cubic:review-run=63e12855-7e7c-472b-ae6b-ada220c66abe -->\n<!-- metadata:{\"confidence\":7} -->\nP3: Use `Vec::with_capacity(preceding_defaults + 1)` instead of `Vec::new()` to avoid reallocations when the vector is subsequently padded an... | true | ||
GraphiteEditor/Graphite | 4,150 | issue_to_patch | Add a wave propagation ripple effect to the website navbar | Now behaving just as I'd always envisioned it from the beginning! | b4e04e616a5cc5a8439049ee147fc02f520fb58a | fdb86e8073eb27c168b061fb7fd071b96e5ea16a | diff --git a/website/sass/base.scss b/website/sass/base.scss
index 3ad0985807..9a5749459d 100644
--- a/website/sass/base.scss
+++ b/website/sass/base.scss
@@ -227,23 +227,34 @@ body > .page {
.ripple {
display: block;
background: none;
- // Covers up content that extends up underneath the header
- fill: ... | [
"website/sass/base.scss",
"website/static/js/navbar.js",
"website/templates/base.html"
] | [
{
"comment": "\n\nThe `setRipples` function, which is called on every animation frame via `requestAnimationFrame`, performs multiple layout-triggering operations that cause significant layout thrashing. Specifically, calling `getBoundingClientRec... | true | ||
GraphiteEditor/Graphite | 4,150 | comment_to_fix | Add a wave propagation ripple effect to the website navbar | 
The `setRipples` function, which is called on every animation frame via `requestAnimationFrame`, performs multiple layout-triggering operations that cause significant layout thrashing. Specifically, calling `getBoundingClientRect` on the SVG (line 148)... | b4e04e616a5cc5a8439049ee147fc02f520fb58a | fdb86e8073eb27c168b061fb7fd071b96e5ea16a | diff --git a/website/static/js/navbar.js b/website/static/js/navbar.js
index c96bf00cc2..54f112a7d7 100644
--- a/website/static/js/navbar.js
+++ b/website/static/js/navbar.js
@@ -1,24 +1,61 @@
-const NAV_BUTTON_INITIAL_FONT_SIZE = 28; // Keep up to date with the initial `--nav-font-size` in base.scss
-const RIPPLE_ANIM... | [
"website/static/js/navbar.js"
] | [
{
"comment": "\n\nThe `setRipples` function, which is called on every animation frame via `requestAnimationFrame`, performs multiple layout-triggering operations that cause significant layout thrashing. Specifically, calling `getBoundingClientRec... | true | ||
GraphiteEditor/Graphite | 4,150 | comment_to_fix | Add a wave propagation ripple effect to the website navbar | <!-- cubic:v=ddda69b0-92f5-46b8-b0eb-a288f59ac97c -->
<!-- cubic:review-run=b8ef7a75-8fe3-46fe-a91f-ed53d9492bd1 -->
<!-- metadata:{"confidence":7} -->
P2: `getComputedStyle` for `--border-thickness` and `fontSize` is called every animation frame inside `setRipples`, but these values only change on window resize. Since... | b4e04e616a5cc5a8439049ee147fc02f520fb58a | fdb86e8073eb27c168b061fb7fd071b96e5ea16a | diff --git a/website/static/js/navbar.js b/website/static/js/navbar.js
index c96bf00cc2..54f112a7d7 100644
--- a/website/static/js/navbar.js
+++ b/website/static/js/navbar.js
@@ -1,24 +1,61 @@
-const NAV_BUTTON_INITIAL_FONT_SIZE = 28; // Keep up to date with the initial `--nav-font-size` in base.scss
-const RIPPLE_ANIM... | [
"website/static/js/navbar.js"
] | [
{
"comment": "<!-- cubic:v=ddda69b0-92f5-46b8-b0eb-a288f59ac97c -->\n<!-- cubic:review-run=b8ef7a75-8fe3-46fe-a91f-ed53d9492bd1 -->\n<!-- metadata:{\"confidence\":7} -->\nP2: `getComputedStyle` for `--border-thickness` and `fontSize` is called every animation frame inside `setRipples`, but these values only cha... | true | ||
GraphiteEditor/Graphite | 4,150 | comment_to_fix | Add a wave propagation ripple effect to the website navbar | <!-- metadata:{"confidence":10} -->
P2: Custom agent: **PR title enforcement**
PR title is a noun phrase and not in imperative mood; it must start with an action verb
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if so, understand the root cause and fix it. At website/sass/... | b4e04e616a5cc5a8439049ee147fc02f520fb58a | fdb86e8073eb27c168b061fb7fd071b96e5ea16a | diff --git a/website/sass/base.scss b/website/sass/base.scss
index 3ad0985807..9a5749459d 100644
--- a/website/sass/base.scss
+++ b/website/sass/base.scss
@@ -227,23 +227,34 @@ body > .page {
.ripple {
display: block;
background: none;
- // Covers up content that extends up underneath the header
- fill: ... | [
"website/sass/base.scss"
] | [
{
"comment": "<!-- metadata:{\"confidence\":10} -->\nP2: Custom agent: **PR title enforcement**\n\nPR title is a noun phrase and not in imperative mood; it must start with an action verb\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, understand the root c... | true | ||
GraphiteEditor/Graphite | 4,150 | comment_to_fix | Add a wave propagation ripple effect to the website navbar | <!-- cubic:v=31cfee3c-e76d-4f9e-b45a-3c169fbd7271 -->
<!-- cubic:review-run=e0d3474a-2088-4300-b0e7-c1c17483dba1 -->
<!-- metadata:{"confidence":8} -->
P2: The active nav button is still allowed to animate downward on `pointerleave`, but the changed condition suppresses only its wave emission. This creates a behavior m... | b4e04e616a5cc5a8439049ee147fc02f520fb58a | fdb86e8073eb27c168b061fb7fd071b96e5ea16a | diff --git a/website/static/js/navbar.js b/website/static/js/navbar.js
index c96bf00cc2..54f112a7d7 100644
--- a/website/static/js/navbar.js
+++ b/website/static/js/navbar.js
@@ -1,24 +1,61 @@
-const NAV_BUTTON_INITIAL_FONT_SIZE = 28; // Keep up to date with the initial `--nav-font-size` in base.scss
-const RIPPLE_ANIM... | [
"website/static/js/navbar.js"
] | [
{
"comment": "<!-- cubic:v=31cfee3c-e76d-4f9e-b45a-3c169fbd7271 -->\n<!-- cubic:review-run=e0d3474a-2088-4300-b0e7-c1c17483dba1 -->\n<!-- metadata:{\"confidence\":8} -->\nP2: The active nav button is still allowed to animate downward on `pointerleave`, but the changed condition suppresses only its wave emission... | true | ||
GraphiteEditor/Graphite | 4,218 | issue_to_patch | Skewing images doesn't preview
Adding an image and skewing it doesn't skew the image in the canvas, but does in the preview and export
<img width="1880" height="862" alt="Image" src="https://github.com/user-attachments/assets/59c5469a-7131-4f96-a937-e0337ec6f76b" /> | Fix the SVG renderer not representing skewed raster images | Fixes #4199 | bc1f63ccc65ca236f9b942215e68d6a9934570a7 | fad51f0b47a66f23b7848aa11efabb43927d9288 | diff --git a/node-graph/libraries/rendering/src/renderer.rs b/node-graph/libraries/rendering/src/renderer.rs
index f1dc09175d..7cae299753 100644
--- a/node-graph/libraries/rendering/src/renderer.rs
+++ b/node-graph/libraries/rendering/src/renderer.rs
@@ -1558,11 +1558,9 @@ impl Render for List<Raster<CPU>> {
rende... | [
"node-graph/libraries/rendering/src/renderer.rs"
] | [] | true | |
GraphiteEditor/Graphite | 4,216 | issue_to_patch | Duplicate in Layers Panel with Alt+Drag
Hi, for UX consitency i would suggest that a layer can be duplicated by Alt+Dragging it in the layerspanel.
not shure if this is to early to note some absolutely minor UX inconsitencys as there isnt a UX tag ... feel free to deleat :) i will come back later xD
Best and big th... | Add Alt+drag layer duplication to the Layers panel | Closes #2824. | 04bca4a8770cdaf25ac7d4559ed766dfffddd039 | 1743254c3a93f936982063bc31e05c9d66d8fe4c | diff --git a/editor/src/messages/portfolio/document/document_message.rs b/editor/src/messages/portfolio/document/document_message.rs
index 0adf37244a..22ef7c6385 100644
--- a/editor/src/messages/portfolio/document/document_message.rs
+++ b/editor/src/messages/portfolio/document/document_message.rs
@@ -60,6 +60,10 @@ pu... | [
"editor/src/messages/portfolio/document/document_message.rs",
"editor/src/messages/portfolio/document/document_message_handler.rs",
"frontend/src/components/panels/Layers.svelte",
"frontend/wrapper/src/editor_wrapper.rs"
] | [
{
"comment": "<!-- cubic:v=7e6b41b4-6c64-4bf2-9602-1f263852b1b9 -->\n<!-- cubic:review-run=14194786-74f6-4822-bcee-1ab0cbe90ba9 -->\n<!-- metadata:{\"confidence\":7} -->\nP1: `DuplicateSelectedLayersTo` reparents duplicates without preserving world-space transform. When duplicating into a different transformed ... | true | |
GraphiteEditor/Graphite | 4,216 | comment_to_fix | Add Alt+drag layer duplication to the Layers panel | <!-- cubic:v=7e6b41b4-6c64-4bf2-9602-1f263852b1b9 -->
<!-- cubic:review-run=14194786-74f6-4822-bcee-1ab0cbe90ba9 -->
<!-- metadata:{"confidence":7} -->
P1: `DuplicateSelectedLayersTo` reparents duplicates without preserving world-space transform. When duplicating into a different transformed parent, copies can visibly ... | 04bca4a8770cdaf25ac7d4559ed766dfffddd039 | 1743254c3a93f936982063bc31e05c9d66d8fe4c | diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs
index fed421a143..7ffceb9f5a 100644
--- a/editor/src/messages/portfolio/document/document_message_handler.rs
+++ b/editor/src/messages/portfolio/document/document_message_... | [
"editor/src/messages/portfolio/document/document_message_handler.rs"
] | [
{
"comment": "<!-- cubic:v=7e6b41b4-6c64-4bf2-9602-1f263852b1b9 -->\n<!-- cubic:review-run=14194786-74f6-4822-bcee-1ab0cbe90ba9 -->\n<!-- metadata:{\"confidence\":7} -->\nP1: `DuplicateSelectedLayersTo` reparents duplicates without preserving world-space transform. When duplicating into a different transformed ... | true | ||
GraphiteEditor/Graphite | 4,216 | comment_to_fix | Add Alt+drag layer duplication to the Layers panel | <!-- cubic:v=d985bf2d-5628-4bfc-ad86-d047aa73c22b -->
<!-- cubic:review-run=14194786-74f6-4822-bcee-1ab0cbe90ba9 -->
<!-- metadata:{"confidence":9} -->
P2: `duplicate_layer()` uses `expect(...)` on a runtime lookup, which can panic and crash the editor if the duplicated node map does not contain `NodeId(0)`. Handle the... | 04bca4a8770cdaf25ac7d4559ed766dfffddd039 | 1743254c3a93f936982063bc31e05c9d66d8fe4c | diff --git a/editor/src/messages/portfolio/document/document_message_handler.rs b/editor/src/messages/portfolio/document/document_message_handler.rs
index fed421a143..7ffceb9f5a 100644
--- a/editor/src/messages/portfolio/document/document_message_handler.rs
+++ b/editor/src/messages/portfolio/document/document_message_... | [
"editor/src/messages/portfolio/document/document_message_handler.rs"
] | [
{
"comment": "<!-- cubic:v=d985bf2d-5628-4bfc-ad86-d047aa73c22b -->\n<!-- cubic:review-run=14194786-74f6-4822-bcee-1ab0cbe90ba9 -->\n<!-- metadata:{\"confidence\":9} -->\nP2: `duplicate_layer()` uses `expect(...)` on a runtime lookup, which can panic and crash the editor if the duplicated node map does not cont... | true | ||
GraphiteEditor/Graphite | 4,215 | issue_to_patch | Fix the Pen tool's preview being misplaced and angle-locked after undo or redo | - Undo/redo: no longer leaves the locked angle snapped angle active while Ctrl and/or Shift are pressed
- Undo: no longer leaves the preview segment at a random place until the cursor is moved to update it | cc7d700bfda6961fece0b6125289ef39c9caa0a5 | e9d13c83f719923a509dc957dd1416a0bd0c83e9 | diff --git a/editor/src/messages/tool/tool_messages/pen_tool.rs b/editor/src/messages/tool/tool_messages/pen_tool.rs
index 4a2a65a623..3e953818bb 100644
--- a/editor/src/messages/tool/tool_messages/pen_tool.rs
+++ b/editor/src/messages/tool/tool_messages/pen_tool.rs
@@ -418,6 +418,10 @@ struct PenToolData {
/// avoid... | [
"editor/src/messages/tool/tool_messages/pen_tool.rs"
] | [
{
"comment": "<!-- cubic:v=254f9edd-a9f7-43e3-bdc1-93763ad434b2 -->\n<!-- cubic:review-run=74714f59-e0e4-4021-8b05-e09ebd116cb7 -->\n<!-- metadata:{\"confidence\":7} -->\nP2: `refresh_preview_after_history` doesn't reset `angle_locked`, so it can remain stale (true) from before the undo/redo. When the user late... | true | ||
GraphiteEditor/Graphite | 4,215 | comment_to_fix | Fix the Pen tool's preview being misplaced and angle-locked after undo or redo | <!-- cubic:v=254f9edd-a9f7-43e3-bdc1-93763ad434b2 -->
<!-- cubic:review-run=74714f59-e0e4-4021-8b05-e09ebd116cb7 -->
<!-- metadata:{"confidence":7} -->
P2: `refresh_preview_after_history` doesn't reset `angle_locked`, so it can remain stale (true) from before the undo/redo. When the user later re-presses Ctrl after sup... | cc7d700bfda6961fece0b6125289ef39c9caa0a5 | e9d13c83f719923a509dc957dd1416a0bd0c83e9 | diff --git a/editor/src/messages/tool/tool_messages/pen_tool.rs b/editor/src/messages/tool/tool_messages/pen_tool.rs
index 4a2a65a623..3e953818bb 100644
--- a/editor/src/messages/tool/tool_messages/pen_tool.rs
+++ b/editor/src/messages/tool/tool_messages/pen_tool.rs
@@ -418,6 +418,10 @@ struct PenToolData {
/// avoid... | [
"editor/src/messages/tool/tool_messages/pen_tool.rs"
] | [
{
"comment": "<!-- cubic:v=254f9edd-a9f7-43e3-bdc1-93763ad434b2 -->\n<!-- cubic:review-run=74714f59-e0e4-4021-8b05-e09ebd116cb7 -->\n<!-- metadata:{\"confidence\":7} -->\nP2: `refresh_preview_after_history` doesn't reset `angle_locked`, so it can remain stale (true) from before the undo/redo. When the user late... | true | ||
GraphiteEditor/Graphite | 3,791 | issue_to_patch | Pen tool preview line disappearing during repeated undo
When using the Pen tool to draw a path and pressing Ctrl+Z multiple times, the preview line (showing the segment from the last anchor to the cursor) would disappear after a certain number of undos.
Current behaviour:
https://github.com/user-attachments/assets/b... | Fix the Pen tool preview segment disappearing during repeated undo | Fixes #3790 | 2835c3b53669f6477473da2bb4fb6fb408b005e0 | fcc3fed743ba43002cb069f8b35bccc9e1589886 | diff --git a/editor/src/messages/tool/tool_messages/pen_tool.rs b/editor/src/messages/tool/tool_messages/pen_tool.rs
index 529404b120..4a2a65a623 100644
--- a/editor/src/messages/tool/tool_messages/pen_tool.rs
+++ b/editor/src/messages/tool/tool_messages/pen_tool.rs
@@ -1133,16 +1133,22 @@ impl PenToolData {
let sel... | [
"editor/src/messages/tool/tool_messages/pen_tool.rs"
] | [
{
"comment": "\n\nThe updated undo logic introduces a regression where the tool fails to abort when undoing the first anchor point. \n\nIn the previous implementation, if `point_index` was 0, the tool would send a `PenToolMessage::Abort` and retu... | true | |
GraphiteEditor/Graphite | 3,791 | comment_to_fix | Fix the Pen tool preview segment disappearing during repeated undo | 
The updated undo logic introduces a regression where the tool fails to abort when undoing the first anchor point.
In the previous implementation, if `point_index` was 0, the tool would send a `PenToolMessage::Abort` and return. In the new code, if `p... | 2835c3b53669f6477473da2bb4fb6fb408b005e0 | fcc3fed743ba43002cb069f8b35bccc9e1589886 | diff --git a/editor/src/messages/tool/tool_messages/pen_tool.rs b/editor/src/messages/tool/tool_messages/pen_tool.rs
index 529404b120..4a2a65a623 100644
--- a/editor/src/messages/tool/tool_messages/pen_tool.rs
+++ b/editor/src/messages/tool/tool_messages/pen_tool.rs
@@ -1133,16 +1133,22 @@ impl PenToolData {
let sel... | [
"editor/src/messages/tool/tool_messages/pen_tool.rs"
] | [
{
"comment": "\n\nThe updated undo logic introduces a regression where the tool fails to abort when undoing the first anchor point. \n\nIn the previous implementation, if `point_index` was 0, the tool would send a `PenToolMessage::Abort` and retu... | true | ||
GraphiteEditor/Graphite | 3,791 | comment_to_fix | Fix the Pen tool preview segment disappearing during repeated undo | "This fixes the regression caught by the bot by ensuring the tool aborts if the index is 0."
````suggestion`
if tool_data.point_index > 0 {
tool_data.point_index -= 1;
if tool_data.point_index > 0 {
tool_data
.place_anchor(SnapData::new(document, input, viewport), transform, input.mouse... | 2835c3b53669f6477473da2bb4fb6fb408b005e0 | fcc3fed743ba43002cb069f8b35bccc9e1589886 | diff --git a/editor/src/messages/tool/tool_messages/pen_tool.rs b/editor/src/messages/tool/tool_messages/pen_tool.rs
index 529404b120..4a2a65a623 100644
--- a/editor/src/messages/tool/tool_messages/pen_tool.rs
+++ b/editor/src/messages/tool/tool_messages/pen_tool.rs
@@ -1133,16 +1133,22 @@ impl PenToolData {
let sel... | [
"editor/src/messages/tool/tool_messages/pen_tool.rs"
] | [
{
"comment": "\"This fixes the regression caught by the bot by ensuring the tool aborts if the index is 0.\"\n````suggestion`\nif tool_data.point_index > 0 {\n tool_data.point_index -= 1;\n \n if tool_data.point_index > 0 {\n tool_data\n .place_anchor(SnapData::new(document, input, vi... | true | ||
GraphiteEditor/Graphite | 4,159 | issue_to_patch | Fill node solid colour backup resets when just clicked
Reproduction video clip -
https://github.com/user-attachments/assets/82463db1-9002-4b78-904b-1c8fb3e66f07 | Fix the Fill node not restoring its solid color after switching to gradient and back | closes #3824
When the colour changes, we now compute the new fill value once and save that same new value both as the active Fill and into the correct backup slot.
https://github.com/user-attachments/assets/c69f08c4-5e78-4503-8ec6-ae694eae857c
| 7a6e4f6f25e01ce62167b1ae04a70da3a7d8247e | 4ce016036df8cc25c30f83e396f1827799ff21f1 | diff --git a/editor/src/messages/portfolio/document/node_graph/node_properties.rs b/editor/src/messages/portfolio/document/node_graph/node_properties.rs
index 01cc4fc8bb..031fdafc6e 100644
--- a/editor/src/messages/portfolio/document/node_graph/node_properties.rs
+++ b/editor/src/messages/portfolio/document/node_graph/... | [
"editor/src/messages/portfolio/document/node_graph/node_properties.rs"
] | [
{
"comment": "\n\nThe logic for updating the backup slot and the active fill can be simplified to reduce duplication of the `NodeGraphMessage::SetInputValue` structure and the `node_id` capture. By extracting the backup index and value into a... | true | |
GraphiteEditor/Graphite | 4,159 | comment_to_fix | Fix the Fill node not restoring its solid color after switching to gradient and back | 
The logic for updating the backup slot and the active fill can be simplified to reduce duplication of the `NodeGraphMessage::SetInputValue` structure and the `node_id` capture. By extracting the backup index and value into a separate match expressi... | 7a6e4f6f25e01ce62167b1ae04a70da3a7d8247e | 4ce016036df8cc25c30f83e396f1827799ff21f1 | diff --git a/editor/src/messages/portfolio/document/node_graph/node_properties.rs b/editor/src/messages/portfolio/document/node_graph/node_properties.rs
index 01cc4fc8bb..031fdafc6e 100644
--- a/editor/src/messages/portfolio/document/node_graph/node_properties.rs
+++ b/editor/src/messages/portfolio/document/node_graph/... | [
"editor/src/messages/portfolio/document/node_graph/node_properties.rs"
] | [
{
"comment": "\n\nThe logic for updating the backup slot and the active fill can be simplified to reduce duplication of the `NodeGraphMessage::SetInputValue` structure and the `node_id` capture. By extracting the backup index and value into a... | true | ||
GraphiteEditor/Graphite | 4,175 | issue_to_patch | Tidy up comments by removing several cases of duplicated words | ## Summary
All comment-only fixes.
| File | Line | Fix |
|---|---|---|
| `desktop/src/window/win/native_handle.rs` | 228 | "Return 0 to to tell Windows" → "Return 0 to tell Windows" |
| `node-graph/libraries/vector-types/src/vector/algorithms/spline.rs` | 24 | "is the the second point" → "is the second point" |
| `no... | 51427bef5fb9241c14ade5765ecd616c702691be | fb5c6173fb9cd3a3b35a68a90c0e5c9b5703b8cf | diff --git a/desktop/src/window/win/native_handle.rs b/desktop/src/window/win/native_handle.rs
index 89f062690c..f7070b7db2 100644
--- a/desktop/src/window/win/native_handle.rs
+++ b/desktop/src/window/win/native_handle.rs
@@ -225,7 +225,7 @@ unsafe extern "system" fn main_window_handle_message(hwnd: HWND, msg: u32, wp... | [
"desktop/src/window/win/native_handle.rs",
"editor/src/messages/tool/common_functionality/shapes/shape_utility.rs",
"node-graph/libraries/rendering/src/renderer.rs",
"node-graph/libraries/vector-types/src/vector/algorithms/poisson_disk.rs",
"node-graph/libraries/vector-types/src/vector/algorithms/spline.rs"... | [] | true | ||
GraphiteEditor/Graphite | 4,211 | issue_to_patch | New nodes added in the wrong place
# Reproduction
- Create new document
- Open node graph
- Right click to add new node near the bottom of the node graph view
- Select node
- Observe it is added **not** in the location of the right click.
# Video
https://github.com/user-attachments/assets/d56ad06d-f2f9-4265-9dea-094... | Fix new nodes being added in the wrong place near graph edges | Fixes #4205 | b645871dbcb8e654f86e7db39f76c7b4595c14b8 | dea4227d4524bb18c4be4492f9850ed107ebb96f | diff --git a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs b/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs
index dc9879f3a4..3ac4622911 100644
--- a/editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs
+++ b/editor/src/messag... | [
"editor/src/messages/portfolio/document/node_graph/node_graph_message_handler.rs",
"editor/src/messages/portfolio/document/node_graph/utility_types.rs",
"frontend/src/components/views/Graph.svelte"
] | [] | true | |
GraphiteEditor/Graphite | 4,180 | issue_to_patch | Same Artboard name selects on export
when the user have same name for the artboard they can reselect the new art board because it selects the both artboard on time !
when I select the one it selects the both so it works as same as the "All Artboard" option.
https://github.com/user-attachments/assets/bb1276ce-604e-4... | Fix duplicated dropdown selection styling when multiple entries have identical labels | If a MenuList contains multiple entries with identical labels, currently both entries will appear selected.
<img width="293" height="215" alt="image" src="https://github.com/user-attachments/assets/2cb2b3c8-e290-40e7-bbad-a3d069409f28" />
This PR ensures only one entry appears selected.
<img width="290" height="21... | 85ee5e41b984be6329b20777043f8a826d653ba6 | e81031bec56c158f4a804d9300edb609bc7b0f11 | diff --git a/frontend/src/components/floating-menus/MenuList.svelte b/frontend/src/components/floating-menus/MenuList.svelte
index 1a8e0279a6..09dcb5664c 100644
--- a/frontend/src/components/floating-menus/MenuList.svelte
+++ b/frontend/src/components/floating-menus/MenuList.svelte
@@ -97,7 +97,7 @@
await tick();
... | [
"frontend/src/components/floating-menus/MenuList.svelte"
] | [
{
"comment": "\n\nWhile changing the active class check to use `entry.value` instead of `entry.label` is correct, this fix is incomplete. There are other places in this file that still identify the highlighted entry by its `label` instead of its ... | true | |
GraphiteEditor/Graphite | 4,180 | comment_to_fix | Fix duplicated dropdown selection styling when multiple entries have identical labels | <!-- metadata:{"confidence":9} -->
P2: Truthy check on `highlighted.value` incorrectly drops highlight when `value` is an empty string
<details>
<summary>Prompt for AI agents</summary>
```text
Check if this issue is valid — if so, understand the root cause and fix it. At frontend/src/components/floating-menus/MenuLis... | 85ee5e41b984be6329b20777043f8a826d653ba6 | e81031bec56c158f4a804d9300edb609bc7b0f11 | diff --git a/frontend/src/components/floating-menus/MenuList.svelte b/frontend/src/components/floating-menus/MenuList.svelte
index 1a8e0279a6..09dcb5664c 100644
--- a/frontend/src/components/floating-menus/MenuList.svelte
+++ b/frontend/src/components/floating-menus/MenuList.svelte
@@ -97,7 +97,7 @@
await tick();
... | [
"frontend/src/components/floating-menus/MenuList.svelte"
] | [
{
"comment": "<!-- metadata:{\"confidence\":9} -->\nP2: Truthy check on `highlighted.value` incorrectly drops highlight when `value` is an empty string\n\n<details>\n<summary>Prompt for AI agents</summary>\n\n```text\nCheck if this issue is valid — if so, understand the root cause and fix it. At frontend/src/co... | true | ||
GyulyVGC/sniffnet | 1,211 | issue_to_patch | docs: add Hurdadd as a contributor for translation | Adds @Hurdadd as a contributor for translation.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/pull/1195#issuecomment-4702387022)
[skip ci] | 8794b55ffabe83aa858d7b86d0c98caba89a222e | 135f3e9a20996e0a052d03eca058ddb88471f8b2 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index 4a8ac038d..caf91f827 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -993,6 +993,15 @@
"contributions": [
"translation"
]
+ },
+ {
+ "login": "Hurdadd",
+ "name": "Hurdad Ashouri",
+ "avatar_url": "htt... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,195 | issue_to_patch | Add Persian translations (v1.4) | Adds missing Persian translations for version 1.4.
RTL support is currently disabled in GUI library, so translations are commented out to avoid runtime issues. | 25c3c67f5b947aed32c7060e55ebba1aa4f4f41b | db142d710bffdefa3388b912da1fa5ad813d82ff | diff --git a/src/translations/translations_4.rs b/src/translations/translations_4.rs
index aad99e91e..ff8a1a299 100644
--- a/src/translations/translations_4.rs
+++ b/src/translations/translations_4.rs
@@ -6,6 +6,7 @@ pub fn reserved_address_translation(language: Language, info: &str) -> String {
match language {
... | [
"src/translations/translations_4.rs"
] | [] | true | ||
GyulyVGC/sniffnet | 1,210 | issue_to_patch | docs: add pml68 as a contributor for translation | Adds @pml68 as a contributor for translation.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/pull/1197#issuecomment-4702382126)
[skip ci] | d2566f8e457ab86dfb533e1c17fa045b94cc009e | 552a5ff76f14d3d307a7eb9778d02c9340b1da19 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index 9d2b4bc7f..4a8ac038d 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -984,6 +984,15 @@
"contributions": [
"financial"
]
+ },
+ {
+ "login": "pml68",
+ "name": "Polesznyák Márk László",
+ "avatar_url": ... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,197 | issue_to_patch | Hungarian translations up to 1.5 including yet-to-be-used ones | Few small caveats:
1. I'm not *entirely* sure about some of the unused translations due to a lack of context, but I can always come back to those later.
2. I didn't update `subset_characters.txt`. I saw there's a `fonts.sh` script that generates the complete file and does subsetting, but running produced an overall n... | 8cb61c8b4052f21fbbc805b88587689e09682179 | 236c1b367d278957404520f31da286a8e77d2e84 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index c55c3853b..9d2b4bc7f 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -939,6 +939,51 @@
"contributions": [
"translation"
]
+ },
+ {
+ "login": "GeorgeLS",
+ "name": "George Liontos",
+ "avatar_url": "ht... | [
".all-contributorsrc",
".design/README.md",
".well-known/funding-manifest-urls",
"CHANGELOG.md",
"CODE_OF_CONDUCT.md",
"CONTRIBUTORS.md",
"Cargo.lock",
"Cargo.toml",
"INCIDENT_RESPONSE.md",
"README.md",
"SECURITY.md",
"THREAT_MODEL.md",
"build.rs",
"giscus.json",
"resources/logos/raw/rec... | [] | diff --git a/resources/test/ip_blacklist_real_cidr_ranges.txt b/resources/test/ip_blacklist_real_cidr_ranges.txt
new file mode 100644
index 000000000..a290dc79e
--- /dev/null
+++ b/resources/test/ip_blacklist_real_cidr_ranges.txt
@@ -0,0 +1,6 @@
+209.186.20.0/22
+209.186.24.0/21
+209.186.224.0/21
+209.186.232.0/22
+209... | true | |
GyulyVGC/sniffnet | 1,196 | issue_to_patch | Add persian translations (v1.5) | 3b1375d4c4a50c0ec79e37f13923a4610404f2dd | 14a4690fb1cd091d2061eca3e634664f42658b2d | diff --git a/src/translations/translations_5.rs b/src/translations/translations_5.rs
index 7e67f5e2a..29ff5d0e8 100644
--- a/src/translations/translations_5.rs
+++ b/src/translations/translations_5.rs
@@ -6,6 +6,7 @@ pub fn filter_traffic_translation(language: Language) -> String {
match language {
Langua... | [
"src/translations/translations_5.rs"
] | [] | true | |||
GyulyVGC/sniffnet | 499 | issue_to_patch | Romanian translations for v1.3 | c0f1f7002b0d234353409978b6845c4225c27208 | c2949cdf57b9fa60074a14e0cb1da1183495ca56 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index f3dbd6ecc..33a4a8b6a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -8,6 +8,7 @@ All Sniffnet releases with the relative changes are documented in this file.
- German - [#495](https://github.com/GyulyVGC/sniffnet/pull/495)
- Russian - [#496](https://github.com/Gyuly... | [
"CHANGELOG.md",
"src/translations/translations_3.rs",
"src/translations/types/language.rs"
] | [] | true | |||
GyulyVGC/sniffnet | 1,204 | issue_to_patch | docs: add golanbenoni as a contributor for financial | Adds @golanbenoni as a contributor for financial.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/pull/1113#issuecomment-4647788082)
[skip ci] | 953060098aa56f7cbbf8033a70ee715f36534026 | 10dfea6b814e7de12b4faf1ee92926d390c90645 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index 9a2f26dc8..9d2b4bc7f 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -975,6 +975,15 @@
"contributions": [
"ideas"
]
+ },
+ {
+ "login": "golanbenoni",
+ "name": "golanbenoni",
+ "avatar_url": "https://... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,113 | issue_to_patch | v1.5.0 | Preparing for version 1.5.0. | 221d7cf4bca6f6933fa57434228b660bc0f3122c | 50e52c862eee3feeb75ef0b3312783c46595e3ce | diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml
index 4e4a0e0e1..f0acb7e44 100644
--- a/.github/workflows/package.yml
+++ b/.github/workflows/package.yml
@@ -393,7 +393,7 @@ jobs:
if-no-files-found: error
- name: Sign package artifacts
- uses: signpath/github-action... | [
".github/workflows/package.yml",
"CHANGELOG.md",
"Cargo.lock",
"Cargo.toml",
"Cross.toml",
"README.md",
"build.rs",
"resources/DB/GeoLite2-ASN.mmdb",
"resources/DB/GeoLite2-Country.mmdb",
"resources/fonts/full/subset_characters.txt",
"resources/fonts/subset/sarasa-mono-sc-regular.subset.ttf",
... | [] | true | ||
GyulyVGC/sniffnet | 1,186 | issue_to_patch | docs: add ahassany as a contributor for ideas | Adds @ahassany as a contributor for ideas.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/issues/303#issuecomment-4418907640)
[skip ci] | bd8b8bdced04a2fe721bc5f3e5e43b0cc5320c66 | 291f4610aa2d8a1ddc1839fa2d84b8caf0358052 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index d589fb54b..9a2f26dc8 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -966,6 +966,15 @@
"contributions": [
"code"
]
+ },
+ {
+ "login": "ahassany",
+ "name": "Ahmed Elhassany",
+ "avatar_url": "https://... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,183 | issue_to_patch | feat: improve IP blacklist import feedback | ## Summary
This PR improves feedback for imported IP blacklist files.
Previously, when an imported blacklist file could not be used, the settings page only showed the path in the danger/error style. It was not clear whether the file could not be read, was empty, or did not contain any valid blacklist entries.
... | e4534b0e0f1a34edd69d2d98f839ed9a2c040b6c | 6b8313a783c161b8109df401e74592e02357b109 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 588f1893e..1655b423a 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,7 @@ All Sniffnet releases with the relative changes are documented in this file.
## [UNRELEASED]
- Support CIDR ranges in imported IP blacklists ([#1181](https://github.com/GyulyVGC/sniffnet/... | [
"CHANGELOG.md",
"src/gui/pages/settings_general_page.rs",
"src/networking/types/ip_blacklist.rs"
] | [] | true | ||
GyulyVGC/sniffnet | 1,181 | issue_to_patch | feat: support CIDR ranges in imported IP blacklists | ## Summary
This PR adds CIDR range support to imported IP blacklists.
Previously, imported blacklist files only supported exact IPv4/IPv6 addresses. This meant common blacklist sources that publish CIDR ranges, such as Spamhaus DROP-style lists, could not be used directly without manually expanding ranges into in... | 8dad7213819c6095cb8c7f1d08b15ea787c8f7b2 | 388c56469cb15b0eb219ed011a22f2205b3dfe95 | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 032cdf20b..588f1893e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,7 @@
All Sniffnet releases with the relative changes are documented in this file.
## [UNRELEASED]
+- Support CIDR ranges in imported IP blacklists ([#1181](https://github.com/GyulyVGC/sniffnet... | [
"CHANGELOG.md",
"Cargo.lock",
"Cargo.toml",
"README.md",
"resources/test/ip_blacklist_real_cidr_ranges.txt",
"resources/test/ip_blacklist_valid_cidr_only.txt",
"resources/test/ip_blacklist_valid_with_cidr.txt",
"src/networking/types/bogon.rs",
"src/networking/types/ip_blacklist.rs",
"src/networkin... | [] | diff --git a/resources/test/ip_blacklist_real_cidr_ranges.txt b/resources/test/ip_blacklist_real_cidr_ranges.txt
new file mode 100644
index 000000000..a290dc79e
--- /dev/null
+++ b/resources/test/ip_blacklist_real_cidr_ranges.txt
@@ -0,0 +1,6 @@
+209.186.20.0/22
+209.186.24.0/21
+209.186.224.0/21
+209.186.232.0/22
+209... | true | |
GyulyVGC/sniffnet | 1,182 | issue_to_patch | docs: add TheMasterOfDisasters as a contributor for code | Adds @TheMasterOfDisasters as a contributor for code.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/pull/1181#issuecomment-4400684948)
[skip ci] | d3227759088efe01eea00db02797f907183b8d24 | 7a30250387516bce9ab0fc8802b6df230c42df1d | diff --git a/.all-contributorsrc b/.all-contributorsrc
index e58873eec..d589fb54b 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -957,6 +957,15 @@
"contributions": [
"financial"
]
+ },
+ {
+ "login": "TheMasterOfDisasters",
+ "name": "TheMasterOfDisasters",
+ "... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,180 | issue_to_patch | docs: add SimplyClever96 as a contributor for financial | Adds @SimplyClever96 as a contributor for financial.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/pull/1113#issuecomment-4389530111)
[skip ci] | 4cb0bcbec6dbac0eebe08df099ba7a4b561dd6e8 | caaf0a08eab0f0c3a26b5045a2bb8ed1563bb740 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index 853e317fe..e58873eec 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -948,6 +948,15 @@
"contributions": [
"translation"
]
+ },
+ {
+ "login": "SimplyClever96",
+ "name": "Kevin",
+ "avatar_url": "https... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,177 | issue_to_patch | docs: add GeorgeLS as a contributor for translation | Adds @GeorgeLS as a contributor for translation.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/pull/1175#issuecomment-4382820068)
[skip ci] | 8cb61c8b4052f21fbbc805b88587689e09682179 | 76549e4cdb50c76c982a63b9404dbbe35b1f4cbc | diff --git a/.all-contributorsrc b/.all-contributorsrc
index c55c3853b..853e317fe 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -939,6 +939,15 @@
"contributions": [
"translation"
]
+ },
+ {
+ "login": "GeorgeLS",
+ "name": "George Liontos",
+ "avatar_url": "ht... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,175 | issue_to_patch | Add Greek translations | Adds Greek translations/improvements and marks Greek as up to date. | 5c89eb1c5894abd632b6837b56912d0c0a7d1c85 | 55f065ebd8bd2abe4b19993d71574ec2ad02771d | diff --git a/src/translations/translations.rs b/src/translations/translations.rs
index f38beb9b8..0e680ff04 100644
--- a/src/translations/translations.rs
+++ b/src/translations/translations.rs
@@ -1196,12 +1196,12 @@ pub fn bytes_translation(language: Language) -> &'static str {
| Language::IT
| Langu... | [
"src/translations/translations.rs",
"src/translations/translations_2.rs",
"src/translations/translations_4.rs",
"src/translations/translations_5.rs",
"src/translations/types/language.rs"
] | [] | true | ||
GyulyVGC/sniffnet | 1,174 | issue_to_patch | AppImage - broken X-AppImage-Version entry
### Is there an existing issue for this?
- [x] I have searched the existing issues.
### What's the problem?
AppImage release
`X-AppImage-Version` entry in `sniffnet.desktop` contains `.glibc2.30`. It should use the current app version as semantic version like `1.4.2`
Tha... | Fix X-AppImage-Version | Set X-AppImage-Version to Sniffnet version number
Fixes #1003 | 28ceaf088248d1a1b4b48d589dff6ddd3a3630fb | 70f9ecfc97238c31c3dec01fbf32d5fc82d5c5e7 | diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml
index e0758b135..3f214bbd0 100644
--- a/.github/workflows/package.yml
+++ b/.github/workflows/package.yml
@@ -204,14 +204,16 @@ jobs:
- name: Replace placeholders
shell: bash
run: |
- sed -i -e 's/REPLACE_TAG/Sn... | [
".github/workflows/package.yml",
"CHANGELOG.md",
"Cargo.lock",
"Cargo.toml"
] | [] | true | |
GyulyVGC/sniffnet | 1,173 | issue_to_patch | docs: add Elyrial as a contributor for translation | Adds @Elyrial as a contributor for translation.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/pull/1068#issuecomment-4364092230)
[skip ci] | 4d290dc2aef121194e2cd42de225983837ae7459 | 13255437f78a55a94932931d30dc3b70eee88201 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index 707487593..c55c3853b 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -930,6 +930,15 @@
"contributions": [
"translation"
]
+ },
+ {
+ "login": "Elyrial",
+ "name": "Elyrial",
+ "avatar_url": "https://av... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,068 | issue_to_patch | Update swedish translation to v1.4 | Hi guys,
I added the swedish translation for v1.4 as well as the remaining translations for the upcoming v1.5 | 292dc95b31fe31ebfa1d63011ab77df93f142d63 | d86e711d0488d3383255326b31a6f3a29fddfbc6 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index a401c9962..707487593 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -903,6 +903,33 @@
"contributions": [
"financial"
]
+ },
+ {
+ "login": "DmytroGaiduk",
+ "name": "Dmytro Gaiduk",
+ "avatar_url": "h... | [
".all-contributorsrc",
"CHANGELOG.md",
"CONTRIBUTORS.md",
"src/gui/components/ellipsized_text.rs",
"src/gui/pages/overview_page.rs",
"src/gui/pages/thumbnail_page.rs",
"src/gui/styles/container.rs",
"src/gui/styles/text.rs",
"src/translations/translations_4.rs",
"src/translations/translations_5.rs... | [] | true | ||
GyulyVGC/sniffnet | 1,172 | issue_to_patch | docs: add FrancoB4 as a contributor for translation | Adds @FrancoB4 as a contributor for translation.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/pull/1140#issuecomment-4358286968)
[skip ci] | f6d04ba141ff7a4860e2300b8797db88b67aaab4 | 328c28bad3f768a79d42aa5caa80fd8b6165d0b0 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index 9092eacc1..707487593 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -921,6 +921,15 @@
"contributions": [
"translation"
]
+ },
+ {
+ "login": "FrancoB4",
+ "name": "Franco Bonfiglio Vazquez",
+ "avatar... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,140 | issue_to_patch | Add Spanish translations for v1.5 | 8a91265376b46db20aacae554431595a46c1fa73 | 7051bdf7666ca4d42d6f40d7fbc7ac6135a4415a | diff --git a/src/translations/translations_5.rs b/src/translations/translations_5.rs
index 1a9a03599..5503832c7 100644
--- a/src/translations/translations_5.rs
+++ b/src/translations/translations_5.rs
@@ -12,6 +12,7 @@ pub fn filter_traffic_translation(language: Language) -> String {
Language::ZH_TW => "篩選流量",... | [
"src/translations/translations_5.rs"
] | [] | true | |||
GyulyVGC/sniffnet | 1,171 | issue_to_patch | docs: add HiProfession as a contributor for translation | Adds @HiProfession as a contributor for translation.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/pull/1122#issuecomment-4358276584)
[skip ci] | e0cc04c9f9e4199fbafb0d6bc69d1a955c6f9510 | c87f3734de6d7730a8059611b2536a3605bdd9c9 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index 640055d3d..9092eacc1 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -912,6 +912,15 @@
"contributions": [
"translation"
]
+ },
+ {
+ "login": "HiProfession",
+ "name": "Christian",
+ "avatar_url": "htt... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,122 | issue_to_patch | Update german translation | This pr updates some previous german `de` translations and adds translations for all new v1.5 expressions
Addresses Issue #60
| dccc7062b5dc93ae81d35a5c67257b23a49dca78 | d49e8a700fcf043a8a81a953810645ff47b233ba | diff --git a/src/translations/translations.rs b/src/translations/translations.rs
index c7bcb6c84..f38beb9b8 100644
--- a/src/translations/translations.rs
+++ b/src/translations/translations.rs
@@ -256,7 +256,7 @@ pub fn traffic_rate_translation<'a>(language: Language) -> Text<'a, StyleType> {
Language::FR => "... | [
"src/translations/translations.rs",
"src/translations/translations_2.rs",
"src/translations/translations_3.rs",
"src/translations/translations_4.rs",
"src/translations/translations_5.rs"
] | [] | true | ||
GyulyVGC/sniffnet | 1,170 | issue_to_patch | docs: add DmytroGaiduk as a contributor for translation | Adds @DmytroGaiduk as a contributor for translation.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/pull/1039#issuecomment-4358217541)
[skip ci] | 292dc95b31fe31ebfa1d63011ab77df93f142d63 | de2840e4328146faaa740ba2e453b509b7495770 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index a401c9962..640055d3d 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -903,6 +903,15 @@
"contributions": [
"financial"
]
+ },
+ {
+ "login": "DmytroGaiduk",
+ "name": "Dmytro Gaiduk",
+ "avatar_url": "h... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,039 | issue_to_patch | Add Ukrainian translation for version 1.4 | I've updated the Ukrainian translation to support 1.4 (and part of future 1.5 release). | 6bf415a19a02d59574aadeff229475b0bf09a2e3 | a96cd8cdae754fe2e580ea11e4c878806e63da27 | diff --git a/src/translations/translations_4.rs b/src/translations/translations_4.rs
index 6589e3125..673f9b254 100644
--- a/src/translations/translations_4.rs
+++ b/src/translations/translations_4.rs
@@ -44,6 +44,7 @@ pub fn share_feedback_translation(language: Language) -> &'static str {
Language::EL => "Μοι... | [
"src/translations/translations_4.rs",
"src/translations/translations_5.rs"
] | [] | true | ||
GyulyVGC/sniffnet | 1,145 | issue_to_patch | Add Indonesian 🇮🇩 translations for v1.5 | Add Indonesian 🇮🇩 translations for v1.5 | f720c8c8ca541a7448b3890636dc8582a3d28b89 | 70ee002134e05276c5a354955489d46dc82a4aae | diff --git a/src/translations/translations_5.rs b/src/translations/translations_5.rs
index 5503832c7..0ab66b1e7 100644
--- a/src/translations/translations_5.rs
+++ b/src/translations/translations_5.rs
@@ -14,6 +14,7 @@ pub fn filter_traffic_translation(language: Language) -> String {
Language::JA => "トラフィックをフィ... | [
"src/translations/translations_5.rs"
] | [] | true | ||
GyulyVGC/sniffnet | 1,123 | issue_to_patch | Add French translations | Adding french strings. | 71abd8eb805b065ec1c049c179e0e39176ccfa06 | c42603e9f6a4ccfdb7644774c9539cd7266d8c17 | diff --git a/src/translations/translations_5.rs b/src/translations/translations_5.rs
index c08efe3c1..1a9a03599 100644
--- a/src/translations/translations_5.rs
+++ b/src/translations/translations_5.rs
@@ -13,6 +13,7 @@ pub fn filter_traffic_translation(language: Language) -> String {
Language::TR => "Trafiği f... | [
"src/translations/translations_5.rs"
] | [] | true | ||
GyulyVGC/sniffnet | 1,155 | issue_to_patch | docs: add abiton-glenn as a contributor for financial | Adds @abiton-glenn as a contributor for financial.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/pull/1113#issuecomment-4316304129)
[skip ci] | 10c609b744fb0bfa25fd4e7da374b1178d476380 | 30314c007bc346b05b69b0fb0071341dc5d7bd59 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index c726b4da3..a401c9962 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -894,6 +894,15 @@
"contributions": [
"ideas"
]
+ },
+ {
+ "login": "abiton-glenn",
+ "name": "Glenn Johansson",
+ "avatar_url": "htt... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,141 | issue_to_patch | docs: add mbe57 as a contributor for ideas | Adds @mbe57 as a contributor for ideas.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/issues/1136#issuecomment-4279055242)
[skip ci] | 936793ced596be2668319e572c6bbf490fcb5742 | 4af6e0f9115ab6883856d67e660711599b35da0a | diff --git a/.all-contributorsrc b/.all-contributorsrc
index 918cfe719..c726b4da3 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -885,6 +885,15 @@
"contributions": [
"translation"
]
+ },
+ {
+ "login": "mbe57",
+ "name": "mbe57",
+ "avatar_url": "https://avatar... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,124 | issue_to_patch | Bump actions/checkout from 4 to 6 | Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v6.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update README to includ... | 8365353d562f94de49f95dcf38979aabf290551e | 858f6c9262d00c33282ff3c64584f3b0ff17284a | diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
index 4d66a31d5..a3548cf24 100644
--- a/.github/workflows/codeql.yml
+++ b/.github/workflows/codeql.yml
@@ -29,7 +29,7 @@ jobs:
steps:
- name: Checkout repository
- uses: actions/checkout@v4
+ uses: actions/checkout@v6
... | [
".github/workflows/codeql.yml"
] | [] | true | ||
GyulyVGC/sniffnet | 1,119 | issue_to_patch | Bump signpath/github-action-submit-signing-request from 2.1 to 2.2 | Bumps [signpath/github-action-submit-signing-request](https://github.com/signpath/github-action-submit-signing-request) from 2.1 to 2.2.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/SignPath/github-action-submit-signing-request/commit/b9d91eadd323de506c0c81cf0c7fe7438f3360fd"><code>b9d91ea<... | 580598df6b29a5916e62570da42c1bcab3743ba8 | 6c1c4c5a421e8935599799d9a4ba9b65d3ee63a2 | diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml
index f0acb7e44..e0758b135 100644
--- a/.github/workflows/package.yml
+++ b/.github/workflows/package.yml
@@ -393,7 +393,7 @@ jobs:
if-no-files-found: error
- name: Sign package artifacts
- uses: signpath/github-action... | [
".github/workflows/package.yml"
] | [] | true | ||
GyulyVGC/sniffnet | 1,115 | issue_to_patch | Bump signpath/github-action-submit-signing-request from 2.0 to 2.1 | Bumps [signpath/github-action-submit-signing-request](https://github.com/signpath/github-action-submit-signing-request) from 2.0 to 2.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/SignPath/github-action-submit-signing-request/commit/bc66d86b015a46e9c6d9700de73143a82f9570ff"><code>bc66d86<... | 61dd289300817e2c94f6df3ad2033365438079aa | 4b368489e206c5c149f7f10447615bb1c561da6b | diff --git a/.github/workflows/package.yml b/.github/workflows/package.yml
index 4e4a0e0e1..f0acb7e44 100644
--- a/.github/workflows/package.yml
+++ b/.github/workflows/package.yml
@@ -393,7 +393,7 @@ jobs:
if-no-files-found: error
- name: Sign package artifacts
- uses: signpath/github-action... | [
".github/workflows/package.yml"
] | [] | true | ||
GyulyVGC/sniffnet | 1,021 | issue_to_patch | added ZH,ZH_TW translations | 8fb08d67c2cea0ec8b65bef1746350922f53c3c6 | e218773882ffcabec560a3a6d75483688b3d102b | diff --git a/src/translations/translations_5.rs b/src/translations/translations_5.rs
index 6b5c18cb8..d6ab285a1 100644
--- a/src/translations/translations_5.rs
+++ b/src/translations/translations_5.rs
@@ -7,6 +7,8 @@ pub fn filter_traffic_translation(language: Language) -> String {
Language::EN => "Filter traf... | [
"src/translations/translations_5.rs"
] | [] | true | |||
GyulyVGC/sniffnet | 1,112 | issue_to_patch | docs: add DeeEffAre as a contributor for translation | Adds @DeeEffAre as a contributor for translation.
This was requested by GyulyVGC [in this comment](https://github.com/GyulyVGC/sniffnet/pull/1074#issuecomment-4209526864)
[skip ci] | b6262328d428b0c07db1a6c21b8aa0ab591cd235 | 76037302ab636abadc2e3ca2ccfa48996a01ee43 | diff --git a/.all-contributorsrc b/.all-contributorsrc
index 691c5f37d..918cfe719 100644
--- a/.all-contributorsrc
+++ b/.all-contributorsrc
@@ -876,6 +876,15 @@
"contributions": [
"bug"
]
+ },
+ {
+ "login": "DeeEffAre",
+ "name": "Enes Çaydere",
+ "avatar_url": "https://ava... | [
".all-contributorsrc",
"CONTRIBUTORS.md"
] | [] | true | ||
GyulyVGC/sniffnet | 1,074 | issue_to_patch | Add Turkish translation for v1.4 and v1.5 | c5ae757b276baa75e830ee520ceba1453ba02a1b | d95beebef0f3d609cd17a9f35b4a5735c0491900 | diff --git a/src/translations/translations_4.rs b/src/translations/translations_4.rs
index 78a389a62..6589e3125 100644
--- a/src/translations/translations_4.rs
+++ b/src/translations/translations_4.rs
@@ -21,6 +21,7 @@ pub fn reserved_address_translation(language: Language, info: &str) -> String {
Language::ID... | [
"src/translations/translations_4.rs",
"src/translations/translations_5.rs"
] | [] | true | |||
GyulyVGC/sniffnet | 1,020 | issue_to_patch | Added Japanese translation to translations_5.rs | This pull request adds Japanese translations to `src/translations/translations_5.rs`
Refs: #60 | 0918804bcd734074c8d55dc5a5ae76409154b691 | b0deec5e961fb7691d156c53942532d445893cd8 | diff --git a/src/translations/translations_5.rs b/src/translations/translations_5.rs
index 96d5bb86c..efb54f55a 100644
--- a/src/translations/translations_5.rs
+++ b/src/translations/translations_5.rs
@@ -7,6 +7,7 @@ pub fn filter_traffic_translation(language: Language) -> String {
Language::EN => "Filter traf... | [
"src/translations/translations_5.rs"
] | [] | true | ||
GyulyVGC/sniffnet | 942 | issue_to_patch | Update translations_5.rs | Added romanian translation | 64be63bf30bcd96db65aeaa39ec96de429a01a60 | cc5c4527812c0dfc0b78229fa8be6b1f8bf3228b | diff --git a/src/translations/translations_5.rs b/src/translations/translations_5.rs
index c594fe8a6..96d5bb86c 100644
--- a/src/translations/translations_5.rs
+++ b/src/translations/translations_5.rs
@@ -7,6 +7,7 @@ pub fn filter_traffic_translation(language: Language) -> String {
Language::EN => "Filter traf... | [
"src/translations/translations_5.rs"
] | [] | true | ||
GyulyVGC/sniffnet | 1,111 | issue_to_patch | [ImgBot] Optimize images | ## Beep boop. Your images are optimized!
Your image file size has been reduced by **20%** 🎉
<details>
<summary>
Details
</summary>
| File | Before | After | Percent reduction |
|:--|:--|:--|:--|
| /resources/repository/pages/inspect.png | 191.64kb | 130.67kb | 31.81% |
| /resources/repository/pages/noti... | 4c8621cea24655ff4647b20262639b8744085c4e | 7cfb02a286472c55a50529d676302e16360c632d | diff --git a/resources/repository/pages/deep_cosmos.png b/resources/repository/pages/deep_cosmos.png
index a73d05cbd..9caa104cb 100644
Binary files a/resources/repository/pages/deep_cosmos.png and b/resources/repository/pages/deep_cosmos.png differ
diff --git a/resources/repository/pages/inspect.png b/resources/reposit... | [
"resources/repository/pages/deep_cosmos.png",
"resources/repository/pages/inspect.png",
"resources/repository/pages/notifications.png",
"resources/repository/pages/overview.png",
"resources/repository/pages/thumbnail.png"
] | [] | true | ||
GyulyVGC/sniffnet | 1,110 | issue_to_patch | [ImgBot] Optimize images | ## Beep boop. Your images are optimized!
Your image file size has been reduced by **8%** 🎉
<details>
<summary>
Details
</summary>
| File | Before | After | Percent reduction |
|:--|:--|:--|:--|
| /resources/embedded_icons/default_picon.svg | 2.96kb | 2.27kb | 23.18% |
| /resources/embedded_icons/countri... | edd1e519a689aa770ba3ddf15d83bfee251b06f4 | 4074cbc9c27c0ee4396346b76d3c6480e88a4438 | diff --git a/resources/embedded_icons/countries/zz-bogon.svg b/resources/embedded_icons/countries/zz-bogon.svg
index 2ac8d700c..e770d8a26 100644
--- a/resources/embedded_icons/countries/zz-bogon.svg
+++ b/resources/embedded_icons/countries/zz-bogon.svg
@@ -1,37 +1,1 @@
-<?xml version="1.0" encoding="UTF-8" standalone="... | [
"resources/embedded_icons/countries/zz-bogon.svg",
"resources/embedded_icons/countries/zz-broadcast.svg",
"resources/embedded_icons/countries/zz-computer.svg",
"resources/embedded_icons/countries/zz-home.svg",
"resources/embedded_icons/countries/zz-multicast.svg",
"resources/embedded_icons/countries/zz-un... | [] | true | ||
GyulyVGC/sniffnet | 1,108 | issue_to_patch | Potential fix for code scanning alert no. 1: Workflow does not contain permissions | Potential fix for [https://github.com/GyulyVGC/sniffnet/security/code-scanning/1](https://github.com/GyulyVGC/sniffnet/security/code-scanning/1)
In general, the fix is to define an explicit `permissions:` block in the workflow, restricting the `GITHUB_TOKEN` to the minimal set needed. Since these jobs only check out c... | 5484515101dbe7cb647d922fa7dfb9a306b6a546 | c4fd4a85ebde6a32545eac18843be5692d97a511 | diff --git a/.github/workflows/crates.yml b/.github/workflows/crates.yml
index 2439aafa0..b48d54b3e 100644
--- a/.github/workflows/crates.yml
+++ b/.github/workflows/crates.yml
@@ -6,6 +6,8 @@ on:
jobs:
crates:
runs-on: macos-latest
+ permissions:
+ contents: read
steps:
- uses: actions/che... | [
".github/workflows/crates.yml",
".github/workflows/docker.yml",
".github/workflows/package.yml",
".github/workflows/rust.yml"
] | [] | true | ||
GyulyVGC/sniffnet | 1,100 | issue_to_patch | Bump quinn-proto from 0.11.13 to 0.11.14 | Bumps [quinn-proto](https://github.com/quinn-rs/quinn) from 0.11.13 to 0.11.14.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/quinn-rs/quinn/releases">quinn-proto's releases</a>.</em></p>
<blockquote>
<h2>quinn-proto 0.11.14</h2>
<p><a href="https://github.com/jxs"><code>@j... | 9eceb99f10a12da2ba7430483330f8b3988f8529 | b4fbc3ed42f1e80493804548c174272af1bce920 | diff --git a/Cargo.lock b/Cargo.lock
index e118950c1..d4c920c53 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3980,9 +3980,9 @@ dependencies = [
[[package]]
name = "quinn-proto"
-version = "0.11.13"
+version = "0.11.14"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "f1906b49b0c3bc04b5... | [
"Cargo.lock"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.