repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
ApolloAuto/apollo | 14,857 | issue_to_patch | fix: fix build error after merge #14850 | cd510fe5c4b3197383900d00b0f832d4be9ca5b0 | bbf29ee48683131679a9ff98b6c1410f907ecc7c | diff --git a/BUILD b/BUILD
index 763b76a5f97..5c26c388e3c 100644
--- a/BUILD
+++ b/BUILD
@@ -1,5 +1,5 @@
load("//tools/install:install.bzl", "install", "install_src_files")
-load("//tools/platform:build_defs.bzl", "if_gpu")
+load("//third_party/gpus:common.bzl", "if_gpu")
package(
default_visibility = ["//visi... | [
"BUILD",
"modules/audio/inference/BUILD",
"modules/common/util/BUILD",
"modules/perception/inference/libtorch/BUILD",
"modules/perception/inference/onnx/BUILD",
"modules/planning/learning_based/model_inference/BUILD",
"modules/planning/proto/BUILD",
"modules/planning/scenarios/bare_intersection/unprot... | [] | true | |||
App-vNext/Polly | 3,115 | issue_to_patch | Set SOURCE_DATE_EPOCH | Set the `SOURCE_DATE_EPOCH` to the date of the checked-out Git commit to use for [NuGet's `DeterministicTimestamp` in .NET 11](https://github.com/dotnet/core/blob/main/release-notes/11.0/preview/preview5/nuget.md#deterministic-pack-support-is-restored).
| 9a4cb07ca4a37d71d6a2b36c553cba3304c74517 | 2835272a0667b6858b7573d764010e3a5ada1e0f | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 3dd59c9dee1..ab2fb114166 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -78,6 +78,12 @@ jobs:
persist-credentials: false
show-progress: false
+ - name: Get Git commit timestamp
+ id: g... | [
".github/workflows/build.yml"
] | [] | true | ||
App-vNext/Polly | 3,114 | issue_to_patch | Bump Refit.HttpClientFactory from 10.2.0 to 11.0.1 | Updated [Refit.HttpClientFactory](https://github.com/reactiveui/refit) from 10.2.0 to 11.0.1.
<details>
<summary>Release notes</summary>
_Sourced from [Refit.HttpClientFactory's releases](https://github.com/reactiveui/refit/releases)._
## 11.0.1
## 🗞️ What's Changed
### 🧹 General Changes
* reactiveui/refit@484... | 6da35592d929176942bb56ecba5c393835f9df13 | 6cccecc56794cbde2d306d31bdf08fa1f0129bde | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 3733a887556..58e4d44b600 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -29,7 +29,7 @@
<PackageVersion Include="Polly.Extensions" Version="8.7.0" />
<PackageVersion Include="Polly.RateLimiting" Version="8.7.0" />
... | [
"Directory.Packages.props"
] | [] | true | ||
App-vNext/Polly | 3,113 | issue_to_patch | Bump meziantou.framework.nugetpackagevalidation.tool from 1.0.53 to 1.0.54 | Updated [meziantou.framework.nugetpackagevalidation.tool](https://github.com/meziantou/Meziantou.Framework) from 1.0.53 to 1.0.54.
<details>
<summary>Release notes</summary>
_Sourced from [meziantou.framework.nugetpackagevalidation.tool's releases](https://github.com/meziantou/Meziantou.Framework/releases)._
No rele... | 6da35592d929176942bb56ecba5c393835f9df13 | db041d5a56550de524970e76ba65588582a148b1 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 1f7308691a1..0d55ce44f48 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -52,7 +52,7 @@
"rollForward": false
},
"meziantou.framework.nugetpackagevalidation.tool": {
- "version": "1.0.53",
+ "ver... | [
".config/dotnet-tools.json"
] | [] | true | ||
App-vNext/Polly | 3,112 | issue_to_patch | Bump martincostello/update-dotnet-sdk/.github/workflows/update-dotnet-sdk.yml from 5.0.4 to 6.0.0 | Bumps [martincostello/update-dotnet-sdk/.github/workflows/update-dotnet-sdk.yml](https://github.com/martincostello/update-dotnet-sdk) from 5.0.4 to 6.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/martincostello/update-dotnet-sdk/releases">martincostello/update-dotnet-sd... | 741a38e2026903f465f77b41904265c709a7c005 | 300e539841da21773116456c8e23a0806d39a5fe | diff --git a/.github/workflows/update-dotnet-sdk.yml b/.github/workflows/update-dotnet-sdk.yml
index 288240dbfb8..61e44b1664f 100644
--- a/.github/workflows/update-dotnet-sdk.yml
+++ b/.github/workflows/update-dotnet-sdk.yml
@@ -9,7 +9,7 @@ permissions: {}
jobs:
update-dotnet-sdk:
- uses: martincostello/update... | [
".github/workflows/update-dotnet-sdk.yml"
] | [] | true | ||
App-vNext/Polly | 3,111 | issue_to_patch | Bump codecov/codecov-action from 6.0.1 to 7.0.0 | Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 6.0.1 to 7.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v7.0.0</h2>
<p>⚠️ Due to migration i... | 741a38e2026903f465f77b41904265c709a7c005 | a8f851e3b1cf9b37362afc68a649e6e5198c41c4 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index dcd198c5f7d..3dd59c9dee1 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -104,13 +104,13 @@ jobs:
- name: Upload coverage to Codecov
if: always() && github.event.repository.fork == false
- uses:... | [
".github/workflows/build.yml"
] | [] | true | ||
App-vNext/Polly | 3,110 | issue_to_patch | Bump github/codeql-action from 4.36.1 to 4.36.2 | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.36.1 to 4.36.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p>
<blockquote>
<h2>v4.36.2</h2>
<ul>
<li>Cache CodeQL CLI ver... | 741a38e2026903f465f77b41904265c709a7c005 | 5d962988e8eb5fd071fac59086e285772bc8bda0 | diff --git a/.github/workflows/code-ql.yml b/.github/workflows/code-ql.yml
index 875d2dc16fc..052121bc706 100644
--- a/.github/workflows/code-ql.yml
+++ b/.github/workflows/code-ql.yml
@@ -35,13 +35,13 @@ jobs:
show-progress: false
- name: Initialize CodeQL
- uses: github/codeql-action/init@87557b9... | [
".github/workflows/code-ql.yml",
".github/workflows/ossf-scorecard.yml"
] | [] | true | ||
App-vNext/Polly | 3,106 | issue_to_patch | Update workflow timeout | Update the timeout to be longer than the `dotnet wait-for-package` timeout.
| a824c6b9258daa2879b8fa2ea768bf06bd5e6cf0 | e917192f595160327e764aa2d254e13e52475dbc | diff --git a/.github/workflows/nuget-packages-published.yml b/.github/workflows/nuget-packages-published.yml
index 66c2d9657e4..fda49f19e16 100644
--- a/.github/workflows/nuget-packages-published.yml
+++ b/.github/workflows/nuget-packages-published.yml
@@ -11,7 +11,7 @@ jobs:
wait-for-publish:
runs-on: [ ubun... | [
".github/workflows/nuget-packages-published.yml"
] | [] | true | ||
App-vNext/Polly | 3,104 | issue_to_patch | Bump version and update CHANGELOG | Update CHANGELOG and samples version for [v8.7.0](https://github.com/App-vNext/Polly/releases/tag/8.7.0).
This pull request was generated by [GitHub Actions](https://github.com/App-vNext/Polly/actions/runs/27145861257). | 057f5e23c9bf16e6e4a9b055b9d6d55b28569fcd | bc1e84cf7d45797afc98cc0f2b357c3c6b9675db | diff --git a/CHANGELOG.md b/CHANGELOG.md
index 5c3c746aebe..4245ffc16ba 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -4,6 +4,11 @@
<!-- next-release -->
+## 8.7.0
+
+* Adds caller cancellation token propagation in hedging and timeout strategies by [@DaRosenberg](https://github.com/DaRosenberg) in https://github... | [
"CHANGELOG.md",
"Directory.Packages.props",
"eng/bump-version.ps1"
] | [
{
"comment": "why is only Polly bumped and the other Polly packages not?",
"path": "Directory.Packages.props",
"hunk": "@@ -23,7 +23,7 @@\n <PackageVersion Include=\"MinVer\" Version=\"7.0.0\" />\n <PackageVersion Include=\"Newtonsoft.Json\" Version=\"13.0.4\" />\n <PackageVersion Include=\"... | true | ||
App-vNext/Polly | 3,104 | comment_to_fix | Bump version and update CHANGELOG | why is only Polly bumped and the other Polly packages not? | 057f5e23c9bf16e6e4a9b055b9d6d55b28569fcd | bc1e84cf7d45797afc98cc0f2b357c3c6b9675db | diff --git a/Directory.Packages.props b/Directory.Packages.props
index edd89424761..3733a887556 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -23,12 +23,12 @@
<PackageVersion Include="MinVer" Version="7.0.0" />
<PackageVersion Include="Newtonsoft.Json" Version="13.0.4" />
<Packa... | [
"Directory.Packages.props"
] | [
{
"comment": "why is only Polly bumped and the other Polly packages not?",
"path": "Directory.Packages.props",
"hunk": "@@ -23,7 +23,7 @@\n <PackageVersion Include=\"MinVer\" Version=\"7.0.0\" />\n <PackageVersion Include=\"Newtonsoft.Json\" Version=\"13.0.4\" />\n <PackageVersion Include=\"... | true | ||
App-vNext/Polly | 3,094 | issue_to_patch | [Bug]: Timeout strategy does not propagate correct CancellationToken
### Describe the bug
This is similar to the stale issue #934, but since it's been 4 years and we are now talking about v8 resilience pipelines, I am choosing to file a new issue.
When a timeout strategy is present in a pipeline, Polly replaces the ... | Adds caller cancellation token propagation in hedging and timeout strategies | # Pull Request
## The issue or feature being addressed
Fixes #3086 (Timeout strategy does not propagate the caller's `CancellationToken`)
When a resilience pipeline contains a strategy that substitutes the execution `CancellationToken` with an internal one (timeout, and also hedging), a caller-initiated cancel... | 8d978129b6569b69241b32f90d39cd97f822d7ce | b36796061a77b6ba489d883b04c4c266dbe136f8 | diff --git a/src/Polly.Core/Hedging/HedgingResilienceStrategy.cs b/src/Polly.Core/Hedging/HedgingResilienceStrategy.cs
index 962b7d62fa2..4013be6af16 100644
--- a/src/Polly.Core/Hedging/HedgingResilienceStrategy.cs
+++ b/src/Polly.Core/Hedging/HedgingResilienceStrategy.cs
@@ -1,5 +1,6 @@
using Polly.Hedging.Utils;
us... | [
"src/Polly.Core/Hedging/HedgingResilienceStrategy.cs",
"src/Polly.Core/Timeout/TimeoutResilienceStrategy.cs",
"src/Polly.Core/Utils/OutcomeUtilities.cs",
"test/Polly.Core.Tests/Hedging/HedgingResilienceStrategyTests.cs",
"test/Polly.Core.Tests/Issues/IssuesTests.CancellationTokenPropagation_3086.cs",
"tes... | [
{
"comment": "I realise this was called out in the PR description, but I wonder if its still better to contain the inner exception and preserve it with [`.ctor(String, Exception, CancellationToken)`](https://learn.microsoft.com/dotnet/api/system.operationcanceledexception.-ctor#system-operationcanceledexception... | diff --git a/test/Polly.Core.Tests/Hedging/HedgingResilienceStrategyTests.cs b/test/Polly.Core.Tests/Hedging/HedgingResilienceStrategyTests.cs
index f196b730cce..5e8e7542fd9 100644
--- a/test/Polly.Core.Tests/Hedging/HedgingResilienceStrategyTests.cs
+++ b/test/Polly.Core.Tests/Hedging/HedgingResilienceStrategyTests.cs... | true |
App-vNext/Polly | 3,094 | comment_to_fix | Adds caller cancellation token propagation in hedging and timeout strategies | I realise this was called out in the PR description, but I wonder if its still better to contain the inner exception and preserve it with [`.ctor(String, Exception, CancellationToken)`](https://learn.microsoft.com/dotnet/api/system.operationcanceledexception.-ctor#system-operationcanceledexception-ctor(system-string-sy... | 8d978129b6569b69241b32f90d39cd97f822d7ce | b36796061a77b6ba489d883b04c4c266dbe136f8 | diff --git a/src/Polly.Core/Utils/OutcomeUtilities.cs b/src/Polly.Core/Utils/OutcomeUtilities.cs
new file mode 100644
index 00000000000..4d7ef63d7e8
--- /dev/null
+++ b/src/Polly.Core/Utils/OutcomeUtilities.cs
@@ -0,0 +1,32 @@
+namespace Polly.Utils;
+
+internal static class OutcomeUtilities
+{
+ /// <summary>
+ ... | [
"src/Polly.Core/Utils/OutcomeUtilities.cs"
] | [
{
"comment": "I realise this was called out in the PR description, but I wonder if its still better to contain the inner exception and preserve it with [`.ctor(String, Exception, CancellationToken)`](https://learn.microsoft.com/dotnet/api/system.operationcanceledexception.-ctor#system-operationcanceledexception... | true | ||
App-vNext/Polly | 3,094 | comment_to_fix | Adds caller cancellation token propagation in hedging and timeout strategies | Just to ensure it's "arbitrary" nesting rather than just one level, could we add one more level of nesting to this test? | 8d978129b6569b69241b32f90d39cd97f822d7ce | b36796061a77b6ba489d883b04c4c266dbe136f8 | diff --git a/test/Polly.Core.Tests/Issues/IssuesTests.CancellationTokenPropagation_3086.cs b/test/Polly.Core.Tests/Issues/IssuesTests.CancellationTokenPropagation_3086.cs
new file mode 100644
index 00000000000..991bffa22dc
--- /dev/null
+++ b/test/Polly.Core.Tests/Issues/IssuesTests.CancellationTokenPropagation_3086.cs... | [
"test/Polly.Core.Tests/Issues/IssuesTests.CancellationTokenPropagation_3086.cs"
] | [
{
"comment": "Just to ensure it's \"arbitrary\" nesting rather than just one level, could we add one more level of nesting to this test?",
"path": "test/Polly.Core.Tests/Issues/IssuesTests.CancellationTokenPropagation_3086.cs",
"hunk": "@@ -0,0 +1,197 @@\n+using Polly.Hedging;\n+using Polly.Timeout;\n+\... | true | ||
App-vNext/Polly | 3,109 | issue_to_patch | Update .NET SDK to 10.0.301 | Updates the .NET SDK to version `10.0.301`, which also updates the .NET runtime from version [``10.0.8``](https://github.com/dotnet/core/blob/main/release-notes/10.0/10.0.8/10.0.8.md) to version [``10.0.9``](https://github.com/dotnet/core/blob/main/release-notes/10.0/10.0.9/10.0.9.md).
This release includes fixes for ... | a824c6b9258daa2879b8fa2ea768bf06bd5e6cf0 | 678296530c9e96093e4c89b5095b879f4cc1371b | diff --git a/global.json b/global.json
index 53f0e477991..6b5ad33c94e 100644
--- a/global.json
+++ b/global.json
@@ -1,8 +1,7 @@
{
"sdk": {
- "version": "10.0.300",
- "allowPrerelease": false,
- "rollForward": "latestMinor"
+ "version": "10.0.301",
+ "allowPrerelease": false
},
"msbuild-sdks": ... | [
"global.json"
] | [
{
"comment": "```suggestion\r\n \"allowPrerelease\": false\r\n```",
"path": "global.json",
"hunk": "@@ -1,6 +1,6 @@\n {\n \"sdk\": {\n- \"version\": \"10.0.300\",\n+ \"version\": \"10.0.301\",\n \"allowPrerelease\": false,\n \"rollForward\": \"latestMinor\"",
"resolving_sha": "678... | true | ||
App-vNext/Polly | 3,109 | comment_to_fix | Update .NET SDK to 10.0.301 | ```suggestion
"allowPrerelease": false
``` | a824c6b9258daa2879b8fa2ea768bf06bd5e6cf0 | 678296530c9e96093e4c89b5095b879f4cc1371b | diff --git a/global.json b/global.json
index 53f0e477991..6b5ad33c94e 100644
--- a/global.json
+++ b/global.json
@@ -1,8 +1,7 @@
{
"sdk": {
- "version": "10.0.300",
- "allowPrerelease": false,
- "rollForward": "latestMinor"
+ "version": "10.0.301",
+ "allowPrerelease": false
},
"msbuild-sdks": ... | [
"global.json"
] | [
{
"comment": "```suggestion\r\n \"allowPrerelease\": false\r\n```",
"path": "global.json",
"hunk": "@@ -1,6 +1,6 @@\n {\n \"sdk\": {\n- \"version\": \"10.0.300\",\n+ \"version\": \"10.0.301\",\n \"allowPrerelease\": false,\n \"rollForward\": \"latestMinor\"",
"resolving_sha": "678... | true | ||
App-vNext/Polly | 3,107 | issue_to_patch | Update to .NET 11 preview 5 | Update to preview 5 of .NET 11.
| 9923b8408e33047ea87581d7d4f6ae08668ec6a3 | 2b6897a7321b3d3121ab51eef268cabfe2d56218 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 6ba3a2b3c74..f4c2f59a1a0 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -13,11 +13,11 @@
<PackageVersion Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="4.14.0" />
<PackageVersion Include="Microsoft.Co... | [
"Directory.Packages.props",
"bench/Polly.Benchmarks/Polly.Benchmarks.csproj",
"global.json"
] | [] | true | ||
App-vNext/Polly | 3,105 | issue_to_patch | Disable Azure deployments | Do not create a GitHub deployment when the Azure environment is used to sign the NuGet packages.
| 057f5e23c9bf16e6e4a9b055b9d6d55b28569fcd | a14bec6286a6502ab701a3775d50a663dafcd762 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index aa5d932f58c..dcd198c5f7d 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -215,6 +215,7 @@ jobs:
environment:
name: Azure
+ deployment: false
permissions:
id-token: write
| [
".github/workflows/build.yml"
] | [] | true | ||
App-vNext/Polly | 3,103 | issue_to_patch | Bump sign from 0.9.1-beta.26227.3 to 0.9.1-beta.26301.2 | Updated [sign](https://github.com/dotnet/sign) from 0.9.1-beta.26227.3 to 0.9.1-beta.26301.2.
<details>
<summary>Release notes</summary>
_Sourced from [sign's releases](https://github.com/dotnet/sign/releases)._
## 0.9.1-beta.26301.2
## What's Changed
* [main] Update dependencies from dotnet/arcade by @dotnet-maes... | 528a1457ec7de7e7491d543a42a1d6dbe830dc47 | abf7ec40a95211f1c4d2d02b33b8f8987c4f63fd | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 0f5341ff6b8..d6baa1605e8 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -59,7 +59,7 @@
"rollForward": false
},
"sign": {
- "version": "0.9.1-beta.26227.3",
+ "version": "0.9.1-beta.26301.2",
... | [
".config/dotnet-tools.json"
] | [] | true | ||
App-vNext/Polly | 3,097 | issue_to_patch | Bump actions/checkout from 6.0.2 to 6.0.3 | Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.2 to 6.0.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v6.0.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Update changelo... | e984839b8324a163270f0bc686929a1066de69e0 | 1fab7881d66a425a6d8f9a3fc30f7175957c5a0e | diff --git a/.github/workflows/after-release.yml b/.github/workflows/after-release.yml
index a6a14b55976..ed4cd7d1863 100644
--- a/.github/workflows/after-release.yml
+++ b/.github/workflows/after-release.yml
@@ -34,7 +34,7 @@ jobs:
permission-pull-requests: write
- name: Checkout code
- uses... | [
".github/workflows/after-release.yml",
".github/workflows/build.yml",
".github/workflows/code-ql.yml",
".github/workflows/dependabot-approve.yml",
".github/workflows/dependency-review.yml",
".github/workflows/gh-pages.yml",
".github/workflows/lint.yml",
".github/workflows/mutation-tests.yml",
".gith... | [] | true | ||
App-vNext/Polly | 3,102 | issue_to_patch | Bump meziantou.framework.nugetpackagevalidation.tool from 1.0.52 to 1.0.53 | Updated [meziantou.framework.nugetpackagevalidation.tool](https://github.com/meziantou/Meziantou.Framework) from 1.0.52 to 1.0.53.
<details>
<summary>Release notes</summary>
_Sourced from [meziantou.framework.nugetpackagevalidation.tool's releases](https://github.com/meziantou/Meziantou.Framework/releases)._
No rele... | 528a1457ec7de7e7491d543a42a1d6dbe830dc47 | d91bc537e044468b160ec724cdee3ce045b5780f | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 0f5341ff6b8..b3b7d6482ba 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -52,7 +52,7 @@
"rollForward": false
},
"meziantou.framework.nugetpackagevalidation.tool": {
- "version": "1.0.52",
+ "ver... | [
".config/dotnet-tools.json"
] | [] | true | ||
App-vNext/Polly | 3,101 | issue_to_patch | Bump markdownsnippets.tool from 28.2.0 to 28.3.0 | Updated [markdownsnippets.tool](https://github.com/SimonCropp/MarkdownSnippets) from 28.2.0 to 28.3.0.
<details>
<summary>Release notes</summary>
_Sourced from [markdownsnippets.tool's releases](https://github.com/SimonCropp/MarkdownSnippets/releases)._
## 28.3.0
- [x] [#768](https://github.com/SimonCropp/Markdown... | 528a1457ec7de7e7491d543a42a1d6dbe830dc47 | fa03909b8c04c312693706d8fca7dfaf5cce82e1 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 0f5341ff6b8..8d9f903e8d3 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -38,7 +38,7 @@
"rollForward": false
},
"markdownsnippets.tool": {
- "version": "28.2.0",
+ "version": "28.3.0",
"c... | [
".config/dotnet-tools.json"
] | [] | true | ||
App-vNext/Polly | 3,100 | issue_to_patch | Bump martincostello/update-dotnet-sdk/.github/workflows/update-dotnet-sdk.yml from 5.0.3 to 5.0.4 | Bumps [martincostello/update-dotnet-sdk/.github/workflows/update-dotnet-sdk.yml](https://github.com/martincostello/update-dotnet-sdk) from 5.0.3 to 5.0.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/martincostello/update-dotnet-sdk/releases">martincostello/update-dotnet-sd... | e984839b8324a163270f0bc686929a1066de69e0 | 7f038b5999a86c5f2e5ab4d4a52b471dca930462 | diff --git a/.github/workflows/update-dotnet-sdk.yml b/.github/workflows/update-dotnet-sdk.yml
index 1522759803a..288240dbfb8 100644
--- a/.github/workflows/update-dotnet-sdk.yml
+++ b/.github/workflows/update-dotnet-sdk.yml
@@ -9,7 +9,7 @@ permissions: {}
jobs:
update-dotnet-sdk:
- uses: martincostello/update... | [
".github/workflows/update-dotnet-sdk.yml"
] | [] | true | ||
App-vNext/Polly | 3,099 | issue_to_patch | Bump actions/setup-dotnet from 5.2.0 to 5.3.0 | Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 5.2.0 to 5.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-dotnet/releases">actions/setup-dotnet's releases</a>.</em></p>
<blockquote>
<h2>v5.3.0</h2>
<h2>What's Changed</h2>
<h3>Enha... | e984839b8324a163270f0bc686929a1066de69e0 | 68258fa9ad6de6e39ec93b89cd73b2a7c2c22db6 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 8b118e10cda..24b0c6ea592 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -79,14 +79,14 @@ jobs:
show-progress: false
- name: Setup .NET SDKs
- uses: actions/setup-dotnet@c2fa09f4bde5ebb9d1777c... | [
".github/workflows/build.yml",
".github/workflows/gh-pages.yml",
".github/workflows/mutation-tests.yml",
".github/workflows/nuget-packages-published.yml",
".github/workflows/on-push-do-docs.yml"
] | [] | true | ||
App-vNext/Polly | 3,098 | issue_to_patch | Bump github/codeql-action from 4.36.0 to 4.36.1 | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.36.0 to 4.36.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p>
<blockquote>
<h2>v4.36.1</h2>
<p>No user facing changes.</p... | e984839b8324a163270f0bc686929a1066de69e0 | 40c70d62da0f195ed779fec8cc2b31b649634bfa | diff --git a/.github/workflows/code-ql.yml b/.github/workflows/code-ql.yml
index 97eb9b11391..d122e7076bb 100644
--- a/.github/workflows/code-ql.yml
+++ b/.github/workflows/code-ql.yml
@@ -35,13 +35,13 @@ jobs:
show-progress: false
- name: Initialize CodeQL
- uses: github/codeql-action/init@7211b7c... | [
".github/workflows/code-ql.yml",
".github/workflows/ossf-scorecard.yml"
] | [] | true | ||
App-vNext/Polly | 2,985 | issue_to_patch | Telemetry refactoring | Cherry-pick changes from #2936:
- Move `Meter` to `TelemetrySource` class.
- Use Polly's actual version for the meter's version.
- Extend some test coverage.
- Apply some minor code style refactoring.
| af7e8b16a0c032149021693d326860c00e48fd0e | 517ce137d8b7f023fc928bebd81d85c10db86035 | diff --git a/src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs b/src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs
index 55d9323aae7..d7aaea5a2c5 100644
--- a/src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs
+++ b/src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs
@@ -6,29 +6,20 ... | [
"src/Polly.Core/Registry/RegistryPipelineComponentBuilder.cs",
"src/Polly.Core/ResiliencePipelineBuilderBase.cs",
"src/Polly.Extensions/Telemetry/TelemetryListenerImpl.cs",
"src/Polly.Extensions/Telemetry/TelemetrySource.cs",
"test/Polly.Core.Tests/ResiliencePipelineBuilderTests.cs",
"test/Polly.Core.Test... | [
{
"comment": "`#if NET` will be true for the net6.0 target, but `string.IndexOf(char, StringComparison)` is only available on newer TFMs (it was added after net6). This will break compilation for the net6.0 target. Prefer using the `IndexOf(char)` overload (it’s already ordinal for a single char) or guard the `... | diff --git a/test/Polly.Core.Tests/ResiliencePipelineBuilderTests.cs b/test/Polly.Core.Tests/ResiliencePipelineBuilderTests.cs
index 61355c31a05..d7a18a66ee1 100644
--- a/test/Polly.Core.Tests/ResiliencePipelineBuilderTests.cs
+++ b/test/Polly.Core.Tests/ResiliencePipelineBuilderTests.cs
@@ -47,6 +47,11 @@ public void ... | true | |
App-vNext/Polly | 2,985 | comment_to_fix | Telemetry refactoring | `#if NET` will be true for the net6.0 target, but `string.IndexOf(char, StringComparison)` is only available on newer TFMs (it was added after net6). This will break compilation for the net6.0 target. Prefer using the `IndexOf(char)` overload (it’s already ordinal for a single char) or guard the `StringComparison` over... | af7e8b16a0c032149021693d326860c00e48fd0e | 517ce137d8b7f023fc928bebd81d85c10db86035 | diff --git a/src/Polly.Extensions/Telemetry/TelemetrySource.cs b/src/Polly.Extensions/Telemetry/TelemetrySource.cs
new file mode 100644
index 00000000000..6e95d62919f
--- /dev/null
+++ b/src/Polly.Extensions/Telemetry/TelemetrySource.cs
@@ -0,0 +1,50 @@
+using System.Diagnostics.Metrics;
+
+namespace Polly.Telemetry;
... | [
"src/Polly.Extensions/Telemetry/TelemetrySource.cs"
] | [
{
"comment": "`#if NET` will be true for the net6.0 target, but `string.IndexOf(char, StringComparison)` is only available on newer TFMs (it was added after net6). This will break compilation for the net6.0 target. Prefer using the `IndexOf(char)` overload (it’s already ordinal for a single char) or guard the `... | true | ||
App-vNext/Polly | 2,985 | comment_to_fix | Telemetry refactoring | Same compatibility issue as above: `string.IndexOf(char, StringComparison)` under `#if NET` will be compiled for net6.0 and can fail there. Use the `IndexOf(char)` overload (or a `string` + `StringComparison` overload) across TFMs, or tighten the preprocessor condition to `NET8_0_OR_GREATER`. | af7e8b16a0c032149021693d326860c00e48fd0e | 517ce137d8b7f023fc928bebd81d85c10db86035 | diff --git a/src/Polly.Extensions/Telemetry/TelemetrySource.cs b/src/Polly.Extensions/Telemetry/TelemetrySource.cs
new file mode 100644
index 00000000000..6e95d62919f
--- /dev/null
+++ b/src/Polly.Extensions/Telemetry/TelemetrySource.cs
@@ -0,0 +1,50 @@
+using System.Diagnostics.Metrics;
+
+namespace Polly.Telemetry;
... | [
"src/Polly.Extensions/Telemetry/TelemetrySource.cs"
] | [
{
"comment": "Same compatibility issue as above: `string.IndexOf(char, StringComparison)` under `#if NET` will be compiled for net6.0 and can fail there. Use the `IndexOf(char)` overload (or a `string` + `StringComparison` overload) across TFMs, or tighten the preprocessor condition to `NET8_0_OR_GREATER`.",
... | true | ||
App-vNext/Polly | 2,985 | comment_to_fix | Telemetry refactoring | Test name says it creates an ActivitySource, but `TelemetrySource` currently only exposes a `Meter`. Consider renaming the test to reflect what it actually verifies (or add ActivitySource creation if that’s intended).
| af7e8b16a0c032149021693d326860c00e48fd0e | 517ce137d8b7f023fc928bebd81d85c10db86035 | diff --git a/test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs b/test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs
new file mode 100644
index 00000000000..529096d21b5
--- /dev/null
+++ b/test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs
@@ -0,0 +1,22 @@
+using Polly.Telemetry;
+
+na... | [
"test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs"
] | [
{
"comment": "Test name says it creates an ActivitySource, but `TelemetrySource` currently only exposes a `Meter`. Consider renaming the test to reflect what it actually verifies (or add ActivitySource creation if that’s intended).\n",
"path": "test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs",... | true | ||
App-vNext/Polly | 2,985 | comment_to_fix | Telemetry refactoring | ```suggestion
public static void TelemetrySource_CreatesMeter()
``` | af7e8b16a0c032149021693d326860c00e48fd0e | 517ce137d8b7f023fc928bebd81d85c10db86035 | diff --git a/test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs b/test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs
new file mode 100644
index 00000000000..529096d21b5
--- /dev/null
+++ b/test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs
@@ -0,0 +1,22 @@
+using Polly.Telemetry;
+
+na... | [
"test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs"
] | [
{
"comment": "```suggestion\n public static void TelemetrySource_CreatesMeter()\n```",
"path": "test/Polly.Extensions.Tests/Telemetry/TelemetrySourceTests.cs",
"hunk": "@@ -0,0 +1,19 @@\n+using Polly.Telemetry;\n+\n+namespace Polly.Extensions.Tests.Telemetry;\n+\n+public static class TelemetrySource... | true | ||
App-vNext/Polly | 3,096 | issue_to_patch | Bump Refit to 10.2.0 | Refit revoked the signing certificate on 10.1.6.
See https://github.com/reactiveui/refit/issues/2114#issuecomment-4612074286.
| 8d978129b6569b69241b32f90d39cd97f822d7ce | 9fdc88570f4486cbf145dc464128970e5d3163f3 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index cc30055a3d1..edd89424761 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -29,7 +29,7 @@
<PackageVersion Include="Polly.Extensions" Version="8.6.2" />
<PackageVersion Include="Polly.RateLimiting" Version="8.6.2" />
... | [
"Directory.Packages.props"
] | [] | true | ||
App-vNext/Polly | 3,090 | issue_to_patch | Bump cake.tool from 6.1.0 to 6.2.0 | Updated [cake.tool](https://github.com/cake-build/cake) from 6.1.0 to 6.2.0.
<details>
<summary>Release notes</summary>
_Sourced from [cake.tool's releases](https://github.com/cake-build/cake/releases)._
## 6.2.0
As part of this release we had [36 issues](https://github.com/cake-build/cake/milestone/96?closed=1) cl... | cebdcea75da9dc261d87dacdb095bb9019832cb6 | 1b486314f50a9231430bab8e1e4bde8405449afd | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 2e0678655fe..5032ef72025 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -10,7 +10,7 @@
"rollForward": false
},
"cake.tool": {
- "version": "6.1.0",
+ "version": "6.2.0",
"commands": [
... | [
".config/dotnet-tools.json"
] | [] | true | ||
App-vNext/Polly | 3,089 | issue_to_patch | Bump Cake.Sdk from 6.1.1 to 6.2.0 | Updated [Cake.Sdk](https://github.com/cake-build/generator) from 6.1.1 to 6.2.0.
<details>
<summary>Release notes</summary>
_Sourced from [Cake.Sdk's releases](https://github.com/cake-build/generator/releases)._
## 6.2.0
## What's Changed
* GH92: Use Cake NuGet Feed for cake-build/cake packages by @devlead in http... | cebdcea75da9dc261d87dacdb095bb9019832cb6 | 3531050c4e15d55e7a421a04cc67f7f93b6fe483 | diff --git a/global.json b/global.json
index 1932b1ee794..53f0e477991 100644
--- a/global.json
+++ b/global.json
@@ -5,6 +5,6 @@
"rollForward": "latestMinor"
},
"msbuild-sdks": {
- "Cake.Sdk": "6.1.1"
+ "Cake.Sdk": "6.2.0"
}
}
\ No newline at end of file
| [
"global.json"
] | [] | true | ||
App-vNext/Polly | 3,093 | issue_to_patch | Bump SonarAnalyzer.CSharp from 10.26.0.140279 to 10.27.0.140913 | Updated [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 10.26.0.140279 to 10.27.0.140913.
<details>
<summary>Release notes</summary>
_Sourced from [SonarAnalyzer.CSharp's releases](https://github.com/SonarSource/sonar-dotnet/releases)._
## 10.27.0.140913
# Release notes - .NET Analyzers - 1... | cebdcea75da9dc261d87dacdb095bb9019832cb6 | 986e813d727b40827ea8cddc0eac16f19bb109e5 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index db7c4194e85..dc6b5cfea9f 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -33,7 +33,7 @@
<PackageVersion Include="ReportGenerator" Version="5.5.10" />
<PackageVersion Include="RestSharp" Version="114.0.0" />
<Pa... | [
"Directory.Packages.props"
] | [] | true | ||
App-vNext/Polly | 3,091 | issue_to_patch | Bump meziantou.framework.nugetpackagevalidation.tool from 1.0.51 to 1.0.52 | Updated [meziantou.framework.nugetpackagevalidation.tool](https://github.com/meziantou/Meziantou.Framework) from 1.0.51 to 1.0.52.
<details>
<summary>Release notes</summary>
_Sourced from [meziantou.framework.nugetpackagevalidation.tool's releases](https://github.com/meziantou/Meziantou.Framework/releases)._
No rele... | cebdcea75da9dc261d87dacdb095bb9019832cb6 | 0754ae1932b63d0a52d6a88105b8536df7cf8ba1 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 2e0678655fe..b17a3033725 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -52,7 +52,7 @@
"rollForward": false
},
"meziantou.framework.nugetpackagevalidation.tool": {
- "version": "1.0.51",
+ "ver... | [
".config/dotnet-tools.json"
] | [] | true | ||
App-vNext/Polly | 3,092 | issue_to_patch | Bump Microsoft.NET.Test.Sdk from 18.5.1 to 18.6.0 | Updated [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 18.5.1 to 18.6.0.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.NET.Test.Sdk's releases](https://github.com/microsoft/vstest/releases)._
## 18.6.0
## What's Changed
* Revert removal of Video Recorder by @nohwnd in http... | cebdcea75da9dc261d87dacdb095bb9019832cb6 | dab84890755226b4fbe47a8a62d2915282f826b9 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index db7c4194e85..c4f16a35987 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -19,7 +19,7 @@
<PackageVersion Include="Microsoft.Extensions.Logging.Console" Version="10.0.8" />
<PackageVersion Include="Microsoft.Extension... | [
"Directory.Packages.props"
] | [] | true | ||
App-vNext/Polly | 3,088 | issue_to_patch | Bump github/codeql-action from 4.35.5 to 4.36.0 | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.5 to 4.36.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p>
<blockquote>
<h2>v4.36.0</h2>
<ul>
<li><em>Breaking change<... | d36bdd5c931784ebf5c99ff63601cace46a1d5e8 | cca4a3135a56a172b6b0ecadcc746d45c5f3dbe0 | diff --git a/.github/workflows/code-ql.yml b/.github/workflows/code-ql.yml
index d5cb8ee161e..97eb9b11391 100644
--- a/.github/workflows/code-ql.yml
+++ b/.github/workflows/code-ql.yml
@@ -35,13 +35,13 @@ jobs:
show-progress: false
- name: Initialize CodeQL
- uses: github/codeql-action/init@9e0d7b8... | [
".github/workflows/code-ql.yml",
".github/workflows/ossf-scorecard.yml"
] | [] | true | ||
App-vNext/Polly | 3,087 | issue_to_patch | Bump actions/stale from 10.2.0 to 10.3.0 | Bumps [actions/stale](https://github.com/actions/stale) from 10.2.0 to 10.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/stale/releases">actions/stale's releases</a>.</em></p>
<blockquote>
<h2>v10.3.0</h2>
<h2>What's Changed</h2>
<h3>Bug Fix</h3>
<ul>
<li>Enhance... | d36bdd5c931784ebf5c99ff63601cace46a1d5e8 | 9bbee656bb88fed18aa3519da8ec441f654b2024 | diff --git a/.github/workflows/stale.yml b/.github/workflows/stale.yml
index 133bf1cdc5e..e8584764cfc 100644
--- a/.github/workflows/stale.yml
+++ b/.github/workflows/stale.yml
@@ -17,7 +17,7 @@ jobs:
pull-requests: write
steps:
- - uses: actions/stale@b5d41d4e1d5dceea10e7104786b73624c18a190f # v10.2... | [
".github/workflows/stale.yml"
] | [] | true | ||
App-vNext/Polly | 3,085 | issue_to_patch | Bump SonarAnalyzer.CSharp from 10.25.0.139117 to 10.26.0.140279 | Updated [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 10.25.0.139117 to 10.26.0.140279.
<details>
<summary>Release notes</summary>
_Sourced from [SonarAnalyzer.CSharp's releases](https://github.com/SonarSource/sonar-dotnet/releases)._
## 10.26.0.140279
# Release notes - .NET Analyzers - 1... | bb7ec2f30e1626b27dc54e1f05e8a8291e671793 | f7390c6ca2bca2612f3c0f725d283518dc494fc1 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index a4c727f25c7..b8dfda7a931 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -33,7 +33,7 @@
<PackageVersion Include="ReportGenerator" Version="5.5.10" />
<PackageVersion Include="RestSharp" Version="114.0.0" />
<Pa... | [
"Directory.Packages.props",
"test/Polly.Core.Tests/CircuitBreaker/BreakDurationGeneratorArgumentsTests.cs",
"test/Polly.Specs/ResiliencePipelineConversionExtensionsTests.cs"
] | [] | diff --git a/test/Polly.Core.Tests/CircuitBreaker/BreakDurationGeneratorArgumentsTests.cs b/test/Polly.Core.Tests/CircuitBreaker/BreakDurationGeneratorArgumentsTests.cs
index 841ad2a20f2..c7ed646797c 100644
--- a/test/Polly.Core.Tests/CircuitBreaker/BreakDurationGeneratorArgumentsTests.cs
+++ b/test/Polly.Core.Tests/Ci... | true | |
App-vNext/Polly | 3,081 | issue_to_patch | Bump the dotnet group with 5 updates | Updated [Microsoft.Extensions.Configuration](https://github.com/dotnet/dotnet) from 10.0.7 to 10.0.8.
<details>
<summary>Release notes</summary>
_Sourced from [Microsoft.Extensions.Configuration's releases](https://github.com/dotnet/dotnet/releases)._
No release notes found for this version range.
Commits viewable ... | 58d65ba4bb5b297090d5728eab7e0ff6df3133cb | fc2386aec08e261352f7b847174270ca17f05030 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index a4c727f25c7..c2730e0a6f8 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -13,11 +13,11 @@
<PackageVersion Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="4.14.0" />
<PackageVersion Include="Microsoft.Co... | [
"Directory.Packages.props"
] | [] | true | ||
App-vNext/Polly | 3,084 | issue_to_patch | Bump meziantou.framework.nugetpackagevalidation.tool from 1.0.50 to 1.0.51 | Updated [meziantou.framework.nugetpackagevalidation.tool](https://github.com/meziantou/Meziantou.Framework) from 1.0.50 to 1.0.51.
<details>
<summary>Release notes</summary>
_Sourced from [meziantou.framework.nugetpackagevalidation.tool's releases](https://github.com/meziantou/Meziantou.Framework/releases)._
No rele... | bb7ec2f30e1626b27dc54e1f05e8a8291e671793 | 50f95a7e6be9d3df27b2a14161bdc509f967b844 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 00bdac4166f..4a6c5b4f332 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -52,7 +52,7 @@
"rollForward": false
},
"meziantou.framework.nugetpackagevalidation.tool": {
- "version": "1.0.50",
+ "ver... | [
".config/dotnet-tools.json"
] | [] | true | ||
App-vNext/Polly | 3,083 | issue_to_patch | Add Testing Platform Support
Today Stryker has support for VSTest as the test runner, and this is what is commonly used today by various testing frameworks.
However Microsoft have built a new replacement call the [Microsoft Testing Platform](https://learn.microsoft.com/en-us/dotnet/core/testing/unit-testing-platfor... | Bump dotnet-stryker from 4.14.1 to 4.14.2 | Updated [dotnet-stryker](https://github.com/stryker-mutator/stryker-net) from 4.14.1 to 4.14.2.
<details>
<summary>Release notes</summary>
_Sourced from [dotnet-stryker's releases](https://github.com/stryker-mutator/stryker-net/releases)._
## 4.14.2
## [4.14.2](https://github.com/stryker-mutator/stryker-net/compare... | bb7ec2f30e1626b27dc54e1f05e8a8291e671793 | e0b9ed1fae51c0969f1e534473d0a33483d71fff | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 00bdac4166f..4b355244ddf 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -24,7 +24,7 @@
"rollForward": false
},
"dotnet-stryker": {
- "version": "4.14.1",
+ "version": "4.14.2",
"commands... | [
".config/dotnet-tools.json"
] | [] | true | |
App-vNext/Polly | 3,080 | issue_to_patch | Bump github/codeql-action from 4.35.4 to 4.35.5 | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.4 to 4.35.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p>
<blockquote>
<h2>v4.35.5</h2>
<ul>
<li>We have improved how... | 283959da8ae8c9693b29c0478ca18d59091331ab | 53fbf67fd6f6f204720fbac718e95b2b599b2398 | diff --git a/.github/workflows/code-ql.yml b/.github/workflows/code-ql.yml
index 7ce545a261e..d5cb8ee161e 100644
--- a/.github/workflows/code-ql.yml
+++ b/.github/workflows/code-ql.yml
@@ -35,13 +35,13 @@ jobs:
show-progress: false
- name: Initialize CodeQL
- uses: github/codeql-action/init@68bde55... | [
".github/workflows/code-ql.yml",
".github/workflows/ossf-scorecard.yml"
] | [] | true | ||
App-vNext/Polly | 3,077 | issue_to_patch | Bump peaceiris/actions-gh-pages from 4.0.0 to 4.1.0 | Bumps [peaceiris/actions-gh-pages](https://github.com/peaceiris/actions-gh-pages) from 4.0.0 to 4.1.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/peaceiris/actions-gh-pages/releases">peaceiris/actions-gh-pages's releases</a>.</em></p>
<blockquote>
<h2>actions-github-pages... | 283959da8ae8c9693b29c0478ca18d59091331ab | 5fe6ebb2f62e4c9918a490b8b4ed3c17c62baadd | diff --git a/.github/workflows/gh-pages.yml b/.github/workflows/gh-pages.yml
index 0a0fdd391cc..7db926ee715 100644
--- a/.github/workflows/gh-pages.yml
+++ b/.github/workflows/gh-pages.yml
@@ -81,7 +81,7 @@ jobs:
path: docs
- name: Deploy to GitHub Pages
- uses: peaceiris/actions-gh-pages@4f9cc6602... | [
".github/workflows/gh-pages.yml"
] | [] | true | ||
App-vNext/Polly | 3,079 | issue_to_patch | Bump codecov/codecov-action from 6.0.0 to 6.0.1 | Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 6.0.0 to 6.0.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v6.0.1</h2>
<h2>What's Changed</h2>
... | 283959da8ae8c9693b29c0478ca18d59091331ab | d3e1c68a656e7f441d7c43c43cd840c03ec2354e | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 4e4b781bb7b..8b118e10cda 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -104,13 +104,13 @@ jobs:
- name: Upload coverage to Codecov
if: always() && github.event.repository.fork == false
- uses:... | [
".github/workflows/build.yml"
] | [] | true | ||
App-vNext/Polly | 3,078 | issue_to_patch | Bump martincostello/update-dotnet-sdk/.github/workflows/update-dotnet-sdk.yml from 5.0.2 to 5.0.3 | Bumps [martincostello/update-dotnet-sdk/.github/workflows/update-dotnet-sdk.yml](https://github.com/martincostello/update-dotnet-sdk) from 5.0.2 to 5.0.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/martincostello/update-dotnet-sdk/releases">martincostello/update-dotnet-sd... | 283959da8ae8c9693b29c0478ca18d59091331ab | 54e7479dd14efc1a539a06e83ed409d72d49063c | diff --git a/.github/workflows/update-dotnet-sdk.yml b/.github/workflows/update-dotnet-sdk.yml
index ab8757078fc..1522759803a 100644
--- a/.github/workflows/update-dotnet-sdk.yml
+++ b/.github/workflows/update-dotnet-sdk.yml
@@ -9,7 +9,7 @@ permissions: {}
jobs:
update-dotnet-sdk:
- uses: martincostello/update... | [
".github/workflows/update-dotnet-sdk.yml"
] | [] | true | ||
App-vNext/Polly | 3,076 | issue_to_patch | Bump zizmorcore/zizmor-action from 0.5.3 to 0.5.6 | Bumps [zizmorcore/zizmor-action](https://github.com/zizmorcore/zizmor-action) from 0.5.3 to 0.5.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/zizmorcore/zizmor-action/releases">zizmorcore/zizmor-action's releases</a>.</em></p>
<blockquote>
<h2>v0.5.6</h2>
<ul>
<li>1.25.2 ... | 283959da8ae8c9693b29c0478ca18d59091331ab | f75ed922b9a07f3e9011551e5b68764673b0f746 | diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index fc79ed70db6..44bdcac5c56 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -47,7 +47,7 @@ jobs:
args: -color
- name: Lint workflows with zizmor
- uses: zizmorcore/zizmor-action@b1d7e1fb5de872772f315... | [
".github/workflows/lint.yml"
] | [] | true | ||
App-vNext/Polly | 3,072 | issue_to_patch | Bump ReportGenerator from 5.5.9 to 5.5.10 | Updated [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 5.5.9 to 5.5.10.
<details>
<summary>Release notes</summary>
_Sourced from [ReportGenerator's releases](https://github.com/danielpalme/ReportGenerator/releases)._
## 5.5.10
# Changes:
- Added support for Sha256 signed licenses
This relea... | 6c757573a93ba7ddb226f945e9ea19a70f77d9cc | 947b4176d6f8b0af7d53e37438105f3c3fc16760 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index dc4ed0977eb..a4c727f25c7 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -30,7 +30,7 @@
<PackageVersion Include="Polly.RateLimiting" Version="8.6.2" />
<PackageVersion Include="Polly.Testing" Version="8.6.2" />
... | [
"Directory.Packages.props"
] | [] | true | ||
App-vNext/Polly | 3,071 | issue_to_patch | Bump actions/dependency-review-action from 4.9.0 to 5.0.0 | Bumps [actions/dependency-review-action](https://github.com/actions/dependency-review-action) from 4.9.0 to 5.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/dependency-review-action/releases">actions/dependency-review-action's releases</a>.</em></p>
<blockquote>
... | ee121575a8967f34b0503220fcd9b659734ab7c0 | e4eb47d3759df5d5cf8f8d368925196e3d3806a5 | diff --git a/.github/workflows/dependency-review.yml b/.github/workflows/dependency-review.yml
index fb38c915cb4..2eac19f00e5 100644
--- a/.github/workflows/dependency-review.yml
+++ b/.github/workflows/dependency-review.yml
@@ -23,6 +23,6 @@ jobs:
show-progress: false
- name: Review dependencies
- ... | [
".github/workflows/dependency-review.yml"
] | [] | true | ||
App-vNext/Polly | 3,069 | issue_to_patch | Bump github/codeql-action from 4.35.3 to 4.35.4 | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.3 to 4.35.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p>
<blockquote>
<h2>v4.35.4</h2>
<ul>
<li>Update default CodeQ... | ee121575a8967f34b0503220fcd9b659734ab7c0 | 99664b22ba4ec437b68b4584c2acf2c66aef83da | diff --git a/.github/workflows/code-ql.yml b/.github/workflows/code-ql.yml
index 4638ea77b77..7ce545a261e 100644
--- a/.github/workflows/code-ql.yml
+++ b/.github/workflows/code-ql.yml
@@ -35,13 +35,13 @@ jobs:
show-progress: false
- name: Initialize CodeQL
- uses: github/codeql-action/init@e46ed2c... | [
".github/workflows/code-ql.yml",
".github/workflows/ossf-scorecard.yml"
] | [] | true | ||
App-vNext/Polly | 3,070 | issue_to_patch | Bump actions/create-github-app-token from 3.1.1 to 3.2.0 | Bumps [actions/create-github-app-token](https://github.com/actions/create-github-app-token) from 3.1.1 to 3.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/create-github-app-token/releases">actions/create-github-app-token's releases</a>.</em></p>
<blockquote>
<h2>... | ee121575a8967f34b0503220fcd9b659734ab7c0 | 16d09cbb7b5f2c17ec38d35f3d620991ca9bbf11 | diff --git a/.github/workflows/after-release.yml b/.github/workflows/after-release.yml
index e84ad7f9fe8..a6a14b55976 100644
--- a/.github/workflows/after-release.yml
+++ b/.github/workflows/after-release.yml
@@ -26,7 +26,7 @@ jobs:
- name: Generate GitHub application token
id: generate-application-to... | [
".github/workflows/after-release.yml",
".github/workflows/build.yml",
".github/workflows/dependabot-approve.yml",
".github/workflows/on-push-do-docs.yml",
".github/workflows/updater-approve.yml"
] | [] | true | ||
App-vNext/Polly | 3,066 | issue_to_patch | Update to .NET 11 preview 4 | Update to preview 4 of .NET 11.
| a8d3a96a2f1b04da149ef8558b024391f0820e29 | bc6ad7a11907e5e1023d265258d42da0ab5d973c | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 63ba14eaf6d..111b4040c2c 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -13,11 +13,11 @@
<PackageVersion Include="Microsoft.CodeAnalysis.BannedApiAnalyzers" Version="4.14.0" />
<PackageVersion Include="Microsoft.Co... | [
"Directory.Packages.props",
"bench/Polly.Benchmarks/Polly.Benchmarks.csproj",
"global.json"
] | [
{
"comment": "`Microsoft.Extensions.DependencyInjection` is centrally versioned in `Directory.Packages.props` (currently also `11.0.0-preview.4.26230.115`), so keeping a `VersionOverride` here is redundant and can easily drift from the central version on future updates. Consider removing `VersionOverride` and r... | true | ||
App-vNext/Polly | 3,067 | issue_to_patch | Update .NET SDK to 10.0.300 | Updates the .NET SDK to version `10.0.300`, which also updates the .NET runtime from version [``10.0.7``](https://github.com/dotnet/core/blob/main/release-notes/10.0/10.0.7/10.0.7.md) to version [``10.0.8``](https://github.com/dotnet/core/blob/main/release-notes/10.0/10.0.8/10.0.8.md).
This release includes fixes for ... | bb790b9765ba18cacb424e89215bf881a2dab7bd | 6f0e0a1ab47997015592f049c4341062fe34a2cc | diff --git a/global.json b/global.json
index c652ba3af80..1932b1ee794 100644
--- a/global.json
+++ b/global.json
@@ -1,6 +1,6 @@
{
"sdk": {
- "version": "10.0.203",
+ "version": "10.0.300",
"allowPrerelease": false,
"rollForward": "latestMinor"
},
| [
"global.json"
] | [] | true | ||
App-vNext/Polly | 3,065 | issue_to_patch | Pin runner images | Pin runner images to a specific OS, rather than using `latest`.
| 647d6838b5c50d8581c82a042eff8eefdcf5310a | 0bde17cd4de2e9e5d4e8a909d88394d916df0876 | diff --git a/.github/workflows/after-release.yml b/.github/workflows/after-release.yml
index c9b4be3be3e..e84ad7f9fe8 100644
--- a/.github/workflows/after-release.yml
+++ b/.github/workflows/after-release.yml
@@ -15,7 +15,7 @@ env:
jobs:
update-changelog:
- runs-on: [ ubuntu-latest ]
+ runs-on: [ ubuntu-24.... | [
".github/workflows/after-release.yml",
".github/workflows/build.yml",
".github/workflows/code-ql.yml",
".github/workflows/dependabot-approve.yml",
".github/workflows/dependency-review.yml",
".github/workflows/gh-pages.yml",
".github/workflows/lint.yml",
".github/workflows/mutation-tests.yml",
".gith... | [
{
"comment": "GitHub Actions expressions can’t reliably access matrix keys that contain hyphens via dot-notation (e.g., `matrix.job-name` gets parsed as subtraction). Rename the matrix keys to use underscores (e.g., `job_name`) or switch to bracket syntax (e.g., `matrix['job-name']`) to avoid workflow evaluatio... | true | ||
App-vNext/Polly | 3,065 | comment_to_fix | Pin runner images | GitHub Actions expressions can’t reliably access matrix keys that contain hyphens via dot-notation (e.g., `matrix.job-name` gets parsed as subtraction). Rename the matrix keys to use underscores (e.g., `job_name`) or switch to bracket syntax (e.g., `matrix['job-name']`) to avoid workflow evaluation failures.
| 647d6838b5c50d8581c82a042eff8eefdcf5310a | 0bde17cd4de2e9e5d4e8a909d88394d916df0876 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 00afbc7a721..f0849c4038d 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -22,8 +22,8 @@ permissions: {}
jobs:
build:
- name: ${{ matrix.os }}
- runs-on: ${{ matrix.os }}
+ name: ${{ matrix.job-name ... | [
".github/workflows/build.yml"
] | [
{
"comment": "GitHub Actions expressions can’t reliably access matrix keys that contain hyphens via dot-notation (e.g., `matrix.job-name` gets parsed as subtraction). Rename the matrix keys to use underscores (e.g., `job_name`) or switch to bracket syntax (e.g., `matrix['job-name']`) to avoid workflow evaluatio... | true | ||
App-vNext/Polly | 3,065 | comment_to_fix | Pin runner images | `matrix.os-name` will be parsed as an expression (`matrix.os - name`) rather than a property access. Use `matrix['os-name']` (or rename the key to `os_name`) so artifact names resolve correctly. | 647d6838b5c50d8581c82a042eff8eefdcf5310a | 0bde17cd4de2e9e5d4e8a909d88394d916df0876 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 00afbc7a721..f0849c4038d 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -22,8 +22,8 @@ permissions: {}
jobs:
build:
- name: ${{ matrix.os }}
- runs-on: ${{ matrix.os }}
+ name: ${{ matrix.job-name ... | [
".github/workflows/build.yml"
] | [
{
"comment": "`matrix.os-name` will be parsed as an expression (`matrix.os - name`) rather than a property access. Use `matrix['os-name']` (or rename the key to `os_name`) so artifact names resolve correctly.",
"path": ".github/workflows/build.yml",
"hunk": "@@ -96,35 +98,35 @@ jobs:\n if: always(... | true | ||
App-vNext/Polly | 3,065 | comment_to_fix | Pin runner images | Same issue here: `matrix.os-name` won’t resolve as intended in expressions. Use bracket syntax (`matrix['os-name']`) or rename the matrix key to avoid hyphens. | 647d6838b5c50d8581c82a042eff8eefdcf5310a | 0bde17cd4de2e9e5d4e8a909d88394d916df0876 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 00afbc7a721..f0849c4038d 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -22,8 +22,8 @@ permissions: {}
jobs:
build:
- name: ${{ matrix.os }}
- runs-on: ${{ matrix.os }}
+ name: ${{ matrix.job-name ... | [
".github/workflows/build.yml"
] | [
{
"comment": "Same issue here: `matrix.os-name` won’t resolve as intended in expressions. Use bracket syntax (`matrix['os-name']`) or rename the matrix key to avoid hyphens.",
"path": ".github/workflows/build.yml",
"hunk": "@@ -96,35 +98,35 @@ jobs:\n if: always()\n uses: actions/upload-arti... | true | ||
App-vNext/Polly | 3,065 | comment_to_fix | Pin runner images | The `if: matrix.os-name == 'windows'` expression will be parsed as subtraction instead of accessing the `os-name` field. Use `matrix['os-name'] == 'windows'` (or rename the key) so the condition evaluates correctly.
| 647d6838b5c50d8581c82a042eff8eefdcf5310a | 0bde17cd4de2e9e5d4e8a909d88394d916df0876 | diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 00afbc7a721..f0849c4038d 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -22,8 +22,8 @@ permissions: {}
jobs:
build:
- name: ${{ matrix.os }}
- runs-on: ${{ matrix.os }}
+ name: ${{ matrix.job-name ... | [
".github/workflows/build.yml"
] | [
{
"comment": "The `if: matrix.os-name == 'windows'` expression will be parsed as subtraction instead of accessing the `os-name` field. Use `matrix['os-name'] == 'windows'` (or rename the key) so the condition evaluates correctly.\n",
"path": ".github/workflows/build.yml",
"hunk": "@@ -96,35 +98,35 @@ jo... | true | ||
App-vNext/Polly | 3,062 | issue_to_patch | Bump meziantou.framework.nugetpackagevalidation.tool from 1.0.49 to 1.0.50 | Updated [meziantou.framework.nugetpackagevalidation.tool](https://github.com/meziantou/Meziantou.Framework) from 1.0.49 to 1.0.50.
<details>
<summary>Release notes</summary>
_Sourced from [meziantou.framework.nugetpackagevalidation.tool's releases](https://github.com/meziantou/Meziantou.Framework/releases)._
No rele... | 9bbc91317d54a04601b9ba3000b4077febc7102c | b4b57b2014b18e72a4926912e64405d4476a80a1 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index d9cf57bcdd0..f96f949bb24 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -52,7 +52,7 @@
"rollForward": false
},
"meziantou.framework.nugetpackagevalidation.tool": {
- "version": "1.0.49",
+ "ver... | [
".config/dotnet-tools.json"
] | [] | true | ||
App-vNext/Polly | 3,061 | issue_to_patch | Bump GitHubActionsTestLogger from 3.0.3 to 3.0.4 | Updated [GitHubActionsTestLogger](https://github.com/Tyrrrz/GitHubActionsTestLogger) from 3.0.3 to 3.0.4.
<details>
<summary>Release notes</summary>
_Sourced from [GitHubActionsTestLogger's releases](https://github.com/Tyrrrz/GitHubActionsTestLogger/releases)._
## 3.0.4
<!-- Release notes generated using configurat... | 9bbc91317d54a04601b9ba3000b4077febc7102c | ee68a88af41c4b76f18d7c9b3da495c98586a633 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 3b1787dde0a..84561483e99 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -6,7 +6,7 @@
<PackageVersion Include="Flurl.Http.Signed" Version="4.0.2" />
<PackageVersion Include="FsCheck.Xunit" Version="3.3.3" />
<P... | [
"Directory.Packages.props"
] | [] | true | ||
App-vNext/Polly | 3,064 | issue_to_patch | Bump sign from 0.9.1-beta.26179.1 to 0.9.1-beta.26227.3 | Updated [sign](https://github.com/dotnet/sign) from 0.9.1-beta.26179.1 to 0.9.1-beta.26227.3.
<details>
<summary>Release notes</summary>
_Sourced from [sign's releases](https://github.com/dotnet/sign/releases)._
## 0.9.1-beta.26227.3
## What's Changed
* [main] Update dependencies from dotnet/arcade by @dotnet-maes... | 9bbc91317d54a04601b9ba3000b4077febc7102c | 8b98a6e70fd1177ef3f02a342e72ecba13c4a0c4 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index d9cf57bcdd0..85a636b71a5 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -59,7 +59,7 @@
"rollForward": false
},
"sign": {
- "version": "0.9.1-beta.26179.1",
+ "version": "0.9.1-beta.26227.3",
... | [
".config/dotnet-tools.json"
] | [] | true | ||
App-vNext/Polly | 3,063 | issue_to_patch | Bump ReportGenerator from 5.5.7 to 5.5.9 | Updated [ReportGenerator](https://github.com/danielpalme/ReportGenerator) from 5.5.7 to 5.5.9.
<details>
<summary>Release notes</summary>
_Sourced from [ReportGenerator's releases](https://github.com/danielpalme/ReportGenerator/releases)._
## 5.5.9
# Changes:
- New: Added new setting "applyQueryStringToAllLinks" to... | 9bbc91317d54a04601b9ba3000b4077febc7102c | 63880b2dc66842c2a3bb38904ffb38485433a054 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 3b1787dde0a..df21dbe00e2 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -30,7 +30,7 @@
<PackageVersion Include="Polly.RateLimiting" Version="8.6.2" />
<PackageVersion Include="Polly.Testing" Version="8.6.2" />
... | [
"Directory.Packages.props"
] | [] | true | ||
App-vNext/Polly | 3,060 | issue_to_patch | Bump github/codeql-action from 4.35.2 to 4.35.3 | Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.35.2 to 4.35.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p>
<blockquote>
<h2>v4.35.3</h2>
<ul>
<li><em>Upcoming breakin... | da4ae8fda107be21eea3ce2f537343255e15b603 | 7827c87e43184f86774ea8a03ab922fb79d18a0d | diff --git a/.github/workflows/code-ql.yml b/.github/workflows/code-ql.yml
index 35afdc4719a..884ea24237e 100644
--- a/.github/workflows/code-ql.yml
+++ b/.github/workflows/code-ql.yml
@@ -35,13 +35,13 @@ jobs:
show-progress: false
- name: Initialize CodeQL
- uses: github/codeql-action/init@95e58e9... | [
".github/workflows/code-ql.yml",
".github/workflows/ossf-scorecard.yml"
] | [] | true | ||
App-vNext/Polly | 3,059 | issue_to_patch | Bump DavidAnson/markdownlint-cli2-action from 23.1.0 to 23.2.0 | Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action) from 23.1.0 to 23.2.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/DavidAnson/markdownlint-cli2-action/commit/ded1f9488f68a970bc66ea5619e13e9b52e601cd"><code>ded1f94</code></a> Update to ver... | da4ae8fda107be21eea3ce2f537343255e15b603 | 37db086c3fea88f4ed00bbd984feb18be0a19cb6 | diff --git a/.github/workflows/gh-pages.yml b/.github/workflows/gh-pages.yml
index 6f9584d4450..e8fdad97709 100644
--- a/.github/workflows/gh-pages.yml
+++ b/.github/workflows/gh-pages.yml
@@ -29,7 +29,7 @@ jobs:
show-progress: false
- name: Lint Markdown files
- uses: DavidAnson/markdownlint-cli2-... | [
".github/workflows/gh-pages.yml"
] | [] | true | ||
AshleyF/VimSpeak | 8 | issue_to_patch | Convert to SDK style project | I wasn't able to build this project in VS2019. Thought I would modernise it slightly to an SDK style project which now seems to work great. | 1158a031069c93d05e988d54029b2cda406e8adc | 1108d60ee0764ecf0e8968f4e654de8c899f5ffb | diff --git a/VimSpeak.fsproj b/VimSpeak.fsproj
index c3b1884..cf888ef 100644
--- a/VimSpeak.fsproj
+++ b/VimSpeak.fsproj
@@ -1,52 +1,12 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Project ToolsVersion="4.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
- <Import Project="$(MSB... | [
"VimSpeak.fsproj",
"VimSpeak.sln"
] | [] | true | ||
AshleyF/VimSpeak | 1 | issue_to_patch | describe project in README | Many people on https://news.ycombinator.com/item?id=5660633 are annoyed that you have to follow a link and watch a video to find out what VimSpeak is. This commit adds a description so people understand the idea quickly and conveniently.
| 278044f454b094ca9a609d6ae74b64f8fdfcdf55 | 6a539bc9861f9ff2a1888c2fcc4b8213ba31e911 | diff --git a/README.md b/README.md
index 3b6a43a..b6cc4e0 100644
--- a/README.md
+++ b/README.md
@@ -1,5 +1,7 @@
# VimSpeak #
+VimSpeak lets you control Vim with your voice, using speech recognition. For instance, you can say “select three words” to type `v3w`.
+
This is a little toy I built over the weekend after ... | [
"README.md"
] | [] | true | ||
AshleyF/VimSpeak | 4 | issue_to_patch | add “append” as synonym for “after” to type ‘a’/‘A’ | That’s the word I think of for the `a` command. And the description in Vim’s `:help a` begins “<em>Append</em> text after the cursor …”, and `:help A` doesn’t include “after”, so I think “append” is the official name.
I haven’t ran the program to test this change. I just copied the format of the surrounding lines.
| f19d69e8bc8f43ef8ef7472791408197bbab8a09 | cb9e1fcc25364352b4d905d1453f33e32f4ed6ad | diff --git a/Main.fs b/Main.fs
index 05c9c55..f131d41 100644
--- a/Main.fs
+++ b/Main.fs
@@ -405,7 +405,9 @@ let normalMode =
Optional count
Choice [
Word ("after", "a", Some "insert")
+ Word ("append", "a", Some "... | [
"Main.fs"
] | [] | true | ||
AvaloniaUI/Avalonia | 21,557 | issue_to_patch | Fix system font caching when retrieved with a different name | ## What does the pull request do?
This PR fixes system font caching when a substitute font with a completely different name is provided by the system.
This is basically #20249, rewritten for the latest font manager changes in Avalonia 12.
## What is the current behavior?
If a substitute font is retrieved, the ori... | 486df8acbadadcbc6ab462e29ece840ddacc65e6 | 02d98839f4485ae8319fcd39870e0be905edb3e7 | diff --git a/src/Avalonia.Base/Media/Fonts/SystemFontCollection.cs b/src/Avalonia.Base/Media/Fonts/SystemFontCollection.cs
index c7b013729ce..390f4f47193 100644
--- a/src/Avalonia.Base/Media/Fonts/SystemFontCollection.cs
+++ b/src/Avalonia.Base/Media/Fonts/SystemFontCollection.cs
@@ -67,6 +67,10 @@ public override bool... | [
"src/Avalonia.Base/Media/Fonts/SystemFontCollection.cs",
"tests/Avalonia.Skia.UnitTests/Media/FontManagerTests.cs"
] | [] | diff --git a/tests/Avalonia.Skia.UnitTests/Media/FontManagerTests.cs b/tests/Avalonia.Skia.UnitTests/Media/FontManagerTests.cs
index b0d6e1bfd11..4f171b29ad3 100644
--- a/tests/Avalonia.Skia.UnitTests/Media/FontManagerTests.cs
+++ b/tests/Avalonia.Skia.UnitTests/Media/FontManagerTests.cs
@@ -1,5 +1,8 @@
using System;... | true | |
AvaloniaUI/Avalonia | 21,472 | issue_to_patch | Update to latest Tmds.DBus.Protocol. | Change to the latest version of Tmds.DBus.Protocol and use the project source generator.
Fix StatusNotifierItem Status property to use "Active" value.
Fix "watch after request" race for portal requests. | 980d8792c62071d56f6784670548e351b9663adc | c505380966bf488cea2fb518cbc9535d853ae2c2 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index 7ef244b355a..f4e677d6311 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -61,8 +61,8 @@
<PackageVersion Include="System.Runtime.CompilerServices.Unsafe" Version="6.1.2" />
<PackageVersion Include="System.Text.Json" ... | [
"Directory.Packages.props",
"src/Avalonia.FreeDesktop/Avalonia.FreeDesktop.csproj",
"src/Avalonia.FreeDesktop/DBusHelper.cs",
"src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs",
"src/Avalonia.FreeDesktop/DBusIme/Fcitx/FcitxICWrapper.cs",
"src/Avalonia.FreeDesktop/DBusIme/Fcitx/FcitxX11TextInput... | [] | true | ||
AvaloniaUI/Avalonia | 21,554 | issue_to_patch | Expose placeholder text as the AT-SPI placeholder-text attribute | ## What does the pull request do?
Exposes a control's placeholder text (`TextBox.PlaceholderText` / watermark) as the AT-SPI `placeholder-text` object attribute on Linux, the standard attribute GTK and Qt use.
## Context
The placeholder is already reachable on the other backends through the existing HelpText routing... | 269d0f2b8e2a2972b2c4e750163b3417f60eddee | 6ea8fa8757513235ec5eb147fba695578d35539d | diff --git a/src/Avalonia.FreeDesktop.AtSpi/Handlers/AtSpiAccessibleHandler.cs b/src/Avalonia.FreeDesktop.AtSpi/Handlers/AtSpiAccessibleHandler.cs
index 4e674a9ed5e..ecca97de791 100644
--- a/src/Avalonia.FreeDesktop.AtSpi/Handlers/AtSpiAccessibleHandler.cs
+++ b/src/Avalonia.FreeDesktop.AtSpi/Handlers/AtSpiAccessibleHa... | [
"src/Avalonia.FreeDesktop.AtSpi/Handlers/AtSpiAccessibleHandler.cs"
] | [
{
"comment": "Where does `30364` come from? I can't find it even in Windows SDK 26200 `UIAutomationClient.h`",
"path": "src/Windows/Avalonia.Win32.Automation/Interop/IRawElementProviderSimple.cs",
"hunk": "@@ -191,7 +191,8 @@ internal enum UiaPropertyId\n Selection2CurrentSelectedItem,\n Selecti... | true | ||
AvaloniaUI/Avalonia | 21,555 | issue_to_patch | Fix caption button background in dark mode | ## What does the pull request do?
This PR fixes the background of caption buttons (when `ExtendClientAreaToDecorationsHint` is enabled) on pointer over, in dark mode.
## What is the current behavior?
<img width="216" height="61" alt="image" src="https://github.com/user-attachments/assets/fe6f4af5-38ee-48a8-85d7-ae... | 269d0f2b8e2a2972b2c4e750163b3417f60eddee | 7e0c5ada397c4bf358653c3f8a53e9037e06632d | diff --git a/src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml b/src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml
index 80778a50dbc..f7d04ccd9b8 100644
--- a/src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml
+++ b/src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml
@@ ... | [
"src/Avalonia.Themes.Fluent/Accents/FluentControlResources.xaml",
"src/Avalonia.Themes.Simple/Accents/Base.xaml"
] | [] | true | ||
AvaloniaUI/Avalonia | 21,527 | issue_to_patch | Linux, avalonia app crashes on every popup close
### Describe the bug
The problem is in this recent change that most likely handles task cancellation wrong
https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs#L76-L106
### To Reproduce
Run an app on linux (m... | Fix mishandled cancellation in DBusTextInputMethodBase | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Removes try catch filter that is most likely was an oversight
## What is the current behavior?
avalonia app crashes on every popup close
## What is the updated/expected behavior with this PR?
Run... | 2913dc59fa526e3a57efd1b07b13bbb988e922f9 | 3eccdf621339a4ce863d589b8b6ef7550c8b6730 | diff --git a/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs b/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs
index cfd28b29aa8..236276f8058 100644
--- a/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs
+++ b/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs
@@ -64,9 +64,9 ... | [
"src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs"
] | [
{
"comment": "Let's make that method a bit more robust: let's return a `Task` here and call `_ = WatchNameAsync(name)` in the loop above to make it clear it's a fire-and-forget operation.",
"path": "src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs",
"hunk": "",
"resolving_sha": "3eccdf621... | true | |
AvaloniaUI/Avalonia | 21,527 | comment_to_fix | Fix mishandled cancellation in DBusTextInputMethodBase | Let's make that method a bit more robust: let's return a `Task` here and call `_ = WatchNameAsync(name)` in the loop above to make it clear it's a fire-and-forget operation. | 2913dc59fa526e3a57efd1b07b13bbb988e922f9 | 3eccdf621339a4ce863d589b8b6ef7550c8b6730 | diff --git a/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs b/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs
index cfd28b29aa8..236276f8058 100644
--- a/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs
+++ b/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs
@@ -64,9 +64,9 ... | [
"src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs"
] | [
{
"comment": "Let's make that method a bit more robust: let's return a `Task` here and call `_ = WatchNameAsync(name)` in the loop above to make it clear it's a fire-and-forget operation.",
"path": "src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs",
"hunk": "",
"resolving_sha": "3eccdf621... | true | ||
AvaloniaUI/Avalonia | 21,527 | comment_to_fix | Fix mishandled cancellation in DBusTextInputMethodBase | I think the intent was to break out of the loop if `cancellationToken` gets cancelled, but not if other tokens are cancelled. So, let's keep the original `when` clause. See my next comment. | 2913dc59fa526e3a57efd1b07b13bbb988e922f9 | 3eccdf621339a4ce863d589b8b6ef7550c8b6730 | diff --git a/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs b/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs
index cfd28b29aa8..236276f8058 100644
--- a/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs
+++ b/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs
@@ -64,9 +64,9 ... | [
"src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs"
] | [
{
"comment": "I think the intent was to break out of the loop if `cancellationToken` gets cancelled, but not if other tokens are cancelled. So, let's keep the original `when` clause. See my next comment.",
"path": "src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs",
"hunk": "@@ -83,7 +83,7 @@ ... | true | ||
AvaloniaUI/Avalonia | 21,527 | comment_to_fix | Fix mishandled cancellation in DBusTextInputMethodBase | The intent was "log if it wasn't cancelled" but this does not handle the exception, causing the issue you noticed.
Let's just change the `when` to an `if` inside the `catch` block. | 2913dc59fa526e3a57efd1b07b13bbb988e922f9 | 3eccdf621339a4ce863d589b8b6ef7550c8b6730 | diff --git a/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs b/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs
index cfd28b29aa8..236276f8058 100644
--- a/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs
+++ b/src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs
@@ -64,9 +64,9 ... | [
"src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs"
] | [
{
"comment": "The intent was \"log if it wasn't cancelled\" but this does not handle the exception, causing the issue you noticed.\n\nLet's just change the `when` to an `if` inside the `catch` block.",
"path": "src/Avalonia.FreeDesktop/DBusIme/DBusTextInputMethodBase.cs",
"hunk": "",
"resolving_sha"... | true | ||
AvaloniaUI/Avalonia | 21,546 | issue_to_patch | Enhance Roslyn-compiler visible metadata | ## What does the pull request do?
Currently defined `CompilerVisibleProperty`/`AdditionalFiles` were added for the `Avalonia.Generator ` only.
But since then, we started using some of these properties in other Roslyn-based extensions (IDE plugins, for example).
And there are several missing pieces:
- `AvaloniaR... | 269d0f2b8e2a2972b2c4e750163b3417f60eddee | 4c3b218689341ac07363e20cda77f91b0e06568e | diff --git a/packages/Avalonia/AvaloniaBuildTasks.targets b/packages/Avalonia/AvaloniaBuildTasks.targets
index d3750935f92..9ed50e61371 100644
--- a/packages/Avalonia/AvaloniaBuildTasks.targets
+++ b/packages/Avalonia/AvaloniaBuildTasks.targets
@@ -39,6 +39,17 @@
Condition="'$(ApplicationIcon)' !... | [
"packages/Avalonia/AvaloniaBuildTasks.targets",
"src/tools/Avalonia.Generators/Avalonia.Generators.props"
] | [] | true | ||
AvaloniaUI/Avalonia | 21,551 | issue_to_patch | Add support for hover events on android | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Adds support for handling hover events for pointers on Android. This allows stylus/pen inputs that have hover states, like the S-Pen to trigger PointerMove events.
## What is the current behavior?
Hover eve... | 269d0f2b8e2a2972b2c4e750163b3417f60eddee | 3ca13f6981d307dde54e000eb33165f9d97fcf7e | diff --git a/src/Android/Avalonia.Android/AvaloniaView.Input.cs b/src/Android/Avalonia.Android/AvaloniaView.Input.cs
index c829be56be5..4862daaf0b8 100644
--- a/src/Android/Avalonia.Android/AvaloniaView.Input.cs
+++ b/src/Android/Avalonia.Android/AvaloniaView.Input.cs
@@ -27,7 +27,13 @@ protected override void OnFocusC... | [
"src/Android/Avalonia.Android/AvaloniaView.Input.cs"
] | [] | true | ||
AvaloniaUI/Avalonia | 21,545 | issue_to_patch | Support Value pattern on editable ComboBox automation peer | ## What does the pull request do?
Makes `ComboBoxAutomationPeer` expose the editable text through the Value pattern. Previously the peer hardcoded `IsReadOnly => true`, returned the selected item's name as `Value`, and threw from `SetValue`, so automation clients couldn't read or set the text of an editable ComboBox w... | 269d0f2b8e2a2972b2c4e750163b3417f60eddee | 299df5cccfee62e7ad2ffc01ed374ef53c0945a3 | diff --git a/src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPeer.cs b/src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPeer.cs
index 5d71e7a8e48..7f629db9e24 100644
--- a/src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPeer.cs
+++ b/src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPee... | [
"src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPeer.cs",
"tests/Avalonia.Controls.UnitTests/Automation/ComboBoxAutomationPeerTests.cs"
] | [
{
"comment": "When `IsEditable` changes, `IValueProvider.Value` semantics switch between `Owner.Text` and the selected item's name, but the peer only raises `IsReadOnlyProperty` and never raises a `ValueProperty` change notification. Automation clients listening for `ValueProperty` changes can miss this transit... | diff --git a/tests/Avalonia.Controls.UnitTests/Automation/ComboBoxAutomationPeerTests.cs b/tests/Avalonia.Controls.UnitTests/Automation/ComboBoxAutomationPeerTests.cs
new file mode 100644
index 00000000000..fde3f2f8bd2
--- /dev/null
+++ b/tests/Avalonia.Controls.UnitTests/Automation/ComboBoxAutomationPeerTests.cs
@@ -0... | true | |
AvaloniaUI/Avalonia | 21,545 | comment_to_fix | Support Value pattern on editable ComboBox automation peer | When `IsEditable` changes, `IValueProvider.Value` semantics switch between `Owner.Text` and the selected item's name, but the peer only raises `IsReadOnlyProperty` and never raises a `ValueProperty` change notification. Automation clients listening for `ValueProperty` changes can miss this transition and keep a stale v... | 269d0f2b8e2a2972b2c4e750163b3417f60eddee | 299df5cccfee62e7ad2ffc01ed374ef53c0945a3 | diff --git a/src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPeer.cs b/src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPeer.cs
index 5d71e7a8e48..7f629db9e24 100644
--- a/src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPeer.cs
+++ b/src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPee... | [
"src/Avalonia.Controls/Automation/Peers/ComboBoxAutomationPeer.cs"
] | [
{
"comment": "When `IsEditable` changes, `IValueProvider.Value` semantics switch between `Owner.Text` and the selected item's name, but the peer only raises `IsReadOnlyProperty` and never raises a `ValueProperty` change notification. Automation clients listening for `ValueProperty` changes can miss this transit... | true | ||
AvaloniaUI/Avalonia | 21,540 | issue_to_patch | Expose Calendar day button selection state to automation | ## What does the pull request do?
Adds a `CalendarDayButtonAutomationPeer` so automation clients can read and drive day selection in a `Calendar`. Day buttons currently fall back to `ButtonAutomationPeer` with no SelectionItem pattern: there is no way to tell which day is selected through UIA or macOS AX.
## What is ... | 2913dc59fa526e3a57efd1b07b13bbb988e922f9 | 0188b072b622b620579234669db2de9732bc06a2 | diff --git a/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs b/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs
new file mode 100644
index 00000000000..49a56e7aea3
--- /dev/null
+++ b/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs
@@ -0,0 +1,... | [
"src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs",
"src/Avalonia.Controls/Calendar/CalendarDayButton.cs",
"tests/Avalonia.Controls.UnitTests/Automation/CalendarDayButtonAutomationPeerTests.cs"
] | [
{
"comment": "AddToSelection() writes directly to Calendar.SelectedDates, which throws InvalidOperationException in SingleDate mode once there is already a selection (SelectedDatesCollection.CheckSelectionMode), and also allows selecting blackout days since CalendarDayButton.IsEnabled stays true for blackout ce... | diff --git a/tests/Avalonia.Controls.UnitTests/Automation/CalendarDayButtonAutomationPeerTests.cs b/tests/Avalonia.Controls.UnitTests/Automation/CalendarDayButtonAutomationPeerTests.cs
new file mode 100644
index 00000000000..e4ac2de39a3
--- /dev/null
+++ b/tests/Avalonia.Controls.UnitTests/Automation/CalendarDayButtonA... | true | |
AvaloniaUI/Avalonia | 21,540 | comment_to_fix | Expose Calendar day button selection state to automation | AddToSelection() writes directly to Calendar.SelectedDates, which throws InvalidOperationException in SingleDate mode once there is already a selection (SelectedDatesCollection.CheckSelectionMode), and also allows selecting blackout days since CalendarDayButton.IsEnabled stays true for blackout cells. Handle SelectionM... | 2913dc59fa526e3a57efd1b07b13bbb988e922f9 | 0188b072b622b620579234669db2de9732bc06a2 | diff --git a/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs b/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs
new file mode 100644
index 00000000000..49a56e7aea3
--- /dev/null
+++ b/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs
@@ -0,0 +1,... | [
"src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs"
] | [
{
"comment": "AddToSelection() writes directly to Calendar.SelectedDates, which throws InvalidOperationException in SingleDate mode once there is already a selection (SelectedDatesCollection.CheckSelectionMode), and also allows selecting blackout days since CalendarDayButton.IsEnabled stays true for blackout ce... | true | ||
AvaloniaUI/Avalonia | 21,540 | comment_to_fix | Expose Calendar day button selection state to automation | This new peer is a behavior change (SelectionItem pattern + Select/AddToSelection/RemoveFromSelection semantics) but there are no unit tests covering it. There are existing automation peer tests for Calendar in tests/Avalonia.Controls.UnitTests/Automation/ComplexControlAutomationPeerTests.cs; please add coverage assert... | 2913dc59fa526e3a57efd1b07b13bbb988e922f9 | 0188b072b622b620579234669db2de9732bc06a2 | diff --git a/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs b/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs
new file mode 100644
index 00000000000..49a56e7aea3
--- /dev/null
+++ b/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs
@@ -0,0 +1,... | [
"src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs"
] | [
{
"comment": "This new peer is a behavior change (SelectionItem pattern + Select/AddToSelection/RemoveFromSelection semantics) but there are no unit tests covering it. There are existing automation peer tests for Calendar in tests/Avalonia.Controls.UnitTests/Automation/ComplexControlAutomationPeerTests.cs; plea... | true | ||
AvaloniaUI/Avalonia | 21,540 | comment_to_fix | Expose Calendar day button selection state to automation | Select() currently sets Calendar.SelectedDate directly, which throws InvalidOperationException when Calendar.SelectionMode is None and also throws for blackout days. Pointer selection logic is a no-op for both cases (SelectionMode.None returns early; blackout days are ignored), so automation should match that behavior ... | 2913dc59fa526e3a57efd1b07b13bbb988e922f9 | 0188b072b622b620579234669db2de9732bc06a2 | diff --git a/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs b/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs
new file mode 100644
index 00000000000..49a56e7aea3
--- /dev/null
+++ b/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs
@@ -0,0 +1,... | [
"src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs"
] | [
{
"comment": "Select() currently sets Calendar.SelectedDate directly, which throws InvalidOperationException when Calendar.SelectionMode is None and also throws for blackout days. Pointer selection logic is a no-op for both cases (SelectionMode.None returns early; blackout days are ignored), so automation shoul... | true | ||
AvaloniaUI/Avalonia | 21,540 | comment_to_fix | Expose Calendar day button selection state to automation | Nullable nit: make the first parameter `[NotNullWhen(true)] Calendar? calendar` and you can remove the `null!` below. | 2913dc59fa526e3a57efd1b07b13bbb988e922f9 | 0188b072b622b620579234669db2de9732bc06a2 | diff --git a/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs b/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs
new file mode 100644
index 00000000000..49a56e7aea3
--- /dev/null
+++ b/src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs
@@ -0,0 +1,... | [
"src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs"
] | [
{
"comment": "Nullable nit: make the first parameter `[NotNullWhen(true)] Calendar? calendar` and you can remove the `null!` below.",
"path": "src/Avalonia.Controls/Automation/Peers/CalendarDayButtonAutomationPeer.cs",
"hunk": "@@ -0,0 +1,77 @@\n+using System;\n+using Avalonia.Automation.Provider;\n+usi... | true | ||
AvaloniaUI/Avalonia | 21,541 | issue_to_patch | Expose menu item toggle state to automation | ## What does the pull request do?
Implements `IToggleProvider` on `MenuItemAutomationPeer`. Checkable menu items (`ToggleType` CheckBox or Radio) currently expose no Toggle pattern, so automation clients cannot tell whether they are checked.
## What is the updated/expected behavior with this PR?
`ToggleState` reflec... | 2913dc59fa526e3a57efd1b07b13bbb988e922f9 | 0b1be4dd9e53ae0f885fa395ad0d1caa21a216ba | diff --git a/src/Avalonia.Controls/Automation/Peers/MenuItemAutomationPeer.cs b/src/Avalonia.Controls/Automation/Peers/MenuItemAutomationPeer.cs
index 5ecfb29afc1..9fa4ede3ca1 100644
--- a/src/Avalonia.Controls/Automation/Peers/MenuItemAutomationPeer.cs
+++ b/src/Avalonia.Controls/Automation/Peers/MenuItemAutomationPee... | [
"src/Avalonia.Controls/Automation/Peers/MenuItemAutomationPeer.cs",
"tests/Avalonia.Controls.UnitTests/Automation/MenuItemAutomationPeerTests.cs"
] | [
{
"comment": "IToggleProvider.Toggle currently changes IsChecked regardless of whether the MenuItem has a submenu. DefaultMenuInteractionHandler.Click only toggles IsChecked when the item does not have a submenu (HasSubMenu == false), so automation Toggle() can put the control into a state that a user click can... | diff --git a/tests/Avalonia.Controls.UnitTests/Automation/MenuItemAutomationPeerTests.cs b/tests/Avalonia.Controls.UnitTests/Automation/MenuItemAutomationPeerTests.cs
new file mode 100644
index 00000000000..0ef10c9a018
--- /dev/null
+++ b/tests/Avalonia.Controls.UnitTests/Automation/MenuItemAutomationPeerTests.cs
@@ -0... | true | |
AvaloniaUI/Avalonia | 21,541 | comment_to_fix | Expose menu item toggle state to automation | IToggleProvider.Toggle currently changes IsChecked regardless of whether the MenuItem has a submenu. DefaultMenuInteractionHandler.Click only toggles IsChecked when the item does not have a submenu (HasSubMenu == false), so automation Toggle() can put the control into a state that a user click cannot reach for submenu ... | 2913dc59fa526e3a57efd1b07b13bbb988e922f9 | 0b1be4dd9e53ae0f885fa395ad0d1caa21a216ba | diff --git a/src/Avalonia.Controls/Automation/Peers/MenuItemAutomationPeer.cs b/src/Avalonia.Controls/Automation/Peers/MenuItemAutomationPeer.cs
index 5ecfb29afc1..9fa4ede3ca1 100644
--- a/src/Avalonia.Controls/Automation/Peers/MenuItemAutomationPeer.cs
+++ b/src/Avalonia.Controls/Automation/Peers/MenuItemAutomationPee... | [
"src/Avalonia.Controls/Automation/Peers/MenuItemAutomationPeer.cs"
] | [
{
"comment": "IToggleProvider.Toggle currently changes IsChecked regardless of whether the MenuItem has a submenu. DefaultMenuInteractionHandler.Click only toggles IsChecked when the item does not have a submenu (HasSubMenu == false), so automation Toggle() can put the control into a state that a user click can... | true | ||
AvaloniaUI/Avalonia | 21,537 | issue_to_patch | Map macOS ListItem accessibility peer to AXRow | ## What does the pull request do?
Changes the macOS accessibility role reported for `ListItem` automation peers
(ListBoxItem and similar) from `AXGroup` to `AXRow`.
## What is the current behavior?
In `automation.mm`, `AutomationListItem` maps to `NSAccessibilityGroupRole`, so
every list item appears in the macOS ac... | 16cd5ff650e48a8d3948b2604b7389a34f5161d8 | 478a93b87ff1ef9ed8d19cd0faca86f298e36cea | diff --git a/native/Avalonia.Native/src/OSX/automation.mm b/native/Avalonia.Native/src/OSX/automation.mm
index 6fd2cb6218f..0f2ae3768c0 100644
--- a/native/Avalonia.Native/src/OSX/automation.mm
+++ b/native/Avalonia.Native/src/OSX/automation.mm
@@ -96,7 +96,7 @@ - (NSAccessibilityRole)accessibilityRole
case Au... | [
"native/Avalonia.Native/src/OSX/automation.mm"
] | [] | true | ||
AvaloniaUI/Avalonia | 21,536 | issue_to_patch | Listen to layout changes for ancestor visuals in text selection canvas | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Add event handlers for all visual ancestors of the `TextPresenter` that an active text selection canvas is attached to. This ensures that any layout changes, irrespective of the viewport, is sent to the canvas.
... | 16cd5ff650e48a8d3948b2604b7389a34f5161d8 | c8a524e810da5e062a782df293306a9fb9e6c24f | diff --git a/src/Avalonia.Controls/Primitives/TextSelectionCanvas.cs b/src/Avalonia.Controls/Primitives/TextSelectionCanvas.cs
index 8875d8de00b..bae5823b80c 100644
--- a/src/Avalonia.Controls/Primitives/TextSelectionCanvas.cs
+++ b/src/Avalonia.Controls/Primitives/TextSelectionCanvas.cs
@@ -5,9 +5,12 @@
using Avaloni... | [
"src/Avalonia.Controls/Primitives/TextSelectionCanvas.cs",
"tests/Avalonia.Controls.UnitTests/TextSelectionCanvasTests.cs"
] | [] | diff --git a/tests/Avalonia.Controls.UnitTests/TextSelectionCanvasTests.cs b/tests/Avalonia.Controls.UnitTests/TextSelectionCanvasTests.cs
new file mode 100644
index 00000000000..6e1c9dcce3f
--- /dev/null
+++ b/tests/Avalonia.Controls.UnitTests/TextSelectionCanvasTests.cs
@@ -0,0 +1,152 @@
+using System.Linq;
+using A... | true | |
AvaloniaUI/Avalonia | 21,430 | issue_to_patch | [WinUI] Create Avalonia.WinUI for initial WinUI embed support | This PR adds "Avalonia.WinUI" to embed Avalonia controls in WinUI 3 applications. My push for this is for the Avalonia.Controls.Maui project, to allow embedding Avalonia controls within existing .NET MAUI apps (which target WinUI 3).
<img width="1805" height="1115" alt="スクリーンショット 2026-05-25 154434" src="https://gith... | aee3f68551b0ac4417e32996a6627f34462edbc3 | db8c86b61782572ca27e59debe8f23cfb8efdc3a | diff --git a/Avalonia.slnx b/Avalonia.slnx
index 80b4042e7a0..dba476ed4a3 100644
--- a/Avalonia.slnx
+++ b/Avalonia.slnx
@@ -65,6 +65,10 @@
<Project Path="samples/ControlCatalog.MacCatalyst/ControlCatalog.MacCatalyst.csproj" />
<Project Path="samples/ControlCatalog.tvOS/ControlCatalog.tvOS.csproj" />
<Pr... | [
"Avalonia.slnx",
"Directory.Packages.props",
"build/TargetFrameworks.props",
"dirs.proj",
"samples/ControlGallery.WinUI/App.xaml",
"samples/ControlGallery.WinUI/App.xaml.cs",
"samples/ControlGallery.WinUI/Assets/LockScreenLogo.scale-200.png",
"samples/ControlGallery.WinUI/Assets/SplashScreen.scale-200... | [
{
"comment": "Haven't checked why, but this InternalsVisibleTo is suspicious - why backend has internal code for the sample app?",
"path": "src/Windows/Avalonia.Win32/Avalonia.Win32.csproj",
"hunk": "@@ -34,6 +34,8 @@\n </PropertyGroup>\n <ItemGroup>\n <InternalsVisibleTo Include=\"Avalonia.Win3... | true | ||
AvaloniaUI/Avalonia | 21,430 | comment_to_fix | [WinUI] Create Avalonia.WinUI for initial WinUI embed support | Haven't checked why, but this InternalsVisibleTo is suspicious - why backend has internal code for the sample app? | aee3f68551b0ac4417e32996a6627f34462edbc3 | db8c86b61782572ca27e59debe8f23cfb8efdc3a | diff --git a/src/Windows/Avalonia.Win32/Avalonia.Win32.csproj b/src/Windows/Avalonia.Win32/Avalonia.Win32.csproj
index ea834e26a68..17796d2f9b7 100644
--- a/src/Windows/Avalonia.Win32/Avalonia.Win32.csproj
+++ b/src/Windows/Avalonia.Win32/Avalonia.Win32.csproj
@@ -34,6 +34,7 @@
</PropertyGroup>
<ItemGroup>
<... | [
"src/Windows/Avalonia.Win32/Avalonia.Win32.csproj"
] | [
{
"comment": "Haven't checked why, but this InternalsVisibleTo is suspicious - why backend has internal code for the sample app?",
"path": "src/Windows/Avalonia.Win32/Avalonia.Win32.csproj",
"hunk": "@@ -34,6 +34,8 @@\n </PropertyGroup>\n <ItemGroup>\n <InternalsVisibleTo Include=\"Avalonia.Win3... | true | ||
AvaloniaUI/Avalonia | 21,430 | comment_to_fix | [WinUI] Create Avalonia.WinUI for initial WinUI embed support | OnUnloaded disposes the MouseDevice/TouchDevice/PenDevice instances, but these fields are created once and reused across the lifetime of the panel. WinUI controls can be unloaded and later reloaded; after the first unload, subsequent input will be routed through disposed devices (MouseDevice/TouchDevice/PenDevice short... | aee3f68551b0ac4417e32996a6627f34462edbc3 | db8c86b61782572ca27e59debe8f23cfb8efdc3a | diff --git a/src/Windows/Avalonia.WinUI/AvaloniaSwapChainPanel.cs b/src/Windows/Avalonia.WinUI/AvaloniaSwapChainPanel.cs
new file mode 100644
index 00000000000..3494305e314
--- /dev/null
+++ b/src/Windows/Avalonia.WinUI/AvaloniaSwapChainPanel.cs
@@ -0,0 +1,915 @@
+using System;
+using System.Collections.Generic;
+using... | [
"src/Windows/Avalonia.WinUI/AvaloniaSwapChainPanel.cs"
] | [
{
"comment": "OnUnloaded disposes the MouseDevice/TouchDevice/PenDevice instances, but these fields are created once and reused across the lifetime of the panel. WinUI controls can be unloaded and later reloaded; after the first unload, subsequent input will be routed through disposed devices (MouseDevice/Touch... | true | ||
AvaloniaUI/Avalonia | 21,430 | comment_to_fix | [WinUI] Create Avalonia.WinUI for initial WinUI embed support | The Present callback disposes the GL context lock after calling _swapChain.Present, but if Present throws (e.g., device removed) the contextLock won't be disposed, leaving the GL context current and potentially leaking resources. Wrap Present in a try/finally (or otherwise ensure contextLock is always disposed) to keep... | aee3f68551b0ac4417e32996a6627f34462edbc3 | db8c86b61782572ca27e59debe8f23cfb8efdc3a | diff --git a/src/Windows/Avalonia.Win32/OpenGl/Angle/SwapChainGlSurface.cs b/src/Windows/Avalonia.Win32/OpenGl/Angle/SwapChainGlSurface.cs
new file mode 100644
index 00000000000..9dfd692da31
--- /dev/null
+++ b/src/Windows/Avalonia.Win32/OpenGl/Angle/SwapChainGlSurface.cs
@@ -0,0 +1,252 @@
+using System;
+using System.... | [
"src/Windows/Avalonia.Win32/OpenGl/Angle/SwapChainGlSurface.cs"
] | [
{
"comment": "The Present callback disposes the GL context lock after calling _swapChain.Present, but if Present throws (e.g., device removed) the contextLock won't be disposed, leaving the GL context current and potentially leaking resources. Wrap Present in a try/finally (or otherwise ensure contextLock is al... | true | ||
AvaloniaUI/Avalonia | 21,430 | comment_to_fix | [WinUI] Create Avalonia.WinUI for initial WinUI embed support | The sample manifest requests the "systemAIModels" capability, which is a restricted capability unrelated to WinUI embed/Avalonia hosting and can prevent the app from installing/running in many environments. Unless this sample actually uses system AI models, remove this capability to avoid unnecessary permission require... | aee3f68551b0ac4417e32996a6627f34462edbc3 | db8c86b61782572ca27e59debe8f23cfb8efdc3a | diff --git a/samples/ControlGallery.WinUI/Package.appxmanifest b/samples/ControlGallery.WinUI/Package.appxmanifest
new file mode 100644
index 00000000000..fcd91fc1ac5
--- /dev/null
+++ b/samples/ControlGallery.WinUI/Package.appxmanifest
@@ -0,0 +1,51 @@
+<?xml version="1.0" encoding="utf-8"?>
+
+<Package
+ xmlns="htt... | [
"samples/ControlGallery.WinUI/Package.appxmanifest"
] | [
{
"comment": "The sample manifest requests the \"systemAIModels\" capability, which is a restricted capability unrelated to WinUI embed/Avalonia hosting and can prevent the app from installing/running in many environments. Unless this sample actually uses system AI models, remove this capability to avoid unnece... | true | ||
AvaloniaUI/Avalonia | 21,430 | comment_to_fix | [WinUI] Create Avalonia.WinUI for initial WinUI embed support | CommitToClient returns immediately when newText is empty. CoreTextEditContext.TextUpdating can represent deletions/replacements where args.Text is empty but args.Range is non-empty; in that case the deletion will be ignored and the Avalonia client won't be updated. Handle the range-deletion case explicitly instead of e... | aee3f68551b0ac4417e32996a6627f34462edbc3 | db8c86b61782572ca27e59debe8f23cfb8efdc3a | diff --git a/src/Windows/Avalonia.WinUI/WinUITextInputMethod.cs b/src/Windows/Avalonia.WinUI/WinUITextInputMethod.cs
new file mode 100644
index 00000000000..f1517a593d0
--- /dev/null
+++ b/src/Windows/Avalonia.WinUI/WinUITextInputMethod.cs
@@ -0,0 +1,384 @@
+using System;
+using System.Runtime.InteropServices;
+using g... | [
"src/Windows/Avalonia.WinUI/WinUITextInputMethod.cs"
] | [
{
"comment": "CommitToClient returns immediately when newText is empty. CoreTextEditContext.TextUpdating can represent deletions/replacements where args.Text is empty but args.Range is non-empty; in that case the deletion will be ignored and the Avalonia client won't be updated. Handle the range-deletion case e... | true | ||
AvaloniaUI/Avalonia | 21,430 | comment_to_fix | [WinUI] Create Avalonia.WinUI for initial WinUI embed support | The doc comment states the panel keeps the most recent PointerPoint per pointer id and looks it up by the triggering Avalonia pointer's id, but AvaloniaSwapChainPanel only caches a single _lastPointerPoint (not per-pointer) and WinUIDragSource doesn't pass an id. Please either implement per-pointer caching/lookup or up... | aee3f68551b0ac4417e32996a6627f34462edbc3 | db8c86b61782572ca27e59debe8f23cfb8efdc3a | diff --git a/src/Windows/Avalonia.WinUI/WinUIDragSource.cs b/src/Windows/Avalonia.WinUI/WinUIDragSource.cs
new file mode 100644
index 00000000000..ed165aada9d
--- /dev/null
+++ b/src/Windows/Avalonia.WinUI/WinUIDragSource.cs
@@ -0,0 +1,42 @@
+using System.Threading.Tasks;
+using global::Avalonia.Controls;
+using global... | [
"src/Windows/Avalonia.WinUI/WinUIDragSource.cs"
] | [
{
"comment": "The doc comment states the panel keeps the most recent PointerPoint per pointer id and looks it up by the triggering Avalonia pointer's id, but AvaloniaSwapChainPanel only caches a single _lastPointerPoint (not per-pointer) and WinUIDragSource doesn't pass an id. Please either implement per-pointe... | true | ||
AvaloniaUI/Avalonia | 21,430 | comment_to_fix | [WinUI] Create Avalonia.WinUI for initial WinUI embed support | The static constructor globally re-binds ICursorFactory in AvaloniaLocator as soon as the type is loaded (e.g., via XAML), which can override bindings established by UseWin32/other platforms and affect other Avalonia surfaces in the same process. Consider moving this to an explicit WinUI-embed initialization entry poin... | aee3f68551b0ac4417e32996a6627f34462edbc3 | db8c86b61782572ca27e59debe8f23cfb8efdc3a | diff --git a/src/Windows/Avalonia.WinUI/AvaloniaSwapChainPanel.cs b/src/Windows/Avalonia.WinUI/AvaloniaSwapChainPanel.cs
new file mode 100644
index 00000000000..3494305e314
--- /dev/null
+++ b/src/Windows/Avalonia.WinUI/AvaloniaSwapChainPanel.cs
@@ -0,0 +1,915 @@
+using System;
+using System.Collections.Generic;
+using... | [
"src/Windows/Avalonia.WinUI/AvaloniaSwapChainPanel.cs"
] | [
{
"comment": "The static constructor globally re-binds ICursorFactory in AvaloniaLocator as soon as the type is loaded (e.g., via XAML), which can override bindings established by UseWin32/other platforms and affect other Avalonia surfaces in the same process. Consider moving this to an explicit WinUI-embed ini... | true | ||
AvaloniaUI/Avalonia | 21,430 | comment_to_fix | [WinUI] Create Avalonia.WinUI for initial WinUI embed support | TransformAvaloniaRectToScreen() multiplies by RasterizationScale but doesn't apply any window/client-to-screen offset (unlike WinUITextInputMethod.ComputeScreenCursorRect, which adds ClientToScreen when running in a ContentIsland). If UIA expects bounding rectangles in screen coordinates, these bounds may be reported r... | aee3f68551b0ac4417e32996a6627f34462edbc3 | db8c86b61782572ca27e59debe8f23cfb8efdc3a | diff --git a/src/Windows/Avalonia.WinUI/Automation/AvaloniaSwapChainPanelAutomationPeer.cs b/src/Windows/Avalonia.WinUI/Automation/AvaloniaSwapChainPanelAutomationPeer.cs
new file mode 100644
index 00000000000..4b6159a5462
--- /dev/null
+++ b/src/Windows/Avalonia.WinUI/Automation/AvaloniaSwapChainPanelAutomationPeer.cs... | [
"src/Windows/Avalonia.WinUI/Automation/AvaloniaSwapChainPanelAutomationPeer.cs"
] | [
{
"comment": "TransformAvaloniaRectToScreen() multiplies by RasterizationScale but doesn't apply any window/client-to-screen offset (unlike WinUITextInputMethod.ComputeScreenCursorRect, which adds ClientToScreen when running in a ContentIsland). If UIA expects bounding rectangles in screen coordinates, these bo... | true | ||
AvaloniaUI/Avalonia | 21,423 | issue_to_patch | Add sleep timer option for the headless platform | ## What does the pull request do?
Allows to run headless rendering more efficiently, although less controlled.
New APIs (naming copied from pre-existing linux options):
```diff
public class AvaloniaHeadlessPlatformOptions
{
+ public int Fps { get; set; } = 60;
+ public bool ShouldRenderOnUIThre... | aee3f68551b0ac4417e32996a6627f34462edbc3 | 28221563fd2f54196345c693ff873785a38fd80a | diff --git a/src/Headless/Avalonia.Headless/AvaloniaHeadlessPlatform.cs b/src/Headless/Avalonia.Headless/AvaloniaHeadlessPlatform.cs
index 8e44942d32e..838301a6b52 100644
--- a/src/Headless/Avalonia.Headless/AvaloniaHeadlessPlatform.cs
+++ b/src/Headless/Avalonia.Headless/AvaloniaHeadlessPlatform.cs
@@ -1,64 +1,22 @@
... | [
"src/Headless/Avalonia.Headless/AvaloniaHeadlessPlatform.cs",
"src/Headless/Avalonia.Headless/HeadlessRenderTimer.cs"
] | [
{
"comment": "For sleep loop timer we can probably spin a dispatcher frame until the next tick? I. e. call Compositor.RequestCommitAsync and stop dispatcher frame once it completes.",
"path": "src/Headless/Avalonia.Headless/AvaloniaHeadlessPlatform.cs",
"hunk": "@@ -97,18 +58,57 @@ internal static void ... | true | ||
AvaloniaUI/Avalonia | 21,446 | issue_to_patch | TextCollapsingProperties bidirectional-text (BiDi) correctness fixes | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Fixes bidirectional-text (BiDi) correctness across every `TextCollapsingProperties` implementation - trailing-character, trailing-word, leading-prefix and path-segment ellipsis — and the helpers they share. Tri... | 392e3a4459df2872339ae9d4a153340861eefe5a | ae3e96f21e4a4a574f7ef6a4309eeb93f081ed58 | diff --git a/src/Avalonia.Base/Media/TextFormatting/LogicalTextRunEnumerator.cs b/src/Avalonia.Base/Media/TextFormatting/LogicalTextRunEnumerator.cs
index 7b391801a69..514c39edd4f 100644
--- a/src/Avalonia.Base/Media/TextFormatting/LogicalTextRunEnumerator.cs
+++ b/src/Avalonia.Base/Media/TextFormatting/LogicalTextRunE... | [
"src/Avalonia.Base/Media/TextFormatting/LogicalTextRunEnumerator.cs",
"src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs",
"src/Avalonia.Base/Media/TextFormatting/ShapedTextRun.cs",
"src/Avalonia.Base/Media/TextFormatting/TextCollapsingProperties.cs",
"src/Avalonia.Base/Media/TextFormatting/TextFormatt... | [
{
"comment": "When a logical-tail run fits entirely within `availableSuffixWidth`, `TryMeasureCharactersBackwards` returns `suffixCount == endShapedRun.Length`. The subsequent call `endShapedRun.Split(run.Length - suffixCount)` then evaluates to `Split(0)`, which throws `ArgumentOutOfRangeException` (see `Shape... | diff --git a/tests/Avalonia.Benchmarks/Text/ShapedBufferOps.cs b/tests/Avalonia.Benchmarks/Text/ShapedBufferOps.cs
index 255ea6aeb6e..33c5a6d76aa 100644
--- a/tests/Avalonia.Benchmarks/Text/ShapedBufferOps.cs
+++ b/tests/Avalonia.Benchmarks/Text/ShapedBufferOps.cs
@@ -10,7 +10,7 @@ namespace Avalonia.Benchmarks.Text;
... | true | |
AvaloniaUI/Avalonia | 21,446 | comment_to_fix | TextCollapsingProperties bidirectional-text (BiDi) correctness fixes | When a logical-tail run fits entirely within `availableSuffixWidth`, `TryMeasureCharactersBackwards` returns `suffixCount == endShapedRun.Length`. The subsequent call `endShapedRun.Split(run.Length - suffixCount)` then evaluates to `Split(0)`, which throws `ArgumentOutOfRangeException` (see `ShapedTextRun.Split` at lin... | 392e3a4459df2872339ae9d4a153340861eefe5a | ae3e96f21e4a4a574f7ef6a4309eeb93f081ed58 | diff --git a/src/Avalonia.Base/Media/TextFormatting/TextLeadingPrefixCharacterEllipsis.cs b/src/Avalonia.Base/Media/TextFormatting/TextLeadingPrefixCharacterEllipsis.cs
index e1f36b5f4cb..10bd3e13d96 100644
--- a/src/Avalonia.Base/Media/TextFormatting/TextLeadingPrefixCharacterEllipsis.cs
+++ b/src/Avalonia.Base/Media/... | [
"src/Avalonia.Base/Media/TextFormatting/TextLeadingPrefixCharacterEllipsis.cs"
] | [
{
"comment": "When a logical-tail run fits entirely within `availableSuffixWidth`, `TryMeasureCharactersBackwards` returns `suffixCount == endShapedRun.Length`. The subsequent call `endShapedRun.Split(run.Length - suffixCount)` then evaluates to `Split(0)`, which throws `ArgumentOutOfRangeException` (see `Shape... | true | ||
AvaloniaUI/Avalonia | 21,446 | comment_to_fix | TextCollapsingProperties bidirectional-text (BiDi) correctness fixes | Nit: we're not limited by .NET Standard anymore, `Math.Clamp` can now be used :) | 392e3a4459df2872339ae9d4a153340861eefe5a | ae3e96f21e4a4a574f7ef6a4309eeb93f081ed58 | diff --git a/src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs b/src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs
index 581ed901d0a..7be486717ee 100644
--- a/src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs
+++ b/src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs
@@ -307,57 +307,6 @@ internal doubl... | [
"src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs"
] | [
{
"comment": "Nit: we're not limited by .NET Standard anymore, `Math.Clamp` can now be used :)",
"path": "src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs",
"hunk": "@@ -799,5 +799,187 @@ private SplitResult<ShapedBuffer> SplitDescending(int textLength)\n \n return new SplitResult<Shap... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.