repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
AvaloniaUI/Avalonia | 21,446 | comment_to_fix | TextCollapsingProperties bidirectional-text (BiDi) correctness fixes | This is a duplicate of `MeasureCharactersThatFit`. | 392e3a4459df2872339ae9d4a153340861eefe5a | ae3e96f21e4a4a574f7ef6a4309eeb93f081ed58 | diff --git a/src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs b/src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs
index 581ed901d0a..7be486717ee 100644
--- a/src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs
+++ b/src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs
@@ -307,57 +307,6 @@ internal doubl... | [
"src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs"
] | [
{
"comment": "This is a duplicate of `MeasureCharactersThatFit`.",
"path": "src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs",
"hunk": "@@ -799,5 +799,187 @@ private SplitResult<ShapedBuffer> SplitDescending(int textLength)\n \n return new SplitResult<ShapedBuffer>(first, second);\n ... | true | ||
AvaloniaUI/Avalonia | 21,189 | issue_to_patch | Add platform feedback api for sound and haptic feedback | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Add audio and haptic feedback for common interact-able controls.
This PR is a rework of https://github.com/AvaloniaUI/Avalonia/pull/9420 .The api has been stripped down and the core implementation is internal.... | 392e3a4459df2872339ae9d4a153340861eefe5a | 9a90dbea1c3f556e850359f5f6d8fb12ea8acc93 | diff --git a/samples/ControlCatalog/Pages/ContextFlyoutPage.xaml b/samples/ControlCatalog/Pages/ContextFlyoutPage.xaml
index afb823dd84e..f96fcd92988 100644
--- a/samples/ControlCatalog/Pages/ContextFlyoutPage.xaml
+++ b/samples/ControlCatalog/Pages/ContextFlyoutPage.xaml
@@ -22,6 +22,7 @@
<Setter Property="Ma... | [
"samples/ControlCatalog/Pages/ContextFlyoutPage.xaml",
"samples/ControlCatalog/Pages/ContextMenuPage.xaml",
"src/Android/Avalonia.Android/Platform/AndroidPlatformFeedback.cs",
"src/Android/Avalonia.Android/Platform/SkiaPlatform/TopLevelImpl.cs",
"src/Avalonia.Base/Input/ContextRequestedEventArgs.cs",
"src... | [
{
"comment": "This method is used to inform the device hardware that haptic feedback might happen soon, so that it can ready itself. This reduces latency when the feedback is requested later on. \n\nThere is no benefit to calling it and then immediately calling `ImpactOccurred`.",
"path": "src/iOS/Avalonia.... | true | ||
AvaloniaUI/Avalonia | 21,189 | comment_to_fix | Add platform feedback api for sound and haptic feedback | This method is used to inform the device hardware that haptic feedback might happen soon, so that it can ready itself. This reduces latency when the feedback is requested later on.
There is no benefit to calling it and then immediately calling `ImpactOccurred`. | 392e3a4459df2872339ae9d4a153340861eefe5a | 9a90dbea1c3f556e850359f5f6d8fb12ea8acc93 | diff --git a/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs b/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs
new file mode 100644
index 00000000000..87544768610
--- /dev/null
+++ b/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs
@@ -0,0 +1,56 @@
+using System;
+using AudioToolbox;
+using Avalonia.Controls;
+using UIKit;
+
+name... | [
"src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs"
] | [
{
"comment": "This method is used to inform the device hardware that haptic feedback might happen soon, so that it can ready itself. This reduces latency when the feedback is requested later on. \n\nThere is no benefit to calling it and then immediately calling `ImpactOccurred`.",
"path": "src/iOS/Avalonia.... | true | ||
AvaloniaUI/Avalonia | 21,189 | comment_to_fix | Add platform feedback api for sound and haptic feedback | This will allow you to drop the pragma and comment above:
```suggestion
#else
_ = _avaloniaView;
#endif
``` | 392e3a4459df2872339ae9d4a153340861eefe5a | 9a90dbea1c3f556e850359f5f6d8fb12ea8acc93 | diff --git a/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs b/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs
new file mode 100644
index 00000000000..87544768610
--- /dev/null
+++ b/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs
@@ -0,0 +1,56 @@
+using System;
+using AudioToolbox;
+using Avalonia.Controls;
+using UIKit;
+
+name... | [
"src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs"
] | [
{
"comment": "This will allow you to drop the pragma and comment above:\n\n```suggestion\n#else\n _ = _avaloniaView;\n#endif\n```",
"path": "src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs",
"hunk": "@@ -0,0 +1,52 @@\n+using System;\n+using AudioToolbox;\n+using Avalonia.Controls.Platform;\n+usi... | true | ||
AvaloniaUI/Avalonia | 21,189 | comment_to_fix | Add platform feedback api for sound and haptic feedback | This will trigger the feedback on all elements in the event route.
While this might be appropriate for elements before and including the one that handled the event, it also means elements *after* will trigger the feedback, as if handling the event did nothing.
To clarify, let's say we have feedback types set on `Cont... | 392e3a4459df2872339ae9d4a153340861eefe5a | 9a90dbea1c3f556e850359f5f6d8fb12ea8acc93 | diff --git a/src/Avalonia.Controls/Control.cs b/src/Avalonia.Controls/Control.cs
index edd647f7722..6b37e48c42f 100644
--- a/src/Avalonia.Controls/Control.cs
+++ b/src/Avalonia.Controls/Control.cs
@@ -2,11 +2,11 @@
using System.Collections.Generic;
using System.ComponentModel;
using Avalonia.Automation.Peers;
+using... | [
"src/Avalonia.Controls/Control.cs"
] | [
{
"comment": "This will trigger the feedback on all elements in the event route.\n\nWhile this might be appropriate for elements before and including the one that handled the event, it also means elements *after* will trigger the feedback, as if handling the event did nothing.\n\nTo clarify, let's say we have f... | true | ||
AvaloniaUI/Avalonia | 21,189 | comment_to_fix | Add platform feedback api for sound and haptic feedback | This was missed in the API review but I think this should return `bool` to help the user know if feedback was actually performed (like `IPlatformFeedback.Perform` does). | 392e3a4459df2872339ae9d4a153340861eefe5a | 9a90dbea1c3f556e850359f5f6d8fb12ea8acc93 | diff --git a/src/Avalonia.Controls/Platform/PlatformFeedback.cs b/src/Avalonia.Controls/Platform/PlatformFeedback.cs
new file mode 100644
index 00000000000..b8ae925b017
--- /dev/null
+++ b/src/Avalonia.Controls/Platform/PlatformFeedback.cs
@@ -0,0 +1,54 @@
+using Avalonia.Input;
+
+namespace Avalonia.Controls
+{
+ ... | [
"src/Avalonia.Controls/Platform/PlatformFeedback.cs"
] | [
{
"comment": "This was missed in the API review but I think this should return `bool` to help the user know if feedback was actually performed (like `IPlatformFeedback.Perform` does).",
"path": "src/Avalonia.Controls/Platform/PlatformFeedback.cs",
"hunk": "@@ -0,0 +1,51 @@\n+using Avalonia.Input;\n+\n+... | true | ||
AvaloniaUI/Avalonia | 21,189 | comment_to_fix | Add platform feedback api for sound and haptic feedback | This should be `public` + `[PrivateAPI]` instead so that all platforms can implement it without an `InternalsVisibleTo`. Then remove the added `InternalsVisibleTo`. | 392e3a4459df2872339ae9d4a153340861eefe5a | 9a90dbea1c3f556e850359f5f6d8fb12ea8acc93 | diff --git a/src/Avalonia.Controls/Platform/IPlatformFeedback.cs b/src/Avalonia.Controls/Platform/IPlatformFeedback.cs
new file mode 100644
index 00000000000..99ea2f37837
--- /dev/null
+++ b/src/Avalonia.Controls/Platform/IPlatformFeedback.cs
@@ -0,0 +1,64 @@
+using Avalonia.Metadata;
+
+namespace Avalonia.Controls
+{... | [
"src/Avalonia.Controls/Platform/IPlatformFeedback.cs"
] | [
{
"comment": "This should be `public` + `[PrivateAPI]` instead so that all platforms can implement it without an `InternalsVisibleTo`. Then remove the added `InternalsVisibleTo`.",
"path": "src/Avalonia.Controls/Platform/IPlatformFeedback.cs",
"hunk": "@@ -0,0 +1,63 @@\n+using Avalonia.Metadata;\n+\n+n... | true | ||
AvaloniaUI/Avalonia | 21,189 | comment_to_fix | Add platform feedback api for sound and haptic feedback | Return `true` in the branches above directly, and `false` here. It will allow us to add new feedback actions in the future without changes. | 392e3a4459df2872339ae9d4a153340861eefe5a | 9a90dbea1c3f556e850359f5f6d8fb12ea8acc93 | diff --git a/src/Android/Avalonia.Android/Platform/AndroidPlatformFeedback.cs b/src/Android/Avalonia.Android/Platform/AndroidPlatformFeedback.cs
new file mode 100644
index 00000000000..1adee29316e
--- /dev/null
+++ b/src/Android/Avalonia.Android/Platform/AndroidPlatformFeedback.cs
@@ -0,0 +1,43 @@
+using Android.Conte... | [
"src/Android/Avalonia.Android/Platform/AndroidPlatformFeedback.cs"
] | [
{
"comment": "Return `true` in the branches above directly, and `false` here. It will allow us to add new feedback actions in the future without changes.",
"path": "src/Android/Avalonia.Android/Platform/AndroidPlatformFeedback.cs",
"hunk": "@@ -0,0 +1,37 @@\n+using Android.Content;\n+using Android.Medi... | true | ||
AvaloniaUI/Avalonia | 21,189 | comment_to_fix | Add platform feedback api for sound and haptic feedback | Nit: check directly that `FeedbackType` is either `Sound` or `Auto` so we can extend the enum safely later. | 392e3a4459df2872339ae9d4a153340861eefe5a | 9a90dbea1c3f556e850359f5f6d8fb12ea8acc93 | diff --git a/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs b/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs
new file mode 100644
index 00000000000..87544768610
--- /dev/null
+++ b/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs
@@ -0,0 +1,56 @@
+using System;
+using AudioToolbox;
+using Avalonia.Controls;
+using UIKit;
+
+name... | [
"src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs"
] | [
{
"comment": "Nit: check directly that `FeedbackType` is either `Sound` or `Auto` so we can extend the enum safely later.",
"path": "src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs",
"hunk": "@@ -0,0 +1,52 @@\n+using System;\n+using AudioToolbox;\n+using Avalonia.Controls.Platform;\n+using UIKit;\n+\n+name... | true | ||
AvaloniaUI/Avalonia | 21,189 | comment_to_fix | Add platform feedback api for sound and haptic feedback | Nit: check directly that `FeedbackType` is either `Haptic` or `Auto` so we can extend the enum safely later. | 392e3a4459df2872339ae9d4a153340861eefe5a | 9a90dbea1c3f556e850359f5f6d8fb12ea8acc93 | diff --git a/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs b/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs
new file mode 100644
index 00000000000..87544768610
--- /dev/null
+++ b/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs
@@ -0,0 +1,56 @@
+using System;
+using AudioToolbox;
+using Avalonia.Controls;
+using UIKit;
+
+name... | [
"src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs"
] | [
{
"comment": "Nit: check directly that `FeedbackType` is either `Haptic` or `Auto` so we can extend the enum safely later.",
"path": "src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs",
"hunk": "@@ -0,0 +1,52 @@\n+using System;\n+using AudioToolbox;\n+using Avalonia.Controls.Platform;\n+using UIKit;\n+\n+nam... | true | ||
AvaloniaUI/Avalonia | 21,189 | comment_to_fix | Add platform feedback api for sound and haptic feedback | Don't throw, just ignore the unknown feedback actions so we can add new ones later. | 392e3a4459df2872339ae9d4a153340861eefe5a | 9a90dbea1c3f556e850359f5f6d8fb12ea8acc93 | diff --git a/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs b/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs
new file mode 100644
index 00000000000..87544768610
--- /dev/null
+++ b/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs
@@ -0,0 +1,56 @@
+using System;
+using AudioToolbox;
+using Avalonia.Controls;
+using UIKit;
+
+name... | [
"src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs"
] | [
{
"comment": "Don't throw, just ignore the unknown feedback actions so we can add new ones later.",
"path": "src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs",
"hunk": "@@ -0,0 +1,52 @@\n+using System;\n+using AudioToolbox;\n+using Avalonia.Controls.Platform;\n+using UIKit;\n+\n+namespace Avalonia.iOS\n+{\n... | true | ||
AvaloniaUI/Avalonia | 21,189 | comment_to_fix | Add platform feedback api for sound and haptic feedback | Consider caching the `SystemSound` instance in a field. | 392e3a4459df2872339ae9d4a153340861eefe5a | 9a90dbea1c3f556e850359f5f6d8fb12ea8acc93 | diff --git a/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs b/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs
new file mode 100644
index 00000000000..87544768610
--- /dev/null
+++ b/src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs
@@ -0,0 +1,56 @@
+using System;
+using AudioToolbox;
+using Avalonia.Controls;
+using UIKit;
+
+name... | [
"src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs"
] | [
{
"comment": "Consider caching the `SystemSound` instance in a field.",
"path": "src/iOS/Avalonia.iOS/IOSPlatformFeedback.cs",
"hunk": "@@ -0,0 +1,52 @@\n+using System;\n+using AudioToolbox;\n+using Avalonia.Controls.Platform;\n+using UIKit;\n+\n+namespace Avalonia.iOS\n+{\n+ internal class IOSPlatf... | true | ||
AvaloniaUI/Avalonia | 21,462 | issue_to_patch | WASM: SynchronizationContext not set when processing input events
### Describe the bug
When dispatching input events in BrowserInputHandler, Thread.SynchronizationContext is not set, it is null.
This makes binding to observables break.
```
System.InvalidOperationException: TaskScheduler_FromCurrentSynchronization... | [WASM] Ensure sync context is set before running dispatcher messages | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Ensures `AvaloniaSynchronizationContext.Current` is set before invoking messages on Dispatcher.
## What is the current behavior?
The dotnet wasm runtime sets `SynchronizationContext.Current` to null on wasm... | 9d4c952ab04211d45492290780aae80dc88ecb53 | 72c90dd16f6c7dacca73463d6ee7ede9b973e999 | diff --git a/src/Avalonia.Base/Threading/Dispatcher.Invoke.cs b/src/Avalonia.Base/Threading/Dispatcher.Invoke.cs
index 90167fa8a1f..c2eba7e5033 100644
--- a/src/Avalonia.Base/Threading/Dispatcher.Invoke.cs
+++ b/src/Avalonia.Base/Threading/Dispatcher.Invoke.cs
@@ -649,7 +649,8 @@ internal void Send(SendOrPostCallback a... | [
"src/Avalonia.Base/Threading/Dispatcher.Invoke.cs",
"tests/Avalonia.Base.UnitTests/DispatcherTests.cs"
] | [] | diff --git a/tests/Avalonia.Base.UnitTests/DispatcherTests.cs b/tests/Avalonia.Base.UnitTests/DispatcherTests.cs
index 2ab442e4fac..f7e251eb50d 100644
--- a/tests/Avalonia.Base.UnitTests/DispatcherTests.cs
+++ b/tests/Avalonia.Base.UnitTests/DispatcherTests.cs
@@ -448,6 +448,7 @@ void DumpCurrentPriority() =>
... | true |
AvaloniaUI/Avalonia | 21,498 | issue_to_patch | `Window` animations is lost when `ExtendClientAreaToDecorationsHint="True"`
### Describe the bug
`Window` Minimize/Maximize/Restore/Close animations is lost when `ExtendClientAreaToDecorationsHint="True"` after update Avalonia to 12.0.4.
https://github.com/user-attachments/assets/137d7d3b-1fa1-45b9-b770-8f9804c25a4a... | Win32: Fix window animations in extended mode | ## What does the pull request do?
This PR restores the window animations on Windows when `WindowDecorations = Full` and `ExtendClientAreaToDecorationsHint = True` in both Windows 10 and 11.
## Notes
The animations were broken by #21412. The changes from this PR are partially reverted here. `WS_CAPTION` is now enfo... | e008beb28730856577d337ef4bc671e7d6abff3f | 364dec13a79b5b2c921c42fa2bdf620c5aefbf61 | diff --git a/src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs b/src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs
index 798affd3377..42938620d91 100644
--- a/src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs
+++ b/src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs
@@ -93,11 +93,9 @@ protected virtual unsafe Int... | [
"src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs",
"src/Windows/Avalonia.Win32/WindowImpl.cs"
] | [] | true | |
AvaloniaUI/Avalonia | 21,495 | issue_to_patch | RadioButton styling for disabled
### Describe the bug
The RadioButton control styling for disabled properties seem to be reversed. Please review for correctness.
### To Reproduce
src/Avalonia.Themes.Fluent/Controls/RadioButton.xaml:
`<Style Selector="^:disabled /template/ Ellipse#CheckGlyph">
<Setter Prop... | Fix radio button disabled fill and stroke brushes | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
The stroke and fill brushes for disabled RadioButton in the FluentTheme was swapped for years. This PR fixes it.
## What is the current behavior?
<!--- If the PR is a fix, describe the current incorrect beh... | e008beb28730856577d337ef4bc671e7d6abff3f | 6dba50958f884b08af711cf88004b2ea01ed9faa | diff --git a/src/Avalonia.Themes.Fluent/Controls/RadioButton.xaml b/src/Avalonia.Themes.Fluent/Controls/RadioButton.xaml
index 07ab1d39503..e1609f5cc3d 100644
--- a/src/Avalonia.Themes.Fluent/Controls/RadioButton.xaml
+++ b/src/Avalonia.Themes.Fluent/Controls/RadioButton.xaml
@@ -154,8 +154,8 @@
</Style>
<S... | [
"src/Avalonia.Themes.Fluent/Controls/RadioButton.xaml"
] | [] | true | |
AvaloniaUI/Avalonia | 21,493 | issue_to_patch | ComboBox placeholder text has incorrect appearance due to missing Opacity styling in Fluent theme
### Describe the bug
When ComboBox.PlaceholderText is displayed, it appears with full opacity (matching the default text color, e.g., solid black) instead of the expected semi-transparent/dimmed appearance seen in TextBo... | Fix - Apply placeholder opacity to combobox placeholder textblock | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Applies placeholder opacity to ComboBox's placeholder textblock in themes
## What is the current behavior?
<!--- If the PR is a fix, describe the current incorrect behavior, otherwise delete this section. -... | f657547b8d6916d979968c4ed885f8aefda7e5be | 2e06d5c3b4c344d72796dd895fe697c11b875b7b | diff --git a/src/Avalonia.Themes.Fluent/Controls/ComboBox.xaml b/src/Avalonia.Themes.Fluent/Controls/ComboBox.xaml
index d9ce9271533..4d830499281 100644
--- a/src/Avalonia.Themes.Fluent/Controls/ComboBox.xaml
+++ b/src/Avalonia.Themes.Fluent/Controls/ComboBox.xaml
@@ -98,6 +98,7 @@
Grid.Column="... | [
"src/Avalonia.Themes.Fluent/Controls/ComboBox.xaml",
"src/Avalonia.Themes.Simple/Controls/ComboBox.xaml"
] | [] | true | |
AvaloniaUI/Avalonia | 21,490 | issue_to_patch | NotificationCard updates pseudo classes additively when NotificationType changes
### Describe the bug
https://github.com/AvaloniaUI/Avalonia/blob/master/src/Avalonia.Controls/Notifications/NotificationCard.cs#L171-L191
```
private void UpdateNotificationType()
{
switch (NotificationType)
... | Fix NotificationCard pseudo class state when NotificationType changes | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
fix https://github.com/AvaloniaUI/Avalonia/issues/21489
## What is the current behavior?
Previous pseudo classes remain applied, causing stale visual states.
## What is the updated/expected behavior wi... | 5ad8b75427a73721be3b6ed5c11e6aff0d7bad21 | 2570ebc3702974aa720bd0ed78c956564dc29f54 | diff --git a/src/Avalonia.Controls/Notifications/NotificationCard.cs b/src/Avalonia.Controls/Notifications/NotificationCard.cs
index 69f568f9f62..5805adb28e4 100644
--- a/src/Avalonia.Controls/Notifications/NotificationCard.cs
+++ b/src/Avalonia.Controls/Notifications/NotificationCard.cs
@@ -170,24 +170,10 @@ protected... | [
"src/Avalonia.Controls/Notifications/NotificationCard.cs",
"tests/Avalonia.Controls.UnitTests/NotificationsTests.cs"
] | [] | diff --git a/tests/Avalonia.Controls.UnitTests/NotificationsTests.cs b/tests/Avalonia.Controls.UnitTests/NotificationsTests.cs
index e8411f7da17..22e8edad829 100644
--- a/tests/Avalonia.Controls.UnitTests/NotificationsTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/NotificationsTests.cs
@@ -113,4 +113,35 @@ public voi... | true |
AvaloniaUI/Avalonia | 21,449 | issue_to_patch | GetItemsAsync 'NotFoundError' exception when upgrading WebAssembly to Avalonia 12
### Describe the bug
With Avalonia 11.3, this worked fine, but after upgrading to 12, GetItemsAsync fails. See the DEBUG section in the method below:
```
public static async Task<IStorageFolder> GetUserSelectedFolder(string title, IBro... | Fixes WASM browser file picker crashing while listing entries of folders | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Pins the version for wasm native file system dependency, avoiding the crash that can occur on Chromium browsers when listing entries in a StorageFolderItem.
## What is the current behavior?
<!--- If the PR ... | f657547b8d6916d979968c4ed885f8aefda7e5be | 997fae1100b30af92061da25d4228a120f84523f | diff --git a/src/Browser/Avalonia.Browser/webapp/bun.lock b/src/Browser/Avalonia.Browser/webapp/bun.lock
index 13c49e05acd..8da488ff450 100644
--- a/src/Browser/Avalonia.Browser/webapp/bun.lock
+++ b/src/Browser/Avalonia.Browser/webapp/bun.lock
@@ -5,7 +5,7 @@
"": {
"name": "avalonia.browser",
"depen... | [
"src/Browser/Avalonia.Browser/webapp/bun.lock",
"src/Browser/Avalonia.Browser/webapp/package.json"
] | [] | true | |
AvaloniaUI/Avalonia | 21,486 | issue_to_patch | Fix Firefox drag-and-drop: handle effectAllowed = "uninitialized" | # Fix Firefox drag-and-drop: handle `effectAllowed = "uninitialized"`
## Summary
Drag and drop from external sources (e.g. files from the OS file manager) was broken in Firefox when targeting a browser-hosted Avalonia application.
## Root Cause
Firefox sends `effectAllowed = "uninitialized"` on `dragenter` ... | 5ad8b75427a73721be3b6ed5c11e6aff0d7bad21 | b0801aba10dca7dbc43c9c3946f4a567799a37ad | diff --git a/src/Browser/Avalonia.Browser/BrowserInputHandler.cs b/src/Browser/Avalonia.Browser/BrowserInputHandler.cs
index 40e7a3da570..ba97ad07a2f 100644
--- a/src/Browser/Avalonia.Browser/BrowserInputHandler.cs
+++ b/src/Browser/Avalonia.Browser/BrowserInputHandler.cs
@@ -208,7 +208,8 @@ public bool OnDragEvent(str... | [
"src/Browser/Avalonia.Browser/BrowserInputHandler.cs"
] | [] | true | ||
AvaloniaUI/Avalonia | 21,480 | issue_to_patch | [v12.0.4] TextBox ignores SelectionForegroundBrush property
### Describe the bug
Starting from v12.0.4, TextBox ignores its SelectionForegroundBrush property value.
### To Reproduce
1. Create a new Avalonia desktop application.
2. Add TextBox control to a window:
```
<TextBox Text="edit me" SelectionBrush="Yellow... | Fix text selection brush not applying when text selection changes | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
This pr invalidates the text run cache in TextLayout when selection changes. This changes the behavior from only invalidating the text layout while keeping the cache. This ensures that selection styles are applie... | 5ad8b75427a73721be3b6ed5c11e6aff0d7bad21 | b38d61b8f410399e7baa330176c016fd475e393c | diff --git a/src/Avalonia.Controls/Presenters/TextPresenter.cs b/src/Avalonia.Controls/Presenters/TextPresenter.cs
index 598ce4905cc..6e6ab17853a 100644
--- a/src/Avalonia.Controls/Presenters/TextPresenter.cs
+++ b/src/Avalonia.Controls/Presenters/TextPresenter.cs
@@ -58,7 +58,7 @@ public class TextPresenter : Control
... | [
"src/Avalonia.Controls/Presenters/TextPresenter.cs"
] | [] | true | |
AvaloniaUI/Avalonia | 21,474 | issue_to_patch | fix typo in key assignment for reference assembly | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
- fixes typo in `XamlCompilerTaskExecutor.cs`. since `refAsm.Write` uses `refWriterParameters`, this appears to be a copy-paste bug
## Checklist
- [ ] Added unit tests (if possible)?
- [ ] Added XML docume... | 9d4c952ab04211d45492290780aae80dc88ecb53 | 588b2c235d6d2c741c567896494a138681738a7b | diff --git a/src/Avalonia.Build.Tasks/XamlCompilerTaskExecutor.cs b/src/Avalonia.Build.Tasks/XamlCompilerTaskExecutor.cs
index a8b0efa342b..acf90179b1e 100644
--- a/src/Avalonia.Build.Tasks/XamlCompilerTaskExecutor.cs
+++ b/src/Avalonia.Build.Tasks/XamlCompilerTaskExecutor.cs
@@ -89,7 +89,7 @@ internal static CompileRe... | [
"src/Avalonia.Build.Tasks/XamlCompilerTaskExecutor.cs"
] | [] | true | ||
AvaloniaUI/Avalonia | 21,435 | issue_to_patch | [Text] Fixes culture aware font matching | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Makes per-codepoint font fallback in `FontCollectionBase` **deterministic, coverage-checked, and culture-aware**, and brings the script/codepoint side of the pipeline in line with ICU, HarfBuzz, DirectWrite, an... | f1aa820986e622fc5aaad8a51e81601bd49f9f74 | f9988d55f275d057786f5bff695c2f8d09b01b90 | diff --git a/src/Avalonia.Base/Media/Fonts/Bcp47ScriptResolver.cs b/src/Avalonia.Base/Media/Fonts/Bcp47ScriptResolver.cs
new file mode 100644
index 00000000000..6fcf23ab5bd
--- /dev/null
+++ b/src/Avalonia.Base/Media/Fonts/Bcp47ScriptResolver.cs
@@ -0,0 +1,203 @@
+using System;
+using System.Globalization;
+
+namespace... | [
"src/Avalonia.Base/Media/Fonts/Bcp47ScriptResolver.cs",
"src/Avalonia.Base/Media/Fonts/FontCodePageCoverage.cs",
"src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs",
"src/Avalonia.Base/Media/Fonts/FontCollectionKey.cs",
"src/Avalonia.Base/Media/Fonts/FontFallbackScriptHints.cs",
"src/Avalonia.Base/Media... | [
{
"comment": "Why `/ 12`? A data map record is 8 bytes, and the 16 bytes of the header should be taken into account.",
"path": "src/Avalonia.Base/Media/Fonts/Tables/MetaTable.cs",
"hunk": "@@ -0,0 +1,145 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Text;\n+\n+namespace Avalonia.... | diff --git a/tests/Avalonia.Base.UnitTests/Media/Fonts/Bcp47ScriptResolverTests.cs b/tests/Avalonia.Base.UnitTests/Media/Fonts/Bcp47ScriptResolverTests.cs
new file mode 100644
index 00000000000..da7b3070ac3
--- /dev/null
+++ b/tests/Avalonia.Base.UnitTests/Media/Fonts/Bcp47ScriptResolverTests.cs
@@ -0,0 +1,61 @@
+using... | true | |
AvaloniaUI/Avalonia | 21,435 | comment_to_fix | [Text] Fixes culture aware font matching | Why `/ 12`? A data map record is 8 bytes, and the 16 bytes of the header should be taken into account. | f1aa820986e622fc5aaad8a51e81601bd49f9f74 | f9988d55f275d057786f5bff695c2f8d09b01b90 | diff --git a/src/Avalonia.Base/Media/Fonts/Tables/MetaTable.cs b/src/Avalonia.Base/Media/Fonts/Tables/MetaTable.cs
new file mode 100644
index 00000000000..3acf713f0c9
--- /dev/null
+++ b/src/Avalonia.Base/Media/Fonts/Tables/MetaTable.cs
@@ -0,0 +1,154 @@
+using System;
+using System.Collections.Generic;
+using System.T... | [
"src/Avalonia.Base/Media/Fonts/Tables/MetaTable.cs"
] | [
{
"comment": "Why `/ 12`? A data map record is 8 bytes, and the 16 bytes of the header should be taken into account.",
"path": "src/Avalonia.Base/Media/Fonts/Tables/MetaTable.cs",
"hunk": "@@ -0,0 +1,145 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Text;\n+\n+namespace Avalonia.... | true | ||
AvaloniaUI/Avalonia | 21,435 | comment_to_fix | [Text] Fixes culture aware font matching | This loop can be replaced with `text.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries)` | f1aa820986e622fc5aaad8a51e81601bd49f9f74 | f9988d55f275d057786f5bff695c2f8d09b01b90 | diff --git a/src/Avalonia.Base/Media/Fonts/Tables/MetaTable.cs b/src/Avalonia.Base/Media/Fonts/Tables/MetaTable.cs
new file mode 100644
index 00000000000..3acf713f0c9
--- /dev/null
+++ b/src/Avalonia.Base/Media/Fonts/Tables/MetaTable.cs
@@ -0,0 +1,154 @@
+using System;
+using System.Collections.Generic;
+using System.T... | [
"src/Avalonia.Base/Media/Fonts/Tables/MetaTable.cs"
] | [
{
"comment": "This loop can be replaced with `text.Split(',', StringSplitOptions.RemoveEmptyEntries | StringSplitOptions.TrimEntries)`",
"path": "src/Avalonia.Base/Media/Fonts/Tables/MetaTable.cs",
"hunk": "@@ -0,0 +1,145 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Text;\n+\n+n... | true | ||
AvaloniaUI/Avalonia | 21,435 | comment_to_fix | [Text] Fixes culture aware font matching | Nit: replace with `Char.IsAsciiLetter`, which use fewer branches. | f1aa820986e622fc5aaad8a51e81601bd49f9f74 | f9988d55f275d057786f5bff695c2f8d09b01b90 | diff --git a/src/Avalonia.Base/Media/Fonts/Bcp47ScriptResolver.cs b/src/Avalonia.Base/Media/Fonts/Bcp47ScriptResolver.cs
new file mode 100644
index 00000000000..6fcf23ab5bd
--- /dev/null
+++ b/src/Avalonia.Base/Media/Fonts/Bcp47ScriptResolver.cs
@@ -0,0 +1,203 @@
+using System;
+using System.Globalization;
+
+namespace... | [
"src/Avalonia.Base/Media/Fonts/Bcp47ScriptResolver.cs"
] | [
{
"comment": "Nit: replace with `Char.IsAsciiLetter`, which use fewer branches.",
"path": "src/Avalonia.Base/Media/Fonts/Bcp47ScriptResolver.cs",
"hunk": "@@ -0,0 +1,203 @@\n+using System;\n+using System.Globalization;\n+\n+namespace Avalonia.Media.Fonts\n+{\n+ /// <summary>\n+ /// Resolves a BCP-... | true | ||
AvaloniaUI/Avalonia | 21,435 | comment_to_fix | [Text] Fixes culture aware font matching | All callers are passing a `ConcurrentDictionary`, take that type directly to simply the method's code. | f1aa820986e622fc5aaad8a51e81601bd49f9f74 | f9988d55f275d057786f5bff695c2f8d09b01b90 | diff --git a/src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs b/src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs
index 6e4283d76e6..649c47f7309 100644
--- a/src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs
+++ b/src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs
@@ -5,7 +5,9 @@
using System.Diagnostics.CodeA... | [
"src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs"
] | [
{
"comment": "All callers are passing a `ConcurrentDictionary`, take that type directly to simply the method's code. ",
"path": "src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs",
"hunk": "@@ -41,55 +48,357 @@ public virtual bool TryMatchCharacter(int codepoint, FontStyle style, FontWeight\n ... | true | ||
AvaloniaUI/Avalonia | 21,435 | comment_to_fix | [Text] Fixes culture aware font matching | Replace this whole loop with `concurrent.Keys.ToArray()`: `Keys` is already a snapshot, as documented. | f1aa820986e622fc5aaad8a51e81601bd49f9f74 | f9988d55f275d057786f5bff695c2f8d09b01b90 | diff --git a/src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs b/src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs
index 6e4283d76e6..649c47f7309 100644
--- a/src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs
+++ b/src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs
@@ -5,7 +5,9 @@
using System.Diagnostics.CodeA... | [
"src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs"
] | [
{
"comment": "Replace this whole loop with `concurrent.Keys.ToArray()`: `Keys` is already a snapshot, as documented.",
"path": "src/Avalonia.Base/Media/Fonts/FontCollectionBase.cs",
"hunk": "@@ -41,55 +48,357 @@ public virtual bool TryMatchCharacter(int codepoint, FontStyle style, FontWeight\n ... | true | ||
AvaloniaUI/Avalonia | 21,435 | comment_to_fix | [Text] Fixes culture aware font matching | We can probably just generate a single `ReadOnlySpan<byte>` for this data, like we're doing with the unicode tries, so it gets embedded directly inside the assembly.
Keep another `ReadOnlySpan<int>` containing the offset + length for each row and the lookup becomes something like `Data.Slice(offsets[row], offsets[row ... | f1aa820986e622fc5aaad8a51e81601bd49f9f74 | f9988d55f275d057786f5bff695c2f8d09b01b90 | diff --git a/src/Avalonia.Base/Media/TextFormatting/Unicode/ScriptExtensions.data.cs b/src/Avalonia.Base/Media/TextFormatting/Unicode/ScriptExtensions.data.cs
new file mode 100644
index 00000000000..4b28446e576
--- /dev/null
+++ b/src/Avalonia.Base/Media/TextFormatting/Unicode/ScriptExtensions.data.cs
@@ -0,0 +1,195 @@... | [
"src/Avalonia.Base/Media/TextFormatting/Unicode/ScriptExtensions.data.cs"
] | [
{
"comment": "We can probably just generate a single `ReadOnlySpan<byte>` for this data, like we're doing with the unicode tries, so it gets embedded directly inside the assembly.\n\nKeep another `ReadOnlySpan<int>` containing the offset + length for each row and the lookup becomes something like `Data.Slice(of... | true | ||
AvaloniaUI/Avalonia | 21,435 | comment_to_fix | [Text] Fixes culture aware font matching | Use `set.AsSpan().Contains(target)`, which is optimized and vectorized. | f1aa820986e622fc5aaad8a51e81601bd49f9f74 | f9988d55f275d057786f5bff695c2f8d09b01b90 | diff --git a/src/Avalonia.Base/Media/TextFormatting/Unicode/UnicodeData.Lookups.cs b/src/Avalonia.Base/Media/TextFormatting/Unicode/UnicodeData.Lookups.cs
index 9323d30ad5b..7ba153935d0 100644
--- a/src/Avalonia.Base/Media/TextFormatting/Unicode/UnicodeData.Lookups.cs
+++ b/src/Avalonia.Base/Media/TextFormatting/Unicod... | [
"src/Avalonia.Base/Media/TextFormatting/Unicode/UnicodeData.Lookups.cs"
] | [
{
"comment": "Use `set.AsSpan().Contains(target)`, which is optimized and vectorized.",
"path": "src/Avalonia.Base/Media/TextFormatting/Unicode/UnicodeData.Lookups.cs",
"hunk": "@@ -113,5 +113,50 @@ public static EastAsianWidthClass GetEastAsianWidthClass(uint codepoint)\n {\n return... | true | ||
AvaloniaUI/Avalonia | 21,337 | issue_to_patch | 'GetPointerDeviceRects' is not available on Proton
### Describe the bug
.NET 10 Avalonia AOT **windows** built running through Proton 9 on Steamdeck, I get an exception when I click on the window close button:
```
System.EntryPointNotFoundException: Unable to find an entry point named 'GetPointerDeviceRects' in
nati... | Win32: fall back to pixel location when GetPointerDeviceRects is unavailable | ## What does the pull request do?
Adds a one-time probe for `user32.dll!GetPointerDeviceRects` and falls back to
`POINTER_INFO.ptPixelLocation` when the export is missing. This stops Avalonia
from crashing on the **first WM_POINTER message** under Wine/Proton, where that
WM_POINTER ancillary API has never been im... | fceaa72f1ee914a0cc5aa3124390546d421be6ff | 5994ca95578ec861526c75d770e2240c22790aa4 | diff --git a/src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs b/src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs
index d9be50a9678..798affd3377 100644
--- a/src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs
+++ b/src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs
@@ -1363,14 +1363,34 @@ private void UpdateInpu... | [
"src/Windows/Avalonia.Win32/WindowImpl.AppWndProc.cs"
] | [] | true | |
AvaloniaUI/Avalonia | 20,790 | issue_to_patch | PushEffect on DrawingContext
### Is your feature request related to a problem? Please describe.
Currently, I’m not sure if the order of operations in Avalonia allows me to do this correctly. My attempt looks like this:
```
public override void Render(DrawingContext ctx)
{
double outlineThickness;
if (S... | Fix RenderTargetBitmap looses effects | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
<!--- Give a bit of background on the PR here, together with links to with related issues etc. -->
RTB currently does not render effects such as `BoxShadow`. This is caused by immediate renderer which has no API... | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Media/DrawingContext.cs b/src/Avalonia.Base/Media/DrawingContext.cs
index df6e7d112b4..8003fb7c324 100644
--- a/src/Avalonia.Base/Media/DrawingContext.cs
+++ b/src/Avalonia.Base/Media/DrawingContext.cs
@@ -285,7 +285,8 @@ public enum PushedStateType
GeometryClip,
... | [
"src/Avalonia.Base/Media/DrawingContext.cs",
"src/Avalonia.Base/Media/DrawingGroup.cs",
"src/Avalonia.Base/Media/PlatformDrawingContext.cs",
"src/Avalonia.Base/Rendering/Composition/Drawing/Nodes/RenderDataNodes.cs",
"src/Avalonia.Base/Rendering/Composition/Drawing/RenderDataDrawingContext.cs",
"src/Avalo... | [
{
"comment": "`PushEffect` is using the visual's local `rect` as the layer bounds. For blur/drop-shadow this bounds rect needs to be inflated by `effect.GetEffectOutputPadding()`; otherwise the effect output will be clipped to the visual bounds (e.g., shadows disappearing/cut off in RenderTargetBitmap).\n```sug... | diff --git a/tests/Avalonia.Base.UnitTests/Media/DrawingGroupTests.cs b/tests/Avalonia.Base.UnitTests/Media/DrawingGroupTests.cs
new file mode 100644
index 00000000000..ccabf7303f5
--- /dev/null
+++ b/tests/Avalonia.Base.UnitTests/Media/DrawingGroupTests.cs
@@ -0,0 +1,156 @@
+using Avalonia.Media;
+using Avalonia.Platf... | true |
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | `PushEffect` is using the visual's local `rect` as the layer bounds. For blur/drop-shadow this bounds rect needs to be inflated by `effect.GetEffectOutputPadding()`; otherwise the effect output will be clipped to the visual bounds (e.g., shadows disappearing/cut off in RenderTargetBitmap).
```suggestion
using (... | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Rendering/ImmediateRenderer.cs b/src/Avalonia.Base/Rendering/ImmediateRenderer.cs
index f054e77db86..af53dd5bd0e 100644
--- a/src/Avalonia.Base/Rendering/ImmediateRenderer.cs
+++ b/src/Avalonia.Base/Rendering/ImmediateRenderer.cs
@@ -63,9 +63,11 @@ private static void Render(DrawingContex... | [
"src/Avalonia.Base/Rendering/ImmediateRenderer.cs"
] | [
{
"comment": "`PushEffect` is using the visual's local `rect` as the layer bounds. For blur/drop-shadow this bounds rect needs to be inflated by `effect.GetEffectOutputPadding()`; otherwise the effect output will be clipped to the visual bounds (e.g., shadows disappearing/cut off in RenderTargetBitmap).\n```sug... | true | ||
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | When applying `DrawingGroup.Effect`, the bounds passed to `PushEffect` should be expanded to include the effect output padding (e.g. `Effect.GetEffectOutputPadding()`), otherwise the effect result can be clipped to the drawing group's unpadded content bounds. | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Media/DrawingGroup.cs b/src/Avalonia.Base/Media/DrawingGroup.cs
index 75921196c02..b2181d74fb6 100644
--- a/src/Avalonia.Base/Media/DrawingGroup.cs
+++ b/src/Avalonia.Base/Media/DrawingGroup.cs
@@ -21,6 +21,12 @@ public sealed class DrawingGroup : Drawing
public static readonly S... | [
"src/Avalonia.Base/Media/DrawingGroup.cs"
] | [
{
"comment": "When applying `DrawingGroup.Effect`, the bounds passed to `PushEffect` should be expanded to include the effect output padding (e.g. `Effect.GetEffectOutputPadding()`), otherwise the effect result can be clipped to the drawing group's unpadded content bounds.",
"path": "src/Avalonia.Base/Media... | true | ||
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | `PushEffectCore(IEffect effect, Rect bounds)` ignores the `bounds` argument and only stores the effect. This makes `DrawingContext.PushEffect(..., bounds)` behave differently when recording into a `DrawingGroup` than when drawing to a platform context (and can cause incorrect clipping/size for effects). Consider persis... | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Media/DrawingGroup.cs b/src/Avalonia.Base/Media/DrawingGroup.cs
index 75921196c02..b2181d74fb6 100644
--- a/src/Avalonia.Base/Media/DrawingGroup.cs
+++ b/src/Avalonia.Base/Media/DrawingGroup.cs
@@ -21,6 +21,12 @@ public sealed class DrawingGroup : Drawing
public static readonly S... | [
"src/Avalonia.Base/Media/DrawingGroup.cs"
] | [
{
"comment": "`PushEffectCore(IEffect effect, Rect bounds)` ignores the `bounds` argument and only stores the effect. This makes `DrawingContext.PushEffect(..., bounds)` behave differently when recording into a `DrawingGroup` than when drawing to a platform context (and can cause incorrect clipping/size for eff... | true | ||
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | `PushEffectCore` records the `IEffect` instance into composition render data as-is. If callers pass a mutable `Effect` (e.g. `DropShadowEffect`, which is an `AvaloniaObject`), this can cross thread boundaries when the render data is replayed on the compositor/render thread, and it diverges from the visual pipeline whic... | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Rendering/Composition/Drawing/RenderDataDrawingContext.cs b/src/Avalonia.Base/Rendering/Composition/Drawing/RenderDataDrawingContext.cs
index ead6a3f7303..28370d71e1f 100644
--- a/src/Avalonia.Base/Rendering/Composition/Drawing/RenderDataDrawingContext.cs
+++ b/src/Avalonia.Base/Rendering... | [
"src/Avalonia.Base/Rendering/Composition/Drawing/RenderDataDrawingContext.cs"
] | [
{
"comment": "`PushEffectCore` records the `IEffect` instance into composition render data as-is. If callers pass a mutable `Effect` (e.g. `DropShadowEffect`, which is an `AvaloniaObject`), this can cross thread boundaries when the render data is replayed on the compositor/render thread, and it diverges from th... | true | ||
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | `effectBounds` is derived from `GetBounds()`, but `GetBounds()` already applies `Transform` (via `TransformToAABB`). Because `DrawCore` then does `PushTransform(Transform)` *before* `PushEffect`, the bounds passed to `PushEffect` end up being in the wrong coordinate space when `Transform` is non-identity (effect layer ... | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Media/DrawingGroup.cs b/src/Avalonia.Base/Media/DrawingGroup.cs
index 75921196c02..b2181d74fb6 100644
--- a/src/Avalonia.Base/Media/DrawingGroup.cs
+++ b/src/Avalonia.Base/Media/DrawingGroup.cs
@@ -21,6 +21,12 @@ public sealed class DrawingGroup : Drawing
public static readonly S... | [
"src/Avalonia.Base/Media/DrawingGroup.cs"
] | [
{
"comment": "`effectBounds` is derived from `GetBounds()`, but `GetBounds()` already applies `Transform` (via `TransformToAABB`). Because `DrawCore` then does `PushTransform(Transform)` *before* `PushEffect`, the bounds passed to `PushEffect` end up being in the wrong coordinate space when `Transform` is non-i... | true | ||
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | This new render test file isn't wrapped in `#if AVALONIA_SKIA` like the rest of `tests/Avalonia.RenderTests` (e.g., `Media/DrawingContextTests.cs`, `Media/BoxShadowTests.cs`). Without the conditional, this file can be compiled/executed in non-Skia build configurations where the render-test infrastructure and baselines ... | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/tests/Avalonia.RenderTests/Media/RenderTargetBitmapTests.cs b/tests/Avalonia.RenderTests/Media/RenderTargetBitmapTests.cs
new file mode 100644
index 00000000000..d213bde3b56
--- /dev/null
+++ b/tests/Avalonia.RenderTests/Media/RenderTargetBitmapTests.cs
@@ -0,0 +1,55 @@
+#if AVALONIA_SKIA
+using System.Thr... | [
"tests/Avalonia.RenderTests/Media/RenderTargetBitmapTests.cs"
] | [
{
"comment": "This new render test file isn't wrapped in `#if AVALONIA_SKIA` like the rest of `tests/Avalonia.RenderTests` (e.g., `Media/DrawingContextTests.cs`, `Media/BoxShadowTests.cs`). Without the conditional, this file can be compiled/executed in non-Skia build configurations where the render-test infrast... | true | ||
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | Nit: inline the effectPadding variable in the expression below, there's no need to compute it ahead of time for nothing if we already have `EffectBounds`. | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Media/DrawingGroup.cs b/src/Avalonia.Base/Media/DrawingGroup.cs
index 75921196c02..b2181d74fb6 100644
--- a/src/Avalonia.Base/Media/DrawingGroup.cs
+++ b/src/Avalonia.Base/Media/DrawingGroup.cs
@@ -21,6 +21,12 @@ public sealed class DrawingGroup : Drawing
public static readonly S... | [
"src/Avalonia.Base/Media/DrawingGroup.cs"
] | [
{
"comment": "Nit: inline the effectPadding variable in the expression below, there's no need to compute it ahead of time for nothing if we already have `EffectBounds`.",
"path": "src/Avalonia.Base/Media/DrawingGroup.cs",
"hunk": "@@ -73,13 +89,24 @@ public DrawingCollection Children\n \n intern... | true | ||
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | DrawingGroup now supports Effect/EffectBounds for rendering, but GetBounds() (and consequently any parent DrawingGroup localBounds calculation and DrawingImage default Viewbox/Size) still ignores the effect output padding / EffectBounds. This can under-report the drawing’s actual rendered extents, leading to shadows/bl... | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Media/DrawingGroup.cs b/src/Avalonia.Base/Media/DrawingGroup.cs
index 75921196c02..b2181d74fb6 100644
--- a/src/Avalonia.Base/Media/DrawingGroup.cs
+++ b/src/Avalonia.Base/Media/DrawingGroup.cs
@@ -21,6 +21,12 @@ public sealed class DrawingGroup : Drawing
public static readonly S... | [
"src/Avalonia.Base/Media/DrawingGroup.cs"
] | [
{
"comment": "DrawingGroup now supports Effect/EffectBounds for rendering, but GetBounds() (and consequently any parent DrawingGroup localBounds calculation and DrawingImage default Viewbox/Size) still ignores the effect output padding / EffectBounds. This can under-report the drawing’s actual rendered extents,... | true | ||
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | RenderDataEffectNode inherits RenderDataPushNode.Bounds (union of children bounds) without accounting for the effect’s expanded output region or the layer clip rect (BoundsRect). Because RenderData bounds are used to size scene brush content (e.g., DrawingBrush/RenderDataSceneBrushContent), this can under-estimate boun... | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Rendering/Composition/Drawing/Nodes/RenderDataNodes.cs b/src/Avalonia.Base/Rendering/Composition/Drawing/Nodes/RenderDataNodes.cs
index c7d10f69a13..52098411cd3 100644
--- a/src/Avalonia.Base/Rendering/Composition/Drawing/Nodes/RenderDataNodes.cs
+++ b/src/Avalonia.Base/Rendering/Composit... | [
"src/Avalonia.Base/Rendering/Composition/Drawing/Nodes/RenderDataNodes.cs"
] | [
{
"comment": "RenderDataEffectNode inherits RenderDataPushNode.Bounds (union of children bounds) without accounting for the effect’s expanded output region or the layer clip rect (BoundsRect). Because RenderData bounds are used to size scene brush content (e.g., DrawingBrush/RenderDataSceneBrushContent), this c... | true | ||
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | `GetBounds()` inflates the group bounds whenever `Effect != null`, even when the group has no content (i.e., `rect` is the default/empty rect because `Children` are empty or all return empty bounds). Inflating an empty rect produces a non-empty bounds, which can make an empty `DrawingGroup` report visible bounds solely... | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Media/DrawingGroup.cs b/src/Avalonia.Base/Media/DrawingGroup.cs
index 75921196c02..b2181d74fb6 100644
--- a/src/Avalonia.Base/Media/DrawingGroup.cs
+++ b/src/Avalonia.Base/Media/DrawingGroup.cs
@@ -21,6 +21,12 @@ public sealed class DrawingGroup : Drawing
public static readonly S... | [
"src/Avalonia.Base/Media/DrawingGroup.cs"
] | [
{
"comment": "`GetBounds()` inflates the group bounds whenever `Effect != null`, even when the group has no content (i.e., `rect` is the default/empty rect because `Children` are empty or all return empty bounds). Inflating an empty rect produces a non-empty bounds, which can make an empty `DrawingGroup` report... | true | ||
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | The PushEffect XML docs describe the bounds parameter generically, but the platform API treats it as an effect clip/layer rect. Since callers typically need to include GetEffectOutputPadding() to avoid clipping (as ImmediateRenderer now does), consider clarifying in the docs that the bounds should cover the effect *out... | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Media/DrawingContext.cs b/src/Avalonia.Base/Media/DrawingContext.cs
index df6e7d112b4..8003fb7c324 100644
--- a/src/Avalonia.Base/Media/DrawingContext.cs
+++ b/src/Avalonia.Base/Media/DrawingContext.cs
@@ -285,7 +285,8 @@ public enum PushedStateType
GeometryClip,
... | [
"src/Avalonia.Base/Media/DrawingContext.cs"
] | [
{
"comment": "The PushEffect XML docs describe the bounds parameter generically, but the platform API treats it as an effect clip/layer rect. Since callers typically need to include GetEffectOutputPadding() to avoid clipping (as ImmediateRenderer now does), consider clarifying in the docs that the bounds should... | true | ||
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | DrawingGroup.DrawCore computes effectBounds (inflated for effect output padding) but still passes the uninflated localBounds to PushOpacityMask. This can cause the opacity mask to not apply to effect output that extends beyond localBounds (e.g., drop shadow around edges) and diverges from composition behavior where bou... | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Media/DrawingGroup.cs b/src/Avalonia.Base/Media/DrawingGroup.cs
index 75921196c02..b2181d74fb6 100644
--- a/src/Avalonia.Base/Media/DrawingGroup.cs
+++ b/src/Avalonia.Base/Media/DrawingGroup.cs
@@ -21,6 +21,12 @@ public sealed class DrawingGroup : Drawing
public static readonly S... | [
"src/Avalonia.Base/Media/DrawingGroup.cs"
] | [
{
"comment": "DrawingGroup.DrawCore computes effectBounds (inflated for effect output padding) but still passes the uninflated localBounds to PushOpacityMask. This can cause the opacity mask to not apply to effect output that extends beyond localBounds (e.g., drop shadow around edges) and diverges from composit... | true | ||
AvaloniaUI/Avalonia | 20,790 | comment_to_fix | Fix RenderTargetBitmap looses effects | `DrawCore` always iterates over `Children` to compute `localBounds`, even when `EffectBounds` is explicitly set and `localBounds` will be ignored. This adds avoidable per-render overhead for large `DrawingGroup`s. Consider computing `localBounds` only when `EffectBounds` is null (or factoring the unioning into a helper... | 46137bd4a51a3cbafd125627fcdb2e7ddc73756a | b562013ed4006f863bfd9df81544dca3459e679b | diff --git a/src/Avalonia.Base/Media/DrawingGroup.cs b/src/Avalonia.Base/Media/DrawingGroup.cs
index 75921196c02..b2181d74fb6 100644
--- a/src/Avalonia.Base/Media/DrawingGroup.cs
+++ b/src/Avalonia.Base/Media/DrawingGroup.cs
@@ -21,6 +21,12 @@ public sealed class DrawingGroup : Drawing
public static readonly S... | [
"src/Avalonia.Base/Media/DrawingGroup.cs"
] | [
{
"comment": "`DrawCore` always iterates over `Children` to compute `localBounds`, even when `EffectBounds` is explicitly set and `localBounds` will be ignored. This adds avoidable per-render overhead for large `DrawingGroup`s. Consider computing `localBounds` only when `EffectBounds` is null (or factoring the ... | true | ||
AvaloniaUI/Avalonia | 21,457 | issue_to_patch | Add macOS AX BringIntoView/AXScrollArea Role | This PR enables a11y clients to detect any peer that impements IScrollProvider as macOS scrollable areas, which enables us to bring items into view with a11y inspection tools. | 9d4c952ab04211d45492290780aae80dc88ecb53 | 45cc4992a86594ab3c5bdf2b8f6033e9d4602922 | diff --git a/native/Avalonia.Native/src/OSX/automation.mm b/native/Avalonia.Native/src/OSX/automation.mm
index 90c06e1ca4c..6fd2cb6218f 100644
--- a/native/Avalonia.Native/src/OSX/automation.mm
+++ b/native/Avalonia.Native/src/OSX/automation.mm
@@ -86,7 +86,7 @@ - (BOOL)isAccessibilityElement
- (NSAccessibilityRole)ac... | [
"native/Avalonia.Native/src/OSX/automation.mm",
"src/Avalonia.Controls/Automation/Peers/AutomationPeer.cs",
"src/Avalonia.Controls/Automation/Peers/ScrollViewerAutomationPeer.cs",
"src/Avalonia.FreeDesktop.AtSpi/AtSpiNode.RoleMapping.cs",
"src/Avalonia.Native/AvnAutomationPeer.cs",
"src/Avalonia.Native/av... | [
{
"comment": "Forcing `NSAccessibilityScrollAreaRole` whenever the peer implements `IScrollProvider` will override the natural role for many controls that also implement this pattern. `ItemsControlAutomationPeer` (the base of `ListBoxAutomationPeer`, `TreeViewAutomationPeer`, `DataGridAutomationPeer`, etc.) imp... | true | ||
AvaloniaUI/Avalonia | 21,457 | comment_to_fix | Add macOS AX BringIntoView/AXScrollArea Role | Forcing `NSAccessibilityScrollAreaRole` whenever the peer implements `IScrollProvider` will override the natural role for many controls that also implement this pattern. `ItemsControlAutomationPeer` (the base of `ListBoxAutomationPeer`, `TreeViewAutomationPeer`, `DataGridAutomationPeer`, etc.) implements `IScrollProvid... | 9d4c952ab04211d45492290780aae80dc88ecb53 | 45cc4992a86594ab3c5bdf2b8f6033e9d4602922 | diff --git a/native/Avalonia.Native/src/OSX/automation.mm b/native/Avalonia.Native/src/OSX/automation.mm
index 90c06e1ca4c..6fd2cb6218f 100644
--- a/native/Avalonia.Native/src/OSX/automation.mm
+++ b/native/Avalonia.Native/src/OSX/automation.mm
@@ -86,7 +86,7 @@ - (BOOL)isAccessibilityElement
- (NSAccessibilityRole)ac... | [
"native/Avalonia.Native/src/OSX/automation.mm"
] | [
{
"comment": "Forcing `NSAccessibilityScrollAreaRole` whenever the peer implements `IScrollProvider` will override the natural role for many controls that also implement this pattern. `ItemsControlAutomationPeer` (the base of `ListBoxAutomationPeer`, `TreeViewAutomationPeer`, `DataGridAutomationPeer`, etc.) imp... | true | ||
AvaloniaUI/Avalonia | 21,354 | issue_to_patch | [v12] [Regression] `ExtendClientAreaToDecorationsHint` Breaks Transparency/Acrylic Blur/Mica Due To `WindowDrawnDecorations`
### Describe the bug
In v12, ` TransparencyLevelHint="Transparent"`, does not seem to make the window transparent and instead produces a black background. AcrylicBlur, Blur, Mica seem to also r... | fix: set WindowDrawnDecorations background to transparent | ## What does the pull request do?
Fixes a [regression](https://github.com/AvaloniaUI/Avalonia/issues/21082) where `WindowDrawnDecorations` used an opaque background, blocking transparency effects (Mica/Acrylic/Blur) when `ExtendClientAreaToDecorationsHint` is enabled.
## What is the current behavior?
`WindowDrawnD... | 593b5a2ff5eeaf61ce4bdb61c7f65b04135a887d | cf20c4bb042824dad66f3711ad67fd3ff1376018 | diff --git a/src/Avalonia.Themes.Fluent/Controls/WindowDrawnDecorations.xaml b/src/Avalonia.Themes.Fluent/Controls/WindowDrawnDecorations.xaml
index 3ccda42ce31..d774ef8ef20 100644
--- a/src/Avalonia.Themes.Fluent/Controls/WindowDrawnDecorations.xaml
+++ b/src/Avalonia.Themes.Fluent/Controls/WindowDrawnDecorations.xaml... | [
"src/Avalonia.Themes.Fluent/Controls/WindowDrawnDecorations.xaml",
"src/Avalonia.Themes.Simple/Controls/WindowDrawnDecorations.xaml"
] | [] | true | |
AvaloniaUI/Avalonia | 21,412 | issue_to_patch | Windows 10 shows no border with Full/BorderOnly window decoration and ExtendClientAreaToDecorationHint=True
### Describe the bug
On Windows 10, a window border and shadow are not shown with the following configuration:
- `WindowsDecorations` = `BorderOnly` or `Full`
- `ExtendClientAreaToDecorationsHint` = `True`
On ... | Fix borders and shadows on Windows 10 in extended mode | ## What does the pull request do?
This PR fixes `ExtendClientAreaToDecorationsHint="True"` not displaying shadows and borders on Windows 10 correctly when `WindowDecorations` is `Full` or `BorderOnly`.
## What is the current behavior?
Borders and shadows, drawn by the OS, are missing when `ExtendClientAreaToDecora... | 75a6ff3a9784c7d0d454d5c7d176159a8d852884 | f50158102470c28bcfc1b4b80129e9517ea65c05 | diff --git a/src/Windows/Avalonia.Win32/WindowImpl.cs b/src/Windows/Avalonia.Win32/WindowImpl.cs
index adc9057c28f..9dd3f50643d 100644
--- a/src/Windows/Avalonia.Win32/WindowImpl.cs
+++ b/src/Windows/Avalonia.Win32/WindowImpl.cs
@@ -1204,19 +1204,12 @@ private void ExtendClientArea()
var margins = Upda... | [
"src/Windows/Avalonia.Win32/WindowImpl.cs"
] | [] | true | |
AvaloniaUI/Avalonia | 21,441 | issue_to_patch | ControlCatalog: improve transparent appearance | ## What does the pull request do?
This PR improves the ControlCatalog sample to be a bit nicer to look at when a transparency level is active.
## Example
On Windows, with `TransparencyLevel = AcrylicBlur` and `ExtendClientAreaToDecorationsHint = true`:
Before:
<img width="1026" height="832" alt="image" src="ht... | 42bba0b859cc27082b3db980ccca8c5e5b3534a9 | 191c404ee2581e0e4925d7dc78073b504a8da01f | diff --git a/Directory.Packages.props b/Directory.Packages.props
index bfb0a0d9c9f..7ef244b355a 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -7,7 +7,7 @@
<PackageVersion Include="Appium.WebDriver" Version="5.2.0" />
<PackageVersion Include="Avalonia.Angle.Windows.Natives" Version="2... | [
"Directory.Packages.props",
"samples/ControlCatalog/MainView.xaml",
"samples/ControlCatalog/MainView.xaml.cs",
"samples/ControlCatalog/MainWindow.xaml",
"samples/ControlCatalog/TransparentStyles.axaml",
"samples/ControlCatalog/TransparentStyles.axaml.cs"
] | [
{
"comment": "This StyleInclude can potentially be broken in AOT builds. Compiled XAML class might be trimmed, if it's not referenced statically.\n\n",
"path": "samples/ControlCatalog/MainView.xaml.cs",
"hunk": "@@ -12,7 +13,10 @@ namespace ControlCatalog\n {\n public partial class MainView : Drawer... | true | ||
AvaloniaUI/Avalonia | 21,452 | issue_to_patch | Remove dead code in AvaloniaObject. | ## What does the pull request do?
Removes some old dead code from `AvaloniaObject`:
No implementation of `BindingBase` implements `IObservable<T>` any more, so the `TryBindStyledPropertyUntyped` and `TryBindDirectPropertyUntyped` methods always returned null.
Remove them, and move the `IsReadOnly` check into a... | 1f8a9e7ada5432773d0d34c7959407d87794d235 | f645dae18a3e70530f5e2eeb901a3863d41b840f | diff --git a/src/Avalonia.Base/AvaloniaObject.cs b/src/Avalonia.Base/AvaloniaObject.cs
index 3ad488b615c..60ffc71c980 100644
--- a/src/Avalonia.Base/AvaloniaObject.cs
+++ b/src/Avalonia.Base/AvaloniaObject.cs
@@ -463,39 +463,12 @@ public IDisposable Bind<T>(
IObservable<object?> source,
Bindin... | [
"src/Avalonia.Base/AvaloniaObject.cs"
] | [] | true | ||
AvaloniaUI/Avalonia | 21,030 | issue_to_patch | Implement TextRunCache | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Introduces a `TextRunCache` that preserves shaped text runs and bidi processing results across `TextLayout` rebuilds. This avoids redundant HarfBuzz shaping and UAX#9 bidi processing when only the paragraph wid... | b7e95c2b0961c33f06a3a64846c4207fb406eada | a077fec6f30d9811f77feed2414768a9f006d460 | diff --git a/src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs b/src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs
index 71640fac085..4b5e4cad841 100644
--- a/src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs
+++ b/src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs
@@ -37,6 +37,11 @@ internal ShapedB... | [
"src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs",
"src/Avalonia.Base/Media/TextFormatting/TextFormatter.cs",
"src/Avalonia.Base/Media/TextFormatting/TextFormatterImpl.cs",
"src/Avalonia.Base/Media/TextFormatting/TextLayout.cs",
"src/Avalonia.Base/Media/TextFormatting/TextRunCache.cs",
"src/Avaloni... | [
{
"comment": "The vast majority of `TextBlock/TextBox` instances will only have a single entry with a `textSourceIndex == 0`. I think we should special case this to avoid allocating the dictionary and its array.",
"path": "src/Avalonia.Base/Media/TextFormatting/TextRunCache.cs",
"hunk": "@@ -0,0 +1,153 ... | diff --git a/tests/Avalonia.Benchmarks/Text/TextRunCacheBenchmark.cs b/tests/Avalonia.Benchmarks/Text/TextRunCacheBenchmark.cs
new file mode 100644
index 00000000000..650c9198473
--- /dev/null
+++ b/tests/Avalonia.Benchmarks/Text/TextRunCacheBenchmark.cs
@@ -0,0 +1,144 @@
+using System;
+using System.Linq;
+using Avalo... | true | |
AvaloniaUI/Avalonia | 21,030 | comment_to_fix | Implement TextRunCache | The vast majority of `TextBlock/TextBox` instances will only have a single entry with a `textSourceIndex == 0`. I think we should special case this to avoid allocating the dictionary and its array. | b7e95c2b0961c33f06a3a64846c4207fb406eada | a077fec6f30d9811f77feed2414768a9f006d460 | diff --git a/src/Avalonia.Base/Media/TextFormatting/TextRunCache.cs b/src/Avalonia.Base/Media/TextFormatting/TextRunCache.cs
new file mode 100644
index 00000000000..8dc21fa387e
--- /dev/null
+++ b/src/Avalonia.Base/Media/TextFormatting/TextRunCache.cs
@@ -0,0 +1,220 @@
+using System;
+using System.Buffers;
+using Syste... | [
"src/Avalonia.Base/Media/TextFormatting/TextRunCache.cs"
] | [
{
"comment": "The vast majority of `TextBlock/TextBox` instances will only have a single entry with a `textSourceIndex == 0`. I think we should special case this to avoid allocating the dictionary and its array.",
"path": "src/Avalonia.Base/Media/TextFormatting/TextRunCache.cs",
"hunk": "@@ -0,0 +1,153 ... | true | ||
AvaloniaUI/Avalonia | 21,030 | comment_to_fix | Implement TextRunCache | Do we really need this class (and all associated APIs) to be public right now? It looks like an implementation detail for optimization, and we might want to improve it in the future without locking the API.
Plus, the lifetime management (the cache outlives the text layout) makes it not easy for users to get right.
We... | b7e95c2b0961c33f06a3a64846c4207fb406eada | a077fec6f30d9811f77feed2414768a9f006d460 | diff --git a/src/Avalonia.Base/Media/TextFormatting/TextRunCache.cs b/src/Avalonia.Base/Media/TextFormatting/TextRunCache.cs
new file mode 100644
index 00000000000..8dc21fa387e
--- /dev/null
+++ b/src/Avalonia.Base/Media/TextFormatting/TextRunCache.cs
@@ -0,0 +1,220 @@
+using System;
+using System.Buffers;
+using Syste... | [
"src/Avalonia.Base/Media/TextFormatting/TextRunCache.cs"
] | [
{
"comment": "Do we really need this class (and all associated APIs) to be public right now? It looks like an implementation detail for optimization, and we might want to improve it in the future without locking the API.\n\nPlus, the lifetime management (the cache outlives the text layout) makes it not easy for... | true | ||
AvaloniaUI/Avalonia | 21,030 | comment_to_fix | Implement TextRunCache | Code reuse: consider extracting the `if/else` to a `CreateNonOwningRun` method. The resulting loop body should be `result[i] = CreateNonOwningRun(runs[i])`. Do the same in `CreateNonOwningRunsList`. | b7e95c2b0961c33f06a3a64846c4207fb406eada | a077fec6f30d9811f77feed2414768a9f006d460 | diff --git a/src/Avalonia.Base/Media/TextFormatting/TextFormatterImpl.cs b/src/Avalonia.Base/Media/TextFormatting/TextFormatterImpl.cs
index fb6777c659a..8af3470dd19 100644
--- a/src/Avalonia.Base/Media/TextFormatting/TextFormatterImpl.cs
+++ b/src/Avalonia.Base/Media/TextFormatting/TextFormatterImpl.cs
@@ -17,9 +17,18... | [
"src/Avalonia.Base/Media/TextFormatting/TextFormatterImpl.cs"
] | [
{
"comment": "Code reuse: consider extracting the `if/else` to a `CreateNonOwningRun` method. The resulting loop body should be `result[i] = CreateNonOwningRun(runs[i])`. Do the same in `CreateNonOwningRunsList`.",
"path": "src/Avalonia.Base/Media/TextFormatting/TextFormatterImpl.cs",
"hunk": "@@ -83,6 ... | true | ||
AvaloniaUI/Avalonia | 21,219 | issue_to_patch | Missing digital signatures on Windows native dependencies
### Describe the bug
On Windows, if Native AOT publishing an app, there are 3 DLL dependencies.
```
av_libglesv2.dll
libSkiaSharp.dll
libHarfBuzzSharp.dll
```
I notice that none of these 3 DLLs are digitally signed. In the past, Windows has never really enfo... | Bump ANGLE version + sign native binaries | ## What does the pull request do?
This PR bumps ours [google/angle fork](https://github.com/AvaloniaUI/angle) up to date. And adds code signing via azure trusted signing.
## Fixed issues
Closes https://github.com/AvaloniaUI/Avalonia/issues/20489
| 8f6467715249cee1eee871aaaae6643c3c921bf8 | 2b3843fc81143a9de9c787b73153a49789b10e43 | diff --git a/Directory.Packages.props b/Directory.Packages.props
index aea84387b27..e7d59ee139a 100644
--- a/Directory.Packages.props
+++ b/Directory.Packages.props
@@ -5,7 +5,7 @@
<ItemGroup>
<PackageVersion Include="Appium.WebDriver" Version="5.2.0" />
- <PackageVersion Include="Avalonia.Angle.Windows.Na... | [
"Directory.Packages.props"
] | [] | true | |
AvaloniaUI/Avalonia | 21,266 | issue_to_patch | Repeatedly cancelling save file picker dialogue freezes app
**Describe the bug**
When the action `toplevel.StorageProvider.SaveFilePickerAsync(options);` is invoked and cancel button is pressed and this process is repeated (5-7 times) it freezes the app
**To Reproduce**
Bind the action `toplevel.StorageProvider.S... | Win32: Run file picker on dedicated STA thread to avoid MTA deadlock | ## What does the pull request do?
Fixes a deadlock in the Win32 file/folder picker.
`Task.Factory.StartNew` ran the picker on an MTA thread-pool. Since `IFileDialog` is apartment-threaded, COM hosted it in the main STA (the UI thread) and proxied every call across apartments. If the UI thread had queued work from a... | 171d932b43282edeffd1255b028454bbafb72846 | 633ab31700b73325cc9154b723cc4807cfc4d53c | diff --git a/src/Windows/Avalonia.Win32/Win32StorageProvider.cs b/src/Windows/Avalonia.Win32/Win32StorageProvider.cs
index a61af0de972..6519933de71 100644
--- a/src/Windows/Avalonia.Win32/Win32StorageProvider.cs
+++ b/src/Windows/Avalonia.Win32/Win32StorageProvider.cs
@@ -3,6 +3,7 @@
using System.IO;
using System.Com... | [
"src/Windows/Avalonia.Win32/Win32StorageProvider.cs"
] | [] | true | |
AvaloniaUI/Avalonia | 21,283 | issue_to_patch | Update XML documentation to reflect correct type references in Avalonia.Controls project | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
<!--- Give a bit of background on the PR here, together with links to with related issues etc. -->
Fix type resolve issues in Avalonia.Controls xml documentations.
## What is the current behavior?
<!--- If ... | 8c3ddb105f3ac1c6129b393055fd917d944f7687 | 60e9bd6b6aceabd98c65d096102399e27bcf5bff | diff --git a/src/Avalonia.Controls/AutoCompleteBox/AutoCompleteBox.Properties.cs b/src/Avalonia.Controls/AutoCompleteBox/AutoCompleteBox.Properties.cs
index 1faa9b340e1..634daa767d1 100644
--- a/src/Avalonia.Controls/AutoCompleteBox/AutoCompleteBox.Properties.cs
+++ b/src/Avalonia.Controls/AutoCompleteBox/AutoCompleteB... | [
"src/Avalonia.Controls/AutoCompleteBox/AutoCompleteBox.Properties.cs",
"src/Avalonia.Controls/AutoCompleteBox/AutoCompleteBox.cs",
"src/Avalonia.Controls/Calendar/Calendar.cs",
"src/Avalonia.Controls/Calendar/CalendarButton.cs",
"src/Avalonia.Controls/Calendar/CalendarDateRange.cs",
"src/Avalonia.Controls... | [] | true | ||
AvaloniaUI/Avalonia | 21,293 | issue_to_patch | macOS MetalExternalObjectsFeature.DeviceLuid is not byte-reversed: LINQ Enumerable.Reverse shadows in-place reverse
### Describe the bug
MetalExternalObjectsFeature.DeviceLuid is supposed to be byte-equal to VkPhysicalDeviceVulkan11Properties.deviceLUID returned by MoltenVK. In Avalonia 12 it ends up byte-reversed.
... | Fix DeviceLuid byte ordering on MacOS GPU interop | Fixes #21291
<!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
<!--- Give a bit of background on the PR here, together with links to with related issues etc. -->
MetalExternalObjectsFeature.DeviceLuid is supposed to be byte-equal to VkPhysicalDeviceVulkan... | 0c9713d9a7ae2b2aea576533e076a838ef662340 | 84039ef0e93eebe6e36b6cbae59757a77a10c172 | diff --git a/src/Avalonia.Native/AvaloniaNativeGlPlatformGraphics.cs b/src/Avalonia.Native/AvaloniaNativeGlPlatformGraphics.cs
index 9efe33689f0..7e111735cf9 100644
--- a/src/Avalonia.Native/AvaloniaNativeGlPlatformGraphics.cs
+++ b/src/Avalonia.Native/AvaloniaNativeGlPlatformGraphics.cs
@@ -264,7 +264,7 @@ public unsa... | [
"src/Avalonia.Native/AvaloniaNativeGlPlatformGraphics.cs",
"src/Avalonia.Native/Metal.cs"
] | [] | true | |
AvaloniaUI/Avalonia | 21,301 | issue_to_patch | PointToScreen on null PlatformImpl causes exception
### Describe the bug
In Avalonia 11.3.7+: Popup PlatformImpl starts going null during popup lifetime (regression, issue [https://github.com/AvaloniaUI/Avalonia/issues/19892] Harmless — just a warning, clicks still work.
Avalonia 12 added ItemSelectionEventTriggers.... | Avoid exceptions when getting a position from a `PointerEventArgs` | #21294 identifies a case in which `PointerEventArgs.GetPosition` can throw. The bug report blames `ItemSelectionEventTriggers.IsPointerEventWithinBounds`, which is where the exception was observed. But the problem is more general than that.
## What is the current behaviour?
Inspecting the code of `GetPosition`,... | 550b57db3340857f1ddd883f7a71ea95c4faceac | d7b9983a6808b70547cd145316d16bb69b18e9fd | diff --git a/src/Avalonia.Base/Input/PointerEventArgs.cs b/src/Avalonia.Base/Input/PointerEventArgs.cs
index 9285e65fa55..ee1b54b7924 100644
--- a/src/Avalonia.Base/Input/PointerEventArgs.cs
+++ b/src/Avalonia.Base/Input/PointerEventArgs.cs
@@ -3,14 +3,14 @@
using Avalonia.Input.Raw;
using Avalonia.Interactivity;
us... | [
"src/Avalonia.Base/Input/PointerEventArgs.cs",
"src/Avalonia.Base/Rendering/IPresentationSource.cs",
"src/Avalonia.Base/VisualExtensions.cs",
"src/Avalonia.Controls/PresentationSource/PresentationSource.RenderRoot.cs",
"tests/Avalonia.Base.UnitTests/Input/MouseDeviceTests.cs",
"tests/Avalonia.RenderTests/... | [] | diff --git a/tests/Avalonia.Base.UnitTests/Input/MouseDeviceTests.cs b/tests/Avalonia.Base.UnitTests/Input/MouseDeviceTests.cs
index 1ec6ec2be5c..f8bb8c3ed29 100644
--- a/tests/Avalonia.Base.UnitTests/Input/MouseDeviceTests.cs
+++ b/tests/Avalonia.Base.UnitTests/Input/MouseDeviceTests.cs
@@ -1,4 +1,6 @@
-using Avaloni... | true |
AvaloniaUI/Avalonia | 21,307 | issue_to_patch | [Android] Implement IStorageItem.GetBasicPropertiesAsync for files
### Is your feature request related to a problem? Please describe.
On Android Avalonia Storage Provider does not support returning of Modified date for files.
Create file test in folder Documents.
Open folder documents via picker and get bookmark.
Ex... | [ ANDROID ] Fix File properties | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Fixes file properties returned on android for Files.
## What is the current behavior?
`MediaStore.IMediaColumns` values seems to no longer work. This may be due to the file provider not providing values fo... | 550b57db3340857f1ddd883f7a71ea95c4faceac | c02f0b18d24f41c4c22145bfcd0ea761cb219e62 | diff --git a/src/Android/Avalonia.Android/Platform/Storage/AndroidStorageItem.cs b/src/Android/Avalonia.Android/Platform/Storage/AndroidStorageItem.cs
index 2ee0236828d..a5ceb02312c 100644
--- a/src/Android/Avalonia.Android/Platform/Storage/AndroidStorageItem.cs
+++ b/src/Android/Avalonia.Android/Platform/Storage/Andro... | [
"src/Android/Avalonia.Android/Platform/Storage/AndroidStorageItem.cs"
] | [] | true | |
AvaloniaUI/Avalonia | 21,246 | issue_to_patch | Ensure system back event is passed to child page once | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
This PR changes the routing strategy for `PageNavigationSystemBackButtonPressedEvent`, and updates handlers for all current page types. Pages that host other pages will generate an event for that child page and r... | cf821c3f83cb388ebc5b67f9892cb643651231db | e07ec52a9b555c8117a242a9b72e1680f050200b | diff --git a/src/Avalonia.Controls/Page/CarouselPage.cs b/src/Avalonia.Controls/Page/CarouselPage.cs
index 22bee65871c..1cf67c603f8 100644
--- a/src/Avalonia.Controls/Page/CarouselPage.cs
+++ b/src/Avalonia.Controls/Page/CarouselPage.cs
@@ -55,6 +55,19 @@ static CarouselPage()
{
ItemsPanelProperty... | [
"src/Avalonia.Controls/Page/CarouselPage.cs",
"src/Avalonia.Controls/Page/DrawerPage.cs",
"src/Avalonia.Controls/Page/NavigationPage.cs",
"src/Avalonia.Controls/Page/Page.cs",
"src/Avalonia.Controls/Page/TabbedPage.cs",
"tests/Avalonia.Controls.UnitTests/CarouselPageTests.cs",
"tests/Avalonia.Controls.U... | [
{
"comment": "Changing PageNavigationSystemBackButtonPressedEvent to RoutingStrategies.Direct and removing the base Page class handler means OnSystemBackButtonPressed() will no longer be invoked for custom Page subclasses unless they add their own handler. This is a behavioral breaking change for anyone overrid... | diff --git a/tests/Avalonia.Controls.UnitTests/CarouselPageTests.cs b/tests/Avalonia.Controls.UnitTests/CarouselPageTests.cs
index d4ba06d6e24..138a2e7a3c4 100644
--- a/tests/Avalonia.Controls.UnitTests/CarouselPageTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/CarouselPageTests.cs
@@ -11,10 +11,11 @@
using Avalonia... | true | |
AvaloniaUI/Avalonia | 21,246 | comment_to_fix | Ensure system back event is passed to child page once | Changing PageNavigationSystemBackButtonPressedEvent to RoutingStrategies.Direct and removing the base Page class handler means OnSystemBackButtonPressed() will no longer be invoked for custom Page subclasses unless they add their own handler. This is a behavioral breaking change for anyone overriding OnSystemBackButton... | cf821c3f83cb388ebc5b67f9892cb643651231db | e07ec52a9b555c8117a242a9b72e1680f050200b | diff --git a/src/Avalonia.Controls/Page/Page.cs b/src/Avalonia.Controls/Page/Page.cs
index 4dcb84312d5..f40840caed8 100644
--- a/src/Avalonia.Controls/Page/Page.cs
+++ b/src/Avalonia.Controls/Page/Page.cs
@@ -62,7 +62,7 @@ public abstract class Page : TemplatedControl, IHeadered
public static readonly RoutedEv... | [
"src/Avalonia.Controls/Page/Page.cs"
] | [
{
"comment": "Changing PageNavigationSystemBackButtonPressedEvent to RoutingStrategies.Direct and removing the base Page class handler means OnSystemBackButtonPressed() will no longer be invoked for custom Page subclasses unless they add their own handler. This is a behavioral breaking change for anyone overrid... | true | ||
AvaloniaUI/Avalonia | 21,246 | comment_to_fix | Ensure system back event is passed to child page once | Minor formatting: this file consistently uses a space after `if` (e.g., `if (sender.IsOpen ...)` a few lines above), but this new code has `if(pageEvent.Handled)`. Please align with the existing formatting to keep diffs/style consistent.
```suggestion
if (pageEvent.Handled)
``` | cf821c3f83cb388ebc5b67f9892cb643651231db | e07ec52a9b555c8117a242a9b72e1680f050200b | diff --git a/src/Avalonia.Controls/Page/DrawerPage.cs b/src/Avalonia.Controls/Page/DrawerPage.cs
index 3494e3a069c..065a5df410b 100644
--- a/src/Avalonia.Controls/Page/DrawerPage.cs
+++ b/src/Avalonia.Controls/Page/DrawerPage.cs
@@ -295,6 +295,9 @@ static DrawerPage()
{
PageNavigationSystemBackBut... | [
"src/Avalonia.Controls/Page/DrawerPage.cs"
] | [
{
"comment": "Minor formatting: this file consistently uses a space after `if` (e.g., `if (sender.IsOpen ...)` a few lines above), but this new code has `if(pageEvent.Handled)`. Please align with the existing formatting to keep diffs/style consistent.\n```suggestion\n if (pageEvent.Handled)\n... | true | ||
AvaloniaUI/Avalonia | 21,246 | comment_to_fix | Ensure system back event is passed to child page once | This adds new system-back forwarding logic for TabbedPage (including propagation of Handled from CurrentPage), but there doesn’t appear to be any unit test coverage validating this behavior. Please add tests that (1) verify the event is forwarded to CurrentPage exactly once and (2) verify Handled is reflected back to t... | cf821c3f83cb388ebc5b67f9892cb643651231db | e07ec52a9b555c8117a242a9b72e1680f050200b | diff --git a/src/Avalonia.Controls/Page/TabbedPage.cs b/src/Avalonia.Controls/Page/TabbedPage.cs
index 89e926dc3ce..81e30819b73 100644
--- a/src/Avalonia.Controls/Page/TabbedPage.cs
+++ b/src/Avalonia.Controls/Page/TabbedPage.cs
@@ -9,6 +9,7 @@
using Avalonia.Controls.Templates;
using Avalonia.Input;
using Avalonia.... | [
"src/Avalonia.Controls/Page/TabbedPage.cs"
] | [
{
"comment": "This adds new system-back forwarding logic for TabbedPage (including propagation of Handled from CurrentPage), but there doesn’t appear to be any unit test coverage validating this behavior. Please add tests that (1) verify the event is forwarded to CurrentPage exactly once and (2) verify Handled ... | true | ||
AvaloniaUI/Avalonia | 21,246 | comment_to_fix | Ensure system back event is passed to child page once | This introduces system-back forwarding for CarouselPage, but there doesn’t appear to be any unit test coverage asserting that the back event is forwarded to CurrentPage and that Handled propagates correctly. Please add a focused test (e.g., with a child page overriding OnSystemBackButtonPressed) to ensure the forwardin... | cf821c3f83cb388ebc5b67f9892cb643651231db | e07ec52a9b555c8117a242a9b72e1680f050200b | diff --git a/src/Avalonia.Controls/Page/CarouselPage.cs b/src/Avalonia.Controls/Page/CarouselPage.cs
index 22bee65871c..1cf67c603f8 100644
--- a/src/Avalonia.Controls/Page/CarouselPage.cs
+++ b/src/Avalonia.Controls/Page/CarouselPage.cs
@@ -55,6 +55,19 @@ static CarouselPage()
{
ItemsPanelProperty... | [
"src/Avalonia.Controls/Page/CarouselPage.cs"
] | [
{
"comment": "This introduces system-back forwarding for CarouselPage, but there doesn’t appear to be any unit test coverage asserting that the back event is forwarded to CurrentPage and that Handled propagates correctly. Please add a focused test (e.g., with a child page overriding OnSystemBackButtonPressed) t... | true | ||
AvaloniaUI/Avalonia | 21,325 | issue_to_patch | Align Touch/Pen capture semantics with Mouse | ## What does the pull request do?
Removes `Capture(null)` from `Pointer.Disposable()`, expecting callers to call it explicitly with the appropriate source.
## What is the current behavior?
PenUp and TouchUp are treated as explicit capture loss, resulting in popups closed unexpectedly.
## What is the updated/exp... | dcb607179b707a6c0e41a39fc697af43c00abc48 | fb6e994d36c486331ac819a3880887deb582b8c0 | diff --git a/src/Avalonia.Base/Input/PenDevice.cs b/src/Avalonia.Base/Input/PenDevice.cs
index b3301ce6126..8780f5291a8 100644
--- a/src/Avalonia.Base/Input/PenDevice.cs
+++ b/src/Avalonia.Base/Input/PenDevice.cs
@@ -104,7 +104,7 @@ private bool PenDown(Pointer pointer, ulong timestamp,
if (source != nul... | [
"src/Avalonia.Base/Input/PenDevice.cs",
"src/Avalonia.Base/Input/Pointer.cs",
"src/Avalonia.Base/Input/TouchDevice.cs"
] | [] | true | ||
AvaloniaUI/Avalonia | 21,356 | issue_to_patch | RadioMenuItems cannot be grouped in MenuFlyout
### Describe the bug
<img width="1002" height="598" alt="Image" src="https://github.com/user-attachments/assets/b34d8b3b-30eb-4b6b-80d0-0aae02f6bb77" />
### To Reproduce
```
<Window.ContextFlyout>
<MenuFlyout>
<MenuItem GroupName="RadioableMenuItem"
... | fix(controls): fix radio MenuItem grouping in MenuFlyout | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
fix https://github.com/AvaloniaUI/Avalonia/issues/21355
## What is the current behavior?
<!--- If the PR is a fix, describe the current incorrect behavior, otherwise delete this section. -->
## What is... | 3011e52f175171e5a91675aaeac27ed9a915a43b | a94b2be2cf7f8eeff3bd2b4f459f7f845f3a9d7b | diff --git a/samples/ControlCatalog/Pages/ContextFlyoutPage.xaml b/samples/ControlCatalog/Pages/ContextFlyoutPage.xaml
index fa52c05bfae..afb823dd84e 100644
--- a/samples/ControlCatalog/Pages/ContextFlyoutPage.xaml
+++ b/samples/ControlCatalog/Pages/ContextFlyoutPage.xaml
@@ -54,6 +54,15 @@
I... | [
"samples/ControlCatalog/Pages/ContextFlyoutPage.xaml",
"samples/ControlCatalog/Pages/ContextMenuPage.xaml",
"src/Avalonia.Controls/MenuItem.cs",
"src/Avalonia.Controls/RadioButtonGroupManager.cs",
"tests/Avalonia.Controls.UnitTests/MenuItemTests.cs"
] | [] | diff --git a/tests/Avalonia.Controls.UnitTests/MenuItemTests.cs b/tests/Avalonia.Controls.UnitTests/MenuItemTests.cs
index c143f8db120..a159e6a9f2f 100644
--- a/tests/Avalonia.Controls.UnitTests/MenuItemTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/MenuItemTests.cs
@@ -560,6 +560,47 @@ public void Radio_MenuItem_In_... | true |
AvaloniaUI/Avalonia | 21,351 | issue_to_patch | [Text] Fixes double reorder of cached bidi runs | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
<!--- Give a bit of background on the PR here, together with links to with related issues etc. -->
Fix double reorder with cached bidi runs
When `TextRunCache` was enabled and a paragraph contained RTL text, ... | 3011e52f175171e5a91675aaeac27ed9a915a43b | 185356ea90722e5ccc74e5fd79678ccfda24eda5 | diff --git a/api/Avalonia.nupkg.xml b/api/Avalonia.nupkg.xml
new file mode 100644
index 00000000000..ac3e50889b5
--- /dev/null
+++ b/api/Avalonia.nupkg.xml
@@ -0,0 +1,28 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!-- https://learn.microsoft.com/dotnet/fundamentals/package-validation/diagnostic-ids -->
+<Suppressions ... | [
"api/Avalonia.nupkg.xml",
"src/Avalonia.Base/Media/TextFormatting/BidiReorderer.cs",
"src/Avalonia.Base/Media/TextFormatting/ShapedBuffer.cs",
"src/Avalonia.Base/Media/TextFormatting/ShapedTextRun.cs",
"src/Avalonia.Base/Media/TextFormatting/TextEllipsisHelper.cs",
"src/Avalonia.Base/Media/TextFormatting/... | [] | diff --git a/tests/Avalonia.Skia.UnitTests/Media/GlyphRunTests.cs b/tests/Avalonia.Skia.UnitTests/Media/GlyphRunTests.cs
index 8f74f0779fb..4aaaa9bf38d 100644
--- a/tests/Avalonia.Skia.UnitTests/Media/GlyphRunTests.cs
+++ b/tests/Avalonia.Skia.UnitTests/Media/GlyphRunTests.cs
@@ -455,19 +455,12 @@ private static List<R... | true | |
AvaloniaUI/Avalonia | 21,344 | issue_to_patch | Tmds.DBus.Protocol.DBusException: org.freedesktop.DBus.Error.ServiceUnknown: The name com.canonical.AppMenu.Registrar was not provided by any .service files
### Describe the bug
Intermittently, at an indeterminate time after successful startup and use, an Avalonia UI app running on Linux (Ubuntu 22.04 and/or 24.04), ... | Observe potential DBus exception in UnregisterWindowAsync | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Fix https://github.com/AvaloniaUI/Avalonia/issues/17616
## What is the current behavior?
`TaskScheduler.UnobservedTaskException` catch an unexpected execption: org.freedesktop.DBus.Error.ServiceUnknown
... | 3011e52f175171e5a91675aaeac27ed9a915a43b | 764e8148747a863f679195c78bb427bae5ea091c | diff --git a/src/Avalonia.FreeDesktop/DBusMenuExporter.cs b/src/Avalonia.FreeDesktop/DBusMenuExporter.cs
index 586f566e1c4..74e5157bc1d 100644
--- a/src/Avalonia.FreeDesktop/DBusMenuExporter.cs
+++ b/src/Avalonia.FreeDesktop/DBusMenuExporter.cs
@@ -10,6 +10,7 @@
using Avalonia.Input;
using Avalonia.Platform;
using A... | [
"src/Avalonia.FreeDesktop/DBusMenuExporter.cs"
] | [
{
"comment": "The `try-catch` block is unnecessary here.",
"path": "src/Avalonia.FreeDesktop/DBusMenuExporter.cs",
"hunk": "@@ -129,7 +130,20 @@ public void Dispose()\n return;\n _disposed = true;\n // Fire and forget\n- _ = _registrar?.... | true | |
AvaloniaUI/Avalonia | 21,344 | comment_to_fix | Observe potential DBus exception in UnregisterWindowAsync | The `try-catch` block is unnecessary here. | 3011e52f175171e5a91675aaeac27ed9a915a43b | 764e8148747a863f679195c78bb427bae5ea091c | diff --git a/src/Avalonia.FreeDesktop/DBusMenuExporter.cs b/src/Avalonia.FreeDesktop/DBusMenuExporter.cs
index 586f566e1c4..74e5157bc1d 100644
--- a/src/Avalonia.FreeDesktop/DBusMenuExporter.cs
+++ b/src/Avalonia.FreeDesktop/DBusMenuExporter.cs
@@ -10,6 +10,7 @@
using Avalonia.Input;
using Avalonia.Platform;
using A... | [
"src/Avalonia.FreeDesktop/DBusMenuExporter.cs"
] | [
{
"comment": "The `try-catch` block is unnecessary here.",
"path": "src/Avalonia.FreeDesktop/DBusMenuExporter.cs",
"hunk": "@@ -129,7 +130,20 @@ public void Dispose()\n return;\n _disposed = true;\n // Fire and forget\n- _ = _registrar?.... | true | ||
AvaloniaUI/Avalonia | 21,344 | comment_to_fix | Observe potential DBus exception in UnregisterWindowAsync | For structured logging to work properly, please use parameters while logging:
```suggestion
?.Log(this, "DBusMenu UnregisterWindowAsync failed: {Exception}", t.Exception);
``` | 3011e52f175171e5a91675aaeac27ed9a915a43b | 764e8148747a863f679195c78bb427bae5ea091c | diff --git a/src/Avalonia.FreeDesktop/DBusMenuExporter.cs b/src/Avalonia.FreeDesktop/DBusMenuExporter.cs
index 586f566e1c4..74e5157bc1d 100644
--- a/src/Avalonia.FreeDesktop/DBusMenuExporter.cs
+++ b/src/Avalonia.FreeDesktop/DBusMenuExporter.cs
@@ -10,6 +10,7 @@
using Avalonia.Input;
using Avalonia.Platform;
using A... | [
"src/Avalonia.FreeDesktop/DBusMenuExporter.cs"
] | [
{
"comment": "For structured logging to work properly, please use parameters while logging:\n\n```suggestion\n ?.Log(this, \"DBusMenu UnregisterWindowAsync failed: {Exception}\", t.Exception);\n```",
"path": "src/Avalonia.FreeDesktop/DBusMenuExporter.cs",
"hunk": "@@ -129,... | true | ||
AvaloniaUI/Avalonia | 21,320 | issue_to_patch | When NumericUpDown.TextConverter is changed, the displayed text doesn't refresh automatically.
### Is your feature request related to a problem? Please describe.
I need to update the displayed text of NumericUpDown based on user selection of currency. Right now I have to set the binded value to 0 and set again to int... | Make text in NumericUpDown update immediately when changing the TextC… | …onverter.
<!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
<!--- Give a bit of background on the PR here, together with links to with related issues etc. -->
Resolves https://github.com/AvaloniaUI/Avalonia/issues/21316
App needs to show the updated text i... | dcb607179b707a6c0e41a39fc697af43c00abc48 | 87e5467e5676986b82d8ea153cfd0c89a3cad4bd | diff --git a/src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs b/src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs
index 2f901860baf..073a2f109a7 100644
--- a/src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs
+++ b/src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs
@@ -605,7 +605,7 @@ protected virtual void ... | [
"src/Avalonia.Controls/NumericUpDown/NumericUpDown.cs",
"tests/Avalonia.Controls.UnitTests/NumericUpDownTests.cs"
] | [] | diff --git a/tests/Avalonia.Controls.UnitTests/NumericUpDownTests.cs b/tests/Avalonia.Controls.UnitTests/NumericUpDownTests.cs
index b1a402435d6..91aeb20b4c4 100644
--- a/tests/Avalonia.Controls.UnitTests/NumericUpDownTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/NumericUpDownTests.cs
@@ -3,8 +3,10 @@
using System.... | true |
AvaloniaUI/Avalonia | 21,357 | issue_to_patch | [v12] Headless Test Case Cleanup Failure with 'Cannot get KeyValueStorage on the idle test context'
### Describe the bug
After updating to Avalonia 12 and xUnit 3, I'm unable to run headless tests.
Tests that used to work fine in Avalonia 11 with xUnit2 now at some point "randomly" fail with:
```
[Test Case Cleanup... | Fix xUnit headless tests losing TestContext on background thread | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
Attempts to mitigate the intermittant xUnit exception seen when running Headless tests. See #21332 for discussions.
## What is the current behavior?
Running headless tests in a single test assembly period... | 06810f70a43f72a4309c2894f3908f57f421b312 | 48092708cafe55d16cde694c86d6f4972888fd1e | diff --git a/src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs b/src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs
index 0d48dd6919b..645812cefbb 100644
--- a/src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs
+++ b/src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs
@@ -54,19 +54,19 @@ pub... | [
"src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs"
] | [
{
"comment": "All other `Dispatch` overloads should be modified.\n\n@maxkatz6 Do you remember why we're explicitly passing `false` here? It was introduced in https://github.com/AvaloniaUI/Avalonia/pull/16157",
"path": "src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs",
"hunk": "@@ -66,7 +66,7 @... | true | |
AvaloniaUI/Avalonia | 21,357 | comment_to_fix | Fix xUnit headless tests losing TestContext on background thread | All other `Dispatch` overloads should be modified.
@maxkatz6 Do you remember why we're explicitly passing `false` here? It was introduced in https://github.com/AvaloniaUI/Avalonia/pull/16157 | 06810f70a43f72a4309c2894f3908f57f421b312 | 48092708cafe55d16cde694c86d6f4972888fd1e | diff --git a/src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs b/src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs
index 0d48dd6919b..645812cefbb 100644
--- a/src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs
+++ b/src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs
@@ -54,19 +54,19 @@ pub... | [
"src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs"
] | [
{
"comment": "All other `Dispatch` overloads should be modified.\n\n@maxkatz6 Do you remember why we're explicitly passing `false` here? It was introduced in https://github.com/AvaloniaUI/Avalonia/pull/16157",
"path": "src/Headless/Avalonia.Headless/HeadlessUnitTestSession.cs",
"hunk": "@@ -66,7 +66,7 @... | true | ||
AvaloniaUI/Avalonia | 21,269 | issue_to_patch | [Text] Make sure TryGetGlyphTypeface does not fail for concurrent access | <!--- See CONTRIBUTING.md for general guidelines on contributions -->
## What does the pull request do?
<!--- Give a bit of background on the PR here, together with links to with related issues etc. -->
Prevent FontManager.TryGetGlyphTypeface failures under concurrent access by making font collection retrieval/cre... | 3011e52f175171e5a91675aaeac27ed9a915a43b | 3652f1f1e0d9256469bebbb43e7838191ad85777 | diff --git a/.gitignore b/.gitignore
index 7b9a7c5a25c..8272eec0da9 100644
--- a/.gitignore
+++ b/.gitignore
@@ -221,3 +221,6 @@ src/Browser/Avalonia.Browser/wwwroot
api/diff
src/Browser/Avalonia.Browser/staticwebassets
.serena
+
+# Claude agent worktrees
+.claude/worktrees/
diff --git a/src/Avalonia.Base/Media/Font... | [
".gitignore",
"src/Avalonia.Base/Media/FontManager.cs",
"tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs",
"tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs"
] | [
{
"comment": "`ConcurrentDictionary<Uri, IFontCollection>` does not allow `null` values. Returning `null!` from the `GetOrAdd` valueFactory will cause `GetOrAdd` to throw (e.g., when `source` is a `fonts:` key that hasn’t been registered, or any other unsupported scheme). Consider handling unsupported schemes b... | diff --git a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs
index ed95773630f..d63f238dc16 100644
--- a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs
+++ b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs
@@ -1,4 +1,6 @@
using System;... | true | |
AvaloniaUI/Avalonia | 21,269 | comment_to_fix | [Text] Make sure TryGetGlyphTypeface does not fail for concurrent access | `ConcurrentDictionary<Uri, IFontCollection>` does not allow `null` values. Returning `null!` from the `GetOrAdd` valueFactory will cause `GetOrAdd` to throw (e.g., when `source` is a `fonts:` key that hasn’t been registered, or any other unsupported scheme). Consider handling unsupported schemes by returning `false` wi... | 3011e52f175171e5a91675aaeac27ed9a915a43b | 3652f1f1e0d9256469bebbb43e7838191ad85777 | diff --git a/src/Avalonia.Base/Media/FontManager.cs b/src/Avalonia.Base/Media/FontManager.cs
index 1f15820b9a6..60200dea851 100644
--- a/src/Avalonia.Base/Media/FontManager.cs
+++ b/src/Avalonia.Base/Media/FontManager.cs
@@ -351,36 +351,58 @@ internal IReadOnlyList<Typeface> GetFamilyTypefaces(FontFamily fontFamily)
... | [
"src/Avalonia.Base/Media/FontManager.cs"
] | [
{
"comment": "`ConcurrentDictionary<Uri, IFontCollection>` does not allow `null` values. Returning `null!` from the `GetOrAdd` valueFactory will cause `GetOrAdd` to throw (e.g., when `source` is a `fonts:` key that hasn’t been registered, or any other unsupported scheme). Consider handling unsupported schemes b... | true | ||
AvaloniaUI/Avalonia | 21,269 | comment_to_fix | [Text] Make sure TryGetGlyphTypeface does not fail for concurrent access | This test reaches into `FontManager` internals via reflection to clear the cache. Since `FontManager` already exposes `RemoveFontCollection(Uri key)`, using that API would make the test less brittle (field name/type changes won’t break it) and also aligns with production usage. | 3011e52f175171e5a91675aaeac27ed9a915a43b | 3652f1f1e0d9256469bebbb43e7838191ad85777 | diff --git a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs
index ed95773630f..d63f238dc16 100644
--- a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs
+++ b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs
@@ -1,4 +1,6 @@
using System;... | [
"tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs"
] | [
{
"comment": "This test reaches into `FontManager` internals via reflection to clear the cache. Since `FontManager` already exposes `RemoveFontCollection(Uri key)`, using that API would make the test less brittle (field name/type changes won’t break it) and also aligns with production usage.",
"path": "test... | true | ||
AvaloniaUI/Avalonia | 21,269 | comment_to_fix | [Text] Make sure TryGetGlyphTypeface does not fail for concurrent access | The removed `IFontCollection` instances are discarded without being disposed. Since `IFontCollection` implements `IDisposable`, repeatedly removing collections in a loop can leak resources (streams/handles/caches) during the test run. Capture the removed value and dispose it (or call `fontManager.RemoveFontCollection(c... | 3011e52f175171e5a91675aaeac27ed9a915a43b | 3652f1f1e0d9256469bebbb43e7838191ad85777 | diff --git a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs
index ed95773630f..d63f238dc16 100644
--- a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs
+++ b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs
@@ -1,4 +1,6 @@
using System;... | [
"tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs"
] | [
{
"comment": "The removed `IFontCollection` instances are discarded without being disposed. Since `IFontCollection` implements `IDisposable`, repeatedly removing collections in a loop can leak resources (streams/handles/caches) during the test run. Capture the removed value and dispose it (or call `fontManager.... | true | ||
AvaloniaUI/Avalonia | 21,269 | comment_to_fix | [Text] Make sure TryGetGlyphTypeface does not fail for concurrent access | Using ConcurrentDictionary.GetOrAdd with a valueFactory that creates an IDisposable (SystemFontCollection) can invoke the factory multiple times under contention; any “losing” instances won’t be disposed and can leak resources/memory. Consider switching to a TryGetValue/TryAdd loop that disposes the newly-created colle... | 3011e52f175171e5a91675aaeac27ed9a915a43b | 3652f1f1e0d9256469bebbb43e7838191ad85777 | diff --git a/src/Avalonia.Base/Media/FontManager.cs b/src/Avalonia.Base/Media/FontManager.cs
index 1f15820b9a6..60200dea851 100644
--- a/src/Avalonia.Base/Media/FontManager.cs
+++ b/src/Avalonia.Base/Media/FontManager.cs
@@ -351,36 +351,58 @@ internal IReadOnlyList<Typeface> GetFamilyTypefaces(FontFamily fontFamily)
... | [
"src/Avalonia.Base/Media/FontManager.cs"
] | [
{
"comment": "Using ConcurrentDictionary.GetOrAdd with a valueFactory that creates an IDisposable (SystemFontCollection) can invoke the factory multiple times under contention; any “losing” instances won’t be disposed and can leak resources/memory. Consider switching to a TryGetValue/TryAdd loop that disposes t... | true | ||
AvaloniaUI/Avalonia | 21,269 | comment_to_fix | [Text] Make sure TryGetGlyphTypeface does not fail for concurrent access | Same concern for EmbeddedFontCollection: GetOrAdd may call the factory multiple times concurrently for the same key, and any unused EmbeddedFontCollection instances won’t be disposed. Since these collections can hold font data/caches, please ensure the losing instance is disposed (e.g., TryAdd + dispose-on-fail) to avo... | 3011e52f175171e5a91675aaeac27ed9a915a43b | 3652f1f1e0d9256469bebbb43e7838191ad85777 | diff --git a/src/Avalonia.Base/Media/FontManager.cs b/src/Avalonia.Base/Media/FontManager.cs
index 1f15820b9a6..60200dea851 100644
--- a/src/Avalonia.Base/Media/FontManager.cs
+++ b/src/Avalonia.Base/Media/FontManager.cs
@@ -351,36 +351,58 @@ internal IReadOnlyList<Typeface> GetFamilyTypefaces(FontFamily fontFamily)
... | [
"src/Avalonia.Base/Media/FontManager.cs"
] | [
{
"comment": "Same concern for EmbeddedFontCollection: GetOrAdd may call the factory multiple times concurrently for the same key, and any unused EmbeddedFontCollection instances won’t be disposed. Since these collections can hold font data/caches, please ensure the losing instance is disposed (e.g., TryAdd + d... | true | ||
AvaloniaUI/Avalonia | 21,269 | comment_to_fix | [Text] Make sure TryGetGlyphTypeface does not fail for concurrent access | The added `using System.Collections.Concurrent;` and `using System.Reflection;` directives appear unused in this file and will generate warnings in analyzers/IDE. Please remove them.
| 3011e52f175171e5a91675aaeac27ed9a915a43b | 3652f1f1e0d9256469bebbb43e7838191ad85777 | diff --git a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs
index ed95773630f..d63f238dc16 100644
--- a/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs
+++ b/tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs
@@ -1,4 +1,6 @@
using System;... | [
"tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs"
] | [
{
"comment": "The added `using System.Collections.Concurrent;` and `using System.Reflection;` directives appear unused in this file and will generate warnings in analyzers/IDE. Please remove them.\n",
"path": "tests/Avalonia.Base.UnitTests/Media/FontManagerTests.cs",
"hunk": "@@ -1,4 +1,8 @@\n using Sy... | true | ||
AvaloniaUI/Avalonia | 21,269 | comment_to_fix | [Text] Make sure TryGetGlyphTypeface does not fail for concurrent access | The test names `TryGetFontCollection_UnknownScheme_*` are a bit misleading: the URIs used (`https://...` and `file://...`) have well-known schemes, they’re just unsupported by `FontManager.TryGetFontCollection`. Renaming these to `UnsupportedScheme_*` (or similar) would better reflect what’s being validated and avoid c... | 3011e52f175171e5a91675aaeac27ed9a915a43b | 3652f1f1e0d9256469bebbb43e7838191ad85777 | diff --git a/tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs b/tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs
new file mode 100644
index 00000000000..2f85f0b63fc
--- /dev/null
+++ b/tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs
@@ -0... | [
"tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs"
] | [
{
"comment": "The test names `TryGetFontCollection_UnknownScheme_*` are a bit misleading: the URIs used (`https://...` and `file://...`) have well-known schemes, they’re just unsupported by `FontManager.TryGetFontCollection`. Renaming these to `UnsupportedScheme_*` (or similar) would better reflect what’s being... | true | ||
AvaloniaUI/Avalonia | 21,269 | comment_to_fix | [Text] Make sure TryGetGlyphTypeface does not fail for concurrent access | This comment suggests testing “a different unknown URI sharing the same key”, but the test calls `TryGetFontCollection` twice with the same `source` value. Consider updating the comment to match the actual assertion (that repeated lookups don’t start returning true due to an accidentally cached null/entry).
| 3011e52f175171e5a91675aaeac27ed9a915a43b | 3652f1f1e0d9256469bebbb43e7838191ad85777 | diff --git a/tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs b/tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs
new file mode 100644
index 00000000000..2f85f0b63fc
--- /dev/null
+++ b/tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs
@@ -0... | [
"tests/Avalonia.Base.UnitTests/Media/FontManagerTryGetFontCollectionTests.cs"
] | [
{
"comment": "This comment suggests testing “a different unknown URI sharing the same key”, but the test calls `TryGetFontCollection` twice with the same `source` value. Consider updating the comment to match the actual assertion (that repeated lookups don’t start returning true due to an accidentally cached nu... | true | ||
AvaloniaUI/Avalonia | 21,248 | issue_to_patch | Shorthand DataContext binding breaks after using an itemtemplate
### Describe the bug
After using an ItemTemplate(at least for combobox which i was using) the shorthand datacontext method introduced in 11.3.0 breaks.
I'm talking about this:
```
<Button Content="Click Me"
Command="{Binding #ListBoxRoot.DataCo... | Fix #20625: fix compiled binding DataContext inference in ItemTemplate | The Sandbox repro failed with AVLN2100/AVLN2000 when compiled bindings were used with ItemTemplate and name-based DataContext access.
Root causes:
- No fallback DataContext type was inferred for the root object when x:DataType was absent.
- Name-scope lookup could capture stale DataContext metadata from an unrelat... | f47606ae9d4dd9b381000fc70118295103171faa | 30c64b920f32284a26e9bb6f521487c159f1e788 | diff --git a/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/XamlIlBindingPathHelper.cs b/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/XamlIlBindingPathHelper.cs
index b366e98856f..3bc9f0dd464 100644
--- a/src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/XamlIlBindingPathHelper.cs
+++ b/... | [
"src/Markup/Avalonia.Markup.Xaml.Loader/CompilerExtensions/XamlIlBindingPathHelper.cs",
"tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs"
] | [
{
"comment": "Please simplify those tests; we don't need a user control per test, nor commands.",
"path": "tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs",
"hunk": "@@ -555,4 +604,135 @@ public IEnumerable<MyType> MyProp\n }\n \n }\n+\n+ public class XamlIlCompiledBindin... | diff --git a/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs b/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs
index 9118378dbd1..e921ad54617 100644
--- a/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs
+++ b/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs
@@ -4,6 +4,7 @@
using Syst... | true |
AvaloniaUI/Avalonia | 21,248 | comment_to_fix | Fix #20625: fix compiled binding DataContext inference in ItemTemplate | Please simplify those tests; we don't need a user control per test, nor commands. | f47606ae9d4dd9b381000fc70118295103171faa | 30c64b920f32284a26e9bb6f521487c159f1e788 | diff --git a/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs b/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs
index 9118378dbd1..e921ad54617 100644
--- a/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs
+++ b/tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs
@@ -4,6 +4,7 @@
using Syst... | [
"tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs"
] | [
{
"comment": "Please simplify those tests; we don't need a user control per test, nor commands.",
"path": "tests/Avalonia.Markup.Xaml.UnitTests/Xaml/XamlIlTests.cs",
"hunk": "@@ -555,4 +604,135 @@ public IEnumerable<MyType> MyProp\n }\n \n }\n+\n+ public class XamlIlCompiledBindin... | true | ||
AvaloniaUI/Avalonia | 21,383 | issue_to_patch | Fixed popup positioning anchor rect bug with drawn window decorations | Popup's anchor rect needs to be computed against the true root visual and not against toplevel that could be offset by drawn decorations | 6fa084abf271532f6929ae7e4a00ed152b3722f4 | f23e33e2da1c5ee481fa0cb1233d312e7770f602 | diff --git a/src/Avalonia.Controls/Primitives/PopupPositioning/IPopupPositioner.cs b/src/Avalonia.Controls/Primitives/PopupPositioning/IPopupPositioner.cs
index ea38f7c7e3f..a962b13da69 100644
--- a/src/Avalonia.Controls/Primitives/PopupPositioning/IPopupPositioner.cs
+++ b/src/Avalonia.Controls/Primitives/PopupPositio... | [
"src/Avalonia.Controls/Primitives/PopupPositioning/IPopupPositioner.cs",
"tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs"
] | [] | diff --git a/tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs b/tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs
index a5133613bb9..ee051649cd3 100644
--- a/tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs
+++ b/tests/Avalonia.Controls.UnitTests/Primitives/PopupRootTests.cs
@@ ... | true | |
AykutSarac/jsoncrack.com | 578 | issue_to_patch | [BUG]: Theme Toggle Button is labeled incorrectly
### Issue description
When a browser user hovers over the Theme Toggle button, the title shows "Fullscreen" because that is what the title attribute is assigned. This is obviously not the intent.
### Media & Screenshots
<img width="839" height="143" alt="Image" src... | Correct title of Theme Toggle toolbar button | ## Issue
Closes #577
## What Changed
I was using the demo app and didn't immediately recognize the Sun icon, so I found the incorrect title confusing. I changed the title attribute to say "Light Mode" or "Dark Mode" using logic consistent with how the icon is selected.
## How to Test
Run the browser applicati... | c4e5902d5c7b77190b07dbb9da4325e988ad6abe | b49bed04fab6b1cd1d7731e737ea42d65a6fa154 | diff --git a/apps/www/src/features/editor/Toolbar/ThemeToggle.tsx b/apps/www/src/features/editor/Toolbar/ThemeToggle.tsx
index f3ce652526c..88102377d28 100644
--- a/apps/www/src/features/editor/Toolbar/ThemeToggle.tsx
+++ b/apps/www/src/features/editor/Toolbar/ThemeToggle.tsx
@@ -7,7 +7,10 @@ export const ThemeToggle =... | [
"apps/www/src/features/editor/Toolbar/ThemeToggle.tsx"
] | [] | true | |
AykutSarac/jsoncrack.com | 573 | issue_to_patch | feat: migrate to turborepo and separate canvas as package | * Create turborepo to manage apps and packages of jsoncrack
* Separated the diagram component under `packages/jsoncrack-react` to publish at npm and sync with vscode app
* Move VS Code app from separate repository to the monorepo | cc935eecbdefd1fd85a1161d343ccae83c68bfb1 | 7c196d43f51d7c617f965219f9c533d69e85860f | diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index 58183386c62..5bf915d83f4 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -32,7 +32,7 @@ jobs:
- uses: pnpm/action-setup@v4
name: Install pnpm
with:
- version: 10.10.0
+ ... | [
".github/workflows/deploy.yml",
".github/workflows/pull-request.yml",
".gitignore",
".npmrc",
".vscode/launch.json",
".vscode/tasks.json",
"README.md",
"apps/vscode/.env",
"apps/vscode/.eslintrc.json",
"apps/vscode/.gitignore",
"apps/vscode/.prettierignore",
"apps/vscode/.prettierrc",
"apps/... | [] | true | ||
AykutSarac/jsoncrack.com | 569 | issue_to_patch | Fix text editor options for paste json schema | Hi Aykut,
This problem that is observed for the spacing between lines in different types of json data, for which there have been reports, is actually related to the initial settings of the editor, which can be enabled by the `formatOnPaste: true` option.
Reference to the issue: https://github.com/AykutSarac/jsoncra... | 2eefe0569f2833d2a2c5e8cdaef8ecac2259a187 | 3160b73d884f0ec5face596c584319e135466b05 | diff --git a/src/features/editor/TextEditor.tsx b/src/features/editor/TextEditor.tsx
index 15263653240..dfccf3514fe 100644
--- a/src/features/editor/TextEditor.tsx
+++ b/src/features/editor/TextEditor.tsx
@@ -12,7 +12,6 @@ loader.config({
});
const editorOptions: EditorProps["options"] = {
- formatOnPaste: true,
... | [
"src/features/editor/TextEditor.tsx"
] | [] | true | ||
AykutSarac/jsoncrack.com | 572 | issue_to_patch | chore: Update outdated GitHub Actions versions | ## Issue
n/a
## What Changed
Updated multiple GitHub Actions to newer versions to improve compatibility and functionality.
## How to Test
Will be tested during CI.
## Evidence
**Screenshots**
- [ ] Before/after screenshots attached (for UI changes)
**Video**
- [ ] Screen recording of the feature i... | 076b963f4a7f7a76d21febbf3d5f6490cb0672ba | c0eb1e7253fa87c402dcd144a274203e14f8160f | diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index 8764241d15b..779c44627af 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -20,12 +20,12 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
- uses: actions/checkout@v4
+ uses:... | [
".github/workflows/deploy.yml",
".github/workflows/pull-request.yml",
"package.json",
"pnpm-lock.yaml"
] | [] | true | ||
AykutSarac/jsoncrack.com | 490 | issue_to_patch | feat: update diagram layout | This pull request introduces multiple updates across the project, focusing on enhancing configuration flexibility, improving the editor's UI/UX, and refactoring code for better maintainability. Key changes include updates to environment variables, UI components, and graph rendering logic.
### Configuration Updates:
... | 637edb86c04bba0d8a07eec50a0a7ff3a6cd487f | 82d74a92f3558a8b9975d3701f0225aac1ffcb5d | diff --git a/.env b/.env
index b6a491ecd3f..6a89b747e4d 100644
--- a/.env
+++ b/.env
@@ -1,2 +1,2 @@
-NEXT_PUBLIC_NODE_LIMIT=600
+NEXT_PUBLIC_NODE_LIMIT=800
NEXT_TELEMETRY_DISABLED=1
\ No newline at end of file
diff --git a/.env.development b/.env.development
index a13af9210c2..7d391f7b11b 100644
--- a/.env.developmen... | [
".env",
".env.development",
"README.md",
"public/assets/editor.webp",
"src/data/example.json",
"src/features/editor/BottomBar.tsx",
"src/features/editor/ExternalMode.tsx",
"src/features/editor/Toolbar/SearchInput.tsx",
"src/features/editor/Toolbar/index.tsx",
"src/features/editor/views/GraphView/C... | [] | true | ||
AykutSarac/jsoncrack.com | 478 | issue_to_patch | [BUG]: Crash on startup with Tree view
### Issue description
Steps to reproduce.
1. Open editor, (/editor)
2. Change View from Graph to Tree
3. Refresh Page.
Existing workarounds:
* Switch back to Graph mode after done with the tree mode.
* Clear Cache.
### Media & Screenshots
### Operating system
- OS: [e.g. ... | fix: Tree View Reload Crashes | This PR addresses the issue where reloading the page in Tree view causes the app to crash due to an null JSON string being parsed.
By ensuring that the zustand store always initializes with valid JSON (i.e., "{}"), we eliminate the risk of invalid JSON parsing in the Tree view component.
Before Fix:
https://gith... | 6c5a4f4db79f0b97ec90e8b5b206caacbdaeda64 | d824e05aa65167db9752d82a9d43d5d2ab3294af | diff --git a/src/store/useJson.ts b/src/store/useJson.ts
index 641bfdb859e..62512c79743 100644
--- a/src/store/useJson.ts
+++ b/src/store/useJson.ts
@@ -8,7 +8,7 @@ interface JsonActions {
}
const initialStates = {
- json: "",
+ json: "{}",
loading: true,
};
| [
"src/store/useJson.ts"
] | [] | true | |
AykutSarac/jsoncrack.com | 469 | issue_to_patch | fix: stick footer to bottom of the page | ## Fix footer positioning in converter tool pages
Previously, there was an empty space below the footer on the converter tool pages. I adjusted the layout to ensure that the pages take up the full available space, keeping the footer properly attached to the bottom.
Additionally, I noticed that these pages are... | d496738dff48a23743054b0bd8e0c84f9544d2b8 | c1b7c6d47e435baccaf5bd4fda2090cf20d4e773 | diff --git a/src/layout/PageLayout/Footer.tsx b/src/layout/PageLayout/Footer.tsx
index 360d1d6f145..88545bd22d1 100644
--- a/src/layout/PageLayout/Footer.tsx
+++ b/src/layout/PageLayout/Footer.tsx
@@ -8,7 +8,7 @@ import { JSONCrackLogo } from "../JsonCrackLogo";
export const Footer = () => {
return (
- <Contai... | [
"src/layout/PageLayout/Footer.tsx",
"src/layout/PageLayout/index.tsx"
] | [
{
"comment": "Good catch! I think just this change in the file is enough, current footer looks alright. The other change is causing a change in the alignment.\r\n\r\n<img width=\"1440\" alt=\"image\" src=\"https://github.com/user-attachments/assets/d6e52664-58da-4d52-9ee1-ff3ce0fcc325\" />\r\n",
"path": "sr... | true | ||
AykutSarac/jsoncrack.com | 469 | comment_to_fix | fix: stick footer to bottom of the page | Good catch! I think just this change in the file is enough, current footer looks alright. The other change is causing a change in the alignment.
<img width="1440" alt="image" src="https://github.com/user-attachments/assets/d6e52664-58da-4d52-9ee1-ff3ce0fcc325" />
| d496738dff48a23743054b0bd8e0c84f9544d2b8 | c1b7c6d47e435baccaf5bd4fda2090cf20d4e773 | diff --git a/src/layout/PageLayout/index.tsx b/src/layout/PageLayout/index.tsx
index 476e4b456ed..9d76b2d574f 100644
--- a/src/layout/PageLayout/index.tsx
+++ b/src/layout/PageLayout/index.tsx
@@ -12,6 +12,13 @@ const inter = Inter({
const StyledLayoutWrapper = styled.div`
background: #fff;
font-family: ${inter.... | [
"src/layout/PageLayout/index.tsx"
] | [
{
"comment": "Good catch! I think just this change in the file is enough, current footer looks alright. The other change is causing a change in the alignment.\r\n\r\n<img width=\"1440\" alt=\"image\" src=\"https://github.com/user-attachments/assets/d6e52664-58da-4d52-9ee1-ff3ce0fcc325\" />\r\n",
"path": "sr... | true | ||
AykutSarac/jsoncrack.com | 449 | issue_to_patch | Modify README.md | I think this project seems to recommend using pnpm rather than yarn to manage packages, so I removed `with yarn` from the README file. | 5a02cb8809d71d73b523b1598a3f1521fc1196da | 5b2d9a9c1380ce3aaae761664baf6aeb0d5b0adb | diff --git a/README.md b/README.md
index 4805514a351..b8818d1c3de 100644
--- a/README.md
+++ b/README.md
@@ -98,7 +98,7 @@ Here is what you need to be able to run JSON Crack.
cd jsoncrack.com
```
-3. Install packages with yarn
+3. Install packages
```sh
pnpm install
| [
"README.md"
] | [] | true | ||
AykutSarac/jsoncrack.com | 413 | issue_to_patch | Quick License Reference – Hyperlink in README | ## Description
This PR adds a direct hyperlink to the `LICENSE` file in the `README.md` to improve accessibility and user experience.
## Problem
- The `README.md` references the `LICENSE` file but does not provide a direct link.
- Users who want to view the licensing terms must navigate manually to the `LICEN... | cb333d3cd48dcd05b2cff9788e795c5fdc189c0a | cc69802b1e610dc8c7f13687c9e24ad029f27eda | diff --git a/README.md b/README.md
index 84747f262c7..16ec16b5044 100644
--- a/README.md
+++ b/README.md
@@ -153,4 +153,4 @@ We have a list of [help wanted](https://github.com/AykutSarac/jsoncrack.com/issu
## License
-See `LICENSE` for more information.
+See [`LICENSE`](/LICENSE) for more information.
| [
"README.md"
] | [] | true | ||
AykutSarac/jsoncrack.com | 443 | issue_to_patch | upgrade cdnjs link for monaco-editor to 0.52.2 | Hello,
Should the version follow here the one defined there ?https://github.com/AykutSarac/jsoncrack.com/blob/46d1182a5d59f7a657de6cb2035bb5926c270afb/pnpm-lock.yaml#L25
| 46d1182a5d59f7a657de6cb2035bb5926c270afb | e02e66d040e7143c6de5878158d3c71d13a99ec0 | diff --git a/src/features/editor/TextEditor.tsx b/src/features/editor/TextEditor.tsx
index 94b0e56e73a..39d36f709db 100644
--- a/src/features/editor/TextEditor.tsx
+++ b/src/features/editor/TextEditor.tsx
@@ -7,7 +7,7 @@ import useFile from "src/store/useFile";
loader.config({
paths: {
- vs: "https://cdnjs.clo... | [
"src/features/editor/TextEditor.tsx"
] | [] | true | ||
AykutSarac/jsoncrack.com | 436 | issue_to_patch | Use nginx-unprivileged image; fix exposed port | Thank you for creating such a great tool!
Two minor changes:
- Changed the base Docker image for the `production` stage to `nginx-unprivileged` for better security (i.e., does not run as `root`)
- Added the `nginxinc` namespace to remove ambiguity and ensure the official `nginx` image is used
- Fixed the ex... | e8496f9eadf3300b3dec204a6012557da76aeea6 | f61b2ed769723562a71336aae669ea97af711b7c | diff --git a/Dockerfile b/Dockerfile
index 2d217dfcbec..f214858e2c7 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -14,9 +14,9 @@ COPY . .
RUN corepack enable pnpm && pnpm run build
# Stage 3: Production image
-FROM nginx:stable AS production
+FROM nginxinc/nginx-unprivileged:stable AS production
WORKDIR /app
COPY -... | [
"Dockerfile"
] | [] | true | ||
AykutSarac/jsoncrack.com | 437 | issue_to_patch | fix typo in error pages' title | Hello,
2 pages are named after "ToDiagram" when I assume that in this repo they should be named after "JSON Crack" | c492d9a62b8c4c95c26479d7f53398564b968945 | d73e66a052bc05212e843bad1264f11bd077d717 | diff --git a/src/pages/404.tsx b/src/pages/404.tsx
index cfcbf6b4fd0..7441a71456e 100644
--- a/src/pages/404.tsx
+++ b/src/pages/404.tsx
@@ -8,7 +8,7 @@ import Layout from "src/layout/Layout";
const NotFound = () => {
return (
<Layout>
- <NextSeo {...SEO} title="404 | ToDiagram" noindex />
+ <NextSeo... | [
"src/pages/404.tsx",
"src/pages/_error.tsx"
] | [] | true | ||
AykutSarac/jsoncrack.com | 427 | issue_to_patch | chore: update _error.tsx | Occured -> Occurred | 87def91d4b9c77f9c3c36c4f7def1f85d7087c33 | 9ac718110c74bc846491c23547050e18d6422771 | diff --git a/src/pages/_error.tsx b/src/pages/_error.tsx
index e1529300634..38edf393c86 100644
--- a/src/pages/_error.tsx
+++ b/src/pages/_error.tsx
@@ -10,7 +10,7 @@ const Custom500 = () => {
return (
<Layout>
- <NextSeo {...SEO} title="Unexpected Error Occured | ToDiagram" />
+ <NextSeo {...SEO} t... | [
"src/pages/_error.tsx"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.