repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
AykutSarac/jsoncrack.com | 429 | issue_to_patch | [BUG]: README does not accurately describe the port exposed via docker container
### Issue description
When use the docker-compose file to set up a container locally, it uses port 8888. The README says to go to `http://localhost:8080` when it should be `http://localhost:8888`. I can make this quick change in the READ... | Fixes port for docker in README for issue #428 | Fixes #428 | e09d5bb1e16d21d9b55563451cd7f214c426197b | 01fdf2ceb7e9de2b0ab62b0d6be545698401b576 | diff --git a/README.md b/README.md
index 3560e4f5068..e43a989ca1b 100644
--- a/README.md
+++ b/README.md
@@ -124,7 +124,7 @@ docker compose build
# Run locally with `docker-compose`
docker compose up
-# Go to http://localhost:8080
+# Go to http://localhost:8888
```
<!-- LICENSE -->
| [
"README.md"
] | [] | true | |
AykutSarac/jsoncrack.com | 416 | issue_to_patch | chore(deps): bump next from 14.2.3 to 14.2.10 | Bumps [next](https://github.com/vercel/next.js) from 14.2.3 to 14.2.10.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/vercel/next.js/releases">next's releases</a>.</em></p>
<blockquote>
<h2>v14.2.10</h2>
<blockquote>
<p>[!NOTE]<br />
This release is backporting bug fixes. It... | 07e265164e7643f1258c1e34e2103700028d4df0 | 0339ec0d023a93f4fedbb7827e90fb2ce26a4e5d | diff --git a/package.json b/package.json
index 9ab516c32b9..f70ec92e30d 100644
--- a/package.json
+++ b/package.json
@@ -41,7 +41,7 @@
"jsonwebtoken": "^9.0.2",
"jxon": "2.0.0-beta.5",
"lodash.debounce": "^4.0.8",
- "next": "14.2.3",
+ "next": "14.2.10",
"next-seo": "^6.5.0",
"nextjs-goog... | [
"package.json",
"pnpm-lock.yaml"
] | [] | true | ||
AykutSarac/jsoncrack.com | 411 | issue_to_patch | chore(deps): bump actions/download-artifact from 2 to 4.1.7 in /.github/workflows | Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 2 to 4.1.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/download-artifact/releases">actions/download-artifact's releases</a>.</em></p>
<blockquote>
<h2>v4.1.7</h2>
<h2>What's Chang... | 07f1539ec97f48409a806d512cb0a27cd4a90875 | 01b2e32e6d6b74f6fb2066a556c81642908e0a10 | diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index 9feab7f0d2e..bd22dead363 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -95,7 +95,7 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
- - uses: actions/download-artifac... | [
".github/workflows/deploy.yml"
] | [] | true | ||
AykutSarac/jsoncrack.com | 393 | issue_to_patch | update the menu item text in view menu from "Expand/Collapse Nodes" t… | This commit will update a menu item's text In the View Menu
"Expand/Collapse Nodes" -> "Expand/Collapse Graph"
Before
<img width="213" alt="Screenshot 2024-02-14 at 3 17 10 PM" src="https://github.com/AykutSarac/jsoncrack.com/assets/29529379/13cdd6eb-dcaf-4ffa-842e-627234767924">
After
<img width="211" alt="Sc... | d88dafc09ff443ca4eea252426fefc6f4e801dec | ab4f5f3b0782d7c10f1b6a49683e6819799f24c7 | diff --git a/src/containers/Toolbar/ViewMenu.tsx b/src/containers/Toolbar/ViewMenu.tsx
index 04667cc6220..f090e2bfc03 100644
--- a/src/containers/Toolbar/ViewMenu.tsx
+++ b/src/containers/Toolbar/ViewMenu.tsx
@@ -122,7 +122,7 @@ export const ViewMenu = () => {
</Text>
}
>
- ... | [
"src/containers/Toolbar/ViewMenu.tsx"
] | [] | true | ||
AykutSarac/jsoncrack.com | 399 | issue_to_patch | Fix :: build docker image with /bin/sh: pnpm: not found | Fix :: build docker image with /bin/sh: pnpm: not found
```
# Reference :: https://pnpm.io/docker
ENV PNPM_HOME="/pnpm"
ENV PATH="$PNPM_HOME:$PATH"
RUN corepack enable
``` | 5e2657d742ddc0e3cf86d808d6e3266a6dd7778d | 2334ab721915add4a284aeb67591d582a443ef25 | diff --git a/Dockerfile b/Dockerfile
index 771b0a52483..36e0bf028af 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,5 +1,9 @@
# Builder
FROM node:18-alpine as builder
+# Reference :: https://pnpm.io/docker
+ENV PNPM_HOME="/pnpm"
+ENV PATH="$PNPM_HOME:$PATH"
+RUN corepack enable
WORKDIR /src
# Cache dependencies fi... | [
"Dockerfile"
] | [] | true | ||
AykutSarac/jsoncrack.com | 390 | issue_to_patch | Fixing grammar and spelling mistake | d5482cd50d5f7fc536fa9be432206eb7bed6aa66 | fafe18bdc3d03632fe4785e5051a66c97b5f70ac | diff --git a/src/containers/Views/GraphView/PremiumView.tsx b/src/containers/Views/GraphView/PremiumView.tsx
index ecc8fe9266e..367dfd74ca4 100644
--- a/src/containers/Views/GraphView/PremiumView.tsx
+++ b/src/containers/Views/GraphView/PremiumView.tsx
@@ -159,7 +159,7 @@ export const PremiumView = () => (
<JS... | [
"src/containers/Views/GraphView/PremiumView.tsx"
] | [] | true | |||
AykutSarac/jsoncrack.com | 391 | issue_to_patch | Incorrect Installation Command | The command `pnpm` is incorrect. Instead it must be `pnpm install` to install the dependencies of the project. | d5482cd50d5f7fc536fa9be432206eb7bed6aa66 | 22dc3d0ac7cb48bb0a996985e3ef100b75e35c59 | diff --git a/README.md b/README.md
index c72e16575d5..9031dab07da 100644
--- a/README.md
+++ b/README.md
@@ -101,7 +101,7 @@ Here is what you need to be able to run JSON Crack.
3. Install packages with yarn
```sh
- pnpm
+ pnpm install
```
4. Run the project
| [
"README.md"
] | [] | true | ||
AykutSarac/jsoncrack.com | 389 | issue_to_patch | [BUG]: Zoom Label Not Updating After Selection or Input
### Issue description
## Issue Summary
When a user enters the zooming amount in the input field or selects the zooming level from the dropdown (e.g., Zoom to 100%, Zoom to 50%), the label next to the zoom dropdown does not update to reflect the selected zoom ... | fix: Zoom label not updating on selection/input |
**### Issue**:
This pull request addresses the issue where the zoom label next to the zoom dropdown and input field does not update to reflect the selected zoom level (Issue #388 ).
### Description:
This PR implements a fix that ensures the zoom label accurately displays the chosen zoom level, regardless of ... | 9a98bc5a68385b7dbf44a5d8488339d7978b76b8 | 08db332b752585e99d757075e1b747376260c214 | diff --git a/src/containers/Views/GraphView/index.tsx b/src/containers/Views/GraphView/index.tsx
index 0f8fdb2c0cd..d8771d39b1b 100644
--- a/src/containers/Views/GraphView/index.tsx
+++ b/src/containers/Views/GraphView/index.tsx
@@ -1,6 +1,7 @@
import React from "react";
import dynamic from "next/dynamic";
import st... | [
"src/containers/Views/GraphView/index.tsx"
] | [
{
"comment": "We may not need them as we attached debounced watcher to onUpdate to `<Space />` component.",
"path": "src/store/useGraph.ts",
"hunk": "",
"resolving_sha": "08db332b752585e99d757075e1b747376260c214",
"resolving_diff": ""
}
] | true | |
AykutSarac/jsoncrack.com | 376 | issue_to_patch | feat: add ability to edit through tree view | 874476d4da06f3d4122bb9b2420f3340bdb4466e | b1fdcbba538219b0f705d2a504a34b0ef05dd492 | diff --git a/package.json b/package.json
index 8f68dbd8432..caf1765c42e 100644
--- a/package.json
+++ b/package.json
@@ -39,6 +39,8 @@
"lodash.debounce": "^4.0.8",
"lodash.get": "^4.4.2",
"lodash.set": "^4.3.2",
+ "lodash.unset": "^4.5.2",
+ "lodash.update": "^4.10.2",
"maketypes": "^1.1.2",
... | [
"package.json",
"pnpm-lock.yaml",
"src/containers/Views/TreeView.tsx",
"src/containers/Views/TreeView/EditModal.tsx",
"src/containers/Views/TreeView/Label.tsx",
"src/containers/Views/TreeView/Value.tsx",
"src/containers/Views/TreeView/index.tsx"
] | [] | true | |||
AykutSarac/jsoncrack.com | 371 | issue_to_patch | feat: upgrade mantine v7 & ui changes | * Upgrade Mantine v7
* Next.js 14
* UI Changes
* Switch from yarn to pnpm | ecb825e5e0a39e534e6aad2146adb2f1953a9ac4 | d33aa5712ef4099f265789f1c48ef794058dcbb5 | diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
index 907b22a7061..9feab7f0d2e 100644
--- a/.github/workflows/deploy.yml
+++ b/.github/workflows/deploy.yml
@@ -23,47 +23,57 @@ jobs:
uses: actions/checkout@v3
with:
fetch-depth: 0
- - name: Detect package manager... | [
".github/workflows/deploy.yml",
".github/workflows/pull-request.yml",
".gitignore",
".prettierrc",
"CONTRIBUTING.md",
"Dockerfile",
"README.md",
"package.json",
"pnpm-lock.yaml",
"src/components/HovercardAds/index.tsx",
"src/components/MonacoEditor/index.tsx",
"src/components/SearchInput/index... | [] | true | ||
AykutSarac/jsoncrack.com | 367 | issue_to_patch | feat: UI updates | 9c1f079f7e0d798b63e061097fc965d5254c7192 | bdf0aa7ccf835deb088aa34c3ad5fcbfffc8946b | diff --git a/.eslintrc.json b/.eslintrc.json
index b3f118044a0..94186d2e0a2 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -22,5 +22,6 @@
]
},
"extends": ["next/core-web-vitals", "prettier"],
- "plugins": ["prettier", "unused-imports"]
+ "plugins": ["prettier", "unused-imports"],
+ "ignorePatterns": ... | [
".eslintrc.json",
".github/workflows/pull-request.yml",
".prettierignore",
"LICENSE",
"next.config.js",
"package.json",
"src/components/Graph/CustomNode/TextNode.tsx",
"src/components/Graph/CustomNode/TextRenderer.tsx",
"src/components/Graph/CustomNode/index.tsx",
"src/components/Graph/index.tsx",... | [] | true | |||
AykutSarac/jsoncrack.com | 363 | issue_to_patch | change "Twitter" to "𝕏 (Twitter)"
### Issue description
1. Go to <a href='https://jsoncrack.com/'>jsoncrack.com</a>
2. Check the footer
3. Twitter is now know as 𝕏 but in website it is still Twitter
### Media & Screenshots
![image](https://github.com/AykutSarac/jsoncrack.com/assets/110784317/1c805416-7b0c-4263-... | fix: changed "Twitter" to "𝕏 (Twitter)" | changed "Twitter" to "𝕏 (Twitter)"
This fixes https://github.com/AykutSarac/jsoncrack.com/issues/362 | f4d5348a60dc4e96448e2002a7efecacdff9d7d0 | bf9628ed7495d184d2262185cef253b8ae2438c2 | diff --git a/src/layout/Footer/index.tsx b/src/layout/Footer/index.tsx
index f2b569e1954..a8c9cafcb45 100644
--- a/src/layout/Footer/index.tsx
+++ b/src/layout/Footer/index.tsx
@@ -30,7 +30,7 @@ export const Footer = () => {
link: "https://discord.gg/yVyTtCRueq",
},
{
- ... | [
"src/layout/Footer/index.tsx"
] | [] | true | |
AykutSarac/jsoncrack.com | 369 | issue_to_patch | feat: add go struct generator | cf733f79122443cff081393c47378addd57bdbd8 | da553309018928f396b81891f350405b57c85c4c | diff --git a/package.json b/package.json
index 70d5bdd7fb3..25d24818ef7 100644
--- a/package.json
+++ b/package.json
@@ -29,6 +29,7 @@
"allotment": "^1.19.3",
"axios": "^1.5.0",
"dayjs": "^1.11.10",
+ "gofmt.js": "^0.0.2",
"html-to-image": "^1.11.11",
"jq-in-the-browser": "^0.7.2",
"jq-... | [
"package.json",
"src/containers/Modals/TypeModal/index.tsx",
"src/lib/utils/json2go.js",
"yarn.lock"
] | [] | true | |||
AykutSarac/jsoncrack.com | 353 | issue_to_patch | Dockefile conf updated cache. Created other conf for dockerisation. | Updated
- Dockerfile for cache
- README.md based the new conf
Created
- .gitignore - to ignore the non docker file
- docker-compose.yml - conf as file along with the image build and run at a time with docker-compose up -d | 14cebeebe58d1a66c28a6da7914e2d1a32b02908 | c09588dacd24430ebc444012c16316ca20170faa | diff --git a/.dockerignore b/.dockerignore
new file mode 100644
index 00000000000..ef85d8fcfc6
--- /dev/null
+++ b/.dockerignore
@@ -0,0 +1,14 @@
+# Ignore node modules as they will be installed in the Dockerfile
+node_modules/
+
+# Ignore local configuration and cache files
+.cache/
+.config/
+.DS_Store
+
+# Ignore lo... | [
".dockerignore",
"Dockerfile",
"README.md",
"docker-compose.yml"
] | [] | true | ||
AykutSarac/jsoncrack.com | 349 | issue_to_patch | [BUG]: Array Length doesn't update when adding elements.
### Issue description
Steps to reproduce:
1. Open the default example.
2. Copy the members and paste them in the same array.
You will find that the array length doesn't update.
### Media & Screenshots
_No response_
### Operating system
- OS: windows
-... | Fixed array length doesn't update | Fixes #345
- The TextNode component is not being re-rendered when the 'childrenCount' is updating.
- Added the condition that when it changes, it should re-render the component
- Changes are made in the propsAreEqual function.
https://github.com/AykutSarac/jsoncrack.com/assets/74180320/2010cf3e-50f9-4748-a440-... | 1fbb777dec62633dfbbc8d87a42b129b04ab1572 | 005047445d1588c138bb1ebc380b5f90ccfadb34 | diff --git a/src/components/Graph/CustomNode/TextNode.tsx b/src/components/Graph/CustomNode/TextNode.tsx
index 4eba966d25c..8539a3bc5e4 100644
--- a/src/components/Graph/CustomNode/TextNode.tsx
+++ b/src/components/Graph/CustomNode/TextNode.tsx
@@ -100,7 +100,11 @@ const Node: React.FC<CustomNodeProps> = ({ node, x, y,... | [
"src/components/Graph/CustomNode/TextNode.tsx"
] | [] | true | |
AykutSarac/jsoncrack.com | 342 | issue_to_patch | chore: optimize bundle | 478775855139803112eca70cb798661c77170b3e | 0e35c6a1e9f6ef211321cfdd28e4e8abfa0106e7 | diff --git a/.eslintrc.json b/.eslintrc.json
index 6de70390e76..2a0ddc71a30 100644
--- a/.eslintrc.json
+++ b/.eslintrc.json
@@ -6,7 +6,24 @@
"space-in-parens": "error",
"no-empty": "error",
"no-multiple-empty-lines": "error",
- "no-irregular-whitespace": "error"
+ "no-irregular-whitespace": "error... | [
".eslintrc.json",
"next.config.js",
"package.json",
"public/assets/multidata.png",
"public/assets/multidata.webp",
"src/api/altogic.ts",
"src/assets/fonts/Mona-Sans.woff2",
"src/components/AdTest/index.tsx",
"src/components/CarbonAds/index.tsx",
"src/components/CustomNode/ObjectNode.tsx",
"src/c... | [] | true | |||
AykutSarac/jsoncrack.com | 335 | issue_to_patch | Version 3 | ## What has changed since version 2?
* New UI
* Edit nodes on graph
* Display path to nodes at Node Modal
* JWT Decoder
* JSON Schema
* Live/Manual Transform toggle
* Performance improvements
* New Landing Page
* Account, Cloud functions, save/share documents
* Fetch JSON through URL
* Image Previews at gr... | 528520cbcebb626356702a3b48c6670061ec8f47 | 7a60d0018117c6e93ca1694b04b797ecb8553c1c | diff --git a/package.json b/package.json
index 56f1da68206..7d714cee1c8 100644
--- a/package.json
+++ b/package.json
@@ -13,23 +13,25 @@
"deploy": "gh-pages -d out -t true"
},
"dependencies": {
- "@emotion/react": "^11.11.0",
+ "@emotion/react": "^11.11.1",
"@emotion/server": "^11.11.0",
- "@ma... | [
"package.json",
"public/assets/download_image.png",
"public/assets/highlight_graph.svg",
"public/assets/multidata.png",
"public/assets/preview_image.svg",
"sentry.client.config.ts",
"src/components/Graph/PremiumView.tsx",
"src/components/MonacoEditor/index.tsx",
"src/components/PreviewDiagram/index.... | [
{
"comment": "it might be better to remove this `!important` :)",
"path": "src/constants/globalStyle.ts",
"hunk": "@@ -14,7 +14,7 @@ const GlobalStyle = createGlobalStyle`\n font-weight: 400;\n font-size: 16px;\n font-family: ${monaSans.style.fontFamily};\n- background: #141517;\n+ bac... | true | ||
AykutSarac/jsoncrack.com | 335 | comment_to_fix | Version 3 | it might be better to remove this `!important` :) | 528520cbcebb626356702a3b48c6670061ec8f47 | 7a60d0018117c6e93ca1694b04b797ecb8553c1c | diff --git a/src/constants/globalStyle.ts b/src/constants/globalStyle.ts
index 833029a9788..cd26f943b78 100644
--- a/src/constants/globalStyle.ts
+++ b/src/constants/globalStyle.ts
@@ -14,7 +14,7 @@ const GlobalStyle = createGlobalStyle`
font-weight: 400;
font-size: 16px;
font-family: ${monaSans.style.fo... | [
"src/constants/globalStyle.ts"
] | [
{
"comment": "it might be better to remove this `!important` :)",
"path": "src/constants/globalStyle.ts",
"hunk": "@@ -14,7 +14,7 @@ const GlobalStyle = createGlobalStyle`\n font-weight: 400;\n font-size: 16px;\n font-family: ${monaSans.style.fontFamily};\n- background: #141517;\n+ bac... | true | ||
AykutSarac/jsoncrack.com | 335 | comment_to_fix | Version 3 | It is good for best practice in removing logs | 528520cbcebb626356702a3b48c6670061ec8f47 | 7a60d0018117c6e93ca1694b04b797ecb8553c1c | diff --git a/src/utils/json/jsonParser.ts b/src/utils/json/jsonParser.ts
index d526eb01024..906ddc9e9d9 100644
--- a/src/utils/json/jsonParser.ts
+++ b/src/utils/json/jsonParser.ts
@@ -74,6 +74,7 @@ export function parser(jsonStr: string): Graph {
path: getNodePath(states.graph.nodes, states.graph.edges, node.id... | [
"src/utils/json/jsonParser.ts"
] | [
{
"comment": "It is good for best practice in removing logs",
"path": "src/utils/json/jsonParser.ts",
"hunk": "@@ -74,6 +74,7 @@ export function parser(jsonStr: string): Graph {\n path: getNodePath(states.graph.nodes, states.graph.edges, node.id),\n }));\n \n+ console.log(states.graph);",
... | true | ||
AykutSarac/jsoncrack.com | 326 | issue_to_patch | Refactor codebase | 25a7d22c9bb8cce211cdec89e9eff07c8b01b9dc | 13da5323251735cad0172f9db8ec6d3edbc53837 | diff --git a/package.json b/package.json
index 693abf6f53a..2dcf253758d 100644
--- a/package.json
+++ b/package.json
@@ -9,7 +9,7 @@
"build": "next build && next export",
"start": "next start",
"lint": "tsc && next lint",
- "lint:fix": "prettier --write \"./**/*.{ts,tsx,json}\"",
+ "lint:fix": "pre... | [
"package.json",
"public/assets/bunny.png",
"src/components/ErrorContainer/index.tsx",
"src/components/Graph/index.tsx",
"src/components/Sidebar/index.tsx",
"src/constants/globalStyle.ts",
"src/containers/Editor/LiveEditor/Tools.tsx",
"src/containers/Home/styles.tsx",
"src/containers/ModalController/... | [] | true | |||
AykutSarac/jsoncrack.com | 318 | issue_to_patch | Feat/mantine UI | bbd0aa1f104344e361a4acd06f612f6e1a2498ee | a93e04eaec7ad62b17dd7b4046e9af0f0170d8e6 | diff --git a/package.json b/package.json
index 1e9c300874f..693abf6f53a 100644
--- a/package.json
+++ b/package.json
@@ -1,7 +1,7 @@
{
"name": "json-crack",
"private": true,
- "version": "v2.6.0",
+ "version": "v2.8.0",
"author": "https://github.com/AykutSarac",
"homepage": "https://jsoncrack.com",
"s... | [
"package.json",
"public/assets/rocket_ship.webp",
"src/components/Button/index.tsx",
"src/components/CustomNode/ObjectNode.tsx",
"src/components/CustomNode/TextNode.tsx",
"src/components/CustomNode/index.tsx",
"src/components/CustomNode/styles.tsx",
"src/components/Graph/PremiumView.tsx",
"src/compo... | [] | true | |||
AykutSarac/jsoncrack.com | 274 | issue_to_patch | Update default.conf | Add widget and embed endpoints to nginx config otherwise you will get 404 when running docker | debe13fef54c902184c780b9586588052227cd02 | 7ffac15f4226df7c9ff094ee6b03dfca9befbecc | diff --git a/default.conf b/default.conf
index c97e205521a..5174d9fec4c 100644
--- a/default.conf
+++ b/default.conf
@@ -6,4 +6,12 @@ server {
location /editor {
try_files $uri /editor.html;
}
+
+ location /widget {
+ try_files $uri /widget.html;
+ }
+
+ location /embed {
+ ... | [
"default.conf"
] | [] | true | ||
AykutSarac/jsoncrack.com | 304 | issue_to_patch | #257 Getting path of JSON on clicking the edges | Feature implementation of issue #257
When edges are clicked, modal popup.
Implementation looks like below.
<img width="1291" alt="image" src="https://user-images.githubusercontent.com/37659866/215338373-82177ee1-0f8c-4698-a2c7-75f38614b810.png">
The modal shows only path not content of node.
Node contents ar... | 935901f87eed6a7e8f93629dc5ef9ff5ccb84732 | 80a02d79baf7d6cc6f2c2f32afdca9d46c577bc6 | diff --git a/src/components/Graph/index.tsx b/src/components/Graph/index.tsx
index aa305ab508b..d7d99c5a807 100644
--- a/src/components/Graph/index.tsx
+++ b/src/components/Graph/index.tsx
@@ -1,6 +1,6 @@
import React from "react";
import { ReactZoomPanPinchRef, TransformComponent, TransformWrapper } from "react-zoom... | [
"src/components/Graph/index.tsx",
"src/containers/Editor/LiveEditor/GraphCanvas.tsx",
"src/containers/Modals/NodeModal/index.tsx",
"src/store/useGraph.tsx"
] | [] | true | ||
AykutSarac/jsoncrack.com | 309 | issue_to_patch | Dogukanuhn/main | 13aaa81d9a0eeea1ab8e19dcb8b9fa1465cbea3f | 819cd2729b17726a4cce5ca7e62f64d119c344ca | diff --git a/jest.config.ts b/jest.config.ts
deleted file mode 100644
index 9c0578a54ed..00000000000
--- a/jest.config.ts
+++ /dev/null
@@ -1,17 +0,0 @@
-import nextJest from "next/jest";
-
-const createJestConfig = nextJest({
- // Provide the path to your Next.js app to load next.config.js and .env files in your test... | [
"jest.config.ts",
"jest.setup.ts",
"package.json",
"src/components/FileInput/index.tsx",
"src/components/__tests__/Button.test.tsx",
"src/containers/Modals/DownloadModal/index.tsx",
"src/pages/_app.tsx"
] | [] | diff --git a/src/components/__tests__/Button.test.tsx b/src/components/__tests__/Button.test.tsx
deleted file mode 100644
index 49d7b8abb1a..00000000000
--- a/src/components/__tests__/Button.test.tsx
+++ /dev/null
@@ -1,10 +0,0 @@
-import React from "react";
-import { screen, render } from "@testing-library/react";
-im... | true | ||
AykutSarac/jsoncrack.com | 291 | issue_to_patch | Fix smooth scroll behavior on styles | 733ecd1cf56337a06b3082d806b39456c5448d86 | 410da36327f4417e63ca010951413af315f1b8ec | diff --git a/src/constants/globalStyle.ts b/src/constants/globalStyle.ts
index 8d08133ad47..0f68ff218e8 100644
--- a/src/constants/globalStyle.ts
+++ b/src/constants/globalStyle.ts
@@ -22,7 +22,7 @@ const GlobalStyle = createGlobalStyle`
* {
-webkit-tap-highlight-color: transparent;
- scroll-behavior: smoo... | [
"src/constants/globalStyle.ts"
] | [] | true | |||
AykutSarac/jsoncrack.com | 302 | issue_to_patch | Fix typo | Inlude -> Include
occured -> occurred | db214a8d787b5110d3ea111032156cf29c617523 | b4df1a4e26a51c4ef73c2b7345d2994ed0bab60f | diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml
index 1f67d2951d0..c04a2dcd0d7 100644
--- a/.github/ISSUE_TEMPLATE/bug_report.yml
+++ b/.github/ISSUE_TEMPLATE/bug_report.yml
@@ -24,7 +24,7 @@ body:
id: media
attributes:
label: Media & Screenshots
- descri... | [
".github/ISSUE_TEMPLATE/bug_report.yml",
"src/containers/Editor/BottomBar.tsx",
"src/containers/Modals/CloudModal/index.tsx"
] | [] | true | ||
AykutSarac/jsoncrack.com | 284 | issue_to_patch | import file by drag and drop | Add a feature that import file by drag and drop.
https://user-images.githubusercontent.com/71168966/210169418-a10c4389-3f42-40cb-903e-5ccb5fa63f4a.mov
Solve the issue #283 | 5914ae94eb2e0c0e8a237c38d7e56a9cc8060765 | 9b70222ff993181c4473e400bd1e1226759cb449 | diff --git a/src/containers/Modals/ImportModal/index.tsx b/src/containers/Modals/ImportModal/index.tsx
index 01789a75d16..3cab186e35c 100644
--- a/src/containers/Modals/ImportModal/index.tsx
+++ b/src/containers/Modals/ImportModal/index.tsx
@@ -50,6 +50,18 @@ export const ImportModal: React.FC<ModalProps> = ({ visible,... | [
"src/containers/Modals/ImportModal/index.tsx"
] | [] | true | ||
AykutSarac/jsoncrack.com | 295 | issue_to_patch | Fixed README typo | 69d6312d417f636b3b99576c5613b69fe174552a | 109af18b4a2ce25c0d236a2ea5a9c1a496abbbcc | diff --git a/README.md b/README.md
index c13fe833370..042c345e4b0 100644
--- a/README.md
+++ b/README.md
@@ -2,7 +2,7 @@
<a href="https://jsoncrack.com">
<img width="700" alt="jsoncrack" src="https://user-images.githubusercontent.com/47941171/206401172-74c21f7f-0a32-4532-96cc-4cf6b493c837.png">
</a>
- <h3>“... | [
"README.md"
] | [] | true | |||
AykutSarac/jsoncrack.com | 299 | issue_to_patch | Bump json5 from 1.0.1 to 1.0.2 | Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/json5/json5/releases">json5's releases</a>.</em></p>
<blockquote>
<h2>v1.0.2</h2>
<ul>
<li>Fix: Properties with the name <code>__proto__</code> are added to objec... | 69d6312d417f636b3b99576c5613b69fe174552a | e6f7af59e1fc18145ca305ff83c625509c002a64 | diff --git a/yarn.lock b/yarn.lock
index 4abcdc62cc8..e20d6cd5f1a 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -3580,9 +3580,9 @@ json-stable-stringify-without-jsonify@^1.0.1:
integrity sha512-Bdboy+l7tA3OGW6FjyFHWkP5LuByj1Tk33Ljyq0axyzdk9//JSi2u3fP1QSmd1KNwq6VOKYGlAu87CisVir6Pw==
json5@^1.0.1:
- version "1.0.1"
- ... | [
"yarn.lock"
] | [] | true | ||
AykutSarac/jsoncrack.com | 268 | issue_to_patch | fix: align object's children to keep the consistency of graph illustration | ### Issue: #266
Solved the issue by aligning object type node's children with sort method.
I checked traverse function performance with performance api.
```javascript
const t0 = performance.now();
traverse(json);
const t1 = performance.now();
console.log(`traverse() with sorting chil... | d16920c2c4ae11e6ea7168f279991a61b9bcc4fc | 08afad8fe047766963dcb97247fbb6b14fcab349 | diff --git a/src/utils/jsonParser.ts b/src/utils/jsonParser.ts
index 09b6ab85eb2..c7f2092ee9c 100644
--- a/src/utils/jsonParser.ts
+++ b/src/utils/jsonParser.ts
@@ -1,4 +1,4 @@
-import { Node, parseTree } from "jsonc-parser";
+import { Node, NodeType, parseTree } from "jsonc-parser";
import useGraph from "src/store/us... | [
"src/utils/jsonParser.ts"
] | [] | true | ||
AykutSarac/jsoncrack.com | 281 | issue_to_patch | Bump loader-utils from 2.0.2 to 2.0.4 | Bumps [loader-utils](https://github.com/webpack/loader-utils) from 2.0.2 to 2.0.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/webpack/loader-utils/releases">loader-utils's releases</a>.</em></p>
<blockquote>
<h2>v2.0.4</h2>
<h3><a href="https://github.com/webpack/loader-u... | 194098775927b7e3d9a095a4824a7560c9cd52b5 | 5cc6d862e6a643a7641047fe9992d62325b66b69 | diff --git a/yarn.lock b/yarn.lock
index ea6f8dfab25..13719cf96ad 100644
--- a/yarn.lock
+++ b/yarn.lock
@@ -3611,9 +3611,9 @@ json5@^1.0.1:
minimist "^1.2.0"
json5@^2.1.2, json5@^2.2.0, json5@^2.2.1:
- version "2.2.1"
- resolved "https://registry.yarnpkg.com/json5/-/json5-2.2.1.tgz#655d50ed1e6f95ad1a3caababd... | [
"yarn.lock"
] | [] | true | ||
AykutSarac/jsoncrack.com | 280 | issue_to_patch | Cloud updates | da620a17cbb086f817baf10e1a246d21a21e622b | db0536a5e79e96ac4fed05587d3e105fdf2c4986 | diff --git a/.env.development b/.env.development
index 629a33693c1..ced98e37028 100644
--- a/.env.development
+++ b/.env.development
@@ -1,1 +1,3 @@
-NEXT_PUBLIC_BASE_URL=http://localhost:3000
\ No newline at end of file
+NEXT_PUBLIC_BASE_URL=http://localhost:3000
+NEXT_PUBLIC_ALTOGIC_ENV_URL=https://jsoncrack.c5-na.al... | [
".env.development",
".env.production",
".prettierrc",
"next.config.js",
"package.json",
"public/assets/404.svg",
"public/assets/Mona-Sans.woff2",
"public/assets/icon.png",
"src/api/altogic.ts",
"src/components/Button/index.tsx",
"src/components/CustomNode/ObjectNode.tsx",
"src/components/Custo... | [] | true | |||
AykutSarac/jsoncrack.com | 210 | issue_to_patch | improve language of "huge file" error | 7c88dca65614acc6e3f0f9be7f07c741f1998fdc | c11779eaba192c0e7a500396cf9bced6e2f299be | diff --git a/src/components/Graph/ErrorView.tsx b/src/components/Graph/ErrorView.tsx
index 84ddcf1ecd4..8a2cc57c98a 100644
--- a/src/components/Graph/ErrorView.tsx
+++ b/src/components/Graph/ErrorView.tsx
@@ -32,11 +32,11 @@ export const ErrorView = () => (
height="200"
alt="oops"
/>
- <StyledTitl... | [
"src/components/Graph/ErrorView.tsx"
] | [] | true | |||
AykutSarac/jsoncrack.com | 264 | issue_to_patch | [BUG]: object member and array of one object member have same visual results
### Issue description
Using JSON:
```json
{
"A": {
"A": true
},
"B": [
{
"A": true
}
]
}
```
at [https://jsoncrack.com/editor](https://jsoncrack.com/editor)
gives:
<img width="677" alt="image" src... | seperate colors from array and object | Fixes #140 | 57389b3837418c52133ed56950d878e812510460 | dface28f1f306a9846c252a123233a65b395af4d | diff --git a/src/components/CustomNode/TextNode.tsx b/src/components/CustomNode/TextNode.tsx
index a6d34102e6a..3ab840d531e 100644
--- a/src/components/CustomNode/TextNode.tsx
+++ b/src/components/CustomNode/TextNode.tsx
@@ -65,16 +65,16 @@ const TextNode: React.FC<CustomNodeProps> = ({
x={0}
y={0}
... | [
"src/components/CustomNode/TextNode.tsx",
"src/components/CustomNode/styles.tsx",
"src/constants/theme.ts",
"src/typings/styled.d.ts",
"src/utils/jsonParser.ts"
] | [] | true | |
AykutSarac/jsoncrack.com | 251 | issue_to_patch | [Bug] Nested objects causing empty nodes
**Issue**
Empty nodes occurs in situations similar to nested objects.
**Reproduction**
Following data could be addressed regarding this: https://raw.githubusercontent.com/json-schema-org/json-schema-spec/draft-next/schema.json
![20220428_231517](https://user-images.... | fix empty nodes | I created the PR #242 but the updates created a conflict with my old PR. This PR solve the same problem, I tested the problems from #242 and it work correctly. Thank you for the patience. | fb6d8a55f5872543e9483794a1c94f07a3ffe3f1 | 41743f1ff0d0b45224b74a2ef7b0c75103f37bfa | diff --git a/src/utils/getOutgoers.ts b/src/utils/getOutgoers.ts
index eb35c4944f0..e1d58d4a5a0 100644
--- a/src/utils/getOutgoers.ts
+++ b/src/utils/getOutgoers.ts
@@ -7,6 +7,11 @@ export const getOutgoers = (
const outgoerNodes: NodeData[] = [];
const matchingNodes: string[] = [];
+ if (parent.includes(nodeI... | [
"src/utils/getOutgoers.ts",
"src/utils/jsonParser.ts"
] | [] | true | |
AykutSarac/jsoncrack.com | 252 | issue_to_patch | chore: code refactor | d3bbc6d8131d468c39cf30abe0a4dbcb66d43d2f | 15f6dd2545f6fdce818169ddcf0e0a91b4e1e217 | diff --git a/src/components/CustomNode/ObjectNode.tsx b/src/components/CustomNode/ObjectNode.tsx
index f55a8940ec9..4679dfb83a2 100644
--- a/src/components/CustomNode/ObjectNode.tsx
+++ b/src/components/CustomNode/ObjectNode.tsx
@@ -1,7 +1,7 @@
import React from "react";
// import { useInViewport } from "react-in-vie... | [
"src/components/CustomNode/ObjectNode.tsx",
"src/components/CustomNode/TextNode.tsx",
"src/components/Graph/ErrorView.tsx",
"src/components/Graph/index.tsx",
"src/components/MonacoEditor/index.tsx",
"src/components/Sidebar/index.tsx",
"src/components/Sponsors/index.tsx",
"src/containers/Editor/LiveEdi... | [] | true | |||
AykutSarac/jsoncrack.com | 250 | issue_to_patch | [BUG]: Ignore mouse click event after resizing view.
### Issue description
**Use right mouse to resize view**
**Use left mouse to resize view when hover the cusor over something "button"**
![l... | fix: #158 | Fixes #158 | e32147e1bfc57253d0764c3136ca157bfdf94b29 | 8fa8130d9de980b11eae28689ef7d1ead9a2cec8 | diff --git a/src/components/Graph/index.tsx b/src/components/Graph/index.tsx
index a9c0ddc39e5..584182d2958 100644
--- a/src/components/Graph/index.tsx
+++ b/src/components/Graph/index.tsx
@@ -31,7 +31,7 @@ const StyledEditorWrapper = styled.div<{ isWidget: boolean }>`
cursor: move;
}
- .dragging {
+ .dragg... | [
"src/components/Graph/index.tsx"
] | [] | true | |
AykutSarac/jsoncrack.com | 243 | issue_to_patch | Collapse bug
@AykutSarac The bug is present on `production` and is unrelated to this ticket.
I suggest opening a new issue for this bug.
https://user-images.githubusercontent.com/71708164/194141356-fcf6c181-f830-42a6-b5e7-49fcb3b77532.mov
You can reproduce it by using this JSON:
`{
"test": "test",... | Fix: don't show disconnected nodes on expand | resolves #241
- expand nodes that are already collapsed and directly connected to parent node.
| 0737bcbbbf87dfb07472fdfc6051c705c2d2392e | f70af5806b675853d32c12e3c165df50979cc55c | diff --git a/src/hooks/store/useGraph.tsx b/src/hooks/store/useGraph.tsx
index 15434b29537..d130347c51a 100644
--- a/src/hooks/store/useGraph.tsx
+++ b/src/hooks/store/useGraph.tsx
@@ -43,7 +43,14 @@ const useGraph = create<Graph & GraphActions>((set, get) => ({
);
const childrenEdges = getChildrenEdges(child... | [
"src/hooks/store/useGraph.tsx"
] | [] | true | |
AykutSarac/jsoncrack.com | 238 | issue_to_patch | [BUG]: When rotated, hidden node showed up. need to "click hide" again to hide it.
### Issue description
1. Hide a node
2. Rotate
3. Here ther result:
4. same behaviour, when got rotated again,
### M... | Fix: persist hidden nodes on rotate | resolves #173
- Doesn't clear hidden nodes, edges on layout change.
- Triggers the side effect to hide nodes on layout change.
| 833c65d73537ce84cf8642efe573ad7907bdde4e | 74671012cbf365c46196839da82dd7de1c1028a5 | diff --git a/src/components/Graph/index.tsx b/src/components/Graph/index.tsx
index 61c108a021e..e8512613489 100644
--- a/src/components/Graph/index.tsx
+++ b/src/components/Graph/index.tsx
@@ -47,6 +47,7 @@ const GraphComponent = ({
}: LayoutProps) => {
const [minScale, setMinScale] = React.useState(0.4);
const ... | [
"src/components/Graph/index.tsx",
"src/containers/Editor/LiveEditor/GraphCanvas.tsx",
"src/hooks/store/useGraph.tsx"
] | [] | true | |
B2R2-org/B2R2 | 364 | issue_to_patch | [Extra] Update dotnet tool
Update b2r2.fslint to v1.1.0 | [Extra] Update dotnet tool | Close #349 | 84ae79a6346465651c5186d37fcb04e23a6c6041 | 64991d86c860ebefc18850948d3a37e1589a79fb | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 4f9931194..1356cc4a6 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -10,7 +10,7 @@
"rollForward": false
},
"b2r2.fslint": {
- "version": "1.1.0",
+ "version": "1.1.1",
"commands": [
... | [
".config/dotnet-tools.json"
] | [
{
"comment": "The PR description/linked issue (#349) says to update `b2r2.fslint` to v1.1.0, but this change bumps the tool to v1.1.1 instead. Please either adjust the version here to match the requested target, or update the PR description/issue context to reflect that v1.1.1 is the intended update.",
"pat... | true | |
B2R2-org/B2R2 | 364 | comment_to_fix | [Extra] Update dotnet tool | The PR description/linked issue (#349) says to update `b2r2.fslint` to v1.1.0, but this change bumps the tool to v1.1.1 instead. Please either adjust the version here to match the requested target, or update the PR description/issue context to reflect that v1.1.1 is the intended update. | 84ae79a6346465651c5186d37fcb04e23a6c6041 | 64991d86c860ebefc18850948d3a37e1589a79fb | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 4f9931194..1356cc4a6 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -10,7 +10,7 @@
"rollForward": false
},
"b2r2.fslint": {
- "version": "1.1.0",
+ "version": "1.1.1",
"commands": [
... | [
".config/dotnet-tools.json"
] | [
{
"comment": "The PR description/linked issue (#349) says to update `b2r2.fslint` to v1.1.0, but this change bumps the tool to v1.1.1 instead. Please either adjust the version here to match the requested target, or update the PR description/issue context to reflect that v1.1.1 is the intended update.",
"pat... | true | ||
B2R2-org/B2R2 | 352 | issue_to_patch | [MiddleEnd] Add support for recovering CFG of a single target function
I would like to request a feature for recovering the CFG of a single target function in BinaryBrew.
## Requested feature
It would be very useful to have an official API or recovery mode that takes a function entry point and recovers only that func... | [MiddleEnd] Remove RecoveryMission | - Introduce IFunctionIdentifiable. | f75b390965ee16517b6a50faba96371cc1ee46bf | bc56f91b0c9eff99831455c9cdc35eeb9c60c134 | diff --git a/src/MiddleEnd/API/BinaryBrew.fs b/src/MiddleEnd/API/BinaryBrew.fs
index f7f8a7146..fa7249fcd 100644
--- a/src/MiddleEnd/API/BinaryBrew.fs
+++ b/src/MiddleEnd/API/BinaryBrew.fs
@@ -50,15 +50,16 @@ type BinaryBrew<'FnCtx,
and 'GlCtx: (new: unit -> 'GlCtx)>
public(hdl: BinHandle,
... | [
"src/MiddleEnd/API/BinaryBrew.fs",
"src/MiddleEnd/ControlFlowAnalysis/B2R2.MiddleEnd.ControlFlowAnalysis.fsproj",
"src/MiddleEnd/ControlFlowAnalysis/CFGBuildingContext.fs",
"src/MiddleEnd/ControlFlowAnalysis/ExternalFnCFGBuilder.fs",
"src/MiddleEnd/ControlFlowAnalysis/ICFGBuildable.fs",
"src/MiddleEnd/Con... | [] | true | |
B2R2-org/B2R2 | 350 | issue_to_patch | [Extra] Update dotnet tool
Update b2r2.fslint to v1.1.0 | [Extra] Update dotnet tool | Close #349 | be406ff72e0fd865581704a5706bd738fa950ad9 | 56336bd88b2ec1bd4baf4d422ca7918a512fa006 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 6ec9d7e48..4f9931194 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -10,7 +10,7 @@
"rollForward": false
},
"b2r2.fslint": {
- "version": "1.0.9",
+ "version": "1.1.0",
"commands": [
... | [
".config/dotnet-tools.json"
] | [] | true | |
B2R2-org/B2R2 | 344 | issue_to_patch | [Build] Fix FS3389 warnings
Enable FS3389 warnings and fix implicit conversions.
This helps catch unintended numeric casts and sign-extension bugs,
including the issue related to #340 . | [Build] Remove implicit conversions (FS3389) | Closes #343 | bcd0efade59f881402002316c3513b1517fd51ae | a4151b1fb0acbdc2468d751172426e31e981e7de | diff --git a/Directory.Build.props b/Directory.Build.props
index bf4e9cc52..c1eb0e3f8 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -14,6 +14,9 @@
<PackageTags>Binary;Disassembly;Assembly;CFG;Reversing;Binary Analysis;x86;AARCH64;ARM;MIPS;AVR;PPC;EVM;ELF;Mach-O;PE</PackageTags>
<FsDocsLogo... | [
"Directory.Build.props",
"src/Assembly.Tests/IntelTests.fs",
"src/Core.Tests/BitVectorTests.fs",
"src/Core.Tests/IntervalTreeTests.fs",
"src/Core.Tests/SortedListTests.fs",
"src/FrontEnd/ARM32/Lifter.fs",
"src/FrontEnd/ARM64/Lifter.fs",
"src/FrontEnd/ARM64/LiftingUtils.fs",
"src/FrontEnd/BinFile.Tes... | [] | true | |
B2R2-org/B2R2 | 342 | issue_to_patch | [Intel] x64 div
Hello,
I believe I've stumbled upon a bug with B2R2 and the div instruction.
For `div rax` (encoded as `48f7f0`) with `RAX=0xffffffffffffff01` and `RDX=0xffffffffffffff00`.
B2R2 produces these values:
```
RAX=0xfffffffeffffffff
RDX=0xffffff00fffffe02
```
While the CPU produces these values:
```
RAX... | [Intel] Fix sign extension in DIV | Closes #340 | 20dc06b2c34e9d3e618574621097a030a3ef39e8 | 9693e217c17d8f80800803790e8e979557802643 | diff --git a/src/FrontEnd/Intel/GeneralLifter.fs b/src/FrontEnd/Intel/GeneralLifter.fs
index f1a99d8f3..5aa321219 100644
--- a/src/FrontEnd/Intel/GeneralLifter.fs
+++ b/src/FrontEnd/Intel/GeneralLifter.fs
@@ -1272,7 +1272,7 @@ let divideWithoutConcat opcode oprSize divisor lblAssign lblErr bld =
let n32 = numI32 32 ... | [
"src/FrontEnd/Intel/GeneralLifter.fs"
] | [] | true | |
B2R2-org/B2R2 | 341 | issue_to_patch | [Intel] x64: cmpxchg8b
Hello,
I believe I've stumbled upon a size bug with B2R2 and the [`cmpxchg8b`](https://www.felixcloutier.com/x86/cmpxchg8b:cmpxchg16b) instruction.
RAX and RDX get written to even when `EDX:EAX = TEMP64` even though they should not be modified.
When testing `cmpxchg8b qword ptr [r8 + 0x20]` e... | [Intel] Fix CMPXCHG8B translation | Closes #337 | 6cbe81a55ad29c33be0ca03713af049f9378c9a0 | a998e27516619461c908cdefa32e770e3815d2fa | diff --git a/src/FrontEnd/Intel/GeneralLifter.fs b/src/FrontEnd/Intel/GeneralLifter.fs
index ec36ca399..eef724c1b 100644
--- a/src/FrontEnd/Intel/GeneralLifter.fs
+++ b/src/FrontEnd/Intel/GeneralLifter.fs
@@ -968,6 +968,9 @@ let compareExchangeBytes ins insLen bld =
bld <!-- (ins.Address, insLen)
match oprSize wi... | [
"src/FrontEnd/Intel/GeneralLifter.fs"
] | [] | true | |
B2R2-org/B2R2 | 339 | issue_to_patch | [Intel] x64: crc32
Hello,
I believe I've stumbled upon a bug with B2R2 and the [`crc32`](https://www.felixcloutier.com/x86/crc32) instruction.
For `crc32 eax, bl` (encoded as `f20f38f0c3`) with `RAX=0` and `RBX=1`, `RAX` is set to `0`, although it should be `RAX=0x00000000f26b8303`.
You should be able to recreate t... | [Intel] Initialize temp value in crc32's bitReflect | In crc32's `bitReflect` helper function, `res` is used before being assigned:
In dumped IR we can see: `TempVar (8, 9, null)` gets used in its first assignment.
The fix, initialize `res` to 0.
```
[|ISMark (5u, null);
Put
(TempVar (8, 1, null), Extract (Var (64, 3, "RBX", null), 8, 0, null), null);
... | 6cbe81a55ad29c33be0ca03713af049f9378c9a0 | 7ea599bf445aed442bd841e1c8eee38d5ff2b0c9 | diff --git a/src/FrontEnd/Intel/GeneralLifter.fs b/src/FrontEnd/Intel/GeneralLifter.fs
index ec36ca399..15605617f 100644
--- a/src/FrontEnd/Intel/GeneralLifter.fs
+++ b/src/FrontEnd/Intel/GeneralLifter.fs
@@ -1033,6 +1033,7 @@ let convWDQ ins insLen bld =
let private bitReflect bld src =
let oprSize = Expr.TypeOf s... | [
"src/FrontEnd/Intel/GeneralLifter.fs"
] | [] | true | |
B2R2-org/B2R2 | 334 | issue_to_patch | [Intel] Update opcodes and simplify JMP/CALL/RET mnemonics
- Synchronize opcodes based on the Intel 325383-089US specification.
- Remove non-standard near/far distinctions for JMP, CALL, and RET. | [Intel] Update opcodes and simplify JMP/CALL/RET mnemonics | Closes #333 | 4243da40bf129515b0f51b08bada128108e47af1 | a85183e629350096feab440a111179e092391914 | diff --git a/src/Assembly/Intel/AsmMain.fs b/src/Assembly/Intel/AsmMain.fs
index d4d865636..6f5ffaaf6 100644
--- a/src/Assembly/Intel/AsmMain.fs
+++ b/src/Assembly/Intel/AsmMain.fs
@@ -82,7 +82,7 @@ let encodeInstruction ins ctx =
| Opcode.ANDPS -> andps ctx ins
| Opcode.BSR -> bsr ctx ins
| Opcode.BT -> bt ct... | [
"src/Assembly/Intel/AsmMain.fs",
"src/Assembly/Intel/Assembler.fs",
"src/FrontEnd/Intel.Tests/ParserTests.fs",
"src/FrontEnd/Intel/Disasm.fs",
"src/FrontEnd/Intel/GeneralLifter.fs",
"src/FrontEnd/Intel/Instruction.fs",
"src/FrontEnd/Intel/Lifter.fs",
"src/FrontEnd/Intel/Opcode.fs",
"src/FrontEnd/Int... | [
{
"comment": "`opcodeToString` -> `toString`",
"path": "src/FrontEnd/Intel/Opcode.fs",
"hunk": "@@ -36,2851 +35,5105 @@ type Opcode =\n | AAM = 2\n /// ASCII Adjust AL After Subtraction.\n | AAS = 3\n- /// Add with Carry.\n+ /// Add With Carry.\n | ADC = 4\n- /// Unsigned integer add with car... | true | |
B2R2-org/B2R2 | 334 | comment_to_fix | [Intel] Update opcodes and simplify JMP/CALL/RET mnemonics | `opcodeToString` -> `toString` | 4243da40bf129515b0f51b08bada128108e47af1 | a85183e629350096feab440a111179e092391914 | diff --git a/src/FrontEnd/Intel/Opcode.fs b/src/FrontEnd/Intel/Opcode.fs
index 9a5270ebf..4e678d12d 100644
--- a/src/FrontEnd/Intel/Opcode.fs
+++ b/src/FrontEnd/Intel/Opcode.fs
@@ -24,8 +24,7 @@
namespace B2R2.FrontEnd.Intel
/// <summary>
-/// Represents an Intel opcode. This type should be generated using
-/// <c>... | [
"src/FrontEnd/Intel/Opcode.fs"
] | [
{
"comment": "`opcodeToString` -> `toString`",
"path": "src/FrontEnd/Intel/Opcode.fs",
"hunk": "@@ -36,2851 +35,5105 @@ type Opcode =\n | AAM = 2\n /// ASCII Adjust AL After Subtraction.\n | AAS = 3\n- /// Add with Carry.\n+ /// Add With Carry.\n | ADC = 4\n- /// Unsigned integer add with car... | true | ||
B2R2-org/B2R2 | 332 | issue_to_patch | [FrontEnd] Make DIE type contain its level
While our current implementation works well, its parsed DIE information lacks which child belongs to which parent, so we may add a field to `DIE` for specifying the children. | [FrontEnd] Make `DIE` type contain its level | Closes #331 | ac1bbbc68c642f46bbbcab6b53da350fa9baf82b | f29ddefc27e4765340c9d08663fb350541558974 | diff --git a/src/FrontEnd/BinFile/ELF/DIE.fs b/src/FrontEnd/BinFile/ELF/DIE.fs
index 9f31d2f0b..6478d89f6 100644
--- a/src/FrontEnd/BinFile/ELF/DIE.fs
+++ b/src/FrontEnd/BinFile/ELF/DIE.fs
@@ -31,6 +31,7 @@ type DIE =
{ Offset: uint64
Tag: DWTag
HasChildren: bool
+ Level: int
Attributes: DWParsedAt... | [
"src/FrontEnd/BinFile/ELF/DIE.fs",
"src/FrontEnd/BinFile/ELF/DebugInformation.fs",
"src/RearEnd/BinScan/ELFViewer.fs"
] | [] | true | |
B2R2-org/B2R2 | 330 | issue_to_patch | [FrontEnd] Parse debugging information from DWARF
Parsing the debugging information in DWARF would be beneficial for many purposes.
For example, using objdump,
`objdump --dwarf=info a.out`
```
<1><eee4>: Abbrev Number: 71 (DW_TAG_subprogram)
<eee5> DW_AT_name : (indirect string, offset: 0x3e37): uninit_... | Implement basic DWARF support | Closes #329 | c9da1740f610c07e309b989302bbbb613497a1ad | 992bc1d28fb218fba470e814a1fe54493f08241e | diff --git a/src/Core/ByteArray.fs b/src/Core/ByteArray.fs
index a3d681acb..fb960b312 100644
--- a/src/Core/ByteArray.fs
+++ b/src/Core/ByteArray.fs
@@ -156,3 +156,14 @@ module ByteArray =
let delta2 = makeDelta2 pattern patlen
searchOne (patlen - 1) buf pattern delta1 delta2
|> Option.map (fun idx -> ui... | [
"src/Core/ByteArray.fs",
"src/FrontEnd/API/GroundWork.fs",
"src/FrontEnd/ARM32.Tests/LifterTests.fs",
"src/FrontEnd/ARM32/RegisterFactory.fs",
"src/FrontEnd/ARM64.Tests/LifterTests.fs",
"src/FrontEnd/ARM64/RegisterFactory.fs",
"src/FrontEnd/AVR.Tests/LifterTests.fs",
"src/FrontEnd/AVR/RegisterFactory.... | [] | true | |
B2R2-org/B2R2 | 328 | issue_to_patch | [Extra] Update dotnet tool
Update b2r2.fslint to v1.0.9 | [Extra] Update dotnet tool | Close #327 | bf6c12388a7c3ebfe835115b55d2c048381ad344 | 529334b16da241a6cd058b33351e666f69e02967 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index f131672e0..4315f8390 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -10,7 +10,7 @@
"rollForward": false
},
"b2r2.fslint": {
- "version": "1.0.8",
+ "version": "1.0.9",
"commands": [
... | [
".config/dotnet-tools.json"
] | [] | true | |
B2R2-org/B2R2 | 326 | issue_to_patch | [Extra] Update dotnet tool
Update b2r2.fslint to v1.0.8 | [Extra] Update dotnet tool | 1b6e73a706f3ed641c10cb51c8355620ffc9f692 | e842171ca22ca2316d95eca0c92e15467100a632 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index af6f78e5c..f131672e0 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -10,7 +10,7 @@
"rollForward": false
},
"b2r2.fslint": {
- "version": "1.0.7",
+ "version": "1.0.8",
"commands": [
... | [
".config/dotnet-tools.json"
] | [] | true | ||
B2R2-org/B2R2 | 324 | issue_to_patch | [Extra] Update dotnet tool
Update b2r2.fslint to v1.0.7 | [Extra] Update dotnet tool | Close #323 | e88f47fed216c3e2ae93e1a987577c6b430c749b | 51630bf71c78a37cf31f589c80a560a3df2ddc43 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 0e35e2c3f..af6f78e5c 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -10,7 +10,7 @@
"rollForward": false
},
"b2r2.fslint": {
- "version": "1.0.6",
+ "version": "1.0.7",
"commands": [
... | [
".config/dotnet-tools.json"
] | [] | true | |
B2R2-org/B2R2 | 322 | issue_to_patch | [Extra] Update dotnet tool
Update b2r2.fslint to v1.0.6 | [Extra] Update dotnet tool | Close #321 | 8ab286e02e3613ee1fd0d30f4e2838fa973c6b48 | aea350dfbc41d53544e866cff56429ee5ff4f9d7 | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index 5b5bbd533..0e35e2c3f 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -10,7 +10,7 @@
"rollForward": false
},
"b2r2.fslint": {
- "version": "1.0.5",
+ "version": "1.0.6",
"commands": [
... | [
".config/dotnet-tools.json"
] | [] | true | |
B2R2-org/B2R2 | 320 | issue_to_patch | [Lint] Fix AppConvention wrong spacing
AppConvention rule fails to detect invalid infix/function spacing in some cases.
Example of invalid spacing that should be reported:
```
|| freg = regVar bld Register.F8|| freg = regVar bld Register.F10
^ Not Detected
```
Correct ... | [Lint] Fix wrong space check due to App | Close #319 | 7a6e12cfe708b2bca16bd0149a4eb1c1b26c3e71 | 5b1c2809aec4d01116e65231fe77929676575820 | diff --git a/src/FrontEnd/NameMangling/MSDemangler.fs b/src/FrontEnd/NameMangling/MSDemangler.fs
index 68d09f46b..be346d685 100644
--- a/src/FrontEnd/NameMangling/MSDemangler.fs
+++ b/src/FrontEnd/NameMangling/MSDemangler.fs
@@ -405,7 +405,7 @@ type MSDemangler() =
<|> anonymousParam
let constructedTemplate =
... | [
"src/FrontEnd/NameMangling/MSDemangler.fs",
"src/FrontEnd/SPARC/GeneralLifter.fs",
"src/FrontEnd/SPARC/ParsingMain.fs",
"src/FrontEnd/TMS320C6000/ParsingMain.fs",
"src/MiddleEnd/BinGraph/Loop.fs"
] | [] | true | |
B2R2-org/B2R2 | 318 | issue_to_patch | [Lint] Fix double newline detection
Multiple consecutive blank lines are not detected in some member-related contexts.
**Case 1: Between members**
The following excessive blank line spacing is not detected:
```
type Class() =
member _.A() =
42
member _.B() =
42
```
**Case 2: Inside member let scope**... | [Lint] Fix double newlines | Close #315 | 2042f73eefd9cd210451c61d08e82fa371567426 | 5c817ac32f82ce1810f37fc6013de8ed8a3d9e34 | diff --git a/src/Assembly/ARM32/Assembler.fs b/src/Assembly/ARM32/Assembler.fs
index b023d4f27..5c93a5f1e 100644
--- a/src/Assembly/ARM32/Assembler.fs
+++ b/src/Assembly/ARM32/Assembler.fs
@@ -89,7 +89,6 @@ type Assembler(startAddress: Addr) =
let betweenCurlyBraces s =
s |> skipWhitespaces |> between (pchar '{... | [
"src/Assembly/ARM32/Assembler.fs",
"src/FrontEnd/NameMangling/ItaniumDemangler.fs"
] | [] | true | |
B2R2-org/B2R2 | 317 | issue_to_patch | [CI] Add strict mode to lint
B2R2 uses strict lint mode by default. | [CI] Add strict mode to lint | Close #316 | 4e27cce90a6c33f2462b3e10f41f5c9c747dce85 | 753c904ef9c393e6b0d74df4a09adfa9f4d3e138 | diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index c72118e1c..3296692a4 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -16,4 +16,4 @@ jobs:
run: |
git clone --depth 1 https://github.com/B2R2-org/FSLint.git
dotnet build FSLint
- dotnet ... | [
".github/workflows/lint.yml"
] | [] | true | |
B2R2-org/B2R2 | 312 | issue_to_patch | [Visualization] Incorrect positioning due to operator precedence
There is an operator precedence bug in the part where the average value of the median is computed.
```
let mid = minX + maxX / 2
```
This code should be
```
let mid = (minX + maxX) / 2
``` | [Visualization] Fix operator precedence | Close #311
This PR fixes operator precedence issues in coordinate calculations (average median logic).
Although the expressions were ambiguous and potentially misleading, the practical impact on the layout was minimal. Since the coordinate computation still maintained relative positioning, the overall layout was... | 6c867571a225631ac929cf2b5427bdb75c1ded1a | c6aa6dfe60b7023d8df40677d7db9085aa1ea61a | diff --git a/src/RearEnd/Visualization/CoordAssignment.fs b/src/RearEnd/Visualization/CoordAssignment.fs
index d3e84a4f2..afab3d455 100644
--- a/src/RearEnd/Visualization/CoordAssignment.fs
+++ b/src/RearEnd/Visualization/CoordAssignment.fs
@@ -275,7 +275,7 @@ let averageMedian (xAlignments: FloatMap list) =
let xs ... | [
"src/RearEnd/Visualization/CoordAssignment.fs"
] | [] | true | |
B2R2-org/B2R2 | 310 | issue_to_patch | [BinExplore] Show only internal functions
Currently BinExplore lists all the functions including imported ones, but imported ones have no CFGs anyways. We should change the API to show only internal ones.
- [x] Fix the current API to show only internal ones
- [x] Introduce an additional API function for fetching the ... | [BinExplore] Fix various issuses | #309 #308 | e3772c95576c08cc1226a32d4b650429655f700f | 356c00e5a2c55271836eb58a2aa6e38c153a0859 | diff --git a/src/FrontEnd/BinFile/ELFBinFile.fs b/src/FrontEnd/BinFile/ELFBinFile.fs
index 8aaf62665..a290cc84c 100644
--- a/src/FrontEnd/BinFile/ELFBinFile.fs
+++ b/src/FrontEnd/BinFile/ELFBinFile.fs
@@ -179,15 +179,17 @@ type ELFBinFile(path, bytes: byte[], baseAddrOpt, rfOpt) =
member _.GetVMMappedRegions() =
... | [
"src/FrontEnd/BinFile/ELFBinFile.fs",
"src/FrontEnd/BinFile/IContentAddressable.fs",
"src/MiddleEnd/API/CallGraph.fs",
"src/MiddleEnd/ControlFlowAnalysis/Function.fs",
"src/RearEnd/BinExplore/API.fs",
"src/RearEnd/BinExplore/HTTPServer.fs",
"src/RearEnd/BinExplore/WebUI/js/b2r2.flowgraph.js",
"src/Rea... | [] | true | |
B2R2-org/B2R2 | 307 | issue_to_patch | [ELF] Empty symbol name for sections
Currently ELF symbols with STT_SECTION type has an empty name. This is not really wrong, but it would make more sense to show the corresponding section name instead. | [ELF] Use section name for STT_SECTION symbols | Adjusted the symbol name retrieval for STT_SECTION types. | d7cfd9374b9f7577e43063901314ecd726eca25c | 8ac1f56d507c2861de589555a9b61818d52ce4a0 | diff --git a/src/FrontEnd/BinFile/ELF/Symbol.fs b/src/FrontEnd/BinFile/ELF/Symbol.fs
index 445f6d5fa..7cefbe2cd 100644
--- a/src/FrontEnd/BinFile/ELF/Symbol.fs
+++ b/src/FrontEnd/BinFile/ELF/Symbol.fs
@@ -42,7 +42,7 @@ type Symbol =
Vis: SymbolVisibility
/// The index of the relevant section with regard to th... | [
"src/FrontEnd/BinFile/ELF/Symbol.fs",
"src/FrontEnd/BinFile/ELF/SymbolStore.fs"
] | [] | true | |
B2R2-org/B2R2 | 305 | issue_to_patch | [RearEnd] Refactor CLI tool names to BinDisasm, BinScan, and BinExplore
We are renaming the core command-line utilities to establish a consistent "Bin + Verb" naming convention. These new names better reflect the specific functionality and behavior of each tool.
- BinDump -> BinDisasm: more precise term
- FileViewer ... | [RearEnd] Rename tools | Close #300 | 4ab108ca872ccc8fcfe993807abf6681ab14fa53 | dd11d8c6e42ed57e5fb76770ad8e316324cd85df | diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json
index f30737090..afebe51d4 100644
--- a/.config/dotnet-tools.json
+++ b/.config/dotnet-tools.json
@@ -10,7 +10,7 @@
"rollForward": false
},
"b2r2.fslint": {
- "version": "0.1.0",
+ "version": "1.0.4",
"commands": [
... | [
".config/dotnet-tools.json",
"B2R2.slnx",
"src/RearEnd/Assembler/B2R2.RearEnd.Assembler.fsproj",
"src/RearEnd/BinDisasm/B2R2.RearEnd.BinDisasm.fsproj",
"src/RearEnd/BinDisasm/BinCodeDumper.fs",
"src/RearEnd/BinDisasm/BinDisasmOpts.fs",
"src/RearEnd/BinDisasm/DumpMode.fs",
"src/RearEnd/BinDisasm/Functi... | [] | true | |
B2R2-org/B2R2 | 304 | issue_to_patch | [Lint] Fix TupleConvention wrong spacing
TupleConvention rule fails to detect invalid tuple spacing in some cases.
Example of invalid spacing that should be reported:
```
| 12UL, _ , 0u -> ...
```
Correct form:
```
| 12UL, _, 0u -> ...
```
Previously, cases involving comments could cause false negatives.
This update... | [Lint] Fix tuple spacing warning | Close #303 | 6562d5c6f5cb2de1aa642088f32bf84a1c659448 | 7d9ba478a561f50ce5366d0dc8233045b0a3faa3 | diff --git a/src/FrontEnd/Intel/ParsingFunctions.fs b/src/FrontEnd/Intel/ParsingFunctions.fs
index dad2f85aa..87046b45b 100644
--- a/src/FrontEnd/Intel/ParsingFunctions.fs
+++ b/src/FrontEnd/Intel/ParsingFunctions.fs
@@ -6282,31 +6282,31 @@ let getGrp9OpKind (phlp: ParsingHelper) b regBits =
let hasREXWPref = REXPre... | [
"src/FrontEnd/Intel/ParsingFunctions.fs",
"src/FrontEnd/Intel/SSELifter.fs",
"src/FrontEnd/PPC32/Disasm.fs",
"src/FrontEnd/SPARC/Disasm.fs"
] | [] | true | |
B2R2-org/B2R2 | 302 | issue_to_patch | [Intel] Parsing error in `knotw`
Hi, i've found an error in parsing `knotw` instruction:
```asm
1240b6: c5 f8 44 d1 knotw k2,k1
```
Thank you as always! | [Intel] Add KNOTB/W/D/Q instructions | Closes #301 | c7d54c67d7fb74075b5114c5d514804e99186281 | f3205f4c2af8b8bade12855c08ac80ee87fd2145 | diff --git a/src/FrontEnd/Intel/ParsingFunctions.fs b/src/FrontEnd/Intel/ParsingFunctions.fs
index 17b457731..dad2f85aa 100644
--- a/src/FrontEnd/Intel/ParsingFunctions.fs
+++ b/src/FrontEnd/Intel/ParsingFunctions.fs
@@ -793,6 +793,20 @@ let vex0F2F = function
| MPref.MPrxF2
| _ (* MPrx66F2 *) -> raise ParsingFai... | [
"src/FrontEnd/Intel/ParsingFunctions.fs"
] | [] | true | |
B2R2-org/B2R2 | 299 | issue_to_patch | [Lint] Fix PPC32 wrong spacing
Fix PPC32 warning detected by FSLint
- Remove double spaces | [Lint] Fix PPC32 wrong space | Close #298 | 7d253fb16bc64019ac835021208b74874af2e2ab | bed23222df075cabc2beae73cb7293809fc5d166 | diff --git a/src/FrontEnd/PPC32/ParsingMain.fs b/src/FrontEnd/PPC32/ParsingMain.fs
index e5f2791b6..106dc9fa8 100644
--- a/src/FrontEnd/PPC32/ParsingMain.fs
+++ b/src/FrontEnd/PPC32/ParsingMain.fs
@@ -467,7 +467,7 @@ let parseADDCx bin =
| 0b00u -> struct (Op.ADDC, ThreeOperands(rd, ra, rb))
| 0b01u -> struct (Op... | [
"src/FrontEnd/PPC32/ParsingMain.fs"
] | [] | true | |
B2R2-org/B2R2 | 295 | issue_to_patch | [Intel] Parsing error in `vpermq`
Hello,
Instruction `vpermq` is not properly parsed now:
```assembly
d3cf8: 62 f2 fd 48 36 e1 vpermq zmm4,zmm0,zmm1
```
Thank you as always! | [Intel] Add VPERMQ instruction | Closes #294 | c69ee25dd896dd9c8435bc1ad97c507f187c985b | 5adc8df759a7ac585d60299c04873befb0df5056 | diff --git a/src/FrontEnd/Intel/ParsingFunctions.fs b/src/FrontEnd/Intel/ParsingFunctions.fs
index 430d00e78..17b457731 100644
--- a/src/FrontEnd/Intel/ParsingFunctions.fs
+++ b/src/FrontEnd/Intel/ParsingFunctions.fs
@@ -3310,6 +3310,14 @@ let vex0F3836W0 = function
| MPref.MPrxF2
| _ (* MPrx66F2 *) -> raise Pars... | [
"src/FrontEnd/Intel/ParsingFunctions.fs"
] | [] | true | |
B2R2-org/B2R2 | 293 | issue_to_patch | [Intel] Unsupported lifting of several AVX-512 instructions
Some instructions are not being properly decoded:
```asm
2efcb6: 62 f1 65 08 72 c3 10 vprord xmm3,xmm3,0x10
2b2cfb: 62 f3 7d 48 39 c0 03 vextracti32x4 xmm0,zmm0,0x3
acbf0: 62 f3 fd 48 03 d9 01 valignq zmm3,zmm0,zmm1,0x1
```
Thank yo... | [Intel] Add instructions | Closes #292 | 037cc0e526b05cc2394b187ce9511dc1868cee7b | 4d92ff206eb1a2dc0459f5e200fdb87b6edac236 | diff --git a/src/FrontEnd/Intel/ParsingFunctions.fs b/src/FrontEnd/Intel/ParsingFunctions.fs
index 66ba15c45..430d00e78 100644
--- a/src/FrontEnd/Intel/ParsingFunctions.fs
+++ b/src/FrontEnd/Intel/ParsingFunctions.fs
@@ -5163,6 +5163,22 @@ let vex0F3A02W0 = function
| MPref.MPrxF2
| _ (* MPrx66F2 *) -> raise Pars... | [
"src/FrontEnd/Intel/ParsingFunctions.fs"
] | [] | true | |
B2R2-org/B2R2 | 271 | issue_to_patch | [PPC64] Implement automated parsing logic | Closes #267 | 9cabd280f482ed7901e89ea5e33f6be667cdc3f3 | 6275ad02a126b3e4742a9a3c4ac10554ae78c6e7 | diff --git a/src/FrontEnd/PPC.Tests/ParserTests.fs b/src/FrontEnd/PPC.Tests/ParserTests.fs
index 439eeddca..dbc8bc44b 100644
--- a/src/FrontEnd/PPC.Tests/ParserTests.fs
+++ b/src/FrontEnd/PPC.Tests/ParserTests.fs
@@ -953,7 +953,7 @@ type ArithmeticClass() =
[<TestMethod>]
member _.``[PPC64] Fixed-Point Load/Store... | [
"src/FrontEnd/PPC.Tests/ParserTests.fs",
"src/FrontEnd/PPC/Disasm.fs",
"src/FrontEnd/PPC/Opcode.fs",
"src/FrontEnd/PPC/ParsingMain.fs",
"src/FrontEnd/PPC/code_generation.py",
"src/FrontEnd/PPC/pdf_parsing.py"
] | [] | true | ||
B2R2-org/B2R2 | 289 | issue_to_patch | [ARM32] Fix incorrect property handling for CBZ and CBNZ instructions
There are incorrect implementations for `CBZ` and `CBNZ` properties in `src/FrontEnd/ARM32/Instruction.fs`.
Currently, `CBZ` and `CBNZ` are represented with the following operands:
```fsharp
Opcode.CBZ, TwoOperands(_, OprMemory(LiteralMode target)... | Fix incorrect property handling for CBZ/CBNZ | Fix #288 | 90ddad856f1ea7c4a2d2e19da6ecba52f55c91d7 | 505a8c4a347c9b8e08ae63f78fc6598e093a40d1 | diff --git a/src/FrontEnd/ARM32/Instruction.fs b/src/FrontEnd/ARM32/Instruction.fs
index 22b6dbd59..657277230 100644
--- a/src/FrontEnd/ARM32/Instruction.fs
+++ b/src/FrontEnd/ARM32/Instruction.fs
@@ -127,6 +127,8 @@ type Instruction
| Op.BX, Condition.NV, _ -> false
| Op.BX, Condition.UN, _ -> false
... | [
"src/FrontEnd/ARM32/Instruction.fs"
] | [] | true | |
B2R2-org/B2R2 | 287 | issue_to_patch | [Intel] Parsing failure in VIA/Zhaoxin PadLock instructions
```
6493a2: 0f a7 c0 xstore-rng
69c7e1: f3 0f a6 c8 repz xsha1
69c863: f3 0f a6 d0 repz xsha256
649eec: f3 0f a7 d8 repz xcrypt-ctr
649392: f3 0f a7 c8 rep... | [Intel] Add PadLock instructions | Closes #286 | b471766c84d5b9a5a824fa8e52a01a062527ce4c | b4a26686ccdb1cdb3e5561e4da5076c0b23da5f1 | diff --git a/scripts/genOpcode.fsx b/scripts/genOpcode.fsx
index b9999ecd0..60347c4a6 100755
--- a/scripts/genOpcode.fsx
+++ b/scripts/genOpcode.fsx
@@ -26,7 +26,7 @@
open System.Text.RegularExpressions
let split line =
- let r = new Regex("(\/\/\/ .+)?([a-zA-Z0-9]+)?\s*(\(\*.+\*\))?")
+ let r = new Regex("(\/\/\... | [
"scripts/genOpcode.fsx",
"src/FrontEnd/Intel/Disasm.fs",
"src/FrontEnd/Intel/IntelSupportedOpcodes.txt",
"src/FrontEnd/Intel/Opcode.fs",
"src/FrontEnd/Intel/ParsingFunctions.fs"
] | [] | true | |
B2R2-org/B2R2 | 285 | issue_to_patch | [Intel] Disassembly errors in sha family
```
589b04: 0f 38 c9 e5 sha1msg1 xmm4,xmm5
...
5e354c: 0f 38 cb d1 sha256rnds2 xmm2,xmm1,xmm0
```
These instructions are not properly disassembled in our front-end now. | [Intel] Add SHA family instructions | Closes #279 | 2d88eddd81eac868b8e3de8e6050a1b8574f30d3 | 858a721e129fbf5161a1ae3bc6bbd6cf57912bed | diff --git a/src/FrontEnd/Intel/Lifter.fs b/src/FrontEnd/Intel/Lifter.fs
index 683117546..96137c903 100644
--- a/src/FrontEnd/Intel/Lifter.fs
+++ b/src/FrontEnd/Intel/Lifter.fs
@@ -208,7 +208,8 @@ let translate (ins: Instruction) insLen bld =
| OP.LMSW | OP.LSL | OP.LTR | OP.OUT | OP.SGDT
| OP.SIDT | OP.SLDT | OP... | [
"src/FrontEnd/Intel/Lifter.fs",
"src/FrontEnd/Intel/ParsingFunctions.fs"
] | [] | true | |
B2R2-org/B2R2 | 284 | issue_to_patch | [PPC64] Implementation of Parsing and Lifting for the ls Binary | Closes #278 | e5a97c6ec593232cddc592e4f45258440cbc29d4 | 09e36ffba9dd8fd56cf1d634d076a985d570367f | diff --git a/src/FrontEnd/PPC.Tests/ParserTests.fs b/src/FrontEnd/PPC.Tests/ParserTests.fs
index 62b06dc47..9bf5fc8e8 100644
--- a/src/FrontEnd/PPC.Tests/ParserTests.fs
+++ b/src/FrontEnd/PPC.Tests/ParserTests.fs
@@ -56,9 +56,6 @@ module private Shortcut =
static member BO(bo) =
OprBO bo
- static membe... | [
"src/FrontEnd/PPC.Tests/ParserTests.fs",
"src/FrontEnd/PPC/Disasm.fs",
"src/FrontEnd/PPC/Lifter.fs",
"src/FrontEnd/PPC/Opcode.fs",
"src/FrontEnd/PPC/Operands.fs",
"src/FrontEnd/PPC/ParsingMain.fs",
"src/FrontEnd/PPC/RegisterFactory.fs",
"src/FrontEnd/PPC/code_generation.py",
"src/FrontEnd/PPC/pdf_pa... | [] | true | ||
B2R2-org/B2R2 | 283 | issue_to_patch | [Build] Upgrade to .NET 10
Now that .NET 10 is available, we'd better use it.
- [x] Update dependencies and push them to Nuget before proceeding.
- [x] Use slnx (#74)
- [x] Update README.md | 282 build upgrade to net 10 | 5cecf22386393f778182454729c4798fd58a0951 | ede197d425b2763478a16f708f0272757ee1bcf0 | diff --git a/.github/workflows/debug.yml b/.github/workflows/debug.yml
index c9103e706..042210dac 100644
--- a/.github/workflows/debug.yml
+++ b/.github/workflows/debug.yml
@@ -15,8 +15,6 @@ jobs:
- uses: actions/checkout@v4
- name: Setup .NET
uses: actions/setup-dotnet@v4
- with:
- dotnet-... | [
".github/workflows/debug.yml",
".github/workflows/docs.yml",
".github/workflows/lint.yml",
".github/workflows/publish.yml",
".github/workflows/push.yml",
".github/workflows/release.yml",
"B2R2.sln",
"B2R2.slnx",
"Directory.Build.props",
"README.md",
"src/Assembly.Tests/B2R2.Assembly.Tests.fsproj... | [] | true | ||
B2R2-org/B2R2 | 280 | issue_to_patch | [Intel] Disassembly errors in sha family
```
589b04: 0f 38 c9 e5 sha1msg1 xmm4,xmm5
...
5e354c: 0f 38 cb d1 sha256rnds2 xmm2,xmm1,xmm0
```
These instructions are not properly disassembled in our front-end now. | [Intel] Add SHA1MSG1/SHA256RNDS2 instructions | Closes #279 | a6a96543a3451c933faccf969e676fb03e8b10d7 | 0b096830061436c99c48071f3ed8bcbeaf457886 | diff --git a/src/FrontEnd/Intel/Lifter.fs b/src/FrontEnd/Intel/Lifter.fs
index 29581535b..683117546 100644
--- a/src/FrontEnd/Intel/Lifter.fs
+++ b/src/FrontEnd/Intel/Lifter.fs
@@ -208,6 +208,8 @@ let translate (ins: Instruction) insLen bld =
| OP.LMSW | OP.LSL | OP.LTR | OP.OUT | OP.SGDT
| OP.SIDT | OP.SLDT | OP... | [
"src/FrontEnd/Intel/Lifter.fs",
"src/FrontEnd/Intel/ParsingFunctions.fs"
] | [] | true | |
B2R2-org/B2R2 | 277 | issue_to_patch | [PPC64] Add lifting for arithmetic instructions | b51f3fe2bdd607a98bc11cd09f8190d4bfaec4de | 09417303b2549843a09cc692ec17c4b8318609ae | diff --git a/src/FrontEnd/PPC.Tests/ParserTests.fs b/src/FrontEnd/PPC.Tests/ParserTests.fs
index 152ea4dcc..62b06dc47 100644
--- a/src/FrontEnd/PPC.Tests/ParserTests.fs
+++ b/src/FrontEnd/PPC.Tests/ParserTests.fs
@@ -119,13 +119,13 @@ type ArithmeticClass() =
[<TestMethod>]
member _.``[PPC64] Arithmetic Instructi... | [
"src/FrontEnd/PPC.Tests/ParserTests.fs",
"src/FrontEnd/PPC/Lifter.fs",
"src/FrontEnd/PPC/ParsingMain.fs",
"src/FrontEnd/PPC/RegisterFactory.fs",
"src/FrontEnd/PPC/code_generation.py"
] | [] | true | |||
B2R2-org/B2R2 | 276 | issue_to_patch | [PPC64] Automated Unit Testing | 1cda80af0fc615a40990c28df2117e8fcf000e83 | 0156117daa58f00c16afa746d5d537c971aa1931 | diff --git a/src/FrontEnd/PPC.Tests/ParserTests.fs b/src/FrontEnd/PPC.Tests/ParserTests.fs
index dbc8bc44b..152ea4dcc 100644
--- a/src/FrontEnd/PPC.Tests/ParserTests.fs
+++ b/src/FrontEnd/PPC.Tests/ParserTests.fs
@@ -62,6 +62,24 @@ module private Shortcut =
static member BH(bh) =
OprBH bh
+ static memb... | [
"src/FrontEnd/PPC.Tests/ParserTests.fs",
"src/FrontEnd/PPC/ParsingMain.fs",
"src/FrontEnd/PPC/code_generation.py",
"src/FrontEnd/PPC/generate_byte_codes.py",
"src/FrontEnd/Registers/PPC.fs"
] | [] | true | |||
B2R2-org/B2R2 | 273 | issue_to_patch | [PPC64] Add miscellaneous instruction support | Closes #272 | cb735369707f4468fb9a883385dbc7a9709cbd97 | 0a418384a8f2974dd14d67c4c88dd6953767c375 | diff --git a/src/FrontEnd/PPC/Disasm.fs b/src/FrontEnd/PPC/Disasm.fs
index dd33673d8..7021f5502 100644
--- a/src/FrontEnd/PPC/Disasm.fs
+++ b/src/FrontEnd/PPC/Disasm.fs
@@ -175,6 +175,381 @@ let opCodeToString =
| Op.LSWX -> "lswx"
| Op.STSWI -> "stswi"
| Op.STSWX -> "stswx"
+ | Op.CMPI -> "cmpi"
+ | Op.CMP ... | [
"src/FrontEnd/PPC/Disasm.fs",
"src/FrontEnd/PPC/Opcode.fs",
"src/FrontEnd/PPC/Operands.fs",
"src/FrontEnd/PPC/ParsingMain.fs",
"src/FrontEnd/PPC/code_generation.py",
"src/FrontEnd/PPC/pdf_parsing.py",
"src/FrontEnd/Registers/PPC.fs"
] | [] | true | ||
B2R2-org/B2R2 | 269 | issue_to_patch | [Assembly] B2R2 Assembler Fails to Detect Duplicate Labels
# PoC
The B2R2 assembler does not properly validate and reject duplicate symbol definitions. This can lead to silent errors and unpredictable behavior in the generated shellcode, as the assembler silently overwrites the address of the first label with the seco... | [Assembly] Add duplicate label check | Closes #266 | ba7f157aa680169a6e8aec7ed21dd003dd37fc5f | 65c693aad708a5d1e4dad1f63b2e6ad2e387d06c | diff --git a/src/Assembly/Intel/Assembler.fs b/src/Assembly/Intel/Assembler.fs
index ee0171aa0..680af3e43 100644
--- a/src/Assembly/Intel/Assembler.fs
+++ b/src/Assembly/Intel/Assembler.fs
@@ -48,7 +48,10 @@ type Assembler(isa: ISA, baseAddr: Addr) =
let addLabeldef lbl =
updateUserState (fun us ->
- { u... | [
"src/Assembly/Intel/Assembler.fs"
] | [
{
"comment": "Use string interpolation than `sprintf`",
"path": "src/Assembly/Intel/Assembler.fs",
"hunk": "@@ -48,7 +48,11 @@ type Assembler(isa: ISA, baseAddr: Addr) =\n \n let addLabeldef lbl =\n updateUserState (fun us ->\n- { us with LabelMap = Map.add lbl us.CurIndex us.LabelMap })\n+ ... | true | |
B2R2-org/B2R2 | 269 | comment_to_fix | [Assembly] Add duplicate label check | Use string interpolation than `sprintf` | ba7f157aa680169a6e8aec7ed21dd003dd37fc5f | 65c693aad708a5d1e4dad1f63b2e6ad2e387d06c | diff --git a/src/Assembly/Intel/Assembler.fs b/src/Assembly/Intel/Assembler.fs
index ee0171aa0..680af3e43 100644
--- a/src/Assembly/Intel/Assembler.fs
+++ b/src/Assembly/Intel/Assembler.fs
@@ -48,7 +48,10 @@ type Assembler(isa: ISA, baseAddr: Addr) =
let addLabeldef lbl =
updateUserState (fun us ->
- { u... | [
"src/Assembly/Intel/Assembler.fs"
] | [
{
"comment": "Use string interpolation than `sprintf`",
"path": "src/Assembly/Intel/Assembler.fs",
"hunk": "@@ -48,7 +48,11 @@ type Assembler(isa: ISA, baseAddr: Addr) =\n \n let addLabeldef lbl =\n updateUserState (fun us ->\n- { us with LabelMap = Map.add lbl us.CurIndex us.LabelMap })\n+ ... | true | ||
B2R2-org/B2R2 | 268 | issue_to_patch | [Assembly] Intel Assembler fails to encode `mov [esp], cl`
When assembling `mov [esp], cl` using the Intel assembler in B2R2 (x86 / 32-bit mode), the encoder throws an `EncodingFailureException` (expected encoding: `88 0C 24`).
Test Code:
```fsharp
open B2R2
open B2R2.Assembly.BinLowerer
open B2R2.Assembly.Intel
[<... | [Assembly] Resolve memory size via register in MOV | Closes #265 | 584a82fbdc74e071135951816e6bc5e6d612de44 | 9d6b2f1926bc59332c8984d0d7c375b4f2063fed | diff --git a/src/Assembly/BinLowerer/Exceptions.fs b/src/Assembly/BinLowerer/Exceptions.fs
index 1f78ad857..858a03ac3 100644
--- a/src/Assembly/BinLowerer/Exceptions.fs
+++ b/src/Assembly/BinLowerer/Exceptions.fs
@@ -26,4 +26,4 @@ namespace B2R2.Assembly.BinLowerer
/// Raised when the given assembly code cannot be l... | [
"src/Assembly/BinLowerer/Exceptions.fs",
"src/Assembly/Intel/AsmMain.fs",
"src/Assembly/Intel/AsmOpcode.fs",
"src/Assembly/Intel/Assembler.fs"
] | [] | true | |
B2R2-org/B2R2 | 264 | issue_to_patch | [PPC64] Add Fixed-Point Load/Store instructions | Closes #263 | cd7ce55ea3ac4ee94abd954cd154dc2caba8ad7c | a5ec31e6cc9f9a34890a0af585011e11de40dde8 | diff --git a/src/FrontEnd/PPC.Tests/ParserTests.fs b/src/FrontEnd/PPC.Tests/ParserTests.fs
index 648f90beb..439eeddca 100644
--- a/src/FrontEnd/PPC.Tests/ParserTests.fs
+++ b/src/FrontEnd/PPC.Tests/ParserTests.fs
@@ -35,11 +35,14 @@ open type Register
[<AutoOpen>]
module private Shortcut =
type O =
- static mem... | [
"src/FrontEnd/PPC.Tests/ParserTests.fs",
"src/FrontEnd/PPC/Disasm.fs",
"src/FrontEnd/PPC/Opcode.fs",
"src/FrontEnd/PPC/Operands.fs",
"src/FrontEnd/PPC/ParsingMain.fs"
] | [
{
"comment": "1. Use `Bits.pick` when extracting a single byte.\r\n2. `checkIfZero` ends with raise, so let binding is unnecessary.\r\n",
"path": "src/FrontEnd/PPC/ParsingMain.fs",
"hunk": "@@ -319,6 +382,90 @@ let getOperands (opcode: Opcode) (bin: uint32) (addr: Addr) =\n let _ = Bits.extract bin ... | true | ||
B2R2-org/B2R2 | 259 | issue_to_patch | [PPC64] Add branch instructions | Closes #255 | 108a047351a1b2c5762a0b3ee493275fcaf8c385 | a5b7edf3f08417963a7542094f9e9de938f52ea5 | diff --git a/src/FrontEnd/PPC.Tests/ParserTests.fs b/src/FrontEnd/PPC.Tests/ParserTests.fs
index ff278b3d4..648f90beb 100644
--- a/src/FrontEnd/PPC.Tests/ParserTests.fs
+++ b/src/FrontEnd/PPC.Tests/ParserTests.fs
@@ -41,11 +41,23 @@ module private Shortcut =
static member Imm(v) =
OprImm v
- static mem... | [
"src/FrontEnd/PPC.Tests/ParserTests.fs",
"src/FrontEnd/PPC/B2R2.FrontEnd.PPC.fsproj",
"src/FrontEnd/PPC/Disasm.fs",
"src/FrontEnd/PPC/Field.fs",
"src/FrontEnd/PPC/Form.fs",
"src/FrontEnd/PPC/Opcode.fs",
"src/FrontEnd/PPC/Operands.fs",
"src/FrontEnd/PPC/ParsingMain.fs"
] | [] | true | ||
B2R2-org/B2R2 | 262 | issue_to_patch | [BinIR] Support APP in BinOpType string conversion
Currently, our front-end does not convert BinOpType `APP` to or from a string, which causes errors when displaying the SSA representation. | [BinExplorer] Support EVM in BinExplorer | Closes #260 and #261 | fb5d32515e878cabda0ae7d3758f817f3ebc88eb | edc0c720cf687a46900c5155397bb37c7f995bcc | diff --git a/src/BinIR/BinOpType.fs b/src/BinIR/BinOpType.fs
index 346fe480c..a5819f327 100644
--- a/src/BinIR/BinOpType.fs
+++ b/src/BinIR/BinOpType.fs
@@ -74,56 +74,47 @@ type BinOpType =
/// </summary>
[<RequireQualifiedAccess>]
module BinOpType =
+ let private symbols =
+ [ (BinOpType.ADD, "+")
+ (BinOp... | [
"src/BinIR/BinOpType.fs",
"src/MiddleEnd/ControlFlowGraph/DisasmCFG.fs"
] | [
{
"comment": "Please provide an example here and above for future references.",
"path": "src/MiddleEnd/ControlFlowGraph/DisasmCFG.fs",
"hunk": "@@ -308,3 +335,10 @@ and private TemporaryDisasmVertex =\n \n /// Mapping from address to TemporaryDisasmVertex.\n and private DisasmVMap = Dictionary<Addr, Tem... | true | |
B2R2-org/B2R2 | 258 | issue_to_patch | [PPC64] Add unit tests for arithmetic instructions | 840f504f2d0ad9f22428c44e65a248e695703ebf | d9e4a9b3601a0f84715735a7105d9dfac8f13417 | diff --git a/src/FrontEnd/PPC.Tests/ParserTests.fs b/src/FrontEnd/PPC.Tests/ParserTests.fs
index 466e160dd..ff278b3d4 100644
--- a/src/FrontEnd/PPC.Tests/ParserTests.fs
+++ b/src/FrontEnd/PPC.Tests/ParserTests.fs
@@ -41,6 +41,12 @@ module private Shortcut =
static member Imm(v) =
OprImm v
+ static memb... | [
"src/FrontEnd/PPC.Tests/ParserTests.fs"
] | [] | true | |||
B2R2-org/B2R2 | 252 | issue_to_patch | [PPC64] Add arithmetic instructions | Closes #250 | a5dd1cd2e3b683abd57317bcebc36baf3c33c1b4 | 7c9891ece396e378b239bc548df22258306325f8 | diff --git a/src/FrontEnd/PPC/B2R2.FrontEnd.PPC.fsproj b/src/FrontEnd/PPC/B2R2.FrontEnd.PPC.fsproj
index 1cf6755cf..fd3859cef 100644
--- a/src/FrontEnd/PPC/B2R2.FrontEnd.PPC.fsproj
+++ b/src/FrontEnd/PPC/B2R2.FrontEnd.PPC.fsproj
@@ -9,6 +9,8 @@
<ItemGroup>
<Compile Include="RegisterFactory.fs" />
+ <Compil... | [
"src/FrontEnd/PPC/B2R2.FrontEnd.PPC.fsproj",
"src/FrontEnd/PPC/Disasm.fs",
"src/FrontEnd/PPC/Field.fs",
"src/FrontEnd/PPC/Form.fs",
"src/FrontEnd/PPC/Opcode.fs",
"src/FrontEnd/PPC/Operands.fs",
"src/FrontEnd/PPC/ParsingMain.fs",
"src/FrontEnd/Registers/PPC.fs"
] | [] | true | ||
B2R2-org/B2R2 | 254 | issue_to_patch | [RearEnd] Introducing BiHexLang
Currently, BinExplorer defines its own simple language for its CLI interface, but the language design is adhoc and needs significant improvement. We also want to shift the language implementation to another namespace so that other projects can reuse it.
We will call the new language Bi... | 253 rearend introducing bihexlang | #253 | f2c535f772fafa2cc658fb917fe8b579c6fa4efe | 1a20a2c801115d85b785250222e0f4831edd54e5 | diff --git a/B2R2.sln b/B2R2.sln
index d001b9c54..2d892fa25 100644
--- a/B2R2.sln
+++ b/B2R2.sln
@@ -1,3 +1,4 @@
+
Microsoft Visual Studio Solution File, Format Version 12.00
Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "B2R2.FrontEnd.Registers", "src\FrontEnd\Registers\B2R2.FrontEnd.Registers.fsproj", "{2E1CC... | [
"B2R2.sln",
"src/RearEnd/BiHexLang.Tests/AST.Tests.fs",
"src/RearEnd/BiHexLang.Tests/B2R2.RearEnd.BiHexLang.Tests.fsproj",
"src/RearEnd/BiHexLang.Tests/Evaluator.Tests.fs",
"src/RearEnd/BiHexLang.Tests/Number.Tests.fs",
"src/RearEnd/BiHexLang/B2R2.RearEnd.BiHexLang.fsproj",
"src/RearEnd/BiHexLang/Evalua... | [
{
"comment": "[nitpick] The solution file has an unnecessary empty line at the beginning. This should be removed to maintain clean file formatting.",
"path": "src/RearEnd/RearEnd.sln",
"hunk": "@@ -89,192 +90,584 @@ Project(\"{F2A71F9B-5D33-465A-A702-920D77279786}\") = \"B2R2.RearEnd.Utils\", \"Utils\n ... | true | |
B2R2-org/B2R2 | 254 | comment_to_fix | 253 rearend introducing bihexlang | [nitpick] The solution file has an unnecessary empty line at the beginning. This should be removed to maintain clean file formatting. | f2c535f772fafa2cc658fb917fe8b579c6fa4efe | 1a20a2c801115d85b785250222e0f4831edd54e5 | diff --git a/src/RearEnd/RearEnd.sln b/src/RearEnd/RearEnd.sln
index 2d744a328..a9a562baa 100644
--- a/src/RearEnd/RearEnd.sln
+++ b/src/RearEnd/RearEnd.sln
@@ -1,3 +1,4 @@
+
Microsoft Visual Studio Solution File, Format Version 12.00
Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "B2R2.RearEnd.Assembler", "Asse... | [
"src/RearEnd/RearEnd.sln"
] | [
{
"comment": "[nitpick] The solution file has an unnecessary empty line at the beginning. This should be removed to maintain clean file formatting.",
"path": "src/RearEnd/RearEnd.sln",
"hunk": "@@ -89,192 +90,584 @@ Project(\"{F2A71F9B-5D33-465A-A702-920D77279786}\") = \"B2R2.RearEnd.Utils\", \"Utils\n ... | true | ||
B2R2-org/B2R2 | 254 | comment_to_fix | 253 rearend introducing bihexlang | The Show command implementation is incomplete - it only returns help text regardless of input. The match statement should handle specific subcommands like 'caller' and 'callee' as mentioned in the help text.
```suggestion
| [| "caller"; addr |] ->
[| sprintf "Showing callers of instruction at address %s... | f2c535f772fafa2cc658fb917fe8b579c6fa4efe | 1a20a2c801115d85b785250222e0f4831edd54e5 | diff --git a/src/RearEnd/BinExplorer/CmdUtils.fs b/src/RearEnd/BinExplorer/Commands/Show.fs
similarity index 60%
rename from src/RearEnd/BinExplorer/CmdUtils.fs
rename to src/RearEnd/BinExplorer/Commands/Show.fs
index 4e154982f..c88acf5c0 100644
--- a/src/RearEnd/BinExplorer/CmdUtils.fs
+++ b/src/RearEnd/BinExplorer/Co... | [
"src/RearEnd/BinExplorer/Commands/Show.fs"
] | [
{
"comment": "The Show command implementation is incomplete - it only returns help text regardless of input. The match statement should handle specific subcommands like 'caller' and 'callee' as mentioned in the help text.\n```suggestion\n | [| \"caller\"; addr |] ->\n [| sprintf \"Showing callers ... | true | ||
B2R2-org/B2R2 | 254 | comment_to_fix | 253 rearend introducing bihexlang | The `adjustPosition` function is defined but never used in the codebase. Consider removing this unused function or documenting why it's being kept for future use.
```suggestion
``` | f2c535f772fafa2cc658fb917fe8b579c6fa4efe | 1a20a2c801115d85b785250222e0f4831edd54e5 | diff --git a/src/RearEnd/BiHexLang/Parser.fs b/src/RearEnd/BiHexLang/Parser.fs
new file mode 100644
index 000000000..9eb916202
--- /dev/null
+++ b/src/RearEnd/BiHexLang/Parser.fs
@@ -0,0 +1,170 @@
+(*
+ B2R2 - the Next-Generation Reversing Platform
+
+ Copyright (c) SoftSec Lab. @ KAIST, since 2016
+
+ Permission is... | [
"src/RearEnd/BiHexLang/Parser.fs"
] | [
{
"comment": "The `adjustPosition` function is defined but never used in the codebase. Consider removing this unused function or documenting why it's being kept for future use.\n```suggestion\n\n```",
"path": "src/RearEnd/BiHexLang/Parser.fs",
"hunk": "@@ -0,0 +1,174 @@\n+(*\n+ B2R2 - the Next-Generati... | true | ||
B2R2-org/B2R2 | 251 | issue_to_patch | [PPC64] Fix ADDI instruction | 8971c7332ddd41a3f0ed3d132128bc711b307f6a | c133d62884e6749d6b5da2fa9a101e242d362f03 | diff --git a/src/FrontEnd/PPC/Disasm.fs b/src/FrontEnd/PPC/Disasm.fs
index 14d59db59..cfb35a3a5 100644
--- a/src/FrontEnd/PPC/Disasm.fs
+++ b/src/FrontEnd/PPC/Disasm.fs
@@ -27,7 +27,8 @@ module internal B2R2.FrontEnd.PPC.Disasm
open B2R2
open B2R2.FrontEnd.BinLifter
-let opCodeToString = function
+let opCodeToStrin... | [
"src/FrontEnd/PPC/Disasm.fs",
"src/FrontEnd/PPC/Operands.fs",
"src/FrontEnd/PPC/ParsingMain.fs"
] | [] | true | |||
B2R2-org/B2R2 | 247 | issue_to_patch | [FrontEnd] MIPS64 lifting errors
- Lifting `swl` and `swr` causes `TypeCheckException`.
- Lifting `movf.d`, `movz.d`, `movt.d`, and `movn.d` causes `InvalidAssignmentException`.
- `nmadd` instruction lifting is not implemented.
# Reproduce
- `swl at, 3(v0)`:
```
b2r2 dump -s 030041A8 -i mips64 --lift
```
- `movf.d ... | [MIPS] Fix MOV/Store translations | - Add NMADD translation | 8c325085480538330324d52134b99cd84472ca73 | a4a4dc378dd89e83e246298070e43429ee846cc4 | diff --git a/src/FrontEnd/MIPS/Lifter.fs b/src/FrontEnd/MIPS/Lifter.fs
index f9cf72051..5cc136d4d 100644
--- a/src/FrontEnd/MIPS/Lifter.fs
+++ b/src/FrontEnd/MIPS/Lifter.fs
@@ -498,6 +498,28 @@ let private reDupSrc opr1 opr2 expr1 expr2 tmp1 tmp2 bld =
bld <+ (tmp1 := expr1)
bld <+ (tmp2 := expr2)
+let priv... | [
"src/FrontEnd/MIPS/Lifter.fs"
] | [] | true | |
B2R2-org/B2R2 | 244 | issue_to_patch | [FrontEnd] Add missing pattern for MIPS register `NPC`
`NPC` register not handled | [FrontEnd] Add pattern for MIPS register NPC | Closes #243 | c29738e1d1ddcff2b1d83c55151448bc2f48c277 | 65c04ef2d9df1f2af9326595cff2961962bbdf0d | diff --git a/src/FrontEnd/Registers/MIPS.fs b/src/FrontEnd/Registers/MIPS.fs
index b622de01f..feaf0d55f 100644
--- a/src/FrontEnd/Registers/MIPS.fs
+++ b/src/FrontEnd/Registers/MIPS.fs
@@ -262,6 +262,7 @@ module Register =
| "hi" -> Register.HI
| "lo" -> Register.LO
| "pc" -> Register.PC
+ | "npc" -> ... | [
"src/FrontEnd/Registers/MIPS.fs"
] | [] | true | |
B2R2-org/B2R2 | 245 | issue_to_patch | [MIPS] Remove IEMark from Branch instructions
Related to #203 | [MIPS] Remove IEMark from advancePC | Closes #239 | c29738e1d1ddcff2b1d83c55151448bc2f48c277 | 887ff0a0c5087e4d2b7abb4f1b475ca677a3abe2 | diff --git a/src/FrontEnd/MIPS/Lifter.fs b/src/FrontEnd/MIPS/Lifter.fs
index 7966de7fc..f9cf72051 100644
--- a/src/FrontEnd/MIPS/Lifter.fs
+++ b/src/FrontEnd/MIPS/Lifter.fs
@@ -375,13 +375,15 @@ let private normalizeValue oprSz result bld =
(AST.ite infBox infWithSign result)))
result)
-let advanc... | [
"src/FrontEnd/MIPS/Lifter.fs"
] | [] | true | |
B2R2-org/B2R2 | 241 | issue_to_patch | [CI] Push to nuget.org when a new release comes out
Currently [the workflow](https://github.com/B2R2-org/B2R2/blob/main/.github/workflows/publish.yml) publishes packages to github.com. But we want to publish packages to nuget.org. | [CI] Change package target from github to nuget | 2725a75a1440068fa1af2da37b3d3c8e43c67d76 | bcef174a1da9b9ee5a5250a848ab8e109ff70ead | diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml
index 5ab0aa963..f7ff51a67 100644
--- a/.github/workflows/publish.yml
+++ b/.github/workflows/publish.yml
@@ -24,8 +24,9 @@ jobs:
run: dotnet pack -c Release --output .
- name: Push
env:
- TOKEN: ${{ secrets.GITHUB_TOKE... | [
".github/workflows/publish.yml"
] | [] | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 930 | issue_to_patch | msg next step is "scan residues"
reHello Marcin
I don't remember if I made this comment before:
The last window at the end of an uninstallation does not indicate that the next step is to search for "vestiges" in french, traces that can be removed, residues. It seems to me that it would be better to indicate this l... | Clarify uninstall progress - leftover scan next step | Fixes #481.
Updates the uninstall progress finished state to clarify that closing the progress window continues the workflow and may prompt for leftover scanning.
Added the new status text to the default resources and localized resources.
German translated by myself, the others by using Translation AI for: Span... | 51d6ca7728ff51a45daf0771c3a6aaf9098967fe | 15650c83f0bc2c9e91ad63cbe3cf483040a70288 | diff --git a/source/BulkCrapUninstaller/Forms/Windows/UninstallProgressWindow.cs b/source/BulkCrapUninstaller/Forms/Windows/UninstallProgressWindow.cs
index acc7c313..a5942d6b 100644
--- a/source/BulkCrapUninstaller/Forms/Windows/UninstallProgressWindow.cs
+++ b/source/BulkCrapUninstaller/Forms/Windows/UninstallProgres... | [
"source/BulkCrapUninstaller/Forms/Windows/UninstallProgressWindow.cs",
"source/BulkCrapUninstaller/Properties/Localisable.Designer.cs",
"source/BulkCrapUninstaller/Properties/Localisable.de.resx",
"source/BulkCrapUninstaller/Properties/Localisable.es.resx",
"source/BulkCrapUninstaller/Properties/Localisable... | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 928 | issue_to_patch | Doesnt remove leftovers
A bit ironic, that BC Uninstaller itself leaves crap behind.
<img width="918" height="557" alt="Image" src="https://github.com/user-attachments/assets/43d50999-68ce-4f1a-af1f-1e59b3718650" /> | BugFix #896 Clean generated files on uninstall | Fixes #896.
Adds Inno Setup `[UninstallDelete]` entries for files generated by BCU itself, including settings, logs, info/certificate caches, usage statistics, rating caches, and crash report zips. Installed files are still handled by the normal Inno uninstall log.
I ran testing against the old & new uninstall an... | b391b5b4929c0577b1055921662791a905cb115b | 85491eb9c3163e3c0ba1db76081c58b3eed600b6 | diff --git a/installer/BcuSetup.iss b/installer/BcuSetup.iss
index 365f0c22..d4374a16 100644
--- a/installer/BcuSetup.iss
+++ b/installer/BcuSetup.iss
@@ -135,13 +135,23 @@ Name: {app}\win-x64; Type: filesandordirs
Name: {app}\win-x86; Type: filesandordirs
[UninstallDelete]
-; Try to remove all leftover files
-... | [
"installer/BcuSetup.iss"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 894 | issue_to_patch | [Feature Request] [Accessibility + Convenience] Provide a 'Status' text column matching app list background color
The background color of items in the main window application list are used to convey the information for the state of an app (Verified Certificate, Unverified, Unregistered application, Windows Store App, ... | Add certificate and integrity columns to app list | Closes #814
## Summary
This PR adds two explicit text columns to the app list:
- `Certificate`
- `Integrity`
## Changes
- replace the previous single `Status` column approach
- add a `Certificate` column with `None` / `Unverified` / `Verified`
- add an `Integrity` column with:
- `Good`
- `Missing ... | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | 1374fcfab53f366df8fd763136272fcda04d2b49 | diff --git a/source/BulkCrapUninstaller/BulkCrapUninstaller.csproj b/source/BulkCrapUninstaller/BulkCrapUninstaller.csproj
index ecc183a7..1a3167ce 100644
--- a/source/BulkCrapUninstaller/BulkCrapUninstaller.csproj
+++ b/source/BulkCrapUninstaller/BulkCrapUninstaller.csproj
@@ -47,19 +47,23 @@
</None>
</ItemGroup... | [
"source/BulkCrapUninstaller/BulkCrapUninstaller.csproj",
"source/BulkCrapUninstaller/Forms/Windows/MainWindow.Designer.cs",
"source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs",
"source/BulkCrapUninstaller/Forms/Windows/MainWindow.resx",
"source/BulkCrapUninstaller/Functions/ApplicationList/ApplicationL... | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 927 | issue_to_patch | First launch of an app produces an error (very minor thing)
Hi, weren't able to find this issue through the search, so here you go. It's a minor thing, doesn't hinder the functionality, but still.
Just installed BCU for the first time and received an error right after the launch.
```
BCUninstaller, Version=5.9.0.0, C... | Guard startup uninstall list loading | Closes #775
## Summary
Prevent BCU from trying to open arbitrary startup arguments as uninstall lists.
## Changes
- only treat the first startup argument as an uninstall list when it is an existing `.bcul` file
- move the startup argument validation into a dedicated helper
- add regression tests for valid... | 7a80f0fc5e28c541b5e41c9b0bba74483ab74e8f | deadbac91fb6f884f573c1547a3a20d5fb295fb3 | diff --git a/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs b/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
index 480096e9..92bd5cb6 100644
--- a/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
+++ b/source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs
@@ -1435,13 +1435,12 @@ private void list... | [
"source/BulkCrapUninstaller/Forms/Windows/MainWindow.cs",
"source/BulkCrapUninstaller/Functions/Tools/StartupArgumentTools.cs",
"source/BulkCrapUninstallerTests/Functions/StartupArgumentToolsTests.cs"
] | [] | true | |
BCUninstaller/Bulk-Crap-Uninstaller | 893 | issue_to_patch | Harden registry factory parsing | ## Summary
This PR hardens several factory parsers against incomplete or unexpected input.
## Changes
- make registry enumeration more tolerant of access and IO failures
- add trace logging for skipped/failed parsing cases
## Why
Enumeration and helper output can vary across systems. These changes reduc... | 4ecea11bfb08b0ccf32279293dd1fcd02c6ce767 | c1c98cbb17fecbac4ec7aae066cc29ab27a2c5fb | diff --git a/source/UninstallTools/Factory/RegistryFactory.cs b/source/UninstallTools/Factory/RegistryFactory.cs
index 59d2cb21..2ebaaa9e 100644
--- a/source/UninstallTools/Factory/RegistryFactory.cs
+++ b/source/UninstallTools/Factory/RegistryFactory.cs
@@ -55,18 +55,27 @@ public IList<ApplicationUninstallerEntry> Get... | [
"source/UninstallTools/Factory/RegistryFactory.cs"
] | [] | true | ||
BCUninstaller/Bulk-Crap-Uninstaller | 924 | issue_to_patch | BCUninstaller do not start.
I just installed the last version ov BCUninstaller. But I can start it. I get the following error:
I tested the Window Install and the Zip Version. | Ignore ERROR_BAD_CONFIGURATION when listing MSI components | a07ac72cd454ccf61ab6adc042a94d9c9fb65c4b | dc71385b55b01f1a020fab426205d61cac21771a | diff --git a/source/KlocTools/IO/MsiTools.cs b/source/KlocTools/IO/MsiTools.cs
index fba724b0..24b581e9 100644
--- a/source/KlocTools/IO/MsiTools.cs
+++ b/source/KlocTools/IO/MsiTools.cs
@@ -81,6 +81,8 @@ public static IEnumerable<string> GetAllComponents()
{
var ret = (ResultWin32)MsiWrap... | [
"source/KlocTools/IO/MsiTools.cs"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.