Datasets:
PotatoHD
/
github-pr-resolve

Dataset card Data Studio Files
xet
 Community
repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
JohnSnowLabs/spark-nlp
14,735
issue_to_patch
[SPARKNLP-1279] Introduce LLMNer
Introduces LangExtract in Spark-NLP ## Description This is a new annotator that is able to use AutoGGUF models to extract entities from sentences. It returns entities as CHUNK annotator type. ## How Has This Been Tested? Local Python and Scala tests ## Types of changes <!--- What types of changes does your...
0469ab1502e5236c6079b663829ad4db6c8543a7
9d558d772c44a782802d4db8d0b6461eb9c71f28
diff --git a/docs/en/annotator_entries/LLMNerModel.md b/docs/en/annotator_entries/LLMNerModel.md new file mode 100644 index 00000000000000..7dacce82b158e6 --- /dev/null +++ b/docs/en/annotator_entries/LLMNerModel.md @@ -0,0 +1,223 @@ +{%- capture title -%} +LLMNerModel +{%- endcapture -%} + +{%- capture description -%}...
[ "docs/en/annotator_entries/LLMNerModel.md", "docs/en/annotators.md", "examples/python/llama.cpp/llama_cpp_in_Spark_NLP_LLMNerModel.ipynb", "python/sparknlp/annotator/ner/__init__.py", "python/sparknlp/annotator/ner/llm_ner.py", "python/sparknlp/internal/__init__.py", "python/test/annotator/ner/llm_ner_t...
[ { "comment": "This should not be changed, this can potentially affect pre-existing models (just minor typos, we can live with that)", "path": "python/sparknlp/common/properties.py", "hunk": "", "resolving_sha": "9d558d772c44a782802d4db8d0b6461eb9c71f28", "resolving_diff": "" }, { "commen...
diff --git a/python/test/annotator/ner/llm_ner_test.py b/python/test/annotator/ner/llm_ner_test.py new file mode 100644 index 00000000000000..2c2885416a24a0 --- /dev/null +++ b/python/test/annotator/ner/llm_ner_test.py @@ -0,0 +1,93 @@ +# Copyright 2017-2024 John Snow Labs +# +# Licensed under the Apache License, Ver...
true
JohnSnowLabs/spark-nlp
14,735
comment_to_fix
[SPARKNLP-1279] Introduce LLMNer
Why can't this class just extend AutoGGUFModel, overriding `batchAnnotate` and adding params? This seems like a lot of redundant code.
0469ab1502e5236c6079b663829ad4db6c8543a7
9d558d772c44a782802d4db8d0b6461eb9c71f28
diff --git a/src/main/scala/com/johnsnowlabs/nlp/annotators/ner/dl/LLMNerModel.scala b/src/main/scala/com/johnsnowlabs/nlp/annotators/ner/dl/LLMNerModel.scala new file mode 100644 index 00000000000000..913cbee431d7e2 --- /dev/null +++ b/src/main/scala/com/johnsnowlabs/nlp/annotators/ner/dl/LLMNerModel.scala @@ -0,0 +1,...
[ "src/main/scala/com/johnsnowlabs/nlp/annotators/ner/dl/LLMNerModel.scala" ]
[ { "comment": "Why can't this class just extend AutoGGUFModel, overriding `batchAnnotate` and adding params? This seems like a lot of redundant code.", "path": "src/main/scala/com/johnsnowlabs/nlp/annotators/ner/dl/LLMNerModel.scala", "hunk": "", "resolving_sha": "9d558d772c44a782802d4db8d0b6461eb9c7...
true
JohnSnowLabs/spark-nlp
14,746
issue_to_patch
[SPARKNLP-1340] Adding instructions for Databricks Volume
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Adding instructions for Databricks Unity Catalog Volume and Pretrained Models ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it...
0469ab1502e5236c6079b663829ad4db6c8543a7
c7484e5a65df0f4335014c194f6962127ed1e229
diff --git a/docs/en/advanced_settings.md b/docs/en/advanced_settings.md index 2c354f2413dd08..bc212af79e93db 100644 --- a/docs/en/advanced_settings.md +++ b/docs/en/advanced_settings.md @@ -106,6 +106,28 @@ spark.executor.userClassPathFirst true These configurations are required because the Databricks runtime environ...
[ "docs/en/advanced_settings.md" ]
[]
true
JohnSnowLabs/spark-nlp
14,743
issue_to_patch
[SPARKNLP-1341] Add MultiColumnAssembler
<!--- Provide a general summary of your changes in the Title above --> ## Description Add `MultiColumnAssembler`, a new annotator that combines multiple document-type annotation columns into a single output column. ## Motivation and Context When using `ReaderAssembler`, document content is split across separa...
e6b9e9732fb5e482ead13517b2db4acda50f204f
bd0b1364a00bdb9856a4112c93cd7f057c127d03
diff --git a/docs/en/annotator_entries/MultiColumnAssembler.md b/docs/en/annotator_entries/MultiColumnAssembler.md new file mode 100644 index 00000000000000..e31c4f3b10c8e7 --- /dev/null +++ b/docs/en/annotator_entries/MultiColumnAssembler.md @@ -0,0 +1,131 @@ +{%- capture title -%} +MultiColumnAssembler +{%- endcaptur...
[ "docs/en/annotator_entries/MultiColumnAssembler.md", "docs/en/annotators.md", "examples/python/annotation/text/english/multi-column-assembler/MergingAnnotationColumns_MultiColumnAssembler.ipynb", "python/sparknlp/__init__.py", "python/sparknlp/base/__init__.py", "python/sparknlp/base/multi_column_assemble...
[]
diff --git a/python/test/base/multi_column_assembler_test.py b/python/test/base/multi_column_assembler_test.py new file mode 100644 index 00000000000000..3d13e9a785bcdb --- /dev/null +++ b/python/test/base/multi_column_assembler_test.py @@ -0,0 +1,223 @@ +# Copyright 2017-2026 John Snow Labs +# +# Licensed under the ...
true
JohnSnowLabs/spark-nlp
14,745
issue_to_patch
fix minor typos in example notebooks (reupload)
d72f72611c59ace224a3730b052001445000baeb
daa4eba7de972bb01535ae301dd33744caf6ec51
diff --git a/examples/python/annotation/text/english/embeddings/ModernBertEmbeddings.ipynb b/examples/python/annotation/text/english/embeddings/ModernBertEmbeddings.ipynb index 74714902087950..4c7fc66f44486a 100644 --- a/examples/python/annotation/text/english/embeddings/ModernBertEmbeddings.ipynb +++ b/examples/python...
[ "examples/python/annotation/text/english/embeddings/ModernBertEmbeddings.ipynb", "examples/python/annotation/text/english/vector-db/VectorDBConnector_Pinecone_Demo.ipynb" ]
[]
true
JohnSnowLabs/spark-nlp
14,744
issue_to_patch
[SPARKNLP-1231] Support columnar metadata LightPipeline
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> This PR add support for this kind of input for LightPipeline: ```python text_list = ["text1", "text2", "text3", "text4"] metadata = { "ids" : ["3", "5", "aabb", "1234"], "dateshift":...
bae62c3410de3906a1e069763d90b958dfc45de6
c3e9bb7d529939f2305577152c3d6aa21396ba93
diff --git a/python/sparknlp/base/light_pipeline.py b/python/sparknlp/base/light_pipeline.py index a8055429ed9413..2a7f57127178d4 100644 --- a/python/sparknlp/base/light_pipeline.py +++ b/python/sparknlp/base/light_pipeline.py @@ -172,6 +172,55 @@ def __get_result(annotation): return result + @staticmet...
[ "python/sparknlp/base/light_pipeline.py" ]
[]
true
JohnSnowLabs/spark-nlp
14,741
issue_to_patch
[SPARKNLP-1231] Implement ModernBERTEmbeddings
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How Has This B...
ed228b8e90bae87eaaceed04fb4d83c78dfc43b0
aae83f4ce3809de5dfc90dc6bcaaf15a1b316e5f
diff --git a/docs/en/annotators.md b/docs/en/annotators.md index cabaa05bff5bbb..47e1212951004f 100644 --- a/docs/en/annotators.md +++ b/docs/en/annotators.md @@ -174,6 +174,7 @@ Additionally, these transformers are available. {% include templates/anno_table_entry.md path="./transformers" name="MiniLMEmbeddings" summa...
[ "docs/en/annotators.md", "docs/en/transformer_entries/ModernBertEmbeddings.md", "examples/python/annotation/text/english/embeddings/ModernBertEmbeddings.ipynb", "python/sparknlp/annotator/embeddings/__init__.py", "python/sparknlp/annotator/embeddings/modernbert_embeddings.py", "python/sparknlp/internal/__...
[]
diff --git a/python/test/annotator/embeddings/test_modernbert_embeddings.py b/python/test/annotator/embeddings/test_modernbert_embeddings.py new file mode 100644 index 00000000000000..c9de0d17e9c030 --- /dev/null +++ b/python/test/annotator/embeddings/test_modernbert_embeddings.py @@ -0,0 +1,254 @@ +""" +Module for tes...
true
JohnSnowLabs/spark-nlp
14,736
issue_to_patch
Sparknlp 1231 implement modern bert embeddings
This PR introducs ModernBert a new state of the art BiDirectional embedding annotator. ## How Has This Been Tested? Tested locally with python and scala tests ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply...
5826dbc125530b700bd29acbe6cb85ffedaf86b1
e5f1537359cb66b20728461b4248db837ba90339
diff --git a/docs/en/annotators.md b/docs/en/annotators.md index a2bc41ba715a0e..7444f86fc7172a 100644 --- a/docs/en/annotators.md +++ b/docs/en/annotators.md @@ -173,6 +173,7 @@ Additionally, these transformers are available. {% include templates/anno_table_entry.md path="./transformers" name="MiniLMEmbeddings" summa...
[ "docs/en/annotators.md", "docs/en/transformer_entries/ModernBertEmbeddings.md", "examples/python/annotation/text/english/embeddings/ModernBertEmbeddings.ipynb", "python/sparknlp/annotator/embeddings/__init__.py", "python/sparknlp/annotator/embeddings/modernbert_embeddings.py", "python/sparknlp/internal/__...
[ { "comment": "This is not necessary for non-tf models, you can remove it", "path": "python/sparknlp/annotator/embeddings/modernbert_embeddings.py", "hunk": "@@ -0,0 +1,223 @@\n+# Copyright 2017-2025 John Snow Labs\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may n...
diff --git a/python/test/annotator/embeddings/test_modernbert_embeddings.py b/python/test/annotator/embeddings/test_modernbert_embeddings.py new file mode 100644 index 00000000000000..c9de0d17e9c030 --- /dev/null +++ b/python/test/annotator/embeddings/test_modernbert_embeddings.py @@ -0,0 +1,254 @@ +""" +Module for tes...
true
JohnSnowLabs/spark-nlp
14,736
comment_to_fix
Sparknlp 1231 implement modern bert embeddings
This is not necessary for non-tf models, you can remove it
5826dbc125530b700bd29acbe6cb85ffedaf86b1
e5f1537359cb66b20728461b4248db837ba90339
diff --git a/python/sparknlp/annotator/embeddings/modernbert_embeddings.py b/python/sparknlp/annotator/embeddings/modernbert_embeddings.py new file mode 100644 index 00000000000000..c24f82f0e5df4c --- /dev/null +++ b/python/sparknlp/annotator/embeddings/modernbert_embeddings.py @@ -0,0 +1,223 @@ +# Copyright 2017-2025...
[ "python/sparknlp/annotator/embeddings/modernbert_embeddings.py" ]
[ { "comment": "This is not necessary for non-tf models, you can remove it", "path": "python/sparknlp/annotator/embeddings/modernbert_embeddings.py", "hunk": "@@ -0,0 +1,223 @@\n+# Copyright 2017-2025 John Snow Labs\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may n...
true
JohnSnowLabs/spark-nlp
14,740
issue_to_patch
[Sparknlp-1287] Add VectorDBConnector docs and demo notebook
d64cd25cfe5eaebaffacd52765e8f8abc92f03e5
49d3403f4c53c5e3e39742599932228cc4d8329f
diff --git a/docs/_data/navigation.yml b/docs/_data/navigation.yml old mode 100755 new mode 100644 index 85688b6c357880..23c747e68e5641 --- a/docs/_data/navigation.yml +++ b/docs/_data/navigation.yml @@ -52,6 +52,8 @@ sparknlp: url: /docs/en/transformers - title: Training url: /docs/en/training...
[ "docs/_data/navigation.yml", "docs/en/annotator_entries/VectorDBConnector.md", "docs/en/annotators.md", "docs/en/unstructured_data_extraction.md", "examples/python/annotation/text/english/vector-db/VectorDBConnector_Pinecone_Demo.ipynb" ]
[ { "comment": "The Scala example imports `com.johnsnowlabs.nlp.ml.ai.VectorDBConnector`, but there is no `com.johnsnowlabs.nlp.ml` package in this codebase. Similar ML/AI components (e.g., OpenAICompletion) are under `com.johnsnowlabs.ml.ai`, so this import/package name likely needs to be corrected to match the ...
true
JohnSnowLabs/spark-nlp
14,737
issue_to_patch
[SPARKNLP-1335] Implement Layout Aligner annotators
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> This PR introduces two new aligner annotators to support multimodal ingestion and reconstruction workflows: 1. **LayoutAlignerForVision** - Aligns DOCUMENT chunks with nearby IM...
81b789d7cbcf960a4d90135df9eafd71968eab35
0cfb7dd840ee5ca5d3fff67bbf1eecb0e6a733d4
diff --git a/python/sparknlp/partition/partition_properties.py b/python/sparknlp/partition/partition_properties.py index d7eda35a597605..7df8625a359dc1 100644 --- a/python/sparknlp/partition/partition_properties.py +++ b/python/sparknlp/partition/partition_properties.py @@ -14,9 +14,10 @@ """Contains classes for parti...
[ "python/sparknlp/partition/partition_properties.py", "python/sparknlp/reader/__init__.py", "python/sparknlp/reader/layout_aligner_for_text.py", "python/sparknlp/reader/layout_aligner_for_vision.py", "python/sparknlp/reader/reader_assembler.py", "python/test/reader/layout_aligner_for_text_test.py", "pyth...
[]
diff --git a/python/test/reader/layout_aligner_for_text_test.py b/python/test/reader/layout_aligner_for_text_test.py new file mode 100644 index 00000000000000..9117595243a26b --- /dev/null +++ b/python/test/reader/layout_aligner_for_text_test.py @@ -0,0 +1,53 @@ +# Copyright 2017-2026 John Snow Labs +# +# Licensed un...
true
JohnSnowLabs/spark-nlp
14,729
issue_to_patch
Sparknlp 1287 vector db connector annotator
This PR introduces VectorDBConnector in spark-nlp ## Description This PR introducesa new annotator called VectorDBConnector that allows users to save their output embeddings to a vector database, currently the only supported databse is PineCone but this will be expanded upon in future releases. ## How ...
4080ea6417b6a66fbfd1427ba67031834a0eb55e
fad2f2882505a5c2253aea6cb1a288baec6c8d84
diff --git a/build.sbt b/build.sbt index eac702f656270e..5ae72ab5a47b69 100644 --- a/build.sbt +++ b/build.sbt @@ -114,6 +114,16 @@ val openVinoDependencies: Seq[sbt.ModuleID] = Seq(openVinoCPU) lazy val mavenProps = settingKey[Unit]("workaround for Maven properties") +lazy val vectorStoreDependencies = Seq( + pi...
[ "build.sbt", "project/Dependencies.scala", "python/sparknlp/annotator/__init__.py", "python/sparknlp/annotator/vector_db/__init__.py", "python/sparknlp/annotator/vector_db/vector_db_connector.py", "python/test/annotator/vector_db/__init__.py", "python/test/annotator/vector_db/vector_db_connector_test.py...
[]
diff --git a/python/test/annotator/vector_db/__init__.py b/python/test/annotator/vector_db/__init__.py new file mode 100644 index 00000000000000..e69de29bb2d1d6 diff --git a/python/test/annotator/vector_db/vector_db_connector_test.py b/python/test/annotator/vector_db/vector_db_connector_test.py new file mode 100644 ind...
true
JohnSnowLabs/spark-nlp
14,734
issue_to_patch
[SPARKNLP-1336] Enhancements to LightPipeline
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> This PR extends `LightPipeline` to support annotators that require internal pre-processing and post-processing steps, including dynamic `extraInputCol`s handling What changed - A...
81b789d7cbcf960a4d90135df9eafd71968eab35
94a3c8f528e4a8dff51391bf0026eabb0688a4fc
diff --git a/python/sparknlp/base/light_pipeline.py b/python/sparknlp/base/light_pipeline.py index f63b0a210c88a9..a8055429ed9413 100644 --- a/python/sparknlp/base/light_pipeline.py +++ b/python/sparknlp/base/light_pipeline.py @@ -180,6 +180,9 @@ def fullAnnotate(self, *args, **kwargs): - fullAnnotate(text: ...
[ "python/sparknlp/base/light_pipeline.py", "python/sparknlp/pretrained/pretrained_pipeline.py", "src/main/scala/com/johnsnowlabs/nlp/AnnotatorModel.scala", "src/main/scala/com/johnsnowlabs/nlp/HasInputAnnotationCols.scala", "src/main/scala/com/johnsnowlabs/nlp/HasLightPipelineAnnotate.scala", "src/main/sca...
[]
true
JohnSnowLabs/spark-nlp
14,727
issue_to_patch
[SPARKNLP-1334] Updating POI dependency for readers
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> This PR pins Apache POI to version 5.4.1 to ensure stable behavior across: - Scala 2.12 and 2.13 - Java 8 and 17 - Spark-based test and runtime environmentss This change also adds...
4080ea6417b6a66fbfd1427ba67031834a0eb55e
5047c3e108232236bfc9fc9f0d03e09c64abbde6
diff --git a/build.sbt b/build.sbt index eac702f656270e..58817266094ae2 100644 --- a/build.sbt +++ b/build.sbt @@ -68,7 +68,8 @@ lazy val utilDependencies = Seq( jsoup, jakartaMail, angusMail, - poiDocx, + poiDocx + exclude ("org.apache.logging.log4j", "log4j-api"), poiSchemas exclude ("org.apache...
[ "build.sbt", "project/Dependencies.scala", "python/sparknlp/annotator/er/entity_ruler.py", "python/test/reader/reader2doc_test.py", "python/test/sparknlp_test.py", "src/main/scala/com/johnsnowlabs/reader/WordReader.scala" ]
[]
diff --git a/python/test/reader/reader2doc_test.py b/python/test/reader/reader2doc_test.py index b53fb970e8c4fb..326bce7960b46d 100644 --- a/python/test/reader/reader2doc_test.py +++ b/python/test/reader/reader2doc_test.py @@ -262,3 +262,29 @@ def test_xml_extract_attribute(self): 39.95""" self.assertEqual(...
true
JohnSnowLabs/spark-nlp
14,733
issue_to_patch
[SPARKNLP-1337] Add Unstructured Data Extraction docs and nav
4080ea6417b6a66fbfd1427ba67031834a0eb55e
bfb3bbb11ef6db7284f513eea4c609aefd6cdbd3
diff --git a/docs/_data/navigation.yml b/docs/_data/navigation.yml old mode 100755 new mode 100644 index 85688b6c357880..23c747e68e5641 --- a/docs/_data/navigation.yml +++ b/docs/_data/navigation.yml @@ -52,6 +52,8 @@ sparknlp: url: /docs/en/transformers - title: Training url: /docs/en/training...
[ "docs/_data/navigation.yml", "docs/en/unstructured_data_extraction.md" ]
[ { "comment": "@AbdullahMubeenAnwar amazing work overall, great job.\nI have a small suggestion to improve clarity and positioning:\n\nConsider renaming the table title from `Key Differences` to `Spark NLP vs Unstructured.io: Practical Trade-offs`, which better reflects the intent of the comparison.\n\nAdditiona...
true
JohnSnowLabs/spark-nlp
14,731
issue_to_patch
2026-02-06-explain_document_dl_en
0dfc6e28066661cd61077b35363b05ead62c15fe
9422d8f184ef7270f7b77880386b3d8b03b554cf
diff --git a/docs/_posts/AbdullahMubeenAnwar/2026-02-06-explain_document_dl_en.md b/docs/_posts/AbdullahMubeenAnwar/2026-02-06-explain_document_dl_en.md index 4e1dc199911d94..03ded3e455cfa4 100644 --- a/docs/_posts/AbdullahMubeenAnwar/2026-02-06-explain_document_dl_en.md +++ b/docs/_posts/AbdullahMubeenAnwar/2026-02-06...
[ "docs/_posts/AbdullahMubeenAnwar/2026-02-06-explain_document_dl_en.md" ]
[]
true
JohnSnowLabs/spark-nlp
14,730
issue_to_patch
2026-02-06-explain_document_dl_en
64713bcd1d766a4d88d1fef57dfd555ed8e4a0c1
e2e989270afa7b17b7c585d61ed56e4457ca3619
diff --git a/docs/_posts/AbdullahMubeenAnwar/2026-02-06-explain_document_dl_en.md b/docs/_posts/AbdullahMubeenAnwar/2026-02-06-explain_document_dl_en.md new file mode 100644 index 00000000000000..4e1dc199911d94 --- /dev/null +++ b/docs/_posts/AbdullahMubeenAnwar/2026-02-06-explain_document_dl_en.md @@ -0,0 +1,106 @@ +-...
[ "docs/_posts/AbdullahMubeenAnwar/2026-02-06-explain_document_dl_en.md" ]
[]
true
JohnSnowLabs/spark-nlp
14,725
issue_to_patch
[SPARKNLP-1329] Adding image coordinates to metadata for Reader2Image
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Adding image coordinates to metadata for HTML, Word and PowerPoint Add images coordinates extraction support for images on HTML, Word and PowerPoint documents ## Motivation and Contex...
8bb1c831ba494f3c99b7607b540f4f354b70bade
b5746e50455b76a89a3a3c0d2ca30e8ea0c7a713
diff --git a/build.sbt b/build.sbt index ac600b67c96987..a99f0bdfda124f 100644 --- a/build.sbt +++ b/build.sbt @@ -68,7 +68,8 @@ lazy val utilDependencies = Seq( jsoup, jakartaMail, angusMail, - poiDocx + poiDocx, + poiSchemas exclude ("org.apache.logging.log4j", "log4j-api"), scratchpad exclud...
[ "build.sbt", "project/Dependencies.scala", "src/main/scala/com/johnsnowlabs/reader/HTMLReader.scala", "src/main/scala/com/johnsnowlabs/reader/PowerPointReader.scala", "src/main/scala/com/johnsnowlabs/reader/WordReader.scala", "src/test/resources/reader/html/example-image-coordinates.html", "src/test/sca...
[]
diff --git a/src/test/resources/reader/html/example-image-coordinates.html b/src/test/resources/reader/html/example-image-coordinates.html new file mode 100644 index 00000000000000..093b143da2a557 --- /dev/null +++ b/src/test/resources/reader/html/example-image-coordinates.html @@ -0,0 +1,12 @@ +<!DOCTYPE html> +<html>...
true
JohnSnowLabs/spark-nlp
14,723
issue_to_patch
Scala 2.13 JSON serialization
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> This PR introduces a mechanism to serialize Spark NLP `Feature`s to JSON instead of java serialization. This is the Scala 2.13 side, that will enable JSON serialized features to be loa...
30d732379b26aca701917aaa9283055b6ec77a89
e7a985fdfba594c86bc2ec6398baa91538df6bdb
diff --git a/build.sbt b/build.sbt index 858adc77bfb288..d3a49fefc528a8 100644 --- a/build.sbt +++ b/build.sbt @@ -80,7 +80,8 @@ lazy val utilDependencies = Seq( exclude ("org.apache.logging.log4j", "log4j-api"), pdfBox, flexmark, - tagSoup) + tagSoup, + json4sNative) lazy val typedDependencyParserDepe...
[ "build.sbt", "project/Dependencies.scala", "src/main/scala/com/johnsnowlabs/collections/SearchTrie.scala", "src/main/scala/com/johnsnowlabs/nlp/annotators/TextMatcherModel.scala", "src/main/scala/com/johnsnowlabs/nlp/annotators/parser/dep/DependencyParserModel.scala", "src/main/scala/com/johnsnowlabs/nlp/...
[]
diff --git a/src/test/scala/com/johnsnowlabs/nlp/annotators/parser/dep/DependencyParserModelTestSpec.scala b/src/test/scala/com/johnsnowlabs/nlp/annotators/parser/dep/DependencyParserModelTestSpec.scala index 00c577791660db..267cb294b445a2 100644 --- a/src/test/scala/com/johnsnowlabs/nlp/annotators/parser/dep/Dependenc...
true
JohnSnowLabs/spark-nlp
14,722
issue_to_patch
[SPARKNLP-1136] JSON Serialization for Features
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> This PR introduces a mechanism to serialize Spark NLP `Feature`s to JSON instead of java serialization. This feature will enable old models to be re-saved in a format this is suitable ...
6300767c4fd3c8aba8382cec252a077ebb48ee75
9c0bbd470fea746e92593a36d82415551b43e3df
diff --git a/build.sbt b/build.sbt index 827a465c1c00ba..2a52075ad04628 100644 --- a/build.sbt +++ b/build.sbt @@ -74,7 +74,8 @@ lazy val utilDependencies = Seq( exclude ("org.apache.logging.log4j", "log4j-api"), pdfBox, flexmark, - tagSoup) + tagSoup, + json4sNative) lazy val typedDependencyParserDepe...
[ "build.sbt", "project/Dependencies.scala", "src/main/scala/com/johnsnowlabs/collections/SearchTrie.scala", "src/main/scala/com/johnsnowlabs/nlp/annotators/TextMatcherModel.scala", "src/main/scala/com/johnsnowlabs/nlp/annotators/parser/dep/DependencyParserModel.scala", "src/main/scala/com/johnsnowlabs/nlp/...
[]
diff --git a/src/test/scala/com/johnsnowlabs/nlp/annotators/parser/dep/DependencyParserModelTestSpec.scala b/src/test/scala/com/johnsnowlabs/nlp/annotators/parser/dep/DependencyParserModelTestSpec.scala index 00c577791660db..267cb294b445a2 100644 --- a/src/test/scala/com/johnsnowlabs/nlp/annotators/parser/dep/Dependenc...
true
JohnSnowLabs/spark-nlp
14,716
issue_to_patch
Sparknlp 1287 vector db connector annotator
This PR introduces VectorDBConnector in spark-nlp ## Description This PR introducesa new annotator called VectorDBConnector that allows users to save their output embeddings to a vector database, currently the only supported databse is PineCone but this will be expanded upon in future releases. ## How ...
50049bbb477c466e938029777a281fb9f69eb3c2
e065abdc44876d1c488d327e693a175b3461c8e1
diff --git a/build.sbt b/build.sbt index ac600b67c96987..827a465c1c00ba 100644 --- a/build.sbt +++ b/build.sbt @@ -112,6 +112,14 @@ val openVinoDependencies: Seq[sbt.ModuleID] = Seq(openVinoCPU) lazy val mavenProps = settingKey[Unit]("workaround for Maven properties") +lazy val vectorStoreDependencies = Seq( + pi...
[ "build.sbt", "project/Dependencies.scala", "python/sparknlp/annotator/__init__.py", "python/sparknlp/annotator/vector_db/__init__.py", "python/sparknlp/annotator/vector_db/vector_db_connector.py", "python/test/annotator/vector_db/vector_db_connector_test.py", "src/main/scala/com/johnsnowlabs/ml/ai/Vecto...
[]
diff --git a/python/test/annotator/vector_db/vector_db_connector_test.py b/python/test/annotator/vector_db/vector_db_connector_test.py new file mode 100644 index 00000000000000..006d381c893d93 --- /dev/null +++ b/python/test/annotator/vector_db/vector_db_connector_test.py @@ -0,0 +1,92 @@ +# Copyright 2017-2024 John S...
true
JohnSnowLabs/spark-nlp
14,720
issue_to_patch
Adding Readers type aliases plus their DefaultParamsReadable companions
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> Adding Readers type aliases plus their DefaultParamsReadable companions ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes...
87ff57e6e75ff459c67cd8fd3d143833901e7ddf
58e6720e82f5b2e019dbf3b50105d7ba7409f31e
diff --git a/src/main/scala/com/johnsnowlabs/nlp/annotator.scala b/src/main/scala/com/johnsnowlabs/nlp/annotator.scala index e88f5feaa9fb01..98b5070ffcb979 100644 --- a/src/main/scala/com/johnsnowlabs/nlp/annotator.scala +++ b/src/main/scala/com/johnsnowlabs/nlp/annotator.scala @@ -837,4 +837,20 @@ package object annot...
[ "src/main/scala/com/johnsnowlabs/nlp/annotator.scala", "src/main/scala/com/johnsnowlabs/reader/Reader2Image.scala", "src/main/scala/com/johnsnowlabs/reader/ReaderAssembler.scala" ]
[]
true
JohnSnowLabs/spark-nlp
14,719
issue_to_patch
[SPARKNLP-1304] Upgrade jsl-llamacpp to llama.cpp b7247
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> This PR upgrades the jsl-llamacpp backend to llama.cpp tag b7247. ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an op...
d7bcceb25f56fea96395fe36c1c78054360f2585
bf534e568b1f4de112b969fe3cd84b07ee5b4f28
diff --git a/build.sbt b/build.sbt index 4bdd73237d7052..f2c932e638bba3 100644 --- a/build.sbt +++ b/build.sbt @@ -74,8 +74,7 @@ lazy val utilDependencies = Seq( exclude ("org.apache.logging.log4j", "log4j-api"), pdfBox, flexmark, - tagSoup -) + tagSoup) lazy val typedDependencyParserDependencies = Seq(...
[ "build.sbt", "project/Dependencies.scala", "python/sparknlp/common/properties.py", "src/main/scala/com/johnsnowlabs/nlp/HasLlamaCppModelProperties.scala", "src/main/scala/com/johnsnowlabs/nlp/annotators/seq2seq/AutoGGUFReranker.scala", "src/main/scala/com/johnsnowlabs/nlp/embeddings/AutoGGUFEmbeddings.sca...
[]
diff --git a/src/test/scala/com/johnsnowlabs/nlp/annotators/seq2seq/AutoGGUFModelTest.scala b/src/test/scala/com/johnsnowlabs/nlp/annotators/seq2seq/AutoGGUFModelTest.scala index 1175f7ffb645f7..9f1c9db464b5e5 100644 --- a/src/test/scala/com/johnsnowlabs/nlp/annotators/seq2seq/AutoGGUFModelTest.scala +++ b/src/test/sca...
true
JordanMarr/SqlHydra
143
issue_to_patch
Feature Request: Make IR public for Insert and Update queries I can access the IR from select queries and from delete queries via something like ```f# let query = select { for row in schema.table do select row.field } let ir = query.IR ``` This lets me access the compiled SQL by running...
Add public access to the IR for insert statements and update statements
Fixes #135
76fbf628b80f998c00ecae9ea0b631c5d5073d4a
346e54e3399ab0dc03cd911c5837e3224d19f1fc
diff --git a/src/SqlHydra.Query/Core.fs b/src/SqlHydra.Query/Core.fs index dffdc03..a7dc318 100644 --- a/src/SqlHydra.Query/Core.fs +++ b/src/SqlHydra.Query/Core.fs @@ -271,7 +271,13 @@ type DeleteQuery<'T>(ir: DeleteQueryIR) = override this.CompileWith(emitter) = emitter.EmitDelete(ir) type UpdateQuery<'T, 'Up...
[ "src/SqlHydra.Query/Core.fs", "src/Tests/SqlServer/DB.fs", "src/Tests/SqlServer/QueryUnitTests.fs" ]
[]
diff --git a/src/Tests/SqlServer/DB.fs b/src/Tests/SqlServer/DB.fs index a357ea6..cca4ea9 100644 --- a/src/Tests/SqlServer/DB.fs +++ b/src/Tests/SqlServer/DB.fs @@ -19,7 +19,7 @@ let server = "localhost,12019" let connectionString = $@"Server={server};Database=AdventureWorks;User=sa;Password=Password#123;Connect Timeo...
true
JordanMarr/SqlHydra
142
issue_to_patch
Corrected Documentation
088c736028c426be86d7d7df413315c02035f2a5
26f44496b6dcb38480fdd82f465d427bfbe48484
diff --git a/README.md b/README.md index fe8b5ef..e9d1c85 100644 --- a/README.md +++ b/README.md @@ -621,7 +621,7 @@ deleteTask db { ```fsharp let completeOrder (db: QueryContextFactory) orderId = task { - use! shared = db.CreateContextAsync() + use! shared = db.OpenContextAsync() shared.BeginTransaction...
[ "README.md" ]
[]
true
JordanMarr/SqlHydra
141
issue_to_patch
Add timeout operation.
Adds a `timeout` operation to the query CEs that sets the `CommandTimeout` of the ADO.NET command.
c11c2dffae06e59d1cbd6993dca3f9cc9659e8d6
08e0301f236e9e1f7ba6caed9c2a8fb09d7f197a
diff --git a/src/SqlHydra.Query/Core.fs b/src/SqlHydra.Query/Core.fs index 3ffacf1..dffdc03 100644 --- a/src/SqlHydra.Query/Core.fs +++ b/src/SqlHydra.Query/Core.fs @@ -76,9 +76,10 @@ type InsertQuerySpec<'T, 'Identity> = IdentityField: string option OutputFields: OutputField list InsertType:...
[ "src/SqlHydra.Query/Core.fs", "src/SqlHydra.Query/DeleteBuilders.fs", "src/SqlHydra.Query/InsertBuilders.fs", "src/SqlHydra.Query/QueryContext.fs", "src/SqlHydra.Query/QueryIR.fs", "src/SqlHydra.Query/SelectBuilders.fs", "src/SqlHydra.Query/SqlEmitter.fs", "src/SqlHydra.Query/SqlEmitterBase.fs", "sr...
[]
diff --git a/src/Tests/Npgsql/QueryIntegrationTests.fs b/src/Tests/Npgsql/QueryIntegrationTests.fs index 9abe1bc..743e418 100644 --- a/src/Tests/Npgsql/QueryIntegrationTests.fs +++ b/src/Tests/Npgsql/QueryIntegrationTests.fs @@ -37,6 +37,19 @@ let ``Where City Contains``() = task { Assert.IsTrue(addresses |> Seq.f...
true
JordanMarr/SqlHydra
138
issue_to_patch
Implicitly implement IDisposible on QueryContext
See #137.
4c09a61677f73db4b20eb61d416daef5c8cc7a93
a5d87aeaa1f6c94bf477f7c559ded9d22ae3673f
diff --git a/src/SqlHydra.Query/QueryContext.fs b/src/SqlHydra.Query/QueryContext.fs index 2ea8584..b6fcee7 100644 --- a/src/SqlHydra.Query/QueryContext.fs +++ b/src/SqlHydra.Query/QueryContext.fs @@ -49,22 +49,28 @@ type QueryContext(conn: DbConnection, emitter: ISqlEmitter) = let mutable logger = fun (cq: Comp...
[ "src/SqlHydra.Query/QueryContext.fs" ]
[]
true
JordanMarr/SqlHydra
133
issue_to_patch
docs: link SqlHydra.Query.Pgvector as an example extension package
Links [SqlHydra.Query.Pgvector](https://github.com/michaelglass/SqlHydra.Query.Pgvector) from the "NuGet Extension Packages" section as a real-world example of an `IExtendTypeMapping` package — it maps the Postgres `vector` type to `Pgvector.Vector` and adds the pgvector distance operators. Also two small correctness ...
be16d1ba45469e8990370ee3bca5fef9160da4dd
5ecf9bed24a96bc8caf93a9ec8e89618806d8298
diff --git a/README.md b/README.md index fe8b5ef..48e8a9c 100644 --- a/README.md +++ b/README.md @@ -764,7 +764,8 @@ type MyCustomMapping() = TypeMapping.ColumnTypeAlias = "vector" TypeMapping.ClrType = "Pgvector.Vector" TypeMapping.DbType = Sys...
[ "README.md" ]
[]
true
JordanMarr/SqlHydra
132
issue_to_patch
Render aggregates over expressions (e.g. `sumBy(caseWhen …)`) instead of throwing
whoops, one more bug from me... `sumBy`/`avgBy`/etc. over anything other than a bare column threw `Invalid argument to aggregate function` — even though `NAggregateColumn`'s own doc comment says such expressions should fall through to full expression rendering. So a conditional count like `SUM(CASE WHEN … THEN 1 ELS...
f5af937b21796c16795f475d3ccebaf4cd658b48
ba949bf45987209cda408a23a15d1f4b1477d816
diff --git a/src/SqlHydra.Query/LinqExpressionVisitors.fs b/src/SqlHydra.Query/LinqExpressionVisitors.fs index 93b396b..6b0daf8 100644 --- a/src/SqlHydra.Query/LinqExpressionVisitors.fs +++ b/src/SqlHydra.Query/LinqExpressionVisitors.fs @@ -307,7 +307,9 @@ module SqlPatterns = let aggType = aggTypeOf m.Met...
[ "src/SqlHydra.Query/LinqExpressionVisitors.fs", "src/Tests/Npgsql/QueryUnitTests.fs" ]
[]
diff --git a/src/Tests/Npgsql/QueryUnitTests.fs b/src/Tests/Npgsql/QueryUnitTests.fs index 1938291..5781783 100644 --- a/src/Tests/Npgsql/QueryUnitTests.fs +++ b/src/Tests/Npgsql/QueryUnitTests.fs @@ -1009,6 +1009,32 @@ let ``nested aggregate-in-aggregate (MAX(SUM(x)))`` () = sql.Contains("CAST(SUM(") =! true ...
true
JordanMarr/SqlHydra
131
issue_to_patch
Tell users when a registered extension loads nothing (instead of silently skipping it)
small usability fix to the cli when using extensions ... Register an extension in your TOML (`[extensions] type_mappings`) that loads no `IExtendTypeMapping` — a wrong/typo'd name, the wrong assembly, or types that failed to load — and SqlHydra silently ignores it: generation runs without the mapping and exits `0`, ...
01cc3fc0cc3eccad61dd32b474cff07d67ee8bb5
3a5bfd73c7cb250388a55a6bc4af5ca9d0b93717
diff --git a/src/SqlHydra.Cli/Extensions.fs b/src/SqlHydra.Cli/Extensions.fs index 0f548c76..dfa2355a 100644 --- a/src/SqlHydra.Cli/Extensions.fs +++ b/src/SqlHydra.Cli/Extensions.fs @@ -130,5 +130,19 @@ let loadNamed (project: FileInfo) (extensionNames: string list) : ISqlHydraExten | None -> fai...
[ "src/SqlHydra.Cli/Extensions.fs", "src/Tests/Tests.fsproj", "src/Tests/UnitTests/Extensions.fs" ]
[]
diff --git a/src/Tests/Tests.fsproj b/src/Tests/Tests.fsproj index 4deebffe..596e5002 100644 --- a/src/Tests/Tests.fsproj +++ b/src/Tests/Tests.fsproj @@ -64,6 +64,7 @@ <Compile Include="UnitTests\TomlConfigParser.fs" /> <Compile Include="UnitTests\ColumnFilters.fs" /> <Compile Include="UnitTests\TableFi...
true
JordanMarr/SqlHydra
130
issue_to_patch
Postgres features + extensibility: RETURNING, ON CONFLICT variants, CTEs, lateral joins, expression rendering, infix-operator registry
Second (and final) PR from #125, following #129. All additive; two commits: features, then the extensibility seam that builds on them. **New CE operations:** `returning` (insert/update/delete), `fromSelect`, `setRaw`, `whereExists`/`whereNotExists`, `havingRaw`, `orderByRaw`/`orderByAlias`(/`Desc`), `nullsFirst`/`null...
99322c1d25621fbd8f1fafafb46e0d70836a77b8
565f2def930ea99e44c7522f6ffe80d6adb145ca
diff --git a/src/SqlHydra.Query/Core.fs b/src/SqlHydra.Query/Core.fs index 3ffacf1..d7e22e3 100644 --- a/src/SqlHydra.Query/Core.fs +++ b/src/SqlHydra.Query/Core.fs @@ -43,8 +43,14 @@ module FQ = let tbl = tables[TableAliasKey tableAlias] $"%s{tbl.Schema}.%s{tbl.Name}.%s{column.Name}" + /// Rende...
[ "src/SqlHydra.Query/Core.fs", "src/SqlHydra.Query/DeleteBuilders.fs", "src/SqlHydra.Query/ExpressionNormalizer.fs", "src/SqlHydra.Query/InsertBuilders.fs", "src/SqlHydra.Query/LinqExpressionVisitors.fs", "src/SqlHydra.Query/NpgsqlExtensions.fs", "src/SqlHydra.Query/QueryContext.fs", "src/SqlHydra.Quer...
[]
diff --git a/src/Tests/Npgsql/QueryUnitTests.fs b/src/Tests/Npgsql/QueryUnitTests.fs index 5360c3a..1938291 100644 --- a/src/Tests/Npgsql/QueryUnitTests.fs +++ b/src/Tests/Npgsql/QueryUnitTests.fs @@ -1,7 +1,10 @@ module Npgsql.``Query Unit Tests`` +open System +open System.Linq.Expressions open Swensen.Unquote o...
true
JordanMarr/SqlHydra
129
issue_to_patch
Fix: correlated subquery emits wrong table in FROM when `for`/`correlate` sources differ
Part of #125, split out as a standalone fix. When a `correlate` subquery's `for` source and `correlate` target are different tables, the inner `FROM` resolves to the wrong table. **Cause:** `IsLikeZip` runs `Correlate` before the enclosing `For`, so both table mappings still key under `Root`; `mergeTableMappings` col...
d6f40750e48ce0031643062b0c509946f0a33769
33dfd69ef70df87b8e04bfaecc9b1747d9287347
diff --git a/src/SqlHydra.Query/SelectBuilders.fs b/src/SqlHydra.Query/SelectBuilders.fs index 006a273e..d74194bd 100644 --- a/src/SqlHydra.Query/SelectBuilders.fs +++ b/src/SqlHydra.Query/SelectBuilders.fs @@ -317,7 +317,18 @@ type SelectBuilder<'Selected, 'Mapped> () = innerSource: QuerySource<...
[ "src/SqlHydra.Query/SelectBuilders.fs", "src/Tests/Npgsql/QueryUnitTests.fs" ]
[]
diff --git a/src/Tests/Npgsql/QueryUnitTests.fs b/src/Tests/Npgsql/QueryUnitTests.fs index 53353d1b..5360c3a6 100644 --- a/src/Tests/Npgsql/QueryUnitTests.fs +++ b/src/Tests/Npgsql/QueryUnitTests.fs @@ -265,6 +265,29 @@ let ``Correlated Subquery``() = (SELECT MAX(\"d\".\"orderdate\") AS __hydra_expr_0 FROM \"s...
true
JordanMarr/SqlHydra
127
issue_to_patch
Replace System.Data.SQLite with Microsoft.Data.Sqlite
This PR relates to #126. I've replaced `System.Data.SQLite` with `Microsoft.Data.Sqlite`. To do this I've had to replace the use of `SQLiteConnection.GetSchema()` with a bit of custom SQL and some filtering to apply the table/column restrictions. I've also added some tests to cover some of the more finicky bits, ...
4f3777ca7a7ec627549d9153d077cc1d7ce04503
638884f4f7346461882808fc57a35ba099c72876
diff --git a/src/SqlHydra.Cli/SqlHydra.Cli.fsproj b/src/SqlHydra.Cli/SqlHydra.Cli.fsproj index 1541cb07..1635b852 100644 --- a/src/SqlHydra.Cli/SqlHydra.Cli.fsproj +++ b/src/SqlHydra.Cli/SqlHydra.Cli.fsproj @@ -55,6 +55,7 @@ <PackageReference Update="FSharp.Core" Version="9.0.201" Condition="'$(TargetFramework)' == ...
[ "src/SqlHydra.Cli/SqlHydra.Cli.fsproj", "src/SqlHydra.Cli/Sqlite/Provider.fs", "src/SqlHydra.Cli/Sqlite/SqliteDataTypes.fs", "src/SqlHydra.Cli/Sqlite/SqliteSchemaProvider.fs", "src/Tests/Sqlite/SchemaProviderTests.fs", "src/Tests/Tests.fsproj" ]
[]
diff --git a/src/Tests/Sqlite/SchemaProviderTests.fs b/src/Tests/Sqlite/SchemaProviderTests.fs new file mode 100644 index 00000000..bec4cad7 --- /dev/null +++ b/src/Tests/Sqlite/SchemaProviderTests.fs @@ -0,0 +1,161 @@ +module Sqlite.``Schema Provider Tests`` + +open System +open System.IO +open Microsoft.Data.Sqlite +...
true
JordanMarr/SqlHydra
121
issue_to_patch
fix(SchemaTemplate.fs): fix missing backticks for table name
Im using postgres and some tables have dashes. The code generation for the HydraReader class generates invalid f# code and causes an exception when formatting with fantomas in SqlHydra.Cli/Console.fs line 201 This fix will generate valid F# code again. Note that I was not able to run the tests in the test contain...
bed4994ab92ffbe49094b8449c4c7a0d6468ef69
68dfb7a306c1208caba453b3e87b1c2c8b4e4e82
diff --git a/src/SqlHydra.Cli/SchemaTemplate.fs b/src/SqlHydra.Cli/SchemaTemplate.fs index a8e00410..1092b2e5 100644 --- a/src/SqlHydra.Cli/SchemaTemplate.fs +++ b/src/SqlHydra.Cli/SchemaTemplate.fs @@ -242,7 +242,7 @@ let buildGetOrdinal tableType = for table in allTables do let schemaTab...
[ "src/SqlHydra.Cli/SchemaTemplate.fs" ]
[]
true
JordanMarr/SqlHydra
120
issue_to_patch
Add Postgres' network address types and CI configuration to run the automated tests
## Description: With this PR, I'm: - Adding [Postgres' network address types](https://www.postgresql.org/docs/current/datatype-net-types.html); - Adding new automated tests to validate that the operations using it are working properly (from my tests, it works with Npgsql 9.0.x); - Adding a new CI configuration ...
3d4706eed2f27b18548ace75d3cae42901bab529
e02cf2b5a5c7eeaecdf3c56028074aa73f7f0ec6
diff --git a/.github/workflows/build-and-test.yml b/.github/workflows/build-and-test.yml new file mode 100644 index 00000000..286de0a3 --- /dev/null +++ b/.github/workflows/build-and-test.yml @@ -0,0 +1,56 @@ +name: Build and test + +on: + push: + branches: + - main + pull_request: + +env: + # Stop wasting t...
[ ".github/workflows/build-and-test.yml", "src/.devcontainer/docker-compose.yml", "src/.devcontainer/postgresql/install.sql", "src/SqlHydra.Cli/Npgsql/NpgsqlDataTypes.fs", "src/Tests/Npgsql/AdventureWorksNet8.fs", "src/Tests/Npgsql/AdventureWorksNet9.fs", "src/Tests/Npgsql/Generation.fs", "src/Tests/Npg...
[]
diff --git a/src/Tests/Npgsql/AdventureWorksNet8.fs b/src/Tests/Npgsql/AdventureWorksNet8.fs index e67b4924..bef0b8bf 100644 --- a/src/Tests/Npgsql/AdventureWorksNet8.fs +++ b/src/Tests/Npgsql/AdventureWorksNet8.fs @@ -759,6 +759,42 @@ module humanresources = member __.ReadIfNotNull() = if...
true
JordanMarr/SqlHydra
115
issue_to_patch
Modified logger to also use NamedBindings as in the other part of the…
Hi, for context; I will be making a PR for sqlkata soon to truly permit database parameters, locally working and tests passing. The change here does not depend on that. Noticed that the logging was using Bindings, while the generation of sql was using NamedBindings (as it should). Adjusted the logging to use NamedBi...
1ba15ce67caa7f8ad857c2d4e1b16444daacfd62
49a9f0318b70042b170c98805a60480a0f014ba0
diff --git a/src/SqlHydra.Query/Kata.fs b/src/SqlHydra.Query/Kata.fs index 3a177565..cdb4dd79 100644 --- a/src/SqlHydra.Query/Kata.fs +++ b/src/SqlHydra.Query/Kata.fs @@ -71,9 +71,8 @@ type LoggedSqlResult(r: SqlResult) = override this.ToString() = let sb = Text.StringBuilder() sb.AppendLine(r.S...
[ "src/SqlHydra.Query/Kata.fs" ]
[]
true
JordanMarr/SqlHydra
112
issue_to_patch
guard against null in Fullname to remove warning when nullable enabled
Ran the CLI locally and the resulting file looked okay and build without errors. Let me know if you want me to adjust something. Also an heads up that I am getting warnings regarding EOL of dotnet 7 when building.
55d02022669e50ec063cf2e36323d0d97a99e3f0
59aba037b857c39d70db0b2cf6c4f4d481e62b52
diff --git a/src/SqlHydra.Cli/SchemaTemplate.fs b/src/SqlHydra.Cli/SchemaTemplate.fs index 7a3c6ec1..845b709f 100644 --- a/src/SqlHydra.Cli/SchemaTemplate.fs +++ b/src/SqlHydra.Cli/SchemaTemplate.fs @@ -340,7 +340,10 @@ static member Read(reader: {reader.ReaderType}) = let ord = getOrdinalAndIncrement() ...
[ "src/SqlHydra.Cli/SchemaTemplate.fs" ]
[]
true
JordanMarr/SqlHydra
109
issue_to_patch
Remove support for net6.0; Add support for net9.0
# Add net9.0 support The following pull request was generated with claude.ai and is an initial attempt to remove support for net6.0 and add support for net9.0. We have updated SqlHydra to support .NET 9 and removed support for .NET 6. ### Project File Updates 1. Updated TargetFrameworks in project files: ...
033e488c43241fa4b78a45383c981f2b9f1c2509
e8b4df0efad682f7e781307d4e1554a2cf5451b3
diff --git a/src/Build/Build.fsproj b/src/Build/Build.fsproj index 5026c1b9..49df67bb 100644 --- a/src/Build/Build.fsproj +++ b/src/Build/Build.fsproj @@ -2,7 +2,7 @@ <PropertyGroup> <OutputType>Exe</OutputType> - <TargetFramework>net6.0</TargetFramework> + <TargetFramework>net9.0</TargetFramework> ...
[ "src/Build/Build.fsproj", "src/Build/Program.fs", "src/SampleApp/SampleApp.fsproj", "src/SampleApp/sqlhydra-mssql.bat", "src/SqlHydra.Cli/SqlHydra.Cli.fsproj", "src/SqlHydra.Query/SqlHydra.Query.fsproj", "src/Tests/Npgsql/AdventureWorksNet9.fs", "src/Tests/Oracle/AdventureWorksNet9.fs", "src/Tests/S...
[]
diff --git a/src/Tests/Npgsql/AdventureWorksNet9.fs b/src/Tests/Npgsql/AdventureWorksNet9.fs new file mode 100644 index 00000000..62055644 --- /dev/null +++ b/src/Tests/Npgsql/AdventureWorksNet9.fs @@ -0,0 +1,7618 @@ +// This code was generated by `SqlHydra.Npgsql` -- v2.7.0. +namespace Npgsql.AdventureWorksNet9 + +ope...
true
JordanMarr/SqlHydra
101
issue_to_patch
Add MySql support to SqlHydra.Cli
### Description Implement mySQL support for SqlHydra CLI with basic type support. **NOTE:** This is tested with a real database, but I was unsure how to implement the test suites for this. I created a corresponding feature request [here](https://github.com/JordanMarr/SqlHydra/issues/100).
910da6ba62b182b5d17b33c3136c5c4bcfe3638c
09a007f371a5d9b7e4c7740c07e408bc0db08d1d
diff --git a/README.md b/README.md index f03e9f28..4d81285c 100644 --- a/README.md +++ b/README.md @@ -451,6 +451,9 @@ let getProductsWithCategory () = } ``` +> [!WARNING] +> You need to write the join `on` equality condition using the known (left) table variable on the left and the new (right) one on the right...
[ "README.md", "src/SqlHydra.Cli/MySql/AppInfo.fs", "src/SqlHydra.Cli/MySql/MySqlDataTypes.fs", "src/SqlHydra.Cli/MySql/MySqlSchemaProvider.fs", "src/SqlHydra.Cli/Program.fs", "src/SqlHydra.Cli/SqlHydra.Cli.fsproj" ]
[]
true
JordanMarr/SqlHydra
95
issue_to_patch
Add warning about variable usage order in `join` condition
I always forget that the order of usage for the variable matters here. This is not a bug in SqlHydra but related to how F# works if I remember correctly. Today again, after not having work on my SqlHydra project for a few weeks/month it took me several minutes to remember this limitations. Hopefully, this can sav...
910da6ba62b182b5d17b33c3136c5c4bcfe3638c
2bc98ae08bea061e923e99ad19469c3a91436d85
diff --git a/README.md b/README.md index f03e9f28..6f797f04 100644 --- a/README.md +++ b/README.md @@ -451,6 +451,9 @@ let getProductsWithCategory () = } ``` +> [!WARNING] +> You need to write the join `on` equality condition using the known (left) table variable on the left and the new (right) one on the right...
[ "README.md" ]
[]
true
JordanMarr/SqlHydra
91
issue_to_patch
Addresses issue #90 - SqlHydra.Cli doesn't map Sqlite longvarchar column types
Added a mapping for longvarchar in sqlite, and altered the `AdventureWorksLT.db` to have a longvarchar column (SalesOrderHeader.SalesOrderNumber) to enable testing
6ea5d91cbd552f9d819aa38d5197fe10fe7f8994
b8fb93cfc23c6b5a70b7958421516f990932ed37
diff --git a/src/SqlHydra.Cli/Sqlite/SqliteDataTypes.fs b/src/SqlHydra.Cli/Sqlite/SqliteDataTypes.fs index 493e128a..9ae8b874 100644 --- a/src/SqlHydra.Cli/Sqlite/SqliteDataTypes.fs +++ b/src/SqlHydra.Cli/Sqlite/SqliteDataTypes.fs @@ -41,6 +41,7 @@ let supportedTypeMappings = "nvarchar", "string", ...
[ "src/SqlHydra.Cli/Sqlite/SqliteDataTypes.fs", "src/Tests/TestData/AdventureWorksLT.db" ]
[]
diff --git a/src/Tests/TestData/AdventureWorksLT.db b/src/Tests/TestData/AdventureWorksLT.db index d4103079..6e9f2da7 100644 Binary files a/src/Tests/TestData/AdventureWorksLT.db and b/src/Tests/TestData/AdventureWorksLT.db differ
true
JordanMarr/SqlHydra
69
issue_to_patch
Update Upsertions section to add example
Add an example on how to upsert multiple records in a single PostgreSQL statement.
ad805a7eb75caf07d48a0ec9a685806d37ba7663
3fb998d775a40baf9690bb5e90ee735074debe2a
diff --git a/README.md b/README.md index f3385766..45a5e35a 100644 --- a/README.md +++ b/README.md @@ -760,6 +760,29 @@ Upsert support has been added for Postgres and Sqlite only because they support } ``` +Or, if you have multiple addresses to upsert: + +```F# + /// Inserts multiple addresses or updates...
[ "README.md" ]
[]
true
JordanMarr/SqlHydra
66
issue_to_patch
Fix Ignored `where` Clauses in `update` Queries
This fixes a major bug that causes update statements to ignore where clauses in update queries that have multiple where clauses. ```F# let query = update { for c in sales.customer do set c.personid (Some 123) where (c.personid = Some 456) // <<-- this clause overwritten by the follo...
72972fd8c5717d66ec0bcc3e474c76fa0229ce9a
85bfae37af5109f5988e23e3cd9077a4e70604ec
diff --git a/src/SqlHydra.Query/UpdateBuilders.fs b/src/SqlHydra.Query/UpdateBuilders.fs index ef1bbc3b..9ebd3b07 100644 --- a/src/SqlHydra.Query/UpdateBuilders.fs +++ b/src/SqlHydra.Query/UpdateBuilders.fs @@ -75,13 +75,21 @@ type UpdateBuilder<'Updated>() = member this.Where (state: QuerySource<'T>, [<Projection...
[ "src/SqlHydra.Query/UpdateBuilders.fs", "src/Tests/Npgsql/QueryUnitTests.fs", "src/Tests/Oracle/QueryUnitTests.fs", "src/Tests/SqlServer/QueryUnitTests.fs", "src/Tests/Sqlite/QueryUnitTests.fs" ]
[]
diff --git a/src/Tests/Npgsql/QueryUnitTests.fs b/src/Tests/Npgsql/QueryUnitTests.fs index 4bb8acc3..a598a0d8 100644 --- a/src/Tests/Npgsql/QueryUnitTests.fs +++ b/src/Tests/Npgsql/QueryUnitTests.fs @@ -1,5 +1,6 @@ module Npgsql.QueryUnitTests +open System open Expecto open SqlHydra.Query open DB @@ -306,6 +307,...
true
JordanMarr/SqlHydra
65
issue_to_patch
Add Query Logging Feature
Add a query logging feature similar to SqlKata without breaking the API.
72972fd8c5717d66ec0bcc3e474c76fa0229ce9a
c2998c1aaf4433b4ea4f64a85c95e5a17290bc82
diff --git a/README.md b/README.md index c84b021d..c5ac90a3 100644 --- a/README.md +++ b/README.md @@ -265,6 +265,17 @@ let openContext() = new QueryContext(conn, compiler) ``` +#### Query Logging + +You can, optionally, set a logger function that will be executed before a query is run. +This is a handy way to ...
[ "README.md", "src/SqlHydra.Query/QueryContext.fs" ]
[]
true
JordanMarr/SqlHydra
63
issue_to_patch
SQLHydra's maxBy causes SqlHydra code to fail if querying an empty table Noticed this when trying to use a maxBy on an empty table. We were able to work around with a sortByDescending into take 1, (we also could grab a count and branch on whether that returned anything) but wanted to suggest it might be a bit more int...
Add documentation for aggregates returning NULL for non-NULL columns
Figured this might be a good starting point. Feel free to suggest or directly make any edits. Fixes #53.
3ba128174e06b263955ca3e082e5e13f259a4056
77bc8ccf3cbb5f3f2e8ec5fc6722193a775701c6
diff --git a/README.md b/README.md index 6c88f447..ad6125e1 100644 --- a/README.md +++ b/README.md @@ -457,6 +457,31 @@ let! customersWithNoSalesPersonCount = } ``` +💥 In some cases when selecting an aggregate of a non-NULL column, the database will still return NULL if the query result set is empty, for examp...
[ "README.md" ]
[]
true
JordanMarr/SqlHydra
60
issue_to_patch
Fix cancellation support
* Fixes async builders not passing CancellationTokens through * Adds task builder variations which accepts a CancellationToken Related to #19
d03ef91afbe21a1fd57e924561e311ba999f2c74
40ee369d6791de63bec893a45e237d7644615573
diff --git a/src/SqlHydra.Query/DeleteBuilders.fs b/src/SqlHydra.Query/DeleteBuilders.fs index 06f0b77f..05717b00 100644 --- a/src/SqlHydra.Query/DeleteBuilders.fs +++ b/src/SqlHydra.Query/DeleteBuilders.fs @@ -2,6 +2,7 @@ [<AutoOpen>] module SqlHydra.Query.DeleteBuilders +open System.Threading open SqlKata let...
[ "src/SqlHydra.Query/DeleteBuilders.fs", "src/SqlHydra.Query/InsertBuilders.fs", "src/SqlHydra.Query/QueryContext.fs", "src/SqlHydra.Query/SelectBuilders.fs", "src/SqlHydra.Query/UpdateBuilders.fs" ]
[]
true
JordanMarr/SqlHydra
51
issue_to_patch
How to use a correlated subquery? I'm trying to write a query with a subquery that references rows from the parent query. For example, say I want SQL for getting the latest weather value from a table of weather data that looks roughly like ```SQL SELECT * FROM weather w WHERE w.time >= '2023-02-01' AND w.time ...
Correlated subqueries?
This maybe fixes #48. It tries to implement option number 2 as referenced in that issue. It lets you write a correlated subquery like ```f# let maxOrderQty = select { for d in table<Sales.SalesOrderDetail> do correlate od in correlatedTable<Sal...
8d14bbd2e0f554e4874399ed4b75e6700d2cb9f7
40162eb1b24e28e75925ac325ab01a33a0f18540
diff --git a/README.md b/README.md index a17fca4f..de0f35a6 100644 --- a/README.md +++ b/README.md @@ -574,6 +574,30 @@ let! productsWithAboveAveragePrice = } ``` +If the subquery is correlated with the parent query (i.e., the subquery references a row variable from the parent query), use the `correlate` keywor...
[ "README.md", "src/SqlHydra.Query/SelectBuilders.fs", "src/Tests/Npgsql/QueryUnitTests.fs", "src/Tests/Oracle/QueryUnitTests.fs", "src/Tests/SqlServer/QueryUnitTests.fs", "src/Tests/Sqlite/QueryUnitTests.fs" ]
[ { "comment": "We could also just make the `correlate` command just work with a `QuerySource<'T>` and the `table` function instead of this. ", "path": "src/SqlHydra.Query/QueryFunctions.fs", "hunk": "@@ -9,6 +9,10 @@ module Table =\n let tables = Map [Root, { Name = ent.Name; Schema = ent.Declar...
diff --git a/src/Tests/Npgsql/QueryUnitTests.fs b/src/Tests/Npgsql/QueryUnitTests.fs index b4f5da69..21d349b0 100644 --- a/src/Tests/Npgsql/QueryUnitTests.fs +++ b/src/Tests/Npgsql/QueryUnitTests.fs @@ -249,6 +249,31 @@ let tests = Expect.isTrue (sql.Contains("LEFT JOIN \"sales\".\"salesorderdetail\" AS \"...
true
JordanMarr/SqlHydra
49
issue_to_patch
Allow comparisons with the column on the right
I was looking at this code while working on something else, and saw an opportunity to address a slight nuisance that I ran into before, so I decided to create a PR for it. Feel free to just close this if it's not a direction you want to go, since I didn't create an issue or any discussion around this before making the...
a808ef0248f647ec78b8143881c32c20aec43982
163400dad925a227cbd6ed74af37568b8dbeb1d1
diff --git a/src/SqlHydra.Query/LinqExpressionVisitors.fs b/src/SqlHydra.Query/LinqExpressionVisitors.fs index 0e5a7090..41761085 100644 --- a/src/SqlHydra.Query/LinqExpressionVisitors.fs +++ b/src/SqlHydra.Query/LinqExpressionVisitors.fs @@ -227,6 +227,17 @@ let getComparison (expType: ExpressionType) = | Express...
[ "src/SqlHydra.Query/LinqExpressionVisitors.fs", "src/Tests/Npgsql/QueryUnitTests.fs", "src/Tests/Oracle/QueryUnitTests.fs", "src/Tests/SqlServer/QueryUnitTests.fs", "src/Tests/Sqlite/QueryUnitTests.fs" ]
[]
diff --git a/src/Tests/Npgsql/QueryUnitTests.fs b/src/Tests/Npgsql/QueryUnitTests.fs index b4f5da69..0e3bd317 100644 --- a/src/Tests/Npgsql/QueryUnitTests.fs +++ b/src/Tests/Npgsql/QueryUnitTests.fs @@ -133,6 +133,17 @@ let tests = "Should wrap OR clause in parenthesis and each individual where clause ...
true
JordanMarr/SqlHydra
41
issue_to_patch
support implicit .NET conversions on option types
currently the LINQ expression visitor runs into an exception when dealing with implicit numeric conversions. since both of the following examples are valid F# i added support for these implicit conversions ```fsharp // runs just fine let query1 = selectAsync HydraReader.Read (Create openContext) { ...
22a65735283f468755fd42b1c6399846d70b1f35
9359c54b2c2445abc832650c74a5c3a6d44d71be
diff --git a/src/SqlHydra.Query/LinqExpressionVisitors.fs b/src/SqlHydra.Query/LinqExpressionVisitors.fs index c3e8aca3..bcbf665c 100644 --- a/src/SqlHydra.Query/LinqExpressionVisitors.fs +++ b/src/SqlHydra.Query/LinqExpressionVisitors.fs @@ -70,7 +70,14 @@ module VisitorPatterns = match exp.NodeType with ...
[ "src/SqlHydra.Query/LinqExpressionVisitors.fs" ]
[]
true
JordanMarr/SqlHydra
36
issue_to_patch
Make it explicit that `conn.Open()` needs to be called
When I did the setup of SqlHydra in my project I read through the README and came up with this code: ```fs [<RequireQualifiedAccess>] module DbContext = open SqlHydra.Query open Microsoft.Data.SqlClient let create () = let compiler = SqlKata.Compilers.SqlServerCompiler() let co...
b4344beabff37bf6409ff6e7a248edc5536b09af
3aa333a5a9ed98b4c9011e633351919b40d13d0a
diff --git a/README.md b/README.md index 554baa26..29ea6a7a 100644 --- a/README.md +++ b/README.md @@ -339,7 +339,8 @@ let errorLogTable = table<dbo.ErrorLog> /// Opens a connection and creates a QueryContext that will generate SQL Server dialect queries let openContext() = let compiler = SqlKata.Compil...
[ "README.md" ]
[]
true
JordanMarr/SqlHydra
33
issue_to_patch
Allow SQL with full datetime2 precision on SQL Server databases
I do not think this PR is ready to be merged yet. The fix ended up being more complicated than it initially looked. The issue is that `QueryContext.setProviderDbType` is ultimately only called on INSERT and UPDATE (SET & entity) commands, but not on SELECT or the WHERE clause of an UPDATE. This was fixed in this PR ...
09aa7fdf97b4ca7458bdd3aa58c3c9114db0b2ec
25a9fb98560c7559a8f827ef78ee2eb13aac1f0a
diff --git a/src/.devcontainer/mssql/install.sql b/src/.devcontainer/mssql/install.sql index db8e77eb..68e2f5bc 100644 --- a/src/.devcontainer/mssql/install.sql +++ b/src/.devcontainer/mssql/install.sql @@ -4,4 +4,16 @@ RESTORE DATABASE [AdventureWorks] WITH REPLACE, MOVE 'AdventureWorks2017' TO '/var...
[ "src/.devcontainer/mssql/install.sql", "src/SqlHydra.Query/Kata.fs", "src/SqlHydra.Query/LinqExpressionVisitors.fs", "src/SqlHydra.Query/SqlHydra.Query.fsproj", "src/SqlHydra.Query/UpdateBuilders.fs", "src/SqlHydra.SqlServer/SqlHydra.SqlServer.fsproj", "src/SqlHydra.SqlServer/SqlServerDataTypes.fs", "...
[ { "comment": "This fails without the changes to LinqExpressionVisitors. `fullPrecisionQuery` is 0 because the timestamp in the where clause is truncated to DATETIME precision.", "path": "src/Tests/SqlServer/QueryIntegrationTests.fs", "hunk": "@@ -658,4 +659,78 @@ let tests =\n }\n #endif\n \n+ ...
diff --git a/src/Tests/SqlServer/AdventureWorksNet5.fs b/src/Tests/SqlServer/AdventureWorksNet5.fs index 1dfc4ddd..ae046fdd 100644 --- a/src/Tests/SqlServer/AdventureWorksNet5.fs +++ b/src/Tests/SqlServer/AdventureWorksNet5.fs @@ -35,6 +35,7 @@ module HumanResources = { DepartmentID: int16 Name: str...
true
JordanMarr/SqlHydra
20
issue_to_patch
Support for cancellation token in db operations It seems like there is no support for passing cancellation token in async operations against `QueryContext`. Do the native drivers have support for this? Would it be difficult to implement, what do you think?
Add cancellation token to query context
Adds cancellation token to all async methods in `QueryContext`, closes #19 . Overloads didn't work for `ReadAsync` and `ReadOneAsync` since they are curried and it is not allowed with overloads (see [docs](https://docs.microsoft.com/en-us/dotnet/fsharp/language-reference/members/methods#overloaded-methods)), so I had ...
fbfb349c4dcf079842ed4a690a4db01f7ed7f2ab
7b7b060118e94b721bcc7799d1b8b14549482fb4
diff --git a/src/SqlHydra.Query/QueryContext.fs b/src/SqlHydra.Query/QueryContext.fs index eb6e5639..995da855 100644 --- a/src/SqlHydra.Query/QueryContext.fs +++ b/src/SqlHydra.Query/QueryContext.fs @@ -1,6 +1,7 @@ namespace SqlHydra.Query open System.Data.Common +open System.Threading open SqlKata /// Contain...
[ "src/SqlHydra.Query/QueryContext.fs" ]
[]
true
JordanMarr/SqlHydra
17
issue_to_patch
Types for views are not generated We are using a `postgres` database and it seems like `sqlhydra` doesn't generate types for views. Is there anything extra we need to add in the configuration file? Or is it not supported by the library? Thanks!
Add views in postgres, fix tests
This PR adds metadata for views in `postgres`. Fixes #16
4918128f7c8c272d88eeb811869089748e0b607c
1ebd4e39d086f85abb69749a92c9be04d40337cf
diff --git a/src/SqlHydra.Npgsql/NpgsqlSchemaProvider.fs b/src/SqlHydra.Npgsql/NpgsqlSchemaProvider.fs index 9d352055..d31e0c48 100644 --- a/src/SqlHydra.Npgsql/NpgsqlSchemaProvider.fs +++ b/src/SqlHydra.Npgsql/NpgsqlSchemaProvider.fs @@ -9,6 +9,7 @@ let getSchema (cfg: Config) : Schema = conn.Open() let sTab...
[ "src/SqlHydra.Npgsql/NpgsqlSchemaProvider.fs", "src/Tests/Npgsql/AdventureWorks.fs", "src/Tests/Npgsql/Generation.fs" ]
[]
diff --git a/src/Tests/Npgsql/AdventureWorks.fs b/src/Tests/Npgsql/AdventureWorks.fs index 3f9875f8..8be8bc83 100644 --- a/src/Tests/Npgsql/AdventureWorks.fs +++ b/src/Tests/Npgsql/AdventureWorks.fs @@ -28,6 +28,196 @@ type OptionalBinaryColumn<'T, 'Reader when 'Reader :> System.Data.IDataReader>(r | o whe...
true
JordanMarr/SqlHydra
12
issue_to_patch
Order columns by ORDINAL_POSITION
I wanted to verify the output of the code in a more automated way, so I've added the Verify.Expecto package to the test project and changed "Print Code" to "Generated Code" so we can acceptance test against that. If you don't want that reference added just let me know and I'll go with the simpler option of making th...
04d2935c532ac99d9ecd3307b1b85dc218942436
64cc599d4e21d4b759ae6c32a8f84061de82ac36
diff --git a/.gitignore b/.gitignore index 5340c6e7..f9dee6f9 100644 --- a/.gitignore +++ b/.gitignore @@ -50,3 +50,4 @@ Desktop.ini *.dbmdl *.jfm /src/Tests/TestData/AdventureWorksLT_Temp.db +*.received.* \ No newline at end of file diff --git a/src/SqlHydra.SqlServer/SqlServerSchemaProvider.fs b/src/SqlHydra.SqlSe...
[ ".gitignore", "src/SqlHydra.SqlServer/SqlServerSchemaProvider.fs", "src/SqlHydra.Sqlite/SqliteSchemaProvider.fs", "src/Tests/SqlServer/Generation.GeneratedCode.verified.txt", "src/Tests/SqlServer/Generation.fs", "src/Tests/Sqlite/Generation.GeneratedCode.verified.txt", "src/Tests/Sqlite/Generation.fs", ...
[]
diff --git a/src/Tests/SqlServer/Generation.GeneratedCode.verified.txt b/src/Tests/SqlServer/Generation.GeneratedCode.verified.txt new file mode 100644 index 00000000..c4eec512 --- /dev/null +++ b/src/Tests/SqlServer/Generation.GeneratedCode.verified.txt @@ -0,0 +1,3485 @@ +namespace TestNS + +type Column(reader: Syst...
true
JordanMarr/SqlHydra
10
issue_to_patch
Fails to insert jsonb values in Postgres We have a table with a field of type `jsonb`, which becomes `string` in the generated type, but it doesn't seem to work when inserting a string with the json format, the exception I get is: ``` Npgsql.PostgresException (0x80004005): 42804: column "test" is of type jsonb but e...
Add provider specific column types
This PR attempts to fix #7 by adding a new attribute for fields that require db provider-specific type to be set on the corresponding command parameter. E.g. `postgres` requires `NpgsqlDbType.Json` and `NpgsqlDbType.Jsonb` to be set on the command parameter for columns of types `json` and `jsonb` correspondingly when u...
376072a947afd19d20ff7919ff06a37818058405
feaf2effcc8d45d58b2966f50c7e0d5c7913f226
diff --git a/.gitignore b/.gitignore index 5340c6e7..98202a43 100644 --- a/.gitignore +++ b/.gitignore @@ -19,6 +19,7 @@ nupkg **/.idea/**/tasks.xml **/.idea/shelf/* **/.idea/dictionaries +.idea # Sensitive or high-churn files **/.idea/**/dataSources/ diff --git a/src/.devcontainer/postgresql/install.sql b/src/....
[ ".gitignore", "src/.devcontainer/postgresql/install.sql", "src/SqlHydra.Domain/Domain.fs", "src/SqlHydra.Domain/ProviderDbTypeAttribute.fs", "src/SqlHydra.Domain/SqlHydra.Domain.fsproj", "src/SqlHydra.Npgsql/NpgsqlDataTypes.fs", "src/SqlHydra.Npgsql/NpgsqlSchemaProvider.fs", "src/SqlHydra.Query/Kata.f...
[ { "comment": "This might be a wrong thing to do, I needed to reference the attribute I created inside `SqlHydra`. Does it mean the nuget package will get a dependency to `SqlHydra`? \r\nAlso had to change the target framework to be compatible with that project. Is it on purpose that this project is targeting `n...
diff --git a/src/Tests/Npgsql/AdventureWorks.fs b/src/Tests/Npgsql/AdventureWorks.fs index 9ef363ee..72a37445 100644 --- a/src/Tests/Npgsql/AdventureWorks.fs +++ b/src/Tests/Npgsql/AdventureWorks.fs @@ -1,4 +1,4 @@ -// This code was generated by `SqlHydra.Npgsql` -- v0.510.0.0. +// This code was generated by `SqlHydra....
true
JosefNemec/Playnite
4,309
issue_to_patch
Update startup arguments for Eden emulator to automatically launch in fullscreen
7437f11ef502efd7d3740d191fb257f2d4f2d675
3aac45beda504a236bb313f8b8c2dc88598a4a62
diff --git a/source/Playnite/Emulation/Emulators/Eden/emulator.yaml b/source/Playnite/Emulation/Emulators/Eden/emulator.yaml index aaf1a688a..65a317cd9 100644 --- a/source/Playnite/Emulation/Emulators/Eden/emulator.yaml +++ b/source/Playnite/Emulation/Emulators/Eden/emulator.yaml @@ -3,7 +3,7 @@ Name: Eden Website: 'h...
[ "source/Playnite/Emulation/Emulators/Eden/emulator.yaml" ]
[]
true
JosefNemec/Playnite
4,310
issue_to_patch
Update startup arguments for Ryujinx emulator to automatically launch…
7437f11ef502efd7d3740d191fb257f2d4f2d675
1d821a5fa2d75eb27e6ef7490f79c1cd097ee484
diff --git a/source/Playnite/Emulation/Emulators/Ryujinx/emulator.yaml b/source/Playnite/Emulation/Emulators/Ryujinx/emulator.yaml index e6222e31b..e1eefc310 100644 --- a/source/Playnite/Emulation/Emulators/Ryujinx/emulator.yaml +++ b/source/Playnite/Emulation/Emulators/Ryujinx/emulator.yaml @@ -3,12 +3,12 @@ Name: Ryu...
[ "source/Playnite/Emulation/Emulators/Ryujinx/emulator.yaml" ]
[]
true
JosefNemec/Playnite
4,293
issue_to_patch
Move Fullscreen Mode's PlayMusic() Call
Move Fullscreen PlayMusic() from FullscreenApplication.InitializeAudio to FullscreenAppViewModel.InitializeView Addresses an issue where Fullscreen background music sometimes fires early before the fullscreen window fully appears.
63608f582402d21ab62099a7b36ca03c1a49cfd6
ad5efeef33f449d29178c14a215c0e24b862b1b4
diff --git a/source/Playnite.FullscreenApp/FullscreenApplication.cs b/source/Playnite.FullscreenApp/FullscreenApplication.cs index 19bf3e0d4..73ac4fad1 100644 --- a/source/Playnite.FullscreenApp/FullscreenApplication.cs +++ b/source/Playnite.FullscreenApp/FullscreenApplication.cs @@ -419,10 +419,6 @@ private void Initi...
[ "source/Playnite.FullscreenApp/FullscreenApplication.cs", "source/Playnite.FullscreenApp/ViewModels/FullscreenAppViewModel.cs" ]
[]
true
JosefNemec/Playnite
4,291
issue_to_patch
add almost all changes from Extra Emulator Profiles
This is basically all of Extra Emulator Profiles. Few changes: - Less Switch emulators listed with the platform just to not recommend them (commented in platforms.yaml). - Removed two TODO comments from RetroArch: `ep128emu` and `m2000` - didn't get around to figuring out how they work - Removed an added `-nogui` ...
fb36ed3a8ff54179c4725dc905ceb49af947722e
2f688798156202e5ea37fa0afb9a74b8e9c33757
diff --git a/source/Playnite/Emulation/Emulators/Azahar/emulator.yaml b/source/Playnite/Emulation/Emulators/Azahar/emulator.yaml new file mode 100644 index 000000000..4a8810fd6 --- /dev/null +++ b/source/Playnite/Emulation/Emulators/Azahar/emulator.yaml @@ -0,0 +1,9 @@ +Id: azahar +Name: Azahar +Website: 'https://azaha...
[ "source/Playnite/Emulation/Emulators/Azahar/emulator.yaml", "source/Playnite/Emulation/Emulators/BizHawk/emulator.yaml", "source/Playnite/Emulation/Emulators/Borked3DS/emulator.yaml", "source/Playnite/Emulation/Emulators/Citron/emulator.yaml", "source/Playnite/Emulation/Emulators/Eden/emulator.yaml", "sou...
[]
true
JosefNemec/Playnite
4,281
issue_to_patch
Enable HDR doesnt work with two monitors connected to different GPUs ### Bug Description I have two monitors, one is connectied to Nvidia card, supports HDR and is set as primary display. Second is connected to the integrated GPU doesnt support HDR and is configured as secondary. When i enable HDR checkbox in a g...
Fix "Enable HDR Support" not working when multiple adapter.
Fix an issue where Enable HDR Support would not work if multiple adapter(GPU, Virtual Display Driver, etc). Maybe Fixes #3754 The problem was that the sourceInfo.Id is based on the adapter and could be identical for 2 different adapter. (Ex.: AdapterId 1/Id 0 and Adapter 2/Id 0). So in my case, instead of returni...
ab2eed4d09eab9e276d51056e2ed487aae1d32e9
d63b92187608aa365d8205b1f2231adaee854358
diff --git a/source/Playnite/HdrUtilities.cs b/source/Playnite/HdrUtilities.cs index 1dcfe6a68..a69daf69c 100644 --- a/source/Playnite/HdrUtilities.cs +++ b/source/Playnite/HdrUtilities.cs @@ -149,7 +149,8 @@ private static bool IsPrimaryDisplayMode(DISPLAYCONFIG_MODE_INFO mode) .FirstOrDefault(IsPrim...
[ "source/Playnite/HdrUtilities.cs" ]
[]
true
JosefNemec/Playnite
4,252
issue_to_patch
explorer.exe process not terminating after folder is closed ### Bug Description When opening game installation directories through Playnite (e.g., "Open Installation Location"), process handles accumulate in memory. Even after closing the Explorer windows, the handles remain and are not released. (I leave my PC runn...
Fix explorer.exe process not terminating after window close
Fixes #4248 This PR fixes the issue where `explorer.exe` processes remain hanging after the window is closed. ### Changes - `Explorer.NavigateToFileSystemEntry`: Replaced `explorer.exe /select,` with Shell32 API (`SHOpenFolderAndSelectItems`) - `Explorer.OpenDirectory`: Use `ProcessStartInfo` with `UseShellExec...
e6016589186fee4b547f0d976905614793b9a1b2
f3e4affafeca978cd231e7083b047ab3b7fb8df0
diff --git a/source/Playnite/Commands/GlobalCommands.cs b/source/Playnite/Commands/GlobalCommands.cs index 34ba3fb46..faa966199 100644 --- a/source/Playnite/Commands/GlobalCommands.cs +++ b/source/Playnite/Commands/GlobalCommands.cs @@ -48,7 +48,7 @@ public static class GlobalCommands } ...
[ "source/Playnite/Commands/GlobalCommands.cs", "source/Playnite/Common/Explorer.cs" ]
[]
true
JosefNemec/Playnite
4,257
issue_to_patch
Add .iso to RPCS3 import script
Already part of Extra Emulator Profiles, figured this could go in Playnite proper too.
e6016589186fee4b547f0d976905614793b9a1b2
141b8749fb51d509cc56fb26494bda3ecbb1b8c7
diff --git a/source/Playnite/Emulation/Emulators/RPCS3/importGames.ps1 b/source/Playnite/Emulation/Emulators/RPCS3/importGames.ps1 index 1e680db67..6a3a94d73 100644 --- a/source/Playnite/Emulation/Emulators/RPCS3/importGames.ps1 +++ b/source/Playnite/Emulation/Emulators/RPCS3/importGames.ps1 @@ -59,7 +59,7 @@ function ...
[ "source/Playnite/Emulation/Emulators/RPCS3/importGames.ps1" ]
[]
true
JosefNemec/Playnite
4,249
issue_to_patch
explorer.exe process not terminating after folder is closed ### Bug Description When opening game installation directories through Playnite (e.g., "Open Installation Location"), process handles accumulate in memory. Even after closing the Explorer windows, the handles remain and are not released. (I leave my PC runn...
Fix process handle leak when opening Explorer windows
Fixes #4248 Changes Dispose `Process` objects after starting Explorer to prevent handle leaks when opening directories.
3cc38a4bd2f28ff86d4f4fab0971c61f3c698b00
1c69801fc060d6f8737b26ea1411a1c00f87a7b2
diff --git a/source/Playnite/Commands/GlobalCommands.cs b/source/Playnite/Commands/GlobalCommands.cs index f816882d4..34ba3fb46 100644 --- a/source/Playnite/Commands/GlobalCommands.cs +++ b/source/Playnite/Commands/GlobalCommands.cs @@ -43,12 +43,12 @@ public static class GlobalCommands catch (Exce...
[ "source/Playnite/Commands/GlobalCommands.cs", "source/Playnite/Common/Explorer.cs" ]
[]
true
JosefNemec/Playnite
4,214
issue_to_patch
Autofill sorting name when saving game edit window
bef7cf9597991b1d68de893016854485baf6591c
063201353a4c4a35fd76c302bfcf79451dbff008
diff --git a/source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs b/source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs index 51600cd94..e5551d26f 100644 --- a/source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs +++ b/source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs @@ -656,6 +656,10 @@ Li...
[ "source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs", "source/Playnite/Localization/LocSource.xaml" ]
[ { "comment": "Should test not just for empty but also whitespace since it's a field that user can fill in and possibly just leave empty whitespace there.", "path": "source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs", "hunk": "@@ -921,6 +925,15 @@ List<Guid> consolidateIds(SelectableDbItemList s...
true
JosefNemec/Playnite
4,214
comment_to_fix
Autofill sorting name when saving game edit window
Should test not just for empty but also whitespace since it's a field that user can fill in and possibly just leave empty whitespace there.
bef7cf9597991b1d68de893016854485baf6591c
063201353a4c4a35fd76c302bfcf79451dbff008
diff --git a/source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs b/source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs index 51600cd94..e5551d26f 100644 --- a/source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs +++ b/source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs @@ -656,6 +656,10 @@ Li...
[ "source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs" ]
[ { "comment": "Should test not just for empty but also whitespace since it's a field that user can fill in and possibly just leave empty whitespace there.", "path": "source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs", "hunk": "@@ -921,6 +925,15 @@ List<Guid> consolidateIds(SelectableDbItemList s...
true
JosefNemec/Playnite
4,214
comment_to_fix
Autofill sorting name when saving game edit window
Can SortableNameConverter change casing? I didn't check the code, but if so, then I would do case insensitive comparison here instead.
bef7cf9597991b1d68de893016854485baf6591c
063201353a4c4a35fd76c302bfcf79451dbff008
diff --git a/source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs b/source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs index 51600cd94..e5551d26f 100644 --- a/source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs +++ b/source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs @@ -656,6 +656,10 @@ Li...
[ "source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs" ]
[ { "comment": "Can SortableNameConverter change casing? I didn't check the code, but if so, then I would do case insensitive comparison here instead.", "path": "source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs", "hunk": "@@ -921,6 +925,15 @@ List<Guid> consolidateIds(SelectableDbItemList select...
true
JosefNemec/Playnite
4,053
issue_to_patch
Avoid named pipe conflicts
Although Playnite correctly creates its named pipe with a unique base address (`net.pipe://localhost/PlaynitePipe`) along with an additional identifier (`PipeEndpoint`), some "misbehaving" programs may interfere when they use only `net.pipe://localhost` as their base address, even if these programs append a unique segm...
31225440c1e7224e5be24f8635c1a9b8699821e2
9bf90be8c2922330f7bc2d92f0705c34d5aaa45c
diff --git a/source/Playnite/Common.config b/source/Playnite/Common.config index 19fd29a6c..7f11f2de0 100644 --- a/source/Playnite/Common.config +++ b/source/Playnite/Common.config @@ -8,4 +8,5 @@ <add key="OfflineMode" value="True" /> <add key="PipeEndpoint" value="net.pipe://localhost/PlaynitePipe" /> <add...
[ "source/Playnite/Common.config" ]
[]
true
JosefNemec/Playnite
4,159
issue_to_patch
Fix window restoration in Fullscreen mode
### Summary Enforced windows restoration in Fullscreen when games exit by directly calling RestoreWindow on the Window. ### Case In my installation, admittedly modified with many addons (though not that many, and only the most popular ones), Playnite Fullscreen window doesn't get restored after I close a game,...
4d5fb929d55bda4db86bc3f0bbebc9742324446c
e22e7093c965a6a3c5520120613350f4b9d0f00c
diff --git a/source/Playnite.FullscreenApp/ViewModels/FullscreenAppViewModel.cs b/source/Playnite.FullscreenApp/ViewModels/FullscreenAppViewModel.cs index 5bd8e7648..4394c72fc 100644 --- a/source/Playnite.FullscreenApp/ViewModels/FullscreenAppViewModel.cs +++ b/source/Playnite.FullscreenApp/ViewModels/FullscreenAppView...
[ "source/Playnite.FullscreenApp/ViewModels/FullscreenAppViewModel.cs" ]
[ { "comment": "Shouldn't this be technically enough to fix the issue if some extension you have installed is breaking it by having `LastActiveWindow` assigned to something else? Not sure about all those other changes.\r\n\r\nI would prefer to not do any extra changes to the `RestoreWindow` function since this ma...
true
JosefNemec/Playnite
4,177
issue_to_patch
Use currently chosen display language for first start
This prevents using an unexpected language if "Windows display language" and other "Language & region" settings don't match.
7e2e9da03b45b73721079164d780b551136a9b84
485d70a9068df68a3f1432d170cbf400e0d2c18b
diff --git a/source/Playnite/App/PlayniteApplication.cs b/source/Playnite/App/PlayniteApplication.cs index 5ac754b5c..d0295490c 100644 --- a/source/Playnite/App/PlayniteApplication.cs +++ b/source/Playnite/App/PlayniteApplication.cs @@ -326,7 +326,7 @@ public PlayniteApplication( { ...
[ "source/Playnite/App/PlayniteApplication.cs" ]
[]
true
JosefNemec/Playnite
4,147
issue_to_patch
Add support for theming ProgressWindow.xaml
# Before (Default theme): <img width="3839" height="2159" alt="Screenshot 2025-10-17 184618" src="https://github.com/user-attachments/assets/a92d1825-bdaf-48ef-826c-f6b05c8d071f" /> <img width="3839" height="2159" alt="Screenshot 2025-10-17 184624" src="https://github.com/user-attachments/assets/5f1ef444-0662-4c3b-88...
fba7c5c83a638beffdb90b8fcad4f827bb8386aa
c8407db2f3233513f9268aa834cfbc3b495289ec
diff --git a/source/Playnite.FullscreenApp/Themes/Fullscreen/Default/Constants.xaml b/source/Playnite.FullscreenApp/Themes/Fullscreen/Default/Constants.xaml index e7e02834a..27ac83326 100644 --- a/source/Playnite.FullscreenApp/Themes/Fullscreen/Default/Constants.xaml +++ b/source/Playnite.FullscreenApp/Themes/Fullscree...
[ "source/Playnite.FullscreenApp/Themes/Fullscreen/Default/Constants.xaml", "source/Playnite.FullscreenApp/Themes/Fullscreen/Default/DefaultControls/ProgressBar.xaml", "source/Playnite.FullscreenApp/Themes/Fullscreen/Default/Media.xaml", "source/Playnite.FullscreenApp/Windows/ProgressWindow.xaml" ]
[]
true
JosefNemec/Playnite
4,124
issue_to_patch
Filter refactor
Removed a lot of repetition, and made single-value fields no longer listen to "match all filters" Sorry about the hassle of checking a refactor. I could just do it in place too if you prefer.
07b96f4d7d0e65e3050ef44de289a5e212a78ea7
a25515c77f4ed67dfa47f1734a365ba8b34ddf52
diff --git a/source/Playnite/Database/GameDatabase_Filters.cs b/source/Playnite/Database/GameDatabase_Filters.cs index 36ec0db49..00beec935 100644 --- a/source/Playnite/Database/GameDatabase_Filters.cs +++ b/source/Playnite/Database/GameDatabase_Filters.cs @@ -3,8 +3,6 @@ using System; using System.Collections.Gener...
[ "source/Playnite/Database/GameDatabase_Filters.cs", "source/Tests/Playnite.Tests/Database/GameLibraryFilterTests.cs", "source/Tests/Playnite.Tests/Playnite.Tests.csproj" ]
[]
diff --git a/source/Tests/Playnite.Tests/Database/GameLibraryFilterTests.cs b/source/Tests/Playnite.Tests/Database/GameLibraryFilterTests.cs new file mode 100644 index 000000000..1379b29bd --- /dev/null +++ b/source/Tests/Playnite.Tests/Database/GameLibraryFilterTests.cs @@ -0,0 +1,417 @@ +using NUnit.Framework; +using...
true
JosefNemec/Playnite
4,050
issue_to_patch
Create jgenesis emulator profile
Just as a note in case you are wondering why some profiles share the same hardware in command line, it's not an error and it's because they use the same hardware internally in the emulator. Profiles are defined per system, and follows the command line systems: - https://github.com/jsgroth/jgenesis/blob/d16262b57d37b...
653bd468101c98dbd176b78ae94c10a0679fa0e4
6e431be73099bd9416487e4b3e3dd48d97656509
diff --git a/source/Playnite/Emulation/Emulators/jgenesis/emulator.yaml b/source/Playnite/Emulation/Emulators/jgenesis/emulator.yaml new file mode 100644 index 000000000..e94b5b6b1 --- /dev/null +++ b/source/Playnite/Emulation/Emulators/jgenesis/emulator.yaml @@ -0,0 +1,57 @@ +Id: jgenesis +Name: jgenesis +Website: 'ht...
[ "source/Playnite/Emulation/Emulators/jgenesis/emulator.yaml", "source/Playnite/Emulation/Platforms.yaml" ]
[]
true
JosefNemec/Playnite
4,040
issue_to_patch
Add Ymir Saturn Emulator Support
Adds Ymir Saturn Emulator Support
653bd468101c98dbd176b78ae94c10a0679fa0e4
53f082d732da02d6cd0967b623e2f947100a0819
diff --git a/source/Playnite/Emulation/Emulators/Ymir/emulator.yaml b/source/Playnite/Emulation/Emulators/Ymir/emulator.yaml new file mode 100644 index 000000000..3c1475421 --- /dev/null +++ b/source/Playnite/Emulation/Emulators/Ymir/emulator.yaml @@ -0,0 +1,9 @@ +Id: ymir +Name: Ymir +Website: 'https://github.com/Stri...
[ "source/Playnite/Emulation/Emulators/Ymir/emulator.yaml" ]
[]
true
JosefNemec/Playnite
4,038
issue_to_patch
Add close button to Explorer Panel
**Code contributions (pull requests) are currently not being accepted while majority of code base is being rewritten for Playnite 11.** **Please wait with any pull requests after P11 is at least in beta state.** --- I think from a UX perspective it makes more sense to have a way to close the panel within itsel...
02e55e1e30c86e6b4ef9f76be5195dca046a5c2e
e7aabcc506c5e0a048012c10842cda883c1badfd
diff --git a/source/Playnite.DesktopApp/Controls/Views/ExplorerPanel.cs b/source/Playnite.DesktopApp/Controls/Views/ExplorerPanel.cs index 458a089df..6881cd442 100644 --- a/source/Playnite.DesktopApp/Controls/Views/ExplorerPanel.cs +++ b/source/Playnite.DesktopApp/Controls/Views/ExplorerPanel.cs @@ -20,12 +20,13 @@ nam...
[ "source/Playnite.DesktopApp/Controls/Views/ExplorerPanel.cs", "source/Playnite.DesktopApp/Themes/Desktop/Default/Views/ExplorerPanel.xaml" ]
[]
true
JosefNemec/Playnite
3,950
issue_to_patch
Extra Library statistics ### Feature description It would be interesting to have a breakdown of games per platform (plugins), e.g.: Steam, Epic, ... ### Screenshots ![Image](https://github.com/user-attachments/assets/9f28854b-4e28-4e9d-9981-2414133ca5d2)
Add GameProvider statistics
Fixes #3949
75372a6d70abbbacabf297e6d75770f58fa25f10
860187f3a56ef15f28d698df9267f75725a8ed89
diff --git a/source/Playnite.DesktopApp/Controls/LibraryStatistics.xaml b/source/Playnite.DesktopApp/Controls/LibraryStatistics.xaml index cb5059835..6d7240064 100644 --- a/source/Playnite.DesktopApp/Controls/LibraryStatistics.xaml +++ b/source/Playnite.DesktopApp/Controls/LibraryStatistics.xaml @@ -118,6 +118,33 @@ ...
[ "source/Playnite.DesktopApp/Controls/LibraryStatistics.xaml", "source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs" ]
[]
true
JosefNemec/Playnite
4,031
issue_to_patch
Added error dialog when trying to bulk download metadata with no fields enabled
Tested. Simple enough that I can't think of anything I could've missed.
485c5292b15eb1493c938eca0aab2a57b32005ad
24cfef874c53c4d952369bf13b10063f80605d27
diff --git a/source/Playnite.DesktopApp/ViewModels/DesktopAppViewModel_Commands.cs b/source/Playnite.DesktopApp/ViewModels/DesktopAppViewModel_Commands.cs index 5f347ac7d..020861a05 100644 --- a/source/Playnite.DesktopApp/ViewModels/DesktopAppViewModel_Commands.cs +++ b/source/Playnite.DesktopApp/ViewModels/DesktopAppV...
[ "source/Playnite.DesktopApp/ViewModels/DesktopAppViewModel_Commands.cs", "source/Playnite.DesktopApp/ViewModels/MetadataDownloadViewModel.cs", "source/Playnite/Localization/LocSource.xaml", "source/Playnite/Localization/LocalizationKeys.cs" ]
[]
true
JosefNemec/Playnite
4,033
issue_to_patch
shadPS4: exclude patch directories
Please credit JupiterJesus if this is merged: https://github.com/JosefNemec/Playnite/issues/3959
485c5292b15eb1493c938eca0aab2a57b32005ad
82f05d10f91fd45f7a242e1206e4af444e0055be
diff --git a/source/Playnite/Emulation/Emulators/shadPS4/importGames.ps1 b/source/Playnite/Emulation/Emulators/shadPS4/importGames.ps1 index 9020e90b4..759559018 100644 --- a/source/Playnite/Emulation/Emulators/shadPS4/importGames.ps1 +++ b/source/Playnite/Emulation/Emulators/shadPS4/importGames.ps1 @@ -59,7 +59,7 @@ f...
[ "source/Playnite/Emulation/Emulators/shadPS4/importGames.ps1" ]
[]
true
JosefNemec/Playnite
4,026
issue_to_patch
Update Lime3DS emulator exe
b840a34f5d8b4eb278c1cfa1a09b58a0d3271ce7
514e2553acb651b8b5f816ec47609fcf61f4fbbd
diff --git a/source/Playnite/Emulation/Emulators/Lime3DS/emulator.yaml b/source/Playnite/Emulation/Emulators/Lime3DS/emulator.yaml index 676c66fb6..3f4b55b34 100644 --- a/source/Playnite/Emulation/Emulators/Lime3DS/emulator.yaml +++ b/source/Playnite/Emulation/Emulators/Lime3DS/emulator.yaml @@ -6,4 +6,4 @@ Profiles: ...
[ "source/Playnite/Emulation/Emulators/Lime3DS/emulator.yaml" ]
[]
true
JosefNemec/Playnite
3,927
issue_to_patch
Added Lime3DS emulator profile
961100a36fc482309655ca9cf415940863c5808c
4fbece0ffbcc993d52914c2720efa4351d233643
diff --git a/source/Playnite/Emulation/Emulators/Lime3DS/emulator.yaml b/source/Playnite/Emulation/Emulators/Lime3DS/emulator.yaml new file mode 100644 index 000000000..676c66fb6 --- /dev/null +++ b/source/Playnite/Emulation/Emulators/Lime3DS/emulator.yaml @@ -0,0 +1,9 @@ +Id: lime3ds +Name: Lime3DS +Website: 'https://...
[ "source/Playnite/Emulation/Emulators/Lime3DS/emulator.yaml", "source/Playnite/Emulation/Platforms.yaml" ]
[]
true
JosefNemec/Playnite
3,909
issue_to_patch
Added shadPS4 emulator support (by vaughngx4) #3897
- Added shadPS4 emulator definition - Added modified version of RPCS3 import script to support PS4 games
05edfc21d7f1e5c73f9a90a27b522b84ab379f2e
3649579e4fa0708aa0f9f00ad88bff30df53c8b9
diff --git a/source/Playnite/Emulation/Emulators/shadPS4/emulator.yaml b/source/Playnite/Emulation/Emulators/shadPS4/emulator.yaml new file mode 100644 index 000000000..5b5088721 --- /dev/null +++ b/source/Playnite/Emulation/Emulators/shadPS4/emulator.yaml @@ -0,0 +1,10 @@ +Id: shadps4 +Name: shadPS4 +Website: 'https:/...
[ "source/Playnite/Emulation/Emulators/shadPS4/emulator.yaml", "source/Playnite/Emulation/Emulators/shadPS4/importGames.ps1", "source/Playnite/Emulation/Platforms.yaml" ]
[]
true
JosefNemec/Playnite
3,915
issue_to_patch
Retroarch updates
**Code contributions (pull requests) are currently not being accepted while majority of code base is being rewritten for Playnite 11.** **Please wait with any pull requests after P11 is at least in beta state.** Welp. I didn't know code contributions were halted... Leaving it here if by chance you make an update ...
fdb2a8652a34fc2ff08ec5a416f2cb50e85907e7
aa3b4f1ced89c0aaf8cf0294b4f51ae7a32f3d8a
diff --git a/build/generateRetroArchProfile.ps1 b/build/generateRetroArchProfile.ps1 index 97456b7e7..a4e2001c3 100644 --- a/build/generateRetroArchProfile.ps1 +++ b/build/generateRetroArchProfile.ps1 @@ -68,24 +68,45 @@ $ignoreList = @( "00_example_libretro.info", "2048_libretro.info", "3dengine_libretr...
[ "build/generateRetroArchProfile.ps1", "source/Playnite/Emulation/Emulators/RetroArch/emulator.yaml" ]
[]
true
JosefNemec/Playnite
3,916
issue_to_patch
Prevent HDR from being activated when closing a game that does not have EnableSystemHdr enabled
This should mitigate https://github.com/JosefNemec/Playnite/issues/3861 but it _does not_ resolve the underlying issue. The intention of the HDR feature is to activate HDR upon starting a game and then to reset HDR back to the original state that Windows was set to prior to the game being launched. This no longer wo...
fdb2a8652a34fc2ff08ec5a416f2cb50e85907e7
e60b09d1a325037dc7496bf8f7f0060ee2f7fed9
diff --git a/source/Playnite/GamesEditor.cs b/source/Playnite/GamesEditor.cs index 4a6c55626..14097fb18 100644 --- a/source/Playnite/GamesEditor.cs +++ b/source/Playnite/GamesEditor.cs @@ -341,7 +341,7 @@ void cancelStartup(string message) { "SelectedRomFile", startingArgs.SelectedRomFile } ...
[ "source/Playnite/GamesEditor.cs" ]
[]
true
JosefNemec/Playnite
2,920
issue_to_patch
Ignore config, redistributables and game engine executables during executables scan #2919
I have verified that: - [x] These changes work, by building the application and testing them. - [x] Pull request is targeting `devel` branch. - [x] I added myself into [contributors file](https://github.com/JosefNemec/Playnite/blob/devel/source/Playnite.DesktopApp/Resources/contributors.txt) if I want to receive con...
8db6599e16070e165bcb8bb88f92de1080a18acd
f7753378c3dbe3cfdf37a432c241b9f7ec4145a0
diff --git a/source/Playnite/Common/Programs.cs b/source/Playnite/Common/Programs.cs index c95132060..684b7612b 100644 --- a/source/Playnite/Common/Programs.cs +++ b/source/Playnite/Common/Programs.cs @@ -49,18 +49,29 @@ public override string ToString() public partial class Programs { - private s...
[ "source/Playnite/Common/Programs.cs", "source/Playnite/Common/Programs2.cs", "source/Tests/Playnite.Tests/ProgramsTests.cs" ]
[ { "comment": "I don't see a good reason to have two separate lists. You can have both set up to be regex matches.", "path": "source/Playnite/Common/Programs.cs", "hunk": "@@ -56,13 +56,42 @@ public partial class Programs\n @\"unins\\d+\"\r\n };\r\n \r\n+ private static readonl...
diff --git a/source/Tests/Playnite.Tests/ProgramsTests.cs b/source/Tests/Playnite.Tests/ProgramsTests.cs index a303337cb..79a5d6688 100644 --- a/source/Tests/Playnite.Tests/ProgramsTests.cs +++ b/source/Tests/Playnite.Tests/ProgramsTests.cs @@ -50,12 +50,30 @@ public void GetUWPAppsTest() } [Test]...
true
JosefNemec/Playnite
2,920
comment_to_fix
Ignore config, redistributables and game engine executables during executables scan #2919
I don't see a good reason to have two separate lists. You can have both set up to be regex matches.
8db6599e16070e165bcb8bb88f92de1080a18acd
f7753378c3dbe3cfdf37a432c241b9f7ec4145a0
diff --git a/source/Playnite/Common/Programs.cs b/source/Playnite/Common/Programs.cs index c95132060..684b7612b 100644 --- a/source/Playnite/Common/Programs.cs +++ b/source/Playnite/Common/Programs.cs @@ -49,18 +49,29 @@ public override string ToString() public partial class Programs { - private s...
[ "source/Playnite/Common/Programs.cs" ]
[ { "comment": "I don't see a good reason to have two separate lists. You can have both set up to be regex matches.", "path": "source/Playnite/Common/Programs.cs", "hunk": "@@ -56,13 +56,42 @@ public partial class Programs\n @\"unins\\d+\"\r\n };\r\n \r\n+ private static readonl...
true
JosefNemec/Playnite
3,571
issue_to_patch
Improve keyboard launcher search results by ordering with weight ranking system ### Feature description Currently the keyboard launcher results are ordered by name. Ideally it should use a weigth ranking system to provide the more relevant results on top. Here is an example of why this is currently not ideal, with th...
Keyboard launcher results improvements
**Code contributions (pull requests) are currently not being accepted while majority of code base is being rewritten for Playnite 11.** **Please wait with any pull requests after P11 is at least in beta state.** Sorry I didn't know that PRs are closed. Opening just in case it could be considered but if there's an...
85d15baf6ffea9d1aa9d5d545d2ee2212650ac59
cdbbc92d070f40b201e683b9c6b72b30f9f22e3b
diff --git a/source/Playnite/Common/Extensions/StringExtensions.cs b/source/Playnite/Common/Extensions/StringExtensions.cs index 0543bde2a..b8aee1dcb 100644 --- a/source/Playnite/Common/Extensions/StringExtensions.cs +++ b/source/Playnite/Common/Extensions/StringExtensions.cs @@ -11,9 +11,25 @@ namespace System {...
[ "source/Playnite/Common/Extensions/StringExtensions.cs", "source/Playnite/ViewModels/SearchViewModel.cs", "source/Tests/Playnite.Tests/Database/GameDatabaseFileTests.cs", "source/Tests/Playnite.Tests/Database/GameDatabaseTests.cs", "source/Tests/Playnite.Tests/Extensions/StringExtensionsTests.cs", "source...
[]
diff --git a/source/Tests/Playnite.Tests/Database/GameDatabaseFileTests.cs b/source/Tests/Playnite.Tests/Database/GameDatabaseFileTests.cs index 084036c0a..14d621465 100644 --- a/source/Tests/Playnite.Tests/Database/GameDatabaseFileTests.cs +++ b/source/Tests/Playnite.Tests/Database/GameDatabaseFileTests.cs @@ -11,6 +1...
true
JosefNemec/Playnite
3,564
issue_to_patch
Update importGames.ps1 to support portable install and relative path
Two changes: 1) Search for scummvm.ini in the scan directory first, then search appdata if not found. 2) Updated the $rompath construction to support relative paths in the scummvm.ini file. $anyFunc also had to be updated to properly identify games already imported using relative paths. **Code contributions (p...
b1e1ade3d999d1a456d5ca103a3da915e3f71d16
8513923951ea5e525dee9a2a0ae81930856270e4
diff --git a/source/Playnite/Emulation/Emulators/ScummVM/importGames.ps1 b/source/Playnite/Emulation/Emulators/ScummVM/importGames.ps1 index a8dd05b38..780e9e3f3 100644 --- a/source/Playnite/Emulation/Emulators/ScummVM/importGames.ps1 +++ b/source/Playnite/Emulation/Emulators/ScummVM/importGames.ps1 @@ -34,10 +34,11 @@...
[ "source/Playnite/Emulation/Emulators/ScummVM/importGames.ps1" ]
[]
true
JosefNemec/Playnite
3,378
issue_to_patch
Update Bizhawk and MelonDS
I have verified that: - [✓] These changes work, by building the application and testing them. - [✓] Pull request is targeting `devel` branch. - [✓] I added myself into [contributors file](https://github.com/JosefNemec/Playnite/blob/devel/source/Playnite.DesktopApp/Resources/contributors.txt) if I want to receive con...
297f5a770c7d786cca8f38174b7100a8c319279e
33ff90d807aa17bf4688f3b88365bbfe30e221a8
diff --git a/source/Playnite.DesktopApp/Resources/contributors.txt b/source/Playnite.DesktopApp/Resources/contributors.txt index 03a1b8842..1961d406d 100644 --- a/source/Playnite.DesktopApp/Resources/contributors.txt +++ b/source/Playnite.DesktopApp/Resources/contributors.txt @@ -49,4 +49,5 @@ WLTD LemmusLemmus Riol...
[ "source/Playnite.DesktopApp/Resources/contributors.txt", "source/Playnite/Emulation/Emulators/BizHawk/emulator.yaml", "source/Playnite/Emulation/Emulators/melonDS/emulator.yaml", "source/Playnite/Emulation/Platforms.yaml" ]
[]
true
JosefNemec/Playnite
3,372
issue_to_patch
Sortablenameconverter refactor
Also added benchmark
d1bc73d5a4aceeec5b8e950aa8fe5ef2e9f7bd69
f58fd11f828d0bf910c917174b54731c64894300
diff --git a/source7/Playnite/SortableNameConverter.cs b/source7/Playnite/SortableNameConverter.cs index f7f5de275..8f8e6a051 100644 --- a/source7/Playnite/SortableNameConverter.cs +++ b/source7/Playnite/SortableNameConverter.cs @@ -4,20 +4,22 @@ namespace Playnite; public class SortableNameConverter { - priv...
[ "source7/Playnite/SortableNameConverter.cs" ]
[]
true
JosefNemec/Playnite
3,354
issue_to_patch
Fixed future date display
Fixes #3353 I have verified that: - [x] These changes work, by building the application and testing them. - [x] Pull request is targeting `devel` branch. - [x] I added myself into [contributors file](https://github.com/JosefNemec/Playnite/blob/devel/source/Playnite.DesktopApp/Resources/contributors.txt) if I want...
0f8c104b88be8ed9aca334662628c19fbf040ec0
dc3b59883910e19037ea98b62671b5a8c4164275
diff --git a/source/Playnite/DateTimes.cs b/source/Playnite/DateTimes.cs index 21a50ba0b..337b42331 100644 --- a/source/Playnite/DateTimes.cs +++ b/source/Playnite/DateTimes.cs @@ -54,19 +54,20 @@ public static string ToDisplayString(this DateTime date, DateFormattingOptions o if (options.PastWeekRelati...
[ "source/Playnite/DateTimes.cs", "source/Tests/Playnite.Tests/Extensions/DateTimesTests.cs", "source/Tests/Playnite.Tests/Playnite.Tests.csproj" ]
[]
diff --git a/source/Tests/Playnite.Tests/Extensions/DateTimesTests.cs b/source/Tests/Playnite.Tests/Extensions/DateTimesTests.cs new file mode 100644 index 000000000..be9ea4df7 --- /dev/null +++ b/source/Tests/Playnite.Tests/Extensions/DateTimesTests.cs @@ -0,0 +1,42 @@ +using NUnit.Framework; +using Playnite.SDK.Mode...
true
JosefNemec/Playnite
3,318
issue_to_patch
Show game name in the confirmation dialog before removing game
I have verified that: - [x] These changes work, by building the application and testing them. - [x] Pull request is targeting `devel` branch. - [x] I added myself into [contributors file](https://github.com/JosefNemec/Playnite/blob/devel/source/Playnite.DesktopApp/Resources/contributors.txt) if I want to receive con...
7037e9869b2608ece02daae1efb4fb5eed20af48
84b0cbec5b954adac9d0d2bbde60481ab77bfbd8
diff --git a/source/Playnite/GamesEditor.cs b/source/Playnite/GamesEditor.cs index c4b1d7b1e..d449a1fd9 100644 --- a/source/Playnite/GamesEditor.cs +++ b/source/Playnite/GamesEditor.cs @@ -27,6 +27,7 @@ using Playnite.Scripting.PowerShell; using Playnite.Windows; using System.Windows.Input; +using System.Security...
[ "source/Playnite/GamesEditor.cs", "source/Playnite/Localization/LocSource.xaml" ]
[ { "comment": "FYI this is something I noticed where if you were to close the game via something other than the action buttons on the dialog (e.g alt-tab and close the dialog), then the logic would proceed to remove the game even though this should more naturally cancel the operation (i.e not remove the game).",...
true
JosefNemec/Playnite
3,290
issue_to_patch
Activate HDR When Game Launches
I have verified that: - [x] These changes work, by building the application and testing them. - [x] Pull request is targeting `devel` branch. - [x] I added myself into [contributors file](https://github.com/JosefNemec/Playnite/blob/devel/source/Playnite.DesktopApp/Resources/contributors.txt) if I want to receive con...
7037e9869b2608ece02daae1efb4fb5eed20af48
c337b0d8ce0fd5dbfc9223aa03cfee8d14732085
diff --git a/source/Playnite.DesktopApp/Resources/contributors.txt b/source/Playnite.DesktopApp/Resources/contributors.txt index f935bfeb8..03a1b8842 100644 --- a/source/Playnite.DesktopApp/Resources/contributors.txt +++ b/source/Playnite.DesktopApp/Resources/contributors.txt @@ -48,4 +48,5 @@ UrbanCMC WLTD LemmusLe...
[ "source/Playnite.DesktopApp/Resources/contributors.txt", "source/Playnite.DesktopApp/Themes/Desktop/Default/Media.xaml", "source/Playnite.DesktopApp/ViewModels/DesktopAppViewModel_Commands.cs", "source/Playnite.DesktopApp/ViewModels/GameEditViewModel.cs", "source/Playnite.DesktopApp/ViewModels/GameEditViewM...
[ { "comment": "I don't think this is needed. Especially since people sometimes transfer libraries between PCs and they wouldn't be able to toggle this option on PCs that don't support and then use it on others that do. The checkbox should be always enabled.", "path": "source/Playnite.DesktopApp/ViewModels/Ga...
true
JosefNemec/Playnite
3,340
issue_to_patch
Fix filter presets name changes in library manager not saving upon restart
I have verified that: - [x] These changes work, by building the application and testing them. - [x] Pull request is targeting `devel` branch. - [x] I added myself into [contributors file](https://github.com/JosefNemec/Playnite/blob/devel/source/Playnite.DesktopApp/Resources/contributors.txt) if I want to receive con...
946b542c85f42601c2b0cdbc2d364df5e3d1552b
b4feeb9078437603e1b423db508559dadddfbedb
diff --git a/source/Playnite.DesktopApp/ViewModels/DatabaseFieldsManagerViewModel.cs b/source/Playnite.DesktopApp/ViewModels/DatabaseFieldsManagerViewModel.cs index 41c1ca464..2be66d998 100644 --- a/source/Playnite.DesktopApp/ViewModels/DatabaseFieldsManagerViewModel.cs +++ b/source/Playnite.DesktopApp/ViewModels/Datab...
[ "source/Playnite.DesktopApp/ViewModels/DatabaseFieldsManagerViewModel.cs" ]
[]
true
JosefNemec/Playnite
3,341
issue_to_patch
Add m3u format to Nintendo Gamecube profile of Dolphin emulator
I have verified that: - [x] These changes work, by building the application and testing them. - [x] Pull request is targeting `devel` branch. - [x] I added myself into [contributors file](https://github.com/JosefNemec/Playnite/blob/devel/source/Playnite.DesktopApp/Resources/contributors.txt) if I want to receive con...
946b542c85f42601c2b0cdbc2d364df5e3d1552b
c4d03bb2d81adfa738e16367a76af0eae36b3102
diff --git a/source/Playnite/Emulation/Emulators/Dolphin/emulator.yaml b/source/Playnite/Emulation/Emulators/Dolphin/emulator.yaml index c54f642f6..fba900347 100644 --- a/source/Playnite/Emulation/Emulators/Dolphin/emulator.yaml +++ b/source/Playnite/Emulation/Emulators/Dolphin/emulator.yaml @@ -5,7 +5,7 @@ Profiles: ...
[ "source/Playnite/Emulation/Emulators/Dolphin/emulator.yaml" ]
[]
true
JosefNemec/Playnite
3,317
issue_to_patch
Support to indicate number of days played in game time played format
I have verified that: - [x] These changes work, by building the application and testing them. - [x] Pull request is targeting `devel` branch. - [x] I added myself into [contributors file](https://github.com/JosefNemec/Playnite/blob/devel/source/Playnite.DesktopApp/Resources/contributors.txt) if I want to receive con...
851979f718ab04c949b9e4228afa24002c2fe306
77e2a186d72af1c6c22bdfceb56337bb215e23bf
diff --git a/source/Playnite.DesktopApp/Controls/GamesGridView.xaml b/source/Playnite.DesktopApp/Controls/GamesGridView.xaml index 66d36d758..370c0c65f 100644 --- a/source/Playnite.DesktopApp/Controls/GamesGridView.xaml +++ b/source/Playnite.DesktopApp/Controls/GamesGridView.xaml @@ -243,7 +243,7 @@ </DataTemp...
[ "source/Playnite.DesktopApp/Controls/GamesGridView.xaml", "source/Playnite.DesktopApp/Controls/LibraryStatistics.xaml", "source/Playnite.DesktopApp/Controls/SettingsSections/AppearanceAdvanced.xaml", "source/Playnite.DesktopApp/Controls/Views/GameOverview.cs", "source/Playnite.DesktopApp/Windows/GameEditWin...
[ { "comment": "Please add unit test for this.", "path": "source/Playnite/Converters/PlayTimeToStringConverter.cs", "hunk": "@@ -61,6 +63,15 @@ public object Convert(object value, Type targetType, object parameter, System.Gl\n }\r\n \r\n var hours = minutes / 60;\r\n+ if...
diff --git a/source/Tests/Playnite.Tests/Converters/PlayTimeToStringConverterTests.cs b/source/Tests/Playnite.Tests/Converters/PlayTimeToStringConverterTests.cs new file mode 100644 index 000000000..609657edb --- /dev/null +++ b/source/Tests/Playnite.Tests/Converters/PlayTimeToStringConverterTests.cs @@ -0,0 +1,47 @@ +...
true
JosefNemec/Playnite
3,317
comment_to_fix
Support to indicate number of days played in game time played format
Please add unit test for this.
851979f718ab04c949b9e4228afa24002c2fe306
77e2a186d72af1c6c22bdfceb56337bb215e23bf
diff --git a/source/Playnite/Converters/PlayTimeToStringConverter.cs b/source/Playnite/Converters/PlayTimeToStringConverter.cs index fcbe84732..53740708a 100644 --- a/source/Playnite/Converters/PlayTimeToStringConverter.cs +++ b/source/Playnite/Converters/PlayTimeToStringConverter.cs @@ -19,6 +19,7 @@ public class Play...
[ "source/Playnite/Converters/PlayTimeToStringConverter.cs" ]
[ { "comment": "Please add unit test for this.", "path": "source/Playnite/Converters/PlayTimeToStringConverter.cs", "hunk": "@@ -61,6 +63,15 @@ public object Convert(object value, Type targetType, object parameter, System.Gl\n }\r\n \r\n var hours = minutes / 60;\r\n+ if...
true
JosefNemec/Playnite
3,317
comment_to_fix
Support to indicate number of days played in game time played format
This tests doesn't actually test anything because localization resources are not working in test projects. You are always comparing placeholder string with placeholder string. I have fixed that in devel so localization resource will work now. Even if those string have worked however, you would be comparing the origi...
851979f718ab04c949b9e4228afa24002c2fe306
77e2a186d72af1c6c22bdfceb56337bb215e23bf
diff --git a/source/Tests/Playnite.Tests/Converters/PlayTimeToStringConverterTests.cs b/source/Tests/Playnite.Tests/Converters/PlayTimeToStringConverterTests.cs new file mode 100644 index 000000000..609657edb --- /dev/null +++ b/source/Tests/Playnite.Tests/Converters/PlayTimeToStringConverterTests.cs @@ -0,0 +1,47 @@ +...
[ "source/Tests/Playnite.Tests/Converters/PlayTimeToStringConverterTests.cs" ]
[ { "comment": "This tests doesn't actually test anything because localization resources are not working in test projects. You are always comparing placeholder string with placeholder string. I have fixed that in devel so localization resource will work now.\r\n\r\nEven if those string have worked however, you wo...
true
JosefNemec/Playnite
3,327
issue_to_patch
Support to display total install size in statistics view
I have verified that: - [x] These changes work, by building the application and testing them. - [x] Pull request is targeting `devel` branch. - [x] I added myself into [contributors file](https://github.com/JosefNemec/Playnite/blob/devel/source/Playnite.DesktopApp/Resources/contributors.txt) if I want to receive con...
7037e9869b2608ece02daae1efb4fb5eed20af48
ea0df032562d4678b175973b4e8bfaee7a6cd58a
diff --git a/source/Playnite.DesktopApp/Controls/LibraryStatistics.xaml b/source/Playnite.DesktopApp/Controls/LibraryStatistics.xaml index 5280f9902..91b81772b 100644 --- a/source/Playnite.DesktopApp/Controls/LibraryStatistics.xaml +++ b/source/Playnite.DesktopApp/Controls/LibraryStatistics.xaml @@ -17,7 +17,7 @@ ...
[ "source/Playnite.DesktopApp/Controls/LibraryStatistics.xaml", "source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs", "source/Playnite/Localization/LocSource.xaml" ]
[ { "comment": "This doesn't need to be nullable, it will always be at least 0 because totalInstallSize has default value of 0.", "path": "source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs", "hunk": "@@ -169,6 +169,7 @@ public class GameStats\n public BaseStatInfo Favorite { get; se...
true
JosefNemec/Playnite
3,327
comment_to_fix
Support to display total install size in statistics view
This doesn't need to be nullable, it will always be at least 0 because totalInstallSize has default value of 0.
7037e9869b2608ece02daae1efb4fb5eed20af48
ea0df032562d4678b175973b4e8bfaee7a6cd58a
diff --git a/source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs b/source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs index 3370330a2..35d809ee0 100644 --- a/source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs +++ b/source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs @@ -169,6 +169,...
[ "source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs" ]
[ { "comment": "This doesn't need to be nullable, it will always be at least 0 because totalInstallSize has default value of 0.", "path": "source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs", "hunk": "@@ -169,6 +169,7 @@ public class GameStats\n public BaseStatInfo Favorite { get; se...
true
JosefNemec/Playnite
3,327
comment_to_fix
Support to display total install size in statistics view
You forgot about this one, doesn't need to be nullable either.
7037e9869b2608ece02daae1efb4fb5eed20af48
ea0df032562d4678b175973b4e8bfaee7a6cd58a
diff --git a/source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs b/source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs index 3370330a2..35d809ee0 100644 --- a/source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs +++ b/source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs @@ -169,6 +169,...
[ "source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs" ]
[ { "comment": "You forgot about this one, doesn't need to be nullable either.", "path": "source/Playnite.DesktopApp/ViewModels/StatisticsViewModel.cs", "hunk": "@@ -321,6 +322,7 @@ private GameStats FillData(bool filtered)\n ulong hidden = 0;\r\n ulong favorite = 0;\r\n ...
true
JosefNemec/Playnite
3,220
issue_to_patch
Add fullscreen mode to jump list
issue #2305 ![Screenshot 2022-12-16 171521](https://user-images.githubusercontent.com/43097559/208145378-a8bbe9a7-e273-49a3-8da9-3f6dd123d80d.png) I have verified that: - [x] These changes work, by building the application and testing them. - [x] Pull request is targeting `devel` branch. - [x] I added myself i...
84a7675d3e34e050ac908a7dbfdf594b5c8459b9
7a293288b44f5dbb7135560864b37b03bb515b6a
diff --git a/source/Playnite.DesktopApp/Resources/contributors.txt b/source/Playnite.DesktopApp/Resources/contributors.txt index 16233fa89..f935bfeb8 100644 --- a/source/Playnite.DesktopApp/Resources/contributors.txt +++ b/source/Playnite.DesktopApp/Resources/contributors.txt @@ -47,4 +47,5 @@ Jeshibu UrbanCMC WLTD ...
[ "source/Playnite.DesktopApp/Resources/contributors.txt", "source/Playnite/GamesEditor.cs" ]
[]
true