repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
JustArchiNET/ArchiSteamFarm
3,497
issue_to_patch
chore(deps): update github artifact actions (major)
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/download-artifact](https://redirect.github.com/actions/download-artifact) | action | major | `v5.0.0` -> `v6.0.0` | | [actions/upload-artifact](https://redirect.github.com/actions/upload-artifact) | action | major...
e23e507a68de069b68239a9aed334edea5f639cf
cdc6de3c0a0cf7b8e9d0759b8b311f30b69012af
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 8bdfbece3483e..830c97f562797 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -43,7 +43,7 @@ jobs: run: npm run-script deploy --no-progress --prefix ASF-ui - name: Upload ASF-ui - uses: a...
[ ".github/workflows/publish.yml" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,494
issue_to_patch
chore(deps): update actions/setup-node action to v6
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://redirect.github.com/actions/setup-node) | action | major | `v5.0.0` -> `v6.0.0` | --- ### Release Notes <details> <summary>actions/setup-node (actions/setup-node)</summary> ### [`v6.0.0`](h...
289f573b006907958c488117960f224e29710a49
67a852ec401540704d0285372bf86df2919daaa3
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 82bb064b7bdcf..8bdfbece3483e 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -25,7 +25,7 @@ jobs: submodules: recursive - name: Setup Node.js with npm - uses: actions/setup-node@a0853c...
[ ".github/workflows/publish.yml" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,493
issue_to_patch
chore(deps): update dependency mstest to v4
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [MSTest](https://redirect.github.com/microsoft/testfx) | `3.11.0` -> `4.0.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/MSTest/4.0.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![conf...
31b735c3d37e6314c6dede24ca7e5085973be0f1
49ff21d57fb325e639dc77512b0c8f150c608de8
diff --git a/ArchiSteamFarm.Tests/Bot.cs b/ArchiSteamFarm.Tests/Bot.cs index 42e0c37ecf72d..8eff332e47207 100644 --- a/ArchiSteamFarm.Tests/Bot.cs +++ b/ArchiSteamFarm.Tests/Bot.cs @@ -526,7 +526,7 @@ private static void AssertResultMatchesExpectation(Dictionary<(uint RealAppID, u ArgumentNullException.ThrowIfNull(i...
[ "ArchiSteamFarm.Tests/Bot.cs", "Directory.Packages.props" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,490
issue_to_patch
chore(deps): update peter-evans/dockerhub-description action to v5
> [!NOTE] > Mend has cancelled [the proposed renaming](https://redirect.github.com/renovatebot/renovate/discussions/37842) of the Renovate GitHub app being renamed to `mend[bot]`. > > This notice will be removed on 2025-10-07. <hr> This PR contains the following updates: | Package | Type | Update | Change | |---|--...
c656b61ce2a7ba6ac137ecab2008f0dc3927a689
e0584c7b3a2e9b138a993febb09862cd5bc40a04
diff --git a/.github/workflows/docker-publish-main.yml b/.github/workflows/docker-publish-main.yml index 618bbafb6f046..c8c40a476321d 100644 --- a/.github/workflows/docker-publish-main.yml +++ b/.github/workflows/docker-publish-main.yml @@ -69,7 +69,7 @@ jobs: push: true - name: Update DockerHub reposit...
[ ".github/workflows/docker-publish-main.yml" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,477
issue_to_patch
chore(deps): update actions/setup-dotnet action to v5
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-dotnet](https://redirect.github.com/actions/setup-dotnet) | action | major | `v4.3.1` -> `v5.0.0` | --- ### Release Notes <details> <summary>actions/setup-dotnet (actions/setup-dotnet)</summary> ### [`v5...
2d79ae9e7aaedd139d599d2f5223371e25f2f881
342543e9e220203dabb17afa8b428fc98a80306b
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0080582533075..f3b3b8c745070 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -27,7 +27,7 @@ jobs: submodules: recursive - name: Setup .NET Core - uses: actions/setup-dotnet@67a3573c9a986a3f9c594539f4ab511...
[ ".github/workflows/ci.yml", ".github/workflows/publish.yml" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,478
issue_to_patch
chore(deps): update actions/setup-node action to v5
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/setup-node](https://redirect.github.com/actions/setup-node) | action | major | `v4.4.0` -> `v5.0.0` | --- ### Release Notes <details> <summary>actions/setup-node (actions/setup-node)</summary> ### [`v5.0.0`](h...
2d79ae9e7aaedd139d599d2f5223371e25f2f881
bae2bb97c2ac5156c5ce4c58fc185df9c873035a
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index e3d9891e302e6..69e3b7bc61b56 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -25,7 +25,7 @@ jobs: submodules: recursive - name: Setup Node.js with npm - uses: actions/setup-node@49933e...
[ ".github/workflows/publish.yml" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,471
issue_to_patch
Cleanup obsolete parts
On hold until ASF V6.2.2.x+.
fe80d3029b6ee371a5acd2bfd6ef3042aea4a3f9
ef669ec6182c19a1a23090c1ce737317b63d20b1
diff --git a/ArchiSteamFarm/Helpers/Json/JsonUtilities.cs b/ArchiSteamFarm/Helpers/Json/JsonUtilities.cs index de77e44164f91..3fb95b57c459b 100644 --- a/ArchiSteamFarm/Helpers/Json/JsonUtilities.cs +++ b/ArchiSteamFarm/Helpers/Json/JsonUtilities.cs @@ -44,16 +44,6 @@ public static class JsonUtilities { [PublicAPI] ...
[ "ArchiSteamFarm/Helpers/Json/JsonUtilities.cs", "ArchiSteamFarm/Steam/Storage/BotConfig.cs" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,476
issue_to_patch
chore(deps): update actions/attest-build-provenance action to v3
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/attest-build-provenance](https://redirect.github.com/actions/attest-build-provenance) | action | major | `v2.4.0` -> `v3.0.0` | --- ### Release Notes <details> <summary>actions/attest-build-provenance (actions/...
d3f45fc33d847a45160bab500e5d5ea31f5e3936
77e0dd39c8908b4aee9041bc7d7418b198f8d9c5
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index 85d9f9dacc1ba..e3d9891e302e6 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -361,7 +361,7 @@ jobs: - name: Generate artifact attestation for ASF-${{ matrix.variant }}.zip if: ${{ github.even...
[ ".github/workflows/publish.yml" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,475
issue_to_patch
chore(deps): update dependency mstest to 3.10.3
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [MSTest](https://redirect.github.com/microsoft/testfx) | `3.10.2` -> `3.10.3` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/MSTest/3.10.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![co...
4b7f570ba5dc57133118b53fd7f3544a5267c3b7
cc404353b70c4994717cc7fb0a7ece845581fa7b
diff --git a/Directory.Packages.props b/Directory.Packages.props index 44820ff0fab85..8e001e27acdda 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -8,7 +8,7 @@ <PackageVersion Include="Microsoft.AspNetCore.OpenApi" Version="9.0.8" /> <PackageVersion Include="Microsoft.CodeAnalysis.ResxSou...
[ "Directory.Packages.props" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,472
issue_to_patch
chore(deps): update crowdin/github-action action to v2.10.0
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [crowdin/github-action](https://redirect.github.com/crowdin/github-action) | action | minor | `v2.9.1` -> `v2.10.0` | --- ### Release Notes <details> <summary>crowdin/github-action (crowdin/github-action)</summary> ###...
90dba00c07aa965630dc533b4b02376446c876ee
712dbfb4df8122d98d163c87c751f15a3a0060b6
diff --git a/.github/workflows/crowdin-ci.yml b/.github/workflows/crowdin-ci.yml index 59b1d14f223cf..8420eb0ef3768 100644 --- a/.github/workflows/crowdin-ci.yml +++ b/.github/workflows/crowdin-ci.yml @@ -20,7 +20,7 @@ jobs: submodules: recursive - name: Upload latest strings for translation on Crowdin ...
[ ".github/workflows/crowdin-ci.yml", ".github/workflows/translations.yml" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,465
issue_to_patch
chore(deps): update actions/checkout action to v5
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://redirect.github.com/actions/checkout) | action | major | `v4.3.0` -> `v5.0.0` | --- ### Release Notes <details> <summary>actions/checkout (actions/checkout)</summary> ### [`v5.0.0`](https://r...
7d5aaed8fb1e46a69b4142aad41007562f287846
7cc0b497a13d2470f686764f2073e7e07616adf6
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 04a3185db2298..0080582533075 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,7 +21,7 @@ jobs: steps: - name: Checkout code - uses: actions/checkout@08eba0b27e820071cde6df949e0beb9ba4906955 # v4.3.0 + ...
[ ".github/workflows/ci.yml", ".github/workflows/crowdin-ci.yml", ".github/workflows/docker-ci.yml", ".github/workflows/docker-publish-latest.yml", ".github/workflows/docker-publish-main.yml", ".github/workflows/docker-publish-released.yml", ".github/workflows/publish.yml", ".github/workflows/translatio...
[]
true
JustArchiNET/ArchiSteamFarm
3,462
issue_to_patch
chore(deps): update actions/download-artifact action to v5
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/download-artifact](https://redirect.github.com/actions/download-artifact) | action | major | `v4.3.0` -> `v5.0.0` | --- ### Release Notes <details> <summary>actions/download-artifact (actions/download-artifact)...
ce1cf6f4b130851b96e17dcd106c3ea11eca1b4d
4bbaa3f3b3e5b59bb6488fd50c10ebe84fe2733d
diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index d46f720bc1264..6948936b00779 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -94,7 +94,7 @@ jobs: run: dotnet --info - name: Download previously built ASF-ui - uses: actions/download-art...
[ ".github/workflows/publish.yml" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,458
issue_to_patch
chore(deps): update dependency mstest to 3.10.0
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [MSTest](https://redirect.github.com/microsoft/testfx) | `3.9.3` -> `3.10.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/MSTest/3.10.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![con...
1de5bfd809452c8be060366c951acbe0de8ae990
7ca95272d8e5f44bb9320b3a4e9d55d8a5d7013a
diff --git a/ArchiSteamFarm.Tests/ArchiCryptoHelper.cs b/ArchiSteamFarm.Tests/ArchiCryptoHelper.cs index 493e40502249b..ce77a368d4e88 100644 --- a/ArchiSteamFarm.Tests/ArchiCryptoHelper.cs +++ b/ArchiSteamFarm.Tests/ArchiCryptoHelper.cs @@ -36,7 +36,7 @@ internal sealed class ArchiCryptoHelper { [DataRow(ECryptoMet...
[ "ArchiSteamFarm.Tests/ArchiCryptoHelper.cs", "ArchiSteamFarm.Tests/MobileAuthenticator.cs", "ArchiSteamFarm.Tests/SteamChatMessage.cs", "Directory.Packages.props" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,456
issue_to_patch
public api
## Checklist <!-- Put an `x` in all the boxes that apply --> - [ ] I read and understood the **[Contributing Guidelines](https://github.com/JustArchiNET/ArchiSteamFarm/blob/main/.github/CONTRIBUTING.md)**. - [ ] This is not a **[duplicate](https://github.com/JustArchiNET/ArchiSteamFarm/pulls)** of an existing me...
bcd9ae047e8d9763e3e1e38f3fa87c74e949b194
4821c4451bcd073c92ff9da3a47e0e7aded1557f
diff --git a/ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs b/ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs index 5c1fea88eecf4..2b2d60b6aa571 100644 --- a/ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs +++ b/ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs @@ -99,6 +99,55 @@ public void Dispose() { ...
[ "ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,454
issue_to_patch
chore(deps): update dependency microsoft.codeanalysis.resxsourcegenerator to v5
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [Microsoft.CodeAnalysis.ResxSourceGenerator](https://redirect.github.com/dotnet/roslyn) ([source](https://redirect.github.com/dotnet/dotnet)) | `3.11.0-beta1.25173.3` -> `5.0.0-1.25277.114` | [![age](https://developer.m...
4ad450f0babb8ba627f358a19431b4194b47b996
e5023657b2d5f769e2ae91f5b62668e30dca6150
diff --git a/Directory.Packages.props b/Directory.Packages.props index a81dc2c498b01..e7e8780f33881 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -6,7 +6,7 @@ <PackageVersion Include="JetBrains.Annotations.Sources" Version="2025.2.0" /> <PackageVersion Include="Markdig.Signed" Version="0...
[ "Directory.Packages.props" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,448
issue_to_patch
chore(deps): update dependency jetbrains.annotations to v2025
This PR contains the following updates: | Package | Change | Age | Confidence | |---|---|---|---| | [JetBrains.Annotations](https://www.jetbrains.com/help/resharper/Code_Analysis__Code_Annotations.html) ([source](https://redirect.github.com/JetBrains/JetBrains.Annotations.git2)) | `2024.3.0` -> `2025.2.0` | [![age](ht...
37d7f14148601df224de2cf6ccfd75e60f497b00
03d74bd135509558005cc24f101fb4563de7f7ae
diff --git a/Directory.Packages.props b/Directory.Packages.props index 638a0c38ef565..96495699d37f3 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -3,7 +3,7 @@ <PackageVersion Include="AngleSharp" Version="1.3.0" /> <PackageVersion Include="CryptSharpStandard" Version="1.0.0" /> <Packa...
[ "Directory.Packages.props" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,442
issue_to_patch
new confirmation type
## Checklist <!-- Put an `x` in all the boxes that apply --> - [x] I read and understood the **[Contributing Guidelines](https://github.com/JustArchiNET/ArchiSteamFarm/blob/main/.github/CONTRIBUTING.md)**. - [x] This is not a **[duplicate](https://github.com/JustArchiNET/ArchiSteamFarm/pulls)** of an existing me...
76e3059b3402d1cab6a3416252453b4c293af506
b208740028201c9347dbab9d00f909cdfc6dc6a6
diff --git a/ArchiSteamFarm/Steam/Data/Confirmation.cs b/ArchiSteamFarm/Steam/Data/Confirmation.cs index 0558fb4224636..61cc6596e6fd2 100644 --- a/ArchiSteamFarm/Steam/Data/Confirmation.cs +++ b/ArchiSteamFarm/Steam/Data/Confirmation.cs @@ -72,6 +72,7 @@ public enum EConfirmationType : byte { PhoneNumberChange = 5, ...
[ "ArchiSteamFarm/Steam/Data/Confirmation.cs" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,438
issue_to_patch
chore(deps): update dependency nlog.web.aspnetcore to v6
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [NLog.Web.AspNetCore](https://redirect.github.com/NLog/NLog.Web) | `5.5.0` -> `6.0.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/NLog.Web.AspNetCore/6.0.0?slim=true)](https:...
c48c1e6acde2199381be8e8c175959fc539901ac
e2192139d811ec078d6182d80d4b0b7f83e1afd4
diff --git a/ArchiSteamFarm/NLog/Logging.cs b/ArchiSteamFarm/NLog/Logging.cs index bf606f323beed..75e75c66cea76 100644 --- a/ArchiSteamFarm/NLog/Logging.cs +++ b/ArchiSteamFarm/NLog/Logging.cs @@ -207,6 +207,7 @@ internal static void EnableTraceLogging() { internal static void InitCoreLoggers(bool uniqueInstance) {...
[ "ArchiSteamFarm/NLog/Logging.cs", "ArchiSteamFarm/NLog/Targets/HistoryTarget.cs", "ArchiSteamFarm/NLog/Targets/SteamTarget.cs", "ArchiSteamFarm/Program.cs", "ArchiSteamFarm/SharedInfo.cs", "Directory.Packages.props" ]
[ { "comment": "Should this check not be moved below the logic that explicit loads `XmlLoggingConfiguration` ?", "path": "ArchiSteamFarm/NLog/Logging.cs", "hunk": "@@ -206,6 +206,11 @@ internal static void EnableTraceLogging() {\n \t}\n \n \tinternal static void InitCoreLoggers(bool uniqueInstance) {\n+\t...
true
JustArchiNET/ArchiSteamFarm
3,438
comment_to_fix
chore(deps): update dependency nlog.web.aspnetcore to v6
Should this check not be moved below the logic that explicit loads `XmlLoggingConfiguration` ?
c48c1e6acde2199381be8e8c175959fc539901ac
e2192139d811ec078d6182d80d4b0b7f83e1afd4
diff --git a/ArchiSteamFarm/NLog/Logging.cs b/ArchiSteamFarm/NLog/Logging.cs index bf606f323beed..75e75c66cea76 100644 --- a/ArchiSteamFarm/NLog/Logging.cs +++ b/ArchiSteamFarm/NLog/Logging.cs @@ -207,6 +207,7 @@ internal static void EnableTraceLogging() { internal static void InitCoreLoggers(bool uniqueInstance) {...
[ "ArchiSteamFarm/NLog/Logging.cs" ]
[ { "comment": "Should this check not be moved below the logic that explicit loads `XmlLoggingConfiguration` ?", "path": "ArchiSteamFarm/NLog/Logging.cs", "hunk": "@@ -206,6 +206,11 @@ internal static void EnableTraceLogging() {\n \t}\n \n \tinternal static void InitCoreLoggers(bool uniqueInstance) {\n+\t...
true
JustArchiNET/ArchiSteamFarm
3,438
comment_to_fix
chore(deps): update dependency nlog.web.aspnetcore to v6
Probably worth adding a check if `new SteamID(SteamID)` is `IsIndividualAccount` in case of `ChatGroupID == 0` and `IsChatAccount` otherwise (unless it is actually possible to send messages to other account types). Also this makes `SteamID` check in `WriteAsyncTask` redundant.
c48c1e6acde2199381be8e8c175959fc539901ac
e2192139d811ec078d6182d80d4b0b7f83e1afd4
diff --git a/ArchiSteamFarm/NLog/Targets/SteamTarget.cs b/ArchiSteamFarm/NLog/Targets/SteamTarget.cs index d9125f1ab6600..086f46c11f332 100644 --- a/ArchiSteamFarm/NLog/Targets/SteamTarget.cs +++ b/ArchiSteamFarm/NLog/Targets/SteamTarget.cs @@ -30,17 +30,15 @@ using ArchiSteamFarm.Steam; using JetBrains.Annotations; ...
[ "ArchiSteamFarm/NLog/Targets/SteamTarget.cs" ]
[ { "comment": "Probably worth adding a check if `new SteamID(SteamID)` is `IsIndividualAccount` in case of `ChatGroupID == 0` and `IsChatAccount` otherwise (unless it is actually possible to send messages to other account types).\r\n\r\nAlso this makes `SteamID` check in `WriteAsyncTask` redundant.", "path":...
true
JustArchiNET/ArchiSteamFarm
3,439
issue_to_patch
chore(deps): pin dependencies
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/attest-build-provenance](https://redirect.github.com/actions/attest-build-provenance) | action | pinDigest | -> `e8998f9` | | [actions/checkout](https://redirect.github.com/actions/checkout) | action | pinDigest ...
e4addcadc8f571b7acaea1050820c2351a60a2fd
f7707541fcdf58538ca0d3e4538c74580c62f502
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index ef8a299043efb..aac2b429776b6 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -21,13 +21,13 @@ jobs: steps: - name: Checkout code - uses: actions/checkout@v4.2.2 + uses: actions/checkout@11bd71901bbe5b163...
[ ".github/workflows/ci.yml", ".github/workflows/crowdin-ci.yml", ".github/workflows/docker-ci.yml", ".github/workflows/docker-publish-latest.yml", ".github/workflows/docker-publish-main.yml", ".github/workflows/docker-publish-released.yml", ".github/workflows/lock-threads.yml", ".github/workflows/publi...
[]
true
JustArchiNET/ArchiSteamFarm
3,437
issue_to_patch
chore: blacklist summer sale 2025 appid
Source: https://steamdb.info/app/3558920/communityitems/
abc2e2be69e9d77ba3ac062955bded0bfb80ca49
7dc192d9d0da71fe64e2396e9054cca115418065
diff --git a/ArchiSteamFarm/Steam/Cards/CardsFarmer.cs b/ArchiSteamFarm/Steam/Cards/CardsFarmer.cs index 3339a004640dc..705b69e9ba5e4 100644 --- a/ArchiSteamFarm/Steam/Cards/CardsFarmer.cs +++ b/ArchiSteamFarm/Steam/Cards/CardsFarmer.cs @@ -56,7 +56,7 @@ public sealed class CardsFarmer : IAsyncDisposable, IDisposable {...
[ "ArchiSteamFarm/Steam/Cards/CardsFarmer.cs" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,435
issue_to_patch
chore(deps): update dependency steamkit2 to 3.3.0
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [SteamKit2](https://redirect.github.com/SteamRE/SteamKit) | `3.2.0` -> `3.3.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/SteamKit2/3.3.0?slim=true)](https://docs.renovatebo...
839bc06f88ed4887640bc9c808efba83765ce633
56f908706046005e86538a75fcea976a8fdd82c3
diff --git a/ArchiSteamFarm/Steam/Bot.cs b/ArchiSteamFarm/Steam/Bot.cs index 64814c99eb869..fdd7fb08bdf85 100644 --- a/ArchiSteamFarm/Steam/Bot.cs +++ b/ArchiSteamFarm/Steam/Bot.cs @@ -334,7 +334,7 @@ private Bot(string botName, BotConfig botConfig, BotDatabase botDatabase) { SteamConfiguration = SteamConfiguratio...
[ "ArchiSteamFarm/Steam/Bot.cs", "ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs", "Directory.Packages.props" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,429
issue_to_patch
chore(deps): update dependency nlog.web.aspnetcore to 5.5.0
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [NLog.Web.AspNetCore](https://redirect.github.com/NLog/NLog.Web) | `5.4.0` -> `5.5.0` | [![age](https://developer.mend.io/api/mc/badges/age/nuget/NLog.Web.AspNetCore/5.5.0?slim=true)](https:...
b20f8adb5f3f603a4618fecd9fdc3b745957feb1
16973c07cb726bf3441777bab4ee0d127480daae
diff --git a/Directory.Packages.props b/Directory.Packages.props index 48de527941ed0..db017d99d8dae 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -10,7 +10,7 @@ <PackageVersion Include="Microsoft.IdentityModel.JsonWebTokens" Version="8.11.0" /> <PackageVersion Include="MSTest" Version="3...
[ "Directory.Packages.props" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,427
issue_to_patch
Closes #3415
@xPaw review welcome
a19611c3ae7efd46850936b263f2bb248356ed62
faefb52180c659d599e702ac91cd79bb0486c5cf
diff --git a/ArchiSteamFarm.OfficialPlugins.SteamTokenDumper/SharedInfo.cs b/ArchiSteamFarm.OfficialPlugins.SteamTokenDumper/SharedInfo.cs index fa5e2503a7d32..08781f7854609 100644 --- a/ArchiSteamFarm.OfficialPlugins.SteamTokenDumper/SharedInfo.cs +++ b/ArchiSteamFarm.OfficialPlugins.SteamTokenDumper/SharedInfo.cs @@ ...
[ "ArchiSteamFarm.OfficialPlugins.SteamTokenDumper/SharedInfo.cs", "ArchiSteamFarm.OfficialPlugins.SteamTokenDumper/SteamTokenDumperPlugin.cs", "ArchiSteamFarm/Steam/Bot.cs", "ArchiSteamFarm/Steam/Data/StoreUserData.cs", "ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs", "ArchiSteamFarm/Steam/Integratio...
[]
true
JustArchiNET/ArchiSteamFarm
3,425
issue_to_patch
chore(deps): update asf-ui digest to 1205ace
This PR contains the following updates: | Package | Update | Change | |---|---|---| | ASF-ui | digest | `afc4c5a` -> `1205ace` | --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whe...
208e844c975322559de62db0d12f3092804f0f34
b240320c74af8756946065f632d970e4def1f995
diff --git a/ASF-ui b/ASF-ui index afc4c5aeb95d9..1205ace91bfb5 160000 --- a/ASF-ui +++ b/ASF-ui @@ -1,1 +1,1 @@ -Subproject commit afc4c5aeb95d91820cb4b83fb635ba3da5e02cff +Subproject commit 1205ace91bfb57d4f0c7e86c106aee014e5b099e
[ "ASF-ui" ]
[]
true
JustArchiNET/ArchiSteamFarm
3,409
issue_to_patch
get inventory with language
## Checklist <!-- Put an `x` in all the boxes that apply --> - [ √] I read and understood the **[Contributing Guidelines](https://github.com/JustArchiNET/ArchiSteamFarm/blob/main/.github/CONTRIBUTING.md)**. - [√ ] This is not a **[duplicate](https://github.com/JustArchiNET/ArchiSteamFarm/pulls)** of an existing ...
f1a49cdff0a7d4160a6f4b96545faf6ec623ad78
59a0a2bbe1a01819552b33454b03535cececf566
diff --git a/ArchiSteamFarm/IPC/Controllers/Api/BotController.cs b/ArchiSteamFarm/IPC/Controllers/Api/BotController.cs index fc77b616b4e60..0a87ad43114a9 100644 --- a/ArchiSteamFarm/IPC/Controllers/Api/BotController.cs +++ b/ArchiSteamFarm/IPC/Controllers/Api/BotController.cs @@ -283,7 +283,7 @@ public async Task<Actio...
[ "ArchiSteamFarm/IPC/Controllers/Api/BotController.cs", "ArchiSteamFarm/Steam/Integration/ArchiHandler.cs", "ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs", "ArchiSteamFarm/Steam/Interaction/Actions.cs" ]
[ { "comment": "All other query parameters are written out (see `RedeemPointsPost`, `GitHubWikiPageGet` and `PluginsGet`). I'd recommend removal of the `(Name = \"l\")`-part.", "path": "ArchiSteamFarm/IPC/Controllers/Api/BotController.cs", "hunk": "@@ -283,7 +283,7 @@ public async Task<ActionResult<Generi...
true
JustArchiNET/ArchiSteamFarm
3,409
comment_to_fix
get inventory with language
All other query parameters are written out (see `RedeemPointsPost`, `GitHubWikiPageGet` and `PluginsGet`). I'd recommend removal of the `(Name = "l")`-part.
f1a49cdff0a7d4160a6f4b96545faf6ec623ad78
59a0a2bbe1a01819552b33454b03535cececf566
diff --git a/ArchiSteamFarm/IPC/Controllers/Api/BotController.cs b/ArchiSteamFarm/IPC/Controllers/Api/BotController.cs index fc77b616b4e60..0a87ad43114a9 100644 --- a/ArchiSteamFarm/IPC/Controllers/Api/BotController.cs +++ b/ArchiSteamFarm/IPC/Controllers/Api/BotController.cs @@ -283,7 +283,7 @@ public async Task<Actio...
[ "ArchiSteamFarm/IPC/Controllers/Api/BotController.cs" ]
[ { "comment": "All other query parameters are written out (see `RedeemPointsPost`, `GitHubWikiPageGet` and `PluginsGet`). I'd recommend removal of the `(Name = \"l\")`-part.", "path": "ArchiSteamFarm/IPC/Controllers/Api/BotController.cs", "hunk": "@@ -283,7 +283,7 @@ public async Task<ActionResult<Generi...
true
JustArchiNET/ArchiSteamFarm
3,409
comment_to_fix
get inventory with language
I'd also prefer a default value of `null` (same with the other methods that take this parameter and falling back to any other value just in the very last method)
f1a49cdff0a7d4160a6f4b96545faf6ec623ad78
59a0a2bbe1a01819552b33454b03535cececf566
diff --git a/ArchiSteamFarm/IPC/Controllers/Api/BotController.cs b/ArchiSteamFarm/IPC/Controllers/Api/BotController.cs index fc77b616b4e60..0a87ad43114a9 100644 --- a/ArchiSteamFarm/IPC/Controllers/Api/BotController.cs +++ b/ArchiSteamFarm/IPC/Controllers/Api/BotController.cs @@ -283,7 +283,7 @@ public async Task<Actio...
[ "ArchiSteamFarm/IPC/Controllers/Api/BotController.cs" ]
[ { "comment": "I'd also prefer a default value of `null` (same with the other methods that take this parameter and falling back to any other value just in the very last method)", "path": "ArchiSteamFarm/IPC/Controllers/Api/BotController.cs", "hunk": "@@ -283,7 +283,7 @@ public async Task<ActionResult<Gen...
true
JustArchiNET/ArchiSteamFarm
3,409
comment_to_fix
get inventory with language
I don't think we should be setting the property at all if it's `null`, let alone duplicate the (current) default value from an external library. In my opinion this should be an `if (language != null) request.language = language;` below the object initializer.
f1a49cdff0a7d4160a6f4b96545faf6ec623ad78
59a0a2bbe1a01819552b33454b03535cececf566
diff --git a/ArchiSteamFarm/Steam/Integration/ArchiHandler.cs b/ArchiSteamFarm/Steam/Integration/ArchiHandler.cs index ba6c505585d21..22977d006f3ec 100644 --- a/ArchiSteamFarm/Steam/Integration/ArchiHandler.cs +++ b/ArchiSteamFarm/Steam/Integration/ArchiHandler.cs @@ -179,7 +179,7 @@ public async Task<bool> AddFriend(u...
[ "ArchiSteamFarm/Steam/Integration/ArchiHandler.cs" ]
[ { "comment": "I don't think we should be setting the property at all if it's `null`, let alone duplicate the (current) default value from an external library. In my opinion this should be an `if (language != null) request.language = language;` below the object initializer.", "path": "ArchiSteamFarm/Steam/In...
true
JustArchiNET/ArchiSteamFarm
3,409
comment_to_fix
get inventory with language
As before, I'd suggest a `null`-value as the default here.
f1a49cdff0a7d4160a6f4b96545faf6ec623ad78
59a0a2bbe1a01819552b33454b03535cececf566
diff --git a/ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs b/ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs index 3dff2dba4e7f1..d63a0c3f9ba5f 100644 --- a/ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs +++ b/ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs @@ -233,7 +233,7 @@ public async Task<bool>...
[ "ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs" ]
[ { "comment": "As before, I'd suggest a `null`-value as the default here.", "path": "ArchiSteamFarm/Steam/Integration/ArchiWebHandler.cs", "hunk": "@@ -233,7 +233,7 @@ public async Task<bool> CancelTradeOffer(ulong tradeID) {\n \t/// This method should be used exclusively for foreign inventories (oth...
true
JustArchiNET/ArchiSteamFarm
3,409
comment_to_fix
get inventory with language
This is a breaking change. We can make it non-breaking by moving the new argument to the end.
f1a49cdff0a7d4160a6f4b96545faf6ec623ad78
59a0a2bbe1a01819552b33454b03535cececf566
diff --git a/ArchiSteamFarm/Steam/Interaction/Actions.cs b/ArchiSteamFarm/Steam/Interaction/Actions.cs index 75aaf72c813f7..b18d3d56664a0 100644 --- a/ArchiSteamFarm/Steam/Interaction/Actions.cs +++ b/ArchiSteamFarm/Steam/Interaction/Actions.cs @@ -174,7 +174,7 @@ public ulong GetFirstSteamMasterID() { /// <remarks...
[ "ArchiSteamFarm/Steam/Interaction/Actions.cs" ]
[ { "comment": "This is a breaking change. We can make it non-breaking by moving the new argument to the end.", "path": "ArchiSteamFarm/Steam/Interaction/Actions.cs", "hunk": "@@ -174,7 +174,7 @@ public ulong GetFirstSteamMasterID() {\n \n \t/// <remarks>This action should be used if you require full inve...
true
Kong/insomnia
10,073
issue_to_patch
fix(linting): fixes linting styling / UI issues for v13
Adds a few fixes for linting discovered during beta testing. 1. First issue is the `Custom Ruleset` modal did not inherit the active theme; so the styles were broken whenever a light theme was chosen. Before: <img width="1112" height="988" alt="Screenshot 2026-06-12 at 8 07 29 AM" src="https://github.com/user-...
007f10655031c62a347b062a9222978b6aadd7ae
472f04a9e9a8e4a776364acd7231551cdf55c44a
[ "packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts", "packages/insomnia-smoke-test/tests/smoke/openapi.test.ts", "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx" ]
[ { "comment": "The ruleset viewer modal no longer includes the `theme--dialog` class. Theme CSS for dialogs is generated under `.theme--dialog` (see `generateThemeCSS`), so dropping this class can cause the modal to ignore the active theme’s dialog palette and look inconsistent across themes/plugins.", "path...
diff --git a/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts b/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts index 1074cf242d8..93fa0e0f8a4 100644 --- a/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts +++ b/packages/insomnia-smoke-test/tests/smoke/custom-lint-r...
true
Kong/insomnia
10,073
comment_to_fix
fix(linting): fixes linting styling / UI issues for v13
The ruleset viewer modal no longer includes the `theme--dialog` class. Theme CSS for dialogs is generated under `.theme--dialog` (see `generateThemeCSS`), so dropping this class can cause the modal to ignore the active theme’s dialog palette and look inconsistent across themes/plugins.
007f10655031c62a347b062a9222978b6aadd7ae
472f04a9e9a8e4a776364acd7231551cdf55c44a
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx index a7274d40f8f..d9317d6dcab 100644 --- a/packages/insomnia/src/routes/organization.$...
[ "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx" ]
[ { "comment": "The ruleset viewer modal no longer includes the `theme--dialog` class. Theme CSS for dialogs is generated under `.theme--dialog` (see `generateThemeCSS`), so dropping this class can cause the modal to ignore the active theme’s dialog palette and look inconsistent across themes/plugins.", "path...
true
Kong/insomnia
10,073
comment_to_fix
fix(linting): fixes linting styling / UI issues for v13
`lintToolbar` is marked as `flex-wrap` but the container also has a fixed height (`h-(--line-height-sm)`). If the toolbar ever wraps (e.g. narrow window), a fixed height can cause clipping/overlap. Prefer letting the height grow when wrapped (or remove wrapping).
007f10655031c62a347b062a9222978b6aadd7ae
472f04a9e9a8e4a776364acd7231551cdf55c44a
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx index a7274d40f8f..d9317d6dcab 100644 --- a/packages/insomnia/src/routes/organization.$...
[ "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx" ]
[ { "comment": "`lintToolbar` is marked as `flex-wrap` but the container also has a fixed height (`h-(--line-height-sm)`). If the toolbar ever wraps (e.g. narrow window), a fixed height can cause clipping/overlap. Prefer letting the height grow when wrapped (or remove wrapping).", "path": "packages/insomnia/s...
true
Kong/insomnia
10,073
comment_to_fix
fix(linting): fixes linting styling / UI issues for v13
`isLintPaneOpen` is initialized as `false` and only updated via `onCollapse`/`onExpand`, but this `PanelGroup` uses `autoSaveId` (restoring panel sizes on load). If the saved layout restores the lint panel expanded, `isLintPaneOpen` can be out of sync (e.g. toggle button at line ~777 calls the wrong action, and the pan...
007f10655031c62a347b062a9222978b6aadd7ae
472f04a9e9a8e4a776364acd7231551cdf55c44a
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx index a7274d40f8f..d9317d6dcab 100644 --- a/packages/insomnia/src/routes/organization.$...
[ "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx" ]
[ { "comment": "`isLintPaneOpen` is initialized as `false` and only updated via `onCollapse`/`onExpand`, but this `PanelGroup` uses `autoSaveId` (restoring panel sizes on load). If the saved layout restores the lint panel expanded, `isLintPaneOpen` can be out of sync (e.g. toggle button at line ~777 calls the wro...
true
Kong/insomnia
10,074
issue_to_patch
fix: let user toggle parameters for newer URL-based LLMs
Need to let user toggle parameters in case some LLMs error because they do not support them. For example, Claude Opus 4.7 and 4.8 do not support temperature, so if a user uses a gateway or proxy (Kong API Gateway, LiteLLM, etc.) to call Claude Opus 4.8 and has temperature enabled in the parameters, then the calls will ...
b7774b01736f30764289b7e6fb66175df85958c7
1afdbeb85f3847375c39b38d0533aa58ab3480b9
diff --git a/packages/insomnia/src/main/ipc/main.ts b/packages/insomnia/src/main/ipc/main.ts index dd2369ede8a7..9c01b6945988 100644 --- a/packages/insomnia/src/main/ipc/main.ts +++ b/packages/insomnia/src/main/ipc/main.ts @@ -101,6 +101,32 @@ export const openInBrowser = (href: string) => { } }; +const sanitizeM...
[ "packages/insomnia/src/main/__tests__/llm-config-service.test.ts", "packages/insomnia/src/main/ipc/main.ts", "packages/insomnia/src/main/llm-config-service.ts", "packages/insomnia/src/plugins/types.ts", "packages/insomnia/src/ui/components/settings/llms/url-utils.test.ts", "packages/insomnia/src/ui/compon...
[ { "comment": "Checkbox label text is identical for multiple toggles, which makes it ambiguous (especially for screen readers). Use a parameter-specific label here so users can distinguish the control.", "path": "packages/insomnia/src/ui/components/settings/llms/url.tsx", "hunk": "@@ -303,6 +305,18 @@ ex...
diff --git a/packages/insomnia/src/main/__tests__/llm-config-service.test.ts b/packages/insomnia/src/main/__tests__/llm-config-service.test.ts index c5f5028d4200..c33d086d6bce 100644 --- a/packages/insomnia/src/main/__tests__/llm-config-service.test.ts +++ b/packages/insomnia/src/main/__tests__/llm-config-service.test....
true
Kong/insomnia
10,074
comment_to_fix
fix: let user toggle parameters for newer URL-based LLMs
Checkbox label text is identical for multiple toggles, which makes it ambiguous (especially for screen readers). Use a parameter-specific label here so users can distinguish the control.
b7774b01736f30764289b7e6fb66175df85958c7
1afdbeb85f3847375c39b38d0533aa58ab3480b9
diff --git a/packages/insomnia/src/ui/components/settings/llms/url.tsx b/packages/insomnia/src/ui/components/settings/llms/url.tsx index ca9777545dbf..0d9d97551ee1 100644 --- a/packages/insomnia/src/ui/components/settings/llms/url.tsx +++ b/packages/insomnia/src/ui/components/settings/llms/url.tsx @@ -2,6 +2,7 @@ impor...
[ "packages/insomnia/src/ui/components/settings/llms/url.tsx" ]
[ { "comment": "Checkbox label text is identical for multiple toggles, which makes it ambiguous (especially for screen readers). Use a parameter-specific label here so users can distinguish the control.", "path": "packages/insomnia/src/ui/components/settings/llms/url.tsx", "hunk": "@@ -303,6 +305,18 @@ ex...
true
Kong/insomnia
10,074
comment_to_fix
fix: let user toggle parameters for newer URL-based LLMs
Checkbox label text is identical for multiple toggles, which makes it ambiguous (especially for screen readers). Use a parameter-specific label here so users can distinguish the control.
b7774b01736f30764289b7e6fb66175df85958c7
1afdbeb85f3847375c39b38d0533aa58ab3480b9
diff --git a/packages/insomnia/src/ui/components/settings/llms/url.tsx b/packages/insomnia/src/ui/components/settings/llms/url.tsx index ca9777545dbf..0d9d97551ee1 100644 --- a/packages/insomnia/src/ui/components/settings/llms/url.tsx +++ b/packages/insomnia/src/ui/components/settings/llms/url.tsx @@ -2,6 +2,7 @@ impor...
[ "packages/insomnia/src/ui/components/settings/llms/url.tsx" ]
[ { "comment": "Checkbox label text is identical for multiple toggles, which makes it ambiguous (especially for screen readers). Use a parameter-specific label here so users can distinguish the control.", "path": "packages/insomnia/src/ui/components/settings/llms/url.tsx", "hunk": "@@ -321,6 +336,18 @@ ex...
true
Kong/insomnia
10,074
comment_to_fix
fix: let user toggle parameters for newer URL-based LLMs
Checkbox label text is identical for multiple toggles, which makes it ambiguous (especially for screen readers). Use a parameter-specific label here so users can distinguish the control.
b7774b01736f30764289b7e6fb66175df85958c7
1afdbeb85f3847375c39b38d0533aa58ab3480b9
diff --git a/packages/insomnia/src/ui/components/settings/llms/url.tsx b/packages/insomnia/src/ui/components/settings/llms/url.tsx index ca9777545dbf..0d9d97551ee1 100644 --- a/packages/insomnia/src/ui/components/settings/llms/url.tsx +++ b/packages/insomnia/src/ui/components/settings/llms/url.tsx @@ -2,6 +2,7 @@ impor...
[ "packages/insomnia/src/ui/components/settings/llms/url.tsx" ]
[ { "comment": "Checkbox label text is identical for multiple toggles, which makes it ambiguous (especially for screen readers). Use a parameter-specific label here so users can distinguish the control.", "path": "packages/insomnia/src/ui/components/settings/llms/url.tsx", "hunk": "@@ -339,6 +367,18 @@ ex...
true
Kong/insomnia
10,070
issue_to_patch
fix: cloud sync toast for v13
Manually pulling from cloud sync was displaying `Pull failed` instead of `Pull started`: <img width="268" height="145" alt="Screenshot 2026-06-11 at 17 07 45" src="https://github.com/user-attachments/assets/73beb77e-82b4-4f25-9e33-ae8eb9eb4ce5" /> This change fixes it so that pull starts display correctly, and so...
1204e6b9db6bcd5681578e8b77605f714ba5fdde
74e7083d577255ac648eafbf71c0f1eba6af51a8
diff --git a/packages/insomnia/src/ui/components/dropdowns/sync-dropdown.tsx b/packages/insomnia/src/ui/components/dropdowns/sync-dropdown.tsx index 58528485929..8f6752fac36 100644 --- a/packages/insomnia/src/ui/components/dropdowns/sync-dropdown.tsx +++ b/packages/insomnia/src/ui/components/dropdowns/sync-dropdown.tsx...
[ "packages/insomnia/src/ui/components/dropdowns/sync-dropdown.tsx" ]
[]
true
Kong/insomnia
9,992
issue_to_patch
Remove all third-party npm package imports from the renderer bundle
## Summary Removes several third-party package imports from the renderer by replacing them with lightweight alternatives or inline implementations. No behavioral changes — pure substitutions. - **node-forge (renderer)** — removed from renderer bundle via IPC bridge. `vault-crypto.ts` is now a thin async wrapper over ...
6695ac8f0488123ad005383da7bb6f0f29cb35fa
805fcc4d7d7cd82a81a23564bd0f148037686157
diff --git a/.gitignore b/.gitignore index 9e48e2a92e53..dfc36daba60f 100644 --- a/.gitignore +++ b/.gitignore @@ -41,3 +41,4 @@ rootCA2.* final.cpp insomnia.ico final.rc +.tmp* diff --git a/packages/insomnia/src/common/constants.ts b/packages/insomnia/src/common/constants.ts index ab46c2c54e7b..ebbc5168ce0d 100644 ...
[ ".gitignore", "packages/insomnia-smoke-test/tests/smoke/app.test.ts", "packages/insomnia-smoke-test/tests/smoke/external-vault-integration.test.ts", "packages/insomnia-smoke-test/tests/smoke/template-tags-interactions.test.ts", "packages/insomnia/src/common/constants.ts", "packages/insomnia/src/entry.prel...
[ { "comment": "This short replacement table changes the previous `mime-types` behavior for many common file uploads. For example, extensions such as `.webp`, `.wasm`, `.mp4`, or `.docx` will now return `false` from `lookupMimeType`, causing the body editor to fall back to `application/octet-stream` instead of th...
diff --git a/packages/insomnia-smoke-test/tests/smoke/app.test.ts b/packages/insomnia-smoke-test/tests/smoke/app.test.ts index 0c7c6665810b..8756a4ce105e 100644 --- a/packages/insomnia-smoke-test/tests/smoke/app.test.ts +++ b/packages/insomnia-smoke-test/tests/smoke/app.test.ts @@ -93,13 +93,6 @@ test('can send request...
true
Kong/insomnia
9,992
comment_to_fix
Remove all third-party npm package imports from the renderer bundle
This new renderer utility still imports and uses `node-forge` runtime submodules, so it does not replace forge with the Web Crypto API or remove forge from the renderer as described. If the intended bundle reduction is to eliminate forge from these flows, this should use `globalThis.crypto.subtle` for AES-GCM or be wir...
6695ac8f0488123ad005383da7bb6f0f29cb35fa
805fcc4d7d7cd82a81a23564bd0f148037686157
diff --git a/packages/insomnia/src/utils/vault-crypto.ts b/packages/insomnia/src/utils/vault-crypto.ts new file mode 100644 index 000000000000..5a1099fe6f4e --- /dev/null +++ b/packages/insomnia/src/utils/vault-crypto.ts @@ -0,0 +1,21 @@ +export const encryptSecretValue = async (rawValue: string, symmetricKey: JsonWebK...
[ "packages/insomnia/src/utils/vault-crypto.ts" ]
[ { "comment": "This new renderer utility still imports and uses `node-forge` runtime submodules, so it does not replace forge with the Web Crypto API or remove forge from the renderer as described. If the intended bundle reduction is to eliminate forge from these flows, this should use `globalThis.crypto.subtle`...
true
Kong/insomnia
9,992
comment_to_fix
Remove all third-party npm package imports from the renderer bundle
`TextDecoder` does not support the same set of charset names as `iconv-lite`; unsupported but previously handled response charsets will now throw here and fall back to UTF-8 via `Buffer.toString()`, corrupting the displayed body for those encodings. This needs a compatibility map/fallback that preserves the encodings I...
6695ac8f0488123ad005383da7bb6f0f29cb35fa
805fcc4d7d7cd82a81a23564bd0f148037686157
diff --git a/packages/insomnia/src/ui/components/viewers/response-viewer.tsx b/packages/insomnia/src/ui/components/viewers/response-viewer.tsx index d19d3b292112..1fc36b7b042f 100644 --- a/packages/insomnia/src/ui/components/viewers/response-viewer.tsx +++ b/packages/insomnia/src/ui/components/viewers/response-viewer.t...
[ "packages/insomnia/src/ui/components/viewers/response-viewer.tsx" ]
[ { "comment": "`TextDecoder` does not support the same set of charset names as `iconv-lite`; unsupported but previously handled response charsets will now throw here and fall back to UTF-8 via `Buffer.toString()`, corrupting the displayed body for those encodings. This needs a compatibility map/fallback that pre...
true
Kong/insomnia
9,992
comment_to_fix
Remove all third-party npm package imports from the renderer bundle
The toast message has a typo: "you local" should be "your local".
6695ac8f0488123ad005383da7bb6f0f29cb35fa
805fcc4d7d7cd82a81a23564bd0f148037686157
diff --git a/packages/insomnia/src/routes/auth.clear-vault-key.tsx b/packages/insomnia/src/routes/auth.clear-vault-key.tsx index eede8df6658c..c508a67240fa 100644 --- a/packages/insomnia/src/routes/auth.clear-vault-key.tsx +++ b/packages/insomnia/src/routes/auth.clear-vault-key.tsx @@ -1,8 +1,8 @@ -import electron from...
[ "packages/insomnia/src/routes/auth.clear-vault-key.tsx" ]
[ { "comment": "The toast message has a typo: \"you local\" should be \"your local\".", "path": "packages/insomnia/src/routes/auth.clear-vault-key.tsx", "hunk": "@@ -23,11 +23,9 @@ export async function clientAction({ request }: Route.ClientActionArgs) {\n // Update vault salt and delete vault key fro...
true
Kong/insomnia
9,992
comment_to_fix
Remove all third-party npm package imports from the renderer bundle
This seems to be insecure. Should we throw the error here?
6695ac8f0488123ad005383da7bb6f0f29cb35fa
805fcc4d7d7cd82a81a23564bd0f148037686157
diff --git a/packages/insomnia/src/utils/vault-crypto.ts b/packages/insomnia/src/utils/vault-crypto.ts new file mode 100644 index 000000000000..5a1099fe6f4e --- /dev/null +++ b/packages/insomnia/src/utils/vault-crypto.ts @@ -0,0 +1,21 @@ +export const encryptSecretValue = async (rawValue: string, symmetricKey: JsonWebK...
[ "packages/insomnia/src/utils/vault-crypto.ts" ]
[ { "comment": "This seems to be insecure. Should we throw the error here?", "path": "packages/insomnia/src/utils/vault-crypto.ts", "hunk": "@@ -0,0 +1,21 @@\n+export const encryptSecretValue = async (rawValue: string, symmetricKey: JsonWebKey): Promise<string> => {\n+ if (typeof symmetricKey !== 'object...
true
Kong/insomnia
9,992
comment_to_fix
Remove all third-party npm package imports from the renderer bundle
Just curious. Is there any better idea instead of explicitly referencing all the envs one by one? Ideally, just adding statements on the types is enough.
6695ac8f0488123ad005383da7bb6f0f29cb35fa
805fcc4d7d7cd82a81a23564bd0f148037686157
diff --git a/packages/insomnia/src/entry.preload.ts b/packages/insomnia/src/entry.preload.ts index 182f610bf87a..82d0a5334882 100644 --- a/packages/insomnia/src/entry.preload.ts +++ b/packages/insomnia/src/entry.preload.ts @@ -343,6 +343,12 @@ const main: Window['main'] = { port.postMessage({ ...options, type:...
[ "packages/insomnia/src/entry.preload.ts" ]
[ { "comment": "Just curious. Is there any better idea instead of explicitly referencing all the envs one by one? Ideally, just adding statements on the types is enough.", "path": "packages/insomnia/src/entry.preload.ts", "hunk": "@@ -437,6 +446,44 @@ const database: Window['database'] = {\n invoke: (fn...
true
Kong/insomnia
9,992
comment_to_fix
Remove all third-party npm package imports from the renderer bundle
Should we reset setDecryptedValues here?
6695ac8f0488123ad005383da7bb6f0f29cb35fa
805fcc4d7d7cd82a81a23564bd0f148037686157
diff --git a/packages/insomnia/src/ui/components/editors/environment-key-value-editor/key-value-editor.tsx b/packages/insomnia/src/ui/components/editors/environment-key-value-editor/key-value-editor.tsx index 831f094dcc2a..5d392674900a 100644 --- a/packages/insomnia/src/ui/components/editors/environment-key-value-edito...
[ "packages/insomnia/src/ui/components/editors/environment-key-value-editor/key-value-editor.tsx" ]
[ { "comment": "Should we reset setDecryptedValues here?", "path": "packages/insomnia/src/ui/components/editors/environment-key-value-editor/key-value-editor.tsx", "hunk": "@@ -77,8 +77,26 @@ export const EnvironmentKVEditor = ({\n );\n const codeModalRef = useRef<CodePromptModalHandle>(null);\n con...
true
Kong/insomnia
9,992
comment_to_fix
Remove all third-party npm package imports from the renderer bundle
Why is this removed?
6695ac8f0488123ad005383da7bb6f0f29cb35fa
805fcc4d7d7cd82a81a23564bd0f148037686157
diff --git a/packages/insomnia/src/main/window-utils.ts b/packages/insomnia/src/main/window-utils.ts index b1754e254818..2a6f2ad04410 100644 --- a/packages/insomnia/src/main/window-utils.ts +++ b/packages/insomnia/src/main/window-utils.ts @@ -17,11 +17,11 @@ import { } from 'electron'; import { isLinux, isMac } fro...
[ "packages/insomnia/src/main/window-utils.ts" ]
[ { "comment": "Why is this removed?", "path": "packages/insomnia/src/main/window-utils.ts", "hunk": "@@ -270,7 +269,6 @@ export function createWindow(): ElectronBrowserWindow {\n {\n label: `${MNEMONIC_SYM}Preferences`,\n click: () => {\n- trackAnalyticsEvent(AnalyticsEvent...
true
Kong/insomnia
9,992
comment_to_fix
Remove all third-party npm package imports from the renderer bundle
Is this expected?
6695ac8f0488123ad005383da7bb6f0f29cb35fa
805fcc4d7d7cd82a81a23564bd0f148037686157
diff --git a/packages/insomnia/src/ui/components/viewers/response-multipart-viewer.tsx b/packages/insomnia/src/ui/components/viewers/response-multipart-viewer.tsx index 9659bb02c956..6ed9154b1197 100644 --- a/packages/insomnia/src/ui/components/viewers/response-multipart-viewer.tsx +++ b/packages/insomnia/src/ui/compon...
[ "packages/insomnia/src/ui/components/viewers/response-multipart-viewer.tsx" ]
[ { "comment": "Is this expected?", "path": "packages/insomnia/src/ui/components/viewers/response-multipart-viewer.tsx", "hunk": "@@ -77,7 +77,7 @@ export const ResponseMultipartViewer: FC<Props> = ({\n return;\n }\n const contentType = getContentTypeFromHeaders(selectedPart.headers, 'text/p...
true
Kong/insomnia
10,051
issue_to_patch
fix: stabilize flaky smoke tests + supporting fixes (runner selection, cloud sync, scripting)
A handful of smoke tests were flaky on CI, and chasing them down surfaced a few small product/runtime bugs. This branch stabilizes the affected tests and fixes the underlying issues. ## Source fixes - **Runner request selection (test + behavior):** the runner request list is a drag-and-drop `GridList`, so a plain...
0ab776ee498d60a8c0fecd31b8db9d0406a4f831
7c7ab9a6b6944a44e5e1ca8d980372d39b0b6044
diff --git a/packages/insomnia-scripting-environment/src/objects/async-objects.ts b/packages/insomnia-scripting-environment/src/objects/async-objects.ts index 738d39fd2c6..810156d1341 100644 --- a/packages/insomnia-scripting-environment/src/objects/async-objects.ts +++ b/packages/insomnia-scripting-environment/src/obje...
[ "packages/insomnia-scripting-environment/src/objects/async-objects.ts", "packages/insomnia-scripting-environment/src/objects/test.ts", "packages/insomnia-smoke-test/fixtures/after-response-collection.yaml", "packages/insomnia-smoke-test/playwright/pages/components/navigation-sidebar.ts", "packages/insomnia-...
[ { "comment": "is this change needed? does the interpolation not work?", "path": "packages/insomnia-smoke-test/fixtures/after-response-collection.yaml", "hunk": "@@ -6,7 +6,7 @@ meta:\n created: 1739888439647\n modified: 1739888439647\n collection:\n- - url: \"{{_.base_url}}/echo\"\n+ - url: http:/...
diff --git a/packages/insomnia-smoke-test/tests/smoke/after-response-script-features.test.ts b/packages/insomnia-smoke-test/tests/smoke/after-response-script-features.test.ts index 0a7b8101b30..252dcb8274d 100644 --- a/packages/insomnia-smoke-test/tests/smoke/after-response-script-features.test.ts +++ b/packages/insomn...
true
Kong/insomnia
10,062
issue_to_patch
fix(e2e): tab tests refactor
- use keyboard for renames instead of mouse - retries breadcrumb nav - more unique names so locators hit the right rows
4f369dbb3078c810772253fc3929cc6de204ff04
042b1f5146c97d95e65a1435343b3a5dbe0e512b
diff --git a/packages/insomnia-smoke-test/playwright/pages/components/navigation-sidebar.ts b/packages/insomnia-smoke-test/playwright/pages/components/navigation-sidebar.ts index f61c940af358..2d4330f07e7d 100644 --- a/packages/insomnia-smoke-test/playwright/pages/components/navigation-sidebar.ts +++ b/packages/insomni...
[ "packages/insomnia-smoke-test/playwright/pages/components/navigation-sidebar.ts", "packages/insomnia-smoke-test/playwright/pages/project/index.ts", "packages/insomnia-smoke-test/playwright/pages/workspace/index.ts", "packages/insomnia-smoke-test/tests/smoke/insomnia-tab.test.ts" ]
[ { "comment": "`selectCreateInProjectType` waits for the menu container to be visible, but it doesn’t wait for the specific menu item to be visible before clicking it. The previous inline test logic explicitly waited for the `Collection` menu item to be visible, and skipping that can reintroduce flakiness (e.g.,...
diff --git a/packages/insomnia-smoke-test/tests/smoke/insomnia-tab.test.ts b/packages/insomnia-smoke-test/tests/smoke/insomnia-tab.test.ts index 3fd33edbf1ab..c43f7873e206 100644 --- a/packages/insomnia-smoke-test/tests/smoke/insomnia-tab.test.ts +++ b/packages/insomnia-smoke-test/tests/smoke/insomnia-tab.test.ts @@ -3...
true
Kong/insomnia
10,062
comment_to_fix
fix(e2e): tab tests refactor
`selectCreateInProjectType` waits for the menu container to be visible, but it doesn’t wait for the specific menu item to be visible before clicking it. The previous inline test logic explicitly waited for the `Collection` menu item to be visible, and skipping that can reintroduce flakiness (e.g., menu opens but items ...
4f369dbb3078c810772253fc3929cc6de204ff04
042b1f5146c97d95e65a1435343b3a5dbe0e512b
diff --git a/packages/insomnia-smoke-test/playwright/pages/project/index.ts b/packages/insomnia-smoke-test/playwright/pages/project/index.ts index 7076bbf69e79..bb77596944c3 100644 --- a/packages/insomnia-smoke-test/playwright/pages/project/index.ts +++ b/packages/insomnia-smoke-test/playwright/pages/project/index.ts @...
[ "packages/insomnia-smoke-test/playwright/pages/project/index.ts" ]
[ { "comment": "`selectCreateInProjectType` waits for the menu container to be visible, but it doesn’t wait for the specific menu item to be visible before clicking it. The previous inline test logic explicitly waited for the `Collection` menu item to be visible, and skipping that can reintroduce flakiness (e.g.,...
true
Kong/insomnia
10,062
comment_to_fix
fix(e2e): tab tests refactor
`createCollection` fills the collection name immediately after only waiting for the dialog container. When `name` is provided, the input may not be ready yet (the old inline test code explicitly waited for the placeholder to be visible), which can cause intermittent `fill` failures. Waiting for the input to be visible ...
4f369dbb3078c810772253fc3929cc6de204ff04
042b1f5146c97d95e65a1435343b3a5dbe0e512b
diff --git a/packages/insomnia-smoke-test/playwright/pages/project/index.ts b/packages/insomnia-smoke-test/playwright/pages/project/index.ts index 7076bbf69e79..bb77596944c3 100644 --- a/packages/insomnia-smoke-test/playwright/pages/project/index.ts +++ b/packages/insomnia-smoke-test/playwright/pages/project/index.ts @...
[ "packages/insomnia-smoke-test/playwright/pages/project/index.ts" ]
[ { "comment": "`createCollection` fills the collection name immediately after only waiting for the dialog container. When `name` is provided, the input may not be ready yet (the old inline test code explicitly waited for the placeholder to be visible), which can cause intermittent `fill` failures. Waiting for th...
true
Kong/insomnia
10,062
comment_to_fix
fix(e2e): tab tests refactor
The retry loop can inadvertently *close* the create menu on subsequent attempts: `createButton.click()` runs before the `try`, so if the menu remained visible after a failed click, the next attempt will toggle it closed and then `menu.waitFor({ state: 'visible' })` will time out. This can make retries less reliable and...
4f369dbb3078c810772253fc3929cc6de204ff04
042b1f5146c97d95e65a1435343b3a5dbe0e512b
diff --git a/packages/insomnia-smoke-test/playwright/pages/project/index.ts b/packages/insomnia-smoke-test/playwright/pages/project/index.ts index 7076bbf69e79..bb77596944c3 100644 --- a/packages/insomnia-smoke-test/playwright/pages/project/index.ts +++ b/packages/insomnia-smoke-test/playwright/pages/project/index.ts @...
[ "packages/insomnia-smoke-test/playwright/pages/project/index.ts" ]
[ { "comment": "The retry loop can inadvertently *close* the create menu on subsequent attempts: `createButton.click()` runs before the `try`, so if the menu remained visible after a failed click, the next attempt will toggle it closed and then `menu.waitFor({ state: 'visible' })` will time out. This can make ret...
true
Kong/insomnia
10,062
comment_to_fix
fix(e2e): tab tests refactor
`page.mouse.move(0, 0)` is used here as a flakiness workaround, but unlike the earlier occurrence in this test it has no explanatory comment. Without context it’s easy for someone to remove or “clean up” this line and reintroduce the tooltip-overlay failure.
4f369dbb3078c810772253fc3929cc6de204ff04
042b1f5146c97d95e65a1435343b3a5dbe0e512b
diff --git a/packages/insomnia-smoke-test/tests/smoke/insomnia-tab.test.ts b/packages/insomnia-smoke-test/tests/smoke/insomnia-tab.test.ts index 3fd33edbf1ab..c43f7873e206 100644 --- a/packages/insomnia-smoke-test/tests/smoke/insomnia-tab.test.ts +++ b/packages/insomnia-smoke-test/tests/smoke/insomnia-tab.test.ts @@ -3...
[ "packages/insomnia-smoke-test/tests/smoke/insomnia-tab.test.ts" ]
[ { "comment": "`page.mouse.move(0, 0)` is used here as a flakiness workaround, but unlike the earlier occurrence in this test it has no explanatory comment. Without context it’s easy for someone to remove or “clean up” this line and reintroduce the tooltip-overlay failure.", "path": "packages/insomnia-smoke-...
true
Kong/insomnia
10,021
issue_to_patch
feat: update plugin notice to clarify third-party development and endorsement
5c08a0383c9d7988f57b8acf17d02d8d06b47eaf
ee77de3c85ef900cdccb8488ad86375734f6351b
diff --git a/packages/insomnia/src/ui/components/settings/plugins.tsx b/packages/insomnia/src/ui/components/settings/plugins.tsx index a2947da1f2f..5fb7e5350cb 100644 --- a/packages/insomnia/src/ui/components/settings/plugins.tsx +++ b/packages/insomnia/src/ui/components/settings/plugins.tsx @@ -124,7 +124,9 @@ export ...
[ "packages/insomnia/src/ui/components/settings/plugins.tsx" ]
[ { "comment": "Minor grammar/style: \"third party\" is commonly hyphenated as the compound adjective \"third-party\", and the list reads more clearly with a serial comma (\"endorse, or support\").", "path": "packages/insomnia/src/ui/components/settings/plugins.tsx", "hunk": "@@ -124,7 +124,9 @@ export co...
true
Kong/insomnia
10,021
comment_to_fix
feat: update plugin notice to clarify third-party development and endorsement
Minor grammar/style: "third party" is commonly hyphenated as the compound adjective "third-party", and the list reads more clearly with a serial comma ("endorse, or support").
5c08a0383c9d7988f57b8acf17d02d8d06b47eaf
ee77de3c85ef900cdccb8488ad86375734f6351b
diff --git a/packages/insomnia/src/ui/components/settings/plugins.tsx b/packages/insomnia/src/ui/components/settings/plugins.tsx index a2947da1f2f..5fb7e5350cb 100644 --- a/packages/insomnia/src/ui/components/settings/plugins.tsx +++ b/packages/insomnia/src/ui/components/settings/plugins.tsx @@ -124,7 +124,9 @@ export ...
[ "packages/insomnia/src/ui/components/settings/plugins.tsx" ]
[ { "comment": "Minor grammar/style: \"third party\" is commonly hyphenated as the compound adjective \"third-party\", and the list reads more clearly with a serial comma (\"endorse, or support\").", "path": "packages/insomnia/src/ui/components/settings/plugins.tsx", "hunk": "@@ -124,7 +124,9 @@ export co...
true
Kong/insomnia
10,038
issue_to_patch
Improve Konnect sync UX [INS-2697]
[M1 Konnect integration UX notes](https://konghq.atlassian.net/wiki/spaces/MT2/pages/5583175685/M1+Konnect+integration+UX+notes)
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia-data/src/models/project.ts b/packages/insomnia-data/src/models/project.ts index fd8502544686..03c052fd558d 100644 --- a/packages/insomnia-data/src/models/project.ts +++ b/packages/insomnia-data/src/models/project.ts @@ -86,11 +86,14 @@ export const isGitProject = (project: Project): proje...
[ "packages/insomnia-data/src/models/project.ts", "packages/insomnia-data/src/models/types.ts", "packages/insomnia-smoke-test/tests/smoke/konnect.test.ts", "packages/insomnia/src/konnect/__tests__/api.test.ts", "packages/insomnia/src/konnect/__tests__/sync.test.ts", "packages/insomnia/src/konnect/api.ts", ...
[ { "comment": "`clusterTypeToIcon` uses bare identifiers (e.g. `CLUSTER_TYPE_SERVERLESS`) as object keys, but these constants are not imported/defined in this module. This will throw a ReferenceError at module evaluation time and break Konnect sync UI. Use string keys instead (and consider defaulting `cloud_gate...
diff --git a/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts b/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts index 8d71df3e44ce..ae8a18579084 100644 --- a/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts +++ b/packages/insomnia-smoke-test/tests/smoke/konnect.test.ts @@ -10,8 +10,7 @@ test.de...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
`KonnectControlPlane.config.cloud_gateway` is modeled as a required boolean, but existing Konnect control plane payloads in this repo’s tests omit it. Keeping this required makes the type contract dishonest and encourages consumers to assume it always exists. Make it optional (and have consumers default it when needed)...
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/konnect/api.ts b/packages/insomnia/src/konnect/api.ts index b17a23454111..9985ed8d0cd5 100644 --- a/packages/insomnia/src/konnect/api.ts +++ b/packages/insomnia/src/konnect/api.ts @@ -23,6 +23,7 @@ export interface KonnectControlPlane { config: { cluster_type: string; con...
[ "packages/insomnia/src/konnect/api.ts" ]
[ { "comment": "`KonnectControlPlane.config.cloud_gateway` is modeled as a required boolean, but existing Konnect control plane payloads in this repo’s tests omit it. Keeping this required makes the type contract dishonest and encourages consumers to assume it always exists. Make it optional (and have consumers d...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
The onboarding popover is positioned once and only repositions on trigger resize. If the sidebar (or window) scrolls, the popover will drift away from the highlighted node. Add scroll/resize listeners to keep it anchored.
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx new file mode 100644 index 000000000000..941362ed4b98 --- /dev/null +++ b/packages/insomnia/src/ui/components...
[ "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx" ]
[ { "comment": "The onboarding popover is positioned once and only repositions on trigger resize. If the sidebar (or window) scrolls, the popover will drift away from the highlighted node. Add scroll/resize listeners to keep it anchored.", "path": "packages/insomnia/src/ui/components/sidebar/project-navigatio...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
The asset/import name `severless.svg` looks like a typo for `serverless.svg`. Keeping the misspelling makes the code harder to search/maintain; consider renaming the file and updating this import.
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-project-icon/konnect-project-icon.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-project-icon/konnect-project-icon.tsx new file mode 100644 index 000000000000..d7f50a0f67e2 --- /dev/null +++...
[ "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-project-icon/konnect-project-icon.tsx" ]
[ { "comment": "The asset/import name `severless.svg` looks like a typo for `serverless.svg`. Keeping the misspelling makes the code harder to search/maintain; consider renaming the file and updating this import.", "path": "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-project...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
```suggestion <div className="flex items-start justify-between gap-3"> ``` Increase space between popover title and close icon
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx new file mode 100644 index 000000000000..941362ed4b98 --- /dev/null +++ b/packages/insomnia/src/ui/components...
[ "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx" ]
[ { "comment": "```suggestion\n <div className=\"flex items-start justify-between gap-3\">\n```\nIncrease space between popover title and close icon", "path": "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx", "hunk": "@@ -0,0 +1,87 @@\n+import { useE...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
```suggestion <p className="mt-2 text-sm text-(--hl)"> ``` Increase size of text content
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx new file mode 100644 index 000000000000..941362ed4b98 --- /dev/null +++ b/packages/insomnia/src/ui/components...
[ "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx" ]
[ { "comment": "```suggestion\n <p className=\"mt-2 text-sm text-(--hl)\">\n```\nIncrease size of text content", "path": "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx", "hunk": "@@ -0,0 +1,87 @@\n+import { useEffect, useRef } from 'react';\n+\n+imp...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
Note: If the environment variable is pulled in as `proxy_host`, let's make sure that the nudge here references the variable like that as well. (I think I added the wrong variable key in my nudge mock)
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx new file mode 100644 index 000000000000..941362ed4b98 --- /dev/null +++ b/packages/insomnia/src/ui/components...
[ "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx" ]
[ { "comment": "Note: If the environment variable is pulled in as `proxy_host`, let's make sure that the nudge here references the variable like that as well. (I think I added the wrong variable key in my nudge mock)", "path": "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
Can we remove the click outside dismiss functionality? I want to make sure that users see this nudge, and I am afraid that they will accidentally dismiss this before they've had a chance to read it.
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx new file mode 100644 index 000000000000..941362ed4b98 --- /dev/null +++ b/packages/insomnia/src/ui/components...
[ "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx" ]
[ { "comment": "Can we remove the click outside dismiss functionality? I want to make sure that users see this nudge, and I am afraid that they will accidentally dismiss this before they've had a chance to read it.", "path": "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-o...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
The `className` includes an unexpected `haha` token, which looks like a leftover debug class and will produce inconsistent styling output (and potentially fail class-name linting/conventions). Remove it so the empty sidebar uses the same base layout classes as the normal sidebar.
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx index 22c34595771b..a62de1047fdb 100644 --- a/packages/insomnia/src/ui/components/sidebar/project-nav...
[ "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx" ]
[ { "comment": "The `className` includes an unexpected `haha` token, which looks like a leftover debug class and will produce inconsistent styling output (and potentially fail class-name linting/conventions). Remove it so the empty sidebar uses the same base layout classes as the normal sidebar.", "path": "pa...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
`cloud_gateway` is typed as a required boolean, but existing control-plane mocks (and potentially older API responses) can omit it, which will flow through as `undefined` at runtime and break deployment-type inference. Make this field optional so consumers are forced to handle the absence explicitly (e.g. defaulting to...
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/konnect/api.ts b/packages/insomnia/src/konnect/api.ts index b17a23454111..9985ed8d0cd5 100644 --- a/packages/insomnia/src/konnect/api.ts +++ b/packages/insomnia/src/konnect/api.ts @@ -23,6 +23,7 @@ export interface KonnectControlPlane { config: { cluster_type: string; con...
[ "packages/insomnia/src/konnect/api.ts" ]
[ { "comment": "`cloud_gateway` is typed as a required boolean, but existing control-plane mocks (and potentially older API responses) can omit it, which will flow through as `undefined` at runtime and break deployment-type inference. Make this field optional so consumers are forced to handle the absence explicit...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
The popover position is only recalculated on mount and when the trigger element resizes. If the sidebar scrolls (virtualized list) or the window resizes, `getBoundingClientRect()` will change but `ResizeObserver` will not fire, leaving the onboarding popover misaligned. Add scroll/resize listeners (and clean them up) t...
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx new file mode 100644 index 000000000000..941362ed4b98 --- /dev/null +++ b/packages/insomnia/src/ui/components...
[ "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/konnect-env-onboarding.tsx" ]
[ { "comment": "The popover position is only recalculated on mount and when the trigger element resizes. If the sidebar scrolls (virtualized list) or the window resizes, `getBoundingClientRect()` will change but `ResizeObserver` will not fire, leaving the onboarding popover misaligned. Add scroll/resize listeners...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
`sync.ts` (Konnect domain logic) now imports `getKonnectDeploymentType` from a UI component path. This creates an unwanted dependency from core sync code onto the UI layer and can complicate bundling, testing, and future refactors. Consider moving this helper into the Konnect module (e.g. `packages/insomnia/src/konnect...
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/konnect/sync.ts b/packages/insomnia/src/konnect/sync.ts index 757b61863048..2b7b31deeb4a 100644 --- a/packages/insomnia/src/konnect/sync.ts +++ b/packages/insomnia/src/konnect/sync.ts @@ -2,6 +2,7 @@ import type { GrpcRequest, Project, Request, RequestGroup, WebSocketRequest, Wor imp...
[ "packages/insomnia/src/konnect/sync.ts" ]
[ { "comment": "`sync.ts` (Konnect domain logic) now imports `getKonnectDeploymentType` from a UI component path. This creates an unwanted dependency from core sync code onto the UI layer and can complicate bundling, testing, and future refactors. Consider moving this helper into the Konnect module (e.g. `package...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
Remove the comment here
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx index a2cd8c9ad84a..ce4e9e1dc21c 100644 --- a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx +++ b/packages/i...
[ "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx" ]
[ { "comment": "Remove the comment here", "path": "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx", "hunk": "@@ -76,6 +76,29 @@ export async function clientLoader({ params }: Route.ClientLoaderArgs) {\n const project = await services.project.get(projectId);\n \n if (!...
true
Kong/insomnia
10,038
comment_to_fix
Improve Konnect sync UX [INS-2697]
Instead of set a new `tooltipNow` state here, we can simple define a component, this can avoid unnecessary re-render caused by state change ``` function LastSyncedLabel({ lastSyncedAt }: { lastSyncedAt: number | null }) { return lastSyncedAt ? `Last synced: ${getRelativeTimeString(lastSyncedAt, Date.now())}` ...
23d21acb674da8929b53cc649d95afbfea3f7be4
34da50be6acd54b81dcfd2c3a41189f21494c27c
diff --git a/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx b/packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx index 22c34595771b..a62de1047fdb 100644 --- a/packages/insomnia/src/ui/components/sidebar/project-nav...
[ "packages/insomnia/src/ui/components/sidebar/project-navigation-sidebar/project-navigation-sidebar.tsx" ]
[ { "comment": "Instead of set a new `tooltipNow` state here, we can simple define a component, this can avoid unnecessary re-render caused by state change\n```\nfunction LastSyncedLabel({ lastSyncedAt }: { lastSyncedAt: number | null }) {\n return lastSyncedAt\n ? `Last synced: ${getRelativeTimeString(lastSy...
true
Kong/insomnia
10,053
issue_to_patch
backport #10048 to release/13.0
cherry picked from commit af0001c13fae673029d7458bb732838d32f2b99e (#10048)
d16ebbe0f54e7d16f8277585cea13faaa06c9876
3a6b39d22750fd116d1063c8601fe7f43acb83a3
diff --git a/packages/insomnia/src/entry.preload.ts b/packages/insomnia/src/entry.preload.ts index 1e835801fdf..704b03bc8cf 100644 --- a/packages/insomnia/src/entry.preload.ts +++ b/packages/insomnia/src/entry.preload.ts @@ -442,8 +442,8 @@ const main: Window['main'] = { applyResponseHooks: (args: ApplyResponseHoo...
[ "packages/insomnia-smoke-test/tests/smoke/template-tags-interactions.test.ts", "packages/insomnia/src/entry.preload.ts", "packages/insomnia/src/main/ipc/electron.ts", "packages/insomnia/src/main/ipc/main.ts", "packages/insomnia/src/main/plugin-window.ts", "packages/insomnia/src/main/prompt-bridge.ts", "...
[]
diff --git a/packages/insomnia-smoke-test/tests/smoke/template-tags-interactions.test.ts b/packages/insomnia-smoke-test/tests/smoke/template-tags-interactions.test.ts index 38cac2ff263..99eccbca0a3 100644 --- a/packages/insomnia-smoke-test/tests/smoke/template-tags-interactions.test.ts +++ b/packages/insomnia-smoke-tes...
true
Kong/insomnia
10,029
issue_to_patch
plugin warning toast
<img width="443" height="98" alt="image" src="https://github.com/user-attachments/assets/4ec7aba2-bab2-45fd-8251-5b4f36362b29" />
47a41c466f3bdbc28fe1fd70929e088f427cc1bb
d2f8b2d2d5572b370d5fd1e46fd2a5c4b29c7ac0
diff --git a/packages/insomnia/src/root.tsx b/packages/insomnia/src/root.tsx index b19ac9dd4ff..28c3835eff9 100644 --- a/packages/insomnia/src/root.tsx +++ b/packages/insomnia/src/root.tsx @@ -23,6 +23,7 @@ import { } from 'react-router'; import { useLatest } from 'react-use'; +import { isLoggedIn } from '~/account...
[ "packages/insomnia/src/root.tsx" ]
[ { "comment": "```suggestion\n <a href=\"https://insomnia.rest/breaking-changes\" target=\"_blank\" rel=\"noopener noreferrer\" className=\"underline\">\n```", "path": "packages/insomnia/src/root.tsx", "hunk": "@@ -694,6 +695,37 @@ const Root = () => {\n }\n }, [organizationId]);\n...
true
Kong/insomnia
10,029
comment_to_fix
plugin warning toast
```suggestion <a href="https://insomnia.rest/breaking-changes" target="_blank" rel="noopener noreferrer" className="underline"> ```
47a41c466f3bdbc28fe1fd70929e088f427cc1bb
d2f8b2d2d5572b370d5fd1e46fd2a5c4b29c7ac0
diff --git a/packages/insomnia/src/root.tsx b/packages/insomnia/src/root.tsx index b19ac9dd4ff..28c3835eff9 100644 --- a/packages/insomnia/src/root.tsx +++ b/packages/insomnia/src/root.tsx @@ -23,6 +23,7 @@ import { } from 'react-router'; import { useLatest } from 'react-use'; +import { isLoggedIn } from '~/account...
[ "packages/insomnia/src/root.tsx" ]
[ { "comment": "```suggestion\n <a href=\"https://insomnia.rest/breaking-changes\" target=\"_blank\" rel=\"noopener noreferrer\" className=\"underline\">\n```", "path": "packages/insomnia/src/root.tsx", "hunk": "@@ -694,6 +695,37 @@ const Root = () => {\n }\n }, [organizationId]);\n...
true
Kong/insomnia
10,063
issue_to_patch
feat: change orphaned projects tip to shorter style
Leave the more compact tip for orphaned projects which was removed in #10057
f035abb8dfd21775c48280618af432dc4f2d067c
a36a40807ab9ed0dced07d3136b4b5d517ca2fda
diff --git a/packages/insomnia/src/routes/organization.tsx b/packages/insomnia/src/routes/organization.tsx index 18a734ae184..dc307e564eb 100644 --- a/packages/insomnia/src/routes/organization.tsx +++ b/packages/insomnia/src/routes/organization.tsx @@ -386,7 +386,7 @@ const Component = ({ loaderData }: Route.ComponentP...
[ "packages/insomnia/src/routes/organization.tsx" ]
[ { "comment": "The orphaned-projects statusbar button is now icon-only, so it no longer has an accessible name for screen readers (tooltip text is not a reliable substitute). Add an `aria-label` (and optionally keep the tooltip for sighted users).", "path": "packages/insomnia/src/routes/organization.tsx", ...
true
Kong/insomnia
10,063
comment_to_fix
feat: change orphaned projects tip to shorter style
The orphaned-projects statusbar button is now icon-only, so it no longer has an accessible name for screen readers (tooltip text is not a reliable substitute). Add an `aria-label` (and optionally keep the tooltip for sighted users).
f035abb8dfd21775c48280618af432dc4f2d067c
a36a40807ab9ed0dced07d3136b4b5d517ca2fda
diff --git a/packages/insomnia/src/routes/organization.tsx b/packages/insomnia/src/routes/organization.tsx index 18a734ae184..dc307e564eb 100644 --- a/packages/insomnia/src/routes/organization.tsx +++ b/packages/insomnia/src/routes/organization.tsx @@ -386,7 +386,7 @@ const Component = ({ loaderData }: Route.ComponentP...
[ "packages/insomnia/src/routes/organization.tsx" ]
[ { "comment": "The orphaned-projects statusbar button is now icon-only, so it no longer has an accessible name for screen readers (tooltip text is not a reliable substitute). Add an `aria-label` (and optionally keep the tooltip for sighted users).", "path": "packages/insomnia/src/routes/organization.tsx", ...
true
Kong/insomnia
10,061
issue_to_patch
fix(ui): align header editors using grid
Before: <img width="654" height="312" alt="image" src="https://github.com/user-attachments/assets/9292776d-24f9-4684-b372-4293adf81e82" /> After: <img width="647" height="271" alt="Screenshot 2026-06-10 at 14 09 43" src="https://github.com/user-attachments/assets/3f04b7f2-1e41-469d-bb5e-2efcb780453a" />
0705350a89c10f3de8d37cbcd5d36e4fc5dce710
1b317c7adcabece9db5751062a05e32c5e63bcd7
diff --git a/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx b/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx index 9e1e656951a..0e4b48cb989 100644 --- a/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx +++ b/packages/insomnia/src/ui/componen...
[ "packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx" ]
[ { "comment": "In the read-only row, the value cell wrapper no longer provides full-height/vertical centering. This can cause the file / multiline button variants of `valueEditor` (which don’t have `h-full` in their own className in this read-only branch) to sit top-aligned within the `h-(--line-height-sm)` row,...
true
Kong/insomnia
10,061
comment_to_fix
fix(ui): align header editors using grid
In the read-only row, the value cell wrapper no longer provides full-height/vertical centering. This can cause the file / multiline button variants of `valueEditor` (which don’t have `h-full` in their own className in this read-only branch) to sit top-aligned within the `h-(--line-height-sm)` row, reintroducing misalig...
0705350a89c10f3de8d37cbcd5d36e4fc5dce710
1b317c7adcabece9db5751062a05e32c5e63bcd7
diff --git a/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx b/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx index 9e1e656951a..0e4b48cb989 100644 --- a/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx +++ b/packages/insomnia/src/ui/componen...
[ "packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx" ]
[ { "comment": "In the read-only row, the value cell wrapper no longer provides full-height/vertical centering. This can cause the file / multiline button variants of `valueEditor` (which don’t have `h-full` in their own className in this read-only branch) to sit top-aligned within the `h-(--line-height-sm)` row,...
true
Kong/insomnia
10,061
comment_to_fix
fix(ui): align header editors using grid
This row-level `Toolbar` will be exposed to assistive tech with `role="toolbar"`. Toolbars should have an accessible name, otherwise screen readers may announce an unlabeled “toolbar” for every row.
0705350a89c10f3de8d37cbcd5d36e4fc5dce710
1b317c7adcabece9db5751062a05e32c5e63bcd7
diff --git a/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx b/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx index 9e1e656951a..0e4b48cb989 100644 --- a/packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx +++ b/packages/insomnia/src/ui/componen...
[ "packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx" ]
[ { "comment": "This row-level `Toolbar` will be exposed to assistive tech with `role=\"toolbar\"`. Toolbars should have an accessible name, otherwise screen readers may announce an unlabeled “toolbar” for every row.", "path": "packages/insomnia/src/ui/components/key-value-editor/key-value-editor.tsx", "h...
true
Kong/insomnia
10,058
issue_to_patch
Fix: Catch organization list fetch error in loader
Catch the organization list fetch error in loader to avoid unexpected app crash when network fails
07a09b519dcec7d89e7a514febac10c5209a23e2
20a520d01c25e8b086c34211016d7b70b1f6a671
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx index 53dc8b5b04f..a2cd8c9ad84 100644 --- a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx +++ b/packages/ins...
[ "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.tsx", "packages/insomnia/src/routes/organization.$organizationId.project._index.tsx" ]
[ { "comment": "In `shouldAutoCreateInitialProject`, if `services.organization.get()` throws, the function currently falls through and may return `true` based solely on localStorage state. That can incorrectly trigger auto-creation of a project when the organization type could not be verified (e.g. network failur...
true
Kong/insomnia
10,036
issue_to_patch
feat: group spectral lint warnings/errors by rule; add drag handler to lint panel
Addresses [INS-2716](https://konghq.atlassian.net/browse/INS-2716). Groups lint error messages / warnings by unique spectral rule code. Also updates styles/UI to add a vertical drag handler to the lint panel. [INS-2716]: https://konghq.atlassian.net/browse/INS-2716?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYz...
51bb1b5178b9c6dcc52586b4a0ab9ebfcf034d54
c1d7cd295e4c98c6acc73d5672c708e636f127fa
[ "packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts", "packages/insomnia-smoke-test/tests/smoke/openapi.test.ts", "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx" ]
[ { "comment": "`ListBox` is built from `items` that already contain `id: message.code`, but `ListBoxItem` overrides `id` with a different value (`lint-message-${item.code}`). In react-aria-components, mismatched ids can break item identity/selection and causes inconsistent accessibility metadata. Prefer keeping ...
diff --git a/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts b/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts index df4e42d7d53..1074cf242d8 100644 --- a/packages/insomnia-smoke-test/tests/smoke/custom-lint-rules.test.ts +++ b/packages/insomnia-smoke-test/tests/smoke/custom-lint-r...
true
Kong/insomnia
10,036
comment_to_fix
feat: group spectral lint warnings/errors by rule; add drag handler to lint panel
`ListBox` is built from `items` that already contain `id: message.code`, but `ListBoxItem` overrides `id` with a different value (`lint-message-${item.code}`). In react-aria-components, mismatched ids can break item identity/selection and causes inconsistent accessibility metadata. Prefer keeping a single stable id (e....
51bb1b5178b9c6dcc52586b4a0ab9ebfcf034d54
c1d7cd295e4c98c6acc73d5672c708e636f127fa
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx index 77f2c54f9b3..a7274d40f8f 100644 --- a/packages/insomnia/src/routes/organization.$...
[ "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx" ]
[ { "comment": "`ListBox` is built from `items` that already contain `id: message.code`, but `ListBoxItem` overrides `id` with a different value (`lint-message-${item.code}`). In react-aria-components, mismatched ids can break item identity/selection and causes inconsistent accessibility metadata. Prefer keeping ...
true
Kong/insomnia
10,036
comment_to_fix
feat: group spectral lint warnings/errors by rule; add drag handler to lint panel
Rendering native `<button>` elements inside a `ListBoxItem` creates nested interactive controls inside a listbox option, which is an invalid ARIA pattern and can break keyboard navigation and screen reader semantics. Consider representing occurrences as actual listbox items (e.g. a flat list with section/group headings...
51bb1b5178b9c6dcc52586b4a0ab9ebfcf034d54
c1d7cd295e4c98c6acc73d5672c708e636f127fa
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx index 77f2c54f9b3..a7274d40f8f 100644 --- a/packages/insomnia/src/routes/organization.$...
[ "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx" ]
[ { "comment": "Rendering native `<button>` elements inside a `ListBoxItem` creates nested interactive controls inside a listbox option, which is an invalid ARIA pattern and can break keyboard navigation and screen reader semantics. Consider representing occurrences as actual listbox items (e.g. a flat list with ...
true
Kong/insomnia
10,036
comment_to_fix
feat: group spectral lint warnings/errors by rule; add drag handler to lint panel
The lint panel `Panel` is always rendered with `defaultSize={5}` and `minSize={5}`, but its contents are conditionally `null` when `apiSpec.contents` is empty. This still reserves vertical space and leaves an empty panel when creating/importing a spec (regression vs the previous conditional render). Conditionally rende...
51bb1b5178b9c6dcc52586b4a0ab9ebfcf034d54
c1d7cd295e4c98c6acc73d5672c708e636f127fa
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx index 77f2c54f9b3..a7274d40f8f 100644 --- a/packages/insomnia/src/routes/organization.$...
[ "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx" ]
[ { "comment": "The lint panel `Panel` is always rendered with `defaultSize={5}` and `minSize={5}`, but its contents are conditionally `null` when `apiSpec.contents` is empty. This still reserves vertical space and leaves an empty panel when creating/importing a spec (regression vs the previous conditional render...
true
Kong/insomnia
10,036
comment_to_fix
feat: group spectral lint warnings/errors by rule; add drag handler to lint panel
When `window.main.lintSpec` returns an `error`, the function returns early without clearing `lintMessages`, so the UI can keep showing stale lint results even though linting failed.
51bb1b5178b9c6dcc52586b4a0ab9ebfcf034d54
c1d7cd295e4c98c6acc73d5672c708e636f127fa
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx index 77f2c54f9b3..a7274d40f8f 100644 --- a/packages/insomnia/src/routes/organization.$...
[ "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx" ]
[ { "comment": "When `window.main.lintSpec` returns an `error`, the function returns early without clearing `lintMessages`, so the UI can keep showing stale lint results even though linting failed.", "path": "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.s...
true
Kong/insomnia
10,036
comment_to_fix
feat: group spectral lint warnings/errors by rule; add drag handler to lint panel
On unexpected exceptions in the lint helper, `lintMessages` is not cleared before returning, which can leave stale errors/warnings displayed after a lint failure.
51bb1b5178b9c6dcc52586b4a0ab9ebfcf034d54
c1d7cd295e4c98c6acc73d5672c708e636f127fa
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx index 77f2c54f9b3..a7274d40f8f 100644 --- a/packages/insomnia/src/routes/organization.$...
[ "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx" ]
[ { "comment": "On unexpected exceptions in the lint helper, `lintMessages` is not cleared before returning, which can leave stale errors/warnings displayed after a lint failure.", "path": "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx", "hunk...
true
Kong/insomnia
10,036
comment_to_fix
feat: group spectral lint warnings/errors by rule; add drag handler to lint panel
The expand/collapse control for grouped lint messages toggles visibility, but it doesn’t expose its expanded state to assistive tech. Adding `aria-expanded` makes the control’s state discoverable to screen readers.
51bb1b5178b9c6dcc52586b4a0ab9ebfcf034d54
c1d7cd295e4c98c6acc73d5672c708e636f127fa
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx index 77f2c54f9b3..a7274d40f8f 100644 --- a/packages/insomnia/src/routes/organization.$...
[ "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx" ]
[ { "comment": "The expand/collapse control for grouped lint messages toggles visibility, but it doesn’t expose its expanded state to assistive tech. Adding `aria-expanded` makes the control’s state discoverable to screen readers.", "path": "packages/insomnia/src/routes/organization.$organizationId.project.$p...
true
Kong/insomnia
10,036
comment_to_fix
feat: group spectral lint warnings/errors by rule; add drag handler to lint panel
The occurrence row `key` is not guaranteed to be unique (multiple diagnostics can share the same `line` and `path`), which can cause React to reuse DOM nodes incorrectly. Include the diagnostic range in the key to make it stable/unique.
51bb1b5178b9c6dcc52586b4a0ab9ebfcf034d54
c1d7cd295e4c98c6acc73d5672c708e636f127fa
diff --git a/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx b/packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx index 77f2c54f9b3..a7274d40f8f 100644 --- a/packages/insomnia/src/routes/organization.$...
[ "packages/insomnia/src/routes/organization.$organizationId.project.$projectId.workspace.$workspaceId.spec.tsx" ]
[ { "comment": "The occurrence row `key` is not guaranteed to be unique (multiple diagnostics can share the same `line` and `path`), which can cause React to reuse DOM nodes incorrectly. Include the diagnostic range in the key to make it stable/unique.", "path": "packages/insomnia/src/routes/organization.$org...
true
Kong/insomnia
10,055
issue_to_patch
add faker to optimizeDeps
<!-- Please open an [Issue](https://github.com/kong/insomnia/issues/new) first to discuss new features or non-trivial changes. Please provide as much detail as possible on the change as possible including general description, implementation details, potential shortcomings, etc. If this PR closes an issue, please menti...
2c1fd804ebea41b9da987096f97890db42647793
df8628f340a3d748f1b76bd523e624dd1680cc82
diff --git a/packages/insomnia/vite.config.ts b/packages/insomnia/vite.config.ts index be6c6190cc9..a34cb1dbd8c 100644 --- a/packages/insomnia/vite.config.ts +++ b/packages/insomnia/vite.config.ts @@ -49,6 +49,7 @@ export default defineConfig(({ mode }) => { '@stoplight/spectral-core', 'isomorphic-git...
[ "packages/insomnia/vite.config.ts" ]
[]
true
Kong/insomnia
10,052
issue_to_patch
backport #10046 to release/13.0
cherry picked from commit 32668df4b8b18cad5357d5c4665a4231f1f1ba4a (#10046)
ee6935dbd0c3710f18978fb17fa3b1c0674c1198
42a0b5519b196428f05751a126ffdb671dff16b0
diff --git a/packages/insomnia-smoke-test/server/cloud-sync-api.ts b/packages/insomnia-smoke-test/server/cloud-sync-api.ts index 69e5f113a7b..cca6888c416 100644 --- a/packages/insomnia-smoke-test/server/cloud-sync-api.ts +++ b/packages/insomnia-smoke-test/server/cloud-sync-api.ts @@ -13,7 +13,21 @@ export interface AES...
[ "packages/insomnia-smoke-test/server/cloud-sync-api.ts", "packages/insomnia/src/plugins/index.ts" ]
[]
true
Kong/insomnia
10,057
issue_to_patch
fix: remove duplicate orphaned tip
This pull request removes the duplicate warning indicator for orphaned projects from the organization route UI.
af0001c13fae673029d7458bb732838d32f2b99e
506565668bfe9c5611352cac10adbb30ae4d1c83
diff --git a/packages/insomnia/src/routes/organization.tsx b/packages/insomnia/src/routes/organization.tsx index afd35094fef..18a734ae184 100644 --- a/packages/insomnia/src/routes/organization.tsx +++ b/packages/insomnia/src/routes/organization.tsx @@ -401,28 +401,6 @@ const Component = ({ loaderData }: Route.Component...
[ "packages/insomnia/src/routes/organization.tsx" ]
[]
true
Kong/insomnia
10,048
issue_to_patch
refactor(runtime): extend IoC runtime to 3 new capabilities
## Summary Consolidate and extend the runtime IoC container: - **Reorganize runtime code** from `src/common/runtime` → `src/runtimes/` with subdirectories per capability (crypto, network, templating, secret-storage) - **Add SecretStorageRuntime**: Platform-native secret storage (Electron safeStorage) - Fixes issue ...
7d5eb88ca01854777189f463bd2b8a68b56ccb17
bfcc266be2633bb94a4e98dd9d098adecdef619c
diff --git a/packages/insomnia-inso/src/cli.ts b/packages/insomnia-inso/src/cli.ts index fb579ae75bc7..645567262ad4 100644 --- a/packages/insomnia-inso/src/cli.ts +++ b/packages/insomnia-inso/src/cli.ts @@ -10,9 +10,9 @@ import { Confirm } from 'enquirer'; import { pick } from 'es-toolkit'; import { isDevelopment, JS...
[ "packages/insomnia-inso/src/cli.ts", "packages/insomnia-scripting-environment/src/objects/interfaces.ts", "packages/insomnia-smoke-test/playwright/test.ts", "packages/insomnia-smoke-test/tests/smoke/template-tags-interactions.test.ts", "packages/insomnia/setup-vitest.ts", "packages/insomnia/src/account/__...
[ { "comment": "This file seems to be unnecessary; all the calls should go through the runtime. As well as `network-adapter`, `templating-adapter`, etc", "path": "packages/insomnia/src/runtimes/crypto/crypto-adapter.ts", "hunk": "@@ -0,0 +1,3 @@\n+// Imports the renderer implementation by default.", "...
diff --git a/packages/insomnia-smoke-test/tests/smoke/template-tags-interactions.test.ts b/packages/insomnia-smoke-test/tests/smoke/template-tags-interactions.test.ts index 38cac2ff2630..99eccbca0a33 100644 --- a/packages/insomnia-smoke-test/tests/smoke/template-tags-interactions.test.ts +++ b/packages/insomnia-smoke-t...
true
Kong/insomnia
10,050
issue_to_patch
fix: show v13 onboarding immediately after Git migration completes [INS-2552]
After introducing `OnboardingV13`, the intended first-run flow is: **Git filesystem migration first → v13 onboarding immediately once migration completes.** The "migration first" half already worked (`getInitialEntry` checks pending Git migrations before the `hasSeenOnboardingV13` flag). But the "onboarding righ...
a9c9216254f9ee2c02a51825aa10dc6f4690a759
f7d4595df5470c396e2878f9cdb755f9679d04dd
diff --git a/packages/insomnia-smoke-test/playwright/test.ts b/packages/insomnia-smoke-test/playwright/test.ts index 1a440596d057..4910e8770330 100644 --- a/packages/insomnia-smoke-test/playwright/test.ts +++ b/packages/insomnia-smoke-test/playwright/test.ts @@ -72,7 +72,9 @@ export const test = baseTest.extend<{ ...
[ "packages/insomnia-smoke-test/playwright/test.ts", "packages/insomnia-smoke-test/tests/migration/git-repo-onboarding.test.ts", "packages/insomnia/src/routes/git-migration.$.tsx" ]
[ { "comment": "`postMigrationPath` reads `window.localStorage` during render. This route is server-rendered (see entry.server.tsx), so referencing `window` will throw during SSR even though the value is only needed client-side after migration completes. Guard the access (or compute it lazily when rendering the c...
diff --git a/packages/insomnia-smoke-test/tests/migration/git-repo-onboarding.test.ts b/packages/insomnia-smoke-test/tests/migration/git-repo-onboarding.test.ts new file mode 100644 index 000000000000..46663016d9a2 --- /dev/null +++ b/packages/insomnia-smoke-test/tests/migration/git-repo-onboarding.test.ts @@ -0,0 +1,9...
true
Kong/insomnia
10,050
comment_to_fix
fix: show v13 onboarding immediately after Git migration completes [INS-2552]
`postMigrationPath` reads `window.localStorage` during render. This route is server-rendered (see entry.server.tsx), so referencing `window` will throw during SSR even though the value is only needed client-side after migration completes. Guard the access (or compute it lazily when rendering the completion link) to kee...
a9c9216254f9ee2c02a51825aa10dc6f4690a759
f7d4595df5470c396e2878f9cdb755f9679d04dd
diff --git a/packages/insomnia/src/routes/git-migration.$.tsx b/packages/insomnia/src/routes/git-migration.$.tsx index 458b3b17cbed..79c379ec66e6 100644 --- a/packages/insomnia/src/routes/git-migration.$.tsx +++ b/packages/insomnia/src/routes/git-migration.$.tsx @@ -49,6 +49,15 @@ const MigrationView = () => { const...
[ "packages/insomnia/src/routes/git-migration.$.tsx" ]
[ { "comment": "`postMigrationPath` reads `window.localStorage` during render. This route is server-rendered (see entry.server.tsx), so referencing `window` will throw during SSR even though the value is only needed client-side after migration completes. Guard the access (or compute it lazily when rendering the c...
true
Kong/insomnia
10,047
issue_to_patch
Fix/pokemon api
<!-- Please open an [Issue](https://github.com/kong/insomnia/issues/new) first to discuss new features or non-trivial changes. Please provide as much detail as possible on the change as possible including general description, implementation details, potential shortcomings, etc. If this PR closes an issue, please ...
4d0901f111a04e0f458059853282998f43680d58
8754d2da9f2bfd4ee7703ea93415ec4a677db1e7
diff --git a/packages/insomnia/src/ui/components/first-request-creation.tsx b/packages/insomnia/src/ui/components/first-request-creation.tsx index 50e613c78fb..9f61de73f2f 100644 --- a/packages/insomnia/src/ui/components/first-request-creation.tsx +++ b/packages/insomnia/src/ui/components/first-request-creation.tsx @@ ...
[ "packages/insomnia/src/ui/components/first-request-creation.tsx" ]
[ { "comment": "The created request name (`List pokemon`) is now inconsistent with the Quick Start item label (`List a pokemon`) later in this file, and the new URL lists multiple Pokémon rather than a single one. Align the label/name (and wording) so the UI text matches what the request actually does.", "pat...
true
Kong/insomnia
10,047
comment_to_fix
Fix/pokemon api
The created request name (`List pokemon`) is now inconsistent with the Quick Start item label (`List a pokemon`) later in this file, and the new URL lists multiple Pokémon rather than a single one. Align the label/name (and wording) so the UI text matches what the request actually does.
4d0901f111a04e0f458059853282998f43680d58
8754d2da9f2bfd4ee7703ea93415ec4a677db1e7
diff --git a/packages/insomnia/src/ui/components/first-request-creation.tsx b/packages/insomnia/src/ui/components/first-request-creation.tsx index 50e613c78fb..9f61de73f2f 100644 --- a/packages/insomnia/src/ui/components/first-request-creation.tsx +++ b/packages/insomnia/src/ui/components/first-request-creation.tsx @@ ...
[ "packages/insomnia/src/ui/components/first-request-creation.tsx" ]
[ { "comment": "The created request name (`List pokemon`) is now inconsistent with the Quick Start item label (`List a pokemon`) later in this file, and the new URL lists multiple Pokémon rather than a single one. Align the label/name (and wording) so the UI text matches what the request actually does.", "pat...
true
Kong/insomnia
10,046
issue_to_patch
fix: load plugins with available require() and align cloud sync mocks with real API
- Fix internal plugin loading failures seen in e2e tests - Matches cloud-sync mock with real API output instead of an empty body Mitigates these two oft-seen logs in test output: ``` [renderer console.error] 20:09:03.441 › Error occurred in handler for 'sync.invoke': Error: Failed to query branches: no data retur...
072f16df9b2738d948e94ffba0bd8b93997a894d
7f98ea7238ccc5e1174a4e72b795dce81e044bb4
diff --git a/packages/insomnia-smoke-test/server/cloud-sync-api.ts b/packages/insomnia-smoke-test/server/cloud-sync-api.ts index 3ce4571d85a..eaad1a49d32 100644 --- a/packages/insomnia-smoke-test/server/cloud-sync-api.ts +++ b/packages/insomnia-smoke-test/server/cloud-sync-api.ts @@ -14,9 +14,7 @@ export interface AESM...
[ "packages/insomnia-smoke-test/server/cloud-sync-api.ts", "packages/insomnia/src/plugins/index.ts" ]
[ { "comment": "`getNodeRequire()` currently treats any truthy `global.require` as usable. In the failure mode shown in the PR description (`global.require is not a function`), this helper will still return the non-function value and the subsequent call will throw again. It should only prefer `global.require` whe...
true
Kong/insomnia
10,046
comment_to_fix
fix: load plugins with available require() and align cloud sync mocks with real API
`getNodeRequire()` currently treats any truthy `global.require` as usable. In the failure mode shown in the PR description (`global.require is not a function`), this helper will still return the non-function value and the subsequent call will throw again. It should only prefer `global.require` when it's actually callab...
072f16df9b2738d948e94ffba0bd8b93997a894d
7f98ea7238ccc5e1174a4e72b795dce81e044bb4
diff --git a/packages/insomnia/src/plugins/index.ts b/packages/insomnia/src/plugins/index.ts index 18cc66cf279..59fc492137c 100644 --- a/packages/insomnia/src/plugins/index.ts +++ b/packages/insomnia/src/plugins/index.ts @@ -32,6 +32,20 @@ export function _testOnlySetPlugins(p: Plugin[] | null) { plugins = p; } +...
[ "packages/insomnia/src/plugins/index.ts" ]
[ { "comment": "`getNodeRequire()` currently treats any truthy `global.require` as usable. In the failure mode shown in the PR description (`global.require is not a function`), this helper will still return the non-function value and the subsequent call will throw again. It should only prefer `global.require` whe...
true
Kong/insomnia
10,045
issue_to_patch
fix(e2e): prevent feature-flag mock leak from breaking export tests
Mock `/features` replaces the whole object, so tests that toggle one flag drop `bulkImport` for later tests, crashing the Preferences render and flaking the export tests. - merge partial overrides over the defaults in the mock - guard `features.bulkImport?.enabled` - harden `waitForExportFiles` against a read-befo...
002ae2f9f30c658359aaeebf7a94da5750db46db
752fdd368ebb563c6e191ecedb0416ff5ada9fce
diff --git a/packages/insomnia-smoke-test/playwright/utils/file-operations.ts b/packages/insomnia-smoke-test/playwright/utils/file-operations.ts index 67ee56206a69..e364a326e663 100644 --- a/packages/insomnia-smoke-test/playwright/utils/file-operations.ts +++ b/packages/insomnia-smoke-test/playwright/utils/file-operati...
[ "packages/insomnia-smoke-test/playwright/utils/file-operations.ts", "packages/insomnia-smoke-test/server/insomnia-api.ts", "packages/insomnia/src/ui/components/settings/import-export.tsx" ]
[]
true