repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
turanszkij/WickedEngine | 1,608 | comment_to_fix | Editor: add drag-and-drop entity reordering in hierarchy tree (#1084) | `entity_user_order` is never pruned/cleared when the current scene changes or when entities/parents are deleted. Over a long editor session this can retain stale entries indefinitely (and can misapply ordering if entity IDs are reused). Consider cleaning the map in `RefreshEntityTree()` using `entitytree_temp_items` (d... | adc81ce7743cd371b9939cc3c83207e769e3f045 | b3d89f69acb294afafff07df8037564cf56858ac | diff --git a/Editor/ComponentsWindow.cpp b/Editor/ComponentsWindow.cpp
index 04ef5eaf23..239c9e9233 100644
--- a/Editor/ComponentsWindow.cpp
+++ b/Editor/ComponentsWindow.cpp
@@ -122,6 +122,122 @@ void ComponentsWindow::Create(EditorComponent* _editor)
entityTree.OnDoubleClick([this](wi::gui::EventArgs args) {
edi... | [
"Editor/ComponentsWindow.cpp"
] | [
{
"comment": "`entity_user_order` is never pruned/cleared when the current scene changes or when entities/parents are deleted. Over a long editor session this can retain stale entries indefinitely (and can misapply ordering if entity IDs are reused). Consider cleaning the map in `RefreshEntityTree()` using `ent... | true | ||
turanszkij/WickedEngine | 1,608 | comment_to_fix | Editor: add drag-and-drop entity reordering in hierarchy tree (#1084) | The drag “ghost” label is rendered after applying the list-area scissor (`rect_without_scrollbar`), so it will be clipped to the list rectangle. If the intent is a cursor-following ghost that can extend outside the list, restore the widget scissor (or disable scissor) before drawing the ghost, while keeping the drop in... | adc81ce7743cd371b9939cc3c83207e769e3f045 | b3d89f69acb294afafff07df8037564cf56858ac | diff --git a/WickedEngine/wiGUI.cpp b/WickedEngine/wiGUI.cpp
index 28d40fe559..d5db1a534b 100644
--- a/WickedEngine/wiGUI.cpp
+++ b/WickedEngine/wiGUI.cpp
@@ -5772,6 +5772,29 @@ namespace wi::gui
Hitbox2D itemlist_box = GetHitbox_ListArea();
+ // Finalize drag-and-drop when mouse is released
+ if (onReorder... | [
"WickedEngine/wiGUI.cpp"
] | [
{
"comment": "The drag “ghost” label is rendered after applying the list-area scissor (`rect_without_scrollbar`), so it will be clipped to the list rectangle. If the intent is a cursor-following ghost that can extend outside the list, restore the widget scissor (or disable scissor) before drawing the ghost, whi... | true | ||
turanszkij/WickedEngine | 1,605 | issue_to_patch | ensure jobsystem::ShutDown is called at exit | This prevents difficult to debug memory corruption if a developer forgot to call it explicitly (would never happen to me, of course *ahem*) | 71ab6cea5dbb6db81d208d6fb5904c8b54554143 | fef9bebd5686ec0e73e93af878421adf66ccd2e2 | diff --git a/WickedEngine/wiJobSystem.cpp b/WickedEngine/wiJobSystem.cpp
index 440c850659..3c94ac09c5 100644
--- a/WickedEngine/wiJobSystem.cpp
+++ b/WickedEngine/wiJobSystem.cpp
@@ -430,6 +430,8 @@ namespace wi::jobsystem
}
wilog("wi::jobsystem Initialized with %d cores in %.2f ms\n\tHigh priority threads: %d\... | [
"WickedEngine/wiJobSystem.cpp"
] | [] | true | ||
turanszkij/WickedEngine | 1,604 | issue_to_patch | Allow aritmentic operations on numeric inputs
For numeric inputs in the Editor, it would be cool if the user could insert arithmetic operations, for example, if the input has value `10` and the user types `* 2` (`10 * 2`) then the value would be `20` when the user commits the change (presses enter). | Add arithmetic expression evaluation to TextInputField | Numeric input fields in the editor now evaluate arithmetic expressions when the user presses Enter. For example, if the field shows '10' and the user appends '* 2' to get '10 * 2', the committed value becomes 20.
Supported operators: +, -, *, /, parentheses, unary +/-, floating-point literals and scientific notation... | 3cffab6843f530ce2583454f21dfd11bad42b58d | 8b93723c65296c332b43edbbdcdc62879c30bf40 | diff --git a/WickedEngine/wiGUI.cpp b/WickedEngine/wiGUI.cpp
index 7f92023f6f..28d40fe559 100644
--- a/WickedEngine/wiGUI.cpp
+++ b/WickedEngine/wiGUI.cpp
@@ -1647,6 +1647,77 @@ namespace wi::gui
}
return false;
}
+
+ // Simple recursive-descent arithmetic expression evaluator.
+ // Supports: +, -, *, /, parent... | [
"WickedEngine/wiGUI.cpp"
] | [
{
"comment": "Parentheses are not validated: if the input contains an opening '(' without a matching closing ')', parsePrimary() returns the inner expression without marking the parse invalid. This makes inputs like \"(1+2\" evaluate and commit as numeric instead of falling back to raw-string behavior. Set vali... | true | |
turanszkij/WickedEngine | 1,604 | comment_to_fix | Add arithmetic expression evaluation to TextInputField | Parentheses are not validated: if the input contains an opening '(' without a matching closing ')', parsePrimary() returns the inner expression without marking the parse invalid. This makes inputs like "(1+2" evaluate and commit as numeric instead of falling back to raw-string behavior. Set valid=false (and ideally sto... | 3cffab6843f530ce2583454f21dfd11bad42b58d | 8b93723c65296c332b43edbbdcdc62879c30bf40 | diff --git a/WickedEngine/wiGUI.cpp b/WickedEngine/wiGUI.cpp
index 7f92023f6f..28d40fe559 100644
--- a/WickedEngine/wiGUI.cpp
+++ b/WickedEngine/wiGUI.cpp
@@ -1647,6 +1647,77 @@ namespace wi::gui
}
return false;
}
+
+ // Simple recursive-descent arithmetic expression evaluator.
+ // Supports: +, -, *, /, parent... | [
"WickedEngine/wiGUI.cpp"
] | [
{
"comment": "Parentheses are not validated: if the input contains an opening '(' without a matching closing ')', parsePrimary() returns the inner expression without marking the parse invalid. This makes inputs like \"(1+2\" evaluate and commit as numeric instead of falling back to raw-string behavior. Set vali... | true | ||
turanszkij/WickedEngine | 1,603 | issue_to_patch | better ocean tiling in distance with perlin noise | 45c63551ee024b99620b2b2946badd04dc9e680d | 74da6651a4d4827afbca12c8d3af892aeba694cd | diff --git a/WickedEngine/perlin.h b/WickedEngine/perlin.h
new file mode 100644
index 0000000000..cc66371e21
--- /dev/null
+++ b/WickedEngine/perlin.h
@@ -0,0 +1,1368 @@
+const unsigned char perlin[] = {
+144,173,144,175,0,0,168,49,32,43,128,174,0,0,192,47,4,51,136,44,0,0,72,174,132,48,196,48,0,0,168,179,
+136,46,196,4... | [
"WickedEngine/perlin.h",
"WickedEngine/shaders/ShaderInterop_Ocean.h",
"WickedEngine/shaders/oceanSurfacePS.hlsl",
"WickedEngine/shaders/oceanSurfaceVS.hlsl",
"WickedEngine/wiOcean.cpp",
"WickedEngine/wiVersion.cpp"
] | [] | true | |||
turanszkij/WickedEngine | 1,598 | issue_to_patch | Add UTF-8 compile option for MSVC (to prevent compilation breaks depending on the building computer locale) | Hi!~
Tried to build and was getting a lot of **"newline in constant"** inside **wiInput.cpp**, complaining specifically about the lines with arrows (→) and other uncommon characters inside strings, so added this (**/utf-8**) to make sure **MSVC** will treat the source file as UTF-8, doesn't matter what locale the us... | c5bc332fd96eef92e142fd556686719ca843b004 | 9c5961178a8adc9a53c4a8362527108a0b508d5d | diff --git a/CMakeLists.txt b/CMakeLists.txt
index 8e453c7a7f..a2c88d0d1a 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -121,6 +121,7 @@ endif()
if (MSVC)
add_compile_options(
+ /utf-8
/W3 # warning level 3
/MP # multi-processor compilation
/EHsc- # exceptions disabled
diff --g... | [
"CMakeLists.txt",
"Editor/Editor_Windows.vcxproj",
"Samples/Example_ImGui/Example_ImGui.vcxproj",
"Samples/Example_ImGui_Docking/Example_ImGui_Docking.vcxproj",
"Samples/Template_Windows/Template_Windows.vcxproj",
"Samples/Tests/Tests.vcxproj",
"WickedEngine/OfflineShaderCompiler.vcxproj",
"WickedEngi... | [] | diff --git a/Samples/Tests/Tests.vcxproj b/Samples/Tests/Tests.vcxproj
index 08eab5020a..3ae3e74042 100644
--- a/Samples/Tests/Tests.vcxproj
+++ b/Samples/Tests/Tests.vcxproj
@@ -113,7 +113,7 @@
<ConformanceMode>true</ConformanceMode>
<LanguageStandard>stdcpp17</LanguageStandard>
<EnableEnhancedIns... | true | |
turanszkij/WickedEngine | 1,594 | issue_to_patch | Only write config file if content changed | This is mainly done to prevent triggering VCS changes between editor and game sessions. | 4a1453e795a1228720d8aabeb2d07913f191a6f7 | 79dfe11ac60916b5c5c5f11c53c6af56b57b8769 | diff --git a/WickedEngine/wiConfig.cpp b/WickedEngine/wiConfig.cpp
index a19df36be4..6d14119083 100644
--- a/WickedEngine/wiConfig.cpp
+++ b/WickedEngine/wiConfig.cpp
@@ -483,7 +483,32 @@ namespace wi::config
}
}
std::scoped_lock lck(locker);
- wi::helper::FileWrite(filename, (const uint8_t*)text.c_str(), te... | [
"WickedEngine/wiConfig.cpp"
] | [] | true | ||
turanszkij/WickedEngine | 1,587 | issue_to_patch | Fix thumbnail rendering | Fix an issue where the thumbnail for scenes with a single root entity would fail to render. Also prevent invisible objects from inflating the bounds and producing a poorly framed thumbnail. | 84b800bbc280bacabe0e0fa3cac2c6f876a22d67 | 70e3c446739a4d53ca1a5685b769680284ba0764 | diff --git a/Editor/Editor.cpp b/Editor/Editor.cpp
index f8883a4452..43ab20d0ea 100644
--- a/Editor/Editor.cpp
+++ b/Editor/Editor.cpp
@@ -5692,10 +5692,6 @@ void EditorComponent::SaveAs()
Texture EditorComponent::CreateThumbnail(Texture texture, uint32_t target_width, uint32_t target_height, bool mipmaps) const
{
... | [
"Editor/Editor.cpp"
] | [] | true | ||
turanszkij/WickedEngine | 1,586 | issue_to_patch | Fix active state of text input field | Fix multiple GUI focus issues where text input field would get stuck in active/typing state. | 84b800bbc280bacabe0e0fa3cac2c6f876a22d67 | 21b2e2838bdd2701c593162ff4f5d2c828a34d30 | diff --git a/WickedEngine/wiGUI.cpp b/WickedEngine/wiGUI.cpp
index 7c1ca076ec..578bf9c0c9 100644
--- a/WickedEngine/wiGUI.cpp
+++ b/WickedEngine/wiGUI.cpp
@@ -199,6 +199,26 @@ namespace wi::gui
}
if (IsTyping())
{
+ // When typing is active but the user clicks outside all GUI widgets,
+ // allow the click ... | [
"WickedEngine/wiGUI.cpp",
"WickedEngine/wiGUI.h"
] | [] | true | ||
turanszkij/WickedEngine | 1,581 | issue_to_patch | updated third party gfx headers | 43452a6a4d1c1882f0a36d14f7f39f2edfc92ca0 | 3ff6191c1b233a50ea5a03e04d2f0bdf45c8b233 | diff --git a/WickedEngine/Utility/D3D12MemAlloc.h b/WickedEngine/Utility/D3D12MemAlloc.h
index de809103c3..32fe908c24 100644
--- a/WickedEngine/Utility/D3D12MemAlloc.h
+++ b/WickedEngine/Utility/D3D12MemAlloc.h
@@ -1,5 +1,5 @@
//
-// Copyright (c) 2019-2025 Advanced Micro Devices, Inc. All rights reserved.
+// Copyrig... | [
"WickedEngine/Utility/D3D12MemAlloc.h",
"WickedEngine/Utility/dx12/D3D12TokenizedProgramFormat.hpp",
"WickedEngine/Utility/dx12/d3d12.h",
"WickedEngine/Utility/dx12/d3d12compatibility.h",
"WickedEngine/Utility/dx12/d3d12sdklayers.h",
"WickedEngine/Utility/dx12/d3d12shader.h",
"WickedEngine/Utility/dx12/... | [] | true | |||
turanszkij/WickedEngine | 1,585 | issue_to_patch | Implement mesh recenter to top | Add a new _Recenter to Top_ function to mesh component as a counterpart to the existing _Recenter to Bottom_ functionality. | 43452a6a4d1c1882f0a36d14f7f39f2edfc92ca0 | 50536b7b028c450dea3dd27c296df0772813530d | diff --git a/Editor/MeshWindow.cpp b/Editor/MeshWindow.cpp
index f1d61769ac..72f78989f6 100644
--- a/Editor/MeshWindow.cpp
+++ b/Editor/MeshWindow.cpp
@@ -327,6 +327,14 @@ void MeshWindow::Create(EditorComponent* _editor)
}));
AddWidget(&recenterButton);
+ recenterToTopButton.Create("Recenter to Top");
+ recenter... | [
"Editor/MeshWindow.cpp",
"Editor/MeshWindow.h",
"WickedEngine/wiScene_Components.cpp",
"WickedEngine/wiScene_Components.h"
] | [] | true | ||
turanszkij/WickedEngine | 1,584 | issue_to_patch | Implement key repeat support for text input field | Implement key repeat functionality for arrow keys (left/right) and delete key in text input fields. Previously, holding these keys would only move the cursor once or delete one character. | 43452a6a4d1c1882f0a36d14f7f39f2edfc92ca0 | 11b3ff979b4dbda6d94e41b609d6ab6439534746 | diff --git a/WickedEngine/wiGUI.cpp b/WickedEngine/wiGUI.cpp
index ee49695a77..2f23a7dfd7 100644
--- a/WickedEngine/wiGUI.cpp
+++ b/WickedEngine/wiGUI.cpp
@@ -1596,6 +1596,37 @@ namespace wi::gui
bool input_updated = false;
bool doubleclick_select = false;
wi::Timer caret_timer;
+ wi::Timer key_repeat_timer;
+ wi... | [
"WickedEngine/wiGUI.cpp"
] | [] | true | ||
turanszkij/WickedEngine | 1,583 | issue_to_patch | Fix root node GLTF export | When exporting scenes to GLTF\GLB format, all transforms were being added to the scene's root node list, regardless of whether they were children in the hierarchy. This caused Blender's importer to instantiate and link the same objects multiple times, resulting in "Object already in collection" errors. The fix ensures ... | 43452a6a4d1c1882f0a36d14f7f39f2edfc92ca0 | a7d6ab88776127dc918bfe39b68cdf18151ee283 | diff --git a/Editor/ModelImporter_GLTF.cpp b/Editor/ModelImporter_GLTF.cpp
index f8e6b5f9ff..b01af81044 100644
--- a/Editor/ModelImporter_GLTF.cpp
+++ b/Editor/ModelImporter_GLTF.cpp
@@ -4442,7 +4442,10 @@ void ExportModel_GLTF(const std::string& filename, Scene& scene)
auto nameComponent = wiscene.names.GetComponen... | [
"Editor/ModelImporter_GLTF.cpp"
] | [] | true | ||
turanszkij/WickedEngine | 1,582 | issue_to_patch | Fix combo box filter scroll position | Fix a bug where combo box items would not appear in search results if they were located before the current scroll position. | 43452a6a4d1c1882f0a36d14f7f39f2edfc92ca0 | fb6f68e35f053cad4fadc36f8e6ea819f0aad7f8 | diff --git a/WickedEngine/wiGUI.cpp b/WickedEngine/wiGUI.cpp
index ee49695a77..82105e134d 100644
--- a/WickedEngine/wiGUI.cpp
+++ b/WickedEngine/wiGUI.cpp
@@ -2912,7 +2912,13 @@ namespace wi::gui
filter.translation_local.x = drop_x;
filter.translation_local.y = translation.y + scale.y + drop_offset - combo_... | [
"WickedEngine/wiGUI.cpp"
] | [] | true | ||
turanszkij/WickedEngine | 1,580 | issue_to_patch | update miniaudio to 0.11.25 | 21eaeed9dad51b7336eaeca1cc52a394c220c9ff | f89e8e56d1e969a897b300bc4e803bdf73a7afab | diff --git a/WickedEngine/Utility/miniaudio.h b/WickedEngine/Utility/miniaudio.h
index 24e676bb26..c6d493ee81 100644
--- a/WickedEngine/Utility/miniaudio.h
+++ b/WickedEngine/Utility/miniaudio.h
@@ -1,6 +1,6 @@
/*
Audio playback and capture library. Choice of public domain or MIT-0. See license statements at the end ... | [
"WickedEngine/Utility/miniaudio.h"
] | [] | true | |||
turanszkij/WickedEngine | 1,579 | issue_to_patch | Radix sort | 8202b1a10e7d7ec3d25132ed0659714ad17f853e | 86c945c89c3dc96bac6f0337cb7841168ef54a63 | diff --git a/WickedEngine/WickedEngine.xcodeproj/project.pbxproj b/WickedEngine/WickedEngine.xcodeproj/project.pbxproj
index 2f22f951de..4168e17519 100644
--- a/WickedEngine/WickedEngine.xcodeproj/project.pbxproj
+++ b/WickedEngine/WickedEngine.xcodeproj/project.pbxproj
@@ -347,8 +347,6 @@
1ED576E12F0115B40032621C /... | [
"WickedEngine/WickedEngine.xcodeproj/project.pbxproj",
"WickedEngine/offlineshadercompiler.cpp",
"WickedEngine/shaders/ShaderInterop.h",
"WickedEngine/shaders/ShaderInterop_GPUSortLib.h",
"WickedEngine/shaders/Shaders_SOURCE.vcxitems",
"WickedEngine/shaders/Shaders_SOURCE.vcxitems.filters",
"WickedEngin... | [] | true | |||
turanszkij/WickedEngine | 1,578 | issue_to_patch | Fix entity tree selection focus | Defer the selection focus operation until after the entity tree rebuild is complete. In heavy scenes, when selecting an entity in the viewport, the entity tree may not scroll to reveal the selected entity because it refreshes immediately and rebuilds the tree. | 7aa350c0b9323ffa5ceb3927044cddfa9853839a | d39e3a917c1a0312d028799a610aca66dfe1ad04 | diff --git a/Editor/ComponentsWindow.cpp b/Editor/ComponentsWindow.cpp
index f0904a83f3..04ef5eaf23 100644
--- a/Editor/ComponentsWindow.cpp
+++ b/Editor/ComponentsWindow.cpp
@@ -1418,6 +1418,12 @@ void ComponentsWindow::RefreshEntityTree()
entitytree_added_items.clear();
entitytree_opened_items.clear();
+
+ if (... | [
"Editor/ComponentsWindow.cpp",
"Editor/ComponentsWindow.h",
"Editor/Editor.cpp"
] | [] | true | ||
turanszkij/WickedEngine | 1,577 | issue_to_patch | Flip normals in mesh settings cannot be undone/redone
Flip normals in mesh settings cannot be undone/redone.
<img width="1989" height="1450" alt="Image" src="https://github.com/user-attachments/assets/1353962a-31a3-406d-a166-3d07b79c8a9e" /> | Implement undo/redo for mesh operations | Fixes #1426, #1425, #1424, #1423, and #1428 | 7aa350c0b9323ffa5ceb3927044cddfa9853839a | efb474a5a8ea2ce824e727a013c2aef52e1d245d | diff --git a/Editor/MeshWindow.cpp b/Editor/MeshWindow.cpp
index 5f0549d3c3..f1d61769ac 100644
--- a/Editor/MeshWindow.cpp
+++ b/Editor/MeshWindow.cpp
@@ -258,14 +258,34 @@ void MeshWindow::Create(EditorComponent* _editor)
return [this, func] (auto args) {
wi::scene::Scene& scene = editor->GetCurrentScene();
... | [
"Editor/MeshWindow.cpp"
] | [] | true | |
turanszkij/WickedEngine | 1,575 | issue_to_patch | gaussian splat global sorting | 712e19524e240d5cb4dd7998d4affb78308576c9 | f83b4525f692861e2f8282f9aae5bd85b850783c | diff --git a/WickedEngine/shaders/ShaderInterop.h b/WickedEngine/shaders/ShaderInterop.h
index 0c591138ec..57f9026d41 100644
--- a/WickedEngine/shaders/ShaderInterop.h
+++ b/WickedEngine/shaders/ShaderInterop.h
@@ -110,7 +110,6 @@ struct IndirectDispatchArgs
#define CBSLOT_FSR 2
#define CBSLOT_TRAILRENDERER ... | [
"WickedEngine/shaders/ShaderInterop.h",
"WickedEngine/shaders/ShaderInterop_GaussianSplat.h",
"WickedEngine/shaders/Shaders_SOURCE.vcxitems.filters",
"WickedEngine/shaders/gaussian_splatCS.hlsl",
"WickedEngine/shaders/gaussian_splatVS.hlsl",
"WickedEngine/shaders/gaussian_splat_indirectCS.hlsl",
"Wicked... | [] | true | |||
turanszkij/WickedEngine | 1,574 | issue_to_patch | gaussian splat multicamera render into cubemap | 4d2f91afc7debd30666da575886ef1ec22d38352 | 9b1869941db96f675a80ff2b9e920b13c33675d1 | diff --git a/WickedEngine/offlineshadercompiler.cpp b/WickedEngine/offlineshadercompiler.cpp
index 981a350a4a..3fc37dab03 100644
--- a/WickedEngine/offlineshadercompiler.cpp
+++ b/WickedEngine/offlineshadercompiler.cpp
@@ -223,6 +223,7 @@ wi::vector<ShaderEntry> shaders = {
{"depth_pyramidCS", wi::graphics::ShaderSta... | [
"WickedEngine/offlineshadercompiler.cpp",
"WickedEngine/shaders/ShaderInterop_GaussianSplat.h",
"WickedEngine/shaders/Shaders_SOURCE.vcxitems",
"WickedEngine/shaders/Shaders_SOURCE.vcxitems.filters",
"WickedEngine/shaders/gaussian_splatCS.hlsl",
"WickedEngine/shaders/gaussian_splatPS.hlsl",
"WickedEngin... | [] | true | |||
turanszkij/WickedEngine | 1,573 | issue_to_patch | Sort entities by depth in the hierarchy component | Sort the parent combo box entries by hierarchy depth: root entities first, then depth-1 children, then depth-2, etc. with alphabetical name sorting. This gives a more organized and convenient dropdown for selecting parent entities. | 54af19d00467e387c6a24fcd5a0635e16efd5708 | b91374facd58ed6c7d818203963ee08541c2c388 | diff --git a/Editor/HierarchyWindow.cpp b/Editor/HierarchyWindow.cpp
index 10d3059082..763c41e813 100644
--- a/Editor/HierarchyWindow.cpp
+++ b/Editor/HierarchyWindow.cpp
@@ -73,11 +73,36 @@ void HierarchyWindow::SetEntity(Entity entity)
entities.clear();
scene.FindAllEntities(entities);
+ // Sort entities by hie... | [
"Editor/HierarchyWindow.cpp"
] | [] | true | ||
turanszkij/WickedEngine | 1,572 | issue_to_patch | Implement LODs deletion button | Implements the "Delete LODs" button right under "Generate LODs". Keeps only the `LOD0` subsets and rebuilds render data. | 54af19d00467e387c6a24fcd5a0635e16efd5708 | 457963839c33831f18440847869053cf2f81802e | diff --git a/Editor/MeshWindow.cpp b/Editor/MeshWindow.cpp
index 4273afd8e5..5f0549d3c3 100644
--- a/Editor/MeshWindow.cpp
+++ b/Editor/MeshWindow.cpp
@@ -814,8 +814,8 @@ void MeshWindow::Create(EditorComponent* _editor)
}));
AddWidget(&morphTargetSlider);
- lodgenButton.Create("LOD Gen");
- lodgenButton.SetToolt... | [
"Editor/MeshWindow.cpp",
"Editor/MeshWindow.h"
] | [] | true | ||
turanszkij/WickedEngine | 1,571 | issue_to_patch | Gaussian splatting | d32904516f4a0ff51b8127fa316b68b377c253d0 | 5f5fb45594371060ce625a18ee50d850f7f7e221 | diff --git a/Content/Documentation/WickedEditor-Manual.pdf b/Content/Documentation/WickedEditor-Manual.pdf
index 3a297bee06..9f37470426 100644
Binary files a/Content/Documentation/WickedEditor-Manual.pdf and b/Content/Documentation/WickedEditor-Manual.pdf differ
diff --git a/Editor/ComponentsWindow.cpp b/Editor/Compone... | [
"Content/Documentation/WickedEditor-Manual.pdf",
"Editor/ComponentsWindow.cpp",
"Editor/ComponentsWindow.h",
"Editor/ContentBrowserWindow.cpp",
"Editor/Editor.cpp",
"Editor/Editor.xcodeproj/project.pbxproj",
"Editor/Editor_SOURCE.vcxitems",
"Editor/Editor_SOURCE.vcxitems.filters",
"Editor/GaussianSp... | [] | true | |||
turanszkij/WickedEngine | 1,570 | issue_to_patch | Fix texture resolution and mip levels display | The material window shows the current streaming resolution of textures, not the actual full resolution. | 4626aabe2bbd347d5bf1f5ac8c8c8af6c931e137 | eccc146af2ab8849bb48fbe778a7166d03ef3fa8 | diff --git a/Editor/MaterialWindow.cpp b/Editor/MaterialWindow.cpp
index 4433e0f83d..6cff4e9b4a 100644
--- a/Editor/MaterialWindow.cpp
+++ b/Editor/MaterialWindow.cpp
@@ -5,9 +5,19 @@ using namespace wi::graphics;
using namespace wi::ecs;
using namespace wi::scene;
-void AddTexturePropertiesString(const wi::graphic... | [
"Editor/MaterialWindow.cpp",
"WickedEngine/wiHelper.cpp",
"WickedEngine/wiResourceManager.cpp",
"WickedEngine/wiResourceManager.h"
] | [] | true | ||
turanszkij/WickedEngine | 1,569 | issue_to_patch | Fix editor doesn't restore prop region | After loading a scene, the combo box defaults to "Base" instead of the loaded prop region value. | 95059d4fc31d33c338d35c5522848ba7e235cf20 | e8710efd29353e4e63d5fa6976cdd0aeef82eabe | diff --git a/Editor/TerrainWindow.cpp b/Editor/TerrainWindow.cpp
index 66a0652743..39ee91293f 100644
--- a/Editor/TerrainWindow.cpp
+++ b/Editor/TerrainWindow.cpp
@@ -366,6 +366,7 @@ PropWindow::PropWindow(wi::terrain::Terrain* terrain, wi::terrain::Prop* prop, w
regionCombo.AddItem("Slopes", 1);
regionCombo.AddIte... | [
"Editor/TerrainWindow.cpp"
] | [] | true | ||
turanszkij/WickedEngine | 1,567 | issue_to_patch | Implement optimization of the physics broadphase for terrain props | Jolt’s broadphase uses a fixed-size node pool for physics bodies. In scenarios such as terrain generation, where many props are likely to have collision shapes, we should periodically compact the pool to free stale nodes. This allows new bodies to be allocated and prevents the engine from forcefully terminating when th... | 01f7c9de220ef7551af76bc27b2b0b8b972a5369 | 832b932a4a057664a57822fb9472af20bbf07f2b | diff --git a/WickedEngine/wiPhysics.h b/WickedEngine/wiPhysics.h
index d7dfa3d76f..6b600a4472 100644
--- a/WickedEngine/wiPhysics.h
+++ b/WickedEngine/wiPhysics.h
@@ -199,6 +199,9 @@ namespace wi::physics
);
void ActivateAllRigidBodies(wi::scene::Scene& scene);
+ // Request broadphase optimization to reclaim node... | [
"WickedEngine/wiPhysics.h",
"WickedEngine/wiPhysics_BindLua.cpp",
"WickedEngine/wiPhysics_BindLua.h",
"WickedEngine/wiPhysics_Jolt.cpp",
"WickedEngine/wiTerrain.cpp"
] | [] | true | ||
turanszkij/WickedEngine | 1,568 | issue_to_patch | Implement persistence for the profiler window's size | Save and restore the profiler window’s size and position between editor sessions. | 01f7c9de220ef7551af76bc27b2b0b8b972a5369 | 6f7f74f7554f1042390f6bc98bc0b6c026c8e9d5 | diff --git a/Editor/ProfilerWindow.cpp b/Editor/ProfilerWindow.cpp
index 86b8a8495f..e094736d95 100644
--- a/Editor/ProfilerWindow.cpp
+++ b/Editor/ProfilerWindow.cpp
@@ -33,8 +33,27 @@ void ProfilerWindow::Create(EditorComponent* _editor)
profilerWidget.SetSize(XMFLOAT2(200, 1000));
AddWidget(&profilerWidget);
-... | [
"Editor/ProfilerWindow.cpp"
] | [] | true | ||
turanszkij/WickedEngine | 1,563 | issue_to_patch | Fix building with PIC | This fixes building with PIC Enabled | a09c0e3154492f12989d8b96a23211f20888c7f1 | 4904229c04306ac0518f5b629c2d63ff7e0188ad | diff --git a/CMakeLists.txt b/CMakeLists.txt
index ca1b6071b9..fe62f332f2 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -79,7 +79,7 @@ endif()
set(CMAKE_CXX_STANDARD 17)
set(CMAKE_CXX_STANDARD_REQUIRED ON)
set(CMAKE_CXX_EXTENSIONS OFF)
-set(CMAKE_POSITION_INDEPENDENT_CODE WICKED_PIC)
+set(CMAKE_POSITION_INDEPE... | [
"CMakeLists.txt"
] | [] | true | ||
turanszkij/WickedEngine | 1,564 | issue_to_patch | Add toggle for RTTI | When using the engine in combination with the JVM (Java virtual machine), you need RTTI. This patch adds an flag to enable the rtti | a09c0e3154492f12989d8b96a23211f20888c7f1 | 33f221e1e9e6a53fc326cfebf1f3fe2867d618e7 | diff --git a/CMakeLists.txt b/CMakeLists.txt
index ca1b6071b9..a34489d8a3 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -29,6 +29,7 @@ option(WICKED_TESTS "Build WickedEngine tests" ON)
option(WICKED_IMGUI_EXAMPLE "Build WickedEngine imgui example" ON)
option(WICKED_ENABLE_IPO "Enable IPO/LTO in non-debug build... | [
"CMakeLists.txt"
] | [] | true | ||
tursodatabase/libsql | 2,248 | issue_to_patch | libsql-sqlite3: Make libsql_stmt_interrupt() abort an in-flight step | libsql_stmt_interrupt() set a per-statement isInterrupted flag, but the
VDBE execution loop only ever checked the connection-wide
db->u1.isInterrupted. A statement already executing inside sqlite3_step()
therefore ran to completion regardless of the request; the flag was only
observed at the next step() entry.
C... | 61d629a0ed06ea5db05e26d90e0524e0827a0f4e | f29dd3a8c3681dad9ba6f8244dea86f97d985430 | diff --git a/Cargo.lock b/Cargo.lock
index 9d411cd66c..c078f4b6d3 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2899,7 +2899,7 @@ dependencies = [
[[package]]
name = "libsql"
-version = "0.10.0-pre.2"
+version = "0.10.0-pre.3"
dependencies = [
"anyhow",
"async-stream",
@@ -2959,7 +2959,7 @@ dependencies = [
... | [
"Cargo.lock",
"libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c",
"libsql-ffi/bundled/src/sqlite3.c",
"libsql-sqlite3/Makefile.in",
"libsql-sqlite3/main.mk",
"libsql-sqlite3/src/test1.c",
"libsql-sqlite3/src/vdbe.c",
"libsql-sqlite3/src/vdbeapi.c",
"libsql-sqlite3/src/vdbeaux.c",
"libsql-sq... | [] | diff --git a/libsql-sqlite3/test/interruptstmt.test b/libsql-sqlite3/test/interruptstmt.test
new file mode 100644
index 0000000000..46bf8b37b1
--- /dev/null
+++ b/libsql-sqlite3/test/interruptstmt.test
@@ -0,0 +1,109 @@
+# 2026 libsql
+#
+# The author disclaims copyright to this source code. In place of
+# a legal not... | true | |
tursodatabase/libsql | 2,234 | issue_to_patch | libsql-server: fix duplicated "the" in doc-comments | Two one-line typo fixes for duplicated "the" in `libsql-server` doc-comments:
- `libsql-server/src/main.rs` — "By default, the the period is 30 seconds." → "By default, the period is 30 seconds."
- `libsql-server/src/rpc/streaming_exec.rs` — "/// Apply the response to the the builder, and return whether..." → "/// Appl... | e4beacaa266fba930b637515e2082b42c2d6a817 | cc9cfaaefac17925f03f66e45dbf18a38b2bef1c | diff --git a/libsql-server/src/main.rs b/libsql-server/src/main.rs
index 307d5482fe..aad76d825d 100644
--- a/libsql-server/src/main.rs
+++ b/libsql-server/src/main.rs
@@ -153,7 +153,7 @@ struct Cli {
heartbeat_auth: Option<String>,
/// The heartbeat time period in seconds.
- /// By default, the the perio... | [
"libsql-server/src/main.rs",
"libsql-server/src/rpc/streaming_exec.rs"
] | [] | true | ||
tursodatabase/libsql | 2,245 | issue_to_patch | libsql-ffi: Update vendored SQLite3MultipleCiphers to 1.9.0 | This updates the vendored SQLite3 Multiple Ciphers encryption extension from 1.8.1 to 1.9.0, the release that targets upstream SQLite 3.47.0 (the base version we now ship). The previous 1.8.1 vendoring lagged the SQLite base and was missing several upstream fixes, including a crash in sqlite3mcSetCodec().
The import... | 58161459018200cc9963e3fbdd584b065eb33fbe | eb03b043f0b6335ff33154c640dd423372a822a6 | diff --git a/libsql-ffi/bundled/SQLite3MultipleCiphers/.editorconfig b/libsql-ffi/bundled/SQLite3MultipleCiphers/.editorconfig
new file mode 100644
index 0000000000..b259d5da6a
--- /dev/null
+++ b/libsql-ffi/bundled/SQLite3MultipleCiphers/.editorconfig
@@ -0,0 +1,16 @@
+# This is the EditorConfig (http://editorconfig.o... | [
"libsql-ffi/bundled/SQLite3MultipleCiphers/.editorconfig",
"libsql-ffi/bundled/SQLite3MultipleCiphers/CHANGELOG.md",
"libsql-ffi/bundled/SQLite3MultipleCiphers/CMakeLists.txt",
"libsql-ffi/bundled/SQLite3MultipleCiphers/LICENSE",
"libsql-ffi/bundled/SQLite3MultipleCiphers/Makefile.am",
"libsql-ffi/bundled... | [] | true | ||
tursodatabase/libsql | 2,242 | issue_to_patch | github: Build the Windows CI job with the MSVC toolchain | The Windows job's `cargo build -p libsql --all-features` was being built with the `x86_64-pc-windows-gnu` toolchain (MinGW/GCC), set as the default host triple by `hecrj/setup-rust-action@v2`. MSVC was never exercised. So breaks that only fail under MSVC -- like the SQLite 3.47.0 `#warning` that errors with C1021 -- co... | b9336da4c7fd4bddbc477f2a008f7dd0132f4fbd | e3f7e8ee0b4fb7ba0e643634883c69cc46f9e9b8 | diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 6647bab9dd..716ad07e6d 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -242,11 +242,14 @@ jobs:
~/.cargo/registry/index/
~/.cargo/registry/cache/
~/.cargo/git/db/
- ta... | [
".github/workflows/rust.yml"
] | [] | true | ||
tursodatabase/libsql | 2,241 | issue_to_patch | libsql-sqlite3: Skip SQLITE_USER_AUTHENTICATION #warning on MSVC | The SQLITE_USER_AUTHENTICATION deprecation #warning (added upstream in SQLite 3.46.0) is a hard error under MSVC's default traditional C preprocessor (error C1021: invalid preprocessor command 'warning'), breaking Windows builds. SQLite3MultipleCiphers force-enables SQLITE_USER_AUTHENTICATION by default, so the directi... | d1d48dddfba7590854cb3ad2a0737a3f58003713 | a1c9afcfeb5137099ebcabacb2dca15e7de06d8c | diff --git a/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c b/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c
index d9a19f55a1..988693f341 100644
--- a/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c
+++ b/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c
@@ -18394,7 +18394,14 @@ struct F... | [
"libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c",
"libsql-ffi/bundled/src/sqlite3.c",
"libsql-sqlite3/src/sqliteInt.h"
] | [] | true | ||
tursodatabase/libsql | 2,239 | issue_to_patch | Switch to minimum supported Rust version compatible resolver | The url 2.5.4+ crate pulls idna 1.x -> idna_adapter -> icu_* 2.2.0, which
require rustc 1.86. A fresh dependency resolution (e.g. the Docker build,
which did not pass --locked) would select those and fail against the 1.85.0
toolchain pinned in rust-toolchain.toml.
Bump the workspace to resolver = "3". With no rust-ver... | e4beacaa266fba930b637515e2082b42c2d6a817 | 46e2c1259ac6235e1274a81308f097bae9164256 | diff --git a/Cargo.toml b/Cargo.toml
index 53c93e2ba2..a71b9117db 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -1,5 +1,5 @@
[workspace]
-resolver = "2"
+resolver = "3"
members = [
"bindings/c",
"bindings/wasm",
diff --git a/Dockerfile b/Dockerfile
index c929085f81..42c548b5b3 100644
--- a/Dockerfile
+++ b/Docker... | [
"Cargo.toml",
"Dockerfile",
"libsql-sqlite3/ext/crr/rs/bundle/Cargo.toml",
"libsql-sqlite3/ext/crr/rs/bundle_static/Cargo.toml",
"libsql-sqlite3/ext/crr/rs/core/Cargo.toml",
"libsql-sqlite3/ext/crr/rs/fractindex-core/Cargo.toml",
"libsql-sqlite3/ext/crr/rs/integration_check/Cargo.toml",
"libsql-sqlite... | [] | diff --git a/libsql-sqlite3/test/rust_suite/Cargo.toml b/libsql-sqlite3/test/rust_suite/Cargo.toml
index 23c1735abe..30a6aecbf0 100644
--- a/libsql-sqlite3/test/rust_suite/Cargo.toml
+++ b/libsql-sqlite3/test/rust_suite/Cargo.toml
@@ -3,7 +3,13 @@ name = "libsql_rust_suite"
version = "0.2.0"
edition = "2021"
+# Thi... | true | |
tursodatabase/libsql | 2,218 | issue_to_patch | bindings/c: Add support for Intel architecture | A continuation of #2202
I added support only for arm64 archs, but the Apple tooling still requires x86_64 to be present, even though intel macs are phased out
This just modifies the make file to create a fat dylib for ios | 61e04f5700ea2033247b12f25d953431e14d4432 | cd605eb40c691832169a2041c2adc989b5f07452 | diff --git a/bindings/c/Makefile b/bindings/c/Makefile
index 3d34e8d462..bf27566e8f 100644
--- a/bindings/c/Makefile
+++ b/bindings/c/Makefile
@@ -57,19 +57,30 @@ package-dylibs:
mkdir -p generated/libsql_experimental.xcframework/ios-arm64/libsql_experimental.framework/Headers
cp include/$(HEADER) generated/libsql_... | [
"bindings/c/Makefile",
"bindings/c/templates/libsql_experimental.xcframework/Info.plist",
"bindings/c/templates/libsql_experimental.xcframework/ios-arm64_x86_64-simulator/libsql_experimental.framework/Info.plist"
] | [] | true | ||
tursodatabase/libsql | 2,220 | issue_to_patch | libsql: Fix total_changes accumulation for SQL over HTTP batch execution | The batch_inner() updates affected_row_count but never adds it to total_changes. Only finalize() did, so total_changes was missing the contributions of all intermediate batch/execute operations.
Found while investigating https://github.com/tursodatabase/libsql-client-ts/issues/312 | 99e6ad3424f890a9f01e06d0f50b108059235a9e | b7cc2b86bd6eae4cacbde6760ae7fecfc471c770 | diff --git a/libsql/src/hrana/stream.rs b/libsql/src/hrana/stream.rs
index 686013d3c5..490824d930 100644
--- a/libsql/src/hrana/stream.rs
+++ b/libsql/src/hrana/stream.rs
@@ -163,6 +163,9 @@ where
self.inner
.affected_row_count
.store(result.affecte... | [
"libsql/src/hrana/stream.rs"
] | [
{
"comment": "`total_changes` is still under-counted for multi-statement batches: this adds only the *last* step's `affected_row_count`, but `execute_batch()` / `Batch::from_iter(...)` can contain many statements and SQLite's `total_changes` semantics accumulate changes from *all* executed statements. Consider ... | true | ||
tursodatabase/libsql | 2,220 | comment_to_fix | libsql: Fix total_changes accumulation for SQL over HTTP batch execution | `total_changes` is still under-counted for multi-statement batches: this adds only the *last* step's `affected_row_count`, but `execute_batch()` / `Batch::from_iter(...)` can contain many statements and SQLite's `total_changes` semantics accumulate changes from *all* executed statements. Consider summing `affected_row_... | 99e6ad3424f890a9f01e06d0f50b108059235a9e | b7cc2b86bd6eae4cacbde6760ae7fecfc471c770 | diff --git a/libsql/src/hrana/stream.rs b/libsql/src/hrana/stream.rs
index 686013d3c5..490824d930 100644
--- a/libsql/src/hrana/stream.rs
+++ b/libsql/src/hrana/stream.rs
@@ -163,6 +163,9 @@ where
self.inner
.affected_row_count
.store(result.affecte... | [
"libsql/src/hrana/stream.rs"
] | [
{
"comment": "`total_changes` is still under-counted for multi-statement batches: this adds only the *last* step's `affected_row_count`, but `execute_batch()` / `Batch::from_iter(...)` can contain many statements and SQLite's `total_changes` semantics accumulate changes from *all* executed statements. Consider ... | true | ||
tursodatabase/libsql | 2,222 | issue_to_patch | Fix Docker build by using --locked for cargo-chef install | cargo-chef's transitive dependencies (cargo-platform, cargo_metadata, guppy, target-spec) bumped their MSRV to Rust 1.86-1.88, breaking the install on our pinned Rust 1.85.0 toolchain. Using --locked forces cargo to use cargo-chef's bundled lockfile, which is tested against its supported Rust versions. | 5835b5565349f1262654fcc1bdbfdc8b03c63dab | 46a0527ac41efdabf8e08d3794b3a33938578eb3 | diff --git a/Dockerfile b/Dockerfile
index da0cd751ee..574f6e6f00 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -15,7 +15,7 @@ RUN cat rust-toolchain.toml | grep "channel" | awk '{print $3}' | sed 's/\"//g'
&& rustup update $(cat toolchain.txt) \
&& rustup default $(cat toolchain.txt) \
&& rm toolchain.txt... | [
"Dockerfile"
] | [] | true | ||
tursodatabase/libsql | 2,221 | issue_to_patch | libsql-sqlite3: Pin psm version in extension tests | ar_archive_writer v0.5.1 pulled by latest psm uses let-chains which require Rust 1.87+. Since the rust_suite Cargo.lock is not tracked, CI resolves to the latest version which breaks the build. | 61e04f5700ea2033247b12f25d953431e14d4432 | 79b5ace3f429433b06b309260a8086e4297a157e | [
"libsql-sqlite3/test/rust_suite/Cargo.toml"
] | [] | diff --git a/libsql-sqlite3/test/rust_suite/Cargo.toml b/libsql-sqlite3/test/rust_suite/Cargo.toml
index 69ae232bda..23c1735abe 100644
--- a/libsql-sqlite3/test/rust_suite/Cargo.toml
+++ b/libsql-sqlite3/test/rust_suite/Cargo.toml
@@ -18,6 +18,9 @@ rustc-hash = "1"
home = { version = "=0.5.9" }
which = "=4.4.0"
+[d... | true | ||
tursodatabase/libsql | 2,213 | issue_to_patch | Remove nemesis cron job | b5dab26b005c51ac8a67a868f8eaa1f9674877a9 | ef2f259103e4b28765aef804d2b094baa7784e03 | diff --git a/.github/workflows/nemesis.yml b/.github/workflows/nemesis.yml
index f5c44a132b..6e69651f3d 100644
--- a/.github/workflows/nemesis.yml
+++ b/.github/workflows/nemesis.yml
@@ -1,8 +1,6 @@
name: Nemesis Tests
on:
- schedule:
- - cron: '* */4 * * *'
workflow_dispatch:
env:
| [
".github/workflows/nemesis.yml"
] | [] | true | |||
tursodatabase/libsql | 2,202 | issue_to_patch | Migrate to dylibs | When I first submitted the patch to compile libsql for mobiles I didn't know what I was doing. A static library is the easiest way to make things work but takes too much disk space as all the necessary code is packaged. Migrating to dylibs is better for mobiles as a lot of the binary size is reduced.
I've managed to... | fa26ac40388973bec8a40ee415e96c246f970510 | 4cca9b7690f426c25f4d633d2c1ff0dbbc89ab4e | diff --git a/bindings/c/Makefile b/bindings/c/Makefile
index 3a6e060da8..3d34e8d462 100644
--- a/bindings/c/Makefile
+++ b/bindings/c/Makefile
@@ -3,12 +3,11 @@ CFLAGS := -Iinclude
LDFLAGS := -lm
ARCHS_IOS = aarch64-apple-ios aarch64-apple-ios-sim
ARCHS_ANDROID = aarch64-linux-android armv7-linux-androideabi x86_64-... | [
"bindings/c/Makefile",
"bindings/c/templates/libsql_experimental.xcframework/Info.plist",
"bindings/c/templates/libsql_experimental.xcframework/ios-arm64-simulator/libsql_experimental.framework/Info.plist",
"bindings/c/templates/libsql_experimental.xcframework/ios-arm64/libsql_experimental.framework/Info.plis... | [] | true | ||
tursodatabase/libsql | 2,199 | issue_to_patch | Add turso cloud encryption example | 2d50cd03aca0abfb0c1ef78e3dc86bb582c78758 | bc81ec0a3d0d4eed2aaff782216d06d04d8d6ffe | diff --git a/libsql/examples/encryption_remote.rs b/libsql/examples/encryption_remote.rs
new file mode 100644
index 0000000000..ffd240b39e
--- /dev/null
+++ b/libsql/examples/encryption_remote.rs
@@ -0,0 +1,79 @@
+// Example: Connecting to an encrypted Turso Cloud database
+//
+// This example shows how to connect to a... | [
"libsql/examples/encryption_remote.rs"
] | [] | true | |||
tursodatabase/libsql | 2,201 | issue_to_patch | Release libsql-server v0.24.33 | ac9c733b970f8a720981ad042a37d4d2ebda6d83 | 2c2a3ac5baa805f4a8c66410cb09f154b716a68b | diff --git a/Cargo.lock b/Cargo.lock
index ed8a842da8..c031a417ca 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3005,7 +3005,7 @@ dependencies = [
[[package]]
name = "libsql-server"
-version = "0.24.32"
+version = "0.24.33"
dependencies = [
"aes",
"anyhow",
diff --git a/libsql-server/Cargo.toml b/libsql-server/... | [
"Cargo.lock",
"libsql-server/Cargo.toml"
] | [] | true | |||
tursodatabase/libsql | 2,200 | issue_to_patch | server/replication: fsync frame data in wallog before writing header | Currently in logger.rs we are not issuing any fsyncs at all. We do `flush()` in `write_header()` but this is a no-op on Unix because there are no userspace buffers to flush since `write_all_at()` writes directly to kernel.
Not fsyncing can cause the following bug:
- We write X frames
- We write wallog header (co... | 2d50cd03aca0abfb0c1ef78e3dc86bb582c78758 | 214baf10200f6e02cd42ac81f4de609667de8b53 | diff --git a/libsql-server/src/replication/primary/logger.rs b/libsql-server/src/replication/primary/logger.rs
index 6213f0da50..8eb268e4ed 100644
--- a/libsql-server/src/replication/primary/logger.rs
+++ b/libsql-server/src/replication/primary/logger.rs
@@ -177,6 +177,10 @@ impl LogFile {
}
pub fn commit(&... | [
"libsql-server/src/replication/primary/logger.rs"
] | [] | true | ||
tursodatabase/libsql | 2,196 | issue_to_patch | Extension tests are broken
See this run: https://github.com/tursodatabase/libsql/actions/runs/18771985804/job/53558192484?pr=2176
which does:
```
cd libsql-sqlite3/test/rust_suite
# Only execute extensions tests
cargo test --features=extensions extensions
```
but it fails with:
```
error: rustc 1.85.0 is not supp... | fix #2180 : pin home and wabt versions for Rust 1.85 compatibility | # Summary
This PR fixes #2180 aka the extension tests that were failing due to dependency incompatibility with Rust 1.85.
## Problem
The extension tests in `libsql-sqlite3/test/rust_suite` were failing because:
The `home` crate version 0.5.12 requires Rust 1.88, but the project uses Rust 1.85
Older versions ... | f17ada2976b9256d612b051b65bb9ff32d74df34 | b22e8822bbf633677f960faf18b03f35c7db7980 | [
"libsql-sqlite3/test/rust_suite/Cargo.toml"
] | [] | diff --git a/libsql-sqlite3/test/rust_suite/Cargo.toml b/libsql-sqlite3/test/rust_suite/Cargo.toml
index d6b12cb158..69ae232bda 100644
--- a/libsql-sqlite3/test/rust_suite/Cargo.toml
+++ b/libsql-sqlite3/test/rust_suite/Cargo.toml
@@ -12,9 +12,10 @@ libsql-sys = { path = "../../../libsql-sys", features = ["wal", "wasmt... | true | |
tursodatabase/libsql | 2,190 | issue_to_patch | docs: Fix inconsistencies in documentation | This PR fixes some typos and formatting artifacts in the documentation files.
It also removes the `version: ` field from the Docker Compose setup instruction, as it is [obsolete](https://docs.docker.com/reference/compose-file/version-and-name/#version-top-level-element-obsolete).
> Compose always uses the most re... | 19b1c7aac9efd241a4af9e1828a527c166b89acd | 400403c9460bd1dff2ae07bb1a87cc058930e7b2 | diff --git a/docs/ADMIN_API.md b/docs/ADMIN_API.md
index 118274a5ec..d5a7fe2478 100644
--- a/docs/ADMIN_API.md
+++ b/docs/ADMIN_API.md
@@ -6,7 +6,7 @@ The admin API is used to manage namespaces on a `sqld` instance. Namespaces are
To enable the admin API, and manage namespaces, two extra flags need to be passed to `... | [
"docs/ADMIN_API.md",
"docs/DOCKER.md",
"docs/USER_GUIDE.md",
"libsql-server/perf/pgbench/README.md",
"libsql-sqlite3/doc/testrunner.md"
] | [] | true | ||
tursodatabase/libsql | 2,195 | issue_to_patch | Add Ring as an experimental community driver | 6702c3da3ea5c8a348217b3db03acea73a5081b6 | 1e2a95c2d62c5079b249a9c16bdfa5b1aefa897b | diff --git a/README.md b/README.md
index c57b503e34..a94930b0df 100644
--- a/README.md
+++ b/README.md
@@ -72,6 +72,7 @@ The comprehensive description can be found [here](libsql-sqlite3/doc/libsql_exte
* [PHP](https://github.com/tursodatabase/turso-client-php)
* [D](https://github.com/pdenapo/libsql-d) (experimenta... | [
"README.md"
] | [] | true | |||
tursodatabase/libsql | 2,194 | issue_to_patch | Bump workers dependency to fix build for cloudflare/wasm | Currently builds are failing due to duplicate dep version for cloudflare/wasm target of `workers` library | 571a1cef9e5231e2096e0416fefe7db92cfd52c6 | 26cc9f5ee94ba650478d8220c734cfd2bdf9f182 | diff --git a/Cargo.lock b/Cargo.lock
index 867bc20074..443b44f055 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -104,12 +104,6 @@ version = "0.0.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "e9d4ee0d472d1cd2e28c97dfa124b3d8d992e10eb0a035f33f5d12e3a177ba3b"
-[[package]]
-name = "andro... | [
"Cargo.lock",
"libsql/Cargo.toml",
"libsql/src/wasm/cloudflare.rs"
] | [] | true | ||
tursodatabase/libsql | 1,839 | issue_to_patch | Add new Connection API to install SQLite update hooks. | Addresses https://github.com/tursodatabase/libsql/issues/1418 | 19b1c7aac9efd241a4af9e1828a527c166b89acd | 9c7699134f11bc3b411039b421020bc8f8fe010d | diff --git a/libsql/src/connection.rs b/libsql/src/connection.rs
index 2bca312500..396f2e1f18 100644
--- a/libsql/src/connection.rs
+++ b/libsql/src/connection.rs
@@ -13,6 +13,15 @@ use crate::{Result, TransactionBehavior};
pub type AuthHook = Arc<dyn Fn(&AuthContext) -> Authorization>;
+pub type UpdateHook = dyn ... | [
"libsql/src/connection.rs",
"libsql/src/errors.rs",
"libsql/src/lib.rs",
"libsql/src/local/connection.rs",
"libsql/src/local/impls.rs",
"libsql/tests/integration_tests.rs"
] | [] | diff --git a/libsql/tests/integration_tests.rs b/libsql/tests/integration_tests.rs
index 57addab948..697ac220ef 100644
--- a/libsql/tests/integration_tests.rs
+++ b/libsql/tests/integration_tests.rs
@@ -4,12 +4,12 @@ use futures::{StreamExt, TryStreamExt};
use libsql::{
named_params, params,
params::{IntoPar... | true | |
tursodatabase/libsql | 2,189 | issue_to_patch | libsql-sqlite3: Optimize pager codec check more | Checking if we have a custom codec at pager open time is still plenty slow. Change the check to happen at database open time instead. | 5379778650804b67bf420b26641b62e3b069ff0d | 0555bdd6e5bd1f53df1c99a597d168a8b9dbca11 | diff --git a/libsql-ffi/bundled/SQLite3MultipleCiphers/src/codecext.c b/libsql-ffi/bundled/SQLite3MultipleCiphers/src/codecext.c
index 5cfaaa47b7..6754109ebc 100644
--- a/libsql-ffi/bundled/SQLite3MultipleCiphers/src/codecext.c
+++ b/libsql-ffi/bundled/SQLite3MultipleCiphers/src/codecext.c
@@ -8,10 +8,10 @@
*/
/*
-... | [
"libsql-ffi/bundled/SQLite3MultipleCiphers/src/codecext.c",
"libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c",
"libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3mc_vfs.c",
"libsql-ffi/bundled/src/sqlite3.c",
"libsql-sqlite3/src/attach.c",
"libsql-sqlite3/src/btree.c",
"libsql-sqlite3/src/btr... | [
{
"comment": "Missing forward declaration for `libsql_db_has_codec`. This function is called within the `#ifdef LIBSQL_CUSTOM_PAGER_CODEC` block but is not declared in any included header. Consider adding a forward declaration similar to the one in `main.c` (lines 3448-3450):\n\n```c\n#ifdef LIBSQL_CUSTOM_PAGER... | true | ||
tursodatabase/libsql | 2,189 | comment_to_fix | libsql-sqlite3: Optimize pager codec check more | Missing forward declaration for `libsql_db_has_codec`. This function is called within the `#ifdef LIBSQL_CUSTOM_PAGER_CODEC` block but is not declared in any included header. Consider adding a forward declaration similar to the one in `main.c` (lines 3448-3450):
```c
#ifdef LIBSQL_CUSTOM_PAGER_CODEC
int libsql_db_has_... | 5379778650804b67bf420b26641b62e3b069ff0d | 0555bdd6e5bd1f53df1c99a597d168a8b9dbca11 | diff --git a/libsql-sqlite3/src/attach.c b/libsql-sqlite3/src/attach.c
index 989cc49ac3..dadb01e611 100644
--- a/libsql-sqlite3/src/attach.c
+++ b/libsql-sqlite3/src/attach.c
@@ -65,6 +65,10 @@ int libsql_handle_extra_attach_params(sqlite3* db, const char* zName, const char
SQLITE_PRIVATE int sqlite3mcHandleAttachKey(... | [
"libsql-sqlite3/src/attach.c"
] | [
{
"comment": "Missing forward declaration for `libsql_db_has_codec`. This function is called within the `#ifdef LIBSQL_CUSTOM_PAGER_CODEC` block but is not declared in any included header. Consider adding a forward declaration similar to the one in `main.c` (lines 3448-3450):\n\n```c\n#ifdef LIBSQL_CUSTOM_PAGER... | true | ||
tursodatabase/libsql | 2,185 | issue_to_patch | libsql-sqlite3: Optimize libsql_pager_has_codec() function | Cache the result of libsql_pager_has_codec() in Pager struct to avoid walking through all VFSes every time a page is read. | 15da41945e288e3707b6c96eaecf86b29778c474 | 6d6ba1e6b4ec9f5f4bd30fc3f8962294cab13966 | diff --git a/libsql-ffi/bundled/SQLite3MultipleCiphers/src/codecext.c b/libsql-ffi/bundled/SQLite3MultipleCiphers/src/codecext.c
index ddc845041d..5cfaaa47b7 100644
--- a/libsql-ffi/bundled/SQLite3MultipleCiphers/src/codecext.c
+++ b/libsql-ffi/bundled/SQLite3MultipleCiphers/src/codecext.c
@@ -7,6 +7,12 @@
** License:... | [
"libsql-ffi/bundled/SQLite3MultipleCiphers/src/codecext.c",
"libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c",
"libsql-ffi/bundled/src/sqlite3.c",
"libsql-sqlite3/src/pager.c"
] | [
{
"comment": "The codec check is cached before the pager is fully initialized. At this point in `sqlite3PagerOpen`, the pager file descriptor (`pPager->fd`) has been opened (line 4977), but if the codec implementation in `libsql_pager_has_codec_impl` needs to traverse the VFS stack or inspect file properties th... | true | ||
tursodatabase/libsql | 2,185 | comment_to_fix | libsql-sqlite3: Optimize libsql_pager_has_codec() function | The codec check is cached before the pager is fully initialized. At this point in `sqlite3PagerOpen`, the pager file descriptor (`pPager->fd`) has been opened (line 4977), but if the codec implementation in `libsql_pager_has_codec_impl` needs to traverse the VFS stack or inspect file properties that might be modified l... | 15da41945e288e3707b6c96eaecf86b29778c474 | 6d6ba1e6b4ec9f5f4bd30fc3f8962294cab13966 | diff --git a/libsql-sqlite3/src/pager.c b/libsql-sqlite3/src/pager.c
index 5a2278b616..88ed3d36fd 100644
--- a/libsql-sqlite3/src/pager.c
+++ b/libsql-sqlite3/src/pager.c
@@ -630,6 +630,7 @@ struct Pager {
u8 readOnly; /* True for a read-only database */
u8 memDb; /* True to inhib... | [
"libsql-sqlite3/src/pager.c"
] | [
{
"comment": "The codec check is cached before the pager is fully initialized. At this point in `sqlite3PagerOpen`, the pager file descriptor (`pPager->fd`) has been opened (line 4977), but if the codec implementation in `libsql_pager_has_codec_impl` needs to traverse the VFS stack or inspect file properties th... | true | ||
tursodatabase/libsql | 2,185 | comment_to_fix | libsql-sqlite3: Optimize libsql_pager_has_codec() function | The comment should clarify that this is a cached value set during pager initialization to avoid repeated VFS traversals. Consider: `/* Cached codec check result (set at initialization to avoid VFS traversals) */`
```suggestion
u8 hasCodec; /* Cached codec check result (set at initialization to avoid VF... | 15da41945e288e3707b6c96eaecf86b29778c474 | 6d6ba1e6b4ec9f5f4bd30fc3f8962294cab13966 | diff --git a/libsql-sqlite3/src/pager.c b/libsql-sqlite3/src/pager.c
index 5a2278b616..88ed3d36fd 100644
--- a/libsql-sqlite3/src/pager.c
+++ b/libsql-sqlite3/src/pager.c
@@ -630,6 +630,7 @@ struct Pager {
u8 readOnly; /* True for a read-only database */
u8 memDb; /* True to inhib... | [
"libsql-sqlite3/src/pager.c"
] | [
{
"comment": "The comment should clarify that this is a cached value set during pager initialization to avoid repeated VFS traversals. Consider: `/* Cached codec check result (set at initialization to avoid VFS traversals) */`\n```suggestion\n u8 hasCodec; /* Cached codec check result (set at in... | true | ||
tursodatabase/libsql | 2,185 | comment_to_fix | libsql-sqlite3: Optimize libsql_pager_has_codec() function | The codec check is cached before the pager is fully initialized. At this point in `sqlite3PagerOpen`, the pager file descriptor (`pPager->fd`) has been opened, but if the codec implementation in `libsql_pager_has_codec_impl` needs to traverse the VFS stack or inspect file properties that might be modified later in the ... | 15da41945e288e3707b6c96eaecf86b29778c474 | 6d6ba1e6b4ec9f5f4bd30fc3f8962294cab13966 | diff --git a/libsql-ffi/bundled/src/sqlite3.c b/libsql-ffi/bundled/src/sqlite3.c
index a446238be3..182d71ea84 100644
--- a/libsql-ffi/bundled/src/sqlite3.c
+++ b/libsql-ffi/bundled/src/sqlite3.c
@@ -58152,6 +58152,7 @@ struct Pager {
u8 readOnly; /* True for a read-only database */
u8 memDb; ... | [
"libsql-ffi/bundled/src/sqlite3.c"
] | [
{
"comment": "The codec check is cached before the pager is fully initialized. At this point in `sqlite3PagerOpen`, the pager file descriptor (`pPager->fd`) has been opened, but if the codec implementation in `libsql_pager_has_codec_impl` needs to traverse the VFS stack or inspect file properties that might be ... | true | ||
tursodatabase/libsql | 2,185 | comment_to_fix | libsql-sqlite3: Optimize libsql_pager_has_codec() function | The comment should clarify that this is a cached value set during pager initialization to avoid repeated VFS traversals. Consider: `/* Cached codec check result (set at initialization to avoid VFS traversals) */` | 15da41945e288e3707b6c96eaecf86b29778c474 | 6d6ba1e6b4ec9f5f4bd30fc3f8962294cab13966 | diff --git a/libsql-ffi/bundled/src/sqlite3.c b/libsql-ffi/bundled/src/sqlite3.c
index a446238be3..182d71ea84 100644
--- a/libsql-ffi/bundled/src/sqlite3.c
+++ b/libsql-ffi/bundled/src/sqlite3.c
@@ -58152,6 +58152,7 @@ struct Pager {
u8 readOnly; /* True for a read-only database */
u8 memDb; ... | [
"libsql-ffi/bundled/src/sqlite3.c"
] | [
{
"comment": "The comment should clarify that this is a cached value set during pager initialization to avoid repeated VFS traversals. Consider: `/* Cached codec check result (set at initialization to avoid VFS traversals) */`",
"path": "libsql-ffi/bundled/src/sqlite3.c",
"hunk": "@@ -58152,6 +58152,7 @... | true | ||
tursodatabase/libsql | 2,185 | comment_to_fix | libsql-sqlite3: Optimize libsql_pager_has_codec() function | The codec check is cached before the pager is fully initialized. At this point in `sqlite3PagerOpen`, the pager file descriptor (`pPager->fd`) has been opened, but if the codec implementation in `libsql_pager_has_codec_impl` needs to traverse the VFS stack or inspect file properties that might be modified later in the ... | 15da41945e288e3707b6c96eaecf86b29778c474 | 6d6ba1e6b4ec9f5f4bd30fc3f8962294cab13966 | diff --git a/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c b/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c
index a446238be3..182d71ea84 100644
--- a/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c
+++ b/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c
@@ -58152,6 +58152,7 @@ struct Pa... | [
"libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c"
] | [
{
"comment": "The codec check is cached before the pager is fully initialized. At this point in `sqlite3PagerOpen`, the pager file descriptor (`pPager->fd`) has been opened, but if the codec implementation in `libsql_pager_has_codec_impl` needs to traverse the VFS stack or inspect file properties that might be ... | true | ||
tursodatabase/libsql | 2,185 | comment_to_fix | libsql-sqlite3: Optimize libsql_pager_has_codec() function | The comment should clarify that this is a cached value set during pager initialization to avoid repeated VFS traversals. Consider: `/* Cached codec check result (set at initialization to avoid VFS traversals) */` | 15da41945e288e3707b6c96eaecf86b29778c474 | 6d6ba1e6b4ec9f5f4bd30fc3f8962294cab13966 | diff --git a/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c b/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c
index a446238be3..182d71ea84 100644
--- a/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c
+++ b/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c
@@ -58152,6 +58152,7 @@ struct Pa... | [
"libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c"
] | [
{
"comment": "The comment should clarify that this is a cached value set during pager initialization to avoid repeated VFS traversals. Consider: `/* Cached codec check result (set at initialization to avoid VFS traversals) */`",
"path": "libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c",
"hunk": ... | true | ||
tursodatabase/libsql | 2,188 | issue_to_patch | Update README to include libSQL and Turso links | Clarify repository purpose and link to related project. | 020168a44542acd3b986d5b2420bbc708f962e9e | e8414bb5220a27f3125f5b3af47cba58f34b62ce | diff --git a/README.md b/README.md
index cf872e8852..c57b503e34 100644
--- a/README.md
+++ b/README.md
@@ -33,6 +33,9 @@
---
+> [!NOTE]
+> This repository contains libSQL, a fork of SQLite developed by Turso. For the full SQLite rewriten in Rust (also by Turso), please visit [tursodatabase/turso](https://github.co... | [
"README.md"
] | [] | true | ||
tursodatabase/libsql | 2,184 | issue_to_patch | Fix Windows compilation in libsql-sys | This occurs on the latest released version 0.9.24 :
```
error[E0599]: no method named `to_str` found for type parameter `impl AsRef<Path>` in the current scope
Error: --> C:\Users\runneradmin\.cargo\registry\src\index.crates.io-1949cf8c6b5b557f\libsql-sys-0.9.24\src\connection.rs:287:18
|
200 | pa... | d4026bcc69c8bbfdcf301b2c438c98856ce54980 | 98a2299ce2969e2919c0e9e89a72c5690d76c70f | diff --git a/libsql-sys/src/connection.rs b/libsql-sys/src/connection.rs
index 6156ed42e1..aa0a370da3 100644
--- a/libsql-sys/src/connection.rs
+++ b/libsql-sys/src/connection.rs
@@ -284,6 +284,7 @@ impl<W: Wal> Connection<W> {
};
#[cfg(not(unix))]
let path = path
+ ... | [
"libsql-sys/src/connection.rs"
] | [] | true | ||
tursodatabase/libsql | 2,186 | issue_to_patch | Fix sqlite3mc bundling | The `cargo xtask build-bundled` did not update sqlite3mc bundle automatically, resulting version drift as people sometimes updated it manually, and sometimes forgot to do that. | d4026bcc69c8bbfdcf301b2c438c98856ce54980 | 7ea80c3a997907938590e1e051a087430c1cea8d | diff --git a/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c b/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c
index ff6d994d90..a446238be3 100644
--- a/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c
+++ b/libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c
@@ -28,7 +28,14 @@
** README.... | [
"libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.c",
"libsql-ffi/bundled/SQLite3MultipleCiphers/src/sqlite3.h",
"libsql-sqlite3/test/rust_suite/Cargo.toml",
"xtask/src/main.rs"
] | [] | diff --git a/libsql-sqlite3/test/rust_suite/Cargo.toml b/libsql-sqlite3/test/rust_suite/Cargo.toml
index 90a8251ebf..d6b12cb158 100644
--- a/libsql-sqlite3/test/rust_suite/Cargo.toml
+++ b/libsql-sqlite3/test/rust_suite/Cargo.toml
@@ -15,6 +15,7 @@ tempfile = "3.3"
wabt = "0.10.0"
hex = "0.4.3"
rustc-hash = "1"
+whi... | true | |
tursodatabase/libsql | 2,187 | issue_to_patch | Fix extensions test by pinning "home" crate version | d4026bcc69c8bbfdcf301b2c438c98856ce54980 | 47e2c3da0c5d8bed4a3c338c5259a83fa6f9cb6e | [
"libsql-sqlite3/test/rust_suite/Cargo.toml"
] | [] | diff --git a/libsql-sqlite3/test/rust_suite/Cargo.toml b/libsql-sqlite3/test/rust_suite/Cargo.toml
index 90a8251ebf..d6b12cb158 100644
--- a/libsql-sqlite3/test/rust_suite/Cargo.toml
+++ b/libsql-sqlite3/test/rust_suite/Cargo.toml
@@ -15,6 +15,7 @@ tempfile = "3.3"
wabt = "0.10.0"
hex = "0.4.3"
rustc-hash = "1"
+whi... | true | |||
tursodatabase/libsql | 2,176 | issue_to_patch | bump version to 0.9.25 | depends on https://github.com/tursodatabase/libsql/pull/2175 | 34033b7d90fcfcd258f622bd8ae21b7f7d8d898a | 4304eabfcc154c61649ab91cd3925390a039b335 | diff --git a/Cargo.lock b/Cargo.lock
index 1de3584134..8e6980fcd6 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2905,7 +2905,7 @@ dependencies = [
[[package]]
name = "libsql"
-version = "0.9.24"
+version = "0.9.25"
dependencies = [
"anyhow",
"async-stream",
@@ -2965,7 +2965,7 @@ dependencies = [
[[package]]
... | [
"Cargo.lock",
"Cargo.toml",
"vendored/rusqlite/Cargo.toml"
] | [] | true | ||
tursodatabase/libsql | 2,175 | issue_to_patch | Add support for cloud encryption for remote connection | Adds a new public method `libsql_open_remote_with_remote_encryption` to use with cloud encryption. Then this can be used in the SDKs. | a55bf61192bdb89e97568de593c4af5b70d24bde | 2c1be7164210677d98f47ae470a5eaa9292f53cf | diff --git a/bindings/c/include/libsql.h b/bindings/c/include/libsql.h
index b14c7b5ad9..5a43eaac61 100644
--- a/bindings/c/include/libsql.h
+++ b/bindings/c/include/libsql.h
@@ -93,6 +93,12 @@ int libsql_open_file(const char *url, libsql_database_t *out_db, const char **ou
int libsql_open_remote(const char *url, co... | [
"bindings/c/include/libsql.h",
"bindings/c/src/lib.rs"
] | [] | true | ||
tursodatabase/libsql | 2,174 | issue_to_patch | Incorrect dump export with virtual fts5 tables
In my database, I have an FTS5 table that uses the [fts5vocab Virtual Table Module](https://www.sqlite.org/fts5.html#the_fts5vocab_virtual_table_module). When I try to create a dump from my database using libsql, I receive an invalid SQL syntax error.
Let's consider the ... | Fix incorrect sql dump for fts5vocab virtual tables | Resolves #2173. | a55bf61192bdb89e97568de593c4af5b70d24bde | 63ba6b8d5c280083dde95d21ad401a264189f249 | diff --git a/libsql-server/src/connection/dump/exporter.rs b/libsql-server/src/connection/dump/exporter.rs
index 730b0928f0..1a1c69728b 100644
--- a/libsql-server/src/connection/dump/exporter.rs
+++ b/libsql-server/src/connection/dump/exporter.rs
@@ -50,10 +50,10 @@ impl<W: Write> DumpState<W> {
let ta... | [
"libsql-server/src/connection/dump/exporter.rs"
] | [] | true | |
tursodatabase/libsql | 2,151 | issue_to_patch | DB creation from dump with triggers is failing
Given `dump.sql`:
```sql
BEGIN TRANSACTION;
CREATE TABLE test (x);
CREATE TRIGGER simple_trigger
AFTER INSERT ON test
BEGIN
INSERT INTO test VALUES (999);
END;
INSERT INTO test VALUES (1);
COMMIT;
```
I need create a new db from this dump:
```sh
curl -s -X POST "0.... | Fix load dump with triggers | Resolves #2150.
Test cases implemented as well. | 6e55668cdb1d1d7406ea7fd6eea22991ac1ac301 | fcfde9edccd17eee668e32540eb3583582f8a8a6 | diff --git a/libsql-server/src/namespace/configurator/helpers.rs b/libsql-server/src/namespace/configurator/helpers.rs
index 810b84b76d..599320783d 100644
--- a/libsql-server/src/namespace/configurator/helpers.rs
+++ b/libsql-server/src/namespace/configurator/helpers.rs
@@ -7,10 +7,13 @@ use anyhow::Context as _;
use ... | [
"libsql-server/src/namespace/configurator/helpers.rs",
"libsql-server/tests/namespaces/dumps.rs",
"libsql-server/tests/namespaces/snapshots/tests__namespaces__dumps__load_dump_with_attach_rejected.snap",
"libsql-server/tests/namespaces/snapshots/tests__namespaces__dumps__load_dump_with_invalid_sql.snap"
] | [
{
"comment": "I think the risk here is that the tokenizer has some subtle bugs. Did you consider the sqlite-parser we already use elsewhere in the server?",
"path": "libsql-server/src/namespace/configurator/helpers.rs",
"hunk": "@@ -290,6 +290,95 @@ async fn run_periodic_compactions(logger: Arc<Replica... | diff --git a/libsql-server/tests/namespaces/dumps.rs b/libsql-server/tests/namespaces/dumps.rs
index 1ef1870d12..859130f773 100644
--- a/libsql-server/tests/namespaces/dumps.rs
+++ b/libsql-server/tests/namespaces/dumps.rs
@@ -425,3 +425,186 @@ fn load_dump_with_invalid_sql() {
sim.run().unwrap();
}
+
+#[test]
... | true |
tursodatabase/libsql | 2,178 | issue_to_patch | Building with encryption rebuilds libsql-ffi every time
Step to reproduce: from inside the repository, run `cargo build -p libsql --features encryption` multiple times, then notice that every time it rebuilds libsql-ffi and other crates in the chain | fix: avoid rebuilding libsql-ffi every time when using Multiple Ciphers | Fix https://github.com/tursodatabase/libsql/issues/2177
When using the Multiple Ciphers extension in libsql, I noticed that it was rebuilding libsql-ffi every time. This fixes the condition in `build.rs` to only check for changes in the Multiple Ciphers source | a55bf61192bdb89e97568de593c4af5b70d24bde | 71906fa55418d60db48e9747c7b7ec9619af322b | diff --git a/libsql-ffi/build.rs b/libsql-ffi/build.rs
index a3bc8cd523..ea95d1ed28 100644
--- a/libsql-ffi/build.rs
+++ b/libsql-ffi/build.rs
@@ -24,7 +24,7 @@ fn main() {
println!("cargo:rerun-if-changed={BUNDLED_DIR}/src/sqlite3.c");
if cfg!(feature = "multiple-ciphers") {
- println!("cargo:rerun-... | [
"libsql-ffi/build.rs"
] | [] | true | |
tursodatabase/libsql | 2,171 | issue_to_patch | Add get/set reserved bytes to C bindings | - Exposes the API to the `Connection` struct
- Adds `libsql_set_reserved_bytes` and `libsql_get_reserved_bytes` to `libsql.h` | 1cfc94076d40092159f8c9ea485da4e9bf2ba72f | 5cfbbd5588ed76383defc2d4af8b21609ead27fd | diff --git a/bindings/c/include/libsql.h b/bindings/c/include/libsql.h
index eec2d5b4d9..b14c7b5ad9 100644
--- a/bindings/c/include/libsql.h
+++ b/bindings/c/include/libsql.h
@@ -107,6 +107,10 @@ int libsql_load_extension(libsql_connection_t conn,
const char *entry_point,
... | [
"bindings/c/include/libsql.h",
"bindings/c/src/lib.rs",
"libsql/src/connection.rs",
"libsql/src/errors.rs",
"libsql/src/local/impls.rs",
"libsql/src/replication/connection.rs",
"libsql/src/sync/connection.rs"
] | [
{
"comment": "we should return `1` if the error is set right? but this returns `0` regardless ",
"path": "bindings/c/src/lib.rs",
"hunk": "@@ -549,6 +549,41 @@ pub unsafe extern \"C\" fn libsql_load_extension(\n 0\n }\n \n+#[no_mangle]\n+pub unsafe extern \"C\" fn libsql_set_reserved_bytes(\n+ co... | true | ||
tursodatabase/libsql | 2,171 | comment_to_fix | Add get/set reserved bytes to C bindings | we should return `1` if the error is set right? but this returns `0` regardless | 1cfc94076d40092159f8c9ea485da4e9bf2ba72f | 5cfbbd5588ed76383defc2d4af8b21609ead27fd | diff --git a/bindings/c/src/lib.rs b/bindings/c/src/lib.rs
index cb369b1d22..ea02fcf966 100644
--- a/bindings/c/src/lib.rs
+++ b/bindings/c/src/lib.rs
@@ -549,6 +549,45 @@ pub unsafe extern "C" fn libsql_load_extension(
0
}
+#[no_mangle]
+pub unsafe extern "C" fn libsql_set_reserved_bytes(
+ conn: libsql_con... | [
"bindings/c/src/lib.rs"
] | [
{
"comment": "we should return `1` if the error is set right? but this returns `0` regardless ",
"path": "bindings/c/src/lib.rs",
"hunk": "@@ -549,6 +549,41 @@ pub unsafe extern \"C\" fn libsql_load_extension(\n 0\n }\n \n+#[no_mangle]\n+pub unsafe extern \"C\" fn libsql_set_reserved_bytes(\n+ co... | true | ||
tursodatabase/libsql | 2,170 | issue_to_patch | Add APIs to get/set reserved bytes | 268d16933c595498a2131f812b0e09adef5fb47c | 8f1a7bedb0754214b5dadcd132f74f34200c985f | diff --git a/libsql-sys/src/connection.rs b/libsql-sys/src/connection.rs
index f3d071bd4b..6156ed42e1 100644
--- a/libsql-sys/src/connection.rs
+++ b/libsql-sys/src/connection.rs
@@ -385,6 +385,31 @@ impl<W: Wal> Connection<W> {
};
Ok(counter)
}
+
+ fn reserved_bytes(&self, reserve: Option<i32... | [
"libsql-sys/src/connection.rs",
"libsql/src/local/connection.rs"
] | [] | true | |||
tursodatabase/libsql | 2,163 | issue_to_patch | bindings/c: Fix Android build | Fixes the following build failure:
```
-- Configuring incomplete, errors occurred!
--- stderr
[libsql-ffi/build.rs:462:9] format!("{BUNDLED_DIR}/SQLite3MultipleCiphers") = "bundled/SQLite3MultipleCiphers"
CMake Error at /opt/homebrew/share/cmake/Modules/Platform/Android-Determine.cmake:217 (message):
... | 76e5772bbfcac9777837136f28f6f65d4ee50262 | 0f548259c48c80bb3851359a232bf9718061c59e | diff --git a/libsql-ffi/build.rs b/libsql-ffi/build.rs
index dc599b48a9..a3bc8cd523 100644
--- a/libsql-ffi/build.rs
+++ b/libsql-ffi/build.rs
@@ -487,6 +487,10 @@ fn build_multiple_ciphers(out_path: &Path) -> PathBuf {
.define("CMAKE_POSITION_INDEPENDENT_CODE", "ON")
.profile("Release");
+ if le... | [
"libsql-ffi/build.rs"
] | [] | true | ||
tursodatabase/libsql | 2,162 | issue_to_patch | bindings/c: Don't forward empty encryption key string | op-sqlite, for example, always passes the remote encryption key:
```
DB opsqlite_libsql_open_sync(std::string const &name,
std::string const &base_path,
std::string const &url,
std::string const &auth_token, int sync_interval,... | a57ad4a2742c1cefb25d3288b33ed25c6570e0d2 | 161c0afd1d8ce57cd7f7a0df8bfa86e26a95a0fd | diff --git a/bindings/c/src/lib.rs b/bindings/c/src/lib.rs
index 5757cd5f7e..cb369b1d22 100644
--- a/bindings/c/src/lib.rs
+++ b/bindings/c/src/lib.rs
@@ -282,9 +282,11 @@ pub unsafe extern "C" fn libsql_open_sync_with_config(
return 5;
}
};
- builder = buil... | [
"bindings/c/src/lib.rs"
] | [] | true | ||
tursodatabase/libsql | 2,160 | issue_to_patch | Bundle regexp | 7cadded4bfbd777200b39bb8426e963283d84f2a | c6adb6543fced0159408e53dc56807d5cbb6baea | diff --git a/libsql-ffi/Cargo.toml b/libsql-ffi/Cargo.toml
index f769cacf1c..ad78acafe1 100644
--- a/libsql-ffi/Cargo.toml
+++ b/libsql-ffi/Cargo.toml
@@ -40,6 +40,7 @@ sqlean-extension-fuzzy = []
sqlean-extension-math = []
sqlean-extension-stats = []
sqlean-extension-text = []
+sqlean-extension-regexp = []
sqlean-... | [
"libsql-ffi/Cargo.toml",
"libsql-ffi/build.rs",
"libsql-sys/Cargo.toml"
] | [] | true | |||
tursodatabase/libsql | 2,152 | issue_to_patch | Add tests for offline sync with db boostraps
We have a mock server https://github.com/tursodatabase/libsql/blob/618505cedab2e7bd4416c756dcb781c50a886760/libsql/src/sync/test.rs#L314-L320 but it does not support `/export` to test bootstrap. Lets update the mock to consider `/export` and also add more tests for offline ... | Add tests for offline sync with db boostraps | Resolves [2034](https://github.com/tursodatabase/libsql/issues/2034) | 7eed8989f3779d76a66aebff8da7a491667bef76 | 6075769ed2b35a4192428e9ce7760e5643cb8056 | diff --git a/libsql/src/sync/test.rs b/libsql/src/sync/test.rs
index c7fb0b65f3..104df12a31 100644
--- a/libsql/src/sync/test.rs
+++ b/libsql/src/sync/test.rs
@@ -251,6 +251,73 @@ async fn test_sync_context_retry_on_error() {
assert_eq!(server.frame_count(), 1);
}
+#[tokio::test]
+async fn test_bootstrap_db_dow... | [
"libsql/src/sync/test.rs"
] | [] | true | |
tursodatabase/libsql | 2,155 | issue_to_patch | Enable encryption for attached databases | 6671a31d327294a1edeeb334aa69b93b61e9d048 | b2cd5b038ecaa8286d08525ea08552e643bb060c | diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 8e88a04140..6647bab9dd 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -130,6 +130,9 @@ jobs:
- name: Run tests
run: cargo nextest run
+
+ - name: Run libsql encryption tests
+ run: cargo test --... | [
".github/workflows/rust.yml",
"libsql-ffi/build.rs",
"libsql-ffi/bundled/SQLite3MultipleCiphers/CMakeLists.txt",
"libsql-ffi/bundled/src/sqlite3.c",
"libsql-sqlite3/src/attach.c",
"libsql/examples/encryption_local.rs",
"libsql/tests/encryption.rs"
] | [
{
"comment": "Drop this",
"path": "libsql-ffi/bundled/src/sqlite3.c",
"hunk": "@@ -122031,6 +122035,18 @@ static void attachFunc(\n rc = libsql_handle_extra_attach_params(db, zName, zPath, argv, &zErrDyn);\n }\n #endif\n+\n+ #ifdef LIBSQL_ENCRYPTION\n+ /* Handle KEY parameter. */\n+ if( rc==SQL... | diff --git a/libsql/tests/encryption.rs b/libsql/tests/encryption.rs
new file mode 100644
index 0000000000..b6cc926740
--- /dev/null
+++ b/libsql/tests/encryption.rs
@@ -0,0 +1,52 @@
+use libsql::{params, Builder};
+use libsql_sys::{Cipher, EncryptionConfig};
+
+#[tokio::test]
+#[cfg(feature = "encryption")]
+async fn ... | true | ||
tursodatabase/libsql | 2,155 | comment_to_fix | Enable encryption for attached databases | Drop this | 6671a31d327294a1edeeb334aa69b93b61e9d048 | b2cd5b038ecaa8286d08525ea08552e643bb060c | diff --git a/libsql-ffi/bundled/src/sqlite3.c b/libsql-ffi/bundled/src/sqlite3.c
index 265c94ad12..a446238be3 100644
--- a/libsql-ffi/bundled/src/sqlite3.c
+++ b/libsql-ffi/bundled/src/sqlite3.c
@@ -121872,6 +121872,10 @@ SQLITE_PRIVATE int sqlite3DbIsNamed(sqlite3 *db, int iDb, const char *zName){
int libsql_handle_e... | [
"libsql-ffi/bundled/src/sqlite3.c"
] | [
{
"comment": "Drop this",
"path": "libsql-ffi/bundled/src/sqlite3.c",
"hunk": "@@ -122031,6 +122035,18 @@ static void attachFunc(\n rc = libsql_handle_extra_attach_params(db, zName, zPath, argv, &zErrDyn);\n }\n #endif\n+\n+ #ifdef LIBSQL_ENCRYPTION\n+ /* Handle KEY parameter. */\n+ if( rc==SQL... | true | ||
tursodatabase/libsql | 2,154 | issue_to_patch | Fix bootstrap case when we treat absent metadata as metadata with gen=0 | 6e55668cdb1d1d7406ea7fd6eea22991ac1ac301 | 7308215a39f43ac15ab7103a1b536b17a6c3c506 | diff --git a/libsql/src/sync.rs b/libsql/src/sync.rs
index 69b69d0467..9f91779e9d 100644
--- a/libsql/src/sync.rs
+++ b/libsql/src/sync.rs
@@ -172,9 +172,6 @@ impl SyncContext {
remote_encryption,
};
me.read_metadata().await?;
- if me.durable_generation == 0 {
- return E... | [
"libsql/src/sync.rs"
] | [] | true | |||
tursodatabase/libsql | 2,116 | issue_to_patch | Fix cross compile via cargo-zigbuild | cargo-zigbuild sets CMAKE_SYSTEM_PROCESSOR to armv7 when building for Rust targets matching `armv7-unknown-linux-*` | cf0fa7456f81c9c8702f1772d4aa3daaf2a6e447 | 84b7ad34c6b24d7b98947abefb57413337ee61cf | diff --git a/libsql-ffi/bundled/SQLite3MultipleCiphers/CMakeLists.txt b/libsql-ffi/bundled/SQLite3MultipleCiphers/CMakeLists.txt
index aa48e789d3..b4b96518f6 100644
--- a/libsql-ffi/bundled/SQLite3MultipleCiphers/CMakeLists.txt
+++ b/libsql-ffi/bundled/SQLite3MultipleCiphers/CMakeLists.txt
@@ -280,6 +280,7 @@ if (CMAKE... | [
"libsql-ffi/bundled/SQLite3MultipleCiphers/CMakeLists.txt"
] | [] | true | ||
tursodatabase/libsql | 2,149 | issue_to_patch | libsql: Fix metadata handling | Fix metadata handling to ensure that we don't have inconsistent metadata locally. | 8f7d444b1c6c11fd88621271eefa73ca23ce0661 | 4d9247b1ea105a3a016b52d30167a321a73f175a | diff --git a/libsql/src/sync.rs b/libsql/src/sync.rs
index 5a0536eb9d..69b69d0467 100644
--- a/libsql/src/sync.rs
+++ b/libsql/src/sync.rs
@@ -68,6 +68,8 @@ pub enum SyncError {
InvalidLocalGeneration(u32, u32),
#[error("invalid local state: {0}")]
InvalidLocalState(String),
+ #[error("invalid remote ... | [
"libsql/src/sync.rs",
"libsql/src/sync/test.rs"
] | [] | true | ||
tursodatabase/libsql | 2,148 | issue_to_patch | libsql: Fix bootstrap error handling | This fixes the following issues:
- If we fail to boostrap at database open, return an error instead of allowing local files to be in inconsistent state. Note that we ignored boostrap errors to avoid probing the remote for generation when offline, but that I fixed now in a different way.
- If we have a database file... | 7fbef8358b8a504c368cbc1febf7413a0d9271e9 | 6c86667ff1378d80853a07cf7a3cf525cdc3d4ef | diff --git a/libsql/src/database.rs b/libsql/src/database.rs
index 322913eefc..5bacda9bf2 100644
--- a/libsql/src/database.rs
+++ b/libsql/src/database.rs
@@ -691,17 +691,16 @@ impl Database {
};
use tokio::sync::Mutex;
- let _ = tokio::task::block_in_place(move || {
+... | [
"libsql/src/database.rs",
"libsql/src/sync.rs"
] | [] | true | ||
tursodatabase/libsql | 2,147 | issue_to_patch | libsql: Remove lazy pulling optimization | The optimization attempts to reduce pulling when an application is writing. However, the logic is embedded in prepare(), which is totally wrong because a statement can be reused. Let's remove the optimization as incorrect.
Refs: tursodatabase/turso-cloud#5 | 7fbef8358b8a504c368cbc1febf7413a0d9271e9 | 5af391972fd2672cf7a0a28ac7ee0171e090636c | diff --git a/libsql/src/database.rs b/libsql/src/database.rs
index 322913eefc..11fa5dcd28 100644
--- a/libsql/src/database.rs
+++ b/libsql/src/database.rs
@@ -719,7 +719,6 @@ impl Database {
read_your_writes: *read_your_writes,
context: db.sync_ctx.clone().unwrap(),
... | [
"libsql/src/database.rs",
"libsql/src/sync/connection.rs",
"libsql/src/sync/statement.rs"
] | [] | true | ||
tursodatabase/libsql | 2,143 | issue_to_patch | fix null guards | 18cf8c747ea22c9ad7dea2cfd29beacde5f0aed2 | 77aaeeb3b57625d0db85a1032ed28ac23ebcfb28 | diff --git a/libsql-sys/src/wal/ffi.rs b/libsql-sys/src/wal/ffi.rs
index d9c6aaee07..fd3044665a 100644
--- a/libsql-sys/src/wal/ffi.rs
+++ b/libsql-sys/src/wal/ffi.rs
@@ -446,8 +446,8 @@ pub unsafe extern "C" fn checkpoint<T: Wal>(
_ => panic!("invalid checkpoint mode"),
};
- let in_wal = (!frames_in... | [
"libsql-sys/src/wal/ffi.rs"
] | [] | true | |||
tursodatabase/libsql | 2,141 | issue_to_patch | More immutable methods | The SQLite connection and statement objects are thread-safe. Let's mark more Rust methods as immutable so that applications don't need to keep wrapping `Connection` and `Statement` with `Mutex`, for example, for mutability. | a9c66e079d774e7e0154f2106f9b7a481e0b1fd4 | 0b4b3cacdc89af280d3f694ef12c130817f8fae5 | diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml
index 20281a7ab1..8e88a04140 100644
--- a/.github/workflows/rust.yml
+++ b/.github/workflows/rust.yml
@@ -23,6 +23,7 @@ jobs:
runs-on: ubuntu-latest
name: Run Checks
env:
+ RUST_BACKTRACE: 1
RUSTFLAGS: -D warnings --cfg toki... | [
".github/workflows/rust.yml",
"libsql-server/tests/standalone/mod.rs",
"libsql/benches/benchmark.rs",
"libsql/examples/deserialization.rs",
"libsql/examples/example.rs",
"libsql/examples/example_v2.rs",
"libsql/examples/flutter.rs",
"libsql/src/connection.rs",
"libsql/src/hrana/hyper.rs",
"libsql/... | [
{
"comment": "should we use `full`?",
"path": ".github/workflows/rust.yml",
"hunk": "@@ -23,6 +23,7 @@ jobs:\n runs-on: ubuntu-latest\n name: Run Checks\n env:\n+ RUST_BACKTRACE: 1",
"resolving_sha": "0b4b3cacdc89af280d3f694ef12c130817f8fae5",
"resolving_diff": "diff --git a/.gi... | diff --git a/libsql-server/tests/standalone/mod.rs b/libsql-server/tests/standalone/mod.rs
index 046f147d4d..ad3fae958b 100644
--- a/libsql-server/tests/standalone/mod.rs
+++ b/libsql-server/tests/standalone/mod.rs
@@ -422,7 +422,7 @@ async fn insert_rows(conn: &Connection, start: u32, count: u32) -> libsql::Resul
a... | true | |
tursodatabase/libsql | 2,029 | issue_to_patch | Bootstrap the db on `connect`
Right now we bootsrap the db only in `sync`, but should probably do during connect call as well. Do note that care must be taken to not call sycn after a connection is created, since bootstrap can replace the db file | Attempt to bootstrap the db on `connect` | Fixes #2024
Whenever `db.connect` is called, we will try to bootstrap the db if required | 361d082b7f63d5ecd918096c7d9894d8da6e3879 | f2f0eda72f247b56d0ea9f520d703a1110ac8062 | diff --git a/libsql/src/database.rs b/libsql/src/database.rs
index 838eeb267f..5f27081f33 100644
--- a/libsql/src/database.rs
+++ b/libsql/src/database.rs
@@ -675,6 +675,18 @@ impl Database {
};
use tokio::sync::Mutex;
+ let _ = tokio::task::block_in_place(move || {
+ ... | [
"libsql/src/database.rs",
"libsql/src/local/database.rs",
"libsql/src/sync.rs"
] | [
{
"comment": "This breaks Db initialization under Actix due to its blocking nature. It forces the user to separate the db initialization out of the actix main and create a custom main which initializes the db first in a multi-threaded Tokio runtime and then passes it to Actix.",
"path": "libsql/src/database... | true | |
tursodatabase/libsql | 2,118 | issue_to_patch | libsql: Use RwLock instead of RefCell for local connection | The `local::Connection` struct has the following safety comments:
```rust
// SAFETY: This is safe because we compile sqlite3 w/ SQLITE_THREADSAFE=1
unsafe impl Send for Connection {}
// SAFETY: This is safe because we compile sqlite3 w/ SQLITE_THREADSAFE=1
unsafe impl Sync for Connection {}
```
This is corre... | bc5d2eba7603b759a2e5dac27e688edbadd4374e | fb39e144dc073ef203d4e7dcd288cfbaad5b9649 | diff --git a/libsql/Cargo.toml b/libsql/Cargo.toml
index 9df2c3e537..2fce342a48 100644
--- a/libsql/Cargo.toml
+++ b/libsql/Cargo.toml
@@ -63,6 +63,7 @@ core = [
"dep:bitflags",
"dep:bytes",
"dep:futures",
+ "dep:parking_lot",
]
stream = [
"dep:futures",
diff --git a/libsql/src/local/connection.rs b/libs... | [
"libsql/Cargo.toml",
"libsql/src/local/connection.rs"
] | [] | true | ||
tursodatabase/libsql | 2,134 | issue_to_patch | do not open wal session from the beginning - wait for pulled frames | Otherwise, if client is on the checkpoint boundary and immediately get checkpoint command - we will crash with assertion
```
assert!(
!insert_handle.in_session(),
"WAL transaction must be finished"
);
``` | ebfe8e164d18242a8bcdf983ba8bcc986754b9ca | faffeb3b5356dbdae053f66828ffbaef45c789f6 | diff --git a/libsql/src/local/connection.rs b/libsql/src/local/connection.rs
index 2e3625b923..389ea33161 100644
--- a/libsql/src/local/connection.rs
+++ b/libsql/src/local/connection.rs
@@ -480,7 +480,7 @@ impl Connection {
let callback = authorizer_callback as unsafe extern "C" fn(_, _, _, _, _, _) -... | [
"libsql/src/local/connection.rs",
"libsql/src/sync.rs"
] | [] | true | ||
tursodatabase/turso | 7,464 | issue_to_patch | mvcc: some memory use improvements | Two primary changes here (represented in clanker chart as items 4 and 6)
1. Box RowKey enum variant with SortableIndexKey, shrinking other variant by 24 bytes
2. Stop cloning Row data on each mvcc read, switch to refcount bump
<img width="718" height="264" alt="image" src="https://github.com/user-attachments/as... | 1bb24c4638351685b792ccac96f375371c78eeca | 084ae81dfafae182e8a299ada9f02612d72100b9 | diff --git a/core/mvcc/database/checkpoint_state_machine.rs b/core/mvcc/database/checkpoint_state_machine.rs
index cb07fcf6a0..7ad97b267b 100644
--- a/core/mvcc/database/checkpoint_state_machine.rs
+++ b/core/mvcc/database/checkpoint_state_machine.rs
@@ -1743,7 +1743,7 @@ impl<Clock: LogicalClock> CheckpointStateMachin... | [
"core/mvcc/database/checkpoint_state_machine.rs",
"core/mvcc/database/mod.rs"
] | [] | true | ||
tursodatabase/turso | 7,462 | issue_to_patch | simulator: dont rollback simulator connection level transaction state for create table failure | found by the following simulator seed failure:
```console
./target/debug/limbo_sim --maximum-tests 1000 \
--min-tick 10 --max-tick 50 --io-backend=memory \
--seed 11558114576248437680
```
which showed that the database had more rows than the simulator model. clanker tracked down the issue being that for a `CREAT... | 083ccc811d67256ad7375bbb84ad8276a46b2c48 | a0ef2726ef25421dd8e5e7e9a2971e2a5e007b97 | diff --git a/testing/simulator/generation/property.rs b/testing/simulator/generation/property.rs
index 88486a5d5af..7ddd8c1729f 100644
--- a/testing/simulator/generation/property.rs
+++ b/testing/simulator/generation/property.rs
@@ -624,14 +624,16 @@ impl Property {
let table_name = create.table.name.c... | [
"testing/simulator/generation/property.rs"
] | [] | true | ||
tursodatabase/turso | 7,443 | issue_to_patch | Add .NET NuGet package publishing workflow | ## Summary
This adds the initial GitHub Actions workflow and package structure needed to build and validate the Turso .NET NuGet package.
The workflow builds the native SDK-kit library for all supported runtime identifiers, packages the managed .NET bindings into a single `Turso.Data.Sqlite` NuGet package, uploads th... | 1bb24c4638351685b792ccac96f375371c78eeca | 7869be78a63990ae1402af019def98a2f248bbb9 | diff --git a/.github/workflows/dotnet-publish.yml b/.github/workflows/dotnet-publish.yml
index 12fcfd05ba6..8b7b08fb137 100644
--- a/.github/workflows/dotnet-publish.yml
+++ b/.github/workflows/dotnet-publish.yml
@@ -1,47 +1,88 @@
name: Dotnet Publish
on:
- # Manually trigger the workflow
+ push:
+ branches:
+... | [
".github/workflows/dotnet-publish.yml",
".gitignore",
"CONTRIBUTING.md",
"bindings/dotnet/Directory.Build.props",
"bindings/dotnet/Directory.Build.targets",
"bindings/dotnet/Makefile",
"bindings/dotnet/Readme.md",
"bindings/dotnet/Turso.slnx",
"bindings/dotnet/src/Benchmarks/Benchmarks.csproj",
"b... | [] | true | ||
tursodatabase/turso | 7,423 | issue_to_patch | mvcc: add sequence_watermark function and track sequence allocations | This PR adds `sequence_watermark(name)` as a scalar function for MVCC sequence users.
The function returns the first sequence value that is not safe for cursor-based readers to pass. Sync can use it as an exclusive upper bound, for example:
```sql
SELECT * FROM turso_cdc
WHERE change_id > ?
AND change_id < s... | aa56944dc2d47eac747129a92d186022042f0cb0 | e3504b6f9f8c0587ab03420bfc899e83c4855964 | diff --git a/core/connection.rs b/core/connection.rs
index 57bca7a8b42..9b6c5af0f2e 100644
--- a/core/connection.rs
+++ b/core/connection.rs
@@ -213,6 +213,13 @@ enum ReparsePhase {
stmt: Option<Box<Statement>>,
/// Descriptor row `(start, inc, min, max, cycle)` captured from `stmt`.
meta: Op... | [
"core/connection.rs",
"core/function.rs",
"core/mvcc/database/mod.rs",
"core/mvcc/database/tests.rs",
"core/translate/expr/translator.rs",
"core/translate/sequence.rs",
"core/vdbe/execute.rs",
"core/vdbe/explain.rs",
"core/vdbe/insn.rs"
] | [
{
"comment": "should we split_once and check schema if present?",
"path": "core/vdbe/execute.rs",
"hunk": "@@ -11712,6 +11745,72 @@ pub fn op_set_sequence_currval(\n Ok(InsnFunctionStepResult::Step)\n }\n \n+/// Publish sequence allocation metadata used by `sequence_watermark()`.\n+///\n+/// The tra... | true | ||
tursodatabase/turso | 7,425 | issue_to_patch | core, sdk-kit: ColumnTypeInfo for custom-type-aware column metadata | ## Summary
- Adds `Statement::get_column_type_info` — a Turso-specific column metadata API that returns declared name, array dimensions, base type, and kind (Builtin/Custom/Domain/Struct/Union) for schema-tagged columns, and inferred primitive types for computed expressions. Gated behind `--experimental-custom-types`; ... | a85e52f808ac30cab418444a04cd2c73cebfad19 | 035b69b1e0f291f1410c78af3d3074c9461b8e2f | diff --git a/core/lib.rs b/core/lib.rs
index cdc9b3de412..92a8a374d69 100644
--- a/core/lib.rs
+++ b/core/lib.rs
@@ -146,7 +146,7 @@ pub use io::{
WriteCompletion, IO,
};
pub use numeric::{nonnan::NonNan, Numeric};
-pub use statement::{Statement, StatementStatusCounter};
+pub use statement::{ColumnTypeInfo, Colu... | [
"core/lib.rs",
"core/statement.rs",
"sdk-kit/src/bindings.rs",
"sdk-kit/src/capi.rs",
"sdk-kit/src/rsapi.rs",
"sdk-kit/turso.h",
"tests/integration/mod.rs",
"tests/integration/statement_metadata.rs"
] | [] | diff --git a/tests/integration/mod.rs b/tests/integration/mod.rs
index 6d1bb96390c..a3d8bd032df 100644
--- a/tests/integration/mod.rs
+++ b/tests/integration/mod.rs
@@ -15,6 +15,7 @@ mod query_processing;
mod query_timeout;
mod queued_io;
mod reindex;
+mod statement_metadata;
mod statement_reset;
mod stmt_journal;... | true | |
tursodatabase/turso | 7,439 | issue_to_patch | Refactor memory benchmark into library + add CodSpeed CI tracking | ## Description
Refactors the memory benchmark crate into a reusable library and adds CodSpeed-instrumented benchmarks for allocation regression tracking in CI.
**Library refactoring:**
- Extract workload execution logic into `memory_benchmark::workload` module with public `run_workload()`, `WorkloadConfig`, and ... | fced14a6f6a0521c07b900608141be3d0106bddc | 50b36b66936503c653e5e7195b11f8264436fa97 | diff --git a/.claude/skills/memory-benchmark/SKILL.md b/.claude/skills/memory-benchmark/SKILL.md
index 5f6cd4a6ff1..c3fe9062420 100644
--- a/.claude/skills/memory-benchmark/SKILL.md
+++ b/.claude/skills/memory-benchmark/SKILL.md
@@ -15,9 +15,17 @@ instead of parsing stderr log text.
## Location
- Benchmark crate: `... | [
".claude/skills/memory-benchmark/SKILL.md",
".github/workflows/codspeed-memory.yml",
"Cargo.lock",
"Cargo.toml",
"perf/memory/Cargo.toml",
"perf/memory/codspeed/Cargo.toml",
"perf/memory/codspeed/benches/memory_profiles.rs",
"perf/memory/src/lib.rs",
"perf/memory/src/main.rs",
"perf/memory/src/pro... | [] | true | ||
tursodatabase/turso | 7,482 | issue_to_patch | core/skiplist: use TursoAllocator for node allocation and add fallible inserts | Human Pedro:
Very big step. There are some tests with allocator stuff here and it works! Very happy with the result. Was easier than I thought. The nice thing about this is that is works on stable as well :) . Next up I will add a Allocator bound to MvStore so that we can add tests independently to check that MvStore ... | fced14a6f6a0521c07b900608141be3d0106bddc | ee7c8a714fc0460447275bba775dd1b35b672bc2 | diff --git a/core/alloc/mod.rs b/core/alloc/mod.rs
index b4cb654917..ed01faaa08 100644
--- a/core/alloc/mod.rs
+++ b/core/alloc/mod.rs
@@ -10,6 +10,9 @@ mod api;
mod backend;
mod collections;
+/// The underlying allocator trait: `allocator_api2::alloc::Allocator` on
+/// stable, `std::alloc::Allocator` on `--cfg ni... | [
"core/alloc/mod.rs",
"core/skiplist/alloc_helper.rs",
"core/skiplist/base.rs",
"core/skiplist/base_tests.rs",
"core/skiplist/map.rs",
"core/skiplist/map_tests.rs",
"core/skiplist/mod.rs",
"core/skiplist/set.rs",
"core/skiplist/set_tests.rs"
] | [] | true | ||
tursodatabase/turso | 7,467 | issue_to_patch | mem usage in MVCC: pack timestamp begin/end in RowVersion | This is meant to be stacked on top of #7464
This packs the begin + end timestamps in RowVersion, bringing each field from 16B to 8B
<img width="795" height="283" alt="image" src="https://github.com/user-attachments/assets/a94e8b2a-8b0b-4126-b9f7-5c02029d7952" />
| 1bb24c4638351685b792ccac96f375371c78eeca | 3aaa45adae1acda6a34039f72a5361596c42a2b4 | diff --git a/core/mvcc/database/checkpoint_state_machine.rs b/core/mvcc/database/checkpoint_state_machine.rs
index cb07fcf6a0..990d6c4eff 100644
--- a/core/mvcc/database/checkpoint_state_machine.rs
+++ b/core/mvcc/database/checkpoint_state_machine.rs
@@ -386,7 +386,7 @@ fn sqlite_schema_versions_refer_to_btree(lhs: &Ro... | [
"core/mvcc/database/checkpoint_state_machine.rs",
"core/mvcc/database/mod.rs",
"core/mvcc/database/tests.rs",
"core/mvcc/persistent_storage/logical_log.rs"
] | [] | true | ||
tursodatabase/turso | 7,465 | issue_to_patch | core/mvcc: RowKey::Record set to Arc | ## Description
There were things that wasted a lot of memory a cpu cycles because we cloned to create a `RowKey::Record`. In theory we only ever need one copy of payloads and it should be on `index_rows` so everything else should be cloned with `Arc`
1. `row.clone()` into the new RowVersion
2. `row.id.clone()` int... | 083ccc811d67256ad7375bbb84ad8276a46b2c48 | 13b0fe4288114b0315b5110a7c81c797cc4543e6 | diff --git a/core/mvcc/cursor.rs b/core/mvcc/cursor.rs
index 6c40b84b4f..9ef3712ab0 100644
--- a/core/mvcc/cursor.rs
+++ b/core/mvcc/cursor.rs
@@ -790,10 +790,10 @@ impl<Clock: LogicalClock + 'static> MvccLazyCursor<Clock> {
}
};
Ok(maybe_record.map(|record| {
- ... | [
"core/mvcc/cursor.rs",
"core/mvcc/database/checkpoint_state_machine.rs",
"core/mvcc/database/mod.rs",
"core/mvcc/database/tests.rs",
"core/mvcc/persistent_storage/logical_log.rs"
] | [] | true | ||
tursodatabase/turso | 7,468 | issue_to_patch | core: make the nightly allocator cfg build green and gate it in CI | Human Pedro explanations:
I was doing stuff more incrementally because I wanted to start changing the interfaces first to accept a Result, and then do the migration with the Nightly types in 1 go. But we need to have these things here now, so that is what I'm trying to do. This PR changes types (either converts more p... | 083ccc811d67256ad7375bbb84ad8276a46b2c48 | ec9293f13b3725fc5299311088cfbad170c1d983 | diff --git a/.github/workflows/nightly-cfg.yml b/.github/workflows/nightly-cfg.yml
new file mode 100644
index 00000000000..58b9ac13ac0
--- /dev/null
+++ b/.github/workflows/nightly-cfg.yml
@@ -0,0 +1,51 @@
+name: Nightly cfg
+
+# Checks that core still compiles with `--cfg nightly`, where the
+# crate::alloc aliases be... | [
".github/workflows/nightly-cfg.yml",
"core/alloc/collections/arc.rs",
"core/alloc/collections/binary_heap.rs",
"core/alloc/collections/boxed.rs",
"core/alloc/collections/btree_map.rs",
"core/alloc/collections/btree_set.rs",
"core/alloc/collections/linked_list.rs",
"core/alloc/collections/mod.rs",
"c... | [] | true | ||
tursodatabase/turso | 7,403 | issue_to_patch | serverless/javascript: add option for custom request headers | Simple PR to allow user to set arbitrary request headers for serverless driver. For example:
```js
const conn = connect({
url: process.env.TURSO_DATABASE_URL,
authToken: process.env.TURSO_AUTH_TOKEN,
requestHeaders: { "x-custom-header": "value" },
});
```
| 51de91ea80f0c06c3a5377eba65e94f33d4f1f00 | 90ae357645f55fe0c053757984992d6ea1048dd4 | diff --git a/serverless/javascript/README.md b/serverless/javascript/README.md
index 2d2f01f284c..fb3f42d8c9d 100644
--- a/serverless/javascript/README.md
+++ b/serverless/javascript/README.md
@@ -70,6 +70,21 @@ await conn.transaction(async () => {
}).concurrent();
```
+### Custom Headers
+
+Requests can carry extr... | [
"serverless/javascript/README.md",
"serverless/javascript/integration-tests/protocol.test.mjs",
"serverless/javascript/src/protocol.ts",
"serverless/javascript/src/session.ts"
] | [] | diff --git a/serverless/javascript/integration-tests/protocol.test.mjs b/serverless/javascript/integration-tests/protocol.test.mjs
index 0bad03bbd6d..01cc97434ba 100644
--- a/serverless/javascript/integration-tests/protocol.test.mjs
+++ b/serverless/javascript/integration-tests/protocol.test.mjs
@@ -1,6 +1,7 @@
import... | true | |
tursodatabase/turso | 7,445 | issue_to_patch | core/translate: Improve DDL compatibility with SQLite | A user reported that bracket-quoted identifiers and repeated CREATE VIEW IF NOT EXISTS reject in Turso but work in SQLite, forcing them to run migrations through stdlib sqlite3. A differential sweep of DDL statements against sqlite3 confirmed those and surfaced several more gaps, all fixed here.
Parser ([bracket] qu... | e773cdd5b743130d80a112c09f7018c1c55ffa09 | d95f2bdcac55bbe20b6079cc15c9813654245a91 | diff --git a/core/schema.rs b/core/schema.rs
index 5a93fbf03fe..600325e1859 100644
--- a/core/schema.rs
+++ b/core/schema.rs
@@ -792,6 +792,12 @@ pub struct Schema {
/// Track views that exist but have incompatible versions
pub incompatible_views: HashSet<String>,
+ /// View rows in sqlite_schema whose s... | [
"core/schema.rs",
"core/translate/alter.rs",
"core/translate/collate.rs",
"core/translate/mod.rs",
"core/translate/planner.rs",
"core/translate/view.rs",
"core/util.rs",
"core/vdbe/execute.rs",
"parser/src/parser.rs",
"testing/sqltests/database/testing_legacy_unquoted_view_columns.db",
"testing/... | [] | diff --git a/testing/sqltests/tests/alter_table.sqltest b/testing/sqltests/tests/alter_table.sqltest
index b14bf4c1436..efd4409ad2e 100644
--- a/testing/sqltests/tests/alter_table.sqltest
+++ b/testing/sqltests/tests/alter_table.sqltest
@@ -2908,3 +2908,26 @@ expect {
table|purchases|purchases
trigger|tr|purc... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.