repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
unopim/unopim | 448 | issue_to_patch | fix(webhook): validate URL on save and harden logs status filter (2.1 backport of #398) | validate URL on save and harden logs status filter
Backport of #398 to 2.1. | 87aa8000b838e5ced02a5c0d032869a0c9233588 | f45d82dc212466dc1e462361d355425a77e12cce | diff --git a/packages/Webkul/Webhook/src/DataGrids/LogsDataGrid.php b/packages/Webkul/Webhook/src/DataGrids/LogsDataGrid.php
index f2b11f4b5..f63238fe4 100644
--- a/packages/Webkul/Webhook/src/DataGrids/LogsDataGrid.php
+++ b/packages/Webkul/Webhook/src/DataGrids/LogsDataGrid.php
@@ -28,7 +28,8 @@ public function prepa... | [
"packages/Webkul/Admin/tests/Feature/Webhook/WebhookLogsFilterTest.php",
"packages/Webkul/Admin/tests/Feature/Webhook/WebhookSettingsValidationTest.php",
"packages/Webkul/Admin/tests/Feature/Webhook/WebhookStatusTest.php",
"packages/Webkul/Webhook/src/DataGrids/LogsDataGrid.php",
"packages/Webkul/Webhook/sr... | [
{
"comment": "The validation rule accepts the strings `'true'` and `'false'` for `webhook_active`, but `(int) 'true'` evaluates to `0` in PHP. As a result, a request with `webhook_active=true` will pass the `required_if:webhook_active,1,true` check (so a URL is required), yet `$active === 1` on line 56 will be ... | diff --git a/packages/Webkul/Admin/tests/Feature/Webhook/WebhookLogsFilterTest.php b/packages/Webkul/Admin/tests/Feature/Webhook/WebhookLogsFilterTest.php
index 883f5fc10..64160179b 100644
--- a/packages/Webkul/Admin/tests/Feature/Webhook/WebhookLogsFilterTest.php
+++ b/packages/Webkul/Admin/tests/Feature/Webhook/Webho... | true | |
unopim/unopim | 448 | comment_to_fix | fix(webhook): validate URL on save and harden logs status filter (2.1 backport of #398) | The validation rule accepts the strings `'true'` and `'false'` for `webhook_active`, but `(int) 'true'` evaluates to `0` in PHP. As a result, a request with `webhook_active=true` will pass the `required_if:webhook_active,1,true` check (so a URL is required), yet `$active === 1` on line 56 will be false — the probe is s... | 87aa8000b838e5ced02a5c0d032869a0c9233588 | f45d82dc212466dc1e462361d355425a77e12cce | diff --git a/packages/Webkul/Webhook/src/Http/Controllers/WebhookSettingsController.php b/packages/Webkul/Webhook/src/Http/Controllers/WebhookSettingsController.php
index e1af17f4f..93c375a96 100644
--- a/packages/Webkul/Webhook/src/Http/Controllers/WebhookSettingsController.php
+++ b/packages/Webkul/Webhook/src/Http/C... | [
"packages/Webkul/Webhook/src/Http/Controllers/WebhookSettingsController.php"
] | [
{
"comment": "The validation rule accepts the strings `'true'` and `'false'` for `webhook_active`, but `(int) 'true'` evaluates to `0` in PHP. As a result, a request with `webhook_active=true` will pass the `required_if:webhook_active,1,true` check (so a URL is required), yet `$active === 1` on line 56 will be ... | true | ||
unopim/unopim | 448 | comment_to_fix | fix(webhook): validate URL on save and harden logs status filter (2.1 backport of #398) | `buildStatusFilterOptions()` runs a `SELECT DISTINCT status, extra->response->status` against `webhook_logs` on every datagrid render (column preparation) with no caching or bound limit. On installations with large webhook log tables this can become an expensive scan for what is purely a UI affordance (building filter ... | 87aa8000b838e5ced02a5c0d032869a0c9233588 | f45d82dc212466dc1e462361d355425a77e12cce | diff --git a/packages/Webkul/Webhook/src/DataGrids/LogsDataGrid.php b/packages/Webkul/Webhook/src/DataGrids/LogsDataGrid.php
index f2b11f4b5..f63238fe4 100644
--- a/packages/Webkul/Webhook/src/DataGrids/LogsDataGrid.php
+++ b/packages/Webkul/Webhook/src/DataGrids/LogsDataGrid.php
@@ -28,7 +28,8 @@ public function prepa... | [
"packages/Webkul/Webhook/src/DataGrids/LogsDataGrid.php"
] | [
{
"comment": "`buildStatusFilterOptions()` runs a `SELECT DISTINCT status, extra->response->status` against `webhook_logs` on every datagrid render (column preparation) with no caching or bound limit. On installations with large webhook log tables this can become an expensive scan for what is purely a UI afford... | true | ||
unopim/unopim | 448 | comment_to_fix | fix(webhook): validate URL on save and harden logs status filter (2.1 backport of #398) | `testWebhookUrl()` issues a server-side POST to whatever URL the admin supplies, with no host/IP allow-listing or block-listing. This is a server-side request forgery (SSRF) primitive: an admin (or anyone who compromises an admin session) can probe internal services such as `http://127.0.0.1:…`, `http://169.254.169.254... | 87aa8000b838e5ced02a5c0d032869a0c9233588 | f45d82dc212466dc1e462361d355425a77e12cce | diff --git a/packages/Webkul/Webhook/src/Http/Controllers/WebhookSettingsController.php b/packages/Webkul/Webhook/src/Http/Controllers/WebhookSettingsController.php
index e1af17f4f..93c375a96 100644
--- a/packages/Webkul/Webhook/src/Http/Controllers/WebhookSettingsController.php
+++ b/packages/Webkul/Webhook/src/Http/C... | [
"packages/Webkul/Webhook/src/Http/Controllers/WebhookSettingsController.php"
] | [
{
"comment": "`testWebhookUrl()` issues a server-side POST to whatever URL the admin supplies, with no host/IP allow-listing or block-listing. This is a server-side request forgery (SSRF) primitive: an admin (or anyone who compromises an admin session) can probe internal services such as `http://127.0.0.1:…`, `... | true | ||
unoplatform/uno | 23,442 | issue_to_patch | fix(wasm): skip a11y focus sync for elements without a semantic peer | **GitHub Issue:** related https://github.com/unoplatform/studio.live/issues/2620
## PR Type
Bug fix.
## What is the current behavior?
On the Skia WebAssembly browser target, the accessibility bridge floods the browser console with:
```
[A11y] focusSemanticElement: element NOT FOUND handle=NNNN (after re... | 69a539c84ddb6094d71f10ea053a45d4ac0dfcbb | 9b2e8408eaf0bfdec3206b78b169b743c1e268b0 | diff --git a/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs b/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs
index 377d3898a716..e4643db56809 100644
--- a/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs
+... | [
"src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs"
] | [
{
"comment": "Unnecessary comment",
"path": "src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs",
"hunk": "@@ -1743,7 +1743,16 @@ public override void OnAutomationEvent(AutomationPeer peer, AutomationEvents eve\n \t\t\t\t\t{\n \t\t\t\t\t\tthis.Log().Trace($\"[A11y] AUT... | true | ||
unoplatform/uno | 23,442 | comment_to_fix | fix(wasm): skip a11y focus sync for elements without a semantic peer | Unnecessary comment | 69a539c84ddb6094d71f10ea053a45d4ac0dfcbb | 9b2e8408eaf0bfdec3206b78b169b743c1e268b0 | diff --git a/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs b/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs
index 377d3898a716..e4643db56809 100644
--- a/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs
+... | [
"src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs"
] | [
{
"comment": "Unnecessary comment",
"path": "src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs",
"hunk": "@@ -1743,7 +1743,16 @@ public override void OnAutomationEvent(AutomationPeer peer, AutomationEvents eve\n \t\t\t\t\t{\n \t\t\t\t\t\tthis.Log().Trace($\"[A11y] AUT... | true | ||
unoplatform/uno | 23,442 | comment_to_fix | fix(wasm): skip a11y focus sync for elements without a semantic peer | Unnecessary comment | 69a539c84ddb6094d71f10ea053a45d4ac0dfcbb | 9b2e8408eaf0bfdec3206b78b169b743c1e268b0 | diff --git a/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs b/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs
index 377d3898a716..e4643db56809 100644
--- a/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs
+... | [
"src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs"
] | [
{
"comment": "Unnecessary comment",
"path": "src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Accessibility/WebAssemblyAccessibility.cs",
"hunk": "@@ -1838,7 +1847,15 @@ protected override void UpdateIsOffscreen(nint handle, bool isOffscreen)\n \t\t}\n \t}\n \tprotected override void SetNativeFocus(nint hand... | true | ||
unoplatform/uno | 23,448 | issue_to_patch | fix(scrollviewer): Arm offset intent on scrollbar drag | **GitHub Issue:** closes https://github.com/unoplatform/kahua-private/issues/490
## PR Type:
🐞 Bugfix
## What changed? 🚀
On the Skia `ScrollViewer`, dragging the scrollbar **thumb** (and track-paging / line-steps) stopped moving the content after any programmatic scroll — e.g. a `ScrollToVerticalOffset(.... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 7db28233d02905579d974138acd8b5db312e0bf7 | diff --git a/src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs b/src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs
index 6c0425936649..293024e57412 100644
--- a/src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs
+++ b/src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs
@@ -1207,7 +1207,8 @@ pri... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs",
"src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs"
] | [
{
"comment": "The test calls OnVerticalScrollBarScrolled with `sut.Scroller` as the `sender`, but in production this handler is subscribed to the *vertical ScrollBar* (`_verticalScrollbar.Scroll += ...`), so the sender is the ScrollBar. Passing the actual scrollbar here makes the test better reflect the real ev... | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs
index e7ea31d14ecc..3022b2d75b3c 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater... | true | |
unoplatform/uno | 23,448 | comment_to_fix | fix(scrollviewer): Arm offset intent on scrollbar drag | The test calls OnVerticalScrollBarScrolled with `sut.Scroller` as the `sender`, but in production this handler is subscribed to the *vertical ScrollBar* (`_verticalScrollbar.Scroll += ...`), so the sender is the ScrollBar. Passing the actual scrollbar here makes the test better reflect the real event path and avoids fu... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 7db28233d02905579d974138acd8b5db312e0bf7 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs
index e7ea31d14ecc..3022b2d75b3c 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs"
] | [
{
"comment": "The test calls OnVerticalScrollBarScrolled with `sut.Scroller` as the `sender`, but in production this handler is subscribed to the *vertical ScrollBar* (`_verticalScrollbar.Scroll += ...`), so the sender is the ScrollBar. Passing the actual scrollbar here makes the test better reflect the real ev... | true | ||
unoplatform/uno | 23,448 | comment_to_fix | fix(scrollviewer): Arm offset intent on scrollbar drag | ```suggestion
Assert.Inconclusive("not application for winui");
``` | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 7db28233d02905579d974138acd8b5db312e0bf7 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs
index e7ea31d14ecc..3022b2d75b3c 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs"
] | [
{
"comment": "```suggestion\n\t\tAssert.Inconclusive(\"not application for winui\");\n```",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs",
"hunk": "@@ -536,6 +536,69 @@ public async Task When_ScrollBarThumbDragged_Then_OffsetTracksRequestMono... | true | ||
unoplatform/uno | 23,448 | comment_to_fix | fix(scrollviewer): Arm offset intent on scrollbar drag | why are we giving such a wide error margin for the assert? 0.3x vs 0.1x and 0.7x vs 0.5x
arent we testing against the same value? unless we have snap to item, but that is not clarified in code/comment. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 7db28233d02905579d974138acd8b5db312e0bf7 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs
index e7ea31d14ecc..3022b2d75b3c 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs"
] | [
{
"comment": "why are we giving such a wide error margin for the assert? 0.3x vs 0.1x and 0.7x vs 0.5x\narent we testing against the same value? unless we have snap to item, but that is not clarified in code/comment.",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRe... | true | ||
unoplatform/uno | 23,448 | comment_to_fix | fix(scrollviewer): Arm offset intent on scrollbar drag | Typo/grammar in the inconclusive message: "not application for winui" should be "not applicable for WinUI" (and consistent capitalization). | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 7db28233d02905579d974138acd8b5db312e0bf7 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs
index e7ea31d14ecc..3022b2d75b3c 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs"
] | [
{
"comment": "Typo/grammar in the inconclusive message: \"not application for winui\" should be \"not applicable for WinUI\" (and consistent capitalization).",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs",
"hunk": "@@ -536,6 +536,69 @@ publi... | true | ||
unoplatform/uno | 23,448 | comment_to_fix | fix(scrollviewer): Arm offset intent on scrollbar drag | ```suggestion
Assert.Inconclusive("not applicable for winappsdk: no backdoor available");
``` | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 7db28233d02905579d974138acd8b5db312e0bf7 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs
index e7ea31d14ecc..3022b2d75b3c 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs"
] | [
{
"comment": "```suggestion\r\n\t\tAssert.Inconclusive(\"not applicable for winappsdk: no backdoor available\");\r\n```",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater_FastScroll.cs",
"hunk": "@@ -536,6 +536,78 @@ public async Task When_ScrollBarThumbDragge... | true | ||
unoplatform/uno | 23,420 | issue_to_patch | fix: Report UIA IsOffscreen for clipped elements | **GitHub Issue:** closes unoplatform/kahua-private#495
## PR Type:
🐞 Bugfix
## What changed? 🚀
The UI Automation `IsOffscreen` property always returned `false`, even for an element scrolled out of a `ScrollViewer`'s viewport (visible to tools like Windows Inspect). `AutomationPeer.IsOffscreen()` determines off-sc... | 69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b | 75f380d3da25602177af52d8584e501e090c1cc1 | diff --git a/src/SamplesApp/SamplesApp.Samples/Windows_UI.Xaml_Automation/AccessibilityScreenReaderPage.xaml b/src/SamplesApp/SamplesApp.Samples/Windows_UI.Xaml_Automation/AccessibilityScreenReaderPage.xaml
index 163e5e4ffa5d..4d1952a611da 100644
--- a/src/SamplesApp/SamplesApp.Samples/Windows_UI.Xaml_Automation/Access... | [
"src/SamplesApp/SamplesApp.Samples/Windows_UI.Xaml_Automation/AccessibilityScreenReaderPage.xaml",
"src/SamplesApp/SamplesApp.Samples/Windows_UI.Xaml_Automation/AccessibilityScreenReaderPage.xaml.cs",
"src/Uno.UI.Composition/Composition/Visual.skia.cs",
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Automatio... | [
{
"comment": "This test is currently only excluded on NativeWasm/NativeMobile, but `AutomationPeer.IsOffscreenImpl` (and `UIElement.GetGlobalBoundsWithOptions`) are guarded by `#if __SKIA__`. On `RuntimeTestPlatforms.NativeWinUI`, `IsOffscreen()` will always return false, so this test would fail if it runs ther... | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Automation/Given_AutomationPeer.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Automation/Given_AutomationPeer.cs
index f81f65c1e1ad..f7d4488daa68 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Automation/Given_AutomationPeer.cs
+++ b/src/Uno.UI... | true | |
unoplatform/uno | 23,420 | comment_to_fix | fix: Report UIA IsOffscreen for clipped elements | This test is currently only excluded on NativeWasm/NativeMobile, but `AutomationPeer.IsOffscreenImpl` (and `UIElement.GetGlobalBoundsWithOptions`) are guarded by `#if __SKIA__`. On `RuntimeTestPlatforms.NativeWinUI`, `IsOffscreen()` will always return false, so this test would fail if it runs there. Restrict the test t... | 69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b | 75f380d3da25602177af52d8584e501e090c1cc1 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Automation/Given_AutomationPeer.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Automation/Given_AutomationPeer.cs
index f81f65c1e1ad..f7d4488daa68 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Automation/Given_AutomationPeer.cs
+++ b/src/Uno.UI... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Automation/Given_AutomationPeer.cs"
] | [
{
"comment": "This test is currently only excluded on NativeWasm/NativeMobile, but `AutomationPeer.IsOffscreenImpl` (and `UIElement.GetGlobalBoundsWithOptions`) are guarded by `#if __SKIA__`. On `RuntimeTestPlatforms.NativeWinUI`, `IsOffscreen()` will always return false, so this test would fail if it runs ther... | true | ||
unoplatform/uno | 23,420 | comment_to_fix | fix: Report UIA IsOffscreen for clipped elements | `OnPageLoaded` subscribes to `LayoutUpdated` every time `Loaded` fires, but the handler is never unsubscribed (and `Loaded` isn’t detached either). If the control is reloaded, this will accumulate duplicate subscriptions and cause repeated refreshes per layout pass. Make the subscription idempotent (or unsubscribe on u... | 69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b | 75f380d3da25602177af52d8584e501e090c1cc1 | diff --git a/src/SamplesApp/SamplesApp.Samples/Windows_UI.Xaml_Automation/AccessibilityScreenReaderPage.xaml.cs b/src/SamplesApp/SamplesApp.Samples/Windows_UI.Xaml_Automation/AccessibilityScreenReaderPage.xaml.cs
index 593fbc004500..4af22faaa8af 100644
--- a/src/SamplesApp/SamplesApp.Samples/Windows_UI.Xaml_Automation/... | [
"src/SamplesApp/SamplesApp.Samples/Windows_UI.Xaml_Automation/AccessibilityScreenReaderPage.xaml.cs"
] | [
{
"comment": "`OnPageLoaded` subscribes to `LayoutUpdated` every time `Loaded` fires, but the handler is never unsubscribed (and `Loaded` isn’t detached either). If the control is reloaded, this will accumulate duplicate subscriptions and cause repeated refreshes per layout pass. Make the subscription idempoten... | true | ||
unoplatform/uno | 23,415 | issue_to_patch | fix(theming): don't dim disabled ListView/GridView item content | **GitHub Issue:** closes https://github.com/unoplatform/kahua-private/issues/491
## PR Type:
🐞 Bugfix
## What changed? 🚀
In the Fluent (v2) theme, a checked, disabled `CheckBox` rendered **dimmer when hosted inside a disabled `ListView`** than the same `CheckBox` standalone.
The default `ListViewItemEx... | 69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b | 40bf777a5c7b9f850d16ad9d2743523550e41fdf | diff --git a/src/SamplesApp/SamplesApp.Samples/Windows_UI_Xaml_Controls/CheckBoxTests/CheckBox_DisabledInDisabledListView.xaml b/src/SamplesApp/SamplesApp.Samples/Windows_UI_Xaml_Controls/CheckBoxTests/CheckBox_DisabledInDisabledListView.xaml
new file mode 100644
index 000000000000..88b136908523
--- /dev/null
+++ b/src... | [
"src/SamplesApp/SamplesApp.Samples/Windows_UI_Xaml_Controls/CheckBoxTests/CheckBox_DisabledInDisabledListView.xaml",
"src/SamplesApp/SamplesApp.Samples/Windows_UI_Xaml_Controls/CheckBoxTests/CheckBox_DisabledInDisabledListView.xaml.cs",
"src/Uno.UI.FluentTheme.v2/Resources/Version2/PriorityDefault/GridViewItem_... | [
{
"comment": "Variable names in this test are misleading: `enabledItemCheckBox` / `disabledItemCheckBox` are both `IsEnabled = false`, so the distinction is actually whether the *ListViewItem container* is enabled/disabled. Renaming avoids confusion when maintaining the test logic.",
"path": "src/Uno.UI.Run... | diff --git a/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs b/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs
new file mode 100644
index 000000000000..6e2f790e67a8
--- /dev/null
+++ b/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs
@@ -0,... | true | |
unoplatform/uno | 23,415 | comment_to_fix | fix(theming): don't dim disabled ListView/GridView item content | Variable names in this test are misleading: `enabledItemCheckBox` / `disabledItemCheckBox` are both `IsEnabled = false`, so the distinction is actually whether the *ListViewItem container* is enabled/disabled. Renaming avoids confusion when maintaining the test logic. | 69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b | 40bf777a5c7b9f850d16ad9d2743523550e41fdf | diff --git a/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs b/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs
new file mode 100644
index 000000000000..6e2f790e67a8
--- /dev/null
+++ b/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs
@@ -0,... | [
"src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs"
] | [
{
"comment": "Variable names in this test are misleading: `enabledItemCheckBox` / `disabledItemCheckBox` are both `IsEnabled = false`, so the distinction is actually whether the *ListViewItem container* is enabled/disabled. Renaming avoids confusion when maintaining the test logic.",
"path": "src/Uno.UI.Run... | true | ||
unoplatform/uno | 23,415 | comment_to_fix | fix(theming): don't dim disabled ListView/GridView item content | `enabledItemCheckBox`/`disabledItemCheckBox` are referenced later in this test, but the locals declared here are named `checkBoxInEnabledItem`/`checkBoxInDisabledItem`. As-is, this won’t compile (and `WaitForLoaded(disabledItemCheckBox)` will also fail). Rename the locals (and update the ListViewItem content) so the id... | 69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b | 40bf777a5c7b9f850d16ad9d2743523550e41fdf | diff --git a/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs b/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs
new file mode 100644
index 000000000000..6e2f790e67a8
--- /dev/null
+++ b/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs
@@ -0,... | [
"src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs"
] | [
{
"comment": "`enabledItemCheckBox`/`disabledItemCheckBox` are referenced later in this test, but the locals declared here are named `checkBoxInEnabledItem`/`checkBoxInDisabledItem`. As-is, this won’t compile (and `WaitForLoaded(disabledItemCheckBox)` will also fail). Rename the locals (and update the ListViewI... | true | ||
unoplatform/uno | 23,415 | comment_to_fix | fix(theming): don't dim disabled ListView/GridView item content | `FindVisualChildByName("NormalRectangle")` is cast with a direct `(Rectangle)` cast. If the template part exists but its type changes, this will throw `InvalidCastException` before the assertion, making failures harder to diagnose. Prefer `as Rectangle` and assert on the result. | 69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b | 40bf777a5c7b9f850d16ad9d2743523550e41fdf | diff --git a/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs b/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs
new file mode 100644
index 000000000000..6e2f790e67a8
--- /dev/null
+++ b/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs
@@ -0,... | [
"src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs"
] | [
{
"comment": "`FindVisualChildByName(\"NormalRectangle\")` is cast with a direct `(Rectangle)` cast. If the template part exists but its type changes, this will throw `InvalidCastException` before the assertion, making failures harder to diagnose. Prefer `as Rectangle` and assert on the result.",
"path": "s... | true | ||
unoplatform/uno | 23,415 | comment_to_fix | fix(theming): don't dim disabled ListView/GridView item content | In this test, both CheckBoxes are created with `IsEnabled = false`, so `enabledItemCheckBox` / `disabledItemCheckBox` reads like it's referring to the CheckBox state rather than the *container* (ListViewItem) state. Renaming to reflect the container-enabled vs container-disabled scenario would make the intent clearer. | 69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b | 40bf777a5c7b9f850d16ad9d2743523550e41fdf | diff --git a/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs b/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs
new file mode 100644
index 000000000000..6e2f790e67a8
--- /dev/null
+++ b/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs
@@ -0,... | [
"src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs"
] | [
{
"comment": "In this test, both CheckBoxes are created with `IsEnabled = false`, so `enabledItemCheckBox` / `disabledItemCheckBox` reads like it's referring to the CheckBox state rather than the *container* (ListViewItem) state. Renaming to reflect the container-enabled vs container-disabled scenario would mak... | true | ||
unoplatform/uno | 23,415 | comment_to_fix | fix(theming): don't dim disabled ListView/GridView item content | PR description says the Fluent v2 ListViewItemExpanded/GridViewItemExpanded templates (and the merged themeresources_v2.xaml) were updated to remove the Disabled state opacity dim on ContentBorder. In the current branch, those opacity animations still appear to be present (e.g., src/Uno.UI.FluentTheme.v2/Resources/Vers... | 69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b | 40bf777a5c7b9f850d16ad9d2743523550e41fdf | diff --git a/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs b/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs
new file mode 100644
index 000000000000..6e2f790e67a8
--- /dev/null
+++ b/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs
@@ -0,... | [
"src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_CheckBox.cs"
] | [
{
"comment": "PR description says the Fluent v2 ListViewItemExpanded/GridViewItemExpanded templates (and the merged themeresources_v2.xaml) were updated to remove the Disabled state opacity dim on ContentBorder. In the current branch, those opacity animations still appear to be present (e.g., src/Uno.UI.FluentT... | true | ||
unoplatform/uno | 23,332 | issue_to_patch | chore: try building and testing against .NET 10 | Context: https://github.com/unoplatform/uno/issues/22745
Context: https://github.com/unoplatform/uno/pull/22742
Context: https://github.com/unoplatform/uno/pull/21171
Context: https://github.com/unoplatform/uno/pull/21183
It's a new year, which means it's time to build and test against a new .NET version (.NET 11... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/.vsts-ci.yml b/.vsts-ci.yml
index c50a77b49b66..b89b468e3b90 100644
--- a/.vsts-ci.yml
+++ b/.vsts-ci.yml
@@ -58,7 +58,7 @@ variables:
linuxScaledPool: 'Ubuntu2404-20251016'
macOSVMImage: 'macOS-15'
macOSVMImage_UITests: 'macOS-14'
- xCodeRoot: '/Applications/Xcode_26.0.1.app'
+ xCodeRoot: '/App... | [
".vsts-ci.yml",
"Directory.Build.props",
"build/Uno.UI.Build.csproj",
"build/ci/.azure-devops-stages.yml",
"build/ci/publish/.azure-devops-publish-ios-testflight.yml",
"build/ci/tests/.azure-devops-tests-android-native.yml",
"build/ci/tests/.azure-devops-tests-ios-native.yml",
"build/ci/tests/.azure-d... | [
{
"comment": "`using System.Globalization;` is unused in this file, which will raise an unused-using warning (and can fail the build if warnings are treated as errors). Please remove it or use it.\n",
"path": "src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/NavigationViewTests/Common/Navigation... | diff --git a/build/ci/tests/.azure-devops-tests-android-native.yml b/build/ci/tests/.azure-devops-tests-android-native.yml
index 95f83b46fa37..6d0a97711b88 100644
--- a/build/ci/tests/.azure-devops-tests-android-native.yml
+++ b/build/ci/tests/.azure-devops-tests-android-native.yml
@@ -55,12 +55,12 @@ jobs:
- bash... | true | |
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `using System.Globalization;` is unused in this file, which will raise an unused-using warning (and can fail the build if warnings are treated as errors). Please remove it or use it.
| c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/NavigationViewTests/Common/NavigationViewAnimationPage.xaml.cs b/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/NavigationViewTests/Common/NavigationViewAnimationPage.xaml.cs
index 0d9626996573..08c6bb0789e7 100644
--- a/src/Samples... | [
"src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/NavigationViewTests/Common/NavigationViewAnimationPage.xaml.cs"
] | [
{
"comment": "`using System.Globalization;` is unused in this file, which will raise an unused-using warning (and can fail the build if warnings are treated as errors). Please remove it or use it.\n",
"path": "src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/NavigationViewTests/Common/Navigation... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This script now references `5.3/uno53net10blank/...` and `5.3/uno53net10Lib/...`, but these paths don’t exist under `src/SolutionTemplate/5.3` (only `uno53net9*` directories are present). This will cause the template test job to fail when it tries to build these projects. Either add/rename the corresponding `uno53net10... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1
index 9a917a093c57..ad50100a665a 100644
--- a/build/test-scripts/run-netcore-mobile-template-tests.ps1
+++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1
@@ -36,18 +36,18 @@ if ( ... | [
"build/test-scripts/run-netcore-mobile-template-tests.ps1"
] | [
{
"comment": "This script now references `5.3/uno53net10blank/...` and `5.3/uno53net10Lib/...`, but these paths don’t exist under `src/SolutionTemplate/5.3` (only `uno53net9*` directories are present). This will cause the template test job to fail when it tries to build these projects. Either add/rename the cor... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | There’s a typo in the commented-out entry `//new(typeof(AppBarButton)_,` (stray `_` and missing closing `)`/`,`), which makes the list harder to read/maintain. Please fix the comment to the intended form (or remove it if it’s no longer needed). | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ContentControl.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ContentControl.cs
index a1a26c7c14ae..61c82bbdb09b 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ContentControl.cs
+++ b/src/Uno.UI.Runti... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ContentControl.cs"
] | [
{
"comment": "There’s a typo in the commented-out entry `//new(typeof(AppBarButton)_,` (stray `_` and missing closing `)`/`,`), which makes the list harder to read/maintain. Please fix the comment to the intended form (or remove it if it’s no longer needed).",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Minor typo in the justification text: duplicated word "and" ("and and").
| c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/NavigationViewTests/Common/NavigationViewAnimationPage.xaml.cs b/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/NavigationViewTests/Common/NavigationViewAnimationPage.xaml.cs
index 0d9626996573..08c6bb0789e7 100644
--- a/src/Samples... | [
"src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/NavigationViewTests/Common/NavigationViewAnimationPage.xaml.cs"
] | [
{
"comment": "Minor typo in the justification text: duplicated word \"and\" (\"and and\").\n",
"path": "src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/NavigationViewTests/Common/NavigationViewAnimationPage.xaml.cs",
"hunk": "@@ -32,9 +34,15 @@ private void NavigateToPage(object pageTag)\n ... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This template test matrix entry still publishes using `net9.0-desktop` even though the rest of this script (and templates in this PR) have been moved to net10.0. This will likely fail once the template project no longer targets net9.0; update this entry (and its `TargetFrameworks=` value) to net10.0-desktop for consist... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1
index 9a917a093c57..ad50100a665a 100644
--- a/build/test-scripts/run-netcore-mobile-template-tests.ps1
+++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1
@@ -36,18 +36,18 @@ if ( ... | [
"build/test-scripts/run-netcore-mobile-template-tests.ps1"
] | [
{
"comment": "This template test matrix entry still publishes using `net9.0-desktop` even though the rest of this script (and templates in this PR) have been moved to net10.0. This will likely fail once the template project no longer targets net9.0; update this entry (and its `TargetFrameworks=` value) to net10... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This add-in fixture is intended to target an older TFM than the host so it produces older-major `AssemblyRef`s (per the file header). With `NetCurrent` now set to net10.0 in the repo, setting this fixture to net10.0 removes the cross-major aspect of the test. Consider targeting net9.0 here (and pinning `System.Text.Enc... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj
index ed126d64ade5..897ff29ef627 100644
--- a/src/Uno.UI.RemoteCont... | [
"src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj"
] | [
{
"comment": "This add-in fixture is intended to target an older TFM than the host so it produces older-major `AssemblyRef`s (per the file header). With `NetCurrent` now set to net10.0 in the repo, setting this fixture to net10.0 removes the cross-major aspect of the test. Consider targeting net9.0 here (and pi... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `Xamarin.Calabash.Start()` is now commented out, but the project still references `Xamarin.TestCloud.Agent` and defines `HAS_TESTCLOUD_AGENT` (see `AdjustCalabash` target). If iOS UI tests/Test Cloud runs still rely on Calabash agent startup, this will break them. Consider restoring the call behind an appropriate compi... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs b/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs
index 1515d6db2f0d..5dd780157287 100644
--- a/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs
+++ b/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs
@@ -1,11 +1,6 @@
using Samp... | [
"src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs"
] | [
{
"comment": "`Xamarin.Calabash.Start()` is now commented out, but the project still references `Xamarin.TestCloud.Agent` and defines `HAS_TESTCLOUD_AGENT` (see `AdjustCalabash` target). If iOS UI tests/Test Cloud runs still rely on Calabash agent startup, this will break them. Consider restoring the call behin... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `ApiInformation.IsTypePresent` is checking for `Windows.UI.Xaml.Media.Animation.SuppressNavigationTransitionInfo`, but this file imports/uses `Microsoft.UI.Xaml.Media.Animation.SuppressNavigationTransitionInfo`. On WinUI/Uno this check is likely to always return false, causing the "no animation" code path to never run.... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs b/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs
index 54a61fa939d2..83ffb9bfd972 100644
--- a/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils... | [
"src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs"
] | [
{
"comment": "`ApiInformation.IsTypePresent` is checking for `Windows.UI.Xaml.Media.Animation.SuppressNavigationTransitionInfo`, but this file imports/uses `Microsoft.UI.Xaml.Media.Animation.SuppressNavigationTransitionInfo`. On WinUI/Uno this check is likely to always return false, causing the \"no animation\"... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The build step runs `ios-uitest-build.sh`, which builds `SamplesApp.netcoremobile` with `-f net10.0-ios26.0`, but this CopyFiles step reads from `bin/Release/net10.0-ios/...`. That folder likely won’t exist, causing the iOS native build artifact publish to fail. Update the SourceFolder path (and any other references in... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/ci/tests/.azure-devops-tests-ios-native.yml b/build/ci/tests/.azure-devops-tests-ios-native.yml
index 64f9d6f3ca74..9f602746751a 100644
--- a/build/ci/tests/.azure-devops-tests-ios-native.yml
+++ b/build/ci/tests/.azure-devops-tests-ios-native.yml
@@ -96,7 +96,7 @@ jobs:
- task: CopyFiles@2
... | [
"build/ci/tests/.azure-devops-tests-ios-native.yml"
] | [
{
"comment": "The build step runs `ios-uitest-build.sh`, which builds `SamplesApp.netcoremobile` with `-f net10.0-ios26.0`, but this CopyFiles step reads from `bin/Release/net10.0-ios/...`. That folder likely won’t exist, causing the iOS native build artifact publish to fail. Update the SourceFolder path (and a... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This fixture is intended to validate cross-major add-in loading by targeting an older TFM than the host and pinning same-major PackageReferences. The host targets `$(NetPrevious);$(NetCurrent)` (net9.0+net10.0), but this fixture now targets net10.0 and pins 10.x packages, which no longer exercises the cross-major scena... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj
index ed126d64ade5..897ff29ef627 100644
--- a/src/Uno.UI.RemoteCont... | [
"src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj"
] | [
{
"comment": "This fixture is intended to validate cross-major add-in loading by targeting an older TFM than the host and pinning same-major PackageReferences. The host targets `$(NetPrevious);$(NetCurrent)` (net9.0+net10.0), but this fixture now targets net10.0 and pins 10.x packages, which no longer exercises... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The job builds the TestFlight package with `-f net10.0-ios` and `UnoTargetFrameworkOverride=net10.0-ios`, but this repo’s mobile TFMs (e.g. `$(NetCurrentNetCoreMobile)`) are versioned (`net10.0-ios26.0`). If `net10.0-ios` isn’t part of the project’s TargetFrameworks, this publish step will fail; even if it builds, it w... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/ci/publish/.azure-devops-publish-ios-testflight.yml b/build/ci/publish/.azure-devops-publish-ios-testflight.yml
index c3d9f4867c9b..7eca61e5078e 100644
--- a/build/ci/publish/.azure-devops-publish-ios-testflight.yml
+++ b/build/ci/publish/.azure-devops-publish-ios-testflight.yml
@@ -64,7 +64,7 @@ job... | [
"build/ci/publish/.azure-devops-publish-ios-testflight.yml"
] | [
{
"comment": "The job builds the TestFlight package with `-f net10.0-ios` and `UnoTargetFrameworkOverride=net10.0-ios`, but this repo’s mobile TFMs (e.g. `$(NetCurrentNetCoreMobile)`) are versioned (`net10.0-ios26.0`). If `net10.0-ios` isn’t part of the project’s TargetFrameworks, this publish step will fail; e... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This CopyFiles step assumes the publish output is under `bin/Release/net10.0-ios/...`, but if the publish TFM is switched to the versioned iOS TFM used elsewhere (e.g. `net10.0-ios26.0`), the output path will change accordingly. Ensure the SourceFolder matches whatever TFM is actually built/published in this job to avo... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/ci/publish/.azure-devops-publish-ios-testflight.yml b/build/ci/publish/.azure-devops-publish-ios-testflight.yml
index c3d9f4867c9b..7eca61e5078e 100644
--- a/build/ci/publish/.azure-devops-publish-ios-testflight.yml
+++ b/build/ci/publish/.azure-devops-publish-ios-testflight.yml
@@ -64,7 +64,7 @@ job... | [
"build/ci/publish/.azure-devops-publish-ios-testflight.yml"
] | [
{
"comment": "This CopyFiles step assumes the publish output is under `bin/Release/net10.0-ios/...`, but if the publish TFM is switched to the versioned iOS TFM used elsewhere (e.g. `net10.0-ios26.0`), the output path will change accordingly. Ensure the SourceFolder matches whatever TFM is actually built/publis... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `GetLocalProperty()` has an else-branch that fetches the static `TimeZoneInfo.Local` property, but the caller always invokes `localProperty.GetValue(cachedData)`. If this branch is ever taken, `GetValue` should be called with `null` (static property), otherwise it will throw at runtime. Either remove the unreachable br... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
index b80f7c0d4a66..fb1022792f16 100644
--- a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
+++ b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
@@ -1,4 +1,5 @@
using System;
+using System... | [
"src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs"
] | [
{
"comment": "`GetLocalProperty()` has an else-branch that fetches the static `TimeZoneInfo.Local` property, but the caller always invokes `localProperty.GetValue(cachedData)`. If this branch is ever taken, `GetValue` should be called with `null` (static property), otherwise it will throw at runtime. Either rem... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `UnoCheckParameters` installs workloads for `--tfm net10.0-ios`, but this repo’s mobile TFMs include an explicit iOS platform version (e.g. `net10.0-ios26.0` in `NetCurrentNetCoreMobile`). Using the non-versioned TFM here is inconsistent and can hide workload/SDK mismatches. Consider switching to `--tfm net10.0-ios26.0... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/ci/publish/.azure-devops-publish-ios-testflight.yml b/build/ci/publish/.azure-devops-publish-ios-testflight.yml
index c3d9f4867c9b..7eca61e5078e 100644
--- a/build/ci/publish/.azure-devops-publish-ios-testflight.yml
+++ b/build/ci/publish/.azure-devops-publish-ios-testflight.yml
@@ -64,7 +64,7 @@ job... | [
"build/ci/publish/.azure-devops-publish-ios-testflight.yml"
] | [
{
"comment": "`UnoCheckParameters` installs workloads for `--tfm net10.0-ios`, but this repo’s mobile TFMs include an explicit iOS platform version (e.g. `net10.0-ios26.0` in `NetCurrentNetCoreMobile`). Using the non-versioned TFM here is inconsistent and can hide workload/SDK mismatches. Consider switching to ... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `dotnet publish -f net10.0-ios` / `UnoTargetFrameworkOverride=net10.0-ios` won’t match the SamplesApp netcoremobile TargetFrameworks (they use versioned Apple TFMs like `net10.0-ios26.0`). This will fail with “TargetFramework 'net10.0-ios' was not found” or publish the wrong TFM. Update these arguments to the versioned... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/ci/publish/.azure-devops-publish-ios-testflight.yml b/build/ci/publish/.azure-devops-publish-ios-testflight.yml
index c3d9f4867c9b..7eca61e5078e 100644
--- a/build/ci/publish/.azure-devops-publish-ios-testflight.yml
+++ b/build/ci/publish/.azure-devops-publish-ios-testflight.yml
@@ -64,7 +64,7 @@ job... | [
"build/ci/publish/.azure-devops-publish-ios-testflight.yml"
] | [
{
"comment": "`dotnet publish -f net10.0-ios` / `UnoTargetFrameworkOverride=net10.0-ios` won’t match the SamplesApp netcoremobile TargetFrameworks (they use versioned Apple TFMs like `net10.0-ios26.0`). This will fail with “TargetFramework 'net10.0-ios' was not found” or publish the wrong TFM. Update these argu... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The CopyFiles `SourceFolder` path uses `.../bin/Release/net10.0-ios/...`, but the build outputs under the versioned iOS TFM directory (e.g. `net10.0-ios26.0`). Update the path to match the TFM used in the publish step.
| c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/ci/publish/.azure-devops-publish-ios-testflight.yml b/build/ci/publish/.azure-devops-publish-ios-testflight.yml
index c3d9f4867c9b..7eca61e5078e 100644
--- a/build/ci/publish/.azure-devops-publish-ios-testflight.yml
+++ b/build/ci/publish/.azure-devops-publish-ios-testflight.yml
@@ -64,7 +64,7 @@ job... | [
"build/ci/publish/.azure-devops-publish-ios-testflight.yml"
] | [
{
"comment": "The CopyFiles `SourceFolder` path uses `.../bin/Release/net10.0-ios/...`, but the build outputs under the versioned iOS TFM directory (e.g. `net10.0-ios26.0`). Update the path to match the TFM used in the publish step.\n",
"path": "build/ci/publish/.azure-devops-publish-ios-testflight.yml",
... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The “Publishing validation” entry still publishes `-f net9.0-desktop` and sets `TargetFrameworks=net9.0-desktop`, but the 5.3 template projects in this script were updated to net10 TFMs. This publish step will fail because `net9.0-desktop` is no longer in the project’s TargetFrameworks. Update this entry to `net10.0-de... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1
index 9a917a093c57..ad50100a665a 100644
--- a/build/test-scripts/run-netcore-mobile-template-tests.ps1
+++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1
@@ -36,18 +36,18 @@ if ( ... | [
"build/test-scripts/run-netcore-mobile-template-tests.ps1"
] | [
{
"comment": "The “Publishing validation” entry still publishes `-f net9.0-desktop` and sets `TargetFrameworks=net9.0-desktop`, but the 5.3 template projects in this script were updated to net10 TFMs. This publish step will fail because `net9.0-desktop` is no longer in the project’s TargetFrameworks. Update thi... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `ApiInformation.IsTypePresent` is checking for `Windows.UI.Xaml.Media.Animation.SuppressNavigationTransitionInfo, Uno.UI`, but this repo defines `SuppressNavigationTransitionInfo` under `Microsoft.UI.Xaml.Media.Animation`. As-is, the check will always be false, so navigation won’t actually be suppressed. Either check f... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs b/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs
index 54a61fa939d2..83ffb9bfd972 100644
--- a/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils... | [
"src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs"
] | [
{
"comment": "`ApiInformation.IsTypePresent` is checking for `Windows.UI.Xaml.Media.Animation.SuppressNavigationTransitionInfo, Uno.UI`, but this repo defines `SuppressNavigationTransitionInfo` under `Microsoft.UI.Xaml.Media.Animation`. As-is, the check will always be false, so navigation won’t actually be supp... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The comment says this leak test fails on `net11.0-wasm`, but the repo’s current .NET TFMs are `net9.0`/`net10.0` (no `net11.0` in this PR). This looks like a stale/incorrect version reference; consider updating it to the actual failing TFM (e.g. `net10.0-wasm`) or removing the version-specific claim. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs
index 8c468e0dfc04..400cd65c0e01 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs
+++ b/src/Uno.UI... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs"
] | [
{
"comment": "The comment says this leak test fails on `net11.0-wasm`, but the repo’s current .NET TFMs are `net9.0`/`net10.0` (no `net11.0` in this PR). This looks like a stale/incorrect version reference; consider updating it to the actual failing TFM (e.g. `net10.0-wasm`) or removing the version-specific cla... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The comment says this leak test fails on `net11.0-wasm`, but the repo’s current .NET TFMs are `net9.0`/`net10.0` (no `net11.0` in this PR). This looks like a stale/incorrect version reference; consider updating it to the actual failing TFM (e.g. `net10.0-wasm`) or removing the version-specific claim. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs
index 8c468e0dfc04..400cd65c0e01 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs
+++ b/src/Uno.UI... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs"
] | [
{
"comment": "The comment says this leak test fails on `net11.0-wasm`, but the repo’s current .NET TFMs are `net9.0`/`net10.0` (no `net11.0` in this PR). This looks like a stale/incorrect version reference; consider updating it to the actual failing TFM (e.g. `net10.0-wasm`) or removing the version-specific cla... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This fixture’s header comment says it should target an older TFM than the host (newest host minus one), but it now targets `net10.0` (same as `$(NetCurrent)`) and the conditional “Only include these on .NET 9” ItemGroup can never apply. This makes the cross-major reference regression test ineffective. Consider revertin... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj
index ed126d64ade5..897ff29ef627 100644
--- a/src/Uno.UI.RemoteCont... | [
"src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj"
] | [
{
"comment": "This fixture’s header comment says it should target an older TFM than the host (newest host minus one), but it now targets `net10.0` (same as `$(NetCurrent)`) and the conditional “Only include these on .NET 9” ItemGroup can never apply. This makes the cross-major reference regression test ineffect... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `Xamarin.Calabash.Start();` has been commented out without explanation. This call only runs in the Release/iOS configuration used by UI tests (it's guarded by `#if __IOS__ && !__MACCATALYST__ && !TESTFLIGHT && !DEBUG`), so silently disabling it will likely break the Calabash-based iOS UI test runs that depend on the te... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs b/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs
index 1515d6db2f0d..5dd780157287 100644
--- a/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs
+++ b/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs
@@ -1,11 +1,6 @@
using Samp... | [
"src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs"
] | [
{
"comment": "`Xamarin.Calabash.Start();` has been commented out without explanation. This call only runs in the Release/iOS configuration used by UI tests (it's guarded by `#if __IOS__ && !__MACCATALYST__ && !TESTFLIGHT && !DEBUG`), so silently disabling it will likely break the Calabash-based iOS UI test runs... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `ApiInformation.IsTypePresent` expects a fully-qualified type name (e.g. `"Windows.UI.Xaml.Media.Animation.SuppressNavigationTransitionInfo"`), not a `Type.GetType`-style assembly-qualified name. Appending `, Uno.UI` here will change the lookup string and is very likely to make `IsTypePresent` return `false` on every p... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs b/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs
index 54a61fa939d2..83ffb9bfd972 100644
--- a/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils... | [
"src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs"
] | [
{
"comment": "`ApiInformation.IsTypePresent` expects a fully-qualified type name (e.g. `\"Windows.UI.Xaml.Media.Animation.SuppressNavigationTransitionInfo\"`), not a `Type.GetType`-style assembly-qualified name. Appending `, Uno.UI` here will change the lookup string and is very likely to make `IsTypePresent` r... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The previously helpful pointer comment ("At the time of writing, the property is found here: https://github.com/dotnet/runtime/...") was removed along with the inline reflection call. The companion `SetLocalTimeZone` still keeps its equivalent "At the time of writing, the field is found here" comment. Consider preservi... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
index b80f7c0d4a66..fb1022792f16 100644
--- a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
+++ b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
@@ -1,4 +1,5 @@
using System;
+using System... | [
"src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs"
] | [
{
"comment": "The previously helpful pointer comment (\"At the time of writing, the property is found here: https://github.com/dotnet/runtime/...\") was removed along with the inline reflection call. The companion `SetLocalTimeZone` still keeps its equivalent \"At the time of writing, the field is found here\" ... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The comment on the `ItemGroup` says "Only include these on .NET 9", but the condition `!IsTargetFrameworkCompatible('net10.0', $(TargetFramework))` will also include the `Microsoft.CSharp` package reference for any older/incompatible TFM (e.g. `net8.0`, `netstandard2.0`). The same comment template is reused unchanged a... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.Tests.ViewLibraryProps/Uno.UI.Tests.ViewLibraryProps.csproj b/src/Uno.UI.Tests.ViewLibraryProps/Uno.UI.Tests.ViewLibraryProps.csproj
index f63beff2da8e..669bea835791 100644
--- a/src/Uno.UI.Tests.ViewLibraryProps/Uno.UI.Tests.ViewLibraryProps.csproj
+++ b/src/Uno.UI.Tests.ViewLibraryProps/Uno.UI... | [
"src/Uno.UI.Tests.ViewLibraryProps/Uno.UI.Tests.ViewLibraryProps.csproj"
] | [
{
"comment": "The comment on the `ItemGroup` says \"Only include these on .NET 9\", but the condition `!IsTargetFrameworkCompatible('net10.0', $(TargetFramework))` will also include the `Microsoft.CSharp` package reference for any older/incompatible TFM (e.g. `net8.0`, `netstandard2.0`). The same comment templa... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `GetAngle` now only runs when `TargetFramework == $(NetUWPOrWinUI)`. If someone builds only the newer WinUI TFM (`$(NetCurrentUWPOrWinUI)`), the ANGLE binaries won't be downloaded in a clean checkout, which can break packing/runtime asset inclusion for this add-in. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
index c7f5eb46fdda..46ee28c715a6 100644
--- a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
+++ b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.cspr... | [
"src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj"
] | [
{
"comment": "`GetAngle` now only runs when `TargetFramework == $(NetUWPOrWinUI)`. If someone builds only the newer WinUI TFM (`$(NetCurrentUWPOrWinUI)`), the ANGLE binaries won't be downloaded in a clean checkout, which can break packing/runtime asset inclusion for this add-in.",
"path": "src/AddIns/Uno.Wi... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The `System.Text.Encodings.Web` reference is currently inside a conditional ItemGroup that will never apply when `TargetFramework` is `net10.0` (the project's only TFM). This means the fixture no longer pins `System.Text.Encodings.Web` at the intended version, which undermines the purpose described in the file header c... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj
index ed126d64ade5..897ff29ef627 100644
--- a/src/Uno.UI.RemoteCont... | [
"src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj"
] | [
{
"comment": "The `System.Text.Encodings.Web` reference is currently inside a conditional ItemGroup that will never apply when `TargetFramework` is `net10.0` (the project's only TFM). This means the fixture no longer pins `System.Text.Encodings.Web` at the intended version, which undermines the purpose describe... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This publishing validation still uses `net9.0-desktop` / `TargetFrameworks=net9.0-desktop`, but the `uno53net9blank` template project now targets `net10.0-desktop`. As written, this step will fail with “TFM not found” once the template TFMs are updated. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1
index 9a917a093c57..ad50100a665a 100644
--- a/build/test-scripts/run-netcore-mobile-template-tests.ps1
+++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1
@@ -36,18 +36,18 @@ if ( ... | [
"build/test-scripts/run-netcore-mobile-template-tests.ps1"
] | [
{
"comment": "This publishing validation still uses `net9.0-desktop` / `TargetFrameworks=net9.0-desktop`, but the `uno53net9blank` template project now targets `net10.0-desktop`. As written, this step will fail with “TFM not found” once the template TFMs are updated.",
"path": "build/test-scripts/run-netcor... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This fixture is documented as targeting a framework *older* than the host (DevServer.Tests targets $(NetCurrent)=net10.0) so its AssemblyRefs embed an older major. Currently it targets net10.0 (same as host), and the System.Text.Encodings.Web reference is in a condition that can never be true for net10.0, so the fixtur... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj
index ed126d64ade5..897ff29ef627 100644
--- a/src/Uno.UI.RemoteCont... | [
"src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj"
] | [
{
"comment": "This fixture is documented as targeting a framework *older* than the host (DevServer.Tests targets $(NetCurrent)=net10.0) so its AssemblyRefs embed an older major. Currently it targets net10.0 (same as host), and the System.Text.Encodings.Web reference is in a condition that can never be true for ... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | GetAngle only runs for $(NetUWPOrWinUI). If someone builds/packs only $(NetCurrentUWPOrWinUI), angle_binaries won't be downloaded and the packaged osx runtime assets will be missing (the glob include will just be empty). | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
index c7f5eb46fdda..46ee28c715a6 100644
--- a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
+++ b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.cspr... | [
"src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj"
] | [
{
"comment": "GetAngle only runs for $(NetUWPOrWinUI). If someone builds/packs only $(NetCurrentUWPOrWinUI), angle_binaries won't be downloaded and the packaged osx runtime assets will be missing (the glob include will just be empty).",
"path": "src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.cspro... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Template projects were updated to net10.0, but the 'Publishing validation' entry still uses net9.0-desktop / TargetFrameworks=net9.0-desktop. This will fail once the template no longer targets net9.0. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1
index 9a917a093c57..ad50100a665a 100644
--- a/build/test-scripts/run-netcore-mobile-template-tests.ps1
+++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1
@@ -36,18 +36,18 @@ if ( ... | [
"build/test-scripts/run-netcore-mobile-template-tests.ps1"
] | [
{
"comment": "Template projects were updated to net10.0, but the 'Publishing validation' entry still uses net9.0-desktop / TargetFrameworks=net9.0-desktop. This will fail once the template no longer targets net9.0.",
"path": "build/test-scripts/run-netcore-mobile-template-tests.ps1",
"hunk": "@@ -204,18... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Commenting out Xamarin.Calabash.Start() disables Test Cloud agent initialization for Release simulator builds. Since the csproj conditionally references Xamarin.TestCloud.Agent and defines HAS_TESTCLOUD_AGENT, prefer guarding the call with that constant instead of removing it. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs b/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs
index 1515d6db2f0d..5dd780157287 100644
--- a/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs
+++ b/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs
@@ -1,11 +1,6 @@
using Samp... | [
"src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs"
] | [
{
"comment": "Commenting out Xamarin.Calabash.Start() disables Test Cloud agent initialization for Release simulator builds. Since the csproj conditionally references Xamarin.TestCloud.Agent and defines HAS_TESTCLOUD_AGENT, prefer guarding the call with that constant instead of removing it.",
"path": "src/S... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | ApiInformation.IsTypePresent() is checking for a non-existent type name (Windows.UI.*) and will always return false, so the SuppressNavigationTransitionInfo overload is never used. Since this file references Microsoft.UI.Xaml.Media.Animation.SuppressNavigationTransitionInfo, the probe should use the Microsoft.UI qualif... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs b/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs
index 54a61fa939d2..83ffb9bfd972 100644
--- a/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils... | [
"src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs"
] | [
{
"comment": "ApiInformation.IsTypePresent() is checking for a non-existent type name (Windows.UI.*) and will always return false, so the SuppressNavigationTransitionInfo overload is never used. Since this file references Microsoft.UI.Xaml.Media.Animation.SuppressNavigationTransitionInfo, the probe should use t... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The publishing validation entry still targets `net9.0-desktop`, but the 5.3 template project was updated to `net10.0-*` TFMs. This will fail when the script tries to build/publish with a TFM the template no longer declares. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1
index 9a917a093c57..ad50100a665a 100644
--- a/build/test-scripts/run-netcore-mobile-template-tests.ps1
+++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1
@@ -36,18 +36,18 @@ if ( ... | [
"build/test-scripts/run-netcore-mobile-template-tests.ps1"
] | [
{
"comment": "The publishing validation entry still targets `net9.0-desktop`, but the 5.3 template project was updated to `net10.0-*` TFMs. This will fail when the script tries to build/publish with a TFM the template no longer declares.",
"path": "build/test-scripts/run-netcore-mobile-template-tests.ps1",
... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `GetAngle` is currently conditioned to run only for `$(NetUWPOrWinUI)` (net9). With the project now also targeting `$(NetCurrentUWPOrWinUI)` (net10), building only the current TFM (e.g. via a TFM-matched ProjectReference) will skip the download and can produce packages missing the ANGLE native binaries. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
index c7f5eb46fdda..46ee28c715a6 100644
--- a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
+++ b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.cspr... | [
"src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj"
] | [
{
"comment": "`GetAngle` is currently conditioned to run only for `$(NetUWPOrWinUI)` (net9). With the project now also targeting `$(NetCurrentUWPOrWinUI)` (net10), building only the current TFM (e.g. via a TFM-matched ProjectReference) will skip the download and can produce packages missing the ANGLE native bin... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `Xamarin.Calabash.Start()` has been commented out, which disables the Xamarin Test Cloud agent hookup for Release (non-TestFlight) iOS builds. Since the project still references `Xamarin.TestCloud.Agent` and defines `HAS_TESTCLOUD_AGENT`, this is likely to break UI test execution on iOS simulators. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs b/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs
index 1515d6db2f0d..5dd780157287 100644
--- a/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs
+++ b/src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs
@@ -1,11 +1,6 @@
using Samp... | [
"src/SamplesApp/SamplesApp.netcoremobile/iOS/Main.iOS.cs"
] | [
{
"comment": "`Xamarin.Calabash.Start()` has been commented out, which disables the Xamarin Test Cloud agent hookup for Release (non-TestFlight) iOS builds. Since the project still references `Xamarin.TestCloud.Agent` and defines `HAS_TESTCLOUD_AGENT`, this is likely to break UI test execution on iOS simulators... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | In the publish-validation entry, this still builds/publishes `net9.0-desktop`, but the template projects were updated to `net10.0-*`. This will fail because `net9.0-desktop` is no longer a valid TFM for this project. Update the publish validation arguments to `net10.0-desktop`. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1
index 9a917a093c57..ad50100a665a 100644
--- a/build/test-scripts/run-netcore-mobile-template-tests.ps1
+++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1
@@ -36,18 +36,18 @@ if ( ... | [
"build/test-scripts/run-netcore-mobile-template-tests.ps1"
] | [
{
"comment": "In the publish-validation entry, this still builds/publishes `net9.0-desktop`, but the template projects were updated to `net10.0-*`. This will fail because `net9.0-desktop` is no longer a valid TFM for this project. Update the publish validation arguments to `net10.0-desktop`.",
"path": "buil... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `System.Text.Encodings.Web` is referenced by `Stub.cs` and is described in the fixture header comment as one of the pinned assembly refs. However, the current conditional ItemGroup (`!IsTargetFrameworkCompatible('net10.0', $(TargetFramework))`) is always false for this `net10.0`-only project, so the package reference w... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj
index ed126d64ade5..897ff29ef627 100644
--- a/src/Uno.UI.RemoteCont... | [
"src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj"
] | [
{
"comment": "`System.Text.Encodings.Web` is referenced by `Stub.cs` and is described in the fixture header comment as one of the pinned assembly refs. However, the current conditional ItemGroup (`!IsTargetFrameworkCompatible('net10.0', $(TargetFramework))`) is always false for this `net10.0`-only project, so t... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `GetAngle` now only runs when building `$(NetUWPOrWinUI)`, but this project was updated to also target `$(NetCurrentUWPOrWinUI)`. If someone builds only the net-current WinUI TFM, the ANGLE native assets may not be downloaded/packed, producing an incomplete package.
Run `GetAngle` for both WinUI TFMs (or generally for... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
index c7f5eb46fdda..46ee28c715a6 100644
--- a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
+++ b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.cspr... | [
"src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj"
] | [
{
"comment": "`GetAngle` now only runs when building `$(NetUWPOrWinUI)`, but this project was updated to also target `$(NetCurrentUWPOrWinUI)`. If someone builds only the net-current WinUI TFM, the ANGLE native assets may not be downloaded/packed, producing an incomplete package.\n\nRun `GetAngle` for both WinU... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `ApiInformation.IsTypePresent()` is checking for `Windows.UI.Xaml.Media.Animation.SuppressNavigationTransitionInfo`, but this repo defines `SuppressNavigationTransitionInfo` under the `Microsoft.UI.Xaml.Media.Animation` namespace (e.g. src/Uno.UI/UI/Xaml/Media/Animation/SuppressNavigationTransitionInfo.cs). This check ... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs b/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs
index 54a61fa939d2..83ffb9bfd972 100644
--- a/src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils... | [
"src/SamplesApp/SamplesApp.Samples/Microsoft_UI_Xaml_Controls/TestAppUtils/FrameExtensions.cs"
] | [
{
"comment": "`ApiInformation.IsTypePresent()` is checking for `Windows.UI.Xaml.Media.Animation.SuppressNavigationTransitionInfo`, but this repo defines `SuppressNavigationTransitionInfo` under the `Microsoft.UI.Xaml.Media.Animation` namespace (e.g. src/Uno.UI/UI/Xaml/Media/Animation/SuppressNavigationTransitio... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This comment says the leak test fails on `net11.0-wasm`, but this PR updates `NetCurrent` to `net10.0` (Directory.Build.props) and the tests appear to be moving from net9 → net10. The referenced issue (#9080) should be associated with the actual failing TFM here (likely `net10.0-wasm`, as the comment previously stated)... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs
index 8c468e0dfc04..400cd65c0e01 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs
+++ b/src/Uno.UI... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs"
] | [
{
"comment": "This comment says the leak test fails on `net11.0-wasm`, but this PR updates `NetCurrent` to `net10.0` (Directory.Build.props) and the tests appear to be moving from net9 → net10. The referenced issue (#9080) should be associated with the actual failing TFM here (likely `net10.0-wasm`, as the comm... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This comment says the leak test fails on `net11.0-wasm`, but `NetCurrent` in this PR is `net10.0` (Directory.Build.props). Update the comment to the actual failing TFM (likely `net10.0-wasm`). | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs
index 8c468e0dfc04..400cd65c0e01 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs
+++ b/src/Uno.UI... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs"
] | [
{
"comment": "This comment says the leak test fails on `net11.0-wasm`, but `NetCurrent` in this PR is `net10.0` (Directory.Build.props). Update the comment to the actual failing TFM (likely `net10.0-wasm`).",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs",
"hu... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This conditional `ItemGroup` is labeled “Only include these on .NET 9”, but this fixture now targets only `net10.0`, so the condition is never true and the `PackageReference` is never included. This is confusing (especially given the fixture header comment describing pinned AssemblyRefs). Consider removing the dead con... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj
index ed126d64ade5..897ff29ef627 100644
--- a/src/Uno.UI.RemoteCont... | [
"src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj"
] | [
{
"comment": "This conditional `ItemGroup` is labeled “Only include these on .NET 9”, but this fixture now targets only `net10.0`, so the condition is never true and the `PackageReference` is never included. This is confusing (especially given the fixture header comment describing pinned AssemblyRefs). Consider... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | There are two consecutive <NoWarn> properties here. In MSBuild, the later property assignment overwrites the earlier one, so NU1703 and SYSLIB1045 will no longer be suppressed. Merge these into a single <NoWarn> value (or remove the earlier one). | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj b/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj
index 2ab81c428e11..3c60a88b995f 100644
--- a/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj
+++ b/src/SamplesApp/SamplesApp.netcoremobi... | [
"src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj"
] | [
{
"comment": "There are two consecutive <NoWarn> properties here. In MSBuild, the later property assignment overwrites the earlier one, so NU1703 and SYSLIB1045 will no longer be suppressed. Merge these into a single <NoWarn> value (or remove the earlier one).",
"path": "src/SamplesApp/SamplesApp.netcoremob... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This PropertyGroup assigns <NoWarn> three times (NU1703/CS0105, then CS1998, then IL2111). MSBuild properties don’t accumulate automatically: the last assignment wins, so NU1703/CS0105/CS1998 will be lost. Consolidate these into a single <NoWarn> value. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj b/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj
index b3f855fecf8f..d1988c149214 100644
--- a/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj
+++ b/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.... | [
"src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj"
] | [
{
"comment": "This PropertyGroup assigns <NoWarn> three times (NU1703/CS0105, then CS1998, then IL2111). MSBuild properties don’t accumulate automatically: the last assignment wins, so NU1703/CS0105/CS1998 will be lost. Consolidate these into a single <NoWarn> value.",
"path": "src/Uno.UI.RuntimeTests/Uno.U... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The comment says this section is “Blank with net9”, but the entry below now builds `-f net10.0-browserwasm` (and the template TFMs in this PR are net10). Update the comment to match the actual TFM being validated. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-net7-template-linux.ps1 b/build/test-scripts/run-net7-template-linux.ps1
index 62d0afdbc242..dbe84d5315a2 100644
--- a/build/test-scripts/run-net7-template-linux.ps1
+++ b/build/test-scripts/run-net7-template-linux.ps1
@@ -28,7 +28,7 @@ $projects =
@(
# 5.3 Blank with net9
... | [
"build/test-scripts/run-net7-template-linux.ps1"
] | [
{
"comment": "The comment says this section is “Blank with net9”, but the entry below now builds `-f net10.0-browserwasm` (and the template TFMs in this PR are net10). Update the comment to match the actual TFM being validated.",
"path": "build/test-scripts/run-net7-template-linux.ps1",
"hunk": "@@ -28,... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | These comments say the project is kept on the “oldest supported TFM” and mention choosing between NetPrevious/NetCurrent, but this PR switches the TFM to `$(NetUnitTests)` (which is now set to `$(NetCurrent)` in Directory.Build.props). Please update the comments so they match the actual intent/behavior. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.Analyzers.Tests/Uno.Analyzers.Tests.csproj b/src/Uno.Analyzers.Tests/Uno.Analyzers.Tests.csproj
index ab1f1b1d8994..79f93022e95e 100644
--- a/src/Uno.Analyzers.Tests/Uno.Analyzers.Tests.csproj
+++ b/src/Uno.Analyzers.Tests/Uno.Analyzers.Tests.csproj
@@ -1,10 +1,10 @@
<Project Sdk="Microsoft.NET.Sd... | [
"src/Uno.Analyzers.Tests/Uno.Analyzers.Tests.csproj"
] | [
{
"comment": "These comments say the project is kept on the “oldest supported TFM” and mention choosing between NetPrevious/NetCurrent, but this PR switches the TFM to `$(NetUnitTests)` (which is now set to `$(NetCurrent)` in Directory.Build.props). Please update the comments so they match the actual intent/beh... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Let's update the justification | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SourceGenerators/System.Xaml/System.Xaml/TypeExtensionMethods.cs b/src/SourceGenerators/System.Xaml/System.Xaml/TypeExtensionMethods.cs
index 2f93fdc67d6f..1474fa309ba0 100644
--- a/src/SourceGenerators/System.Xaml/System.Xaml/TypeExtensionMethods.cs
+++ b/src/SourceGenerators/System.Xaml/System.Xaml/T... | [
"src/SourceGenerators/System.Xaml/System.Xaml/TypeExtensionMethods.cs"
] | [
{
"comment": "Let's update the justification",
"path": "src/SourceGenerators/System.Xaml/System.Xaml/TypeExtensionMethods.cs",
"hunk": "@@ -33,7 +33,10 @@\n \n namespace Uno.Xaml\n {\n+\t[UnconditionalSuppressMessage(\"Trimming\", \"IL2026\", Justification = \"TODO\")]",
"resolving_sha": "8bd11bcc6d... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Let's update the justification | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SourceGenerators/System.Xaml/System.Xaml/XamlMember.cs b/src/SourceGenerators/System.Xaml/System.Xaml/XamlMember.cs
index 80188782b04f..c8cc85cbc00c 100644
--- a/src/SourceGenerators/System.Xaml/System.Xaml/XamlMember.cs
+++ b/src/SourceGenerators/System.Xaml/System.Xaml/XamlMember.cs
@@ -23,6 +23,7 @@... | [
"src/SourceGenerators/System.Xaml/System.Xaml/XamlMember.cs"
] | [
{
"comment": "Let's update the justification",
"path": "src/SourceGenerators/System.Xaml/System.Xaml/XamlMember.cs",
"hunk": "@@ -417,6 +418,7 @@ Type DoGetType ()\n \t\t\treturn typeof (object);\n \t\t}\n \n+\t\t[UnconditionalSuppressMessage(\"Trimming\", \"IL2072\", Justification = \"TODO\")]",
"r... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Let's update the justification | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectNodeIterator.cs b/src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectNodeIterator.cs
index b75d8bdd402b..a36a74e24a75 100644
--- a/src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectNodeIterator.cs
+++ b/src/SourceGenerators/System.Xaml/System.... | [
"src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectNodeIterator.cs"
] | [
{
"comment": "Let's update the justification",
"path": "src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectNodeIterator.cs",
"hunk": "@@ -36,6 +37,7 @@\n \n namespace Uno.Xaml\n {\n+\t[UnconditionalSuppressMessage(\"Trimming\", \"IL2075\", Justification = \"TODO\")]",
"resolving_sha": "8bd11bcc6... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Let's update the justification | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectWriter.cs b/src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectWriter.cs
index 6951542e9d78..9f9009f5b9cf 100644
--- a/src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectWriter.cs
+++ b/src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectWri... | [
"src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectWriter.cs"
] | [
{
"comment": "Let's update the justification",
"path": "src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectWriter.cs",
"hunk": "@@ -329,6 +330,7 @@ protected override void OnWriteStartMember (XamlMember property)\n \n \t\tstatic readonly BindingFlags static_flags = BindingFlags.Public | BindingFlags... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Let's update the justification | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectWriter.cs b/src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectWriter.cs
index 6951542e9d78..9f9009f5b9cf 100644
--- a/src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectWriter.cs
+++ b/src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectWri... | [
"src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectWriter.cs"
] | [
{
"comment": "Let's update the justification",
"path": "src/SourceGenerators/System.Xaml/System.Xaml/XamlObjectWriter.cs",
"hunk": "@@ -365,6 +367,7 @@ protected override void OnWriteEndMember ()\n \t\t\t}\n \t\t}\n \n+\t\t[UnconditionalSuppressMessage(\"Trimming\", \"IL2075\", Justification = \"TODO\")... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Let's update the justification | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Control_Visibility.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Control_Visibility.cs
index 7637ac70e9a2..53df511d69ba 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Control_Visibility.cs
+++ b/src/... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Control_Visibility.cs"
] | [
{
"comment": "Let's update the justification",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Control_Visibility.cs",
"hunk": "@@ -26,6 +27,11 @@ public class Given_Control_Visibility\n #if !HAS_RENDER_TARGET_BITMAP\n \t[Ignore(\"Cannot take screenshot on this platform.\")]\n #end... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Let's update the justification | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Data/Given_Convert.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Data/Given_Convert.cs
index 761be05c45a4..8ce1d00f2d74 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Data/Given_Convert.cs
+++ b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Dat... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Data/Given_Convert.cs"
] | [
{
"comment": "Let's update the justification",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Data/Given_Convert.cs",
"hunk": "@@ -16,8 +17,13 @@ public void When_Uri()\n \t\t{\n \t\t\tstring Expected = \"http://platform.uno\";\n \n-\t\t\tvar converter = TypeDescriptor.GetConverter(typeof(Uri));... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Let's update the justification | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Markup/Given_XamlReader.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Markup/Given_XamlReader.cs
index 2b5d4b94f302..5f179e1c9eb2 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Markup/Given_XamlReader.cs
+++ b/src/Uno.UI.RuntimeTests/Tests/Wind... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Markup/Given_XamlReader.cs"
] | [
{
"comment": "Let's update the justification",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Markup/Given_XamlReader.cs",
"hunk": "@@ -1279,11 +1280,15 @@ pvt.TargetObject is FrameworkElement fe &&\n \t\t\t\t\t\tDebugMarkupAttachable.SetValue(fe, serviceProvider);\n \t\t\t\t\t}\n \n-\t\t\t\t\tr... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Duplicate `using System.Diagnostics.CodeAnalysis;` directive (already present earlier in the file). This is redundant noise and can trigger style analyzers depending on configuration. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs
index 8c468e0dfc04..400cd65c0e01 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs
+++ b/src/Uno.UI... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs"
] | [
{
"comment": "Duplicate `using System.Diagnostics.CodeAnalysis;` directive (already present earlier in the file). This is redundant noise and can trigger style analyzers depending on configuration.",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_FrameworkElement_And_Leak.cs",
"hunk": "@@ ... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `TimeZoneInfoCachedDataType` is initialized with `throwOnError: false`, so it can be null. In that case the `t.GetProperty()` branch is always taken, contradicting the current suppression justification ("should be impossible") and making the behavior depend on type-forwarding details. Consider explicitly checking for n... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
index b80f7c0d4a66..fb1022792f16 100644
--- a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
+++ b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
@@ -1,4 +1,5 @@
using System;
+using System... | [
"src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs"
] | [
{
"comment": "`TimeZoneInfoCachedDataType` is initialized with `throwOnError: false`, so it can be null. In that case the `t.GetProperty()` branch is always taken, contradicting the current suppression justification (\"should be impossible\") and making the behavior depend on type-forwarding details. Consider e... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | Same issue as `GetLocalProperty()`: `TimeZoneInfoCachedDataType` can be null, so the "impossible" branch can be taken. The suppression justification should match reality, and the logic should explicitly check for null before using the statically-resolvable `Type.GetType(...)` fallback. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
index b80f7c0d4a66..fb1022792f16 100644
--- a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
+++ b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
@@ -1,4 +1,5 @@
using System;
+using System... | [
"src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs"
] | [
{
"comment": "Same issue as `GetLocalProperty()`: `TimeZoneInfoCachedDataType` can be null, so the \"impossible\" branch can be taken. The suppression justification should match reality, and the logic should explicitly check for null before using the statically-resolvable `Type.GetType(...)` fallback.",
"pa... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `GetAngle` runs only when `TargetFramework == $(NetUWPOrWinUI)`. If someone builds just the new `$(NetCurrentUWPOrWinUI)` target (e.g. `-f $(NetCurrentUWPOrWinUI)`), the ANGLE binaries won't be downloaded and the pack output can miss `angle_binaries`.
Consider broadening the condition to cover all WinUI/UWP TFMs (cons... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
index c7f5eb46fdda..46ee28c715a6 100644
--- a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
+++ b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.cspr... | [
"src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj"
] | [
{
"comment": "`GetAngle` runs only when `TargetFramework == $(NetUWPOrWinUI)`. If someone builds just the new `$(NetCurrentUWPOrWinUI)` target (e.g. `-f $(NetCurrentUWPOrWinUI)`), the ANGLE binaries won't be downloaded and the pack output can miss `angle_binaries`.\n\nConsider broadening the condition to cover ... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This template test entry still builds/publishes `net9.0-desktop`, but the template projects in this PR have been updated to `net10.0-*` TFMs. As-is, this step should fail because `net9.0-desktop` is no longer a valid target framework for `5.3/uno53net9blank`. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1
index 9a917a093c57..ad50100a665a 100644
--- a/build/test-scripts/run-netcore-mobile-template-tests.ps1
+++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1
@@ -36,18 +36,18 @@ if ( ... | [
"build/test-scripts/run-netcore-mobile-template-tests.ps1"
] | [
{
"comment": "This template test entry still builds/publishes `net9.0-desktop`, but the template projects in this PR have been updated to `net10.0-*` TFMs. As-is, this step should fail because `net9.0-desktop` is no longer a valid target framework for `5.3/uno53net9blank`.",
"path": "build/test-scripts/run-... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This entry still publishes/builds the template using `net9.0-desktop`, but the 5.3 templates in this PR are updated to `net10.0-*`. This will fail because `net9.0-desktop` is no longer a valid TFM for that project in this branch. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1
index 9a917a093c57..ad50100a665a 100644
--- a/build/test-scripts/run-netcore-mobile-template-tests.ps1
+++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1
@@ -36,18 +36,18 @@ if ( ... | [
"build/test-scripts/run-netcore-mobile-template-tests.ps1"
] | [
{
"comment": "This entry still publishes/builds the template using `net9.0-desktop`, but the 5.3 templates in this PR are updated to `net10.0-*`. This will fail because `net9.0-desktop` is no longer a valid TFM for that project in this branch.",
"path": "build/test-scripts/run-netcore-mobile-template-tests.... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `NoWarn` is defined twice here; the second definition overwrites the first, so `NU1703` and `SYSLIB1045` are no longer suppressed (unless they happen to be included in `$(NoWarn)` from elsewhere). Combine these into a single `NoWarn` so all intended suppressions apply. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj b/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj
index 2ab81c428e11..3c60a88b995f 100644
--- a/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj
+++ b/src/SamplesApp/SamplesApp.netcoremobi... | [
"src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj"
] | [
{
"comment": "`NoWarn` is defined twice here; the second definition overwrites the first, so `NU1703` and `SYSLIB1045` are no longer suppressed (unless they happen to be included in `$(NoWarn)` from elsewhere). Combine these into a single `NoWarn` so all intended suppressions apply.",
"path": "src/SamplesAp... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `GetAngle` now only runs when `$(TargetFramework)` equals `$(NetUWPOrWinUI)`. When `BuildGraphics3DGLForWindows` is not set, this project no longer targets any `*-windows10.*` TFM, so the target will never execute and the `angle_binaries/osx/*` files won't be downloaded/packed. Since the `DownloadFile` tasks are alread... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
index c7f5eb46fdda..46ee28c715a6 100644
--- a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
+++ b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.cspr... | [
"src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj"
] | [
{
"comment": "`GetAngle` now only runs when `$(TargetFramework)` equals `$(NetUWPOrWinUI)`. When `BuildGraphics3DGLForWindows` is not set, this project no longer targets any `*-windows10.*` TFM, so the target will never execute and the `angle_binaries/osx/*` files won't be downloaded/packed. Since the `Download... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `Type.GetType(..., throwOnError: false)` can return `null`, but `TimeZoneInfoCachedDataType` is declared as non-nullable `Type`. Mark it as nullable (and ideally `readonly`) to avoid nullable-analysis warnings and to better reflect runtime behavior. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
index b80f7c0d4a66..fb1022792f16 100644
--- a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
+++ b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs
@@ -1,4 +1,5 @@
using System;
+using System... | [
"src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs"
] | [
{
"comment": "`Type.GetType(..., throwOnError: false)` can return `null`, but `TimeZoneInfoCachedDataType` is declared as non-nullable `Type`. Mark it as nullable (and ideally `readonly`) to avoid nullable-analysis warnings and to better reflect runtime behavior.",
"path": "src/Uno.UI.RuntimeTests/Helpers/T... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `GetPropertyValue()` can return `null` (when the DP field/property isn't found), but it's declared as returning non-nullable `DependencyProperty`. Change the return type to `DependencyProperty?` so the nullable contract matches the implementation (and the subsequent `if (property is null)` check). | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/UITests/_Engine/UnoUITests/Helpers/QueryExtensions.cs b/src/Uno.UI.RuntimeTests/UITests/_Engine/UnoUITests/Helpers/QueryExtensions.cs
index 5c92ad2167f0..f8e8ccec3f20 100644
--- a/src/Uno.UI.RuntimeTests/UITests/_Engine/UnoUITests/Helpers/QueryExtensions.cs
+++ b/src/Uno.UI.RuntimeT... | [
"src/Uno.UI.RuntimeTests/UITests/_Engine/UnoUITests/Helpers/QueryExtensions.cs"
] | [
{
"comment": "`GetPropertyValue()` can return `null` (when the DP field/property isn't found), but it's declared as returning non-nullable `DependencyProperty`. Change the return type to `DependencyProperty?` so the nullable contract matches the implementation (and the subsequent `if (property is null)` check).... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `UnconditionalSuppressMessage` was added with an empty `Justification`. Since these suppressions are used to document trimming-safety decisions, leaving the justification blank makes future maintenance harder (and is inconsistent with the other suppressions added in this PR). Please add a short justification explaining... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI/DataBinding/BindingExpression.cs b/src/Uno.UI/DataBinding/BindingExpression.cs
index 7b7c6d3ef536..1790c7a82a08 100644
--- a/src/Uno.UI/DataBinding/BindingExpression.cs
+++ b/src/Uno.UI/DataBinding/BindingExpression.cs
@@ -210,7 +210,10 @@ public void UpdateSource(object value)
// Convert i... | [
"src/Uno.UI/DataBinding/BindingExpression.cs"
] | [
{
"comment": "`UnconditionalSuppressMessage` was added with an empty `Justification`. Since these suppressions are used to document trimming-safety decisions, leaving the justification blank makes future maintenance harder (and is inconsistent with the other suppressions added in this PR). Please add a short ju... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `RunTestsForInstanceRequirements` includes `PublicParameterlessConstructor`, but `RunTestsForInstance()` accepts an already-created instance and is called with test classes that *don't* have a parameterless ctor (e.g. pickable storage tests). This requirement will trigger trimming analyzer warnings at call sites and is... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UnitTest/UnitTestsControl.cs b/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UnitTest/UnitTestsControl.cs
index c726c68df3a7..1456376d6dc7 100644
--- a/src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UnitTest/UnitTestsControl.cs
+++ b/src/Sample... | [
"src/SamplesApp/SamplesApp.UnitTests.Shared/Controls/UnitTest/UnitTestsControl.cs"
] | [
{
"comment": "`RunTestsForInstanceRequirements` includes `PublicParameterlessConstructor`, but `RunTestsForInstance()` accepts an already-created instance and is called with test classes that *don't* have a parameterless ctor (e.g. pickable storage tests). This requirement will trigger trimming analyzer warning... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The conditional `ItemGroup` means `System.Text.Encodings.Web` is **not referenced at all** when targeting `net10.0` (the current `TargetFramework`), defeating the fixture's intent and potentially breaking compilation/AssemblyRef expectations. The package reference should be unconditional for this project (or the condit... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj
index ed126d64ade5..897ff29ef627 100644
--- a/src/Uno.UI.RemoteCont... | [
"src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj"
] | [
{
"comment": "The conditional `ItemGroup` means `System.Text.Encodings.Web` is **not referenced at all** when targeting `net10.0` (the current `TargetFramework`), defeating the fixture's intent and potentially breaking compilation/AssemblyRef expectations. The package reference should be unconditional for this ... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `UnconditionalSuppressMessage` has an empty `Justification`. This makes the suppression hard to audit and can violate analyzer expectations; please add a short explanation of why the trimming warning is safe/expected here. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI/DataBinding/BindingExpression.cs b/src/Uno.UI/DataBinding/BindingExpression.cs
index 7b7c6d3ef536..1790c7a82a08 100644
--- a/src/Uno.UI/DataBinding/BindingExpression.cs
+++ b/src/Uno.UI/DataBinding/BindingExpression.cs
@@ -210,7 +210,10 @@ public void UpdateSource(object value)
// Convert i... | [
"src/Uno.UI/DataBinding/BindingExpression.cs"
] | [
{
"comment": "`UnconditionalSuppressMessage` has an empty `Justification`. This makes the suppression hard to audit and can violate analyzer expectations; please add a short explanation of why the trimming warning is safe/expected here.",
"path": "src/Uno.UI/DataBinding/BindingExpression.cs",
"hunk": "@... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `System.Text.Encodings.Web` is now only referenced under a condition that will never be true for this project (`TargetFramework` is `net10.0`), which defeats the fixture’s goal of pinning that AssemblyRef (per the header comment). Move the `System.Text.Encodings.Web` PackageReference into the main ItemGroup (or re-intr... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj
index ed126d64ade5..897ff29ef627 100644
--- a/src/Uno.UI.RemoteCont... | [
"src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj"
] | [
{
"comment": "`System.Text.Encodings.Web` is now only referenced under a condition that will never be true for this project (`TargetFramework` is `net10.0`), which defeats the fixture’s goal of pinning that AssemblyRef (per the header comment). Move the `System.Text.Encodings.Web` PackageReference into the main... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | The trimming suppression has an empty `Justification`, which makes it hard to understand why IL2072 is safe to ignore here. Please provide a short rationale (or drop the `Justification` named argument entirely). | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI/DataBinding/BindingExpression.cs b/src/Uno.UI/DataBinding/BindingExpression.cs
index 7b7c6d3ef536..1790c7a82a08 100644
--- a/src/Uno.UI/DataBinding/BindingExpression.cs
+++ b/src/Uno.UI/DataBinding/BindingExpression.cs
@@ -210,7 +210,10 @@ public void UpdateSource(object value)
// Convert i... | [
"src/Uno.UI/DataBinding/BindingExpression.cs"
] | [
{
"comment": "The trimming suppression has an empty `Justification`, which makes it hard to understand why IL2072 is safe to ignore here. Please provide a short rationale (or drop the `Justification` named argument entirely).",
"path": "src/Uno.UI/DataBinding/BindingExpression.cs",
"hunk": "@@ -210,7 +2... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This publish-validation entry still hardcodes `net9.0-desktop`, but the template projects in this script have been migrated to `net10.0`. As-is, `dotnet publish -f net9.0-desktop` will fail because that TFM no longer exists in the project. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1
index 9a917a093c57..ad50100a665a 100644
--- a/build/test-scripts/run-netcore-mobile-template-tests.ps1
+++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1
@@ -36,18 +36,18 @@ if ( ... | [
"build/test-scripts/run-netcore-mobile-template-tests.ps1"
] | [
{
"comment": "This publish-validation entry still hardcodes `net9.0-desktop`, but the template projects in this script have been migrated to `net10.0`. As-is, `dotnet publish -f net9.0-desktop` will fail because that TFM no longer exists in the project.",
"path": "build/test-scripts/run-netcore-mobile-templ... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `GetAngle` now only runs when `$(TargetFramework)` equals `$(NetUWPOrWinUI)`. Since this project is referenced from `SamplesApp.Windows` (which now targets `$(NetCurrentWinAppSDK)`), MSBuild will typically build **only** the `$(NetCurrentUWPOrWinUI)` target of this project, meaning the ANGLE dylibs may never be downloa... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
index c7f5eb46fdda..46ee28c715a6 100644
--- a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
+++ b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.cspr... | [
"src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj"
] | [
{
"comment": "`GetAngle` now only runs when `$(TargetFramework)` equals `$(NetUWPOrWinUI)`. Since this project is referenced from `SamplesApp.Windows` (which now targets `$(NetCurrentWinAppSDK)`), MSBuild will typically build **only** the `$(NetCurrentUWPOrWinUI)` target of this project, meaning the ANGLE dylib... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `GetAngle` now runs only when `$(TargetFramework)` equals `$(NetUWPOrWinUI)`, but this project’s default `TargetFrameworks` is `$(NetSkiaPreviousAndCurrent)` (no WinUI/UWP TFMs). That means the ANGLE binaries won’t be downloaded in the common build, and the package can miss the `angle_binaries/osx/lib*` files.
Either ... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
index c7f5eb46fdda..46ee28c715a6 100644
--- a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj
+++ b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.cspr... | [
"src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj"
] | [
{
"comment": "`GetAngle` now runs only when `$(TargetFramework)` equals `$(NetUWPOrWinUI)`, but this project’s default `TargetFrameworks` is `$(NetSkiaPreviousAndCurrent)` (no WinUI/UWP TFMs). That means the ANGLE binaries won’t be downloaded in the common build, and the package can miss the `angle_binaries/osx... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This template publish validation still targets `net9.0-desktop`, but the 5.3 templates in this PR were updated to `net10.0-*`. Running this script will fail because `net9.0-desktop` won’t be a valid TargetFramework for that project anymore.
Update this entry to `net10.0-desktop` (and the `TargetFrameworks` property ac... | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1
index 9a917a093c57..ad50100a665a 100644
--- a/build/test-scripts/run-netcore-mobile-template-tests.ps1
+++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1
@@ -36,18 +36,18 @@ if ( ... | [
"build/test-scripts/run-netcore-mobile-template-tests.ps1"
] | [
{
"comment": "This template publish validation still targets `net9.0-desktop`, but the 5.3 templates in this PR were updated to `net10.0-*`. Running this script will fail because `net9.0-desktop` won’t be a valid TargetFramework for that project anymore.\n\nUpdate this entry to `net10.0-desktop` (and the `Targe... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | This template-test publish step still targets `net9.0-desktop`, but the 5.3 template project was updated to `net10.0-*` TFMs in this PR. As a result, this publish validation will fail because `net9.0-desktop` is no longer a valid target framework for that project. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/build/test-scripts/run-netcore-mobile-template-tests.ps1 b/build/test-scripts/run-netcore-mobile-template-tests.ps1
index 9a917a093c57..ad50100a665a 100644
--- a/build/test-scripts/run-netcore-mobile-template-tests.ps1
+++ b/build/test-scripts/run-netcore-mobile-template-tests.ps1
@@ -36,18 +36,18 @@ if ( ... | [
"build/test-scripts/run-netcore-mobile-template-tests.ps1"
] | [
{
"comment": "This template-test publish step still targets `net9.0-desktop`, but the 5.3 template project was updated to `net10.0-*` TFMs in this PR. As a result, this publish validation will fail because `net9.0-desktop` is no longer a valid target framework for that project.",
"path": "build/test-scripts... | true | ||
unoplatform/uno | 23,332 | comment_to_fix | chore: try building and testing against .NET 10 | `GetPropertyValue()` can legitimately return null (missing DP field/property), but it currently returns `DependencyProperty` (non-nullable). This can trigger nullable warnings and makes the subsequent `property is null` check inconsistent with the signature. Return `DependencyProperty?` instead. | c7b9ac0d1e68a3c806618d6f303fa678f5056e56 | 8bd11bcc6d76ba88b59ffb57692974e9b23df565 | diff --git a/src/Uno.UI.RuntimeTests/UITests/_Engine/UnoUITests/Helpers/QueryExtensions.cs b/src/Uno.UI.RuntimeTests/UITests/_Engine/UnoUITests/Helpers/QueryExtensions.cs
index 5c92ad2167f0..f8e8ccec3f20 100644
--- a/src/Uno.UI.RuntimeTests/UITests/_Engine/UnoUITests/Helpers/QueryExtensions.cs
+++ b/src/Uno.UI.RuntimeT... | [
"src/Uno.UI.RuntimeTests/UITests/_Engine/UnoUITests/Helpers/QueryExtensions.cs"
] | [
{
"comment": "`GetPropertyValue()` can legitimately return null (missing DP field/property), but it currently returns `DependencyProperty` (non-nullable). This can trigger nullable warnings and makes the subsequent `property is null` check inconsistent with the signature. Return `DependencyProperty?` instead.",... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.