repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
unoplatform/uno | 23,405 | issue_to_patch | Update repo-internal Windows App SDK to 2.1.3 (runtime tests, WinUI sync generator)
### What would you like to be added? 💡
Update the **Windows App SDK** version used *internally by the repository* to the latest 2.x stable (**2.1.3**), so that parity testing and the generated WinUI API surface reflect the latest Win... | chore: Update internal Windows App SDK to 2.1.3 + sync WinUI stubs | **GitHub Issue:** closes #23404
## PR Type:
🏗️ Build or CI related changes
## What changed? 🚀
Updates the **Windows App SDK** version used *internally by the repository* to the latest 2.x stable (**2.1.3**, with `Microsoft.Windows.SDK.BuildTools 10.0.26100.4654`), and regenerates the WinUI API stubs against that ... | df5d18a850248cb8c2ccb34032b4ebeb54dc8283 | 3a0255ee97d1384b35d42b1b0f7d5430d2ccd4c1 | diff --git a/.claude/skills/winui-runtime-tests/SKILL.md b/.claude/skills/winui-runtime-tests/SKILL.md
index b623cb2e1fbb..046164ad58cd 100644
--- a/.claude/skills/winui-runtime-tests/SKILL.md
+++ b/.claude/skills/winui-runtime-tests/SKILL.md
@@ -419,10 +419,10 @@ for m in re.finditer(r'<test-case\s+name=\"([^\"]+)\"[^... | [
".claude/skills/winui-runtime-tests/SKILL.md",
"build/ci/tests/.azure-devops-tests-winappsdk.yml",
"src/SamplesApp/SamplesApp.Windows/SamplesApp.Windows.csproj",
"src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.Windows.csproj",
"src/Uno.UI/Generated/3.0.0.0/Microsoft.UI.Content/DesktopPopupSiteBridge.cs",
"sr... | [] | diff --git a/build/ci/tests/.azure-devops-tests-winappsdk.yml b/build/ci/tests/.azure-devops-tests-winappsdk.yml
index f2e2baa8f33b..6cb34a4049d0 100644
--- a/build/ci/tests/.azure-devops-tests-winappsdk.yml
+++ b/build/ci/tests/.azure-devops-tests-winappsdk.yml
@@ -141,17 +141,27 @@ jobs:
- template: ../templates/d... | true |
unoplatform/uno | 23,307 | issue_to_patch | fix(cubicbeziereasingfunction): fix the calculation of the interpolation | **GitHub Issue:** closes https://github.com/unoplatform/kahua-private/issues/485
<!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal), unless the change is documentation related. -->
## PR Type:
<!--
Copy the label that applies to this PR and ... | 0658c33cbffe4fb135c949511d7123b6c7f3002e | 2083ccb86ee387f30e79ba4a57683561174f4f8c | diff --git a/src/Uno.UI.Composition/Composition/KeyFrameAnimations/CubicBezierEasingFunction.cs b/src/Uno.UI.Composition/Composition/KeyFrameAnimations/CubicBezierEasingFunction.cs
index 74968073b07f..f515a5b123ce 100644
--- a/src/Uno.UI.Composition/Composition/KeyFrameAnimations/CubicBezierEasingFunction.cs
+++ b/src/... | [
"src/Uno.UI.Composition/Composition/KeyFrameAnimations/CubicBezierEasingFunction.cs",
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Given_CubicBezierEasingFunction.cs"
] | [
{
"comment": "The comment references \"https://github.com/unoplatform/uno/issues\" without an issue number, so the link is not actionable. Please update it to the specific issue URL (or remove the link if it’s not meant to be a reference).\n",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Gi... | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Given_CubicBezierEasingFunction.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Given_CubicBezierEasingFunction.cs
new file mode 100644
index 000000000000..9393a01e0687
--- /dev/null
+++ b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Gi... | true | |
unoplatform/uno | 23,307 | comment_to_fix | fix(cubicbeziereasingfunction): fix the calculation of the interpolation | The comment references "https://github.com/unoplatform/uno/issues" without an issue number, so the link is not actionable. Please update it to the specific issue URL (or remove the link if it’s not meant to be a reference).
| 0658c33cbffe4fb135c949511d7123b6c7f3002e | 2083ccb86ee387f30e79ba4a57683561174f4f8c | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Given_CubicBezierEasingFunction.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Given_CubicBezierEasingFunction.cs
new file mode 100644
index 000000000000..9393a01e0687
--- /dev/null
+++ b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Gi... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Given_CubicBezierEasingFunction.cs"
] | [
{
"comment": "The comment references \"https://github.com/unoplatform/uno/issues\" without an issue number, so the link is not actionable. Please update it to the specific issue URL (or remove the link if it’s not meant to be a reference).\n",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Composition/Gi... | true | ||
unoplatform/uno | 23,307 | comment_to_fix | fix(cubicbeziereasingfunction): fix the calculation of the interpolation | The bisection fallback assumes SampleX is monotonic increasing (it updates lo/hi based on x > currentX). For control-point X values outside [0,1], SampleX can become non-monotonic, in which case this fallback can converge to an arbitrary parameter and return an incorrect easing value. Consider either validating/clampin... | 0658c33cbffe4fb135c949511d7123b6c7f3002e | 2083ccb86ee387f30e79ba4a57683561174f4f8c | diff --git a/src/Uno.UI.Composition/Composition/KeyFrameAnimations/CubicBezierEasingFunction.cs b/src/Uno.UI.Composition/Composition/KeyFrameAnimations/CubicBezierEasingFunction.cs
index 74968073b07f..f515a5b123ce 100644
--- a/src/Uno.UI.Composition/Composition/KeyFrameAnimations/CubicBezierEasingFunction.cs
+++ b/src/... | [
"src/Uno.UI.Composition/Composition/KeyFrameAnimations/CubicBezierEasingFunction.cs"
] | [
{
"comment": "The bisection fallback assumes SampleX is monotonic increasing (it updates lo/hi based on x > currentX). For control-point X values outside [0,1], SampleX can become non-monotonic, in which case this fallback can converge to an arbitrary parameter and return an incorrect easing value. Consider eit... | true | ||
unoplatform/uno | 23,341 | issue_to_patch | Text wrapping breaks alignment
### Current behavior 🐛
When text is centered, wrapping, and has width constraint, the alignment breaks. Also note that due to this bug, the text actually breaks out of the assigned constrained width:
<img width="392" height="269" alt="Image" src="https://github.com/user-attachments/as... | fix(text): fix the case of having a continuous word being wider than the entire line | **GitHub Issue:** closes https://github.com/unoplatform/uno/issues/21008
<!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal), unless the change is documentation related. -->
## PR Type:
<!--
Copy the label that applies to this PR and paste it... | 6aa50ccaf5f8fd983ced6c57b1a296ca31999475 | a4570d45cf1bce352e0bed6d5292ca3c2dfaa4a9 | diff --git a/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs b/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs
index 86f66a7bd1de..78ce0ed3101f 100644
--- a/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs
@@ -360,14 +360,24 @@ internal unsafe UnicodeText(
... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs",
"src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs"
] | [
{
"comment": "This fixes a regression-prone wrapping path, but the PR does not add coverage for the reported case where a normal word is already committed before an overlong continuous word. Existing long-word wrapping tests cover an overlong word starting on an empty line, so please add a runtime test with pre... | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs
index 079e601d81f1..1cf143517957 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs
+++ b/src/Uno.UI.RuntimeTests/Tests/W... | true |
unoplatform/uno | 23,341 | comment_to_fix | fix(text): fix the case of having a continuous word being wider than the entire line | This fixes a regression-prone wrapping path, but the PR does not add coverage for the reported case where a normal word is already committed before an overlong continuous word. Existing long-word wrapping tests cover an overlong word starting on an empty line, so please add a runtime test with preceding text plus a con... | 6aa50ccaf5f8fd983ced6c57b1a296ca31999475 | a4570d45cf1bce352e0bed6d5292ca3c2dfaa4a9 | diff --git a/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs b/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs
index 86f66a7bd1de..78ce0ed3101f 100644
--- a/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs
@@ -360,14 +360,24 @@ internal unsafe UnicodeText(
... | [
"src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs"
] | [
{
"comment": "This fixes a regression-prone wrapping path, but the PR does not add coverage for the reported case where a normal word is already committed before an overlong continuous word. Existing long-word wrapping tests cover an overlong word starting on an empty line, so please add a runtime test with pre... | true | ||
unoplatform/uno | 23,380 | issue_to_patch | chore(deps): bump dessant/lock-threads from 5 to 6 | Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads) from 5 to 6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/dessant/lock-threads/releases">dessant/lock-threads's releases</a>.</em></p>
<blockquote>
<h2>v6.0.0</h2>
<p>Learn more about this release from th... | 4357cb7149a935e0ab82e9aefb2d27deafd0359a | 44fbf3ddaacadefa135f220a3754ee912a1b8926 | diff --git a/.github/workflows/lock-threads.yml b/.github/workflows/lock-threads.yml
index 2cc4e229e5c8..14ff2e171348 100644
--- a/.github/workflows/lock-threads.yml
+++ b/.github/workflows/lock-threads.yml
@@ -16,7 +16,7 @@ jobs:
if: github.repository == 'unoplatform/uno'
runs-on: ubuntu-latest
steps:
-... | [
".github/workflows/lock-threads.yml"
] | [] | true | ||
unoplatform/uno | 23,378 | issue_to_patch | chore(deps): bump actions/setup-dotnet from 3.2.0 to 5.3.0 | Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 3.2.0 to 5.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/setup-dotnet/releases">actions/setup-dotnet's releases</a>.</em></p>
<blockquote>
<h2>v5.3.0</h2>
<h2>What's Changed</h2>
<h3>Enha... | f414a306b6c7f8d7b71ea8cb88382a26e4855328 | 95b1a3c4f9e1bceb0464655f1ef6c3a474964a19 | diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml
index 38c358ffa0eb..b836558f8762 100644
--- a/.github/workflows/codeql.yml
+++ b/.github/workflows/codeql.yml
@@ -84,7 +84,7 @@ jobs:
cp build/ci/net10/_global.json global.json
- name: Setup .NET SDK
- uses: actions/setup-dotn... | [
".github/workflows/codeql.yml",
".github/workflows/winappsdk-sync-apply.yml",
".github/workflows/winappsdk-sync-check.yml",
".github/workflows/xaml-style-apply.yml",
".github/workflows/xaml-style-check.yml"
] | [] | true | ||
unoplatform/uno | 23,371 | issue_to_patch | [Skia] Partial text selection behavior inconsistency
> Actually, the behavior is not entirely correct in Skia renderer, as it allows selecting a word by double tapping, and with a continuous tap, the options to "select all" and "copy" appear, but the balloons should appear to allow for a partial selection as it does i... | feat(textblock): add support for selection handling with touch input | **GitHub Issue:** closes https://github.com/unoplatform/uno/issues/20959
<!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal), unless the change is documentation related. -->
## PR Type:
<!--
Copy the label that applies to this PR and paste it... | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 5e8df1e45ded51ac0ed6178372831d9567b15bdb | diff --git a/src/Uno.UI.RuntimeTests/Helpers/ThemeHelper.cs b/src/Uno.UI.RuntimeTests/Helpers/ThemeHelper.cs
index eb19c1d97efd..76a1a73fb69b 100644
--- a/src/Uno.UI.RuntimeTests/Helpers/ThemeHelper.cs
+++ b/src/Uno.UI.RuntimeTests/Helpers/ThemeHelper.cs
@@ -18,12 +18,12 @@ public static IDisposable UseDarkTheme()
{... | [
"src/Uno.UI.RuntimeTests/Helpers/ThemeHelper.cs",
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs",
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBox.skia.cs",
"src/Uno.UI/UI/Xaml/Controls/Primitives/CaretWithStemAndThumb.skia.cs",
"src/Uno.UI/UI/Xaml/Controls/... | [
{
"comment": "The `index == _text.Length` branch now runs for `right:true`, and its `else` case currently returns `(_wordBoundaries[^2], _text.Length)` where the second value is treated as a *length*. That makes `start + length` exceed `_text.Length` for multi-word text, leading to invalid ranges for callers (e... | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs
index 079e601d81f1..8f070fb1c3cb 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs
+++ b/src/Uno.UI.RuntimeTests/Tests/W... | true |
unoplatform/uno | 23,371 | comment_to_fix | feat(textblock): add support for selection handling with touch input | The `index == _text.Length` branch now runs for `right:true`, and its `else` case currently returns `(_wordBoundaries[^2], _text.Length)` where the second value is treated as a *length*. That makes `start + length` exceed `_text.Length` for multi-word text, leading to invalid ranges for callers (e.g., touch word select... | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 5e8df1e45ded51ac0ed6178372831d9567b15bdb | diff --git a/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs b/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs
index 86f66a7bd1de..722505ecac08 100644
--- a/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs
@@ -1236,17 +1236,13 @@ public int GetIndexAt(Point p, bo... | [
"src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs"
] | [
{
"comment": "The `index == _text.Length` branch now runs for `right:true`, and its `else` case currently returns `(_wordBoundaries[^2], _text.Length)` where the second value is treated as a *length*. That makes `start + length` exceed `_text.Length` for multi-word text, leading to invalid ranges for callers (e... | true | ||
unoplatform/uno | 23,371 | comment_to_fix | feat(textblock): add support for selection handling with touch input | `OnPointerReleasedPartial` sets `_isPressed = false` twice (once immediately after the guard, and again a few lines later). Also, the new comment contains typos ("preceeding", "content menu"). This makes the logic harder to follow and suggests an accidental duplication. | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 5e8df1e45ded51ac0ed6178372831d9567b15bdb | diff --git a/src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.pointers.skia.cs b/src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.pointers.skia.cs
index 03ef76b573e1..2fa115ef60ff 100644
--- a/src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.pointers.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.pointers.skia.cs
@@ -119,6... | [
"src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.pointers.skia.cs"
] | [
{
"comment": "`OnPointerReleasedPartial` sets `_isPressed = false` twice (once immediately after the guard, and again a few lines later). Also, the new comment contains typos (\"preceeding\", \"content menu\"). This makes the logic harder to follow and suggests an accidental duplication.",
"path": "src/Uno.... | true | ||
unoplatform/uno | 23,371 | comment_to_fix | feat(textblock): add support for selection handling with touch input | Typo in the touch-hold comment: "content menu" should be "context menu". | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 5e8df1e45ded51ac0ed6178372831d9567b15bdb | diff --git a/src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.pointers.skia.cs b/src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.pointers.skia.cs
index 03ef76b573e1..2fa115ef60ff 100644
--- a/src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.pointers.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.pointers.skia.cs
@@ -119,6... | [
"src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.pointers.skia.cs"
] | [
{
"comment": "Typo in the touch-hold comment: \"content menu\" should be \"context menu\".",
"path": "src/Uno.UI/UI/Xaml/Controls/TextBox/TextBox.pointers.skia.cs",
"hunk": "@@ -180,22 +189,18 @@ partial void OnPointerReleasedPartial(PointerRoutedEventArgs args, bool wasFocus\n \t\t_isPressed = false;\n... | true | ||
unoplatform/uno | 23,371 | comment_to_fix | feat(textblock): add support for selection handling with touch input | `_lastPointerDownPoint` is never cleared in `OnPointerReleasedForSelectionFlyout`. If a PointerReleased is raised without a corresponding touch/pen press (or if a previous press was cancelled), the stale timestamp can be reused and cause a later release to be misclassified as a tap/hold. Clearing the stored press point... | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 5e8df1e45ded51ac0ed6178372831d9567b15bdb | diff --git a/src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.skia.cs b/src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.skia.cs
index 39387f3a21da..4325bd23721c 100644
--- a/src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.skia.cs
@@ -26,7 +26,7 @@
namespac... | [
"src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.skia.cs"
] | [
{
"comment": "`_lastPointerDownPoint` is never cleared in `OnPointerReleasedForSelectionFlyout`. If a PointerReleased is raised without a corresponding touch/pen press (or if a previous press was cancelled), the stale timestamp can be reused and cause a later release to be misclassified as a tap/hold. Clearing ... | true | ||
unoplatform/uno | 23,371 | comment_to_fix | feat(textblock): add support for selection handling with touch input | Constructor parameter has an extra space (`Action repositionCallback`), which looks like a typo and will fail style analyzers if whitespace rules are enforced. | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 5e8df1e45ded51ac0ed6178372831d9567b15bdb | diff --git a/src/Uno.UI/UI/Xaml/Controls/Primitives/CaretWithStemAndThumb.skia.cs b/src/Uno.UI/UI/Xaml/Controls/Primitives/CaretWithStemAndThumb.skia.cs
new file mode 100644
index 000000000000..71b386e63783
--- /dev/null
+++ b/src/Uno.UI/UI/Xaml/Controls/Primitives/CaretWithStemAndThumb.skia.cs
@@ -0,0 +1,125 @@
+using... | [
"src/Uno.UI/UI/Xaml/Controls/Primitives/CaretWithStemAndThumb.skia.cs"
] | [
{
"comment": "Constructor parameter has an extra space (`Action repositionCallback`), which looks like a typo and will fail style analyzers if whitespace rules are enforced.",
"path": "src/Uno.UI/UI/Xaml/Controls/Primitives/CaretWithStemAndThumb.skia.cs",
"hunk": "@@ -0,0 +1,125 @@\n+using System;\n+us... | true | ||
unoplatform/uno | 23,371 | comment_to_fix | feat(textblock): add support for selection handling with touch input | This test changes the expected finger-tap behavior for *all* targets, but the implementation change is Skia-specific (the new tap-to-select-word logic lives in `TextBlock.skia.cs`). On non-Skia targets this will likely assert a behavior that wasn't changed by this PR, making the test platform-dependent/failing. | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 5e8df1e45ded51ac0ed6178372831d9567b15bdb | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs
index 079e601d81f1..8f070fb1c3cb 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs
+++ b/src/Uno.UI.RuntimeTests/Tests/W... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs"
] | [
{
"comment": "This test changes the expected finger-tap behavior for *all* targets, but the implementation change is Skia-specific (the new tap-to-select-word logic lives in `TextBlock.skia.cs`). On non-Skia targets this will likely assert a behavior that wasn't changed by this PR, making the test platform-depe... | true | ||
unoplatform/uno | 23,371 | comment_to_fix | feat(textblock): add support for selection handling with touch input | This new file references `TextBlock` but does not import `Microsoft.UI.Xaml.Controls`, so `TextBlock` will not resolve in this namespace (`Microsoft.UI.Xaml.Controls.Primitives`). This is a compile-time issue unless `TextBlock` is fully qualified. | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 5e8df1e45ded51ac0ed6178372831d9567b15bdb | diff --git a/src/Uno.UI/UI/Xaml/Controls/Primitives/TextSelectionGripperPresenter.skia.cs b/src/Uno.UI/UI/Xaml/Controls/Primitives/TextSelectionGripperPresenter.skia.cs
new file mode 100644
index 000000000000..7c43721003fc
--- /dev/null
+++ b/src/Uno.UI/UI/Xaml/Controls/Primitives/TextSelectionGripperPresenter.skia.cs
... | [
"src/Uno.UI/UI/Xaml/Controls/Primitives/TextSelectionGripperPresenter.skia.cs"
] | [
{
"comment": "This new file references `TextBlock` but does not import `Microsoft.UI.Xaml.Controls`, so `TextBlock` will not resolve in this namespace (`Microsoft.UI.Xaml.Controls.Primitives`). This is a compile-time issue unless `TextBlock` is fully qualified.",
"path": "src/Uno.UI/UI/Xaml/Controls/Primiti... | true | ||
unoplatform/uno | 23,371 | comment_to_fix | feat(textblock): add support for selection handling with touch input | This new file derives from `Grid` and uses `RowDefinition`, `GridLength`, `Thickness`, `Visibility`, and `XamlRoot`, but it doesn't import `Microsoft.UI.Xaml` / `Microsoft.UI.Xaml.Controls`. Unless those types are fully qualified elsewhere, this will not compile. | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 5e8df1e45ded51ac0ed6178372831d9567b15bdb | diff --git a/src/Uno.UI/UI/Xaml/Controls/Primitives/CaretWithStemAndThumb.skia.cs b/src/Uno.UI/UI/Xaml/Controls/Primitives/CaretWithStemAndThumb.skia.cs
new file mode 100644
index 000000000000..71b386e63783
--- /dev/null
+++ b/src/Uno.UI/UI/Xaml/Controls/Primitives/CaretWithStemAndThumb.skia.cs
@@ -0,0 +1,125 @@
+using... | [
"src/Uno.UI/UI/Xaml/Controls/Primitives/CaretWithStemAndThumb.skia.cs"
] | [
{
"comment": "This new file derives from `Grid` and uses `RowDefinition`, `GridLength`, `Thickness`, `Visibility`, and `XamlRoot`, but it doesn't import `Microsoft.UI.Xaml` / `Microsoft.UI.Xaml.Controls`. Unless those types are fully qualified elsewhere, this will not compile.",
"path": "src/Uno.UI/UI/Xaml/... | true | ||
unoplatform/uno | 23,371 | comment_to_fix | feat(textblock): add support for selection handling with touch input | This should remain `Standard`:
https://github.com/microsoft/microsoft-ui-xaml/blob/fc2f821173298e8130fb5b143373ba70793bc251/src/dxaml/xcp/core/core/elements/uielement.cpp#L12594-L12613 | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 5e8df1e45ded51ac0ed6178372831d9567b15bdb | diff --git a/src/Uno.UI/UI/Xaml/UIElement.ContextRequested.cs b/src/Uno.UI/UI/Xaml/UIElement.ContextRequested.cs
index 0794db61b469..2b8d5200939e 100644
--- a/src/Uno.UI/UI/Xaml/UIElement.ContextRequested.cs
+++ b/src/Uno.UI/UI/Xaml/UIElement.ContextRequested.cs
@@ -42,6 +42,13 @@ internal static void OnContextRequeste... | [
"src/Uno.UI/UI/Xaml/UIElement.ContextRequested.cs"
] | [
{
"comment": "This should remain `Standard`:\n\nhttps://github.com/microsoft/microsoft-ui-xaml/blob/fc2f821173298e8130fb5b143373ba70793bc251/src/dxaml/xcp/core/core/elements/uielement.cpp#L12594-L12613",
"path": "src/Uno.UI/UI/Xaml/UIElement.ContextRequested.cs",
"hunk": "@@ -117,7 +124,7 @@ sender is R... | true | ||
unoplatform/uno | 23,371 | comment_to_fix | feat(textblock): add support for selection handling with touch input | `UnicodeText.GetWordAt`'s `right` parameter contract is documented as selecting the left vs right word when on a boundary, but the `index == _text.Length` case no longer honors it. With the current code, `GetWordAt(_text.Length, right: true)` returns the *last* word rather than an empty range, which makes the method in... | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 5e8df1e45ded51ac0ed6178372831d9567b15bdb | diff --git a/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs b/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs
index 86f66a7bd1de..722505ecac08 100644
--- a/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs
@@ -1236,17 +1236,13 @@ public int GetIndexAt(Point p, bo... | [
"src/Uno.UI/UI/Xaml/Documents/UnicodeText.skia.cs"
] | [
{
"comment": "`UnicodeText.GetWordAt`'s `right` parameter contract is documented as selecting the left vs right word when on a boundary, but the `index == _text.Length` case no longer honors it. With the current code, `GetWordAt(_text.Length, right: true)` returns the *last* word rather than an empty range, whi... | true | ||
unoplatform/uno | 23,344 | issue_to_patch | refactor: Cleanup NuGet packages | **GitHub Issue:** closes #
<!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal), unless the change is documentation related. -->
## PR Type:
<!--
Copy the label that applies to this PR and paste it above:
🐞 Bugfix
✨ Feature
🎨 Code style... | 7770ba1d72de8dc049d4693e395410310a238e2c | 561a85aef4162d9931683f5c0494a2f61626fc4a | diff --git a/src/SamplesApp/UnoIslandsSamplesApp.Skia/UnoIslandsSamplesApp.Skia.csproj b/src/SamplesApp/UnoIslandsSamplesApp.Skia/UnoIslandsSamplesApp.Skia.csproj
index 485d3d53559d..7a7a92c2877e 100644
--- a/src/SamplesApp/UnoIslandsSamplesApp.Skia/UnoIslandsSamplesApp.Skia.csproj
+++ b/src/SamplesApp/UnoIslandsSample... | [
"src/SamplesApp/UnoIslandsSamplesApp.Skia/UnoIslandsSamplesApp.Skia.csproj",
"src/Uno.UI.Tests.ViewLibrary/Uno.UI.Tests.ViewLibrary.csproj",
"src/Uno.UI.Tests.ViewLibraryProps/Uno.UI.Tests.ViewLibraryProps.csproj",
"src/Uno.UI.Tests/Uno.UI.Unit.Tests.csproj"
] | [] | true | ||
unoplatform/uno | 23,397 | issue_to_patch | VisualState.Setter {ThemeResource} resolves against the application theme instead of the element's RequestedTheme
### Current behavior 🐛
A control that lives in a subtree pinned to an explicit `RequestedTheme` that differs from the application theme (for example a `RequestedTheme="Light"` subtree while the applicati... | fix(theming): honor owner theme in VisualState setter | **GitHub Issue:** closes #23396
## PR Type:
Bugfix
## What changed? 🚀
A property set through a `VisualState.Setter` whose value is a `{ThemeResource}` could paint the wrong theme's brush for an element living in a subtree pinned to a `RequestedTheme` that differs from the application theme (e.g. a `RequestedTheme="... | 1e2e0aa20513549559af4b4250f9a1e11018683c | b7b1bea6920458102774911a608137cdb2379ad8 | diff --git a/src/Uno.UI/UI/Xaml/ResourceResolver.cs b/src/Uno.UI/UI/Xaml/ResourceResolver.cs
index 646db59f555a..4758d9d1ef7c 100644
--- a/src/Uno.UI/UI/Xaml/ResourceResolver.cs
+++ b/src/Uno.UI/UI/Xaml/ResourceResolver.cs
@@ -425,33 +425,54 @@ internal static void ApplyThemeResource(DependencyObject owner, DependencyP... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/CheckBoxNavReproOtherPage.xaml",
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/CheckBoxNavReproOtherPage.xaml.cs",
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/FlatButtonNavReproPage.xaml",
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_X... | [
{
"comment": "The comment refers to a “key-frame” resolution, but this repro uses a VisualState.Setter (no storyboard key-frames). This can be misleading when someone later tries to understand what is being exercised.",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/ThemeNavReproOverrides.x... | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/CheckBoxNavReproOtherPage.xaml b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/CheckBoxNavReproOtherPage.xaml
new file mode 100644
index 000000000000..77381c4a51cc
--- /dev/null
+++ b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Chec... | true |
unoplatform/uno | 23,397 | comment_to_fix | fix(theming): honor owner theme in VisualState setter | The comment refers to a “key-frame” resolution, but this repro uses a VisualState.Setter (no storyboard key-frames). This can be misleading when someone later tries to understand what is being exercised. | 1e2e0aa20513549559af4b4250f9a1e11018683c | b7b1bea6920458102774911a608137cdb2379ad8 | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/ThemeNavReproOverrides.xaml b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/ThemeNavReproOverrides.xaml
new file mode 100644
index 000000000000..95252b105244
--- /dev/null
+++ b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/ThemeNavRe... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/ThemeNavReproOverrides.xaml"
] | [
{
"comment": "The comment refers to a “key-frame” resolution, but this repro uses a VisualState.Setter (no storyboard key-frames). This can be misleading when someone later tries to understand what is being exercised.",
"path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/ThemeNavReproOverrides.x... | true | ||
unoplatform/uno | 23,302 | issue_to_patch | [macOS] `SpeechRecognizer`
## What would you like to be added:
`SpeechRecognizer` on macOS
## Notes for contributors:
Should be fairly similar to the iOS implementation, except for some missing classes that must be replaced by macOS alternatives.
## For which Platform:
- [ ] iOS
- [ ] Android
- [ ] We... | feat: Add macOS speech recognition support | **GitHub Issue:** closes https://github.com/unoplatform/uno/issues/5631
<!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal), unless the change is documentation related. -->
## PR Type:
<!--
Copy the label that applies to this PR and paste it ... | 3e317847cad85f94e0e3d59dc8b6460f730efd06 | 4c25e1dafd1c79ed15ce6a1084d14e3f8ec13750 | diff --git a/doc/articles/features/SpeechRecognition.md b/doc/articles/features/SpeechRecognition.md
index 060a3fbc2a8b..4b75945ed65b 100644
--- a/doc/articles/features/SpeechRecognition.md
+++ b/doc/articles/features/SpeechRecognition.md
@@ -15,28 +15,28 @@ Uno's implementation currently supports basic native speech r... | [
"doc/articles/features/SpeechRecognition.md",
"src/SamplesApp/SamplesApp.Skia.Generic/Resources/Info.plist",
"src/SamplesApp/SamplesApp.Skia.Generic/SamplesApp.Skia.Generic.csproj",
"src/SamplesApp/SamplesApp.Skia.netcoremobile/MacCatalyst/Info.plist",
"src/SamplesApp/SamplesApp.Skia.netcoremobile/iOS/Info.... | [
{
"comment": "In the audio-engine start failure path, the input tap and recognition task/request are left active (you return NO after raising an error without removing the tap / cancelling the task). This can leak resources and break subsequent recognition attempts. Consider calling teardownAudio (and/or cancel... | true | |
unoplatform/uno | 23,302 | comment_to_fix | feat: Add macOS speech recognition support | In the audio-engine start failure path, the input tap and recognition task/request are left active (you return NO after raising an error without removing the tap / cancelling the task). This can leak resources and break subsequent recognition attempts. Consider calling teardownAudio (and/or cancelling the recognitionTa... | 3e317847cad85f94e0e3d59dc8b6460f730efd06 | 4c25e1dafd1c79ed15ce6a1084d14e3f8ec13750 | diff --git a/src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOSpeechRecognizer.m b/src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOSpeechRecognizer.m
new file mode 100644
index 000000000000..ef02e2569aae
--- /dev/null
+++ b/src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOSpeechRecognizer... | [
"src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOSpeechRecognizer.m"
] | [
{
"comment": "In the audio-engine start failure path, the input tap and recognition task/request are left active (you return NO after raising an error without removing the tap / cancelling the task). This can leak resources and break subsequent recognition attempts. Consider calling teardownAudio (and/or cancel... | true | ||
unoplatform/uno | 23,302 | comment_to_fix | feat: Add macOS speech recognition support | teardownAudio clears recognitionTask by setting it to nil, but does not cancel it first. If the recognizer is destroyed or stopped mid-recognition, the task can continue running and invoke callbacks after managed disposal. Consider explicitly cancelling the recognitionTask before releasing it (and then nil it) to ensur... | 3e317847cad85f94e0e3d59dc8b6460f730efd06 | 4c25e1dafd1c79ed15ce6a1084d14e3f8ec13750 | diff --git a/src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOSpeechRecognizer.m b/src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOSpeechRecognizer.m
new file mode 100644
index 000000000000..ef02e2569aae
--- /dev/null
+++ b/src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOSpeechRecognizer... | [
"src/Uno.UI.Runtime.Skia.MacOS/UnoNativeMac/UnoNativeMac/UNOSpeechRecognizer.m"
] | [
{
"comment": "teardownAudio clears recognitionTask by setting it to nil, but does not cancel it first. If the recognizer is destroyed or stopped mid-recognition, the task can continue running and invoke callbacks after managed disposal. Consider explicitly cancelling the recognitionTask before releasing it (and... | true | ||
unoplatform/uno | 23,302 | comment_to_fix | feat: Add macOS speech recognition support | The supported-features table lists `StopRecognitionAsync()()` (double parentheses), which looks like a typo and may confuse readers searching for the API. It should likely be `StopRecognitionAsync()`.
| 3e317847cad85f94e0e3d59dc8b6460f730efd06 | 4c25e1dafd1c79ed15ce6a1084d14e3f8ec13750 | diff --git a/doc/articles/features/SpeechRecognition.md b/doc/articles/features/SpeechRecognition.md
index 060a3fbc2a8b..4b75945ed65b 100644
--- a/doc/articles/features/SpeechRecognition.md
+++ b/doc/articles/features/SpeechRecognition.md
@@ -15,28 +15,28 @@ Uno's implementation currently supports basic native speech r... | [
"doc/articles/features/SpeechRecognition.md"
] | [
{
"comment": "The supported-features table lists `StopRecognitionAsync()()` (double parentheses), which looks like a typo and may confuse readers searching for the API. It should likely be `StopRecognitionAsync()`.\n",
"path": "doc/articles/features/SpeechRecognition.md",
"hunk": "@@ -15,28 +15,28 @@ Un... | true | ||
unoplatform/uno | 23,302 | comment_to_fix | feat: Add macOS speech recognition support | The suggested `open ...` command has a malformed app bundle name/path (`SamplesApp.> Skia.Generic.app`), which will not work as written. Please correct it to the actual `.app` bundle name/path produced by the build target (likely `SamplesApp.Skia.Generic.app`).
| 3e317847cad85f94e0e3d59dc8b6460f730efd06 | 4c25e1dafd1c79ed15ce6a1084d14e3f8ec13750 | diff --git a/doc/articles/features/SpeechRecognition.md b/doc/articles/features/SpeechRecognition.md
index 060a3fbc2a8b..4b75945ed65b 100644
--- a/doc/articles/features/SpeechRecognition.md
+++ b/doc/articles/features/SpeechRecognition.md
@@ -15,28 +15,28 @@ Uno's implementation currently supports basic native speech r... | [
"doc/articles/features/SpeechRecognition.md"
] | [
{
"comment": "The suggested `open ...` command has a malformed app bundle name/path (`SamplesApp.> Skia.Generic.app`), which will not work as written. Please correct it to the actual `.app` bundle name/path produced by the build target (likely `SamplesApp.Skia.Generic.app`).\n",
"path": "doc/articles/featur... | true | ||
unoplatform/uno | 23,319 | issue_to_patch | fix(x11): drop XIM fallback as it causes input issues on WSL | **GitHub Issue:** closes https://github.com/unoplatform/studio.live/issues/2008
<!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal), unless the change is documentation related. -->
## PR Type:
<!--
Copy the label that applies to this PR and p... | 6914f92ed1585eea6623dfcccf1d9b863e0c504e | 79a466e381ff0ed7260a22114e9a272e5476de07 | diff --git a/src/Uno.UI.Runtime.Skia.X11/Devices/Input/X11KeyboardInputSource.cs b/src/Uno.UI.Runtime.Skia.X11/Devices/Input/X11KeyboardInputSource.cs
index 2c59818a70c5..91287b3865fe 100644
--- a/src/Uno.UI.Runtime.Skia.X11/Devices/Input/X11KeyboardInputSource.cs
+++ b/src/Uno.UI.Runtime.Skia.X11/Devices/Input/X11Keyb... | [
"src/Uno.UI.Runtime.Skia.X11/Devices/Input/X11KeyboardInputSource.cs",
"src/Uno.UI.Runtime.Skia.X11/Hosting/X11ApplicationHost.cs",
"src/Uno.UI.Runtime.Skia.X11/Hosting/X11XamlRootHost.x11events.cs",
"src/Uno.UI.Runtime.Skia.X11/IME/FcitxInputMethod.cs",
"src/Uno.UI.Runtime.Skia.X11/IME/IBusInputMethod.cs",... | [
{
"comment": "StartImeSession snapshots the IME instance once, but the D-Bus IME is initialized asynchronously. If StartImeSession runs before the keyboard source has populated _dbusIme (or before the backend’s IsEnabled flips true), focus/cursor location are never pushed to the IME, so composition may remain n... | true | ||
unoplatform/uno | 23,319 | comment_to_fix | fix(x11): drop XIM fallback as it causes input issues on WSL | StartImeSession snapshots the IME instance once, but the D-Bus IME is initialized asynchronously. If StartImeSession runs before the keyboard source has populated _dbusIme (or before the backend’s IsEnabled flips true), focus/cursor location are never pushed to the IME, so composition may remain non-functional until th... | 6914f92ed1585eea6623dfcccf1d9b863e0c504e | 79a466e381ff0ed7260a22114e9a272e5476de07 | diff --git a/src/Uno.UI.Runtime.Skia.X11/UI/Xaml/Controls/TextBox/X11ImeTextBoxExtension.cs b/src/Uno.UI.Runtime.Skia.X11/UI/Xaml/Controls/TextBox/X11ImeTextBoxExtension.cs
index bf946d16507f..a50a07fcb607 100644
--- a/src/Uno.UI.Runtime.Skia.X11/UI/Xaml/Controls/TextBox/X11ImeTextBoxExtension.cs
+++ b/src/Uno.UI.Runti... | [
"src/Uno.UI.Runtime.Skia.X11/UI/Xaml/Controls/TextBox/X11ImeTextBoxExtension.cs"
] | [
{
"comment": "StartImeSession snapshots the IME instance once, but the D-Bus IME is initialized asynchronously. If StartImeSession runs before the keyboard source has populated _dbusIme (or before the backend’s IsEnabled flips true), focus/cursor location are never pushed to the IME, so composition may remain n... | true | ||
unoplatform/uno | 23,376 | issue_to_patch | Modernize AI coding-agent configuration (AGENTS.md, .claude/rules, skills)
## What would you like to be added? 💡
Restructure the repository's AI coding-agent guidance so it is leaner, path-scoped, and single-sourced:
- **Slim `AGENTS.md`** (loaded into every agent session) down to only what an agent would get wrong... | chore: Modernize AI coding-agent configuration (AGENTS.md, rules, skills) | **GitHub Issue:** closes #23375
## PR Type:
🤖 Project automation
## What changed? 🚀
Modernizes the repository's AI coding-agent configuration. No runtime/product code is touched.
- **`AGENTS.md` slimmed** to always-relevant guidance; detailed subsystem conventions moved into path-scoped **`.claude/rules/`** (`co... | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 87c1767815681e50aeb6cd52cf4165da2377c1fa | diff --git a/.claude/rules/build-system.md b/.claude/rules/build-system.md
new file mode 100644
index 000000000000..381cc9251fa1
--- /dev/null
+++ b/.claude/rules/build-system.md
@@ -0,0 +1,21 @@
+---
+description: MSBuild/cross-targeting internals for the Uno solution (TFMs, output paths, package versions, runtime ass... | [
".claude/rules/build-system.md",
".claude/rules/code-style.md",
".claude/rules/debugging-discipline.md",
".claude/rules/dependency-properties.md",
".claude/rules/platform-targeting.md",
".claude/rules/runtime-tests.md",
".claude/rules/samples.md",
".claude/rules/source-generators.md",
".claude/rules... | [
{
"comment": "The suggested command runs `dotnet test` on `src/Uno.UI/Uno.UI.Tests.csproj`, which is not a test project (no MSTest adapter/packages) and will typically report “no tests found”. For Uno.UI unit tests, the actual test project is `src/Uno.UI.Tests/Uno.UI.Unit.Tests.csproj`.",
"path": ".claude/r... | true | |
unoplatform/uno | 23,376 | comment_to_fix | chore: Modernize AI coding-agent configuration (AGENTS.md, rules, skills) | The suggested command runs `dotnet test` on `src/Uno.UI/Uno.UI.Tests.csproj`, which is not a test project (no MSTest adapter/packages) and will typically report “no tests found”. For Uno.UI unit tests, the actual test project is `src/Uno.UI.Tests/Uno.UI.Unit.Tests.csproj`. | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 87c1767815681e50aeb6cd52cf4165da2377c1fa | diff --git a/.claude/rules/unit-tests.md b/.claude/rules/unit-tests.md
new file mode 100644
index 000000000000..5c93c4178dc6
--- /dev/null
+++ b/.claude/rules/unit-tests.md
@@ -0,0 +1,17 @@
+---
+description: Conventions for Uno.UI unit tests (pure logic, no visual tree). Auto-loaded in Uno.UI.Tests. Distinct from runt... | [
".claude/rules/unit-tests.md"
] | [
{
"comment": "The suggested command runs `dotnet test` on `src/Uno.UI/Uno.UI.Tests.csproj`, which is not a test project (no MSTest adapter/packages) and will typically report “no tests found”. For Uno.UI unit tests, the actual test project is `src/Uno.UI.Tests/Uno.UI.Unit.Tests.csproj`.",
"path": ".claude/r... | true | ||
unoplatform/uno | 23,376 | comment_to_fix | chore: Modernize AI coding-agent configuration (AGENTS.md, rules, skills) | `[RunsOnUIThread]` is used both at the class level and at the individual `[TestMethod]` level in the existing runtime tests (e.g. `Given_Control` applies it per method). Saying the test class “needs” the attribute can mislead authors into thinking method-level usage is invalid. | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 87c1767815681e50aeb6cd52cf4165da2377c1fa | diff --git a/.claude/rules/runtime-tests.md b/.claude/rules/runtime-tests.md
new file mode 100644
index 000000000000..2c3ce098e835
--- /dev/null
+++ b/.claude/rules/runtime-tests.md
@@ -0,0 +1,23 @@
+---
+description: Conventions for writing Uno runtime tests (real visual tree, runs on Skia/WASM/native/WinUI). Auto-loa... | [
".claude/rules/runtime-tests.md"
] | [
{
"comment": "`[RunsOnUIThread]` is used both at the class level and at the individual `[TestMethod]` level in the existing runtime tests (e.g. `Given_Control` applies it per method). Saying the test class “needs” the attribute can mislead authors into thinking method-level usage is invalid.",
"path": ".cla... | true | ||
unoplatform/uno | 23,388 | issue_to_patch | fix: App-level ThemeResource overrides lost on storyboard keyframes | **GitHub Issue:** closes https://github.com/unoplatform/kahua-private/issues/491
## PR Type:
🤖 Bug
## What changed? 🚀
Fix App-Level ThemeResource overrides
## PR Checklist ✅
- [x] 🧪 Added Runtime tests, UI tests, or a manual test sample — _N/A: no runtime/product code changes_
- [ ] 📚 Docs added/... | 4357cb7149a935e0ab82e9aefb2d27deafd0359a | d467a555dbb7c8355c2229c8d5efc875ddb5209c | diff --git a/src/Uno.UI/UI/Xaml/Data/ThemeResourceReference.cs b/src/Uno.UI/UI/Xaml/Data/ThemeResourceReference.cs
index 95114cf0f769..1d343f7ff48e 100644
--- a/src/Uno.UI/UI/Xaml/Data/ThemeResourceReference.cs
+++ b/src/Uno.UI/UI/Xaml/Data/ThemeResourceReference.cs
@@ -342,9 +342,18 @@ private static Theme ResolveInhe... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/CheckBoxReproOverrides.xaml",
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/CheckBoxReproOverrides.xaml.cs",
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_CheckBox_ThemeResource_Regression.cs",
"src/Uno.UI/UI/Xaml/Data/ThemeReso... | [
{
"comment": "When repinning the ThemeResourceReference after resolving via TryTopLevelRetrieval, the reference is updated with LastResolvedValue but not marked as resolved. `IsResolved` is used elsewhere to distinguish deferred/unresolved refs (notably when the resolved value can be null), so it should be set ... | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/CheckBoxReproOverrides.xaml b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/CheckBoxReproOverrides.xaml
new file mode 100644
index 000000000000..45050f9ea2ad
--- /dev/null
+++ b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/CheckBoxRe... | true | |
unoplatform/uno | 23,388 | comment_to_fix | fix: App-level ThemeResource overrides lost on storyboard keyframes | When repinning the ThemeResourceReference after resolving via TryTopLevelRetrieval, the reference is updated with LastResolvedValue but not marked as resolved. `IsResolved` is used elsewhere to distinguish deferred/unresolved refs (notably when the resolved value can be null), so it should be set to true when a value h... | 4357cb7149a935e0ab82e9aefb2d27deafd0359a | d467a555dbb7c8355c2229c8d5efc875ddb5209c | diff --git a/src/Uno.UI/UI/Xaml/DependencyObjectStore.Theming.cs b/src/Uno.UI/UI/Xaml/DependencyObjectStore.Theming.cs
index 080e8ea768e7..cee93d16af1d 100644
--- a/src/Uno.UI/UI/Xaml/DependencyObjectStore.Theming.cs
+++ b/src/Uno.UI/UI/Xaml/DependencyObjectStore.Theming.cs
@@ -533,6 +533,7 @@ private void InnerUpdateR... | [
"src/Uno.UI/UI/Xaml/DependencyObjectStore.Theming.cs"
] | [
{
"comment": "When repinning the ThemeResourceReference after resolving via TryTopLevelRetrieval, the reference is updated with LastResolvedValue but not marked as resolved. `IsResolved` is used elsewhere to distinguish deferred/unresolved refs (notably when the resolved value can be null), so it should be set ... | true | ||
unoplatform/uno | 23,339 | issue_to_patch | feat: Add x:Load compiler error diagnostics (WMC0907/WMC0913) | **GitHub Issue:** https://github.com/unoplatform/kahua-private/issues/403
## PR Type:
✨ Feature
## What changed? 🚀
Previously, the Uno XAML source generator did not emit errors for invalid `x:Load` usage that the WinUI XAML compiler rejects. This PR adds the missing diagnostics:
- **WMC0907**: `x:Load... | b35817e841b1ea2464f60e03fa24abc5b10e04d1 | dc8aee22689d5de7a0b4b535fdf7c98eeabb6a17 | diff --git a/src/SourceGenerators/Uno.UI.SourceGenerators.Tests/MetadataUpdateTests/Scenarios/When_DataTemplate_xLoad_xBind_Add/0/p1/MainPage.xaml b/src/SourceGenerators/Uno.UI.SourceGenerators.Tests/MetadataUpdateTests/Scenarios/When_DataTemplate_xLoad_xBind_Add/0/p1/MainPage.xaml
index f8d477b0e53d..771fb4c22d7f 1006... | [
"src/SourceGenerators/Uno.UI.SourceGenerators.Tests/MetadataUpdateTests/Scenarios/When_DataTemplate_xLoad_xBind_Add/0/p1/MainPage.xaml",
"src/SourceGenerators/Uno.UI.SourceGenerators.Tests/MetadataUpdateTests/Scenarios/When_DataTemplate_xLoad_xBind_Add/1/p1/MainPage.xaml",
"src/SourceGenerators/Uno.UI.SourceGen... | [
{
"comment": "The XAML snippet in this test has an extra '>' after the self-closing <Border ... /> tag (`/> >`), which makes the XAML invalid and will likely fail parsing for the wrong reason (before the intended WMC0913 diagnostic is reached). Remove the trailing '>' so the test exercises only the x:Load valid... | true | ||
unoplatform/uno | 23,339 | comment_to_fix | feat: Add x:Load compiler error diagnostics (WMC0907/WMC0913) | The XAML snippet in this test has an extra '>' after the self-closing <Border ... /> tag (`/> >`), which makes the XAML invalid and will likely fail parsing for the wrong reason (before the intended WMC0913 diagnostic is reached). Remove the trailing '>' so the test exercises only the x:Load validation.
| b35817e841b1ea2464f60e03fa24abc5b10e04d1 | dc8aee22689d5de7a0b4b535fdf7c98eeabb6a17 | diff --git a/src/SourceGenerators/Uno.UI.SourceGenerators.Tests/XamlCodeGeneratorTests/Given_Parser.Errors.cs b/src/SourceGenerators/Uno.UI.SourceGenerators.Tests/XamlCodeGeneratorTests/Given_Parser.Errors.cs
index 124a34efbfc7..62c1e4433934 100644
--- a/src/SourceGenerators/Uno.UI.SourceGenerators.Tests/XamlCodeGenera... | [
"src/SourceGenerators/Uno.UI.SourceGenerators.Tests/XamlCodeGeneratorTests/Given_Parser.Errors.cs"
] | [
{
"comment": "The XAML snippet in this test has an extra '>' after the self-closing <Border ... /> tag (`/> >`), which makes the XAML invalid and will likely fail parsing for the wrong reason (before the intended WMC0913 diagnostic is reached). Remove the trailing '>' so the test exercises only the x:Load valid... | true | ||
unoplatform/uno | 23,339 | comment_to_fix | feat: Add x:Load compiler error diagnostics (WMC0907/WMC0913) | WMC0907/WMC0913 checks are currently only evaluated inside the deferred-load condition (`strategy == lazy || x:Load == false || markup`). If `x:Load` is present but doesn't match that condition (e.g. `x:Load="True"`), these diagnostics will be skipped for DataTemplate roots / ResourceDictionary direct children, while t... | b35817e841b1ea2464f60e03fa24abc5b10e04d1 | dc8aee22689d5de7a0b4b535fdf7c98eeabb6a17 | diff --git a/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs b/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
index 755eec57f403..cf4953b641a5 100644
--- a/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
+++ b/src/SourceGen... | [
"src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs"
] | [
{
"comment": "WMC0907/WMC0913 checks are currently only evaluated inside the deferred-load condition (`strategy == lazy || x:Load == false || markup`). If `x:Load` is present but doesn't match that condition (e.g. `x:Load=\"True\"`), these diagnostics will be skipped for DataTemplate roots / ResourceDictionary ... | true | ||
unoplatform/uno | 23,339 | comment_to_fix | feat: Add x:Load compiler error diagnostics (WMC0907/WMC0913) | Nit: excessive commenting? | b35817e841b1ea2464f60e03fa24abc5b10e04d1 | dc8aee22689d5de7a0b4b535fdf7c98eeabb6a17 | diff --git a/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs b/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
index 755eec57f403..cf4953b641a5 100644
--- a/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs
+++ b/src/SourceGen... | [
"src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs"
] | [
{
"comment": "Nit: excessive commenting?",
"path": "src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs",
"hunk": "@@ -6670,6 +6698,25 @@ private IEnumerable<XamlObjectDefinition> EnumerateSubElements(IEnumerable<XamlO\n \t\t\t\tvar nameMember = FindMember(definition, \"Name\... | true | ||
unoplatform/uno | 23,350 | issue_to_patch | [Feature Request] Uno.Sdk library build property to remove Uno dependencies from WinAppSdk target
### What would you like to be added? 💡
Some build property that can be put into Uno.Sdk library projects to produce a "pure" WinAppSdk lib without Uno dependencies:
<img width="530" height="167" alt="Image" src="https:... | feat(sdk): add DisableImplicitUnoWinAppSdkPackages property | ## Summary
Adds a new MSBuild property `DisableImplicitUnoWinAppSdkPackages` to `Uno.Sdk`. When set to `true` on a library, the SDK no longer implicitly adds the base Uno.* package references on the Windows App SDK (`net*-windows10*`) target framework:
- `Uno.WinUI` (which also bundles `Uno.UI.Toolkit.dll` inside its... | 6a6651b1bc1b0aaba89f74e7d6f93555fb9847c4 | b6bf904289c28668e8ff5916f360054c71dcbe34 | diff --git a/doc/articles/features/using-the-uno-sdk.md b/doc/articles/features/using-the-uno-sdk.md
index 643149107e60..4b42cb6f5628 100644
--- a/doc/articles/features/using-the-uno-sdk.md
+++ b/doc/articles/features/using-the-uno-sdk.md
@@ -190,6 +190,45 @@ to your `Directory.Build.props` file or `csproj` file. You w... | [
"doc/articles/features/using-the-uno-sdk.md",
"src/Uno.Sdk/Sdk/Sdk.props",
"src/Uno.Sdk/Sdk/Sdk.props.buildschema.json",
"src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets"
] | [
{
"comment": "The MSBuild condition only checks the property + windows10 TFM, but the property description/docs imply it’s meant for libraries. As implemented, setting this in a shared Directory.Build.props would also strip required Uno packages from Windows app heads, likely breaking builds/runs. Consider gati... | true | |
unoplatform/uno | 23,350 | comment_to_fix | feat(sdk): add DisableImplicitUnoWinAppSdkPackages property | The MSBuild condition only checks the property + windows10 TFM, but the property description/docs imply it’s meant for libraries. As implemented, setting this in a shared Directory.Build.props would also strip required Uno packages from Windows app heads, likely breaking builds/runs. Consider gating this removal to lib... | 6a6651b1bc1b0aaba89f74e7d6f93555fb9847c4 | b6bf904289c28668e8ff5916f360054c71dcbe34 | diff --git a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets
index 179eb3a2de1a..8bc3297e561c 100644
--- a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets
+++ b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targe... | [
"src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets"
] | [
{
"comment": "The MSBuild condition only checks the property + windows10 TFM, but the property description/docs imply it’s meant for libraries. As implemented, setting this in a shared Directory.Build.props would also strip required Uno packages from Windows app heads, likely breaking builds/runs. Consider gati... | true | ||
unoplatform/uno | 23,350 | comment_to_fix | feat(sdk): add DisableImplicitUnoWinAppSdkPackages property | The doc says a Windows-targeted assembly cannot be strong-named if it references `Uno.WinUI` because `Uno.WinUI` is not strong-named. Strong-named assemblies can reference non-strong-named assemblies in general, so this reads as a factual absolute that’s likely incorrect. Suggest rewording to the actual constraint you’... | 6a6651b1bc1b0aaba89f74e7d6f93555fb9847c4 | b6bf904289c28668e8ff5916f360054c71dcbe34 | diff --git a/doc/articles/features/using-the-uno-sdk.md b/doc/articles/features/using-the-uno-sdk.md
index 643149107e60..4b42cb6f5628 100644
--- a/doc/articles/features/using-the-uno-sdk.md
+++ b/doc/articles/features/using-the-uno-sdk.md
@@ -190,6 +190,45 @@ to your `Directory.Build.props` file or `csproj` file. You w... | [
"doc/articles/features/using-the-uno-sdk.md"
] | [
{
"comment": "The doc says a Windows-targeted assembly cannot be strong-named if it references `Uno.WinUI` because `Uno.WinUI` is not strong-named. Strong-named assemblies can reference non-strong-named assemblies in general, so this reads as a factual absolute that’s likely incorrect. Suggest rewording to the ... | true | ||
unoplatform/uno | 23,350 | comment_to_fix | feat(sdk): add DisableImplicitUnoWinAppSdkPackages property | In the “add it back explicitly” example, the condition uses `GetTargetPlatformIdentifier(...) == 'windows'`, but this section is specifically about Windows App SDK TFMs (`net*-windows10*`) and the property itself keys off `TargetFramework.Contains('windows10')`. Consider aligning the sample condition to the same window... | 6a6651b1bc1b0aaba89f74e7d6f93555fb9847c4 | b6bf904289c28668e8ff5916f360054c71dcbe34 | diff --git a/doc/articles/features/using-the-uno-sdk.md b/doc/articles/features/using-the-uno-sdk.md
index 643149107e60..4b42cb6f5628 100644
--- a/doc/articles/features/using-the-uno-sdk.md
+++ b/doc/articles/features/using-the-uno-sdk.md
@@ -190,6 +190,45 @@ to your `Directory.Build.props` file or `csproj` file. You w... | [
"doc/articles/features/using-the-uno-sdk.md"
] | [
{
"comment": "In the “add it back explicitly” example, the condition uses `GetTargetPlatformIdentifier(...) == 'windows'`, but this section is specifically about Windows App SDK TFMs (`net*-windows10*`) and the property itself keys off `TargetFramework.Contains('windows10')`. Consider aligning the sample condit... | true | ||
unoplatform/uno | 23,350 | comment_to_fix | feat(sdk): add DisableImplicitUnoWinAppSdkPackages property | Minor grammar in the new comment block: “opting into a UnoFeature” should be “an UnoFeature”.
| 6a6651b1bc1b0aaba89f74e7d6f93555fb9847c4 | b6bf904289c28668e8ff5916f360054c71dcbe34 | diff --git a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets
index 179eb3a2de1a..8bc3297e561c 100644
--- a/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets
+++ b/src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targe... | [
"src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets"
] | [
{
"comment": "Minor grammar in the new comment block: “opting into a UnoFeature” should be “an UnoFeature”.\n",
"path": "src/Uno.Sdk/targets/Uno.Implicit.Packages.ProjectSystem.targets",
"hunk": "@@ -122,6 +122,20 @@\n \t<Import Project=\"$(MSBuildThisFileDirectory)Uno.Implicit.Packages.ProjectSystem.Un... | true | ||
unoplatform/uno | 23,350 | comment_to_fix | feat(sdk): add DisableImplicitUnoWinAppSdkPackages property | The document already uses the official casing “WinAppSDK” in other sections; the new heading/text uses “WinAppSdk”. Consider aligning the casing for consistency within this doc (even if the MSBuild property name keeps its current casing). | 6a6651b1bc1b0aaba89f74e7d6f93555fb9847c4 | b6bf904289c28668e8ff5916f360054c71dcbe34 | diff --git a/doc/articles/features/using-the-uno-sdk.md b/doc/articles/features/using-the-uno-sdk.md
index 643149107e60..4b42cb6f5628 100644
--- a/doc/articles/features/using-the-uno-sdk.md
+++ b/doc/articles/features/using-the-uno-sdk.md
@@ -190,6 +190,45 @@ to your `Directory.Build.props` file or `csproj` file. You w... | [
"doc/articles/features/using-the-uno-sdk.md"
] | [
{
"comment": "The document already uses the official casing “WinAppSDK” in other sections; the new heading/text uses “WinAppSdk”. Consider aligning the casing for consistency within this doc (even if the MSBuild property name keeps its current casing).",
"path": "doc/articles/features/using-the-uno-sdk.md",... | true | ||
unoplatform/uno | 23,377 | issue_to_patch | chore(deps): bump actions/checkout from 4 to 6 | Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/actions/checkout/releases">actions/checkout's releases</a>.</em></p>
<blockquote>
<h2>v6.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Update README to includ... | 4357cb7149a935e0ab82e9aefb2d27deafd0359a | 0763df8a86fbd7079a0c1f2b5bd95be5d8fec279 | diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml
index dbbe33806d73..429591c1e343 100644
--- a/.github/workflows/claude-code-review.yml
+++ b/.github/workflows/claude-code-review.yml
@@ -51,7 +51,7 @@ jobs:
timeout-minutes: 20
steps:
- name: Checkout repo... | [
".github/workflows/claude-code-review.yml",
".github/workflows/codeql.yml",
".github/workflows/docs-updater.yml",
".github/workflows/link-validation.yml",
".github/workflows/scorecard.yml",
".github/workflows/winappsdk-sync-apply.yml",
".github/workflows/winappsdk-sync-check.yml",
".github/workflows/x... | [] | true | ||
unoplatform/uno | 23,374 | issue_to_patch | ci: Add claude code reviews | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 2ed1829bc60da8f8f623e7695c96213c0145124c | diff --git a/.github/dependabot.yml b/.github/dependabot.yml
index a0de80d5baef..b5a134509e08 100644
--- a/.github/dependabot.yml
+++ b/.github/dependabot.yml
@@ -1,5 +1,16 @@
version: 2
updates:
+- package-ecosystem: github-actions
+ directory: "/"
+ schedule:
+ interval: weekly
+ time: "01:00"
+ open-pull-... | [
".github/dependabot.yml",
".github/workflows/claude-code-review.yml",
"REVIEW.md"
] | [
{
"comment": "This workflow loads REVIEW.md from the base branch (`ref=${{ github.base_ref }}`), but REVIEW.md is introduced by this PR. Until this PR is merged, that `gh api .../contents/REVIEW.md` call will 404 and fail the job, effectively preventing the workflow from running on its own PR.",
"path": ".g... | true | |||
unoplatform/uno | 23,374 | comment_to_fix | ci: Add claude code reviews | This workflow loads REVIEW.md from the base branch (`ref=${{ github.base_ref }}`), but REVIEW.md is introduced by this PR. Until this PR is merged, that `gh api .../contents/REVIEW.md` call will 404 and fail the job, effectively preventing the workflow from running on its own PR. | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 2ed1829bc60da8f8f623e7695c96213c0145124c | diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml
new file mode 100644
index 000000000000..dbbe33806d73
--- /dev/null
+++ b/.github/workflows/claude-code-review.yml
@@ -0,0 +1,93 @@
+# This workflow runs an AI agent over pull requests. PR titles, descriptions,
+# and diffs... | [
".github/workflows/claude-code-review.yml"
] | [
{
"comment": "This workflow loads REVIEW.md from the base branch (`ref=${{ github.base_ref }}`), but REVIEW.md is introduced by this PR. Until this PR is merged, that `gh api .../contents/REVIEW.md` call will 404 and fail the job, effectively preventing the workflow from running on its own PR.",
"path": ".g... | true | ||
unoplatform/uno | 23,374 | comment_to_fix | ci: Add claude code reviews | The header comment claims the tool allowlist prevents the agent from reaching the network, but the allowed Bash tools include `gh pr diff` / `gh pr view`, which call the GitHub API over the network. This is a documentation inconsistency that could mislead future changes to the security posture; consider clarifying that... | fe3e504075afddfe6fd763ac9ac0bfe28399c415 | 2ed1829bc60da8f8f623e7695c96213c0145124c | diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml
new file mode 100644
index 000000000000..dbbe33806d73
--- /dev/null
+++ b/.github/workflows/claude-code-review.yml
@@ -0,0 +1,93 @@
+# This workflow runs an AI agent over pull requests. PR titles, descriptions,
+# and diffs... | [
".github/workflows/claude-code-review.yml"
] | [
{
"comment": "The header comment claims the tool allowlist prevents the agent from reaching the network, but the allowed Bash tools include `gh pr diff` / `gh pr view`, which call the GitHub API over the network. This is a documentation inconsistency that could mislead future changes to the security posture; co... | true | ||
unoplatform/uno | 23,140 | issue_to_patch | [WASM] OnContentDrop fires on background thread.
### Current behavior 🐛
As indicated, the `OnContentDrop` event fires on background threads, causing exceptions if you do anything that requires you to be on the UI thread.
### Expected behavior 🎯
Should fire on the UI thread.
### How to reproduce it (as minimally ... | fix: [WASM] OnContentDrop fires on background thread | closes #23227
In WASM with threading enabled, `[JSExport]` methods can be invoked on a background thread. `BrowserDragDropExtension.OnNativeDropEvent` was processing all drag-drop events—including `drop`—without pinning to the UI thread, causing exceptions in any UI-thread-only code inside drop handlers.
## Changes
... | 0171c2c7aff39ba0f757ca26814e0be7fa336855 | 72f4fa9a9ce15943a5c0cdafc54608b4ab175084 | diff --git a/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs b/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs
index 58af71935d5f..91eabef8036a 100644
--- a/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs
+++ b/src/... | [
"src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs",
"src/Uno.UWP/UI/Core/SystemNavigationManager.wasm.cs"
] | [
{
"comment": "Let's not do that, we can enqueue the events on the native dispatcher directly",
"path": "src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs",
"hunk": "@@ -68,6 +69,10 @@ public static string OnNativeDropEvent(\n \t\t{\n \t\t\ttry\n \t\t\t{\n+\t\t\t\t// Ensu... | true | |
unoplatform/uno | 23,140 | comment_to_fix | fix: [WASM] OnContentDrop fires on background thread | Let's not do that, we can enqueue the events on the native dispatcher directly | 0171c2c7aff39ba0f757ca26814e0be7fa336855 | 72f4fa9a9ce15943a5c0cdafc54608b4ab175084 | diff --git a/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs b/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs
index 58af71935d5f..91eabef8036a 100644
--- a/src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs
+++ b/src/... | [
"src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs"
] | [
{
"comment": "Let's not do that, we can enqueue the events on the native dispatcher directly",
"path": "src/Uno.UI.Runtime.Skia.WebAssembly.Browser/Extensions/BrowserDragDropExtension.cs",
"hunk": "@@ -68,6 +69,10 @@ public static string OnNativeDropEvent(\n \t\t{\n \t\t\ttry\n \t\t\t{\n+\t\t\t\t// Ensu... | true | ||
unoplatform/uno | 23,367 | issue_to_patch | UniformGridLayout throws DivideByZeroException when ItemsRepeater is measured with an available width smaller than MinItemWidth
### What happened?
An `ItemsRepeater` using a `UniformGridLayout` with `MinItemWidth` set crashes with an unhandled `System.DivideByZeroException` during a measure pass where the available w... | fix(repeater): prevent UniformGridLayout divide-by-zero | **GitHub Issue:** closes #23366
## PR Type:
🐞 Bugfix
## What changed? 🚀
An `ItemsRepeater` using a `UniformGridLayout` with `MinItemWidth` (or `MinItemHeight`) set crashed with an unhandled `System.DivideByZeroException` whenever it was measured with a finite minor-axis available size that was smaller than a sing... | 86886ec134ec598033463eb2cc851b3bca5b8d6a | 9ce43a6b66247aca6b4277d47fb214e6e5b4ae4f | diff --git a/src/Uno.UI/UI/Xaml/Controls/Repeater/UniformGridLayout/UniformGridLayout.cs b/src/Uno.UI/UI/Xaml/Controls/Repeater/UniformGridLayout/UniformGridLayout.cs
index fda5d3f0bf3c..780479710dfa 100644
--- a/src/Uno.UI/UI/Xaml/Controls/Repeater/UniformGridLayout/UniformGridLayout.cs
+++ b/src/Uno.UI/UI/Xaml/Contro... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/UniformGridLayout/Given_UniformGridLayout.cs",
"src/Uno.UI/UI/Xaml/Controls/Repeater/UniformGridLayout/UniformGridLayout.cs"
] | [] | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/UniformGridLayout/Given_UniformGridLayout.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/UniformGridLayout/Given_UniformGridLayout.cs
index 7f59b9bda33e..4b094cfb08e4 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_... | true |
unoplatform/uno | 23,164 | issue_to_patch | feat: FeatureConfiguration.Font.FallbackService | **GitHub Issue:** closes https://github.com/unoplatform/kahua-private/issues/431
<!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal), unless the change is documentation related. -->
## PR Type:
<!--
Copy the label that applies to this PR and ... | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/doc/articles/features/custom-fonts.md b/doc/articles/features/custom-fonts.md
index c53f02c58f79..49461283dd56 100644
--- a/doc/articles/features/custom-fonts.md
+++ b/doc/articles/features/custom-fonts.md
@@ -257,3 +257,96 @@ Second, you can use it in XAML in this way:
> [!NOTE]
> This approach is nic... | [
"doc/articles/features/custom-fonts.md",
"src/FontFallbackPreprocessor/Program.cs",
"src/Uno.UI.Runtime.Skia.Android/UI/Xaml/Controls/TextBox/AndroidSkiaFontFallbackService.cs",
"src/Uno.UI/FeatureConfiguration.cs",
"src/Uno.UI/UI/Xaml/Documents/CoverageTableFontFallbackService.cs",
"src/Uno.UI/UI/Xaml/Do... | [
{
"comment": "`_fontFallbackService` is initialized once at type initialization time, so changing `FeatureConfiguration.Font.FallbackService` later won't have any effect. If the intent is that apps can override this at runtime (or after startup), consider resolving the service on-demand (e.g., via a property th... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | `_fontFallbackService` is initialized once at type initialization time, so changing `FeatureConfiguration.Font.FallbackService` later won't have any effect. If the intent is that apps can override this at runtime (or after startup), consider resolving the service on-demand (e.g., via a property that checks `FeatureConf... | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/src/Uno.UI/UI/Xaml/Documents/TextFormatting/FontDetailsCache.skia.cs b/src/Uno.UI/UI/Xaml/Documents/TextFormatting/FontDetailsCache.skia.cs
index 55729400cac5..9feec7b2f1d9 100644
--- a/src/Uno.UI/UI/Xaml/Documents/TextFormatting/FontDetailsCache.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Documents/TextFormatting/Fo... | [
"src/Uno.UI/UI/Xaml/Documents/TextFormatting/FontDetailsCache.skia.cs"
] | [
{
"comment": "`_fontFallbackService` is initialized once at type initialization time, so changing `FeatureConfiguration.Font.FallbackService` later won't have any effect. If the intent is that apps can override this at runtime (or after startup), consider resolving the service on-demand (e.g., via a property th... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | Changing `FallbackFontMaps` from `public` to `internal` is a breaking API change for any external consumers that might be using this generated map. If this is intentional, it should be called out explicitly (and ideally replaced with a supported public surface if customers are expected to customize fallback coverage).
... | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs b/src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs
index 5fa9ca8251cd..d3f314ec51ee 100644
--- a/src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs
@@ -2,7 +2,7 @@
namespace Microsof... | [
"src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs"
] | [
{
"comment": "Changing `FallbackFontMaps` from `public` to `internal` is a breaking API change for any external consumers that might be using this generated map. If this is intentional, it should be called out explicitly (and ideally replaced with a supported public surface if customers are expected to customiz... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | The XML docs reference `CoverageTableFontFallbackService`, but that type doesn't exist in the repo (only references are found). This will produce broken doc links (and can trigger CS1574 warnings depending on build settings). Either add the type or update the docs to point to the correct supported implementation.
```su... | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/src/Uno.UI/UI/Xaml/Documents/IFontFallbackService.cs b/src/Uno.UI/UI/Xaml/Documents/IFontFallbackService.cs
new file mode 100644
index 000000000000..d4312a5d9831
--- /dev/null
+++ b/src/Uno.UI/UI/Xaml/Documents/IFontFallbackService.cs
@@ -0,0 +1,31 @@
+#nullable enable
+using System.IO;
+using System.Threa... | [
"src/Uno.UI/UI/Xaml/Documents/IFontFallbackService.cs"
] | [
{
"comment": "The XML docs reference `CoverageTableFontFallbackService`, but that type doesn't exist in the repo (only references are found). This will produce broken doc links (and can trigger CS1574 warnings depending on build settings). Either add the type or update the docs to point to the correct supported... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | `FeatureConfiguration.Font.FallbackService` references `Microsoft.UI.Xaml.Documents.TextFormatting.IFontFallbackService`, but that type is defined in a `*.skia.cs` file and is removed from non-Skia builds (see `Uno.CrossTargetting.targets`). As-is, this will break compilation for non-Skia targets that still compile `Fe... | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/src/Uno.UI/FeatureConfiguration.cs b/src/Uno.UI/FeatureConfiguration.cs
index 26dc4f85a903..e0879a1b6d28 100644
--- a/src/Uno.UI/FeatureConfiguration.cs
+++ b/src/Uno.UI/FeatureConfiguration.cs
@@ -230,6 +230,20 @@ public static string SymbolsFont
/// </summary>
public static float? MaximumTextScal... | [
"src/Uno.UI/FeatureConfiguration.cs"
] | [
{
"comment": "`FeatureConfiguration.Font.FallbackService` references `Microsoft.UI.Xaml.Documents.TextFormatting.IFontFallbackService`, but that type is defined in a `*.skia.cs` file and is removed from non-Skia builds (see `Uno.CrossTargetting.targets`). As-is, this will break compilation for non-Skia targets ... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | This code references `FontFallbackCoverageRange` and `CoverageTableFontFallbackService`, but those types don't exist anywhere in the repository (searching `src/**/*.cs` only finds these usages). This will not compile until those types are added (or the code is adjusted to use the existing fallback implementation). | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/src/Uno.UI/UI/Xaml/Documents/FontFallbackService.skia.cs b/src/Uno.UI/UI/Xaml/Documents/FontFallbackService.skia.cs
index a1438b7a1683..def4f2e3e7b5 100644
--- a/src/Uno.UI/UI/Xaml/Documents/FontFallbackService.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Documents/FontFallbackService.skia.cs
@@ -33,222 +33,65 @@
usi... | [
"src/Uno.UI/UI/Xaml/Documents/FontFallbackService.skia.cs"
] | [
{
"comment": "This code references `FontFallbackCoverageRange` and `CoverageTableFontFallbackService`, but those types don't exist anywhere in the repository (searching `src/**/*.cs` only finds these usages). This will not compile until those types are added (or the code is adjusted to use the existing fallback... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | `GetFontStreamForFontFamily` can throw (e.g., `File.OpenRead` if the file is missing/unreadable). Since `FontDetailsCache.GetFontInternal` doesn’t currently catch exceptions around stream retrieval, this can break font resolution. Consider handling IO exceptions here (return `null` and optionally log) to keep fallback ... | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/src/Uno.UI.Runtime.Skia.Android/UI/Xaml/Controls/TextBox/AndroidSkiaFontFallbackService.cs b/src/Uno.UI.Runtime.Skia.Android/UI/Xaml/Controls/TextBox/AndroidSkiaFontFallbackService.cs
index 5d6bf531d96a..37be15c39e60 100644
--- a/src/Uno.UI.Runtime.Skia.Android/UI/Xaml/Controls/TextBox/AndroidSkiaFontFallb... | [
"src/Uno.UI.Runtime.Skia.Android/UI/Xaml/Controls/TextBox/AndroidSkiaFontFallbackService.cs"
] | [
{
"comment": "`GetFontStreamForFontFamily` can throw (e.g., `File.OpenRead` if the file is missing/unreadable). Since `FontDetailsCache.GetFontInternal` doesn’t currently catch exceptions around stream retrieval, this can break font resolution. Consider handling IO exceptions here (return `null` and optionally ... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | The remarks suggest customers can “copy the data shipped with the default service” to keep the same coverage, but this PR also makes the generated `FallbackFontMaps` internal. Without a public way to access the default coverage table, this guidance is hard to follow without copying source. Consider either exposing the ... | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/src/Uno.UI/UI/Xaml/Documents/CoverageTableFontFallbackService.cs b/src/Uno.UI/UI/Xaml/Documents/CoverageTableFontFallbackService.cs
new file mode 100644
index 000000000000..e395ca1d4a5e
--- /dev/null
+++ b/src/Uno.UI/UI/Xaml/Documents/CoverageTableFontFallbackService.cs
@@ -0,0 +1,304 @@
+#nullable enable
... | [
"src/Uno.UI/UI/Xaml/Documents/CoverageTableFontFallbackService.cs"
] | [
{
"comment": "The remarks suggest customers can “copy the data shipped with the default service” to keep the same coverage, but this PR also makes the generated `FallbackFontMaps` internal. Without a public way to access the default coverage table, this guidance is hard to follow without copying source. Conside... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | The interface docs say `GetFontFamilyForCodepoint` returns a “family name”, but the contract really only requires an identifier that will be passed back to `GetFontStreamForFontFamily` (and implementations may return non-family identifiers like variant keys or file names). Consider updating the XML docs (and possibly p... | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/src/Uno.UI/UI/Xaml/Documents/IFontFallbackService.cs b/src/Uno.UI/UI/Xaml/Documents/IFontFallbackService.cs
new file mode 100644
index 000000000000..d4312a5d9831
--- /dev/null
+++ b/src/Uno.UI/UI/Xaml/Documents/IFontFallbackService.cs
@@ -0,0 +1,31 @@
+#nullable enable
+using System.IO;
+using System.Threa... | [
"src/Uno.UI/UI/Xaml/Documents/IFontFallbackService.cs"
] | [
{
"comment": "The interface docs say `GetFontFamilyForCodepoint` returns a “family name”, but the contract really only requires an identifier that will be passed back to `GetFontStreamForFontFamily` (and implementations may return non-family identifiers like variant keys or file names). Consider updating the XM... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | More than a `FeatureConfiguration` flag this type of features looks more like an App Configuration, something to add the same way we enable Logs and other App capabilities. | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/doc/articles/features/custom-fonts.md b/doc/articles/features/custom-fonts.md
index c53f02c58f79..49461283dd56 100644
--- a/doc/articles/features/custom-fonts.md
+++ b/doc/articles/features/custom-fonts.md
@@ -257,3 +257,96 @@ Second, you can use it in XAML in this way:
> [!NOTE]
> This approach is nic... | [
"doc/articles/features/custom-fonts.md"
] | [
{
"comment": "More than a `FeatureConfiguration` flag this type of features looks more like an App Configuration, something to add the same way we enable Logs and other App capabilities.",
"path": "doc/articles/features/custom-fonts.md",
"hunk": "@@ -257,3 +257,97 @@ Second, you can use it in XAML in t... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | remember to update PackageDiffIgnore.xml | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs b/src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs
index 5fa9ca8251cd..d3f314ec51ee 100644
--- a/src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs
@@ -2,7 +2,7 @@
namespace Microsof... | [
"src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs"
] | [
{
"comment": "remember to update PackageDiffIgnore.xml",
"path": "src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs",
"hunk": "",
"resolving_sha": "e781a50b8cbafc448df8d0c313c0e4831347dbb7",
"resolving_diff": "diff --git a/src/Uno.UI/UI/Xaml/Documents/FontFallbackMaps.skia.cs b/src/Uno.UI/UI... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | The stream returned by GetFontStreamForFontFamily is not disposed after creating the SKTypeface. This leaks file/network handles (e.g., Android returns File.OpenRead). Dispose the stream after SKTypeface.FromStream (consistent with LoadTypefaceFromApplicationUriAsync) or otherwise ensure ownership is clearly handled.
`... | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/src/Uno.UI/UI/Xaml/Documents/TextFormatting/FontDetailsCache.skia.cs b/src/Uno.UI/UI/Xaml/Documents/TextFormatting/FontDetailsCache.skia.cs
index 55729400cac5..9feec7b2f1d9 100644
--- a/src/Uno.UI/UI/Xaml/Documents/TextFormatting/FontDetailsCache.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Documents/TextFormatting/Fo... | [
"src/Uno.UI/UI/Xaml/Documents/TextFormatting/FontDetailsCache.skia.cs"
] | [
{
"comment": "The stream returned by GetFontStreamForFontFamily is not disposed after creating the SKTypeface. This leaks file/network handles (e.g., Android returns File.OpenRead). Dispose the stream after SKTypeface.FromStream (consistent with LoadTypefaceFromApplicationUriAsync) or otherwise ensure ownership... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | GetFontFamilyForCodepoint is invoked outside the try/catch, so an implementation that throws synchronously (before returning a Task) will bypass the exception handling. Wrap the call itself in the try/catch (or move it inside) so both synchronous and async failures are handled consistently. | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/src/Uno.UI/UI/Xaml/Documents/TextFormatting/FontDetailsCache.skia.cs b/src/Uno.UI/UI/Xaml/Documents/TextFormatting/FontDetailsCache.skia.cs
index 55729400cac5..9feec7b2f1d9 100644
--- a/src/Uno.UI/UI/Xaml/Documents/TextFormatting/FontDetailsCache.skia.cs
+++ b/src/Uno.UI/UI/Xaml/Documents/TextFormatting/Fo... | [
"src/Uno.UI/UI/Xaml/Documents/TextFormatting/FontDetailsCache.skia.cs"
] | [
{
"comment": "GetFontFamilyForCodepoint is invoked outside the try/catch, so an implementation that throws synchronously (before returning a Task) will bypass the exception handling. Wrap the call itself in the try/catch (or move it inside) so both synchronous and async failures are handled consistently.",
... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | Spelling: "font fall back" should be "font fallback" (consistent with the rest of the section).
```suggestion
To opt out of font fallback entirely, assign the empty service:
``` | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/doc/articles/features/custom-fonts.md b/doc/articles/features/custom-fonts.md
index c53f02c58f79..49461283dd56 100644
--- a/doc/articles/features/custom-fonts.md
+++ b/doc/articles/features/custom-fonts.md
@@ -257,3 +257,96 @@ Second, you can use it in XAML in this way:
> [!NOTE]
> This approach is nic... | [
"doc/articles/features/custom-fonts.md"
] | [
{
"comment": "Spelling: \"font fall back\" should be \"font fallback\" (consistent with the rest of the section).\n```suggestion\nTo opt out of font fallback entirely, assign the empty service:\n```",
"path": "doc/articles/features/custom-fonts.md",
"hunk": "@@ -257,3 +257,96 @@ Second, you can use it i... | true | ||
unoplatform/uno | 23,164 | comment_to_fix | feat: FeatureConfiguration.Font.FallbackService | New behavior is introduced via FeatureConfiguration.Font.FallbackService (override/opt-out). There are existing Skia font-fallback runtime tests, but none covering the configuration override path (e.g., custom service is used, and EmptyFontFallbackService disables fallback). Adding a runtime test would help prevent reg... | d829926cc0cbee8342aace7eb4751ab08518dfed | e781a50b8cbafc448df8d0c313c0e4831347dbb7 | diff --git a/src/Uno.UI/FeatureConfiguration.cs b/src/Uno.UI/FeatureConfiguration.cs
index 26dc4f85a903..e0879a1b6d28 100644
--- a/src/Uno.UI/FeatureConfiguration.cs
+++ b/src/Uno.UI/FeatureConfiguration.cs
@@ -230,6 +230,20 @@ public static string SymbolsFont
/// </summary>
public static float? MaximumTextScal... | [
"src/Uno.UI/FeatureConfiguration.cs"
] | [
{
"comment": "New behavior is introduced via FeatureConfiguration.Font.FallbackService (override/opt-out). There are existing Skia font-fallback runtime tests, but none covering the configuration override path (e.g., custom service is used, and EmptyFontFallbackService disables fallback). Adding a runtime test ... | true | ||
unoplatform/uno | 23,365 | issue_to_patch | feat: FeatureConfiguration.Font.FallbackService (backport #23164) | **GitHub Issue:** closes https://github.com/unoplatform/kahua-private/issues/431
## PR Type:
## What changed? 🚀
## PR Checklist ✅
- [ ] 🧪 Added [Runtime tests, UI tests, or a manual test sample](https://github.com/unoplatform/uno/blob/master/doc/articles/uno-development/working-with-the-samples-apps.md) (f... | bb81e9e014141d3830e3454075c4b5e6a0d3ebbb | 8b1fd9178d5acc50f1a336bb101a0d1007a6368b | diff --git a/doc/articles/features/custom-fonts.md b/doc/articles/features/custom-fonts.md
index c53f02c58f79..49461283dd56 100644
--- a/doc/articles/features/custom-fonts.md
+++ b/doc/articles/features/custom-fonts.md
@@ -257,3 +257,96 @@ Second, you can use it in XAML in this way:
> [!NOTE]
> This approach is nic... | [
"doc/articles/features/custom-fonts.md",
"src/FontFallbackPreprocessor/Program.cs",
"src/Uno.UI.Runtime.Skia.Android/UI/Xaml/Controls/TextBox/AndroidSkiaFontFallbackService.cs",
"src/Uno.UI/FeatureConfiguration.cs",
"src/Uno.UI/UI/Xaml/Documents/CoverageTableFontFallbackService.cs",
"src/Uno.UI/UI/Xaml/Do... | [] | true | ||
unoplatform/uno | 23,364 | issue_to_patch | fix: cancel parent direct manipulations after press bubble completes (backport #23135) | **GitHub Issue:** closes https://github.com/unoplatform/kahua-private/issues/434
## PR Type:
## What is the current behavior? 🤔
## What is the new behavior? 🚀
## PR Checklist ✅
Please check if your PR fulfills the following requirements:
- [ ] 📝 Commits must be following the [Conventional Commits](ht... | 148e464dfb68ebd6f8a61bdf6d08afa192f10be4 | eef604b7f56d7c45205a12069cb1a1893cd7c2b1 | diff --git a/src/Uno.UI/UI/Xaml/Internal/InputManager.Pointers.ManagedDirectManip.cs b/src/Uno.UI/UI/Xaml/Internal/InputManager.Pointers.ManagedDirectManip.cs
index f434347ed03b..514e2a0ce09a 100644
--- a/src/Uno.UI/UI/Xaml/Internal/InputManager.Pointers.ManagedDirectManip.cs
+++ b/src/Uno.UI/UI/Xaml/Internal/InputMana... | [
"src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_UIElement.Manipulations.cs",
"src/Uno.UI/UI/Xaml/Internal/InputManager.Pointers.ManagedDirectManip.cs",
"src/Uno.UI/UI/Xaml/UIElement.Pointers.cs"
] | [] | diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_UIElement.Manipulations.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_UIElement.Manipulations.cs
index fdc263af8e0f..a0841ea61f6b 100644
--- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml/Given_UIElement.Manipulations.cs
+++ b/src/Uno.UI.Runti... | true | |
unslothai/unsloth | 6,310 | issue_to_patch | Studio: don't silently fall back to a CPU prebuilt on NVIDIA Linux GPU hosts | This PR is a preparation for merging https://github.com/unslothai/llama.cpp/pull/23.
Currently, on a Linux device with a usable NVIDIA GPU, if no CUDA prebuilt covers the GPU, a source compilation is triggered. After unslothai/llama.cpp#23 is merged and runs, the manifest will also include CPU builds, and `_linux_pu... | 8febe2ca8f3797094f9742882cb96a7f67ddde4c | b1eb1d9a9be8e9bf6dde604a6354995494494824 | diff --git a/studio/install_llama_prebuilt.py b/studio/install_llama_prebuilt.py
index aab6d641fe..b33d0b6325 100644
--- a/studio/install_llama_prebuilt.py
+++ b/studio/install_llama_prebuilt.py
@@ -5932,9 +5932,9 @@ def resolve_install_attempts(
def _linux_published_attempts(host: HostInfo, bundle: PublishedRelease... | [
"studio/install_llama_prebuilt.py",
"tests/studio/install/test_selection_logic.py"
] | [] | diff --git a/tests/studio/install/test_selection_logic.py b/tests/studio/install/test_selection_logic.py
index 4e8beeb888..0282370fe0 100644
--- a/tests/studio/install/test_selection_logic.py
+++ b/tests/studio/install/test_selection_logic.py
@@ -2611,6 +2611,59 @@ def test_cpu_host_still_gets_cpu_bundle(self, monkeypa... | true | |
unslothai/unsloth | 6,301 | issue_to_patch | Bump install.sh / install.ps1 pin to unsloth>=2026.6.7 | ## Summary
- PyPI release [unsloth 2026.6.7](https://pypi.org/project/unsloth/2026.6.7/) is now live.
- Bumps the pinned `unsloth` floor in `install.sh` and `install.ps1` from `unsloth>=2026.6.6` to `unsloth>=2026.6.7` so fresh installs resolve to the new wheel.
- Updates all 5 install commands in each of `install.sh`... | b32ef2ef865eb89ce5e9075e84e5e35832c91a5f | ba998f9cb12543ca91f4c01a552f73888b70d370 | diff --git a/install.ps1 b/install.ps1
index 88939ce627..dccd8e4fc1 100644
--- a/install.ps1
+++ b/install.ps1
@@ -1923,7 +1923,7 @@ shell.Run cmd, 0, False
if ($SkipTorch) {
# No-torch: install unsloth + unsloth-zoo with --no-deps, then
# runtime deps (typer, safetensors, transformer... | [
"install.ps1",
"install.sh"
] | [] | true | ||
unslothai/unsloth | 6,299 | issue_to_patch | Studio: decide diffusion routing before the SWA resolver | ## Problem
Loading a DiffusionGemma GGUF in Studio could fail with `llama-server failed to start. Check that the GGUF file is valid`, even though `llama-diffusion-cli` runs the same model fine.
`_read_gguf_metadata` assigned `self._is_diffusion` after calling `_resolve_swa_pattern`, both inside one `try/except`. The r... | bd9324b634356ecc281297c91dc9cc71f13fd558 | 21904e029dbfee0aff1055c871abbc5ade9bc934 | diff --git a/studio/backend/core/inference/llama_cpp.py b/studio/backend/core/inference/llama_cpp.py
index 16f6376aab..57cc97f3b5 100644
--- a/studio/backend/core/inference/llama_cpp.py
+++ b/studio/backend/core/inference/llama_cpp.py
@@ -2380,6 +2380,17 @@ def _read_gguf_metadata(self, gguf_path: str) -> None:
... | [
"studio/backend/core/inference/llama_cpp.py"
] | [] | true | ||
unslothai/unsloth | 6,278 | issue_to_patch | Studio: force-refresh the llama.cpp update check so new builds are not masked by the 24h cache | ## Problem
The "New llama.cpp version" banner often never appears even when a newer prebuilt has been published.
The banner is driven by `useLlamaUpdateCheck`, which polls `GET /api/llama/update-status`. On the backend, the latest GitHub release tag is memoized for 24 hours, in memory and on disk, so the value surviv... | 2b76c6855a023d1bdd492c75193f83f66fe47562 | f87e3d57586add7dc96f0a84e4a2072b9fb867fb | diff --git a/studio/frontend/src/hooks/use-llama-update-check.ts b/studio/frontend/src/hooks/use-llama-update-check.ts
index 9532ee0735..73e12f9bff 100644
--- a/studio/frontend/src/hooks/use-llama-update-check.ts
+++ b/studio/frontend/src/hooks/use-llama-update-check.ts
@@ -68,6 +68,11 @@ async function fetchStatus(
... | [
"studio/frontend/src/hooks/use-llama-update-check.ts"
] | [] | true | ||
unslothai/unsloth | 6,289 | issue_to_patch | Studio: resolve studio home before the llama-only setup split | ## Summary
`UNSLOTH_STUDIO_LLAMA_ONLY=1` is the llama.cpp-only fast path in `studio/setup.sh`, i.e. the llama.cpp step that `unsloth studio update` runs. It skips the base-install block, but that block is also where the studio-home resolution lives:
- `STUDIO_HOME`
- `_STUDIO_HOME_IS_CUSTOM`
- `_STUDIO_OWNED_MARKER`
... | 502d4ade1cc2211c2febbc4f29f1628cff18e2e0 | 324033fc42511623f063dba21cb0ebf349821482 | diff --git a/studio/setup.sh b/studio/setup.sh
index 613d311708..4fba761cef 100755
--- a/studio/setup.sh
+++ b/studio/setup.sh
@@ -386,6 +386,70 @@ if [[ "$keynames" == *$'\nCOLAB_'* ]]; then
IS_COLAB=true
fi
+# Resolve studio home + ownership marker before the llama-only split: the
+# llama.cpp section needs S... | [
"studio/setup.sh"
] | [] | true | ||
unslothai/unsloth | 6,280 | issue_to_patch | Studio: offer llama.cpp update for same-base mix builds on source installs | ## Problem
The "New llama.cpp version" banner never appeared for some users even when a newer Unsloth llama.cpp binary was published. This was reproducible on macOS in particular.
The banner is driven entirely by `update_available` from `GET /api/llama/update-status`. Two backend paths compute that flag and they disa... | 2b76c6855a023d1bdd492c75193f83f66fe47562 | 88d2f04e7b89cd9ff26b2ad7643ddcf76f53a8c8 | diff --git a/studio/backend/utils/llama_cpp_update.py b/studio/backend/utils/llama_cpp_update.py
index 8b90d36bc5..3518247d7e 100644
--- a/studio/backend/utils/llama_cpp_update.py
+++ b/studio/backend/utils/llama_cpp_update.py
@@ -37,6 +37,7 @@
_INSTALL_MARKER_NAME,
check_prebuilt_freshness,
latest_publi... | [
"studio/backend/tests/test_llama_cpp_update.py",
"studio/backend/utils/llama_cpp_update.py"
] | [] | diff --git a/studio/backend/tests/test_llama_cpp_update.py b/studio/backend/tests/test_llama_cpp_update.py
index e207306c91..326b3dc6aa 100644
--- a/studio/backend/tests/test_llama_cpp_update.py
+++ b/studio/backend/tests/test_llama_cpp_update.py
@@ -233,6 +233,39 @@ def test_status_source_build_suppressed_when_newer(m... | true | |
unslothai/unsloth | 6,293 | issue_to_patch | Studio: fix training output dir escaping outputs root for models on another drive | ## Summary
Starting a LoRA/QLoRA run in Studio from a model that is loaded by an absolute local path fails before training begins with:
```
path escapes root: G:\modelsAI\gguf\test\gemma-4-12B-it_1781327234
-> G:\modelsAI\gguf\test\gemma-4-12B-it_1781327234
is not under C:\Users\<user>\.unsloth\studio\outputs
```
Th... | 985792a83b7f1fdfc2bd661f8754d4f018b3dce8 | 7e872e43d72535e73a90f4eec3f8557393af989c | diff --git a/studio/backend/core/training/worker.py b/studio/backend/core/training/worker.py
index 1120744a2d..4a6d182da8 100644
--- a/studio/backend/core/training/worker.py
+++ b/studio/backend/core/training/worker.py
@@ -1687,12 +1687,12 @@ def _fmt_progress(status_message = "", **_kw):
warmup_steps = 5
... | [
"studio/backend/core/training/worker.py",
"studio/backend/tests/test_default_output_dir_name.py",
"studio/backend/utils/paths/__init__.py",
"studio/backend/utils/paths/storage_roots.py"
] | [
{
"comment": "\n\nTo prevent potential filesystem errors such as `OSError: [Errno 36] File name too long` when dealing with extremely long model names or local paths, it is highly recommended to defensively truncate the generated directory na... | diff --git a/studio/backend/tests/test_default_output_dir_name.py b/studio/backend/tests/test_default_output_dir_name.py
new file mode 100644
index 0000000000..d8a7f5ae21
--- /dev/null
+++ b/studio/backend/tests/test_default_output_dir_name.py
@@ -0,0 +1,65 @@
+# SPDX-License-Identifier: AGPL-3.0-only
+# Copyright 2026... | true | |
unslothai/unsloth | 6,288 | issue_to_patch | Studio: UI polish for sidebar, menus, hub and toasts | ## Summary
A round of UI polish for Unsloth Studio. Everything here is scoped to the studio frontend.
## Changes
### Chat sidebar
- Add a Pinned section above Recents. Chats can be pinned or unpinned from the row menu, and each pinned row shows an unpin button on hover.
- Align the Recents and Pinned section labels ... | 8e57c5ee3448be913c447702dec3dc2722638d01 | f81a8cb3173a73fd856354375a860e87735f7136 | diff --git a/studio/frontend/src/components/app-sidebar.tsx b/studio/frontend/src/components/app-sidebar.tsx
index 23fe5e188b..d3ba923e69 100644
--- a/studio/frontend/src/components/app-sidebar.tsx
+++ b/studio/frontend/src/components/app-sidebar.tsx
@@ -45,8 +45,7 @@ import { Switch } from "@/components/ui/switch";
i... | [
"studio/frontend/src/components/app-sidebar.tsx",
"studio/frontend/src/components/assistant-ui/model-selector.tsx",
"studio/frontend/src/components/assistant-ui/thread.tsx",
"studio/frontend/src/components/ui/alert-dialog.tsx",
"studio/frontend/src/components/ui/dialog.tsx",
"studio/frontend/src/component... | [
{
"comment": "**<sub><sub></sub></sub> Pass the active thread when deleting archived chats**\n\nWhen the user has an archived chat open (for example after selecting it from this dialog) and later deletes that same row here, `deleteChatItem` receives... | true | ||
unslothai/unsloth | 6,282 | issue_to_patch | [Bug] Installation error: configuration error: `project.license` must be valid exactly by one definition
Note: Please do not remove the questions. Answer beside them.
1. Did you update? `pip install --upgrade unsloth unsloth_zoo` → manually install
2. `Colab` or `Kaggle` or local / cloud → local machine
3. Number GPUs... | Upgrade setuptools and wheel in the auto-install command | ## Summary
Fixes #6277.
The auto-install command generated by `unsloth/_auto_install.py` builds unsloth from git with `--no-build-isolation`:
```
pip install --upgrade pip && pip install --no-deps git+...unsloth-zoo.git && pip install "unsloth[...] @ git+...unsloth.git" --no-build-isolation
```
`--no-build-isolatio... | 502d4ade1cc2211c2febbc4f29f1628cff18e2e0 | daf0951b66eb9ee171c510750b616b0a2410ba8b | diff --git a/unsloth/_auto_install.py b/unsloth/_auto_install.py
index f6deefeb33..d34e09e89c 100644
--- a/unsloth/_auto_install.py
+++ b/unsloth/_auto_install.py
@@ -40,4 +40,4 @@
if v > V('2.6.9') and cuda not in ("11.8", "12.6", "12.8", "13.0"): raise RuntimeError(f"CUDA = {cuda} not supported!")
if v >= V('2.10.0... | [
"unsloth/_auto_install.py"
] | [
{
"comment": "**<sub><sub></sub></sub> Install the full no-isolation build requirements**\n\nIn environments that do not already have `setuptools-scm` installed, this generated command still fails at the final `pip install ... --no-build-isolation`:... | true | |
unslothai/unsloth | 6,287 | issue_to_patch | [Bug] In responses API tool call output field doesn't get processed correctly unless it is plain text
Note: Please do not remove the questions. Answer beside them.
1. Did you update? `pip install --upgrade unsloth unsloth_zoo`
I updated today using `curl -fsSL https://unsloth.ai/install.sh | sh`
2. `Colab` or `Kaggl... | Fix Responses tool output content arrays | ## Summary
- Preserve Responses `function_call_output.output` text and image content arrays instead of JSON-serializing them.
- This prevents structured tool outputs from being shown to the model as raw JSON and allows image-bearing tool results to reach vision models.
## Tests
- pytest studio/backend/tests/test_... | 985792a83b7f1fdfc2bd661f8754d4f018b3dce8 | f4456e2df4643f698fa99abc094ca3dcc07caf5b | diff --git a/studio/backend/models/inference.py b/studio/backend/models/inference.py
index 04c63c2247..4e6a5937d8 100644
--- a/studio/backend/models/inference.py
+++ b/studio/backend/models/inference.py
@@ -416,7 +416,7 @@ class ImageUrl(BaseModel):
"""Image URL object — supports data URIs and remote URLs."""
... | [
"studio/backend/models/inference.py",
"studio/backend/routes/inference.py",
"studio/backend/tests/test_responses_tool_passthrough.py"
] | [
{
"comment": "**<sub><sub></sub></sub> Preserve image file_id tool outputs**\n\nWhen a Responses `function_call_output` contains an `input_image` supplied by `file_id` (or mixed text plus such an image), this branch only reads `image_url` and skips ... | diff --git a/studio/backend/tests/test_responses_tool_passthrough.py b/studio/backend/tests/test_responses_tool_passthrough.py
index ae7ff729bd..89155c2daf 100644
--- a/studio/backend/tests/test_responses_tool_passthrough.py
+++ b/studio/backend/tests/test_responses_tool_passthrough.py
@@ -36,6 +36,7 @@
import httpx... | true |
unslothai/unsloth | 6,287 | comment_to_fix | Fix Responses tool output content arrays | **<sub><sub></sub></sub> Preserve image file_id tool outputs**
When a Responses `function_call_output` contains an `input_image` supplied by `file_id` (or mixed text plus such an image), this branch only reads `image_url` and skips the image when that fiel... | 985792a83b7f1fdfc2bd661f8754d4f018b3dce8 | f4456e2df4643f698fa99abc094ca3dcc07caf5b | diff --git a/studio/backend/routes/inference.py b/studio/backend/routes/inference.py
index e9353cd803..2f9ed35936 100644
--- a/studio/backend/routes/inference.py
+++ b/studio/backend/routes/inference.py
@@ -5309,15 +5309,72 @@ def _responses_message_text(content: Union[str, list]) -> str:
return "\n".join(parts)
... | [
"studio/backend/routes/inference.py"
] | [
{
"comment": "**<sub><sub></sub></sub> Preserve image file_id tool outputs**\n\nWhen a Responses `function_call_output` contains an `input_image` supplied by `file_id` (or mixed text plus such an image), this branch only reads `image_url` and skips ... | true | ||
unslothai/unsloth | 6,287 | comment_to_fix | Fix Responses tool output content arrays | **<sub><sub></sub></sub> Avoid image_url parts in tool messages**
For URL/data-URL image tool outputs, this creates an OpenAI Chat `role="tool"` message whose content contains an `image_url` part; the downstream Responses adapter immediately converts the r... | 985792a83b7f1fdfc2bd661f8754d4f018b3dce8 | f4456e2df4643f698fa99abc094ca3dcc07caf5b | diff --git a/studio/backend/routes/inference.py b/studio/backend/routes/inference.py
index e9353cd803..2f9ed35936 100644
--- a/studio/backend/routes/inference.py
+++ b/studio/backend/routes/inference.py
@@ -5309,15 +5309,72 @@ def _responses_message_text(content: Union[str, list]) -> str:
return "\n".join(parts)
... | [
"studio/backend/routes/inference.py"
] | [
{
"comment": "**<sub><sub></sub></sub> Avoid image_url parts in tool messages**\n\nFor URL/data-URL image tool outputs, this creates an OpenAI Chat `role=\"tool\"` message whose content contains an `image_url` part; the downstream Responses adapter ... | true | ||
unslothai/unsloth | 6,287 | comment_to_fix | Fix Responses tool output content arrays | **<sub><sub></sub></sub> Preserve mixed file tool outputs**
Responses `function_call_output.output` arrays can also carry `input_file` parts, but this fallback only preserves the raw array when no recognized text/image parts were found. If a tool returns a... | 985792a83b7f1fdfc2bd661f8754d4f018b3dce8 | f4456e2df4643f698fa99abc094ca3dcc07caf5b | diff --git a/studio/backend/routes/inference.py b/studio/backend/routes/inference.py
index e9353cd803..2f9ed35936 100644
--- a/studio/backend/routes/inference.py
+++ b/studio/backend/routes/inference.py
@@ -5309,15 +5309,72 @@ def _responses_message_text(content: Union[str, list]) -> str:
return "\n".join(parts)
... | [
"studio/backend/routes/inference.py"
] | [
{
"comment": "**<sub><sub></sub></sub> Preserve mixed file tool outputs**\n\nResponses `function_call_output.output` arrays can also carry `input_file` parts, but this fallback only preserves the raw array when no recognized text/image parts were fo... | true | ||
unslothai/unsloth | 6,287 | comment_to_fix | Fix Responses tool output content arrays | **<sub><sub></sub></sub> Allow original image detail for tool outputs**
When a Responses `function_call_output.output` image part uses `detail: "original"` (a valid image detail level for current OpenAI Responses/Chat image inputs: https://developers.opena... | 985792a83b7f1fdfc2bd661f8754d4f018b3dce8 | f4456e2df4643f698fa99abc094ca3dcc07caf5b | diff --git a/studio/backend/routes/inference.py b/studio/backend/routes/inference.py
index e9353cd803..2f9ed35936 100644
--- a/studio/backend/routes/inference.py
+++ b/studio/backend/routes/inference.py
@@ -5309,15 +5309,72 @@ def _responses_message_text(content: Union[str, list]) -> str:
return "\n".join(parts)
... | [
"studio/backend/routes/inference.py"
] | [
{
"comment": "**<sub><sub></sub></sub> Allow original image detail for tool outputs**\n\nWhen a Responses `function_call_output.output` image part uses `detail: \"original\"` (a valid image detail level for current OpenAI Responses/Chat image inputs... | true | ||
unslothai/unsloth | 6,284 | issue_to_patch | Installer: drop redundant -WindowStyle Hidden from the Windows launcher VBS | ## Summary
The Windows installer creates a desktop / Start Menu shortcut that launches Unsloth Studio windowlessly through a generated `launch-studio.vbs`:
```vbs
Set shell = CreateObject("WScript.Shell")
cmd = "powershell -NoProfile -ExecutionPolicy Bypass -WindowStyle Hidden -File ""...launch-studio.ps1"""
shell.Ru... | 502d4ade1cc2211c2febbc4f29f1628cff18e2e0 | b41ad6a9f9def9bdece9fdec951ea08d1210f601 | diff --git a/install.ps1 b/install.ps1
index 5baf76b9fa..88939ce627 100644
--- a/install.ps1
+++ b/install.ps1
@@ -799,9 +799,11 @@ exit 0
# even when install.ps1 is executed from PowerShell 7.
$utf8Bom = New-Object System.Text.UTF8Encoding($true)
[System.IO.File]::WriteAllText($l... | [
"install.ps1",
"tests/studio/install/test_launch_studio_launcher.py"
] | [] | diff --git a/tests/studio/install/test_launch_studio_launcher.py b/tests/studio/install/test_launch_studio_launcher.py
new file mode 100644
index 0000000000..8ea9ca7d80
--- /dev/null
+++ b/tests/studio/install/test_launch_studio_launcher.py
@@ -0,0 +1,50 @@
+"""Guard install.ps1's launch-studio.vbs against re-introduci... | true | |
unslothai/unsloth | 6,285 | issue_to_patch | Fix llama.cpp prebuilt: skip already-installed same-release fallback | ## Summary
Fixes two failing tests on `main`, one a real installer bug and one a brittle guard.
### 1. `install_prebuilt` re-installs an already-installed fallback bundle (real bug)
`install_prebuilt` computes `diffusion_visual_server_backfill_needed` from the newest candidate (`plan.attempts[0]`). When that is `Tru... | 502d4ade1cc2211c2febbc4f29f1628cff18e2e0 | aacb95fd62166b06e92e121ce983014f41df3233 | diff --git a/studio/install_llama_prebuilt.py b/studio/install_llama_prebuilt.py
index 46aa14b041..aab6d641fe 100644
--- a/studio/install_llama_prebuilt.py
+++ b/studio/install_llama_prebuilt.py
@@ -6436,13 +6436,19 @@ def validate_prebuilt_attempts(
f"runtime_line={attempt.runtime_line} coverage_class... | [
"studio/install_llama_prebuilt.py",
"tests/test_studio_install_workspace_guard.py"
] | [] | diff --git a/tests/test_studio_install_workspace_guard.py b/tests/test_studio_install_workspace_guard.py
index 7d93645ca9..27035b522d 100644
--- a/tests/test_studio_install_workspace_guard.py
+++ b/tests/test_studio_install_workspace_guard.py
@@ -873,15 +873,20 @@ def test_llama_cpp_search_roots_handles_studio_root_ose... | true | |
unslothai/unsloth | 5,863 | issue_to_patch | Studio: add stdio MCP server support | Remote (HTTP) MCP support was added in #5750; stdio (local) servers are the other transport. The [official reference servers](https://github.com/modelcontextprotocol/servers) (filesystem, git, fetch, memory) and most community ones run locally as a subprocess via npx/uvx, not over HTTP.
This PR adds stdio MCP suppor... | a3a0cb1606f1041810dba339a1e91ae68d3cb5e2 | e009df19828313ce33fb6739aa26a6c69f84c561 | diff --git a/studio/backend/core/inference/mcp_client.py b/studio/backend/core/inference/mcp_client.py
index a5e614899d..1a38bc8c49 100644
--- a/studio/backend/core/inference/mcp_client.py
+++ b/studio/backend/core/inference/mcp_client.py
@@ -5,6 +5,9 @@
import asyncio
import json
+import os
+import shlex
+import s... | [
"studio/backend/core/inference/mcp_client.py",
"studio/backend/core/inference/tools.py",
"studio/backend/main.py",
"studio/backend/routes/mcp_servers.py",
"studio/frontend/src/features/chat/chat-mcp-servers-dialog.tsx"
] | [
{
"comment": "\n\nThe current implementation of `isValidAddress` rejects any local command that contains `://` anywhere in the string. This is a major bug because it prevents users from configuring stdio MCP servers that accept connection strings... | true | ||
unslothai/unsloth | 5,863 | comment_to_fix | Studio: add stdio MCP server support | 
The current implementation of `isValidAddress` rejects any local command that contains `://` anywhere in the string. This is a major bug because it prevents users from configuring stdio MCP servers that accept connection strings or URLs as arguments (f... | a3a0cb1606f1041810dba339a1e91ae68d3cb5e2 | e009df19828313ce33fb6739aa26a6c69f84c561 | diff --git a/studio/frontend/src/features/chat/chat-mcp-servers-dialog.tsx b/studio/frontend/src/features/chat/chat-mcp-servers-dialog.tsx
index 35b5aca64c..dfb50b5bc2 100644
--- a/studio/frontend/src/features/chat/chat-mcp-servers-dialog.tsx
+++ b/studio/frontend/src/features/chat/chat-mcp-servers-dialog.tsx
@@ -66,23... | [
"studio/frontend/src/features/chat/chat-mcp-servers-dialog.tsx"
] | [
{
"comment": "\n\nThe current implementation of `isValidAddress` rejects any local command that contains `://` anywhere in the string. This is a major bug because it prevents users from configuring stdio MCP servers that accept connection strings... | true | ||
unslothai/unsloth | 5,863 | comment_to_fix | Studio: add stdio MCP server support | 
On Windows, `shlex.split` is called with `posix=False` to preserve backslashes in paths. However, a side effect of `posix=False` is that quotes are preserved in the parsed tokens (e.g., `"C:\Program Files\node.exe"` is returned as `'"C:\\Program Fi... | a3a0cb1606f1041810dba339a1e91ae68d3cb5e2 | e009df19828313ce33fb6739aa26a6c69f84c561 | diff --git a/studio/backend/core/inference/mcp_client.py b/studio/backend/core/inference/mcp_client.py
index a5e614899d..1a38bc8c49 100644
--- a/studio/backend/core/inference/mcp_client.py
+++ b/studio/backend/core/inference/mcp_client.py
@@ -5,6 +5,9 @@
import asyncio
import json
+import os
+import shlex
+import s... | [
"studio/backend/core/inference/mcp_client.py"
] | [
{
"comment": "\n\nOn Windows, `shlex.split` is called with `posix=False` to preserve backslashes in paths. However, a side effect of `posix=False` is that quotes are preserved in the parsed tokens (e.g., `\"C:\\Program Files\\node.exe\"` is r... | true | ||
unslothai/unsloth | 5,863 | comment_to_fix | Studio: add stdio MCP server support | 
If `parse_stdio_command` returns an empty list (for example, if the URL/command is empty or consists only of whitespace), accessing `parts[0]` will raise an `IndexError`. We should defensively check if `parts` is empty and raise a descriptive `Valu... | a3a0cb1606f1041810dba339a1e91ae68d3cb5e2 | e009df19828313ce33fb6739aa26a6c69f84c561 | diff --git a/studio/backend/core/inference/mcp_client.py b/studio/backend/core/inference/mcp_client.py
index a5e614899d..1a38bc8c49 100644
--- a/studio/backend/core/inference/mcp_client.py
+++ b/studio/backend/core/inference/mcp_client.py
@@ -5,6 +5,9 @@
import asyncio
import json
+import os
+import shlex
+import s... | [
"studio/backend/core/inference/mcp_client.py"
] | [
{
"comment": "\n\nIf `parse_stdio_command` returns an empty list (for example, if the URL/command is empty or consists only of whitespace), accessing `parts[0]` will raise an `IndexError`. We should defensively check if `parts` is empty and r... | true | ||
unslothai/unsloth | 6,279 | issue_to_patch | Tidy update banner and auth button spacing | ## What
Two small spacing fixes in the Studio frontend.
### Update banners
The action row used `justify-between`, which spreads two buttons to opposite edges of the card and leaves a large empty gap between them. The buttons also carried margin hacks to push each one flush against its edge, fighting the layout. This... | 2b76c6855a023d1bdd492c75193f83f66fe47562 | 1e58f9a92d4b02379833b480e59d9f77b8ef9d3c | diff --git a/studio/frontend/src/components/llama-update-banner.tsx b/studio/frontend/src/components/llama-update-banner.tsx
index 8f8bc5ca7f..1aa9fc4e60 100644
--- a/studio/frontend/src/components/llama-update-banner.tsx
+++ b/studio/frontend/src/components/llama-update-banner.tsx
@@ -203,11 +203,11 @@ export function... | [
"studio/frontend/src/components/llama-update-banner.tsx",
"studio/frontend/src/components/web/update-banner.tsx",
"studio/frontend/src/features/auth/components/auth-form.tsx"
] | [
{
"comment": "**<sub><sub></sub></sub> Keep action buttons wrapping on narrow banners**\n\nOn narrow web viewports, the new wrapper makes the two action buttons a single flex item, while `Button` itself is `shrink-0`/`whitespace-nowrap`; once that g... | true | ||
unslothai/unsloth | 6,222 | issue_to_patch | feat(studio): implement S3 dataset loading (completes #5951) | ## Summary
Completes the S3 dataset loader scaffold from #5951 and wires S3 in as a first-class Studio dataset source alongside Hugging Face and local uploads.
## Backend
- Adds `core/training/s3_dataset.py` to list and download supported dataset files from S3 using IAM role or access-key credentials.
- Keeps `boto3... | b72cf0af2443c066b539c8dd10aa17b7dbe702fa | fbeae7b166419ec4c23046a25d61c57a282af6da | diff --git a/studio/backend/core/training/resume.py b/studio/backend/core/training/resume.py
index 165c1c2cf1..2a4a198610 100644
--- a/studio/backend/core/training/resume.py
+++ b/studio/backend/core/training/resume.py
@@ -3,6 +3,7 @@
"""Helpers for validating resumable training outputs."""
+import json
from path... | [
"studio/backend/core/training/resume.py",
"studio/backend/core/training/s3_dataset.py",
"studio/backend/core/training/trainer.py",
"studio/backend/core/training/training.py",
"studio/backend/core/training/worker.py",
"studio/backend/models/training.py",
"studio/backend/requirements/studio.txt",
"studi... | [
{
"comment": "**<sub><sub></sub></sub> Handle S3 in onboarding progression**\n\nWhen the S3 tab is selected here, the store sets `datasetSource` to `\"s3\"` while clearing both `dataset` and `uploadedFile`; however, `canProceedForStep` still treats ... | diff --git a/studio/backend/tests/test_s3_dataset.py b/studio/backend/tests/test_s3_dataset.py
new file mode 100644
index 0000000000..f47db565ff
--- /dev/null
+++ b/studio/backend/tests/test_s3_dataset.py
@@ -0,0 +1,274 @@
+# SPDX-License-Identifier: AGPL-3.0-only
+# Copyright 2026-present the Unsloth AI Inc. team. All... | true | |
unslothai/unsloth | 6,222 | comment_to_fix | feat(studio): implement S3 dataset loading (completes #5951) | **<sub><sub></sub></sub> Avoid overwriting S3 files after basename collisions**
When an S3 prefix contains repeated basenames and also a file whose basename matches the generated suffix (for example `a/train.parquet`, `b/train_2.parquet`, then `c/train.par... | b72cf0af2443c066b539c8dd10aa17b7dbe702fa | fbeae7b166419ec4c23046a25d61c57a282af6da | diff --git a/studio/backend/core/training/s3_dataset.py b/studio/backend/core/training/s3_dataset.py
new file mode 100644
index 0000000000..3d05d19c75
--- /dev/null
+++ b/studio/backend/core/training/s3_dataset.py
@@ -0,0 +1,228 @@
+# SPDX-License-Identifier: AGPL-3.0-only
+# Copyright 2026-present the Unsloth AI Inc. ... | [
"studio/backend/core/training/s3_dataset.py"
] | [
{
"comment": "**<sub><sub></sub></sub> Avoid overwriting S3 files after basename collisions**\n\nWhen an S3 prefix contains repeated basenames and also a file whose basename matches the generated suffix (for example `a/train.parquet`, `b/train_2.par... | true | ||
unslothai/unsloth | 6,222 | comment_to_fix | feat(studio): implement S3 dataset loading (completes #5951) | **<sub><sub></sub></sub> Wire S3 into MLX dataset loading**
This only passes `s3_config` into the CUDA/standard `UnslothTrainer` path, but `run_training_process` routes Apple Silicon hosts into `_run_mlx_training`, whose dataset loader still checks only `h... | b72cf0af2443c066b539c8dd10aa17b7dbe702fa | fbeae7b166419ec4c23046a25d61c57a282af6da | diff --git a/studio/backend/core/training/worker.py b/studio/backend/core/training/worker.py
index c7c9003a04..1120744a2d 100644
--- a/studio/backend/core/training/worker.py
+++ b/studio/backend/core/training/worker.py
@@ -1336,6 +1336,32 @@ def _send(event_type, **kwargs):
kwargs["message"] = sm
... | [
"studio/backend/core/training/worker.py"
] | [
{
"comment": "**<sub><sub></sub></sub> Wire S3 into MLX dataset loading**\n\nThis only passes `s3_config` into the CUDA/standard `UnslothTrainer` path, but `run_training_process` routes Apple Silicon hosts into `_run_mlx_training`, whose dataset loa... | true | ||
unslothai/unsloth | 6,222 | comment_to_fix | feat(studio): implement S3 dataset loading (completes #5951) | **<sub><sub></sub></sub> Hide S3 for embedding models until supported**
When the selected model type is embeddings, this new S3 tab lets the user configure and submit an S3 dataset, but `run_training_process` branches to `_run_embedding_training` for `conf... | b72cf0af2443c066b539c8dd10aa17b7dbe702fa | fbeae7b166419ec4c23046a25d61c57a282af6da | diff --git a/studio/frontend/src/features/studio/sections/dataset-section.tsx b/studio/frontend/src/features/studio/sections/dataset-section.tsx
index 3677b8e1bd..970e5246af 100644
--- a/studio/frontend/src/features/studio/sections/dataset-section.tsx
+++ b/studio/frontend/src/features/studio/sections/dataset-section.t... | [
"studio/frontend/src/features/studio/sections/dataset-section.tsx"
] | [
{
"comment": "**<sub><sub></sub></sub> Hide S3 for embedding models until supported**\n\nWhen the selected model type is embeddings, this new S3 tab lets the user configure and submit an S3 dataset, but `run_training_process` branches to `_run_embed... | true | ||
unslothai/unsloth | 6,222 | comment_to_fix | feat(studio): implement S3 dataset loading (completes #5951) | **<sub><sub></sub></sub> Reject mixed S3 file formats before loading**
When an S3 prefix contains multiple supported extensions, for example `train.parquet` plus a `schema.json`/metadata file or a stray CSV, this collects every matching key. The downstream... | b72cf0af2443c066b539c8dd10aa17b7dbe702fa | fbeae7b166419ec4c23046a25d61c57a282af6da | diff --git a/studio/backend/core/training/s3_dataset.py b/studio/backend/core/training/s3_dataset.py
new file mode 100644
index 0000000000..3d05d19c75
--- /dev/null
+++ b/studio/backend/core/training/s3_dataset.py
@@ -0,0 +1,228 @@
+# SPDX-License-Identifier: AGPL-3.0-only
+# Copyright 2026-present the Unsloth AI Inc. ... | [
"studio/backend/core/training/s3_dataset.py"
] | [
{
"comment": "**<sub><sub></sub></sub> Reject mixed S3 file formats before loading**\n\nWhen an S3 prefix contains multiple supported extensions, for example `train.parquet` plus a `schema.json`/metadata file or a stray CSV, this collects every matc... | true | ||
unslothai/unsloth | 6,222 | comment_to_fix | feat(studio): implement S3 dataset loading (completes #5951) | **<sub><sub></sub></sub> Clean up downloaded S3 temp directories**
In normal training calls `dest_dir` is not supplied, so every S3 run creates a new `unsloth_s3_dataset_*` directory and nothing removes it after success, failure, or cancellation. S3 datase... | b72cf0af2443c066b539c8dd10aa17b7dbe702fa | fbeae7b166419ec4c23046a25d61c57a282af6da | diff --git a/studio/backend/core/training/s3_dataset.py b/studio/backend/core/training/s3_dataset.py
new file mode 100644
index 0000000000..3d05d19c75
--- /dev/null
+++ b/studio/backend/core/training/s3_dataset.py
@@ -0,0 +1,228 @@
+# SPDX-License-Identifier: AGPL-3.0-only
+# Copyright 2026-present the Unsloth AI Inc. ... | [
"studio/backend/core/training/s3_dataset.py"
] | [
{
"comment": "**<sub><sub></sub></sub> Clean up downloaded S3 temp directories**\n\nIn normal training calls `dest_dir` is not supplied, so every S3 run creates a new `unsloth_s3_dataset_*` directory and nothing removes it after success, failure, or... | true | ||
unslothai/unsloth | 6,222 | comment_to_fix | feat(studio): implement S3 dataset loading (completes #5951) | **<sub><sub></sub></sub> Preserve mapping review for S3 datasets**
When S3 is selected this gate removes the dataset preview/mapping path, and `startTrainingRun` also skips `checkDatasetFormat` because `getDatasetName()` returns `uploadedFile` for every no... | b72cf0af2443c066b539c8dd10aa17b7dbe702fa | fbeae7b166419ec4c23046a25d61c57a282af6da | diff --git a/studio/frontend/src/features/studio/sections/dataset-section.tsx b/studio/frontend/src/features/studio/sections/dataset-section.tsx
index 3677b8e1bd..970e5246af 100644
--- a/studio/frontend/src/features/studio/sections/dataset-section.tsx
+++ b/studio/frontend/src/features/studio/sections/dataset-section.t... | [
"studio/frontend/src/features/studio/sections/dataset-section.tsx"
] | [
{
"comment": "**<sub><sub></sub></sub> Preserve mapping review for S3 datasets**\n\nWhen S3 is selected this gate removes the dataset preview/mapping path, and `startTrainingRun` also skips `checkDatasetFormat` because `getDatasetName()` returns `up... | true | ||
unslothai/unsloth | 6,222 | comment_to_fix | feat(studio): implement S3 dataset loading (completes #5951) | **<sub><sub></sub></sub> Poll cancellation while downloading S3 objects**
When the S3 prefix contains a large object or many shards and the user cancels during the download, this loop stays inside `download_file` until all selected keys finish; the standar... | b72cf0af2443c066b539c8dd10aa17b7dbe702fa | fbeae7b166419ec4c23046a25d61c57a282af6da | diff --git a/studio/backend/core/training/s3_dataset.py b/studio/backend/core/training/s3_dataset.py
new file mode 100644
index 0000000000..3d05d19c75
--- /dev/null
+++ b/studio/backend/core/training/s3_dataset.py
@@ -0,0 +1,228 @@
+# SPDX-License-Identifier: AGPL-3.0-only
+# Copyright 2026-present the Unsloth AI Inc. ... | [
"studio/backend/core/training/s3_dataset.py"
] | [
{
"comment": "**<sub><sub></sub></sub> Poll cancellation while downloading S3 objects**\n\nWhen the S3 prefix contains a large object or many shards and the user cancels during the download, this loop stays inside `download_file` until all selected ... | true | ||
unslothai/unsloth | 6,222 | comment_to_fix | feat(studio): implement S3 dataset loading (completes #5951) | **<sub><sub></sub></sub> Block S3 for multimodal runs until detection exists**
When a vision or audio model is selected, this tab now allows an S3 dataset to be submitted, but the S3 path never runs `checkDatasetFormat`: `getDatasetName()` returns `null` f... | b72cf0af2443c066b539c8dd10aa17b7dbe702fa | fbeae7b166419ec4c23046a25d61c57a282af6da | diff --git a/studio/frontend/src/features/studio/sections/dataset-section.tsx b/studio/frontend/src/features/studio/sections/dataset-section.tsx
index 3677b8e1bd..970e5246af 100644
--- a/studio/frontend/src/features/studio/sections/dataset-section.tsx
+++ b/studio/frontend/src/features/studio/sections/dataset-section.t... | [
"studio/frontend/src/features/studio/sections/dataset-section.tsx"
] | [
{
"comment": "**<sub><sub></sub></sub> Block S3 for multimodal runs until detection exists**\n\nWhen a vision or audio model is selected, this tab now allows an S3 dataset to be submitted, but the S3 path never runs `checkDatasetFormat`: `getDataset... | true | ||
unslothai/unsloth | 6,270 | issue_to_patch | Bump install.sh / install.ps1 pin to unsloth>=2026.6.6 | ## Summary
- PyPI release [unsloth 2026.6.6](https://pypi.org/project/unsloth/2026.6.6/) is now live.
- Bumps the pinned floor in `install.sh` and `install.ps1` from `unsloth>=2026.6.5` to `unsloth>=2026.6.6` so fresh installs resolve to the new wheel.
- Tagged on main as `v0.1.463-beta`.
## Test plan
- [ ] Sanity-r... | cd270e2878ea63de1569a04fd2a7156b5d0966a1 | 1e954c35405ce2e670e64ea4f64cf1c65f8592ad | diff --git a/install.ps1 b/install.ps1
index fa0d160a33..5baf76b9fa 100644
--- a/install.ps1
+++ b/install.ps1
@@ -1921,7 +1921,7 @@ shell.Run cmd, 0, False
if ($SkipTorch) {
# No-torch: install unsloth + unsloth-zoo with --no-deps, then
# runtime deps (typer, safetensors, transformer... | [
"install.ps1",
"install.sh"
] | [] | true | ||
unslothai/unsloth | 6,268 | issue_to_patch | Studio: keep llama-server discovery from crashing on an access-denied candidate | ## Problem
On Windows, loading a model could fail validation with:
```
PermissionError: [WinError 5] Access is denied:
'C:\Users\...\.unsloth\llama.cpp\build\bin\Release\llama-server.exe'
```
`_find_llama_server_binary` probes candidate paths with `Path.is_file()`. `is_file()` returns False for an absent path but ra... | 01d152b06f558ec4b63a62d4ea04b5ff28579ecc | 2d3ad88be3201d931413dee6e831d1d28b262fdb | diff --git a/studio/backend/core/inference/llama_cpp.py b/studio/backend/core/inference/llama_cpp.py
index 80b9739cc1..16f6376aab 100644
--- a/studio/backend/core/inference/llama_cpp.py
+++ b/studio/backend/core/inference/llama_cpp.py
@@ -1071,7 +1071,7 @@ def spec_draft_n_max(self) -> Optional[int]:
# ── Binary d... | [
"studio/backend/core/inference/llama_cpp.py",
"studio/backend/utils/models/model_config.py"
] | [
{
"comment": "**<sub><sub></sub></sub> Guard the capability probe before returning denied paths**\n\nWhen this branch treats a still access-denied candidate as found, the next launch path can immediately pass that value to `probe_server_capabilities... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.