repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
unoplatform/uno
23,332
comment_to_fix
chore: try building and testing against .NET 10
`GetLocalProperty()` returns the result of `Type.GetProperty(...)`, which can be null, but the local function currently returns `PropertyInfo` (non-nullable). This makes the subsequent `if (localProperty is null)` check inconsistent and can produce nullable warnings. Return `PropertyInfo?` instead.
c7b9ac0d1e68a3c806618d6f303fa678f5056e56
8bd11bcc6d76ba88b59ffb57692974e9b23df565
diff --git a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs index b80f7c0d4a66..fb1022792f16 100644 --- a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs +++ b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs @@ -1,4 +1,5 @@ using System; +using System...
[ "src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs" ]
[ { "comment": "`GetLocalProperty()` returns the result of `Type.GetProperty(...)`, which can be null, but the local function currently returns `PropertyInfo` (non-nullable). This makes the subsequent `if (localProperty is null)` check inconsistent and can produce nullable warnings. Return `PropertyInfo?` instead...
true
unoplatform/uno
23,332
comment_to_fix
chore: try building and testing against .NET 10
`GetLocalField()` returns the result of `Type.GetField(...)`, which can be null, but the local function currently returns `FieldInfo` (non-nullable). This makes the subsequent `if (localTimeZoneField is null)` check inconsistent and can produce nullable warnings. Return `FieldInfo?` instead.
c7b9ac0d1e68a3c806618d6f303fa678f5056e56
8bd11bcc6d76ba88b59ffb57692974e9b23df565
diff --git a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs index b80f7c0d4a66..fb1022792f16 100644 --- a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs +++ b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs @@ -1,4 +1,5 @@ using System; +using System...
[ "src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs" ]
[ { "comment": "`GetLocalField()` returns the result of `Type.GetField(...)`, which can be null, but the local function currently returns `FieldInfo` (non-nullable). This makes the subsequent `if (localTimeZoneField is null)` check inconsistent and can produce nullable warnings. Return `FieldInfo?` instead.", ...
true
unoplatform/uno
23,332
comment_to_fix
chore: try building and testing against .NET 10
The `System.Text.Encodings.Web` PackageReference is currently under a condition that can never be true for this project (`TargetFramework` is `net10.0`, and `IsTargetFrameworkCompatible('net10.0', net10.0)` is true). As written, the reference will not be included at all, which undermines the fixture’s intent to pin Ass...
c7b9ac0d1e68a3c806618d6f303fa678f5056e56
8bd11bcc6d76ba88b59ffb57692974e9b23df565
diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj index ed126d64ade5..897ff29ef627 100644 --- a/src/Uno.UI.RemoteCont...
[ "src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj" ]
[ { "comment": "The `System.Text.Encodings.Web` PackageReference is currently under a condition that can never be true for this project (`TargetFramework` is `net10.0`, and `IsTargetFrameworkCompatible('net10.0', net10.0)` is true). As written, the reference will not be included at all, which undermines the fixtu...
true
unoplatform/uno
23,332
comment_to_fix
chore: try building and testing against .NET 10
`GetAngle` is conditioned to run only when `TargetFramework == $(NetUWPOrWinUI)`. If someone builds only the new `$(NetCurrentUWPOrWinUI)` target (e.g. `-f $(NetCurrentUWPOrWinUI)`), the ANGLE binaries won't be downloaded and the build/pack step may fail. Consider running this target for both WinUI TFMs (the `DownloadF...
c7b9ac0d1e68a3c806618d6f303fa678f5056e56
8bd11bcc6d76ba88b59ffb57692974e9b23df565
diff --git a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj index c7f5eb46fdda..46ee28c715a6 100644 --- a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj +++ b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.cspr...
[ "src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj" ]
[ { "comment": "`GetAngle` is conditioned to run only when `TargetFramework == $(NetUWPOrWinUI)`. If someone builds only the new `$(NetCurrentUWPOrWinUI)` target (e.g. `-f $(NetCurrentUWPOrWinUI)`), the ANGLE binaries won't be downloaded and the build/pack step may fail. Consider running this target for both WinU...
true
unoplatform/uno
23,332
comment_to_fix
chore: try building and testing against .NET 10
The comment block says this test project is kept on the *oldest supported* TFM, but it now targets `$(NetUnitTests)` (which is `$(NetCurrent)` in `Directory.Build.props`). Update the comment to avoid misleading future maintainers.
c7b9ac0d1e68a3c806618d6f303fa678f5056e56
8bd11bcc6d76ba88b59ffb57692974e9b23df565
diff --git a/src/Uno.Analyzers.Tests/Uno.Analyzers.Tests.csproj b/src/Uno.Analyzers.Tests/Uno.Analyzers.Tests.csproj index ab1f1b1d8994..79f93022e95e 100644 --- a/src/Uno.Analyzers.Tests/Uno.Analyzers.Tests.csproj +++ b/src/Uno.Analyzers.Tests/Uno.Analyzers.Tests.csproj @@ -1,10 +1,10 @@ <Project Sdk="Microsoft.NET.Sd...
[ "src/Uno.Analyzers.Tests/Uno.Analyzers.Tests.csproj" ]
[ { "comment": "The comment block says this test project is kept on the *oldest supported* TFM, but it now targets `$(NetUnitTests)` (which is `$(NetCurrent)` in `Directory.Build.props`). Update the comment to avoid misleading future maintainers.", "path": "src/Uno.Analyzers.Tests/Uno.Analyzers.Tests.csproj",...
true
unoplatform/uno
23,332
comment_to_fix
chore: try building and testing against .NET 10
`Type.GetType(..., throwOnError: false)` can return null, but `TimeZoneInfoCachedDataType` is declared as non-nullable `Type`. If this project has nullable enabled, this will produce warnings and makes the subsequent comparisons misleading. Consider making it `Type?` (and ideally `readonly`).
c7b9ac0d1e68a3c806618d6f303fa678f5056e56
8bd11bcc6d76ba88b59ffb57692974e9b23df565
diff --git a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs index b80f7c0d4a66..fb1022792f16 100644 --- a/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs +++ b/src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs @@ -1,4 +1,5 @@ using System; +using System...
[ "src/Uno.UI.RuntimeTests/Helpers/TimeZoneModifier.cs" ]
[ { "comment": "`Type.GetType(..., throwOnError: false)` can return null, but `TimeZoneInfoCachedDataType` is declared as non-nullable `Type`. If this project has nullable enabled, this will produce warnings and makes the subsequent comparisons misleading. Consider making it `Type?` (and ideally `readonly`).", ...
true
unoplatform/uno
23,332
comment_to_fix
chore: try building and testing against .NET 10
This fixture is documented as intentionally targeting an older TFM than the host tests to validate cross-major assembly resolution. With `Directory.Build.props` setting `NetCurrent=net10.0` and `NetPrevious=net9.0`, targeting `net10.0` here makes the fixture the *same* major as the host and the conditional ItemGroup fo...
c7b9ac0d1e68a3c806618d6f303fa678f5056e56
8bd11bcc6d76ba88b59ffb57692974e9b23df565
diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj index ed126d64ade5..897ff29ef627 100644 --- a/src/Uno.UI.RemoteCont...
[ "src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj" ]
[ { "comment": "This fixture is documented as intentionally targeting an older TFM than the host tests to validate cross-major assembly resolution. With `Directory.Build.props` setting `NetCurrent=net10.0` and `NetPrevious=net9.0`, targeting `net10.0` here makes the fixture the *same* major as the host and the co...
true
unoplatform/uno
23,332
comment_to_fix
chore: try building and testing against .NET 10
`GetAngle` now only runs for `$(NetUWPOrWinUI)` (net9). If the project is built/packed only for `$(NetCurrentUWPOrWinUI)` (net10) (e.g., via `-f $(NetCurrentUWPOrWinUI)`), the ANGLE binaries may not be downloaded, resulting in a package missing the `runtimes/osx/native/lib*.dylib` assets. The condition should include t...
c7b9ac0d1e68a3c806618d6f303fa678f5056e56
8bd11bcc6d76ba88b59ffb57692974e9b23df565
diff --git a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj index c7f5eb46fdda..46ee28c715a6 100644 --- a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj +++ b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.cspr...
[ "src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj" ]
[ { "comment": "`GetAngle` now only runs for `$(NetUWPOrWinUI)` (net9). If the project is built/packed only for `$(NetCurrentUWPOrWinUI)` (net10) (e.g., via `-f $(NetCurrentUWPOrWinUI)`), the ANGLE binaries may not be downloaded, resulting in a package missing the `runtimes/osx/native/lib*.dylib` assets. The cond...
true
unoplatform/uno
23,332
comment_to_fix
chore: try building and testing against .NET 10
The project no longer targets any `net10.0-windows*` TFMs, but `_UnoValidateSelfAssets` is still conditioned on `net10.0-windows10.0.19041`, meaning it will never run. Either re-add a Windows target framework, or update the condition to an existing TFM (e.g., `net10.0-desktop`) so the asset validation still executes.
c7b9ac0d1e68a3c806618d6f303fa678f5056e56
8bd11bcc6d76ba88b59ffb57692974e9b23df565
diff --git a/src/SolutionTemplate/5.6/uno56droidioswasmskia/uno56droidioswasmskia/uno56droidioswasmskia.csproj b/src/SolutionTemplate/5.6/uno56droidioswasmskia/uno56droidioswasmskia/uno56droidioswasmskia.csproj index 817c80fe45b9..df790ac1e3ca 100644 --- a/src/SolutionTemplate/5.6/uno56droidioswasmskia/uno56droidioswas...
[ "src/SolutionTemplate/5.6/uno56droidioswasmskia/uno56droidioswasmskia/uno56droidioswasmskia.csproj" ]
[ { "comment": "The project no longer targets any `net10.0-windows*` TFMs, but `_UnoValidateSelfAssets` is still conditioned on `net10.0-windows10.0.19041`, meaning it will never run. Either re-add a Windows target framework, or update the condition to an existing TFM (e.g., `net10.0-desktop`) so the asset valida...
true
unoplatform/uno
23,332
comment_to_fix
chore: try building and testing against .NET 10
This fixture is documented (and relied upon by DevServer_ShouldStart_WithAddInThatHasCrossMajorVersionFrameworkRefs) to compile with *older-major* AssemblyRefs (e.g. System.Text.Encodings.Web 8.0.0.0) so the host’s ALC bridging can be validated. Switching it to net10.0 and removing the pinned v8 PackageReferences defea...
c7b9ac0d1e68a3c806618d6f303fa678f5056e56
8bd11bcc6d76ba88b59ffb57692974e9b23df565
diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj index ed126d64ade5..897ff29ef627 100644 --- a/src/Uno.UI.RemoteCont...
[ "src/Uno.UI.RemoteControl.DevServer.Tests/Fixtures/AddInWithCrossMajorVersionRefs/AddInWithCrossMajorVersionRefs.csproj" ]
[ { "comment": "This fixture is documented (and relied upon by DevServer_ShouldStart_WithAddInThatHasCrossMajorVersionFrameworkRefs) to compile with *older-major* AssemblyRefs (e.g. System.Text.Encodings.Web 8.0.0.0) so the host’s ALC bridging can be validated. Switching it to net10.0 and removing the pinned v8 P...
true
unoplatform/uno
23,332
comment_to_fix
chore: try building and testing against .NET 10
GetAngle currently only runs for $(NetUWPOrWinUI). If the project is built/packed for only $(NetCurrentUWPOrWinUI) (or in a clean environment where the net9 target wasn’t built first), angle_binaries won’t be downloaded and the package can miss the native ANGLE files. Consider running this target for any Windows TFM in...
c7b9ac0d1e68a3c806618d6f303fa678f5056e56
8bd11bcc6d76ba88b59ffb57692974e9b23df565
diff --git a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj index c7f5eb46fdda..46ee28c715a6 100644 --- a/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj +++ b/src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.cspr...
[ "src/AddIns/Uno.WinUI.Graphics3DGL/Uno.WinUI.Graphics3DGL.csproj" ]
[ { "comment": "GetAngle currently only runs for $(NetUWPOrWinUI). If the project is built/packed for only $(NetCurrentUWPOrWinUI) (or in a clean environment where the net9 target wasn’t built first), angle_binaries won’t be downloaded and the package can miss the native ANGLE files. Consider running this target ...
true
unoplatform/uno
23,269
issue_to_patch
test: Add runtime tests for ItemsRepeater fast-scroll and scroll-to-top with high-variance item heights ## Current behavior The existing runtime test suite for `ItemsRepeater` in `src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater.cs` covers a handful of virtualization scenarios (`Whe...
Items repeater item variance fixes
**GitHub Issue:** Closes https://github.com/unoplatform/uno/issues/23041, Closes https://github.com/unoplatform/uno/issues/23042 <!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal), unless the change is documentation related. --> ## PR Type: <!-- Co...
43d2980a44d6bd57412a43d091f90ae2cb5558c3
2a78164886f5605fac2eeb2377962d39fdbc800d
diff --git a/src/SamplesApp/UITests.Shared/UITests.Shared.projitems b/src/SamplesApp/UITests.Shared/UITests.Shared.projitems index 20c3a79010a8..30558397df54 100644 --- a/src/SamplesApp/UITests.Shared/UITests.Shared.projitems +++ b/src/SamplesApp/UITests.Shared/UITests.Shared.projitems @@ -2601,6 +2601,14 @@ <Su...
[ "src/SamplesApp/UITests.Shared/UITests.Shared.projitems", "src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/Repeater/ItemsRepeaterMultiTemplate.xaml", "src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Controls/Repeater/ItemsRepeaterMultiTemplate.xaml.cs", "src/SamplesApp/UITests.Shared/Windows_UI_Xaml_Cont...
[ { "comment": "`TrimOverscroll` can run in `ArrangeOverride` and then again in `UpdateDimensionProperties` for the same layout pass when the viewport size changes, which risks double-clamping (and the arrange-time call still uses stale ExtentHeight/Width as noted in the comment). Consider removing the arrange-ti...
diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater.cs index ea2e69b23f2a..1e3934cccd2b 100644 --- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Repeater/Given_ItemsRepeater.c...
true
unoplatform/uno
23,269
comment_to_fix
Items repeater item variance fixes
`TrimOverscroll` can run in `ArrangeOverride` and then again in `UpdateDimensionProperties` for the same layout pass when the viewport size changes, which risks double-clamping (and the arrange-time call still uses stale ExtentHeight/Width as noted in the comment). Consider removing the arrange-time trim entirely or up...
43d2980a44d6bd57412a43d091f90ae2cb5558c3
2a78164886f5605fac2eeb2377962d39fdbc800d
diff --git a/src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs b/src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs index 8e4ec86c0bea..6c0425936649 100644 --- a/src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs +++ b/src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs @@ -681,13 +681,7 @@ prot...
[ "src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs" ]
[ { "comment": "`TrimOverscroll` can run in `ArrangeOverride` and then again in `UpdateDimensionProperties` for the same layout pass when the viewport size changes, which risks double-clamping (and the arrange-time call still uses stale ExtentHeight/Width as noted in the comment). Consider removing the arrange-ti...
true
unoplatform/uno
23,269
comment_to_fix
Items repeater item variance fixes
`IsScrollAnimationInProgress` treats the mere presence of an AnimationController as “in progress”. In Uno’s composition implementation, a KeyFrameAnimation can stop by itself without being removed from the owning CompositionObject’s animation dictionary, so `TryGetAnimationController(...)` can remain non-null after com...
43d2980a44d6bd57412a43d091f90ae2cb5558c3
2a78164886f5605fac2eeb2377962d39fdbc800d
diff --git a/src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.Managed.cs b/src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.Managed.cs index 583213c8cafe..9cb0697b8dbd 100644 --- a/src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.Managed.cs +++ ...
[ "src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.Managed.cs" ]
[ { "comment": "`IsScrollAnimationInProgress` treats the mere presence of an AnimationController as “in progress”. In Uno’s composition implementation, a KeyFrameAnimation can stop by itself without being removed from the owning CompositionObject’s animation dictionary, so `TryGetAnimationController(...)` can rem...
true
unoplatform/uno
23,269
comment_to_fix
Items repeater item variance fixes
New state (`Uno_LastReportedExtentMajorStart`, `Uno_PostAnchorJumpRefreshCountdown`) is introduced with comments describing anchor-jump/reset behavior, but the countdown is never decremented/used anywhere in the codebase. Either wire this into the measure/extent pipeline (and actually perform the described reset/decrem...
43d2980a44d6bd57412a43d091f90ae2cb5558c3
2a78164886f5605fac2eeb2377962d39fdbc800d
diff --git a/src/Uno.UI/UI/Xaml/Controls/Repeater/StackLayoutState.cs b/src/Uno.UI/UI/Xaml/Controls/Repeater/StackLayoutState.cs index aa6807517fa8..afd7f5f508fa 100644 --- a/src/Uno.UI/UI/Xaml/Controls/Repeater/StackLayoutState.cs +++ b/src/Uno.UI/UI/Xaml/Controls/Repeater/StackLayoutState.cs @@ -30,6 +30,14 @@ public...
[ "src/Uno.UI/UI/Xaml/Controls/Repeater/StackLayoutState.cs" ]
[ { "comment": "New state (`Uno_LastReportedExtentMajorStart`, `Uno_PostAnchorJumpRefreshCountdown`) is introduced with comments describing anchor-jump/reset behavior, but the countdown is never decremented/used anywhere in the codebase. Either wire this into the measure/extent pipeline (and actually perform the ...
true
unoplatform/uno
23,269
comment_to_fix
Items repeater item variance fixes
`Uno_LastMeasureDidAnchorJump` is set/reset, but there are no consumers that “inspect and clear” it as the comment claims (a repo search shows no reads). This is dead state right now; either implement the intended consumption (e.g. in StackLayout.GetExtent) or remove the flag/comment to keep the codebase accurate.
43d2980a44d6bd57412a43d091f90ae2cb5558c3
2a78164886f5605fac2eeb2377962d39fdbc800d
diff --git a/src/Uno.UI/UI/Xaml/Controls/Repeater/FlowLayoutAlgorithm.cs b/src/Uno.UI/UI/Xaml/Controls/Repeater/FlowLayoutAlgorithm.cs index 1c98061eac28..a7fb2866d815 100644 --- a/src/Uno.UI/UI/Xaml/Controls/Repeater/FlowLayoutAlgorithm.cs +++ b/src/Uno.UI/UI/Xaml/Controls/Repeater/FlowLayoutAlgorithm.cs @@ -29,7 +29,...
[ "src/Uno.UI/UI/Xaml/Controls/Repeater/FlowLayoutAlgorithm.cs" ]
[ { "comment": "`Uno_LastMeasureDidAnchorJump` is set/reset, but there are no consumers that “inspect and clear” it as the comment claims (a repo search shows no reads). This is dead state right now; either implement the intended consumption (e.g. in StackLayout.GetExtent) or remove the flag/comment to keep the c...
true
unoplatform/uno
23,269
comment_to_fix
Items repeater item variance fixes
`IsScrollAnimationInProgress` treats "animation exists" as "animation is in flight" by checking `TryGetAnimationController(...) != null`. In Uno's composition implementation, a completed `KeyFrameAnimation` can remain tracked on the `CompositionObject` until `StopAnimation` is called, so this can stay non-null after th...
43d2980a44d6bd57412a43d091f90ae2cb5558c3
2a78164886f5605fac2eeb2377962d39fdbc800d
diff --git a/src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.Managed.cs b/src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.Managed.cs index 583213c8cafe..9cb0697b8dbd 100644 --- a/src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.Managed.cs +++ ...
[ "src/Uno.UI/UI/Xaml/Controls/ScrollContentPresenter/ScrollContentPresenter.Managed.cs" ]
[ { "comment": "`IsScrollAnimationInProgress` treats \"animation exists\" as \"animation is in flight\" by checking `TryGetAnimationController(...) != null`. In Uno's composition implementation, a completed `KeyFrameAnimation` can remain tracked on the `CompositionObject` until `StopAnimation` is called, so this ...
true
unoplatform/uno
23,269
comment_to_fix
Items repeater item variance fixes
`Uno_PostAnchorJumpRefreshCountdown` is introduced but never read or updated anywhere, and the comment claims it is decremented/reset based on `FlowLayoutAlgorithm.Uno_LastMeasureDidAnchorJump` (which also isn't consumed). Either wire this state into `StackLayout`/`StackLayoutState` so it actually controls the stable-`...
43d2980a44d6bd57412a43d091f90ae2cb5558c3
2a78164886f5605fac2eeb2377962d39fdbc800d
diff --git a/src/Uno.UI/UI/Xaml/Controls/Repeater/StackLayoutState.cs b/src/Uno.UI/UI/Xaml/Controls/Repeater/StackLayoutState.cs index aa6807517fa8..afd7f5f508fa 100644 --- a/src/Uno.UI/UI/Xaml/Controls/Repeater/StackLayoutState.cs +++ b/src/Uno.UI/UI/Xaml/Controls/Repeater/StackLayoutState.cs @@ -30,6 +30,14 @@ public...
[ "src/Uno.UI/UI/Xaml/Controls/Repeater/StackLayoutState.cs" ]
[ { "comment": "`Uno_PostAnchorJumpRefreshCountdown` is introduced but never read or updated anywhere, and the comment claims it is decremented/reset based on `FlowLayoutAlgorithm.Uno_LastMeasureDidAnchorJump` (which also isn't consumed). Either wire this state into `StackLayout`/`StackLayoutState` so it actually...
true
unoplatform/uno
23,269
comment_to_fix
Items repeater item variance fixes
`Uno_LastMeasureDidAnchorJump` is set in `Measure`/`MakeAnchor`/the disconnected-window path, but there are no readers in the codebase and the comment says consumers “inspect and clear” it. Either add the intended consumer logic (e.g., `StackLayout.GetExtent` resetting cached origin state) or drop the flag/comment to a...
43d2980a44d6bd57412a43d091f90ae2cb5558c3
2a78164886f5605fac2eeb2377962d39fdbc800d
diff --git a/src/Uno.UI/UI/Xaml/Controls/Repeater/FlowLayoutAlgorithm.cs b/src/Uno.UI/UI/Xaml/Controls/Repeater/FlowLayoutAlgorithm.cs index 1c98061eac28..a7fb2866d815 100644 --- a/src/Uno.UI/UI/Xaml/Controls/Repeater/FlowLayoutAlgorithm.cs +++ b/src/Uno.UI/UI/Xaml/Controls/Repeater/FlowLayoutAlgorithm.cs @@ -29,7 +29,...
[ "src/Uno.UI/UI/Xaml/Controls/Repeater/FlowLayoutAlgorithm.cs" ]
[ { "comment": "`Uno_LastMeasureDidAnchorJump` is set in `Measure`/`MakeAnchor`/the disconnected-window path, but there are no readers in the codebase and the comment says consumers “inspect and clear” it. Either add the intended consumer logic (e.g., `StackLayout.GetExtent` resetting cached origin state) or drop...
true
unoplatform/uno
23,269
comment_to_fix
Items repeater item variance fixes
The PR description currently contains a placeholder "closes #" without an actual linked issue. Please update the PR description to include a fully-qualified issue link (e.g., `Closes https://github.com/unoplatform/uno/issues/<id>`) to comply with the repo's PR requirements.
43d2980a44d6bd57412a43d091f90ae2cb5558c3
2a78164886f5605fac2eeb2377962d39fdbc800d
diff --git a/src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs b/src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs index 8e4ec86c0bea..6c0425936649 100644 --- a/src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs +++ b/src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs @@ -681,13 +681,7 @@ prot...
[ "src/Uno.UI/UI/Xaml/Controls/ScrollViewer/ScrollViewer.cs" ]
[ { "comment": "The PR description currently contains a placeholder \"closes #\" without an actual linked issue. Please update the PR description to include a fully-qualified issue link (e.g., `Closes https://github.com/unoplatform/uno/issues/<id>`) to comply with the repo's PR requirements.", "path": "src/Un...
true
unoplatform/uno
23,421
issue_to_patch
Keep Catalyst temporarily
…drop" This reverts commit e7518b8e23ea8cd0e3ac8a15093c5942d5899285, reversing changes made to 4990906d88232dfd8dbcf280e305fec9b2272f7e. # Conflicts: # src/Directory.Build.props **GitHub Issue:** closes # <!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub i...
22e702416ae3cd297e1e438c483981c275f1f816
8c242edac5ed1572a659b72aa635991d7ba03310
diff --git a/.github/workflows/winappsdk-sync-apply.yml b/.github/workflows/winappsdk-sync-apply.yml index 7c6b21b2acaf..d2edcdc5c401 100644 --- a/.github/workflows/winappsdk-sync-apply.yml +++ b/.github/workflows/winappsdk-sync-apply.yml @@ -99,7 +99,7 @@ jobs: - name: Install required .NET workloads ...
[ ".github/workflows/winappsdk-sync-apply.yml", ".github/workflows/winappsdk-sync-check.yml", "Directory.Build.props", "build/cSpell.json", "build/ci/build/.azure-devops-build-managed.yml", "build/nuget/Uno.Foundation.nuspec", "build/nuget/Uno.WinRT.nuspec", "build/nuget/Uno.WinUI.DevServer.nuspec", "...
[ { "comment": "This top-level `InvariantGlobalization=true` for maccatalyst conflicts with the `InvariantGlobalization=false` set inside the `<When Condition=\"...maccatalyst...\">` block below (line 147). MSBuild evaluates the `When` block last, so the effective value will be `false` — but having both is confus...
diff --git a/src/Uno.UI.RuntimeTests/Tests/HotReload/Frame/HRApp/AppHead.xaml.cs b/src/Uno.UI.RuntimeTests/Tests/HotReload/Frame/HRApp/AppHead.xaml.cs index 43d82a3e3e1b..1a685c6d6e25 100644 --- a/src/Uno.UI.RuntimeTests/Tests/HotReload/Frame/HRApp/AppHead.xaml.cs +++ b/src/Uno.UI.RuntimeTests/Tests/HotReload/Frame/HRA...
true
unoplatform/uno
23,421
comment_to_fix
Keep Catalyst temporarily
This top-level `InvariantGlobalization=true` for maccatalyst conflicts with the `InvariantGlobalization=false` set inside the `<When Condition="...maccatalyst...">` block below (line 147). MSBuild evaluates the `When` block last, so the effective value will be `false` — but having both is confusing and the `true` here ...
22e702416ae3cd297e1e438c483981c275f1f816
8c242edac5ed1572a659b72aa635991d7ba03310
diff --git a/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj b/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj index f34cb7b39ee0..2ab81c428e11 100644 --- a/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj +++ b/src/SamplesApp/SamplesApp.netcoremobi...
[ "src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj" ]
[ { "comment": "This top-level `InvariantGlobalization=true` for maccatalyst conflicts with the `InvariantGlobalization=false` set inside the `<When Condition=\"...maccatalyst...\">` block below (line 147). MSBuild evaluates the `When` block last, so the effective value will be `false` — but having both is confus...
true
unoplatform/uno
23,421
comment_to_fix
Keep Catalyst temporarily
Misleading comment — it's a copy-paste from the iOS block where the setting is `true` (invariant mode). Here the value is `false` (full globalization), so the comment about "invariant culture" mode is backwards. Suggest replacing with something like ``.
22e702416ae3cd297e1e438c483981c275f1f816
8c242edac5ed1572a659b72aa635991d7ba03310
diff --git a/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj b/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj index f34cb7b39ee0..2ab81c428e11 100644 --- a/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj +++ b/src/SamplesApp/SamplesApp.netcoremobi...
[ "src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj" ]
[ { "comment": "Misleading comment — it's a copy-paste from the iOS block where the setting is `true` (invariant mode). Here the value is `false` (full globalization), so the comment about \"invariant culture\" mode is backwards. Suggest replacing with something like ``.", "path": "src/SamplesApp/SamplesApp.n...
true
unoplatform/uno
23,421
comment_to_fix
Keep Catalyst temporarily
Same redundancy as in the non-Skia sample project: `InvariantGlobalization=true` here, then overridden to `false` in the `<When Condition="...maccatalyst...">` block at line 140. The top-level `true` is dead config and should be removed to keep intent clear.
22e702416ae3cd297e1e438c483981c275f1f816
8c242edac5ed1572a659b72aa635991d7ba03310
diff --git a/src/SamplesApp/SamplesApp.Skia.netcoremobile/SamplesApp.Skia.netcoremobile.csproj b/src/SamplesApp/SamplesApp.Skia.netcoremobile/SamplesApp.Skia.netcoremobile.csproj index dd514521b86e..c141d0df9f8c 100644 --- a/src/SamplesApp/SamplesApp.Skia.netcoremobile/SamplesApp.Skia.netcoremobile.csproj +++ b/src/Sam...
[ "src/SamplesApp/SamplesApp.Skia.netcoremobile/SamplesApp.Skia.netcoremobile.csproj" ]
[ { "comment": "Same redundancy as in the non-Skia sample project: `InvariantGlobalization=true` here, then overridden to `false` in the `<When Condition=\"...maccatalyst...\">` block at line 140. The top-level `true` is dead config and should be removed to keep intent clear.", "path": "src/SamplesApp/Samples...
true
unoplatform/uno
23,421
comment_to_fix
Keep Catalyst temporarily
Same misleading copy-paste comment as in the non-Skia project: the comment describes invariant-globalization mode but the value is `false` (full globalization). Replace with ``.
22e702416ae3cd297e1e438c483981c275f1f816
8c242edac5ed1572a659b72aa635991d7ba03310
diff --git a/src/SamplesApp/SamplesApp.Skia.netcoremobile/SamplesApp.Skia.netcoremobile.csproj b/src/SamplesApp/SamplesApp.Skia.netcoremobile/SamplesApp.Skia.netcoremobile.csproj index dd514521b86e..c141d0df9f8c 100644 --- a/src/SamplesApp/SamplesApp.Skia.netcoremobile/SamplesApp.Skia.netcoremobile.csproj +++ b/src/Sam...
[ "src/SamplesApp/SamplesApp.Skia.netcoremobile/SamplesApp.Skia.netcoremobile.csproj" ]
[ { "comment": "Same misleading copy-paste comment as in the non-Skia project: the comment describes invariant-globalization mode but the value is `false` (full globalization). Replace with ``.", "path": "src/SamplesApp/SamplesApp.Skia.netcoremobile/SamplesApp.Skia.netcoremobile.csproj", "hunk": "@@ -116,...
true
unoplatform/uno
23,421
comment_to_fix
Keep Catalyst temporarily
The `//TODO:MZ:` developer-initials note shouldn't land in production code. If this is an open design question ("should `_ownerEvents` also exist for iOS/tvOS rather than only Mac Catalyst?"), either resolve it here or track it as a GitHub issue and remove the inline comment. A comment in production code should state a...
22e702416ae3cd297e1e438c483981c275f1f816
8c242edac5ed1572a659b72aa635991d7ba03310
diff --git a/src/Uno.UI/UI/Xaml/Window/Native/NativeWindow.UIKit.cs b/src/Uno.UI/UI/Xaml/Window/Native/NativeWindow.UIKit.cs index 592b6ad2c996..f92e9cda95d7 100644 --- a/src/Uno.UI/UI/Xaml/Window/Native/NativeWindow.UIKit.cs +++ b/src/Uno.UI/UI/Xaml/Window/Native/NativeWindow.UIKit.cs @@ -53,6 +53,10 @@ public static ...
[ "src/Uno.UI/UI/Xaml/Window/Native/NativeWindow.UIKit.cs" ]
[ { "comment": "The `//TODO:MZ:` developer-initials note shouldn't land in production code. If this is an open design question (\"should `_ownerEvents` also exist for iOS/tvOS rather than only Mac Catalyst?\"), either resolve it here or track it as a GitHub issue and remove the inline comment. A comment in produc...
true
unoplatform/uno
23,423
issue_to_patch
Merge latest ALC changes
**GitHub Issue:** closes # <!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal), unless the change is documentation related. --> ## PR Type: <!-- Copy the label that applies to this PR and paste it above: 🐞 Bugfix ✨ Feature 🎨 Code style...
22e702416ae3cd297e1e438c483981c275f1f816
2660425802f44e91e6fc91ee8fa14f58b2ef6040
diff --git a/src/Uno.UI.RemoteControl.DevServer.Tests/Uno.UI.RemoteControl.DevServer.Tests.csproj b/src/Uno.UI.RemoteControl.DevServer.Tests/Uno.UI.RemoteControl.DevServer.Tests.csproj index 3818ad2aee20..09270d9a8a77 100644 --- a/src/Uno.UI.RemoteControl.DevServer.Tests/Uno.UI.RemoteControl.DevServer.Tests.csproj +++ ...
[ "specs/044-alc-secondary-app-resource-refresh/spec.md", "src/Uno.UI.RemoteControl.DevServer.Tests/Uno.UI.RemoteControl.DevServer.Tests.csproj", "src/Uno.UI.RemoteControl.Host/Uno.UI.RemoteControl.Host.csproj", "src/Uno.UI.RemoteControl.VS/Uno.UI.RemoteControl.VS.csproj", "src/Uno.UI.RemoteControl/HotReload/...
[ { "comment": "The fully-qualified `System.Runtime.Loader.AssemblyLoadContext` is redundant here — `using System.Runtime.Loader;` is already present at the top of this file. Use the short form to stay consistent with the rest of the file:\n\n```suggestion\n\t\tvar alc = AssemblyLoadContext.GetLoadContext(app.Get...
diff --git a/specs/044-alc-secondary-app-resource-refresh/spec.md b/specs/044-alc-secondary-app-resource-refresh/spec.md new file mode 100644 index 000000000000..7cb901840835 --- /dev/null +++ b/specs/044-alc-secondary-app-resource-refresh/spec.md @@ -0,0 +1,66 @@ +# Hot-reload resource refresh for apps hosted in a sec...
true
unoplatform/uno
23,423
comment_to_fix
Merge latest ALC changes
The fully-qualified `System.Runtime.Loader.AssemblyLoadContext` is redundant here — `using System.Runtime.Loader;` is already present at the top of this file. Use the short form to stay consistent with the rest of the file: ```suggestion var alc = AssemblyLoadContext.GetLoadContext(app.GetType().Assembly) ?? Asse...
22e702416ae3cd297e1e438c483981c275f1f816
2660425802f44e91e6fc91ee8fa14f58b2ef6040
diff --git a/src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.MetadataUpdate.cs b/src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.MetadataUpdate.cs index c5b836e93959..809d699bc109 100644 --- a/src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.MetadataUpdate.cs +++ b/src/Uno.UI.RemoteCo...
[ "src/Uno.UI.RemoteControl/HotReload/ClientHotReloadProcessor.MetadataUpdate.cs" ]
[ { "comment": "The fully-qualified `System.Runtime.Loader.AssemblyLoadContext` is redundant here — `using System.Runtime.Loader;` is already present at the top of this file. Use the short form to stay consistent with the rest of the file:\n\n```suggestion\n\t\tvar alc = AssemblyLoadContext.GetLoadContext(app.Get...
true
unoplatform/uno
23,423
comment_to_fix
Merge latest ALC changes
`Assert.Inconclusive` is flagged by Uno conventions (`.claude/rules/runtime-tests.md`). Since the test is already guarded by `[PlatformCondition(ConditionMode.Include, RuntimeTestPlatforms.SkiaWin32 | RuntimeTestPlatforms.SkiaX11)]`, `Uno.UI.RemoteControl` should always be present when this test runs. If the guard is t...
22e702416ae3cd297e1e438c483981c275f1f816
2660425802f44e91e6fc91ee8fa14f58b2ef6040
diff --git a/src/Uno.UI.RuntimeTests/Tests/HotReload/Given_HotReload_UpdateResourceDictionaries.cs b/src/Uno.UI.RuntimeTests/Tests/HotReload/Given_HotReload_UpdateResourceDictionaries.cs new file mode 100644 index 000000000000..9797a672512b --- /dev/null +++ b/src/Uno.UI.RuntimeTests/Tests/HotReload/Given_HotReload_Upd...
[ "src/Uno.UI.RuntimeTests/Tests/HotReload/Given_HotReload_UpdateResourceDictionaries.cs" ]
[ { "comment": "`Assert.Inconclusive` is flagged by Uno conventions (`.claude/rules/runtime-tests.md`). Since the test is already guarded by `[PlatformCondition(ConditionMode.Include, RuntimeTestPlatforms.SkiaWin32 | RuntimeTestPlatforms.SkiaX11)]`, `Uno.UI.RemoteControl` should always be present when this test r...
true
unoplatform/uno
23,423
comment_to_fix
Merge latest ALC changes
This lists `HotReloadAgent.cs` as a changed file ("no behavior change — diagnostic logging only, since removed"), but it is **not in this PR's diff**. If the change was reverted before the PR was raised, this bullet should be removed or updated to reflect that the file was not ultimately modified.
22e702416ae3cd297e1e438c483981c275f1f816
2660425802f44e91e6fc91ee8fa14f58b2ef6040
diff --git a/specs/044-alc-secondary-app-resource-refresh/spec.md b/specs/044-alc-secondary-app-resource-refresh/spec.md new file mode 100644 index 000000000000..7cb901840835 --- /dev/null +++ b/specs/044-alc-secondary-app-resource-refresh/spec.md @@ -0,0 +1,66 @@ +# Hot-reload resource refresh for apps hosted in a sec...
[ "specs/044-alc-secondary-app-resource-refresh/spec.md" ]
[ { "comment": "This lists `HotReloadAgent.cs` as a changed file (\"no behavior change — diagnostic logging only, since removed\"), but it is **not in this PR's diff**. If the change was reverted before the PR was raised, this bullet should be removed or updated to reflect that the file was not ultimately modifie...
true
unoplatform/uno
23,423
comment_to_fix
Merge latest ALC changes
`System.Runtime.Loader.AssemblyLoadContext` is fully qualified here but `using System.Runtime.Loader;` is already present at the top of the file. Prefer the short form for consistency: ```suggestion AssemblyLoadContext.Default, ```
22e702416ae3cd297e1e438c483981c275f1f816
2660425802f44e91e6fc91ee8fa14f58b2ef6040
diff --git a/src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs b/src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs index 0111aeb25f5b..b137e3075d2f 100644 --- a/src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs +++ b/src/Uno.UI.RuntimeTests/Tests/A...
[ "src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs" ]
[ { "comment": "`System.Runtime.Loader.AssemblyLoadContext` is fully qualified here but `using System.Runtime.Loader;` is already present at the top of the file. Prefer the short form for consistency:\n\n```suggestion\n\t\t\t\tAssemblyLoadContext.Default,\n```", "path": "src/Uno.UI.RuntimeTests/Tests/Assembly...
true
unoplatform/uno
23,423
comment_to_fix
Merge latest ALC changes
Same fully-qualified redundancy — use `AssemblyLoadContext.GetLoadContext(...)` directly. ```suggestion AssemblyLoadContext.GetLoadContext(rootContent.GetType().Assembly), ```
22e702416ae3cd297e1e438c483981c275f1f816
2660425802f44e91e6fc91ee8fa14f58b2ef6040
diff --git a/src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs b/src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs index 0111aeb25f5b..b137e3075d2f 100644 --- a/src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs +++ b/src/Uno.UI.RuntimeTests/Tests/A...
[ "src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs" ]
[ { "comment": "Same fully-qualified redundancy — use `AssemblyLoadContext.GetLoadContext(...)` directly.\n\n```suggestion\n\t\t\t\tAssemblyLoadContext.GetLoadContext(rootContent.GetType().Assembly),\n```", "path": "src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs", "hunk": "@@ -1...
true
unoplatform/uno
23,423
comment_to_fix
Merge latest ALC changes
`using System.Runtime.Loader;` is already present at the top of this file — use the short form for consistency with the rest of the file: ```suggestion AssemblyLoadContext.Default, ```
22e702416ae3cd297e1e438c483981c275f1f816
2660425802f44e91e6fc91ee8fa14f58b2ef6040
diff --git a/src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs b/src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs index 0111aeb25f5b..b137e3075d2f 100644 --- a/src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs +++ b/src/Uno.UI.RuntimeTests/Tests/A...
[ "src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs" ]
[ { "comment": "`using System.Runtime.Loader;` is already present at the top of this file — use the short form for consistency with the rest of the file:\n\n```suggestion\n\t\t\t\t\tAssemblyLoadContext.Default,\n```", "path": "src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs", "hu...
true
unoplatform/uno
23,423
comment_to_fix
Merge latest ALC changes
Same redundant qualification — `AssemblyLoadContext` is already imported: ```suggestion AssemblyLoadContext.GetLoadContext(rootContent.GetType().Assembly), ```
22e702416ae3cd297e1e438c483981c275f1f816
2660425802f44e91e6fc91ee8fa14f58b2ef6040
diff --git a/src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs b/src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs index 0111aeb25f5b..b137e3075d2f 100644 --- a/src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs +++ b/src/Uno.UI.RuntimeTests/Tests/A...
[ "src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs" ]
[ { "comment": "Same redundant qualification — `AssemblyLoadContext` is already imported:\n\n```suggestion\n\t\t\t\t\tAssemblyLoadContext.GetLoadContext(rootContent.GetType().Assembly),\n```", "path": "src/Uno.UI.RuntimeTests/Tests/AssemblyLoadContext/Given_AlcContentHost.cs", "hunk": "@@ -1013,6 +1013,27...
true
unoplatform/uno
23,423
comment_to_fix
Merge latest ALC changes
`Assert.Inconclusive` is flagged by Uno runtime-test conventions. The test is already guarded by `[PlatformCondition(ConditionMode.Include, RuntimeTestPlatforms.SkiaWin32 | RuntimeTestPlatforms.SkiaX11)]`, so `Uno.UI.RemoteControl` is always present when this test runs — the fallback is dead code. Either remove it, or ...
22e702416ae3cd297e1e438c483981c275f1f816
2660425802f44e91e6fc91ee8fa14f58b2ef6040
diff --git a/src/Uno.UI.RuntimeTests/Tests/HotReload/Given_HotReload_UpdateResourceDictionaries.cs b/src/Uno.UI.RuntimeTests/Tests/HotReload/Given_HotReload_UpdateResourceDictionaries.cs new file mode 100644 index 000000000000..9797a672512b --- /dev/null +++ b/src/Uno.UI.RuntimeTests/Tests/HotReload/Given_HotReload_Upd...
[ "src/Uno.UI.RuntimeTests/Tests/HotReload/Given_HotReload_UpdateResourceDictionaries.cs" ]
[ { "comment": "`Assert.Inconclusive` is flagged by Uno runtime-test conventions. The test is already guarded by `[PlatformCondition(ConditionMode.Include, RuntimeTestPlatforms.SkiaWin32 | RuntimeTestPlatforms.SkiaX11)]`, so `Uno.UI.RemoteControl` is always present when this test runs — the fallback is dead code....
true
unoplatform/uno
23,426
issue_to_patch
fix(hotreload): decide batch merge under the solution-update gate
**GitHub Issue:** closes # ## PR Type: 🐞 Bugfix ## What changed? 🚀 **Current behavior.** In `HotReloadManager.ProcessFileChanges`, the `TryMerge`/`StartHotReload` decision is made **before** acquiring `_solutionUpdateGate`, while operations are completed by the pass that processes them — which runs **unde...
69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b
13a346f746444b2d99ba364e6947a7fb9cd3b6ec
diff --git a/src/Uno.HotReload.Tests/Given_HotReloadManager.cs b/src/Uno.HotReload.Tests/Given_HotReloadManager.cs new file mode 100644 index 000000000000..f23483003623 --- /dev/null +++ b/src/Uno.HotReload.Tests/Given_HotReloadManager.cs @@ -0,0 +1,109 @@ +using System.Collections.Immutable; +using AwesomeAssertions; ...
[ "specs/044-hotreload-late-batch-result-loss/spec.md", "src/Uno.HotReload.Tests/Given_HotReloadManager.cs", "src/Uno.HotReload.Tests/Given_HotReloadOperation.cs", "src/Uno.HotReload.Tests/TestUtils/HotReloadManagerHarness.cs", "src/Uno.HotReload.Tests/TestUtils/RecordingReporter.cs", "src/Uno.HotReload.Tes...
[ { "comment": "The spec header lists **Status** as \"Planned\", but the same document's Progress section indicates the work is already implemented and validated (checked items + green tests). Updating the status would avoid confusion when scanning specs for what is done vs. pending.", "path": "specs/044-hotr...
diff --git a/specs/044-hotreload-late-batch-result-loss/spec.md b/specs/044-hotreload-late-batch-result-loss/spec.md new file mode 100644 index 000000000000..4859cdfa0aa2 --- /dev/null +++ b/specs/044-hotreload-late-batch-result-loss/spec.md @@ -0,0 +1,169 @@ +# Fix Specification: Hot-Reload Operation Loses the Result ...
true
unoplatform/uno
23,426
comment_to_fix
fix(hotreload): decide batch merge under the solution-update gate
The spec header lists **Status** as "Planned", but the same document's Progress section indicates the work is already implemented and validated (checked items + green tests). Updating the status would avoid confusion when scanning specs for what is done vs. pending.
69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b
13a346f746444b2d99ba364e6947a7fb9cd3b6ec
diff --git a/specs/044-hotreload-late-batch-result-loss/spec.md b/specs/044-hotreload-late-batch-result-loss/spec.md new file mode 100644 index 000000000000..4859cdfa0aa2 --- /dev/null +++ b/specs/044-hotreload-late-batch-result-loss/spec.md @@ -0,0 +1,169 @@ +# Fix Specification: Hot-Reload Operation Loses the Result ...
[ "specs/044-hotreload-late-batch-result-loss/spec.md" ]
[ { "comment": "The spec header lists **Status** as \"Planned\", but the same document's Progress section indicates the work is already implemented and validated (checked items + green tests). Updating the status would avoid confusion when scanning specs for what is done vs. pending.", "path": "specs/044-hotr...
true
unoplatform/uno
23,426
comment_to_fix
fix(hotreload): decide batch merge under the solution-update gate
This test name/description suggests the *overall* scenario results in a single tracked operation, but the assertions are taken before unblocking the first `ProcessFileChanges` call. Once `pendingBatch` is released, the first call can still run and (because `TryMerge` returns false for completed operations) start a new ...
69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b
13a346f746444b2d99ba364e6947a7fb9cd3b6ec
diff --git a/src/Uno.HotReload.Tests/Given_HotReloadManager.cs b/src/Uno.HotReload.Tests/Given_HotReloadManager.cs new file mode 100644 index 000000000000..f23483003623 --- /dev/null +++ b/src/Uno.HotReload.Tests/Given_HotReloadManager.cs @@ -0,0 +1,109 @@ +using System.Collections.Immutable; +using AwesomeAssertions; ...
[ "src/Uno.HotReload.Tests/Given_HotReloadManager.cs" ]
[ { "comment": "This test name/description suggests the *overall* scenario results in a single tracked operation, but the assertions are taken before unblocking the first `ProcessFileChanges` call. Once `pendingBatch` is released, the first call can still run and (because `TryMerge` returns false for completed op...
true
unoplatform/uno
23,426
comment_to_fix
fix(hotreload): decide batch merge under the solution-update gate
The assertion message says **"intersecting batches"**, but the merge actually fires via the `TryMerge` `IsEmpty` branch — `pendingOperation` was created by `StartOrContinueHotReload(null)` and has empty `_consideredFilePaths`, so any batch is absorbed regardless of path overlap. "intersecting" implies the `original.Any...
69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b
13a346f746444b2d99ba364e6947a7fb9cd3b6ec
diff --git a/src/Uno.HotReload.Tests/Given_HotReloadManager.cs b/src/Uno.HotReload.Tests/Given_HotReloadManager.cs new file mode 100644 index 000000000000..f23483003623 --- /dev/null +++ b/src/Uno.HotReload.Tests/Given_HotReloadManager.cs @@ -0,0 +1,109 @@ +using System.Collections.Immutable; +using AwesomeAssertions; ...
[ "src/Uno.HotReload.Tests/Given_HotReloadManager.cs" ]
[ { "comment": "The assertion message says **\"intersecting batches\"**, but the merge actually fires via the `TryMerge` `IsEmpty` branch — `pendingOperation` was created by `StartOrContinueHotReload(null)` and has empty `_consideredFilePaths`, so any batch is absorbed regardless of path overlap. \"intersecting\"...
true
unoplatform/uno
23,425
issue_to_patch
docs: add docs-build validation skill and bump studio-docs pin
**GitHub Issue:** N/A — documentation / tooling change (exempt per template) ## PR Type: 📚 Documentation content changes 🤖 Project automation ## What changed? 🚀 Two related documentation changes: 1. **Bump the `studio-docs` external-docs pin** in `doc/import_external_docs.ps1` (`97f349b` → `3b86af4`) to pull...
69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b
1c5a0f41a9b60e9d28b6dbf108fde9b211a1b386
diff --git a/.claude/skills/docs-build/SKILL.md b/.claude/skills/docs-build/SKILL.md new file mode 100644 index 000000000000..29a55495f780 --- /dev/null +++ b/.claude/skills/docs-build/SKILL.md @@ -0,0 +1,130 @@ +--- +name: docs-build +description: Build, preview, and validate the Uno documentation website (DocFX) loca...
[ ".claude/skills/docs-build/SKILL.md", "AGENTS.md", "doc/import_external_docs.ps1" ]
[ { "comment": "Minor: `-Command` interprets the argument as a PowerShell expression, not a script path. For running a `.ps1` file, `-File` is the correct flag — it properly sets `$PSScriptRoot`, propagates the script's exit code (so the calling shell sees failures), and handles parameters correctly.\n\n```sugges...
true
unoplatform/uno
23,425
comment_to_fix
docs: add docs-build validation skill and bump studio-docs pin
Minor: `-Command` interprets the argument as a PowerShell expression, not a script path. For running a `.ps1` file, `-File` is the correct flag — it properly sets `$PSScriptRoot`, propagates the script's exit code (so the calling shell sees failures), and handles parameters correctly. ```suggestion pwsh -NoProfile -Fi...
69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b
1c5a0f41a9b60e9d28b6dbf108fde9b211a1b386
diff --git a/.claude/skills/docs-build/SKILL.md b/.claude/skills/docs-build/SKILL.md new file mode 100644 index 000000000000..29a55495f780 --- /dev/null +++ b/.claude/skills/docs-build/SKILL.md @@ -0,0 +1,130 @@ +--- +name: docs-build +description: Build, preview, and validate the Uno documentation website (DocFX) loca...
[ ".claude/skills/docs-build/SKILL.md" ]
[ { "comment": "Minor: `-Command` interprets the argument as a PowerShell expression, not a script path. For running a `.ps1` file, `-File` is the correct flag — it properly sets `$PSScriptRoot`, propagates the script's exit code (so the calling shell sees failures), and handles parameters correctly.\n\n```sugges...
true
unoplatform/uno
23,425
comment_to_fix
docs: add docs-build validation skill and bump studio-docs pin
The Playwright example uses `await` at top-level with `require(...)` (CommonJS). This won’t run in Node unless the file is treated as an ES module (top-level await), so the snippet as written will throw a syntax error for most users. Wrap it in an async IIFE (or switch to ESM `import`) and close the browser at the end ...
69ba94c681cb98f183988c5fc1d5c5fe9f8dd47b
1c5a0f41a9b60e9d28b6dbf108fde9b211a1b386
diff --git a/.claude/skills/docs-build/SKILL.md b/.claude/skills/docs-build/SKILL.md new file mode 100644 index 000000000000..29a55495f780 --- /dev/null +++ b/.claude/skills/docs-build/SKILL.md @@ -0,0 +1,130 @@ +--- +name: docs-build +description: Build, preview, and validate the Uno documentation website (DocFX) loca...
[ ".claude/skills/docs-build/SKILL.md" ]
[ { "comment": "The Playwright example uses `await` at top-level with `require(...)` (CommonJS). This won’t run in Node unless the file is treated as an ES module (top-level await), so the snippet as written will throw a syntax error for most users. Wrap it in an async IIFE (or switch to ESM `import`) and close t...
true
unoplatform/uno
23,379
issue_to_patch
chore(deps): bump github/codeql-action from 3 to 4
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3 to 4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/github/codeql-action/releases">github/codeql-action's releases</a>.</em></p> <blockquote> <h2>v3.36.1</h2> <p>No user facing changes.</p> <h2>v3.3...
4357cb7149a935e0ab82e9aefb2d27deafd0359a
0d31c49e11fc4382c0fde34c949ad02d7170003b
diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 194797890d78..e13b8a2b111b 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -93,7 +93,7 @@ jobs: # Initializes the CodeQL tools for scanning. - name: Initialize CodeQL - uses: github/codeql-a...
[ ".github/workflows/codeql.yml", ".github/workflows/scorecard.yml" ]
[]
true
unoplatform/uno
23,386
issue_to_patch
chore(deps): bump lycheeverse/lychee-action from 2.4.1 to 2.8.0
Bumps [lycheeverse/lychee-action](https://github.com/lycheeverse/lychee-action) from 2.4.1 to 2.8.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/lycheeverse/lychee-action/releases">lycheeverse/lychee-action's releases</a>.</em></p> <blockquote> <h2>v2.8.0</h2> <h2>What's C...
4357cb7149a935e0ab82e9aefb2d27deafd0359a
4cf24ca7086e26b6dfd7407d0f4f8121f5f9cf78
diff --git a/.github/workflows/link-validation.yml b/.github/workflows/link-validation.yml index 2e41a13576c1..be334558343b 100644 --- a/.github/workflows/link-validation.yml +++ b/.github/workflows/link-validation.yml @@ -1,4 +1,4 @@ -name: Check Links +name: Check Links on: pull_request: @@ -24,7 +24,7 @@ jobs...
[ ".github/workflows/link-validation.yml" ]
[]
true
unoplatform/uno
23,381
issue_to_patch
chore(deps): bump actions/labeler from 4.3.0 to 6.1.0
Bumps [actions/labeler](https://github.com/actions/labeler) from 4.3.0 to 6.1.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/labeler/releases">actions/labeler's releases</a>.</em></p> <blockquote> <h2>v6.1.0</h2> <h2>Enhancements</h2> <ul> <li>Add changed-files-lab...
4357cb7149a935e0ab82e9aefb2d27deafd0359a
291cd3d3d68f9d39ce38d379b9948938e3925256
diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index 4041b6e5e63b..fd8c1f111222 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -10,7 +10,7 @@ jobs: pull-requests: write runs-on: ubuntu-latest steps: - - uses: actions/labeler@ac9175f8a1f3...
[ ".github/workflows/labeler.yml" ]
[]
true
unoplatform/uno
23,419
issue_to_patch
chore(deps): bump anthropics/claude-code-action from 1.0.134 to 1.0.143
Bumps [anthropics/claude-code-action](https://github.com/anthropics/claude-code-action) from 1.0.134 to 1.0.143. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/anthropics/claude-code-action/releases">anthropics/claude-code-action's releases</a>.</em></p> <blockquote> <h2>v1.0...
dd5b4ffbea35657d2b68f04dea807fd3ce5b2de9
8dc2d85861c42a87aabdf548324dd81c9dd65852
diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml index 8c08bb080252..f9c9948c6228 100644 --- a/.github/workflows/claude-code-review.yml +++ b/.github/workflows/claude-code-review.yml @@ -89,7 +89,7 @@ jobs: # blocks exfil URL patterns (`gh ... view https://attack...
[ ".github/workflows/claude-code-review.yml" ]
[]
true
unoplatform/uno
23,382
issue_to_patch
chore(deps): bump actions/github-script from 6 to 9
Bumps [actions/github-script](https://github.com/actions/github-script) from 6 to 9. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/github-script/releases">actions/github-script's releases</a>.</em></p> <blockquote> <h2>v9.0.0</h2> <p><strong>New features:</strong></p...
4357cb7149a935e0ab82e9aefb2d27deafd0359a
8dd7952ce1048d8e75eb8fc2c15ffaf013f5ad8c
diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml index 4041b6e5e63b..7b0a2479f8a5 100644 --- a/.github/workflows/labeler.yml +++ b/.github/workflows/labeler.yml @@ -14,7 +14,7 @@ jobs: with: repo-token: "${{ secrets.GITHUB_TOKEN }}" - name: Assign PR to its author - u...
[ ".github/workflows/labeler.yml", ".github/workflows/winappsdk-sync-apply.yml", ".github/workflows/winappsdk-sync-check.yml", ".github/workflows/xaml-style-apply.yml", ".github/workflows/xaml-style-check.yml" ]
[]
true
unoplatform/uno
23,383
issue_to_patch
chore(deps): bump actions/upload-artifact from 4 to 7
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 7. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/upload-artifact/releases">actions/upload-artifact's releases</a>.</em></p> <blockquote> <h2>v7.0.0</h2> <h2>v7 What's new</h2> <h3>D...
4357cb7149a935e0ab82e9aefb2d27deafd0359a
1a827f9f406f5a1e951953fe7c07f99d7eb809e8
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index 6b5865ab39aa..163fa2ff6aba 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -60,7 +60,7 @@ jobs: # Upload the results as artifacts (optional). Commenting out will disable uploads of run resul...
[ ".github/workflows/scorecard.yml", ".github/workflows/winappsdk-sync-check.yml", ".github/workflows/xaml-style-check.yml" ]
[]
true
unoplatform/uno
23,384
issue_to_patch
chore(deps): bump peter-evans/create-pull-request from 6.0.5 to 8.1.1
Bumps [peter-evans/create-pull-request](https://github.com/peter-evans/create-pull-request) from 6.0.5 to 8.1.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/peter-evans/create-pull-request/releases">peter-evans/create-pull-request's releases</a>.</em></p> <blockquote> <h2>...
4357cb7149a935e0ab82e9aefb2d27deafd0359a
4489a1e8d56afb8a55b681936d310ab0958f1458
diff --git a/.github/workflows/docs-updater.yml b/.github/workflows/docs-updater.yml index 69adb93f9e05..89e1d2ffd6e2 100644 --- a/.github/workflows/docs-updater.yml +++ b/.github/workflows/docs-updater.yml @@ -52,7 +52,7 @@ jobs: - name: Create Pull Request id: cpr if: steps.docs_update.output...
[ ".github/workflows/docs-updater.yml" ]
[]
true
unoplatform/uno
23,385
issue_to_patch
chore(deps): bump ossf/scorecard-action from 2.3.1 to 2.4.3
Bumps [ossf/scorecard-action](https://github.com/ossf/scorecard-action) from 2.3.1 to 2.4.3. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/ossf/scorecard-action/releases">ossf/scorecard-action's releases</a>.</em></p> <blockquote> <h2>v2.4.3</h2> <h2>What's Changed</h2> <p>T...
4357cb7149a935e0ab82e9aefb2d27deafd0359a
1065a13556d3dd7ac9b5903e067ec9e9f9cb5c66
diff --git a/.github/workflows/scorecard.yml b/.github/workflows/scorecard.yml index 6b5865ab39aa..7c40f1a203b0 100644 --- a/.github/workflows/scorecard.yml +++ b/.github/workflows/scorecard.yml @@ -38,7 +38,7 @@ jobs: persist-credentials: false - name: "Run analysis" - uses: ossf/scorecard-a...
[ ".github/workflows/scorecard.yml" ]
[]
true
unoplatform/uno
23,418
issue_to_patch
chore(deps): bump actions/stale from 9 to 10
Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/actions/stale/releases">actions/stale's releases</a>.</em></p> <blockquote> <h2>v10.0.0</h2> <h2>What's Changed</h2> <h3>Breaking Changes</h3> <ul> <li>Upgrade...
dd5b4ffbea35657d2b68f04dea807fd3ce5b2de9
e1491f72ab6fe93c582d8f9b4871235f1470dd89
diff --git a/.github/workflows/stale-issues.yml b/.github/workflows/stale-issues.yml index 0bba88eb4aa3..71b16d5e772a 100644 --- a/.github/workflows/stale-issues.yml +++ b/.github/workflows/stale-issues.yml @@ -12,7 +12,7 @@ jobs: stale: runs-on: ubuntu-latest steps: - - uses: actions/stale@v9 + ...
[ ".github/workflows/stale-issues.yml", ".github/workflows/stale-prs.yml" ]
[]
true
unoplatform/uno
23,407
issue_to_patch
Hyperlink hover hand
**GitHub Issue:** closes https://github.com/unoplatform/kahua-private/issues/497 <!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal), unless the change is documentation related. --> ## PR Type: <!-- Copy the label that applies to this PR and ...
fb9f2cdd367c323d6846049969cb2fff1178204a
539f7c0de9a29dc2e59b2b598acdf126693d49e6
diff --git a/src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.cs b/src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.cs index 66f8efac6a6c..524d1b920adf 100644 --- a/src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.cs +++ b/src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.cs @@ -50,7 +50,20 @@ public partial class TextBlock...
[ "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs", "src/Uno.UI/UI/Xaml/Controls/TextBlock/TextBlock.cs" ]
[]
diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs index 643ca1278d01..a58a4bf158a6 100644 --- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_TextBlock.cs +++ b/src/Uno.UI.RuntimeTests/Tests/W...
true
unoplatform/uno
23,347
issue_to_patch
Remove the Mac Catalyst (`net*-maccatalyst`) target ## Summary Uno currently multi-targets a Mac Catalyst TFM (`net9.0-maccatalyst18.0` / `net10.0-maccatalyst26.0`) across the framework, add-ins, NuGet packages, CI, and solution templates. This issue proposes **removing the Mac Catalyst target entirely**. ## Motivat...
feat!: Remove the Mac Catalyst target
## Summary - Drops `net*-maccatalyst` end-to-end: TFMs, projects, NuGet packaging, Uno.Sdk plumbing, CI, test scripts, runtime test helpers, source dead branches, solution templates (incl. 5.3 and 5.6 frozen snapshots), and documentation. - **Breaking change** for any consumer currently targeting `net*-maccatalyst` vi...
4990906d88232dfd8dbcf280e305fec9b2272f7e
5f72f831d70f89ed606a4e892546673f25280d2c
diff --git a/.github/workflows/winappsdk-sync-apply.yml b/.github/workflows/winappsdk-sync-apply.yml index d2edcdc5c401..7c6b21b2acaf 100644 --- a/.github/workflows/winappsdk-sync-apply.yml +++ b/.github/workflows/winappsdk-sync-apply.yml @@ -99,7 +99,7 @@ jobs: - name: Install required .NET workloads ...
[ ".github/workflows/winappsdk-sync-apply.yml", ".github/workflows/winappsdk-sync-check.yml", "Directory.Build.props", "build/cSpell.json", "build/ci/build/.azure-devops-build-managed.yml", "build/nuget/Uno.Foundation.nuspec", "build/nuget/Uno.WinRT.nuspec", "build/nuget/Uno.WinUI.DevServer.nuspec", "...
[ { "comment": "This article still has a Catalyst row in the compiler-symbol table above, including `__MACCATALYST__` and “iOS or tvOS or Catalyst” for `__APPLE_UIKIT__`. Since these suffix rules now document iOS/tvOS-only behavior, update the symbol table in the same article as well so the page does not give con...
diff --git a/src/Uno.UI.RuntimeTests/Tests/HotReload/Frame/HRApp/AppHead.xaml.cs b/src/Uno.UI.RuntimeTests/Tests/HotReload/Frame/HRApp/AppHead.xaml.cs index 1a685c6d6e25..43d82a3e3e1b 100644 --- a/src/Uno.UI.RuntimeTests/Tests/HotReload/Frame/HRApp/AppHead.xaml.cs +++ b/src/Uno.UI.RuntimeTests/Tests/HotReload/Frame/HRA...
true
unoplatform/uno
23,347
comment_to_fix
feat!: Remove the Mac Catalyst target
This article still has a Catalyst row in the compiler-symbol table above, including `__MACCATALYST__` and “iOS or tvOS or Catalyst” for `__APPLE_UIKIT__`. Since these suffix rules now document iOS/tvOS-only behavior, update the symbol table in the same article as well so the page does not give contradictory guidance af...
4990906d88232dfd8dbcf280e305fec9b2272f7e
5f72f831d70f89ed606a4e892546673f25280d2c
diff --git a/doc/articles/platform-specific-csharp.md b/doc/articles/platform-specific-csharp.md index 1360cb00d7de..6e83ae64b1fa 100644 --- a/doc/articles/platform-specific-csharp.md +++ b/doc/articles/platform-specific-csharp.md @@ -57,8 +57,7 @@ The following conditional symbols are predefined for each Uno platform:...
[ "doc/articles/platform-specific-csharp.md" ]
[ { "comment": "This article still has a Catalyst row in the compiler-symbol table above, including `__MACCATALYST__` and “iOS or tvOS or Catalyst” for `__APPLE_UIKIT__`. Since these suffix rules now document iOS/tvOS-only behavior, update the symbol table in the same article as well so the page does not give con...
true
unoplatform/uno
23,347
comment_to_fix
feat!: Remove the Mac Catalyst target
After removing the Mac Catalyst runtime identifier here, the `Uno.UI.Runtime.Skia.AppleUIKit` package metadata still advertises “Skia Apple iOS, Mac Catalyst, and tvOS” in its NuGet description. Please update that description to avoid publishing a package that appears to support a target this PR removes.
4990906d88232dfd8dbcf280e305fec9b2272f7e
5f72f831d70f89ed606a4e892546673f25280d2c
diff --git a/src/Uno.UI.Runtime.Skia.AppleUIKit/build/Uno.WinUI.Runtime.Skia.AppleUIKit.props b/src/Uno.UI.Runtime.Skia.AppleUIKit/build/Uno.WinUI.Runtime.Skia.AppleUIKit.props index 12ec79a1e8f8..76da10a4d0f1 100644 --- a/src/Uno.UI.Runtime.Skia.AppleUIKit/build/Uno.WinUI.Runtime.Skia.AppleUIKit.props +++ b/src/Uno.UI...
[ "src/Uno.UI.Runtime.Skia.AppleUIKit/build/Uno.WinUI.Runtime.Skia.AppleUIKit.props" ]
[ { "comment": "After removing the Mac Catalyst runtime identifier here, the `Uno.UI.Runtime.Skia.AppleUIKit` package metadata still advertises “Skia Apple iOS, Mac Catalyst, and tvOS” in its NuGet description. Please update that description to avoid publishing a package that appears to support a target this PR r...
true
unoplatform/uno
23,347
comment_to_fix
feat!: Remove the Mac Catalyst target
The comment says "Flaky on iOS native and iOS Skia" but `NativeWasm` is now also excluded with no explanation. Please update the comment to mention why WASM native is being excluded, or file a tracking issue for it — otherwise the exclusion is untracked and won't be revisited.
4990906d88232dfd8dbcf280e305fec9b2272f7e
5f72f831d70f89ed606a4e892546673f25280d2c
diff --git a/src/Uno.UI.RuntimeTests/IntegrationTests/dxaml/controls/commandbar/CommandBarIntegrationTests.cs b/src/Uno.UI.RuntimeTests/IntegrationTests/dxaml/controls/commandbar/CommandBarIntegrationTests.cs index f5675e71611f..9819557a0186 100644 --- a/src/Uno.UI.RuntimeTests/IntegrationTests/dxaml/controls/commandba...
[ "src/Uno.UI.RuntimeTests/IntegrationTests/dxaml/controls/commandbar/CommandBarIntegrationTests.cs" ]
[ { "comment": "The comment says \"Flaky on iOS native and iOS Skia\" but `NativeWasm` is now also excluded with no explanation. Please update the comment to mention why WASM native is being excluded, or file a tracking issue for it — otherwise the exclusion is untracked and won't be revisited.", "path": "src...
true
unoplatform/uno
23,347
comment_to_fix
feat!: Remove the Mac Catalyst target
These three tests are now skipped on **all** native platforms (`NativeWinUI`, `NativeWasm`, `NativeAndroid`, `NativeIOS`, `NativeTvOS`) — a broad blanket exclusion that silently removes test coverage everywhere except Skia. Per AGENTS.md, guard-only changes aren't a complete resolution. Please either: 1. Narrow the ex...
4990906d88232dfd8dbcf280e305fec9b2272f7e
5f72f831d70f89ed606a4e892546673f25280d2c
diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_CheckBox_ThemeResource_Regression.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_CheckBox_ThemeResource_Regression.cs index b3150101005a..9f67f9b41733 100644 --- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Ch...
[ "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_CheckBox_ThemeResource_Regression.cs" ]
[ { "comment": "These three tests are now skipped on **all** native platforms (`NativeWinUI`, `NativeWasm`, `NativeAndroid`, `NativeIOS`, `NativeTvOS`) — a broad blanket exclusion that silently removes test coverage everywhere except Skia. Per AGENTS.md, guard-only changes aren't a complete resolution.\n\nPlease ...
true
unoplatform/uno
23,347
comment_to_fix
feat!: Remove the Mac Catalyst target
Same concern as in `Given_CheckBox_ThemeResource_Regression.cs`: blanket `RuntimeTestPlatforms.Native` exclusion with no comment or issue link explaining which platform actually fails and why. Please narrow the exclusion or add a tracking reference so these skips are revisited.
4990906d88232dfd8dbcf280e305fec9b2272f7e
5f72f831d70f89ed606a4e892546673f25280d2c
diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_CommandBarFlyout.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_CommandBarFlyout.cs index ac5ad4284487..c8db4a3b590c 100644 --- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_CommandBarFlyout.cs +++ b/src/Uno.UI...
[ "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_CommandBarFlyout.cs" ]
[ { "comment": "Same concern as in `Given_CheckBox_ThemeResource_Regression.cs`: blanket `RuntimeTestPlatforms.Native` exclusion with no comment or issue link explaining which platform actually fails and why. Please narrow the exclusion or add a tracking reference so these skips are revisited.", "path": "src/...
true
unoplatform/uno
23,347
comment_to_fix
feat!: Remove the Mac Catalyst target
Same concern as other theming tests in this PR: `RuntimeTestPlatforms.Native` is a very broad exclusion (all 5 native platforms). Please narrow to the failing platform(s) and link to a tracking issue, so the coverage gap can be resolved.
4990906d88232dfd8dbcf280e305fec9b2272f7e
5f72f831d70f89ed606a4e892546673f25280d2c
diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_MenuFlyout.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_MenuFlyout.cs index d568bc73624f..822db077cd80 100644 --- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_MenuFlyout.cs +++ b/src/Uno.UI.RuntimeTests/Test...
[ "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_MenuFlyout.cs" ]
[ { "comment": "Same concern as other theming tests in this PR: `RuntimeTestPlatforms.Native` is a very broad exclusion (all 5 native platforms). Please narrow to the failing platform(s) and link to a tracking issue, so the coverage gap can be resolved.", "path": "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml...
true
unoplatform/uno
23,347
comment_to_fix
feat!: Remove the Mac Catalyst target
there are still 2 more instances of this comment left in the repo, should probably apply the same
4990906d88232dfd8dbcf280e305fec9b2272f7e
5f72f831d70f89ed606a4e892546673f25280d2c
diff --git a/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj b/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj index 2ab81c428e11..f34cb7b39ee0 100644 --- a/src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj +++ b/src/SamplesApp/SamplesApp.netcoremobi...
[ "src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj" ]
[ { "comment": "there are still 2 more instances of this comment left in the repo, should probably apply the same", "path": "src/SamplesApp/SamplesApp.netcoremobile/SamplesApp.netcoremobile.csproj", "hunk": "@@ -17,21 +17,12 @@\n \n \t\t<RuntimeIdentifier Condition=\"$([MSBuild]::GetTargetPlatformIdentifi...
true
unoplatform/uno
23,347
comment_to_fix
feat!: Remove the Mac Catalyst target
`IsIOSOrCatalyst` not sure if already done, but we need to document this in the migration doc
4990906d88232dfd8dbcf280e305fec9b2272f7e
5f72f831d70f89ed606a4e892546673f25280d2c
diff --git a/src/Uno.Sdk/targets/Uno.IsPlatform.Before.props b/src/Uno.Sdk/targets/Uno.IsPlatform.Before.props index 5b4522462e05..cc641974b9c6 100644 --- a/src/Uno.Sdk/targets/Uno.IsPlatform.Before.props +++ b/src/Uno.Sdk/targets/Uno.IsPlatform.Before.props @@ -2,8 +2,6 @@ <PropertyGroup> <IsAndroid>false</IsAndr...
[ "src/Uno.Sdk/targets/Uno.IsPlatform.Before.props" ]
[ { "comment": "`IsIOSOrCatalyst` not sure if already done, but we need to document this in the migration doc", "path": "src/Uno.Sdk/targets/Uno.IsPlatform.Before.props", "hunk": "@@ -2,8 +2,6 @@\n \t<PropertyGroup>\n \t\t<IsAndroid>false</IsAndroid>\n \t\t<IsIOS>false</IsIOS>\n-\t\t<IsMacCatalyst>false</...
true
unoplatform/uno
23,347
comment_to_fix
feat!: Remove the Mac Catalyst target
The `helpUrl` that previously pointed to the Mac Catalyst MAUI sample was correctly removed, but the property is still opaque to users without context. Since this property now applies exclusively to iOS builds (it guards `MtouchExtraArgs` in `xamarin-ios-workarounds.targets`), the description could be made more actiona...
4990906d88232dfd8dbcf280e305fec9b2272f7e
5f72f831d70f89ed606a4e892546673f25280d2c
diff --git a/src/Uno.Sdk/Sdk/Sdk.props.buildschema.json b/src/Uno.Sdk/Sdk/Sdk.props.buildschema.json index c075191e4069..cf63ed7f273e 100644 --- a/src/Uno.Sdk/Sdk/Sdk.props.buildschema.json +++ b/src/Uno.Sdk/Sdk/Sdk.props.buildschema.json @@ -59,11 +59,7 @@ }, "tvOSProjectFolder": { "type": "folder-with-slash...
[ "src/Uno.Sdk/Sdk/Sdk.props.buildschema.json" ]
[ { "comment": "The `helpUrl` that previously pointed to the Mac Catalyst MAUI sample was correctly removed, but the property is still opaque to users without context. Since this property now applies exclusively to iOS builds (it guards `MtouchExtraArgs` in `xamarin-ios-workarounds.targets`), the description coul...
true
unoplatform/uno
23,347
comment_to_fix
feat!: Remove the Mac Catalyst target
The comment above (lines 19–23) says "Uno renders nothing on Skia", yet the test assertion on line 65 requires `flipView.ActualHeight > 0`, and `[PlatformCondition(ConditionMode.Exclude, RuntimeTestPlatforms.Native)]` leaves the test running on **all Skia targets** (SkiaWin32, X11, MacOS, etc.). If the Skia behavior is...
4990906d88232dfd8dbcf280e305fec9b2272f7e
5f72f831d70f89ed606a4e892546673f25280d2c
diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_FlipView.StackPanelItemsPanel_13944.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_FlipView.StackPanelItemsPanel_13944.cs index 40ef09a94ad9..ff1812e2bce9 100644 --- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Give...
[ "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_FlipView.StackPanelItemsPanel_13944.cs" ]
[ { "comment": "The comment above (lines 19–23) says \"Uno renders nothing on Skia\", yet the test assertion on line 65 requires `flipView.ActualHeight > 0`, and `[PlatformCondition(ConditionMode.Exclude, RuntimeTestPlatforms.Native)]` leaves the test running on **all Skia targets** (SkiaWin32, X11, MacOS, etc.)....
true
unoplatform/uno
23,347
comment_to_fix
feat!: Remove the Mac Catalyst target
Two concerns with this exclusion: 1. **No rationale comment** — every other native exclusion added in this PR (theming tests, `ValidateOverflowScrollViewerDoesNotScrollWithArrowKeys`) carries an inline comment explaining *why*. This one does not, which breaks the pattern and leaves the skip untracked. 2. **Contradict...
4990906d88232dfd8dbcf280e305fec9b2272f7e
5f72f831d70f89ed606a4e892546673f25280d2c
diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_FlipView.StackPanelItemsPanel_13944.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_FlipView.StackPanelItemsPanel_13944.cs index 40ef09a94ad9..ff1812e2bce9 100644 --- a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Give...
[ "src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_FlipView.StackPanelItemsPanel_13944.cs" ]
[ { "comment": "Two concerns with this exclusion:\n\n1. **No rationale comment** — every other native exclusion added in this PR (theming tests, `ValidateOverflowScrollViewerDoesNotScrollWithArrowKeys`) carries an inline comment explaining *why*. This one does not, which breaks the pattern and leaves the skip unt...
true
unoplatform/uno
23,387
issue_to_patch
docs: update for studio
**GitHub Issue:** closes # <!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal), unless the change is documentation related. --> ## PR Type: <!-- Copy the label that applies to this PR and paste it above: 🐞 Bugfix ✨ Feature 🎨 Code style update (fo...
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/.gitignore b/.gitignore index fe47e2f57738..935c889dbca9 100644 --- a/.gitignore +++ b/.gitignore @@ -266,6 +266,9 @@ src/AddIns/Uno.UI.MSAL/WasmScripts/*.d.ts # external docs doc/articles/external +# imported at build time from unoplatform/hd-docs (see doc/import_external_docs.ps1) +doc/articles/studi...
[ ".gitignore", "build/cSpell.json", "doc/articles/concepts/overview/philosophy-of-uno.md", "doc/articles/concepts/overview/why-uno-platform.md", "doc/articles/faq.md", "doc/articles/get-started-licensing.md", "doc/articles/intro.md", "doc/articles/studio/Assets/Introducing-Uno-Platform-Studio.png", "...
[ { "comment": "The TOC adds entries for `studio/App/toc.yml` and `studio/Agent/toc.yml`, but those paths do not exist under `doc/articles/studio/` in this branch. This will create broken links (and may fail DocFX validation, depending on build settings). Either add the missing TOCs/pages, or remove/comment-out t...
diff --git a/doc/import_external_docs_test.ps1 b/doc/import_external_docs_test.ps1 index c21fc6cd0cf4..a84a1e116602 100644 --- a/doc/import_external_docs_test.ps1 +++ b/doc/import_external_docs_test.ps1 @@ -31,6 +31,7 @@ if (-not $NoFetch) { "uno.samples" = "master" "uno.chefs" = "main...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
The TOC adds entries for `studio/App/toc.yml` and `studio/Agent/toc.yml`, but those paths do not exist under `doc/articles/studio/` in this branch. This will create broken links (and may fail DocFX validation, depending on build settings). Either add the missing TOCs/pages, or remove/comment-out these entries until the...
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/toc.yml b/doc/articles/toc.yml index 80920622b173..9ecc6bd7669c 100644 --- a/doc/articles/toc.yml +++ b/doc/articles/toc.yml @@ -465,10 +465,14 @@ - name: FAQ href: xref:Uno.Development.FAQ -- name: Studio +- name: Uno Platform Studio items: - name: Overview href: ...
[ "doc/articles/toc.yml" ]
[ { "comment": "The TOC adds entries for `studio/App/toc.yml` and `studio/Agent/toc.yml`, but those paths do not exist under `doc/articles/studio/` in this branch. This will create broken links (and may fail DocFX validation, depending on build settings). Either add the missing TOCs/pages, or remove/comment-out t...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
These new `xref:` links reference `Uno.PlatformStudio.*`, but there are no corresponding `uid:` entries in this repo (and no other references to that UID namespace). As-is, DocFX will likely emit unresolved xref warnings/errors and the links will be broken. Please either add the new pages with matching `uid`s, or updat...
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-overview.md b/doc/articles/studio/studio-overview.md index d519c8094361..b2bd599928ef 100644 --- a/doc/articles/studio/studio-overview.md +++ b/doc/articles/studio/studio-overview.md @@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview # Uno Platform Studio Overview -**Uno Pl...
[ "doc/articles/studio/studio-overview.md" ]
[ { "comment": "These new `xref:` links reference `Uno.PlatformStudio.*`, but there are no corresponding `uid:` entries in this repo (and no other references to that UID namespace). As-is, DocFX will likely emit unresolved xref warnings/errors and the links will be broken. Please either add the new pages with mat...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
The page calls out "Uno Platform Studio 3.0" as the current "New in" version, but other docs in this repo still describe the latest as "Uno Platform Studio 2.0" (e.g., `doc/articles/concepts/overview/philosophy-of-uno.md`). If this PR is intentionally bumping the version branding, consider making this heading version-a...
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-overview.md b/doc/articles/studio/studio-overview.md index d519c8094361..b2bd599928ef 100644 --- a/doc/articles/studio/studio-overview.md +++ b/doc/articles/studio/studio-overview.md @@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview # Uno Platform Studio Overview -**Uno Pl...
[ "doc/articles/studio/studio-overview.md" ]
[ { "comment": "The page calls out \"Uno Platform Studio 3.0\" as the current \"New in\" version, but other docs in this repo still describe the latest as \"Uno Platform Studio 2.0\" (e.g., `doc/articles/concepts/overview/philosophy-of-uno.md`). If this PR is intentionally bumping the version branding, consider m...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
The Studio section links to `external/studio-docs/App/toc.yml` and `external/studio-docs/Agent/toc.yml`, but the referenced `studio-docs` repository (at the pinned commit) only provides a single root `toc.yml` and does not contain `App/` or `Agent/` subfolders. This will break the doc build/navigation unless those toc ...
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/toc.yml b/doc/articles/toc.yml index 80920622b173..9ecc6bd7669c 100644 --- a/doc/articles/toc.yml +++ b/doc/articles/toc.yml @@ -465,10 +465,14 @@ - name: FAQ href: xref:Uno.Development.FAQ -- name: Studio +- name: Uno Platform Studio items: - name: Overview href: ...
[ "doc/articles/toc.yml" ]
[ { "comment": "The Studio section links to `external/studio-docs/App/toc.yml` and `external/studio-docs/Agent/toc.yml`, but the referenced `studio-docs` repository (at the pinned commit) only provides a single root `toc.yml` and does not contain `App/` or `Agent/` subfolders. This will break the doc build/naviga...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
The TOC links for Studio currently point to `external/studio-docs/App/toc.yml` and `external/studio-docs/Agent/toc.yml`, but the pinned `unoplatform/studio-docs` commit (5253bed...) does not contain `App/` or `Agent/` directories/tocs. This will produce broken links / doc build failures once the external docs are impor...
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/toc.yml b/doc/articles/toc.yml index 80920622b173..9ecc6bd7669c 100644 --- a/doc/articles/toc.yml +++ b/doc/articles/toc.yml @@ -465,10 +465,14 @@ - name: FAQ href: xref:Uno.Development.FAQ -- name: Studio +- name: Uno Platform Studio items: - name: Overview href: ...
[ "doc/articles/toc.yml" ]
[ { "comment": "The TOC links for Studio currently point to `external/studio-docs/App/toc.yml` and `external/studio-docs/Agent/toc.yml`, but the pinned `unoplatform/studio-docs` commit (5253bed...) does not contain `App/` or `Agent/` directories/tocs. This will produce broken links / doc build failures once the e...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
The PR description currently contains `closes #` without an issue number/link. Either add the correct issue URL (preferred) or remove the `closes` footer if this docs-only change is intentionally not tied to an issue, to avoid invalid auto-closing behavior.
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/import_external_docs.ps1 b/doc/import_external_docs.ps1 index 007afa9481ec..4184cec291da 100644 --- a/doc/import_external_docs.ps1 +++ b/doc/import_external_docs.ps1 @@ -23,6 +23,7 @@ $external_docs = @{ "uno.samples" = @{ ref="1d9ea60a7aec335e1d034446c631b93f605f06b8" } #latest master com...
[ "doc/import_external_docs.ps1" ]
[ { "comment": "The PR description currently contains `closes #` without an issue number/link. Either add the correct issue URL (preferred) or remove the `closes` footer if this docs-only change is intentionally not tied to an issue, to avoid invalid auto-closing behavior.", "path": "doc/import_external_docs....
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
The new xref targets `Uno.PlatformStudio.GetStarted` and `Uno.PlatformStudio.Skills` don’t match the existing Studio UID naming pattern used elsewhere in this repo (e.g., `uid: Uno.Platform.Studio.*`) and there are no matching `uid: Uno.PlatformStudio.*` pages in the current documentation set. If the intent is to link ...
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-overview.md b/doc/articles/studio/studio-overview.md index d519c8094361..b2bd599928ef 100644 --- a/doc/articles/studio/studio-overview.md +++ b/doc/articles/studio/studio-overview.md @@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview # Uno Platform Studio Overview -**Uno Pl...
[ "doc/articles/studio/studio-overview.md" ]
[ { "comment": "The new xref targets `Uno.PlatformStudio.GetStarted` and `Uno.PlatformStudio.Skills` don’t match the existing Studio UID naming pattern used elsewhere in this repo (e.g., `uid: Uno.Platform.Studio.*`) and there are no matching `uid: Uno.PlatformStudio.*` pages in the current documentation set. If ...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
No need to date it with 3.0 - here or elsewhere
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-overview.md b/doc/articles/studio/studio-overview.md index d519c8094361..b2bd599928ef 100644 --- a/doc/articles/studio/studio-overview.md +++ b/doc/articles/studio/studio-overview.md @@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview # Uno Platform Studio Overview -**Uno Pl...
[ "doc/articles/studio/studio-overview.md" ]
[ { "comment": "No need to date it with 3.0 - here or elsewhere", "path": "doc/articles/studio/studio-overview.md", "hunk": "@@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview\n \n # Uno Platform Studio Overview\n \n-**Uno Platform Studio** is a set of productivity tools designed to enhance developer pro...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
Currently it is a browser-based app; add remark that mobile and desktop application are coming
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-overview.md b/doc/articles/studio/studio-overview.md index d519c8094361..b2bd599928ef 100644 --- a/doc/articles/studio/studio-overview.md +++ b/doc/articles/studio/studio-overview.md @@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview # Uno Platform Studio Overview -**Uno Pl...
[ "doc/articles/studio/studio-overview.md" ]
[ { "comment": "Currently it is a browser-based app; add remark that mobile and desktop application are coming", "path": "doc/articles/studio/studio-overview.md", "hunk": "@@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview\n \n # Uno Platform Studio Overview\n \n-**Uno Platform Studio** is a set of produ...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
Industry-first, patented,
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-overview.md b/doc/articles/studio/studio-overview.md index d519c8094361..b2bd599928ef 100644 --- a/doc/articles/studio/studio-overview.md +++ b/doc/articles/studio/studio-overview.md @@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview # Uno Platform Studio Overview -**Uno Pl...
[ "doc/articles/studio/studio-overview.md" ]
[ { "comment": "Industry-first, patented, ", "path": "doc/articles/studio/studio-overview.md", "hunk": "@@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview\n \n # Uno Platform Studio Overview\n \n-**Uno Platform Studio** is a set of productivity tools designed to enhance developer productivity, be it for ...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
Grammar: "lets you to go" should be "lets you go".
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-overview.md b/doc/articles/studio/studio-overview.md index d519c8094361..b2bd599928ef 100644 --- a/doc/articles/studio/studio-overview.md +++ b/doc/articles/studio/studio-overview.md @@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview # Uno Platform Studio Overview -**Uno Pl...
[ "doc/articles/studio/studio-overview.md" ]
[ { "comment": "Grammar: \"lets you to go\" should be \"lets you go\".", "path": "doc/articles/studio/studio-overview.md", "hunk": "@@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview\n \n # Uno Platform Studio Overview\n \n-**Uno Platform Studio** is a set of productivity tools designed to enhance develo...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
Wording is ungrammatical: "so it is where to report issues" reads awkwardly; consider "so it is the place to report issues".
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-feedback.md b/doc/articles/studio/studio-feedback.md index 21e96b221042..e8783d75a156 100644 --- a/doc/articles/studio/studio-feedback.md +++ b/doc/articles/studio/studio-feedback.md @@ -4,7 +4,7 @@ uid: Uno.Platform.Studio.Feedback # Providing Feedback for Uno Platform Studio...
[ "doc/articles/studio/studio-feedback.md" ]
[ { "comment": "Wording is ungrammatical: \"so it is where to report issues\" reads awkwardly; consider \"so it is the place to report issues\".", "path": "doc/articles/studio/studio-feedback.md", "hunk": "@@ -24,9 +24,22 @@ Navigate to the [Uno Platform Studio GitHub repository](https://github.com/unopl\...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
Grammar: “lets you to go …” should be “lets you go …”.
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-overview.md b/doc/articles/studio/studio-overview.md index d519c8094361..b2bd599928ef 100644 --- a/doc/articles/studio/studio-overview.md +++ b/doc/articles/studio/studio-overview.md @@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview # Uno Platform Studio Overview -**Uno Pl...
[ "doc/articles/studio/studio-overview.md" ]
[ { "comment": "Grammar: “lets you to go …” should be “lets you go …”.", "path": "doc/articles/studio/studio-overview.md", "hunk": "@@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview\n \n # Uno Platform Studio Overview\n \n-**Uno Platform Studio** is a set of productivity tools designed to enhance develo...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
This sentence is ungrammatical/awkward (“so it is where to report issues…”). Consider rephrasing to make it clear this repo is the place to report Agent issues.
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-feedback.md b/doc/articles/studio/studio-feedback.md index 21e96b221042..e8783d75a156 100644 --- a/doc/articles/studio/studio-feedback.md +++ b/doc/articles/studio/studio-feedback.md @@ -4,7 +4,7 @@ uid: Uno.Platform.Studio.Feedback # Providing Feedback for Uno Platform Studio...
[ "doc/articles/studio/studio-feedback.md" ]
[ { "comment": "This sentence is ungrammatical/awkward (“so it is where to report issues…”). Consider rephrasing to make it clear this repo is the place to report Agent issues.", "path": "doc/articles/studio/studio-feedback.md", "hunk": "@@ -24,9 +24,22 @@ Navigate to the [Uno Platform Studio GitHub repos...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
There are multiple consecutive blank lines here, which violates markdownlint rule MD012 (enabled in build/.markdownlint.json) and can fail the docs lint step. Remove one of the extra blank lines.
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-feedback.md b/doc/articles/studio/studio-feedback.md index 21e96b221042..e8783d75a156 100644 --- a/doc/articles/studio/studio-feedback.md +++ b/doc/articles/studio/studio-feedback.md @@ -4,7 +4,7 @@ uid: Uno.Platform.Studio.Feedback # Providing Feedback for Uno Platform Studio...
[ "doc/articles/studio/studio-feedback.md" ]
[ { "comment": "There are multiple consecutive blank lines here, which violates markdownlint rule MD012 (enabled in build/.markdownlint.json) and can fail the docs lint step. Remove one of the extra blank lines.", "path": "doc/articles/studio/studio-feedback.md", "hunk": "@@ -43,9 +56,7 @@ Follow these st...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
Grammar: "lets you to go" should be "lets you go".
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-overview.md b/doc/articles/studio/studio-overview.md index d519c8094361..b2bd599928ef 100644 --- a/doc/articles/studio/studio-overview.md +++ b/doc/articles/studio/studio-overview.md @@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview # Uno Platform Studio Overview -**Uno Pl...
[ "doc/articles/studio/studio-overview.md" ]
[ { "comment": "Grammar: \"lets you to go\" should be \"lets you go\".", "path": "doc/articles/studio/studio-overview.md", "hunk": "@@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview\n \n # Uno Platform Studio Overview\n \n-**Uno Platform Studio** is a set of productivity tools designed to enhance develo...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
Wording is ungrammatical ("so it is where to report issues"). Consider rephrasing to clearly state that this is the place to report Agent issues when used from other tools.
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-feedback.md b/doc/articles/studio/studio-feedback.md index 21e96b221042..e8783d75a156 100644 --- a/doc/articles/studio/studio-feedback.md +++ b/doc/articles/studio/studio-feedback.md @@ -4,7 +4,7 @@ uid: Uno.Platform.Studio.Feedback # Providing Feedback for Uno Platform Studio...
[ "doc/articles/studio/studio-feedback.md" ]
[ { "comment": "Wording is ungrammatical (\"so it is where to report issues\"). Consider rephrasing to clearly state that this is the place to report Agent issues when used from other tools.", "path": "doc/articles/studio/studio-feedback.md", "hunk": "@@ -24,9 +24,22 @@ Navigate to the [Uno Platform Studi...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
The `studio-docs` ref is pinned to `5253bed...` but the surrounding changes (e.g., `external/studio-docs/App/toc.yml`, `external/studio-docs/Agent/toc.yml`, and xrefs like `Uno.PlatformStudio.Agent` / `Uno.PlatformStudio.Troubleshooting`) require a newer `studio-docs` commit where those paths/uids exist. With the curre...
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/import_external_docs.ps1 b/doc/import_external_docs.ps1 index 007afa9481ec..4184cec291da 100644 --- a/doc/import_external_docs.ps1 +++ b/doc/import_external_docs.ps1 @@ -23,6 +23,7 @@ $external_docs = @{ "uno.samples" = @{ ref="1d9ea60a7aec335e1d034446c631b93f605f06b8" } #latest master com...
[ "doc/import_external_docs.ps1" ]
[ { "comment": "The `studio-docs` ref is pinned to `5253bed...` but the surrounding changes (e.g., `external/studio-docs/App/toc.yml`, `external/studio-docs/Agent/toc.yml`, and xrefs like `Uno.PlatformStudio.Agent` / `Uno.PlatformStudio.Troubleshooting`) require a newer `studio-docs` commit where those paths/uids...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
The “from … to …” construction is ungrammatical here (“from … and …, to … and …”) and makes the sentence hard to parse. Consider rewriting as a simple list (e.g., using an em-dash list) while keeping the same meaning.
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-overview.md b/doc/articles/studio/studio-overview.md index d519c8094361..b2bd599928ef 100644 --- a/doc/articles/studio/studio-overview.md +++ b/doc/articles/studio/studio-overview.md @@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview # Uno Platform Studio Overview -**Uno Pl...
[ "doc/articles/studio/studio-overview.md" ]
[ { "comment": "The “from … to …” construction is ungrammatical here (“from … and …, to … and …”) and makes the sentence hard to parse. Consider rewriting as a simple list (e.g., using an em-dash list) while keeping the same meaning.", "path": "doc/articles/studio/studio-overview.md", "hunk": "@@ -4,38 +4...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
There are unnecessary commas in this sentence (“designer, for …”), which reads like a typo and breaks the flow. Removing the extra comma(s) fixes the grammar without changing meaning.
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-overview.md b/doc/articles/studio/studio-overview.md index d519c8094361..b2bd599928ef 100644 --- a/doc/articles/studio/studio-overview.md +++ b/doc/articles/studio/studio-overview.md @@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview # Uno Platform Studio Overview -**Uno Pl...
[ "doc/articles/studio/studio-overview.md" ]
[ { "comment": "There are unnecessary commas in this sentence (“designer, for …”), which reads like a typo and breaks the flow. Removing the extra comma(s) fixes the grammar without changing meaning.", "path": "doc/articles/studio/studio-overview.md", "hunk": "@@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Ov...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
There’s an extra comma in “cross-platform, Uno Platform app”, which reads as a grammatical typo. Remove the comma so the phrase is “cross-platform Uno Platform app”.
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/studio/studio-overview.md b/doc/articles/studio/studio-overview.md index d519c8094361..b2bd599928ef 100644 --- a/doc/articles/studio/studio-overview.md +++ b/doc/articles/studio/studio-overview.md @@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview # Uno Platform Studio Overview -**Uno Pl...
[ "doc/articles/studio/studio-overview.md" ]
[ { "comment": "There’s an extra comma in “cross-platform, Uno Platform app”, which reads as a grammatical typo. Remove the comma so the phrase is “cross-platform Uno Platform app”.", "path": "doc/articles/studio/studio-overview.md", "hunk": "@@ -4,38 +4,58 @@ uid: Uno.Platform.Studio.Overview\n \n # Uno ...
true
unoplatform/uno
23,387
comment_to_fix
docs: update for studio
`uno-check` is a command name and is typically formatted as inline code elsewhere in the docs (e.g., doc/articles/uno-builds-troubleshooting.md:7). Consider formatting it as `uno-check` here for consistency/readability.
374e3a33b00f0cc298c553ffac9a81d661a29ae6
3ee2b4fab031ec422d78b6442c7622a3a86c4731
diff --git a/doc/articles/concepts/overview/philosophy-of-uno.md b/doc/articles/concepts/overview/philosophy-of-uno.md index b068cb3dd660..8c3b0340725a 100644 --- a/doc/articles/concepts/overview/philosophy-of-uno.md +++ b/doc/articles/concepts/overview/philosophy-of-uno.md @@ -24,22 +24,23 @@ Uno Platform is built on ...
[ "doc/articles/concepts/overview/philosophy-of-uno.md" ]
[ { "comment": "`uno-check` is a command name and is typically formatted as inline code elsewhere in the docs (e.g., doc/articles/uno-builds-troubleshooting.md:7). Consider formatting it as `uno-check` here for consistency/readability.", "path": "doc/articles/concepts/overview/philosophy-of-uno.md", "hunk...
true
unoplatform/uno
23,261
issue_to_patch
Drop support for the WPF targets ## Summary This issue tracks the removal of the **WPF target** (`Uno.WinUI.Skia.Wpf` / `Uno.WinUI.Runtime.Skia.Wpf`) and the **WPF Islands** feature (`Uno.WinUI.XamlHost.Skia.Wpf`) from Uno Platform. This is an **intentional breaking change**. The WPF-based Skia desktop runtime is be...
feat!: Drop WPF targets
**GitHub Issue:** closes #23260 ## PR Type: ✨ Feature ## What changed? 🚀 Completely removes the WPF-based Skia desktop runtime (`Uno.WinUI.Skia.Wpf` / `Uno.WinUI.Runtime.Skia.Wpf`) and the WPF Islands hosting control (`Uno.WinUI.XamlHost.Skia.Wpf`). These have been superseded by the native Skia Desktop runtimes (`...
c225e62911ab60986fd5a933d4b29e1cdc61d5a7
437ed852e3d03e267a6f4ff02faff71d83a24990
diff --git a/.github/labeler.yml b/.github/labeler.yml index 39bc5f5ea4e9..1e4c778cce36 100644 --- a/.github/labeler.yml +++ b/.github/labeler.yml @@ -32,14 +32,10 @@ area/skia ✏️: - src/Uno.UI.Runtime.Skia.Linux.FrameBuffer/**/* - src/Uno.UI.Runtime.Skia.Tizen/* - src/Uno.UI.Runtime.Skia.Tizen/**/* - - src/U...
[ ".github/labeler.yml", "Directory.Build.props", "build/PackageDiffIgnore.xml", "build/Uno.UI.Build.csproj", "build/ci/build/.azure-devops-build-native.yml", "build/ci/tests/.azure-devops-tests-skia-build.yml", "build/ci/tests/.azure-devops-tests-windows-skia.yml", "build/filters/Uno.UI-packages-all.sl...
[ { "comment": "`Microsoft.Web.WebView2` is referenced from code in this project (e.g., `Program.cs` uses `Microsoft.Web.WebView2.Core.CoreWebView2`), but this `PackageReference` sets a non-`global` assembly alias (`Aliases=\"MsWebView2\"`). With an alias set, the WebView2 assemblies won't be available in the glo...
diff --git a/build/ci/tests/.azure-devops-tests-skia-build.yml b/build/ci/tests/.azure-devops-tests-skia-build.yml index a4ddadb1d848..002f3813d6ab 100644 --- a/build/ci/tests/.azure-devops-tests-skia-build.yml +++ b/build/ci/tests/.azure-devops-tests-skia-build.yml @@ -41,9 +41,6 @@ jobs: artifact: native-asset...
true
unoplatform/uno
23,261
comment_to_fix
feat!: Drop WPF targets
`Microsoft.Web.WebView2` is referenced from code in this project (e.g., `Program.cs` uses `Microsoft.Web.WebView2.Core.CoreWebView2`), but this `PackageReference` sets a non-`global` assembly alias (`Aliases="MsWebView2"`). With an alias set, the WebView2 assemblies won't be available in the global namespace, which wil...
c225e62911ab60986fd5a933d4b29e1cdc61d5a7
437ed852e3d03e267a6f4ff02faff71d83a24990
diff --git a/src/SamplesApp/SamplesApp.Skia.Generic/SamplesApp.Skia.Generic.csproj b/src/SamplesApp/SamplesApp.Skia.Generic/SamplesApp.Skia.Generic.csproj index e0510b81a17a..e1097f4bdbd9 100644 --- a/src/SamplesApp/SamplesApp.Skia.Generic/SamplesApp.Skia.Generic.csproj +++ b/src/SamplesApp/SamplesApp.Skia.Generic/Samp...
[ "src/SamplesApp/SamplesApp.Skia.Generic/SamplesApp.Skia.Generic.csproj" ]
[ { "comment": "`Microsoft.Web.WebView2` is referenced from code in this project (e.g., `Program.cs` uses `Microsoft.Web.WebView2.Core.CoreWebView2`), but this `PackageReference` sets a non-`global` assembly alias (`Aliases=\"MsWebView2\"`). With an alias set, the WebView2 assemblies won't be available in the glo...
true
unoplatform/uno
23,261
comment_to_fix
feat!: Drop WPF targets
PR description uses `closes #23260`. Repo guidelines require fully-qualified issue links in the PR footer (e.g., `Closes https://github.com/unoplatform/uno/issues/23260`) to avoid link breakage if issues move between repos.
c225e62911ab60986fd5a933d4b29e1cdc61d5a7
437ed852e3d03e267a6f4ff02faff71d83a24990
diff --git a/Directory.Build.props b/Directory.Build.props index ecabebc2e8fa..9275b2ec8899 100644 --- a/Directory.Build.props +++ b/Directory.Build.props @@ -23,15 +23,11 @@ <NetPreviousNetCoreApple>$(NetPrevious)-ios18.0;$(NetPrevious)-maccatalyst18.0;$(NetPrevious)-tvos18.0</NetPreviousNetCoreApple> <NetPrevio...
[ "Directory.Build.props" ]
[ { "comment": "PR description uses `closes #23260`. Repo guidelines require fully-qualified issue links in the PR footer (e.g., `Closes https://github.com/unoplatform/uno/issues/23260`) to avoid link breakage if issues move between repos.", "path": "Directory.Build.props", "hunk": "@@ -23,15 +23,11 @@\n ...
true
unoplatform/uno
23,408
issue_to_patch
ci: Update security measures in AI review workflow to ensure least privilege and prevent token exposure
f9e27b279c6056435993bf6da143d52834e80cb4
cf5ae1e85b37a4e9ed19d0b22163225aed714a52
diff --git a/.github/workflows/claude-code-review.yml b/.github/workflows/claude-code-review.yml index 429591c1e343..8c08bb080252 100644 --- a/.github/workflows/claude-code-review.yml +++ b/.github/workflows/claude-code-review.yml @@ -19,8 +19,12 @@ # `env`/`cat /proc/*/environ`/`curl`/`git push` to abuse. Do not...
[ ".github/workflows/claude-code-review.yml" ]
[]
true
unoplatform/uno
23,394
issue_to_patch
docs: Additional changes for agents
**GitHub Issue:** closes # <!-- Link to relevant GitHub issue if applicable. All PRs should be associated with an issue (GitHub issue or internal), unless the change is documentation related. --> ## PR Type: <!-- Copy the label that applies to this PR and paste it above: 🐞 Bugfix ✨ Feature 🎨 Code style...
1e2e0aa20513549559af4b4250f9a1e11018683c
30c8470e2967cfc8e7d484f428a9c98cc93afa78
diff --git a/.claude/rules/runtime-tests.md b/.claude/rules/runtime-tests.md index 2c3ce098e835..3c3eedadc38f 100644 --- a/.claude/rules/runtime-tests.md +++ b/.claude/rules/runtime-tests.md @@ -8,7 +8,7 @@ paths: Build & run with the **`/runtime-tests`** skill. WinUI parity: `/winui-runtime-tests`. -- Test class ...
[ ".claude/rules/runtime-tests.md", ".claude/rules/unit-tests.md", ".github/CODEOWNERS", "AGENTS.md" ]
[ { "comment": "The validation commands are ambiguous about the working directory. As written, `dotnet build Uno.UI-UnitTests-only.slnf` and `dotnet test Uno.UI.Tests/…` will fail when run from the repo root because both paths live under `src/`. Make the paths explicit (or add `cd src &&`) so the checklist works ...
true
unoplatform/uno
23,394
comment_to_fix
docs: Additional changes for agents
The validation commands are ambiguous about the working directory. As written, `dotnet build Uno.UI-UnitTests-only.slnf` and `dotnet test Uno.UI.Tests/…` will fail when run from the repo root because both paths live under `src/`. Make the paths explicit (or add `cd src &&`) so the checklist works from any directory.
1e2e0aa20513549559af4b4250f9a1e11018683c
30c8470e2967cfc8e7d484f428a9c98cc93afa78
diff --git a/AGENTS.md b/AGENTS.md index 4107e6a2edd1..0853d12776f8 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -128,7 +128,7 @@ Combined impact on `SamplesApp.Skia.Generic` (Windows, 32-core, warm NuGet cache cd src dotnet restore Uno.UI-Skia-only.slnf # Restore (50-60s) dotnet build Uno.UI-Skia-on...
[ "AGENTS.md" ]
[ { "comment": "The validation commands are ambiguous about the working directory. As written, `dotnet build Uno.UI-UnitTests-only.slnf` and `dotnet test Uno.UI.Tests/…` will fail when run from the repo root because both paths live under `src/`. Make the paths explicit (or add `cd src &&`) so the checklist works ...
true
unoplatform/uno
23,394
comment_to_fix
docs: Additional changes for agents
Complaining because of `uno-core-team`
1e2e0aa20513549559af4b4250f9a1e11018683c
30c8470e2967cfc8e7d484f428a9c98cc93afa78
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 008fb6703778..b3976d3631c8 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -3,9 +3,9 @@ # standard @username or @org/team-name format. You can also refer to a user by an # email address that has been added to their GitHub account, for example user...
[ ".github/CODEOWNERS" ]
[ { "comment": "Complaining because of `uno-core-team` ", "path": ".github/CODEOWNERS", "hunk": "@@ -3,9 +3,9 @@\n # standard @username or @org/team-name format. You can also refer to a user by an\n # email address that has been added to their GitHub account, for example user@example.com\n \n-* ...
true
unoplatform/uno
22,546
issue_to_patch
[Docs] Migrating WPF Apps to Uno ### What would you like clarification on The Migrating WPF Apps to Web page - https://platform.uno/docs/articles/wpf-migration.html the title is not clear enough and can be misleading for users. We should target it more on migrating to other platforms as well. CC @MartinZikmund DWX...
docs: Update WPF migration documentation to emphasize multi-platform support
**GitHub Issue:** #18791 ## PR Type: 📚 Documentation content changes ## What is the current behavior? 🤔 Documentation titled "Migrating WPF Apps to Web" narrowly focuses on WebAssembly, misleading users about Uno Platform's full cross-platform capabilities. ## What is the new behavior? 🚀 **Title:** "Migrating ...
df5d18a850248cb8c2ccb34032b4ebeb54dc8283
95261b8a630bf2e2dbe94f18bbbd7a4280226c2c
diff --git a/doc/articles/toc.yml b/doc/articles/toc.yml index 3e92725eb4fa..5a856cebd1c4 100644 --- a/doc/articles/toc.yml +++ b/doc/articles/toc.yml @@ -294,7 +294,7 @@ href: guides/xf-migration/toc.yml - name: WPF items: - - name: Migrating WPF Apps to Web + - name: Migrati...
[ "doc/articles/toc.yml", "doc/articles/wpf-migration.md" ]
[ { "comment": "The alt text for this image still references \"the web\" specifically, but the documentation has been updated to cover multi-platform migration. Consider updating the alt text to be more generic, such as \"A WPF app migrated to multiple platforms with Uno Platform\" to align with the broader scope...
true
unoplatform/uno
22,546
comment_to_fix
docs: Update WPF migration documentation to emphasize multi-platform support
The alt text for this image still references "the web" specifically, but the documentation has been updated to cover multi-platform migration. Consider updating the alt text to be more generic, such as "A WPF app migrated to multiple platforms with Uno Platform" to align with the broader scope of the documentation. ```...
df5d18a850248cb8c2ccb34032b4ebeb54dc8283
95261b8a630bf2e2dbe94f18bbbd7a4280226c2c
diff --git a/doc/articles/wpf-migration.md b/doc/articles/wpf-migration.md index 852b0f02b689..554c16e4bdb4 100644 --- a/doc/articles/wpf-migration.md +++ b/doc/articles/wpf-migration.md @@ -2,17 +2,17 @@ uid: Uno.Development.WPFMigration --- -# Migrating WPF Apps to Web +# Migrating WPF Apps to Uno Platform -Thi...
[ "doc/articles/wpf-migration.md" ]
[ { "comment": "The alt text for this image still references \"the web\" specifically, but the documentation has been updated to cover multi-platform migration. Consider updating the alt text to be more generic, such as \"A WPF app migrated to multiple platforms with Uno Platform\" to align with the broader scope...
true
unoplatform/uno
22,546
comment_to_fix
docs: Update WPF migration documentation to emphasize multi-platform support
The renamed "Platform-Specific Integration" section still refers to "the Web's platform agnostic app model", which contradicts the updated multi-platform framing and keeps Web-centric wording. Also, the PR description mentions adding an xref to platform-specific code docs, but this section currently has no links to tho...
df5d18a850248cb8c2ccb34032b4ebeb54dc8283
95261b8a630bf2e2dbe94f18bbbd7a4280226c2c
diff --git a/doc/articles/wpf-migration.md b/doc/articles/wpf-migration.md index 852b0f02b689..554c16e4bdb4 100644 --- a/doc/articles/wpf-migration.md +++ b/doc/articles/wpf-migration.md @@ -2,17 +2,17 @@ uid: Uno.Development.WPFMigration --- -# Migrating WPF Apps to Web +# Migrating WPF Apps to Uno Platform -Thi...
[ "doc/articles/wpf-migration.md" ]
[ { "comment": "The renamed \"Platform-Specific Integration\" section still refers to \"the Web's platform agnostic app model\", which contradicts the updated multi-platform framing and keeps Web-centric wording. Also, the PR description mentions adding an xref to platform-specific code docs, but this section cur...
true
unoplatform/uno
22,546
comment_to_fix
docs: Update WPF migration documentation to emphasize multi-platform support
Minor grammar: "decisions which served your customers well become less valid" reads awkwardly; using "that" and adding "may" improves readability and keeps the tense consistent.
df5d18a850248cb8c2ccb34032b4ebeb54dc8283
95261b8a630bf2e2dbe94f18bbbd7a4280226c2c
diff --git a/doc/articles/wpf-migration.md b/doc/articles/wpf-migration.md index 852b0f02b689..554c16e4bdb4 100644 --- a/doc/articles/wpf-migration.md +++ b/doc/articles/wpf-migration.md @@ -2,17 +2,17 @@ uid: Uno.Development.WPFMigration --- -# Migrating WPF Apps to Web +# Migrating WPF Apps to Uno Platform -Thi...
[ "doc/articles/wpf-migration.md" ]
[ { "comment": "Minor grammar: \"decisions which served your customers well become less valid\" reads awkwardly; using \"that\" and adding \"may\" improves readability and keeps the tense consistent.", "path": "doc/articles/wpf-migration.md", "hunk": "@@ -2,17 +2,17 @@\n uid: Uno.Development.WPFMigration\...
true
unoplatform/uno
22,546
comment_to_fix
docs: Update WPF migration documentation to emphasize multi-platform support
PR metadata references "GitHub Issue: #18791", but the description footer also includes "Fixes unoplatform/uno#17370". This appears to be a different issue number and is not in the required fully-qualified URL format ("Fixes https://github.com/unoplatform/uno/issues/<id>"). Please update the PR description to reference...
df5d18a850248cb8c2ccb34032b4ebeb54dc8283
95261b8a630bf2e2dbe94f18bbbd7a4280226c2c
diff --git a/doc/articles/wpf-migration.md b/doc/articles/wpf-migration.md index 852b0f02b689..554c16e4bdb4 100644 --- a/doc/articles/wpf-migration.md +++ b/doc/articles/wpf-migration.md @@ -2,17 +2,17 @@ uid: Uno.Development.WPFMigration --- -# Migrating WPF Apps to Web +# Migrating WPF Apps to Uno Platform -Thi...
[ "doc/articles/wpf-migration.md" ]
[ { "comment": "PR metadata references \"GitHub Issue: #18791\", but the description footer also includes \"Fixes unoplatform/uno#17370\". This appears to be a different issue number and is not in the required fully-qualified URL format (\"Fixes https://github.com/unoplatform/uno/issues/<id>\"). Please update the...
true
unoplatform/uno
23,346
issue_to_patch
feat: Enable `dotnet run` for packaged WinUI apps via WinApp build tools
Related to #23345 ## Summary - Adds [`Microsoft.Windows.SDK.BuildTools.WinApp`](https://www.nuget.org/packages/Microsoft.Windows.SDK.BuildTools.WinApp) (0.3.1) to ``SamplesApp.Windows`` and makes it an implicit reference for WinAppSDK executables produced by the Uno.Sdk, so ``dotnet run`` registers a loose-layout...
6270c2b018f55444183cd6758d0a7f8a7fa26867
d2abea8ea84cf467f6d8adbf8a5e71066ff4d7f5
diff --git a/doc/articles/features/using-the-uno-sdk.md b/doc/articles/features/using-the-uno-sdk.md index 4b42cb6f5628..6406328e7783 100644 --- a/doc/articles/features/using-the-uno-sdk.md +++ b/doc/articles/features/using-the-uno-sdk.md @@ -138,6 +138,7 @@ Here are the supported properties: | `SkiaSharpVersion` ...
[ "doc/articles/features/using-the-uno-sdk.md", "src/SamplesApp/SamplesApp.Windows/SamplesApp.Windows.csproj", "src/Uno.Sdk/Sdk/Sdk.props.buildschema.json", "src/Uno.Sdk/Services/PackageManifest.cs", "src/Uno.Sdk/Tasks/ImplicitPackagesResolver.cs", "src/Uno.Sdk/packages.json", "src/Uno.Sdk/targets/Uno.Imp...
[]
true