repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
urfave/cli | 2,276 | issue_to_patch | chore(deps): bump mkdocs-material from 9.7.3 to 9.7.4 in the python-packages group | Bumps the python-packages group with 1 update: [mkdocs-material](https://github.com/squidfunk/mkdocs-material).
Updates `mkdocs-material` from 9.7.3 to 9.7.4
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/squidfunk/mkdocs-material/releases">mkdocs-material's releases</a>.</e... | be9a4ba05ccf8e92f34274a5e0c555f2ad09e2b3 | 80956461fdf1984b6cb6328a8a9c2bf45633a35e | diff --git a/mkdocs-requirements.txt b/mkdocs-requirements.txt
index 681de355e5..843fb18ffa 100644
--- a/mkdocs-requirements.txt
+++ b/mkdocs-requirements.txt
@@ -1,5 +1,5 @@
mkdocs-git-revision-date-localized-plugin==1.5.1
-mkdocs-material==9.7.3
+mkdocs-material==9.7.4
mkdocs==1.6.1
mkdocs-redirects==1.2.2
pygmen... | [
"mkdocs-requirements.txt"
] | [] | true | ||
urfave/cli | 2,272 | issue_to_patch | chore(deps): bump mkdocs-material from 9.7.2 to 9.7.3 in the python-packages group | Bumps the python-packages group with 1 update: [mkdocs-material](https://github.com/squidfunk/mkdocs-material).
Updates `mkdocs-material` from 9.7.2 to 9.7.3
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/squidfunk/mkdocs-material/blob/master/CHANGELOG">mkdocs-material's changel... | 400fdfe10094e9f19f9a7a2b3447d5109a212676 | 6c91597415e79dbd4f77c170203d91ef44436c37 | diff --git a/mkdocs-requirements.txt b/mkdocs-requirements.txt
index 5324694e53..681de355e5 100644
--- a/mkdocs-requirements.txt
+++ b/mkdocs-requirements.txt
@@ -1,5 +1,5 @@
mkdocs-git-revision-date-localized-plugin==1.5.1
-mkdocs-material==9.7.2
+mkdocs-material==9.7.3
mkdocs==1.6.1
mkdocs-redirects==1.2.2
pygmen... | [
"mkdocs-requirements.txt"
] | [] | true | ||
urfave/cli | 2,245 | issue_to_patch | Required global flags are breaking help and completion commands
## My urfave/cli version is
v3.6.1
## Checklist
- [x] Are you running the latest v3 release? The list of releases is [here](https://github.com/urfave/cli/releases).
- [x] Did you check the manual for your release? The v3 manual is [here](https://cli.ur... | Fix:(issue_2244) Dont check req flags for help and completion commands | <!--
This template provides some ideas of things to include in your PR description.
To start, try providing a short summary of your changes in the Title above.
If a section of the PR template does not apply to this PR, then delete that section.
-->
## What type of PR is this?
_(REQUIRED)_
<!--
De... | c32fd204eea8343b388287fa0e8812ad01a71e0f | f92e992dd5998679be71285e2fd61f64f44ef80f | diff --git a/command_run.go b/command_run.go
index 32bd509199..e5cfff8a57 100644
--- a/command_run.go
+++ b/command_run.go
@@ -141,8 +141,8 @@ func (cmd *Command) run(ctx context.Context, osArgs []string) (_ context.Context
var rargs Args = &stringSliceArgs{v: osArgs}
var args Args = &stringSliceArgs{rargs.Tail()}
... | [
"command_run.go",
"completion_test.go",
"help_test.go"
] | [] | diff --git a/completion_test.go b/completion_test.go
index cf47381a87..17112d02fa 100644
--- a/completion_test.go
+++ b/completion_test.go
@@ -21,7 +21,7 @@ func TestCompletionEnable(t *testing.T) {
cmd := &Command{
EnableShellCompletion: true,
Flags: []Flag{
- &BoolFlag{
+ &StringFlag{
Name: "goo"... | true |
usebruno/bruno | 8,255 | issue_to_patch | fix(apispec): prevent crash on non-array specs and fix Windows spec listing (BRU-3556) | ### Description
Fixes two linked failures in the OpenAPI Spec viewer.
**Jira:** https://usebruno.atlassian.net/browse/BRU-3556
**1. Crash on workspace switch / open (`TypeError: ... .map is not a function`)**
The API Specs sidebar assumed `workspace.apiSpecs` is always an array and called `.map(...)`, guard... | db195fe302119cd6cdb49bbc6db2807239b43f16 | 37e6b77e749fe37427d745aa0b86df12ea39c5dc | diff --git a/packages/bruno-app/src/components/Sidebar/ApiSpecs/index.js b/packages/bruno-app/src/components/Sidebar/ApiSpecs/index.js
index 8bedb95814a..de4f4358192 100644
--- a/packages/bruno-app/src/components/Sidebar/ApiSpecs/index.js
+++ b/packages/bruno-app/src/components/Sidebar/ApiSpecs/index.js
@@ -5,6 +5,7 @@... | [
"packages/bruno-app/src/components/Sidebar/ApiSpecs/index.js",
"packages/bruno-app/src/components/Sidebar/ApiSpecs/matchLoadedApiSpecs.js",
"packages/bruno-app/src/components/Sidebar/ApiSpecs/matchLoadedApiSpecs.spec.js",
"packages/bruno-app/src/providers/ReduxStore/slices/workspaces/actions.js",
"packages/... | [] | diff --git a/packages/bruno-app/src/components/Sidebar/ApiSpecs/matchLoadedApiSpecs.spec.js b/packages/bruno-app/src/components/Sidebar/ApiSpecs/matchLoadedApiSpecs.spec.js
new file mode 100644
index 00000000000..b5e1e514655
--- /dev/null
+++ b/packages/bruno-app/src/components/Sidebar/ApiSpecs/matchLoadedApiSpecs.spec... | true | |
usebruno/bruno | 8,253 | issue_to_patch | fix(electron): Install packages dialog reports npm not on PATH when Node.js and npm are installed | ### Description
https://usebruno.atlassian.net/browse/BRU-3531
Postman package install showed “npm was not found on your PATH” even when Node/npm worked in the terminal..
Bruno’s main process couldn’t reliably find the user’s Node/npm at install time.
Apps launched from Finder/Dock get a minimal PATH, without... | 0d73e38515fec261f7559c49f67135b58a459c78 | 5b0ad126e84a200aabae55dc1788b2f2318c887b | diff --git a/packages/bruno-app/src/hooks/useResizablePanel/index.js b/packages/bruno-app/src/hooks/useResizablePanel/index.js
index acb988ad25..19ed50d747 100644
--- a/packages/bruno-app/src/hooks/useResizablePanel/index.js
+++ b/packages/bruno-app/src/hooks/useResizablePanel/index.js
@@ -55,8 +55,8 @@ export function... | [
"packages/bruno-app/src/hooks/useResizablePanel/index.js",
"packages/bruno-electron/src/ipc/collection.js",
"packages/bruno-electron/src/utils/install-packages.js",
"packages/bruno-electron/tests/utils/install-packages.spec.js",
"packages/bruno-requests/src/utils/shell-env.spec.ts",
"packages/bruno-reques... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**These two Windows shell tests still target the removed `runNpmInstall()` contract.**\n\n`runNpmInstall()` no longer reads `npmCommand` or `platform`; it resolves `nodePath`/`npmCliPath` and spawns `nodePath` with `[npmCliPath, ...args]`. So th... | diff --git a/packages/bruno-electron/tests/utils/install-packages.spec.js b/packages/bruno-electron/tests/utils/install-packages.spec.js
index e0d369211e..d2650a9739 100644
--- a/packages/bruno-electron/tests/utils/install-packages.spec.js
+++ b/packages/bruno-electron/tests/utils/install-packages.spec.js
@@ -1,5 +1,37... | true | |
usebruno/bruno | 8,253 | comment_to_fix | fix(electron): Install packages dialog reports npm not on PATH when Node.js and npm are installed | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**These two Windows shell tests still target the removed `runNpmInstall()` contract.**
`runNpmInstall()` no longer reads `npmCommand` or `platform`; it resolves `nodePath`/`npmCliPath` and spawns `nodePath` with `[npmCliPath, ...args]`. So these assertions are now che... | 0d73e38515fec261f7559c49f67135b58a459c78 | 5b0ad126e84a200aabae55dc1788b2f2318c887b | diff --git a/packages/bruno-electron/tests/utils/install-packages.spec.js b/packages/bruno-electron/tests/utils/install-packages.spec.js
index e0d369211e..d2650a9739 100644
--- a/packages/bruno-electron/tests/utils/install-packages.spec.js
+++ b/packages/bruno-electron/tests/utils/install-packages.spec.js
@@ -1,5 +1,37... | [
"packages/bruno-electron/tests/utils/install-packages.spec.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**These two Windows shell tests still target the removed `runNpmInstall()` contract.**\n\n`runNpmInstall()` no longer reads `npmCommand` or `platform`; it resolves `nodePath`/`npmCliPath` and spawns `nodePath` with `[npmCliPath, ...args]`. So th... | true | ||
usebruno/bruno | 8,253 | comment_to_fix | fix(electron): Install packages dialog reports npm not on PATH when Node.js and npm are installed | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Handle an empty inherited `PATH` the same as a missing one.**
If `process.env.PATH === ''`, Line 34 is skipped because the value is falsey, but Line 36 is also skipped because the key still exists. That leaves `PATH` empty even when the shell provided a usable value... | 0d73e38515fec261f7559c49f67135b58a459c78 | 5b0ad126e84a200aabae55dc1788b2f2318c887b | diff --git a/packages/bruno-requests/src/utils/shell-env.ts b/packages/bruno-requests/src/utils/shell-env.ts
index 82933880c2..49c8ac2312 100644
--- a/packages/bruno-requests/src/utils/shell-env.ts
+++ b/packages/bruno-requests/src/utils/shell-env.ts
@@ -4,6 +4,8 @@
* Fetches environment variables from the user's she... | [
"packages/bruno-requests/src/utils/shell-env.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Handle an empty inherited `PATH` the same as a missing one.**\n\nIf `process.env.PATH === ''`, Line 34 is skipped because the value is falsey, but Line 36 is also skipped because the key still exists. That leaves `PATH` empty even when the she... | true | ||
usebruno/bruno | 8,253 | comment_to_fix | fix(electron): Install packages dialog reports npm not on PATH when Node.js and npm are installed | For *nix systems I can see it right beside the `node` binary itself, so should be faster to just look it closer to node binary first assuming nvm would have the same setup for both linux and windows, though worth checking if it needs to `npm.cmd` (you can self resolve otherwise)
```suggestion
const candidates = [
... | 0d73e38515fec261f7559c49f67135b58a459c78 | 5b0ad126e84a200aabae55dc1788b2f2318c887b | diff --git a/packages/bruno-electron/src/utils/install-packages.js b/packages/bruno-electron/src/utils/install-packages.js
index 5f81d483f7..d5831f9fa2 100644
--- a/packages/bruno-electron/src/utils/install-packages.js
+++ b/packages/bruno-electron/src/utils/install-packages.js
@@ -1,11 +1,19 @@
const { spawn } = requ... | [
"packages/bruno-electron/src/utils/install-packages.js"
] | [
{
"comment": "For *nix systems I can see it right beside the `node` binary itself, so should be faster to just look it closer to node binary first assuming nvm would have the same setup for both linux and windows, though worth checking if it needs to `npm.cmd` (you can self resolve otherwise)\n\n```suggestion\n... | true | ||
usebruno/bruno | 8,251 | issue_to_patch | feat: support annotations for secret environment variables in `bru` and preserve variable value type in `yml` | ### Description
Secret env vars support annotations in bru and a type field in yml. Env, collection and folder variables preserve data types in yml via a datatype prop, and external secrets blocks survive read/save.
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
... | 13363d7931c91f986a03a4dbf8492ea4e56b2c08 | ae9ea4b1ac071386b91424fb03d2db30d0dbcba3 | diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js b/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js
index 5586e491e3c..c2f740f6abb 100644
--- a/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js
+++ b/packages/bruno-app/src/providers/ReduxS... | [
"packages/bruno-app/src/providers/ReduxStore/slices/collections/environment-events.spec.js",
"packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js",
"packages/bruno-filestore/src/formats/yml/common/variables.ts",
"packages/bruno-filestore/src/formats/yml/parseEnvironment.ts",
"packages/br... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_\n\n**External secret records collapse to `{ name, value }` across the BRU layer.**\n\n`packages/bruno-lang/v2/src/envToJson.js` reads `vars:externalsecrets` into `{ name, value }` entries, and `packages/bruno-lang/v2/src/jsonToEnv.js` writes onl... | diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/collections/environment-events.spec.js b/packages/bruno-app/src/providers/ReduxStore/slices/collections/environment-events.spec.js
new file mode 100644
index 00000000000..a24a718fb9c
--- /dev/null
+++ b/packages/bruno-app/src/providers/ReduxStore/slices/co... | true | |
usebruno/bruno | 8,251 | comment_to_fix | feat: support annotations for secret environment variables in `bru` and preserve variable value type in `yml` | _⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_
**External secret records collapse to `{ name, value }` across the BRU layer.**
`packages/bruno-lang/v2/src/envToJson.js` reads `vars:externalsecrets` into `{ name, value }` entries, and `packages/bruno-lang/v2/src/jsonToEnv.js` writes only those same two fields ba... | 13363d7931c91f986a03a4dbf8492ea4e56b2c08 | ae9ea4b1ac071386b91424fb03d2db30d0dbcba3 | diff --git a/packages/bruno-lang/v2/src/envToJson.js b/packages/bruno-lang/v2/src/envToJson.js
index 70f0362851f..0b248e98d48 100644
--- a/packages/bruno-lang/v2/src/envToJson.js
+++ b/packages/bruno-lang/v2/src/envToJson.js
@@ -16,7 +16,7 @@ const ANNOTATIONS_KEY = Symbol('annotations');
// }
const indentLevel = 4;
... | [
"packages/bruno-lang/v2/src/envToJson.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_\n\n**External secret records collapse to `{ name, value }` across the BRU layer.**\n\n`packages/bruno-lang/v2/src/envToJson.js` reads `vars:externalsecrets` into `{ name, value }` entries, and `packages/bruno-lang/v2/src/jsonToEnv.js` writes onl... | true | ||
usebruno/bruno | 8,251 | comment_to_fix | feat: support annotations for secret environment variables in `bru` and preserve variable value type in `yml` | _⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_
**Missing `description` field across all variable mapping functions in `index.js`.**
`setRequestVars` (lines 2070-2078), `setFolderVars` (lines 2426-2434), and `setCollectionVars` (lines 2666-2674) all use the same mapping pattern that omits the `description` fiel... | 13363d7931c91f986a03a4dbf8492ea4e56b2c08 | ae9ea4b1ac071386b91424fb03d2db30d0dbcba3 | diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js b/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js
index 5586e491e3c..c2f740f6abb 100644
--- a/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js
+++ b/packages/bruno-app/src/providers/ReduxS... | [
"packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_\n\n**Missing `description` field across all variable mapping functions in `index.js`.** \n\n`setRequestVars` (lines 2070-2078), `setFolderVars` (lines 2426-2434), and `setCollectionVars` (lines 2666-2674) all use the same mapping pattern that om... | true | ||
usebruno/bruno | 8,225 | issue_to_patch | fix(snapshot): folder nested script tab interactivity and tests | ### Description
[JIRA](https://usebruno.atlassian.net/browse/BRU-3545)
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [ ] **The pull request only addresses one issue or adds one feature.**
- [ ] **The pull request does not introduce any breaking changes**
- [... | 6791e0a6746d453334bebe030df5b07e4023b32d | 4706de8a275963042f91ebf746af85ae8a46906a | diff --git a/packages/bruno-app/src/components/FolderSettings/Script/index.js b/packages/bruno-app/src/components/FolderSettings/Script/index.js
index 61b0af6e85c..3458fe44264 100644
--- a/packages/bruno-app/src/components/FolderSettings/Script/index.js
+++ b/packages/bruno-app/src/components/FolderSettings/Script/inde... | [
"packages/bruno-app/src/components/FolderSettings/Script/index.js",
"packages/bruno-app/src/components/RequestTabs/RequestTab/index.js",
"packages/bruno-app/src/providers/ReduxStore/slices/tabs.js",
"tests/snapshots/collection.spec.ts",
"tests/snapshots/folder.spec.ts",
"tests/utils/page/actions.ts",
"t... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Add error handling for corrupted snapshot files.**\n\nIf `ui-state-snapshot.json` is malformed, `JSON.parse` will throw, causing tests to fail with a cryptic error. Wrap the parse in a try-catch and return `null` or throw a descriptive error.\... | diff --git a/tests/snapshots/collection.spec.ts b/tests/snapshots/collection.spec.ts
new file mode 100644
index 00000000000..38bf2e5d421
--- /dev/null
+++ b/tests/snapshots/collection.spec.ts
@@ -0,0 +1,135 @@
+import { test, expect, closeElectronApp } from '../../playwright';
+import {
+ createCollection,
+ createWo... | true | |
usebruno/bruno | 8,225 | comment_to_fix | fix(snapshot): folder nested script tab interactivity and tests | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Add error handling for corrupted snapshot files.**
If `ui-state-snapshot.json` is malformed, `JSON.parse` will throw, causing tests to fail with a cryptic error. Wrap the parse in a try-catch and return `null` or throw a descriptive error.
<details>
<summary>🛡... | 6791e0a6746d453334bebe030df5b07e4023b32d | 4706de8a275963042f91ebf746af85ae8a46906a | diff --git a/tests/utils/snapshot.ts b/tests/utils/snapshot.ts
new file mode 100644
index 00000000000..64df1f401d4
--- /dev/null
+++ b/tests/utils/snapshot.ts
@@ -0,0 +1,43 @@
+import path from 'path';
+import fs from 'fs';
+import { expect } from '../../playwright';
+
+export const getSnapshotPath = (userDataPath: str... | [
"tests/utils/snapshot.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Add error handling for corrupted snapshot files.**\n\nIf `ui-state-snapshot.json` is malformed, `JSON.parse` will throw, causing tests to fail with a cryptic error. Wrap the parse in a try-catch and return `null` or throw a descriptive error.\... | true | ||
usebruno/bruno | 8,225 | comment_to_fix | fix(snapshot): folder nested script tab interactivity and tests | _⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_
**Fix type signature to match implementation.**
The parameter `collectionPath: string` is typed as required, but line 37 treats it as optional with `if (collectionPath && ...)`. This is a type/runtime contract mismatch.
Either make it optional: `collectionPath?: s... | 6791e0a6746d453334bebe030df5b07e4023b32d | 4706de8a275963042f91ebf746af85ae8a46906a | diff --git a/tests/utils/snapshot.ts b/tests/utils/snapshot.ts
new file mode 100644
index 00000000000..64df1f401d4
--- /dev/null
+++ b/tests/utils/snapshot.ts
@@ -0,0 +1,43 @@
+import path from 'path';
+import fs from 'fs';
+import { expect } from '../../playwright';
+
+export const getSnapshotPath = (userDataPath: str... | [
"tests/utils/snapshot.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_\n\n**Fix type signature to match implementation.**\n\nThe parameter `collectionPath: string` is typed as required, but line 37 treats it as optional with `if (collectionPath && ...)`. This is a type/runtime contract mismatch.\n\nEither make it o... | true | ||
usebruno/bruno | 8,193 | issue_to_patch | chore: sec updates | ### Description
[JIRA](https://usebruno.atlassian.net/browse/BRU-3564)
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [ ] **The pull request only addresses one issue or adds one feature.**
- [ ] **The pull request does not introduce any breaking changes**
- [... | 59b4a16b798e195ae3e57e827e794e56c6dd23f4 | 78a3cf30b79fb5c1475ce61eb301e2ad7f689a99 | diff --git a/package-lock.json b/package-lock.json
index 91f47fd98a..ec627df44c 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -51,7 +51,7 @@
"globals": "^16.1.0",
"husky": "^9.1.7",
"jest": "^29.2.0",
- "lodash-es": "^4.17.21",
+ "lodash-es": "^4.17.23",
"na... | [
"package-lock.json",
"package.json",
"packages/bruno-app/package.json",
"packages/bruno-cli/package.json",
"packages/bruno-electron/package.json",
"packages/bruno-js/package.json",
"packages/bruno-requests/package.json",
"packages/bruno-tests/package.json"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify Jest ecosystem major alignment across workspace manifests.\n# Expected: jest-related packages should resolve to a consistent major (30) whe... | true | ||
usebruno/bruno | 8,193 | comment_to_fix | chore: sec updates | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Verify Jest ecosystem major alignment across workspace manifests.
# Expected: jest-related packages should resolve to a consistent major (30) where used together.
rg -n --glob ... | 59b4a16b798e195ae3e57e827e794e56c6dd23f4 | 78a3cf30b79fb5c1475ce61eb301e2ad7f689a99 | diff --git a/package.json b/package.json
index e3ac38d06c..1f3de70fdb 100644
--- a/package.json
+++ b/package.json
@@ -44,7 +44,7 @@
"globals": "^16.1.0",
"husky": "^9.1.7",
"jest": "^29.2.0",
- "lodash-es": "^4.17.21",
+ "lodash-es": "^4.17.23",
"nano-staged": "^0.8.0",
"playwright": "^1... | [
"package.json"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify Jest ecosystem major alignment across workspace manifests.\n# Expected: jest-related packages should resolve to a consistent major (30) whe... | true | ||
usebruno/bruno | 8,193 | comment_to_fix | chore: sec updates | Jest was bumped to 30.0.0, but this repo is still pinning `@jest/globals` and `@types/jest` to the 29.x line. This currently pulls `@jest/globals@29.7.0` (and its `@jest/*` deps) alongside Jest 30 in the lockfile, which can lead to incompatible internal Jest package mixtures when tests import from `@jest/globals`. Cons... | 59b4a16b798e195ae3e57e827e794e56c6dd23f4 | 78a3cf30b79fb5c1475ce61eb301e2ad7f689a99 | diff --git a/package.json b/package.json
index e3ac38d06c..1f3de70fdb 100644
--- a/package.json
+++ b/package.json
@@ -44,7 +44,7 @@
"globals": "^16.1.0",
"husky": "^9.1.7",
"jest": "^29.2.0",
- "lodash-es": "^4.17.21",
+ "lodash-es": "^4.17.23",
"nano-staged": "^0.8.0",
"playwright": "^1... | [
"package.json"
] | [
{
"comment": "Jest was bumped to 30.0.0, but this repo is still pinning `@jest/globals` and `@types/jest` to the 29.x line. This currently pulls `@jest/globals@29.7.0` (and its `@jest/*` deps) alongside Jest 30 in the lockfile, which can lead to incompatible internal Jest package mixtures when tests import from... | true | ||
usebruno/bruno | 8,193 | comment_to_fix | chore: sec updates | `jest` is now 30.0.0, but `babel-jest` and `@types/jest` are still pinned to 29.x. This keeps Jest-related internals on mixed majors (e.g. `@jest/transform@29` via `babel-jest@29`), which can cause runtime failures when Jest loads transformers. Align these companion packages with Jest 30 as well. | 59b4a16b798e195ae3e57e827e794e56c6dd23f4 | 78a3cf30b79fb5c1475ce61eb301e2ad7f689a99 | diff --git a/packages/bruno-requests/package.json b/packages/bruno-requests/package.json
index 2d26b30f8c..c69d8bad9b 100644
--- a/packages/bruno-requests/package.json
+++ b/packages/bruno-requests/package.json
@@ -24,7 +24,7 @@
"@grpc/grpc-js": "^1.13.3",
"@grpc/proto-loader": "^0.7.15",
"@types/qs": "^... | [
"packages/bruno-requests/package.json"
] | [
{
"comment": "`jest` is now 30.0.0, but `babel-jest` and `@types/jest` are still pinned to 29.x. This keeps Jest-related internals on mixed majors (e.g. `@jest/transform@29` via `babel-jest@29`), which can cause runtime failures when Jest loads transformers. Align these companion packages with Jest 30 as well."... | true | ||
usebruno/bruno | 8,193 | comment_to_fix | chore: sec updates | `jest-environment-jsdom` has been bumped to 30.0.0 (Jest 30 line), but `babel-jest` remains on 29.x. `babel-jest@29` pulls `@jest/transform@29`, which can be incompatible with Jest 30 when transforming test files. Align `babel-jest` to the Jest 30 major to avoid mixed Jest internals. | 59b4a16b798e195ae3e57e827e794e56c6dd23f4 | 78a3cf30b79fb5c1475ce61eb301e2ad7f689a99 | diff --git a/packages/bruno-app/package.json b/packages/bruno-app/package.json
index efbf326d51..1c2b9fbe24 100644
--- a/packages/bruno-app/package.json
+++ b/packages/bruno-app/package.json
@@ -86,7 +86,7 @@
"react-virtuoso": "^4.18.1",
"sass": "^1.46.0",
"semver": "^7.7.1",
- "shell-quote": "^1.8.3"... | [
"packages/bruno-app/package.json"
] | [
{
"comment": "`jest-environment-jsdom` has been bumped to 30.0.0 (Jest 30 line), but `babel-jest` remains on 29.x. `babel-jest@29` pulls `@jest/transform@29`, which can be incompatible with Jest 30 when transforming test files. Align `babel-jest` to the Jest 30 major to avoid mixed Jest internals.",
"path":... | true | ||
usebruno/bruno | 8,234 | issue_to_patch | feat(dev-tools-rquest-resize): dev tools details panel can be resized horizontally via a drag handle | [JIRA](https://usebruno.atlassian.net/browse/BRU-3468)
This PR targets the **Details panel can be resized horizontally via a drag handle**
<!-- Explain here the changes your PR introduces and text to help us understand the context of this change. -->
The details panel that opens when clicking a network request... | 377cdb488c75926f6e68a34903c0b972bf35d937 | 467ec6ddf76185367b40150b605d5b088877040f | diff --git a/packages/bruno-app/src/components/Devtools/Console/RequestDetailsPanel/StyledWrapper.js b/packages/bruno-app/src/components/Devtools/Console/RequestDetailsPanel/StyledWrapper.js
index 0f768a6980e..698bb90ae2a 100644
--- a/packages/bruno-app/src/components/Devtools/Console/RequestDetailsPanel/StyledWrapper.... | [
"packages/bruno-app/src/components/Devtools/Console/RequestDetailsPanel/StyledWrapper.js",
"packages/bruno-app/src/components/Devtools/Console/StyledWrapper.js",
"packages/bruno-app/src/components/Devtools/Console/index.js",
"packages/bruno-app/src/hooks/useResizablePanel/index.js",
"packages/bruno-app/src/... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Fix stale listener closures for dynamic hook options.**\n\n`mousemove`/`mouseup` listeners are registered once (Line 57-64), so they keep first-render `direction`, bounds, and `onResizeEnd`. If options change after mount, drag math/callbacks k... | diff --git a/packages/bruno-app/src/hooks/useResizablePanel/index.spec.js b/packages/bruno-app/src/hooks/useResizablePanel/index.spec.js
new file mode 100644
index 00000000000..b6a3887bd09
--- /dev/null
+++ b/packages/bruno-app/src/hooks/useResizablePanel/index.spec.js
@@ -0,0 +1,192 @@
+const { describe, it, expect, j... | true | |
usebruno/bruno | 8,234 | comment_to_fix | feat(dev-tools-rquest-resize): dev tools details panel can be resized horizontally via a drag handle | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Fix stale listener closures for dynamic hook options.**
`mousemove`/`mouseup` listeners are registered once (Line 57-64), so they keep first-render `direction`, bounds, and `onResizeEnd`. If options change after mount, drag math/callbacks keep stale behavior.
... | 377cdb488c75926f6e68a34903c0b972bf35d937 | 467ec6ddf76185367b40150b605d5b088877040f | diff --git a/packages/bruno-app/src/hooks/useResizablePanel/index.js b/packages/bruno-app/src/hooks/useResizablePanel/index.js
new file mode 100644
index 00000000000..acb988ad251
--- /dev/null
+++ b/packages/bruno-app/src/hooks/useResizablePanel/index.js
@@ -0,0 +1,69 @@
+import { useEffect, useRef, useState } from 're... | [
"packages/bruno-app/src/hooks/useResizablePanel/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Fix stale listener closures for dynamic hook options.**\n\n`mousemove`/`mouseup` listeners are registered once (Line 57-64), so they keep first-render `direction`, bounds, and `onResizeEnd`. If options change after mount, drag math/callbacks k... | true | ||
usebruno/bruno | 8,234 | comment_to_fix | feat(dev-tools-rquest-resize): dev tools details panel can be resized horizontally via a drag handle | ```suggestion
// Note: tying the events to the document instead of the parent to avoid fast movement
// from breaking the flow state of dragging
document.addEventListener('mousemove', handleMouseMove);
``` | 377cdb488c75926f6e68a34903c0b972bf35d937 | 467ec6ddf76185367b40150b605d5b088877040f | diff --git a/packages/bruno-app/src/hooks/useResizablePanel/index.js b/packages/bruno-app/src/hooks/useResizablePanel/index.js
new file mode 100644
index 00000000000..acb988ad251
--- /dev/null
+++ b/packages/bruno-app/src/hooks/useResizablePanel/index.js
@@ -0,0 +1,69 @@
+import { useEffect, useRef, useState } from 're... | [
"packages/bruno-app/src/hooks/useResizablePanel/index.js"
] | [
{
"comment": "```suggestion\n // Note: tying the events to the document instead of the parent to avoid fast movement \n // from breaking the flow state of dragging \n document.addEventListener('mousemove', handleMouseMove);\n```",
"path": "packages/bruno-app/src/hooks/useResizablePanel/index.js",
... | true | ||
usebruno/bruno | 8,238 | issue_to_patch | feat(dev-tools)/adds sorting on columns with verticle borders | ### Description
[JIRA](https://usebruno.atlassian.net/browse/BRU-3468)
This PR covers the **Sorting on the Network tab column.**
<!-- Explain here the changes your PR introduces and text to help us understand the context of this change. -->
- Column config — introduced a COLUMNS array with width and alignment... | 59b4a16b798e195ae3e57e827e794e56c6dd23f4 | e66da4831aa7567e5943f24375705346d4d594b2 | diff --git a/packages/bruno-app/jest.setup.js b/packages/bruno-app/jest.setup.js
index 1dbb39d85e7..5863193d4d6 100644
--- a/packages/bruno-app/jest.setup.js
+++ b/packages/bruno-app/jest.setup.js
@@ -1,3 +1,19 @@
+global.ResizeObserver = class ResizeObserver {
+ observe() {}
+ unobserve() {}
+ disconnect() {}
+};
+... | [
"packages/bruno-app/jest.setup.js",
"packages/bruno-app/src/components/Devtools/Console/NetworkTab/StyledWrapper.js",
"packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.js",
"packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.spec.js",
"packages/bruno-app/src/components/De... | [
{
"comment": "computes the left/right pixel position of each separator from column widths. Renders as absolutely positioned 1px divs spanning the full container height, laying the groundwork for column resizing.",
"path": "packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.js",
"hunk": ... | diff --git a/packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.spec.js b/packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.spec.js
new file mode 100644
index 00000000000..5ae619b9446
--- /dev/null
+++ b/packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.spec.js
@@ -0... | true | |
usebruno/bruno | 8,238 | comment_to_fix | feat(dev-tools)/adds sorting on columns with verticle borders | computes the left/right pixel position of each separator from column widths. Renders as absolutely positioned 1px divs spanning the full container height, laying the groundwork for column resizing. | 59b4a16b798e195ae3e57e827e794e56c6dd23f4 | e66da4831aa7567e5943f24375705346d4d594b2 | diff --git a/packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.js b/packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.js
index e424b690cf7..4fae5745c8d 100644
--- a/packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.js
+++ b/packages/bruno-app/src/components/Devtools... | [
"packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.js"
] | [
{
"comment": "computes the left/right pixel position of each separator from column widths. Renders as absolutely positioned 1px divs spanning the full container height, laying the groundwork for column resizing.",
"path": "packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.js",
"hunk": ... | true | ||
usebruno/bruno | 8,238 | comment_to_fix | feat(dev-tools)/adds sorting on columns with verticle borders | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Missing `.text-right` class definition.**
Line 253 conditionally adds the `text-right` class when `col.align === 'right'`, but this class is not defined in `StyledWrapper.js`. The header cells won't align correctly for right-aligned columns (Duration, Size).
<d... | 59b4a16b798e195ae3e57e827e794e56c6dd23f4 | e66da4831aa7567e5943f24375705346d4d594b2 | diff --git a/packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.js b/packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.js
index e424b690cf7..4fae5745c8d 100644
--- a/packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.js
+++ b/packages/bruno-app/src/components/Devtools... | [
"packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Missing `.text-right` class definition.**\n\nLine 253 conditionally adds the `text-right` class when `col.align === 'right'`, but this class is not defined in `StyledWrapper.js`. The header cells won't align correctly for right-aligned columns... | true | ||
usebruno/bruno | 8,238 | comment_to_fix | feat(dev-tools)/adds sorting on columns with verticle borders | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Restore global mocks after the suite to prevent cross-test leakage.**
Line 12 and Line 20 patch globals (`global.ResizeObserver`, `window.matchMedia`) but never restore them. This can make other suites order-dependent and flaky.
<details>
<summary>Suggested minimal... | 59b4a16b798e195ae3e57e827e794e56c6dd23f4 | e66da4831aa7567e5943f24375705346d4d594b2 | diff --git a/packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.spec.js b/packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.spec.js
new file mode 100644
index 00000000000..5ae619b9446
--- /dev/null
+++ b/packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.spec.js
@@ -0... | [
"packages/bruno-app/src/components/Devtools/Console/NetworkTab/index.spec.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Restore global mocks after the suite to prevent cross-test leakage.**\n\nLine 12 and Line 20 patch globals (`global.ResizeObserver`, `window.matchMedia`) but never restore them. This can make other suites order-dependent and flaky.\n\n<details... | true | ||
usebruno/bruno | 8,238 | comment_to_fix | feat(dev-tools)/adds sorting on columns with verticle borders | _⚠️ Potential issue_ | _🟡 Minor_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Description: Check if HTTP methods in the codebase are normalized to uppercase
# Search for method assignments and usage patterns
rg -nP --type=js -C2 'method\s*[:=]' | head -50
# Check for t... | 59b4a16b798e195ae3e57e827e794e56c6dd23f4 | e66da4831aa7567e5943f24375705346d4d594b2 | diff --git a/packages/bruno-app/src/components/Devtools/Console/NetworkTab/utils.js b/packages/bruno-app/src/components/Devtools/Console/NetworkTab/utils.js
new file mode 100644
index 00000000000..507fced80ee
--- /dev/null
+++ b/packages/bruno-app/src/components/Devtools/Console/NetworkTab/utils.js
@@ -0,0 +1,57 @@
+ex... | [
"packages/bruno-app/src/components/Devtools/Console/NetworkTab/utils.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Description: Check if HTTP methods in the codebase are normalized to uppercase\n\n# Search for method assignments and usage patterns\nrg -nP --type=js -C2 'method... | true | ||
usebruno/bruno | 8,249 | issue_to_patch | fix(workspace): keep workspace nav tabs visible when editing docs | ### Description
When a workspace had many collections and the user opened **Workspace Docs** for editing, the workspace name and tabs disappeared and could not be recovered.
Fixes [BRU-3562](https://usebruno.atlassian.net/browse/BRU-3562)
### Screen Recording
https://github.com/user-attachments/assets/90a... | 13363d7931c91f986a03a4dbf8492ea4e56b2c08 | 282e3a26175bb57bc5d1af56afe45c11b91d9e6a | diff --git a/packages/bruno-app/src/components/WorkspaceHome/WorkspaceOverview/StyledWrapper.js b/packages/bruno-app/src/components/WorkspaceHome/WorkspaceOverview/StyledWrapper.js
index c0c677db2c..8d675a787a 100644
--- a/packages/bruno-app/src/components/WorkspaceHome/WorkspaceOverview/StyledWrapper.js
+++ b/packages... | [
"packages/bruno-app/src/components/WorkspaceHome/WorkspaceOverview/StyledWrapper.js"
] | [] | true | ||
usebruno/bruno | 8,245 | issue_to_patch | Command + W closes tab without prompt
[JIRA](https://usebruno.atlassian.net/browse/BRU-372)
### I have checked the following:
- [X] I use the newest version of bruno.
- [X] I've searched existing issues and found nothing related to my issue.
### Describe the bug
On ARM, MacOS 13.5.2 (22G91).
When closing a tab w... | fix: show unsaved changes prompt when closing tab with Cmd+W | ### Description
Fixes #8244
Fixes #3264
Pressing `Cmd+W` / `Ctrl+W` on a modified request tab closed it immediately
without the unsaved-changes prompt because the `closeTab` handler's condition
was missing the `'http-request'` type. Added it so HTTP tabs get the same
dirty-state check as all other request typ... | 59b4a16b798e195ae3e57e827e794e56c6dd23f4 | 822baf967ce904eceb8575e3a4f9f1acf7421c77 | diff --git a/packages/bruno-app/src/components/RequestTabs/RequestTab/index.js b/packages/bruno-app/src/components/RequestTabs/RequestTab/index.js
index bd00be0924c..631dd33b045 100644
--- a/packages/bruno-app/src/components/RequestTabs/RequestTab/index.js
+++ b/packages/bruno-app/src/components/RequestTabs/RequestTab/... | [
"packages/bruno-app/src/components/RequestTabs/RequestTab/index.js"
] | [] | true | |
usebruno/bruno | 8,196 | issue_to_patch | feat(workspace): move external collections into the workspace | ### Description
When a collection is opened from a path outside the workspace folder, there is no way to bring it under the workspace. This means the collection cannot be managed by the workspace's Git setup. The only workaround today is to manually move the collection folder into `<workspace>/collections` on disk. ... | 13a48a256fc62c874c151b48052d114b0fb7da56 | e0448af5e8dd25f9bd8e2a3edfa6112ee1edeff8 | diff --git a/packages/bruno-app/src/components/Sidebar/Collections/Collection/MoveToWorkspace/ConfirmMoveDrafts.js b/packages/bruno-app/src/components/Sidebar/Collections/Collection/MoveToWorkspace/ConfirmMoveDrafts.js
new file mode 100644
index 00000000000..28da4c92b6a
--- /dev/null
+++ b/packages/bruno-app/src/compon... | [
"packages/bruno-app/src/components/Sidebar/Collections/Collection/MoveToWorkspace/ConfirmMoveDrafts.js",
"packages/bruno-app/src/components/Sidebar/Collections/Collection/MoveToWorkspace/StyledWrapper.js",
"packages/bruno-app/src/components/Sidebar/Collections/Collection/MoveToWorkspace/index.js",
"packages/b... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Add `testId` for the new “Move into Workspace” menu action.**\n\nLine 455 through Line 460 adds a new dropdown action without a stable test selector, which makes Playwright coverage for this feature harder to maintain.\n\n<details>\n<summary>S... | diff --git a/packages/bruno-app/src/utils/common/path.spec.js b/packages/bruno-app/src/utils/common/path.spec.js
index e283ff4751f..0a08426fc1b 100644
--- a/packages/bruno-app/src/utils/common/path.spec.js
+++ b/packages/bruno-app/src/utils/common/path.spec.js
@@ -6,7 +6,7 @@ jest.mock('platform', () => ({
}));
imp... | true | |
usebruno/bruno | 8,196 | comment_to_fix | feat(workspace): move external collections into the workspace | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Add `testId` for the new “Move into Workspace” menu action.**
Line 455 through Line 460 adds a new dropdown action without a stable test selector, which makes Playwright coverage for this feature harder to maintain.
<details>
<summary>Suggested minimal patch</summa... | 13a48a256fc62c874c151b48052d114b0fb7da56 | e0448af5e8dd25f9bd8e2a3edfa6112ee1edeff8 | diff --git a/packages/bruno-app/src/components/Sidebar/Collections/Collection/index.js b/packages/bruno-app/src/components/Sidebar/Collections/Collection/index.js
index abf6b7817d5..4092af11c70 100644
--- a/packages/bruno-app/src/components/Sidebar/Collections/Collection/index.js
+++ b/packages/bruno-app/src/components... | [
"packages/bruno-app/src/components/Sidebar/Collections/Collection/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Add `testId` for the new “Move into Workspace” menu action.**\n\nLine 455 through Line 460 adds a new dropdown action without a stable test selector, which makes Playwright coverage for this feature harder to maintain.\n\n<details>\n<summary>S... | true | ||
usebruno/bruno | 8,196 | comment_to_fix | feat(workspace): move external collections into the workspace | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Add stable test selectors for draft action buttons.**
Line 173 through Line 206 introduce key user actions (`Save`, `Discard All and Move`, `Cancel`, `Save All and Move`) without `data-testid`, which makes Playwright coverage brittle for this new flow.
<details>
<s... | 13a48a256fc62c874c151b48052d114b0fb7da56 | e0448af5e8dd25f9bd8e2a3edfa6112ee1edeff8 | diff --git a/packages/bruno-app/src/components/Sidebar/Collections/Collection/MoveToWorkspace/ConfirmMoveDrafts.js b/packages/bruno-app/src/components/Sidebar/Collections/Collection/MoveToWorkspace/ConfirmMoveDrafts.js
new file mode 100644
index 00000000000..28da4c92b6a
--- /dev/null
+++ b/packages/bruno-app/src/compon... | [
"packages/bruno-app/src/components/Sidebar/Collections/Collection/MoveToWorkspace/ConfirmMoveDrafts.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Add stable test selectors for draft action buttons.**\n\nLine 173 through Line 206 introduce key user actions (`Save`, `Discard All and Move`, `Cancel`, `Save All and Move`) without `data-testid`, which makes Playwright coverage brittle for th... | true | ||
usebruno/bruno | 8,196 | comment_to_fix | feat(workspace): move external collections into the workspace | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Use OS-agnostic path joining for destination path display.**
Line 60 hardcodes `'/'` in a filesystem path. In Bruno’s cross-platform context, this should be composed via a path-join utility to avoid platform-specific formatting drift.
As per coding guidelines, file... | 13a48a256fc62c874c151b48052d114b0fb7da56 | e0448af5e8dd25f9bd8e2a3edfa6112ee1edeff8 | diff --git a/packages/bruno-app/src/components/Sidebar/Collections/Collection/MoveToWorkspace/index.js b/packages/bruno-app/src/components/Sidebar/Collections/Collection/MoveToWorkspace/index.js
new file mode 100644
index 00000000000..5e2e5724ead
--- /dev/null
+++ b/packages/bruno-app/src/components/Sidebar/Collections... | [
"packages/bruno-app/src/components/Sidebar/Collections/Collection/MoveToWorkspace/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Use OS-agnostic path joining for destination path display.**\n\nLine 60 hardcodes `'/'` in a filesystem path. In Bruno’s cross-platform context, this should be composed via a path-join utility to avoid platform-specific formatting drift.\n\nAs... | true | ||
usebruno/bruno | 8,196 | comment_to_fix | feat(workspace): move external collections into the workspace | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Assert the discard outcome, not just that the move succeeded.**
This scenario currently proves the move happened, but it does not prove that **discard** actually discarded the dirty draft. Add an on-disk assertion for the moved request content (e.g., verify the chan... | 13a48a256fc62c874c151b48052d114b0fb7da56 | e0448af5e8dd25f9bd8e2a3edfa6112ee1edeff8 | diff --git a/tests/workspace/move-collection-to-workspace.spec.ts b/tests/workspace/move-collection-to-workspace.spec.ts
new file mode 100644
index 00000000000..282d1f49fa6
--- /dev/null
+++ b/tests/workspace/move-collection-to-workspace.spec.ts
@@ -0,0 +1,174 @@
+import path from 'path';
+import fs from 'fs';
+import ... | [
"tests/workspace/move-collection-to-workspace.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Assert the discard outcome, not just that the move succeeded.**\n\nThis scenario currently proves the move happened, but it does not prove that **discard** actually discarded the dirty draft. Add an on-disk assertion for the moved request cont... | true | ||
usebruno/bruno | 8,210 | issue_to_patch | fix(timeline): scope scripted requests to their own request | ### Description
[JIRA](https://usebruno.atlassian.net/browse/BRU-3526)
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [ ] **The pull request only addresses one issue or adds one feature.**
- [ ] **The pull request does not introduce any breaking changes**
- [... | 240826ebc1106b440306f9050c4c793afb3c58fd | c8b1709c78078692394a951b5af6f9f23afb6d9c | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Body/index.js b/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Body/index.js
index c71810830f4..7ad58cf3353 100644
--- a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Body/... | [
"packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Body/index.js",
"packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Headers/index.js",
"packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Status/index.js",
"packages/bruno-app/src/co... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Update downstream E2E assertion for the new empty-state copy.**\n\nThis text change to `'No Headers'` conflicts with an existing assertion in `tests/auth/auth-mode/folder-no-auth-stops-inheritance.spec.ts` (Lines 68-73) that still expects `'No... | diff --git a/tests/auth/auth-mode/folder-no-auth-stops-inheritance.spec.ts b/tests/auth/auth-mode/folder-no-auth-stops-inheritance.spec.ts
index 621f360de85..99de26dd62d 100644
--- a/tests/auth/auth-mode/folder-no-auth-stops-inheritance.spec.ts
+++ b/tests/auth/auth-mode/folder-no-auth-stops-inheritance.spec.ts
@@ -68,... | true | |
usebruno/bruno | 8,210 | comment_to_fix | fix(timeline): scope scripted requests to their own request | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Update downstream E2E assertion for the new empty-state copy.**
This text change to `'No Headers'` conflicts with an existing assertion in `tests/auth/auth-mode/folder-no-auth-stops-inheritance.spec.ts` (Lines 68-73) that still expects `'No Headers found'`, so that ... | 240826ebc1106b440306f9050c4c793afb3c58fd | c8b1709c78078692394a951b5af6f9f23afb6d9c | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Headers/index.js b/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Headers/index.js
index 27e6fc82fd0..cc8ab96d9ee 100644
--- a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common... | [
"packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Headers/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Update downstream E2E assertion for the new empty-state copy.**\n\nThis text change to `'No Headers'` conflicts with an existing assertion in `tests/auth/auth-mode/folder-no-auth-stops-inheritance.spec.ts` (Lines 68-73) that still expects `'No... | true | ||
usebruno/bruno | 8,213 | issue_to_patch | fix(size/L): Preserve folder order from seq attribute | ### Description
A user organizes their Bruno collection with folders ordered using the seq attribute. When they run "Generate Docs", they expect the HTML output to reflect that order. Today the order is non-deterministic — each regeneration produces a different folder order in the rendered output and in the JSON blo... | 13a48a256fc62c874c151b48052d114b0fb7da56 | 13cc6e52c8a6752fd31fb8262518e3063c238529 | diff --git a/package-lock.json b/package-lock.json
index d2f90304f14..91f47fd98a4 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -39,6 +39,7 @@
"@storybook/react-webpack5": "^10.1.10",
"@stylistic/eslint-plugin": "^5.3.1",
"@types/jest": "^29.5.11",
+ "@types/js-yaml": "^4.0... | [
"package-lock.json",
"package.json",
"packages/bruno-app/src/components/Sidebar/Collections/Collection/GenerateDocumentation/index.js",
"packages/bruno-app/src/utils/collections/index.js",
"packages/bruno-app/src/utils/common/sort-items-by-sidebar-order.spec.js",
"tests/collection/generate-docs/fixtures/c... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**JSDoc mentions files but implementation doesn't handle them.**\n\nThe JSDoc states the function orders \"folders first...then requests...then code/data files (in their existing order).\" However, the implementation only processes folders and r... | diff --git a/packages/bruno-app/src/utils/common/sort-items-by-sidebar-order.spec.js b/packages/bruno-app/src/utils/common/sort-items-by-sidebar-order.spec.js
new file mode 100644
index 00000000000..64b759fc821
--- /dev/null
+++ b/packages/bruno-app/src/utils/common/sort-items-by-sidebar-order.spec.js
@@ -0,0 +1,93 @@
... | true | |
usebruno/bruno | 8,213 | comment_to_fix | fix(size/L): Preserve folder order from seq attribute | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**JSDoc mentions files but implementation doesn't handle them.**
The JSDoc states the function orders "folders first...then requests...then code/data files (in their existing order)." However, the implementation only processes folders and requests. Any items that are ... | 13a48a256fc62c874c151b48052d114b0fb7da56 | 13cc6e52c8a6752fd31fb8262518e3063c238529 | diff --git a/packages/bruno-app/src/utils/collections/index.js b/packages/bruno-app/src/utils/collections/index.js
index 0b551b53b5c..ca51ed03d6b 100644
--- a/packages/bruno-app/src/utils/collections/index.js
+++ b/packages/bruno-app/src/utils/collections/index.js
@@ -888,6 +888,25 @@ export const isItemAFolder = (item... | [
"packages/bruno-app/src/utils/collections/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**JSDoc mentions files but implementation doesn't handle them.**\n\nThe JSDoc states the function orders \"folders first...then requests...then code/data files (in their existing order).\" However, the implementation only processes folders and r... | true | ||
usebruno/bruno | 8,213 | comment_to_fix | fix(size/L): Preserve folder order from seq attribute | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Consider eliminating the `new Function()` fallback by ensuring JSON-compatible jsesc output.**
The `new Function()` fallback is needed when jsesc emits JS-only escapes (e.g., `\x..`) that `JSON.parse` rejects. While the security risk is minimal here (parsing trusted... | 13a48a256fc62c874c151b48052d114b0fb7da56 | 13cc6e52c8a6752fd31fb8262518e3063c238529 | diff --git a/tests/collection/generate-docs/generate-docs.spec.ts b/tests/collection/generate-docs/generate-docs.spec.ts
new file mode 100644
index 00000000000..75de96a3ada
--- /dev/null
+++ b/tests/collection/generate-docs/generate-docs.spec.ts
@@ -0,0 +1,125 @@
+import jsyaml from 'js-yaml';
+import { test, expect } ... | [
"tests/collection/generate-docs/generate-docs.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Consider eliminating the `new Function()` fallback by ensuring JSON-compatible jsesc output.**\n\nThe `new Function()` fallback is needed when jsesc emits JS-only escapes (e.g., `\\x..`) that `JSON.parse` rejects. While the security risk is mi... | true | ||
usebruno/bruno | 8,212 | issue_to_patch | fix(SSE-text/event-stream): sse response body is empty in res.getBody() for app and cli | ### Description
[JIRA](https://usebruno.atlassian.net/browse/BRU-3465)
<!-- Explain here the changes your PR introduces and text to help us understand the context of this change. -->
## Bug
The desktop app always requests responses as a stream
(`responseType: 'stream'`). For non-streaming responses it drai... | 13a48a256fc62c874c151b48052d114b0fb7da56 | c58d24af88f2a29216bbcb1e60afcda7f5469fb5 | diff --git a/packages/bruno-electron/src/ipc/network/index.js b/packages/bruno-electron/src/ipc/network/index.js
index 92459f61d4f..5bef312e889 100644
--- a/packages/bruno-electron/src/ipc/network/index.js
+++ b/packages/bruno-electron/src/ipc/network/index.js
@@ -73,6 +73,12 @@ const hasStreamHeaders = (headers) => {
... | [
"packages/bruno-electron/src/ipc/network/index.js",
"packages/bruno-tests/collection/sse/sse finite stream.bru",
"packages/bruno-tests/src/sse/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add error handling for the close event handler.**\n\nTwo concerns:\n\n1. `runPostScripts().then()` at line 1257 lacks a `.catch()` handler. If `runPostScripts` rejects, it will result in an unhandled promise rejection.\n\n2. `Buffer.concat()` ... | true | ||
usebruno/bruno | 8,212 | comment_to_fix | fix(SSE-text/event-stream): sse response body is empty in res.getBody() for app and cli | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Add error handling for the close event handler.**
Two concerns:
1. `runPostScripts().then()` at line 1257 lacks a `.catch()` handler. If `runPostScripts` rejects, it will result in an unhandled promise rejection.
2. `Buffer.concat()` and `parseDataFromResponse()` ... | 13a48a256fc62c874c151b48052d114b0fb7da56 | c58d24af88f2a29216bbcb1e60afcda7f5469fb5 | diff --git a/packages/bruno-electron/src/ipc/network/index.js b/packages/bruno-electron/src/ipc/network/index.js
index 92459f61d4f..5bef312e889 100644
--- a/packages/bruno-electron/src/ipc/network/index.js
+++ b/packages/bruno-electron/src/ipc/network/index.js
@@ -73,6 +73,12 @@ const hasStreamHeaders = (headers) => {
... | [
"packages/bruno-electron/src/ipc/network/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add error handling for the close event handler.**\n\nTwo concerns:\n\n1. `runPostScripts().then()` at line 1257 lacks a `.catch()` handler. If `runPostScripts` rejects, it will result in an unhandled promise rejection.\n\n2. `Buffer.concat()` ... | true | ||
usebruno/bruno | 8,212 | comment_to_fix | fix(SSE-text/event-stream): sse response body is empty in res.getBody() for app and cli | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Optional chaining could silently fail to collect chunks.**
Using `response.sseChunks?.push(newData)` means that if `response.sseChunks` is undefined or null, the chunk will be silently dropped without any error or warning. This directly ties to the concern at line 1... | 13a48a256fc62c874c151b48052d114b0fb7da56 | c58d24af88f2a29216bbcb1e60afcda7f5469fb5 | diff --git a/packages/bruno-electron/src/ipc/network/index.js b/packages/bruno-electron/src/ipc/network/index.js
index 92459f61d4f..5bef312e889 100644
--- a/packages/bruno-electron/src/ipc/network/index.js
+++ b/packages/bruno-electron/src/ipc/network/index.js
@@ -73,6 +73,12 @@ const hasStreamHeaders = (headers) => {
... | [
"packages/bruno-electron/src/ipc/network/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Optional chaining could silently fail to collect chunks.**\n\nUsing `response.sseChunks?.push(newData)` means that if `response.sseChunks` is undefined or null, the chunk will be silently dropped without any error or warning. This directly tie... | true | ||
usebruno/bruno | 8,212 | comment_to_fix | fix(SSE-text/event-stream): sse response body is empty in res.getBody() for app and cli | Don't think we need to send this anywhere at least for now, without this the above and below should work | 13a48a256fc62c874c151b48052d114b0fb7da56 | c58d24af88f2a29216bbcb1e60afcda7f5469fb5 | diff --git a/packages/bruno-electron/src/ipc/network/index.js b/packages/bruno-electron/src/ipc/network/index.js
index 92459f61d4f..5bef312e889 100644
--- a/packages/bruno-electron/src/ipc/network/index.js
+++ b/packages/bruno-electron/src/ipc/network/index.js
@@ -73,6 +73,12 @@ const hasStreamHeaders = (headers) => {
... | [
"packages/bruno-electron/src/ipc/network/index.js"
] | [
{
"comment": "Don't think we need to send this anywhere at least for now, without this the above and below should work",
"path": "packages/bruno-electron/src/ipc/network/index.js",
"hunk": "@@ -1254,6 +1272,7 @@ const registerNetworkIpc = (mainWindow) => {\n headers: response.headers,\n ... | true | ||
usebruno/bruno | 8,212 | comment_to_fix | fix(SSE-text/event-stream): sse response body is empty in res.getBody() for app and cli | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Align route contract comment with implementation.**
Line 58 documents `?messages=...`, but the handler never reads query params and always streams hardcoded values. Either parse `req.query.messages` or remove that query-string claim to avoid a misleading API contrac... | 13a48a256fc62c874c151b48052d114b0fb7da56 | c58d24af88f2a29216bbcb1e60afcda7f5469fb5 | diff --git a/packages/bruno-tests/src/sse/index.js b/packages/bruno-tests/src/sse/index.js
index 0cd4cfb49ac..6b8b9ad4418 100644
--- a/packages/bruno-tests/src/sse/index.js
+++ b/packages/bruno-tests/src/sse/index.js
@@ -55,4 +55,27 @@ router.post('/reset', (req, res) => {
res.json({ message: 'Reset complete', activ... | [
"packages/bruno-tests/src/sse/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Align route contract comment with implementation.**\n\nLine 58 documents `?messages=...`, but the handler never reads query params and always streams hardcoded values. Either parse `req.query.messages` or remove that query-string claim to avoi... | true | ||
usebruno/bruno | 8,220 | issue_to_patch | feat: integrate AIAssist for script editing | ### Description
[JIRA](https://usebruno.atlassian.net/browse/BRU-3427)
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [ ] **The pull request only addresses one issue or adds one feature.**
- [ ] **The pull request does not introduce any breaking changes**
- [... | ed5f5c21cfceeea1a8519ad40acbf86adf0d1e09 | 86b7c48892d8985233d1a4cc6ee26bd86c98570c | diff --git a/packages/bruno-app/src/components/AIAssist/StyledWrapper.js b/packages/bruno-app/src/components/AIAssist/StyledWrapper.js
new file mode 100644
index 00000000000..443f40c989d
--- /dev/null
+++ b/packages/bruno-app/src/components/AIAssist/StyledWrapper.js
@@ -0,0 +1,298 @@
+import styled from 'styled-compone... | [
"packages/bruno-app/src/components/AIAssist/StyledWrapper.js",
"packages/bruno-app/src/components/AIAssist/index.js",
"packages/bruno-app/src/components/CollectionSettings/Script/index.js",
"packages/bruno-app/src/components/CollectionSettings/Tests/index.js",
"packages/bruno-app/src/components/FolderSettin... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add `data-testid` attributes for Playwright testing.**\n\nPer coding guidelines, testable elements must have `data-testid` for Playwright. Add them to key interactive elements:\n\n- Trigger button (line 134): `data-testid=\"ai-assist-trigger\"... | diff --git a/packages/bruno-app/src/components/CollectionSettings/Tests/index.js b/packages/bruno-app/src/components/CollectionSettings/Tests/index.js
index fcce927fd1c..b1708215432 100644
--- a/packages/bruno-app/src/components/CollectionSettings/Tests/index.js
+++ b/packages/bruno-app/src/components/CollectionSetting... | true | |
usebruno/bruno | 8,220 | comment_to_fix | feat: integrate AIAssist for script editing | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Add `data-testid` attributes for Playwright testing.**
Per coding guidelines, testable elements must have `data-testid` for Playwright. Add them to key interactive elements:
- Trigger button (line 134): `data-testid="ai-assist-trigger"`
- Popup (line 146): `data-te... | ed5f5c21cfceeea1a8519ad40acbf86adf0d1e09 | 86b7c48892d8985233d1a4cc6ee26bd86c98570c | diff --git a/packages/bruno-app/src/components/AIAssist/index.js b/packages/bruno-app/src/components/AIAssist/index.js
new file mode 100644
index 00000000000..c6362267a1a
--- /dev/null
+++ b/packages/bruno-app/src/components/AIAssist/index.js
@@ -0,0 +1,232 @@
+import React, { useCallback, useMemo, useRef, useState } f... | [
"packages/bruno-app/src/components/AIAssist/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add `data-testid` attributes for Playwright testing.**\n\nPer coding guidelines, testable elements must have `data-testid` for Playwright. Add them to key interactive elements:\n\n- Trigger button (line 134): `data-testid=\"ai-assist-trigger\"... | true | ||
usebruno/bruno | 8,220 | comment_to_fix | feat: integrate AIAssist for script editing | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Set temperature for consistent code generation.**
The `generateText` call at line 170 doesn't specify `temperature`, so it uses the library's default. For code generation, a lower temperature (0.2–0.3) produces more deterministic, structured output. The existing `re... | ed5f5c21cfceeea1a8519ad40acbf86adf0d1e09 | 86b7c48892d8985233d1a4cc6ee26bd86c98570c | diff --git a/packages/bruno-electron/src/ipc/ai/index.js b/packages/bruno-electron/src/ipc/ai/index.js
index 7f3636c2dcc..f418674e344 100644
--- a/packages/bruno-electron/src/ipc/ai/index.js
+++ b/packages/bruno-electron/src/ipc/ai/index.js
@@ -11,6 +11,7 @@ const {
getAvailableModels,
clearSdkCache
} = require(... | [
"packages/bruno-electron/src/ipc/ai/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Set temperature for consistent code generation.**\n\nThe `generateText` call at line 170 doesn't specify `temperature`, so it uses the library's default. For code generation, a lower temperature (0.2–0.3) produces more deterministic, structure... | true | ||
usebruno/bruno | 8,220 | comment_to_fix | feat: integrate AIAssist for script editing | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Reconsider the test prompt restriction on side effects.**
Line 106 instructs the AI: "Do NOT use `bru.setEnvVar` or other side-effecting calls inside tests." However, in Bruno workflows, tests commonly extract response data (tokens, IDs) and store them for subsequen... | ed5f5c21cfceeea1a8519ad40acbf86adf0d1e09 | 86b7c48892d8985233d1a4cc6ee26bd86c98570c | diff --git a/packages/bruno-electron/src/ipc/ai/script-prompts.js b/packages/bruno-electron/src/ipc/ai/script-prompts.js
new file mode 100644
index 00000000000..a5f2c3b06af
--- /dev/null
+++ b/packages/bruno-electron/src/ipc/ai/script-prompts.js
@@ -0,0 +1,207 @@
+const BRUNO_API_REFERENCE = `## Bruno API Reference
+
+... | [
"packages/bruno-electron/src/ipc/ai/script-prompts.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Reconsider the test prompt restriction on side effects.**\n\nLine 106 instructs the AI: \"Do NOT use `bru.setEnvVar` or other side-effecting calls inside tests.\" However, in Bruno workflows, tests commonly extract response data (tokens, IDs) ... | true | ||
usebruno/bruno | 8,220 | comment_to_fix | feat: integrate AIAssist for script editing | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Include GraphQL variables in request context.**
Line 172 extracts only `body.graphql?.query`, but GraphQL requests also include `variables` which provide essential parameter context for the AI. Update to:
```diff
- else if (body.mode === 'graphql') bodyText = bo... | ed5f5c21cfceeea1a8519ad40acbf86adf0d1e09 | 86b7c48892d8985233d1a4cc6ee26bd86c98570c | diff --git a/packages/bruno-electron/src/ipc/ai/script-prompts.js b/packages/bruno-electron/src/ipc/ai/script-prompts.js
new file mode 100644
index 00000000000..a5f2c3b06af
--- /dev/null
+++ b/packages/bruno-electron/src/ipc/ai/script-prompts.js
@@ -0,0 +1,207 @@
+const BRUNO_API_REFERENCE = `## Bruno API Reference
+
+... | [
"packages/bruno-electron/src/ipc/ai/script-prompts.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Include GraphQL variables in request context.**\n\nLine 172 extracts only `body.graphql?.query`, but GraphQL requests also include `variables` which provide essential parameter context for the AI. Update to:\n\n```diff\n- else if (body.mode... | true | ||
usebruno/bruno | 8,220 | comment_to_fix | feat: integrate AIAssist for script editing | Move this to the hidden elements `ref` block instead of waiting for the effect chain to fire | ed5f5c21cfceeea1a8519ad40acbf86adf0d1e09 | 86b7c48892d8985233d1a4cc6ee26bd86c98570c | diff --git a/packages/bruno-app/src/components/AIAssist/index.js b/packages/bruno-app/src/components/AIAssist/index.js
new file mode 100644
index 00000000000..c6362267a1a
--- /dev/null
+++ b/packages/bruno-app/src/components/AIAssist/index.js
@@ -0,0 +1,232 @@
+import React, { useCallback, useMemo, useRef, useState } f... | [
"packages/bruno-app/src/components/AIAssist/index.js"
] | [
{
"comment": "Move this to the hidden elements `ref` block instead of waiting for the effect chain to fire",
"path": "packages/bruno-app/src/components/AIAssist/index.js",
"hunk": "@@ -0,0 +1,241 @@\n+import React, { useCallback, useEffect, useMemo, useRef, useState } from 'react';\n+import { useSelecto... | true | ||
usebruno/bruno | 8,217 | issue_to_patch | Revert "fix: open panes at default size on expand from collapsed state" | Reverts usebruno/bruno#8133
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Bug Fixes**
* Request panes now properly preserve and restore their dimensions when collapsed and expanded, automatically maintaining your preferred layout.
* Fixed an unintended si... | 280b8568699d78dad5aaa742685eaca19ce50960 | d335cd147805e14940d079634ca70e78becfbf20 | diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/tabs.js b/packages/bruno-app/src/providers/ReduxStore/slices/tabs.js
index 7b9c24e3f8..afac7998ad 100644
--- a/packages/bruno-app/src/providers/ReduxStore/slices/tabs.js
+++ b/packages/bruno-app/src/providers/ReduxStore/slices/tabs.js
@@ -104,6 +104,8 @@ e... | [
"packages/bruno-app/src/providers/ReduxStore/slices/tabs.js",
"packages/bruno-app/src/providers/ReduxStore/slices/tabs.spec.js"
] | [] | diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/tabs.spec.js b/packages/bruno-app/src/providers/ReduxStore/slices/tabs.spec.js
deleted file mode 100644
index 0979483d5a..0000000000
--- a/packages/bruno-app/src/providers/ReduxStore/slices/tabs.spec.js
+++ /dev/null
@@ -1,59 +0,0 @@
-import reducer, {
- ... | true | |
usebruno/bruno | 8,133 | issue_to_patch | fix: open panes at default size on expand from collapsed state | ### Description
Fixed an issue where the Response Pane did not restore to its default width after being reopened from a collapsed state. This caused the pane content to render in a squished layout, with icons and content partially clipped.
[JIRA](https://usebruno.atlassian.net/browse/BRU-3352)
### Demo
https:... | b43a5e6e0a9ac3cc4b3ffd904a034d47240f22bf | a243f606ab06625d3544d9ad459aad65ca97d958 | diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/tabs.js b/packages/bruno-app/src/providers/ReduxStore/slices/tabs.js
index afac7998ad5..7b9c24e3f8c 100644
--- a/packages/bruno-app/src/providers/ReduxStore/slices/tabs.js
+++ b/packages/bruno-app/src/providers/ReduxStore/slices/tabs.js
@@ -104,8 +104,6 @@... | [
"packages/bruno-app/src/providers/ReduxStore/slices/tabs.js",
"packages/bruno-app/src/providers/ReduxStore/slices/tabs.spec.js"
] | [] | diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/tabs.spec.js b/packages/bruno-app/src/providers/ReduxStore/slices/tabs.spec.js
new file mode 100644
index 00000000000..0979483d5a0
--- /dev/null
+++ b/packages/bruno-app/src/providers/ReduxStore/slices/tabs.spec.js
@@ -0,0 +1,59 @@
+import reducer, {
+ co... | true | |
usebruno/bruno | 8,167 | issue_to_patch | fix(ui): prevent empty header row from persisting state and crashing CLI | **Jira Link: https://usebruno.atlassian.net/browse/BRU-3228**
### Description
Fixes inconsistent auto-append behavior in the editable table (Headers/Params). Previously a new empty row was only added when typing into the Name field; now it's added when typing into either Name or Value. Also removes stray empty ro... | 95c75c90c14efa2d3837407899788e339b851c5b | 5b2ac8276cc9c5e03680fa586e3b2ca83d05ce69 | diff --git a/packages/bruno-app/src/components/EditableTable/index.js b/packages/bruno-app/src/components/EditableTable/index.js
index 5dd24803f5d..bbf929d6e5b 100644
--- a/packages/bruno-app/src/components/EditableTable/index.js
+++ b/packages/bruno-app/src/components/EditableTable/index.js
@@ -168,6 +168,17 @@ const ... | [
"packages/bruno-app/src/components/EditableTable/index.js",
"tests/request/headers/auto-append-empty-header-row.spec.ts",
"tests/utils/page/actions.ts"
] | [
{
"comment": "@sharan-bruno remove page.pause()",
"path": "tests/request/headers/auto-append-empty-header-row.spec.ts",
"hunk": "@@ -0,0 +1,80 @@\n+import { test, expect } from '../../../playwright';\n+import {\n+ buildCommonLocators,\n+ closeAllCollections,\n+ createCollection,\n+ createFolder,\n+ ... | diff --git a/tests/request/headers/auto-append-empty-header-row.spec.ts b/tests/request/headers/auto-append-empty-header-row.spec.ts
new file mode 100644
index 00000000000..eb71d173706
--- /dev/null
+++ b/tests/request/headers/auto-append-empty-header-row.spec.ts
@@ -0,0 +1,79 @@
+import { test, expect } from '../../..... | true | |
usebruno/bruno | 8,167 | comment_to_fix | fix(ui): prevent empty header row from persisting state and crashing CLI | @sharan-bruno remove page.pause() | 95c75c90c14efa2d3837407899788e339b851c5b | 5b2ac8276cc9c5e03680fa586e3b2ca83d05ce69 | diff --git a/tests/request/headers/auto-append-empty-header-row.spec.ts b/tests/request/headers/auto-append-empty-header-row.spec.ts
new file mode 100644
index 00000000000..eb71d173706
--- /dev/null
+++ b/tests/request/headers/auto-append-empty-header-row.spec.ts
@@ -0,0 +1,79 @@
+import { test, expect } from '../../..... | [
"tests/request/headers/auto-append-empty-header-row.spec.ts"
] | [
{
"comment": "@sharan-bruno remove page.pause()",
"path": "tests/request/headers/auto-append-empty-header-row.spec.ts",
"hunk": "@@ -0,0 +1,80 @@\n+import { test, expect } from '../../../playwright';\n+import {\n+ buildCommonLocators,\n+ closeAllCollections,\n+ createCollection,\n+ createFolder,\n+ ... | true | ||
usebruno/bruno | 8,167 | comment_to_fix | fix(ui): prevent empty header row from persisting state and crashing CLI | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Keep the append trigger configurable.**
This change stops using the configured `col.isKeyField` metadata and treats any edited column as an append trigger. `isEmptyRow()` still keys emptiness off `col.isKeyField`, so the component now uses different rules for “this ... | 95c75c90c14efa2d3837407899788e339b851c5b | 5b2ac8276cc9c5e03680fa586e3b2ca83d05ce69 | diff --git a/packages/bruno-app/src/components/EditableTable/index.js b/packages/bruno-app/src/components/EditableTable/index.js
index 5dd24803f5d..bbf929d6e5b 100644
--- a/packages/bruno-app/src/components/EditableTable/index.js
+++ b/packages/bruno-app/src/components/EditableTable/index.js
@@ -168,6 +168,17 @@ const ... | [
"packages/bruno-app/src/components/EditableTable/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Keep the append trigger configurable.**\n\nThis change stops using the configured `col.isKeyField` metadata and treats any edited column as an append trigger. `isEmptyRow()` still keys emptiness off `col.isKeyField`, so the component now uses ... | true | ||
usebruno/bruno | 8,167 | comment_to_fix | fix(ui): prevent empty header row from persisting state and crashing CLI | _⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_
**Remove the leftover `page.pause()`.**
This will block the spec in automation and turn the new coverage into a CI blocker. As per coding guidelines, `tests/**/**.*`: "Avoid using `page.pause()` in code".
<details>
<summary>Suggested fix</summary>
```diff
- aw... | 95c75c90c14efa2d3837407899788e339b851c5b | 5b2ac8276cc9c5e03680fa586e3b2ca83d05ce69 | diff --git a/tests/request/headers/auto-append-empty-header-row.spec.ts b/tests/request/headers/auto-append-empty-header-row.spec.ts
new file mode 100644
index 00000000000..eb71d173706
--- /dev/null
+++ b/tests/request/headers/auto-append-empty-header-row.spec.ts
@@ -0,0 +1,79 @@
+import { test, expect } from '../../..... | [
"tests/request/headers/auto-append-empty-header-row.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_\n\n**Remove the leftover `page.pause()`.**\n\nThis will block the spec in automation and turn the new coverage into a CI blocker. As per coding guidelines, `tests/**/**.*`: \"Avoid using `page.pause()` in code\".\n\n \n<details>\n<summary>Sugges... | true | ||
usebruno/bruno | 8,167 | comment_to_fix | fix(ui): prevent empty header row from persisting state and crashing CLI | maybe redundant now!
With the new filter `updatedRows.filter(hasAnyValue)`, the pushed empty row is immediately filtered out. The `rowsWithEmpty` memo then appends a new empty row on the next render anyway. This push does nothing except allocate a throwaway object and a wasted UUID. The misleading comment ("Only add a... | 95c75c90c14efa2d3837407899788e339b851c5b | 5b2ac8276cc9c5e03680fa586e3b2ca83d05ce69 | diff --git a/packages/bruno-app/src/components/EditableTable/index.js b/packages/bruno-app/src/components/EditableTable/index.js
index 5dd24803f5d..bbf929d6e5b 100644
--- a/packages/bruno-app/src/components/EditableTable/index.js
+++ b/packages/bruno-app/src/components/EditableTable/index.js
@@ -168,6 +168,17 @@ const ... | [
"packages/bruno-app/src/components/EditableTable/index.js"
] | [
{
"comment": "maybe redundant now!\n\nWith the new filter `updatedRows.filter(hasAnyValue)`, the pushed empty row is immediately filtered out. The `rowsWithEmpty` memo then appends a new empty row on the next render anyway. This push does nothing except allocate a throwaway object and a wasted UUID. The mislead... | true | ||
usebruno/bruno | 8,167 | comment_to_fix | fix(ui): prevent empty header row from persisting state and crashing CLI | please verify,
**rowsWithEmpty can show duplicate empty rows on initial render**
The removed check prevented appending an empty row when the last row's key field was already empty. Without it, if rows from the parent contains a stray empty row (the exact corrupted state this PR fixes), the memo will append another emp... | 95c75c90c14efa2d3837407899788e339b851c5b | 5b2ac8276cc9c5e03680fa586e3b2ca83d05ce69 | diff --git a/packages/bruno-app/src/components/EditableTable/index.js b/packages/bruno-app/src/components/EditableTable/index.js
index 5dd24803f5d..bbf929d6e5b 100644
--- a/packages/bruno-app/src/components/EditableTable/index.js
+++ b/packages/bruno-app/src/components/EditableTable/index.js
@@ -168,6 +168,17 @@ const ... | [
"packages/bruno-app/src/components/EditableTable/index.js"
] | [
{
"comment": "please verify,\n**rowsWithEmpty can show duplicate empty rows on initial render**\n\nThe removed check prevented appending an empty row when the last row's key field was already empty. Without it, if rows from the parent contains a stray empty row (the exact corrupted state this PR fixes), the mem... | true | ||
usebruno/bruno | 8,167 | comment_to_fix | fix(ui): prevent empty header row from persisting state and crashing CLI | isEmptyRow is now inconsistent with hasAnyValue | 95c75c90c14efa2d3837407899788e339b851c5b | 5b2ac8276cc9c5e03680fa586e3b2ca83d05ce69 | diff --git a/packages/bruno-app/src/components/EditableTable/index.js b/packages/bruno-app/src/components/EditableTable/index.js
index 5dd24803f5d..bbf929d6e5b 100644
--- a/packages/bruno-app/src/components/EditableTable/index.js
+++ b/packages/bruno-app/src/components/EditableTable/index.js
@@ -168,6 +168,17 @@ const ... | [
"packages/bruno-app/src/components/EditableTable/index.js"
] | [
{
"comment": "isEmptyRow is now inconsistent with hasAnyValue",
"path": "packages/bruno-app/src/components/EditableTable/index.js",
"hunk": "",
"resolving_sha": "5b2ac8276cc9c5e03680fa586e3b2ca83d05ce69",
"resolving_diff": "diff --git a/packages/bruno-app/src/components/EditableTable/index.js b/... | true | ||
usebruno/bruno | 8,167 | comment_to_fix | fix(ui): prevent empty header row from persisting state and crashing CLI | please add a comment on why we are choosing row - 1 | 95c75c90c14efa2d3837407899788e339b851c5b | 5b2ac8276cc9c5e03680fa586e3b2ca83d05ce69 | diff --git a/tests/utils/page/actions.ts b/tests/utils/page/actions.ts
index f9874f88d31..12d909afc2f 100644
--- a/tests/utils/page/actions.ts
+++ b/tests/utils/page/actions.ts
@@ -1118,13 +1118,17 @@ const addMultipartFileToLastRow = async (page: Page, electronApp: ElectronApplic
await mockBrowseFiles(electronApp... | [
"tests/utils/page/actions.ts"
] | [
{
"comment": "please add a comment on why we are choosing row - 1",
"path": "tests/utils/page/actions.ts",
"hunk": "@@ -1118,13 +1118,14 @@ const addMultipartFileToLastRow = async (page: Page, electronApp: ElectronApplic\n await mockBrowseFiles(electronApp, [filePath]);\n \n const table = buildC... | true | ||
usebruno/bruno | 8,167 | comment_to_fix | fix(ui): prevent empty header row from persisting state and crashing CLI | hasAnyValue treats false as "no value" , boolean false is treated as "no value." , disabled check box can cause issues, please check | 95c75c90c14efa2d3837407899788e339b851c5b | 5b2ac8276cc9c5e03680fa586e3b2ca83d05ce69 | diff --git a/packages/bruno-app/src/components/EditableTable/index.js b/packages/bruno-app/src/components/EditableTable/index.js
index 5dd24803f5d..bbf929d6e5b 100644
--- a/packages/bruno-app/src/components/EditableTable/index.js
+++ b/packages/bruno-app/src/components/EditableTable/index.js
@@ -168,6 +168,17 @@ const ... | [
"packages/bruno-app/src/components/EditableTable/index.js"
] | [
{
"comment": "hasAnyValue treats false as \"no value\" , boolean false is treated as \"no value.\" , disabled check box can cause issues, please check",
"path": "packages/bruno-app/src/components/EditableTable/index.js",
"hunk": "@@ -177,16 +188,11 @@ const EditableTable = ({\n return [createEmpty... | true | ||
usebruno/bruno | 8,167 | comment_to_fix | fix(ui): prevent empty header row from persisting state and crashing CLI | is is possible to use getByTestId here instead of `.locator('[data-testid="column-name"] .CodeMirror')`, applicable to rest of the places too, whereever it is applicable | 95c75c90c14efa2d3837407899788e339b851c5b | 5b2ac8276cc9c5e03680fa586e3b2ca83d05ce69 | diff --git a/tests/request/headers/auto-append-empty-header-row.spec.ts b/tests/request/headers/auto-append-empty-header-row.spec.ts
new file mode 100644
index 00000000000..eb71d173706
--- /dev/null
+++ b/tests/request/headers/auto-append-empty-header-row.spec.ts
@@ -0,0 +1,79 @@
+import { test, expect } from '../../..... | [
"tests/request/headers/auto-append-empty-header-row.spec.ts"
] | [
{
"comment": "is is possible to use getByTestId here instead of `.locator('[data-testid=\"column-name\"] .CodeMirror')`, applicable to rest of the places too, whereever it is applicable",
"path": "tests/request/headers/auto-append-empty-header-row.spec.ts",
"hunk": "@@ -0,0 +1,79 @@\n+import { test, exp... | true | ||
usebruno/bruno | 8,169 | issue_to_patch | fix(cli): use path name for classname in JUnit reports instead of request URL | **Jira link: https://usebruno.atlassian.net/browse/BRU-3123**
### Description
The CLI's JUnit reporter used the request URL as the classname on each <testcase>. Since URLs change per environment/region, the same test produced duplicate entries in CI tools (Xray, Azure DevOps) that key tests by classname + name.
... | 6f47218a81b744a900132a34203426ce95e7f918 | fa5e05e509997174d9ae555a38ff65ff3a147d8a | diff --git a/packages/bruno-cli/src/reporters/junit.js b/packages/bruno-cli/src/reporters/junit.js
index 71d523b942a..3a6611ba603 100644
--- a/packages/bruno-cli/src/reporters/junit.js
+++ b/packages/bruno-cli/src/reporters/junit.js
@@ -1,6 +1,7 @@
const os = require('os');
const fs = require('fs');
const xmlbuilder... | [
"packages/bruno-cli/src/reporters/junit.js",
"packages/bruno-cli/tests/reporters/junit.spec.js",
"tests/runner/collection-run-report/collection-run-report.spec.ts",
"tests/runner/collection-run-report/collection-run-report.spec.ts-snapshots/cli-junit-report-default-darwin.xml",
"tests/runner/collection-run-... | [
{
"comment": "have we decided on what should be the classname? path or the name?",
"path": "packages/bruno-cli/src/reporters/junit.js",
"hunk": "@@ -15,6 +15,7 @@ const makeJUnitOutput = async (results, outputPath) => {\n const testCount = result.testResults ? result.testResults.length : 0;\n co... | diff --git a/packages/bruno-cli/tests/reporters/junit.spec.js b/packages/bruno-cli/tests/reporters/junit.spec.js
index 30430b370af..f53d3710aac 100644
--- a/packages/bruno-cli/tests/reporters/junit.spec.js
+++ b/packages/bruno-cli/tests/reporters/junit.spec.js
@@ -103,6 +103,36 @@ describe('makeJUnitOutput', () => {
... | true | |
usebruno/bruno | 8,169 | comment_to_fix | fix(cli): use path name for classname in JUnit reports instead of request URL | have we decided on what should be the classname? path or the name? | 6f47218a81b744a900132a34203426ce95e7f918 | fa5e05e509997174d9ae555a38ff65ff3a147d8a | diff --git a/packages/bruno-cli/src/reporters/junit.js b/packages/bruno-cli/src/reporters/junit.js
index 71d523b942a..3a6611ba603 100644
--- a/packages/bruno-cli/src/reporters/junit.js
+++ b/packages/bruno-cli/src/reporters/junit.js
@@ -1,6 +1,7 @@
const os = require('os');
const fs = require('fs');
const xmlbuilder... | [
"packages/bruno-cli/src/reporters/junit.js"
] | [
{
"comment": "have we decided on what should be the classname? path or the name?",
"path": "packages/bruno-cli/src/reporters/junit.js",
"hunk": "@@ -15,6 +15,7 @@ const makeJUnitOutput = async (results, outputPath) => {\n const testCount = result.testResults ? result.testResults.length : 0;\n co... | true | ||
usebruno/bruno | 8,169 | comment_to_fix | fix(cli): use path name for classname in JUnit reports instead of request URL | we need to update the snapshots fro junit playwright tests we have | 6f47218a81b744a900132a34203426ce95e7f918 | fa5e05e509997174d9ae555a38ff65ff3a147d8a | diff --git a/packages/bruno-cli/src/reporters/junit.js b/packages/bruno-cli/src/reporters/junit.js
index 71d523b942a..3a6611ba603 100644
--- a/packages/bruno-cli/src/reporters/junit.js
+++ b/packages/bruno-cli/src/reporters/junit.js
@@ -1,6 +1,7 @@
const os = require('os');
const fs = require('fs');
const xmlbuilder... | [
"packages/bruno-cli/src/reporters/junit.js"
] | [
{
"comment": "we need to update the snapshots fro junit playwright tests we have",
"path": "packages/bruno-cli/src/reporters/junit.js",
"hunk": "@@ -34,7 +35,7 @@ const makeJUnitOutput = async (results, outputPath) => {\n const testcase = {\n '@name': `${assertion.lhsExpr} ${assertion.rhsE... | true | ||
usebruno/bruno | 8,169 | comment_to_fix | fix(cli): use path name for classname in JUnit reports instead of request URL | check if this regex works fine! it seems like it is different from the prev version of it `/classname="[^"]*[\\/][^"]*"/g` | 6f47218a81b744a900132a34203426ce95e7f918 | fa5e05e509997174d9ae555a38ff65ff3a147d8a | diff --git a/tests/runner/collection-run-report/collection-run-report.spec.ts b/tests/runner/collection-run-report/collection-run-report.spec.ts
index 8d710b3a102..2121ec3209a 100644
--- a/tests/runner/collection-run-report/collection-run-report.spec.ts
+++ b/tests/runner/collection-run-report/collection-run-report.spe... | [
"tests/runner/collection-run-report/collection-run-report.spec.ts"
] | [
{
"comment": "check if this regex works fine! it seems like it is different from the prev version of it `/classname=\"[^\"]*[\\\\/][^\"]*\"/g`",
"path": "tests/runner/collection-run-report/collection-run-report.spec.ts",
"hunk": "@@ -13,8 +13,9 @@ function normalizeJunitReport(xmlContent: string): strin... | true | ||
usebruno/bruno | 8,203 | issue_to_patch | fix(grpc): gRPC request loses all messages except the first on save for yaml collection | **Jira link: https://usebruno.atlassian.net/browse/BRU-3271**
### Description
In YAML collections, saving a gRPC request with multiple client messages only persisted the first message. On reload, all additional messages were lost.
This happened because both the YAML stringifier and parser handled grpc.message ... | 95c75c90c14efa2d3837407899788e339b851c5b | d035be29be6d87326b6a17b29762be5e246c8dab | diff --git a/packages/bruno-app/src/components/RequestPane/GrpcBody/index.js b/packages/bruno-app/src/components/RequestPane/GrpcBody/index.js
index 0433da1cdd3..8261d3755b0 100644
--- a/packages/bruno-app/src/components/RequestPane/GrpcBody/index.js
+++ b/packages/bruno-app/src/components/RequestPane/GrpcBody/index.js... | [
"packages/bruno-app/src/components/RequestPane/GrpcBody/index.js",
"packages/bruno-app/src/components/Sidebar/CreateCollection/index.js",
"packages/bruno-filestore/src/formats/yml/items/parseGrpcRequest.ts",
"packages/bruno-filestore/src/formats/yml/items/stringifyGrpcRequest.ts",
"tests/grpc/multi-message-... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Consider validating array element structure before casting.**\n\nLine 62 casts `rawMessage` to `GrpcMessageVariant[]` without runtime validation. If the YAML contains malformed message objects (e.g., missing `message` field or wrong shape), th... | diff --git a/tests/grpc/multi-message-yml/multi-message.spec.ts b/tests/grpc/multi-message-yml/multi-message.spec.ts
new file mode 100644
index 00000000000..401861d3dc6
--- /dev/null
+++ b/tests/grpc/multi-message-yml/multi-message.spec.ts
@@ -0,0 +1,70 @@
+import fs from 'node:fs';
+import path from 'node:path';
+impo... | true | |
usebruno/bruno | 8,203 | comment_to_fix | fix(grpc): gRPC request loses all messages except the first on save for yaml collection | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Consider validating array element structure before casting.**
Line 62 casts `rawMessage` to `GrpcMessageVariant[]` without runtime validation. If the YAML contains malformed message objects (e.g., missing `message` field or wrong shape), the map will silently procee... | 95c75c90c14efa2d3837407899788e339b851c5b | d035be29be6d87326b6a17b29762be5e246c8dab | diff --git a/packages/bruno-filestore/src/formats/yml/items/parseGrpcRequest.ts b/packages/bruno-filestore/src/formats/yml/items/parseGrpcRequest.ts
index f38a6ffe4c5..9ed478f7dad 100644
--- a/packages/bruno-filestore/src/formats/yml/items/parseGrpcRequest.ts
+++ b/packages/bruno-filestore/src/formats/yml/items/parseGr... | [
"packages/bruno-filestore/src/formats/yml/items/parseGrpcRequest.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Consider validating array element structure before casting.**\n\nLine 62 casts `rawMessage` to `GrpcMessageVariant[]` without runtime validation. If the YAML contains malformed message objects (e.g., missing `message` field or wrong shape), th... | true | ||
usebruno/bruno | 8,203 | comment_to_fix | fix(grpc): gRPC request loses all messages except the first on save for yaml collection | @sharan-bruno please use common locators within actions too | 95c75c90c14efa2d3837407899788e339b851c5b | d035be29be6d87326b6a17b29762be5e246c8dab | diff --git a/tests/utils/page/actions.ts b/tests/utils/page/actions.ts
index f9874f88d31..136d046eece 100644
--- a/tests/utils/page/actions.ts
+++ b/tests/utils/page/actions.ts
@@ -1,10 +1,12 @@
import { test, expect, Page, ElectronApplication, waitForReadyPage as waitForReadyPageImpl } from '../../../playwright';
im... | [
"tests/utils/page/actions.ts"
] | [
{
"comment": "@sharan-bruno please use common locators within actions too",
"path": "tests/utils/page/actions.ts",
"hunk": "@@ -1335,6 +1335,42 @@ const saveRequest = async (page: Page) => {\n });\n };\n \n+/**\n+ * Click the gRPC \"Add Message\" button to append a new message to the request\n+ * @par... | true | ||
usebruno/bruno | 8,203 | comment_to_fix | fix(grpc): gRPC request loses all messages except the first on save for yaml collection | can you extract this fileType to the top of the file | 95c75c90c14efa2d3837407899788e339b851c5b | d035be29be6d87326b6a17b29762be5e246c8dab | diff --git a/tests/utils/page/actions.ts b/tests/utils/page/actions.ts
index f9874f88d31..136d046eece 100644
--- a/tests/utils/page/actions.ts
+++ b/tests/utils/page/actions.ts
@@ -1,10 +1,12 @@
import { test, expect, Page, ElectronApplication, waitForReadyPage as waitForReadyPageImpl } from '../../../playwright';
im... | [
"tests/utils/page/actions.ts"
] | [
{
"comment": "can you extract this fileType to the top of the file",
"path": "tests/utils/page/actions.ts",
"hunk": "@@ -101,9 +101,9 @@ const createCollection = async (\n page,\n collectionName: string,\n collectionLocation: string,\n- format?: 'bru' | 'yml'\n+ format: 'bru' | 'yml' = 'yml'",
... | true | ||
usebruno/bruno | 8,136 | issue_to_patch | Generate code fails for requests with queries that contain percent character (%)
[JIRA](https://usebruno.atlassian.net/browse/BRU-3242)
### I have checked the following:
- [x] I have searched existing issues and found nothing related to my issue.
### This bug is:
- [ ] making Bruno unusable for me
- [x] slowing me... | fix(generate-code)!: generate code URL issues | ### Description
BREAKING CHANGES for how encoding works in URL and in Code Generation
[JIRA](https://usebruno.atlassian.net/browse/BRU-3242)
Fixes : #6915, #7913, #8107, #4989, #6268, #7653, #5788, #6915, #5919
### Problem
#### Bruno's URL encoding had four overlapping bugs:
- Path-param values like :id... | 49088e98c8e829935c2587331c5ede13c46adcda | 40b737be207b7f72d2a404298068061d9de5b27e | diff --git a/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/utils/snippet-generator.js b/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/utils/snippet-generator.js
index 2feaab2faf8..0712b1c53ff 100644
--- a/packages/brun... | [
"packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/utils/snippet-generator.js",
"packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/utils/snippet-generator.spec.js",
"packages/bruno-app/src/providers/ReduxStore/slices/c... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Pass real path params to `buildHar()` instead of an empty array.**\n\nOn Line 59, `pathParams: []` drops path-param substitution when `item.rawUrl` is missing, which can leave `:param` unresolved/encoded in generated snippets and break snippet... | diff --git a/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/utils/snippet-generator.spec.js b/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/utils/snippet-generator.spec.js
index 0a282245154..cc08aad55c9 100644
--- a/pac... | true |
usebruno/bruno | 8,136 | comment_to_fix | fix(generate-code)!: generate code URL issues | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Pass real path params to `buildHar()` instead of an empty array.**
On Line 59, `pathParams: []` drops path-param substitution when `item.rawUrl` is missing, which can leave `:param` unresolved/encoded in generated snippets and break snippet/runtime parity.
<detai... | 49088e98c8e829935c2587331c5ede13c46adcda | 40b737be207b7f72d2a404298068061d9de5b27e | diff --git a/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/utils/snippet-generator.js b/packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/utils/snippet-generator.js
index 2feaab2faf8..0712b1c53ff 100644
--- a/packages/brun... | [
"packages/bruno-app/src/components/Sidebar/Collections/Collection/CollectionItem/GenerateCodeItem/utils/snippet-generator.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Pass real path params to `buildHar()` instead of an empty array.**\n\nOn Line 59, `pathParams: []` drops path-param substitution when `item.rawUrl` is missing, which can leave `:param` unresolved/encoded in generated snippets and break snippet... | true | ||
usebruno/bruno | 8,136 | comment_to_fix | fix(generate-code)!: generate code URL issues | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🌐 Web query:
`What does JavaScript `encodeURIComponent(undefined)` return, and does `String.prototype.replace(..., undefined)` insert the literal string "undefined"?`
💡 Result:
JavaScript `encodeURIComponent(undefine... | 49088e98c8e829935c2587331c5ede13c46adcda | 40b737be207b7f72d2a404298068061d9de5b27e | diff --git a/packages/bruno-app/src/utils/url/index.js b/packages/bruno-app/src/utils/url/index.js
index 71018612747..db6ca7b620a 100644
--- a/packages/bruno-app/src/utils/url/index.js
+++ b/packages/bruno-app/src/utils/url/index.js
@@ -111,6 +111,11 @@ export const interpolateUrl = ({ url, variables }) => {
};
exp... | [
"packages/bruno-app/src/utils/url/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`What does JavaScript `encodeURIComponent(undefined)` return, and does `String.prototype.replace(..., undefined)` insert the literal string \"undefined\"?`\n\n💡 Result:\n\nJava... | true | ||
usebruno/bruno | 8,136 | comment_to_fix | fix(generate-code)!: generate code URL issues | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Use `enabled !== false` when deciding interpolation.**
On Line 225 and Line 233, interpolation is gated by `p.enabled` truthiness. Entries with `enabled` omitted are treated as disabled, unlike the rest of this file where default-enabled means `enabled !== false`.
... | 49088e98c8e829935c2587331c5ede13c46adcda | 40b737be207b7f72d2a404298068061d9de5b27e | diff --git a/packages/bruno-common/src/generate-code/har/index.ts b/packages/bruno-common/src/generate-code/har/index.ts
new file mode 100644
index 00000000000..23afc678b2a
--- /dev/null
+++ b/packages/bruno-common/src/generate-code/har/index.ts
@@ -0,0 +1,655 @@
+/**
+ * Bruno → HAR generation.
+ *
+ * This module is ... | [
"packages/bruno-common/src/generate-code/har/index.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Use `enabled !== false` when deciding interpolation.**\n\nOn Line 225 and Line 233, interpolation is gated by `p.enabled` truthiness. Entries with `enabled` omitted are treated as disabled, unlike the rest of this file where default-enabled me... | true | ||
usebruno/bruno | 8,136 | comment_to_fix | fix(generate-code)!: generate code URL issues | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Preserve duplicate keys in `formUrlEncoded` serialization.**
On Line 518-524, reducing to an object (`Record<string, string>`) overwrites repeated field names, so `a=1&a=2` becomes only one entry in `postData.text`. This breaks valid form payloads and can desync sni... | 49088e98c8e829935c2587331c5ede13c46adcda | 40b737be207b7f72d2a404298068061d9de5b27e | diff --git a/packages/bruno-common/src/generate-code/har/index.ts b/packages/bruno-common/src/generate-code/har/index.ts
new file mode 100644
index 00000000000..23afc678b2a
--- /dev/null
+++ b/packages/bruno-common/src/generate-code/har/index.ts
@@ -0,0 +1,655 @@
+/**
+ * Bruno → HAR generation.
+ *
+ * This module is ... | [
"packages/bruno-common/src/generate-code/har/index.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Preserve duplicate keys in `formUrlEncoded` serialization.**\n\nOn Line 518-524, reducing to an object (`Record<string, string>`) overwrites repeated field names, so `a=1&a=2` becomes only one entry in `postData.text`. This breaks valid form p... | true | ||
usebruno/bruno | 8,136 | comment_to_fix | fix(generate-code)!: generate code URL issues | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Assert `%23` for ON-mode `#` scenarios.**
Line 130 and Line 149 expect raw `#`, but the ON-mode contract in this PR is to encode `#` as `%23`. These checks should validate the encoded form to catch regressions correctly.
<details>
<summary>Suggested fix</summary>... | 49088e98c8e829935c2587331c5ede13c46adcda | 40b737be207b7f72d2a404298068061d9de5b27e | diff --git a/tests/request/generate-code/send-vs-snippet.spec.ts b/tests/request/generate-code/send-vs-snippet.spec.ts
new file mode 100644
index 00000000000..1919444b2c0
--- /dev/null
+++ b/tests/request/generate-code/send-vs-snippet.spec.ts
@@ -0,0 +1,183 @@
+import { expect, Page, test } from '../../../playwright';
... | [
"tests/request/generate-code/send-vs-snippet.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Assert `%23` for ON-mode `#` scenarios.**\n\nLine 130 and Line 149 expect raw `#`, but the ON-mode contract in this PR is to encode `#` as `%23`. These checks should validate the encoded form to catch regressions correctly.\n\n \n<details>\n<s... | true | ||
usebruno/bruno | 8,136 | comment_to_fix | fix(generate-code)!: generate code URL issues | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Wait for the dialog to close, not just the close button.**
On Line 1558, waiting for `modal.closeButton()` to be hidden can pass while dialog teardown is still in progress. Waiting on the dialog element is more reliable for subsequent actions.
<details>
<summary>... | 49088e98c8e829935c2587331c5ede13c46adcda | 40b737be207b7f72d2a404298068061d9de5b27e | diff --git a/tests/utils/page/actions.ts b/tests/utils/page/actions.ts
index 11f14cb20d8..0affab6577d 100644
--- a/tests/utils/page/actions.ts
+++ b/tests/utils/page/actions.ts
@@ -1527,6 +1527,78 @@ const openExampleFromSidebar = async (page: Page, requestName: string, exampleNa
await exampleRow.click();
};
+/**... | [
"tests/utils/page/actions.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Wait for the dialog to close, not just the close button.**\n\nOn Line 1558, waiting for `modal.closeButton()` to be hidden can pass while dialog teardown is still in progress. Waiting on the dialog element is more reliable for subsequent actio... | true | ||
usebruno/bruno | 8,136 | comment_to_fix | fix(generate-code)!: generate code URL issues | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Add a visibility wait before clicking the folder request row.**
On Line 1579, `requestRow.click()` is executed without asserting the row is visible after Line 1572. This can intermittently fail when sidebar expansion/render is delayed.
<details>
<summary>Suggeste... | 49088e98c8e829935c2587331c5ede13c46adcda | 40b737be207b7f72d2a404298068061d9de5b27e | diff --git a/tests/utils/page/actions.ts b/tests/utils/page/actions.ts
index 11f14cb20d8..0affab6577d 100644
--- a/tests/utils/page/actions.ts
+++ b/tests/utils/page/actions.ts
@@ -1527,6 +1527,78 @@ const openExampleFromSidebar = async (page: Page, requestName: string, exampleNa
await exampleRow.click();
};
+/**... | [
"tests/utils/page/actions.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Add a visibility wait before clicking the folder request row.**\n\nOn Line 1579, `requestRow.click()` is executed without asserting the row is visible after Line 1572. This can intermittently fail when sidebar expansion/render is delayed.\n\n ... | true | ||
usebruno/bruno | 8,202 | issue_to_patch | fix(tests): update timeline item locators and improve response status code assertion | **Jira link: https://usebruno.atlassian.net/browse/BRU-3386**
### Description
Switch Timeline E2E locators to data-testids (added timeline-item / timeline-item-header) so they no longer break on CSS-class refactors and Playwrite test scrips failing issue fixed
#### Contribution Checklist:
- [ ] **I've used ... | b9ee1ee5233b98ea3ed0c84e1f7a3fc82934d814 | 9c44b253d3a3bd2ab009a141e65aa65663e1c192 | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/index.js b/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/index.js
index 65fd87e1df..55a0273b9d 100644
--- a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/index.js
+++ b/packages/bruno-app/src/... | [
"packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/index.js",
"packages/bruno-app/src/components/ResponsePane/Timeline/index.js",
"tests/auth/auth-mode/folder-no-auth-stops-inheritance.spec.ts",
"tests/utils/page/locators.ts"
] | [] | diff --git a/tests/auth/auth-mode/folder-no-auth-stops-inheritance.spec.ts b/tests/auth/auth-mode/folder-no-auth-stops-inheritance.spec.ts
index 3d4d5abfa5..621f360de8 100644
--- a/tests/auth/auth-mode/folder-no-auth-stops-inheritance.spec.ts
+++ b/tests/auth/auth-mode/folder-no-auth-stops-inheritance.spec.ts
@@ -62,7 ... | true | |
usebruno/bruno | 8,201 | issue_to_patch | fix(tests): update locators for save button in presets indicator tests | **Jira link: https://usebruno.atlassian.net/browse/BRU-3386**
### Description
changed the locators name preset.save() to preset.saveBtn()
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [x] **The pull request only addresses one issue or adds one feature.**
-... | 2d4d4e4037f993966f2e6b8feb9b9deb8dba2b6a | 36de8ac786bd7f07a82b6a7c8a626a583da52a8b | [
"tests/collection/presets-indicator.spec.ts",
"tests/utils/page/locators.ts"
] | [] | diff --git a/tests/collection/presets-indicator.spec.ts b/tests/collection/presets-indicator.spec.ts
index d6ef97a24a..37cc56e593 100644
--- a/tests/collection/presets-indicator.spec.ts
+++ b/tests/collection/presets-indicator.spec.ts
@@ -40,7 +40,7 @@ test.describe('Presets status dot in collection settings', () => {
... | true | ||
usebruno/bruno | 7,466 | issue_to_patch | test(core): current mount pipeline | ### Description
[JIRA](https://usebruno.atlassian.net/browse/BRU-3240)
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [ ] **The pull request only addresses one issue or adds one feature.**
- [ ] **The pull request does not introduce any breaking changes**
- [... | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | [
"tests/mounting/fixtures/method-indicators/bru/DELETE-Request.bru",
"tests/mounting/fixtures/method-indicators/bru/GET-Request.bru",
"tests/mounting/fixtures/method-indicators/bru/PATCH-Request.bru",
"tests/mounting/fixtures/method-indicators/bru/POST-Request.bru",
"tests/mounting/fixtures/method-indicators... | [
{
"comment": "To wide a boundary if you have 2 or more collections with the same folder name, this might pick the wrong one. You might wanna reuse/add a `openFolder` that takes the collection in consideration as well.",
"path": "tests/utils/page/mounting.ts",
"hunk": "@@ -0,0 +1,454 @@\n+import { test, ... | diff --git a/tests/mounting/fixtures/method-indicators/bru/DELETE-Request.bru b/tests/mounting/fixtures/method-indicators/bru/DELETE-Request.bru
new file mode 100644
index 0000000000..a813919ce1
--- /dev/null
+++ b/tests/mounting/fixtures/method-indicators/bru/DELETE-Request.bru
@@ -0,0 +1,11 @@
+meta {
+ name: DELETE... | true | ||
usebruno/bruno | 7,466 | comment_to_fix | test(core): current mount pipeline | To wide a boundary if you have 2 or more collections with the same folder name, this might pick the wrong one. You might wanna reuse/add a `openFolder` that takes the collection in consideration as well. | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | diff --git a/tests/utils/page/mounting.ts b/tests/utils/page/mounting.ts
new file mode 100644
index 0000000000..57f3207138
--- /dev/null
+++ b/tests/utils/page/mounting.ts
@@ -0,0 +1,414 @@
+import { test, expect, Page, ElectronApplication } from '../../../playwright';
+
+/**
+ * Collection tree item structure for asse... | [
"tests/utils/page/mounting.ts"
] | [
{
"comment": "To wide a boundary if you have 2 or more collections with the same folder name, this might pick the wrong one. You might wanna reuse/add a `openFolder` that takes the collection in consideration as well.",
"path": "tests/utils/page/mounting.ts",
"hunk": "@@ -0,0 +1,454 @@\n+import { test, ... | true | ||
usebruno/bruno | 7,466 | comment_to_fix | test(core): current mount pipeline | same problem as folder, this needs to be scoped to a collection/request row instead of globally searching for it in the sidebar | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | diff --git a/tests/utils/page/mounting.ts b/tests/utils/page/mounting.ts
new file mode 100644
index 0000000000..57f3207138
--- /dev/null
+++ b/tests/utils/page/mounting.ts
@@ -0,0 +1,414 @@
+import { test, expect, Page, ElectronApplication } from '../../../playwright';
+
+/**
+ * Collection tree item structure for asse... | [
"tests/utils/page/mounting.ts"
] | [
{
"comment": "same problem as folder, this needs to be scoped to a collection/request row instead of globally searching for it in the sidebar",
"path": "tests/utils/page/mounting.ts",
"hunk": "@@ -0,0 +1,454 @@\n+import { test, expect, Page, ElectronApplication } from '../../../playwright';\n+\n+/**\n+ ... | true | ||
usebruno/bruno | 7,466 | comment_to_fix | test(core): current mount pipeline | edge case but if the yml one throws , the bru one was still created and is left in the tmp dirs, can we just add a helper to make sure that if either fails and the `cleanup` function for the other is returned, you exec the cleanup.
Something like this or if there's a better way then that
```suggestion
const bru = ... | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | diff --git a/tests/utils/fixtures/generator.ts b/tests/utils/fixtures/generator.ts
new file mode 100644
index 0000000000..2fa664d468
--- /dev/null
+++ b/tests/utils/fixtures/generator.ts
@@ -0,0 +1,681 @@
+import * as fs from 'fs';
+import * as path from 'path';
+import * as os from 'os';
+
+export type CollectionForma... | [
"tests/utils/fixtures/generator.ts"
] | [
{
"comment": "edge case but if the yml one throws , the bru one was still created and is left in the tmp dirs, can we just add a helper to make sure that if either fails and the `cleanup` function for the other is returned, you exec the cleanup. \n\nSomething like this or if there's a better way then that\n\n``... | true | ||
usebruno/bruno | 7,466 | comment_to_fix | test(core): current mount pipeline | Same as before comments, this could be anything in the generated set of collections if there's more than one | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | diff --git a/tests/utils/page/mounting.ts b/tests/utils/page/mounting.ts
new file mode 100644
index 0000000000..57f3207138
--- /dev/null
+++ b/tests/utils/page/mounting.ts
@@ -0,0 +1,414 @@
+import { test, expect, Page, ElectronApplication } from '../../../playwright';
+
+/**
+ * Collection tree item structure for asse... | [
"tests/utils/page/mounting.ts"
] | [
{
"comment": "Same as before comments, this could be anything in the generated set of collections if there's more than one",
"path": "tests/utils/page/mounting.ts",
"hunk": "@@ -0,0 +1,454 @@\n+import { test, expect, Page, ElectronApplication } from '../../../playwright';\n+\n+/**\n+ * Collection tree i... | true | ||
usebruno/bruno | 7,466 | comment_to_fix | test(core): current mount pipeline | The check for `.animate-spin` is redundant since `isCollectionLoading` does the same thing internally
```suggestion
// Verify via helper
const loading = await isCollectionLoading(page, 'Test Collection');
expect(loading).toBe(false);
``` | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | diff --git a/tests/mounting/loading-state.spec.ts b/tests/mounting/loading-state.spec.ts
new file mode 100644
index 0000000000..14a59cb29a
--- /dev/null
+++ b/tests/mounting/loading-state.spec.ts
@@ -0,0 +1,69 @@
+import { test, expect, ElectronApplication, Page } from '../../playwright';
+import { setupTestFixture, Te... | [
"tests/mounting/loading-state.spec.ts"
] | [
{
"comment": "The check for `.animate-spin` is redundant since `isCollectionLoading` does the same thing internally\n\n\n```suggestion\n // Verify via helper\n const loading = await isCollectionLoading(page, 'Test Collection');\n expect(loading).toBe(false);\n```",
"path": "tests/mounting/loa... | true | ||
usebruno/bruno | 7,466 | comment_to_fix | test(core): current mount pipeline | There's nothing deterministic about this test, we are testing randomness and assuming the randomness might match.
The assumption that it's greater than 2 is strictly based off the random algorithm that the generator has, i'd suggest we change this to an actual physical fixture instead of a generated one. | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | diff --git a/tests/mounting/tree-construction.spec.ts b/tests/mounting/tree-construction.spec.ts
new file mode 100644
index 0000000000..af325f522c
--- /dev/null
+++ b/tests/mounting/tree-construction.spec.ts
@@ -0,0 +1,172 @@
+import * as path from 'path';
+import { test, expect, ElectronApplication, Page } from '../..... | [
"tests/mounting/tree-construction.spec.ts"
] | [
{
"comment": "There's nothing deterministic about this test, we are testing randomness and assuming the randomness might match. \n\nThe assumption that it's greater than 2 is strictly based off the random algorithm that the generator has, i'd suggest we change this to an actual physical fixture instead of a gen... | true | ||
usebruno/bruno | 7,466 | comment_to_fix | test(core): current mount pipeline | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Both teardown blocks can short-circuit and leak resources on failure.**
If one teardown call throws, the remaining cleanup steps are skipped. Apply a `try/finally`-guarded pattern in both hooks.
<details>
<summary>Suggested pattern (apply to both `afterAll` bloc... | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | diff --git a/tests/mounting/item-sorting.spec.ts b/tests/mounting/item-sorting.spec.ts
new file mode 100644
index 0000000000..bcc71dcf91
--- /dev/null
+++ b/tests/mounting/item-sorting.spec.ts
@@ -0,0 +1,116 @@
+import { test, expect, ElectronApplication, Page } from '../../playwright';
+import { setupSortingTestFixtur... | [
"tests/mounting/item-sorting.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Both teardown blocks can short-circuit and leak resources on failure.**\n\nIf one teardown call throws, the remaining cleanup steps are skipped. Apply a `try/finally`-guarded pattern in both hooks.\n\n \n\n<details>\n<summary>Suggested pattern... | true | ||
usebruno/bruno | 7,466 | comment_to_fix | test(core): current mount pipeline | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Teardown is not failure-safe; cleanup can be skipped.**
A throw in an earlier teardown step prevents later cleanup steps from running. This can leak temp dirs and lock files.
<details>
<summary>Suggested fix</summary>
```diff
- test.afterAll(async () => {
- ... | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | diff --git a/tests/mounting/loading-state.spec.ts b/tests/mounting/loading-state.spec.ts
new file mode 100644
index 0000000000..14a59cb29a
--- /dev/null
+++ b/tests/mounting/loading-state.spec.ts
@@ -0,0 +1,69 @@
+import { test, expect, ElectronApplication, Page } from '../../playwright';
+import { setupTestFixture, Te... | [
"tests/mounting/loading-state.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Teardown is not failure-safe; cleanup can be skipped.**\n\nA throw in an earlier teardown step prevents later cleanup steps from running. This can leak temp dirs and lock files.\n\n \n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n-... | true | ||
usebruno/bruno | 7,466 | comment_to_fix | test(core): current mount pipeline | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Teardown should be failure-safe to avoid leaking app/user-data resources.**
A failure in any earlier teardown step can skip the rest, leaving locked files/directories.
<details>
<summary>Suggested fix</summary>
```diff
- test.afterAll(async () => {
- if... | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | diff --git a/tests/mounting/tree-construction.spec.ts b/tests/mounting/tree-construction.spec.ts
new file mode 100644
index 0000000000..af325f522c
--- /dev/null
+++ b/tests/mounting/tree-construction.spec.ts
@@ -0,0 +1,172 @@
+import * as path from 'path';
+import { test, expect, ElectronApplication, Page } from '../..... | [
"tests/mounting/tree-construction.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Teardown should be failure-safe to avoid leaking app/user-data resources.**\n\nA failure in any earlier teardown step can skip the rest, leaving locked files/directories.\n\n \n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n- tes... | true | ||
usebruno/bruno | 7,466 | comment_to_fix | test(core): current mount pipeline | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Environment files can be silently overwritten when `count > 5`.**
`envName` cycles through a fixed 5-name list, so later iterations reuse the same filename and overwrite earlier files. That breaks the implied `count` contract.
<details>
<summary>Suggested fix</s... | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | diff --git a/tests/utils/fixtures/generator.ts b/tests/utils/fixtures/generator.ts
new file mode 100644
index 0000000000..2fa664d468
--- /dev/null
+++ b/tests/utils/fixtures/generator.ts
@@ -0,0 +1,681 @@
+import * as fs from 'fs';
+import * as path from 'path';
+import * as os from 'os';
+
+export type CollectionForma... | [
"tests/utils/fixtures/generator.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Environment files can be silently overwritten when `count > 5`.**\n\n`envName` cycles through a fixed 5-name list, so later iterations reuse the same filename and overwrite earlier files. That breaks the implied `count` contract.\n\n \n\n<deta... | true | ||
usebruno/bruno | 7,466 | comment_to_fix | test(core): current mount pipeline | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Avoid hardcoded path separators in folder path construction.**
Using `'/'` here violates the repo’s OS-agnostic path rule and can cause platform-specific behavior drift.
<details>
<summary>Suggested fix</summary>
```diff
- const newPath = currentPath ? `${... | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | diff --git a/tests/utils/fixtures/generator.ts b/tests/utils/fixtures/generator.ts
new file mode 100644
index 0000000000..2fa664d468
--- /dev/null
+++ b/tests/utils/fixtures/generator.ts
@@ -0,0 +1,681 @@
+import * as fs from 'fs';
+import * as path from 'path';
+import * as os from 'os';
+
+export type CollectionForma... | [
"tests/utils/fixtures/generator.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Avoid hardcoded path separators in folder path construction.**\n\nUsing `'/'` here violates the repo’s OS-agnostic path rule and can cause platform-specific behavior drift.\n\n \n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n- ... | true | ||
usebruno/bruno | 7,466 | comment_to_fix | test(core): current mount pipeline | _⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
set -euo pipefail
# Show the relevant portion of the file
echo "=== File: tests/utils/page/mounting.ts (lines 90-160) ==="
nl -ba tests/utils/page/mounting.ts | sed -n '90,170... | b70bfb26d46cfaea3208d3f987810282b876e908 | d3d92838c3b2bdc8caf2f157c68f78534b057e07 | diff --git a/tests/utils/page/mounting.ts b/tests/utils/page/mounting.ts
new file mode 100644
index 0000000000..57f3207138
--- /dev/null
+++ b/tests/utils/page/mounting.ts
@@ -0,0 +1,414 @@
+import { test, expect, Page, ElectronApplication } from '../../../playwright';
+
+/**
+ * Collection tree item structure for asse... | [
"tests/utils/page/mounting.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\n# Show the relevant portion of the file\necho \"=== File: tests/utils/page/mounting.ts (lines 90-160) ===\"\nnl -ba tests/ut... | true | ||
usebruno/bruno | 8,027 | issue_to_patch | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | **Jira link: https://usebruno.atlassian.net/browse/BRU-3386**
**https://usebruno.atlassian.net/browse/BRU-3421**
### Description
Fixes the false "modified" indicator dot shown on the **Auth** tab for requests and folders when auth mode is `inherit`. Previously the dot was driven purely by `auth.mode !== 'none'`, w... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/package-lock.json b/package-lock.json
index bfe8ce05cb9..d2f90304f14 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -5027,7 +5027,7 @@
"version": "7.26.3",
"resolved": "https://registry.npmjs.org/@babel/helper-create-regexp-features-plugin/-/helper-create-regexp-features-plugin-7.2... | [
"package-lock.json",
"packages/bruno-app/src/components/CollectionSettings/Auth/AuthMode/index.js",
"packages/bruno-app/src/components/CollectionSettings/Presets/index.js",
"packages/bruno-app/src/components/CollectionSettings/index.js",
"packages/bruno-app/src/components/FolderSettings/Auth/index.js",
"p... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**GraphQL auth indicator still skips parent `none` during inheritance.**\n\nAt Line 184, filtering out `'none'` means a parent folder set to No Auth is ignored, so resolution can incorrectly fall back to higher ancestors and show the Auth dot.\n... | diff --git a/packages/bruno-app/src/utils/auth/index.spec.js b/packages/bruno-app/src/utils/auth/index.spec.js
index dfdde956f1c..2da6dd329d3 100644
--- a/packages/bruno-app/src/utils/auth/index.spec.js
+++ b/packages/bruno-app/src/utils/auth/index.spec.js
@@ -1,13 +1,21 @@
-import { resolveInheritedAuth } from './inde... | true | |
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**GraphQL auth indicator still skips parent `none` during inheritance.**
At Line 184, filtering out `'none'` means a parent folder set to No Auth is ignored, so resolution can incorrectly fall back to higher ancestors and show the Auth dot.
<details>
<summary>Suggest... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/RequestPane/GraphQLRequestPane/index.js b/packages/bruno-app/src/components/RequestPane/GraphQLRequestPane/index.js
index a6f15723f44..7255731b16e 100644
--- a/packages/bruno-app/src/components/RequestPane/GraphQLRequestPane/index.js
+++ b/packages/bruno-app/src/components... | [
"packages/bruno-app/src/components/RequestPane/GraphQLRequestPane/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**GraphQL auth indicator still skips parent `none` during inheritance.**\n\nAt Line 184, filtering out `'none'` means a parent folder set to No Auth is ignored, so resolution can incorrectly fall back to higher ancestors and show the Auth dot.\n... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Treat parent-folder `none` as the effective auth here too.**
This helper has the same fallthrough bug as the WebSocket pane: ancestor folders with `auth.mode === 'none'` are skipped, so the indicator can still resolve to collection auth and stay visible for nested r... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/RequestPane/GrpcRequestPane/index.js b/packages/bruno-app/src/components/RequestPane/GrpcRequestPane/index.js
index 7ea16f177d5..fc849e60d0f 100644
--- a/packages/bruno-app/src/components/RequestPane/GrpcRequestPane/index.js
+++ b/packages/bruno-app/src/components/RequestP... | [
"packages/bruno-app/src/components/RequestPane/GrpcRequestPane/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Treat parent-folder `none` as the effective auth here too.**\n\nThis helper has the same fallthrough bug as the WebSocket pane: ancestor folders with `auth.mode === 'none'` are skipped, so the indicator can still resolve to collection auth and... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Stop inheritance when an ancestor folder is `none`.**
This resolver still skips `folderAuth.mode === 'none'` and falls through to the collection root, so a request under a child folder can still show the Auth dot when its parent folder explicitly set **No Auth**. Th... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js b/packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js
index 66825181aef..4752a693275 100644
--- a/packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js
+++ b/packages/bruno-app/src/components/RequestPane/WS... | [
"packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Stop inheritance when an ancestor folder is `none`.**\n\nThis resolver still skips `folderAuth.mode === 'none'` and falls through to the collection root, so a request under a child folder can still show the Auth dot when its parent folder expl... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Sanitize preset fields to strings at parse time.**
Line 39 and Line 40 still allow non-string truthy YAML values to pass through. This can leak invalid types into `brunoConfig.presets` and break downstream assumptions.
<details>
<summary>Proposed fix</summary>
`... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-filestore/src/formats/yml/parseCollection.ts b/packages/bruno-filestore/src/formats/yml/parseCollection.ts
index 602d65aa260..ecb57bbf24b 100644
--- a/packages/bruno-filestore/src/formats/yml/parseCollection.ts
+++ b/packages/bruno-filestore/src/formats/yml/parseCollection.ts
@@ -7,6 +7,7 @@... | [
"packages/bruno-filestore/src/formats/yml/parseCollection.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Sanitize preset fields to strings at parse time.**\n\nLine 39 and Line 40 still allow non-string truthy YAML values to pass through. This can leak invalid types into `brunoConfig.presets` and break downstream assumptions.\n\n \n<details>\n<sum... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | _🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_
**Add semicolons consistently to comply with repo JS standards.**
Several statements in this spec currently omit trailing semicolons; please align the file with the repository rule.
As per coding guidelines: "Always add semicolons at the end of statements".
... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-filestore/src/formats/yml/tests/parseCollection.spec.js b/packages/bruno-filestore/src/formats/yml/tests/parseCollection.spec.js
new file mode 100644
index 00000000000..d210ef7e75a
--- /dev/null
+++ b/packages/bruno-filestore/src/formats/yml/tests/parseCollection.spec.js
@@ -0,0 +1,63 @@
+im... | [
"packages/bruno-filestore/src/formats/yml/tests/parseCollection.spec.js"
] | [
{
"comment": "_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add semicolons consistently to comply with repo JS standards.**\n\nSeveral statements in this spec currently omit trailing semicolons; please align the file with the repository rule.\n\n \n\nAs per coding guidelines: \"Always add semicolo... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | _🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_
**Please add semicolons throughout this spec to match repo conventions.**
This test file has multiple statements without semicolons; bring it in line with the project’s required JS/TS formatting rule.
As per coding guidelines: "Always add semicolons at the en... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/tests/collection/presets-indicator.spec.ts b/tests/collection/presets-indicator.spec.ts
new file mode 100644
index 00000000000..d6ef97a24a8
--- /dev/null
+++ b/tests/collection/presets-indicator.spec.ts
@@ -0,0 +1,70 @@
+import type { Locator } from '@playwright/test';
+import { test, expect } from '../../... | [
"tests/collection/presets-indicator.spec.ts"
] | [
{
"comment": "_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_\n\n**Please add semicolons throughout this spec to match repo conventions.**\n\nThis test file has multiple statements without semicolons; bring it in line with the project’s required JS/TS formatting rule.\n\n \n\nAs per coding guidelines: \"... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.