repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🌐 Web query:
`In Playwright 1.51.x, is the built-in `page` fixture allowed inside `test.afterAll`, or only in per-test hooks like `afterEach`?`
💡 Result:
In Playwright, the built-in page fixture is not available in t... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/tests/collection/presets-indicator.spec.ts b/tests/collection/presets-indicator.spec.ts
new file mode 100644
index 00000000000..d6ef97a24a8
--- /dev/null
+++ b/tests/collection/presets-indicator.spec.ts
@@ -0,0 +1,70 @@
+import type { Locator } from '@playwright/test';
+import { test, expect } from '../../... | [
"tests/collection/presets-indicator.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`In Playwright 1.51.x, is the built-in `page` fixture allowed inside `test.afterAll`, or only in per-test hooks like `afterEach`?`\n\n💡 Result:\n\nIn Playwright, the built-in p... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Use effective auth resolution for folder Auth indicator, not raw mode.**
Line 36 still treats `'inherit'` as active auth, so the dot can remain visible even when inherited effective auth resolves to `none`. This keeps the false-positive indicator behavior on folder ... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/FolderSettings/index.js b/packages/bruno-app/src/components/FolderSettings/index.js
index d87deb471a7..23763d27e7c 100644
--- a/packages/bruno-app/src/components/FolderSettings/index.js
+++ b/packages/bruno-app/src/components/FolderSettings/index.js
@@ -1,4 +1,4 @@
-import... | [
"packages/bruno-app/src/components/FolderSettings/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Use effective auth resolution for folder Auth indicator, not raw mode.**\n\nLine 36 still treats `'inherit'` as active auth, so the dot can remain visible even when inherited effective auth resolves to `none`. This keeps the false-positive ind... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Missing draft check for ancestor folder auth.**
When traversing ancestor folders, this line ignores draft auth changes. The original `resolveInheritedAuth` (line 32) checks `i?.draft` before selecting the auth path. If a parent folder has unsaved auth modifications,... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/auth/index.js b/packages/bruno-app/src/utils/auth/index.js
index b479b63c4f1..fa23a1fc99d 100644
--- a/packages/bruno-app/src/utils/auth/index.js
+++ b/packages/bruno-app/src/utils/auth/index.js
@@ -2,6 +2,7 @@ import { get } from 'lodash';
import {
getTreePathFromCollectio... | [
"packages/bruno-app/src/utils/auth/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Missing draft check for ancestor folder auth.**\n\nWhen traversing ancestor folders, this line ignores draft auth changes. The original `resolveInheritedAuth` (line 32) checks `i?.draft` before selecting the auth path. If a parent folder has u... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Missing fallback to `root.request.auth` for folder items.**
For folders, auth is stored at `root.request.auth`, not `request.auth`. Without the fallback, folder items will return `undefined` instead of their actual auth mode, and the inheritance logic on line 84 won... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/auth/index.js b/packages/bruno-app/src/utils/auth/index.js
index b479b63c4f1..fa23a1fc99d 100644
--- a/packages/bruno-app/src/utils/auth/index.js
+++ b/packages/bruno-app/src/utils/auth/index.js
@@ -2,6 +2,7 @@ import { get } from 'lodash';
import {
getTreePathFromCollectio... | [
"packages/bruno-app/src/utils/auth/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Missing fallback to `root.request.auth` for folder items.**\n\nFor folders, auth is stored at `root.request.auth`, not `request.auth`. Without the fallback, folder items will return `undefined` instead of their actual auth mode, and the inheri... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Remove the debug pause from the E2E test.**
Line 86 uses `page.pause()`, which blocks automation and can hang CI runs.
<details>
<summary>Suggested fix</summary>
```diff
- await page.pause();
```
</details>
As per coding guidelines, "Avoid using `page.pause()... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/tests/auth/auth-mode/effective-auth-mode.spec.ts b/tests/auth/auth-mode/effective-auth-mode.spec.ts
new file mode 100644
index 00000000000..f993a6b449a
--- /dev/null
+++ b/tests/auth/auth-mode/effective-auth-mode.spec.ts
@@ -0,0 +1,113 @@
+import { test, expect } from '../../../playwright';
+import { build... | [
"tests/auth/auth-mode/effective-auth-mode.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Remove the debug pause from the E2E test.**\n\nLine 86 uses `page.pause()`, which blocks automation and can hang CI runs.\n\n \n<details>\n<summary>Suggested fix</summary>\n\n```diff\n- await page.pause();\n```\n</details>\nAs per coding gu... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | can we compute hasAuth outside the memo, just like how grpc, ws, gql request panes do currently, i guess adding item, collection defeats the purpose memoization a bit.
```js
const hasAuth = hasEffectiveAuth(collection, item);
// ... compute outside the useMemo, then depend on hasAuth instead of item + collection
```... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js b/packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js
index bfa9253e060..a0621adb2a1 100644
--- a/packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js
+++ b/packages/bruno-app/src/components/RequestP... | [
"packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js"
] | [
{
"comment": "can we compute hasAuth outside the memo, just like how grpc, ws, gql request panes do currently, i guess adding item, collection defeats the purpose memoization a bit.\n\n```js\nconst hasAuth = hasEffectiveAuth(collection, item);\n // ... compute outside the useMemo, then depend on hasAuth instea... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | // Auth modes supported by WS protocol. | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/common/constants.js b/packages/bruno-app/src/utils/common/constants.js
index b52c8dbf2ed..c555022e892 100644
--- a/packages/bruno-app/src/utils/common/constants.js
+++ b/packages/bruno-app/src/utils/common/constants.js
@@ -1,3 +1,47 @@
export const REQUEST_TYPES = ['http-reque... | [
"packages/bruno-app/src/utils/common/constants.js"
] | [
{
"comment": "// Auth modes supported by WS protocol.",
"path": "packages/bruno-app/src/utils/common/constants.js",
"hunk": "@@ -1,3 +1,47 @@\n export const REQUEST_TYPES = ['http-request', 'graphql-request', 'grpc-request', 'ws-request'];\n \n+export const PRESET_REQUEST_TYPES = {\n+ HTTP: 'http',\n+ ... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | Auth modes supported by GRPC protocol. | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/common/constants.js b/packages/bruno-app/src/utils/common/constants.js
index b52c8dbf2ed..c555022e892 100644
--- a/packages/bruno-app/src/utils/common/constants.js
+++ b/packages/bruno-app/src/utils/common/constants.js
@@ -1,3 +1,47 @@
export const REQUEST_TYPES = ['http-reque... | [
"packages/bruno-app/src/utils/common/constants.js"
] | [
{
"comment": "Auth modes supported by GRPC protocol.",
"path": "packages/bruno-app/src/utils/common/constants.js",
"hunk": "@@ -1,3 +1,47 @@\n export const REQUEST_TYPES = ['http-request', 'graphql-request', 'grpc-request', 'ws-request'];\n \n+export const PRESET_REQUEST_TYPES = {\n+ HTTP: 'http',\n+ ... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | instead f reversing the array, can we iterate backwards, considering performance, nothing major, good to have | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/auth/index.js b/packages/bruno-app/src/utils/auth/index.js
index b479b63c4f1..fa23a1fc99d 100644
--- a/packages/bruno-app/src/utils/auth/index.js
+++ b/packages/bruno-app/src/utils/auth/index.js
@@ -2,6 +2,7 @@ import { get } from 'lodash';
import {
getTreePathFromCollectio... | [
"packages/bruno-app/src/utils/auth/index.js"
] | [
{
"comment": "instead f reversing the array, can we iterate backwards, considering performance, nothing major, good to have",
"path": "packages/bruno-app/src/utils/auth/index.js",
"hunk": "@@ -41,3 +42,50 @@ export const resolveInheritedAuth = (item, collection) => {\n auth: effectiveAuth\n };\n }... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | @sharan-bruno Do we need to make the check this complex? I feel like, we can keep it simple, Could it be the reason `presers.requestUrl !== ''` fails for null, undefined than, in the case, can the simple check like
`presets && (Boolean(presets.requestUrl) || Boolean(presets.requestType))` can work | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/CollectionSettings/index.js b/packages/bruno-app/src/components/CollectionSettings/index.js
index d2bb6dd8f52..95adf02cced 100644
--- a/packages/bruno-app/src/components/CollectionSettings/index.js
+++ b/packages/bruno-app/src/components/CollectionSettings/index.js
@@ -15,... | [
"packages/bruno-app/src/components/CollectionSettings/index.js"
] | [
{
"comment": "@sharan-bruno Do we need to make the check this complex? I feel like, we can keep it simple, Could it be the reason `presers.requestUrl !== ''` fails for null, undefined than, in the case, can the simple check like\n`presets && (Boolean(presets.requestUrl) || Boolean(presets.requestType))` can wor... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | rm extraline | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/RequestPane/GrpcRequestPane/index.js b/packages/bruno-app/src/components/RequestPane/GrpcRequestPane/index.js
index 7ea16f177d5..fc849e60d0f 100644
--- a/packages/bruno-app/src/components/RequestPane/GrpcRequestPane/index.js
+++ b/packages/bruno-app/src/components/RequestP... | [
"packages/bruno-app/src/components/RequestPane/GrpcRequestPane/index.js"
] | [
{
"comment": "rm extraline ",
"path": "packages/bruno-app/src/components/RequestPane/GrpcRequestPane/index.js",
"hunk": "@@ -53,7 +55,8 @@ const GrpcRequestPane = ({ item, collection, handleRun }) => {\n const body = getPropertyFromDraftOrRequest(item, 'request.body');\n const headers = getPropertyF... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | rm extra line | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js b/packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js
index 66825181aef..4752a693275 100644
--- a/packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js
+++ b/packages/bruno-app/src/components/RequestPane/WS... | [
"packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js"
] | [
{
"comment": "rm extra line",
"path": "packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js",
"hunk": "@@ -36,7 +38,8 @@ const WSRequestPane = ({ item, collection, handleRun }) => {\n \n const headers = getPropertyFromDraftOrRequest(item, 'request.headers');\n const docs = getPropert... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | I guess we might not need any of the changes just to avoid any un-expected behaviours. I guess it is just a different way of doing the same, let me know if it is not the case @sharan-bruno | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-filestore/src/formats/yml/parseFolder.ts b/packages/bruno-filestore/src/formats/yml/parseFolder.ts
index d2109dfb283..60ba51f766a 100644
--- a/packages/bruno-filestore/src/formats/yml/parseFolder.ts
+++ b/packages/bruno-filestore/src/formats/yml/parseFolder.ts
@@ -19,15 +19,9 @@ const parseF... | [
"packages/bruno-filestore/src/formats/yml/parseFolder.ts"
] | [
{
"comment": "I guess we might not need any of the changes just to avoid any un-expected behaviours. I guess it is just a different way of doing the same, let me know if it is not the case @sharan-bruno ",
"path": "packages/bruno-filestore/src/formats/yml/parseFolder.ts",
"hunk": "@@ -19,15 +19,9 @@ con... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | can remove this as it might not be needed if we are updating the presets check not to include default request type | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/common/constants.js b/packages/bruno-app/src/utils/common/constants.js
index b52c8dbf2ed..c555022e892 100644
--- a/packages/bruno-app/src/utils/common/constants.js
+++ b/packages/bruno-app/src/utils/common/constants.js
@@ -1,3 +1,47 @@
export const REQUEST_TYPES = ['http-reque... | [
"packages/bruno-app/src/utils/common/constants.js"
] | [
{
"comment": "can remove this as it might not be needed if we are updating the presets check not to include default request type",
"path": "packages/bruno-app/src/utils/common/constants.js",
"hunk": "@@ -1,3 +1,47 @@\n export const REQUEST_TYPES = ['http-request', 'graphql-request', 'grpc-request', 'ws-... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | i guess presets should be appearing, if there is anything inside, presets object, we do not have to make it specific to http | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/tests/collection/presets-indicator.spec.ts b/tests/collection/presets-indicator.spec.ts
new file mode 100644
index 00000000000..d6ef97a24a8
--- /dev/null
+++ b/tests/collection/presets-indicator.spec.ts
@@ -0,0 +1,70 @@
+import type { Locator } from '@playwright/test';
+import { test, expect } from '../../... | [
"tests/collection/presets-indicator.spec.ts"
] | [
{
"comment": "i guess presets should be appearing, if there is anything inside, presets object, we do not have to make it specific to http",
"path": "tests/collection/presets-indicator.spec.ts",
"hunk": "@@ -0,0 +1,71 @@\n+import type { Locator } from '@playwright/test';\n+import { test, expect } from '... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | @sharan-bruno move the locators to common locators and use them here, can also consider adding data-testids as needed | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/tests/collection/presets-indicator.spec.ts b/tests/collection/presets-indicator.spec.ts
new file mode 100644
index 00000000000..d6ef97a24a8
--- /dev/null
+++ b/tests/collection/presets-indicator.spec.ts
@@ -0,0 +1,70 @@
+import type { Locator } from '@playwright/test';
+import { test, expect } from '../../... | [
"tests/collection/presets-indicator.spec.ts"
] | [
{
"comment": "@sharan-bruno move the locators to common locators and use them here, can also consider adding data-testids as needed",
"path": "tests/collection/presets-indicator.spec.ts",
"hunk": "@@ -0,0 +1,71 @@\n+import type { Locator } from '@playwright/test';\n+import { test, expect } from '../../p... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | use common locators
| 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/tests/auth/auth-mode/modified-indicator-for-auth.spec.ts b/tests/auth/auth-mode/modified-indicator-for-auth.spec.ts
new file mode 100644
index 00000000000..6ed67327b57
--- /dev/null
+++ b/tests/auth/auth-mode/modified-indicator-for-auth.spec.ts
@@ -0,0 +1,147 @@
+import { test, expect } from '../../../play... | [
"tests/auth/auth-mode/modified-indicator-for-auth.spec.ts"
] | [
{
"comment": "use common locators\n",
"path": "tests/auth/auth-mode/modified-indicator-for-auth.spec.ts",
"hunk": "@@ -0,0 +1,127 @@\n+import { test, expect } from '../../../playwright';\n+import {\n+ AUTH_MODE_LABELS,\n+ closeAllCollections,\n+ createCollection,\n+ createFolder,\n+ createRequest,\... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | Add similar bru tests too | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-filestore/src/formats/yml/tests/fixtures/presets/empty-request.yml b/packages/bruno-filestore/src/formats/yml/tests/fixtures/presets/empty-request.yml
new file mode 100644
index 00000000000..72230b95731
--- /dev/null
+++ b/packages/bruno-filestore/src/formats/yml/tests/fixtures/presets/empty... | [
"packages/bruno-filestore/src/formats/yml/tests/fixtures/presets/empty-request.yml"
] | [
{
"comment": "Add similar bru tests too",
"path": "packages/bruno-filestore/src/formats/yml/tests/fixtures/presets/empty-request.yml",
"hunk": "@@ -0,0 +1,7 @@\n+opencollection: 1.0.0\n+info:\n+ name: My Collection\n+extensions:",
"resolving_sha": "283b9ad8d2a56e070081dcd3f2c177f254a4a742",
"re... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | can we explain why we have root.request? i guess it is for the collection, but it might not be that straight forward to understand, can we create `collection auth Mode` to make this more apparent? also will need to consider collection level draft state, better things seperate
```js
const collectionAuthMode = ...
const... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/auth/index.js b/packages/bruno-app/src/utils/auth/index.js
index b479b63c4f1..fa23a1fc99d 100644
--- a/packages/bruno-app/src/utils/auth/index.js
+++ b/packages/bruno-app/src/utils/auth/index.js
@@ -2,6 +2,7 @@ import { get } from 'lodash';
import {
getTreePathFromCollectio... | [
"packages/bruno-app/src/utils/auth/index.js"
] | [
{
"comment": "can we explain why we have root.request? i guess it is for the collection, but it might not be that straight forward to understand, can we create `collection auth Mode` to make this more apparent? also will need to consider collection level draft state, better things seperate\n```js\nconst collec... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | same as before, don't we need to consider `draft state` for root.request? | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/auth/index.js b/packages/bruno-app/src/utils/auth/index.js
index b479b63c4f1..fa23a1fc99d 100644
--- a/packages/bruno-app/src/utils/auth/index.js
+++ b/packages/bruno-app/src/utils/auth/index.js
@@ -2,6 +2,7 @@ import { get } from 'lodash';
import {
getTreePathFromCollectio... | [
"packages/bruno-app/src/utils/auth/index.js"
] | [
{
"comment": "same as before, don't we need to consider `draft state` for root.request?",
"path": "packages/bruno-app/src/utils/auth/index.js",
"hunk": "@@ -41,3 +43,51 @@ export const resolveInheritedAuth = (item, collection) => {\n auth: effectiveAuth\n };\n };\n+\n+export const getEffectiveAuth... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | To be reviewed with Product.
@sanish-bruno @sreelakshmi-bruno | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/CollectionSettings/index.js b/packages/bruno-app/src/components/CollectionSettings/index.js
index d2bb6dd8f52..95adf02cced 100644
--- a/packages/bruno-app/src/components/CollectionSettings/index.js
+++ b/packages/bruno-app/src/components/CollectionSettings/index.js
@@ -15,... | [
"packages/bruno-app/src/components/CollectionSettings/index.js"
] | [
{
"comment": "To be reviewed with Product.\n@sanish-bruno @sreelakshmi-bruno ",
"path": "packages/bruno-app/src/components/CollectionSettings/index.js",
"hunk": "@@ -60,7 +60,7 @@ const CollectionSettings = ({ collection }) => {\n ? get(collection, 'draft.brunoConfig.protobuf', {})\n : get(colle... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | Can we memoize this? | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/RequestPane/GrpcRequestPane/GrpcAuth/index.js b/packages/bruno-app/src/components/RequestPane/GrpcRequestPane/GrpcAuth/index.js
index 7ae205c5269..900bd78cea3 100644
--- a/packages/bruno-app/src/components/RequestPane/GrpcRequestPane/GrpcAuth/index.js
+++ b/packages/bruno-... | [
"packages/bruno-app/src/components/RequestPane/GrpcRequestPane/GrpcAuth/index.js"
] | [
{
"comment": "Can we memoize this?",
"path": "packages/bruno-app/src/components/RequestPane/GrpcRequestPane/GrpcAuth/index.js",
"hunk": "@@ -95,10 +61,10 @@ const GrpcAuth = ({ item, collection }) => {\n return <WsseAuth collection={collection} item={item} updateAuth={updateAuth} request={reques... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | We should support an extra identifier like a suffix. A page can have multiple StatusDots.
```
const StatusDot = ({ type = 'default', dataTestId = null }) => (
<sup
className={`ml-[.125rem] opacity-80 font-medium ${
type === 'error' ? 'text-red-500' : ''
}`}
data-testid={dataTestId ? `status-dot-${da... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/StatusDot/index.js b/packages/bruno-app/src/components/StatusDot/index.js
index f02002111ca..9ddc3ed1c13 100644
--- a/packages/bruno-app/src/components/StatusDot/index.js
+++ b/packages/bruno-app/src/components/StatusDot/index.js
@@ -1,11 +1,12 @@
import React from 'react... | [
"packages/bruno-app/src/components/StatusDot/index.js"
] | [
{
"comment": "We should support an extra identifier like a suffix. A page can have multiple StatusDots.\n```\nconst StatusDot = ({ type = 'default', dataTestId = null }) => (\n <sup\n className={`ml-[.125rem] opacity-80 font-medium ${\n type === 'error' ? 'text-red-500' : ''\n }`}\n data-testid={... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | Update the comments? | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/auth/index.js b/packages/bruno-app/src/utils/auth/index.js
index b479b63c4f1..fa23a1fc99d 100644
--- a/packages/bruno-app/src/utils/auth/index.js
+++ b/packages/bruno-app/src/utils/auth/index.js
@@ -2,6 +2,7 @@ import { get } from 'lodash';
import {
getTreePathFromCollectio... | [
"packages/bruno-app/src/utils/auth/index.js"
] | [
{
"comment": "Update the comments?",
"path": "packages/bruno-app/src/utils/auth/index.js",
"hunk": "@@ -26,7 +27,8 @@ export const resolveInheritedAuth = (item, collection) => {\n let effectiveAuth = collectionAuth;\n \n // Check folders in reverse to find the closest auth configuration",
"resol... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | Both draft and saved item auth is `inherit`
Both item and parent type is `folder`.
Neeed to harden the test case. Please revisit and update other tests as required. | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/auth/index.spec.js b/packages/bruno-app/src/utils/auth/index.spec.js
index dfdde956f1c..2da6dd329d3 100644
--- a/packages/bruno-app/src/utils/auth/index.spec.js
+++ b/packages/bruno-app/src/utils/auth/index.spec.js
@@ -1,13 +1,21 @@
-import { resolveInheritedAuth } from './inde... | [
"packages/bruno-app/src/utils/auth/index.spec.js"
] | [
{
"comment": "Both draft and saved item auth is `inherit`\nBoth item and parent type is `folder`. \n\nNeeed to harden the test case. Please revisit and update other tests as required.",
"path": "packages/bruno-app/src/utils/auth/index.spec.js",
"hunk": "@@ -77,3 +85,145 @@ describe('auth-utils.resolveIn... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | `AUTH_MODES_WS` & `AUTH_MODES_GRPC` | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/common/constants.js b/packages/bruno-app/src/utils/common/constants.js
index b52c8dbf2ed..c555022e892 100644
--- a/packages/bruno-app/src/utils/common/constants.js
+++ b/packages/bruno-app/src/utils/common/constants.js
@@ -1,3 +1,47 @@
export const REQUEST_TYPES = ['http-reque... | [
"packages/bruno-app/src/utils/common/constants.js"
] | [
{
"comment": "`AUTH_MODES_WS` & `AUTH_MODES_GRPC`",
"path": "packages/bruno-app/src/utils/common/constants.js",
"hunk": "@@ -1,3 +1,38 @@\n export const REQUEST_TYPES = ['http-request', 'graphql-request', 'grpc-request', 'ws-request'];\n \n export const DEFAULT_COLLECTION_FORMAT = 'yml';\n+\n+export con... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | @sharan-bruno useMemo even if the collection or folder is added to the deps, it might not have much of effect, as collection objects gets changed on every change not sure even adding collection and folder to deps make sense, if we are checking just the uid, i am afraid that the auth resolution happen with stale data no... | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/FolderSettings/Auth/index.js b/packages/bruno-app/src/components/FolderSettings/Auth/index.js
index 14c5d25639d..35687bf93fe 100644
--- a/packages/bruno-app/src/components/FolderSettings/Auth/index.js
+++ b/packages/bruno-app/src/components/FolderSettings/Auth/index.js
@@ ... | [
"packages/bruno-app/src/components/FolderSettings/Auth/index.js"
] | [
{
"comment": "@sharan-bruno useMemo even if the collection or folder is added to the deps, it might not have much of effect, as collection objects gets changed on every change not sure even adding collection and folder to deps make sense, if we are checking just the uid, i am afraid that the auth resolution hap... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | Same useMemo comment | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/RequestPane/GrpcRequestPane/GrpcAuth/index.js b/packages/bruno-app/src/components/RequestPane/GrpcRequestPane/GrpcAuth/index.js
index 7ae205c5269..900bd78cea3 100644
--- a/packages/bruno-app/src/components/RequestPane/GrpcRequestPane/GrpcAuth/index.js
+++ b/packages/bruno-... | [
"packages/bruno-app/src/components/RequestPane/GrpcRequestPane/GrpcAuth/index.js"
] | [
{
"comment": "Same useMemo comment",
"path": "packages/bruno-app/src/components/RequestPane/GrpcRequestPane/GrpcAuth/index.js",
"hunk": "@@ -9,32 +9,32 @@ import OAuth2 from '../../Auth/OAuth2/index';\n import WsseAuth from '../../Auth/WsseAuth';\n import StyledWrapper from './StyledWrapper';\n import {... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | same usememo comment, please discuss with @bijin-bruno before making final chnages | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js b/packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js
index bfa9253e060..a0621adb2a1 100644
--- a/packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js
+++ b/packages/bruno-app/src/components/RequestP... | [
"packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js"
] | [
{
"comment": "same usememo comment, please discuss with @bijin-bruno before making final chnages",
"path": "packages/bruno-app/src/components/RequestPane/HttpRequestPane/index.js",
"hunk": "@@ -86,6 +86,12 @@ const HttpRequestPane = ({ item, collection }) => {\n [dispatch, item.uid]\n );\n \n+ c... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | same as above | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/index.js b/packages/bruno-app/src/components/ResponsePane/Timeline/index.js
index e6d12a41ffd..8a5a7a6ef85 100644
--- a/packages/bruno-app/src/components/ResponsePane/Timeline/index.js
+++ b/packages/bruno-app/src/components/ResponsePane/Timeline/inde... | [
"packages/bruno-app/src/components/ResponsePane/Timeline/index.js"
] | [
{
"comment": "same as above",
"path": "packages/bruno-app/src/components/ResponsePane/Timeline/index.js",
"hunk": "@@ -50,7 +50,11 @@ const Timeline = ({ collection, item }) => {\n const [scroll, setScroll] = usePersistedState({ key: `response-timeline-scroll-${item.uid}`, default: 0 });\n useTrackS... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | add collection level draft, and the request in inheriting properly | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/auth/index.spec.js b/packages/bruno-app/src/utils/auth/index.spec.js
index dfdde956f1c..2da6dd329d3 100644
--- a/packages/bruno-app/src/utils/auth/index.spec.js
+++ b/packages/bruno-app/src/utils/auth/index.spec.js
@@ -1,13 +1,21 @@
-import { resolveInheritedAuth } from './inde... | [
"packages/bruno-app/src/utils/auth/index.spec.js"
] | [
{
"comment": "add collection level draft, and the request in inheriting properly",
"path": "packages/bruno-app/src/utils/auth/index.spec.js",
"hunk": "@@ -77,3 +85,184 @@ describe('auth-utils.resolveInheritedAuth', () => {\n expect(resolved.auth.basic.username).toBe('override');\n });\n });\n+\n+d... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | folder item with draft case, if not already in the test cases | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-app/src/utils/auth/index.spec.js b/packages/bruno-app/src/utils/auth/index.spec.js
index dfdde956f1c..2da6dd329d3 100644
--- a/packages/bruno-app/src/utils/auth/index.spec.js
+++ b/packages/bruno-app/src/utils/auth/index.spec.js
@@ -1,13 +1,21 @@
-import { resolveInheritedAuth } from './inde... | [
"packages/bruno-app/src/utils/auth/index.spec.js"
] | [
{
"comment": "folder item with draft case, if not already in the test cases",
"path": "packages/bruno-app/src/utils/auth/index.spec.js",
"hunk": "@@ -77,3 +85,184 @@ describe('auth-utils.resolveInheritedAuth', () => {\n expect(resolved.auth.basic.username).toBe('override');\n });\n });\n+\n+descri... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | url only case, just incase! | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/packages/bruno-filestore/src/formats/yml/tests/parseCollection.spec.js b/packages/bruno-filestore/src/formats/yml/tests/parseCollection.spec.js
new file mode 100644
index 00000000000..d210ef7e75a
--- /dev/null
+++ b/packages/bruno-filestore/src/formats/yml/tests/parseCollection.spec.js
@@ -0,0 +1,63 @@
+im... | [
"packages/bruno-filestore/src/formats/yml/tests/parseCollection.spec.js"
] | [
{
"comment": "url only case, just incase!",
"path": "packages/bruno-filestore/src/formats/yml/tests/parseCollection.spec.js",
"hunk": "@@ -0,0 +1,51 @@\n+import fs from 'node:fs';\n+import path from 'node:path';\n+import parseCollection from '../parseCollection';\n+\n+const loadFixture = (name) =>\n+ f... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | use common locators when ever possible, applicable to whole file @sharan-bruno | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/tests/auth/auth-mode/effective-auth-mode.spec.ts b/tests/auth/auth-mode/effective-auth-mode.spec.ts
new file mode 100644
index 00000000000..f993a6b449a
--- /dev/null
+++ b/tests/auth/auth-mode/effective-auth-mode.spec.ts
@@ -0,0 +1,113 @@
+import { test, expect } from '../../../playwright';
+import { build... | [
"tests/auth/auth-mode/effective-auth-mode.spec.ts"
] | [
{
"comment": "use common locators when ever possible, applicable to whole file @sharan-bruno ",
"path": "tests/auth/auth-mode/effective-auth-mode.spec.ts",
"hunk": "@@ -0,0 +1,111 @@\n+import { test, expect } from '../../../playwright';\n+import { AUTH_MODE_LABELS, closeAllCollections, createCollection,... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | can remove jira ids | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/tests/auth/auth-mode/effective-auth-mode.spec.ts b/tests/auth/auth-mode/effective-auth-mode.spec.ts
new file mode 100644
index 00000000000..f993a6b449a
--- /dev/null
+++ b/tests/auth/auth-mode/effective-auth-mode.spec.ts
@@ -0,0 +1,113 @@
+import { test, expect } from '../../../playwright';
+import { build... | [
"tests/auth/auth-mode/effective-auth-mode.spec.ts"
] | [
{
"comment": "can remove jira ids",
"path": "tests/auth/auth-mode/effective-auth-mode.spec.ts",
"hunk": "@@ -0,0 +1,111 @@\n+import { test, expect } from '../../../playwright';\n+import { AUTH_MODE_LABELS, closeAllCollections, createCollection, createFolder, selectAuthMode } from '../../utils/page';\n+\... | true | ||
usebruno/bruno | 8,027 | comment_to_fix | fix(ui): correct “modified” indicator state across collection, folder, request, and presets/auth tabs (#3386) | will need to add the case where, the request is inheriting from parent and the parent has `NO AUTH`, in that case we are not showing the dot for request too | 913214e96bbc21ebcf364c78dd2193056076a96b | 283b9ad8d2a56e070081dcd3f2c177f254a4a742 | diff --git a/tests/auth/auth-mode/modified-indicator-for-auth.spec.ts b/tests/auth/auth-mode/modified-indicator-for-auth.spec.ts
new file mode 100644
index 00000000000..6ed67327b57
--- /dev/null
+++ b/tests/auth/auth-mode/modified-indicator-for-auth.spec.ts
@@ -0,0 +1,147 @@
+import { test, expect } from '../../../play... | [
"tests/auth/auth-mode/modified-indicator-for-auth.spec.ts"
] | [
{
"comment": "will need to add the case where, the request is inheriting from parent and the parent has `NO AUTH`, in that case we are not showing the dot for request too",
"path": "tests/auth/auth-mode/modified-indicator-for-auth.spec.ts",
"hunk": "@@ -0,0 +1,130 @@\n+import { test, expect } from '../... | true | ||
usebruno/bruno | 8,115 | issue_to_patch | feat(ws): multiple messages support in websockets | ### Description
[BRU-3293](https://usebruno.atlassian.net/browse/BRU-3293)
[BRU-3295](https://usebruno.atlassian.net/browse/BRU-3295)
[BRU-2483](https://usebruno.atlassian.net/browse/BRU-2483)
[BRU-2932](https://usebruno.atlassian.net/browse/BRU-2932)
#### Contribution Checklist:
- [ ] **I've used AI signif... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 78bb7a7a64e677dd7a8e779ba02776979a897f27 | diff --git a/packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js b/packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js
index 66825181aef..432d07c9584 100644
--- a/packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js
+++ b/packages/bruno-app/src/components/RequestPane/WS... | [
"packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js",
"packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/StyledWrapper.js",
"packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js",
"packages/bruno-app/src/components/RequestPane/WsBody/StyledWrapper.... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\nFILE=\"packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js\"\n\n# Show file with line numbers around ... | diff --git a/packages/bruno-lang/v2/tests/bruToJson.spec.js b/packages/bruno-lang/v2/tests/bruToJson.spec.js
index b9b27a685bf..c018289dafa 100644
--- a/packages/bruno-lang/v2/tests/bruToJson.spec.js
+++ b/packages/bruno-lang/v2/tests/bruToJson.spec.js
@@ -9,7 +9,7 @@ body:ws {
name: message 1
content: '''
... | true | |
usebruno/bruno | 8,115 | comment_to_fix | feat(ws): multiple messages support in websockets | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
set -euo pipefail
FILE="packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js"
# Show file with line numbers around the areas referenced in the original ... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 78bb7a7a64e677dd7a8e779ba02776979a897f27 | diff --git a/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js b/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js
index 275665dc085..ebf9e1d04e6 100644
--- a/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js
+++ b/packages/bruno-app/sr... | [
"packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\nFILE=\"packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js\"\n\n# Show file with line numbers around ... | true | ||
usebruno/bruno | 8,115 | comment_to_fix | feat(ws): multiple messages support in websockets | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Deleting the active message can clear persisted selection entirely.**
If the removed row is the selected one, this writes `body.ws` back with no `selected: true`. `WSBody` only falls back to index `0` at render time, so the stored request no longer matches what the ... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 78bb7a7a64e677dd7a8e779ba02776979a897f27 | diff --git a/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js b/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js
index 275665dc085..ebf9e1d04e6 100644
--- a/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js
+++ b/packages/bruno-app/sr... | [
"packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Deleting the active message can clear persisted selection entirely.**\n\nIf the removed row is the selected one, this writes `body.ws` back with no `selected: true`. `WSBody` only falls back to index `0` at render time, so the stored request n... | true | ||
usebruno/bruno | 8,115 | comment_to_fix | feat(ws): multiple messages support in websockets | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Fix `onSendMessage` hook dependencies to avoid stale `index`/`item` values**
`onSendMessage` uses `collection.uid`, `index`, and `item`, but the `useCallback` dependency array only includes `collections`, so after delete/reindex it can keep the previous slot’s values... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 78bb7a7a64e677dd7a8e779ba02776979a897f27 | diff --git a/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js b/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js
index 275665dc085..ebf9e1d04e6 100644
--- a/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js
+++ b/packages/bruno-app/sr... | [
"packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Fix `onSendMessage` hook dependencies to avoid stale `index`/`item` values**\n`onSendMessage` uses `collection.uid`, `index`, and `item`, but the `useCallback` dependency array only includes `collections`, so after delete/reindex it can keep t... | true | ||
usebruno/bruno | 8,115 | comment_to_fix | feat(ws): multiple messages support in websockets | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
set -euo pipefail
FILE="packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js"
echo "== File exists? =="
ls -l "$FILE" || true
echo
echo "== Relevant se... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 78bb7a7a64e677dd7a8e779ba02776979a897f27 | diff --git a/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js b/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js
index 275665dc085..ebf9e1d04e6 100644
--- a/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js
+++ b/packages/bruno-app/sr... | [
"packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\nFILE=\"packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/index.js\"\n\necho \"== File exists? ==\"\nls -l \"... | true | ||
usebruno/bruno | 8,115 | comment_to_fix | feat(ws): multiple messages support in websockets | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Hover-only action visibility blocks keyboard access.**
`visibility: hidden` keeps Send/Delete out of the tab order until pointer hover, so keyboard users cannot reach them. Reveal the actions on `:focus-within` too.
<details>
<summary>Suggested fix</summary>
```d... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 78bb7a7a64e677dd7a8e779ba02776979a897f27 | diff --git a/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/StyledWrapper.js b/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/StyledWrapper.js
index a2922b8a33f..e2ce8e423f4 100644
--- a/packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/StyledWrapper.js
+++... | [
"packages/bruno-app/src/components/RequestPane/WsBody/SingleWSMessage/StyledWrapper.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Hover-only action visibility blocks keyboard access.**\n\n`visibility: hidden` keeps Send/Delete out of the tab order until pointer hover, so keyboard users cannot reach them. Reveal the actions on `:focus-within` too.\n \n<details>\n<summary>... | true | ||
usebruno/bruno | 8,115 | comment_to_fix | feat(ws): multiple messages support in websockets | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Use a distinct test id for the toolbar add action.**
`WsBody` already renders another `data-testid="ws-add-message"` in the empty state, so that view exposes two identical targets. That makes Playwright selectors ambiguous.
<details>
<summary>Suggested fix</summar... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 78bb7a7a64e677dd7a8e779ba02776979a897f27 | diff --git a/packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js b/packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js
index 66825181aef..432d07c9584 100644
--- a/packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js
+++ b/packages/bruno-app/src/components/RequestPane/WS... | [
"packages/bruno-app/src/components/RequestPane/WSRequestPane/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Use a distinct test id for the toolbar add action.**\n\n`WsBody` already renders another `data-testid=\"ws-add-message\"` in the empty state, so that view exposes two identical targets. That makes Playwright selectors ambiguous.\n \n<details>\... | true | ||
usebruno/bruno | 8,115 | comment_to_fix | feat(ws): multiple messages support in websockets | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Return failure when no message is actually queued**
At Line 413 and Line 418, invalid/missing `selectedMessageIndex` (or empty selected message) still returns `{ success: true }`, so sends can silently no-op while UI treats them as successful.
<details>
<summary... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 78bb7a7a64e677dd7a8e779ba02776979a897f27 | diff --git a/packages/bruno-electron/src/ipc/network/ws-event-handlers.js b/packages/bruno-electron/src/ipc/network/ws-event-handlers.js
index b9aad047ea6..b9319838377 100644
--- a/packages/bruno-electron/src/ipc/network/ws-event-handlers.js
+++ b/packages/bruno-electron/src/ipc/network/ws-event-handlers.js
@@ -400,35 ... | [
"packages/bruno-electron/src/ipc/network/ws-event-handlers.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Return failure when no message is actually queued**\n\nAt Line 413 and Line 418, invalid/missing `selectedMessageIndex` (or empty selected message) still returns `{ success: true }`, so sends can silently no-op while UI treats them as successf... | true | ||
usebruno/bruno | 8,115 | comment_to_fix | feat(ws): multiple messages support in websockets | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Default single-message names are treated as “custom,” breaking flat serialization fallback.**
Line 48 marks any non-empty name as custom, so a single auto-generated name like `message 1` is serialized as `WebSocketMessageVariant[]` instead of flat `WebSocketMessage`... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 78bb7a7a64e677dd7a8e779ba02776979a897f27 | diff --git a/packages/bruno-filestore/src/formats/yml/items/stringifyWebsocketRequest.ts b/packages/bruno-filestore/src/formats/yml/items/stringifyWebsocketRequest.ts
index 6a3d00fe73d..0d3ead549a4 100644
--- a/packages/bruno-filestore/src/formats/yml/items/stringifyWebsocketRequest.ts
+++ b/packages/bruno-filestore/sr... | [
"packages/bruno-filestore/src/formats/yml/items/stringifyWebsocketRequest.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Default single-message names are treated as “custom,” breaking flat serialization fallback.**\n\nLine 48 marks any non-empty name as custom, so a single auto-generated name like `message 1` is serialized as `WebSocketMessageVariant[]` instead ... | true | ||
usebruno/bruno | 8,115 | comment_to_fix | feat(ws): multiple messages support in websockets | _⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_
**Avoid mutating shared fixture files across tests.**
Line 10-26 writes back to repo-level fixture files after each test, which can cause cross-worker/spec interference and flaky runs when suites execute in parallel. Use a per-test or per-worker isolated fixture co... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 78bb7a7a64e677dd7a8e779ba02776979a897f27 | diff --git a/tests/websockets/multi-message-bru/multi-message.spec.ts b/tests/websockets/multi-message-bru/multi-message.spec.ts
new file mode 100644
index 00000000000..fbc41d983fb
--- /dev/null
+++ b/tests/websockets/multi-message-bru/multi-message.spec.ts
@@ -0,0 +1,256 @@
+import { expect, test } from '../../../play... | [
"tests/websockets/multi-message-bru/multi-message.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_\n\n**Avoid mutating shared fixture files across tests.**\n\nLine 10-26 writes back to repo-level fixture files after each test, which can cause cross-worker/spec interference and flaky runs when suites execute in parallel. Use a per-test or per-... | true | ||
usebruno/bruno | 8,184 | issue_to_patch | docs: update README to include Bruno CLI and Docker usage instructions | ### Description
Update README to include Bruno CLI and Docker usage instructions
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [ ] **The pull request only addresses one issue or adds one feature.**
- [ ] **The pull request does not introduce any breaking cha... | b70bfb26d46cfaea3208d3f987810282b876e908 | 83bde44171eb3eae0cd551be64279d7741a4c178 | diff --git a/readme.md b/readme.md
index 2d4199c75b..9d78ea58df 100644
--- a/readme.md
+++ b/readme.md
@@ -56,6 +56,8 @@ You can explore our [paid versions](https://www.usebruno.com/pricing) to see if
## Table of Contents
- [Installation](#installation)
+- [Bruno CLI](#bruno-cli)
+- [Run with Docker](#run-with-dock... | [
"readme.md"
] | [] | true | ||
usebruno/bruno | 8,113 | issue_to_patch | fix/3112 - Postman import: OAuth2 Implicit Grant Type Silently Converted to Client Credentials on Import | Jira link: https://usebruno.atlassian.net/browse/BRU-3112
### Description
Added Grant type implicit in postman-to-bruno.js and handled the case for same.
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [x] **The pull request only addresses one issue or adds ... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 8868b339e3a956464c7b8a05b504944676e8a582 | diff --git a/packages/bruno-app/src/components/RequestPane/Auth/OAuth2/GrantTypeSelector/index.js b/packages/bruno-app/src/components/RequestPane/Auth/OAuth2/GrantTypeSelector/index.js
index d6417f7479c..4fd58dfa46e 100644
--- a/packages/bruno-app/src/components/RequestPane/Auth/OAuth2/GrantTypeSelector/index.js
+++ b/... | [
"packages/bruno-app/src/components/RequestPane/Auth/OAuth2/GrantTypeSelector/index.js",
"packages/bruno-converters/src/postman/postman-to-bruno.js",
"packages/bruno-converters/tests/postman/postman-to-bruno/process-auth.spec.js",
"tests/import/postman/fixtures/postman-import-oauth2-implicit-grant-type.json",
... | [
{
"comment": "@rajashreehj-bruno we need to add test cases for this case, we should add test cases here `packages/bruno-converters/tests/postman/postman-to-bruno`",
"path": "packages/bruno-converters/src/postman/postman-to-bruno.js",
"hunk": "@@ -349,6 +350,13 @@ export const processAuth = (auth, reques... | diff --git a/packages/bruno-converters/tests/postman/postman-to-bruno/process-auth.spec.js b/packages/bruno-converters/tests/postman/postman-to-bruno/process-auth.spec.js
index d59116f2ea3..cd04fd95230 100644
--- a/packages/bruno-converters/tests/postman/postman-to-bruno/process-auth.spec.js
+++ b/packages/bruno-conver... | true | |
usebruno/bruno | 8,113 | comment_to_fix | fix/3112 - Postman import: OAuth2 Implicit Grant Type Silently Converted to Client Credentials on Import | @rajashreehj-bruno we need to add test cases for this case, we should add test cases here `packages/bruno-converters/tests/postman/postman-to-bruno` | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 8868b339e3a956464c7b8a05b504944676e8a582 | diff --git a/packages/bruno-converters/src/postman/postman-to-bruno.js b/packages/bruno-converters/src/postman/postman-to-bruno.js
index 5c6b3f7edb6..02705bb122c 100644
--- a/packages/bruno-converters/src/postman/postman-to-bruno.js
+++ b/packages/bruno-converters/src/postman/postman-to-bruno.js
@@ -303,7 +303,8 @@ exp... | [
"packages/bruno-converters/src/postman/postman-to-bruno.js"
] | [
{
"comment": "@rajashreehj-bruno we need to add test cases for this case, we should add test cases here `packages/bruno-converters/tests/postman/postman-to-bruno`",
"path": "packages/bruno-converters/src/postman/postman-to-bruno.js",
"hunk": "@@ -349,6 +350,13 @@ export const processAuth = (auth, reques... | true | ||
usebruno/bruno | 8,113 | comment_to_fix | fix/3112 - Postman import: OAuth2 Implicit Grant Type Silently Converted to Client Credentials on Import | _⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Check what fields the implicit case sets
ast-grep --pattern $'case \'implicit\':
$$$
break;'
```
Repository: usebruno/bruno
Length of output: 40
---
🏁 Script execute... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 8868b339e3a956464c7b8a05b504944676e8a582 | diff --git a/packages/bruno-converters/tests/postman/postman-to-bruno/process-auth.spec.js b/packages/bruno-converters/tests/postman/postman-to-bruno/process-auth.spec.js
index d59116f2ea3..cd04fd95230 100644
--- a/packages/bruno-converters/tests/postman/postman-to-bruno/process-auth.spec.js
+++ b/packages/bruno-conver... | [
"packages/bruno-converters/tests/postman/postman-to-bruno/process-auth.spec.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Check what fields the implicit case sets\nast-grep --pattern $'case \\'implicit\\':\n $$$\n break;'\n```\n\nRepository: usebruno/bruno\n\nLen... | true | ||
usebruno/bruno | 8,113 | comment_to_fix | fix/3112 - Postman import: OAuth2 Implicit Grant Type Silently Converted to Client Credentials on Import | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Remove debug console.log.**
This debug statement should be removed before merging.
<details>
<summary>🧹 Proposed fix</summary>
```diff
const locators = buildCommonLocators(page);
- console.log('locators:', locators);
const importDir = await createTm... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 8868b339e3a956464c7b8a05b504944676e8a582 | diff --git a/tests/import/postman/import-oauth2-implicit-grant-type.spec.ts b/tests/import/postman/import-oauth2-implicit-grant-type.spec.ts
new file mode 100644
index 00000000000..d0f9183abbb
--- /dev/null
+++ b/tests/import/postman/import-oauth2-implicit-grant-type.spec.ts
@@ -0,0 +1,63 @@
+import { test, expect } fr... | [
"tests/import/postman/import-oauth2-implicit-grant-type.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Remove debug console.log.**\n\nThis debug statement should be removed before merging.\n\n\n\n\n<details>\n<summary>🧹 Proposed fix</summary>\n\n```diff\n const locators = buildCommonLocators(page);\n- console.log('locators:', locators);\... | true | ||
usebruno/bruno | 8,113 | comment_to_fix | fix/3112 - Postman import: OAuth2 Implicit Grant Type Silently Converted to Client Credentials on Import | @rajashreehj-bruno we can keep the importing steps together, we can mainly asserting the oauth imports, | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 8868b339e3a956464c7b8a05b504944676e8a582 | diff --git a/tests/import/postman/import-oauth2-implicit-grant-type.spec.ts b/tests/import/postman/import-oauth2-implicit-grant-type.spec.ts
new file mode 100644
index 00000000000..d0f9183abbb
--- /dev/null
+++ b/tests/import/postman/import-oauth2-implicit-grant-type.spec.ts
@@ -0,0 +1,63 @@
+import { test, expect } fr... | [
"tests/import/postman/import-oauth2-implicit-grant-type.spec.ts"
] | [
{
"comment": "@rajashreehj-bruno we can keep the importing steps together, we can mainly asserting the oauth imports,",
"path": "tests/import/postman/import-oauth2-implicit-grant-type.spec.ts",
"hunk": "@@ -0,0 +1,88 @@\n+import { test, expect } from '../../../playwright';\n+import * as path from 'path'... | true | ||
usebruno/bruno | 8,113 | comment_to_fix | fix/3112 - Postman import: OAuth2 Implicit Grant Type Silently Converted to Client Credentials on Import | @rajashreehj-bruno can use testId | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 8868b339e3a956464c7b8a05b504944676e8a582 | diff --git a/tests/utils/page/locators.ts b/tests/utils/page/locators.ts
index 4dda96a4fc9..567d8db61cc 100644
--- a/tests/utils/page/locators.ts
+++ b/tests/utils/page/locators.ts
@@ -94,6 +94,9 @@ export const buildCommonLocators = (page: Page) => ({
apiKey: {
placementSelector: () => page.getByTestId('au... | [
"tests/utils/page/locators.ts"
] | [
{
"comment": "@rajashreehj-bruno can use testId",
"path": "tests/utils/page/locators.ts",
"hunk": "@@ -94,6 +94,9 @@ export const buildCommonLocators = (page: Page) => ({\n apiKey: {\n placementSelector: () => page.getByTestId('auth-placement-selector'),\n placementLabel: () => page.getB... | true | ||
usebruno/bruno | 8,113 | comment_to_fix | fix/3112 - Postman import: OAuth2 Implicit Grant Type Silently Converted to Client Credentials on Import | Please use existing locators from `tests/utils/page/locators.ts`
```
import: {
modal: () => page.locator('[data-testid="import-collection-modal"]'),
| 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 8868b339e3a956464c7b8a05b504944676e8a582 | diff --git a/tests/import/postman/import-oauth2-implicit-grant-type.spec.ts b/tests/import/postman/import-oauth2-implicit-grant-type.spec.ts
new file mode 100644
index 00000000000..d0f9183abbb
--- /dev/null
+++ b/tests/import/postman/import-oauth2-implicit-grant-type.spec.ts
@@ -0,0 +1,63 @@
+import { test, expect } fr... | [
"tests/import/postman/import-oauth2-implicit-grant-type.spec.ts"
] | [
{
"comment": "Please use existing locators from `tests/utils/page/locators.ts`\n\n```\n import: {\n modal: () => page.locator('[data-testid=\"import-collection-modal\"]'),\n",
"path": "tests/import/postman/import-oauth2-implicit-grant-type.spec.ts",
"hunk": "@@ -0,0 +1,67 @@\n+import { test, expect ... | true | ||
usebruno/bruno | 8,113 | comment_to_fix | fix/3112 - Postman import: OAuth2 Implicit Grant Type Silently Converted to Client Credentials on Import | I think we should not expect any error here | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | 8868b339e3a956464c7b8a05b504944676e8a582 | diff --git a/tests/import/postman/import-oauth2-implicit-grant-type.spec.ts b/tests/import/postman/import-oauth2-implicit-grant-type.spec.ts
new file mode 100644
index 00000000000..d0f9183abbb
--- /dev/null
+++ b/tests/import/postman/import-oauth2-implicit-grant-type.spec.ts
@@ -0,0 +1,63 @@
+import { test, expect } fr... | [
"tests/import/postman/import-oauth2-implicit-grant-type.spec.ts"
] | [
{
"comment": "I think we should not expect any error here",
"path": "tests/import/postman/import-oauth2-implicit-grant-type.spec.ts",
"hunk": "@@ -0,0 +1,67 @@\n+import { test, expect } from '../../../playwright';\n+import * as path from 'path';\n+import { closeAllCollections, openCollection, selectRequ... | true | ||
usebruno/bruno | 8,181 | issue_to_patch | chore: remove deps array from playwright test | ### Description
<!-- Explain here the changes your PR introduces and text to help us understand the context of this change. -->
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [ ] **The pull request only addresses one issue or adds one feature.**
- [ ] **The pu... | a8b938fe4cb6c7207c5317ee40b57a803df0c227 | 9be649f668944651b87d18465e2f15bac81a6583 | diff --git a/playwright.config.ts b/playwright.config.ts
index 02bbbd60f3..bee0241117 100644
--- a/playwright.config.ts
+++ b/playwright.config.ts
@@ -40,7 +40,6 @@ export default defineConfig({
// system-pac and pac specs share the same PAC/proxy/target ports.
name: 'system-pac',
testDir: './tests... | [
"playwright.config.ts"
] | [] | true | ||
usebruno/bruno | 8,161 | issue_to_patch | fix(bruno-app): use primary accent in OpenAPI Sync settings modal | ### Description
Aligns the OpenAPI Sync **Connection Settings** modal with Bruno's primary theme accent, fixing the out-of-place bright-green **Auto-check for updates** toggle.
JIRA: [BRU-3409](https://usebruno.atlassian.net/browse/BRU-3409)
Changes (pure CSS, no behavior change):
- **Auto-check toggle** — ... | db91dbf192b230fd676ba3861ab446491b392371 | 281cc947676d49456a2631a4e5307cb033e93812 | diff --git a/packages/bruno-app/src/components/OpenAPISyncTab/StyledWrapper.js b/packages/bruno-app/src/components/OpenAPISyncTab/StyledWrapper.js
index d21e67e2787..215d08da759 100644
--- a/packages/bruno-app/src/components/OpenAPISyncTab/StyledWrapper.js
+++ b/packages/bruno-app/src/components/OpenAPISyncTab/StyledWr... | [
"packages/bruno-app/src/components/OpenAPISyncTab/StyledWrapper.js"
] | [] | true | ||
usebruno/bruno | 8,178 | issue_to_patch | feat: AI features into preferences and Redux store | ### Description
[JIRA](https://usebruno.atlassian.net/browse/BRU-3426)
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [ ] **The pull request only addresses one issue or adds one feature.**
- [ ] **The pull request does not introduce any breaking changes**
- [... | 8f80230708acfd84b41de212e4d4f292ff801acd | 39c15c3a85fd8593e966512e88e946d0738c3e37 | diff --git a/package-lock.json b/package-lock.json
index c83299f4333..bfe8ce05cb9 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -67,6 +67,84 @@
"dev": true,
"license": "MIT"
},
+ "node_modules/@ai-sdk/anthropic": {
+ "version": "3.0.15",
+ "resolved": "https://registry.npmjs.... | [
"package-lock.json",
"packages/bruno-app/src/components/Preferences/AI/ProviderCard.js",
"packages/bruno-app/src/components/Preferences/AI/StyledWrapper.js",
"packages/bruno-app/src/components/Preferences/AI/index.js",
"packages/bruno-app/src/components/Preferences/index.js",
"packages/bruno-app/src/compo... | [] | true | ||
usebruno/bruno | 8,173 | issue_to_patch | fix(proxy): refresh cached PAC content on demand | ### Description
[JIRA](https://usebruno.atlassian.net/browse/BRU-3501)
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [ ] **The pull request only addresses one issue or adds one feature.**
- [ ] **The pull request does not introduce any breaking changes**
- [... | 462a39308dc480c1463697b53cd10fc95f59d842 | a1c285ea10d6dbce1980dd997ca85bcc0c757e46 | diff --git a/packages/bruno-app/src/components/Preferences/ProxySettings/index.js b/packages/bruno-app/src/components/Preferences/ProxySettings/index.js
index 9cdb539871a..e7931f2d709 100644
--- a/packages/bruno-app/src/components/Preferences/ProxySettings/index.js
+++ b/packages/bruno-app/src/components/Preferences/Pr... | [
"packages/bruno-app/src/components/Preferences/ProxySettings/index.js",
"packages/bruno-app/src/providers/ReduxStore/slices/app.js",
"packages/bruno-electron/src/ipc/preferences.js",
"packages/bruno-requests/src/utils/pac-resolver.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Make \"Refetch\" keyboard-accessible and add a `data-testid`.**\n\nA clickable `<span>` is not reachable via keyboard (no focus, no Enter/Space activation). Swapping to a `<button>` gives that for free, and a `data-testid` keeps it Playwright-... | diff --git a/packages/bruno-requests/src/utils/pac-resolver.spec.ts b/packages/bruno-requests/src/utils/pac-resolver.spec.ts
index 46689b13e00..0f97f383bf5 100644
--- a/packages/bruno-requests/src/utils/pac-resolver.spec.ts
+++ b/packages/bruno-requests/src/utils/pac-resolver.spec.ts
@@ -278,4 +278,38 @@ describe('pac-... | true | |
usebruno/bruno | 8,173 | comment_to_fix | fix(proxy): refresh cached PAC content on demand | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Make "Refetch" keyboard-accessible and add a `data-testid`.**
A clickable `<span>` is not reachable via keyboard (no focus, no Enter/Space activation). Swapping to a `<button>` gives that for free, and a `data-testid` keeps it Playwright-friendly.
<details>
<summ... | 462a39308dc480c1463697b53cd10fc95f59d842 | a1c285ea10d6dbce1980dd997ca85bcc0c757e46 | diff --git a/packages/bruno-app/src/components/Preferences/ProxySettings/index.js b/packages/bruno-app/src/components/Preferences/ProxySettings/index.js
index 9cdb539871a..e7931f2d709 100644
--- a/packages/bruno-app/src/components/Preferences/ProxySettings/index.js
+++ b/packages/bruno-app/src/components/Preferences/Pr... | [
"packages/bruno-app/src/components/Preferences/ProxySettings/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Make \"Refetch\" keyboard-accessible and add a `data-testid`.**\n\nA clickable `<span>` is not reachable via keyboard (no focus, no Enter/Space activation). Swapping to a `<button>` gives that for free, and a `data-testid` keeps it Playwright-... | true | ||
usebruno/bruno | 8,132 | issue_to_patch | fix: openapi spec export crash on websocket request | ### Description
We we're not handling websocket filtering when exporting via openapi, that caused exporter to crash the app.
[JIRA](https://usebruno.atlassian.net/browse/BRU-3495)
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [ ] **The pull request only add... | b43a5e6e0a9ac3cc4b3ffd904a034d47240f22bf | 1701fa2bae599b21ffe949a2d2531c0150f5c289 | diff --git a/packages/bruno-app/src/utils/exporters/openapi-spec.js b/packages/bruno-app/src/utils/exporters/openapi-spec.js
index d9ed25e0e8..4613add40d 100644
--- a/packages/bruno-app/src/utils/exporters/openapi-spec.js
+++ b/packages/bruno-app/src/utils/exporters/openapi-spec.js
@@ -4,8 +4,8 @@ import { isValidUrl }... | [
"packages/bruno-app/src/utils/exporters/openapi-spec.js",
"packages/bruno-app/src/utils/exporters/openapi-spec.spec.js"
] | [] | diff --git a/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js b/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js
index 87f668e204..6cbb122d83 100644
--- a/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js
+++ b/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js
@@ -881,3 +881,90... | true | |
usebruno/bruno | 8,103 | issue_to_patch | fix/902 - enhancement in CLI: --bail flag not stopping execution when a test fails | ### Description
CLI run command now prints a cli-table3 execution summary table and handles --bail cleanly:
New 📊 Execution Summary table with Status / Requests / Tests / Assertions / Duration columns.
Requests cell breaks down counts inline, e.g. 4 (1 Passed, 1 Failed, 2 Skipped (Bail)).
On --bail, the run sy... | 809f951a478460cf832256ebdbd96ee599dbc3a6 | 203b89bc16c8f610ce822518b089a449570a8643 | diff --git a/package-lock.json b/package-lock.json
index 64525a3731b..c83299f4333 100644
--- a/package-lock.json
+++ b/package-lock.json
@@ -4949,7 +4949,7 @@
"version": "7.26.3",
"resolved": "https://registry.npmjs.org/@babel/helper-create-regexp-features-plugin/-/helper-create-regexp-features-plugin-7.2... | [
"package-lock.json",
"packages/bruno-cli/package.json",
"packages/bruno-cli/src/commands/run.js",
"packages/bruno-cli/src/constants.js",
"packages/bruno-common/src/runner/runner-summary.ts",
"packages/bruno-common/src/runner/types/index.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_\n\n**Lock file out of sync — CI is blocked.**\n\nAll pipelines are failing because `package-lock.json` was not updated after adding `cli-table3`. Run `npm install` at the repo root to regenerate the lock file, then commit it.\n\n<details>\n<summ... | true | ||
usebruno/bruno | 8,103 | comment_to_fix | fix/902 - enhancement in CLI: --bail flag not stopping execution when a test fails | _⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_
**Lock file out of sync — CI is blocked.**
All pipelines are failing because `package-lock.json` was not updated after adding `cli-table3`. Run `npm install` at the repo root to regenerate the lock file, then commit it.
<details>
<summary>🤖 Prompt for AI Agents</... | 809f951a478460cf832256ebdbd96ee599dbc3a6 | 203b89bc16c8f610ce822518b089a449570a8643 | diff --git a/packages/bruno-cli/package.json b/packages/bruno-cli/package.json
index 53bdf77bafb..d2c2c0ea6eb 100644
--- a/packages/bruno-cli/package.json
+++ b/packages/bruno-cli/package.json
@@ -59,6 +59,7 @@
"axios-ntlm": "^1.4.2",
"chai": "^4.3.7",
"chalk": "^3.0.0",
+ "cli-table3": "^0.6.5",
... | [
"packages/bruno-cli/package.json"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_\n\n**Lock file out of sync — CI is blocked.**\n\nAll pipelines are failing because `package-lock.json` was not updated after adding `cli-table3`. Run `npm install` at the repo root to regenerate the lock file, then commit it.\n\n<details>\n<summ... | true | ||
usebruno/bruno | 8,103 | comment_to_fix | fix/902 - enhancement in CLI: --bail flag not stopping execution when a test fails | _⚠️ Potential issue_ | _🔴 Critical_ | _💤 Low value_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Search for usages of result.request or result.iterationIndex in reporters and related code
rg -n --type=js -C2 '\.request\b|\.iterationIndex\b' packages/bruno-cli/src/report... | 809f951a478460cf832256ebdbd96ee599dbc3a6 | 203b89bc16c8f610ce822518b089a449570a8643 | diff --git a/packages/bruno-cli/src/commands/run.js b/packages/bruno-cli/src/commands/run.js
index 835772a18dc..89d95c89f6a 100644
--- a/packages/bruno-cli/src/commands/run.js
+++ b/packages/bruno-cli/src/commands/run.js
@@ -4,17 +4,17 @@ const path = require('path');
const yaml = require('js-yaml');
const { forOwn, ... | [
"packages/bruno-cli/src/commands/run.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _💤 Low value_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Search for usages of result.request or result.iterationIndex in reporters and related code\nrg -n --type=js -C2 '\\.request\\b|\\.iterationInd... | true | ||
usebruno/bruno | 8,103 | comment_to_fix | fix/902 - enhancement in CLI: --bail flag not stopping execution when a test fails | can you check why we need suitename? | 809f951a478460cf832256ebdbd96ee599dbc3a6 | 203b89bc16c8f610ce822518b089a449570a8643 | diff --git a/packages/bruno-cli/src/commands/run.js b/packages/bruno-cli/src/commands/run.js
index 835772a18dc..89d95c89f6a 100644
--- a/packages/bruno-cli/src/commands/run.js
+++ b/packages/bruno-cli/src/commands/run.js
@@ -4,17 +4,17 @@ const path = require('path');
const yaml = require('js-yaml');
const { forOwn, ... | [
"packages/bruno-cli/src/commands/run.js"
] | [
{
"comment": "can you check why we need suitename?",
"path": "packages/bruno-cli/src/commands/run.js",
"hunk": "@@ -732,6 +713,49 @@ const handler = async function (argv) {\n const preRequestTestFailure = result?.preRequestTestResults?.find((iter) => iter.status === 'fail');\n const post... | true | ||
usebruno/bruno | 8,103 | comment_to_fix | fix/902 - enhancement in CLI: --bail flag not stopping execution when a test fails | I think it is better to export a COLORS object rather than exporting individual colors.
```
const COLORS = {
ORANGE: '#FFA500'
};
``` | 809f951a478460cf832256ebdbd96ee599dbc3a6 | 203b89bc16c8f610ce822518b089a449570a8643 | diff --git a/packages/bruno-cli/src/constants.js b/packages/bruno-cli/src/constants.js
index b84ecf21539..cce6dc799c7 100644
--- a/packages/bruno-cli/src/constants.js
+++ b/packages/bruno-cli/src/constants.js
@@ -2,6 +2,9 @@ const { version } = require('../package.json');
const CLI_EPILOGUE = `Documentation: https:/... | [
"packages/bruno-cli/src/constants.js"
] | [
{
"comment": "I think it is better to export a COLORS object rather than exporting individual colors.\n\n```\nconst COLORS = { \n ORANGE: '#FFA500'\n};\n```",
"path": "packages/bruno-cli/src/constants.js",
"hunk": "@@ -2,6 +2,7 @@ const { version } = require('../package.json');\n \n const CLI_EPILOGUE ... | true | ||
usebruno/bruno | 8,103 | comment_to_fix | fix/902 - enhancement in CLI: --bail flag not stopping execution when a test fails | I think the summary should already get bail information extracted using `getRunnerSummary` method. | 809f951a478460cf832256ebdbd96ee599dbc3a6 | 203b89bc16c8f610ce822518b089a449570a8643 | diff --git a/packages/bruno-cli/src/commands/run.js b/packages/bruno-cli/src/commands/run.js
index 835772a18dc..89d95c89f6a 100644
--- a/packages/bruno-cli/src/commands/run.js
+++ b/packages/bruno-cli/src/commands/run.js
@@ -4,17 +4,17 @@ const path = require('path');
const yaml = require('js-yaml');
const { forOwn, ... | [
"packages/bruno-cli/src/commands/run.js"
] | [
{
"comment": "I think the summary should already get bail information extracted using `getRunnerSummary` method.",
"path": "packages/bruno-cli/src/commands/run.js",
"hunk": "@@ -23,86 +23,66 @@ const { getSystemProxy } = require('@usebruno/requests');\n const command = 'run [paths...]';\n const desc = '... | true | ||
usebruno/bruno | 8,103 | comment_to_fix | fix/902 - enhancement in CLI: --bail flag not stopping execution when a test fails | I think we are missing `skipped: boolean` here. `skipReason` should coexist with `skipped` property. | 809f951a478460cf832256ebdbd96ee599dbc3a6 | 203b89bc16c8f610ce822518b089a449570a8643 | diff --git a/packages/bruno-common/src/runner/types/index.ts b/packages/bruno-common/src/runner/types/index.ts
index 0d9b40eb562..823c9b0cf30 100644
--- a/packages/bruno-common/src/runner/types/index.ts
+++ b/packages/bruno-common/src/runner/types/index.ts
@@ -88,6 +88,8 @@ export type T_RunnerRequestExecutionResult = ... | [
"packages/bruno-common/src/runner/types/index.ts"
] | [
{
"comment": "I think we are missing `skipped: boolean` here. `skipReason` should coexist with `skipped` property.",
"path": "packages/bruno-common/src/runner/types/index.ts",
"hunk": "@@ -88,6 +88,7 @@ export type T_RunnerRequestExecutionResult = {\n request: T_EmptyRequest | T_Request;\n response:... | true | ||
usebruno/bruno | 8,103 | comment_to_fix | fix/902 - enhancement in CLI: --bail flag not stopping execution when a test fails | Is this handing yml collections? | 809f951a478460cf832256ebdbd96ee599dbc3a6 | 203b89bc16c8f610ce822518b089a449570a8643 | diff --git a/packages/bruno-cli/src/commands/run.js b/packages/bruno-cli/src/commands/run.js
index 835772a18dc..89d95c89f6a 100644
--- a/packages/bruno-cli/src/commands/run.js
+++ b/packages/bruno-cli/src/commands/run.js
@@ -4,17 +4,17 @@ const path = require('path');
const yaml = require('js-yaml');
const { forOwn, ... | [
"packages/bruno-cli/src/commands/run.js"
] | [
{
"comment": "Is this handing yml collections?",
"path": "packages/bruno-cli/src/commands/run.js",
"hunk": "@@ -732,6 +711,64 @@ const handler = async function (argv) {\n const preRequestTestFailure = result?.preRequestTestResults?.find((iter) => iter.status === 'fail');\n const postResp... | true | ||
usebruno/bruno | 8,112 | issue_to_patch | fix(proxy): proxy config export from v2 to import in v3 | JIRA link - https://usebruno.atlassian.net/browse/BRU-3216
### Description
Proxy settings were not being imported properly from JSON export file created with v2 and imported into v3.
Currently yaml import method works but the bru method still fails to import a collection.
#### Contribution Checklist:
- [... | 413697cbe751fb4a01876f1ce4c6ffd7b176317a | dc58dd9a9b9407c4f3049f151918d08710650154 | diff --git a/packages/bruno-electron/src/ipc/collection.js b/packages/bruno-electron/src/ipc/collection.js
index 09dd7af6207..d71643457a9 100644
--- a/packages/bruno-electron/src/ipc/collection.js
+++ b/packages/bruno-electron/src/ipc/collection.js
@@ -28,6 +28,7 @@ const { cookiesStore } = require('../store/cookies');... | [
"packages/bruno-electron/src/ipc/collection.js",
"packages/bruno-electron/src/utils/collection-import.js",
"tests/import/bruno/fixtures/bruno-v2-json-collection-with-proxy.json",
"tests/import/bruno/import-bruno-JSON-v2.spec.ts"
] | [
{
"comment": "Please verify if we needed to add this anywhere else, also we need to have a playwright test case teh verifies that the proxy is successfully imported",
"path": "packages/bruno-electron/src/ipc/collection.js",
"hunk": "@@ -1226,7 +1227,7 @@ const registerRendererEventHandlers = (mainWindow... | diff --git a/tests/import/bruno/fixtures/bruno-v2-json-collection-with-proxy.json b/tests/import/bruno/fixtures/bruno-v2-json-collection-with-proxy.json
new file mode 100644
index 00000000000..d8ea92dc508
--- /dev/null
+++ b/tests/import/bruno/fixtures/bruno-v2-json-collection-with-proxy.json
@@ -0,0 +1,87 @@
+{
+ "na... | true | |
usebruno/bruno | 8,112 | comment_to_fix | fix(proxy): proxy config export from v2 to import in v3 | Please verify if we needed to add this anywhere else, also we need to have a playwright test case teh verifies that the proxy is successfully imported | 413697cbe751fb4a01876f1ce4c6ffd7b176317a | dc58dd9a9b9407c4f3049f151918d08710650154 | diff --git a/packages/bruno-electron/src/ipc/collection.js b/packages/bruno-electron/src/ipc/collection.js
index 09dd7af6207..d71643457a9 100644
--- a/packages/bruno-electron/src/ipc/collection.js
+++ b/packages/bruno-electron/src/ipc/collection.js
@@ -28,6 +28,7 @@ const { cookiesStore } = require('../store/cookies');... | [
"packages/bruno-electron/src/ipc/collection.js"
] | [
{
"comment": "Please verify if we needed to add this anywhere else, also we need to have a playwright test case teh verifies that the proxy is successfully imported",
"path": "packages/bruno-electron/src/ipc/collection.js",
"hunk": "@@ -1226,7 +1227,7 @@ const registerRendererEventHandlers = (mainWindow... | true | ||
usebruno/bruno | 8,112 | comment_to_fix | fix(proxy): proxy config export from v2 to import in v3 | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Verify whether the custom Playwright wrapper defines a worker-scoped `page`
# and whether this pattern is already used successfully across tests.
set -euo pipefail
echo "== Lo... | 413697cbe751fb4a01876f1ce4c6ffd7b176317a | dc58dd9a9b9407c4f3049f151918d08710650154 | diff --git a/tests/import/bruno/import-bruno-JSON-v2.spec.ts b/tests/import/bruno/import-bruno-JSON-v2.spec.ts
new file mode 100644
index 00000000000..1c9f3416ab1
--- /dev/null
+++ b/tests/import/bruno/import-bruno-JSON-v2.spec.ts
@@ -0,0 +1,37 @@
+import path from 'path';
+import { test, expect } from '../../../playwr... | [
"tests/import/bruno/import-bruno-JSON-v2.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify whether the custom Playwright wrapper defines a worker-scoped `page`\n# and whether this pattern is already used successfully across tests.... | true | ||
usebruno/bruno | 8,112 | comment_to_fix | fix(proxy): proxy config export from v2 to import in v3 | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
set -euo pipefail
echo "== Verify transformProxyConfig default behavior =="
rg -n -C3 "proxy = proxy \|\| \{\}|hasOwnProperty\('enabled'\)|return proxy;" --type=ts
echo
echo "==... | 413697cbe751fb4a01876f1ce4c6ffd7b176317a | dc58dd9a9b9407c4f3049f151918d08710650154 | diff --git a/packages/bruno-electron/src/utils/collection-import.js b/packages/bruno-electron/src/utils/collection-import.js
index 4cfeac60bec..4d541d60f07 100644
--- a/packages/bruno-electron/src/utils/collection-import.js
+++ b/packages/bruno-electron/src/utils/collection-import.js
@@ -4,6 +4,7 @@ const { ipcMain } =... | [
"packages/bruno-electron/src/utils/collection-import.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\necho \"== Verify transformProxyConfig default behavior ==\"\nrg -n -C3 \"proxy = proxy \\|\\| \\{\\}|hasOwnProperty\\('enabled'... | true | ||
usebruno/bruno | 8,047 | issue_to_patch | feat: show scripted requests in timeline | ### Description
[JIRA](https://usebruno.atlassian.net/browse/BRU-1270)
<!-- Explain here the changes your PR introduces and text to help us understand the context of this change. -->
#### Contribution Checklist:
- [x] **I've used AI significantly to create this pull request**
- [x] **The pull request only ... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-app/src/components/ResponsePane/RunnerTimeline/index.js b/packages/bruno-app/src/components/ResponsePane/RunnerTimeline/index.js
index 8c3e839aad8..9a0ec8e2775 100644
--- a/packages/bruno-app/src/components/ResponsePane/RunnerTimeline/index.js
+++ b/packages/bruno-app/src/components/Response... | [
"packages/bruno-app/src/components/ResponsePane/RunnerTimeline/index.js",
"packages/bruno-app/src/components/ResponsePane/Timeline/GrpcTimelineItem/index.js",
"packages/bruno-app/src/components/ResponsePane/Timeline/StyledWrapper.js",
"packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Commo... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_\n\n**Runner timeline is missing some OAuth entries.**\n\nThis builder only looks at `collection.timeline` rows for `item.uid`, and it only emits oauth rows from `debugInfo`. That means inherited collection/folder auth calls and oauth entries wit... | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Status/index.spec.js b/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Status/index.spec.js
new file mode 100644
index 00000000000..c68c0c2e126
--- /dev/null
+++ b/packages/bruno-app/src/components/Respo... | true | |
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_
**Runner timeline is missing some OAuth entries.**
This builder only looks at `collection.timeline` rows for `item.uid`, and it only emits oauth rows from `debugInfo`. That means inherited collection/folder auth calls and oauth entries without debug info can disapp... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-app/src/components/ResponsePane/RunnerTimeline/index.js b/packages/bruno-app/src/components/ResponsePane/RunnerTimeline/index.js
index 8c3e839aad8..9a0ec8e2775 100644
--- a/packages/bruno-app/src/components/ResponsePane/RunnerTimeline/index.js
+++ b/packages/bruno-app/src/components/Response... | [
"packages/bruno-app/src/components/ResponsePane/RunnerTimeline/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_\n\n**Runner timeline is missing some OAuth entries.**\n\nThis builder only looks at `collection.timeline` rows for `item.uid`, and it only emits oauth rows from `debugInfo`. That means inherited collection/folder auth calls and oauth entries wit... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Badge selection is out of sync with the filter kind.**
`getEntryKind()` buckets `tests` and `post-response` entries as `post`, but `getBadge()` ignores `phase` and only checks `source`. A tests-phase `sendRequest` entry will therefore be counted under Post-Response ... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/entryMeta.js b/packages/bruno-app/src/components/ResponsePane/Timeline/entryMeta.js
new file mode 100644
index 00000000000..addaf31d90d
--- /dev/null
+++ b/packages/bruno-app/src/components/ResponsePane/Timeline/entryMeta.js
@@ -0,0 +1,22 @@
+// Keys ... | [
"packages/bruno-app/src/components/ResponsePane/Timeline/entryMeta.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Badge selection is out of sync with the filter kind.**\n\n`getEntryKind()` buckets `tests` and `post-response` entries as `post`, but `getBadge()` ignores `phase` and only checks `source`. A tests-phase `sendRequest` entry will therefore be co... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Reset the active filter when the entry set changes.**
If a user leaves this pane on `oauth`/`post` and then opens a request that only has main entries, `showFilterBar` becomes false but `activeFilter` still filters every row out. The result is an empty timeline with... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/index.js b/packages/bruno-app/src/components/ResponsePane/Timeline/index.js
index 93d4ec082c5..e6d12a41ffd 100644
--- a/packages/bruno-app/src/components/ResponsePane/Timeline/index.js
+++ b/packages/bruno-app/src/components/ResponsePane/Timeline/inde... | [
"packages/bruno-app/src/components/ResponsePane/Timeline/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Reset the active filter when the entry set changes.**\n\nIf a user leaves this pane on `oauth`/`post` and then opens a request that only has main entries, `showFilterBar` becomes false but `activeFilter` still filters every row out. The result... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**OAuth entries without `debugInfo` disappear here.**
`buildTimelineEntries()` keeps an oauth entry even when `debugInfo` is empty, but this branch only renders oauth rows that have `_oauth2Child`. Those fallback oauth entries currently vanish from the timeline. Eithe... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/index.js b/packages/bruno-app/src/components/ResponsePane/Timeline/index.js
index 93d4ec082c5..e6d12a41ffd 100644
--- a/packages/bruno-app/src/components/ResponsePane/Timeline/index.js
+++ b/packages/bruno-app/src/components/ResponsePane/Timeline/inde... | [
"packages/bruno-app/src/components/ResponsePane/Timeline/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**OAuth entries without `debugInfo` disappear here.**\n\n`buildTimelineEntries()` keeps an oauth entry even when `debugInfo` is empty, but this branch only renders oauth rows that have `_oauth2Child`. Those fallback oauth entries currently vanis... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Use a semantic button for the Body toggle (and add a test hook).**
This toggle is click-only right now; keyboard users can’t reliably operate it. Please switch to a `<button type='button'>` and add `aria-expanded` + `data-testid`.
<details>
<summary>Proposed fix<... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Body/index.js b/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Body/index.js
index 21976c97164..c71810830f4 100644
--- a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Body/... | [
"packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Body/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Use a semantic button for the Body toggle (and add a test hook).**\n\nThis toggle is click-only right now; keyboard users can’t reliably operate it. Please switch to a `<button type='button'>` and add `aria-expanded` + `data-testid`.\n\n \n<de... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Make the Headers toggle keyboard-accessible and testable.**
`div` + `onClick` is not a good control for keyboard users. Use a button with `aria-expanded`, and add a `data-testid` for Playwright.
<details>
<summary>Proposed fix</summary>
```diff
- <div class... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Headers/index.js b/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Headers/index.js
index 812a61de9f6..27e6fc82fd0 100644
--- a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common... | [
"packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Common/Headers/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Make the Headers toggle keyboard-accessible and testable.**\n\n`div` + `onClick` is not a good control for keyboard users. Use a button with `aria-expanded`, and add a `data-testid` for Playwright.\n\n \n<details>\n<summary>Proposed fix</summa... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Use a real control for expand/collapse.**
The row is clickable but rendered as a plain `div`, so it can't be focused or toggled from the keyboard. That blocks access to the request/response/network panels for keyboard users. A `button` wrapper, or at least `role="bu... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/index.js b/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/index.js
index 030ba6fb02a..65fd87e1df5 100644
--- a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/index.js
+++ b/packages/bruno-app/sr... | [
"packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Use a real control for expand/collapse.**\n\nThe row is clickable but rendered as a plain `div`, so it can't be focused or toggled from the keyboard. That blocks access to the request/response/network panels for keyboard users. A `button` wrap... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Treat status code `0` as a valid value in metadata visibility.**
Using truthiness for `code` hides metadata when `code === 0`. Use an explicit null/undefined check.
<details>
<summary>Proposed fix</summary>
```diff
- const hasAny = code || statusText || (typeof... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Response/index.js b/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Response/index.js
index 84dd6920f90..38a1e84f734 100644
--- a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Response/index.js
... | [
"packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/Response/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Treat status code `0` as a valid value in metadata visibility.**\n\nUsing truthiness for `code` hides metadata when `code === 0`. Use an explicit null/undefined check.\n\n \n<details>\n<summary>Proposed fix</summary>\n\n```diff\n- const hasAn... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_
**Move hardcoded RGBA colors to theme-driven tokens/functions.**
The new badge/hover backgrounds use literal RGBA values, which will drift across themes. Please route these through `theme` color tokens (or theme-derived alpha helpers) for consistency.
As per c... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/StyledWrapper.js b/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/StyledWrapper.js
index e570bded244..3d7e76f35f4 100644
--- a/packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/StyledWrapper.js
+++... | [
"packages/bruno-app/src/components/ResponsePane/Timeline/TimelineItem/StyledWrapper.js"
] | [
{
"comment": "_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_\n\n**Move hardcoded RGBA colors to theme-driven tokens/functions.**\n\nThe new badge/hover backgrounds use literal RGBA values, which will drift across themes. Please route these through `theme` color tokens (or theme-derived alpha helpers) fo... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Persist `requestUid` for runner scripted-request entries.**
The item-level timeline stores `requestUid`, but this runner branch drops it. If the same `itemUid` runs multiple times in one collection run, scripted requests from different iterations become indistinguis... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js b/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js
index ed6cf95c84b..a769b24af79 100644
--- a/packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js
+++ b/packages/bruno-app/src/providers/ReduxS... | [
"packages/bruno-app/src/providers/ReduxStore/slices/collections/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Persist `requestUid` for runner scripted-request entries.**\n\nThe item-level timeline stores `requestUid`, but this runner branch drops it. If the same `itemUid` runs multiple times in one collection run, scripted requests from different iter... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Record `bru.runRequest()` calls in the runner path too.**
These emissions only replay `scriptResult.scriptedRequestEntries`, but the folder-runner `runRequestByItemPathname()` still doesn't mirror the standalone `callerBru._recordScriptedRequest()` flow. `bru.runReq... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-electron/src/ipc/network/index.js b/packages/bruno-electron/src/ipc/network/index.js
index 1445a097921..259133a4db4 100644
--- a/packages/bruno-electron/src/ipc/network/index.js
+++ b/packages/bruno-electron/src/ipc/network/index.js
@@ -2,6 +2,7 @@ const https = require('https');
const axio... | [
"packages/bruno-electron/src/ipc/network/index.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Record `bru.runRequest()` calls in the runner path too.**\n\nThese emissions only replay `scriptResult.scriptedRequestEntries`, but the folder-runner `runRequestByItemPathname()` still doesn't mirror the standalone `callerBru._recordScriptedRe... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
# First, let's read the file around the referenced lines
head -n 180 packages/bruno-electron/src/utils/collection.js | tail -n 30
```
Repository: usebruno/bruno
Length of output: 1207
---
... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-electron/src/utils/collection.js b/packages/bruno-electron/src/utils/collection.js
index 9c837e01b19..39018e6cceb 100644
--- a/packages/bruno-electron/src/utils/collection.js
+++ b/packages/bruno-electron/src/utils/collection.js
@@ -151,12 +151,9 @@ const mergeVars = (collection, request, re... | [
"packages/bruno-electron/src/utils/collection.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n# First, let's read the file around the referenced lines\nhead -n 180 packages/bruno-electron/src/utils/collection.js | tail -n 30\n```\n\nRepository: usebruno/b... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_
**Snapshot scope when `sendRequest` is dispatched, not when it completes.**
`onComplete` reads `this._currentScope` after the async request settles. If a segment fires `bru.sendRequest()` without awaiting it, the next wrapped segment can update the scope first, so ... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-js/src/bru.js b/packages/bruno-js/src/bru.js
index f728f15c02f..e578952adf0 100644
--- a/packages/bruno-js/src/bru.js
+++ b/packages/bruno-js/src/bru.js
@@ -1,7 +1,7 @@
const { cloneDeep } = require('lodash');
const xmlFormat = require('xml-formatter');
const { interpolate: _interpolate }... | [
"packages/bruno-js/src/bru.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _🏗️ Heavy lift_\n\n**Snapshot scope when `sendRequest` is dispatched, not when it completes.**\n\n`onComplete` reads `this._currentScope` after the async request settles. If a segment fires `bru.sendRequest()` without awaiting it, the next wrapped segment can u... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Assert Body placement also excludes OAuth from headers.**
The body-placement branch currently checks URL and body only. It can still pass if OAuth params are accidentally sent via `Authorization`. Add a negative headers assertion here to fully validate placement.
... | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/tests/auth/oauth1/oauth1-runner.spec.ts b/tests/auth/oauth1/oauth1-runner.spec.ts
index 1836195625a..c662206ac85 100644
--- a/tests/auth/oauth1/oauth1-runner.spec.ts
+++ b/tests/auth/oauth1/oauth1-runner.spec.ts
@@ -71,38 +71,39 @@ const runAndValidate = async (page, collectionName: string) => {
};
/**... | [
"tests/auth/oauth1/oauth1-runner.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Assert Body placement also excludes OAuth from headers.**\n\nThe body-placement branch currently checks URL and body only. It can still pass if OAuth params are accidentally sent via `Authorization`. Add a negative headers assertion here to fu... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | should this also be `standalone` or `runner` based on where the call is from? | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-electron/src/ipc/network/index.js b/packages/bruno-electron/src/ipc/network/index.js
index 1445a097921..259133a4db4 100644
--- a/packages/bruno-electron/src/ipc/network/index.js
+++ b/packages/bruno-electron/src/ipc/network/index.js
@@ -2,6 +2,7 @@ const https = require('https');
const axio... | [
"packages/bruno-electron/src/ipc/network/index.js"
] | [
{
"comment": "should this also be `standalone` or `runner` based on where the call is from?",
"path": "packages/bruno-electron/src/ipc/network/index.js",
"hunk": "",
"resolving_sha": "cd5e226e20b902083697a80a2a6f1cca6adfc8f8",
"resolving_diff": "diff --git a/packages/bruno-electron/src/ipc/netwo... | true | ||
usebruno/bruno | 8,047 | comment_to_fix | feat: show scripted requests in timeline | @lohit-bruno @sanish-bruno need your eyes here | e0de7d55571e8c3cc0bfb557598f6bcbb635c75f | cd5e226e20b902083697a80a2a6f1cca6adfc8f8 | diff --git a/packages/bruno-electron/src/utils/collection.js b/packages/bruno-electron/src/utils/collection.js
index 9c837e01b19..39018e6cceb 100644
--- a/packages/bruno-electron/src/utils/collection.js
+++ b/packages/bruno-electron/src/utils/collection.js
@@ -151,12 +151,9 @@ const mergeVars = (collection, request, re... | [
"packages/bruno-electron/src/utils/collection.js"
] | [
{
"comment": "@lohit-bruno @sanish-bruno need your eyes here",
"path": "packages/bruno-electron/src/utils/collection.js",
"hunk": "@@ -151,20 +151,20 @@ const mergeVars = (collection, request, requestTreePath = []) => {\n }\n };\n \n-/**\n- * Wraps a script in an IIFE closure to isolate its scope\n- *... | true | ||
usebruno/bruno | 8,143 | issue_to_patch | feat: npm package report and installation support | ### Description
[JIRA](https://usebruno.atlassian.net/browse/BRU-2898)
<!-- Explain here the changes your PR introduces and text to help us understand the context of this change. -->
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [ ] **The pull request only ... | 244f528277933118ab7f27cecb95d659d1ee4866 | ac18cf4f06909ffcdf0cb5c5d874bb0f9fb4a366 | diff --git a/packages/bruno-app/src/components/Sidebar/PostmanPackageReport/StyledWrapper.js b/packages/bruno-app/src/components/Sidebar/PostmanPackageReport/StyledWrapper.js
new file mode 100644
index 00000000000..6f3c11793b6
--- /dev/null
+++ b/packages/bruno-app/src/components/Sidebar/PostmanPackageReport/StyledWrap... | [
"packages/bruno-app/src/components/Sidebar/PostmanPackageReport/StyledWrapper.js",
"packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.js",
"packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.spec.jsx",
"packages/bruno-app/src/components/Sidebar/Sections/CollectionsSection/... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Normalization drops neither subpath nor `node:` prefix → spurious `needsInstall`.**\n\n`require('lodash/get')` normalizes to `lodash/get` (not in `BUNDLED_LIBRARIES`) and `require('node:crypto')` stays `node:crypto` (not in `NODE_BUILTINS`). B... | diff --git a/packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.spec.jsx b/packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.spec.jsx
new file mode 100644
index 00000000000..9accd8458f4
--- /dev/null
+++ b/packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.spec.jsx... | true | |
usebruno/bruno | 8,143 | comment_to_fix | feat: npm package report and installation support | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Normalization drops neither subpath nor `node:` prefix → spurious `needsInstall`.**
`require('lodash/get')` normalizes to `lodash/get` (not in `BUNDLED_LIBRARIES`) and `require('node:crypto')` stays `node:crypto` (not in `NODE_BUILTINS`). Both fall through to `needs... | 244f528277933118ab7f27cecb95d659d1ee4866 | ac18cf4f06909ffcdf0cb5c5d874bb0f9fb4a366 | diff --git a/packages/bruno-converters/src/postman/postman-package-detector.js b/packages/bruno-converters/src/postman/postman-package-detector.js
new file mode 100644
index 00000000000..f4a103be3ec
--- /dev/null
+++ b/packages/bruno-converters/src/postman/postman-package-detector.js
@@ -0,0 +1,178 @@
+/**
+ * Detectio... | [
"packages/bruno-converters/src/postman/postman-package-detector.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Normalization drops neither subpath nor `node:` prefix → spurious `needsInstall`.**\n\n`require('lodash/get')` normalizes to `lodash/get` (not in `BUNDLED_LIBRARIES`) and `require('node:crypto')` stays `node:crypto` (not in `NODE_BUILTINS`). B... | true | ||
usebruno/bruno | 8,143 | comment_to_fix | feat: npm package report and installation support | if the script has developer mode only lib (eg. lodash), we wont be showing the switch to developer prompt modal ? | 244f528277933118ab7f27cecb95d659d1ee4866 | ac18cf4f06909ffcdf0cb5c5d874bb0f9fb4a366 | diff --git a/packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.js b/packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.js
new file mode 100644
index 00000000000..e19d9878228
--- /dev/null
+++ b/packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.js
@@ -0,0 +1,341 @@... | [
"packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.js"
] | [
{
"comment": "if the script has developer mode only lib (eg. lodash), we wont be showing the switch to developer prompt modal ? ",
"path": "packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.js",
"hunk": "@@ -0,0 +1,304 @@\n+import React, { Fragment, useMemo, useState } from 'react';\n... | true | ||
usebruno/bruno | 8,143 | comment_to_fix | feat: npm package report and installation support | should we strip `node:` prefix as well ? | 244f528277933118ab7f27cecb95d659d1ee4866 | ac18cf4f06909ffcdf0cb5c5d874bb0f9fb4a366 | diff --git a/packages/bruno-converters/src/postman/postman-package-detector.js b/packages/bruno-converters/src/postman/postman-package-detector.js
new file mode 100644
index 00000000000..f4a103be3ec
--- /dev/null
+++ b/packages/bruno-converters/src/postman/postman-package-detector.js
@@ -0,0 +1,178 @@
+/**
+ * Detectio... | [
"packages/bruno-converters/src/postman/postman-package-detector.js"
] | [
{
"comment": "should we strip `node:` prefix as well ?",
"path": "packages/bruno-converters/src/postman/postman-package-detector.js",
"hunk": "@@ -0,0 +1,164 @@\n+/**\n+ * Detection, translation and classification of `pm.require()` / `require()`\n+ * calls inside Postman scripts being imported into Brun... | true | ||
usebruno/bruno | 8,143 | comment_to_fix | feat: npm package report and installation support | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Make the auto-dismiss assertions async-safe to avoid flaky tests.**
`onClose` and empty-state rendering may occur after effect/state updates. Assert them with `waitFor` instead of immediately after `renderModal`.
<details>
<summary>Suggested fix</summary>
```diff... | 244f528277933118ab7f27cecb95d659d1ee4866 | ac18cf4f06909ffcdf0cb5c5d874bb0f9fb4a366 | diff --git a/packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.spec.jsx b/packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.spec.jsx
new file mode 100644
index 00000000000..9accd8458f4
--- /dev/null
+++ b/packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.spec.jsx... | [
"packages/bruno-app/src/components/Sidebar/PostmanPackageReport/index.spec.jsx"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Make the auto-dismiss assertions async-safe to avoid flaky tests.**\n\n`onClose` and empty-state rendering may occur after effect/state updates. Assert them with `waitFor` instead of immediately after `renderModal`.\n \n<details>\n<summary>Sug... | true | ||
usebruno/bruno | 8,129 | issue_to_patch | fix(app): preserve multipart file values when creating example from r… | ### Description
[JIRA](https://usebruno.atlassian.net/browse/BRU-3036)
#### Contribution Checklist:
- [ ] **I've used AI significantly to create this pull request**
- [ ] **The pull request only addresses one issue or adds one feature.**
- [ ] **The pull request does not introduce any breaking changes**
- [... | 4ee9a7546510f4e7cc4a040b12b01ed5da265908 | a7b45ef5f30a9252a23fa4fb8059a1cdf24ce74f | diff --git a/packages/bruno-app/src/components/MultipartFileChipsCell/index.js b/packages/bruno-app/src/components/MultipartFileChipsCell/index.js
index 62340e766a7..73ee8ac4e11 100644
--- a/packages/bruno-app/src/components/MultipartFileChipsCell/index.js
+++ b/packages/bruno-app/src/components/MultipartFileChipsCell/... | [
"packages/bruno-app/src/components/MultipartFileChipsCell/index.js",
"packages/bruno-app/src/providers/ReduxStore/slices/collections/exampleReducers.js",
"tests/request/multipart-form/fixtures/collection/bruno.json",
"tests/request/multipart-form/fixtures/collection/chip-tooltip.bru",
"tests/request/multipa... | [
{
"comment": "is this supposed to be a `serial` test? \n\nIf not then please remove this. ",
"path": "tests/response-examples/save-as-example-multipart.spec.ts",
"hunk": "@@ -0,0 +1,59 @@\n+import { test, expect } from '../../playwright';\n+import fs from 'fs';\n+import path from 'path';\n+\n+const fixt... | diff --git a/tests/request/multipart-form/fixtures/collection/bruno.json b/tests/request/multipart-form/fixtures/collection/bruno.json
new file mode 100644
index 00000000000..03a26e1f763
--- /dev/null
+++ b/tests/request/multipart-form/fixtures/collection/bruno.json
@@ -0,0 +1,5 @@
+{
+ "version": "1",
+ "name": "col... | true | |
usebruno/bruno | 8,129 | comment_to_fix | fix(app): preserve multipart file values when creating example from r… | is this supposed to be a `serial` test?
If not then please remove this. | 4ee9a7546510f4e7cc4a040b12b01ed5da265908 | a7b45ef5f30a9252a23fa4fb8059a1cdf24ce74f | diff --git a/tests/response-examples/save-as-example-multipart.spec.ts b/tests/response-examples/save-as-example-multipart.spec.ts
new file mode 100644
index 00000000000..a26ab180ac2
--- /dev/null
+++ b/tests/response-examples/save-as-example-multipart.spec.ts
@@ -0,0 +1,59 @@
+import { test, expect } from '../../playw... | [
"tests/response-examples/save-as-example-multipart.spec.ts"
] | [
{
"comment": "is this supposed to be a `serial` test? \n\nIf not then please remove this. ",
"path": "tests/response-examples/save-as-example-multipart.spec.ts",
"hunk": "@@ -0,0 +1,59 @@\n+import { test, expect } from '../../playwright';\n+import fs from 'fs';\n+import path from 'path';\n+\n+const fixt... | true | ||
usebruno/bruno | 8,129 | comment_to_fix | fix(app): preserve multipart file values when creating example from r… | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Use visibility, not DOM presence, for branch selection**
Line 21 uses `summary.count()` which can be truthy even when the summary is not visible, making this branch flaky (`summary.click()` may fail on Line 22). Use a visibility check instead.
<details>
<summary... | 4ee9a7546510f4e7cc4a040b12b01ed5da265908 | a7b45ef5f30a9252a23fa4fb8059a1cdf24ce74f | diff --git a/tests/request/multipart-form/multipart-chip-tooltips.spec.ts b/tests/request/multipart-form/multipart-chip-tooltips.spec.ts
new file mode 100644
index 00000000000..15059727b45
--- /dev/null
+++ b/tests/request/multipart-form/multipart-chip-tooltips.spec.ts
@@ -0,0 +1,54 @@
+import { test, expect } from '..... | [
"tests/request/multipart-form/multipart-chip-tooltips.spec.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Use visibility, not DOM presence, for branch selection**\n\nLine 21 uses `summary.count()` which can be truthy even when the summary is not visible, making this branch flaky (`summary.click()` may fail on Line 22). Use a visibility check inste... | true | ||
usebruno/bruno | 8,109 | issue_to_patch | OpenAPI "Try it out" requests blocket by Content Security Policy
### I have checked the following:
- [x] I have searched existing issues and found nothing related to my issue.
### This bug is:
- [ ] making Bruno unusable for me
- [x] slowing me down but I'm able to continue working
- [ ] annoying
- [x] this feature... | fix(app): make SwaggerUI "Try it out" work cross-origin in API Spec viewer (BRU-3300) | ### Description
SwaggerUI's **Try it out** in the API Spec viewer failed on every cross-origin request with:
> `Failed to fetch. Possible Reasons: CORS / Network Failure / URL scheme must be "http" or "https" for CORS request.`
JIRA : https://usebruno.atlassian.net/browse/BRU-3300
Two stacked blockers caused it:
-... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | e3cd91235e58e6e54d60a650a5bfd0f50f3efc34 | diff --git a/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js b/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js
index 8f276faf26e..faead0945e7 100644
--- a/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js
+++ b/packages/bruno-app/src/components... | [
"packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js",
"packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/serializeBody.js",
"packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/serializeBody.spec.js",
"packages/bruno-electron/src/ipc/apiSpec.js",
"packages/... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Guard IPC payload before destructuring.**\n\nIf the caller sends `undefined`/`null`, Line 4 throws before `try/catch`, so this path skips your normalized `{ error, code, message }` contract.\n\n \n\n<details>\n<summary>Proposed fix</summary>\n... | diff --git a/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/serializeBody.spec.js b/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/serializeBody.spec.js
new file mode 100644
index 00000000000..81f52035310
--- /dev/null
+++ b/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Sw... | true |
usebruno/bruno | 8,109 | comment_to_fix | fix(app): make SwaggerUI "Try it out" work cross-origin in API Spec viewer (BRU-3300) | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Guard IPC payload before destructuring.**
If the caller sends `undefined`/`null`, Line 4 throws before `try/catch`, so this path skips your normalized `{ error, code, message }` contract.
<details>
<summary>Proposed fix</summary>
```diff
-const proxySwaggerFetc... | 6b7e5f3813e5eba1ba60d2a1651dd39be32af31e | e3cd91235e58e6e54d60a650a5bfd0f50f3efc34 | diff --git a/packages/bruno-electron/src/ipc/swagger-fetch.js b/packages/bruno-electron/src/ipc/swagger-fetch.js
new file mode 100644
index 00000000000..845867fb93f
--- /dev/null
+++ b/packages/bruno-electron/src/ipc/swagger-fetch.js
@@ -0,0 +1,69 @@
+const { getCertsAndProxyConfig } = require('./network/cert-utils');
... | [
"packages/bruno-electron/src/ipc/swagger-fetch.js"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Guard IPC payload before destructuring.**\n\nIf the caller sends `undefined`/`null`, Line 4 throws before `try/catch`, so this path skips your normalized `{ error, code, message }` contract.\n\n \n\n<details>\n<summary>Proposed fix</summary>\n... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.