repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
usebruno/bruno
8,109
comment_to_fix
fix(app): make SwaggerUI "Try it out" work cross-origin in API Spec viewer (BRU-3300)
Axios returns response.headers['set-cookie'] as string[]. new Headers({ 'set-cookie': ['a=1','b=2'] }) coerces the array via toString() to "a=1,b=2", which is an invalid Set-Cookie and in some engines throws. Normalize on the main side, or Headers.append() per value: ``` const h = new Headers(); for (const [k, v] of O...
6b7e5f3813e5eba1ba60d2a1651dd39be32af31e
e3cd91235e58e6e54d60a650a5bfd0f50f3efc34
diff --git a/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js b/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js index 8f276faf26e..faead0945e7 100644 --- a/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js +++ b/packages/bruno-app/src/components...
[ "packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js" ]
[ { "comment": "Axios returns response.headers['set-cookie'] as string[]. new Headers({ 'set-cookie': ['a=1','b=2'] }) coerces the array via toString() to \"a=1,b=2\", which is an invalid Set-Cookie and in some engines throws. Normalize on the main side, or Headers.append() per value:\n\n```\nconst h = new Header...
true
usebruno/bruno
8,109
comment_to_fix
fix(app): make SwaggerUI "Try it out" work cross-origin in API Spec viewer (BRU-3300)
> // FormData / Blob / ArrayBuffer not yet supported by the IPC bridge. Are we displaying a clear warning to the user in this case?
6b7e5f3813e5eba1ba60d2a1651dd39be32af31e
e3cd91235e58e6e54d60a650a5bfd0f50f3efc34
diff --git a/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js b/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js index 8f276faf26e..faead0945e7 100644 --- a/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js +++ b/packages/bruno-app/src/components...
[ "packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js" ]
[ { "comment": "> // FormData / Blob / ArrayBuffer not yet supported by the IPC bridge.\n\nAre we displaying a clear warning to the user in this case?", "path": "packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js", "hunk": "@@ -2,11 +2,63 @@ import { memo } from 'react';\n import Sw...
true
usebruno/bruno
8,109
comment_to_fix
fix(app): make SwaggerUI "Try it out" work cross-origin in API Spec viewer (BRU-3300)
`response.headers` in axios is an AxiosHeaders instance ``` headers: typeof response.headers?.toJSON === 'function' ? response.headers.toJSON() : { ...response.headers } ```
6b7e5f3813e5eba1ba60d2a1651dd39be32af31e
e3cd91235e58e6e54d60a650a5bfd0f50f3efc34
diff --git a/packages/bruno-electron/src/ipc/swagger-fetch.js b/packages/bruno-electron/src/ipc/swagger-fetch.js new file mode 100644 index 00000000000..845867fb93f --- /dev/null +++ b/packages/bruno-electron/src/ipc/swagger-fetch.js @@ -0,0 +1,69 @@ +const { getCertsAndProxyConfig } = require('./network/cert-utils'); ...
[ "packages/bruno-electron/src/ipc/swagger-fetch.js" ]
[ { "comment": "`response.headers` in axios is an AxiosHeaders instance\n\n```\nheaders: typeof response.headers?.toJSON === 'function'\n ? response.headers.toJSON()\n : { ...response.headers }\n```", "path": "packages/bruno-electron/src/ipc/swagger-fetch.js", "hunk": "@@ -0,0 +1,65 @@\n+const { getCert...
true
usebruno/bruno
8,109
comment_to_fix
fix(app): make SwaggerUI "Try it out" work cross-origin in API Spec viewer (BRU-3300)
${code}: ${message} discards stack and original error type. For diagnostics, attach the code as a property: ``` const err = new TypeError(result.message); err.code = result.code; throw err;
6b7e5f3813e5eba1ba60d2a1651dd39be32af31e
e3cd91235e58e6e54d60a650a5bfd0f50f3efc34
diff --git a/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js b/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js index 8f276faf26e..faead0945e7 100644 --- a/packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js +++ b/packages/bruno-app/src/components...
[ "packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js" ]
[ { "comment": "${code}: ${message} discards stack and original error type. For diagnostics, attach the code as a property:\n\n```\nconst err = new TypeError(result.message);\nerr.code = result.code;\nthrow err;", "path": "packages/bruno-app/src/components/ApiSpecPanel/Renderers/Swagger/index.js", "hunk":...
true
usebruno/bruno
8,096
issue_to_patch
“Workspace opened successfully” Toast Appears Even After Canceling Workspace Folder Selection ### I have checked the following: - [x] I have searched existing issues and found nothing related to my issue. ### This bug is: - [ ] making Bruno unusable for me - [ ] slowing me down but I'm able to continue working - [ ...
fix: prevent success toast when workspace selection is cancelled
### Description When attempting to open a workspace in Bruno, the application shows a success toast notification even if the workspace selection is canceled. #### Changes Made - Updated `handleOpenWorkspace` to verify that a workspace was actually selected before showing the success toast. - Prevented false-pos...
a3e31994903d17afa2c09968c0d44bcb7ee01035
39308bc03cb158777cb16dd7339192e9cc777029
diff --git a/packages/bruno-app/src/components/AppTitleBar/index.js b/packages/bruno-app/src/components/AppTitleBar/index.js index 3551556dd3d..2e2dff47483 100644 --- a/packages/bruno-app/src/components/AppTitleBar/index.js +++ b/packages/bruno-app/src/components/AppTitleBar/index.js @@ -152,8 +152,10 @@ const AppTitle...
[ "packages/bruno-app/src/components/AppTitleBar/index.js" ]
[ { "comment": "Gating on `if (result)` is likely ineffective: in Redux (incl. thunks/RTK), `dispatch(...)` commonly resolves to an action object which is almost always truthy, even for rejected/canceled flows. If the intent is to only toast when a workspace was actually opened/selected, check a specific success ...
true
usebruno/bruno
8,096
comment_to_fix
fix: prevent success toast when workspace selection is cancelled
Gating on `if (result)` is likely ineffective: in Redux (incl. thunks/RTK), `dispatch(...)` commonly resolves to an action object which is almost always truthy, even for rejected/canceled flows. If the intent is to only toast when a workspace was actually opened/selected, check a specific success signal (e.g., `result....
a3e31994903d17afa2c09968c0d44bcb7ee01035
39308bc03cb158777cb16dd7339192e9cc777029
diff --git a/packages/bruno-app/src/components/AppTitleBar/index.js b/packages/bruno-app/src/components/AppTitleBar/index.js index 3551556dd3d..2e2dff47483 100644 --- a/packages/bruno-app/src/components/AppTitleBar/index.js +++ b/packages/bruno-app/src/components/AppTitleBar/index.js @@ -152,8 +152,10 @@ const AppTitle...
[ "packages/bruno-app/src/components/AppTitleBar/index.js" ]
[ { "comment": "Gating on `if (result)` is likely ineffective: in Redux (incl. thunks/RTK), `dispatch(...)` commonly resolves to an action object which is almost always truthy, even for rejected/canceled flows. If the intent is to only toast when a workspace was actually opened/selected, check a specific success ...
true
usebruno/bruno
8,146
issue_to_patch
Bugfix/workspace open success toast on cancel
JIRA Link - https://usebruno.atlassian.net/browse/BRU-3488 ### Description <!-- Explain here the changes your PR introduces and text to help us understand the context of this change. --> #### Contribution Checklist: - [ ] **I've used AI significantly to create this pull request** - [x] **The pull request o...
244f528277933118ab7f27cecb95d659d1ee4866
472241b51c06f2c2757b2eddd1c60e766e74e2cc
diff --git a/packages/bruno-app/src/components/AppTitleBar/index.js b/packages/bruno-app/src/components/AppTitleBar/index.js index 3551556dd3d..2e2dff47483 100644 --- a/packages/bruno-app/src/components/AppTitleBar/index.js +++ b/packages/bruno-app/src/components/AppTitleBar/index.js @@ -152,8 +152,10 @@ const AppTitle...
[ "packages/bruno-app/src/components/AppTitleBar/index.js", "packages/bruno-app/src/providers/ReduxStore/slices/workspaces/actions.js", "tests/workspace/open-workspace/open-workspace.spec.ts" ]
[]
diff --git a/tests/workspace/open-workspace/open-workspace.spec.ts b/tests/workspace/open-workspace/open-workspace.spec.ts new file mode 100644 index 00000000000..8984c9e3d8d --- /dev/null +++ b/tests/workspace/open-workspace/open-workspace.spec.ts @@ -0,0 +1,38 @@ +import type { ElectronApplication } from '@playwright...
true
usebruno/bruno
8,098
issue_to_patch
feat(import): enhance import functionality with issue tracking and logging
[JIRA](https://usebruno.atlassian.net/browse/BRU-2900) https://github.com/user-attachments/assets/c90f15a5-572b-4ecf-ad8a-4a8ffd392eca ### Description - Updated the import process to return both collections and issues for better error handling. - Introduced a new toast notification for displaying import i...
4ee9a7546510f4e7cc4a040b12b01ed5da265908
98e038a275a5932423d7c979eefb3b17db99661d
diff --git a/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js b/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js index e9829272f91..f541bd52806 100644 --- a/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js +++ b/packages/bruno-...
[ "packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js", "packages/bruno-app/src/components/Sidebar/ImportCollectionLocation/index.js", "packages/bruno-app/src/components/Toast/ImportIssuesToast/StyledWrapper.js", "packages/bruno-app/src/components/Toast/ImportIssuesToast/index.js", ...
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Clear `importIssues` when incoming bulk data has no issues.**\n\nCurrent effect only updates state when `issuesMap` is non-empty, so old issues can persist and be shown for later imports incorrectly.\n \n<details>\n<summary>Suggested fix</summ...
diff --git a/packages/bruno-converters/tests/fixtures/postman-with-import-issues.json b/packages/bruno-converters/tests/fixtures/postman-with-import-issues.json new file mode 100644 index 00000000000..d221613a7ac --- /dev/null +++ b/packages/bruno-converters/tests/fixtures/postman-with-import-issues.json @@ -0,0 +1,210...
true
usebruno/bruno
8,098
comment_to_fix
feat(import): enhance import functionality with issue tracking and logging
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Clear `importIssues` when incoming bulk data has no issues.** Current effect only updates state when `issuesMap` is non-empty, so old issues can persist and be shown for later imports incorrectly. <details> <summary>Suggested fix</summary> ```diff useEffect(()...
4ee9a7546510f4e7cc4a040b12b01ed5da265908
98e038a275a5932423d7c979eefb3b17db99661d
diff --git a/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js b/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js index e9829272f91..f541bd52806 100644 --- a/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js +++ b/packages/bruno-...
[ "packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Clear `importIssues` when incoming bulk data has no issues.**\n\nCurrent effect only updates state when `issuesMap` is non-empty, so old issues can persist and be shown for later imports incorrectly.\n \n<details>\n<summary>Suggested fix</summ...
true
usebruno/bruno
8,098
comment_to_fix
feat(import): enhance import functionality with issue tracking and logging
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Do not include raw `sourceItem` objects in logs without explicit consent.** Line 333 logs potentially sensitive request payloads (tokens/keys/internal URLs). Keep logs to path/message, or redact before dispatching. <details> <summary>🤖 Prompt for AI Agents</summar...
4ee9a7546510f4e7cc4a040b12b01ed5da265908
98e038a275a5932423d7c979eefb3b17db99661d
diff --git a/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js b/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js index e9829272f91..f541bd52806 100644 --- a/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js +++ b/packages/bruno-...
[ "packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Do not include raw `sourceItem` objects in logs without explicit consent.**\n\nLine 333 logs potentially sensitive request payloads (tokens/keys/internal URLs). Keep logs to path/message, or redact before dispatching.\n\n<details>\n<summary>🤖...
true
usebruno/bruno
8,098
comment_to_fix
feat(import): enhance import functionality with issue tracking and logging
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Wrap clipboard copy in `try/catch` and await completion.** This path currently always shows “Copied to clipboard” even when write fails. <details> <summary>🤖 Prompt for AI Agents</summary> ``` Verify each finding against current code. Fix only still-valid issues,...
4ee9a7546510f4e7cc4a040b12b01ed5da265908
98e038a275a5932423d7c979eefb3b17db99661d
diff --git a/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js b/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js index e9829272f91..f541bd52806 100644 --- a/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js +++ b/packages/bruno-...
[ "packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Wrap clipboard copy in `try/catch` and await completion.**\n\nThis path currently always shows “Copied to clipboard” even when write fails.\n\n<details>\n<summary>🤖 Prompt for AI Agents</summary>\n\n```\nVerify each finding against current co...
true
usebruno/bruno
8,098
comment_to_fix
feat(import): enhance import functionality with issue tracking and logging
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Avoid logging raw `sourceItem` payloads by default.** Line 190 pushes unredacted request data into internal logs, which can include secrets/PII. Log metadata only (or redact/mask sensitive fields) unless the user explicitly opts in. <details> <summary>Suggested fi...
4ee9a7546510f4e7cc4a040b12b01ed5da265908
98e038a275a5932423d7c979eefb3b17db99661d
diff --git a/packages/bruno-app/src/components/Sidebar/ImportCollectionLocation/index.js b/packages/bruno-app/src/components/Sidebar/ImportCollectionLocation/index.js index 0840880cd8e..1739a6961ad 100644 --- a/packages/bruno-app/src/components/Sidebar/ImportCollectionLocation/index.js +++ b/packages/bruno-app/src/comp...
[ "packages/bruno-app/src/components/Sidebar/ImportCollectionLocation/index.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Avoid logging raw `sourceItem` payloads by default.**\n\nLine 190 pushes unredacted request data into internal logs, which can include secrets/PII. Log metadata only (or redact/mask sensitive fields) unless the user explicitly opts in.\n \n<de...
true
usebruno/bruno
8,098
comment_to_fix
feat(import): enhance import functionality with issue tracking and logging
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Handle clipboard failures before showing success toast.** Line 36 is async and can fail (permissions/availability), but Line 37 always reports success. This can mislead users after copy failure. <details> <summary>Suggested fix</summary> ```diff - const handleCo...
4ee9a7546510f4e7cc4a040b12b01ed5da265908
98e038a275a5932423d7c979eefb3b17db99661d
diff --git a/packages/bruno-app/src/components/Toast/ImportIssuesToast/index.js b/packages/bruno-app/src/components/Toast/ImportIssuesToast/index.js new file mode 100644 index 00000000000..b84e281599f --- /dev/null +++ b/packages/bruno-app/src/components/Toast/ImportIssuesToast/index.js @@ -0,0 +1,176 @@ +import React,...
[ "packages/bruno-app/src/components/Toast/ImportIssuesToast/index.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Handle clipboard failures before showing success toast.**\n\nLine 36 is async and can fail (permissions/availability), but Line 37 always reports success. This can mislead users after copy failure.\n \n<details>\n<summary>Suggested fix</summar...
true
usebruno/bruno
8,098
comment_to_fix
feat(import): enhance import functionality with issue tracking and logging
_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_ **Add `data-testid` attributes to new testable controls.** The new checkbox and action buttons are user-interactive and should expose stable selectors for Playwright tests. As per coding guidelines, "Add `data-testid` to testable elements for Playwright in Reac...
4ee9a7546510f4e7cc4a040b12b01ed5da265908
98e038a275a5932423d7c979eefb3b17db99661d
diff --git a/packages/bruno-app/src/components/Toast/ImportIssuesToast/index.js b/packages/bruno-app/src/components/Toast/ImportIssuesToast/index.js new file mode 100644 index 00000000000..b84e281599f --- /dev/null +++ b/packages/bruno-app/src/components/Toast/ImportIssuesToast/index.js @@ -0,0 +1,176 @@ +import React,...
[ "packages/bruno-app/src/components/Toast/ImportIssuesToast/index.js" ]
[ { "comment": "_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add `data-testid` attributes to new testable controls.**\n\nThe new checkbox and action buttons are user-interactive and should expose stable selectors for Playwright tests.\n \nAs per coding guidelines, \"Add `data-testid` to testable el...
true
usebruno/bruno
8,098
comment_to_fix
feat(import): enhance import functionality with issue tracking and logging
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Guard malformed items before folder/request branching.** If `collection.item` contains `null`/primitive entries, Line 375 can throw before an issue is recorded, which aborts partial import. <details> <summary>💡 Proposed fix</summary> ```diff item.forEach((i, i...
4ee9a7546510f4e7cc4a040b12b01ed5da265908
98e038a275a5932423d7c979eefb3b17db99661d
diff --git a/packages/bruno-converters/src/postman/postman-to-bruno.js b/packages/bruno-converters/src/postman/postman-to-bruno.js index 5c6b3f7edb6..5f27cb59844 100644 --- a/packages/bruno-converters/src/postman/postman-to-bruno.js +++ b/packages/bruno-converters/src/postman/postman-to-bruno.js @@ -363,12 +363,20 @@ e...
[ "packages/bruno-converters/src/postman/postman-to-bruno.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Guard malformed items before folder/request branching.**\n\nIf `collection.item` contains `null`/primitive entries, Line 375 can throw before an issue is recorded, which aborts partial import.\n\n<details>\n<summary>💡 Proposed fix</summary>\n...
true
usebruno/bruno
8,098
comment_to_fix
feat(import): enhance import functionality with issue tracking and logging
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Verify current method-normalization order around the changed block sed -n '434,442p' packages/bruno-converters/src/postman/postman-to-bruno.js ``` Repository: usebruno/bruno L...
4ee9a7546510f4e7cc4a040b12b01ed5da265908
98e038a275a5932423d7c979eefb3b17db99661d
diff --git a/packages/bruno-converters/src/postman/postman-to-bruno.js b/packages/bruno-converters/src/postman/postman-to-bruno.js index 5c6b3f7edb6..5f27cb59844 100644 --- a/packages/bruno-converters/src/postman/postman-to-bruno.js +++ b/packages/bruno-converters/src/postman/postman-to-bruno.js @@ -363,12 +363,20 @@ e...
[ "packages/bruno-converters/src/postman/postman-to-bruno.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify current method-normalization order around the changed block\nsed -n '434,442p' packages/bruno-converters/src/postman/postman-to-bruno.js\n`...
true
usebruno/bruno
8,098
comment_to_fix
feat(import): enhance import functionality with issue tracking and logging
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ **Use severity-aware log level for the per-collection summary.** The summary header is always logged as `error`, even when a collection has only warnings. This misclassifies import outcomes in logs. <details> <summary>Suggested fix</summary> ```diff - ...
4ee9a7546510f4e7cc4a040b12b01ed5da265908
98e038a275a5932423d7c979eefb3b17db99661d
diff --git a/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js b/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js index e9829272f91..f541bd52806 100644 --- a/packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js +++ b/packages/bruno-...
[ "packages/bruno-app/src/components/Sidebar/BulkImportCollectionLocation/index.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Use severity-aware log level for the per-collection summary.**\n\nThe summary header is always logged as `error`, even when a collection has only warnings. This misclassifies import outcomes in logs.\n\n \n\n<details>\n<summary>Suggested fix</...
true
usebruno/bruno
8,121
issue_to_patch
feat: import modal revamp
### Description [Jira](https://usebruno.atlassian.net/browse/BRU-2493) Add new import collection modals for bulk and git repo imports. <img width="1575" height="1035" alt="Screenshot 2026-05-27 at 11 52 12 PM" src="https://github.com/user-attachments/assets/f3294f43-02c9-4b3a-b464-685f8d4e763f" /> <img width=...
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/packages/bruno-app/src/components/Modal/index.js b/packages/bruno-app/src/components/Modal/index.js index 75662d2bc98..9ddab746bf1 100644 --- a/packages/bruno-app/src/components/Modal/index.js +++ b/packages/bruno-app/src/components/Modal/index.js @@ -28,6 +28,7 @@ const ModalFooter = ({ confirmDisabled...
[ "packages/bruno-app/src/components/Modal/index.js", "packages/bruno-app/src/components/SelectionFooter/index.js", "packages/bruno-app/src/components/SelectionList/StyledWrapper.js", "packages/bruno-app/src/components/SelectionList/constants.js", "packages/bruno-app/src/components/SelectionList/index.js", ...
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Add a stable test id for the new Back button.**\n\nThe new interactive Back control should expose a `data-testid` for reliable Playwright targeting.\n\n<details>\n<summary>Suggested patch</summary>\n\n```diff\n <button\n ...
diff --git a/tests/import/bulk-import/001-multiple-files-upload.spec.ts b/tests/import/bulk-import/001-multiple-files-upload.spec.ts index 8b2bbf4d0b8..e60088797d2 100644 --- a/tests/import/bulk-import/001-multiple-files-upload.spec.ts +++ b/tests/import/bulk-import/001-multiple-files-upload.spec.ts @@ -32,7 +32,9 @@ t...
true
usebruno/bruno
8,121
comment_to_fix
feat: import modal revamp
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ **Add a stable test id for the new Back button.** The new interactive Back control should expose a `data-testid` for reliable Playwright targeting. <details> <summary>Suggested patch</summary> ```diff <button type="button" ...
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/packages/bruno-app/src/components/Modal/index.js b/packages/bruno-app/src/components/Modal/index.js index 75662d2bc98..9ddab746bf1 100644 --- a/packages/bruno-app/src/components/Modal/index.js +++ b/packages/bruno-app/src/components/Modal/index.js @@ -28,6 +28,7 @@ const ModalFooter = ({ confirmDisabled...
[ "packages/bruno-app/src/components/Modal/index.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Add a stable test id for the new Back button.**\n\nThe new interactive Back control should expose a `data-testid` for reliable Playwright targeting.\n\n<details>\n<summary>Suggested patch</summary>\n\n```diff\n <button\n ...
true
usebruno/bruno
8,121
comment_to_fix
feat: import modal revamp
_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_ **Add stable `data-testid` hooks for new SelectionList UI nodes.** New test-critical elements are exposed only via CSS class selectors. Please add explicit `data-testid` attributes to the heading/count/search/select-all/list rows so Playwright selectors stay stab...
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/packages/bruno-app/src/components/SelectionList/index.js b/packages/bruno-app/src/components/SelectionList/index.js index 2913e480301..0366584fc7d 100644 --- a/packages/bruno-app/src/components/SelectionList/index.js +++ b/packages/bruno-app/src/components/SelectionList/index.js @@ -1,5 +1,13 @@ -import Re...
[ "packages/bruno-app/src/components/SelectionList/index.js" ]
[ { "comment": "_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add stable `data-testid` hooks for new SelectionList UI nodes.**\n\nNew test-critical elements are exposed only via CSS class selectors. Please add explicit `data-testid` attributes to the heading/count/search/select-all/list rows so Play...
true
usebruno/bruno
8,121
comment_to_fix
feat: import modal revamp
_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_ **Use theme-driven colors instead of Tailwind color classes in this styled-components flow.** Move `text-red-500` / `text-yellow-500` icon colors to `StyledWrapper` theme tokens. As per coding guidelines, "Use styled component's theme prop to manage CSS colors...
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/packages/bruno-app/src/components/Sidebar/CloneGitRespository/index.js b/packages/bruno-app/src/components/Sidebar/CloneGitRespository/index.js index 151bc02d971..b48a5e06af4 100644 --- a/packages/bruno-app/src/components/Sidebar/CloneGitRespository/index.js +++ b/packages/bruno-app/src/components/Sidebar/...
[ "packages/bruno-app/src/components/Sidebar/CloneGitRespository/index.js" ]
[ { "comment": "_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_\n\n**Use theme-driven colors instead of Tailwind color classes in this styled-components flow.**\n\nMove `text-red-500` / `text-yellow-500` icon colors to `StyledWrapper` theme tokens.\n\n\n\nAs per coding guidelines, \"Use styled component's ...
true
usebruno/bruno
8,121
comment_to_fix
feat: import modal revamp
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Use semantic buttons for clickable controls (tabs and dismiss action).** Using clickable `<div>` elements here breaks keyboard accessibility. Replace with `<button type='button'>` (or full tab semantics) so these actions are reachable and operable via keyboard. <de...
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/packages/bruno-app/src/components/Sidebar/ImportCollection/index.js b/packages/bruno-app/src/components/Sidebar/ImportCollection/index.js index 6c39274d702..96120be21e9 100644 --- a/packages/bruno-app/src/components/Sidebar/ImportCollection/index.js +++ b/packages/bruno-app/src/components/Sidebar/ImportCol...
[ "packages/bruno-app/src/components/Sidebar/ImportCollection/index.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Use semantic buttons for clickable controls (tabs and dismiss action).**\n\nUsing clickable `<div>` elements here breaks keyboard accessibility. Replace with `<button type='button'>` (or full tab semantics) so these actions are reachable and o...
true
usebruno/bruno
8,121
comment_to_fix
feat: import modal revamp
_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_ **Add stable test hooks (and wire disclosure semantics) on the details toggle.** Please add `data-testid` for the toggle button and details list, and include `aria-expanded`/`aria-controls` so the expanded state is explicit. <details> <summary>Proposed patch</...
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/packages/bruno-app/src/components/SkippedPathsWarning/index.js b/packages/bruno-app/src/components/SkippedPathsWarning/index.js new file mode 100644 index 00000000000..77b3a6a99a5 --- /dev/null +++ b/packages/bruno-app/src/components/SkippedPathsWarning/index.js @@ -0,0 +1,40 @@ +import React, { useState }...
[ "packages/bruno-app/src/components/SkippedPathsWarning/index.js" ]
[ { "comment": "_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add stable test hooks (and wire disclosure semantics) on the details toggle.**\n\nPlease add `data-testid` for the toggle button and details list, and include `aria-expanded`/`aria-controls` so the expanded state is explicit.\n\n \n<detai...
true
usebruno/bruno
8,121
comment_to_fix
feat: import modal revamp
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail echo "Inspect SelectionList instances in bulk import screen" rg -n -C3 "SelectionList|title=\"Collections\"|title=\"Environments\"" packages/bruno-app/src/compo...
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/tests/import/bulk-import/004-select-all.spec.ts b/tests/import/bulk-import/004-select-all.spec.ts new file mode 100644 index 00000000000..7b0c2b78921 --- /dev/null +++ b/tests/import/bulk-import/004-select-all.spec.ts @@ -0,0 +1,137 @@ +import { test, expect } from '../../../playwright'; +import * as path ...
[ "tests/import/bulk-import/004-select-all.spec.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\necho \"Inspect SelectionList instances in bulk import screen\"\nrg -n -C3 \"SelectionList|title=\\\"Collections\\\"|title=\\\"E...
true
usebruno/bruno
8,121
comment_to_fix
feat: import modal revamp
this margin still renders even when there’s no content. can you remove it?
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/packages/bruno-app/src/components/Modal/index.js b/packages/bruno-app/src/components/Modal/index.js index 75662d2bc98..9ddab746bf1 100644 --- a/packages/bruno-app/src/components/Modal/index.js +++ b/packages/bruno-app/src/components/Modal/index.js @@ -28,6 +28,7 @@ const ModalFooter = ({ confirmDisabled...
[ "packages/bruno-app/src/components/Modal/index.js" ]
[ { "comment": "this margin still renders even when there’s no content. can you remove it?", "path": "packages/bruno-app/src/components/Modal/index.js", "hunk": "@@ -39,24 +42,42 @@ const ModalFooter = ({\n }\n \n return (\n- <div className=\"flex justify-end p-4 bruno-modal-footer\">\n- <span...
true
usebruno/bruno
8,121
comment_to_fix
feat: import modal revamp
use `ui/Button`
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/packages/bruno-app/src/components/Modal/index.js b/packages/bruno-app/src/components/Modal/index.js index 75662d2bc98..9ddab746bf1 100644 --- a/packages/bruno-app/src/components/Modal/index.js +++ b/packages/bruno-app/src/components/Modal/index.js @@ -28,6 +28,7 @@ const ModalFooter = ({ confirmDisabled...
[ "packages/bruno-app/src/components/Modal/index.js" ]
[ { "comment": "use `ui/Button`", "path": "packages/bruno-app/src/components/Modal/index.js", "hunk": "@@ -39,24 +42,42 @@ const ModalFooter = ({\n }\n \n return (\n- <div className=\"flex justify-end p-4 bruno-modal-footer\">\n- <span className={hideCancel ? 'hidden' : 'mr-2'}>\n- <But...
true
usebruno/bruno
8,121
comment_to_fix
feat: import modal revamp
remove optional chaining
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/packages/bruno-app/src/components/SelectionList/index.js b/packages/bruno-app/src/components/SelectionList/index.js index 2913e480301..0366584fc7d 100644 --- a/packages/bruno-app/src/components/SelectionList/index.js +++ b/packages/bruno-app/src/components/SelectionList/index.js @@ -1,5 +1,13 @@ -import Re...
[ "packages/bruno-app/src/components/SelectionList/index.js" ]
[ { "comment": "remove optional chaining", "path": "packages/bruno-app/src/components/SelectionList/index.js", "hunk": "@@ -8,65 +16,137 @@ const SelectionList = ({\n onSelectAll,\n onItemToggle,\n getItemId,\n- renderItemLabel,\n+ renderItemTitle,\n+ renderItemDescription,\n+ searchPlaceholder,...
true
usebruno/bruno
8,121
comment_to_fix
feat: import modal revamp
use stable section testid instead of parent walks
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/tests/import/bulk-import/004-select-all.spec.ts b/tests/import/bulk-import/004-select-all.spec.ts new file mode 100644 index 00000000000..7b0c2b78921 --- /dev/null +++ b/tests/import/bulk-import/004-select-all.spec.ts @@ -0,0 +1,137 @@ +import { test, expect } from '../../../playwright'; +import * as path ...
[ "tests/import/bulk-import/004-select-all.spec.ts" ]
[ { "comment": "use stable section testid instead of parent walks", "path": "tests/import/bulk-import/004-select-all.spec.ts", "hunk": "@@ -0,0 +1,138 @@\n+import { test, expect } from '../../../playwright';\n+import * as path from 'path';\n+import * as fs from 'fs/promises';\n+import { closeAllCollection...
true
usebruno/bruno
8,121
comment_to_fix
feat: import modal revamp
this file is inconsistent with the rest of the codebase
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/packages/bruno-app/src/components/SkippedPathsWarning/StyledWrapper.js b/packages/bruno-app/src/components/SkippedPathsWarning/StyledWrapper.js new file mode 100644 index 00000000000..ed3386f1903 --- /dev/null +++ b/packages/bruno-app/src/components/SkippedPathsWarning/StyledWrapper.js @@ -0,0 +1,62 @@ +im...
[ "packages/bruno-app/src/components/SkippedPathsWarning/StyledWrapper.js" ]
[ { "comment": "this file is inconsistent with the rest of the codebase", "path": "packages/bruno-app/src/components/SkippedPathsWarning/StyledWrapper.js", "hunk": "@@ -0,0 +1,3 @@\n+import StyledWrapper from './StyledWrapper';\n+", "resolving_sha": "7daa02ac884b9d15857b83c933ceb1f738555d46", "res...
true
usebruno/bruno
8,121
comment_to_fix
feat: import modal revamp
drop the new `showBackButton / handleBack` Modal props and render the Back button via the `footerLeft` slot instead
413697cbe751fb4a01876f1ce4c6ffd7b176317a
7daa02ac884b9d15857b83c933ceb1f738555d46
diff --git a/packages/bruno-app/src/components/Modal/index.js b/packages/bruno-app/src/components/Modal/index.js index 75662d2bc98..9ddab746bf1 100644 --- a/packages/bruno-app/src/components/Modal/index.js +++ b/packages/bruno-app/src/components/Modal/index.js @@ -28,6 +28,7 @@ const ModalFooter = ({ confirmDisabled...
[ "packages/bruno-app/src/components/Modal/index.js" ]
[ { "comment": "drop the new `showBackButton / handleBack` Modal props and render the Back button via the `footerLeft` slot instead", "path": "packages/bruno-app/src/components/Modal/index.js", "hunk": "@@ -25,9 +25,12 @@ const ModalFooter = ({\n cancelText,\n handleSubmit,\n handleCancel,\n+ handl...
true
usebruno/bruno
8,123
issue_to_patch
fix(import): preserve special chars in OpenAPI tag/folder names for yml collections
### Description When importing an OpenAPI spec into an opencollection (yml) collection, the importer rewrites every non-alphanumeric character in tag names to `_` and collapses/trims the result. Because tag names also drive folder names, users lose their authored tag values: | OpenAPI tag | Current | Expected | ...
413697cbe751fb4a01876f1ce4c6ffd7b176317a
cccb5b2bf540595c8bf19b86e64da9b4ddf94b8d
diff --git a/packages/bruno-converters/src/common/index.js b/packages/bruno-converters/src/common/index.js index 765533f10d9..dc07349350b 100644 --- a/packages/bruno-converters/src/common/index.js +++ b/packages/bruno-converters/src/common/index.js @@ -60,11 +60,18 @@ export const sanitizeTag = (tag, options = {}) => {...
[ "packages/bruno-converters/src/common/index.js", "packages/bruno-converters/src/openapi/openapi-common.js", "packages/bruno-converters/tests/common/sanitizeTag.spec.js", "packages/bruno-converters/tests/openapi/openapi-to-bruno/openapi-tags.spec.js", "packages/bruno-schema/src/collections/index.js", "pack...
[]
diff --git a/packages/bruno-converters/tests/common/sanitizeTag.spec.js b/packages/bruno-converters/tests/common/sanitizeTag.spec.js index b6d64dcf96b..89014b64b53 100644 --- a/packages/bruno-converters/tests/common/sanitizeTag.spec.js +++ b/packages/bruno-converters/tests/common/sanitizeTag.spec.js @@ -125,14 +125,50 ...
true
usebruno/bruno
7,766
issue_to_patch
fix: honor OS-level PAC configuration in system proxy mode
### Description Bruno supports PAC proxy resolution when explicitly configured in preferences, but in System proxy mode, OS-level PAC configuration is silently ignored. [JIRA](http://usebruno.atlassian.net/browse/BRU-3055) #### Contribution Checklist: - [x] **I've used AI significantly to create this pull ...
10da27dde8a03afc7cd2c7d95ae4ba8f5798a9ca
bdb6982fc3bd911231e31b4fa58849b91ef2040e
diff --git a/.github/workflows/tests-linux.yml b/.github/workflows/tests-linux.yml index b7a0ff3e411..de4c0b02e13 100644 --- a/.github/workflows/tests-linux.yml +++ b/.github/workflows/tests-linux.yml @@ -59,7 +59,8 @@ jobs: sudo apt-get update sudo apt-get --no-install-recommends install -y \ ...
[ ".github/actions/tests/run-e2e-tests/action.yml", ".github/workflows/tests-linux.yml", "package.json", "packages/bruno-app/src/components/Preferences/ProxySettings/SystemProxy/index.js", "packages/bruno-cli/src/runner/run-single-request.js", "packages/bruno-cli/src/utils/axios-instance.js", "packages/br...
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Add one positive PAC-enabled test case.**\n\nCurrent updates assert `pac_url: null`, but the new PAC extraction path is not directly asserted with a non-null URL scenario.\n\n<details>\n<summary>Proposed test addition</summary>\n\n```diff\n describe('scutil p...
diff --git a/.github/actions/tests/run-e2e-tests/action.yml b/.github/actions/tests/run-e2e-tests/action.yml index fd9c9e10918..c3650975250 100644 --- a/.github/actions/tests/run-e2e-tests/action.yml +++ b/.github/actions/tests/run-e2e-tests/action.yml @@ -18,7 +18,7 @@ runs: - name: Run Playwright Tests (Ubuntu) ...
true
usebruno/bruno
7,766
comment_to_fix
fix: honor OS-level PAC configuration in system proxy mode
_⚠️ Potential issue_ | _🟡 Minor_ **Add one positive PAC-enabled test case.** Current updates assert `pac_url: null`, but the new PAC extraction path is not directly asserted with a non-null URL scenario. <details> <summary>Proposed test addition</summary> ```diff describe('scutil proxy detection', () => { + it('...
10da27dde8a03afc7cd2c7d95ae4ba8f5798a9ca
bdb6982fc3bd911231e31b4fa58849b91ef2040e
diff --git a/packages/bruno-requests/src/network/system-proxy/utils/macos.spec.ts b/packages/bruno-requests/src/network/system-proxy/utils/macos.spec.ts index 89b31839d44..24758dbf0e9 100644 --- a/packages/bruno-requests/src/network/system-proxy/utils/macos.spec.ts +++ b/packages/bruno-requests/src/network/system-proxy...
[ "packages/bruno-requests/src/network/system-proxy/utils/macos.spec.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Add one positive PAC-enabled test case.**\n\nCurrent updates assert `pac_url: null`, but the new PAC extraction path is not directly asserted with a non-null URL scenario.\n\n<details>\n<summary>Proposed test addition</summary>\n\n```diff\n describe('scutil p...
true
usebruno/bruno
7,766
comment_to_fix
fix: honor OS-level PAC configuration in system proxy mode
_⚠️ Potential issue_ | _🟡 Minor_ **Hardcoded network service and missing platform guard.** 1. `NETWORK_SERVICE = 'Wi-Fi'` won't work on macOS machines using Ethernet, Thunderbolt Bridge, or other network interfaces. 2. This test uses `networksetup` which is macOS-only, but there's no `test.skip` for non-Darwin platf...
10da27dde8a03afc7cd2c7d95ae4ba8f5798a9ca
bdb6982fc3bd911231e31b4fa58849b91ef2040e
diff --git a/tests/proxy/system-pac/system-pac-proxy.spec.ts b/tests/proxy/system-pac/system-pac-proxy.spec.ts new file mode 100644 index 00000000000..4548f9cb862 --- /dev/null +++ b/tests/proxy/system-pac/system-pac-proxy.spec.ts @@ -0,0 +1,103 @@ +import * as path from 'path'; +import { execFileSync } from 'child_pro...
[ "tests/proxy/system-pac/system-pac-proxy.spec.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Hardcoded network service and missing platform guard.**\n\n1. `NETWORK_SERVICE = 'Wi-Fi'` won't work on macOS machines using Ethernet, Thunderbolt Bridge, or other network interfaces.\n2. This test uses `networksetup` which is macOS-only, but there's no `test...
true
usebruno/bruno
7,766
comment_to_fix
fix: honor OS-level PAC configuration in system proxy mode
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Ensure server teardown always runs even if PAC reset fails.** If `disableSystemPac()` throws in `afterAll`, `stopServers(servers)` is skipped. Wrap cleanup in `try/finally` so test infrastructure is always torn down. <details> <summary>Suggested patch</summary> ...
10da27dde8a03afc7cd2c7d95ae4ba8f5798a9ca
bdb6982fc3bd911231e31b4fa58849b91ef2040e
diff --git a/tests/proxy/system-pac/system-pac-proxy.spec.ts b/tests/proxy/system-pac/system-pac-proxy.spec.ts new file mode 100644 index 00000000000..4548f9cb862 --- /dev/null +++ b/tests/proxy/system-pac/system-pac-proxy.spec.ts @@ -0,0 +1,103 @@ +import * as path from 'path'; +import { execFileSync } from 'child_pro...
[ "tests/proxy/system-pac/system-pac-proxy.spec.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Ensure server teardown always runs even if PAC reset fails.**\n\nIf `disableSystemPac()` throws in `afterAll`, `stopServers(servers)` is skipped. Wrap cleanup in `try/finally` so test infrastructure is always torn down.\n\n\n\n\n<details>\n<su...
true
usebruno/bruno
7,766
comment_to_fix
fix: honor OS-level PAC configuration in system proxy mode
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Teardown should restore prior PAC config, not always force `off`** `disableSystemPac()` always turns PAC off in `afterAll`. If PAC was enabled before this suite, the test permanently changes host proxy config after run. Capture original PAC state/URL before mutation...
10da27dde8a03afc7cd2c7d95ae4ba8f5798a9ca
bdb6982fc3bd911231e31b4fa58849b91ef2040e
diff --git a/tests/proxy/system-pac/system-pac-proxy.spec.ts b/tests/proxy/system-pac/system-pac-proxy.spec.ts new file mode 100644 index 00000000000..4548f9cb862 --- /dev/null +++ b/tests/proxy/system-pac/system-pac-proxy.spec.ts @@ -0,0 +1,103 @@ +import * as path from 'path'; +import { execFileSync } from 'child_pro...
[ "tests/proxy/system-pac/system-pac-proxy.spec.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Teardown should restore prior PAC config, not always force `off`**\n\n`disableSystemPac()` always turns PAC off in `afterAll`. If PAC was enabled before this suite, the test permanently changes host proxy config after run. Capture original PAC...
true
usebruno/bruno
7,766
comment_to_fix
fix: honor OS-level PAC configuration in system proxy mode
Tests for windows and linux? also , did we manually test this on windows and linux ?
10da27dde8a03afc7cd2c7d95ae4ba8f5798a9ca
bdb6982fc3bd911231e31b4fa58849b91ef2040e
diff --git a/tests/proxy/system-pac/system-pac-proxy.spec.ts b/tests/proxy/system-pac/system-pac-proxy.spec.ts new file mode 100644 index 00000000000..4548f9cb862 --- /dev/null +++ b/tests/proxy/system-pac/system-pac-proxy.spec.ts @@ -0,0 +1,103 @@ +import * as path from 'path'; +import { execFileSync } from 'child_pro...
[ "tests/proxy/system-pac/system-pac-proxy.spec.ts" ]
[ { "comment": "Tests for windows and linux?\n\nalso , did we manually test this on windows and linux ?", "path": "tests/proxy/system-pac/system-pac-proxy.spec.ts", "hunk": "", "resolving_sha": "bdb6982fc3bd911231e31b4fa58849b91ef2040e", "resolving_diff": "diff --git a/tests/proxy/system-pac/syste...
true
usebruno/bruno
7,766
comment_to_fix
fix: honor OS-level PAC configuration in system proxy mode
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell find . -name "proxy-util.js" -type f ``` Repository: usebruno/bruno Length of output: 153 --- 🏁 Script executed: ```shell wc -l packages/bruno-electron/src/utils/proxy-util.js ``` Repo...
10da27dde8a03afc7cd2c7d95ae4ba8f5798a9ca
bdb6982fc3bd911231e31b4fa58849b91ef2040e
diff --git a/packages/bruno-electron/src/utils/proxy-util.js b/packages/bruno-electron/src/utils/proxy-util.js index 8398ba3119e..9c2eb787382 100644 --- a/packages/bruno-electron/src/utils/proxy-util.js +++ b/packages/bruno-electron/src/utils/proxy-util.js @@ -1,14 +1,17 @@ const parseUrl = require('url').parse; cons...
[ "packages/bruno-electron/src/utils/proxy-util.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\nfind . -name \"proxy-util.js\" -type f\n```\n\nRepository: usebruno/bruno\n\nLength of output: 153\n\n---\n\n🏁 Script executed:\n\n```shell\nwc -l packages/brun...
true
usebruno/bruno
7,766
comment_to_fix
fix: honor OS-level PAC configuration in system proxy mode
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell cat -n tests/proxy/system-pac/system-pac-proxy.spec.ts | head -30 ``` Repository: usebruno/bruno Length of output: 1263 --- 🏁 Script executed: ```shell rg "execSync|execFileSync|child_p...
10da27dde8a03afc7cd2c7d95ae4ba8f5798a9ca
bdb6982fc3bd911231e31b4fa58849b91ef2040e
diff --git a/tests/proxy/system-pac/system-pac-proxy.spec.ts b/tests/proxy/system-pac/system-pac-proxy.spec.ts new file mode 100644 index 00000000000..4548f9cb862 --- /dev/null +++ b/tests/proxy/system-pac/system-pac-proxy.spec.ts @@ -0,0 +1,103 @@ +import * as path from 'path'; +import { execFileSync } from 'child_pro...
[ "tests/proxy/system-pac/system-pac-proxy.spec.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\ncat -n tests/proxy/system-pac/system-pac-proxy.spec.ts | head -30\n```\n\nRepository: usebruno/bruno\n\nLength of output: 1263\n\n---\n\n🏁 Script executed:\n\n`...
true
usebruno/bruno
7,766
comment_to_fix
fix: honor OS-level PAC configuration in system proxy mode
needed for making system requests for dbus requests
10da27dde8a03afc7cd2c7d95ae4ba8f5798a9ca
bdb6982fc3bd911231e31b4fa58849b91ef2040e
diff --git a/.github/actions/tests/run-e2e-tests/action.yml b/.github/actions/tests/run-e2e-tests/action.yml index fd9c9e10918..c3650975250 100644 --- a/.github/actions/tests/run-e2e-tests/action.yml +++ b/.github/actions/tests/run-e2e-tests/action.yml @@ -18,7 +18,7 @@ runs: - name: Run Playwright Tests (Ubuntu) ...
[ ".github/actions/tests/run-e2e-tests/action.yml" ]
[ { "comment": "needed for making system requests for dbus requests ", "path": ".github/actions/tests/run-e2e-tests/action.yml", "hunk": "@@ -14,7 +14,7 @@ runs:\n - name: Run Playwright Tests (Ubuntu)\n if: inputs.os == 'ubuntu'\n shell: bash\n- run: xvfb-run npm run test:e2e\n+ ...
true
usebruno/bruno
7,766
comment_to_fix
fix: honor OS-level PAC configuration in system proxy mode
added for linux system proxy test
10da27dde8a03afc7cd2c7d95ae4ba8f5798a9ca
bdb6982fc3bd911231e31b4fa58849b91ef2040e
diff --git a/.github/workflows/tests-linux.yml b/.github/workflows/tests-linux.yml index b7a0ff3e411..de4c0b02e13 100644 --- a/.github/workflows/tests-linux.yml +++ b/.github/workflows/tests-linux.yml @@ -59,7 +59,8 @@ jobs: sudo apt-get update sudo apt-get --no-install-recommends install -y \ ...
[ ".github/workflows/tests-linux.yml" ]
[ { "comment": "added for linux system proxy test", "path": ".github/workflows/tests-linux.yml", "hunk": "@@ -58,7 +58,8 @@ jobs:\n sudo apt-get update\n sudo apt-get --no-install-recommends install -y \\\n libglib2.0-0 libnss3 libdbus-1-3 libatk1.0-0 libatk-bridge2.0-0 lib...
true
usebruno/bruno
7,766
comment_to_fix
fix: honor OS-level PAC configuration in system proxy mode
```suggestion } catch (error) { console.warn(`Failed pac resolutions`) } ``` I don't know if we show verbose logs in cli or not but we should at least silent log this in for users to know what's going on, the GUI allows showing stuff but CLI doesn't, the log itself can go as a separate tic...
10da27dde8a03afc7cd2c7d95ae4ba8f5798a9ca
bdb6982fc3bd911231e31b4fa58849b91ef2040e
diff --git a/packages/bruno-cli/src/utils/proxy-util.js b/packages/bruno-cli/src/utils/proxy-util.js index 1066021996b..df14c46467f 100644 --- a/packages/bruno-cli/src/utils/proxy-util.js +++ b/packages/bruno-cli/src/utils/proxy-util.js @@ -2,10 +2,14 @@ const parseUrl = require('url').parse; const http = require('nod...
[ "packages/bruno-cli/src/utils/proxy-util.js" ]
[ { "comment": "```suggestion\n } catch (error) {\n console.warn(`Failed pac resolutions`)\n }\n```\n\nI don't know if we show verbose logs in cli or not but we should at least silent log this in for users to know what's going on, the GUI allows showing stuff but CLI doesn't, the log its...
true
usebruno/bruno
8,086
issue_to_patch
fix(app): null-safe OAuth2 scope in OpenAPI export (BRU-3297)
### Description The OpenAPI exporter (`packages/bruno-app/src/utils/exporters/openapi-spec.js`) calls `.length` on `auth.oauth2.scope` without a null guard. When a user never fills the Scope field for an OAuth2 auth, Bruno stores `scope` as `null`, causing the entire export to crash with: ``` TypeError: Cannot r...
9b0911926ca62b213c72b13886cff65560493d4e
4867f96d348d4c02c0b8dc91ab9ae66786761187
diff --git a/packages/bruno-app/src/utils/exporters/openapi-spec.js b/packages/bruno-app/src/utils/exporters/openapi-spec.js index 06331978313..d02641fa06c 100644 --- a/packages/bruno-app/src/utils/exporters/openapi-spec.js +++ b/packages/bruno-app/src/utils/exporters/openapi-spec.js @@ -358,9 +358,10 @@ export const e...
[ "packages/bruno-app/src/utils/exporters/openapi-spec.js", "packages/bruno-app/src/utils/exporters/openapi-spec.spec.js" ]
[]
diff --git a/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js b/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js index 92b7196d81f..d361ed37836 100644 --- a/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js +++ b/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js @@ -476,3 +476,...
true
usebruno/bruno
8,028
issue_to_patch
feat: add support for duplicate request url + type in OpenAPI spec
### Description [Jira](https://usebruno.atlassian.net/browse/BRU-2237) Currently the OpenAPI spec doesn't allow duplicate request url + type and it only keeps one. After this change it will create a new `x-bruno-variants` that will be used to keep the duplicates instead of discard it. https://github.com/u...
8cd7c26648673b7e4c6a8994a11d8cf5f08a31bf
8a4e085ba81f66599b8d9125b677ceecb84c6d21
diff --git a/packages/bruno-app/src/utils/exporters/openapi-spec.js b/packages/bruno-app/src/utils/exporters/openapi-spec.js index 06331978313..4e9802056f1 100644 --- a/packages/bruno-app/src/utils/exporters/openapi-spec.js +++ b/packages/bruno-app/src/utils/exporters/openapi-spec.js @@ -4,7 +4,8 @@ import { isValidUrl...
[ "packages/bruno-app/src/utils/exporters/openapi-spec.js", "packages/bruno-app/src/utils/exporters/openapi-spec.spec.js", "packages/bruno-converters/src/openapi/openapi-to-bruno.js", "packages/bruno-converters/tests/openapi/openapi-to-bruno/openapi-server-variables.spec.js" ]
[ { "comment": "Preserving two same-named requests now writes both to the same components.* slot — both operations end up with the same $ref (last writes).", "path": "packages/bruno-app/src/utils/exporters/openapi-spec.js", "hunk": "@@ -463,11 +463,23 @@ export const exportApiSpec = ({ variables, items, n...
diff --git a/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js b/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js index 92b7196d81f..8ac0f58ac0e 100644 --- a/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js +++ b/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js @@ -1,4 +1,10 @...
true
usebruno/bruno
8,028
comment_to_fix
feat: add support for duplicate request url + type in OpenAPI spec
Preserving two same-named requests now writes both to the same components.* slot — both operations end up with the same $ref (last writes).
8cd7c26648673b7e4c6a8994a11d8cf5f08a31bf
8a4e085ba81f66599b8d9125b677ceecb84c6d21
diff --git a/packages/bruno-app/src/utils/exporters/openapi-spec.js b/packages/bruno-app/src/utils/exporters/openapi-spec.js index 06331978313..4e9802056f1 100644 --- a/packages/bruno-app/src/utils/exporters/openapi-spec.js +++ b/packages/bruno-app/src/utils/exporters/openapi-spec.js @@ -4,7 +4,8 @@ import { isValidUrl...
[ "packages/bruno-app/src/utils/exporters/openapi-spec.js" ]
[ { "comment": "Preserving two same-named requests now writes both to the same components.* slot — both operations end up with the same $ref (last writes).", "path": "packages/bruno-app/src/utils/exporters/openapi-spec.js", "hunk": "@@ -463,11 +463,23 @@ export const exportApiSpec = ({ variables, items, n...
true
usebruno/bruno
8,028
comment_to_fix
feat: add support for duplicate request url + type in OpenAPI spec
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail FILE="packages/bruno-app/src/utils/exporters/openapi-spec.js" echo "== File exists ==" test -f "$FILE" && echo "FOUND: $FILE" || (echo "MISSING: $FILE" && exit...
8cd7c26648673b7e4c6a8994a11d8cf5f08a31bf
8a4e085ba81f66599b8d9125b677ceecb84c6d21
diff --git a/packages/bruno-app/src/utils/exporters/openapi-spec.js b/packages/bruno-app/src/utils/exporters/openapi-spec.js index 06331978313..4e9802056f1 100644 --- a/packages/bruno-app/src/utils/exporters/openapi-spec.js +++ b/packages/bruno-app/src/utils/exporters/openapi-spec.js @@ -4,7 +4,8 @@ import { isValidUrl...
[ "packages/bruno-app/src/utils/exporters/openapi-spec.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\nFILE=\"packages/bruno-app/src/utils/exporters/openapi-spec.js\"\n\necho \"== File exists ==\"\ntest -f \"$FILE\" && echo \"FOUN...
true
usebruno/bruno
8,028
comment_to_fix
feat: add support for duplicate request url + type in OpenAPI spec
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail FILE="packages/bruno-app/src/utils/exporters/openapi-spec.js" # Show a focused window around the reported lines nl -ba "$FILE" | sed -n '330,420p' # Also sear...
8cd7c26648673b7e4c6a8994a11d8cf5f08a31bf
8a4e085ba81f66599b8d9125b677ceecb84c6d21
diff --git a/packages/bruno-app/src/utils/exporters/openapi-spec.js b/packages/bruno-app/src/utils/exporters/openapi-spec.js index 06331978313..4e9802056f1 100644 --- a/packages/bruno-app/src/utils/exporters/openapi-spec.js +++ b/packages/bruno-app/src/utils/exporters/openapi-spec.js @@ -4,7 +4,8 @@ import { isValidUrl...
[ "packages/bruno-app/src/utils/exporters/openapi-spec.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\nFILE=\"packages/bruno-app/src/utils/exporters/openapi-spec.js\"\n\n# Show a focused window around the reported lines\nnl -ba \"...
true
usebruno/bruno
8,028
comment_to_fix
feat: add support for duplicate request url + type in OpenAPI spec
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail FILE="packages/bruno-app/src/utils/exporters/openapi-spec.js" # Show the exact switch section around the referenced lines. nl -ba "$FILE" | sed -n '270,380p' ...
8cd7c26648673b7e4c6a8994a11d8cf5f08a31bf
8a4e085ba81f66599b8d9125b677ceecb84c6d21
diff --git a/packages/bruno-app/src/utils/exporters/openapi-spec.js b/packages/bruno-app/src/utils/exporters/openapi-spec.js index 06331978313..4e9802056f1 100644 --- a/packages/bruno-app/src/utils/exporters/openapi-spec.js +++ b/packages/bruno-app/src/utils/exporters/openapi-spec.js @@ -4,7 +4,8 @@ import { isValidUrl...
[ "packages/bruno-app/src/utils/exporters/openapi-spec.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\nFILE=\"packages/bruno-app/src/utils/exporters/openapi-spec.js\"\n\n# Show the exact switch section around the referenced lines....
true
usebruno/bruno
8,028
comment_to_fix
feat: add support for duplicate request url + type in OpenAPI spec
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Avoid hardcoding Windows separators in the round-trip fixture helper.** These fixtures lock the new variant round-trip coverage to Windows-style `pathname` values, so the suite still won't catch the macOS/Linux case Bruno has to support. Please build these paths wit...
8cd7c26648673b7e4c6a8994a11d8cf5f08a31bf
8a4e085ba81f66599b8d9125b677ceecb84c6d21
diff --git a/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js b/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js index 92b7196d81f..8ac0f58ac0e 100644 --- a/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js +++ b/packages/bruno-app/src/utils/exporters/openapi-spec.spec.js @@ -1,4 +1,10 @...
[ "packages/bruno-app/src/utils/exporters/openapi-spec.spec.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Avoid hardcoding Windows separators in the round-trip fixture helper.**\n\nThese fixtures lock the new variant round-trip coverage to Windows-style `pathname` values, so the suite still won't catch the macOS/Linux case Bruno has to support. Pl...
true
usebruno/bruno
8,028
comment_to_fix
feat: add support for duplicate request url + type in OpenAPI spec
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Variants should inherit base operation fields before per-variant overrides.** Line 865 and Line 876 currently resolve from `operationObjectCleaned` only, so sparse variants drop base operation `parameters`/`servers` instead of inheriting them. This can break round-t...
8cd7c26648673b7e4c6a8994a11d8cf5f08a31bf
8a4e085ba81f66599b8d9125b677ceecb84c6d21
diff --git a/packages/bruno-converters/src/openapi/openapi-to-bruno.js b/packages/bruno-converters/src/openapi/openapi-to-bruno.js index 28304c8affb..5ccd39ce846 100644 --- a/packages/bruno-converters/src/openapi/openapi-to-bruno.js +++ b/packages/bruno-converters/src/openapi/openapi-to-bruno.js @@ -855,21 +855,30 @@ e...
[ "packages/bruno-converters/src/openapi/openapi-to-bruno.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Variants should inherit base operation fields before per-variant overrides.**\n\nLine 865 and Line 876 currently resolve from `operationObjectCleaned` only, so sparse variants drop base operation `parameters`/`servers` instead of inheriting th...
true
usebruno/bruno
8,092
issue_to_patch
Revert "perf: optimize DNS resolution to reduce request latency"
### Description #### Contribution Checklist: - [ ] **I've used AI significantly to create this pull request** - [ ] **The pull request only addresses one issue or adds one feature.** - [ ] **The pull request does not introduce any breaking changes** - [ ] **I have added screenshots or gifs to help explain ...
71f5659763d9d19bdc3f71dde6e23d6e925a2a27
60fc17f10a009bd2ea2429eac4c8352f7ef41d59
diff --git a/packages/bruno-requests/src/network/agent-defaults.ts b/packages/bruno-requests/src/network/agent-defaults.ts deleted file mode 100644 index 5725349c2d8..00000000000 --- a/packages/bruno-requests/src/network/agent-defaults.ts +++ /dev/null @@ -1,24 +0,0 @@ -import http from 'node:http'; -import { fastLooku...
[ "packages/bruno-requests/src/network/agent-defaults.ts", "packages/bruno-requests/src/network/axios-instance.ts", "packages/bruno-requests/src/network/fast-lookup.spec.ts", "packages/bruno-requests/src/network/fast-lookup.ts", "packages/bruno-requests/src/utils/agent-cache.ts" ]
[]
diff --git a/packages/bruno-requests/src/network/fast-lookup.spec.ts b/packages/bruno-requests/src/network/fast-lookup.spec.ts deleted file mode 100644 index 89205f3e265..00000000000 --- a/packages/bruno-requests/src/network/fast-lookup.spec.ts +++ /dev/null @@ -1,60 +0,0 @@ -import dns from 'node:dns'; -import { fastL...
true
usebruno/bruno
8,097
issue_to_patch
fix: tab type resolution for non request types
### Description - `folder-settings` tab type isn't deserialized properly because the request type takes over. [JIRA](https://usebruno.atlassian.net/browse/BRU-3431) #### Contribution Checklist: - [ ] **I've used AI significantly to create this pull request** - [ ] **The pull request only addresses one iss...
a3e31994903d17afa2c09968c0d44bcb7ee01035
b193f18a7c51309e96f5faef1040fa3ef9fb7ba3
diff --git a/packages/bruno-app/src/utils/snapshot/index.js b/packages/bruno-app/src/utils/snapshot/index.js index 9c7a17a2d58..066b75be873 100644 --- a/packages/bruno-app/src/utils/snapshot/index.js +++ b/packages/bruno-app/src/utils/snapshot/index.js @@ -350,6 +350,10 @@ const getAccessor = (tab) => { }; const ge...
[ "packages/bruno-app/src/utils/snapshot/index.js", "packages/bruno-app/src/utils/snapshot/index.spec.js", "tests/snapshots/folder.spec.ts", "tests/utils/page/actions.ts", "tests/utils/page/locators.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Remove debug console.log statement.**\n\nThis debug statement should be removed before merging.\n\n\n\n<details>\n<summary>🧹 Proposed fix</summary>\n\n```diff\n const snapshot = readSnapshot(userDataPath);\n const tab = findSnapsh...
diff --git a/packages/bruno-app/src/utils/snapshot/index.spec.js b/packages/bruno-app/src/utils/snapshot/index.spec.js index bf6b8508f82..a71ca644a5a 100644 --- a/packages/bruno-app/src/utils/snapshot/index.spec.js +++ b/packages/bruno-app/src/utils/snapshot/index.spec.js @@ -286,6 +286,56 @@ describe('deserializeTab',...
true
usebruno/bruno
8,097
comment_to_fix
fix: tab type resolution for non request types
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ **Remove debug console.log statement.** This debug statement should be removed before merging. <details> <summary>🧹 Proposed fix</summary> ```diff const snapshot = readSnapshot(userDataPath); const tab = findSnapshotFolderTab(snapshot, 'TestFolder')...
a3e31994903d17afa2c09968c0d44bcb7ee01035
b193f18a7c51309e96f5faef1040fa3ef9fb7ba3
diff --git a/tests/snapshots/folder.spec.ts b/tests/snapshots/folder.spec.ts new file mode 100644 index 00000000000..c45ed9a2d30 --- /dev/null +++ b/tests/snapshots/folder.spec.ts @@ -0,0 +1,118 @@ +import path from 'path'; +import fs from 'fs'; +import { test, expect, closeElectronApp } from '../../playwright'; +impor...
[ "tests/snapshots/folder.spec.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Remove debug console.log statement.**\n\nThis debug statement should be removed before merging.\n\n\n\n<details>\n<summary>🧹 Proposed fix</summary>\n\n```diff\n const snapshot = readSnapshot(userDataPath);\n const tab = findSnapsh...
true
usebruno/bruno
8,070
issue_to_patch
fix: varinfo drag-select dismiss
### Description [JIRA](https://usebruno.atlassian.net/browse/BRU-3484) Fixes - select the entire value and drag the mouse outside the input field. The popup closes even though the input remains focused. #### Contribution Checklist: - [ ] **I've used AI significantly to create this pull request** - [ ] **Th...
8cd7c26648673b7e4c6a8994a11d8cf5f08a31bf
1e7f92fd29bc82f0fc6b6446fa6e102c2b211448
diff --git a/packages/bruno-app/src/utils/codemirror/brunoVarInfo.js b/packages/bruno-app/src/utils/codemirror/brunoVarInfo.js index 89e79fda132..338f962accd 100644 --- a/packages/bruno-app/src/utils/codemirror/brunoVarInfo.js +++ b/packages/bruno-app/src/utils/codemirror/brunoVarInfo.js @@ -912,6 +912,10 @@ if (!SERVE...
[ "packages/bruno-app/src/utils/codemirror/brunoVarInfo.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Outside clicks can no longer dismiss the popup in common cases**\n\nAt Line 915, the unconditional `popup.contains(document.activeElement)` early return also skips valid outside-dismiss clicks (e.g., clicking a non-focusable area while focus i...
true
usebruno/bruno
8,070
comment_to_fix
fix: varinfo drag-select dismiss
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Outside clicks can no longer dismiss the popup in common cases** At Line 915, the unconditional `popup.contains(document.activeElement)` early return also skips valid outside-dismiss clicks (e.g., clicking a non-focusable area while focus is still inside the popup),...
8cd7c26648673b7e4c6a8994a11d8cf5f08a31bf
1e7f92fd29bc82f0fc6b6446fa6e102c2b211448
diff --git a/packages/bruno-app/src/utils/codemirror/brunoVarInfo.js b/packages/bruno-app/src/utils/codemirror/brunoVarInfo.js index 89e79fda132..338f962accd 100644 --- a/packages/bruno-app/src/utils/codemirror/brunoVarInfo.js +++ b/packages/bruno-app/src/utils/codemirror/brunoVarInfo.js @@ -912,6 +912,10 @@ if (!SERVE...
[ "packages/bruno-app/src/utils/codemirror/brunoVarInfo.js" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Outside clicks can no longer dismiss the popup in common cases**\n\nAt Line 915, the unconditional `popup.contains(document.activeElement)` early return also skips valid outside-dismiss clicks (e.g., clicking a non-focusable area while focus i...
true
usebruno/bruno
8,087
issue_to_patch
Multipart upload fails because Bruno sends Content-Type: multipart/form-data without boundary ### I have checked the following: - [x] I have searched existing issues and found nothing related to my issue. ### This bug is: - [x] making Bruno unusable for me - [ ] slowing me down but I'm able to continue working - [x...
fix: multipart/mixed and multipart/form-data interpolation and generic request behaviour
### Description Fixes: https://github.com/usebruno/bruno/issues/7726 [JIRA](https://usebruno.atlassian.net/browse/BRU-3479) #### Contribution Checklist: - [ ] **I've used AI significantly to create this pull request** - [ ] **The pull request only addresses one issue or adds one feature.** - [ ] **The pul...
9b0911926ca62b213c72b13886cff65560493d4e
b3cda1e902916a87fcad50ac46ebbcad23952d05
diff --git a/packages/bruno-cli/src/runner/interpolate-vars.js b/packages/bruno-cli/src/runner/interpolate-vars.js index 7f76aab14f3..fa531082f96 100644 --- a/packages/bruno-cli/src/runner/interpolate-vars.js +++ b/packages/bruno-cli/src/runner/interpolate-vars.js @@ -102,7 +102,9 @@ const interpolateVars = (request, e...
[ "packages/bruno-cli/src/runner/interpolate-vars.js", "packages/bruno-cli/src/runner/run-single-request.js", "packages/bruno-cli/tests/runner/interpolate-vars.spec.js", "packages/bruno-electron/src/ipc/network/index.js", "packages/bruno-electron/src/ipc/network/interpolate-vars.js", "packages/bruno-electro...
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Set explicit multipart header with boundary to validate the real contract.**\n\nThis scenario can pass as plain text echo without proving multipart parsing behavior. Add `Content-Type: multipart/mixed; boundary=------MyCustomBoundaryString` so...
diff --git a/packages/bruno-cli/tests/runner/interpolate-vars.spec.js b/packages/bruno-cli/tests/runner/interpolate-vars.spec.js index 4f39185c308..ce105c67b13 100644 --- a/packages/bruno-cli/tests/runner/interpolate-vars.spec.js +++ b/packages/bruno-cli/tests/runner/interpolate-vars.spec.js @@ -18,6 +18,58 @@ describe...
true
usebruno/bruno
8,087
comment_to_fix
fix: multipart/mixed and multipart/form-data interpolation and generic request behaviour
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Set explicit multipart header with boundary to validate the real contract.** This scenario can pass as plain text echo without proving multipart parsing behavior. Add `Content-Type: multipart/mixed; boundary=------MyCustomBoundaryString` so the test actually exercis...
9b0911926ca62b213c72b13886cff65560493d4e
b3cda1e902916a87fcad50ac46ebbcad23952d05
diff --git a/packages/bruno-tests/collection/multipart/content-types-mixed-interpolation.bru b/packages/bruno-tests/collection/multipart/content-types-mixed-interpolation.bru new file mode 100644 index 00000000000..0052b5c6295 --- /dev/null +++ b/packages/bruno-tests/collection/multipart/content-types-mixed-interpolati...
[ "packages/bruno-tests/collection/multipart/content-types-mixed-interpolation.bru" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Set explicit multipart header with boundary to validate the real contract.**\n\nThis scenario can pass as plain text echo without proving multipart parsing behavior. Add `Content-Type: multipart/mixed; boundary=------MyCustomBoundaryString` so...
true
usebruno/bruno
8,087
comment_to_fix
fix: multipart/mixed and multipart/form-data interpolation and generic request behaviour
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Add an assertion for top-level `Content-Type` boundary parameter.** Given this PR’s multipart boundary objective, this test should explicitly verify `multipart/mixed; boundary=...` is present in the outgoing request representation. <details> <summary>Proposed asser...
9b0911926ca62b213c72b13886cff65560493d4e
b3cda1e902916a87fcad50ac46ebbcad23952d05
diff --git a/packages/bruno-tests/collection/multipart/multipart-mixed-form-data-parse.bru b/packages/bruno-tests/collection/multipart/multipart-mixed-form-data-parse.bru new file mode 100644 index 00000000000..f25bf3b4292 --- /dev/null +++ b/packages/bruno-tests/collection/multipart/multipart-mixed-form-data-parse.bru...
[ "packages/bruno-tests/collection/multipart/multipart-mixed-form-data-parse.bru" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add an assertion for top-level `Content-Type` boundary parameter.**\n\nGiven this PR’s multipart boundary objective, this test should explicitly verify `multipart/mixed; boundary=...` is present in the outgoing request representation.\n\n<deta...
true
usememos/memos
6,030
issue_to_patch
Simple Markdown Editor ### Is your feature request related to a problem? I just noticed that memo supports markdown, but it is not possible to easily edit the content in markdown. ### Describe the solution you'd like Would it be possible to integrate a light editor, so that the text can be bolded, highlighted or it...
feat(web): markdown WYSIWYG editor with raw-mode toggle
## Summary - Replaces the plain textarea memo editor with a **Tiptap 3.26 WYSIWYG editor** that renders markdown live as you type (Linear/Claude-composer style), while keeping **markdown as the only storage and API format** — the backend and proto are untouched. - The textarea editor stays as **raw mode** behind a per...
8080bd10e1301a03609bc188800371c541fcf004
cc08506232db525d471967e20ee8ea47a6afdf96
diff --git a/docs/superpowers/plans/2026-06-11-markdown-wysiwyg-editor.md b/docs/superpowers/plans/2026-06-11-markdown-wysiwyg-editor.md new file mode 100644 index 0000000000000..c4d044a107a69 --- /dev/null +++ b/docs/superpowers/plans/2026-06-11-markdown-wysiwyg-editor.md @@ -0,0 +1,2621 @@ +# Markdown WYSIWYG Editor ...
[ "docs/superpowers/plans/2026-06-11-markdown-wysiwyg-editor.md", "docs/superpowers/specs/2026-06-11-markdown-wysiwyg-editor-design.md", "web/package.json", "web/pnpm-lock.yaml", "web/src/components/MemoEditor/Editor/controllerAdapter.ts", "web/src/components/MemoEditor/Editor/shortcuts.ts", "web/src/comp...
[]
diff --git a/docs/superpowers/specs/2026-06-11-markdown-wysiwyg-editor-design.md b/docs/superpowers/specs/2026-06-11-markdown-wysiwyg-editor-design.md new file mode 100644 index 0000000000000..94302a4729f6e --- /dev/null +++ b/docs/superpowers/specs/2026-06-11-markdown-wysiwyg-editor-design.md @@ -0,0 +1,168 @@ +# Mark...
true
usememos/memos
6,013
issue_to_patch
feat: add optional webhook signing secret (Standard Webhooks HMAC-SHA256)
## Summary Add optional HMAC-SHA256 request signing for webhooks, following the [Standard Webhooks](https://github.com/standard-webhooks/standard-webhooks/blob/main/spec/standard-webhooks.md) convention. The signing secret is never transmitted on the wire — instead, each outgoing request body is signed and the signatu...
8f1377324f9c59505a39d395c09ff7536459911a
c5880d0870b146fe52109342b16ed39f33950d76
diff --git a/internal/webhook/validate.go b/internal/webhook/validate.go index 579edfa56dc53..37afa9d819778 100644 --- a/internal/webhook/validate.go +++ b/internal/webhook/validate.go @@ -81,3 +81,18 @@ func ValidateURL(rawURL string) error { } return nil } + +// ValidateSigningSecret checks that secret is either...
[ "internal/webhook/validate.go", "internal/webhook/webhook.go", "proto/api/v1/user_service.proto", "proto/gen/api/v1/user_service.pb.go", "proto/gen/openapi.yaml", "proto/gen/store/user_setting.pb.go", "proto/store/user_setting.proto", "server/router/api/v1/memo_service.go", "server/router/api/v1/use...
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Validate bearer token format before persisting.**\n\n`BearerToken` is accepted with only whitespace trimming, then later used to build the `Authorization` header during dispatch. Invalid header-value characters can make outbound webhook reques...
true
usememos/memos
6,013
comment_to_fix
feat: add optional webhook signing secret (Standard Webhooks HMAC-SHA256)
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Validate bearer token format before persisting.** `BearerToken` is accepted with only whitespace trimming, then later used to build the `Authorization` header during dispatch. Invalid header-value characters can make outbound webhook requests fail at runtime for tha...
8f1377324f9c59505a39d395c09ff7536459911a
c5880d0870b146fe52109342b16ed39f33950d76
diff --git a/server/router/api/v1/user_service.go b/server/router/api/v1/user_service.go index adcebcd4a75d2..380ee7f342ed1 100644 --- a/server/router/api/v1/user_service.go +++ b/server/router/api/v1/user_service.go @@ -1095,12 +1095,16 @@ func (s *APIV1Service) CreateUserWebhook(ctx context.Context, request *v1pb.Cre...
[ "server/router/api/v1/user_service.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Validate bearer token format before persisting.**\n\n`BearerToken` is accepted with only whitespace trimming, then later used to build the `Authorization` header during dispatch. Invalid header-value characters can make outbound webhook reques...
true
usememos/memos
6,013
comment_to_fix
feat: add optional webhook signing secret (Standard Webhooks HMAC-SHA256)
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Cannot clear an existing bearer token in edit flow** `bearer_token` is only added to `updateMask` when `state.bearerToken` is non-empty, so users cannot clear a previously stored token (empty value is ignored and backend keeps old token). This makes “optional token”...
8f1377324f9c59505a39d395c09ff7536459911a
c5880d0870b146fe52109342b16ed39f33950d76
diff --git a/web/src/components/CreateWebhookDialog.tsx b/web/src/components/CreateWebhookDialog.tsx index 543d0d5cc607c..ed63104a4d111 100644 --- a/web/src/components/CreateWebhookDialog.tsx +++ b/web/src/components/CreateWebhookDialog.tsx @@ -1,5 +1,7 @@ import { create } from "@bufbuild/protobuf"; import { FieldMa...
[ "web/src/components/CreateWebhookDialog.tsx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Cannot clear an existing bearer token in edit flow**\n\n`bearer_token` is only added to `updateMask` when `state.bearerToken` is non-empty, so users cannot clear a previously stored token (empty value is ignored and backend keeps old token). T...
true
usememos/memos
6,013
comment_to_fix
feat: add optional webhook signing secret (Standard Webhooks HMAC-SHA256)
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Bearer token is exposed in plain text input** The token field uses `type="text"`, which exposes secret material during entry/edit. Use a masked input by default. <details> <summary>💡 Proposed fix</summary> ```diff - <Input + <Input ...
8f1377324f9c59505a39d395c09ff7536459911a
c5880d0870b146fe52109342b16ed39f33950d76
diff --git a/web/src/components/CreateWebhookDialog.tsx b/web/src/components/CreateWebhookDialog.tsx index 543d0d5cc607c..ed63104a4d111 100644 --- a/web/src/components/CreateWebhookDialog.tsx +++ b/web/src/components/CreateWebhookDialog.tsx @@ -1,5 +1,7 @@ import { create } from "@bufbuild/protobuf"; import { FieldMa...
[ "web/src/components/CreateWebhookDialog.tsx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Bearer token is exposed in plain text input**\n\nThe token field uses `type=\"text\"`, which exposes secret material during entry/edit. Use a masked input by default.\n\n<details>\n<summary>💡 Proposed fix</summary>\n\n```diff\n- ...
true
usememos/memos
6,013
comment_to_fix
feat: add optional webhook signing secret (Standard Webhooks HMAC-SHA256)
_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_ **Validate signing secret before persisting in the no-mask update path.** When `update_mask` is not provided and `request.Webhook.SigningSecret` is non-empty, the secret is trimmed but not validated before being persisted. This is inconsistent with the `update_mask...
8f1377324f9c59505a39d395c09ff7536459911a
c5880d0870b146fe52109342b16ed39f33950d76
diff --git a/server/router/api/v1/user_service.go b/server/router/api/v1/user_service.go index adcebcd4a75d2..380ee7f342ed1 100644 --- a/server/router/api/v1/user_service.go +++ b/server/router/api/v1/user_service.go @@ -1095,12 +1095,16 @@ func (s *APIV1Service) CreateUserWebhook(ctx context.Context, request *v1pb.Cre...
[ "server/router/api/v1/user_service.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🔴 Critical_ | _⚡ Quick win_\n\n**Validate signing secret before persisting in the no-mask update path.**\n\nWhen `update_mask` is not provided and `request.Webhook.SigningSecret` is non-empty, the secret is trimmed but not validated before being persisted. This is inconsis...
true
usememos/memos
6,013
comment_to_fix
feat: add optional webhook signing secret (Standard Webhooks HMAC-SHA256)
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Reset the form when switching between create/edit sessions.** The `isCreating ? "" : undefined` default only applies on the initial mount. If this dialog stays mounted, reopening it in create mode can reuse the last typed `signingSecret`, and Line 119 will persist t...
8f1377324f9c59505a39d395c09ff7536459911a
c5880d0870b146fe52109342b16ed39f33950d76
diff --git a/web/src/components/CreateWebhookDialog.tsx b/web/src/components/CreateWebhookDialog.tsx index 543d0d5cc607c..ed63104a4d111 100644 --- a/web/src/components/CreateWebhookDialog.tsx +++ b/web/src/components/CreateWebhookDialog.tsx @@ -1,5 +1,7 @@ import { create } from "@bufbuild/protobuf"; import { FieldMa...
[ "web/src/components/CreateWebhookDialog.tsx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Reset the form when switching between create/edit sessions.**\n\nThe `isCreating ? \"\" : undefined` default only applies on the initial mount. If this dialog stays mounted, reopening it in create mode can reuse the last typed `signingSecret`,...
true
usememos/memos
6,013
comment_to_fix
feat: add optional webhook signing secret (Standard Webhooks HMAC-SHA256)
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ **Normalize the secret before copying or saving it.** `server/router/api/v1/user_service.go` trims `request.Webhook.SigningSecret` on both create and update, but this dialog keeps and copies the raw input. A user who pastes `whsec_... ` will share one secret and persi...
8f1377324f9c59505a39d395c09ff7536459911a
c5880d0870b146fe52109342b16ed39f33950d76
diff --git a/web/src/components/CreateWebhookDialog.tsx b/web/src/components/CreateWebhookDialog.tsx index 543d0d5cc607c..ed63104a4d111 100644 --- a/web/src/components/CreateWebhookDialog.tsx +++ b/web/src/components/CreateWebhookDialog.tsx @@ -1,5 +1,7 @@ import { create } from "@bufbuild/protobuf"; import { FieldMa...
[ "web/src/components/CreateWebhookDialog.tsx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Normalize the secret before copying or saving it.**\n\n`server/router/api/v1/user_service.go` trims `request.Webhook.SigningSecret` on both create and update, but this dialog keeps and copies the raw input. A user who pastes `whsec_... ` will ...
true
usememos/memos
6,013
comment_to_fix
feat: add optional webhook signing secret (Standard Webhooks HMAC-SHA256)
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Add an accessible name to the copy button.** This is an icon-only control with no text or `aria-label`, so assistive tech exposes it as an unnamed button. That is especially problematic here because the secret input is masked and this button becomes the main way to ...
8f1377324f9c59505a39d395c09ff7536459911a
c5880d0870b146fe52109342b16ed39f33950d76
diff --git a/web/src/components/CreateWebhookDialog.tsx b/web/src/components/CreateWebhookDialog.tsx index 543d0d5cc607c..ed63104a4d111 100644 --- a/web/src/components/CreateWebhookDialog.tsx +++ b/web/src/components/CreateWebhookDialog.tsx @@ -1,5 +1,7 @@ import { create } from "@bufbuild/protobuf"; import { FieldMa...
[ "web/src/components/CreateWebhookDialog.tsx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add an accessible name to the copy button.**\n\nThis is an icon-only control with no text or `aria-label`, so assistive tech exposes it as an unnamed button. That is especially problematic here because the secret input is masked and this butto...
true
usememos/memos
6,013
comment_to_fix
feat: add optional webhook signing secret (Standard Webhooks HMAC-SHA256)
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Decode whsec_ secrets before signing** When the secret comes from the new Generate button it is serialized as `whsec_` plus base64 random bytes, and Standard Webhooks-compatible receivers/libraries strip that prefix and base64-deco...
8f1377324f9c59505a39d395c09ff7536459911a
c5880d0870b146fe52109342b16ed39f33950d76
diff --git a/internal/webhook/webhook.go b/internal/webhook/webhook.go index 07dc64cdf4986..70dfa126cb5c5 100644 --- a/internal/webhook/webhook.go +++ b/internal/webhook/webhook.go @@ -3,13 +3,19 @@ package webhook import ( "bytes" "context" + "crypto/hmac" + "crypto/sha256" + "encoding/base64" "encoding/json" ...
[ "internal/webhook/webhook.go" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Decode whsec_ secrets before signing**\n\nWhen the secret comes from the new Generate button it is serialized as `whsec_` plus base64 random bytes, and Standard Webhooks-compatible receivers/libraries strip tha...
true
usememos/memos
6,013
comment_to_fix
feat: add optional webhook signing secret (Standard Webhooks HMAC-SHA256)
**<sub><sub>![P3 Badge](https://img.shields.io/badge/P3-lightgrey?style=flat)</sub></sub> Provide a real way to clear webhook secrets** In edit mode the server intentionally never returns `signingSecret`, so the password input renders empty while `state.signingSecret` remains `undefined`; because these lines only add...
8f1377324f9c59505a39d395c09ff7536459911a
c5880d0870b146fe52109342b16ed39f33950d76
diff --git a/web/src/components/CreateWebhookDialog.tsx b/web/src/components/CreateWebhookDialog.tsx index 543d0d5cc607c..ed63104a4d111 100644 --- a/web/src/components/CreateWebhookDialog.tsx +++ b/web/src/components/CreateWebhookDialog.tsx @@ -1,5 +1,7 @@ import { create } from "@bufbuild/protobuf"; import { FieldMa...
[ "web/src/components/CreateWebhookDialog.tsx" ]
[ { "comment": "**<sub><sub>![P3 Badge](https://img.shields.io/badge/P3-lightgrey?style=flat)</sub></sub> Provide a real way to clear webhook secrets**\n\nIn edit mode the server intentionally never returns `signingSecret`, so the password input renders empty while `state.signingSecret` remains `undefined`; beca...
true
usememos/memos
6,026
issue_to_patch
MCP server returns arrays in some tools ### Pre-submission Checklist - [x] I have searched existing issues and confirmed this has not already been reported - [x] This is a bug report, not a question or configuration request ### Memos Version 0.29 ### Environment Details Simple docker compose instance with sqlite....
feat: add OpenAPI-driven MCP support
## Summary - Restore MCP support with a `/mcp` Streamable HTTP endpoint backed by the official Go MCP SDK. - Generate curated memo and attachment MCP tools from `proto/gen/openapi.yaml` instead of handwritten tool definitions. - Route tool calls through existing API handlers, preserving auth behavior while validating t...
6870e863deffa9ea49ccc1bb7a7391b1f7835f19
fb9a9fb3326180957f6b89025fbed20d5b5e1672
diff --git a/docs/superpowers/plans/2026-06-08-openapi-mcp-support.md b/docs/superpowers/plans/2026-06-08-openapi-mcp-support.md new file mode 100644 index 0000000000000..cec118431529c --- /dev/null +++ b/docs/superpowers/plans/2026-06-08-openapi-mcp-support.md @@ -0,0 +1,1562 @@ +# OpenAPI-Driven MCP Support Implement...
[ "docs/superpowers/plans/2026-06-08-openapi-mcp-support.md", "docs/superpowers/specs/2026-06-08-openapi-mcp-support-design.md", "go.mod", "go.sum", "proto/openapi_embed.go", "server/router/mcp/adapter.go", "server/router/mcp/adapter_test.go", "server/router/mcp/catalog.go", "server/router/mcp/catalog...
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Guard the `TextContent` assertion to avoid panic in test execution.**\n\nLine 209 uses an unchecked type assertion; this can panic and is already flagged by static checks.\n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n-\ttext := r...
diff --git a/docs/superpowers/specs/2026-06-08-openapi-mcp-support-design.md b/docs/superpowers/specs/2026-06-08-openapi-mcp-support-design.md new file mode 100644 index 0000000000000..06a9dc050e2f3 --- /dev/null +++ b/docs/superpowers/specs/2026-06-08-openapi-mcp-support-design.md @@ -0,0 +1,241 @@ +# OpenAPI-Driven M...
true
usememos/memos
6,026
comment_to_fix
feat: add OpenAPI-driven MCP support
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Guard the `TextContent` assertion to avoid panic in test execution.** Line 209 uses an unchecked type assertion; this can panic and is already flagged by static checks. <details> <summary>Suggested fix</summary> ```diff - text := result.Content[0].(*sdkmcp.TextCon...
6870e863deffa9ea49ccc1bb7a7391b1f7835f19
fb9a9fb3326180957f6b89025fbed20d5b5e1672
diff --git a/server/router/mcp/adapter_test.go b/server/router/mcp/adapter_test.go new file mode 100644 index 0000000000000..584955533e6d8 --- /dev/null +++ b/server/router/mcp/adapter_test.go @@ -0,0 +1,213 @@ +package mcp + +import ( + "context" + "encoding/json" + "errors" + "io" + "net/http" + "testing" + + "github...
[ "server/router/mcp/adapter_test.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Guard the `TextContent` assertion to avoid panic in test execution.**\n\nLine 209 uses an unchecked type assertion; this can panic and is already flagged by static checks.\n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n-\ttext := r...
true
usememos/memos
6,026
comment_to_fix
feat: add OpenAPI-driven MCP support
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Guard the type assertions to avoid revive `unchecked-type-assertion` failures.** Line 81, Line 83, and Line 86 use direct assertions that can panic and currently fail static checks. Use checked assertions before dereferencing. <details> <summary>Suggested patch...
6870e863deffa9ea49ccc1bb7a7391b1f7835f19
fb9a9fb3326180957f6b89025fbed20d5b5e1672
diff --git a/server/router/mcp/catalog_test.go b/server/router/mcp/catalog_test.go new file mode 100644 index 0000000000000..46492dd27733e --- /dev/null +++ b/server/router/mcp/catalog_test.go @@ -0,0 +1,152 @@ +package mcp + +import ( + "encoding/json" + "testing" + + sdkmcp "github.com/modelcontextprotocol/go-sdk/mcp...
[ "server/router/mcp/catalog_test.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Guard the type assertions to avoid revive `unchecked-type-assertion` failures.**\n\nLine 81, Line 83, and Line 86 use direct assertions that can panic and currently fail static checks. Use checked assertions before dereferencing.\n\n\n\n\n\n<d...
true
usememos/memos
6,026
comment_to_fix
feat: add OpenAPI-driven MCP support
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Replace unchecked type assertions in JSON-RPC response parsing.** These casts can panic and are currently flagged by static checks. Use checked assertions (`value, ok := ...`) with `require.True`/`require.Contains` guards so failures stay assertion-based. <det...
6870e863deffa9ea49ccc1bb7a7391b1f7835f19
fb9a9fb3326180957f6b89025fbed20d5b5e1672
diff --git a/server/router/mcp/service_test.go b/server/router/mcp/service_test.go new file mode 100644 index 0000000000000..e1ea1efe760c4 --- /dev/null +++ b/server/router/mcp/service_test.go @@ -0,0 +1,283 @@ +package mcp + +import ( + "bytes" + "context" + "encoding/json" + "net/http" + "net/http/httptest" + "os" + ...
[ "server/router/mcp/service_test.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Replace unchecked type assertions in JSON-RPC response parsing.**\n\nThese casts can panic and are currently flagged by static checks. Use checked assertions (`value, ok := ...`) with `require.True`/`require.Contains` guards so failures stay a...
true
usememos/memos
6,026
comment_to_fix
feat: add OpenAPI-driven MCP support
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Remove unreachable nil check in type loop (govet nilness blocker).** Because Line 53 already returns when `value == nil`, the Line 62 branch is unreachable and triggers the reported `nilness` failure. <details> <summary>Suggested fix</summary> ```diff for _, sch...
6870e863deffa9ea49ccc1bb7a7391b1f7835f19
fb9a9fb3326180957f6b89025fbed20d5b5e1672
diff --git a/server/router/mcp/validation.go b/server/router/mcp/validation.go new file mode 100644 index 0000000000000..c9ca92f54bb2b --- /dev/null +++ b/server/router/mcp/validation.go @@ -0,0 +1,226 @@ +package mcp + +import ( + "encoding/json" + "math" + "strings" + + googlejsonschema "github.com/google/jsonschema-...
[ "server/router/mcp/validation.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Remove unreachable nil check in type loop (govet nilness blocker).**\n\nBecause Line 53 already returns when `value == nil`, the Line 62 branch is unreachable and triggers the reported `nilness` failure.\n\n<details>\n<summary>Suggested fix</s...
true
usememos/memos
6,016
issue_to_patch
Markdown formatting keyboard shortcuts are documented but not wired, and additional code shortcuts would be useful ### Pre-submission Checklist - [x] I have searched existing issues and confirmed this has not already been requested - [x] This is a feature request, not a bug report or support question ### Problem or ...
fix(editor): wire Ctrl+B and Ctrl+I markdown shortcuts to textarea
## Summary - `shortcuts.ts` に `handleMarkdownShortcuts` 関数が実装されていたが `<textarea>` の `onKeyDown` に接続されておらず、`Ctrl+B`(太字)・`Ctrl+I`(斜体)が動作しない状態だった - `Editor/index.tsx` に `onKeyDown` ハンドラを追加し、`Ctrl`/`Cmd` 押下時に `handleMarkdownShortcuts` を呼ぶよう接続 - IME変換中はショートカットをスキップするよう制御を追加 ## Notes on Ctrl+K `shortcuts.ts` には `Ctrl+K`(リン...
a50ce09e8159836aed1a97fa717488283378200f
b5aece126f29347c8c2c726335cdbb32e282344b
diff --git a/web/src/components/MemoEditor/Editor/index.tsx b/web/src/components/MemoEditor/Editor/index.tsx index 4ce1dd59a34b3..1d2ff135846ec 100644 --- a/web/src/components/MemoEditor/Editor/index.tsx +++ b/web/src/components/MemoEditor/Editor/index.tsx @@ -5,7 +5,7 @@ import { EDITOR_HEIGHT } from "../constants"; ...
[ "web/src/components/MemoEditor/Editor/index.tsx", "web/src/components/MemoEditor/Editor/shortcuts.ts", "web/tests/memo-editor-shortcuts.test.tsx" ]
[]
diff --git a/web/tests/memo-editor-shortcuts.test.tsx b/web/tests/memo-editor-shortcuts.test.tsx new file mode 100644 index 0000000000000..46090029c57f9 --- /dev/null +++ b/web/tests/memo-editor-shortcuts.test.tsx @@ -0,0 +1,116 @@ +import { fireEvent, render, screen } from "@testing-library/react"; +import { describe,...
true
usememos/memos
6,017
issue_to_patch
feat(settings): move tag metadata to user settings
## Summary - Move active tag metadata from instance settings to per-user `UserSetting.TAGS`. - Update memo tag rendering and blur behavior to use the current viewer's user-level tag settings. - Add 0.30 migrations for SQLite, MySQL, and PostgreSQL to copy existing instance `TAGS` values into user settings without over...
a50ce09e8159836aed1a97fa717488283378200f
1a91d53da3541ef9bac77a3d70e19fbcf34b7aff
diff --git a/proto/api/v1/instance_service.proto b/proto/api/v1/instance_service.proto index b1accc5e6d069..88f6b2ccbdfd7 100644 --- a/proto/api/v1/instance_service.proto +++ b/proto/api/v1/instance_service.proto @@ -204,6 +204,8 @@ message InstanceSetting { } // Tag metadata configuration. + // Active tag met...
[ "proto/api/v1/instance_service.proto", "proto/api/v1/user_service.proto", "proto/gen/api/v1/ai_service_grpc.pb.go", "proto/gen/api/v1/attachment_service_grpc.pb.go", "proto/gen/api/v1/auth_service_grpc.pb.go", "proto/gen/api/v1/idp_service_grpc.pb.go", "proto/gen/api/v1/instance_service.pb.go", "proto...
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Remove the redundant import alias for `fieldmaskpb`.**\n\nThis triggers the reported revive lint failure and is a trivial cleanup.\n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n-\tfieldmaskpb \"google.golang.org/protobuf/types/kno...
diff --git a/server/router/api/v1/test/user_setting_test.go b/server/router/api/v1/test/user_setting_test.go index 9e68368ad8a8d..cd6f5db33433c 100644 --- a/server/router/api/v1/test/user_setting_test.go +++ b/server/router/api/v1/test/user_setting_test.go @@ -5,6 +5,8 @@ import ( "testing" "github.com/stretchr/t...
true
usememos/memos
6,017
comment_to_fix
feat(settings): move tag metadata to user settings
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ **Remove the redundant import alias for `fieldmaskpb`.** This triggers the reported revive lint failure and is a trivial cleanup. <details> <summary>Suggested fix</summary> ```diff - fieldmaskpb "google.golang.org/protobuf/types/known/fieldmaskpb" + "google.golang.o...
a50ce09e8159836aed1a97fa717488283378200f
1a91d53da3541ef9bac77a3d70e19fbcf34b7aff
diff --git a/server/router/api/v1/test/user_setting_test.go b/server/router/api/v1/test/user_setting_test.go index 9e68368ad8a8d..cd6f5db33433c 100644 --- a/server/router/api/v1/test/user_setting_test.go +++ b/server/router/api/v1/test/user_setting_test.go @@ -5,6 +5,8 @@ import ( "testing" "github.com/stretchr/t...
[ "server/router/api/v1/test/user_setting_test.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Remove the redundant import alias for `fieldmaskpb`.**\n\nThis triggers the reported revive lint failure and is a trivial cleanup.\n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n-\tfieldmaskpb \"google.golang.org/protobuf/types/kno...
true
usememos/memos
6,017
comment_to_fix
feat(settings): move tag metadata to user settings
_⚠️ Potential issue_ | _🟡 Minor_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Verify err-wrapping style in this file. rg -n 'errors\.Errorf\(".*%v",\s*err\)' server/router/api/v1/user_service.go ``` Repository: usememos/memos Length of output: 40 --- 🏁 Script execut...
a50ce09e8159836aed1a97fa717488283378200f
1a91d53da3541ef9bac77a3d70e19fbcf34b7aff
diff --git a/server/router/api/v1/user_service.go b/server/router/api/v1/user_service.go index 0d1a040331393..adcebcd4a75d2 100644 --- a/server/router/api/v1/user_service.go +++ b/server/router/api/v1/user_service.go @@ -37,6 +37,29 @@ func validatePassword(password string) error { return nil } +func validateUserT...
[ "server/router/api/v1/user_service.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify err-wrapping style in this file.\nrg -n 'errors\\.Errorf\\(\".*%v\",\\s*err\\)' server/router/api/v1/user_service.go\n```\n\nRepository: usememos/memos\n\n...
true
usememos/memos
6,017
comment_to_fix
feat(settings): move tag metadata to user settings
_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_ **Add a doc comment for the exported test function.** Line 117 introduces an exported function without a leading comment, which can fail godot checks. <details> <summary>Suggested patch</summary> ```diff +// TestMigrationCopiesInstanceTagsToUserSettings verifie...
a50ce09e8159836aed1a97fa717488283378200f
1a91d53da3541ef9bac77a3d70e19fbcf34b7aff
diff --git a/store/test/migrator_test.go b/store/test/migrator_test.go index 86c8c8de08f6f..dcbe64eb03800 100644 --- a/store/test/migrator_test.go +++ b/store/test/migrator_test.go @@ -2,12 +2,16 @@ package test import ( "context" + "database/sql" "fmt" "testing" "time" "github.com/stretchr/testify/requi...
[ "store/test/migrator_test.go" ]
[ { "comment": "_🛠️ Refactor suggestion_ | _🟠 Major_ | _⚡ Quick win_\n\n**Add a doc comment for the exported test function.**\n\nLine 117 introduces an exported function without a leading comment, which can fail godot checks.\n\n<details>\n<summary>Suggested patch</summary>\n\n```diff\n+// TestMigrationCopiesIn...
true
usememos/memos
6,017
comment_to_fix
feat(settings): move tag metadata to user settings
_⚠️ Potential issue_ | _🟡 Minor_ **Wrap TAGS marshal/unmarshal errors with context.** `store/user_setting.go` returns raw `err` for the `storepb.UserSetting_TAGS` protojson unmarshalling/marshalling paths; wrap them with `errors.Wrap(err, "...")` to follow the `github.com/pkg/errors` rule. <details> <summary>Sugges...
a50ce09e8159836aed1a97fa717488283378200f
1a91d53da3541ef9bac77a3d70e19fbcf34b7aff
diff --git a/store/user_setting.go b/store/user_setting.go index a020920e864a3..c5c208d9a0c1b 100644 --- a/store/user_setting.go +++ b/store/user_setting.go @@ -435,6 +435,12 @@ func convertUserSettingFromRaw(raw *UserSetting) (*storepb.UserSetting, error) { return nil, err } userSetting.Value = &storepb.User...
[ "store/user_setting.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Wrap TAGS marshal/unmarshal errors with context.**\n\n`store/user_setting.go` returns raw `err` for the `storepb.UserSetting_TAGS` protojson unmarshalling/marshalling paths; wrap them with `errors.Wrap(err, \"...\")` to follow the `github.com/pkg/errors` rule...
true
usememos/memos
6,000
issue_to_patch
HTML link previews drop description when page uses <meta name="description"> (only OpenGraph works) ### Pre-submission Checklist - [x] I have searched existing issues and confirmed this has not already been reported - [x] This is a bug report, not a question or configuration request > Note: this was previously repor...
fix: support <meta name=description> in link previews
## Summary The function only matched <meta property=...> (OpenGraph) attributes and ignored <meta name=...> (standard HTML). This caused link previews to silently drop descriptions for pages that use the standard HTML <meta name="description"\u003e tag without OpenGraph fallback. ## Root Cause In , the condition wa...
fadc974364876abb641f9a0df1d62c1a0ec2560c
badeac12d208238cb429b59470d1568dd81d1ce0
diff --git a/internal/httpgetter/html_meta.go b/internal/httpgetter/html_meta.go index 2e72f1aac8ad6..8a5f31491baa0 100644 --- a/internal/httpgetter/html_meta.go +++ b/internal/httpgetter/html_meta.go @@ -7,6 +7,7 @@ import ( "net" "net/http" "net/url" + "strings" "time" "github.com/pkg/errors" @@ -175,11 +...
[ "internal/httpgetter/html_meta.go", "internal/httpgetter/html_meta_test.go" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Match meta name values case-insensitively**\n\nWhen a page uses a valid case variant such as `<meta name=\"Description\" content=\"...\">`, this new `name` path still leaves `ok` false because `attr.Val` is com...
diff --git a/internal/httpgetter/html_meta_test.go b/internal/httpgetter/html_meta_test.go index d5d77bad1a1d2..f10e5ac83cb2b 100644 --- a/internal/httpgetter/html_meta_test.go +++ b/internal/httpgetter/html_meta_test.go @@ -55,6 +55,74 @@ func TestGetHTMLMeta(t *testing.T) { }, *metadata) } +func TestGetHTMLMetaW...
true
usememos/memos
6,000
comment_to_fix
fix: support <meta name=description> in link previews
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Match meta name values case-insensitively** When a page uses a valid case variant such as `<meta name="Description" content="...">`, this new `name` path still leaves `ok` false because `attr.Val` is compared byte-for-byte. Attribu...
fadc974364876abb641f9a0df1d62c1a0ec2560c
badeac12d208238cb429b59470d1568dd81d1ce0
diff --git a/internal/httpgetter/html_meta.go b/internal/httpgetter/html_meta.go index 2e72f1aac8ad6..8a5f31491baa0 100644 --- a/internal/httpgetter/html_meta.go +++ b/internal/httpgetter/html_meta.go @@ -7,6 +7,7 @@ import ( "net" "net/http" "net/url" + "strings" "time" "github.com/pkg/errors" @@ -175,11 +...
[ "internal/httpgetter/html_meta.go" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Match meta name values case-insensitively**\n\nWhen a page uses a valid case variant such as `<meta name=\"Description\" content=\"...\">`, this new `name` path still leaves `ok` false because `attr.Val` is com...
true
usememos/memos
6,000
comment_to_fix
fix: support <meta name=description> in link previews
Because `name` now participates in every `extractMetaProperty` lookup, a later plain `<meta name="description">` can overwrite an earlier `<meta property="og:description">` at lines 179-191. The existing test only covers the opposite order, but Open Graph metadata should keep priority for link previews regardless of ta...
fadc974364876abb641f9a0df1d62c1a0ec2560c
badeac12d208238cb429b59470d1568dd81d1ce0
diff --git a/internal/httpgetter/html_meta.go b/internal/httpgetter/html_meta.go index 2e72f1aac8ad6..8a5f31491baa0 100644 --- a/internal/httpgetter/html_meta.go +++ b/internal/httpgetter/html_meta.go @@ -7,6 +7,7 @@ import ( "net" "net/http" "net/url" + "strings" "time" "github.com/pkg/errors" @@ -175,11 +...
[ "internal/httpgetter/html_meta.go" ]
[ { "comment": "Because `name` now participates in every `extractMetaProperty` lookup, a later plain `<meta name=\"description\">` can overwrite an earlier `<meta property=\"og:description\">` at lines 179-191. The existing test only covers the opposite order, but Open Graph metadata should keep priority for link...
true
usememos/memos
5,985
issue_to_patch
chore(main): release 0.29.1
:robot: I have created a release *beep* *boop* --- ## [0.29.1](https://github.com/usememos/memos/compare/v0.29.0...v0.29.1) (2026-06-04) ### Bug Fixes * **markdown:** keep task item content in one grid column ([7c3bff4](https://github.com/usememos/memos/commit/7c3bff4e98223fb99a5d49f093e3cd57dd140ba4)) * support &...
bb76949fc0d9c954d1a03bc0f4dd7f35f2a5dcb2
e029f8e1910fd647fed453bc9436d9ced1905a90
diff --git a/.release-please-manifest.json b/.release-please-manifest.json index 8316a6de1cee6..712789e13230f 100644 --- a/.release-please-manifest.json +++ b/.release-please-manifest.json @@ -1,3 +1,3 @@ { - ".": "0.29.0" + ".": "0.29.1" } diff --git a/CHANGELOG.md b/CHANGELOG.md index 51f4480bfe726..8832d6eafe4d4...
[ ".release-please-manifest.json", "CHANGELOG.md" ]
[]
true
usememos/memos
5,909
issue_to_patch
chore(main): release 0.29.0
:robot: I have created a release *beep* *boop* --- ## [0.29.0](https://github.com/usememos/memos/compare/v0.28.0...v0.29.0) (2026-05-27) ### Features * **about:** add about page with bird sprites ([411ba7b](https://github.com/usememos/memos/commit/411ba7b34c0c23ad217a7897835097887a28a036)) * **activity-calendar:**...
e0bb3a2e684e932309df2f9fb0ff774ce8e6b692
9d8ad349ea9b5177358d6a1b49d84dcfa4748ce0
diff --git a/.release-please-manifest.json b/.release-please-manifest.json index 9800444892ca3..8316a6de1cee6 100644 --- a/.release-please-manifest.json +++ b/.release-please-manifest.json @@ -1,3 +1,3 @@ { - ".": "0.28.0" + ".": "0.29.0" } diff --git a/CHANGELOG.md b/CHANGELOG.md index 99bd2b5ab9680..51f4480bfe726...
[ ".release-please-manifest.json", "CHANGELOG.md" ]
[]
true
usememos/memos
5,983
issue_to_patch
feat(memo): add task list quick actions
## Summary - Add memo task quick actions for checking all tasks and unchecking all tasks. - Parse GFM task list items with mdast/micromark so code blocks and inline code are ignored. - Re-render memo markdown content when the content changes, independent of update timestamp changes. ## Validation - `cd web && pnpm tes...
e564c1a993ffa2a9568625539d6ff5f0aa3fec7a
3080ba418f02c1ad47d1ed8a15853c8f8bc6d7b8
diff --git a/web/src/components/MemoActionMenu/MemoActionMenu.tsx b/web/src/components/MemoActionMenu/MemoActionMenu.tsx index aaa6d386d6b09..999ef7fb880be 100644 --- a/web/src/components/MemoActionMenu/MemoActionMenu.tsx +++ b/web/src/components/MemoActionMenu/MemoActionMenu.tsx @@ -3,10 +3,13 @@ import { ArchiveRe...
[ "web/src/components/MemoActionMenu/MemoActionMenu.tsx", "web/src/components/MemoActionMenu/hooks.ts", "web/src/components/MemoActionMenu/index.ts", "web/src/components/MemoActionMenu/types.ts", "web/src/components/MemoView/components/MemoBody.tsx", "web/src/locales/en.json", "web/src/utils/markdown-task...
[]
diff --git a/web/tests/markdown-task-actions.test.ts b/web/tests/markdown-task-actions.test.ts new file mode 100644 index 0000000000000..bf5874b0bf1e9 --- /dev/null +++ b/web/tests/markdown-task-actions.test.ts @@ -0,0 +1,38 @@ +import { describe, expect, it } from "vitest"; +import { checkAllTasks, uncheckAllTasks } f...
true
usememos/memos
5,981
issue_to_patch
fix: delete user cleanup
## Summary - Move full user deletion cleanup into per-engine store drivers for SQLite, MySQL, and Postgres. - Keep `Store.DeleteUser` as the single store-level delete API and return collected delete metadata for attachment cleanup. - Quote MySQL `user_setting.key` during delete-user target collection to avoid MariaDB ...
d1208a68e9fadd87536f7f1fc7cba756d8f862a5
1d9c6a2bb5eab271cd4a2e6abfb63f3ea2e54608
diff --git a/server/router/api/v1/auth_service.go b/server/router/api/v1/auth_service.go index 604bd414c80a8..aeb43df6e199e 100644 --- a/server/router/api/v1/auth_service.go +++ b/server/router/api/v1/auth_service.go @@ -189,7 +189,7 @@ func (s *APIV1Service) resolveSSOUser(ctx context.Context, currentUser *store.Us ...
[ "server/router/api/v1/auth_service.go", "server/router/api/v1/test/memo_service_test.go", "server/router/api/v1/test/memo_share_service_test.go", "server/router/api/v1/test/reaction_service_test.go", "server/router/api/v1/test/user_notification_test.go", "server/router/api/v1/user_service.go", "store/at...
[]
diff --git a/server/router/api/v1/test/memo_service_test.go b/server/router/api/v1/test/memo_service_test.go index c07ba269c2914..d9f3fe5d54bef 100644 --- a/server/router/api/v1/test/memo_service_test.go +++ b/server/router/api/v1/test/memo_service_test.go @@ -402,7 +402,7 @@ func TestListMemosSkipsReactionsWithMissing...
true
usememos/memos
5,961
issue_to_patch
API send two case if the memo has a pic ### Pre-submission Checklist - [x] I have searched existing issues and confirmed this has not already been reported - [x] This is a bug report, not a question or configuration request ### Memos Version v0.28.0 ### Environment Details run as docker SQL Edge run on Synology n...
fix: avoid update event on memo create attachments
## Summary - Link initial memo attachments and relations through internal helpers during `CreateMemo`. - Preserve `memo.updated` side effects for explicit attachment/relation updates after creation. - Add a regression test for creating a memo with an initial attachment. ## Root cause `CreateMemo` called `SetMemoAttach...
858f7419b43b36ed76234762d8327ddbaacf1337
bc8ac0c351813cd3ca820182f47dc2c889bc29eb
diff --git a/server/router/api/v1/memo_service.go b/server/router/api/v1/memo_service.go index 086cb6b7a0d55..0a544ddb68f2f 100644 --- a/server/router/api/v1/memo_service.go +++ b/server/router/api/v1/memo_service.go @@ -130,11 +130,7 @@ func (s *APIV1Service) CreateMemo(ctx context.Context, request *v1pb.CreateMemoR ...
[ "server/router/api/v1/memo_service.go", "server/router/api/v1/sse_service_test.go" ]
[]
diff --git a/server/router/api/v1/sse_service_test.go b/server/router/api/v1/sse_service_test.go index 689a35b31b7c9..f7910bcbecc35 100644 --- a/server/router/api/v1/sse_service_test.go +++ b/server/router/api/v1/sse_service_test.go @@ -113,6 +113,48 @@ func TestCreateMemoComment_NoDuplicateSSEBroadcast(t *testing.T) {...
true
usememos/memos
5,250
issue_to_patch
Keyboard Shortcuts not working ### Describe the bug I see that https://www.usememos.com/docs/guides/getting-started#keyboard-shortcuts mentions we can use the listed keyboard shortcuts But in the latest version (0.25.1), none of the shortcuts respond when pressed, which includes: | Shortcut | Expected Action | |:-...
Fix/keyboard shortcuts
Restored the keyboard shortcuts in docs: - Memo editor once again responds to Cmd/Ctrl+Enter and Cmd/Ctrl+S without inserting stray newlines. - Cmd/Ctrl+K now focuses the sidebar search input globally. - Memo cards become focusable and, when selected, support E for inline edit and A for archive, while ignorin...
d1b2c0308b39dca98579b2f8f65706284f4f2221
4bd85ac86d1b9251ca8d903720cd6c8a2604b145
diff --git a/web/src/components/MemoEditor/index.tsx b/web/src/components/MemoEditor/index.tsx index e9868ca75e266..9548d99f8c51f 100644 --- a/web/src/components/MemoEditor/index.tsx +++ b/web/src/components/MemoEditor/index.tsx @@ -151,6 +151,12 @@ const MemoEditor = observer((props: Props) => { const isMetaKey =...
[ "web/src/components/MemoEditor/index.tsx", "web/src/components/MemoView.tsx", "web/src/components/SearchBar.tsx" ]
[ { "comment": "The `archiveMemo` callback is missing dependencies in its dependency array. The callback uses `memoStore` and `userStore` (lines 136 and 144), but these are not included in the dependency array. This could lead to stale closures if these store references ever change.\n\nAdd `memoStore` and `userSt...
true
usememos/memos
5,250
comment_to_fix
Fix/keyboard shortcuts
The `archiveMemo` callback is missing dependencies in its dependency array. The callback uses `memoStore` and `userStore` (lines 136 and 144), but these are not included in the dependency array. This could lead to stale closures if these store references ever change. Add `memoStore` and `userStore` to the dependency a...
d1b2c0308b39dca98579b2f8f65706284f4f2221
4bd85ac86d1b9251ca8d903720cd6c8a2604b145
diff --git a/web/src/components/MemoView.tsx b/web/src/components/MemoView.tsx index 3040084b865ff..3625e06eb4bf0 100644 --- a/web/src/components/MemoView.tsx +++ b/web/src/components/MemoView.tsx @@ -1,6 +1,7 @@ import { BookmarkIcon, EyeOffIcon, MessageCircleMoreIcon } from "lucide-react"; import { observer } from ...
[ "web/src/components/MemoView.tsx" ]
[ { "comment": "The `archiveMemo` callback is missing dependencies in its dependency array. The callback uses `memoStore` and `userStore` (lines 136 and 144), but these are not included in the dependency array. This could lead to stale closures if these store references ever change.\n\nAdd `memoStore` and `userSt...
true
usememos/memos
5,954
issue_to_patch
chore: fix coderabbit logo for light and dark theme
Add light and dark theme logo <img width="1576" height="364" alt="Screenshot 2026-05-14 at 22 08 42" src="https://github.com/user-attachments/assets/4c4f10c2-14a6-42c4-ad15-597c80f7ec4d" />
ab2b08a21e9d8e65316107a4a271bb998d2516ed
c4be4ed720147169cf5cb404f0f6770a9687bf61
diff --git a/README.md b/README.md index 4ca7f673ed883..3b2aeeeb0644b 100644 --- a/README.md +++ b/README.md @@ -11,7 +11,11 @@ </td> <td align="center" width="50%"> <a href="https://coderabbit.link/usememos" target="_blank" rel="noopener"> + <picture> + <source media="(prefers-co...
[ "README.md" ]
[]
true
usememos/memos
5,949
issue_to_patch
feat: add <Placeholder> component with ASCII bird states
## Summary - Adds a new `<Placeholder variant="empty | loading | noResults | notFound">` component that renders a hand-curated ASCII bird from a pool-shaped data file, with subtle CSS-only motion that respects `prefers-reduced-motion`. - Replaces the single-purpose `Empty.tsx` everywhere it was used (`Inboxes.tsx`, `P...
f1e2a06b46c7f45ba6562c308d2703fdfb4067b0
01d6a9bca8a9c28d617fe45cd57f08d1e7b09c85
diff --git a/docs/superpowers/plans/2026-05-12-placeholder-component.md b/docs/superpowers/plans/2026-05-12-placeholder-component.md new file mode 100644 index 0000000000000..8c902b053278e --- /dev/null +++ b/docs/superpowers/plans/2026-05-12-placeholder-component.md @@ -0,0 +1,776 @@ +# Placeholder Component Implement...
[ "docs/superpowers/plans/2026-05-12-placeholder-component.md", "docs/superpowers/specs/2026-05-12-placeholder-component-design.md", "web/src/components/Empty.tsx", "web/src/components/PagedMemoList/PagedMemoList.tsx", "web/src/components/Placeholder/CREDITS.md", "web/src/components/Placeholder/Placeholder....
[]
diff --git a/docs/superpowers/specs/2026-05-12-placeholder-component-design.md b/docs/superpowers/specs/2026-05-12-placeholder-component-design.md new file mode 100644 index 0000000000000..7c12ac6bfb1e7 --- /dev/null +++ b/docs/superpowers/specs/2026-05-12-placeholder-component-design.md @@ -0,0 +1,282 @@ +# Placeholde...
true
usememos/memos
5,934
issue_to_patch
Log level correction ### Pre-submission Checklist - [x] I have searched existing issues and confirmed this has not already been requested - [x] This is a feature request, not a bug report or support question ### Problem or Use Case Every user interaction with any note generating container logs with INFO severity. B...
feat: add configurable --log-level flag
## Summary Closes #5927 Every user interaction currently logs at INFO severity with no way to reduce verbosity. This adds a `--log-level` flag so operators running Memos in Docker can filter noise without rebuilding. - Adds `--log-level` persistent flag with default `info` (debug / info / warn / error) - Env var `ME...
bcbcb03894d0b69104de340fcd5e2de1db7765fd
feb7571d4420d191c01aa802d73fffb5c4a24690
diff --git a/cmd/memos/log.go b/cmd/memos/log.go new file mode 100644 index 0000000000000..3bc5622ac2727 --- /dev/null +++ b/cmd/memos/log.go @@ -0,0 +1,28 @@ +package main + +import ( + "io" + "log/slog" + "strings" + + "github.com/pkg/errors" +) + +func parseSlogLevel(s string) (slog.Level, error) { + switch strings....
[ "cmd/memos/log.go", "cmd/memos/log_test.go", "cmd/memos/main.go" ]
[]
diff --git a/cmd/memos/log_test.go b/cmd/memos/log_test.go new file mode 100644 index 0000000000000..b8d4397c51bb9 --- /dev/null +++ b/cmd/memos/log_test.go @@ -0,0 +1,107 @@ +package main + +import ( + "bytes" + "context" + "log/slog" + "strings" + "testing" +) + +func TestParseSlogLevel(t *testing.T) { + tests := []s...
true
usememos/memos
5,947
issue_to_patch
perf: lazy load heavy first-screen dependencies
## Summary - Lazy-load Home, map UI, profile map, and Mermaid so auth/signup first render does not preload memo/map/diagram dependencies. - Move Leaflet and KaTeX CSS out of the app entry and into feature-loaded paths. - Replace editor-facing Leaflet `LatLng` state with plain `MapPoint` coordinates to keep parent chunk...
7f1f53ffc417962f6930d1e6e3783eacd911003d
54eb553b14cf6176818dd2520664c24628a59c9b
diff --git a/docs/superpowers/plans/2026-05-12-first-screen-lazy-heavy-deps.md b/docs/superpowers/plans/2026-05-12-first-screen-lazy-heavy-deps.md new file mode 100644 index 0000000000000..6aff403b29b61 --- /dev/null +++ b/docs/superpowers/plans/2026-05-12-first-screen-lazy-heavy-deps.md @@ -0,0 +1,774 @@ +# First Scre...
[ "docs/superpowers/plans/2026-05-12-first-screen-lazy-heavy-deps.md", "docs/superpowers/specs/2026-05-12-first-screen-lazy-heavy-deps-design.md", "web/src/components/MemoContent/MemoMarkdownRenderer.tsx", "web/src/components/MemoContent/MermaidBlock.tsx", "web/src/components/MemoEditor/Toolbar/InsertMenu.tsx...
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\nfind web/src -name \"LocationPicker.tsx\" -type f\n```\n\nRepository: usememos/memos\n\nLength of output: 100\n\n---\n\n🏁 Script executed:\n\n```shell\nfind web...
diff --git a/docs/superpowers/specs/2026-05-12-first-screen-lazy-heavy-deps-design.md b/docs/superpowers/specs/2026-05-12-first-screen-lazy-heavy-deps-design.md new file mode 100644 index 0000000000000..ed8dd051251cd --- /dev/null +++ b/docs/superpowers/specs/2026-05-12-first-screen-lazy-heavy-deps-design.md @@ -0,0 +1...
true
usememos/memos
5,947
comment_to_fix
perf: lazy load heavy first-screen dependencies
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell find web/src -name "LocationPicker.tsx" -type f ``` Repository: usememos/memos Length of output: 100 --- 🏁 Script executed: ```shell find web/src -name "LocationMarker*" -type f ``` Re...
7f1f53ffc417962f6930d1e6e3783eacd911003d
54eb553b14cf6176818dd2520664c24628a59c9b
diff --git a/web/src/components/map/LocationPicker.tsx b/web/src/components/map/LocationPicker.tsx index 14513c03cb4da..6fd269e7dc44f 100644 --- a/web/src/components/map/LocationPicker.tsx +++ b/web/src/components/map/LocationPicker.tsx @@ -1,14 +1,19 @@ import L, { LatLng } from "leaflet"; +import "leaflet/dist/leafl...
[ "web/src/components/map/LocationPicker.tsx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\nfind web/src -name \"LocationPicker.tsx\" -type f\n```\n\nRepository: usememos/memos\n\nLength of output: 100\n\n---\n\n🏁 Script executed:\n\n```shell\nfind web...
true
usememos/memos
5,947
comment_to_fix
perf: lazy load heavy first-screen dependencies
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ **Reset diagram state when content is cleared.** When `codeContent` becomes empty, the effect exits without clearing previously rendered output, so stale SVG/error can remain visible. <details> <summary>💡 Proposed fix</summary> ```diff useEffect(() => { - i...
7f1f53ffc417962f6930d1e6e3783eacd911003d
54eb553b14cf6176818dd2520664c24628a59c9b
diff --git a/web/src/components/MemoContent/MermaidBlock.tsx b/web/src/components/MemoContent/MermaidBlock.tsx index c4edc195a0706..48fee0b76cd1e 100644 --- a/web/src/components/MemoContent/MermaidBlock.tsx +++ b/web/src/components/MemoContent/MermaidBlock.tsx @@ -1,4 +1,3 @@ -import mermaid from "mermaid"; import { u...
[ "web/src/components/MemoContent/MermaidBlock.tsx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Reset diagram state when content is cleared.**\n\nWhen `codeContent` becomes empty, the effect exits without clearing previously rendered output, so stale SVG/error can remain visible.\n\n \n<details>\n<summary>💡 Proposed fix</summary>\n\n```...
true
usememos/memos
5,942
issue_to_patch
feat: add dedicated shortcuts page
## Summary - Add an authenticated `/shortcuts` page for listing and managing shortcut filters. - Replace the create/edit shortcut dialog with a shared inline form that supports create and edit flows. - Add expression examples and supported fields guidance that appears only while creating or editing. ## Validation - `p...
02096836c36c4450ef4f45ae4ed5ce83f5bc7f5f
93cde83a8659b92fbe7135d2c5f7794379fb3d6b
diff --git a/web/src/components/CreateShortcutDialog.tsx b/web/src/components/CreateShortcutDialog.tsx deleted file mode 100644 index b32d297e93ef7..0000000000000 --- a/web/src/components/CreateShortcutDialog.tsx +++ /dev/null @@ -1,158 +0,0 @@ -import { create } from "@bufbuild/protobuf"; -import { FieldMaskSchema } f...
[ "web/src/components/CreateShortcutDialog.tsx", "web/src/components/MemoExplorer/ShortcutsSection.tsx", "web/src/pages/Shortcuts.tsx", "web/src/router/index.tsx", "web/src/router/routes.ts" ]
[]
true
usememos/memos
5,940
issue_to_patch
chore: upgrade frontend to React 19
## Summary - Upgrade the Vite SPA frontend to React 19.2 and refresh compatible frontend dependencies. - Add React Compiler integration through Vite 8 `@vitejs/plugin-react` v6, `@rolldown/plugin-babel`, and `reactCompilerPreset()`. - Preserve the existing Biome and TypeScript lint pipeline while updating React 19 typ...
4f0556e23f8863027f2b3b57d64acc2207f040a8
e84f0d832dc09fa1808b9d31781ec847b4aad360
diff --git a/web/package.json b/web/package.json index f36dd85cca167..0ba52cc1c7d50 100644 --- a/web/package.json +++ b/web/package.json @@ -21,7 +21,7 @@ "@connectrpc/connect-web": "^2.1.1", "@emotion/react": "^11.14.0", "@emotion/styled": "^11.14.1", - "@github/relative-time-element": "^4.5.1", + ...
[ "web/package.json", "web/pnpm-lock.yaml", "web/src/components/MemoContent/CodeBlock.tsx", "web/src/components/MemoContent/utils.ts", "web/src/components/MemoEditor/Editor/useListCompletion.ts", "web/src/components/MemoEditor/Editor/useSuggestions.ts", "web/src/components/MemoEditor/types/components.ts",...
[]
true
usememos/memos
5,930
issue_to_patch
chore: update zh-Hant translation
5ccba98adce38642a4fd3dc1b7dc1d0ebaa8709f
cd1d5b7e45144be1e1bc5bbebc4f0d327fa56264
diff --git a/web/src/locales/zh-Hant.json b/web/src/locales/zh-Hant.json index ee892c232f02b..266f3d88b19b8 100644 --- a/web/src/locales/zh-Hant.json +++ b/web/src/locales/zh-Hant.json @@ -3,6 +3,7 @@ "blogs": "部落格", "description": "以隱私為核心的輕量化筆記服務,輕鬆記錄並分享您的好點子。", "documents": "文件", + "media": "媒體", ...
[ "web/src/locales/zh-Hant.json" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Use zh-Hant wording for export action**\n\nLine [401] uses `導出`, which is uncommon in Traditional Chinese UI copy here; `匯出` is more consistent and natural.\n\n \n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n- \"export-memos\...
true
usememos/memos
5,930
comment_to_fix
chore: update zh-Hant translation
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ **Use zh-Hant wording for export action** Line [401] uses `導出`, which is uncommon in Traditional Chinese UI copy here; `匯出` is more consistent and natural. <details> <summary>Suggested fix</summary> ```diff - "export-memos": "導出備忘錄", + "export-memos": "...
5ccba98adce38642a4fd3dc1b7dc1d0ebaa8709f
cd1d5b7e45144be1e1bc5bbebc4f0d327fa56264
diff --git a/web/src/locales/zh-Hant.json b/web/src/locales/zh-Hant.json index ee892c232f02b..266f3d88b19b8 100644 --- a/web/src/locales/zh-Hant.json +++ b/web/src/locales/zh-Hant.json @@ -3,6 +3,7 @@ "blogs": "部落格", "description": "以隱私為核心的輕量化筆記服務,輕鬆記錄並分享您的好點子。", "documents": "文件", + "media": "媒體", ...
[ "web/src/locales/zh-Hant.json" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Use zh-Hant wording for export action**\n\nLine [401] uses `導出`, which is uncommon in Traditional Chinese UI copy here; `匯出` is more consistent and natural.\n\n \n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n- \"export-memos\...
true