repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
uutils/coreutils | 12,752 | issue_to_patch | tail: drop outdated comment about <&- | ```
> tail <&-
tail: cannot fstat 'standard input': Bad file descriptor
tail: no files remaining
``` | 82ff02156ecf2982d61654a0bd7b17ebc4b9fc1a | 85a6df9d0d1fbc2eebed3854852e8196a6bf6252 | diff --git a/src/uu/tail/src/platform/unix.rs b/src/uu/tail/src/platform/unix.rs
index 9f3b96d5101..d980f258cfd 100644
--- a/src/uu/tail/src/platform/unix.rs
+++ b/src/uu/tail/src/platform/unix.rs
@@ -45,12 +45,3 @@ pub fn supports_pid_checks(pid: Pid) -> bool {
Err(_) => true,
}
}
-
-//pub fn stdin_is_b... | [
"src/uu/tail/src/platform/unix.rs"
] | [] | true | ||
uutils/coreutils | 12,668 | issue_to_patch | fold: continue processing files after an open error | Should make test fold/multiple-files.sh pass | 962566b194f3a3ca38cc6eaf2a9aab593a9cd121 | 6ddf485cfa3ea21dea87131104c6fb352c5a079a | diff --git a/src/uu/fold/src/fold.rs b/src/uu/fold/src/fold.rs
index ecd08264f0c..6d10b5c5a2d 100644
--- a/src/uu/fold/src/fold.rs
+++ b/src/uu/fold/src/fold.rs
@@ -13,6 +13,7 @@ use unicode_width::UnicodeWidthChar;
use uucore::display::Quotable;
use uucore::error::{FromIo, UResult, USimpleError};
use uucore::format... | [
"src/uu/fold/src/fold.rs",
"tests/by-util/test_fold.rs"
] | [
{
"comment": "This is a direct copy of `tests/fold/multiple-files.sh` and should therefore be GPLv3+.",
"path": "tests/by-util/test_fold.rs",
"hunk": "@@ -890,44 +890,19 @@ fn test_bytewise_carriage_return_is_not_word_boundary() {\n .stdout_is(\"fizz\\rb\\nuzz\\rfi\\nzzbuzz\"); // spell-checker:... | diff --git a/tests/by-util/test_fold.rs b/tests/by-util/test_fold.rs
index 23ac6c989a7..1981aaa9890 100644
--- a/tests/by-util/test_fold.rs
+++ b/tests/by-util/test_fold.rs
@@ -930,6 +930,21 @@ fn test_bytewise_fold_at_read_buffer_boundary() {
.stdout_is_bytes(expected);
}
+#[test]
+fn test_continue_after_m... | true | |
uutils/coreutils | 12,668 | comment_to_fix | fold: continue processing files after an open error | This is a direct copy of `tests/fold/multiple-files.sh` and should therefore be GPLv3+. | 962566b194f3a3ca38cc6eaf2a9aab593a9cd121 | 6ddf485cfa3ea21dea87131104c6fb352c5a079a | diff --git a/tests/by-util/test_fold.rs b/tests/by-util/test_fold.rs
index 23ac6c989a7..1981aaa9890 100644
--- a/tests/by-util/test_fold.rs
+++ b/tests/by-util/test_fold.rs
@@ -930,6 +930,21 @@ fn test_bytewise_fold_at_read_buffer_boundary() {
.stdout_is_bytes(expected);
}
+#[test]
+fn test_continue_after_m... | [
"tests/by-util/test_fold.rs"
] | [
{
"comment": "This is a direct copy of `tests/fold/multiple-files.sh` and should therefore be GPLv3+.",
"path": "tests/by-util/test_fold.rs",
"hunk": "@@ -890,44 +890,19 @@ fn test_bytewise_carriage_return_is_not_word_boundary() {\n .stdout_is(\"fizz\\rb\\nuzz\\rfi\\nzzbuzz\"); // spell-checker:... | true | ||
uutils/coreutils | 12,746 | issue_to_patch | chore(deps): update rust crate regex to v1.12.4 | This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [regex](https://redirect.github.com/rust-lang/regex) | workspace.dependencies | patch | `1.12.3` → `1.12.4` |
---
### Release Notes
<details>
<summary>rust-lang/regex (regex)</summary>
### [`v1.12.4`](https://redirect.... | d21d02e6ab401637c5d54007b99909d3c81acd8e | ee264f226adfa4ed0bc2767c21d5d68fe5fd5a43 | diff --git a/Cargo.lock b/Cargo.lock
index dd9f31c654..9decf7cc6c 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2470,9 +2470,9 @@ dependencies = [
[[package]]
name = "regex"
-version = "1.12.3"
+version = "1.12.4"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "e10754a14b9137dd7b1e3e5b... | [
"Cargo.lock"
] | [] | true | ||
uutils/coreutils | 12,745 | issue_to_patch | uufuzz: simplify | test code does not need to ban unwrap() | d21d02e6ab401637c5d54007b99909d3c81acd8e | 3f47d143284e97423a0d9440d57db3be998ea410 | diff --git a/fuzz/uufuzz/src/lib.rs b/fuzz/uufuzz/src/lib.rs
index 151a5f71b80..4b39bc3ba6a 100644
--- a/fuzz/uufuzz/src/lib.rs
+++ b/fuzz/uufuzz/src/lib.rs
@@ -69,58 +69,18 @@ where
F: FnOnce(std::vec::IntoIter<OsString>) -> i32 + Send + 'static,
{
// Duplicate the stdout and stderr file descriptors to rest... | [
"fuzz/uufuzz/src/lib.rs"
] | [] | true | ||
uutils/coreutils | 12,730 | issue_to_patch | install panics (unwrap None) when the strip program is killed by a signal
## Summary
`install -s --strip-program=PROG SRC DEST`, where `PROG` is terminated by a signal (rather than exiting normally), makes uutils `install` format the "strip abnormal" error by calling `status.code().unwrap()`. For a signal-terminated ... | install: don't panic when the strip program is killed by a signal | Fixes #12729
`install -s --strip-program=PROG` aborted with an `Option::unwrap()` panic when PROG was terminated by a signal: the strip-failure branch formatted its error with `status.code().unwrap()`, but `ExitStatus::code()` is `None` for a signal-terminated process.
Branch on `status.code()`: keep the existing "ex... | dab93926d25269e0fdbc5445e40b71ee0d44ab8a | ed3d552967d4f6fcb48c897f2115b3a0d48bd311 | diff --git a/src/uu/install/locales/en-US.ftl b/src/uu/install/locales/en-US.ftl
index 34189d86333..a0e9a85351f 100644
--- a/src/uu/install/locales/en-US.ftl
+++ b/src/uu/install/locales/en-US.ftl
@@ -33,6 +33,7 @@ install-error-backup-failed = cannot backup { $from } to { $to }
install-error-install-failed = cannot i... | [
"src/uu/install/locales/en-US.ftl",
"src/uu/install/locales/fr-FR.ftl",
"src/uu/install/src/install.rs",
"tests/by-util/test_install.rs"
] | [] | diff --git a/tests/by-util/test_install.rs b/tests/by-util/test_install.rs
index 81b1c07aae0..88e4ef07c90 100644
--- a/tests/by-util/test_install.rs
+++ b/tests/by-util/test_install.rs
@@ -935,6 +935,26 @@ fn test_install_and_strip_with_invalid_program() {
assert!(!at.file_exists(STRIP_TARGET_FILE));
}
+#[test]... | true |
uutils/coreutils | 12,728 | issue_to_patch | dircolors panics (unwrap Err) on an invalid TERM/COLORTERM glob in a database file
## Summary
`dircolors` panics with `called 'Result::unwrap()' on an 'Err' value` and aborts (exit 134) when a user-supplied database file contains a `TERM`/`COLORTERM` line whose value is an invalid glob (e.g. an unclosed char class `[... | dircolors: don't panic on an invalid TERM/COLORTERM glob | Fixes #12727
A database file with a TERM/COLORTERM line whose value is an invalid glob (e.g. an unclosed `[`) aborted dircolors with a `Result::unwrap()` panic: `fnmatch` did `parse_glob::from_str(pat).unwrap().matches(self)`, and `from_str` returns `Err` for an unparseable pattern.
Use `is_ok_and`, so an invalid glo... | dab93926d25269e0fdbc5445e40b71ee0d44ab8a | 45ef85f562724e5c9a81834a604cce2be45547c0 | diff --git a/src/uu/dircolors/src/dircolors.rs b/src/uu/dircolors/src/dircolors.rs
index 311aa3af9bd..05a30a8eb51 100644
--- a/src/uu/dircolors/src/dircolors.rs
+++ b/src/uu/dircolors/src/dircolors.rs
@@ -310,7 +310,8 @@ impl StrUtils for str {
}
fn fnmatch(&self, pat: &str) -> bool {
- parse_glob::f... | [
"src/uu/dircolors/src/dircolors.rs",
"tests/by-util/test_dircolors.rs"
] | [] | diff --git a/tests/by-util/test_dircolors.rs b/tests/by-util/test_dircolors.rs
index 2be2671af94..871151fe3fc 100644
--- a/tests/by-util/test_dircolors.rs
+++ b/tests/by-util/test_dircolors.rs
@@ -254,3 +254,12 @@ fn test_colorterm_empty_with_wildcard() {
.succeeds()
.stdout_only("LS_COLORS='';\nexpor... | true |
uutils/coreutils | 12,744 | issue_to_patch | gnucompability(fold): uutils fold accept width 0 but gnu fold rejects it
Hi, uutils mainteners
To reproduce that, use simply
```css
relunsec@relunsec:~/software/coreutils/target/debug$ ./fold -w 0 a
```
as i see it not reject it and just outputs indefnitevly empty lines but the gnu version rejects it
```css
reluns... | gnucompability(fold): uutils fold accept width 0 but gnu fold rejects it | This PR resolves #12697. | d21d02e6ab401637c5d54007b99909d3c81acd8e | 54e87c66f90c97468c9c3ed9990771a3c9b7e879 | diff --git a/src/uu/fold/src/fold.rs b/src/uu/fold/src/fold.rs
index ecd08264f0c..97feeeea50b 100644
--- a/src/uu/fold/src/fold.rs
+++ b/src/uu/fold/src/fold.rs
@@ -64,12 +64,21 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
};
let width = match poss_width {
- Some(inp_width) => inp_width... | [
"src/uu/fold/src/fold.rs",
"tests/by-util/test_fold.rs"
] | [
{
"comment": "I would do the zero check in the other match arm, after the parsing. It will allow you to also catch input like `00`.",
"path": "src/uu/fold/src/fold.rs",
"hunk": "@@ -64,6 +64,12 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {\n };\n \n let width = match poss_width {\n+... | diff --git a/tests/by-util/test_fold.rs b/tests/by-util/test_fold.rs
index 23ac6c989a7..6cd85401644 100644
--- a/tests/by-util/test_fold.rs
+++ b/tests/by-util/test_fold.rs
@@ -1033,3 +1033,12 @@ fn test_character_mode_special_chars() {
.stdout_is(expected);
}
}
+
+#[test]
+fn test_width_zero() {
+ ... | true |
uutils/coreutils | 12,744 | comment_to_fix | gnucompability(fold): uutils fold accept width 0 but gnu fold rejects it | I would do the zero check in the other match arm, after the parsing. It will allow you to also catch input like `00`. | d21d02e6ab401637c5d54007b99909d3c81acd8e | 54e87c66f90c97468c9c3ed9990771a3c9b7e879 | diff --git a/src/uu/fold/src/fold.rs b/src/uu/fold/src/fold.rs
index ecd08264f0c..97feeeea50b 100644
--- a/src/uu/fold/src/fold.rs
+++ b/src/uu/fold/src/fold.rs
@@ -64,12 +64,21 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
};
let width = match poss_width {
- Some(inp_width) => inp_width... | [
"src/uu/fold/src/fold.rs"
] | [
{
"comment": "I would do the zero check in the other match arm, after the parsing. It will allow you to also catch input like `00`.",
"path": "src/uu/fold/src/fold.rs",
"hunk": "@@ -64,6 +64,12 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {\n };\n \n let width = match poss_width {\n+... | true | ||
uutils/coreutils | 12,608 | issue_to_patch | rm: hint to use ./-foo when removing a dash-prefixed file | 43536897e4efc90d4792b4122ff393f312482006 | 3335656afb4a8439aadd01a6c4995d7ee565cd97 | diff --git a/src/uu/rm/Cargo.toml b/src/uu/rm/Cargo.toml
index 5ca685ed1e4..d82fc0b3aa9 100644
--- a/src/uu/rm/Cargo.toml
+++ b/src/uu/rm/Cargo.toml
@@ -21,7 +21,7 @@ doctest = false
[dependencies]
thiserror = { workspace = true }
clap = { workspace = true }
-uucore = { workspace = true, features = ["fs", "parser"] ... | [
"src/uu/rm/Cargo.toml",
"src/uu/rm/locales/en-US.ftl",
"src/uu/rm/locales/fr-FR.ftl",
"src/uu/rm/src/rm.rs",
"tests/by-util/test_rm.rs"
] | [
{
"comment": "This is essentially a verbatim copy of what I wrote in `tests/rm/dash-hint.sh`. Please license it under GPLv3+.",
"path": "tests/by-util/test_rm.rs",
"hunk": "@@ -1581,3 +1581,37 @@ fn test_symlink_to_dot_protection() {\n assert!(at.file_exists(\"subdir/file\"));\n assert!(at.file_... | diff --git a/tests/by-util/test_rm.rs b/tests/by-util/test_rm.rs
index 43c712e9c4b..f226c7b3849 100644
--- a/tests/by-util/test_rm.rs
+++ b/tests/by-util/test_rm.rs
@@ -1581,3 +1581,37 @@ fn test_symlink_to_dot_protection() {
assert!(at.file_exists("subdir/file"));
assert!(at.file_exists("topfile"));
}
+
+#[... | true | ||
uutils/coreutils | 12,608 | comment_to_fix | rm: hint to use ./-foo when removing a dash-prefixed file | This is essentially a verbatim copy of what I wrote in `tests/rm/dash-hint.sh`. Please license it under GPLv3+. | 43536897e4efc90d4792b4122ff393f312482006 | 3335656afb4a8439aadd01a6c4995d7ee565cd97 | diff --git a/tests/by-util/test_rm.rs b/tests/by-util/test_rm.rs
index 43c712e9c4b..f226c7b3849 100644
--- a/tests/by-util/test_rm.rs
+++ b/tests/by-util/test_rm.rs
@@ -1581,3 +1581,37 @@ fn test_symlink_to_dot_protection() {
assert!(at.file_exists("subdir/file"));
assert!(at.file_exists("topfile"));
}
+
+#[... | [
"tests/by-util/test_rm.rs"
] | [
{
"comment": "This is essentially a verbatim copy of what I wrote in `tests/rm/dash-hint.sh`. Please license it under GPLv3+.",
"path": "tests/by-util/test_rm.rs",
"hunk": "@@ -1581,3 +1581,37 @@ fn test_symlink_to_dot_protection() {\n assert!(at.file_exists(\"subdir/file\"));\n assert!(at.file_... | true | ||
uutils/coreutils | 12,734 | issue_to_patch | truncate: process all files when one fails | Should make test truncate/multiple-files.sh pass | dab93926d25269e0fdbc5445e40b71ee0d44ab8a | 8a4f18e42e372968c46cf14907d53085b61b04f9 | diff --git a/src/uu/truncate/src/truncate.rs b/src/uu/truncate/src/truncate.rs
index 31a67f5f82a..da69c81c914 100644
--- a/src/uu/truncate/src/truncate.rs
+++ b/src/uu/truncate/src/truncate.rs
@@ -14,6 +14,7 @@ use std::path::Path;
use uucore::display::Quotable;
use uucore::error::{FromIo, UResult, USimpleError, UUsa... | [
"src/uu/truncate/src/truncate.rs",
"tests/by-util/test_truncate.rs"
] | [] | diff --git a/tests/by-util/test_truncate.rs b/tests/by-util/test_truncate.rs
index 11b154b3cd5..5f046ca6880 100644
--- a/tests/by-util/test_truncate.rs
+++ b/tests/by-util/test_truncate.rs
@@ -404,6 +404,19 @@ fn test_no_such_dir() {
.stderr_contains("cannot open 'a/b' for writing: No such file or directory");... | true | |
uutils/coreutils | 12,737 | issue_to_patch | rm: rewrite dash-hint test with original fixtures | 962566b194f3a3ca38cc6eaf2a9aab593a9cd121 | d3232445c46d07279e39041620e7136754eebf84 | diff --git a/src/uu/rm/src/rm.rs b/src/uu/rm/src/rm.rs
index 67a50236183..0f25b517579 100644
--- a/src/uu/rm/src/rm.rs
+++ b/src/uu/rm/src/rm.rs
@@ -298,7 +298,7 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
/// Turn a clap parsing error into a `UError`, reproducing GNU's hint when an
/// unknown `-foo... | [
"src/uu/rm/src/rm.rs",
"tests/by-util/test_rm.rs"
] | [] | diff --git a/tests/by-util/test_rm.rs b/tests/by-util/test_rm.rs
index f226c7b3849..3ac54a3bb58 100644
--- a/tests/by-util/test_rm.rs
+++ b/tests/by-util/test_rm.rs
@@ -1583,35 +1583,38 @@ fn test_symlink_to_dot_protection() {
}
#[test]
-fn test_dash_hint() {
- // `rm -foo` where a file named "-foo" exists: GNU ... | true | ||
uutils/coreutils | 12,738 | issue_to_patch | wc: remove unnecessary .as_fd() | 962566b194f3a3ca38cc6eaf2a9aab593a9cd121 | 596f7e408eabb2368c29d98fc28027d1bebb0c5e | diff --git a/src/uu/wc/src/count_fast.rs b/src/uu/wc/src/count_fast.rs
index 7e8aef5ed63..c4281eac220 100644
--- a/src/uu/wc/src/count_fast.rs
+++ b/src/uu/wc/src/count_fast.rs
@@ -12,8 +12,6 @@ use std::io::{self, ErrorKind, Read};
#[cfg(unix)]
use std::io::{Seek, SeekFrom};
-#[cfg(unix)]
-use std::os::fd::{AsFd, ... | [
"src/uu/wc/src/count_fast.rs",
"src/uu/wc/src/wc.rs"
] | [] | true | |||
uutils/coreutils | 12,740 | issue_to_patch | uucore: remove unnecessary .as_fd() | 962566b194f3a3ca38cc6eaf2a9aab593a9cd121 | d0f45c495d32c104bfb765bcab50ad96ff17516a | diff --git a/src/uucore/src/lib/features/fs.rs b/src/uucore/src/lib/features/fs.rs
index 28544d65711..7cd9041dd62 100644
--- a/src/uucore/src/lib/features/fs.rs
+++ b/src/uucore/src/lib/features/fs.rs
@@ -789,7 +789,7 @@ pub fn is_stdin_directory(stdin: &Stdin) -> bool {
#[cfg(unix)]
{
use mode::{S_I... | [
"src/uucore/src/lib/features/fs.rs",
"src/uucore/src/lib/features/signals.rs"
] | [] | true | |||
v2fly/v2ray-core | 3,748 | issue_to_patch | Chore: bump codecov/codecov-action from 5 to 7 | Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5 to 7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/codecov/codecov-action/releases">codecov/codecov-action's releases</a>.</em></p>
<blockquote>
<h2>v7.0.0</h2>
<p>⚠️ Due to migration issues wi... | 3bfa8a541c62e30a0ea753f83035b0ea7600046c | 2cefd37185c851c02cd5939d32f61e5d7a37416d | diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index a29e3ef2788..23659adeb73 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -49,7 +49,7 @@ jobs:
go test ./... -v -timeout=1h -coverprofile=coverage.out -covermode=atomic
- name: Upload coverage to Co... | [
".github/workflows/test.yml"
] | [] | true | ||
v2fly/v2ray-core | 3,734 | issue_to_patch | Chore: bump github.com/go-chi/chi/v5 from 5.2.5 to 5.3.0 | Bumps [github.com/go-chi/chi/v5](https://github.com/go-chi/chi) from 5.2.5 to 5.3.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/go-chi/chi/releases">github.com/go-chi/chi/v5's releases</a>.</em></p>
<blockquote>
<h2>v5.3.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Use strings... | 59950bd0b02c482ee88f4c7fe1aeb1e48db7e286 | 8204fb0809d44725623d5846c5b8e87ae0133feb | diff --git a/go.mod b/go.mod
index febae28ab77..04fec4f75f2 100644
--- a/go.mod
+++ b/go.mod
@@ -7,7 +7,7 @@ toolchain go1.26.1
require (
github.com/adrg/xdg v0.5.3
github.com/apernet/quic-go v0.59.1-0.20260217092621-db4786c77a22
- github.com/go-chi/chi/v5 v5.2.5
+ github.com/go-chi/chi/v5 v5.3.0
github.com/go-c... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 3,736 | issue_to_patch | v5版本中通过nginx代理后access.log文件中源IP为127.0.0.1
vmess+httpupdate+tls+nginx V5版配置文件运行，access.log内只能获取到127.0.0.1的源IP 。
但是同样的客户端和nginx配置vmess+websocket+tls+nginx V4版配置文件运行就能获取到真实的客户端IP。 | Fix v4 X-Forwarded-For transport config | ## Summary
Fixes #3329.
Fix legacy v4 JSON config handling for `parseXForwardedFor` on WebSocket and HTTP transports.
After the transport-level `parse_x_forwarded_for` gate was added, v4 JSON configs could not actually enable it through `wsSettings` or `httpSettings`. As a result, access logs continued to show t... | 59950bd0b02c482ee88f4c7fe1aeb1e48db7e286 | 9eb150181d360d0a84312aebe0b52f1e6814f430 | diff --git a/infra/conf/v4/transport_internet.go b/infra/conf/v4/transport_internet.go
index 9a47f2ad3f8..c2c13463493 100644
--- a/infra/conf/v4/transport_internet.go
+++ b/infra/conf/v4/transport_internet.go
@@ -172,6 +172,7 @@ type WebSocketConfig struct {
MaxEarlyData int32 `json:"maxEarlyData"... | [
"infra/conf/v4/transport_internet.go",
"infra/conf/v4/transport_test.go"
] | [] | diff --git a/infra/conf/v4/transport_test.go b/infra/conf/v4/transport_test.go
index 1eddc3fc2d3..4a2ac7ac65e 100644
--- a/infra/conf/v4/transport_test.go
+++ b/infra/conf/v4/transport_test.go
@@ -16,6 +16,7 @@ import (
"github.com/v2fly/v2ray-core/v5/transport/internet/headers/http"
"github.com/v2fly/v2ray-core/v5... | true |
v2fly/v2ray-core | 3,737 | issue_to_patch | Add X-Forwarded-For support to gRPC transport | Add a gated parseXForwardedFor option to gRPC transport config and use incoming x-forwarded-for metadata for the connection remote address when enabled.
Wire the option through legacy v4 grpc/gun settings and add v4, v5, and gRPC encoding coverage. | 59950bd0b02c482ee88f4c7fe1aeb1e48db7e286 | f395c97c1aeb2f6d33577ef8ba4de13041e0dd0c | diff --git a/infra/conf/v4/gun.go b/infra/conf/v4/gun.go
index e533a6e7614..dede174332f 100644
--- a/infra/conf/v4/gun.go
+++ b/infra/conf/v4/gun.go
@@ -12,6 +12,7 @@ type GunConfig struct {
HealthCheckTimeout int32 `json:"health_check_timeout"`
PermitWithoutStream bool `json:"permit_without_stream"`
InitialW... | [
"infra/conf/v4/gun.go",
"infra/conf/v4/transport_test.go",
"infra/conf/v5cfg/stream_test.go",
"transport/internet/grpc/config.pb.go",
"transport/internet/grpc/config.proto",
"transport/internet/grpc/dial.go",
"transport/internet/grpc/encoding/conn.go",
"transport/internet/grpc/encoding/conn_test.go",
... | [] | diff --git a/infra/conf/v4/transport_test.go b/infra/conf/v4/transport_test.go
index 1eddc3fc2d3..ee15937fe67 100644
--- a/infra/conf/v4/transport_test.go
+++ b/infra/conf/v4/transport_test.go
@@ -13,6 +13,7 @@ import (
v4 "github.com/v2fly/v2ray-core/v5/infra/conf/v4"
"github.com/v2fly/v2ray-core/v5/transport"
"... | true | |
v2fly/v2ray-core | 3,726 | issue_to_patch | Mismatch between digset in the "Release" file and independent/actual for zip file releases
## What version of V2Ray are you using?
The mismatch occurs for at least release 5.15.3 and 5.16.1.
## What's your scenario of using V2Ray?
Steps to reproduce:
1. Go to, say https://github.com/v2fly/v2ray-core/releas... | ci: fix release artifacts hash mismatch | # ci: fix release artifacts hash mismatch
The signed `Release` file's SHA256 entries don't match the actually-downloadable zip artifacts (reproducible on every recent release, e.g. v5.49.0's `v2ray-windows-64.zip` is `1a535fa7...` but `Release` says `29a212d1...`).
Root cause: `release.yml` triggers on both `prerelea... | 46f9b8dfb2ff848329cb73a146c7f7630128766f | a6c54c8a6f2ade2eae4d6ae36414ae8137c97d4d | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index c726398a487..3c3b3c53bf5 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -25,6 +25,8 @@ on:
jobs:
build:
+ # Run on push/PR and on prereleased; skip on released to avoid overwriting prerelease zip... | [
".github/workflows/release.yml"
] | [] | true | |
v2fly/v2ray-core | 3,728 | issue_to_patch | gdocsviewer: allow adding headers in public config | This pull request export the additional header config in public facing transport config.
----
This pull request introduces support for custom request headers in the GDocsViewer transport configuration. The main changes add a `request_headers` map field to the configuration, update the code to propagate this field, ... | 0c35ff1a220f1430170c04b9d542a66a4e52e4d3 | e289386451158b177675eb39d22c7e489bc71e3f | diff --git a/common/protofilter/filter.go b/common/protofilter/filter.go
index 521d0d1c428..d088e044bd1 100644
--- a/common/protofilter/filter.go
+++ b/common/protofilter/filter.go
@@ -68,7 +68,7 @@ func filterMessage(ctx context.Context, message protoreflect.Message) error {
switch descriptor.Kind() {
case proto... | [
"common/protofilter/filter.go",
"transport/internet/request/stereotype/gdocsviewer/config.pb.go",
"transport/internet/request/stereotype/gdocsviewer/config.proto",
"transport/internet/request/stereotype/gdocsviewer/gdocsviewer.go",
"transport/internet/request/stereotype/gdocsviewer/gdocsviewer_test.go"
] | [] | diff --git a/transport/internet/request/stereotype/gdocsviewer/gdocsviewer_test.go b/transport/internet/request/stereotype/gdocsviewer/gdocsviewer_test.go
index 1463075e0ab..65631cef535 100644
--- a/transport/internet/request/stereotype/gdocsviewer/gdocsviewer_test.go
+++ b/transport/internet/request/stereotype/gdocsvi... | true | |
v2fly/v2ray-core | 3,727 | issue_to_patch | GDocsViewer: Refine poll logic and allow custom headers to reduce rate limiting | This merge requests adds custom header support for GDocsViewer to reduce rate limiting, and refined polling parameters.
----------------
[Machine Generated]
This pull request introduces several improvements and new features to the simple assembler transport and the GDocsViewer roundtripper. The main changes are th... | 46f9b8dfb2ff848329cb73a146c7f7630128766f | 26e8ac5e937cd71ca2bd1d7855789173a9cd5349 | diff --git a/transport/internet/request/assembler/simple/client.go b/transport/internet/request/assembler/simple/client.go
index b1377c09e43..1dad5f97030 100644
--- a/transport/internet/request/assembler/simple/client.go
+++ b/transport/internet/request/assembler/simple/client.go
@@ -54,7 +54,7 @@ type simpleAssemblerC... | [
"transport/internet/request/assembler/simple/client.go",
"transport/internet/request/assembler/simple/config.pb.go",
"transport/internet/request/assembler/simple/config.proto",
"transport/internet/request/assembler/simple/server.go",
"transport/internet/request/roundtripper/gdocsviewer/config.pb.go",
"tra... | [] | diff --git a/transport/internet/request/roundtripper/gdocsviewer/gdocsviewer_test.go b/transport/internet/request/roundtripper/gdocsviewer/gdocsviewer_test.go
index 718d3e998c5..2f9a7fb5ab9 100644
--- a/transport/internet/request/roundtripper/gdocsviewer/gdocsviewer_test.go
+++ b/transport/internet/request/roundtripper... | true | |
v2fly/v2ray-core | 3,725 | issue_to_patch | Add Google Docs Viewer based transport | This pull request adds a Google Docs Viewer based transport based on the tunnel method utilized in https://github.com/0xinf0/gdocs-tunnel.
This tunnel method has been tested to work correctly in Iran without requiring special network position, however, due to its slowness, it is not suitable in environments where ot... | 8db99ba5b9636e9b0e379bd6abe06b814b007b27 | 72383327e515fd7eef089f161acd875e338e5d8f | diff --git a/main/distro/all/all.go b/main/distro/all/all.go
index 5357a05f79e..459fda901c1 100644
--- a/main/distro/all/all.go
+++ b/main/distro/all/all.go
@@ -74,10 +74,12 @@ import (
_ "github.com/v2fly/v2ray-core/v5/transport/internet/request/assembly"
_ "github.com/v2fly/v2ray-core/v5/transport/internet/requ... | [
"main/distro/all/all.go",
"transport/internet/request/roundtripper/gdocsviewer/config.pb.go",
"transport/internet/request/roundtripper/gdocsviewer/config.proto",
"transport/internet/request/roundtripper/gdocsviewer/errors.generated.go",
"transport/internet/request/roundtripper/gdocsviewer/gdocsviewer.go",
... | [
{
"comment": "## CodeQL / Size computation for allocation may overflow\n\nThis operation, which is used in an [allocation](1), involves a [potentially large value](2) and might overflow.\nThis operation, which is used in an [allocation](1), involves a [potentially large value](3) and might overflow.\nThis opera... | diff --git a/transport/internet/request/roundtripper/gdocsviewer/gdocsviewer_test.go b/transport/internet/request/roundtripper/gdocsviewer/gdocsviewer_test.go
new file mode 100644
index 00000000000..718d3e998c5
--- /dev/null
+++ b/transport/internet/request/roundtripper/gdocsviewer/gdocsviewer_test.go
@@ -0,0 +1,670 @@... | true | |
v2fly/v2ray-core | 3,688 | issue_to_patch | Chore: bump github.com/pires/go-proxyproto from 0.11.0 to 0.12.0 | Bumps [github.com/pires/go-proxyproto](https://github.com/pires/go-proxyproto) from 0.11.0 to 0.12.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/pires/go-proxyproto/releases">github.com/pires/go-proxyproto's releases</a>.</em></p>
<blockquote>
<h2>v0.12.0</h2>
<h2>What's ... | 9ca038324f7116033a5826727f9ab5c91de473bc | 3cc87f5f94a6d56dc7e08f382da6710f08eb58bc | diff --git a/go.mod b/go.mod
index 81215f13272..febae28ab77 100644
--- a/go.mod
+++ b/go.mod
@@ -29,7 +29,7 @@ require (
github.com/pion/transport/v2 v2.2.10
github.com/pion/transport/v4 v4.0.1
github.com/pion/webrtc/v4 v4.2.12
- github.com/pires/go-proxyproto v0.11.0
+ github.com/pires/go-proxyproto v0.12.0
gi... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 3,715 | issue_to_patch | Chore: bump google.golang.org/grpc from 1.80.0 to 1.81.1 | Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.80.0 to 1.81.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases">google.golang.org/grpc's releases</a>.</em></p>
<blockquote>
<h2>Release 1.81.1</h2>
<h1>Security</h1>
<ul>
<li>xds/rba... | 41d3a03cecd08f39b8a6de6f2df6519e28352987 | 9e0cecbaa256e2cf4872cabdcb4b105a11746471 | diff --git a/go.mod b/go.mod
index 00db7583598..774bd451956 100644
--- a/go.mod
+++ b/go.mod
@@ -50,7 +50,7 @@ require (
golang.org/x/sync v0.20.0
golang.org/x/sys v0.44.0
golang.zx2c4.com/wireguard v0.0.0-20250521234502-f333402bd9cb
- google.golang.org/grpc v1.80.0
+ google.golang.org/grpc v1.81.1
google.golan... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 3,706 | issue_to_patch | Chore: bump github.com/pion/webrtc/v4 from 4.2.11 to 4.2.12 | Bumps [github.com/pion/webrtc/v4](https://github.com/pion/webrtc) from 4.2.11 to 4.2.12.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/pion/webrtc/releases">github.com/pion/webrtc/v4's releases</a>.</em></p>
<blockquote>
<h2>v4.2.12</h2>
<h2>Changelog</h2>
<ul>
<li>8e210ec04... | 41d3a03cecd08f39b8a6de6f2df6519e28352987 | 91b4571f4a8dc47fe0b84aed6b13511da69a1336 | diff --git a/go.mod b/go.mod
index 00db7583598..68950e938cc 100644
--- a/go.mod
+++ b/go.mod
@@ -23,12 +23,12 @@ require (
github.com/mustafaturan/bus v1.0.2
github.com/pelletier/go-toml v1.9.5
github.com/pion/dtls/v3 v3.1.2
- github.com/pion/ice/v4 v4.2.2
+ github.com/pion/ice/v4 v4.2.5
github.com/pion/logging... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 3,704 | issue_to_patch | Chore: bump github.com/xssnick/raptorq from 1.3.0 to 1.4.0 | Bumps [github.com/xssnick/raptorq](https://github.com/xssnick/raptorq) from 1.3.0 to 1.4.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/xssnick/raptorq/releases">github.com/xssnick/raptorq's releases</a>.</em></p>
<blockquote>
<h2>v1.4.0</h2>
<ul>
<li>Store fast symbols in... | 05cc5424631413ada31d14c27b06fd828cf2e5f4 | 5fd16c2b60ce4f7beee3adf88862d7ed8d26db91 | diff --git a/go.mod b/go.mod
index 58d4ef31353..977813e21e5 100644
--- a/go.mod
+++ b/go.mod
@@ -41,7 +41,7 @@ require (
github.com/v2fly/struc v0.0.0-20241227015403-8e8fa1badfd6
github.com/vincent-petithory/dataurl v1.0.0
github.com/xiaokangwang/VLite v0.0.0-20220418190619-cff95160a432
- github.com/xssnick/rapto... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 3,723 | issue_to_patch | Chore: bump github.com/quic-go/quic-go from 0.59.0 to 0.59.1 | Bumps [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) from 0.59.0 to 0.59.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/quic-go/quic-go/releases">github.com/quic-go/quic-go's releases</a>.</em></p>
<blockquote>
<h2>v0.59.1</h2>
<p>This patch release backp... | 05cc5424631413ada31d14c27b06fd828cf2e5f4 | 2a5058c7e38de68b47880686a002d6be5f1d58e5 | diff --git a/go.mod b/go.mod
index 58d4ef31353..52146c31336 100644
--- a/go.mod
+++ b/go.mod
@@ -30,7 +30,7 @@ require (
github.com/pion/transport/v4 v4.0.1
github.com/pion/webrtc/v4 v4.2.11
github.com/pires/go-proxyproto v0.11.0
- github.com/quic-go/quic-go v0.59.0
+ github.com/quic-go/quic-go v0.59.1
github.c... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 3,719 | issue_to_patch | Chore: bump golang.org/x/net from 0.53.0 to 0.54.0 | Bumps [golang.org/x/net](https://github.com/golang/net) from 0.53.0 to 0.54.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/golang/net/commit/b138e06246cb323f2f380c2b7f7dd91f581dd56b"><code>b138e06</code></a> go.mod: update golang.org/x dependencies</li>
<li><a href="https://github.com/gola... | 05cc5424631413ada31d14c27b06fd828cf2e5f4 | 312d0bd3e70bfd6b5d66eb9843fcfd4a9ae687b8 | diff --git a/go.mod b/go.mod
index 58d4ef31353..20a1656bb1c 100644
--- a/go.mod
+++ b/go.mod
@@ -45,10 +45,10 @@ require (
github.com/xtaci/smux v1.5.24
go.starlark.net v0.0.0-20230612165344-9532f5667272
go4.org/netipx v0.0.0-20230303233057-f1b76eb4bb35
- golang.org/x/crypto v0.50.0
- golang.org/x/net v0.53.0
+ g... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 3,654 | issue_to_patch | feat: grpc: allow configurable keepalive and initial windows size | added configuration options:
- idle_timeout
- health_check_timeout
- permit_without_stream
- initial_windows_size
acknowledge:
- https://github.com/XTLS/Xray-core
- https://xtls.github.io/en/config/transports/grpc.html | fbff1421bf27cc8c54b34a2f8e580f7f8ab3253a | 29cdb33b85020a7119c2de5950195c0c5086453e | diff --git a/infra/conf/v4/gun.go b/infra/conf/v4/gun.go
index 059e3b4c407..e533a6e7614 100644
--- a/infra/conf/v4/gun.go
+++ b/infra/conf/v4/gun.go
@@ -7,9 +7,28 @@ import (
)
type GunConfig struct {
- ServiceName string `json:"serviceName"`
+ ServiceName string `json:"serviceName"`
+ IdleTimeout i... | [
"infra/conf/v4/gun.go",
"transport/internet/grpc/config.pb.go",
"transport/internet/grpc/config.proto",
"transport/internet/grpc/dial.go"
] | [] | true | ||
v2fly/v2ray-core | 1,302 | issue_to_patch | Fix some tests to use udp.PickPort() | https://github.com/XTLS/Xray-core/pull/739 | deb9d08487501e73c6693fb0ac90bd91952cb1a6 | 418b4996eaa144da57508f9cca39eec02ef11d79 | [
"testing/scenarios/dokodemo_test.go",
"testing/scenarios/feature_test.go",
"testing/scenarios/shadowsocks_test.go",
"testing/scenarios/transport_test.go",
"testing/scenarios/vmess_test.go"
] | [] | diff --git a/testing/scenarios/dokodemo_test.go b/testing/scenarios/dokodemo_test.go
index 0fcc21a063f..a63b859500d 100644
--- a/testing/scenarios/dokodemo_test.go
+++ b/testing/scenarios/dokodemo_test.go
@@ -156,7 +156,7 @@ func TestDokodemoUDP(t *testing.T) {
},
}
- clientPort := uint32(tcp.PickPort())
+ clien... | true | ||
v2fly/v2ray-core | 1 | issue_to_patch | enable TLS 1.3 by default | 7460f61f39c051f40ef2a3254630168556f0bd1c | 15c0e975ca66cc8ce3fb96e2943d04fb8b7a42de | diff --git a/transport/internet/tls/tls.go b/transport/internet/tls/tls.go
index dd9a0bb8095..dea950d1508 100644
--- a/transport/internet/tls/tls.go
+++ b/transport/internet/tls/tls.go
@@ -4,6 +4,7 @@ package tls
import (
"crypto/tls"
+ "os"
"v2ray.com/core/common/buf"
"v2ray.com/core/common/net"
@@ -65,3 +6... | [
"transport/internet/tls/tls.go"
] | [] | true | |||
v2fly/v2ray-core | 3,676 | issue_to_patch | also parse X-Forwarded-For in httpupgrade | logic copied from transport/internet/websocket/hub.go
but just before i submit pr. i found someone did a exact pr few month ago (#3608). so i added a option to control parse address from X-Forwarded-For. as requested in https://github.com/v2fly/v2ray-core/pull/3608#issuecomment-3870670015 | 044994a96e28b031a76b9b90420d006fbdbdbf7e | 839a732bd7ba633d1bbd1502e880f5708a615334 | diff --git a/transport/internet/http/config.pb.go b/transport/internet/http/config.pb.go
index af0017874de..a620e9dd9d1 100644
--- a/transport/internet/http/config.pb.go
+++ b/transport/internet/http/config.pb.go
@@ -1,3 +1,9 @@
+// Code generated by protoc-gen-go. DO NOT EDIT.
+// versions:
+// protoc-gen-go v1.36.11... | [
"transport/internet/http/config.pb.go",
"transport/internet/http/config.proto",
"transport/internet/http/hub.go",
"transport/internet/httpupgrade/config.pb.go",
"transport/internet/httpupgrade/config.proto",
"transport/internet/httpupgrade/connection.go",
"transport/internet/httpupgrade/hub.go",
"tran... | [] | true | ||
v2fly/v2ray-core | 3,661 | issue_to_patch | Chore: bump github.com/go-playground/validator/v10 from 10.30.1 to 10.30.2 | Bumps [github.com/go-playground/validator/v10](https://github.com/go-playground/validator) from 10.30.1 to 10.30.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/go-playground/validator/releases">github.com/go-playground/validator/v10's releases</a>.</em></p>
<blockquote>
<h... | d1e2c2391a653255fe61687a6394d3457cdd3dea | 0810e66d709fbcba15924e0ea946543b806f2e8c | diff --git a/go.mod b/go.mod
index 02d38b1f850..b12e75c0078 100644
--- a/go.mod
+++ b/go.mod
@@ -9,7 +9,7 @@ require (
github.com/apernet/quic-go v0.59.1-0.20260217092621-db4786c77a22
github.com/go-chi/chi/v5 v5.2.5
github.com/go-chi/render v1.0.3
- github.com/go-playground/validator/v10 v10.30.1
+ github.com/go-... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 3,665 | issue_to_patch | Chore: bump google.golang.org/grpc from 1.79.3 to 1.80.0 | Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.79.3 to 1.80.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases">google.golang.org/grpc's releases</a>.</em></p>
<blockquote>
<h2>Release 1.80.0</h2>
<h1>Behavior Changes</h1>
<ul>
<li... | 044994a96e28b031a76b9b90420d006fbdbdbf7e | 21c35e098ca66f40f2cc05cd719f978f26517d8b | diff --git a/go.mod b/go.mod
index 62b08f16238..fb96ed60163 100644
--- a/go.mod
+++ b/go.mod
@@ -50,7 +50,7 @@ require (
golang.org/x/sync v0.20.0
golang.org/x/sys v0.43.0
golang.zx2c4.com/wireguard v0.0.0-20250521234502-f333402bd9cb
- google.golang.org/grpc v1.79.3
+ google.golang.org/grpc v1.80.0
google.golan... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 3,666 | issue_to_patch | Chore: bump github.com/pion/stun/v3 from 3.1.1 to 3.1.2 | Bumps [github.com/pion/stun/v3](https://github.com/pion/stun) from 3.1.1 to 3.1.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/pion/stun/releases">github.com/pion/stun/v3's releases</a>.</em></p>
<blockquote>
<h2>v3.1.2</h2>
<h2>Changelog</h2>
<ul>
<li>f927db87cf42b1a39cb2... | cbab1db9f705129ab85d03c991b91ce067963aed | cb636b4c0b94f6d61304b7a3d3c8866e013784d8 | diff --git a/go.mod b/go.mod
index d3339c703f8..6ad19900777 100644
--- a/go.mod
+++ b/go.mod
@@ -25,7 +25,7 @@ require (
github.com/pion/dtls/v3 v3.1.2
github.com/pion/ice/v4 v4.2.2
github.com/pion/logging v0.2.4
- github.com/pion/stun/v3 v3.1.1
+ github.com/pion/stun/v3 v3.1.2
github.com/pion/transport/v2 v2.2... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 3,672 | issue_to_patch | Chore: bump golang.org/x/net from 0.52.0 to 0.53.0 | Bumps [golang.org/x/net](https://github.com/golang/net) from 0.52.0 to 0.53.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/golang/net/commit/a8d1fc14d9e33e1f6842ab78a0127d42cd8fff44"><code>a8d1fc1</code></a> go.mod: update golang.org/x dependencies</li>
<li><a href="https://github.com/gola... | 044994a96e28b031a76b9b90420d006fbdbdbf7e | 718d41425cc788ae200493e57a9506fc6a282492 | diff --git a/go.mod b/go.mod
index 62b08f16238..817d263d055 100644
--- a/go.mod
+++ b/go.mod
@@ -46,7 +46,7 @@ require (
go.starlark.net v0.0.0-20230612165344-9532f5667272
go4.org/netipx v0.0.0-20230303233057-f1b76eb4bb35
golang.org/x/crypto v0.50.0
- golang.org/x/net v0.52.0
+ golang.org/x/net v0.53.0
golang.o... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 3,673 | issue_to_patch | Chore: bump golang.org/x/crypto from 0.49.0 to 0.50.0 | Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.49.0 to 0.50.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/golang/crypto/commit/03ca0dcccbd37ba6be80adf74dde8d78a4d72817"><code>03ca0dc</code></a> go.mod: update golang.org/x dependencies</li>
<li><a href="https://github... | cbab1db9f705129ab85d03c991b91ce067963aed | e0575c3dc60b233a2d5863060ecd7fc6929e384f | diff --git a/go.mod b/go.mod
index d3339c703f8..62b08f16238 100644
--- a/go.mod
+++ b/go.mod
@@ -45,10 +45,10 @@ require (
github.com/xtaci/smux v1.5.24
go.starlark.net v0.0.0-20230612165344-9532f5667272
go4.org/netipx v0.0.0-20230303233057-f1b76eb4bb35
- golang.org/x/crypto v0.49.0
+ golang.org/x/crypto v0.50.0
... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 3,130 | issue_to_patch | fix: use sync.Map in request transpot's packet conn server | This pull request fixes the issue within packet conn server, where a map is accessed without protection.
Thanks @dyhkwong for reporting this bug.
```
fatal error: concurrent map read and map write
goroutine 4895 [running]:
github.com/v2fly/v2ray-core/v5/transport/internet/request/assembler/packetconn.(*reque... | ae4b7733eeffc6496040b5ace936d14684b07ed6 | 8ba512ce5f2b5b64bf15ea9d7a56e03335779241 | diff --git a/transport/internet/request/assembler/packetconn/req2packet.go b/transport/internet/request/assembler/packetconn/req2packet.go
index baf12c366d8..c8e7e881ad9 100644
--- a/transport/internet/request/assembler/packetconn/req2packet.go
+++ b/transport/internet/request/assembler/packetconn/req2packet.go
@@ -5,6... | [
"transport/internet/request/assembler/packetconn/req2packet.go"
] | [] | true | ||
v2fly/v2ray-core | 3,660 | issue_to_patch | Add WebRTC Tunnel Support in V2Ray | [Machine Generated]
This pull request introduces a new WebRTC active listener implementation for the project, including protocol buffer definitions, network abstraction layers, error handling, frame encoding/decoding, and comprehensive unit tests. The changes add foundational support for active WebRTC listeners with a... | d1e2c2391a653255fe61687a6394d3457cdd3dea | 1c474e6376f6bac027e3dc4449712441f7ba1b25 | diff --git a/app/webrtc/active_listener_net.go b/app/webrtc/active_listener_net.go
new file mode 100644
index 00000000000..0f168ebd7b6
--- /dev/null
+++ b/app/webrtc/active_listener_net.go
@@ -0,0 +1,81 @@
+package webrtc
+
+import (
+ "net"
+ "sync"
+
+ piontransport "github.com/pion/transport/v4"
+ "github.com/pion/t... | [
"app/webrtc/active_listener_net.go",
"app/webrtc/config.pb.go",
"app/webrtc/config.proto",
"app/webrtc/connect_via_net.go",
"app/webrtc/errors.generated.go",
"app/webrtc/frame.go",
"app/webrtc/frame_test.go",
"app/webrtc/listener.go",
"app/webrtc/listener_test.go",
"app/webrtc/message.pb.go",
"a... | [] | diff --git a/app/webrtc/frame_test.go b/app/webrtc/frame_test.go
new file mode 100644
index 00000000000..2d4eb281064
--- /dev/null
+++ b/app/webrtc/frame_test.go
@@ -0,0 +1,69 @@
+package webrtc
+
+import "testing"
+
+func TestWireFrameRoundTrip(t *testing.T) {
+ t.Run("open", func(t *testing.T) {
+ encoded := encodeW... | true | |
v2fly/v2ray-core | 2,316 | issue_to_patch | Chore: bump golang.org/x/crypto from 0.4.0 to 0.6.0 | Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.4.0 to 0.6.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/golang/crypto/commit/a9f661cb6e1b78478731da332a7b82f1e2fd779c"><code>a9f661c</code></a> go.mod: update golang.org/x dependencies</li>
<li><a href="https://github.c... | 1aac75c8bc628cb45f68ec71c45cd436167a07c2 | c3d35fba55aa857831680acef579294c80985d99 | diff --git a/go.mod b/go.mod
index 1991602a521..c9c9d02a36e 100644
--- a/go.mod
+++ b/go.mod
@@ -28,10 +28,10 @@ require (
github.com/xiaokangwang/VLite v0.0.0-20220418190619-cff95160a432
go.starlark.net v0.0.0-20220817180228-f738f5508c12
go4.org/netipx v0.0.0-20220812043211-3cc044ffd68d
- golang.org/x/crypto v0.... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 1,338 | issue_to_patch | Chore: bump github.com/lucas-clemente/quic-go from 0.23.0 to 0.24.0 | Bumps [github.com/lucas-clemente/quic-go](https://github.com/lucas-clemente/quic-go) from 0.23.0 to 0.24.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/lucas-clemente/quic-go/commit/b935a54c295e2a91e21302c3e48cb46646d635b8"><code>b935a54</code></a> Merge pull request <a href="https://githu... | 5931240fb19b2f1b42cba834ddb9e9f499526b25 | 8af8401aef2e0a20384556015ba3d3aea6d4cb6a | diff --git a/go.mod b/go.mod
index 6e25d5696f0..aa5f99b534c 100644
--- a/go.mod
+++ b/go.mod
@@ -11,7 +11,7 @@ require (
github.com/google/go-cmp v0.5.6
github.com/gorilla/websocket v1.4.2
github.com/jhump/protoreflect v1.9.0
- github.com/lucas-clemente/quic-go v0.23.0
+ github.com/lucas-clemente/quic-go v0.24.0
... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 1,183 | issue_to_patch | fix: dns cache with empty response | this provides a fix that the dns app won't do cache with the IPRecord with a empty address (len(rec.IP == 0)).
```
[v2ray] [Info] v2ray.com/core/app/dns: DOHL//dns.google got answer: x.xxx. TypeA -> []
[v2ray] [Info] v2ray.com/core/app/dns: DOHL//dns.google cache HIT x.xxx -> [] > empty response
```
extensive ... | ecaf597a76017dd0492bf3ee3ce636ccaf5a5161 | b08d67f60748fc404cd6219bf3ef4f3d4c026e20 | diff --git a/app/dns/dnscommon.go b/app/dns/dnscommon.go
index 239e04c2101..07907b1ba53 100644
--- a/app/dns/dnscommon.go
+++ b/app/dns/dnscommon.go
@@ -213,7 +213,7 @@ L:
case dnsmessage.TypeAAAA:
ans, err := parser.AAAAResource()
if err != nil {
- newError("failed to parse A record for domain: ", ah.Nam... | [
"app/dns/dnscommon.go",
"app/dns/nameserver_doh.go",
"app/dns/nameserver_quic.go",
"app/dns/nameserver_tcp.go",
"app/dns/nameserver_udp.go"
] | [
{
"comment": "I found a bug that might caused by this changes. The program may wait until the context timeout if the records are empty, and return this error:\r\n```\r\n[Info] app/dns: failed to lookup ip for domain api.twitter.com at server DOH//9.9.9.9 > context deadline exceeded\r\n[Info] proxy/dns: ip query... | true | ||
v2fly/v2ray-core | 1,892 | issue_to_patch | Chore: bump google.golang.org/protobuf from 1.28.0 to 1.28.1 | Bumps [google.golang.org/protobuf](https://github.com/protocolbuffers/protobuf-go) from 1.28.0 to 1.28.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/protocolbuffers/protobuf-go/releases">google.golang.org/protobuf's releases</a>.</em></p>
<blockquote>
<h2>v1.28.1</h2>
<p>... | 01104c2e06a367fadf75140ee8ba88e471407c73 | a18679dfd963a6ba6944ad5947242b3d12a6ed09 | diff --git a/go.mod b/go.mod
index 829c7d66669..4793661c8aa 100644
--- a/go.mod
+++ b/go.mod
@@ -32,7 +32,7 @@ require (
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
golang.org/x/sys v0.0.0-20220520151302-bc2c85ada10a
google.golang.org/grpc v1.48.0
- google.golang.org/protobuf v1.28.0
+ google.golang.org/... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 1,959 | issue_to_patch | Chore: bump github.com/google/go-cmp from 0.5.8 to 0.5.9 | Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.8 to 0.5.9.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/google/go-cmp/releases">github.com/google/go-cmp's releases</a>.</em></p>
<blockquote>
<h2>v0.5.9</h2>
<p>Reporter changes:</p>
<ul>
<li>(<a ... | 305661c32b470b7d31d500fa5e5e2303828c8cc5 | e84d1b4df1a20dce4988b1f2930a6d0fa0bef632 | diff --git a/go.mod b/go.mod
index 43d6ebd06df..3819f27c4b5 100644
--- a/go.mod
+++ b/go.mod
@@ -9,7 +9,7 @@ require (
github.com/go-playground/validator/v10 v10.11.0
github.com/golang/mock v1.6.0
github.com/golang/protobuf v1.5.2
- github.com/google/go-cmp v0.5.8
+ github.com/google/go-cmp v0.5.9
github.com/go... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 2,360 | issue_to_patch | Chore: bump github.com/miekg/dns from 1.1.50 to 1.1.51 | Bumps [github.com/miekg/dns](https://github.com/miekg/dns) from 1.1.50 to 1.1.51.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/miekg/dns/commit/8f21ecc55d2193963df8393245640629835c30fe"><code>8f21ecc</code></a> Release 1.1.51</li>
<li><a href="https://github.com/miekg/dns/commit/21e21a327d3... | f1b9b571883a11554bed979b06c79382a4584301 | c655cdba84376087a058e4d69bebc8f6f8af4603 | diff --git a/go.mod b/go.mod
index d0fc051c911..e954963ebac 100644
--- a/go.mod
+++ b/go.mod
@@ -12,7 +12,7 @@ require (
github.com/google/go-cmp v0.5.9
github.com/gorilla/websocket v1.5.0
github.com/jhump/protoreflect v1.14.0
- github.com/miekg/dns v1.1.50
+ github.com/miekg/dns v1.1.51
github.com/mustafaturan... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 1,072 | issue_to_patch | Chore: bump github.com/lucas-clemente/quic-go from 0.21.0 to 0.21.1 | Bumps [github.com/lucas-clemente/quic-go](https://github.com/lucas-clemente/quic-go) from 0.21.0 to 0.21.1.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/lucas-clemente/quic-go/commit/29452277517826b3c0c450dc8bd0a351edc9e8d9"><code>2945227</code></a> Merge pull request <a href="https://githu... | 92bb1688fd56fcbe76d0eec5b33efa6144539e1e | 90ba80d8b98e2dcdd8301d2c82f2b1f0c6603879 | diff --git a/go.mod b/go.mod
index b139d22289b..e95b7a86044 100644
--- a/go.mod
+++ b/go.mod
@@ -8,7 +8,7 @@ require (
github.com/google/go-cmp v0.5.6
github.com/gorilla/websocket v1.4.2
github.com/jhump/protoreflect v1.8.2
- github.com/lucas-clemente/quic-go v0.21.0
+ github.com/lucas-clemente/quic-go v0.21.1
... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 2,326 | issue_to_patch | Chore: bump golang.org/x/net from 0.6.0 to 0.7.0 | Bumps [golang.org/x/net](https://github.com/golang/net) from 0.6.0 to 0.7.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/golang/net/commit/8e2b117aee74f6b86c207a808b0255de45c0a18a"><code>8e2b117</code></a> http2/hpack: avoid quadratic complexity in hpack decoding</li>
<li><a href="https://... | 37cfe716efe2caaefd2ea2101fbe48657560b9f9 | 89886852b24e965ba3f12ef73d93c45164b96d6b | diff --git a/go.mod b/go.mod
index eb7028e2152..962271b0147 100644
--- a/go.mod
+++ b/go.mod
@@ -29,7 +29,7 @@ require (
go.starlark.net v0.0.0-20220817180228-f738f5508c12
go4.org/netipx v0.0.0-20220812043211-3cc044ffd68d
golang.org/x/crypto v0.6.0
- golang.org/x/net v0.6.0
+ golang.org/x/net v0.7.0
golang.org/... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 1,971 | issue_to_patch | socks4/4a client does not work
PR #1269 claims to have added socks4/4a client support. However, no matter what socks version specified, it is actually always a socks5 client because it handshakes with `ClientHandshake`, which is for socks5 only. We need a different handshake function for socks4(a).
https://github.c... | fix: socks4/4a client handshake | fix #1968 | 2e0ea88041a775f0bbe77b2c7cc1ec3a9a29d8ac | 51665775984eee16d32c1f07123dc56e36b9b314 | diff --git a/proxy/socks/client.go b/proxy/socks/client.go
index 31d5f268cc6..bdb24e12c99 100644
--- a/proxy/socks/client.go
+++ b/proxy/socks/client.go
@@ -146,10 +146,21 @@ func (c *Client) Process(ctx context.Context, link *transport.Link, dialer inter
if err := conn.SetDeadline(time.Now().Add(p.Timeouts.Handshake... | [
"proxy/socks/client.go",
"proxy/socks/protocol.go"
] | [] | true | |
v2fly/v2ray-core | 1,852 | issue_to_patch | Chore: bump github.com/stretchr/testify from 1.7.1 to 1.8.0 | Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.7.1 to 1.8.0.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/stretchr/testify/commit/181cea6eab8b2de7071383eca4be32a424db38dd"><code>181cea6</code></a> impr: <code>CallerInfo</code> should print full paths to the ... | 7fec5bc1587221877e73557c2b2e1119e38d24f1 | 65229ea29bc1e26c065e0f64641df14bb9cebce6 | diff --git a/go.mod b/go.mod
index 1515c626046..df555a341b7 100644
--- a/go.mod
+++ b/go.mod
@@ -21,7 +21,7 @@ require (
github.com/pelletier/go-toml v1.9.5
github.com/pires/go-proxyproto v0.6.2
github.com/seiflotfy/cuckoofilter v0.0.0-20220312154859-af7fbb8e765b
- github.com/stretchr/testify v1.7.1
+ github.com/... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 2,212 | issue_to_patch | [app/dns] Support per-client configuration for fakedns | FakeDNS is very useful for switching between regions when resolving a set of domains. If just returning the real IP, after the v2ray is restarted for new region, OS and browsers would still keep old IPs in their DNS cache for a notable time, and they are very hard to flush completely. With fake IP, OS and browsers woul... | a1ee432d290598a6bc85de11281b6c97573310aa | 64bab40133bb473a7882320c2e43df557bb87b13 | diff --git a/app/dns/config.pb.go b/app/dns/config.pb.go
index 66338f9d655..2963d31d6d1 100644
--- a/app/dns/config.pb.go
+++ b/app/dns/config.pb.go
@@ -1,6 +1,7 @@
package dns
import (
+ fakedns "github.com/v2fly/v2ray-core/v5/app/dns/fakedns"
routercommon "github.com/v2fly/v2ray-core/v5/app/router/routercommon"... | [
"app/dns/config.pb.go",
"app/dns/config.proto",
"app/dns/dns.go",
"app/dns/dnscommon.go",
"app/dns/fakedns.go",
"app/dns/fakedns/fake.go",
"app/dns/fakedns/fakedns_test.go",
"app/dns/fakedns_test.go",
"app/dns/hosts.go",
"app/dns/nameserver.go",
"app/dns/nameserver_fakedns.go",
"common/net/sys... | [
{
"comment": "Here tests and demonstrates the options and patterns for the new per-client DNS configurations.",
"path": "infra/conf/synthetic/dns/dns_test.go",
"hunk": "@@ -149,5 +150,141 @@ func TestDNSConfigParsing(t *testing.T) {\n \t\t\t\tDisableFallback: true,\n \t\t\t},\n \t\t},\n+\t\t{\n+\t\t\tIn... | diff --git a/app/dns/fakedns/fakedns_test.go b/app/dns/fakedns/fakedns_test.go
index 9df481506fa..3d61dc71f61 100644
--- a/app/dns/fakedns/fakedns_test.go
+++ b/app/dns/fakedns/fakedns_test.go
@@ -217,3 +217,99 @@ func TestFakeDNSMulti(t *testing.T) {
})
})
}
+
+func TestFakeDNSMultiAddPool(t *testing.T) {
+ runT... | true | |
v2fly/v2ray-core | 1,738 | issue_to_patch | Chore: bump github.com/pelletier/go-toml from 1.9.4 to 1.9.5 | Bumps [github.com/pelletier/go-toml](https://github.com/pelletier/go-toml) from 1.9.4 to 1.9.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/pelletier/go-toml/releases">github.com/pelletier/go-toml's releases</a>.</em></p>
<blockquote>
<h2>v1.9.5</h2>
<h2>What's Changed</h2... | 542571d3a5df8b1576f23e69899b843de4216af3 | 3aba7e7859589d4e9e46f57ea070890208926f70 | diff --git a/go.mod b/go.mod
index 7c8f62ad688..c1634483479 100644
--- a/go.mod
+++ b/go.mod
@@ -17,7 +17,7 @@ require (
github.com/marten-seemann/qtls-go1-17 v0.1.1
github.com/marten-seemann/qtls-go1-18 v0.1.1
github.com/miekg/dns v1.1.48
- github.com/pelletier/go-toml v1.9.4
+ github.com/pelletier/go-toml v1.9.... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 1,866 | issue_to_patch | Chore: bump google.golang.org/grpc from 1.46.0 to 1.48.0 | Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.46.0 to 1.48.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases">google.golang.org/grpc's releases</a>.</em></p>
<blockquote>
<h2>Release 1.48.0</h2>
<h1>Bug Fixes</h1>
<ul>
<li>xds/pr... | 7fec5bc1587221877e73557c2b2e1119e38d24f1 | 849bde83f926f84b59ddedf1f80e17cf523089f5 | diff --git a/go.mod b/go.mod
index 1515c626046..edeeed1197a 100644
--- a/go.mod
+++ b/go.mod
@@ -31,7 +31,7 @@ require (
golang.org/x/net v0.0.0-20220325170049-de3da57026de
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
golang.org/x/sys v0.0.0-20220325203850-36772127a21f
- google.golang.org/grpc v1.46.0
+ g... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 1,071 | issue_to_patch | Chore: update dependencies | b275548a800993da0c4a02680bd74e1d28002a02 | 48c4e071a45e5a303c24dec680e231746c5d4968 | diff --git a/go.mod b/go.mod
index eda77b80945..b139d22289b 100644
--- a/go.mod
+++ b/go.mod
@@ -3,7 +3,7 @@ module github.com/v2fly/v2ray-core/v4
go 1.16
require (
- github.com/golang/mock v1.5.0
+ github.com/golang/mock v1.6.0
github.com/golang/protobuf v1.5.2
github.com/google/go-cmp v0.5.6
github.com/gori... | [
"go.mod",
"go.sum"
] | [] | true | |||
v2fly/v2ray-core | 3,193 | issue_to_patch | Chore: bump github.com/adrg/xdg from 0.5.0 to 0.5.1 | Bumps [github.com/adrg/xdg](https://github.com/adrg/xdg) from 0.5.0 to 0.5.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/adrg/xdg/releases">github.com/adrg/xdg's releases</a>.</em></p>
<blockquote>
<h2>v0.5.1</h2>
<h3>Changelog</h3>
<ul>
<li>Added support for the non-stan... | 0d0572338d41becf437b6fe73c602ff13aaf4a10 | 26fabcf9e022cdbe1db2d1db555ae15534b477a3 | diff --git a/go.mod b/go.mod
index f76aaef8f22..d73102bd664 100644
--- a/go.mod
+++ b/go.mod
@@ -5,7 +5,7 @@ go 1.22
toolchain go1.22.7
require (
- github.com/adrg/xdg v0.5.0
+ github.com/adrg/xdg v0.5.1
github.com/apernet/hysteria/core/v2 v2.4.5
github.com/apernet/quic-go v0.45.2-0.20240702221538-ed74cfbe8b6e
... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 1,891 | issue_to_patch | Chore: bump github.com/go-chi/render from 1.0.1 to 1.0.2 | Bumps [github.com/go-chi/render](https://github.com/go-chi/render) from 1.0.1 to 1.0.2.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/go-chi/render/commit/996350ff55de76c0d4a7d5d7e06469031ff93149"><code>996350f</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/go-... | 01104c2e06a367fadf75140ee8ba88e471407c73 | f402b97d361a403998b9097cb7b3989b5645273f | diff --git a/go.mod b/go.mod
index 829c7d66669..5f740643807 100644
--- a/go.mod
+++ b/go.mod
@@ -5,7 +5,7 @@ go 1.18
require (
github.com/adrg/xdg v0.4.0
github.com/go-chi/chi/v5 v5.0.7
- github.com/go-chi/render v1.0.1
+ github.com/go-chi/render v1.0.2
github.com/go-playground/validator/v10 v10.11.0
github.co... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 1,512 | issue_to_patch | fix typo | d24c276cc5a9080642cc33e76b798e9793a6232e | af1d771831f1629d0d1f255ff6bae86f9478911b | diff --git a/app/dispatcher/fakednssniffer.go b/app/dispatcher/fakednssniffer.go
index 2867eefff6f..9f9cfbd7d00 100644
--- a/app/dispatcher/fakednssniffer.go
+++ b/app/dispatcher/fakednssniffer.go
@@ -14,7 +14,7 @@ import (
"github.com/v2fly/v2ray-core/v4/features/dns"
)
-// newFakeDNSSniffer Create a Fake DNS met... | [
"app/dispatcher/fakednssniffer.go",
"app/dns/dnscommon.go",
"app/dns/fakedns/fake.go",
"app/observatory/burst/healthping.go",
"common/antireplay/replayfilter.go",
"common/buf/multi_buffer.go",
"common/cache/lru.go"
] | [] | true | |||
v2fly/v2ray-core | 2,609 | issue_to_patch | CI: Add Linux loong64 build task | Bump github.com/refraction-networking/utls from 1.3.2 to 1.3.3 is necessary because it fixes build error on the loong64 port: https://github.com/refraction-networking/utls/pull/195 | faa60cbb0720aebdb3c9827d2070192aeea77d45 | b6e65d3af39094e4b8635a76d6c86193485d27ef | diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
index 172e319ceab..5601770eb6b 100644
--- a/.github/workflows/release.yml
+++ b/.github/workflows/release.yml
@@ -74,6 +74,8 @@ jobs:
goarch: arm64
- goos: linux
goarch: riscv64
+ - goos: linux
+ ... | [
".github/workflows/release.yml",
"go.mod",
"go.sum",
"release/friendly-filenames.json",
"release/user-package.sh"
] | [] | true | ||
v2fly/v2ray-core | 1,230 | issue_to_patch | Keep probe interval consistent for the same outbound | Sort `outbounds` before probing so the probing interval is consistent for the same outbound. | 4f9415d001701a09f7b31596573e538a5971fea9 | 61dfe346ebc9a770dfb0d9406f7b0f88b3b923ed | diff --git a/app/observatory/observer.go b/app/observatory/observer.go
index 0a573a96aa4..83df15aa673 100644
--- a/app/observatory/observer.go
+++ b/app/observatory/observer.go
@@ -7,6 +7,7 @@ import (
"net"
"net/http"
"net/url"
+ "sort"
"sync"
"time"
@@ -67,6 +68,7 @@ func (o *Observer) background() {
}... | [
"app/observatory/observer.go"
] | [] | true | ||
v2fly/v2ray-core | 1,219 | issue_to_patch | Fix: go module & update dependencies | f2a504e2bb20d1b67c934c5b3378b4edfcf13ad7 | a84a9f1f07b049ff7b9025aaf23c4b3d5ee8b389 | diff --git a/go.mod b/go.mod
index 03a016cca73..c9b8875448d 100644
--- a/go.mod
+++ b/go.mod
@@ -17,11 +17,11 @@ require (
github.com/v2fly/VSign v0.0.0-20201108000810-e2adc24bf848
github.com/v2fly/ss-bloomring v0.0.0-20210312155135-28617310f63e
go.starlark.net v0.0.0-20210602144842-1cdb82c9e17a
- golang.org/x/cr... | [
"go.mod",
"go.sum"
] | [] | true | |||
v2fly/v2ray-core | 1,492 | issue_to_patch | Update Error Warnings | 423d566024b8e58f44eaad9ccad73eabdfd1046f | d4470c517644f80fad62c0e19ddcbbe48ac6425a | diff --git a/proxy/vmess/encoding/commands.go b/proxy/vmess/encoding/commands.go
index ff3ef2f0396..b3ab5003b0d 100644
--- a/proxy/vmess/encoding/commands.go
+++ b/proxy/vmess/encoding/commands.go
@@ -16,6 +16,8 @@ var (
ErrCommandTypeMismatch = newError("Command type mismatch.")
ErrUnknownCommand = newError("... | [
"proxy/vmess/encoding/commands.go"
] | [] | true | |||
v2fly/v2ray-core | 1,750 | issue_to_patch | Chore: bump github.com/google/go-cmp from 0.5.7 to 0.5.8 | Bumps [github.com/google/go-cmp](https://github.com/google/go-cmp) from 0.5.7 to 0.5.8.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/google/go-cmp/releases">github.com/google/go-cmp's releases</a>.</em></p>
<blockquote>
<h2>v0.5.8</h2>
<p>Reporter changes:</p>
<ul>
<li>(<a ... | eee91ae689595e5f3ebff1d7d8d2efc5f7f292b2 | d38b9d624b40e9eec080323340172b09aaa37ada | diff --git a/go.mod b/go.mod
index 22dc20346df..ba4794bacf1 100644
--- a/go.mod
+++ b/go.mod
@@ -9,7 +9,7 @@ require (
github.com/go-playground/validator/v10 v10.10.1
github.com/golang/mock v1.6.0
github.com/golang/protobuf v1.5.2
- github.com/google/go-cmp v0.5.7
+ github.com/google/go-cmp v0.5.8
github.com/go... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2fly/v2ray-core | 1,305 | issue_to_patch | proxyman/inbound/udpWorker在部分场景中会不断重复断开、建立链接
<!--
除非特殊情况，请完整填写所有问题。不按模板发的 issue 将直接被关闭。
如果你遇到的问题不是 V2Ray 的 bug，比如你不清楚如何配置，请在 https://github.com/v2fly/v2ray-core/discussions 进行讨论。
-->
## 你正在使用哪个版本的 V2Ray？
V2Ray 4.42.2 (V2Fly, a community-driven edition of V2Ray.) Custom (go1.17.1 linux/amd64)
<!-- 如果服务端和客户端使用... | Fix: Remove udp connection twice(#1297) | Fix #1297 | deb9d08487501e73c6693fb0ac90bd91952cb1a6 | c6a4e3a00aee7d9f7a1f0150b7fc6825e68d7e97 | diff --git a/app/proxyman/inbound/worker.go b/app/proxyman/inbound/worker.go
index 09574a976d8..eac983e7e9e 100644
--- a/app/proxyman/inbound/worker.go
+++ b/app/proxyman/inbound/worker.go
@@ -153,6 +153,11 @@ type udpConn struct {
done *done.Instance
uplink stats.Counter
downlink st... | [
"app/proxyman/inbound/worker.go"
] | [] | true | |
v2fly/v2ray-core | 3,658 | issue_to_patch | Add RRPIT - Rapid Reliable Packet Interactive Transport | This pull request adds RRPIT, a packet loss resistant, forward error correct as retransmission transport that is designed for unreliable network environment, it supports auto-reconnect self healing, multi-channel, packet loss compensation, and connection prioritization to work to create a fast and interactive proxy con... | cf7577f650f97226d34a4e7ab6e30b765a15677a | 0d8df7349f7ed97170075b93dd065bc12268e910 | diff --git a/app/dispatcher/default.go b/app/dispatcher/default.go
index a233936dca6..455588fa290 100644
--- a/app/dispatcher/default.go
+++ b/app/dispatcher/default.go
@@ -313,6 +313,19 @@ func (d *DefaultDispatcher) routedDispatch(ctx context.Context, link *transport.
}
} else if d.router != nil {
if route, e... | [
"app/dispatcher/default.go",
"app/router/config.go",
"app/router/config.pb.go",
"app/router/config.proto",
"app/router/router.go",
"app/router/router_test.go",
"common/net/abstactOutbound/errors.generated.go",
"common/net/abstactOutbound/outbound.go",
"config.pb.go",
"go.mod",
"go.sum",
"main/... | [] | diff --git a/app/router/router_test.go b/app/router/router_test.go
index 6c981fbdfcf..65e9ee1e905 100644
--- a/app/router/router_test.go
+++ b/app/router/router_test.go
@@ -54,6 +54,50 @@ func TestSimpleRouter(t *testing.T) {
}
}
+func TestRouteSetAttribute(t *testing.T) {
+ config := &Config{
+ Rule: []*RoutingR... | true | |
v2fly/v2ray-core | 1,366 | issue_to_patch | Chore: bump google.golang.org/grpc from 1.40.0 to 1.42.0 | Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.40.0 to 1.42.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases">google.golang.org/grpc's releases</a>.</em></p>
<blockquote>
<h2>Release 1.42.0</h2>
<h1>Behavior Changes</h1>
<ul>
<li... | 05f96fc4346abc699fa61b22e66d1e502ef918d0 | f4ea2d2b5faebc685b65d51620430ee60f90b165 | diff --git a/go.mod b/go.mod
index aa5f99b534c..ec31436cb0b 100644
--- a/go.mod
+++ b/go.mod
@@ -25,7 +25,7 @@ require (
golang.org/x/net v0.0.0-20210903162142-ad29c8ab022f
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
golang.org/x/sys v0.0.0-20210903071746-97244b99971b
- google.golang.org/grpc v1.40.0
+ g... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2ray/v2ray-core | 3,085 | issue_to_patch | Bump github.com/stretchr/testify from 1.6.1 to 1.8.1 | Bumps [github.com/stretchr/testify](https://github.com/stretchr/testify) from 1.6.1 to 1.8.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/stretchr/testify/releases">github.com/stretchr/testify's releases</a>.</em></p>
<blockquote>
<h2>Minor improvements and bug fixes</h2>
... | 5dffca84234a74da9e8174f1e0b0af3dfb2a58ce | 6a747255bc2dddeca7c93b6d27c90cab3007798c | diff --git a/go.mod b/go.mod
index a8dbab2140..b62b21d1a0 100644
--- a/go.mod
+++ b/go.mod
@@ -12,7 +12,7 @@ require (
github.com/miekg/dns v1.1.31
github.com/pires/go-proxyproto v0.2.0
github.com/seiflotfy/cuckoofilter v0.0.0-20200511222245-56093a4d3841
- github.com/stretchr/testify v1.6.1
+ github.com/stretchr/... | [
"go.mod",
"go.sum"
] | [] | true | ||
v2ray/v2ray-core | 1,767 | issue_to_patch | Add email into access log for shadowsocks and vmess | 给 shadowsocks 和 vmess 的 access log 里添加了 email 字段，效果如下，如果没有设置 email，则不会显示。
mux模式暂时也无法显示。
| de43bc7eb94cfcdc5796b1e47dc3102c8e52ca76 | dd048bfb2950e8da32f792a25c991766316705e9 | diff --git a/common/log/access.go b/common/log/access.go
index 621f75b0a9..41946c9b2b 100644
--- a/common/log/access.go
+++ b/common/log/access.go
@@ -18,6 +18,7 @@ type AccessMessage struct {
To interface{}
Status AccessStatus
Reason interface{}
+ Email string
}
func (m *AccessMessage) String() string {... | [
"common/log/access.go",
"common/mux/server.go",
"proxy/shadowsocks/server.go",
"proxy/vmess/inbound/inbound.go"
] | [] | true | ||
vadimdemedes/ink | 971 | issue_to_patch | Ink 7 rendering broken on all Windows terminals
Since upgrading from Ink 6 to 7, the ANSI escape sequences generated by Ink 7's render pipeline are incompatible with every Windows terminal — Git Bash, PowerShell, cmd, Windows Terminal. All produce garbled, overlapped text.
Reverting to Ink 6 resolves the issue comple... | Fix stale frames on Windows when output exactly fills the terminal | Fixes #969
## Problem
On Windows, an app whose output is exactly the height of the terminal leaves a stale copy of the previous frame behind on every rerender. The duplicates pile up above the UI as the app repaints. The reporter of #969 hit this through qwen-code, which upgraded ink 6 to 7 in its 0.16.0 release and ... | cb222feec2bd4a70ec2e559997f73f6119d21329 | 7d4bb31343d00a967a4df4a9592dc62ac3562bce | diff --git a/src/ink.tsx b/src/ink.tsx
index 1fda6222e..4998c60c8 100644
--- a/src/ink.tsx
+++ b/src/ink.tsx
@@ -115,6 +115,13 @@ const stripKittyQueryResponsesAndTrailingPartial = (
return keptBytes;
};
+// Windows consoles scroll the buffer when the bottom-right cell is written,
+// unlike xterm-like terminals w... | [
"src/ink.tsx",
"test/fixtures/issue-969-windows-full-height-rerender.tsx",
"test/render.tsx"
] | [] | diff --git a/test/fixtures/issue-969-windows-full-height-rerender.tsx b/test/fixtures/issue-969-windows-full-height-rerender.tsx
new file mode 100644
index 000000000..3c779a6e1
--- /dev/null
+++ b/test/fixtures/issue-969-windows-full-height-rerender.tsx
@@ -0,0 +1,12 @@
+import process from 'node:process';
+
+// Simula... | true |
vadimdemedes/ink | 962 | issue_to_patch | Update xo to version 2 | Update the xo package to version 2.0.2 and modify ESLint rules in the configuration to disable certain checks for improved flexibility. | 40b3a7578811fd616341ca4e31cc7748aeeff12f | 93dd69efd880a07373883972de280214c2427225 | diff --git a/package.json b/package.json
index 8722b37eb..72ff9bb0f 100644
--- a/package.json
+++ b/package.json
@@ -102,7 +102,7 @@
"strip-ansi": "^7.2.0",
"tsx": "^4.21.0",
"typescript": "^5.8.3",
- "xo": "^1.2.3"
+ "xo": "^2.0.2"
},
"peerDependencies": {
"@types/react": ">=19.2.0",
diff --git a/xo.... | [
"package.json",
"test/helpers/term.ts",
"test/render.tsx",
"xo.config.ts"
] | [] | diff --git a/test/helpers/term.ts b/test/helpers/term.ts
index 837bbfc2f..59c82174e 100644
--- a/test/helpers/term.ts
+++ b/test/helpers/term.ts
@@ -14,14 +14,12 @@ const term = (fixture: string, args: string[] = []) => {
let resolve: (value?: any) => void;
let reject: (error?: Error) => void;
- // eslint-disable... | true | |
vadimdemedes/ink | 965 | issue_to_patch | ErrorOverview: duplicate keys on empty stack lines + incomplete parseLine guard for native frames
## Environment
- ink version: 5.2.1 (also present in 6.x — confirmed in bun cache)
- stack-utils version: 2.0.6
- React version: 18.3.x
## Problem
`ErrorOverview` has two bugs that can cause a secondary crash when rend... | fix: handle incomplete stack frames in error overview | ## Summary
- Render `stack-utils` incomplete stack frames (for example `at native`) as raw stack lines instead of structured frames with `undefined` fields.
- Give repeated stack lines unique, stable keys so trailing/empty stack lines do not trigger React duplicate-key warnings.
- Add focused `ErrorOverview` regression... | 40b3a7578811fd616341ca4e31cc7748aeeff12f | fc85827ecdfe26916e6f2776b85bb252b969a3b3 | diff --git a/src/components/ErrorOverview.tsx b/src/components/ErrorOverview.tsx
index 5b597872f..1349f8837 100644
--- a/src/components/ErrorOverview.tsx
+++ b/src/components/ErrorOverview.tsx
@@ -27,6 +27,7 @@ export default function ErrorOverview({error}: Props) {
const filePath = cleanupPath(origin?.file);
let e... | [
"src/components/ErrorOverview.tsx",
"test/error-overview.tsx"
] | [] | diff --git a/test/error-overview.tsx b/test/error-overview.tsx
new file mode 100644
index 000000000..80ce6f85c
--- /dev/null
+++ b/test/error-overview.tsx
@@ -0,0 +1,62 @@
+import React from 'react';
+import test from 'ava';
+import stripAnsi from 'strip-ansi';
+import {renderToString} from '../src/index.js';
+import E... | true |
vadimdemedes/ink | 941 | issue_to_patch | Fix linting errors, warnings | This PR fixes the master branch CI build which is currently failing with linting errors in two test files:
* test/components.tsx
* test/kitty-keyboard.tsx
The transgression was `@typescript-eslint/no-unnecessary-type-assertion` with message "This assertion is unnecessary since the receiver accepts the original typ... | dc48987348a39554902da79dc17d59fdb34a6ea0 | 35b7fd2fd300d9d5c9271b64ba3a1f586f16ce8b | diff --git a/src/hooks/use-input.ts b/src/hooks/use-input.ts
index 5071cf1df..64cf9d03e 100644
--- a/src/hooks/use-input.ts
+++ b/src/hooks/use-input.ts
@@ -265,7 +265,7 @@ const useInput = (inputHandler: Handler, options: Options = {}) => {
return () => {
internal_eventEmitter.removeListener('input', handleData... | [
"src/hooks/use-input.ts",
"src/hooks/use-paste.ts",
"test/components.tsx",
"test/kitty-keyboard.tsx"
] | [] | diff --git a/test/components.tsx b/test/components.tsx
index 4e70ac5cf..982685e8f 100644
--- a/test/components.tsx
+++ b/test/components.tsx
@@ -1100,21 +1100,23 @@ test.serial(
'primary screen - cleanup console output follows the native console during unmount',
async t => {
const stdout = createStdout(100, true... | true | |
vadimdemedes/ink | 952 | issue_to_patch | fix: share useBoxMetrics resize listener via emitLayoutListeners | Currently each instance of this hook adds a `stdout.on("resize")`, quickly hitting the max listeners warning. This errors go through `process.emitWarning()`, the ink console log patch doesn't catch it and they end up in the terminal output.
A workaround is bumping the max listeners, but I think a better fix is jus... | 3d30345af45466839672e6dda9ae790ba40104a8 | d3d9fb90a3f9af6121fec16c2ff6598f3dd6047f | diff --git a/src/hooks/use-box-metrics.ts b/src/hooks/use-box-metrics.ts
index 89312b096..d9110010c 100644
--- a/src/hooks/use-box-metrics.ts
+++ b/src/hooks/use-box-metrics.ts
@@ -1,6 +1,5 @@
import {type RefObject, useState, useEffect, useCallback, useMemo} from 'react';
import {type DOMElement, addLayoutListener} ... | [
"src/hooks/use-box-metrics.ts",
"src/ink.tsx"
] | [] | true | ||
vadimdemedes/ink | 960 | issue_to_patch | fix: remove useEffectEvent functions from useEffect dependency arrays | ## Summary
- Remove `handleData` from the `useEffect` dependency array in `useInput`
- Remove `handlePaste` from the `useEffect` dependency array in `usePaste`
These were incorrectly added in #941. `useEffectEvent` return values intentionally have an unstable identity (they change every render), so including them in ... | 3d30345af45466839672e6dda9ae790ba40104a8 | e1ef49f9672555a6494fa3ad5bca91f43bc78e42 | diff --git a/src/hooks/use-input.ts b/src/hooks/use-input.ts
index 64cf9d03e..5071cf1df 100644
--- a/src/hooks/use-input.ts
+++ b/src/hooks/use-input.ts
@@ -265,7 +265,7 @@ const useInput = (inputHandler: Handler, options: Options = {}) => {
return () => {
internal_eventEmitter.removeListener('input', handleData... | [
"src/hooks/use-input.ts",
"src/hooks/use-paste.ts"
] | [] | true | ||
vadimdemedes/ink | 950 | issue_to_patch | fullStaticOutput retains items from unmounted/replaced <Static>, causing stale content to reappear on clearTerminal rewrites
## Summary
\`Ink#fullStaticOutput\` is the running concatenation of every chunk ever emitted by any \`<Static>\` instance during the lifetime of an Ink renderer. It is initialised to \`''\` in ... | Fix: drop stale <Static> output from fullStaticOutput on identity change | Fixes #949.
## Summary
\`Ink#fullStaticOutput\` is the running concatenation of everything every \`<Static>\` instance has ever emitted during the lifetime of an Ink renderer. It is initialised to \`''\` in the constructor and only ever grows — no code path shrinks or resets it. When \`shouldClearTerminalForFrame\` l... | be9f44cda18af60fa664c04e87266b8c3e0f8f5e | 6c8a8a2f155607115bf50721f0128c017b5219dd | diff --git a/src/dom.ts b/src/dom.ts
index 2a406516a..a19941634 100644
--- a/src/dom.ts
+++ b/src/dom.ts
@@ -66,9 +66,17 @@ export type DOMElement = {
// Internal properties
isStaticDirty?: boolean;
staticNode?: DOMElement;
+ // Identity of `staticNode` at the end of the previous commit. Used by the
+ // reconcil... | [
"src/dom.ts",
"src/ink.tsx",
"src/reconciler.ts",
"test/components.tsx"
] | [
{
"comment": "This new test is not Prettier-formatted, which makes the repository lint step fail before AVA runs. I reproduced it with `npm run lint` and `npx prettier --check src/dom.ts src/ink.tsx src/reconciler.ts test/components.tsx`; Prettier reports this function signature here and the assertion formattin... | diff --git a/test/components.tsx b/test/components.tsx
index 51e3528e0..621faa7cc 100644
--- a/test/components.tsx
+++ b/test/components.tsx
@@ -555,6 +555,60 @@ test('static output stops accumulating after Static unmounts (#904)', t => {
t.true(outputAfterChurn.includes('Dynamic'));
});
+test('fullStaticOutput is... | true |
vadimdemedes/ink | 950 | comment_to_fix | Fix: drop stale <Static> output from fullStaticOutput on identity change | This new test is not Prettier-formatted, which makes the repository lint step fail before AVA runs. I reproduced it with `npm run lint` and `npx prettier --check src/dom.ts src/ink.tsx src/reconciler.ts test/components.tsx`; Prettier reports this function signature here and the assertion formatting around line 606. Run... | be9f44cda18af60fa664c04e87266b8c3e0f8f5e | 6c8a8a2f155607115bf50721f0128c017b5219dd | diff --git a/test/components.tsx b/test/components.tsx
index 51e3528e0..621faa7cc 100644
--- a/test/components.tsx
+++ b/test/components.tsx
@@ -555,6 +555,60 @@ test('static output stops accumulating after Static unmounts (#904)', t => {
t.true(outputAfterChurn.includes('Dynamic'));
});
+test('fullStaticOutput is... | [
"test/components.tsx"
] | [
{
"comment": "This new test is not Prettier-formatted, which makes the repository lint step fail before AVA runs. I reproduced it with `npm run lint` and `npx prettier --check src/dom.ts src/ink.tsx src/reconciler.ts test/components.tsx`; Prettier reports this function signature here and the assertion formattin... | true | ||
vadimdemedes/ink | 948 | issue_to_patch | <Static> remount via key change drops new items (post-7.0 regression)
## Summary
In ink 7.x, remounting `<Static>` via a `key` prop change causes the new instance's items to silently drop from stdout. The dynamic frame keeps rendering, so the symptom is "items vanished" rather than a crash. Apps that drive a Static r... | Fix: <Static> remount via key change drops new items | Fixes #947.
## Summary
\`reconciler.removeChildFromContainer\` / \`removeChild\` unconditionally cleared \`rootNode.staticNode\` whenever the removed node was marked \`internal_static\`. React processes insertions before deletions inside a single commit, so when a \`<Static>\` is remounted via a \`key\` prop change:
... | 76d221c3639f62c8c2f6c3599d51a1bf51ed1b7b | 1693fa30f40cbdeec4194f174a273edc845d09cb | diff --git a/src/reconciler.ts b/src/reconciler.ts
index c282291b1..729e2cbed 100644
--- a/src/reconciler.ts
+++ b/src/reconciler.ts
@@ -295,7 +295,17 @@ export default createReconciler<
removeChildNode(node, removeNode);
cleanupYogaNode(removeNode.yogaNode);
- if (removeNode.internal_static && currentRootNode... | [
"src/reconciler.ts",
"test/components.tsx"
] | [
{
"comment": "This guard currently fails the repo lint (`npm run lint`) with `@typescript-eslint/prefer-optional-chain`. Please collapse it to `removeNode.internal_static && currentRootNode?.staticNode === removeNode` before merging. generated by GPT-5 model",
"path": "src/reconciler.ts",
"hunk": "@@ -2... | diff --git a/test/components.tsx b/test/components.tsx
index 8b4fe0331..51e3528e0 100644
--- a/test/components.tsx
+++ b/test/components.tsx
@@ -555,6 +555,109 @@ test('static output stops accumulating after Static unmounts (#904)', t => {
t.true(outputAfterChurn.includes('Dynamic'));
});
+test('remounting <Static... | true |
vadimdemedes/ink | 948 | comment_to_fix | Fix: <Static> remount via key change drops new items | Same lint failure here: XO prefers optional chaining for this guard, so `npm run lint` currently exits non-zero until this is written as `removeNode.internal_static && currentRootNode?.staticNode === removeNode`. generated by GPT-5 model | 76d221c3639f62c8c2f6c3599d51a1bf51ed1b7b | 1693fa30f40cbdeec4194f174a273edc845d09cb | diff --git a/src/reconciler.ts b/src/reconciler.ts
index c282291b1..729e2cbed 100644
--- a/src/reconciler.ts
+++ b/src/reconciler.ts
@@ -295,7 +295,17 @@ export default createReconciler<
removeChildNode(node, removeNode);
cleanupYogaNode(removeNode.yogaNode);
- if (removeNode.internal_static && currentRootNode... | [
"src/reconciler.ts"
] | [
{
"comment": "Same lint failure here: XO prefers optional chaining for this guard, so `npm run lint` currently exits non-zero until this is written as `removeNode.internal_static && currentRootNode?.staticNode === removeNode`. generated by GPT-5 model",
"path": "src/reconciler.ts",
"hunk": "@@ -351,7 +3... | true | ||
vadimdemedes/ink | 945 | issue_to_patch | Fix `useBoxMetrics` not accepting ref objects with an initial null value | This pull request hopes to change the current behaviours below to the expected behaviours.
Current Behaviours
--
With `complierOptions.strictNullChecks: true` set in `tsconfig.json`, compilation with the below code in the project always fails due to `useBoxMetrics` only accepting `RefObject<DOMElement>` and not ... | 1510851294393f5606166ecd0b5e1a203b82b1e3 | dde47256272a0ebdbb8faa459cbe56b966aeed5b | diff --git a/readme.md b/readme.md
index 1ccde74c3..bf7b0ad09 100644
--- a/readme.md
+++ b/readme.md
@@ -2080,7 +2080,7 @@ Use `hasMeasured` to detect when the currently tracked element has been measured
#### ref
-Type: `React.RefObject<DOMElement>`
+Type: `React.RefObject<DOMElement | null>`
A ref to the `<Box... | [
"readme.md",
"src/hooks/use-box-metrics.ts"
] | [] | true | ||
vadimdemedes/ink | 944 | issue_to_patch | docs: add Deepcode CLI to who uses ink list | # Deep Code CLI
[Deep Code](https://github.com/lessweb/deepcode-cli) is a terminal AI coding assistant optimized for the `deepseek-v4` model, with support for deep thinking, reasoning effort control, and Agent Skills. | 1510851294393f5606166ecd0b5e1a203b82b1e3 | 2b166c9da2ee8cae5dcf084cd5cd65dfbe8847f9 | diff --git a/readme.md b/readme.md
index 1ccde74c3..e63cacf9b 100644
--- a/readme.md
+++ b/readme.md
@@ -131,6 +131,7 @@ render(<Counter />);
- [instagram-cli](https://github.com/supreme-gg-gg/instagram-cli) - Instagram client.
- [ElevenLabs CLI](https://github.com/elevenlabs/cli) - ElevenLabs agents client.
- [SSH ... | [
"readme.md"
] | [] | true | ||
vadimdemedes/ink | 937 | issue_to_patch | Update focus handling in `App` component to conditionally reset on Escape | We are disabiling focus control with:
```
const { disableFocus} = useFocusManager();
```
and the start of our CLI because we want manually manage the tab, shift-tab and escape, but while this is effective to disable the automaticaly handling of tab, it is still messing with the escape, leaving the application on ... | fb14d811d513be19e5a57bb2faebbfd9ebd2f06a | 9df116818b9420470793d5b3f4d161efc1d6c6a9 | diff --git a/src/components/App.tsx b/src/components/App.tsx
index 6e2e57dae..bfe7a41a0 100644
--- a/src/components/App.tsx
+++ b/src/components/App.tsx
@@ -238,11 +238,11 @@ function App({
}
// Reset focus when there's an active focused component on Esc
- if (input === escape) {
+ if (input === escape &&... | [
"src/components/App.tsx"
] | [] | true | ||
vadimdemedes/ink | 925 | issue_to_patch | [Feature Request] Support `word-break` like props for `<Text />` component
Currently, the `<Text />` component supports the `wrap` prop, which controls the overflow behavior.
```js
if (wrapType === 'wrap') {
wrappedText = wrapAnsi(text, maxWidth, {
trim: false,
hard: true,
});
}
```
Can we add a prop lik... | Add wrap-anywhere option for Text component | Add 'wrap-anywhere' as a new value for the wrap prop on <Text />.
Unlike the default 'wrap' which tries to break at word boundaries, 'wrap-anywhere' fills each line to the full column width, breaking mid-word when needed. Uses wrap-ansi with wordWrap: false.
Closes #741 | 7c34548134f2fc0be80f2f1c6051cf95299fb305 | 9a628a537447afe4f00c16ce6f30b1d07bdef69e | diff --git a/readme.md b/readme.md
index 2a2923296..1ccde74c3 100644
--- a/readme.md
+++ b/readme.md
@@ -369,11 +369,12 @@ Invert background and foreground colors.
#### wrap
Type: `string`\
-Allowed values: `wrap` `truncate` `truncate-start` `truncate-middle` `truncate-end`\
+Allowed values: `wrap` `hard` `truncate... | [
"readme.md",
"src/components/Text.tsx",
"src/styles.ts",
"src/wrap-text.ts",
"test/components.tsx"
] | [] | diff --git a/test/components.tsx b/test/components.tsx
index a3e31f274..4e70ac5cf 100644
--- a/test/components.tsx
+++ b/test/components.tsx
@@ -94,6 +94,36 @@ test('don’t wrap text if there is enough space', t => {
t.is(output, 'Hello World');
});
+test('hard wrap text', t => {
+ const output = renderToString(
+ ... | true |
vadimdemedes/ink | 932 | issue_to_patch | `npm run build` task broken - generates incorrect structure in `outDir`
The `npm run build` task generates the following folder structure in the `build` folder:
```
build
├── media
│ ├── demo.d.ts
│ ├── demo.js
│ ├── ...
└── src
├── ansi-tokenizer.d.ts
├── ansi-tokenizer.js
├── ...
```
This prevent... | Fix build output and add tests | Introduce tests to verify the build output structure and ensure that the TypeScript configuration only includes the source directory, preventing nested build outputs.
closes #918 | 10136e6939a991d03d4248acccdebd738aace81a | 5e2366575654c3814f8d4496ac17815605012b2f | diff --git a/tsconfig.json b/tsconfig.json
index 56fe393d9..2b34f1186 100644
--- a/tsconfig.json
+++ b/tsconfig.json
@@ -11,5 +11,5 @@
"jsx": "react",
"isolatedModules": true
},
- "include": ["src", "media"]
+ "include": ["src"]
}
diff --git a/xo.config.ts b/xo.config.ts
index 54c2b5f30..4703e6aca 100644
--- a... | [
"test/build-output.ts",
"tsconfig.json",
"xo.config.ts"
] | [] | diff --git a/test/build-output.ts b/test/build-output.ts
new file mode 100644
index 000000000..021fde340
--- /dev/null
+++ b/test/build-output.ts
@@ -0,0 +1,65 @@
+import fs from 'node:fs';
+import path from 'node:path';
+import url from 'node:url';
+import {execSync} from 'node:child_process';
+import test from 'ava';... | true |
vadimdemedes/ink | 906 | issue_to_patch | ✨ feat: add border background color support for Box component | This PR builds on @miunau's work in #778 by completing the remaining feedback items from that PR.
The branch was rebased on latest `master` and the unit tests updated so that:
* test texts are placed within `<Text>` elements
* asserting (via regex) that border-colors around multiline text do not bleed into the w... | 19b53168c80d5ece90c17eda065012d3518d90e0 | fdf8e5f95a039ffcda3064d059763b644ec20a77 | diff --git a/examples/border-backgrounds/border-backgrounds.tsx b/examples/border-backgrounds/border-backgrounds.tsx
new file mode 100644
index 000000000..819c4358e
--- /dev/null
+++ b/examples/border-backgrounds/border-backgrounds.tsx
@@ -0,0 +1,62 @@
+import React from 'react';
+import {render, Box, Text} from '../..... | [
"examples/border-backgrounds/border-backgrounds.tsx",
"examples/border-backgrounds/index.ts",
"readme.md",
"src/render-border.ts",
"src/styles.ts",
"test/border-backgrounds.tsx"
] | [] | diff --git a/test/border-backgrounds.tsx b/test/border-backgrounds.tsx
new file mode 100644
index 000000000..2fc30e432
--- /dev/null
+++ b/test/border-backgrounds.tsx
@@ -0,0 +1,137 @@
+import React from 'react';
+import test from 'ava';
+import {Box, Text} from '../src/index.js';
+import {renderToString} from './helpe... | true | |
vadimdemedes/ink | 930 | issue_to_patch | Overlapping write on wide (CJK) character splits it, corrupting terminal output
## Description
When two elements overlap in the output grid (via `position="absolute"`, negative margins, etc.) and the overlapping write lands in the middle of a wide (CJK) character, the terminal output is corrupted.
Wide characters oc... | Fix split wide characters when overlapping writes occur | ## Summary
- When two elements overlap in the output grid (via `position="absolute"`, negative margins, etc.) and the write lands in the middle of a wide (CJK) character, one half of the character was left behind, corrupting terminal output
- Add left/right boundary checks in `Output.write()` to replace orphaned halve... | b5f3e3ac4ea17e0208bb367d242071b912d04f66 | cbab8ded4c5326a0c7f60d4714e41a7f5ab7583c | diff --git a/src/output.ts b/src/output.ts
index 197000849..c3baf9274 100644
--- a/src/output.ts
+++ b/src/output.ts
@@ -242,6 +242,33 @@ export default class Output {
const characters = this.caches.getStyledChars(line);
let offsetX = x;
+ // Nothing to write (e.g. line was clipped away).
+ if (ch... | [
"src/output.ts",
"test/text-width.tsx"
] | [] | diff --git a/test/text-width.tsx b/test/text-width.tsx
index 24c1b5e8e..77093b4af 100644
--- a/test/text-width.tsx
+++ b/test/text-width.tsx
@@ -140,3 +140,76 @@ test('truncate CJK text does not exceed Box width', t => {
const stripped = stripAnsi(lines[0]!);
t.true(stripped.endsWith('|'));
});
+
+test('overlay on... | true |
vadimdemedes/ink | 920 | issue_to_patch | docs: note terminal resize reflow limitation | Adds a note about the resize/reflow known limitation discussed in #916.
Terminal emulators differ in whether they reflow wrapped lines on resize, and there's no reliable way for Ink to detect which behavior is active.
Related: #907 | 19b53168c80d5ece90c17eda065012d3518d90e0 | 2c0e0c7f3ec4b9e0f097b2d66adf945af58d7519 | diff --git a/readme.md b/readme.md
index 05ba90fae..7d3cde6ee 100644
--- a/readme.md
+++ b/readme.md
@@ -2135,6 +2135,9 @@ Type: `number`
Number of rows (vertical character cells).
+> [!NOTE]
+> When the terminal is resized narrower, ghost lines may briefly appear depending on the terminal emulator's reflow behavi... | [
"readme.md"
] | [] | true | ||
vadimdemedes/ink | 910 | issue_to_patch | Incremental rendering: ghost/duplicate lines when output has trailing newline
## Description
When using `incrementalRendering: true`, content updates produce ghost/duplicate lines instead of updating in place. Lines that should be overwritten remain visible, with new content appearing below them.
## Steps to Reprodu... | Fix cursorUp offset in incremental rendering for trailing newline | ## Summary
Fixes the cursor rewind offset in `createIncremental` (`src/log-update.ts`) that causes ghost/duplicate lines when the rendered output has a trailing newline.
**Root cause:** The "same or grow height" branch uses `cursorUp(previousVisible - 1)` to rewind to line 0. `previousVisible` is `visibleLineCount()`... | 243e962f7e4f00510a322cf0ebf494c9e109273f | 389a2416c784b845944d7e880765de5db6893618 | diff --git a/src/log-update.ts b/src/log-update.ts
index d1693dcc9..c129d2863 100644
--- a/src/log-update.ts
+++ b/src/log-update.ts
@@ -270,7 +270,7 @@ const createIncremental = (
ansiEscapes.cursorUp(visibleCount),
);
} else {
- buffer.push(ansiEscapes.cursorUp(previousVisible - 1));
+ buffer.push(ans... | [
"src/log-update.ts",
"test/log-update.tsx"
] | [] | diff --git a/test/log-update.tsx b/test/log-update.tsx
index 9c451e26e..c00ca6d3f 100644
--- a/test/log-update.tsx
+++ b/test/log-update.tsx
@@ -76,6 +76,25 @@ test('incremental rendering - surgical updates', t => {
t.false(secondCall.includes('Line 3')); // Doesn't rewrite unchanged
});
+test('incremental renderi... | true |
vadimdemedes/ink | 914 | issue_to_patch | Convert class components to functional components with hooks in test fixtures | Refactor test fixtures to use functional components and React hooks, improving readability and performance. This change eliminates class components in favor of functional components, leveraging hooks for state and lifecycle management. | 0dc4dfa4271717a327603bc8cf50537b7ca767e7 | 469faf150742e41831ed5dd35088071a95b9bfc1 | diff --git a/examples/jest/jest.tsx b/examples/jest/jest.tsx
index 396f0153c..89eddc702 100644
--- a/examples/jest/jest.tsx
+++ b/examples/jest/jest.tsx
@@ -1,4 +1,4 @@
-import React from 'react';
+import React, {useState, useEffect, useCallback} from 'react';
import PQueue from 'p-queue';
import delay from 'delay';
... | [
"examples/jest/jest.tsx",
"test/components.tsx",
"test/fixtures/ci.tsx",
"test/fixtures/exit-double-raw-mode.tsx",
"test/fixtures/exit-on-exit-with-error.tsx",
"test/fixtures/exit-on-exit.tsx",
"test/fixtures/exit-on-finish.tsx",
"test/fixtures/exit-on-unmount.tsx",
"test/fixtures/exit-raw-on-exit-w... | [] | diff --git a/test/components.tsx b/test/components.tsx
index 0e5827afc..a3e31f274 100644
--- a/test/components.tsx
+++ b/test/components.tsx
@@ -583,18 +583,16 @@ test('disable raw mode when all input components are unmounted', t => {
debug: true,
};
- class Input extends React.Component<{setRawMode: (mode: bool... | true | |
vadimdemedes/ink | 913 | issue_to_patch | Remove unused React lint rules and clean up code structure | Refactor the code by removing unused React lint rules and restructuring components for improved readability and performance. The changes include converting a class component to a functional component and simplifying state management. | 33c07e35850f4b4ff181cb0a0d2bc592d4c44c9e | 2e60625d375f2fe298e820426eb29636936ddb7f | diff --git a/examples/jest/jest.tsx b/examples/jest/jest.tsx
index 2dddaa7c9..396f0153c 100644
--- a/examples/jest/jest.tsx
+++ b/examples/jest/jest.tsx
@@ -32,15 +32,11 @@ type State = {
};
class Jest extends React.Component<Record<string, unknown>, State> {
- constructor(properties: Record<string, unknown>) {
- ... | [
"examples/jest/jest.tsx",
"examples/use-focus/use-focus.tsx",
"media/demo.js",
"media/demo.tsx",
"tsconfig.json",
"xo.config.ts"
] | [] | true | ||
vadimdemedes/ink | 911 | issue_to_patch | Refactor effect dependencies in hooks and examples for improved stability | Enable react-hooks/exhaustive-deps then update effect dependencies in various hooks and examples to enhance stability and ensure proper functionality. Additionally, include a new formatting script in package.json. | 969a4f18722c3faead5847921d28a3c4b03bd259 | b4d402d321b4544572448b232736cda9b3930995 | diff --git a/examples/use-stderr/use-stderr.tsx b/examples/use-stderr/use-stderr.tsx
index ddf133fec..073543752 100644
--- a/examples/use-stderr/use-stderr.tsx
+++ b/examples/use-stderr/use-stderr.tsx
@@ -12,7 +12,7 @@ function Example() {
return () => {
clearInterval(timer);
};
- }, []);
+ }, [write]);
r... | [
"examples/use-stderr/use-stderr.tsx",
"examples/use-stdout/use-stdout.tsx",
"src/hooks/use-focus.ts",
"src/hooks/use-input.ts",
"test/fixtures/exit-on-exit-with-error-value-property.tsx",
"test/fixtures/exit-with-static.tsx",
"test/fixtures/use-input-many.tsx",
"test/fixtures/use-input-multiple.tsx",
... | [
{
"comment": "Don't make unrelated changes.",
"path": "readme.md",
"hunk": "@@ -2566,6 +2586,7 @@ Default: `['disambiguateEscapeCodes']`\n Protocol flags to request from the terminal. Pass an array of flag name strings.\n \n Available flags:\n+",
"resolving_sha": "b4d402d321b4544572448b232736cda9b39... | diff --git a/test/fixtures/exit-on-exit-with-error-value-property.tsx b/test/fixtures/exit-on-exit-with-error-value-property.tsx
index e4218e458..b3c0cab11 100644
--- a/test/fixtures/exit-on-exit-with-error-value-property.tsx
+++ b/test/fixtures/exit-on-exit-with-error-value-property.tsx
@@ -10,7 +10,7 @@ function Test... | true | |
vadimdemedes/ink | 905 | issue_to_patch | rootNode.staticNode dangling reference causes OOM after <Static> unmount
Hey! Thanks for the awesome lib.
While writing a cli preview for a couple of apps, I hit a weird error where the bun process executing ink explodes in memory usage to 150+GB. I was stumped and thought it was an issue on my side. In a way it was,... | fix: clear staticNode reference on Static unmount | ## Summary
When a `<Static>` component unmounts, `rootNode.staticNode` was not cleared, leaving a dangling reference to a freed Yoga WASM node. Subsequent renders called `getComputedWidth()`/`getComputedHeight()` on the freed node, returning garbage values that caused OOM when allocating the output grid.
This clears ... | 243e962f7e4f00510a322cf0ebf494c9e109273f | 3b7fb800b1abe80fec44cf4dcf5c99cdc90b0aa0 | diff --git a/src/reconciler.ts b/src/reconciler.ts
index 4cbaad1ea..c282291b1 100644
--- a/src/reconciler.ts
+++ b/src/reconciler.ts
@@ -294,6 +294,10 @@ export default createReconciler<
removeChildFromContainer(node, removeNode) {
removeChildNode(node, removeNode);
cleanupYogaNode(removeNode.yogaNode);
+
+ if... | [
"src/reconciler.ts",
"test/components.tsx"
] | [] | diff --git a/test/components.tsx b/test/components.tsx
index 3f631766a..0e5827afc 100644
--- a/test/components.tsx
+++ b/test/components.tsx
@@ -468,6 +468,50 @@ test('skip previous output when rendering new static output', t => {
t.is((stdout.write as any).lastCall.args[0], 'A\nB\n');
});
+test('static output sto... | true |
vadimdemedes/ink | 902 | issue_to_patch | bug: useInput crashes with TypeError when keyName lookup misses — `Cannot read properties of undefined (reading 'startsWith')` on VSCode v1.111.0
## Bug Description
`useInput` crashes with `TypeError: Cannot read properties of undefined (reading 'startsWith')` when the terminal sends ANSI escape sequences with a Ctrl... | Fix useInput crash on unmapped keyName codes | ## Summary
- Fix `TypeError: Cannot read properties of undefined (reading 'startsWith')` crash in `useInput` when the terminal sends escape sequences with Ctrl modifiers whose key codes aren't in the `keyName` map (e.g. Ctrl+F1 via `ESC[1;5P`)
- Root cause: `keyName[code]!` non-null assertion in `parse-keypress.ts` re... | 243e962f7e4f00510a322cf0ebf494c9e109273f | de9b124d6d5d29686bcf3587e6da39a571e433e6 | diff --git a/src/hooks/use-input.ts b/src/hooks/use-input.ts
index e368ab9d6..b750c7c73 100644
--- a/src/hooks/use-input.ts
+++ b/src/hooks/use-input.ts
@@ -225,7 +225,10 @@ const useInput = (inputHandler: Handler, options: Options = {}) => {
input = '';
}
} else if (keypress.ctrl) {
- input = keypres... | [
"src/hooks/use-input.ts",
"src/parse-keypress.ts",
"test/fixtures/use-input.tsx",
"test/hooks-use-input.tsx",
"test/parse-keypress.ts"
] | [] | diff --git a/test/fixtures/use-input.tsx b/test/fixtures/use-input.tsx
index 4b0a42081..33e637fa7 100644
--- a/test/fixtures/use-input.tsx
+++ b/test/fixtures/use-input.tsx
@@ -208,6 +208,16 @@ function UserInput({test}: {readonly test: string | undefined}) {
return;
}
+ if (test === 'ctrlF1' && input === '' ... | true |
vadimdemedes/ink | 912 | issue_to_patch | Add Prettier script for code formatting | Integrate a format script in `package.json` to run Prettier for consistent code formatting across the project. Minor formatting adjustments made throughout the codebase for improved readability. | 969a4f18722c3faead5847921d28a3c4b03bd259 | aca6bb22d1a81bfafa82cdbdb0dbeaf2216b2821 | diff --git a/package.json b/package.json
index e39a628ec..f0a6396ee 100644
--- a/package.json
+++ b/package.json
@@ -23,6 +23,7 @@
"prepare": "npm run build",
"test": "npm run typecheck && npm run lint && FORCE_COLOR=true ava",
"lint": "xo",
+ "format": "prettier --write .",
"typecheck": "tsc --noEmit",
... | [
"package.json",
"readme.md"
] | [] | true | ||
vadimdemedes/ink | 908 | issue_to_patch | Refactor to use Uint8Array for improved performance | Replace Buffer with Uint8Array across the codebase to enhance compatibility and performance when handling binary data. This change simplifies data processing and improves memory efficiency.
Performance difference:
Slight wins:
[test/render.tsx:108,111](test/render.tsx#L108-L111) — new TextDecoder().decode(chun... | 243e962f7e4f00510a322cf0ebf494c9e109273f | 2ffa409d4ff92ce4cc02e195338048ddb13e4503 | diff --git a/examples/subprocess-output/subprocess-output.tsx b/examples/subprocess-output/subprocess-output.tsx
index 92f32b86d..ae4ee9878 100644
--- a/examples/subprocess-output/subprocess-output.tsx
+++ b/examples/subprocess-output/subprocess-output.tsx
@@ -1,9 +1,10 @@
import childProcess from 'node:child_process'... | [
"examples/subprocess-output/subprocess-output.tsx",
"src/ink.tsx",
"src/parse-keypress.ts",
"test/kitty-keyboard.tsx",
"test/render.tsx"
] | [] | diff --git a/test/kitty-keyboard.tsx b/test/kitty-keyboard.tsx
index 011a90e99..87f39c52c 100644
--- a/test/kitty-keyboard.tsx
+++ b/test/kitty-keyboard.tsx
@@ -1,12 +1,13 @@
import process from 'node:process';
import EventEmitter from 'node:events';
-import {Buffer} from 'node:buffer';
import React from 'react';
i... | true | |
vadimdemedes/ink | 899 | issue_to_patch | Update ava to version 7.0.0 and improve error handling in exit tests | a test failed after upgrading ava so here's the fix analysis
## Summary of the fix
The issue was caused by AVA 6's breaking change: **failed assertions now throw errors**. When `t.fail()` was called after `resolve()`, it threw an error after the test had already completed, creating an uncaught exception.
**The... | 0cea59169ef0f3f83e4aa7fbedbff9d165646472 | 7a5222a7482442acdd01882535f3e9182b4aa1a9 | diff --git a/package.json b/package.json
index 60bc424e6..e39a628ec 100644
--- a/package.json
+++ b/package.json
@@ -86,7 +86,7 @@
"@types/stack-utils": "^2.0.2",
"@types/ws": "^8.18.1",
"@vdemedes/prettier-config": "^2.0.1",
- "ava": "^5.1.1",
+ "ava": "^7.0.0",
"boxen": "^8.0.1",
"delay": "^7.0.0",
... | [
"package.json",
"src/components/ErrorBoundary.tsx",
"src/components/Static.tsx",
"test/components.tsx",
"test/exit.tsx"
] | [] | diff --git a/test/components.tsx b/test/components.tsx
index 2ce34c2f7..3f631766a 100644
--- a/test/components.tsx
+++ b/test/components.tsx
@@ -219,12 +219,11 @@ test('fail when text nodes are not within <Text> component', t => {
let error: Error | undefined;
class ErrorBoundary extends Component<{children?: Rea... | true | |
vadimdemedes/ink | 885 | issue_to_patch | Bundlers can't tree-shake `react-devtools-core` import after v6.8.0 refactor of DEV check
After upgrading from ink 6.7.0 to 6.8.0, production builds with Rspack (and likely other bundlers) fail with:
```
ERROR in ../../node_modules/ink/build/devtools.js 5:1-43
× Module not found: Can't resolve 'react-devtools-core... | Handle missing package.json in dev mode + bundler regression | Gracefully handle the absence of package.json by returning default values when loading it fails in development mode.
it seems undefined can still cause crashes in some instances
related. to #877
closes #886
| a27a17e785ec04285f24377f2e5c99ea555f1322 | 60a5c38975257b0a914bc7a08a536f9d515d130c | diff --git a/src/ink.tsx b/src/ink.tsx
index 5fa5d3275..070c6b7f0 100644
--- a/src/ink.tsx
+++ b/src/ink.tsx
@@ -11,7 +11,7 @@ import {LegacyRoot, ConcurrentRoot} from 'react-reconciler/constants.js';
import {type FiberRoot} from 'react-reconciler';
import Yoga from 'yoga-layout';
import wrapAnsi from 'wrap-ansi';
-... | [
"src/ink.tsx",
"src/reconciler.ts",
"src/utils.ts"
] | [
{
"comment": "Small thing: the empty catch {} here means if loadPackageJson() fails for any reason (bad JSON, permissions, etc.) it's completely silent. Since you're already in dev mode at this point, a console.warn would be nice so people know something's off.\nEverything else looks good to me.",
"path": "... | true | |
vadimdemedes/ink | 885 | comment_to_fix | Handle missing package.json in dev mode + bundler regression | Small thing: the empty catch {} here means if loadPackageJson() fails for any reason (bad JSON, permissions, etc.) it's completely silent. Since you're already in dev mode at this point, a console.warn would be nice so people know something's off.
Everything else looks good to me. | a27a17e785ec04285f24377f2e5c99ea555f1322 | 60a5c38975257b0a914bc7a08a536f9d515d130c | diff --git a/src/reconciler.ts b/src/reconciler.ts
index 3a6e16e21..4cbaad1ea 100644
--- a/src/reconciler.ts
+++ b/src/reconciler.ts
@@ -1,3 +1,4 @@
+import process from 'node:process';
import createReconciler, {type ReactContext} from 'react-reconciler';
import {
DefaultEventPriority,
@@ -5,7 +6,7 @@ import {
} f... | [
"src/reconciler.ts"
] | [
{
"comment": "Small thing: the empty catch {} here means if loadPackageJson() fails for any reason (bad JSON, permissions, etc.) it's completely silent. Since you're already in dev mode at this point, a console.warn would be nice so people know something's off.\nEverything else looks good to me.",
"path": "... | true | ||
vadimdemedes/ink | 895 | issue_to_patch | feat: auto-detect kitty keyboard protocol via query instead of terminal whitelist | ## Summary
In `auto` mode, `initKittyKeyboard()` currently only attempts kitty keyboard protocol detection for a hardcoded list of terminals (kitty, WezTerm, ghostty, and those setting `KITTY_WINDOW_ID`). Any terminal not on this list is silently skipped, even if it fully supports the protocol.
This PR removes the wh... | 77431f739ad7467489acde11b5396fe10200129b | 84f2d08bbec8a00e924bac5bc556983b06b33277 | diff --git a/src/ink.tsx b/src/ink.tsx
index 1afc0ec05..788d2f35b 100644
--- a/src/ink.tsx
+++ b/src/ink.tsx
@@ -1037,19 +1037,11 @@ export default class Ink {
return;
}
- // Auto mode: use heuristic precheck, then confirm with protocol query
- const term = process.env['TERM'] ?? '';
- const termProgram = p... | [
"src/ink.tsx"
] | [] | true | ||
vadimdemedes/ink | 893 | issue_to_patch | Update XO to support react 19 rules | ReactNode can be a promise however Ink's code assumes it's not a promise so i undid my async changes but they can be found [here](https://github.com/vadimdemedes/ink/pull/893/changes/2b40fcd6081ea730d7d4095c6e283404bf004318) if you wanna handle them in the future | c7b6800e8afd37b65692c23641d73e7fbc94bf97 | 3bf27c5b85285dfc0f146c5418e922a77ae69370 | diff --git a/examples/concurrent-suspense/concurrent-suspense.tsx b/examples/concurrent-suspense/concurrent-suspense.tsx
index 902faf13b..b035ffe59 100644
--- a/examples/concurrent-suspense/concurrent-suspense.tsx
+++ b/examples/concurrent-suspense/concurrent-suspense.tsx
@@ -103,7 +103,7 @@ function App() {
<Data... | [
"examples/concurrent-suspense/concurrent-suspense.tsx",
"examples/jest/summary.tsx",
"examples/subprocess-output/subprocess-output.tsx",
"examples/use-focus-with-id/use-focus-with-id.tsx",
"examples/use-focus/use-focus.tsx",
"examples/use-transition/use-transition.tsx",
"package.json",
"src/components... | [] | diff --git a/test/ansi-tokenizer.ts b/test/ansi-tokenizer.ts
index ea199fa3e..66cc9b744 100644
--- a/test/ansi-tokenizer.ts
+++ b/test/ansi-tokenizer.ts
@@ -16,7 +16,7 @@ test('tokenize ESC CSI SGR sequence', t => {
t.deepEqual(tokens[2], {type: 'text', value: 'B'});
const csiToken = tokens[1];
- if (csiToken ===... | true | |
vadimdemedes/ink | 888 | issue_to_patch | Expected behavior when there is no output TTY
We have a command with long-running output in a `<Static>` which we would like our users to be able to pipe into a command like `more` or `less`. However ink does not seem to handle piped output / lack of TTY as there are ANSI escapes in the output. You also see re-renders... | Add interactive option for non-TTY and CI environments | ## Summary
Closes #667
Adds a configurable `interactive` option that defaults to `false` when running in CI or when `stdout` is not a TTY. This allows Ink to gracefully handle piped output (e.g. `node app.js | cat`) by skipping terminal-specific features.
When `interactive` is disabled:
- Only the final frame of non... | fbbeb23594f3a0b74f312afbc32823c79e01b9c6 | 763ac98ed7f6de2df8f84fe309b49eebc84573d7 | diff --git a/readme.md b/readme.md
index 78f521c35..8dedf6f8a 100644
--- a/readme.md
+++ b/readme.md
@@ -2480,6 +2480,23 @@ render(<MyApp />, {concurrent: true});
> [!NOTE]
> Concurrent mode changes the timing of renders. Some tests may need to use `act()` to properly await updates. The `concurrent` option only takes... | [
"readme.md",
"src/components/App.tsx",
"src/ink.tsx",
"src/render.ts",
"src/write-synchronized.ts",
"test/components.tsx",
"test/cursor.tsx",
"test/errors.tsx",
"test/helpers/create-stdout.ts",
"test/log-update.tsx",
"test/measure-element.tsx",
"test/render.tsx",
"test/terminal-resize.tsx",
... | [
{
"comment": "It should continue using this when `interactive` is not specified.",
"path": "src/write-synchronized.ts",
"hunk": "@@ -1,9 +1,15 @@\n import {type Writable} from 'node:stream';\n-import isInCi from 'is-in-ci';",
"resolving_sha": "763ac98ed7f6de2df8f84fe309b49eebc84573d7",
"resolvin... | diff --git a/test/components.tsx b/test/components.tsx
index 2f5b9c0ea..527ae7868 100644
--- a/test/components.tsx
+++ b/test/components.tsx
@@ -217,6 +217,7 @@ test('fail when text nodes are not within <Text> component', t => {
let error: Error | undefined;
class ErrorBoundary extends Component<{children?: React... | true |
vadimdemedes/ink | 888 | comment_to_fix | Add interactive option for non-TTY and CI environments | It should continue using this when `interactive` is not specified. | fbbeb23594f3a0b74f312afbc32823c79e01b9c6 | 763ac98ed7f6de2df8f84fe309b49eebc84573d7 | diff --git a/src/write-synchronized.ts b/src/write-synchronized.ts
index aa84ecf36..640ef5fc1 100644
--- a/src/write-synchronized.ts
+++ b/src/write-synchronized.ts
@@ -4,6 +4,13 @@ import isInCi from 'is-in-ci';
export const bsu = '\u001B[?2026h';
export const esu = '\u001B[?2026l';
-export function shouldSynchron... | [
"src/write-synchronized.ts"
] | [
{
"comment": "It should continue using this when `interactive` is not specified.",
"path": "src/write-synchronized.ts",
"hunk": "@@ -1,9 +1,15 @@\n import {type Writable} from 'node:stream';\n-import isInCi from 'is-in-ci';",
"resolving_sha": "763ac98ed7f6de2df8f84fe309b49eebc84573d7",
"resolvin... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.