repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
usememos/memos | 5,930 | comment_to_fix | chore: update zh-Hant translation | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Fix Simplified character in zh-Hant string**
Line [536] contains `专` (Simplified). This should be `專` in the zh-Hant locale.
<details>
<summary>Suggested fix</summary>
```diff
- "smtp-password-description": "SMTP 密碼或應用程式专用密碼。Gmail 需使用 Google 應用程式密碼，而非一般帳號密... | 5ccba98adce38642a4fd3dc1b7dc1d0ebaa8709f | cd1d5b7e45144be1e1bc5bbebc4f0d327fa56264 | diff --git a/web/src/locales/zh-Hant.json b/web/src/locales/zh-Hant.json
index ee892c232f02b..266f3d88b19b8 100644
--- a/web/src/locales/zh-Hant.json
+++ b/web/src/locales/zh-Hant.json
@@ -3,6 +3,7 @@
"blogs": "部落格",
"description": "以隱私為核心的輕量化筆記服務，輕鬆記錄並分享您的好點子。",
"documents": "文件",
+ "media": "媒體",
... | [
"web/src/locales/zh-Hant.json"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Fix Simplified character in zh-Hant string**\n\nLine [536] contains `专` (Simplified). This should be `專` in the zh-Hant locale.\n\n \n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n- \"smtp-password-description\": \"SMTP 密碼或應用程... | true | ||
usememos/memos | 5,930 | comment_to_fix | chore: update zh-Hant translation | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Normalize storage terminology in warning text**
Line [692] uses `存儲`, while this section mostly uses `儲存`. Unifying terms improves consistency.
<details>
<summary>Suggested fix</summary>
```diff
- "warning-text": "您確定要刪除存儲服務 `{{name}}` 嗎？此操作無法恢復。"
+ "... | 5ccba98adce38642a4fd3dc1b7dc1d0ebaa8709f | cd1d5b7e45144be1e1bc5bbebc4f0d327fa56264 | diff --git a/web/src/locales/zh-Hant.json b/web/src/locales/zh-Hant.json
index ee892c232f02b..266f3d88b19b8 100644
--- a/web/src/locales/zh-Hant.json
+++ b/web/src/locales/zh-Hant.json
@@ -3,6 +3,7 @@
"blogs": "部落格",
"description": "以隱私為核心的輕量化筆記服務，輕鬆記錄並分享您的好點子。",
"documents": "文件",
+ "media": "媒體",
... | [
"web/src/locales/zh-Hant.json"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Normalize storage terminology in warning text**\n\nLine [692] uses `存儲`, while this section mostly uses `儲存`. Unifying terms improves consistency.\n\n \n\n<details>\n<summary>Suggested fix</summary>\n\n```diff\n- \"warning-text\": \"您確定要刪... | true | ||
usememos/memos | 5,928 | issue_to_patch | refactor(ai): split STT and Audio-LLM into separate interfaces | ## Summary
Refactors `internal/ai/` from a single `Transcriber` interface (which dressed Gemini's multimodal LLM up as STT) into two honest interfaces, aligned with mainstream OSS conventions (Vercel AI SDK, LiteLLM, Go AI ecosystem):
- `internal/ai/stt/` — deterministic speech-to-text (OpenAI Whisper + gpt-4o-transc... | 238f27dea149492a78a8994470b0aac55fece78d | 6a1c71db2c448961b3ecf821e81d5d68c621abc3 | diff --git a/docs/superpowers/plans/2026-05-02-stt-audiollm-split.md b/docs/superpowers/plans/2026-05-02-stt-audiollm-split.md
new file mode 100644
index 0000000000000..fadf557981ec2
--- /dev/null
+++ b/docs/superpowers/plans/2026-05-02-stt-audiollm-split.md
@@ -0,0 +1,1590 @@
+# STT and Audio-LLM Split — Implementatio... | [
"docs/superpowers/plans/2026-05-02-stt-audiollm-split.md",
"docs/superpowers/specs/2026-05-02-stt-audiollm-split-design.md",
"go.mod",
"go.sum",
"internal/ai/audio/webm.go",
"internal/ai/audio/webm_test.go",
"internal/ai/audiollm/audiollm.go",
"internal/ai/audiollm/gemini/gemini.go",
"internal/ai/au... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Keep the manifest aligned with the actual change set.**\n\nThis section says `internal/ai/audio/webm.go` and `audio/webm_test.go` are untouched, but they are part of the implementation in this PR. Leaving them here will confuse anyone replayin... | diff --git a/docs/superpowers/specs/2026-05-02-stt-audiollm-split-design.md b/docs/superpowers/specs/2026-05-02-stt-audiollm-split-design.md
new file mode 100644
index 0000000000000..d69d70c2e6396
--- /dev/null
+++ b/docs/superpowers/specs/2026-05-02-stt-audiollm-split-design.md
@@ -0,0 +1,511 @@
+# STT and Audio-LLM S... | true | |
usememos/memos | 5,928 | comment_to_fix | refactor(ai): split STT and Audio-LLM into separate interfaces | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Keep the manifest aligned with the actual change set.**
This section says `internal/ai/audio/webm.go` and `audio/webm_test.go` are untouched, but they are part of the implementation in this PR. Leaving them here will confuse anyone replaying the staged plan or recon... | 238f27dea149492a78a8994470b0aac55fece78d | 6a1c71db2c448961b3ecf821e81d5d68c621abc3 | diff --git a/docs/superpowers/plans/2026-05-02-stt-audiollm-split.md b/docs/superpowers/plans/2026-05-02-stt-audiollm-split.md
new file mode 100644
index 0000000000000..fadf557981ec2
--- /dev/null
+++ b/docs/superpowers/plans/2026-05-02-stt-audiollm-split.md
@@ -0,0 +1,1590 @@
+# STT and Audio-LLM Split — Implementatio... | [
"docs/superpowers/plans/2026-05-02-stt-audiollm-split.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Keep the manifest aligned with the actual change set.**\n\nThis section says `internal/ai/audio/webm.go` and `audio/webm_test.go` are untouched, but they are part of the implementation in this PR. Leaving them here will confuse anyone replayin... | true | ||
usememos/memos | 5,926 | issue_to_patch | feat(transcription): explicit STT settings with provider, model, prompt | Replaces the implicit "first AI provider with apiKey wins" transcription flow with an explicit InstanceAISetting.transcription configuration that names a provider, model, default language, and prompt hint. Unblocks:
- Whisper via OpenAI's whisper-1 model
- Groq's whisper-large-v3-turbo via custom endpoint
- Self-h... | ef55013418d68e2d6a24a6d02a0365c1ffff03d7 | fad6595eceadca039075a217357ee2b7dc8b528f | diff --git a/docs/superpowers/plans/2026-05-02-transcription-settings.md b/docs/superpowers/plans/2026-05-02-transcription-settings.md
new file mode 100644
index 0000000000000..4899d0389682a
--- /dev/null
+++ b/docs/superpowers/plans/2026-05-02-transcription-settings.md
@@ -0,0 +1,1816 @@
+# Transcription (STT) Setting... | [
"docs/superpowers/plans/2026-05-02-transcription-settings.md",
"docs/superpowers/specs/2026-05-02-transcription-settings-design.md",
"internal/ai/models.go",
"proto/api/v1/ai_service.proto",
"proto/api/v1/instance_service.proto",
"proto/gen/api/v1/ai_service.pb.go",
"proto/gen/api/v1/instance_service.pb... | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\ncat proto/api/v1/ai_service.proto\n```\n\nRepository: usememos/memos\n\nLength of output: 1215\n\n---\n\n🏁 Script executed:\n\n```shell\ncd proto/api/v1 && git log --oneline --... | diff --git a/docs/superpowers/specs/2026-05-02-transcription-settings-design.md b/docs/superpowers/specs/2026-05-02-transcription-settings-design.md
new file mode 100644
index 0000000000000..d14536c33196b
--- /dev/null
+++ b/docs/superpowers/specs/2026-05-02-transcription-settings-design.md
@@ -0,0 +1,155 @@
+# Transcr... | true | |
usememos/memos | 5,926 | comment_to_fix | feat(transcription): explicit STT settings with provider, model, prompt | _⚠️ Potential issue_ | _🟠 Major_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
cat proto/api/v1/ai_service.proto
```
Repository: usememos/memos
Length of output: 1215
---
🏁 Script executed:
```shell
cd proto/api/v1 && git log --oneline --all -- ai_service.proto | head -20
```
Re... | ef55013418d68e2d6a24a6d02a0365c1ffff03d7 | fad6595eceadca039075a217357ee2b7dc8b528f | diff --git a/proto/api/v1/ai_service.proto b/proto/api/v1/ai_service.proto
index 82c9386ebd6c5..1aeb1e63ef250 100644
--- a/proto/api/v1/ai_service.proto
+++ b/proto/api/v1/ai_service.proto
@@ -15,27 +15,13 @@ service AIService {
post: "/api/v1/ai:transcribe"
body: "*"
};
- option (google.api.metho... | [
"proto/api/v1/ai_service.proto"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\ncat proto/api/v1/ai_service.proto\n```\n\nRepository: usememos/memos\n\nLength of output: 1215\n\n---\n\n🏁 Script executed:\n\n```shell\ncd proto/api/v1 && git log --oneline --... | true | ||
usememos/memos | 5,926 | comment_to_fix | feat(transcription): explicit STT settings with provider, model, prompt | _⚠️ Potential issue_ | _🟠 Major_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
cat -n server/router/api/v1/ai_service.go | head -150 | tail -50
```
Repository: usememos/memos
Length of output: 2025
---
🏁 Script executed:
```shell
# Get the full context of the resolveAIProvider me... | ef55013418d68e2d6a24a6d02a0365c1ffff03d7 | fad6595eceadca039075a217357ee2b7dc8b528f | diff --git a/server/router/api/v1/ai_service.go b/server/router/api/v1/ai_service.go
index ad70b6e3f32bc..35a094ea439bf 100644
--- a/server/router/api/v1/ai_service.go
+++ b/server/router/api/v1/ai_service.go
@@ -17,8 +17,6 @@ import (
const (
maxTranscriptionAudioSizeBytes = 25 * MebiByte
- maxTranscriptionPrompt... | [
"server/router/api/v1/ai_service.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\ncat -n server/router/api/v1/ai_service.go | head -150 | tail -50\n```\n\nRepository: usememos/memos\n\nLength of output: 2025\n\n---\n\n🏁 Script executed:\n\n```shell\n# Get th... | true | ||
usememos/memos | 5,926 | comment_to_fix | feat(transcription): explicit STT settings with provider, model, prompt | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Avoid exposing full transcription defaults to non-admin users**
Line 518 now includes `model/language/prompt` in AI setting responses. Combined with the auth-only (not admin-only) AI read path, this exposes admin-entered prompt hints to all authenticated users, whic... | ef55013418d68e2d6a24a6d02a0365c1ffff03d7 | fad6595eceadca039075a217357ee2b7dc8b528f | diff --git a/server/router/api/v1/instance_service.go b/server/router/api/v1/instance_service.go
index 7a89ec38e1a65..3d0cfa2cf24d7 100644
--- a/server/router/api/v1/instance_service.go
+++ b/server/router/api/v1/instance_service.go
@@ -20,6 +20,12 @@ import (
"github.com/usememos/memos/store"
)
+const (
+ maxTran... | [
"server/router/api/v1/instance_service.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Avoid exposing full transcription defaults to non-admin users**\n\nLine 518 now includes `model/language/prompt` in AI setting responses. Combined with the auth-only (not admin-only) AI read path, this exposes admin-entered prompt hints to all... | true | ||
usememos/memos | 5,926 | comment_to_fix | feat(transcription): explicit STT settings with provider, model, prompt | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Revalidate preserved transcription against updated providers**
When `transcription` is omitted, Line 664-669 preserves the old config and returns early. If the same update removes/renames providers, a stale `provider_id` is persisted without validation, and transcri... | ef55013418d68e2d6a24a6d02a0365c1ffff03d7 | fad6595eceadca039075a217357ee2b7dc8b528f | diff --git a/server/router/api/v1/instance_service.go b/server/router/api/v1/instance_service.go
index 7a89ec38e1a65..3d0cfa2cf24d7 100644
--- a/server/router/api/v1/instance_service.go
+++ b/server/router/api/v1/instance_service.go
@@ -20,6 +20,12 @@ import (
"github.com/usememos/memos/store"
)
+const (
+ maxTran... | [
"server/router/api/v1/instance_service.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Revalidate preserved transcription against updated providers**\n\nWhen `transcription` is omitted, Line 664-669 preserves the old config and returns early. If the same update removes/renames providers, a stale `provider_id` is persisted withou... | true | ||
usememos/memos | 5,926 | comment_to_fix | feat(transcription): explicit STT settings with provider, model, prompt | _⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_
**Don't mutate the local provider state before the save succeeds.**
`persistAISetting()` returns `false` on failure, but both handlers update local state and close the dialog first. If the request is rejected, this screen keeps showing provider/transcription changes t... | ef55013418d68e2d6a24a6d02a0365c1ffff03d7 | fad6595eceadca039075a217357ee2b7dc8b528f | diff --git a/web/src/components/Settings/AISection.tsx b/web/src/components/Settings/AISection.tsx
index 459b2842f3cd8..ba393684ecf6a 100644
--- a/web/src/components/Settings/AISection.tsx
+++ b/web/src/components/Settings/AISection.tsx
@@ -1,7 +1,7 @@
import { create } from "@bufbuild/protobuf";
import { isEqual } f... | [
"web/src/components/Settings/AISection.tsx"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Don't mutate the local provider state before the save succeeds.**\n\n`persistAISetting()` returns `false` on failure, but both handlers update local state and close the dialog first. If the request is rejected, this screen keeps showing provid... | true | ||
usememos/memos | 5,926 | comment_to_fix | feat(transcription): explicit STT settings with provider, model, prompt | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**Mirror the backend length caps in this form.**
The backend now rejects `model > 256`, `language > 32`, and `prompt > 4096`, but these controls allow larger values and only fail after a save attempt. Adding `maxLength` here avoids a round-trip validation error.
<... | ef55013418d68e2d6a24a6d02a0365c1ffff03d7 | fad6595eceadca039075a217357ee2b7dc8b528f | diff --git a/web/src/components/Settings/AISection.tsx b/web/src/components/Settings/AISection.tsx
index 459b2842f3cd8..ba393684ecf6a 100644
--- a/web/src/components/Settings/AISection.tsx
+++ b/web/src/components/Settings/AISection.tsx
@@ -1,7 +1,7 @@
import { create } from "@bufbuild/protobuf";
import { isEqual } f... | [
"web/src/components/Settings/AISection.tsx"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Mirror the backend length caps in this form.**\n\nThe backend now rejects `model > 256`, `language > 32`, and `prompt > 4096`, but these controls allow larger values and only fail after a save attempt. Adding `maxLength` here avoids a round-tr... | true | ||
usememos/memos | 5,926 | comment_to_fix | feat(transcription): explicit STT settings with provider, model, prompt | _⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_
**`codes.InvalidArgument` is semantically incorrect for a configuration-driven failure.**
`ai.DefaultTranscriptionModel(provider.Type)` fails only when the stored provider carries an unrecognized type (data corruption or a missing case in `convertAIProviderTypeFromSto... | ef55013418d68e2d6a24a6d02a0365c1ffff03d7 | fad6595eceadca039075a217357ee2b7dc8b528f | diff --git a/server/router/api/v1/ai_service.go b/server/router/api/v1/ai_service.go
index ad70b6e3f32bc..35a094ea439bf 100644
--- a/server/router/api/v1/ai_service.go
+++ b/server/router/api/v1/ai_service.go
@@ -17,8 +17,6 @@ import (
const (
maxTranscriptionAudioSizeBytes = 25 * MebiByte
- maxTranscriptionPrompt... | [
"server/router/api/v1/ai_service.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**`codes.InvalidArgument` is semantically incorrect for a configuration-driven failure.**\n\n`ai.DefaultTranscriptionModel(provider.Type)` fails only when the stored provider carries an unrecognized type (data corruption or a missing case in `co... | true | ||
usememos/memos | 5,925 | issue_to_patch | feat(memo): create memos on the selected calendar date | When a date is active in the activity calendar, the home memo editor now seeds the new memo's createTime/updateTime to that date and reveals the existing TimestampPopover so the user can adjust before saving. Empty in-month calendar cells also become clickable so users can start the first memo for an empty day.
- Ad... | d349fe4409cd1912c447f43572ab2e102f4964c0 | f403be2fae032e05958ec40204edcecc7b015022 | diff --git a/docs/superpowers/plans/2026-05-02-calendar-date-prefill.md b/docs/superpowers/plans/2026-05-02-calendar-date-prefill.md
new file mode 100644
index 0000000000000..88e8fb2778273
--- /dev/null
+++ b/docs/superpowers/plans/2026-05-02-calendar-date-prefill.md
@@ -0,0 +1,738 @@
+# Calendar-Date Memo Prefill — Im... | [
"docs/superpowers/plans/2026-05-02-calendar-date-prefill.md",
"docs/superpowers/specs/2026-05-02-calendar-date-prefill-design.md",
"web/src/components/ActivityCalendar/CalendarCell.tsx",
"web/src/components/MemoEditor/hooks/useMemoInit.ts",
"web/src/components/MemoEditor/index.tsx",
"web/src/components/Me... | [
{
"comment": "**<sub><sub></sub></sub> Keep default timestamp stable when non-date filters change**\n\n`defaultCreateTime` is recomputed from `new Date()` whenever the whole `filters` array changes, even if the `displayTime` value is unchanged. Beca... | diff --git a/docs/superpowers/specs/2026-05-02-calendar-date-prefill-design.md b/docs/superpowers/specs/2026-05-02-calendar-date-prefill-design.md
new file mode 100644
index 0000000000000..676d919943087
--- /dev/null
+++ b/docs/superpowers/specs/2026-05-02-calendar-date-prefill-design.md
@@ -0,0 +1,165 @@
+# Create mem... | true | |
usememos/memos | 5,925 | comment_to_fix | feat(memo): create memos on the selected calendar date | **<sub><sub></sub></sub> Keep default timestamp stable when non-date filters change**
`defaultCreateTime` is recomputed from `new Date()` whenever the whole `filters` array changes, even if the `displayTime` value is unchanged. Because `MemoEditor` re-sync... | d349fe4409cd1912c447f43572ab2e102f4964c0 | f403be2fae032e05958ec40204edcecc7b015022 | diff --git a/web/src/components/PagedMemoList/PagedMemoList.tsx b/web/src/components/PagedMemoList/PagedMemoList.tsx
index 3432da4c3f8b7..7750a7213b61f 100644
--- a/web/src/components/PagedMemoList/PagedMemoList.tsx
+++ b/web/src/components/PagedMemoList/PagedMemoList.tsx
@@ -2,8 +2,10 @@ import { useQueryClient } from... | [
"web/src/components/PagedMemoList/PagedMemoList.tsx"
] | [
{
"comment": "**<sub><sub></sub></sub> Keep default timestamp stable when non-date filters change**\n\n`defaultCreateTime` is recomputed from `new Date()` whenever the whole `filters` array changes, even if the `displayTime` value is unchanged. Beca... | true | ||
usememos/memos | 5,921 | issue_to_patch | fix(frontend): use correct url path for memos in sitemap.xml | Newer Memos versions use `/memos/<UID>` instead of `/m/<UID>`. Sitemap generation doesn't reflect this change, and URLs result in 404.
This fix replaces `/m/` with `/memos/`. | a0b64176891d40525c1b8b6634150671a71fdc53 | e605da370ce39c99e7f3f520a1b7a3bc0f3bbb89 | diff --git a/server/router/frontend/frontend.go b/server/router/frontend/frontend.go
index 6034484cda5b1..7274c6927b265 100644
--- a/server/router/frontend/frontend.go
+++ b/server/router/frontend/frontend.go
@@ -109,7 +109,7 @@ func (s *FrontendService) getSitemapXML(c *echo.Context) error {
urls := make([]sitemapUR... | [
"server/router/frontend/frontend.go"
] | [] | true | ||
usememos/memos | 5,917 | issue_to_patch | fix(user): omit internal settings from list responses | ## Summary
- Stop converting internal store-only user setting rows into public `generalSetting` responses.
- Keep the real `GENERAL` setting as the source of truth when listing user settings.
- Add a regression test covering mixed internal and public settings.
## Testing
- `go test ./server/router/api/v1/test -count=1... | 0bc56694b0ca347ab1eb083f62997a22007b763d | 9a1e7da41795575f8087b074da9cfc2928c227e4 | diff --git a/server/router/api/v1/user_service.go b/server/router/api/v1/user_service.go
index 8fab09b8dfb3c..4d59b011449de 100644
--- a/server/router/api/v1/user_service.go
+++ b/server/router/api/v1/user_service.go
@@ -1294,6 +1294,10 @@ func convertUserSettingFromStore(storeSetting *storepb.UserSetting, user *store.... | [
"server/router/api/v1/test/user_setting_test.go",
"server/router/api/v1/user_service.go"
] | [] | diff --git a/server/router/api/v1/test/user_setting_test.go b/server/router/api/v1/test/user_setting_test.go
new file mode 100644
index 0000000000000..9e68368ad8a8d
--- /dev/null
+++ b/server/router/api/v1/test/user_setting_test.go
@@ -0,0 +1,58 @@
+package test
+
+import (
+ "context"
+ "testing"
+
+ "github.com/stret... | true | |
usememos/memos | 5,912 | issue_to_patch | chore: refactor Settings UI structure | ## Summary
- consolidate Settings section registration into a single typed registry
- add shared Settings list, panel, code editor, and save updater helpers
- migrate Storage, Tags, Instance, Preferences, Memo, and AI settings onto shared primitives while preserving behavior
## Validation
- cd web && pnpm lint
- cd we... | 14480bfc4638213e2b3ccefa31628704354b9034 | 4df1f7a51e0ae302841a21e318b5dd2bce58d676 | diff --git a/web/src/components/Settings/AISection.tsx b/web/src/components/Settings/AISection.tsx
index 7e0fda6166833..459b2842f3cd8 100644
--- a/web/src/components/Settings/AISection.tsx
+++ b/web/src/components/Settings/AISection.tsx
@@ -11,7 +11,6 @@ import { Input } from "@/components/ui/input";
import { Label } ... | [
"web/src/components/Settings/AISection.tsx",
"web/src/components/Settings/InstanceSection.tsx",
"web/src/components/Settings/MemoRelatedSettings.tsx",
"web/src/components/Settings/PreferencesSection.tsx",
"web/src/components/Settings/SettingGroup.tsx",
"web/src/components/Settings/SettingList.tsx",
"web... | [] | true | ||
usememos/memos | 5,911 | issue_to_patch | chore: upgrade pnpm to 11 | ## Summary
- Pin the web package manager to `pnpm@11.0.0`.
- Move pnpm build-script approval from `package.json#pnpm.onlyBuiltDependencies` to `web/pnpm-workspace.yaml` using `allowBuilds`.
- Update frontend CI, canary, and release workflows to install pnpm 11.
## Validation
- `CI=true npx -y pnpm@11.0.0 install --fro... | 328396a97f2219592032e8418c383e0ab7edaca6 | 799cb5a9b8afa611c55a47b5f6c97d8948cd1114 | diff --git a/.github/workflows/build-canary-image.yml b/.github/workflows/build-canary-image.yml
index 8be60768e268b..ce32aa28cbdaf 100644
--- a/.github/workflows/build-canary-image.yml
+++ b/.github/workflows/build-canary-image.yml
@@ -19,7 +19,7 @@ jobs:
- uses: pnpm/action-setup@v4.2.0
with:
- ... | [
".github/workflows/build-canary-image.yml",
".github/workflows/frontend-tests.yml",
".github/workflows/release.yml",
"AGENTS.md",
"web/package.json",
"web/pnpm-workspace.yaml"
] | [] | true | ||
usememos/memos | 5,903 | issue_to_patch | Profile picture changes are not applied after the initial change
### Pre-submission Checklist
- [x] I have searched existing issues and confirmed this has not already been reported
- [x] This is a bug report, not a question or configuration request
### Memos Version
demo site
### Environment Details
_No response_... | fix(web): sync avatar changes immediately after profile update | ## Summary
Fixes [#5878](https://github.com/usememos/memos/issues/5878) - Profile picture changes are not reflected in the UI after the initial change. Users must reload the page to see updated avatars.
## Root Cause
The v0.28.0 "redesign account and SSO management" migrated from MobX to React Context + React Quer... | 616487fa373e89ce25cffc5cc0d2c22f8802c561 | 71af95e396d082b451c5e449900134aa6b218b7e | diff --git a/web/src/components/UpdateAccountDialog.tsx b/web/src/components/UpdateAccountDialog.tsx
index b74665e31d48b..6013b1b53a54e 100644
--- a/web/src/components/UpdateAccountDialog.tsx
+++ b/web/src/components/UpdateAccountDialog.tsx
@@ -7,6 +7,7 @@ import { Dialog, DialogContent, DialogFooter, DialogHeader, Dia... | [
"web/src/components/UpdateAccountDialog.tsx",
"web/src/contexts/AuthContext.tsx"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Handle `undefined` in `setCurrentUser` cache sync path.**\n\nAt Lines 159-165, passing `undefined` clears context state but leaves React Query user cache untouched. That can produce context/query divergence when consumers read `userKeys.currentUser()`.\n\n<de... | true | |
usememos/memos | 5,903 | comment_to_fix | fix(web): sync avatar changes immediately after profile update | _⚠️ Potential issue_ | _🟡 Minor_
**Handle `undefined` in `setCurrentUser` cache sync path.**
At Lines 159-165, passing `undefined` clears context state but leaves React Query user cache untouched. That can produce context/query divergence when consumers read `userKeys.currentUser()`.
<details>
<summary>Suggested pa... | 616487fa373e89ce25cffc5cc0d2c22f8802c561 | 71af95e396d082b451c5e449900134aa6b218b7e | diff --git a/web/src/contexts/AuthContext.tsx b/web/src/contexts/AuthContext.tsx
index 943b4a2075ed4..f902e8dff8149 100644
--- a/web/src/contexts/AuthContext.tsx
+++ b/web/src/contexts/AuthContext.tsx
@@ -19,6 +19,7 @@ interface AuthContextValue extends AuthState {
initialize: () => Promise<void>;
logout: () => P... | [
"web/src/contexts/AuthContext.tsx"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Handle `undefined` in `setCurrentUser` cache sync path.**\n\nAt Lines 159-165, passing `undefined` clears context state but leaves React Query user cache untouched. That can produce context/query divergence when consumers read `userKeys.currentUser()`.\n\n<de... | true | ||
usememos/memos | 5,902 | issue_to_patch | Dark theme text is unreadable
### Pre-submission Checklist
- [x] I have searched existing issues and confirmed this has not already been reported
- [x] This is a bug report, not a question or configuration request
### Memos Version
0.28.0
### Environment Details
- Deployment: Docker
- Browser: Firefox 150.0
- OS... | chore: increased muted text contrast in dark theme | Closes #5899
This PR updates the --muted-foreground color variable in the dark theme CSS to resolve a reported accessibility issue.
### Changes:
- Adjusted --muted-foreground from oklch(0.56 0.005 265) to oklch(0.76 0.005 265).
- This increases the contrast ratio against the background from 3.01:1 to approxi... | 616487fa373e89ce25cffc5cc0d2c22f8802c561 | 412362417c588371330a932b11ebd9eb255b4d4a | diff --git a/web/src/themes/default-dark.css b/web/src/themes/default-dark.css
index 93a4c2f9409aa..fda9fe53285d2 100644
--- a/web/src/themes/default-dark.css
+++ b/web/src/themes/default-dark.css
@@ -20,7 +20,7 @@
/* Muted — inline backgrounds (code, skeletons, error panels) */
--muted: oklch(0.21 0.008 265);
... | [
"web/src/themes/default-dark.css"
] | [] | true | |
usememos/memos | 5,900 | issue_to_patch | chore: update backend and frontend dependencies | ## Summary
- Update Go module dependencies and tidy with Go 1.26.2.
- Update frontend pnpm dependencies and lockfile.
- Align Go 1.26.2 across CI, release workflow, Dockerfile, and AGENTS guidance.
- Adjust the testcontainers HostConfig import for the updated API.
## Validation
- `pnpm lint`
- `pnpm build`
- `go test ... | 18e729fe0037e740649f87feaa53c1dadf7cc8e9 | 52d3fde0c90fb72a19c4f4e6228a8adc6a4ba503 | diff --git a/.github/workflows/backend-tests.yml b/.github/workflows/backend-tests.yml
index 1f12fc61c60d9..3f52fedc759ef 100644
--- a/.github/workflows/backend-tests.yml
+++ b/.github/workflows/backend-tests.yml
@@ -15,7 +15,7 @@ concurrency:
cancel-in-progress: true
env:
- GO_VERSION: "1.26.1"
+ GO_VERSION: "... | [
".github/workflows/backend-tests.yml",
".github/workflows/release.yml",
"AGENTS.md",
"go.mod",
"go.sum",
"scripts/Dockerfile",
"store/test/containers.go",
"web/package.json",
"web/pnpm-lock.yaml"
] | [] | diff --git a/store/test/containers.go b/store/test/containers.go
index e9760b6a1644a..177d77feb53a8 100644
--- a/store/test/containers.go
+++ b/store/test/containers.go
@@ -13,8 +13,8 @@ import (
"testing"
"time"
- "github.com/docker/docker/api/types/container"
mysqldriver "github.com/go-sql-driver/mysql"
+ "gi... | true | |
usememos/memos | 5,681 | issue_to_patch | Notes disappearing when returning to homepage
### Pre-submission Checklist
- [x] I have searched the existing issues and this bug has not been reported yet
- [x] I have tested this issue on the [demo site](https://demo.usememos.com) or the latest version
### Where did you encounter this bug?
Latest stable version (... | fix: access token refresh on web app | A bug exists within the token refresh flow that invalidates active browser sessions. Retrieving the active access token returns `null` if it's expired. Seem like a small oversight when token storage was migrated to the jwt tokens.
This means expired tokens don't refresh, and if leave the browser tab idle for 15min, ... | 0729779e0427c68bdbc5b6b711a5683f66ba9bbc | 32b6ca33b85bda867c0a0a78655240d2b04de47b | diff --git a/web/src/connect.ts b/web/src/connect.ts
index 199f59a85c981..9a6d4cff493cc 100644
--- a/web/src/connect.ts
+++ b/web/src/connect.ts
@@ -1,7 +1,7 @@
import { timestampDate } from "@bufbuild/protobuf/wkt";
import { Code, ConnectError, createClient, type Interceptor } from "@connectrpc/connect";
import { c... | [
"web/src/connect.ts",
"web/src/hooks/useTokenRefreshOnFocus.ts"
] | [
{
"comment": "this was the bug: `getAccessToken()` returns null if the token we have is expired, meaning we don't get a chance to refresh it",
"path": "web/src/hooks/useTokenRefreshOnFocus.ts",
"hunk": "@@ -20,9 +20,8 @@ export function useTokenRefreshOnFocus(refreshFn: () => Promise<void>, enabled:\n ... | true | |
usememos/memos | 5,681 | comment_to_fix | fix: access token refresh on web app | this was the bug: `getAccessToken()` returns null if the token we have is expired, meaning we don't get a chance to refresh it | 0729779e0427c68bdbc5b6b711a5683f66ba9bbc | 32b6ca33b85bda867c0a0a78655240d2b04de47b | diff --git a/web/src/hooks/useTokenRefreshOnFocus.ts b/web/src/hooks/useTokenRefreshOnFocus.ts
index cab7575c74dca..f838087d0ba0b 100644
--- a/web/src/hooks/useTokenRefreshOnFocus.ts
+++ b/web/src/hooks/useTokenRefreshOnFocus.ts
@@ -1,5 +1,5 @@
import { useEffect } from "react";
-import { FOCUS_TOKEN_EXPIRY_BUFFER_MS,... | [
"web/src/hooks/useTokenRefreshOnFocus.ts"
] | [
{
"comment": "this was the bug: `getAccessToken()` returns null if the token we have is expired, meaning we don't get a chance to refresh it",
"path": "web/src/hooks/useTokenRefreshOnFocus.ts",
"hunk": "@@ -20,9 +20,8 @@ export function useTokenRefreshOnFocus(refreshFn: () => Promise<void>, enabled:\n ... | true | ||
usememos/memos | 5,866 | issue_to_patch | chore(main): release 0.28.0 | :robot: I have created a release *beep* *boop*
---
## [0.28.0](https://github.com/usememos/memos/compare/v0.27.1...v0.28.0) (2026-04-27)
### Features
* **auth:** add SSO user identity linkage ([#5883](https://github.com/usememos/memos/issues/5883)) ([d688914](https://github.com/usememos/memos/commit/d688914b286479... | 94ce1e53476d9d15eabdc5ea3f0472468693d42d | 88e58727c674c1153f02c81c454c85f5d36125fd | diff --git a/.release-please-manifest.json b/.release-please-manifest.json
index 1f59b6814a3de..9800444892ca3 100644
--- a/.release-please-manifest.json
+++ b/.release-please-manifest.json
@@ -1,3 +1,3 @@
{
- ".": "0.27.1"
+ ".": "0.28.0"
}
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 63a63ff329206..99bd2b5ab9680... | [
".release-please-manifest.json",
"CHANGELOG.md"
] | [] | true | ||
usememos/memos | 5,894 | issue_to_patch | feat(memos): choose created or updated time for memos | ## Summary
- Add a local view preference for choosing whether memos use created time or updated time as their shown time basis.
- Use that same time basis for memo list ordering and memo card timestamps, with created time as the default.
- Keep the control in the existing search display settings menu and update the lab... | 3949a252dbcf0c78458b845aeb345ded8f461423 | 03cfb6f516e206b33faf2a4df10a2552a9060ef9 | diff --git a/proto/api/v1/instance_service.proto b/proto/api/v1/instance_service.proto
index 91bbcf632e566..1ab587570ede6 100644
--- a/proto/api/v1/instance_service.proto
+++ b/proto/api/v1/instance_service.proto
@@ -158,8 +158,8 @@ message InstanceSetting {
// Memo-related instance settings and policies.
messa... | [
"proto/api/v1/instance_service.proto",
"proto/api/v1/memo_service.proto",
"proto/api/v1/user_service.proto",
"proto/gen/api/v1/instance_service.pb.go",
"proto/gen/api/v1/memo_service.pb.go",
"proto/gen/api/v1/user_service.pb.go",
"proto/gen/openapi.yaml",
"proto/gen/store/instance_setting.pb.go",
"p... | [] | diff --git a/server/router/api/v1/test/memo_service_test.go b/server/router/api/v1/test/memo_service_test.go
index ed61e042d4864..dffff1ec502ac 100644
--- a/server/router/api/v1/test/memo_service_test.go
+++ b/server/router/api/v1/test/memo_service_test.go
@@ -254,6 +254,120 @@ func TestListMemos(t *testing.T) {
requ... | true | |
usememos/memos | 5,890 | issue_to_patch | fix(auth): harden authorization and username validation | ## Summary
- Reject archived users across access-token authenticated flows
- Require memo ownership before attaching uploads or updating memo attachments
- Separate writable username validation from legacy resource-name lookup
- Restrict state changes and tighten Connect CORS origin checks
- Make first-user admin creat... | ee1799851e88674a6920c7a56d93428fcf95e662 | 2d7a0f1439068d9cfa88e892f91a5188dfbc3ae4 | diff --git a/server/auth/authenticator.go b/server/auth/authenticator.go
index d66961b1adb06..16e98611fd1b7 100644
--- a/server/auth/authenticator.go
+++ b/server/auth/authenticator.go
@@ -141,7 +141,14 @@ func (a *Authenticator) AuthenticateToUser(ctx context.Context, authHeader, cook
if !strings.HasPrefix(token, ... | [
"server/auth/authenticator.go",
"server/router/api/v1/attachment_service.go",
"server/router/api/v1/auth_service.go",
"server/router/api/v1/common.go",
"server/router/api/v1/connect_interceptors_test.go",
"server/router/api/v1/memo_attachment_service.go",
"server/router/api/v1/sso_username.go",
"serve... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify existing patterns for obtaining request scheme in this repo\nrg -nP --type=go -C2 '\\b(IsTLS|Scheme)\\s*\\(' -g '!**/vendor/**'\n# Check other CORS / origi... | diff --git a/server/router/api/v1/connect_interceptors_test.go b/server/router/api/v1/connect_interceptors_test.go
index b4f8c79b96492..62925610f3287 100644
--- a/server/router/api/v1/connect_interceptors_test.go
+++ b/server/router/api/v1/connect_interceptors_test.go
@@ -2,11 +2,16 @@ package v1
import (
"context... | true | |
usememos/memos | 5,890 | comment_to_fix | fix(auth): harden authorization and username validation | _⚠️ Potential issue_ | _🟡 Minor_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Verify existing patterns for obtaining request scheme in this repo
rg -nP --type=go -C2 '\b(IsTLS|Scheme)\s*\(' -g '!**/vendor/**'
# Check other CORS / origin handling sites for reference
rg -n... | ee1799851e88674a6920c7a56d93428fcf95e662 | 2d7a0f1439068d9cfa88e892f91a5188dfbc3ae4 | diff --git a/server/router/api/v1/v1.go b/server/router/api/v1/v1.go
index ad974b4a5a187..259a1b8b92412 100644
--- a/server/router/api/v1/v1.go
+++ b/server/router/api/v1/v1.go
@@ -3,6 +3,8 @@ package v1
import (
"context"
"net/http"
+ "net/url"
+ "strings"
"connectrpc.com/connect"
"github.com/grpc-ecosystem... | [
"server/router/api/v1/v1.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Verify existing patterns for obtaining request scheme in this repo\nrg -nP --type=go -C2 '\\b(IsTLS|Scheme)\\s*\\(' -g '!**/vendor/**'\n# Check other CORS / origi... | true | ||
usememos/memos | 5,890 | comment_to_fix | fix(auth): harden authorization and username validation | _⚠️ Potential issue_ | _🟠 Major_
**Wrong gRPC code for unauthenticated callers; downstream effect on six call sites.**
When `currentUser == nil`, `authorizeUserResourceAccess` returns `codes.PermissionDenied` (Line 690). The rest of this file consistently uses `codes.Unauthenticated` for the "no current user" case (... | ee1799851e88674a6920c7a56d93428fcf95e662 | 2d7a0f1439068d9cfa88e892f91a5188dfbc3ae4 | diff --git a/server/router/api/v1/user_service.go b/server/router/api/v1/user_service.go
index 4550815f9f76c..8fab09b8dfb3c 100644
--- a/server/router/api/v1/user_service.go
+++ b/server/router/api/v1/user_service.go
@@ -78,21 +78,23 @@ func (s *APIV1Service) ListUsers(ctx context.Context, request *v1pb.ListUsersReq
... | [
"server/router/api/v1/user_service.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Wrong gRPC code for unauthenticated callers; downstream effect on six call sites.**\n\nWhen `currentUser == nil`, `authorizeUserResourceAccess` returns `codes.PermissionDenied` (Line 690). The rest of this file consistently uses `codes.Unauthenticated` for th... | true | ||
usememos/memos | 5,886 | issue_to_patch | feat: redesign account and SSO management | ## What changed
This PR refreshes the account and SSO management experience in settings and hardens user deletion cleanup on the backend.
- redesigned the SSO provider, linked identity, and member tables into a clearer information-flow layout
- reorganized the SSO create/update dialog into grouped sections with bette... | 30c0611a82f9254952a74650095105254f2940e4 | 3e428667e7e9e0c7bd0061ffddb83bc9ae9b6908 | diff --git a/internal/idp/oauth2/oauth2.go b/internal/idp/oauth2/oauth2.go
index 8354024a51bf5..a6915e41b3e91 100644
--- a/internal/idp/oauth2/oauth2.go
+++ b/internal/idp/oauth2/oauth2.go
@@ -8,6 +8,7 @@ import (
"io"
"log/slog"
"net/http"
+ "time"
"github.com/pkg/errors"
"golang.org/x/oauth2"
@@ -21,6 +22... | [
"internal/idp/oauth2/oauth2.go",
"internal/idp/oauth2/oauth2_test.go",
"server/router/api/v1/auth_service.go",
"server/router/api/v1/test/test_helper.go",
"server/router/api/v1/test/user_service_delete_test.go",
"server/router/api/v1/user_service.go",
"store/attachment.go",
"store/db/mysql/memo_share.... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Handler logic looks correct; one UX nit on error ordering.**\n\nFlow is sound: transactional delete via `DeleteUserCompletely`, per-attachment storage cleanup with per-item logging, auth-cookie clearing for self-delete regardless of cleanup outcome, and final... | diff --git a/internal/idp/oauth2/oauth2_test.go b/internal/idp/oauth2/oauth2_test.go
index c7039f5bd0d8c..0bec3d69a465c 100644
--- a/internal/idp/oauth2/oauth2_test.go
+++ b/internal/idp/oauth2/oauth2_test.go
@@ -152,7 +152,7 @@ func TestIdentityProvider(t *testing.T) {
require.NoError(t, err)
require.Equal(t, test... | true | |
usememos/memos | 5,886 | comment_to_fix | feat: redesign account and SSO management | _⚠️ Potential issue_ | _🟡 Minor_
**Handler logic looks correct; one UX nit on error ordering.**
Flow is sound: transactional delete via `DeleteUserCompletely`, per-attachment storage cleanup with per-item logging, auth-cookie clearing for self-delete regardless of cleanup outcome, and finally a single propagated err... | 30c0611a82f9254952a74650095105254f2940e4 | 3e428667e7e9e0c7bd0061ffddb83bc9ae9b6908 | diff --git a/server/router/api/v1/user_service.go b/server/router/api/v1/user_service.go
index 9e587859cc0cc..4550815f9f76c 100644
--- a/server/router/api/v1/user_service.go
+++ b/server/router/api/v1/user_service.go
@@ -353,27 +353,37 @@ func (s *APIV1Service) DeleteUser(ctx context.Context, request *v1pb.DeleteUserR
... | [
"server/router/api/v1/user_service.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Handler logic looks correct; one UX nit on error ordering.**\n\nFlow is sound: transactional delete via `DeleteUserCompletely`, per-attachment storage cleanup with per-item logging, auth-cookie clearing for self-delete regardless of cleanup outcome, and final... | true | ||
usememos/memos | 5,886 | comment_to_fix | feat: redesign account and SSO management | _⚠️ Potential issue_ | _🔴 Critical_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Find how userCache is populated to learn its key format.
rg -nP -C3 '\buserCache\.(Set|Add|Store|Put|Get)\s*\(' --type=go
# Also check getUserSettingCacheKey for reference on the canonical I... | 30c0611a82f9254952a74650095105254f2940e4 | 3e428667e7e9e0c7bd0061ffddb83bc9ae9b6908 | diff --git a/store/user_delete.go b/store/user_delete.go
new file mode 100644
index 0000000000000..110c7fa205905
--- /dev/null
+++ b/store/user_delete.go
@@ -0,0 +1,666 @@
+package store
+
+import (
+ "context"
+ "database/sql"
+ "fmt"
+ "strings"
+
+ "github.com/pkg/errors"
+
+ storepb "github.com/usememos/memos/proto... | [
"store/user_delete.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Find how userCache is populated to learn its key format.\nrg -nP -C3 '\\buserCache\\.(Set|Add|Store|Put|Get)\\s*\\(' --type=go\n# Also check getUserSettingCach... | true | ||
usememos/memos | 5,886 | comment_to_fix | feat: redesign account and SSO management | _⚠️ Potential issue_ | _🟠 Major_
<details>
<summary>🧩 Analysis chain</summary>
🏁 Script executed:
```shell
#!/bin/bash
# Check the documented/declared minimum MySQL version for this project.
rg -n -C2 -i 'mysql' README.md docs/ 2>/dev/null | rg -i '8\.0|5\.[67]|version'
# And check existing usages of WITH RECURSI... | 30c0611a82f9254952a74650095105254f2940e4 | 3e428667e7e9e0c7bd0061ffddb83bc9ae9b6908 | diff --git a/store/user_delete.go b/store/user_delete.go
new file mode 100644
index 0000000000000..110c7fa205905
--- /dev/null
+++ b/store/user_delete.go
@@ -0,0 +1,666 @@
+package store
+
+import (
+ "context"
+ "database/sql"
+ "fmt"
+ "strings"
+
+ "github.com/pkg/errors"
+
+ storepb "github.com/usememos/memos/proto... | [
"store/user_delete.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Check the documented/declared minimum MySQL version for this project.\nrg -n -C2 -i 'mysql' README.md docs/ 2>/dev/null | rg -i '8\\.0|5\\.[67]|version'\n# And ch... | true | ||
usememos/memos | 5,886 | comment_to_fix | feat: redesign account and SSO management | _⚠️ Potential issue_ | _🟠 Major_
**Full inbox table scan scales poorly; push the sender/receiver/message filter into SQL.**
`listDeleteUserInboxIDs` issues `SELECT id, sender_id, receiver_id, message FROM inbox` with no `WHERE` clause and then filters in Go. On instances with a large inbox history (which is exactly ... | 30c0611a82f9254952a74650095105254f2940e4 | 3e428667e7e9e0c7bd0061ffddb83bc9ae9b6908 | diff --git a/store/user_delete.go b/store/user_delete.go
new file mode 100644
index 0000000000000..110c7fa205905
--- /dev/null
+++ b/store/user_delete.go
@@ -0,0 +1,666 @@
+package store
+
+import (
+ "context"
+ "database/sql"
+ "fmt"
+ "strings"
+
+ "github.com/pkg/errors"
+
+ storepb "github.com/usememos/memos/proto... | [
"store/user_delete.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Full inbox table scan scales poorly; push the sender/receiver/message filter into SQL.**\n\n`listDeleteUserInboxIDs` issues `SELECT id, sender_id, receiver_id, message FROM inbox` with no `WHERE` clause and then filters in Go. On instances with a large inbox ... | true | ||
usememos/memos | 5,886 | comment_to_fix | feat: redesign account and SSO management | _⚠️ Potential issue_ | _🟡 Minor_
**Apply the submit lock to dialog-level closes.**
Line 285 only guards the Cancel button. Escape/outside-close can still call `onOpenChange` on Line 393 and reset dialog state while the request is in flight.
<details>
<summary>Proposed fix</summary>
```diff
- <Dialog open={open... | 30c0611a82f9254952a74650095105254f2940e4 | 3e428667e7e9e0c7bd0061ffddb83bc9ae9b6908 | diff --git a/web/src/components/CreateIdentityProviderDialog.tsx b/web/src/components/CreateIdentityProviderDialog.tsx
index 64d370a6d5a4c..3197502d164e9 100644
--- a/web/src/components/CreateIdentityProviderDialog.tsx
+++ b/web/src/components/CreateIdentityProviderDialog.tsx
@@ -1,12 +1,12 @@
import { create } from "... | [
"web/src/components/CreateIdentityProviderDialog.tsx"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Apply the submit lock to dialog-level closes.**\n\nLine 285 only guards the Cancel button. Escape/outside-close can still call `onOpenChange` on Line 393 and reset dialog state while the request is in flight.\n\n\n<details>\n<summary>Proposed fix</summary>\n\... | true | ||
usememos/memos | 5,886 | comment_to_fix | feat: redesign account and SSO management | _⚠️ Potential issue_ | _🟡 Minor_
**Make tooltip chips keyboard-accessible.**
The tooltip trigger is a plain non-focusable `span`, so keyboard users cannot reveal the full truncated value.
<details>
<summary>♿ Proposed fix</summary>
```diff
return (
<Tooltip>
<TooltipTrigger asChild>
- <span c... | 30c0611a82f9254952a74650095105254f2940e4 | 3e428667e7e9e0c7bd0061ffddb83bc9ae9b6908 | diff --git a/web/src/components/Settings/InfoChip.tsx b/web/src/components/Settings/InfoChip.tsx
new file mode 100644
index 0000000000000..e39fa0e1e73a0
--- /dev/null
+++ b/web/src/components/Settings/InfoChip.tsx
@@ -0,0 +1,42 @@
+import { Badge } from "@/components/ui/badge";
+import { Tooltip, TooltipContent, Toolti... | [
"web/src/components/Settings/InfoChip.tsx"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Make tooltip chips keyboard-accessible.**\n\nThe tooltip trigger is a plain non-focusable `span`, so keyboard users cannot reveal the full truncated value.\n\n<details>\n<summary>♿ Proposed fix</summary>\n\n```diff\n return (\n <Tooltip>\n <Toolti... | true | ||
usememos/memos | 5,886 | comment_to_fix | feat: redesign account and SSO management | _⚠️ Potential issue_ | _🟡 Minor_
<details>
<summary>🧩 Analysis chain</summary>
🌐 Web query:
`SQLite default SQLITE_MAX_VARIABLE_NUMBER and PostgreSQL max bind parameters per query`
💡 Result:
SQLite default SQLITE_MAX_VARIABLE_NUMBER is 32766 (for versions 3.32.0 and later). PostgreSQL maximum bind parameters (... | 30c0611a82f9254952a74650095105254f2940e4 | 3e428667e7e9e0c7bd0061ffddb83bc9ae9b6908 | diff --git a/store/user_delete.go b/store/user_delete.go
new file mode 100644
index 0000000000000..110c7fa205905
--- /dev/null
+++ b/store/user_delete.go
@@ -0,0 +1,666 @@
+package store
+
+import (
+ "context"
+ "database/sql"
+ "fmt"
+ "strings"
+
+ "github.com/pkg/errors"
+
+ storepb "github.com/usememos/memos/proto... | [
"store/user_delete.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`SQLite default SQLITE_MAX_VARIABLE_NUMBER and PostgreSQL max bind parameters per query`\n\n💡 Result:\n\nSQLite default SQLITE_MAX_VARIABLE_NUMBER is 32766 (for versions 3.32.0 and later). Pos... | true | ||
usememos/memos | 5,885 | issue_to_patch | fix: fix legacy username auth flows | ## What changed
- allow user-service lookups to resolve existing accounts even when their usernames no longer satisfy the current validation rules
- keep username validation on create/rename paths, while letting legacy SSO-created email-like usernames be renamed, archived, or deleted
- harden auth/session handling by f... | d688914b2864791eeadbf21c882608632875f17c | 6e30abe003e30ab6c80a79dcf2fb566ceaf57637 | diff --git a/server/router/api/v1/auth_service.go b/server/router/api/v1/auth_service.go
index 85d904dc8b04b..86ae6cd9ee1f7 100644
--- a/server/router/api/v1/auth_service.go
+++ b/server/router/api/v1/auth_service.go
@@ -529,6 +529,36 @@ func (s *APIV1Service) clearAuthCookies(ctx context.Context) error {
return nil
... | [
"server/router/api/v1/auth_service.go",
"server/router/api/v1/auth_service_client_info_test.go",
"server/router/api/v1/connect_interceptors.go",
"server/router/api/v1/connect_interceptors_test.go",
"server/router/api/v1/test/shortcut_service_test.go",
"server/router/api/v1/test/user_notification_test.go",... | [] | diff --git a/server/router/api/v1/auth_service_client_info_test.go b/server/router/api/v1/auth_service_client_info_test.go
index 300663c04583e..682fd7f583e5f 100644
--- a/server/router/api/v1/auth_service_client_info_test.go
+++ b/server/router/api/v1/auth_service_client_info_test.go
@@ -2,7 +2,9 @@ package v1
impor... | true | |
usememos/memos | 5,883 | issue_to_patch | feat(auth): add SSO user identity linkage | ## Summary
- Add a `user_identity` model and per-database migrations to link external SSO subjects to local users.
- Resolve SSO sign-ins through the linkage table instead of using the external identifier as the local username.
- Derive new SSO usernames from profile data with collision handling and cleanup for concurr... | 50638040f618b02b0c6d010e1d41554c75067517 | e35fcf91f3b4124ab0d15223e1ca85715b0e99c1 | diff --git a/.gitignore b/.gitignore
index 29b7afb28c88d..6b0f27999b4d3 100644
--- a/.gitignore
+++ b/.gitignore
@@ -9,9 +9,6 @@ build/
bin/
memos
-# Plan/design documents
-docs/plans/
-
.DS_Store
# Jetbrains
diff --git a/docs/issues/2026-03-23-memo-detail-outline/definition.md b/docs/plans/2026-03-23-memo-deta... | [
".gitignore",
"docs/plans/2026-03-23-memo-detail-outline/definition.md",
"docs/plans/2026-03-23-memo-detail-outline/plan.md",
"docs/plans/2026-03-23-tag-blur-attribute/definition.md",
"docs/plans/2026-03-23-tag-blur-attribute/execution.md",
"docs/plans/2026-03-23-tag-blur-attribute/plan.md",
"docs/plans... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Hyphenate `open-source` when used as a compound modifier.**\n\nSmall docs polish: `upstream open source schemas` should be `upstream open-source schemas`.\n\n\n<details>\n<summary>📝 Proposed wording fix</summary>\n\n```diff\n-The existing issue artifacts und... | diff --git a/server/router/api/v1/test/auth_service_test.go b/server/router/api/v1/test/auth_service_test.go
new file mode 100644
index 0000000000000..f415565568f60
--- /dev/null
+++ b/server/router/api/v1/test/auth_service_test.go
@@ -0,0 +1,254 @@
+package test
+
+import (
+ "context"
+ "encoding/json"
+ "io"
+ "net/... | true | |
usememos/memos | 5,880 | issue_to_patch | fix: reduce list memo query overhead | ## Summary
This PR reduces `ListMemos` overhead without changing schema or adding indexes.
It makes three targeted changes:
- split memo relation batch lookups into directional queries and avoid eager relation snippet hydration on list responses
- reuse creator and display-time data across list conversion work in the... | b5863d76be3cfbf3e0f8237d8e762122b5a0a679 | f133abc8c0419b82c98fb98a4e670328d5f96ab1 | diff --git a/server/router/api/v1/memo_service.go b/server/router/api/v1/memo_service.go
index 48323ca49626d..497be456c155a 100644
--- a/server/router/api/v1/memo_service.go
+++ b/server/router/api/v1/memo_service.go
@@ -297,18 +297,22 @@ func (s *APIV1Service) ListMemos(ctx context.Context, request *v1pb.ListMemosReq
... | [
"server/router/api/v1/memo_service.go",
"server/router/api/v1/memo_service_converter.go",
"server/router/api/v1/memo_share_service.go",
"server/router/api/v1/test/memo_service_benchmark_test.go",
"store/db/mysql/memo_relation.go",
"store/db/postgres/memo_relation.go",
"store/db/sqlite/memo_relation.go",... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Reuse the setting already loaded in `ListMemos`.**\n\n`ListMemos` fetched `instanceMemoRelatedSetting` earlier at Line 221, so this second store call adds hot-path overhead and could make ordering/display-time conversion inconsistent if the setting changes mi... | diff --git a/server/router/api/v1/test/memo_service_benchmark_test.go b/server/router/api/v1/test/memo_service_benchmark_test.go
new file mode 100644
index 0000000000000..e880317bf54d0
--- /dev/null
+++ b/server/router/api/v1/test/memo_service_benchmark_test.go
@@ -0,0 +1,282 @@
+package test
+
+import (
+ "context"
+ ... | true | |
usememos/memos | 5,880 | comment_to_fix | fix: reduce list memo query overhead | _⚠️ Potential issue_ | _🟡 Minor_
**Reuse the setting already loaded in `ListMemos`.**
`ListMemos` fetched `instanceMemoRelatedSetting` earlier at Line 221, so this second store call adds hot-path overhead and could make ordering/display-time conversion inconsistent if the setting changes mid-request.
<details>
<su... | b5863d76be3cfbf3e0f8237d8e762122b5a0a679 | f133abc8c0419b82c98fb98a4e670328d5f96ab1 | diff --git a/server/router/api/v1/memo_service.go b/server/router/api/v1/memo_service.go
index 48323ca49626d..497be456c155a 100644
--- a/server/router/api/v1/memo_service.go
+++ b/server/router/api/v1/memo_service.go
@@ -297,18 +297,22 @@ func (s *APIV1Service) ListMemos(ctx context.Context, request *v1pb.ListMemosReq
... | [
"server/router/api/v1/memo_service.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Reuse the setting already loaded in `ListMemos`.**\n\n`ListMemos` fetched `instanceMemoRelatedSetting` earlier at Line 221, so this second store call adds hot-path overhead and could make ordering/display-time conversion inconsistent if the setting changes mi... | true | ||
usememos/memos | 5,880 | comment_to_fix | fix: reduce list memo query overhead | _⚠️ Potential issue_ | _🟡 Minor_
**Stale doc comment on `MemoIDList`.**
After this PR, the sqlite/mysql/postgres drivers filter `MemoIDList` only against `memo_id` (with `RelatedMemoIDList` covering the inbound side). The "memo_id OR related_memo_id" wording no longer reflects the behavior and will mislead callers w... | b5863d76be3cfbf3e0f8237d8e762122b5a0a679 | f133abc8c0419b82c98fb98a4e670328d5f96ab1 | diff --git a/store/memo_relation.go b/store/memo_relation.go
index d341c9b0b4e16..12a448665f6da 100644
--- a/store/memo_relation.go
+++ b/store/memo_relation.go
@@ -26,8 +26,12 @@ type FindMemoRelation struct {
MemoFilter *string
// MemoIDList matches relations where memo_id OR related_memo_id is in the list.
... | [
"store/memo_relation.go"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Stale doc comment on `MemoIDList`.**\n\nAfter this PR, the sqlite/mysql/postgres drivers filter `MemoIDList` only against `memo_id` (with `RelatedMemoIDList` covering the inbound side). The \"memo_id OR related_memo_id\" wording no longer reflects the behavio... | true | ||
usememos/memos | 5,879 | issue_to_patch | docs: refine SSO identity linkage design | ## Summary
- expand the SSO identity-linkage research with verified upstream schema references
- clarify the issue definition around provider-scoped identity linkage patterns
- keep the proposed memos table name as `user_identity` while retaining `provider` and `extern_uid`
## Testing
- not run (docs only) | b5863d76be3cfbf3e0f8237d8e762122b5a0a679 | 39cc6b11d5330fa8527e342833e1166c5f99d222 | diff --git a/docs/issues/2026-04-21-sso-user-identity-linkage/definition.md b/docs/issues/2026-04-21-sso-user-identity-linkage/definition.md
new file mode 100644
index 0000000000000..7b55c0a18586b
--- /dev/null
+++ b/docs/issues/2026-04-21-sso-user-identity-linkage/definition.md
@@ -0,0 +1,70 @@
+## Background & Contex... | [
"docs/issues/2026-04-21-sso-user-identity-linkage/definition.md",
"docs/issues/2026-04-21-sso-user-identity-linkage/design.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Use “open-source” for standard hyphenation.**\n\nSmall docs polish: “open source schemas” should be “open-source schemas.”\n\n<details>\n<summary>🧰 Tools</summary>\n\n<details>\n<summary>🪛 LanguageTool</summary>\n\n[grammar] ~5-~5: Use a hyphen to join word... | true | ||
usememos/memos | 5,879 | comment_to_fix | docs: refine SSO identity linkage design | _⚠️ Potential issue_ | _🟡 Minor_
**Use “open-source” for standard hyphenation.**
Small docs polish: “open source schemas” should be “open-source schemas.”
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 LanguageTool</summary>
[grammar] ~5-~5: Use a hyphen to join words.
Context: ...users. A broader re... | b5863d76be3cfbf3e0f8237d8e762122b5a0a679 | 39cc6b11d5330fa8527e342833e1166c5f99d222 | diff --git a/docs/issues/2026-04-21-sso-user-identity-linkage/definition.md b/docs/issues/2026-04-21-sso-user-identity-linkage/definition.md
new file mode 100644
index 0000000000000..7b55c0a18586b
--- /dev/null
+++ b/docs/issues/2026-04-21-sso-user-identity-linkage/definition.md
@@ -0,0 +1,70 @@
+## Background & Contex... | [
"docs/issues/2026-04-21-sso-user-identity-linkage/definition.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Use “open-source” for standard hyphenation.**\n\nSmall docs polish: “open source schemas” should be “open-source schemas.”\n\n<details>\n<summary>🧰 Tools</summary>\n\n<details>\n<summary>🪛 LanguageTool</summary>\n\n[grammar] ~5-~5: Use a hyphen to join word... | true | ||
usememos/memos | 5,879 | comment_to_fix | docs: refine SSO identity linkage design | _⚠️ Potential issue_ | _🟡 Minor_
**Use “open-source” for consistency.**
Minor wording fix: “open source systems” → “open-source systems.”
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 LanguageTool</summary>
[grammar] ~30-~30: Use a hyphen to join words.
Context: ...ame for SSO identity linkage acros... | b5863d76be3cfbf3e0f8237d8e762122b5a0a679 | 39cc6b11d5330fa8527e342833e1166c5f99d222 | diff --git a/docs/issues/2026-04-21-sso-user-identity-linkage/design.md b/docs/issues/2026-04-21-sso-user-identity-linkage/design.md
new file mode 100644
index 0000000000000..45e3ae33121a5
--- /dev/null
+++ b/docs/issues/2026-04-21-sso-user-identity-linkage/design.md
@@ -0,0 +1,173 @@
+## References
+
+1. **GitLab `db/... | [
"docs/issues/2026-04-21-sso-user-identity-linkage/design.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Use “open-source” for consistency.**\n\nMinor wording fix: “open source systems” → “open-source systems.”\n\n<details>\n<summary>🧰 Tools</summary>\n\n<details>\n<summary>🪛 LanguageTool</summary>\n\n[grammar] ~30-~30: Use a hyphen to join words.\nContext: ..... | true | ||
usememos/memos | 5,879 | comment_to_fix | docs: refine SSO identity linkage design | _⚠️ Potential issue_ | _🟠 Major_
**Define atomic first-login semantics to prevent orphan users on race.**
The miss path (“create user, then insert identity row”) needs explicit transaction/conflict handling. Concurrent first sign-ins for the same `(provider, extern_uid)` can otherwise create an extra local user and ... | b5863d76be3cfbf3e0f8237d8e762122b5a0a679 | 39cc6b11d5330fa8527e342833e1166c5f99d222 | diff --git a/docs/issues/2026-04-21-sso-user-identity-linkage/design.md b/docs/issues/2026-04-21-sso-user-identity-linkage/design.md
new file mode 100644
index 0000000000000..45e3ae33121a5
--- /dev/null
+++ b/docs/issues/2026-04-21-sso-user-identity-linkage/design.md
@@ -0,0 +1,173 @@
+## References
+
+1. **GitLab `db/... | [
"docs/issues/2026-04-21-sso-user-identity-linkage/design.md"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Define atomic first-login semantics to prevent orphan users on race.**\n\nThe miss path (“create user, then insert identity row”) needs explicit transaction/conflict handling. Concurrent first sign-ins for the same `(provider, extern_uid)` can otherwise creat... | true | ||
usememos/memos | 5,871 | issue_to_patch | SSO: fall back to raw identifier lookup when transform is active | When `identifier_transform` is configured on an IdP, sign-in was looking up users exclusively by the transformed username. Accounts created before the transform was added (stored under the raw IdP identifier) were never found — causing lockouts when registration is disabled, or silent duplicate accounts when it is enab... | 7cd0256fca789f515e8e0b0246b726029a642280 | f82216a92610c3f7dac28e8189ebf9db52adedc8 | diff --git a/server/router/api/v1/auth_service.go b/server/router/api/v1/auth_service.go
index 36a57230cef43..1f2fcb13ce972 100644
--- a/server/router/api/v1/auth_service.go
+++ b/server/router/api/v1/auth_service.go
@@ -149,6 +149,17 @@ func (s *APIV1Service) SignIn(ctx context.Context, request *v1pb.SignInRequest)
... | [
"server/router/api/v1/auth_service.go"
] | [] | true | ||
usememos/memos | 5,870 | issue_to_patch | fix: correct gofmt formatting in transform_test.go | The `Static Checks` CI job was failing because `internal/idp/transform_test.go` had manual column-alignment spaces in a struct literal, which `goimports`/`gofmt` does not produce.
- **`internal/idp/transform_test.go`**: Removed extra alignment spaces from the anonymous struct field declarations so the file matches can... | 54e875a061697ee8f077e15f0c7c61bfd5cd2a7b | 96ccbc70782e89d0b76c02686d3b419dabd306b2 | [
"internal/idp/transform_test.go"
] | [] | diff --git a/internal/idp/transform_test.go b/internal/idp/transform_test.go
index 237f5a3c4fc19..4068cc956d662 100644
--- a/internal/idp/transform_test.go
+++ b/internal/idp/transform_test.go
@@ -8,11 +8,11 @@ import (
func TestApplyIdentifierTransform(t *testing.T) {
tests := []struct {
- name string
- ... | true | ||
usememos/memos | 5,867 | issue_to_patch | Checkbox state not saved when editing
### Pre-submission Checklist
- [x] I have searched existing issues and confirmed this has not already been reported
- [x] This is a bug report, not a question or configuration request
### Memos Version
v0.27.1
### Environment Details
_No response_
### Steps to Reproduce
1. ... | fix(web): preserve task checkbox state | ## Summary
- preserve GFM task checkbox checked state after markdown sanitization
- disable localStorage draft restore for editing existing memos while keeping draft cache for new memos/comments
- optimistically patch memo collection caches, including comment lists, when memo content updates
## Root cause
Checked task... | d98f6659190b8d1a8252e64549d9120d85e05d33 | 31f7de9be056b7bc36e8e3884e56dd792a167659 | diff --git a/web/src/components/MemoContent/TaskListItem.tsx b/web/src/components/MemoContent/TaskListItem.tsx
index 94545ebb3d2bf..0f89f7d2adef8 100644
--- a/web/src/components/MemoContent/TaskListItem.tsx
+++ b/web/src/components/MemoContent/TaskListItem.tsx
@@ -61,7 +61,7 @@ export const TaskListItem: React.FC<TaskL... | [
"web/src/components/MemoContent/TaskListItem.tsx",
"web/src/components/MemoContent/constants.ts",
"web/src/components/MemoEditor/hooks/useAutoSave.ts",
"web/src/components/MemoEditor/hooks/useMemoInit.ts",
"web/src/components/MemoEditor/index.tsx",
"web/src/components/MemoEditor/services/cacheService.ts",... | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Validate the structured draft envelope version before unwrapping.**\n\nRight now any raw JSON draft with `{\"kind\":\"memos.editor-cache\",\"content\":\"...\"}` is treated as an envelope and loses the original JSON text. Since the structured shape includes `v... | diff --git a/web/tests/memo-content-security.test.tsx b/web/tests/memo-content-security.test.tsx
index 13b9923a772be..455ad2bab40b3 100644
--- a/web/tests/memo-content-security.test.tsx
+++ b/web/tests/memo-content-security.test.tsx
@@ -4,6 +4,7 @@ import ReactMarkdown from "react-markdown";
import rehypeKatex from "r... | true |
usememos/memos | 5,867 | comment_to_fix | fix(web): preserve task checkbox state | _⚠️ Potential issue_ | _🟡 Minor_
**Validate the structured draft envelope version before unwrapping.**
Right now any raw JSON draft with `{"kind":"memos.editor-cache","content":"..."}` is treated as an envelope and loses the original JSON text. Since the structured shape includes `version`, gate on it before returni... | d98f6659190b8d1a8252e64549d9120d85e05d33 | 31f7de9be056b7bc36e8e3884e56dd792a167659 | diff --git a/web/src/components/MemoEditor/services/cacheService.ts b/web/src/components/MemoEditor/services/cacheService.ts
index dde785cd245bb..07826f24e4214 100644
--- a/web/src/components/MemoEditor/services/cacheService.ts
+++ b/web/src/components/MemoEditor/services/cacheService.ts
@@ -1,6 +1,33 @@
export const ... | [
"web/src/components/MemoEditor/services/cacheService.ts"
] | [
{
"comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Validate the structured draft envelope version before unwrapping.**\n\nRight now any raw JSON draft with `{\"kind\":\"memos.editor-cache\",\"content\":\"...\"}` is treated as an envelope and loses the original JSON text. Since the structured shape includes `v... | true | ||
usememos/memos | 5,861 | issue_to_patch | Scroll disappears when the memo dropdown menu appears
### Pre-submission Checklist
- [x] I have searched existing issues and confirmed this has not already been reported
- [x] This is a bug report, not a question or configuration request
### Memos Version
demo site
### Environment Details
[- Demo site](https://de... | fix: disable modal prop on DropdownMenu to prevent scroll disappearing | Fixed an issue where the layout was unstable because the scroll bar disappeared when the memo dropdown menu appeared.
Resolved #5860
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Bug Fixes**
* Adjusted dropdown menu modal interaction behavior for improv... | 765a8c6e28a0b1e2a9bfab6b88d5847d1501e321 | c1f559180cd8493a711edae9c8f4aecacf206316 | diff --git a/web/src/components/ui/dropdown-menu.tsx b/web/src/components/ui/dropdown-menu.tsx
index acdb4b5f21423..5ae8a4cb5fdad 100644
--- a/web/src/components/ui/dropdown-menu.tsx
+++ b/web/src/components/ui/dropdown-menu.tsx
@@ -9,7 +9,7 @@ const DropdownMenu = React.forwardRef<
React.ComponentPropsWithoutRef<ty... | [
"web/src/components/ui/dropdown-menu.tsx"
] | [] | true | |
usememos/memos | 5,856 | issue_to_patch | fix: user resource names can be uuidv4 from idp sub claim | usernames that come from identity providers might be UUIDv4 which would fail the UIDMatcher regex causing an invalid username error when trying to log in.
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **Enhancements**
* Increased allowed UID length from 32 to ... | f8a304bae33086320b39095d631288156eec4249 | de56f23fa57f016e171289795750eb8edda57dc5 | diff --git a/internal/base/resource_name.go b/internal/base/resource_name.go
index 828bfa366f113..8731579faee5d 100644
--- a/internal/base/resource_name.go
+++ b/internal/base/resource_name.go
@@ -3,5 +3,5 @@ package base
import "regexp"
var (
- UIDMatcher = regexp.MustCompile("^[a-zA-Z0-9]([a-zA-Z0-9-]{0,30}[a-zA-... | [
"internal/base/resource_name.go",
"internal/base/resource_name_test.go",
"server/router/api/v1/resource_name.go"
] | [] | diff --git a/internal/base/resource_name_test.go b/internal/base/resource_name_test.go
index cef922ac03136..88b39d307c55a 100644
--- a/internal/base/resource_name_test.go
+++ b/internal/base/resource_name_test.go
@@ -22,6 +22,8 @@ func TestUIDMatcher(t *testing.T) {
{"a1234567890123456789012345678901", true},
{"a... | true | |
usememos/memos | 5,855 | issue_to_patch | chore(main): release 0.27.1 | :robot: I have created a release *beep* *boop*
---
## [0.27.1](https://github.com/usememos/memos/compare/v0.27.0...v0.27.1) (2026-04-19)
### Bug Fixes
* mixed-case user resource names ([#5853](https://github.com/usememos/memos/issues/5853)) ([01be01f](https://github.com/usememos/memos/commit/01be01f4b7676af41bdd17... | bbded584ce85a856d863485768e08b53adec7244 | 7bde7019dbf536bf0bab744c11f82c031b545b97 | diff --git a/.release-please-manifest.json b/.release-please-manifest.json
index 2b114496d1832..1f59b6814a3de 100644
--- a/.release-please-manifest.json
+++ b/.release-please-manifest.json
@@ -1,3 +1,3 @@
{
- ".": "0.27.0"
+ ".": "0.27.1"
}
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8dc5da08da48a..63a63ff329206... | [
".release-please-manifest.json",
"CHANGELOG.md"
] | [] | true | ||
usememos/memos | 5,854 | issue_to_patch | chore(main): release 0.27.1 | :robot: I have created a release *beep* *boop*
---
## [0.27.1](https://github.com/usememos/memos/compare/v0.27.0...v0.27.1) (2026-04-19)
### Bug Fixes
* mixed-case user resource names ([#5853](https://github.com/usememos/memos/issues/5853)) ([01be01f](https://github.com/usememos/memos/commit/01be01f4b7676af41bdd17... | 01be01f4b7676af41bdd1758b1e9b096aa922546 | 64c64a3aa36cea91b76ebdb4eca698b83a12ebc1 | diff --git a/.release-please-manifest.json b/.release-please-manifest.json
index 2b114496d1832..1f59b6814a3de 100644
--- a/.release-please-manifest.json
+++ b/.release-please-manifest.json
@@ -1,3 +1,3 @@
{
- ".": "0.27.0"
+ ".": "0.27.1"
}
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 8dc5da08da48a..b954b7d8d4dbb... | [
".release-please-manifest.json",
"CHANGELOG.md"
] | [] | true | ||
usememos/memos | 5,849 | issue_to_patch | Insufficient permissions for unix socket
### Pre-submission Checklist
- [x] I have searched existing issues and confirmed this bug has not been reported
- [x] I can reproduce this bug on the latest version or the [demo site](https://demo.usememos.com)
- [x] This is a bug, not a question (use [Discussions](https://git... | fix: add unix socket file permission setting (755 -> 660) | Changed the permissions of Unix socket files created by flags or environment variables from 755 to 660.
Communication via socket files is possible simply by adding a reverse proxy user (e.g., nginx) to memos' group.
Resolves #5827
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## S... | 88cb58ab643f4049d6477f4b1f110488269dbd5b | ea64468f4d5fd2e12847194352b8d9346dbb34cf | diff --git a/server/server.go b/server/server.go
index 6096228d779c2..122504114e393 100644
--- a/server/server.go
+++ b/server/server.go
@@ -6,6 +6,7 @@ import (
"log/slog"
"net"
"net/http"
+ "os"
"sync"
"time"
@@ -108,6 +109,13 @@ func (s *Server) Start(ctx context.Context) error {
return errors.Wrap(er... | [
"server/server.go"
] | [] | true | |
usememos/memos | 5,853 | issue_to_patch | Cannot login
### Pre-submission Checklist
- [x] I have searched existing issues and confirmed this has not already been reported
- [x] This is a bug report, not a question or configuration request
### Memos Version
0.27
### Environment Details
docker + sqlite
### Steps to Reproduce
1. Try to login
### Current ... | fix: mixed-case user resource names | ## Summary
- Allow mixed-case usernames in `users/{username}` resource parsing so server-emitted names remain reusable.
- Share username validation across resource parsing, user create/update, and batch user lookup.
- Reject all-numeric usernames at create/update time to preserve the username-only resource-name contrac... | 1fd6a2a385175399fb515d50d44bee4cda30b40c | 238f873255cb796529187105456d93564f1c2215 | diff --git a/server/router/api/v1/user_resource_name.go b/server/router/api/v1/user_resource_name.go
index cf91e5be4bb80..e5d7716ee4862 100644
--- a/server/router/api/v1/user_resource_name.go
+++ b/server/router/api/v1/user_resource_name.go
@@ -2,8 +2,6 @@ package v1
import (
"context"
- "strconv"
- "strings"
... | [
"server/router/api/v1/test/user_resource_name_test.go",
"server/router/api/v1/user_resource_name.go",
"server/router/api/v1/user_service.go"
] | [] | diff --git a/server/router/api/v1/test/user_resource_name_test.go b/server/router/api/v1/test/user_resource_name_test.go
index 544c13452c559..799cf63ebd360 100644
--- a/server/router/api/v1/test/user_resource_name_test.go
+++ b/server/router/api/v1/test/user_resource_name_test.go
@@ -44,6 +44,62 @@ func TestUserResourc... | true |
usememos/memos | 5,843 | issue_to_patch | chore(main): release 0.27.0 | :robot: I have created a release *beep* *boop*
---
## [0.27.0](https://github.com/usememos/memos/compare/v0.26.2...v0.27.0) (2026-04-18)
### Features
* add --allow-private-webhooks flag to bypass SSRF protection ([#5694](https://github.com/usememos/memos/issues/5694)) ([cd5816c](https://github.com/usememos/memos/c... | 583c3d24f4d785faa5e034c1b88ed90eda119baa | 88804420b5a8ea191174a4491d392bc504044664 | diff --git a/.release-please-manifest.json b/.release-please-manifest.json
index eb65bfe9ee34f..2b114496d1832 100644
--- a/.release-please-manifest.json
+++ b/.release-please-manifest.json
@@ -1,3 +1,3 @@
{
- ".": "0.26.2"
+ ".": "0.27.0"
}
diff --git a/CHANGELOG.md b/CHANGELOG.md
new file mode 100644
index 0000000... | [
".release-please-manifest.json",
"CHANGELOG.md"
] | [] | true | ||
usememos/memos | 5,850 | issue_to_patch | feat(mcp): harden tool exposure and side effects | ## Summary
- add MCP read-only and toolset filtering via headers and route aliases
- return structured MCP tool content while keeping JSON text fallbacks stable
- route mutating MCP tools through APIV1Service so SSE, webhooks, mentions, and payload rebuilding stay consistent
- document the new MCP controls and add reg... | 0fc1dab28b33f7fdbe9a21cd3bd3affe75dd7f19 | a9024f2790c57a41d8eef7b511266626e17fe6f9 | diff --git a/server/router/mcp/README.md b/server/router/mcp/README.md
index 0af991fc07cde..cd2fbf1829cac 100644
--- a/server/router/mcp/README.md
+++ b/server/router/mcp/README.md
@@ -12,6 +12,35 @@ DELETE /mcp (optional session termination)
Transport: [Streamable HTTP](https://modelcontextprotocol.io/specification... | [
"server/router/mcp/README.md",
"server/router/mcp/api_helpers.go",
"server/router/mcp/mcp.go",
"server/router/mcp/mcp_test.go",
"server/router/mcp/tool_metadata.go",
"server/router/mcp/tools_attachment.go",
"server/router/mcp/tools_memo.go",
"server/router/mcp/tools_reaction.go",
"server/router/mcp/... | [] | diff --git a/server/router/mcp/mcp_test.go b/server/router/mcp/mcp_test.go
index a4dd1c4898da1..7e1e0dbfb294d 100644
--- a/server/router/mcp/mcp_test.go
+++ b/server/router/mcp/mcp_test.go
@@ -1,11 +1,17 @@
package mcp
import (
+ "bytes"
"context"
"encoding/json"
+ "net/http"
"net/http/httptest"
+ "reflect"
... | true | |
usememos/memos | 5,848 | issue_to_patch | refactor(web/routing): guard-based auth flow, migrate tests to Vitest | Move authentication decisions into route-level guards so the correct landing page renders first, fixing the pre-login main-UI flash reported in usememos/memos#5846:
- Introduce LandingRoute, RequireAuthRoute and RequireGuestRoute; make `/` a pure entry redirect and add `/home` as the authenticated primary page. Pres... | 587f5b1b6cb7e1f89c400f4619bdf9af4f7bf306 | 7d923d63f955322751a06399fddec167ee56fcbd | diff --git a/.github/workflows/frontend-tests.yml b/.github/workflows/frontend-tests.yml
index d1fe8a613034e..ee5fc2c337f2d 100644
--- a/.github/workflows/frontend-tests.yml
+++ b/.github/workflows/frontend-tests.yml
@@ -44,6 +44,10 @@ jobs:
working-directory: web
run: pnpm lint
+ - name: Run u... | [
".github/workflows/frontend-tests.yml",
".gitignore",
"web/package.json",
"web/pnpm-lock.yaml",
"web/src/components/MemoActionMenu/hooks.ts",
"web/src/components/MemoContent/Tag.tsx",
"web/src/components/Navigation.tsx",
"web/src/components/PagedMemoList/PagedMemoList.tsx",
"web/src/components/Passw... | [] | diff --git a/web/tests/auth-redirect.test.ts b/web/tests/auth-redirect.test.ts
new file mode 100644
index 0000000000000..f0150e0879f5b
--- /dev/null
+++ b/web/tests/auth-redirect.test.ts
@@ -0,0 +1,115 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+
+vi.mock("@/auth-state", () => ({
+ c... | true | |
uutils/coreutils | 12,733 | issue_to_patch | Add buffered printing and lock output stream to tsort | This pull request adds buffered output and locks stdout during printing to improve performance. As a side effect, tsort no longer panics when printing to stdout fails. | 82435436d6e3d393cb3fedf163ae23073e6b086d | 78b6f7ec33d7414877e28151b5b021e6117174c4 | diff --git a/src/uu/tsort/src/tsort.rs b/src/uu/tsort/src/tsort.rs
index 001ab16ebe6..e772cd3388c 100644
--- a/src/uu/tsort/src/tsort.rs
+++ b/src/uu/tsort/src/tsort.rs
@@ -10,7 +10,7 @@ use std::collections::VecDeque;
use std::collections::hash_map::Entry;
use std::ffi::OsString;
use std::fs::File;
-use std::io::{s... | [
"src/uu/tsort/src/tsort.rs"
] | [] | true | ||
uutils/coreutils | 11,431 | issue_to_patch | GnuTests (Smack) needs stable URL to get busybox binary
Reopens https://github.com/uutils/coreutils/issues/11368 | run-gnu-tests-smack-ci.sh: Use alpine busybox | Closes #11430 | 33d698b4054a0474968b4091677d914d759224fb | d4f89099adbd828d9c8ed7663bea6a58701cdc70 | diff --git a/util/run-gnu-tests-smack-ci.sh b/util/run-gnu-tests-smack-ci.sh
index e37e29ca3fa..867a15dad4a 100755
--- a/util/run-gnu-tests-smack-ci.sh
+++ b/util/run-gnu-tests-smack-ci.sh
@@ -17,15 +17,14 @@ mkdir -p "$QEMU_DIR"/{rootfs/{bin,lib64,proc,sys,dev,tmp,etc,gnu},kernel}
# Copy Ubuntu kernel (runner's ker... | [
"util/run-gnu-tests-smack-ci.sh"
] | [] | true | |
uutils/coreutils | 12,871 | issue_to_patch | nproc: systemd-run --user --scope -q --property="CPUQuota=199%" nproc is different
```
$ systemd-run --user --scope -q --property="CPUQuota=199%" gnu-nproc
2
$ systemd-run --user --scope -q --property="CPUQuota=199%" uu-nproc
1
``` | nproc: PASS nproc-quota-systemd.sh (manually parse cgroups2 quota) | Try to fix https://github.com/uutils/coreutils/issues/9815 & a GnuTest | 82435436d6e3d393cb3fedf163ae23073e6b086d | 47a9a6ee9b3e4bfb90757e2694cfcc2df27efd2d | diff --git a/src/uu/nproc/src/nproc.rs b/src/uu/nproc/src/nproc.rs
index f28663ff99..7de90e9f6c 100644
--- a/src/uu/nproc/src/nproc.rs
+++ b/src/uu/nproc/src/nproc.rs
@@ -6,8 +6,8 @@
// spell-checker:ignore NPROCESSORS SCHED getaffinity getcpu getscheduler sched sysconf
use clap::{Arg, ArgAction, Command};
+use std... | [
"src/uu/nproc/src/nproc.rs"
] | [] | true | |
uutils/coreutils | 12,872 | issue_to_patch | Bump `time` & adapt `pinky` and `who` to API change | This PR bumps `time` from `0.3.47` to `0.3.49` and it adapts `pinky` and `who` to use `parse_borrowed()` instead of the deprecated `parse()`.
Closes https://github.com/uutils/coreutils/pull/12803 | e21b30dd79df5f07bba828c00ecb80187627471b | 2d0fb57db3fdc02866fe5758cedf0340b765293d | diff --git a/Cargo.lock b/Cargo.lock
index ae8870e7a4b..08eee753cd6 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -857,9 +857,6 @@ name = "deranged"
version = "0.5.8"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "7cd812cc2bc1d69d4764bd80df88b4317eaef9e773c75226407d9bc0876b211c"
-dependen... | [
"Cargo.lock",
"src/uu/pinky/src/platform/unix.rs",
"src/uu/who/src/platform/unix.rs"
] | [] | true | ||
uutils/coreutils | 12,859 | issue_to_patch | nproc: rejects affinity mask under systemd-run AllowedCPUs=0 chrt --fifo 10
```
$ run0 systemd-run --scope -q -p AllowedCPUs=0 chrt --fifo 10 gnu9.11/nproc
1
$ run0 systemd-run --scope -q -p AllowedCPUs=0 chrt --fifo 10 uu-nproc
12
``` | nproc: honor affinity mask | Fixes https://github.com/uutils/coreutils/issues/12858 | 8f1214b9d783829169e9b2b692396f53c7d46f65 | 27160376a2a93e0e45f7fabf665c32a423f19ce5 | diff --git a/Cargo.lock b/Cargo.lock
index d1077e227e..ae8870e7a4 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3845,6 +3845,7 @@ dependencies = [
"clap",
"fluent",
"libc",
+ "rustix",
"uucore",
]
diff --git a/src/uu/nproc/Cargo.toml b/src/uu/nproc/Cargo.toml
index 65e6692fbc..853be86fd8 100644
--- a/src/uu/n... | [
"Cargo.lock",
"src/uu/nproc/Cargo.toml",
"src/uu/nproc/src/nproc.rs"
] | [] | true | |
uutils/coreutils | 12,718 | issue_to_patch | minorbug(install): using /proc/self/mem as a dst leads to show raw rust errors not standard human readable errors
Hi, uutils mainteners
note: that just a minor bug not like the previous one the errors shown correctly, the problem only shown in raw format, i used
```rust
relunsec@relunsec:~/software/coreutils/target/... | minor fix for error message install to /proc/self/mem | Fixes #12695.
Not added a test since no behavior changes in this PR. | dab93926d25269e0fdbc5445e40b71ee0d44ab8a | 74ced610a1b2950344d907d28a7eac12ab5aa70b | diff --git a/src/uu/install/locales/en-US.ftl b/src/uu/install/locales/en-US.ftl
index 34189d86333..c141899fdea 100644
--- a/src/uu/install/locales/en-US.ftl
+++ b/src/uu/install/locales/en-US.ftl
@@ -42,6 +42,7 @@ install-error-override-directory-failed = cannot overwrite directory { $dir } wi
install-error-same-file... | [
"src/uu/install/locales/en-US.ftl",
"src/uu/install/src/install.rs",
"tests/by-util/test_install.rs"
] | [
{
"comment": "Linux specific file. Guard by cfg.",
"path": "tests/by-util/test_install.rs",
"hunk": "@@ -2782,3 +2782,18 @@ fn test_install_set_owner_nonexistent_uid_and_gid() {\n println!(\"Test skipped; requires root user\");\n }\n }\n+\n+#[test]\n+fn test_install_proc_self_mem_as_dst() {\... | diff --git a/tests/by-util/test_install.rs b/tests/by-util/test_install.rs
index 81b1c07aae0..cca3d01c228 100644
--- a/tests/by-util/test_install.rs
+++ b/tests/by-util/test_install.rs
@@ -2782,3 +2782,19 @@ fn test_install_set_owner_nonexistent_uid_and_gid() {
println!("Test skipped; requires root user");
... | true |
uutils/coreutils | 12,718 | comment_to_fix | minor fix for error message install to /proc/self/mem | Linux specific file. Guard by cfg. | dab93926d25269e0fdbc5445e40b71ee0d44ab8a | 74ced610a1b2950344d907d28a7eac12ab5aa70b | diff --git a/tests/by-util/test_install.rs b/tests/by-util/test_install.rs
index 81b1c07aae0..cca3d01c228 100644
--- a/tests/by-util/test_install.rs
+++ b/tests/by-util/test_install.rs
@@ -2782,3 +2782,19 @@ fn test_install_set_owner_nonexistent_uid_and_gid() {
println!("Test skipped; requires root user");
... | [
"tests/by-util/test_install.rs"
] | [
{
"comment": "Linux specific file. Guard by cfg.",
"path": "tests/by-util/test_install.rs",
"hunk": "@@ -2782,3 +2782,18 @@ fn test_install_set_owner_nonexistent_uid_and_gid() {\n println!(\"Test skipped; requires root user\");\n }\n }\n+\n+#[test]\n+fn test_install_proc_self_mem_as_dst() {\... | true | ||
uutils/coreutils | 12,854 | issue_to_patch | bug(head): when -n is a massive low negative number panics
Hi, uutils mainteners
that panic happending only with massive low negative numbers while massive positive numbers no as i confirmed with
the utility head
```rust
relunsec@relunsec:~/software/coreutils/target/debug$ ./head -n=-116265256266241262252526 a
thre... | fix(head): avoid overflow panic on huge negative -n/-c values | ### What does this PR do?
Fixes two integer overflow panics in `head` when given an extremely large negative value for `-n`/`--lines` or `-c`/`--bytes` (the "all but last N lines/bytes" mode).
- `copy_all_but_n_bytes` and `copy_all_but_n_lines` in `src/uu/head/src/take.rs` computed `n + b.remaining_bytes()` / `n + b.... | eee005a864ae09fd5a8cd4ef4f1c62529d3854a0 | 4ad8be4d59c1e32a3453f048baaaf6206f20ca2c | diff --git a/src/uu/head/src/head.rs b/src/uu/head/src/head.rs
index e8e09ea0007..955b3334dfd 100644
--- a/src/uu/head/src/head.rs
+++ b/src/uu/head/src/head.rs
@@ -329,7 +329,7 @@ where
for separator_offset in memrchr_iter(separator, &buffer[..]) {
lines += 1;
- if lines == n + 1 {
+... | [
"src/uu/head/src/head.rs",
"src/uu/head/src/take.rs",
"tests/by-util/test_head.rs"
] | [] | diff --git a/tests/by-util/test_head.rs b/tests/by-util/test_head.rs
index 570bea45a38..0f4e9dae5dd 100644
--- a/tests/by-util/test_head.rs
+++ b/tests/by-util/test_head.rs
@@ -871,6 +871,24 @@ fn test_value_too_large() {
.succeeds();
}
+#[test]
+fn test_all_but_last_lines_huge_count_does_not_panic() {
+ ... | true |
uutils/coreutils | 12,850 | issue_to_patch | cat: improve throughput & simplify (split PR) | Split https://github.com/uutils/coreutils/pull/12651 to make diff smaller. This part is needed for GnuTests. | eee005a864ae09fd5a8cd4ef4f1c62529d3854a0 | 0c3a028d1a278acd2895386dacc4c2f4b2b0857b | diff --git a/src/uucore/src/lib/features/pipes.rs b/src/uucore/src/lib/features/pipes.rs
index 076e4fbdd5..02c13dc8ba 100644
--- a/src/uucore/src/lib/features/pipes.rs
+++ b/src/uucore/src/lib/features/pipes.rs
@@ -82,24 +82,23 @@ pub fn might_fuse(source: &impl AsFd) -> bool {
rustix::fs::fstatfs(source).map_or(t... | [
"src/uucore/src/lib/features/pipes.rs"
] | [] | true | ||
uutils/coreutils | 12,822 | issue_to_patch | dircolors: replace `if`/`else` chain with `match` | 048f56e0bcddf010b16cd0271e67868f309bf214 | 570268f750000a99a811af090aaa0284463ac05a | diff --git a/src/uu/dircolors/src/dircolors.rs b/src/uu/dircolors/src/dircolors.rs
index 55e2b17872..de842fea87 100644
--- a/src/uu/dircolors/src/dircolors.rs
+++ b/src/uu/dircolors/src/dircolors.rs
@@ -163,44 +163,43 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
})?
};
- let result;... | [
"src/uu/dircolors/src/dircolors.rs"
] | [] | true | |||
uutils/coreutils | 12,861 | issue_to_patch | nproc: OMP_NUM_THREADS overflow error should be clamped
```
$ env OMP_NUM_THREADS="99999999999999999999" gnu9.11/nproc
18446744073709551615
$ env OMP_NUM_THREADS="99999999999999999999" nproc
4
``` | nproc: clamp OMP_NUM_THREADS overflow | Fixes https://github.com/uutils/coreutils/issues/12860 | 8f1214b9d783829169e9b2b692396f53c7d46f65 | 58578edb82c17bea019c1264736ecea6a3885c2b | diff --git a/src/uu/nproc/src/nproc.rs b/src/uu/nproc/src/nproc.rs
index a8bf6a8b7a..af6d9e36fc 100644
--- a/src/uu/nproc/src/nproc.rs
+++ b/src/uu/nproc/src/nproc.rs
@@ -45,9 +45,10 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
// If OMP_NUM_THREADS=0, rejects the value
match threads.spl... | [
"src/uu/nproc/src/nproc.rs",
"tests/by-util/test_nproc.rs"
] | [] | diff --git a/tests/by-util/test_nproc.rs b/tests/by-util/test_nproc.rs
index 05ec83d185..e0babfacc9 100644
--- a/tests/by-util/test_nproc.rs
+++ b/tests/by-util/test_nproc.rs
@@ -48,6 +48,14 @@ fn test_nproc_all_omp() {
.succeeds();
let nproc_omp: u8 = result.stdout_str().trim().parse().unwrap();
ass... | true |
uutils/coreutils | 12,857 | issue_to_patch | nproc: use chain for OMP_THREAD_LIMIT | 8f1214b9d783829169e9b2b692396f53c7d46f65 | b0c9bfe36a9c1ba1f84c67f02661b08450e10cf7 | diff --git a/src/uu/nproc/src/nproc.rs b/src/uu/nproc/src/nproc.rs
index a8bf6a8b7a..f511900326 100644
--- a/src/uu/nproc/src/nproc.rs
+++ b/src/uu/nproc/src/nproc.rs
@@ -20,19 +20,13 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
let matches = uucore::clap_localization::handle_clap_result(uu_app(), ar... | [
"src/uu/nproc/src/nproc.rs"
] | [] | true | |||
uutils/coreutils | 12,856 | issue_to_patch | nproc: simplify by value_parser! | ```
$ nproc-main --ignore NaN
nproc: 'NaN' is not a valid number: invalid digit found in string
$ target/debug/nproc-clap --ignore NaN
error: invalid value 'NaN' for '--ignore <N>': invalid digit found in string
For more information, try '--help'.
```
No meaning change. | 0ab42174bdfef8fa60efb34580eae4a9b35001fc | d2a5e39bb55aa6c88e17870577fcfc1f682b309e | diff --git a/src/uu/nproc/locales/en-US.ftl b/src/uu/nproc/locales/en-US.ftl
index 0a7b97cc64d..dc184ab3720 100644
--- a/src/uu/nproc/locales/en-US.ftl
+++ b/src/uu/nproc/locales/en-US.ftl
@@ -3,9 +3,6 @@ nproc-about = Print the number of cores available to the current process.
they will determine the minimum and ma... | [
"src/uu/nproc/locales/en-US.ftl",
"src/uu/nproc/src/nproc.rs"
] | [] | true | ||
uutils/coreutils | 12,853 | issue_to_patch | nproc: OMP_NUM_THREADS=NaN should reject quota if fifo schedular is used
```
$ run0 systemd-run --scope -q -p CPUQuota=100% chrt --fifo 10 env OMP_NUM_THREADS=NaN nproc
1
$ run0 systemd-run --scope -q -p CPUQuota=100% chrt --fifo 10 env OMP_NUM_THREADS=NaN '/home/a/bin/gnu9.11/nproc'
12
``` | nproc: reject quota with some sched if OMP_NUM_THREADS=NaN | Fixes https://github.com/uutils/coreutils/issues/12852 .
Difficult to add Rust native test... | eee005a864ae09fd5a8cd4ef4f1c62529d3854a0 | 17a19e22e76ae51ef86a1bd85ed64ce1738aade2 | diff --git a/src/uu/nproc/src/nproc.rs b/src/uu/nproc/src/nproc.rs
index af78e52ffe..b299c955e3 100644
--- a/src/uu/nproc/src/nproc.rs
+++ b/src/uu/nproc/src/nproc.rs
@@ -60,13 +60,6 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
} else {
// the variable 'OMP_NUM_THREADS' doesn't exist
... | [
"src/uu/nproc/src/nproc.rs"
] | [
{
"comment": "To avoid the duplicate code on lines 126 and 129, it might make sense to do an early return. Something like:\n```suggestion\n {\n let scheduler = unsafe { libc::sched_getscheduler(0) };\n\n if matches!(scheduler, libc::SCHED_FIFO | libc::SCHED_RR | libc::SCHED_DEADLINE) {\n ... | true | |
uutils/coreutils | 12,853 | comment_to_fix | nproc: reject quota with some sched if OMP_NUM_THREADS=NaN | To avoid the duplicate code on lines 126 and 129, it might make sense to do an early return. Something like:
```suggestion
{
let scheduler = unsafe { libc::sched_getscheduler(0) };
if matches!(scheduler, libc::SCHED_FIFO | libc::SCHED_RR | libc::SCHED_DEADLINE) {
return num_cpus_all();
... | eee005a864ae09fd5a8cd4ef4f1c62529d3854a0 | 17a19e22e76ae51ef86a1bd85ed64ce1738aade2 | diff --git a/src/uu/nproc/src/nproc.rs b/src/uu/nproc/src/nproc.rs
index af78e52ffe..b299c955e3 100644
--- a/src/uu/nproc/src/nproc.rs
+++ b/src/uu/nproc/src/nproc.rs
@@ -60,13 +60,6 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
} else {
// the variable 'OMP_NUM_THREADS' doesn't exist
... | [
"src/uu/nproc/src/nproc.rs"
] | [
{
"comment": "To avoid the duplicate code on lines 126 and 129, it might make sense to do an early return. Something like:\n```suggestion\n {\n let scheduler = unsafe { libc::sched_getscheduler(0) };\n\n if matches!(scheduler, libc::SCHED_FIFO | libc::SCHED_RR | libc::SCHED_DEADLINE) {\n ... | true | ||
uutils/coreutils | 12,849 | issue_to_patch | nproc: reduce a nest by if | ce40f0ba379bfe26a0f3f10553c31bd896176230 | 64f2a0bcd44a983a33d91aedbfdbf994d76b44e9 | diff --git a/src/uu/nproc/src/nproc.rs b/src/uu/nproc/src/nproc.rs
index 619ba1c87d..af78e52ffe 100644
--- a/src/uu/nproc/src/nproc.rs
+++ b/src/uu/nproc/src/nproc.rs
@@ -43,36 +43,31 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
let mut cores = if matches.get_flag(OPT_ALL) {
num_cpus_all()... | [
"src/uu/nproc/src/nproc.rs"
] | [] | true | |||
uutils/coreutils | 12,747 | issue_to_patch | date: rejects `<digits>j`/`<digits>J` (time in local military timezone J) that GNU accepts
`date -d` accepts a bare military-timezone letter `j`/`J` (the local/UTC zone) as midnight today, but rejects it when prefixed with a time like `9j` or `1230j`. GNU reads `<digits>j` as that time today in zone J. Other zone lett... | date: parse <digits>j as a local time of day | `date -d 9j` was rejected even though GNU reads it as 09:00 today. The military timezone `J` means local time, so a number followed by `j`/`J` (`9j`, `1230J`) is just the bare time-of-day form. The fix strips the suffix and handles it like the bare number.
Fixes #12684.
| 048f56e0bcddf010b16cd0271e67868f309bf214 | 832a239d724f67a1017d30ae716f427350896680 | diff --git a/src/uu/date/src/date.rs b/src/uu/date/src/date.rs
index 9d25dbd587a..23eaf540047 100644
--- a/src/uu/date/src/date.rs
+++ b/src/uu/date/src/date.rs
@@ -418,8 +418,14 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
// - Semantics: a pure decimal number denotes today's time-of-day (HH... | [
"src/uu/date/src/date.rs",
"tests/by-util/test_date.rs"
] | [
{
"comment": "I would perform the checks only once, on lines 433 - 435. It allows you to simplify the code above to something like:\n```suggestion\n let time_digits = input.strip_suffix(['j', 'J']).unwrap_or(input);\n```",
"path": "src/uu/date/src/date.rs",
"hunk": "@@ -418,8 +418,21 @@ pub f... | diff --git a/tests/by-util/test_date.rs b/tests/by-util/test_date.rs
index 539867fca18..763e4a844fd 100644
--- a/tests/by-util/test_date.rs
+++ b/tests/by-util/test_date.rs
@@ -1263,6 +1263,41 @@ fn test_date_military_timezone_j_variations() {
.stdout_contains("UTC");
}
+#[test]
+fn test_date_military_timez... | true |
uutils/coreutils | 12,810 | issue_to_patch | bug(dirname): panics when redirecting output to /dev/full or /proc/self/mem
Hi, uutils mainteners
i want let you known, that dirname panics when redirecting output to /dev/full or /proc/self/mem, as our testing confirms
```rust
relunsec@relunsec:~/software/coreutils/target/debug$ ./dirname a > /proc/self/mem
thread... | dirname: fix dirname . >/dev/full panic | Closes https://github.com/uutils/coreutils/issues/12808 | 048f56e0bcddf010b16cd0271e67868f309bf214 | e7412549bc9111e8ec87c898a31f0c60ba05e5ff | diff --git a/src/uu/dirname/src/dirname.rs b/src/uu/dirname/src/dirname.rs
index 340cbff5d81..0728a919303 100644
--- a/src/uu/dirname/src/dirname.rs
+++ b/src/uu/dirname/src/dirname.rs
@@ -5,6 +5,7 @@
use clap::{Arg, ArgAction, Command};
use std::ffi::OsString;
+use std::io::{Write as _, stdout};
#[cfg(unix)]
use... | [
"src/uu/dirname/src/dirname.rs"
] | [] | true | |
uutils/coreutils | 12,823 | issue_to_patch | nproc: let default value of --ignore 0 by clap | b1ba4b0d1176f534ec8f2f768236824f1d2e7b0b | c7529ae36039d32bbe5d7c43d48a667fc3e8d93e | diff --git a/src/uu/nproc/src/nproc.rs b/src/uu/nproc/src/nproc.rs
index 1e76f81df28..619ba1c87d4 100644
--- a/src/uu/nproc/src/nproc.rs
+++ b/src/uu/nproc/src/nproc.rs
@@ -19,19 +19,14 @@ static OPT_IGNORE: &str = "ignore";
#[uucore::main(no_signals)]
pub fn uumain(args: impl uucore::Args) -> UResult<()> {
let ... | [
"src/uu/nproc/src/nproc.rs"
] | [] | true | |||
uutils/coreutils | 12,840 | issue_to_patch | test_ls.rs: Add test case for -T | b1ba4b0d1176f534ec8f2f768236824f1d2e7b0b | fcc2e40bfcdff964a7614effa66ffd70a33958c8 | [
"tests/by-util/test_ls.rs"
] | [] | diff --git a/tests/by-util/test_ls.rs b/tests/by-util/test_ls.rs
index 55e9b22e11..a7d4ca5f48 100644
--- a/tests/by-util/test_ls.rs
+++ b/tests/by-util/test_ls.rs
@@ -5184,6 +5184,7 @@ fn test_tabsize_option() {
scene.ucmd().args(&["-T", "3"]).succeeds();
scene.ucmd().args(&["--tabsize", "0"]).succeeds();
+... | true | |||
uutils/coreutils | 12,821 | issue_to_patch | cat: drop fuse workaround | split https://github.com/uutils/coreutils/pull/12607 to avoid confliction with myself's PR... | 048f56e0bcddf010b16cd0271e67868f309bf214 | f40af12a45402606421c9e6edbb66f53a72cb465 | diff --git a/src/uu/cat/src/cat.rs b/src/uu/cat/src/cat.rs
index 226c43a7ceb..e458bf3e081 100644
--- a/src/uu/cat/src/cat.rs
+++ b/src/uu/cat/src/cat.rs
@@ -481,9 +481,7 @@ fn print_fast<R: FdReadable>(handle: &mut InputHandle<R>) -> CatResult<()> {
let mut stdout = stdout;
// Try to use the splice() system c... | [
"src/uu/cat/src/cat.rs"
] | [] | true | ||
uutils/coreutils | 12,811 | issue_to_patch | dircolors: reduce nested code | c599d5175c2ba4a738b4a944e6e21d92cbbaf36d | bfbe7824dcbf13d4ea9dcac93a96ce4682049801 | diff --git a/src/uu/dircolors/src/dircolors.rs b/src/uu/dircolors/src/dircolors.rs
index 05a30a8eb51..55e2b178723 100644
--- a/src/uu/dircolors/src/dircolors.rs
+++ b/src/uu/dircolors/src/dircolors.rs
@@ -188,28 +188,19 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
translate!("dircolors-er... | [
"src/uu/dircolors/src/dircolors.rs"
] | [] | true | |||
uutils/coreutils | 12,782 | issue_to_patch | gnucompability(pr): uutils pr accept -e=-1 however gnu one rejects it
Hi, uutils mainteners
that is a compability issue, gnu pr errors out but uutils does not as i see
```rust
relunsec@relunsec:~/software/coreutils/target/debug$ ./pr -e=-1 a
2026-06-11 02:29 a Page 1
... | pr: uutils pr accepts negative expand tabs argument, GNU pr doesn't | this PR closes #12766 | 2680abd678b8f879d52a3d7a860f4403a61efb15 | cdc52630c3d9a25b1220d3622a4fb1254353e988 | diff --git a/src/uu/pr/src/pr.rs b/src/uu/pr/src/pr.rs
index 2a216c7b30..0671742cb3 100644
--- a/src/uu/pr/src/pr.rs
+++ b/src/uu/pr/src/pr.rs
@@ -621,6 +621,8 @@ fn build_options(
let width: i32 = s[1..].parse().map_err(|_e| invalid(&s[1..]))?;
if width <= 0 {
... | [
"src/uu/pr/src/pr.rs",
"tests/by-util/test_pr.rs"
] | [] | diff --git a/tests/by-util/test_pr.rs b/tests/by-util/test_pr.rs
index 84e3acb160..5c60d879aa 100644
--- a/tests/by-util/test_pr.rs
+++ b/tests/by-util/test_pr.rs
@@ -962,3 +962,11 @@ fn test_zero_pages() {
.fails_with_code(1)
.stderr_is("pr: invalid --pages argument '0'\n");
}
+
+#[test]
+fn test_ne... | true |
uutils/coreutils | 12,802 | issue_to_patch | wc: remove a nest by cfg | ef9b7119646b64d6019f46f3d9308c40d75f65c4 | f4d78fde2c2217541b8c3255bca00867cf7cd993 | diff --git a/src/uu/wc/src/count_fast.rs b/src/uu/wc/src/count_fast.rs
index c4281eac22..0e9a45e1bf 100644
--- a/src/uu/wc/src/count_fast.rs
+++ b/src/uu/wc/src/count_fast.rs
@@ -66,79 +66,77 @@ pub(crate) fn count_bytes_fast<T: WordCountable>(handle: &mut T) -> (usize, Opti
let mut byte_count = 0;
#[cfg(un... | [
"src/uu/wc/src/count_fast.rs"
] | [] | true | |||
uutils/coreutils | 12,781 | issue_to_patch | gnucompability(pr): -l 0/--pages 0 uutils accept it and gnu rejects it
Hi, uutils mainteners
the compability issue here the problem with the 0 value for the `pr`, how interepted by gnu and uutils differently, the testing confirms it
the uutils accept but gnu behavior reject
```rust
relunsec@relunsec:~/software/coreu... | pr: uutils pr accepts -l 0 and --pages 0 while GNU doesn't | This PR resolves #12768 | 4505d51e9ca36b2dc9f2b67244d4ce1f84f68a44 | c56b5ad86968c24581ca6a6c3a1513bd462a6457 | diff --git a/src/uu/pr/src/pr.rs b/src/uu/pr/src/pr.rs
index 29acf48dfa..2a216c7b30 100644
--- a/src/uu/pr/src/pr.rs
+++ b/src/uu/pr/src/pr.rs
@@ -703,9 +703,17 @@ fn build_options(
let invalid_pages_map = |i: String| {
let unparsed_value = matches.get_one::<String>(options::PAGES).unwrap();
- i.... | [
"src/uu/pr/src/pr.rs",
"tests/by-util/test_pr.rs"
] | [] | diff --git a/tests/by-util/test_pr.rs b/tests/by-util/test_pr.rs
index b7d500e6af..84e3acb160 100644
--- a/tests/by-util/test_pr.rs
+++ b/tests/by-util/test_pr.rs
@@ -946,3 +946,19 @@ fn test_zero_page_width() {
.fails_with_code(1)
.stderr_is("pr: invalid --page-width argument '0'\n");
}
+
+#[test]
+... | true |
uutils/coreutils | 12,796 | issue_to_patch | chore(deps): update rust crate memchr to v2.8.2 | This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [memchr](https://redirect.github.com/BurntSushi/memchr) | workspace.dependencies | patch | `2.8.1` → `2.8.2` |
---
### Release Notes
<details>
<summary>BurntSushi/memchr (memchr)</summary>
### [`v2.8.2`](https://redire... | 4505d51e9ca36b2dc9f2b67244d4ce1f84f68a44 | 4ee1a5e3f9bd8b7d68ac78cfadabe2eeab639949 | diff --git a/Cargo.lock b/Cargo.lock
index 9decf7cc6c..d1077e227e 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1900,9 +1900,9 @@ dependencies = [
[[package]]
name = "memchr"
-version = "2.8.1"
+version = "2.8.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "6b947ae49db0d222b1dbc6b11... | [
"Cargo.lock"
] | [] | true | ||
uutils/coreutils | 11,713 | issue_to_patch | ln: add WASI support via symlink_path | This PR replaces the error-returning WASI stub with a real symlink implementation using `std::os::wasi::fs::symlink_path`.
## Changes
- Import `std::os::wasi::fs::symlink_path as symlink` alongside the existing unix and windows symlink imports
- Remove the WASI `fn symlink` stub that returned `io::ErrorKind::Uns... | 5e65ceb4a741362ebc808416cb19440e85f4d108 | e67e34765d48eb1544221de327045db1c7e09445 | diff --git a/.github/workflows/wasi.yml b/.github/workflows/wasi.yml
index 7597fa92782..320c0943f55 100644
--- a/.github/workflows/wasi.yml
+++ b/.github/workflows/wasi.yml
@@ -50,7 +50,7 @@ jobs:
# Tests incompatible with WASI are annotated with
# #[cfg_attr(wasi_runner, ignore)] in the test source f... | [
".github/workflows/wasi.yml",
"Cargo.lock",
"docs/src/wasi-test-gaps.md",
"src/uu/ln/Cargo.toml",
"src/uu/ln/src/ln.rs",
"src/uucore/src/lib/features/backup_control.rs",
"tests/by-util/test_ln.rs"
] | [
{
"comment": "can we use libc or rustix instead?\ni really would like to avoid CString ",
"path": "src/uu/ln/src/ln.rs",
"hunk": "@@ -490,9 +494,17 @@ pub fn symlink<P1: AsRef<Path>, P2: AsRef<Path>>(src: P1, dst: P2) -> std::io::R\n }\n \n #[cfg(target_os = \"wasi\")]\n-fn symlink<P1: AsRef<Path>, P2: ... | diff --git a/tests/by-util/test_ln.rs b/tests/by-util/test_ln.rs
index 560a7364f2f..9d8bfdf995b 100644
--- a/tests/by-util/test_ln.rs
+++ b/tests/by-util/test_ln.rs
@@ -501,6 +501,7 @@ fn test_symlink_implicit_target_dir() {
}
#[test]
+#[cfg_attr(wasi_runner, ignore = "WASI sandbox: host paths not visible")]
fn te... | true | |
uutils/coreutils | 11,717 | issue_to_patch | tests: add WASI integration test support via wasmtime | This PR adds WASI integration test support, enabling ~1,250 existing integration tests across 26 tools to run against the WASI binary via wasmtime.
The changes have gone through multiple rounds of review and refinement with Claude Code and Codex. I have tested them on macOS and Linux.
The test framework now suppo... | 11f29ddd042563e648c096b8c9b1d4f5e25e0008 | 5001ec5eb590385ec340cac25f9e94423a3ba65e | diff --git a/.github/workflows/wasi.yml b/.github/workflows/wasi.yml
index ba5e5ac3472..8c3721d6ac5 100644
--- a/.github/workflows/wasi.yml
+++ b/.github/workflows/wasi.yml
@@ -32,7 +32,7 @@ jobs:
run: |
curl https://wasmtime.dev/install.sh -sSf | bash
echo "$HOME/.wasmtime/bin" >> $GITHUB_PATH... | [
".github/workflows/wasi.yml",
".vscode/cspell.dictionaries/acronyms+names.wordlist.txt",
".vscode/cspell.dictionaries/jargon.wordlist.txt",
"Cargo.toml",
"docs/src/wasi-test-gaps.md",
"tests/by-util/test_base64.rs",
"tests/by-util/test_basename.rs",
"tests/by-util/test_basenc.rs",
"tests/by-util/tes... | [
{
"comment": "this long list isn't ideal\nwe should #ignore them for wasi in the .rs files\n",
"path": ".github/workflows/wasi.yml",
"hunk": "@@ -32,11 +32,94 @@ jobs:\n run: |\n curl https://wasmtime.dev/install.sh -sSf | bash\n echo \"$HOME/.wasmtime/bin\" >> $GITHUB_PATH\n- -... | diff --git a/tests/by-util/test_base64.rs b/tests/by-util/test_base64.rs
index 7d02b62f74e..a8de3bb6972 100644
--- a/tests/by-util/test_base64.rs
+++ b/tests/by-util/test_base64.rs
@@ -20,6 +20,7 @@ fn test_version() {
#[test]
#[cfg(target_os = "linux")]
+#[cfg_attr(wasi_runner, ignore = "WASI: argv/filenames must ... | true | |
uutils/coreutils | 12,779 | issue_to_patch | gnucompability(pr): -W 0 and -w 0 uutils accept it and gnu rejects it
Hi, uutils mainteners
i want let you known, that the gnu pr rejects the -W 0 and the -w 0 argument as well for pr but uutils one accept it happily
our testing confirm the difference
```rust
relunsec@relunsec:~/software/coreutils/target/debug$ gnup... | pr: uutils pr accepts -W 0 and -w 0 while gnu pr rejects it | This PR resolves #12767 | 7a944ce9344a4bf7cfc6dfa828088ced0912924e | 5a4d17eef1426ba6a5066a6e150eeb820720a564 | diff --git a/src/uu/pr/src/pr.rs b/src/uu/pr/src/pr.rs
index 73b8706db4..29acf48dfa 100644
--- a/src/uu/pr/src/pr.rs
+++ b/src/uu/pr/src/pr.rs
@@ -788,6 +788,12 @@ fn build_options(
let column_width =
parse_usize(matches, options::COLUMN_WIDTH).unwrap_or(Ok(default_column_width))?;
+ if column_width ... | [
"src/uu/pr/src/pr.rs",
"tests/by-util/test_pr.rs"
] | [] | diff --git a/tests/by-util/test_pr.rs b/tests/by-util/test_pr.rs
index 16a4032a7f..b7d500e6af 100644
--- a/tests/by-util/test_pr.rs
+++ b/tests/by-util/test_pr.rs
@@ -930,3 +930,19 @@ fn test_zero_expand_tab_width() {
.fails_with_code(1)
.stderr_only(expected);
}
+
+#[test]
+fn test_zero_column_width... | true |
uutils/coreutils | 12,667 | issue_to_patch | dd: propagate truncate errors on regular files | BlockWriter::truncate discarded the result of set_len() with .ok() for every output, hiding truncation failures (ENOSPC, read-only fs) on regular files and masking data loss in backup/imaging scripts. Only suppress the error for special outputs such as /dev/null, as GNU dd does. | fab0cbd327b9d413b8c7a64e16f0a4fdfd8f42cc | fcfef0a594268bc40603451a1a7a2eeccaa304ed | diff --git a/src/uu/dd/src/dd.rs b/src/uu/dd/src/dd.rs
index 6b34afd012f..782d2664c21 100644
--- a/src/uu/dd/src/dd.rs
+++ b/src/uu/dd/src/dd.rs
@@ -680,7 +680,15 @@ impl Dest {
match self {
Self::File(f, _) => {
let pos = f.stream_position()?;
- f.set_len(pos)
+ ... | [
"src/uu/dd/src/dd.rs"
] | [] | true | ||
uutils/coreutils | 12,702 | issue_to_patch | Simplify if-guard-then-bool returns | Reduce the `if cond { return false } true` pattern to `!(cond)` in df, cp and sort. No behavior change. | 80cc82977105d497939dab6a087c280dd776e899 | fcb41c9e51b437defd62a0d557e2ede159f5e344 | diff --git a/src/uu/cp/src/cp.rs b/src/uu/cp/src/cp.rs
index cda57ed0fb0..ba8108d1feb 100644
--- a/src/uu/cp/src/cp.rs
+++ b/src/uu/cp/src/cp.rs
@@ -2029,14 +2029,10 @@ fn is_forbidden_to_copy_to_same_file(
}
// If source and dest are both the same symlink but with different names, then allow the copy.
/... | [
"src/uu/cp/src/cp.rs",
"src/uu/df/src/df.rs",
"src/uu/sort/src/custom_str_cmp.rs"
] | [] | true | ||
uutils/coreutils | 12,726 | issue_to_patch | bug: base32 and base64 incorrect error messages when appending to a regular file /
Hi, uutils mainteners
to reproduce that incorrect error messages behavior you need do simply
```yaml
relunsec@relunsec:~/software/coreutils/target/debug$ ./base32 a/
base32: a/: No such file or directory
```
the same with base64
```... | Fix base32/base64 error for file paths ending in slash | Fixes #12670
Before, `base32` and `base64` checked `Path::exists()` before opening the file. That turned the real OS error into `No such file or directory`. Now the file is opened directly, so paths like `file/` correctly report `Not a directory`.
Added regression tests for `base32` and `base64`.
No GNU coreut... | dab93926d25269e0fdbc5445e40b71ee0d44ab8a | 7059b87a05aaecbb7e5a5b787b2baa3d2190e533 | diff --git a/src/uu/base32/src/base_common.rs b/src/uu/base32/src/base_common.rs
index be90f1e7ed6..79f6435eb46 100644
--- a/src/uu/base32/src/base_common.rs
+++ b/src/uu/base32/src/base_common.rs
@@ -62,16 +62,7 @@ impl Config {
if name == "-" {
None
} else {
- ... | [
"src/uu/base32/src/base_common.rs",
"tests/by-util/test_base32.rs",
"tests/by-util/test_base64.rs"
] | [] | diff --git a/tests/by-util/test_base32.rs b/tests/by-util/test_base32.rs
index 87e044574e1..fbff336b86b 100644
--- a/tests/by-util/test_base32.rs
+++ b/tests/by-util/test_base32.rs
@@ -3,7 +3,8 @@
// For the full copyright and license information, please view the LICENSE
// file that was distributed with this source ... | true |
uutils/coreutils | 12,725 | issue_to_patch | bug(shred): when adding a / to a regular file cause the tool to report incorrect error messages
Hi, uutils mainteners
it looks like the utility shred when adding a / to a regular file reports a wrong no such file or directory, but a is a file and exists, as i tried
```rust
relunsec@relunsec:~/software/coreutils/targ... | shred: fix error message when path has trailing slash | fix #12701 | 962566b194f3a3ca38cc6eaf2a9aab593a9cd121 | d95d271ea732e9919ce75e363447d9dd13643daa | diff --git a/src/uu/shred/locales/en-US.ftl b/src/uu/shred/locales/en-US.ftl
index 41af9150ad7..b2f749a0b82 100644
--- a/src/uu/shred/locales/en-US.ftl
+++ b/src/uu/shred/locales/en-US.ftl
@@ -42,6 +42,8 @@ shred-invalid-number-of-passes = invalid number of passes: {$passes}
shred-cannot-open-random-source = cannot op... | [
"src/uu/shred/locales/en-US.ftl",
"src/uu/shred/locales/fr-FR.ftl",
"src/uu/shred/src/shred.rs",
"tests/by-util/test_shred.rs"
] | [
{
"comment": "This code leads to unreachable code on line 641.\n\nGNU `shred` shows different errors for the scenarios \"path with trailing slash is a directory\" and \"path with trailing slash is a file\":\n```\n$ touch shred_file\n$ mkdir shred_dir\n$ shred shred_dir/\nshred: shred_dir/: failed to open for wr... | diff --git a/tests/by-util/test_shred.rs b/tests/by-util/test_shred.rs
index 43327fe0e8e..28812b106f4 100644
--- a/tests/by-util/test_shred.rs
+++ b/tests/by-util/test_shred.rs
@@ -434,3 +434,27 @@ fn test_gnu_shred_passes_different_counts() {
result.stderr_contains("pass 1/19 (random)");
result.stderr_contai... | true |
uutils/coreutils | 12,725 | comment_to_fix | shred: fix error message when path has trailing slash | This code leads to unreachable code on line 641.
GNU `shred` shows different errors for the scenarios "path with trailing slash is a directory" and "path with trailing slash is a file":
```
$ touch shred_file
$ mkdir shred_dir
$ shred shred_dir/
shred: shred_dir/: failed to open for writing: Is a directory
$ shred shr... | 962566b194f3a3ca38cc6eaf2a9aab593a9cd121 | d95d271ea732e9919ce75e363447d9dd13643daa | diff --git a/src/uu/shred/src/shred.rs b/src/uu/shred/src/shred.rs
index d382a999387..69bf981f1bd 100644
--- a/src/uu/shred/src/shred.rs
+++ b/src/uu/shred/src/shred.rs
@@ -625,6 +625,22 @@ fn wipe_file(
) -> UResult<()> {
// Get these potential errors out of the way first
let path = Path::new(path_str);
+
+... | [
"src/uu/shred/src/shred.rs"
] | [
{
"comment": "This code leads to unreachable code on line 641.\n\nGNU `shred` shows different errors for the scenarios \"path with trailing slash is a directory\" and \"path with trailing slash is a file\":\n```\n$ touch shred_file\n$ mkdir shred_dir\n$ shred shred_dir/\nshred: shred_dir/: failed to open for wr... | true | ||
uutils/coreutils | 12,732 | issue_to_patch | chroot panics (unwrap Err) on `--skip-chdir` with a non-existent NEWROOT
## Summary
Running `chroot --skip-chdir <NEWROOT>` with a NEWROOT that does not exist (or has an unreadable path component) panics during argument validation. To decide whether `--skip-chdir` is allowed, the code canonicalizes NEWROOT and unwrap... | chroot: don't panic on --skip-chdir with a non-resolving NEWROOT | Fixes #12731
`chroot --skip-chdir NEWROOT` aborted with a `Result::unwrap()` panic when NEWROOT did not resolve: the permitted-only-if check canonicalized NEWROOT and unwrapped the result, but `canonicalize` returns `Err` when the path (or a component) doesn't exist or isn't readable.
Map the `Err` to a non-match (`.... | dab93926d25269e0fdbc5445e40b71ee0d44ab8a | 256166af2e0af0233f1e748af297364697f1c7c8 | diff --git a/src/uu/chroot/src/chroot.rs b/src/uu/chroot/src/chroot.rs
index 23e696be914..985d8deb14e 100644
--- a/src/uu/chroot/src/chroot.rs
+++ b/src/uu/chroot/src/chroot.rs
@@ -171,8 +171,11 @@ pub fn uumain(args: impl uucore::Args) -> UResult<()> {
MissingHandling::Normal,
ResolveMode::Lo... | [
"src/uu/chroot/src/chroot.rs",
"tests/by-util/test_chroot.rs"
] | [] | diff --git a/tests/by-util/test_chroot.rs b/tests/by-util/test_chroot.rs
index 7d7a1c3b227..66e10927740 100644
--- a/tests/by-util/test_chroot.rs
+++ b/tests/by-util/test_chroot.rs
@@ -289,6 +289,15 @@ fn test_chroot_skip_chdir_not_root() {
.stderr_contains("chroot: option --skip-chdir only permitted if NEWROO... | true |
uutils/coreutils | 12,757 | issue_to_patch | bug(fmt): large width value cause a panic
Hi, uutils mainteners
to reproduce that use a large -w value, by example like
```rust
relunsec@relunsec:~/software/coreutils/target/debug$ ./fmt -w 267672676527678256
thread 'main' (78302) panicked at src/uu/fmt/src/fmt.rs:144:26:
attempt to multiply with overflow
note: run... | fmt: large width value causes a panic | this PR resolves #12698 | 542e7af8f1b6725113335fcfe49919c7a90c88be | 5a51fc2019f996f5a73de4f268f8529986782347 | diff --git a/src/uu/fmt/src/fmt.rs b/src/uu/fmt/src/fmt.rs
index dd8f10fd882..06cac3cb3ea 100644
--- a/src/uu/fmt/src/fmt.rs
+++ b/src/uu/fmt/src/fmt.rs
@@ -141,7 +141,10 @@ impl FmtOptions {
(0, 0)
}
(Some(w), None) => {
- let g = (w * DEFAULT_GOAL_TO_WIDTH_RAT... | [
"src/uu/fmt/src/fmt.rs",
"tests/by-util/test_fmt.rs"
] | [] | diff --git a/tests/by-util/test_fmt.rs b/tests/by-util/test_fmt.rs
index b223da5bc5c..8953cfe8a4e 100644
--- a/tests/by-util/test_fmt.rs
+++ b/tests/by-util/test_fmt.rs
@@ -428,3 +428,11 @@ fn test_fmt_invalid_utf8() {
.succeeds()
.stdout_is_bytes(b"=\xA0=\n");
}
+
+#[test]
+fn test_fmt_width_multipl... | true |
uutils/coreutils | 12,762 | issue_to_patch | pr panic (str char-boundary) on a multibyte char in the `-e` or `-n` argument
## Summary
`pr` byte-slices the argument of `-e`/`--expand-tabs` and `-n`/`--number-lines` to split the leading character from the trailing width. When that argument begins with a multibyte UTF-8 character (e.g. `€`, 3 bytes), the byte inde... | pr: reject a multibyte -e/-n argument instead of panicking | Fixes #12761
`pr -e<CHAR>` and `pr -n<CHAR>` (and an empty `--number-lines=`) byte-sliced the option argument at index 1 to split the leading character from the trailing width. A multibyte leading character (e.g. `€`) made that index land inside the code point, and an empty value sliced out of bounds — both aborted:
... | 542e7af8f1b6725113335fcfe49919c7a90c88be | c47b14919d8d173d0ac6fa259bc049edcf54d7a6 | diff --git a/src/uu/pr/locales/en-US.ftl b/src/uu/pr/locales/en-US.ftl
index 946dea2cb51..22635349f72 100644
--- a/src/uu/pr/locales/en-US.ftl
+++ b/src/uu/pr/locales/en-US.ftl
@@ -102,3 +102,4 @@ pr-error-column-merge-conflict = cannot specify number of columns when printing
pr-error-across-merge-conflict = cannot sp... | [
"src/uu/pr/locales/en-US.ftl",
"src/uu/pr/locales/fr-FR.ftl",
"src/uu/pr/src/pr.rs",
"tests/by-util/test_pr.rs"
] | [] | diff --git a/tests/by-util/test_pr.rs b/tests/by-util/test_pr.rs
index d1b0c757561..16a4032a7f5 100644
--- a/tests/by-util/test_pr.rs
+++ b/tests/by-util/test_pr.rs
@@ -53,6 +53,34 @@ fn test_invalid_flag() {
.no_stdout();
}
+#[test]
+fn test_expand_tabs_multibyte_char_is_rejected() {
+ for arg in ["-e€"... | true |
uutils/coreutils | 12,717 | issue_to_patch | yes: match with GNU's strace behaviour | GNU 9.11 yes catches strace injections for zero-copy syscalls except for 1st one:
```
$ strace -o /dev/null -e fault=splice:error=EINTR:when=2 gnu9.11/yes>/dev/null
yes: standard output: Interrupted system call
``` | d21d02e6ab401637c5d54007b99909d3c81acd8e | 69607fa943c013aad60a20cdd9559ea2d514af9c | diff --git a/src/uu/yes/src/yes.rs b/src/uu/yes/src/yes.rs
index a24fb8e4688..b07b496345f 100644
--- a/src/uu/yes/src/yes.rs
+++ b/src/uu/yes/src/yes.rs
@@ -111,23 +111,21 @@ pub fn exec(bytes: &[u8]) -> io::Result<()> {
let stdout = rustix::stdio::stdout();
// improve throughput
let _ = rustix::pipe::fc... | [
"src/uu/yes/src/yes.rs"
] | [] | true | ||
uutils/coreutils | 12,756 | issue_to_patch | truncate: remove duplicate test | This PR removes the test `test_failed_2` as it is a duplicate of `test_error_filename_only`. | 42235374f114a7428fa1dc750111b08d924a848f | 612af0264d5e702c7c6d56476186cd535b3e4445 | [
"tests/by-util/test_truncate.rs"
] | [] | diff --git a/tests/by-util/test_truncate.rs b/tests/by-util/test_truncate.rs
index 5f046ca688..21fbc8558f 100644
--- a/tests/by-util/test_truncate.rs
+++ b/tests/by-util/test_truncate.rs
@@ -89,12 +89,6 @@ fn test_failed() {
new_ucmd!().fails();
}
-#[test]
-fn test_failed_2() {
- let (_at, mut ucmd) = at_and... | true | ||
uutils/coreutils | 12,754 | issue_to_patch | GnuTests (SMACK): bump busybox URL | f406ea0b29f0dd585c30261b74ade68e9dc7b6c5 | 2b319a7aefab9f803084586954a10948b0835121 | diff --git a/util/run-gnu-tests-smack-ci.sh b/util/run-gnu-tests-smack-ci.sh
index 867a15dad4a..3eaae1ea24d 100755
--- a/util/run-gnu-tests-smack-ci.sh
+++ b/util/run-gnu-tests-smack-ci.sh
@@ -21,7 +21,7 @@ sudo apt-get install -y --no-install-recommends linux-image-generic
sudo install -Dvm644 "$(ls -1 /boot/vmlinuz-... | [
"util/run-gnu-tests-smack-ci.sh"
] | [] | true | |||
uutils/coreutils | 12,755 | issue_to_patch | tail: reduce code | f406ea0b29f0dd585c30261b74ade68e9dc7b6c5 | 3429804989df11b16b88b5c7051a7ab167734851 | diff --git a/src/uu/tail/src/platform/unix.rs b/src/uu/tail/src/platform/unix.rs
index d980f258cf..d233f8eb6f 100644
--- a/src/uu/tail/src/platform/unix.rs
+++ b/src/uu/tail/src/platform/unix.rs
@@ -36,12 +36,5 @@ impl Drop for ProcessChecker {
}
pub fn supports_pid_checks(pid: Pid) -> bool {
- let Some(pid) = R... | [
"src/uu/tail/src/platform/unix.rs"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.