repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
vercel/hyper
7,853
issue_to_patch
Bump dawidd6/action-download-artifact from 3.1.2 to 3.1.4
Bumps [dawidd6/action-download-artifact](https://github.com/dawidd6/action-download-artifact) from 3.1.2 to 3.1.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/dawidd6/action-download-artifact/releases">dawidd6/action-download-artifact's releases</a>.</em></p> <blockquote> ...
56617230191b24e63744753d0e2427fb4f724a9c
31ffb1bc1ea8793c3b00fa7b1f293c0deea91a77
diff --git a/.github/workflows/e2e_comment.yml b/.github/workflows/e2e_comment.yml index cd62c09bd818..573a4d5908b8 100644 --- a/.github/workflows/e2e_comment.yml +++ b/.github/workflows/e2e_comment.yml @@ -14,14 +14,14 @@ jobs: WORKFLOW_RUN_INFO: ${{ toJSON(github.event.workflow_run) }} run: echo "...
[ ".github/workflows/e2e_comment.yml" ]
[]
true
vercel/hyper
3,038
issue_to_patch
Add scrollback option to config
As I was preparing this PR I was surprised to find that there was very little test coverage. Perhaps I am missing something? It'd be great to get this pushed through and I am fairly confident the change is working as expected, but it feels strange to add functionality without writing/running tests 🤔 ... Addition...
f75895a176d421d579611ba84fdba88d1ebedab2
cb1503d2101f7f84a1aaa5248687fad5c8d52a5c
diff --git a/lib/components/term-group.js b/lib/components/term-group.js index 38f67c8d2531..328f959b4f99 100644 --- a/lib/components/term-group.js +++ b/lib/components/term-group.js @@ -58,6 +58,7 @@ class TermGroup_ extends React.PureComponent { const props = getTermProps(uid, this.props, { isTermActive: ...
[ "lib/components/term-group.js", "lib/components/term.js", "lib/components/terms.js", "lib/containers/terms.js", "lib/reducers/ui.js" ]
[]
true
vercel/hyper
7,812
issue_to_patch
Bump @types/react from 18.2.56 to 18.2.58
Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.2.56 to 18.2.58. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react">compare view</a></li> </ul> </details> <br /> [![...
6b6b97dd7b54421c36e15bb62a910239dc78455c
c0089029285bb97cb4f3aed1ae64febc2fb5f8b3
diff --git a/package.json b/package.json index 3504de8366be..0f16974cb9fb 100644 --- a/package.json +++ b/package.json @@ -93,7 +93,7 @@ "@types/ms": "0.7.34", "@types/node": "18.19.17", "@types/plist": "3.0.5", - "@types/react": "18.2.56", + "@types/react": "18.2.58", "@types/react-dom": "18....
[ "package.json", "yarn.lock" ]
[]
true
vercel/next.js
94,783
issue_to_patch
Avoid a premature Suspense fallback flash in the streaming dev render
The Cache Components streaming dev render streams the response while filling caches in the background, but when those caches are already warm it should behave like a production render, delivering the cached content as part of the shell rather than behind a Suspense fallback. The render previously held the stream back u...
6caa2285585bb3866d59348a68e3944e3a55157d
0352438dff9acb5a921390c7ba3e278c9fef2cfe
diff --git a/packages/next/src/client/components/router-reducer/fetch-server-response.ts b/packages/next/src/client/components/router-reducer/fetch-server-response.ts index 6b3830ee08c..0fd18a1e366 100644 --- a/packages/next/src/client/components/router-reducer/fetch-server-response.ts +++ b/packages/next/src/client/co...
[ "packages/next/src/client/components/router-reducer/fetch-server-response.ts", "packages/next/src/client/components/router-reducer/ppr-navigations.ts", "packages/next/src/client/components/segment-cache/navigation.ts", "packages/next/src/server/app-render/app-render.tsx", "packages/next/src/shared/lib/app-r...
[ { "comment": "in what scenario does `revealAfter`reject?", "path": "packages/next/src/client/components/router-reducer/ppr-navigations.ts", "hunk": "@@ -1949,7 +1959,18 @@ function finishPendingCacheNode(\n // This is a deferred RSC promise. We can fulfill it with the data we just\n // received ...
diff --git a/test/development/app-dir/cache-components-dev-streaming/cache-components-dev-streaming.test.ts b/test/development/app-dir/cache-components-dev-streaming/cache-components-dev-streaming.test.ts index a5faa29c871..e45ff7fcb78 100644 --- a/test/development/app-dir/cache-components-dev-streaming/cache-component...
true
vercel/next.js
94,783
comment_to_fix
Avoid a premature Suspense fallback flash in the streaming dev render
in what scenario does `revealAfter`reject?
6caa2285585bb3866d59348a68e3944e3a55157d
0352438dff9acb5a921390c7ba3e278c9fef2cfe
diff --git a/packages/next/src/client/components/router-reducer/ppr-navigations.ts b/packages/next/src/client/components/router-reducer/ppr-navigations.ts index c40d7dec042..675385b5674 100644 --- a/packages/next/src/client/components/router-reducer/ppr-navigations.ts +++ b/packages/next/src/client/components/router-re...
[ "packages/next/src/client/components/router-reducer/ppr-navigations.ts" ]
[ { "comment": "in what scenario does `revealAfter`reject?", "path": "packages/next/src/client/components/router-reducer/ppr-navigations.ts", "hunk": "@@ -1949,7 +1959,18 @@ function finishPendingCacheNode(\n // This is a deferred RSC promise. We can fulfill it with the data we just\n // received ...
true
vercel/next.js
94,783
comment_to_fix
Avoid a premature Suspense fallback flash in the streaming dev render
we can skip putting it in if `holdStreamUntilRevealed`, right? that'd be a nice symmetry with the `if (holdStreamUntilRevealed) { await revealAfter.promise }` bit downstairs, it's a bit weird otherwise
6caa2285585bb3866d59348a68e3944e3a55157d
0352438dff9acb5a921390c7ba3e278c9fef2cfe
diff --git a/packages/next/src/server/app-render/app-render.tsx b/packages/next/src/server/app-render/app-render.tsx index 1855a35b306..1efbcd88dbd 100644 --- a/packages/next/src/server/app-render/app-render.tsx +++ b/packages/next/src/server/app-render/app-render.tsx @@ -1341,23 +1341,27 @@ async function generateDyna...
[ "packages/next/src/server/app-render/app-render.tsx" ]
[ { "comment": "we can skip putting it in if `holdStreamUntilRevealed`, right? that'd be a nice symmetry with the `if (holdStreamUntilRevealed) { await revealAfter.promise }` bit downstairs, it's a bit weird otherwise", "path": "packages/next/src/server/app-render/app-render.tsx", "hunk": "@@ -4545,42 +45...
true
vercel/next.js
94,754
issue_to_patch
fix: this in edge sandbox setTimeout/setInterval
Our attempts at setting the correct `this` in our `setTimeout`/`setInterval` polyfills were slightly incorrect, because they used the wrong global object. (Thanks to [cyberjoker](https://hackerone.com/cyberjoker) for discovering this)
643e34a59183f90ae9d2db9a64673781316ce786
6eda99eeff475c40713143a8054c721acd822035
diff --git a/packages/next/src/server/web/sandbox/context.ts b/packages/next/src/server/web/sandbox/context.ts index 431505ae5165..10b34ad89933 100644 --- a/packages/next/src/server/web/sandbox/context.ts +++ b/packages/next/src/server/web/sandbox/context.ts @@ -436,7 +436,7 @@ Learn More: https://nextjs.org/docs/messa...
[ "packages/next/src/server/web/sandbox/context.ts", "packages/next/src/server/web/sandbox/resource-managers.ts", "test/e2e/edge-runtime-timer-this/app/route.ts", "test/e2e/edge-runtime-timer-this/edge-runtime-timer-this.test.ts", "test/e2e/edge-runtime-timer-this/next.config.ts" ]
[ { "comment": "This works, but why not store the context in the resource manager itself and save all the spreading and whatnot", "path": "packages/next/src/server/web/sandbox/resource-managers.ts", "hunk": "@@ -49,7 +49,10 @@ class TimeoutsManager extends ResourceManager<\n }\n }\n \n+export type Globa...
diff --git a/test/e2e/edge-runtime-timer-this/app/route.ts b/test/e2e/edge-runtime-timer-this/app/route.ts new file mode 100644 index 000000000000..15f29c538e8c --- /dev/null +++ b/test/e2e/edge-runtime-timer-this/app/route.ts @@ -0,0 +1,24 @@ +export const runtime = 'edge' + +export async function GET() { + const res...
true
vercel/next.js
94,771
issue_to_patch
Generalize IsRootLayout prefetch hint to IsRootLayoutOrAbove
Encodes via a prefetch hint whether a given segment is at or above the root layout. The client can use this to determine whether a param is a "root param" (as defined by Next.js: a param that appears above the topmost layout.tsx for a given route). The `IsRootLayout` hint has been replaced by `IsRootLayoutOrAbove`. Th...
5d69485828526b60c4ab3116d49adb24a1312f5e
102fa1bd37175780165f8532870e0010d2a41f99
diff --git a/packages/next/src/client/components/router-reducer/is-navigating-to-new-root-layout.ts b/packages/next/src/client/components/router-reducer/is-navigating-to-new-root-layout.ts index c7bd7d7444f7..c614d31b9ab1 100644 --- a/packages/next/src/client/components/router-reducer/is-navigating-to-new-root-layout.t...
[ "packages/next/src/client/components/router-reducer/compute-changed-path.test.ts", "packages/next/src/client/components/router-reducer/is-navigating-to-new-root-layout.ts", "packages/next/src/client/components/router-reducer/ppr-navigations.ts", "packages/next/src/client/components/router-reducer/should-hard-...
[]
diff --git a/packages/next/src/client/components/router-reducer/compute-changed-path.test.ts b/packages/next/src/client/components/router-reducer/compute-changed-path.test.ts index bf6eea2756b0..5f9522331f09 100644 --- a/packages/next/src/client/components/router-reducer/compute-changed-path.test.ts +++ b/packages/next...
true
vercel/next.js
94,773
issue_to_patch
Allow root params in the App Shell (client)
The App Shell is the generic loading state for a route. It does not depend on concrete param values, so it can be used for every navigation to a route before its params are known. We've decided to special case root params: those that appear above the topmost layout for a given route. These are typically used for param...
dfa80cd4b49b1c91c3ad5d0218b07ea1da7112a8
d7b465091c8aa1fe135b2edbec9a9d91878277b7
diff --git a/packages/next/src/client/components/segment-cache/cache.ts b/packages/next/src/client/components/segment-cache/cache.ts index e6fed88d28b..26d206bf1c7 100644 --- a/packages/next/src/client/components/segment-cache/cache.ts +++ b/packages/next/src/client/components/segment-cache/cache.ts @@ -46,6 +46,7 @@ i...
[ "packages/next/src/client/components/segment-cache/cache.ts", "packages/next/src/client/components/segment-cache/optimistic-routes.ts", "packages/next/src/client/components/segment-cache/vary-path.ts" ]
[]
true
vercel/next.js
94,764
issue_to_patch
refactor: process streaming prerenders more efficiently
Introducing a brand new concept: processing a stream by having a callback invoked whenever a chunk is emitted. No more tee()ing streams just to run two loops over the chunks from a render. Turns out node streams had it right all along This lets us simplify the (stream) runtime prerender and static prerender codepath...
658d3786e73b189817e6e872ef124349ebe6e8c7
88f02f76951f82329bc61f7478ed9744d562f8da
diff --git a/packages/next/src/server/app-render/app-render.tsx b/packages/next/src/server/app-render/app-render.tsx index 5cd3271a872..1855a35b306 100644 --- a/packages/next/src/server/app-render/app-render.tsx +++ b/packages/next/src/server/app-render/app-render.tsx @@ -1735,6 +1735,16 @@ async function finalRuntimeS...
[ "packages/next/src/server/app-render/app-render.tsx" ]
[ { "comment": "drive-by fix. the node branch never accumulates anything if `cancelled` is set. a `cancel()` call results in a `{ done: true }` chunk, so this probably doesn't matter, but this guarantees parity.", "path": "packages/next/src/server/app-render/app-render.tsx", "hunk": "@@ -4982,11 +4981,11 ...
true
vercel/next.js
94,712
issue_to_patch
[turbopack] Use `final_read_hint` in top level turbo tasks
Use `final_read_hint` on top level turbo tasks For many top level tasks where we are returning data there is no need for turbo-tasks to hold on to it afterwars, but these are typically also _transient_ and thus un-evictable. So use the `final_read_hint` to allow turbo tasks to drop the cell after reading it. The big...
d056188b458f4f7aa4f7a61e084d5c34c56a8721
f3ed4ffc329c1c51cfad516c98ee54b4a34d2e0d
diff --git a/crates/next-napi-bindings/src/next_api/project.rs b/crates/next-napi-bindings/src/next_api/project.rs index b3895bbb0ee5..f1028eee9b8e 100644 --- a/crates/next-napi-bindings/src/next_api/project.rs +++ b/crates/next-napi-bindings/src/next_api/project.rs @@ -1362,6 +1362,7 @@ pub async fn project_write_all_...
[ "crates/next-napi-bindings/src/next_api/project.rs", "crates/next-napi-bindings/src/next_api/utils.rs", "turbopack/crates/turbo-tasks/src/effect.rs" ]
[]
true
vercel/next.js
94,717
issue_to_patch
[turbopack] Optimize cell_dependency representation
Split the representtation of cell dependencies to split `hashed` and `non-hashed` dependencies into separate structures Hashed deps are rare but the bloat the size of the edge representation so a distinct field can optimize for the common case. | | canary | branch | delta | per...
658d3786e73b189817e6e872ef124349ebe6e8c7
86eadeee30cdf5c48c3bec46bab85ba35dd22dca
diff --git a/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs b/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs index 076b318951ad..a7659ef8ff3c 100644 --- a/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs +++ b/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs @@ -70,8 +70,8 @@ use crate::...
[ "turbopack/crates/turbo-tasks-backend/src/backend/mod.rs", "turbopack/crates/turbo-tasks-backend/src/backend/operation/cleanup_old_edges.rs", "turbopack/crates/turbo-tasks-backend/src/backend/operation/mod.rs", "turbopack/crates/turbo-tasks-backend/src/backend/operation/update_cell.rs", "turbopack/crates/tu...
[ { "comment": "this can probably be larger than 1, it should be sized as large as possible without growsing the size of the lazy field enum", "path": "turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs", "hunk": "@@ -245,15 +245,27 @@ struct TaskStorageSchema {\n )]\n output_depen...
true
vercel/next.js
94,717
comment_to_fix
[turbopack] Optimize cell_dependency representation
this can probably be larger than 1, it should be sized as large as possible without growsing the size of the lazy field enum
658d3786e73b189817e6e872ef124349ebe6e8c7
86eadeee30cdf5c48c3bec46bab85ba35dd22dca
diff --git a/turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs b/turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs index a3a8f8f7549b..509ccb952f8c 100644 --- a/turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs +++ b/turbopack/crates/turbo-tasks-backend/src/backend/sto...
[ "turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs" ]
[ { "comment": "this can probably be larger than 1, it should be sized as large as possible without growsing the size of the lazy field enum", "path": "turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs", "hunk": "@@ -245,15 +245,27 @@ struct TaskStorageSchema {\n )]\n output_depen...
true
vercel/next.js
94,717
comment_to_fix
[turbopack] Optimize cell_dependency representation
ditto
658d3786e73b189817e6e872ef124349ebe6e8c7
86eadeee30cdf5c48c3bec46bab85ba35dd22dca
diff --git a/turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs b/turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs index a3a8f8f7549b..509ccb952f8c 100644 --- a/turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs +++ b/turbopack/crates/turbo-tasks-backend/src/backend/sto...
[ "turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs" ]
[ { "comment": "ditto", "path": "turbopack/crates/turbo-tasks-backend/src/backend/storage_schema.rs", "hunk": "@@ -269,9 +281,13 @@ struct TaskStorageSchema {\n #[field(storage = \"auto_set\", category = \"transient\", shrink_on_completion)]\n outdated_output_dependencies: AutoSet<TaskId, 6>,\n \n...
true
vercel/next.js
94,717
comment_to_fix
[turbopack] Optimize cell_dependency representation
The track_dependencies flag is not needed. That is already tracked by reader_task.is_some()
658d3786e73b189817e6e872ef124349ebe6e8c7
86eadeee30cdf5c48c3bec46bab85ba35dd22dca
diff --git a/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs b/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs index 076b318951ad..a7659ef8ff3c 100644 --- a/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs +++ b/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs @@ -70,8 +70,8 @@ use crate::...
[ "turbopack/crates/turbo-tasks-backend/src/backend/mod.rs" ]
[ { "comment": "The track_dependencies flag is not needed. That is already tracked by reader_task.is_some()", "path": "turbopack/crates/turbo-tasks-backend/src/backend/mod.rs", "hunk": "@@ -821,7 +827,7 @@ impl TurboTasksBackend {\n } = options;\n \n let mut ctx = self.execute_context(turb...
true
vercel/next.js
94,570
issue_to_patch
disallow reads from .next-profiles
`next` already disallows reading out of `.next` during a build, this extends that to the new `.next-profiles` directory This is currently hardcoded (not end user configurable), so we just hardcode the path in the next entrypoints.
2cc99c73b5a89f36750cb9a914b52d880a33ec80
e246323570cdb12e47574224ea98ceef8ccfb78a
diff --git a/crates/next-api/src/project.rs b/crates/next-api/src/project.rs index 3fb85621a24d..d68ce7ec5d7d 100644 --- a/crates/next-api/src/project.rs +++ b/crates/next-api/src/project.rs @@ -16,7 +16,8 @@ use next_core::{ ClientChunkingContextOptions, get_client_chunking_context, get_client_compile_time_in...
[ "crates/next-api/src/project.rs", "crates/next-core/src/next_config.rs", "crates/next-napi-bindings/src/next_api/project.rs" ]
[]
true
vercel/next.js
94,561
issue_to_patch
[turbopack] Drop data while serializing in `next build`
When turbopack persists it needs to allocate scratch buffers and gather and sort large amounts of data before it can start writing to disk. Fundamentally this is because in memory the data is organized by FxHash and on disk it is by a different hash function and sorted. We get more efficient output files if we buffer ...
ea74495726b32244c014686613724ce56e25c98b
cbdde6cef266d5b07c6e55bc23ac023bcd60f53b
diff --git a/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs b/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs index 879c4ed9c76a..076b318951ad 100644 --- a/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs +++ b/turbopack/crates/turbo-tasks-backend/src/backend/mod.rs @@ -170,6 +170,35 @@ pub enum...
[ "turbopack/crates/turbo-tasks-backend/src/backend/mod.rs", "turbopack/crates/turbo-tasks-backend/src/backend/storage.rs" ]
[ { "comment": "In drain_entries mode we technically don't need to keep track of the modified tasks. Since we erase all non-modified tasks we could just iterate over the remaining entries in the map. That would avoid the Vec and a lot of map lookups.", "path": "turbopack/crates/turbo-tasks-backend/src/backend...
true
vercel/next.js
94,561
comment_to_fix
[turbopack] Drop data while serializing in `next build`
In drain_entries mode we technically don't need to keep track of the modified tasks. Since we erase all non-modified tasks we could just iterate over the remaining entries in the map. That would avoid the Vec and a lot of map lookups.
ea74495726b32244c014686613724ce56e25c98b
cbdde6cef266d5b07c6e55bc23ac023bcd60f53b
diff --git a/turbopack/crates/turbo-tasks-backend/src/backend/storage.rs b/turbopack/crates/turbo-tasks-backend/src/backend/storage.rs index 17f3e2204cc0..a34b3ab7cbc4 100644 --- a/turbopack/crates/turbo-tasks-backend/src/backend/storage.rs +++ b/turbopack/crates/turbo-tasks-backend/src/backend/storage.rs @@ -9,6 +9,8 ...
[ "turbopack/crates/turbo-tasks-backend/src/backend/storage.rs" ]
[ { "comment": "In drain_entries mode we technically don't need to keep track of the modified tasks. Since we erase all non-modified tasks we could just iterate over the remaining entries in the map. That would avoid the Vec and a lot of map lookups.", "path": "turbopack/crates/turbo-tasks-backend/src/backend...
true
vercel/next.js
94,561
comment_to_fix
[turbopack] Drop data while serializing in `next build`
I think it might make sense to split the logic into two separate methods `take_snapshot` and `into_snapshot`. This would allow to move the shards into the returned type and iterator.
ea74495726b32244c014686613724ce56e25c98b
cbdde6cef266d5b07c6e55bc23ac023bcd60f53b
diff --git a/turbopack/crates/turbo-tasks-backend/src/backend/storage.rs b/turbopack/crates/turbo-tasks-backend/src/backend/storage.rs index 17f3e2204cc0..a34b3ab7cbc4 100644 --- a/turbopack/crates/turbo-tasks-backend/src/backend/storage.rs +++ b/turbopack/crates/turbo-tasks-backend/src/backend/storage.rs @@ -9,6 +9,8 ...
[ "turbopack/crates/turbo-tasks-backend/src/backend/storage.rs" ]
[ { "comment": "I think it might make sense to split the logic into two separate methods `take_snapshot` and `into_snapshot`. This would allow to move the shards into the returned type and iterator.", "path": "turbopack/crates/turbo-tasks-backend/src/backend/storage.rs", "hunk": "@@ -270,13 +270,17 @@ imp...
true
vercel/next.js
94,749
issue_to_patch
[CC] Rename shellStage to streamReleaseStage
"shell" is quite overloaded these days. it gets especially confusing in #94595, where we're dealing with app shells in dev for validation purposes. since the variable currently only controls the server-side buffering/release of the stream, we can just rename it to match that.
d0562082e9a24db6a0d421d41a625889a1a56ef1
3e538b4f90ef879b34ada90a42e825e9856064dd
diff --git a/packages/next/src/server/app-render/app-render.tsx b/packages/next/src/server/app-render/app-render.tsx index bece804364e..5cd3271a872 100644 --- a/packages/next/src/server/app-render/app-render.tsx +++ b/packages/next/src/server/app-render/app-render.tsx @@ -1341,7 +1341,7 @@ async function generateDynami...
[ "packages/next/src/server/app-render/app-render.tsx" ]
[]
true
vercel/next.js
94,678
issue_to_patch
[CC] Exclude caches with low stale from static prerenders
In #[94645](https://github.com/vercel/next.js/pull/94645) we discovered that there's a disparity between how we handle caches with low stale time (<30s): runtime prerenders exclude them, but static prerenders do not. We should avoid situations where a static prerender contains data that a runtime prerender of the same ...
902a7c3e5de8e0b02bc066db7380c0b02f2316cf
fd99970be287830b830e4e4d6f454c225900c49a
diff --git a/packages/next/src/server/app-render/app-render.tsx b/packages/next/src/server/app-render/app-render.tsx index 81a596811daf..bece804364e2 100644 --- a/packages/next/src/server/app-render/app-render.tsx +++ b/packages/next/src/server/app-render/app-render.tsx @@ -4377,7 +4377,6 @@ function runDevValidationIn...
[ "packages/next/src/server/app-render/app-render.tsx", "packages/next/src/server/app-render/work-unit-async-storage.external.ts", "packages/next/src/server/use-cache/constants.ts", "packages/next/src/server/use-cache/use-cache-wrapper.ts", "test/development/app-dir/cache-components-dev-warmup/cache-component...
[ { "comment": "this (pre-existing) dev gate is outdated, because we should also be excluding the cache it in cachedNavigations and build-time instant validation. planning to remove it in #94679 (unless we discover reasons not to)", "path": "packages/next/src/server/use-cache/use-cache-wrapper.ts", "hunk"...
diff --git a/test/development/app-dir/cache-components-dev-warmup/cache-components.dev-warmup.test.ts b/test/development/app-dir/cache-components-dev-warmup/cache-components.dev-warmup.test.ts index b17d24c3a922..1d9fb5b568d2 100644 --- a/test/development/app-dir/cache-components-dev-warmup/cache-components.dev-warmup....
true
vercel/next.js
94,605
issue_to_patch
docs: document non-streamed bot rendering and Cache Components
Bots get to see the fully formed HTML page - and hit the server, rather than receiving a static shell from PPR.
902a7c3e5de8e0b02bc066db7380c0b02f2316cf
676311780f2070694d57cad03c059dca078b538c
diff --git a/docs/01-app/01-getting-started/06-fetching-data.mdx b/docs/01-app/01-getting-started/06-fetching-data.mdx index 67d2f2a7837d..5b967df0d227 100644 --- a/docs/01-app/01-getting-started/06-fetching-data.mdx +++ b/docs/01-app/01-getting-started/06-fetching-data.mdx @@ -116,6 +116,8 @@ There are two ways you ca...
[ "docs/01-app/01-getting-started/06-fetching-data.mdx", "docs/01-app/01-getting-started/08-caching.mdx", "docs/01-app/02-guides/streaming.mdx" ]
[]
true
vercel/next.js
94,711
issue_to_patch
[App Shells] refactor instant-validation to make adding new stages easier
Extracted from #94595. Cleans up a bunch of stuff in the `instant-validation`module that deals with assembling payloads for instant validation, no behavioral changes.
40d08d6630642d035c0239064e23c9eb1cc0a6ae
4d3f0a44b5728befeeffb3e214a1d579a62004b6
diff --git a/packages/next/src/server/app-render/instant-validation/instant-validation.tsx b/packages/next/src/server/app-render/instant-validation/instant-validation.tsx index 843b7701334d..44b25ca56a51 100644 --- a/packages/next/src/server/app-render/instant-validation/instant-validation.tsx +++ b/packages/next/src/s...
[ "packages/next/src/server/app-render/instant-validation/instant-validation.tsx" ]
[]
true
vercel/next.js
94,718
issue_to_patch
[CC] refactor staged rendering codepaths in params/searchParams
The 'request' codepath in params/searchParams was forked `process.env.NODE_ENV === 'development'`, but that's a leftover from when dev was the only place where we did staged rendering. It didn't account for conditions like `--debug-prerender`, and now makes it generally confusing to reason about. This PR simplifies the...
3574821c771324300d974131b55aa9843a349522
d2f9473305ea6d937bfae6638543bf5eeb1c7133
diff --git a/packages/next/src/server/request/params.ts b/packages/next/src/server/request/params.ts index 46bdf42380c..4396440b501 100644 --- a/packages/next/src/server/request/params.ts +++ b/packages/next/src/server/request/params.ts @@ -89,30 +89,28 @@ export function createParamsFromClient( throw new Inva...
[ "packages/next/src/server/request/params.ts", "packages/next/src/server/request/root-params.ts", "packages/next/src/server/request/search-params.ts" ]
[ { "comment": "In `createRenderSearchParams`\\, the `workStore.forceStatic` check was placed after the `asyncApiPromises` branch\\, so a `force-static` page running under cacheComponents\\+cachedNavigations returns real \\(staged\\) searchParams instead of the empty `{}` that `forceStatic` must always force\\.\n...
true
vercel/next.js
94,718
comment_to_fix
[CC] refactor staged rendering codepaths in params/searchParams
In `createRenderSearchParams`\, the `workStore.forceStatic` check was placed after the `asyncApiPromises` branch\, so a `force-static` page running under cacheComponents\+cachedNavigations returns real \(staged\) searchParams instead of the empty `{}` that `forceStatic` must always force\. <!-- VADE-CATEGORY: logic --...
3574821c771324300d974131b55aa9843a349522
d2f9473305ea6d937bfae6638543bf5eeb1c7133
diff --git a/packages/next/src/server/request/search-params.ts b/packages/next/src/server/request/search-params.ts index 75fd19ea01a..c055618e3bb 100644 --- a/packages/next/src/server/request/search-params.ts +++ b/packages/next/src/server/request/search-params.ts @@ -270,47 +270,98 @@ function createRenderSearchParams...
[ "packages/next/src/server/request/search-params.ts" ]
[ { "comment": "In `createRenderSearchParams`\\, the `workStore.forceStatic` check was placed after the `asyncApiPromises` branch\\, so a `force-static` page running under cacheComponents\\+cachedNavigations returns real \\(staged\\) searchParams instead of the empty `{}` that `forceStatic` must always force\\.\n...
true
vercel/next.js
94,557
issue_to_patch
[ci] Always upload canary tarballs from the canary branch
`canary` is the branch we reference in protected environments and the branch we work on. The default branch in the private mirror is not functional so this needs changing.
c082ffe4e23a3514c842d27b42b7bbd465e2e29a
6f332314cdc1b536650df8cd15205b653bc14681
diff --git a/.github/workflows/upload_preview_tarballs.yml b/.github/workflows/upload_preview_tarballs.yml index 5dfe5a929b0e..f91e19e3873c 100644 --- a/.github/workflows/upload_preview_tarballs.yml +++ b/.github/workflows/upload_preview_tarballs.yml @@ -35,7 +35,7 @@ jobs: # matches that, ensuring the upload sc...
[ ".github/workflows/upload_preview_tarballs.yml" ]
[]
true
vercel/next.js
94,690
issue_to_patch
codemod: pnpm ignores package.json overrides as of v11 ### Link to the code that reproduces this issue https://github.com/Brycero/pnpm-override ### To Reproduce 1. Run `pnpx @next/codemod upgrade latest` against the sample project using pnpm v11+. 2. pnpm will return a warning about the pnpm overrides field no long...
[codemod] Write pnpm overrides to pnpm-workspace.yaml on pnpm v11+
pnpm v1 stopped reading `pnpm.overrides` (and `pnpm.patchedDependencies`) from `package.json`. The canonical location moved to `pnpm-workspace.yaml#overrides`. `next-codemod upgrade` uses overrides to pin `@types/react` / `@types/react-dom` during React major upgrades. On pnpm v11 those pins were a no-op. On pnpm...
40d08d6630642d035c0239064e23c9eb1cc0a6ae
77ee772c824ecc66a808ae604da80900d820194d
diff --git a/packages/next-codemod/bin/__testfixtures__/pnpm-v11-overrides/README.md b/packages/next-codemod/bin/__testfixtures__/pnpm-v11-overrides/README.md new file mode 100644 index 000000000000..b3ff0b5c52d3 --- /dev/null +++ b/packages/next-codemod/bin/__testfixtures__/pnpm-v11-overrides/README.md @@ -0,0 +1,44 @...
[ "packages/next-codemod/bin/__testfixtures__/pnpm-v11-overrides/README.md", "packages/next-codemod/bin/__testfixtures__/pnpm-v11-overrides/package.json", "packages/next-codemod/bin/__testfixtures__/pnpm-v11-overrides/pnpm-workspace.yaml", "packages/next-codemod/bin/upgrade.ts", "packages/next-codemod/lib/han...
[ { "comment": "could swap out for `semver` (already installed)", "path": "packages/next-codemod/lib/handle-package.ts", "hunk": "@@ -1,9 +1,57 @@\n import findUp from 'find-up'\n import execa from 'execa'\n+import { execSync } from 'node:child_process'\n import { basename } from 'node:path'\n \n export t...
true
vercel/next.js
94,729
issue_to_patch
Treat empty resume bodies as dynamic render requests
Distinguish an absent postponed state from an empty one so cold RDC resume requests perform a full dynamic RSC render instead of being rejected or treated as revalidation.
fd2669ea021e6faeb40805736fb1b1729880488f
ddac51e1fb496f203566f5eefbe0098ce82c63cf
diff --git a/packages/next/src/build/templates/app-page.ts b/packages/next/src/build/templates/app-page.ts index 60e5c16d3ee..f62b11e1e28 100644 --- a/packages/next/src/build/templates/app-page.ts +++ b/packages/next/src/build/templates/app-page.ts @@ -376,7 +376,7 @@ export async function handler( } if ( - ...
[ "packages/next/src/build/templates/app-page.ts", "packages/next/src/server/base-server.ts", "test/production/app-dir/empty-resume/app/dynamic/[slug]/page.tsx", "test/production/app-dir/empty-resume/app/layout.tsx", "test/production/app-dir/empty-resume/empty-resume.test.ts", "test/production/app-dir/empty...
[]
diff --git a/test/production/app-dir/empty-resume/app/dynamic/[slug]/page.tsx b/test/production/app-dir/empty-resume/app/dynamic/[slug]/page.tsx new file mode 100644 index 00000000000..b9c417ad7a1 --- /dev/null +++ b/test/production/app-dir/empty-resume/app/dynamic/[slug]/page.tsx @@ -0,0 +1,16 @@ +import { connection ...
true
vercel/next.js
94,484
issue_to_patch
[App Shells] Track whether shell prefetch used session data
When we send a `next-router-prefetch: 3` request, we now track if unblocking session data produced new content. Exposed as `u?: Promise<boolean>` on the navigation response.
0d49fafbea5c095d632dee67bf25d729b3fbe3ea
f6026371da00efeb41adc8c36b0e6bcdf535b532
diff --git a/packages/next/src/server/app-render/app-render.tsx b/packages/next/src/server/app-render/app-render.tsx index cf6dfc5fec06..81a596811daf 100644 --- a/packages/next/src/server/app-render/app-render.tsx +++ b/packages/next/src/server/app-render/app-render.tsx @@ -604,6 +604,7 @@ async function generateDynami...
[ "packages/next/src/server/app-render/app-render.tsx", "packages/next/src/shared/lib/app-router-types.ts" ]
[]
true
vercel/next.js
94,503
issue_to_patch
migrate turbo-tasks to scattered collect
# What This uses `scatter_collect` from @mmastrac to register all values, traits and value impls of traits. now all data can be consistently accessed when constructing the VALUEs registry, eliminating a number of racy access opportunities. # Why Scatter collect uses link sections to gather registries at link ti...
a683d06fbbecef2d185160b7388f3770cdf71faa
cf3a2b92e859d7eefb89dafcfe71fc634453a2bb
diff --git a/Cargo.lock b/Cargo.lock index 8000cedc758d..5935c16399c9 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3731,15 +3731,6 @@ dependencies = [ "syn 2.0.104", ] -[[package]] -name = "inventory" -version = "0.3.21" -source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "bc61209c082fbeb...
[ "Cargo.lock", "Cargo.toml", "turbopack/crates/turbo-tasks-macros/src/func.rs", "turbopack/crates/turbo-tasks-macros/src/function_macro.rs", "turbopack/crates/turbo-tasks-macros/src/ident.rs", "turbopack/crates/turbo-tasks-macros/src/value_impl_macro.rs", "turbopack/crates/turbo-tasks-macros/src/value_ma...
[ { "comment": "The macro\\-emitted `install_vtable` closure declares a `value_type` parameter that is never used in its body\\, producing a duplicated `unused variable: value_type` warning in every downstream crate that uses `#[turbo_tasks::value_impl]`\\.\n\n<!-- VADE-CATEGORY: code-style -->\n<!-- VADE-GITHUB-...
true
vercel/next.js
94,503
comment_to_fix
migrate turbo-tasks to scattered collect
The macro\-emitted `install_vtable` closure declares a `value_type` parameter that is never used in its body\, producing a duplicated `unused variable: value_type` warning in every downstream crate that uses `#[turbo_tasks::value_impl]`\. <!-- VADE-CATEGORY: code-style --> <!-- VADE-GITHUB-SUGGESTION-ID:40b21b5634a60a...
a683d06fbbecef2d185160b7388f3770cdf71faa
cf3a2b92e859d7eefb89dafcfe71fc634453a2bb
diff --git a/turbopack/crates/turbo-tasks-macros/src/value_impl_macro.rs b/turbopack/crates/turbo-tasks-macros/src/value_impl_macro.rs index 7d2b19d30da7..3958967ea044 100644 --- a/turbopack/crates/turbo-tasks-macros/src/value_impl_macro.rs +++ b/turbopack/crates/turbo-tasks-macros/src/value_impl_macro.rs @@ -17,7 +17,...
[ "turbopack/crates/turbo-tasks-macros/src/value_impl_macro.rs" ]
[ { "comment": "The macro\\-emitted `install_vtable` closure declares a `value_type` parameter that is never used in its body\\, producing a duplicated `unused variable: value_type` warning in every downstream crate that uses `#[turbo_tasks::value_impl]`\\.\n\n<!-- VADE-CATEGORY: code-style -->\n<!-- VADE-GITHUB-...
true
vercel/next.js
94,503
comment_to_fix
migrate turbo-tasks to scattered collect
```suggestion /// [`TRAIT_IMPLS_SLICE`]. ```
a683d06fbbecef2d185160b7388f3770cdf71faa
cf3a2b92e859d7eefb89dafcfe71fc634453a2bb
diff --git a/turbopack/crates/turbo-tasks/src/macro_helpers.rs b/turbopack/crates/turbo-tasks/src/macro_helpers.rs index 1ae06b74fc95..2e6498495370 100644 --- a/turbopack/crates/turbo-tasks/src/macro_helpers.rs +++ b/turbopack/crates/turbo-tasks/src/macro_helpers.rs @@ -7,9 +7,9 @@ use std::{ pub use async_trait::as...
[ "turbopack/crates/turbo-tasks/src/macro_helpers.rs" ]
[ { "comment": "```suggestion\n/// [`TRAIT_IMPLS_SLICE`].\n```", "path": "turbopack/crates/turbo-tasks/src/macro_helpers.rs", "hunk": "@@ -289,34 +243,28 @@ where\n }\n }\n \n-pub struct CollectableTraitMethods {\n+/// One `impl Trait for ConcreteType` registration, gathered at link time into\n+/// [`...
true
vercel/next.js
94,503
comment_to_fix
migrate turbo-tasks to scattered collect
This macro name doesn't make a ton of sense anymore if it's not actually doing the collection.
a683d06fbbecef2d185160b7388f3770cdf71faa
cf3a2b92e859d7eefb89dafcfe71fc634453a2bb
diff --git a/turbopack/crates/turbo-tasks/src/registry/mod.rs b/turbopack/crates/turbo-tasks/src/registry/mod.rs index d810443d8a1f..83d28e3b4a6c 100644 --- a/turbopack/crates/turbo-tasks/src/registry/mod.rs +++ b/turbopack/crates/turbo-tasks/src/registry/mod.rs @@ -1,6 +1,7 @@ use std::{cell::SyncUnsafeCell, num::Non...
[ "turbopack/crates/turbo-tasks/src/registry/mod.rs" ]
[ { "comment": "This macro name doesn't make a ton of sense anymore if it's not actually doing the collection.", "path": "turbopack/crates/turbo-tasks/src/registry/mod.rs", "hunk": "@@ -14,12 +15,13 @@ pub use registry_type::RegistryType;\n \n /// Declare a type as a compile-time-collected registry item.\...
true
vercel/next.js
94,694
issue_to_patch
Persist `'use cache: private'` entries in dev
Private caches were never stored in a cache handler, so every reload in `next dev` re-ran them from scratch and they registered as a cache miss on each load. This change persists `'use cache: private'` entries in development in a dedicated built-in in-memory handler so that warm reloads are fast. The handler is gated o...
cb922affe9a41988040440250c9d4b1e8494b98f
f0b58bd19df825fb3d00d827c2e4c5e810ec619a
diff --git a/packages/next/src/server/app-render/work-unit-async-storage.external.ts b/packages/next/src/server/app-render/work-unit-async-storage.external.ts index 568e3853368f..f9276dfa950a 100644 --- a/packages/next/src/server/app-render/work-unit-async-storage.external.ts +++ b/packages/next/src/server/app-render/w...
[ "packages/next/src/server/app-render/work-unit-async-storage.external.ts", "packages/next/src/server/request/root-params.ts", "packages/next/src/server/use-cache/handlers.ts", "packages/next/src/server/use-cache/use-cache-wrapper.ts", "test/development/app-dir/cache-components-dev-streaming/app/page.tsx", ...
[ { "comment": "The raw `cookie` request header is included in the dev private cache key\\, re\\-introducing cookies that were explicitly excluded via `COOKIES_EXCLUDED_FROM_PRIVATE_CACHE_KEY` and defeating those exclusions\\.\n\n<!-- VADE-CATEGORY: logic -->\n<!-- VADE-GITHUB-SUGGESTION-ID:1ee1d75b1d326a0c78d5c8...
diff --git a/test/development/app-dir/cache-components-dev-streaming/app/page.tsx b/test/development/app-dir/cache-components-dev-streaming/app/page.tsx index eaae221515b2..72ce624d8661 100644 --- a/test/development/app-dir/cache-components-dev-streaming/app/page.tsx +++ b/test/development/app-dir/cache-components-dev-...
true
vercel/next.js
94,694
comment_to_fix
Persist `'use cache: private'` entries in dev
The raw `cookie` request header is included in the dev private cache key\, re\-introducing cookies that were explicitly excluded via `COOKIES_EXCLUDED_FROM_PRIVATE_CACHE_KEY` and defeating those exclusions\. <!-- VADE-CATEGORY: logic --> <!-- VADE-GITHUB-SUGGESTION-ID:1ee1d75b1d326a0c78d5c86d63e07e61dbdaeacf3db57bdd5f...
cb922affe9a41988040440250c9d4b1e8494b98f
f0b58bd19df825fb3d00d827c2e4c5e810ec619a
diff --git a/packages/next/src/server/use-cache/use-cache-wrapper.ts b/packages/next/src/server/use-cache/use-cache-wrapper.ts index 18cea026f661..8b49a6ab39ab 100644 --- a/packages/next/src/server/use-cache/use-cache-wrapper.ts +++ b/packages/next/src/server/use-cache/use-cache-wrapper.ts @@ -65,7 +65,13 @@ import str...
[ "packages/next/src/server/use-cache/use-cache-wrapper.ts" ]
[ { "comment": "The raw `cookie` request header is included in the dev private cache key\\, re\\-introducing cookies that were explicitly excluded via `COOKIES_EXCLUDED_FROM_PRIVATE_CACHE_KEY` and defeating those exclusions\\.\n\n<!-- VADE-CATEGORY: logic -->\n<!-- VADE-GITHUB-SUGGESTION-ID:1ee1d75b1d326a0c78d5c8...
true
vercel/next.js
94,703
issue_to_patch
Strip internal dev request-id headers from userland `headers()`
The client sends the dev-only `x-nextjs-request-id` and `x-nextjs-html-request-id` headers so the server can route debug information back to the originating request. They are internal plumbing, like the flight headers, but unlike the flight headers they were never stripped from the headers exposed to userland `headers(...
000e088059506a61c395f90a482938ee6419dcf7
cb922affe9a41988040440250c9d4b1e8494b98f
diff --git a/packages/next/src/server/async-storage/request-store.ts b/packages/next/src/server/async-storage/request-store.ts index d91d6a82587f..4d904ce30b5f 100644 --- a/packages/next/src/server/async-storage/request-store.ts +++ b/packages/next/src/server/async-storage/request-store.ts @@ -5,7 +5,11 @@ import type ...
[ "packages/next/src/server/async-storage/request-store.ts" ]
[]
true
vercel/next.js
94,498
issue_to_patch
[tubopack] migrate rcstr! to use scattered collect
### What? Adopt `[scattered_collect`](https://docs.rs/scattered-collect/latest/scattered_collect/) for collecting static rcstr values. ### Why? Built by our good friend @mmastrac to solve some of our problems. Replaces inventory with a simpler linker driver approach. Basically inventory works using constructor fun...
8052dc955232b17e38f7857e33f0d3ff59704c16
9cbb1e979dee5c90abb62bf861e1e552fa970852
diff --git a/Cargo.lock b/Cargo.lock index 28c69c9a7146..8000cedc758d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -884,9 +884,9 @@ checksum = "5ce89b21cab1437276d2650d57e971f9d548a2d9037cc231abdc0562b97498ce" [[package]] name = "bytemuck" -version = "1.21.0" +version = "1.25.0" source = "registry+https://github.co...
[ "Cargo.lock", "Cargo.toml", "turbopack/crates/turbo-rcstr-macros/src/lib.rs", "turbopack/crates/turbo-rcstr/Cargo.toml", "turbopack/crates/turbo-rcstr/src/lib.rs" ]
[ { "comment": "`STATIC_RCSTRS` uses `scattered_collect::slice::ScatteredSlice`\\, whose directly\\-stored static link\\-section items are unsupported on WASM\\, breaking the next\\-swc wasm build\\.\n\n<!-- VADE-CATEGORY: api-compatibility -->\n<!-- VADE-GITHUB-SUGGESTION-ID:5b9c812eec9ac29ef3234175de4397088ebfa...
true
vercel/next.js
94,498
comment_to_fix
[tubopack] migrate rcstr! to use scattered collect
`STATIC_RCSTRS` uses `scattered_collect::slice::ScatteredSlice`\, whose directly\-stored static link\-section items are unsupported on WASM\, breaking the next\-swc wasm build\. <!-- VADE-CATEGORY: api-compatibility --> <!-- VADE-GITHUB-SUGGESTION-ID:5b9c812eec9ac29ef3234175de4397088ebfa789e0639682397edceaac21048a -->...
8052dc955232b17e38f7857e33f0d3ff59704c16
9cbb1e979dee5c90abb62bf861e1e552fa970852
diff --git a/turbopack/crates/turbo-rcstr/src/lib.rs b/turbopack/crates/turbo-rcstr/src/lib.rs index 8b044d87107f..bfa31a40cc88 100644 --- a/turbopack/crates/turbo-rcstr/src/lib.rs +++ b/turbopack/crates/turbo-rcstr/src/lib.rs @@ -25,6 +25,8 @@ use bincode::{ use bytes_str::BytesStr; use debug_unreachable::debug_unre...
[ "turbopack/crates/turbo-rcstr/src/lib.rs" ]
[ { "comment": "`STATIC_RCSTRS` uses `scattered_collect::slice::ScatteredSlice`\\, whose directly\\-stored static link\\-section items are unsupported on WASM\\, breaking the next\\-swc wasm build\\.\n\n<!-- VADE-CATEGORY: api-compatibility -->\n<!-- VADE-GITHUB-SUGGESTION-ID:5b9c812eec9ac29ef3234175de4397088ebfa...
true
vercel/next.js
94,498
comment_to_fix
[tubopack] migrate rcstr! to use scattered collect
```suggestion // Disabled under wasm because scattered-collect relies on a environment provided function // described in <https://docs.rs/link-section/latest/link_section/#wasm> and installing it is tricky // using wasm-bindgen. Also this is only here to support deserialization of rcstrs which shouldn't // happen unde...
8052dc955232b17e38f7857e33f0d3ff59704c16
9cbb1e979dee5c90abb62bf861e1e552fa970852
diff --git a/turbopack/crates/turbo-rcstr/src/lib.rs b/turbopack/crates/turbo-rcstr/src/lib.rs index 8b044d87107f..bfa31a40cc88 100644 --- a/turbopack/crates/turbo-rcstr/src/lib.rs +++ b/turbopack/crates/turbo-rcstr/src/lib.rs @@ -25,6 +25,8 @@ use bincode::{ use bytes_str::BytesStr; use debug_unreachable::debug_unre...
[ "turbopack/crates/turbo-rcstr/src/lib.rs" ]
[ { "comment": "```suggestion\n// Disabled under wasm because scattered-collect relies on a environment provided function \n// described in <https://docs.rs/link-section/latest/link_section/#wasm> and installing it is tricky\n// using wasm-bindgen. Also this is only here to support deserialization of rcstrs which...
true
vercel/next.js
94,683
issue_to_patch
Add Owner Stack to "`prefetch={true}` navigation without Partial Prefetching" warning
by capturing an Owner Stack eagerly during render and reusing that when we issue the warning. Either we capture the Owner Stack eagerly or we check the route eagerly during render. We don't capture the Owner Stack eagerly all the time so render performance impact is reduced. Memoizing should be. If the parents chang...
5c27d82bfb4f0374b00823665bfc55db15d28f8c
db998c3bb3380886f0dbd36676f35765281cb943
diff --git a/packages/next/errors.json b/packages/next/errors.json index f55520c522bb..8f8511df230c 100644 --- a/packages/next/errors.json +++ b/packages/next/errors.json @@ -1359,5 +1359,6 @@ "1358": "Route \"%s\": Next.js encountered uncached data during prerendering or a navigation.\\n\\n\\`fetch(...)\\` or \\`co...
[ "packages/next/errors.json", "packages/next/src/client/app-dir/link.tsx", "packages/next/src/client/components/links.ts", "packages/next/src/client/components/segment-cache/navigation.ts", "test/development/app-dir/prefetch-true-partial-warning/app/control-route/page.tsx", "test/development/app-dir/prefet...
[ { "comment": "The `ownerStack` field is set\\/read on union members and passed an argument type that don\\'t declare it\\, producing four TypeScript errors that fail `pnpm --filter=next types` and the CI build\\.\n\n<!-- VADE-CATEGORY: type-safety -->\n<!-- VADE-GITHUB-SUGGESTION-ID:2a647f13e17c92a12c33e6f29cf5...
diff --git a/test/e2e/app-dir/prefetch-true-partial-warning/app/control-route/page.tsx b/test/development/app-dir/prefetch-true-partial-warning/app/control-route/page.tsx similarity index 100% rename from test/e2e/app-dir/prefetch-true-partial-warning/app/control-route/page.tsx rename to test/development/app-dir/prefet...
true
vercel/next.js
94,683
comment_to_fix
Add Owner Stack to "`prefetch={true}` navigation without Partial Prefetching" warning
The `ownerStack` field is set\/read on union members and passed an argument type that don\'t declare it\, producing four TypeScript errors that fail `pnpm --filter=next types` and the CI build\. <!-- VADE-CATEGORY: type-safety --> <!-- VADE-GITHUB-SUGGESTION-ID:2a647f13e17c92a12c33e6f29cf5098d939ff6099267d9dd74d8e950a...
5c27d82bfb4f0374b00823665bfc55db15d28f8c
db998c3bb3380886f0dbd36676f35765281cb943
diff --git a/packages/next/src/client/components/links.ts b/packages/next/src/client/components/links.ts index 5d6ee0b07f43..c6a79de1fba9 100644 --- a/packages/next/src/client/components/links.ts +++ b/packages/next/src/client/components/links.ts @@ -39,11 +39,21 @@ export type FormInstance = LinkOrFormInstanceShared &...
[ "packages/next/src/client/components/links.ts" ]
[ { "comment": "The `ownerStack` field is set\\/read on union members and passed an argument type that don\\'t declare it\\, producing four TypeScript errors that fail `pnpm --filter=next types` and the CI build\\.\n\n<!-- VADE-CATEGORY: type-safety -->\n<!-- VADE-GITHUB-SUGGESTION-ID:2a647f13e17c92a12c33e6f29cf5...
true
vercel/next.js
94,683
comment_to_fix
Add Owner Stack to "`prefetch={true}` navigation without Partial Prefetching" warning
`'' +` is a noop, looks like a leftover from something? ```suggestion ```
5c27d82bfb4f0374b00823665bfc55db15d28f8c
db998c3bb3380886f0dbd36676f35765281cb943
diff --git a/packages/next/src/client/components/segment-cache/navigation.ts b/packages/next/src/client/components/segment-cache/navigation.ts index ac4c3e24b4a1..6f8efe68d999 100644 --- a/packages/next/src/client/components/segment-cache/navigation.ts +++ b/packages/next/src/client/components/segment-cache/navigation....
[ "packages/next/src/client/components/segment-cache/navigation.ts" ]
[ { "comment": "`'' +` is a noop, looks like a leftover from something?\n```suggestion\n```", "path": "packages/next/src/client/components/segment-cache/navigation.ts", "hunk": "@@ -263,13 +263,29 @@ export function navigateToKnownRoute(\n PrefetchHint.SubtreeHasPartialPrefetching) ===\n 0...
true
vercel/next.js
94,649
issue_to_patch
docs: expand the Cache Components migration guide
Continuation of - https://github.com/vercel/next.js/pull/92382 ### What? Adds a `generateStaticParams` section to [Migrating to Cache Components](https://nextjs.org/docs/app/guides/migrating-to-cache-components). ### Why? Developers migrating dynamic routes (for example blogs with `[slug]`) had no guidance ...
a9e076d5af0c415d21ba725ff81ddbbdb6c0f524
00779e7bd2aa059673165b601cf7d0764b2548d8
diff --git a/docs/01-app/02-guides/migrating-to-cache-components.mdx b/docs/01-app/02-guides/migrating-to-cache-components.mdx index dff0f4398034..3b5186384505 100644 --- a/docs/01-app/02-guides/migrating-to-cache-components.mdx +++ b/docs/01-app/02-guides/migrating-to-cache-components.mdx @@ -6,12 +6,47 @@ related: ...
[ "docs/01-app/02-guides/migrating-to-cache-components.mdx" ]
[ { "comment": "instead of \"right now\" maybe \"at that point in time\" or \"immediately\"? sounds a bit non-docsy", "path": "docs/01-app/02-guides/migrating-to-cache-components.mdx", "hunk": "@@ -176,18 +207,593 @@ export default async function Page() {\n }\n ```\n \n+## Opting out of validation\n+\n+A ...
true
vercel/next.js
94,649
comment_to_fix
docs: expand the Cache Components migration guide
might wanna link to streaming guide and promote then()
a9e076d5af0c415d21ba725ff81ddbbdb6c0f524
00779e7bd2aa059673165b601cf7d0764b2548d8
diff --git a/docs/01-app/02-guides/migrating-to-cache-components.mdx b/docs/01-app/02-guides/migrating-to-cache-components.mdx index dff0f4398034..3b5186384505 100644 --- a/docs/01-app/02-guides/migrating-to-cache-components.mdx +++ b/docs/01-app/02-guides/migrating-to-cache-components.mdx @@ -6,12 +6,47 @@ related: ...
[ "docs/01-app/02-guides/migrating-to-cache-components.mdx" ]
[ { "comment": "might wanna link to streaming guide and promote then()", "path": "docs/01-app/02-guides/migrating-to-cache-components.mdx", "hunk": "@@ -176,18 +207,593 @@ export default async function Page() {\n }\n ```\n \n+## Opting out of validation\n+\n+A validation insight or error tells you a route...
true
vercel/next.js
94,649
comment_to_fix
docs: expand the Cache Components migration guide
TODO add usepathname and useselectedlayoutsegment(s), could link directly to the API refs and say to use the same pattern maybe
a9e076d5af0c415d21ba725ff81ddbbdb6c0f524
00779e7bd2aa059673165b601cf7d0764b2548d8
diff --git a/docs/01-app/02-guides/migrating-to-cache-components.mdx b/docs/01-app/02-guides/migrating-to-cache-components.mdx index dff0f4398034..3b5186384505 100644 --- a/docs/01-app/02-guides/migrating-to-cache-components.mdx +++ b/docs/01-app/02-guides/migrating-to-cache-components.mdx @@ -6,12 +6,47 @@ related: ...
[ "docs/01-app/02-guides/migrating-to-cache-components.mdx" ]
[ { "comment": "TODO add usepathname and useselectedlayoutsegment(s), could link directly to the API refs and say to use the same pattern maybe", "path": "docs/01-app/02-guides/migrating-to-cache-components.mdx", "hunk": "@@ -176,18 +207,593 @@ export default async function Page() {\n }\n ```\n \n+## Opti...
true
vercel/next.js
94,655
issue_to_patch
Re-fetch dynamic content on navigation with `partialPrefetching` enabled
With `partialPrefetching` enabled, navigating back to a page that was first loaded as a full HTML document served stale dynamic content. Its `connection()`-gated output kept showing the value from the original document load instead of being re-run per request, and the `<Link prefetch={true}>` navigation issued no serve...
0a518a84e99919438177fc78bbf614e7a3231fa5
6a1f6222e7170db468ef883a6b63f3228994b31f
diff --git a/packages/next/src/build/templates/app-page.ts b/packages/next/src/build/templates/app-page.ts index d123b984c998..60e5c16d3ee5 100644 --- a/packages/next/src/build/templates/app-page.ts +++ b/packages/next/src/build/templates/app-page.ts @@ -882,6 +882,7 @@ export async function handler( } ...
[ "packages/next/src/build/templates/app-page.ts", "test/e2e/app-dir/partial-prefetching-config/app/layout.tsx", "test/e2e/app-dir/partial-prefetching-config/app/target-page/page.tsx", "test/e2e/app-dir/partial-prefetching-config/partial-prefetching-config.test.ts" ]
[]
diff --git a/test/e2e/app-dir/partial-prefetching-config/app/layout.tsx b/test/e2e/app-dir/partial-prefetching-config/app/layout.tsx index 888614deda3b..5bd0a2a6b212 100644 --- a/test/e2e/app-dir/partial-prefetching-config/app/layout.tsx +++ b/test/e2e/app-dir/partial-prefetching-config/app/layout.tsx @@ -1,8 +1,16 @@ ...
true
vercel/next.js
94,662
issue_to_patch
Serve stale `'use cache'` entries in the dev server until they expire
The default in-memory cache handler drops an entry once it goes stale (past its `revalidate` time) rather than serving it: in-memory entries are fragile, so warming a replacement in the background isn't worth it when it's likely to be evicted before it's used, and we don't want to keep reusing a stale entry for too lon...
0d49fafbea5c095d632dee67bf25d729b3fbe3ea
994f465211633f33d999c385e30980d2862130c7
diff --git a/packages/next/src/server/lib/cache-handlers/default.ts b/packages/next/src/server/lib/cache-handlers/default.ts index 1f936e41da1a..5a215994fe33 100644 --- a/packages/next/src/server/lib/cache-handlers/default.ts +++ b/packages/next/src/server/lib/cache-handlers/default.ts @@ -5,6 +5,11 @@ * likely going...
[ "packages/next/src/server/lib/cache-handlers/default.ts", "test/development/app-dir/cache-components-dev-warmup/fixtures/with-prefetch-config/app/short-lived-cache/data-fetching.tsx", "test/development/app-dir/cache-components-dev-warmup/fixtures/with-prefetch-config/app/short-stale-cache/data-fetching.tsx", ...
[]
diff --git a/test/development/app-dir/cache-components-dev-warmup/fixtures/with-prefetch-config/app/short-lived-cache/data-fetching.tsx b/test/development/app-dir/cache-components-dev-warmup/fixtures/with-prefetch-config/app/short-lived-cache/data-fetching.tsx index f7baf4a615f4..51d10bbf77eb 100644 --- a/test/developm...
true
vercel/next.js
94,672
issue_to_patch
Warn on prefetch={true} navigation without Partial Prefetching (dev)
Under Cache Components, a `<Link prefetch={true}>` pointing at a route that hasn't enabled Partial Prefetching quietly falls back to a legacy full prefetch: it pulls down the route's dynamic data instead of just the static shell, defeating the static/dynamic split. In development we now surface this with a console erro...
d80732585bbc028bc1032eadd9b99847083d7dc4
3312f17dc67691966ecb695c2c18efd107dd0997
diff --git a/packages/next/src/client/components/segment-cache/navigation.ts b/packages/next/src/client/components/segment-cache/navigation.ts index 309daf8f18e3..ac4c3e24b4a1 100644 --- a/packages/next/src/client/components/segment-cache/navigation.ts +++ b/packages/next/src/client/components/segment-cache/navigation....
[ "packages/next/src/client/components/segment-cache/navigation.ts", "test/e2e/app-dir/prefetch-true-partial-warning/app/control-route/page.tsx", "test/e2e/app-dir/prefetch-true-partial-warning/app/default-route/page.tsx", "test/e2e/app-dir/prefetch-true-partial-warning/app/layout.tsx", "test/e2e/app-dir/pref...
[]
diff --git a/test/e2e/app-dir/prefetch-true-partial-warning/app/control-route/page.tsx b/test/e2e/app-dir/prefetch-true-partial-warning/app/control-route/page.tsx new file mode 100644 index 000000000000..548e744df20b --- /dev/null +++ b/test/e2e/app-dir/prefetch-true-partial-warning/app/control-route/page.tsx @@ -0,0 +...
true
vercel/next.js
94,625
issue_to_patch
[turbopack] Rename variables in `path_join` and add tests
`results` became `segments` and `results_final` became `locked_prefix`, the `segments` name I'm not too attached to, I'm just trying to communicate that that vector stores the "other" parts of the path that aren't fixed and can change. Meanwhile, the `locked_prefix` has to be at the start - it contains variables we don...
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
560384d46c3cb2ea1dcc2d0bca9c24697a1ca2e6
diff --git a/turbopack/crates/turbopack-ecmascript/src/analyzer/well_known/mod.rs b/turbopack/crates/turbopack-ecmascript/src/analyzer/well_known/mod.rs index 9391f84159e4..6c4f0832c187 100644 --- a/turbopack/crates/turbopack-ecmascript/src/analyzer/well_known/mod.rs +++ b/turbopack/crates/turbopack-ecmascript/src/anal...
[ "turbopack/crates/turbopack-ecmascript/src/analyzer/well_known/mod.rs" ]
[ { "comment": "can you add the cases where we diverge from node here also, either commented out or with a comment saying that node computes something different", "path": "turbopack/crates/turbopack-ecmascript/src/analyzer/well_known/mod.rs", "hunk": "@@ -1096,3 +1099,145 @@ fn protobuf_loader<'a>(arena: ...
true
vercel/next.js
94,668
issue_to_patch
fix: handle shell errors when resuming Node streams
The Node resume adapter returned its stream without observing whether React produced a resumable HTML shell. When an empty prerendered shell resumed into a redirect, React reported an onShellError, but Next.js continued into Flight injection and waited forever for an HTML chunk that would never arrive. Wire the resu...
0d49fafbea5c095d632dee67bf25d729b3fbe3ea
2a0eae484e887a3428f41002a3b11c39058567c2
diff --git a/packages/next/src/server/app-render/stream-ops.node.ts b/packages/next/src/server/app-render/stream-ops.node.ts index 575e988bac0e..0698da90df04 100644 --- a/packages/next/src/server/app-render/stream-ops.node.ts +++ b/packages/next/src/server/app-render/stream-ops.node.ts @@ -612,18 +612,29 @@ export asyn...
[ "packages/next/src/server/app-render/stream-ops.node.ts", "test/production/app-dir/empty-shell-redirect-resume/app/layout.tsx", "test/production/app-dir/empty-shell-redirect-resume/app/login/page.tsx", "test/production/app-dir/empty-shell-redirect-resume/app/search/page.tsx", "test/production/app-dir/empty-...
[]
diff --git a/test/production/app-dir/empty-shell-redirect-resume/app/layout.tsx b/test/production/app-dir/empty-shell-redirect-resume/app/layout.tsx new file mode 100644 index 000000000000..ff646b85da93 --- /dev/null +++ b/test/production/app-dir/empty-shell-redirect-resume/app/layout.tsx @@ -0,0 +1,19 @@ +import { Rea...
true
vercel/next.js
94,581
issue_to_patch
Call `register_assignment_scope()` in `visit_export_default_expr()` and `visit_export_default_decl()`
Talked IRL, we found that calling this in `visit_export_default_expr()` cut down the `module-cost` benchmark on ESM execution by about 10ms (approx. 35%). Doing this unlocks a codegen optimization to avoid arrow functions, this special case was needed to support `export default ...` which is a kind of declaration all ...
7b6f95367aa3991da0fa9451503a2eb76d1bd90c
c643c05b59d98d9e4c466c91aa603bea763aec74
diff --git a/turbopack/crates/turbopack-ecmascript/src/analyzer/imports.rs b/turbopack/crates/turbopack-ecmascript/src/analyzer/imports.rs index c1c22519eda1..737422d95cf7 100644 --- a/turbopack/crates/turbopack-ecmascript/src/analyzer/imports.rs +++ b/turbopack/crates/turbopack-ecmascript/src/analyzer/imports.rs @@ -1...
[ "turbopack/crates/turbopack-ecmascript/src/analyzer/imports.rs", "turbopack/crates/turbopack-tests/tests/snapshot/basic/export-default/input/index.js", "turbopack/crates/turbopack-tests/tests/snapshot/basic/export-default/input/node_modules/lib/index.js", "turbopack/crates/turbopack-tests/tests/snapshot/basic...
[ { "comment": "The committed input `node_modules/lib/index.js` is missing a 3\\-line comment that the committed snapshot output and source map were generated from\\, so the snapshot test will fail in CI\\.\n\n<!-- VADE-CATEGORY: unfinished-work -->\n<!-- VADE-GITHUB-SUGGESTION-ID:709273664cbcd160bf22506bfd44c2f5...
diff --git a/turbopack/crates/turbopack-tests/tests/snapshot/basic/export-default/input/index.js b/turbopack/crates/turbopack-tests/tests/snapshot/basic/export-default/input/index.js new file mode 100644 index 000000000000..37f40192a0ac --- /dev/null +++ b/turbopack/crates/turbopack-tests/tests/snapshot/basic/export-de...
true
vercel/next.js
94,581
comment_to_fix
Call `register_assignment_scope()` in `visit_export_default_expr()` and `visit_export_default_decl()`
The committed input `node_modules/lib/index.js` is missing a 3\-line comment that the committed snapshot output and source map were generated from\, so the snapshot test will fail in CI\. <!-- VADE-CATEGORY: unfinished-work --> <!-- VADE-GITHUB-SUGGESTION-ID:709273664cbcd160bf22506bfd44c2f590a9ae63c55dcaee07e8b8df5628...
7b6f95367aa3991da0fa9451503a2eb76d1bd90c
c643c05b59d98d9e4c466c91aa603bea763aec74
diff --git a/turbopack/crates/turbopack-tests/tests/snapshot/basic/export-default/input/node_modules/lib/index.js b/turbopack/crates/turbopack-tests/tests/snapshot/basic/export-default/input/node_modules/lib/index.js new file mode 100644 index 000000000000..43a7329637da --- /dev/null +++ b/turbopack/crates/turbopack-te...
[ "turbopack/crates/turbopack-tests/tests/snapshot/basic/export-default/input/node_modules/lib/index.js" ]
[ { "comment": "The committed input `node_modules/lib/index.js` is missing a 3\\-line comment that the committed snapshot output and source map were generated from\\, so the snapshot test will fail in CI\\.\n\n<!-- VADE-CATEGORY: unfinished-work -->\n<!-- VADE-GITHUB-SUGGESTION-ID:709273664cbcd160bf22506bfd44c2f5...
true
vercel/next.js
94,579
issue_to_patch
[ci] Download fnm directly from GitHub releases and validate checksum
I determined that [`nvm` wasn't sufficient for our use-case since we need to support windows](https://github.com/vercel/next.js/pull/94175#issuecomment-4654622674), so this doubles down on `fnm`. This reduces risks of supply chain attacks with `fnm`. This also cleans up some old stuff that was left over from self...
409fa64d162ebc6ba46ac3c7a4ce5802488718ca
ad84b8e5ce4b45c37a3c0ecebe445c68946ba00f
diff --git a/.github/workflows/build_reusable.yml b/.github/workflows/build_reusable.yml index 822b70d8e92b..c48a8557f41f 100644 --- a/.github/workflows/build_reusable.yml +++ b/.github/workflows/build_reusable.yml @@ -172,73 +172,65 @@ jobs: git config --global core.eol lf shell: bash - - na...
[ ".github/workflows/build_reusable.yml" ]
[ { "comment": "The fnm\\-pinned Node\\.js bin directory is never correctly added to `GITHUB_PATH` \\(wrong directory \\+ stale multishell path\\)\\, so later steps run with system Node \\(ignoring the version pin\\) or fail when no system Node exists\\.\n\n<!-- VADE-CATEGORY: configuration -->\n<!-- VADE-GITHUB-...
true
vercel/next.js
94,579
comment_to_fix
[ci] Download fnm directly from GitHub releases and validate checksum
The fnm\-pinned Node\.js bin directory is never correctly added to `GITHUB_PATH` \(wrong directory \+ stale multishell path\)\, so later steps run with system Node \(ignoring the version pin\) or fail when no system Node exists\. <!-- VADE-CATEGORY: configuration --> <!-- VADE-GITHUB-SUGGESTION-ID:954f193a881d28899ca5...
409fa64d162ebc6ba46ac3c7a4ce5802488718ca
ad84b8e5ce4b45c37a3c0ecebe445c68946ba00f
diff --git a/.github/workflows/build_reusable.yml b/.github/workflows/build_reusable.yml index 822b70d8e92b..c48a8557f41f 100644 --- a/.github/workflows/build_reusable.yml +++ b/.github/workflows/build_reusable.yml @@ -172,73 +172,65 @@ jobs: git config --global core.eol lf shell: bash - - na...
[ ".github/workflows/build_reusable.yml" ]
[ { "comment": "The fnm\\-pinned Node\\.js bin directory is never correctly added to `GITHUB_PATH` \\(wrong directory \\+ stale multishell path\\)\\, so later steps run with system Node \\(ignoring the version pin\\) or fail when no system Node exists\\.\n\n<!-- VADE-CATEGORY: configuration -->\n<!-- VADE-GITHUB-...
true
vercel/next.js
94,579
comment_to_fix
[ci] Download fnm directly from GitHub releases and validate checksum
What are the instructions to get this checksum?
409fa64d162ebc6ba46ac3c7a4ce5802488718ca
ad84b8e5ce4b45c37a3c0ecebe445c68946ba00f
diff --git a/.github/workflows/build_reusable.yml b/.github/workflows/build_reusable.yml index 822b70d8e92b..c48a8557f41f 100644 --- a/.github/workflows/build_reusable.yml +++ b/.github/workflows/build_reusable.yml @@ -172,73 +172,65 @@ jobs: git config --global core.eol lf shell: bash - - na...
[ ".github/workflows/build_reusable.yml" ]
[ { "comment": "What are the instructions to get this checksum?", "path": ".github/workflows/build_reusable.yml", "hunk": "@@ -172,73 +172,63 @@ jobs:\n git config --global core.eol lf\n shell: bash\n \n- - name: Check if fnm is installed\n- id: check-fnm\n- run: |\n- ...
true
vercel/next.js
94,319
issue_to_patch
[ci] Reduce usage of turborepo cache in `build_and_deploy.yml`
We're consolidating on `actions/cache` now that we got rid of self-hosted runners. This doesn't remove all of the uses of turborepo's cache (notably sccache), but this does eliminate the remote turborepo cache for the native build cache and the docker image. These build steps use docker so that we're building agains...
84f9247617f91917bfeecd9c6d95b1dedef4a411
fc2d49dbad84faf511765f1fb320a5b9d229e439
diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index 4f8394a33b68..80f73fdffc8c 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -270,55 +270,120 @@ jobs: - name: normalize versions run: node scripts/normali...
[ ".github/workflows/build_and_deploy.yml", "scripts/docker-image-cache.js", "scripts/docker-native-build.js", "scripts/native-cache.js", "scripts/rust-fingerprint.js", "scripts/turbo-cache.mjs" ]
[ { "comment": "Do we even use this step nowadays? `NEXT_SKIP_BUILD_CACHE` is true for production, staging, and force-preview. So we only enable the build cache for the automated preview. However, the automated preview only builds Linux which runs in Docker. Seems like this always evaluates to false.", "path"...
true
vercel/next.js
94,319
comment_to_fix
[ci] Reduce usage of turborepo cache in `build_and_deploy.yml`
Do we even use this step nowadays? `NEXT_SKIP_BUILD_CACHE` is true for production, staging, and force-preview. So we only enable the build cache for the automated preview. However, the automated preview only builds Linux which runs in Docker. Seems like this always evaluates to false.
84f9247617f91917bfeecd9c6d95b1dedef4a411
fc2d49dbad84faf511765f1fb320a5b9d229e439
diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index 4f8394a33b68..80f73fdffc8c 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -270,55 +270,120 @@ jobs: - name: normalize versions run: node scripts/normali...
[ ".github/workflows/build_and_deploy.yml" ]
[ { "comment": "Do we even use this step nowadays? `NEXT_SKIP_BUILD_CACHE` is true for production, staging, and force-preview. So we only enable the build cache for the automated preview. However, the automated preview only builds Linux which runs in Docker. Seems like this always evaluates to false.", "path"...
true
vercel/next.js
94,319
comment_to_fix
[ci] Reduce usage of turborepo cache in `build_and_deploy.yml`
Rust fingerprint step emits an empty cache\-key hash when the fingerprint file is missing\/empty\, fail\-open poisoning the native binary cache <!-- VADE-CATEGORY: logic --> <!-- VADE-GITHUB-SUGGESTION-ID:ae3f6e4428ade67eeefcf6da9725263fb9b1d9d5f608e80c9373f2767d7c0d57 --> <!-- VADE-RECOMMENDATION: FIX --> <a href="h...
84f9247617f91917bfeecd9c6d95b1dedef4a411
fc2d49dbad84faf511765f1fb320a5b9d229e439
diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index 4f8394a33b68..80f73fdffc8c 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -270,55 +270,120 @@ jobs: - name: normalize versions run: node scripts/normali...
[ ".github/workflows/build_and_deploy.yml" ]
[ { "comment": "Rust fingerprint step emits an empty cache\\-key hash when the fingerprint file is missing\\/empty\\, fail\\-open poisoning the native binary cache\n\n<!-- VADE-CATEGORY: logic -->\n<!-- VADE-GITHUB-SUGGESTION-ID:ae3f6e4428ade67eeefcf6da9725263fb9b1d9d5f608e80c9373f2767d7c0d57 -->\n\n<!-- VADE-REC...
true
vercel/next.js
94,319
comment_to_fix
[ci] Reduce usage of turborepo cache in `build_and_deploy.yml`
Why can't this be listed in `env`? This seems pretty sketchy to dynamically expose variables. We don't know what future variables this may cover.
84f9247617f91917bfeecd9c6d95b1dedef4a411
fc2d49dbad84faf511765f1fb320a5b9d229e439
diff --git a/.github/workflows/build_and_deploy.yml b/.github/workflows/build_and_deploy.yml index 4f8394a33b68..80f73fdffc8c 100644 --- a/.github/workflows/build_and_deploy.yml +++ b/.github/workflows/build_and_deploy.yml @@ -270,55 +270,120 @@ jobs: - name: normalize versions run: node scripts/normali...
[ ".github/workflows/build_and_deploy.yml" ]
[ { "comment": "Why can't this be listed in `env`? This seems pretty sketchy to dynamically expose variables. We don't know what future variables this may cover.", "path": ".github/workflows/build_and_deploy.yml", "hunk": "@@ -270,55 +270,121 @@ jobs:\n - name: normalize versions\n run: node...
true
vercel/next.js
94,629
issue_to_patch
docs: next/root-params references on i18n guide
x-ref to next/root-params from the i18n guide
0553b34542432a402012737504e09bf1af3c8b60
7d5433c73fbb214c14c43632bae097e9344ba60b
diff --git a/docs/01-app/02-guides/internationalization.mdx b/docs/01-app/02-guides/internationalization.mdx index b7d5bbb56807..36f348a7f978 100644 --- a/docs/01-app/02-guides/internationalization.mdx +++ b/docs/01-app/02-guides/internationalization.mdx @@ -1,6 +1,10 @@ --- title: Internationalization description: ...
[ "docs/01-app/02-guides/internationalization.mdx" ]
[]
true
vercel/next.js
94,645
issue_to_patch
Stage short-lived `'use cache'` entries correctly in dev
When the streaming dev render defers a short-lived `'use cache'` entry to a later stage (a `revalidate` of zero or a short `expire` excludes it from the static shell, a short `stale` time excludes it from the runtime prefetch shell), it previously left the cache signal read open. At a staged rendering task boundary tha...
0a518a84e99919438177fc78bbf614e7a3231fa5
7451d830e60d8a31e59171a88eb6a3b59c1f0b62
diff --git a/packages/next/src/server/app-render/app-render.tsx b/packages/next/src/server/app-render/app-render.tsx index 23c098ae920e..cf6dfc5fec06 100644 --- a/packages/next/src/server/app-render/app-render.tsx +++ b/packages/next/src/server/app-render/app-render.tsx @@ -4339,6 +4339,7 @@ function runDevValidationIn...
[ "packages/next/src/server/app-render/app-render.tsx", "packages/next/src/server/app-render/work-unit-async-storage.external.ts", "packages/next/src/server/use-cache/use-cache-wrapper.ts", "test/development/app-dir/cache-components-dev-warmup/cache-components.dev-warmup.test.ts", "test/development/app-dir/ca...
[ { "comment": "A short\\-lived `'use cache'` handler entry that is also past its `expire` time triggers a double `cacheSignal.endRead()` in dev\\, throwing a `CacheSignal` `InvariantError` and crashing the render\\.\n\n<!-- VADE-CATEGORY: logic -->\n<!-- VADE-GITHUB-SUGGESTION-ID:2fcfb708223baf306cc41393a74db4ae...
diff --git a/test/development/app-dir/cache-components-dev-warmup/cache-components.dev-warmup.test.ts b/test/development/app-dir/cache-components-dev-warmup/cache-components.dev-warmup.test.ts index be0aee13b30e..33accd55d408 100644 --- a/test/development/app-dir/cache-components-dev-warmup/cache-components.dev-warmup....
true
vercel/next.js
94,645
comment_to_fix
Stage short-lived `'use cache'` entries correctly in dev
A short\-lived `'use cache'` handler entry that is also past its `expire` time triggers a double `cacheSignal.endRead()` in dev\, throwing a `CacheSignal` `InvariantError` and crashing the render\. <!-- VADE-CATEGORY: logic --> <!-- VADE-GITHUB-SUGGESTION-ID:2fcfb708223baf306cc41393a74db4ae1a2d128ea5b60a1f768203dbd857...
0a518a84e99919438177fc78bbf614e7a3231fa5
7451d830e60d8a31e59171a88eb6a3b59c1f0b62
diff --git a/packages/next/src/server/use-cache/use-cache-wrapper.ts b/packages/next/src/server/use-cache/use-cache-wrapper.ts index b29e64c42e30..18cea026f661 100644 --- a/packages/next/src/server/use-cache/use-cache-wrapper.ts +++ b/packages/next/src/server/use-cache/use-cache-wrapper.ts @@ -2023,6 +2023,12 @@ export...
[ "packages/next/src/server/use-cache/use-cache-wrapper.ts" ]
[ { "comment": "A short\\-lived `'use cache'` handler entry that is also past its `expire` time triggers a double `cacheSignal.endRead()` in dev\\, throwing a `CacheSignal` `InvariantError` and crashing the render\\.\n\n<!-- VADE-CATEGORY: logic -->\n<!-- VADE-GITHUB-SUGGESTION-ID:2fcfb708223baf306cc41393a74db4ae...
true
vercel/next.js
94,641
issue_to_patch
[15.5.x][ci]: fix release script to not strip newlines
Backports https://github.com/vercel/next.js/pull/93302
b04e93814f6d810cdda9ddb998282053c28965e3
2b9f40fd01c295009e5c502a726dbe29d4ac1df8
diff --git a/lerna.json b/lerna.json index 88608bcf74fe..018322eeb519 100644 --- a/lerna.json +++ b/lerna.json @@ -18,4 +18,4 @@ } }, "version": "15.5.19" -} \ No newline at end of file +} diff --git a/scripts/release-github-api.js b/scripts/release-github-api.js index 3d650a9032db..db4d85e8a2fb 100644 --- a...
[ "lerna.json", "scripts/release-github-api.js" ]
[]
true
vercel/next.js
94,640
issue_to_patch
[16.2.x][ci]: fix release script to not strip newlines
Backports https://github.com/vercel/next.js/pull/93302
f37fad940522e000af5498209fd237d863b4fa16
e787012cb30932cbe7806632298aaec6af12e6ef
diff --git a/lerna.json b/lerna.json index 5063d77506ee..2aaa31e664b5 100644 --- a/lerna.json +++ b/lerna.json @@ -17,4 +17,4 @@ } }, "version": "16.2.9" -} \ No newline at end of file +} diff --git a/packages/create-next-app/package.json b/packages/create-next-app/package.json index 7d0573406571..1d295bb5d0...
[ "lerna.json", "packages/create-next-app/package.json", "packages/eslint-config-next/package.json", "packages/eslint-plugin-internal/package.json", "packages/eslint-plugin-next/package.json", "packages/font/package.json", "packages/next-bundle-analyzer/package.json", "packages/next-codemod/package.json...
[]
true
vercel/next.js
94,637
issue_to_patch
instant: build fix-card Copy AI prompt dynamically from title + link
### What The dev-overlay fix cards' `Copy AI prompt` button used to copy a multi-paragraph instruction string baked into each card (71 prompts across docs + runtime). This PR replaces that with a dynamic template the button builds at click time: ``` Apply the [Stream] "Wrap in or move into Suspense" fix to the Next.j...
2725a6b7f3f83b3bd7f568fc5be1dd7f1e8feaad
a0a56bbe95fc4f63dbf0a965a8929710c656646a
diff --git a/.agents/skills/insight-error-page/SKILL.md b/.agents/skills/insight-error-page/SKILL.md index 26be374a732b..a7aeb909c777 100644 --- a/.agents/skills/insight-error-page/SKILL.md +++ b/.agents/skills/insight-error-page/SKILL.md @@ -95,8 +95,8 @@ kind: insight - `title` = card title from framework, **verbati...
[ ".agents/skills/insight-error-page/SKILL.md", "errors/blocking-prerender-client-hook.mdx", "errors/blocking-prerender-crypto-client.mdx", "errors/blocking-prerender-crypto.mdx", "errors/blocking-prerender-current-time-client.mdx", "errors/blocking-prerender-current-time.mdx", "errors/blocking-prerender-...
[]
true
vercel/next.js
94,611
issue_to_patch
Add a cold cache dev indicator
When Cache Components is enabled, a `next dev` load that streams while filling an empty cache is not representative of production: cached content streams in as it is computed rather than being served instantly, and React's DevTools cannot accurately show what would normally suspend. This surfaces that state in the dev ...
9af81ed9a1a9772c68c4f8bf2d81f83d17ac6a49
562790aa87d284ddf8a02b8f6e6a55a04d452c4e
diff --git a/packages/next/src/next-devtools/dev-overlay/cache-indicator.tsx b/packages/next/src/next-devtools/dev-overlay/cache-indicator.tsx index e1b0d9bfd6b7..9e6d049f14f0 100644 --- a/packages/next/src/next-devtools/dev-overlay/cache-indicator.tsx +++ b/packages/next/src/next-devtools/dev-overlay/cache-indicator.t...
[ "packages/next/src/next-devtools/dev-overlay/cache-indicator.tsx", "packages/next/src/next-devtools/dev-overlay/components/devtools-indicator/next-logo.stories.tsx", "packages/next/src/next-devtools/dev-overlay/components/devtools-indicator/next-logo.tsx", "packages/next/src/next-devtools/dev-overlay/componen...
[]
diff --git a/test/development/app-dir/cache-indicator/app/layout.tsx b/test/development/app-dir/cache-indicator/app/layout.tsx index 9d7705fc033c..5c2bdf38d06b 100644 --- a/test/development/app-dir/cache-indicator/app/layout.tsx +++ b/test/development/app-dir/cache-indicator/app/layout.tsx @@ -6,7 +6,9 @@ export defaul...
true
vercel/next.js
94,616
issue_to_patch
[turbopack] Enable turbopackFileSystemCacheForBuild by default in non-stable releases
This is enabled by default in canary releases if we detect certain environment variables In the future as part of stabilization this should be handled in the build-adaptors as a more generic solution
6b3936a3329486cc3c126d8cb7701f95517adbc0
5527b0bd9eec8ce94ba7c3100f4ddc3340685fc9
diff --git a/packages/next/src/server/config-shared.ts b/packages/next/src/server/config-shared.ts index 26ec96887ddd..bee323d018bd 100644 --- a/packages/next/src/server/config-shared.ts +++ b/packages/next/src/server/config-shared.ts @@ -15,6 +15,8 @@ import type { ExperimentalPPRConfig } from './lib/experimental/ppr'...
[ "packages/next/src/server/config-shared.ts", "test/production/deterministic-build/deployment-id.test.ts" ]
[]
diff --git a/test/production/deterministic-build/deployment-id.test.ts b/test/production/deterministic-build/deployment-id.test.ts index be5419bf5697..2931806bbdc1 100644 --- a/test/production/deterministic-build/deployment-id.test.ts +++ b/test/production/deterministic-build/deployment-id.test.ts @@ -36,6 +36,7 @@ asy...
true
vercel/next.js
94,623
issue_to_patch
Reapply "Stabilize catchError and retry by removing unstable_ prefix"
### What? Reverts #94617, which had reverted #94610. This re-lands the stabilization of the `catchError` API and the `retry` error prop by removing their `unstable_` prefix across source, docs, and tests. ### Why? #94610 was reverted in #94617 to unblock another change. This re-applies it now that it is no longer bl...
d424aa8ec4c7bfdf4175df47e26f17d7a60a49d3
b8436aed333b937381039b0eccd55eaa5b167a3b
diff --git a/crates/next-custom-transforms/src/transforms/react_server_components.rs b/crates/next-custom-transforms/src/transforms/react_server_components.rs index 1aecded9e81d..3ad4394e0822 100644 --- a/crates/next-custom-transforms/src/transforms/react_server_components.rs +++ b/crates/next-custom-transforms/src/tra...
[ "crates/next-custom-transforms/src/transforms/react_server_components.rs", "docs/01-app/01-getting-started/10-error-handling.mdx", "docs/01-app/03-api-reference/03-file-conventions/error.mdx", "docs/01-app/03-api-reference/04-functions/catchError.mdx", "packages/next/error.d.ts", "packages/next/error.js",...
[]
diff --git a/test/development/acceptance-app/rsc-build-errors.test.ts b/test/development/acceptance-app/rsc-build-errors.test.ts index 5a7545837dd7..812120edc7a2 100644 --- a/test/development/acceptance-app/rsc-build-errors.test.ts +++ b/test/development/acceptance-app/rsc-build-errors.test.ts @@ -256,14 +256,14 @@ des...
true
vercel/next.js
94,627
issue_to_patch
[cd] Allow tagging semver-lower releases as `@latest` if `@latest` points at a prerelease
`@latest` pointing at a prerelease is always a mistake so subsequent stable release should automatically get `@latest`. `publish-native` already overwrites (which will be fixed in https://github.com/vercel/next.js/pull/94319) ## test plan ``` $ git commit --allow-empty -m 'v16.2.9' $ node scripts/publish-rel...
6f1680448c81904efcd36704edf01a6b7323abbf
967822989554b66b4450f843bfa93aac81b1f04f
diff --git a/scripts/publish-release.js b/scripts/publish-release.js index c33f6e0cc071..b46b83d3e695 100755 --- a/scripts/publish-release.js +++ b/scripts/publish-release.js @@ -65,7 +65,10 @@ const cwd = process.cwd() // during publishing, when users install `next@latest`, they might // get the back...
[ "scripts/publish-release.js" ]
[]
true
vercel/next.js
93,204
issue_to_patch
doc: instant navs runtime story
- changes getting started -> caching - new guide for instant navs - new guide for runtime-prefetching (most pending stuff is here) - x-refs between docs - App Shell mentions in other docs (ISR w/ CC)
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/01-getting-started/08-caching.mdx b/docs/01-app/01-getting-started/08-caching.mdx index c1934e8adc59..d99771888baa 100644 --- a/docs/01-app/01-getting-started/08-caching.mdx +++ b/docs/01-app/01-getting-started/08-caching.mdx @@ -8,7 +8,7 @@ related: - app/getting-started/revalidating ...
[ "docs/01-app/01-getting-started/08-caching.mdx", "docs/01-app/02-guides/adopting-partial-prefetching.mdx", "docs/01-app/02-guides/incremental-static-regeneration-cache-components.mdx", "docs/01-app/02-guides/instant-navigation.mdx", "docs/01-app/02-guides/prefetching.mdx", "docs/01-app/02-guides/public-st...
[ { "comment": "Wondering if we should mention next-browser (which is now a part og agent-browser) to do this proccess with agents", "path": "docs/01-app/02-guides/instant-navigation.mdx", "hunk": "@@ -303,18 +331,123 @@ Each case is validated independently. A `<Suspense>` boundary that covers one na\n \n...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
Wondering if we should mention next-browser (which is now a part og agent-browser) to do this proccess with agents
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/02-guides/instant-navigation.mdx b/docs/01-app/02-guides/instant-navigation.mdx index 21bc94b2df7f..6d866e2c4245 100644 --- a/docs/01-app/02-guides/instant-navigation.mdx +++ b/docs/01-app/02-guides/instant-navigation.mdx @@ -2,40 +2,130 @@ title: Ensuring instant navigations description: Lea...
[ "docs/01-app/02-guides/instant-navigation.mdx" ]
[ { "comment": "Wondering if we should mention next-browser (which is now a part og agent-browser) to do this proccess with agents", "path": "docs/01-app/02-guides/instant-navigation.mdx", "hunk": "@@ -303,18 +331,123 @@ Each case is validated independently. A `<Suspense>` boundary that covers one na\n \n...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
The above snippet states "`"use cache: private"`" but theres no :private here I think it's equivalent here, but the flow is unclear Ah, i see below theres a mention of use cache private.
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/02-guides/instant-navigation.mdx b/docs/01-app/02-guides/instant-navigation.mdx index 21bc94b2df7f..6d866e2c4245 100644 --- a/docs/01-app/02-guides/instant-navigation.mdx +++ b/docs/01-app/02-guides/instant-navigation.mdx @@ -2,40 +2,130 @@ title: Ensuring instant navigations description: Lea...
[ "docs/01-app/02-guides/instant-navigation.mdx" ]
[ { "comment": "The above snippet states \"`\"use cache: private\"`\"\n\nbut theres no :private here\n\nI think it's equivalent here, but the flow is unclear\n\nAh, i see below theres a mention of use cache private. ", "path": "docs/01-app/02-guides/instant-navigation.mdx", "hunk": "@@ -303,18 +331,123 @@...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
Ah, disregard my comment about this above. But yeah this is merged into agent-browser afaik!
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/02-guides/instant-navigation.mdx b/docs/01-app/02-guides/instant-navigation.mdx index 21bc94b2df7f..6d866e2c4245 100644 --- a/docs/01-app/02-guides/instant-navigation.mdx +++ b/docs/01-app/02-guides/instant-navigation.mdx @@ -2,40 +2,130 @@ title: Ensuring instant navigations description: Lea...
[ "docs/01-app/02-guides/instant-navigation.mdx" ]
[ { "comment": "Ah, disregard my comment about this above. But yeah this is merged into agent-browser afaik!", "path": "docs/01-app/02-guides/instant-navigation.mdx", "hunk": "@@ -303,18 +331,123 @@ Each case is validated independently. A `<Suspense>` boundary that covers one na\n \n </details>\n \n+## It...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
Did you make the draft PR for this yet?
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/03-api-reference/03-file-conventions/02-route-segment-config/instant.mdx b/docs/01-app/03-api-reference/03-file-conventions/02-route-segment-config/instant.mdx index 4d2f56642af0..d7756adaa646 100644 --- a/docs/01-app/03-api-reference/03-file-conventions/02-route-segment-config/instant.mdx +++ ...
[ "docs/01-app/03-api-reference/03-file-conventions/02-route-segment-config/instant.mdx" ]
[ { "comment": "Did you make the draft PR for this yet?", "path": "docs/01-app/03-api-reference/03-file-conventions/02-route-segment-config/instant.mdx", "hunk": "@@ -20,38 +20,130 @@ The `unstable_instant` route segment config opts a route into validation for ins\n > - `unstable_instant` cannot be used i...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
"users data" seems to narrow when its also unknown params or searchparams
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/02-guides/runtime-prefetching.mdx b/docs/01-app/02-guides/runtime-prefetching.mdx new file mode 100644 index 000000000000..ff0cb563c2fd --- /dev/null +++ b/docs/01-app/02-guides/runtime-prefetching.mdx @@ -0,0 +1,208 @@ +--- +title: Runtime prefetching +description: Extend the static shell with...
[ "docs/01-app/02-guides/runtime-prefetching.mdx" ]
[ { "comment": "\"users data\" seems to narrow when its also unknown params or searchparams", "path": "docs/01-app/02-guides/runtime-prefetching.mdx", "hunk": "@@ -0,0 +1,124 @@\n+---\n+title: Runtime prefetching\n+description: Extend the static shell with personalized content using unstable_prefetch and ...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
We wont need this config with the release. only the prefetch route segment export.
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/02-guides/runtime-prefetching.mdx b/docs/01-app/02-guides/runtime-prefetching.mdx new file mode 100644 index 000000000000..ff0cb563c2fd --- /dev/null +++ b/docs/01-app/02-guides/runtime-prefetching.mdx @@ -0,0 +1,208 @@ +--- +title: Runtime prefetching +description: Extend the static shell with...
[ "docs/01-app/02-guides/runtime-prefetching.mdx" ]
[ { "comment": "We wont need this config with the release. only the prefetch route segment export.", "path": "docs/01-app/02-guides/runtime-prefetching.mdx", "hunk": "@@ -0,0 +1,124 @@\n+---\n+title: Runtime prefetching\n+description: Extend the static shell with personalized content using unstable_prefet...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
Would be more clear if we present the "fixed" Cache component validated state first, then add the prefetch
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/02-guides/runtime-prefetching.mdx b/docs/01-app/02-guides/runtime-prefetching.mdx new file mode 100644 index 000000000000..ff0cb563c2fd --- /dev/null +++ b/docs/01-app/02-guides/runtime-prefetching.mdx @@ -0,0 +1,208 @@ +--- +title: Runtime prefetching +description: Extend the static shell with...
[ "docs/01-app/02-guides/runtime-prefetching.mdx" ]
[ { "comment": "Would be more clear if we present the \"fixed\" Cache component validated state first, then add the prefetch", "path": "docs/01-app/02-guides/runtime-prefetching.mdx", "hunk": "@@ -0,0 +1,124 @@\n+---\n+title: Runtime prefetching\n+description: Extend the static shell with personalized con...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
Youre probably aware already, but this is outdated. Instant will be default warning on in 16.3. This part probably need to be rewritten
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/02-guides/runtime-prefetching.mdx b/docs/01-app/02-guides/runtime-prefetching.mdx new file mode 100644 index 000000000000..ff0cb563c2fd --- /dev/null +++ b/docs/01-app/02-guides/runtime-prefetching.mdx @@ -0,0 +1,208 @@ +--- +title: Runtime prefetching +description: Extend the static shell with...
[ "docs/01-app/02-guides/runtime-prefetching.mdx" ]
[ { "comment": "Youre probably aware already, but this is outdated. Instant will be default warning on in 16.3. This part probably need to be rewritten", "path": "docs/01-app/02-guides/runtime-prefetching.mdx", "hunk": "@@ -0,0 +1,124 @@\n+---\n+title: Runtime prefetching\n+description: Extend the static ...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
This wont be a problem
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/02-guides/runtime-prefetching.mdx b/docs/01-app/02-guides/runtime-prefetching.mdx new file mode 100644 index 000000000000..ff0cb563c2fd --- /dev/null +++ b/docs/01-app/02-guides/runtime-prefetching.mdx @@ -0,0 +1,208 @@ +--- +title: Runtime prefetching +description: Extend the static shell with...
[ "docs/01-app/02-guides/runtime-prefetching.mdx" ]
[ { "comment": "This wont be a problem", "path": "docs/01-app/02-guides/runtime-prefetching.mdx", "hunk": "@@ -0,0 +1,124 @@\n+---\n+title: Runtime prefetching\n+description: Extend the static shell with personalized content using unstable_prefetch and per-session caching directives.\n+nav_title: Runtime ...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
Theres no mention of unknown params or searchparams in this guide! Should be there as its the most common blocker for caching reusable data
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/02-guides/runtime-prefetching.mdx b/docs/01-app/02-guides/runtime-prefetching.mdx new file mode 100644 index 000000000000..ff0cb563c2fd --- /dev/null +++ b/docs/01-app/02-guides/runtime-prefetching.mdx @@ -0,0 +1,208 @@ +--- +title: Runtime prefetching +description: Extend the static shell with...
[ "docs/01-app/02-guides/runtime-prefetching.mdx" ]
[ { "comment": "Theres no mention of unknown params or searchparams in this guide! Should be there as its the most common blocker for caching reusable data ", "path": "docs/01-app/02-guides/runtime-prefetching.mdx", "hunk": "@@ -0,0 +1,124 @@\n+---\n+title: Runtime prefetching\n+description: Extend the st...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
TODO update! See comments below.
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/01-getting-started/08-caching.mdx b/docs/01-app/01-getting-started/08-caching.mdx index c1934e8adc59..d99771888baa 100644 --- a/docs/01-app/01-getting-started/08-caching.mdx +++ b/docs/01-app/01-getting-started/08-caching.mdx @@ -8,7 +8,7 @@ related: - app/getting-started/revalidating ...
[ "docs/01-app/01-getting-started/08-caching.mdx" ]
[ { "comment": "TODO update! See comments below.", "path": "docs/01-app/01-getting-started/08-caching.mdx", "hunk": "@@ -289,130 +371,118 @@ This rendering approach is called **Partial Prerendering (PPR)**, and it's the d\n height=\"785\"\n />\n \n-Next.js requires you to explicitly handle components th...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
Add a callout to performance.now exception, you typically use it for telemetry, not to render
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/01-getting-started/08-caching.mdx b/docs/01-app/01-getting-started/08-caching.mdx index c1934e8adc59..d99771888baa 100644 --- a/docs/01-app/01-getting-started/08-caching.mdx +++ b/docs/01-app/01-getting-started/08-caching.mdx @@ -8,7 +8,7 @@ related: - app/getting-started/revalidating ...
[ "docs/01-app/01-getting-started/08-caching.mdx" ]
[ { "comment": "Add a callout to performance.now exception, you typically use it for telemetry, not to render", "path": "docs/01-app/01-getting-started/08-caching.mdx", "hunk": "@@ -195,9 +195,91 @@ async function CachedContent({ sessionId }: { sessionId: string }) {\n \n At request time, `CachedContent` ...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
Shouldnt this be removed? It will be default
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/01-getting-started/08-caching.mdx b/docs/01-app/01-getting-started/08-caching.mdx index c1934e8adc59..d99771888baa 100644 --- a/docs/01-app/01-getting-started/08-caching.mdx +++ b/docs/01-app/01-getting-started/08-caching.mdx @@ -8,7 +8,7 @@ related: - app/getting-started/revalidating ...
[ "docs/01-app/01-getting-started/08-caching.mdx" ]
[ { "comment": "Shouldnt this be removed? It will be default", "path": "docs/01-app/01-getting-started/08-caching.mdx", "hunk": "@@ -8,10 +8,10 @@ related:\n - app/getting-started/revalidating\n - app/api-reference/directives/use-cache\n - app/api-reference/config/next-config-js/cacheComponent...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
It also surfaces it as console logs! but it DOES need to run in dev, as it is right now
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/01-getting-started/08-caching.mdx b/docs/01-app/01-getting-started/08-caching.mdx index c1934e8adc59..d99771888baa 100644 --- a/docs/01-app/01-getting-started/08-caching.mdx +++ b/docs/01-app/01-getting-started/08-caching.mdx @@ -8,7 +8,7 @@ related: - app/getting-started/revalidating ...
[ "docs/01-app/01-getting-started/08-caching.mdx" ]
[ { "comment": "It also surfaces it as console logs! but it DOES need to run in dev, as it is right now", "path": "docs/01-app/01-getting-started/08-caching.mdx", "hunk": "@@ -277,9 +367,9 @@ This generates a static shell consisting of HTML for initial page loads and a se\n height=\"632\"\n />\n \n-This...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
Higher up you use "App Shell" but here its "fallback shell". its unclear how they differ
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/02-guides/runtime-prefetching.mdx b/docs/01-app/02-guides/runtime-prefetching.mdx new file mode 100644 index 000000000000..ff0cb563c2fd --- /dev/null +++ b/docs/01-app/02-guides/runtime-prefetching.mdx @@ -0,0 +1,208 @@ +--- +title: Runtime prefetching +description: Extend the static shell with...
[ "docs/01-app/02-guides/runtime-prefetching.mdx" ]
[ { "comment": "Higher up you use \"App Shell\" but here its \"fallback shell\". its unclear how they differ", "path": "docs/01-app/02-guides/runtime-prefetching.mdx", "hunk": "@@ -0,0 +1,161 @@\n+---\n+title: Runtime prefetching\n+description: Extend the static shell with personalized content using unsta...
true
vercel/next.js
93,204
comment_to_fix
doc: instant navs runtime story
```suggestion ```
23b1977efcea9d78b55607b2c7a7f248aefcf1c5
a5126cf276ff9885c9346cc6811e09bd2dd81900
diff --git a/docs/01-app/03-api-reference/01-directives/use-cache-private.mdx b/docs/01-app/03-api-reference/01-directives/use-cache-private.mdx index ad40504c379a..9ac807b31c99 100644 --- a/docs/01-app/03-api-reference/01-directives/use-cache-private.mdx +++ b/docs/01-app/03-api-reference/01-directives/use-cache-priva...
[ "docs/01-app/03-api-reference/01-directives/use-cache-private.mdx" ]
[ { "comment": "```suggestion\n```", "path": "docs/01-app/03-api-reference/01-directives/use-cache-private.mdx", "hunk": "@@ -19,13 +18,13 @@ Reach for `'use cache: private'` when:\n - You want to cache a function that already accesses runtime data, and refactoring to [move the runtime access outside and ...
true
vercel/next.js
94,608
issue_to_patch
docs: remove unstable_disableValidation recommendations
### What? Removes `unstable_disableValidation` recommendations from all 14 insight-kind error pages and the `generateViewport` API reference. The key on `unstable_instant`'s object form is not going to ship as a recommended public API. ### Why? Each error page's **"Don't want this validation?"** block previously lis...
d424aa8ec4c7bfdf4175df47e26f17d7a60a49d3
2bc7c96a8122893153d505a293b3e1421847d30a
diff --git a/errors/blocking-prerender-client-hook.mdx b/errors/blocking-prerender-client-hook.mdx index 806e787d5b0f..b1f630c0c432 100644 --- a/errors/blocking-prerender-client-hook.mdx +++ b/errors/blocking-prerender-client-hook.mdx @@ -271,7 +271,7 @@ Navigations to this route are not instant. The user waits for the...
[ "errors/blocking-prerender-client-hook.mdx", "errors/blocking-prerender-crypto-client.mdx", "errors/blocking-prerender-crypto.mdx", "errors/blocking-prerender-current-time-client.mdx", "errors/blocking-prerender-current-time.mdx", "errors/blocking-prerender-dynamic.mdx", "errors/blocking-prerender-metad...
[]
true
vercel/next.js
94,621
issue_to_patch
[cd] Ensure wasm binaries get tagged properly
Follow-up to https://github.com/vercel/next.js/pull/94619
0630b70f3c5be7f4228c98c40828bc71bfc4ab26
36e54ada91b92d73f747cf3ccc40988fbea95a04
diff --git a/scripts/publish-native.js b/scripts/publish-native.js index 6a20b1c72cb8..d5fb96c985e5 100755 --- a/scripts/publish-native.js +++ b/scripts/publish-native.js @@ -171,7 +171,8 @@ const cwd = process.cwd() `${path.join(wasmDir, `pkg-${wasmTarget}`)}`, '--access', ...
[ "scripts/publish-native.js" ]
[]
true
vercel/next.js
94,617
issue_to_patch
Revert "Stabilize catchError and retry by removing unstable_ prefix"
Reverts vercel/next.js#94610 Unblock https://github.com/vercel/next.js/pull/94578
6b3936a3329486cc3c126d8cb7701f95517adbc0
03beaebd0d2c327282e5917cd1562d6196057f69
diff --git a/crates/next-custom-transforms/src/transforms/react_server_components.rs b/crates/next-custom-transforms/src/transforms/react_server_components.rs index f60d3fb2ca64..9658ed45c76d 100644 --- a/crates/next-custom-transforms/src/transforms/react_server_components.rs +++ b/crates/next-custom-transforms/src/tra...
[ "crates/next-custom-transforms/src/transforms/react_server_components.rs", "docs/01-app/01-getting-started/10-error-handling.mdx", "docs/01-app/03-api-reference/03-file-conventions/error.mdx", "docs/01-app/03-api-reference/04-functions/catchError.mdx", "packages/next/error.d.ts", "packages/next/error.js",...
[]
diff --git a/test/development/acceptance-app/rsc-build-errors.test.ts b/test/development/acceptance-app/rsc-build-errors.test.ts index 812120edc7a2..5a7545837dd7 100644 --- a/test/development/acceptance-app/rsc-build-errors.test.ts +++ b/test/development/acceptance-app/rsc-build-errors.test.ts @@ -256,14 +256,14 @@ des...
true
vercel/next.js
94,619
issue_to_patch
[cd] Publish preview release with `@preview` NPM dist-tag
I don't know why the publish native script drifted so much. But at a glance, it seemed like it only handled publish `@latest` and `@canary` i.e. a preview release would've published native binaries `@latest`. Forgot https://github.com/vercel/next.js/pull/84725 ## test plan ```console $ git commit --allow-empt...
db6f86450605986e04a58b6f489616bef571e04c
820fc9e6d5763d8a4430a83b054fbe0a9f82102d
diff --git a/scripts/publish-native.js b/scripts/publish-native.js index 9d4dafbcc4c8..6a20b1c72cb8 100755 --- a/scripts/publish-native.js +++ b/scripts/publish-native.js @@ -2,17 +2,82 @@ const path = require('path') const execa = require('execa') +const semver = require('semver') const { Sema } = require('async-...
[ "scripts/publish-native.js", "scripts/publish-release.js" ]
[]
true
vercel/next.js
94,620
issue_to_patch
docs: root-params highligth fixes
Once again, reformatting broke the highlights
3d920355dd7f037c942456532d26d6f7eebaea4d
748e7165a5a89edf9eef01d931811e037404366a
diff --git a/docs/01-app/03-api-reference/04-functions/next-root-params.mdx b/docs/01-app/03-api-reference/04-functions/next-root-params.mdx index 9280f8b974d1..53fd65ee32eb 100644 --- a/docs/01-app/03-api-reference/04-functions/next-root-params.mdx +++ b/docs/01-app/03-api-reference/04-functions/next-root-params.mdx @...
[ "docs/01-app/03-api-reference/04-functions/next-root-params.mdx" ]
[]
true
vercel/next.js
94,618
issue_to_patch
docs: update legacy blocking-route / next-prerender-* slugs
### What? Updates legacy error-page slugs in four App Router guides to the canonical `blocking-prerender-*` slugs. ### Why? The new error pages added to canary in #94564 use `blocking-prerender-dynamic`, `blocking-prerender-random`, etc. Several App Router guides still linked at the old `blocking-route` / `next-prer...
5975f633fc971ac925bd125ac7af219b279298e1
e5841986ae4b53d33bcba06ed0f4fb7e62df14b9
diff --git a/docs/01-app/01-getting-started/08-caching.mdx b/docs/01-app/01-getting-started/08-caching.mdx index cd9b1f11f1a6..d99771888baa 100644 --- a/docs/01-app/01-getting-started/08-caching.mdx +++ b/docs/01-app/01-getting-started/08-caching.mdx @@ -133,7 +133,7 @@ Without a `<Suspense>` boundary around the uncach...
[ "docs/01-app/01-getting-started/08-caching.mdx", "docs/01-app/02-guides/instant-navigation.mdx", "docs/01-app/02-guides/public-static-pages.mdx", "docs/01-app/02-guides/runtime-prefetching.mdx", "docs/01-app/02-guides/streaming.mdx" ]
[]
true
vercel/next.js
94,610
issue_to_patch
Stabilize catchError and retry by removing unstable_ prefix
### What? Promotes two experimental error-handling APIs to stable by dropping the `unstable_` prefix: - `unstable_catchError` → `catchError` (exported from `next/error`) - `unstable_retry` → `retry` (the prop Next.js injects into `error.js` / `global-error.js` boundaries and `catchError` fallbacks) ### Why? Both we...
de1fdd496a882b9e90702c87fa2f1b3aebea7150
7a7748ddb3e6d7bc78863312cbf08228d3a713b8
diff --git a/crates/next-custom-transforms/src/transforms/react_server_components.rs b/crates/next-custom-transforms/src/transforms/react_server_components.rs index 9658ed45c76d..f60d3fb2ca64 100644 --- a/crates/next-custom-transforms/src/transforms/react_server_components.rs +++ b/crates/next-custom-transforms/src/tra...
[ "crates/next-custom-transforms/src/transforms/react_server_components.rs", "docs/01-app/01-getting-started/10-error-handling.mdx", "docs/01-app/03-api-reference/03-file-conventions/error.mdx", "docs/01-app/03-api-reference/04-functions/catchError.mdx", "packages/next/error.d.ts", "packages/next/error.js",...
[]
diff --git a/test/development/acceptance-app/rsc-build-errors.test.ts b/test/development/acceptance-app/rsc-build-errors.test.ts index 5a7545837dd7..812120edc7a2 100644 --- a/test/development/acceptance-app/rsc-build-errors.test.ts +++ b/test/development/acceptance-app/rsc-build-errors.test.ts @@ -256,14 +256,14 @@ des...
true
vercel/turborepo
13,077
issue_to_patch
fix: Avoid Windows PTY task output
## Why Using ConPTY for Windows task output in stream mode regressed terminal rendering: ConPTY cursor inheritance can place output relative to the wrong terminal position, causing task output and the prompt/cursor to overlap. ## What Return Windows CLI task execution to piped stdio by only enabling PTY task output on...
823faeaabee97e2b76d0e3ab09bf715ec574fb6f
971aff25b3d9c78a7aaffd34c1d4c7d1833009f4
diff --git a/crates/turborepo-process/src/child/io.rs b/crates/turborepo-process/src/child/io.rs index 913f8cdfb37e4..dc439dd25d2d8 100644 --- a/crates/turborepo-process/src/child/io.rs +++ b/crates/turborepo-process/src/child/io.rs @@ -12,6 +12,8 @@ use tracing::{debug, trace}; use super::{Child, ChildExit}; const...
[ "crates/turborepo-process/src/child/io.rs" ]
[]
true
vercel/turborepo
13,074
issue_to_patch
release(turborepo): 2.9.19-canary.4
## Release v2.9.19-canary.4 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/27459271465) ### Changes - release(turborepo): 2.9.19-canary.3 (#13071) (`6a2f50c`) - fix: Use PTY for interactive Windows tasks (#13073) (`b95ebda`)
b95ebda1b47efa0a8769db188cc4944130704847
f414016ec48fbbd193b6d565b084d2885a39c17a
diff --git a/packages/create-turbo/package.json b/packages/create-turbo/package.json index 63c10a7e3062b..f8a8b278384ea 100644 --- a/packages/create-turbo/package.json +++ b/packages/create-turbo/package.json @@ -1,6 +1,6 @@ { "name": "create-turbo", - "version": "2.9.19-canary.3", + "version": "2.9.19-canary.4",...
[ "packages/create-turbo/package.json", "packages/eslint-config-turbo/package.json", "packages/eslint-plugin-turbo/package.json", "packages/turbo-codemod/package.json", "packages/turbo-gen/package.json", "packages/turbo-ignore/package.json", "packages/turbo-types/package.json", "packages/turbo-workspace...
[]
true
vercel/turborepo
13,076
issue_to_patch
Cannot cache symlink output dir ### Verify canary release - [x] I verified that the issue exists in the latest Turborepo canary release. ### Link to code that reproduces this issue https://github.com/serkodev/repros/tree/turborepo/symlink-output ### Which canary version will you have in your reproduction? 2.9.16 ...
fix: Cache outputs through internal symlinks
## Why Fixes https://github.com/vercel/turborepo/issues/13042. Tasks can produce cache outputs where an output directory is an internal symlink, such as `dist -> actual-dist`. Those outputs should be cacheable without `Not a directory` warnings, while symlink escapes outside the repo must remain rejected. ## W...
b95ebda1b47efa0a8769db188cc4944130704847
b3e92fa25241ead119e777f64502faa5033df5a4
diff --git a/crates/turborepo-cache/src/cache_archive/create.rs b/crates/turborepo-cache/src/cache_archive/create.rs index da4e05ec51d09..4e212e7dd184c 100644 --- a/crates/turborepo-cache/src/cache_archive/create.rs +++ b/crates/turborepo-cache/src/cache_archive/create.rs @@ -334,6 +334,8 @@ fn open_parent_dir( us...
[ "crates/turborepo-cache/src/cache_archive/create.rs", "crates/turborepo-cache/src/fs.rs", "crates/turborepo-run-cache/src/lib.rs" ]
[ { "comment": "```suggestion\n Err(CacheError::IO(err, _))\n if matches!(\n err.kind(),\n std::io::ErrorKind::NotADirectory | std::io::ErrorKind::FilesystemLoop\n ) =>\n {\n```\n\nInternal\\-symlink cache fix only handles `ENOTDIR` and misses `ELO...
true
vercel/turborepo
13,076
comment_to_fix
fix: Cache outputs through internal symlinks
```suggestion Err(CacheError::IO(err, _)) if matches!( err.kind(), std::io::ErrorKind::NotADirectory | std::io::ErrorKind::FilesystemLoop ) => { ``` Internal\-symlink cache fix only handles `ENOTDIR` and misses `ELOOP`\, so caching outputs through...
b95ebda1b47efa0a8769db188cc4944130704847
b3e92fa25241ead119e777f64502faa5033df5a4
diff --git a/crates/turborepo-cache/src/cache_archive/create.rs b/crates/turborepo-cache/src/cache_archive/create.rs index da4e05ec51d09..4e212e7dd184c 100644 --- a/crates/turborepo-cache/src/cache_archive/create.rs +++ b/crates/turborepo-cache/src/cache_archive/create.rs @@ -334,6 +334,8 @@ fn open_parent_dir( us...
[ "crates/turborepo-cache/src/cache_archive/create.rs" ]
[ { "comment": "```suggestion\n Err(CacheError::IO(err, _))\n if matches!(\n err.kind(),\n std::io::ErrorKind::NotADirectory | std::io::ErrorKind::FilesystemLoop\n ) =>\n {\n```\n\nInternal\\-symlink cache fix only handles `ENOTDIR` and misses `ELO...
true
vercel/turborepo
13,075
issue_to_patch
`turbo prune --docker`: pruned `pnpm-workspace.yaml` keeps out-of-closure `patchedDependencies` (pnpm 11 `ERR_PNPM_LOCKFILE_CONFIG_MISMATCH`) ### Verify canary release - [x] I verified that the issue exists in the latest Turborepo canary release (`2.9.17-canary.7`). ### Link to code that reproduces this issue https...
fix: Filter pruned pnpm workspace patches
## Why `turbo prune --docker` can produce a pnpm install context where the pruned lockfile has filtered `patchedDependencies`, but the root pruned `pnpm-workspace.yaml` still references stale workspace patches. pnpm then rejects frozen installs with `ERR_PNPM_LOCKFILE_CONFIG_MISMATCH`. Fixes #13066. ## What Fi...
b95ebda1b47efa0a8769db188cc4944130704847
a5e3de939ff4d3507e6f321ce9833503b5100d14
diff --git a/crates/turborepo-lib/src/commands/prune.rs b/crates/turborepo-lib/src/commands/prune.rs index b695337c898d6..60ae83f95f8e9 100644 --- a/crates/turborepo-lib/src/commands/prune.rs +++ b/crates/turborepo-lib/src/commands/prune.rs @@ -328,6 +328,11 @@ pub async fn prune( &pruned_patches, ...
[ "crates/turborepo-lib/src/commands/prune.rs", "crates/turborepo/tests/prune_test.rs" ]
[]
diff --git a/crates/turborepo/tests/prune_test.rs b/crates/turborepo/tests/prune_test.rs index 391f13dc094ee..06187f184b061 100644 --- a/crates/turborepo/tests/prune_test.rs +++ b/crates/turborepo/tests/prune_test.rs @@ -81,6 +81,65 @@ fn test_prune_docker() { ); } +#[test] +fn test_prune_docker_filters_pnpm_wo...
true
vercel/turborepo
13,073
issue_to_patch
fix: Use PTY for interactive Windows tasks
## Why Windows stream-mode task shutdown still relied on console-wide Ctrl+C delivery. That lets the task receive the interrupt, but it also lets surrounding shell wrappers react to the same Ctrl+C and can produce confusing shutdown behavior. Using a terminal-backed PTY for interactive runs gives Turbo its own ch...
6a2f50cb98c6b9e18f317bb0a7076bddf67f251e
8d9ffe3a0b97cbab6ba0d01177953ea2dd2fc9fa
diff --git a/crates/turborepo-lib/src/run/builder.rs b/crates/turborepo-lib/src/run/builder.rs index 2ade9e7f369d1..197c7a8176a8f 100644 --- a/crates/turborepo-lib/src/run/builder.rs +++ b/crates/turborepo-lib/src/run/builder.rs @@ -34,7 +34,7 @@ use turborepo_telemetry::events::{ repo::{RepoEventBuilder, RepoType...
[ "crates/turborepo-lib/src/run/builder.rs", "crates/turborepo-process/src/child/test.rs" ]
[]
true
vercel/turborepo
13,071
issue_to_patch
release(turborepo): 2.9.19-canary.3
## Release v2.9.19-canary.3 > [!CAUTION] > Versioned docs aliasing FAILED. [View logs](https://github.com/vercel/turborepo/actions/runs/27379226169) ### Changes - release(turborepo): 2.9.19-canary.2 (#13068) (`b62a04b`) - ci: Add PR workflow timeouts (#13070) (`539c17e`) - fix: Deliver Ctrl-C to ConPTY children duri...
ca712abac7b3ab966a149bc16f0483542beb4417
cdaa2c363d926a00afe07104062ed76ecd8db5fe
diff --git a/packages/create-turbo/package.json b/packages/create-turbo/package.json index bbe370f8846dd..63c10a7e3062b 100644 --- a/packages/create-turbo/package.json +++ b/packages/create-turbo/package.json @@ -1,6 +1,6 @@ { "name": "create-turbo", - "version": "2.9.19-canary.2", + "version": "2.9.19-canary.3",...
[ "packages/create-turbo/package.json", "packages/eslint-config-turbo/package.json", "packages/eslint-plugin-turbo/package.json", "packages/turbo-codemod/package.json", "packages/turbo-gen/package.json", "packages/turbo-ignore/package.json", "packages/turbo-types/package.json", "packages/turbo-workspace...
[]
true