repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
viatsko/awesome-vscode
286
issue_to_patch
Fix C# Link in Table of Contents
62023ec444c89c9374e81d8fdb56a649bcc23775
de97f2466bd9e2375aaf913c98c89219bb665fb1
diff --git a/README.md b/README.md index a25a011b..071c9ec0 100644 --- a/README.md +++ b/README.md @@ -30,7 +30,7 @@ A curated list of delightful [Visual Studio Code](https://code.visualstudio.com/ - [Bash IDE](#bash-ide) - [Bash Debug](#bash-debug) - [C++](#c) - - [C#](#c) + - [C#](#c-asp-net-and-net-co...
[ "README.md" ]
[]
true
viatsko/awesome-vscode
283
issue_to_patch
Added Remote Development
## Name of the extension you are adding Remote Development ## Why do you think this extension is awesome? This extension saves a lot of time and makes working on projects that are on remote servers or containers very seamless. ## Make sure that: - [x] Screenshot/GIF included (to demonstrate the plugin fu...
5a4a94520e7458f83d16210ee50bc00d75021a31
9fe4725f281451f6d7984290f0a1616c85b4edef
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 616a51ad..9dd41b97 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -3,7 +3,7 @@ To submit a package to this list, please do the following: 1. Find a link to the package you consider is awesome. Use the link from [marketplace.visualstudio.com](https://marke...
[ "CONTRIBUTING.md", "README.md" ]
[]
true
virattt/ai-hedge-fund
645
issue_to_patch
Add MIT LICENSE file (resolves #644)
Hi @virattt β€” following up on #644, this adds a standard **MIT `LICENSE`** file at the repo root, matching the README's stated MIT license. - Copyright is attributed to you (`Copyright (c) 2024 Virat Singh`) β€” please adjust the holder/year as you prefer. - This removes the "all rights reserved by default" ambiguity (n...
90351f35edd1bab5eec22df78d4d655d08eeed16
bf1f5368fd86a0416f6ec3d921a687256aa862eb
diff --git a/LICENSE b/LICENSE new file mode 100644 index 0000000000..6ed5ed19cf --- /dev/null +++ b/LICENSE @@ -0,0 +1,21 @@ +MIT License + +Copyright (c) 2024 Virat Singh + +Permission is hereby granted, free of charge, to any person obtaining a copy +of this software and associated documentation files (the "Software...
[ "LICENSE" ]
[]
true
virattt/ai-hedge-fund
638
issue_to_patch
fix: accept ticker CLI alias
## Summary - accept `--ticker` as an alias for the existing `--tickers` argument in both CLI parsers - keep the parsed destination as `args.tickers`, so existing code paths keep working - add a regression test for the documented alias contract ## Why README, Docker Compose, and the Docker wrapper scripts currently doc...
ac7654dc69411ee411de1b0eb0018d5641ccb21b
8d8a0107ea6d749031188a0dd42c31b7f2abb179
diff --git a/src/backtesting/cli.py b/src/backtesting/cli.py index 9867bfcd07..f54ce90357 100644 --- a/src/backtesting/cli.py +++ b/src/backtesting/cli.py @@ -17,7 +17,7 @@ def main() -> int: parser = argparse.ArgumentParser(description="Run backtesting engine (modular)") - parser.add_argument("--tickers", t...
[ "src/backtesting/cli.py", "src/cli/input.py", "tests/test_cli_ticker_alias.py" ]
[]
diff --git a/tests/test_cli_ticker_alias.py b/tests/test_cli_ticker_alias.py new file mode 100644 index 0000000000..21bb804b5f --- /dev/null +++ b/tests/test_cli_ticker_alias.py @@ -0,0 +1,48 @@ +import ast +from pathlib import Path + +ROOT = Path(__file__).resolve().parents[1] + + +def _add_argument_calls(path: str): ...
true
virattt/ai-hedge-fund
615
issue_to_patch
test: skip live FD smoke tests without API key
## Summary - skip the live Financial Datasets smoke tests when `FINANCIAL_DATASETS_API_KEY` is not configured - keep the existing `v2/data/test_client.py` smoke coverage available for contributors who opt in with credentials ## Why `v2/data/test_client.py` is collected by default by pytest, but it exercises the live F...
8da82186e08311986f6340475532f72686314e0f
aebc62f6b7effa20d3849e27b5b922c05acf4075
[ "v2/data/test_client.py" ]
[]
diff --git a/v2/data/test_client.py b/v2/data/test_client.py index 6898c820ea..e570735701 100644 --- a/v2/data/test_client.py +++ b/v2/data/test_client.py @@ -1,5 +1,6 @@ """Week 1 data exploration β€” pull and inspect FD data for 5 tickers.""" +import os import pytest from v2.data import FDClient @@ -8,6 +9,11 @@...
true
virattt/ai-hedge-fund
602
issue_to_patch
Seems not working with Deepseek V4 **Describe the bug** It was working well with Deepseek - v3 API. But with the latest V4, it always shows "No trading decisions available". NOTE: The LLM model was selected as DeepSeek V3 in the menu since there is no V4 option. But it actually used V4 in API calls as shown in Deepse...
fix: make JSON extraction robust for DeepSeek V4 output format
Fixes #601 ## Problem DeepSeek V4 (`deepseek-chat`) may return JSON without markdown code blocks or using plain backtick fences without the `json` specifier. The existing `extract_json_from_response` only searched for ` ```json ` blocks, so any response in a different format caused a `None` result. This triggered the...
876801b29592bef49b631e44640509684988bb25
0210109717a645911ab8c3d6e493ac37e424c46b
diff --git a/src/utils/llm.py b/src/utils/llm.py index c7535d5d27..6d746e82c8 100644 --- a/src/utils/llm.py +++ b/src/utils/llm.py @@ -107,15 +107,53 @@ def create_default_response(model_class: type[BaseModel]) -> BaseModel: def extract_json_from_response(content: str) -> dict | None: - """Extracts JSON from ma...
[ "src/utils/llm.py" ]
[]
true
virattt/ai-hedge-fund
584
issue_to_patch
add kimi api "Can you integrate the Kimi API?"
feat(llm): add Moonshot Kimi as a model provider
## Summary Adds Kimi (Moonshot) as a first-class LLM provider so users can run the hedge fund on `kimi-k2-0905-preview`, `kimi-latest`, and `moonshot-v1-128k` without routing through OpenRouter. Kimi exposes an OpenAI-compatible endpoint, so the new branch in `get_model()` reuses `ChatOpenAI` with a base URL override....
7fd0e1b954d0236b0517a841afdf7779d3d426cf
f7780f7dea568c7d7e9a419fbd6b38c7e64c7dec
diff --git a/.env.example b/.env.example index 8fbb936b59..0931ff4b4d 100644 --- a/.env.example +++ b/.env.example @@ -25,6 +25,11 @@ GOOGLE_API_KEY=your-google-api-key # For running LLMs hosted by xAI (Grok 4, etc.) XAI_API_KEY=your-xai-api-key +# For running LLMs hosted by Moonshot / Kimi (kimi-k2, kimi-latest, m...
[ ".env.example", "app/frontend/src/components/settings/api-keys.tsx", "src/llm/api_models.json", "src/llm/models.py" ]
[]
true
virattt/ai-hedge-fund
556
issue_to_patch
Fix news sentiment handling when news is missing
Initialize the sentiment aggregation state before branching on the fetched company news and normalize missing responses to an empty list. This prevents an UnboundLocalError when get_company_news() returns None or no articles while downstream logic still references the classification counters and aggregated results.
87481059152abdb40ff52c54a9fa87621e15307f
84c2f9e4dfa584596789259394725d4553925eb6
diff --git a/src/agents/news_sentiment.py b/src/agents/news_sentiment.py index 07e4ca4ab6..cce7b5349d 100644 --- a/src/agents/news_sentiment.py +++ b/src/agents/news_sentiment.py @@ -52,8 +52,10 @@ def news_sentiment_agent(state: AgentState, agent_id: str = "news_sentiment_agen api_key=api_key, ) ...
[ "src/agents/news_sentiment.py" ]
[]
true
virattt/ai-hedge-fund
567
issue_to_patch
test: add unit tests for Cache class
## Summary - Adds comprehensive unit tests for `src/data/cache.py` which previously had zero test coverage - Tests cover all five cache types (prices, financial metrics, line items, insider trades, company news) - Verifies deduplication logic in `_merge_data`, singleton behavior of `get_cache()`, and ticker isolation ...
03c87a7125da4d8f24831e95770a8d4684da0980
73a7ca166973f928d4f9ab09550364222e98b773
[ "tests/test_cache.py" ]
[]
diff --git a/tests/test_cache.py b/tests/test_cache.py new file mode 100644 index 0000000000..bde6f15059 --- /dev/null +++ b/tests/test_cache.py @@ -0,0 +1,158 @@ +import pytest + +from src.data.cache import Cache, get_cache + + +class TestCacheInit: + """Test Cache initialization.""" + + def test_new_cache_has_e...
true
virattt/ai-hedge-fund
536
issue_to_patch
fix: log API failures and handle missing data in Ben Graham agent
## Summary - **API calls that fail (e.g. HTTP 401 for unsupported tickers) were completely silent** β€” returning empty lists with no logging. This made it very difficult to diagnose why agents produced unexpected output. - **The Ben Graham agent interpreted "no data" as a bearish signal** β€” when all API calls returned ...
1317ba40283061409357679614308128c43e09df
488f7f4bb4b4c31428c432fbdb261f6fcce0269a
diff --git a/src/agents/ben_graham.py b/src/agents/ben_graham.py index 807175abbf..91d81d3d08 100644 --- a/src/agents/ben_graham.py +++ b/src/agents/ben_graham.py @@ -43,6 +43,16 @@ def ben_graham_agent(state: AgentState, agent_id: str = "ben_graham_agent"): progress.update_status(agent_id, ticker, "Getting ma...
[ "src/agents/ben_graham.py", "src/tools/api.py" ]
[]
true
virattt/ai-hedge-fund
549
issue_to_patch
fix: make CompanyNews.author optional to handle missing API data
## Problem When running the news sentiment agent, the Financial Datasets API sometimes returns company news articles without an `author` field. Since `CompanyNews.author` is defined as a required `str` field, Pydantic raises a validation error for every article missing it: ``` Failed to parse company news response fo...
c7775d7cd93768efd1ff4180ab51aca770dcc83f
7ad24547f7fd11e84817b86d31c5ab17676fb28f
diff --git a/src/data/models.py b/src/data/models.py index 994da88fbb..a5d492e686 100644 --- a/src/data/models.py +++ b/src/data/models.py @@ -102,7 +102,7 @@ class InsiderTradeResponse(BaseModel): class CompanyNews(BaseModel): ticker: str title: str - author: str + author: str | None = None sourc...
[ "src/data/models.py" ]
[]
true
virattt/ai-hedge-fund
530
issue_to_patch
Error in analysis, using default **Describe the bug** A clear and concise description of what the bug is. When i using the model Deepseek R1,Error in analysis,using default occured.,i have changed the baseurl for Deepseek R1,but it won't work either. **Screenshot** Add a screenshot of the bug to help explain your prob...
fix: replace bare except clauses with Exception in api.py
## Summary - Replace all 5 bare `except:` clauses in `src/tools/api.py` with `except Exception as e:` - Add `logger.warning()` calls so parsing failures are visible in logs instead of silently returning empty results - Bare `except:` catches `KeyboardInterrupt`, `SystemExit`, and `MemoryError`, making the program unin...
9be9ecfd74bd09c255d92a34809ddecf3cae0d36
e32baad19e00804e4daa9110e70c48d173e55e72
diff --git a/src/tools/api.py b/src/tools/api.py index 4bdd2148b8..b85d80ac45 100644 --- a/src/tools/api.py +++ b/src/tools/api.py @@ -1,9 +1,12 @@ import datetime +import logging import os import pandas as pd import requests import time +logger = logging.getLogger(__name__) + from src.data.cache import get_cac...
[ "src/tools/api.py" ]
[]
true
virattt/ai-hedge-fund
531
issue_to_patch
fix: raise ValueError for unsupported providers and remove duplicate import
## Summary - `get_model()` silently returns `None` when called with `ALIBABA`, `META`, or `MISTRAL` providers (defined in `ModelProvider` enum but missing from the if/elif chain). Callers then invoke `None.invoke(prompt)`, raising an opaque `AttributeError`. - Add an explicit `else` branch that raises `ValueError` wit...
9be9ecfd74bd09c255d92a34809ddecf3cae0d36
771114fa0763a16bc17e1ca1f9f36e8e97ca8c07
diff --git a/src/llm/models.py b/src/llm/models.py index 97af370e9a..9843b25ca8 100644 --- a/src/llm/models.py +++ b/src/llm/models.py @@ -6,7 +6,6 @@ from langchain_groq import ChatGroq from langchain_xai import ChatXAI from langchain_openai import ChatOpenAI, AzureChatOpenAI -from langchain_openai import ChatOpenA...
[ "src/llm/models.py" ]
[]
true
virattt/ai-hedge-fund
499
issue_to_patch
backtester.py short position cash check is inaccurate In backtester.py, the short position cash check if margin_required <= self.portfolio["cash"]: is inaccurate, because cash here represents the total cash balance, which can include amounts tied up in margin, rather than the actual free cash available for new positi...
Fix short position cash check to use available cash (margin-aware)
## Summary - Fixed the short position cash availability check in both `Portfolio.apply_short_open` and `BacktestService.execute_trade` to correctly compute available cash as `cash - margin_used` rather than using total cash. - Added a regression test that verifies the available cash semantics when opening additional s...
06602cb0798841dca8ff8336d59e2057b87c1ec4
6616baa4f8f778e04f56fc2084d6b6a17eeb711d
diff --git a/src/backtesting/portfolio.py b/src/backtesting/portfolio.py index 47ccaeed4d..8ced99239b 100644 --- a/src/backtesting/portfolio.py +++ b/src/backtesting/portfolio.py @@ -133,7 +133,10 @@ def apply_short_open(self, ticker: str, quantity: int, price: float) -> int: proceeds = price * quantity ...
[ "app/backend/services/backtest_service.py", "src/backtesting/portfolio.py", "tests/backtesting/test_portfolio.py" ]
[]
diff --git a/app/backend/services/backtest_service.py b/app/backend/services/backtest_service.py index b563939092..fef6959d21 100644 --- a/app/backend/services/backtest_service.py +++ b/app/backend/services/backtest_service.py @@ -122,7 +122,10 @@ def execute_trade(self, ticker: str, action: str, quantity: float, curre...
true
virattt/ai-hedge-fund
502
issue_to_patch
fix: use target downside deviation in Sortino ratio
## Summary - Sortino ratio used `std()` of only negative excess returns, which overstates downside risk - Replaced with target downside deviation: `sqrt(mean(min(excess, 0)^2))` across all periods - This matches the standard definition (Sortino & van der Meer, 1991) and is consistent with libraries like `ffn` and `empy...
06602cb0798841dca8ff8336d59e2057b87c1ec4
b64ca2dad6ccbc7d91097432b46d2fec032c3a41
diff --git a/src/backtesting/metrics.py b/src/backtesting/metrics.py index 78ba718959..09b2ab7456 100644 --- a/src/backtesting/metrics.py +++ b/src/backtesting/metrics.py @@ -46,13 +46,11 @@ def compute_metrics(self, values: Sequence[PortfolioValuePoint]) -> PerformanceM else: sharpe = 0.0 - ...
[ "src/backtesting/metrics.py" ]
[]
true
virattt/ai-hedge-fund
444
issue_to_patch
Add support for external Ollama endpoint and improve run scripts
The current docker installation does not support using an existing Ollama instance. This PR introduces support for an external Ollama endpoint, enhancing the configuration for dynamic endpoint management. Update Dockerfile and scripts to ensure correct paths for build context. Improve utilities for checking model ava...
f8eb5670024f8a5885a3e5f196f23e81e9fece34
6fa2c9c354ea04bf5c32abdc86bf608dc92d2a89
diff --git a/.dockerignore b/.dockerignore new file mode 100644 index 0000000000..10e3398b77 --- /dev/null +++ b/.dockerignore @@ -0,0 +1,28 @@ +# Git +.git +.gitignore + +# Poetry +.venv +__pycache__/ +*.py[cod] +*$py.class +.pytest_cache/ + +# Environment +.env + +# IDEs and editors +.idea/ +.vscode/ +*.swp +*.swo + ...
[ ".dockerignore", "docker/Dockerfile", "docker/README.md", "docker/docker-compose.yml", "docker/run.bat", "docker/run.sh", "src/utils/docker.py", "src/utils/ollama.py" ]
[ { "comment": "Is this default (assuming yes)?", "path": "src/utils/ollama.py", "hunk": "@@ -11,8 +11,25 @@\n from . import docker\n \n # Constants\n-OLLAMA_SERVER_URL = \"http://localhost:11434\"\n-OLLAMA_API_MODELS_ENDPOINT = f\"{OLLAMA_SERVER_URL}/api/tags\"\n+DEFAULT_OLLAMA_SERVER_URL = \"http://loca...
true
virattt/ai-hedge-fund
445
issue_to_patch
fix: escape percent character in backtester help text
The `poetry run python src/backtester.py --help` command was failing with a formatting error: ``` ValueError: unsupported format character '(' (0x28) at index 51 ``` To fix, I escaped `%` as `%%` in help string: `"50% (default: 0.0)"` β†’ `"50%% (default: 0.0)"`
5cc9dbcb83d49fa72c0d6de194b72f08118e679b
3a86a2d6f3ff37e2dec35e210939949caddc6446
diff --git a/src/cli/input.py b/src/cli/input.py index d4b275ee80..dd18c0487c 100644 --- a/src/cli/input.py +++ b/src/cli/input.py @@ -241,7 +241,7 @@ def parse_cli_inputs( dest="margin_requirement", type=float, default=0.0, - help="Initial margin requirement ratio for shorts (e.g., 0....
[ "src/cli/input.py" ]
[]
true
virattt/ai-hedge-fund
449
issue_to_patch
Fix growth rate calculations to use CAGR for accurate PEG ratios
## Summary - Fixed incorrect growth rate calculations in Peter Lynch, Phil Fisher, and Stanley Druckenmiller agents - All agents now use annualized growth rates (CAGR) instead of total growth over the period - This ensures accurate PEG ratio calculations and consistent growth comparisons ## Problem The agents we...
2c7e447aedfb9620ed5e846203f9a8b47fa23be3
1ee11538f8e85f5bbba465ff02a36604385b2271
diff --git a/src/agents/peter_lynch.py b/src/agents/peter_lynch.py index e936a650ab..f2b2c1cc74 100644 --- a/src/agents/peter_lynch.py +++ b/src/agents/peter_lynch.py @@ -317,8 +317,15 @@ def analyze_lynch_valuation(financial_line_items: list, market_cap: float | None latest_eps = eps_values[0] older_...
[ "src/agents/peter_lynch.py", "src/agents/phil_fisher.py", "src/agents/stanley_druckenmiller.py" ]
[]
true
virattt/ai-hedge-fund
441
issue_to_patch
fix: implement Cmd+, settings shortcut
Fixes missing `Cmd+,` shortcut for opening settings. The UI mentioned this shortcut but it wasn't implemented. Now both `Cmd+,` and `Cmd+Shift+J` work. - Added `Cmd+,` keyboard shortcut - Updated tooltip to match - Maintains backward compatibility with `Cmd+Shift+J` Screenshot of UI shortcut mention: <img widt...
c247746e9b9ef750f6036ee959a9a5d6f8551cae
3ca80670d27f55266e2af304999bbcfb28e1461d
diff --git a/app/frontend/src/components/layout/top-bar.tsx b/app/frontend/src/components/layout/top-bar.tsx index feb342e0f6..eb83a68f46 100644 --- a/app/frontend/src/components/layout/top-bar.tsx +++ b/app/frontend/src/components/layout/top-bar.tsx @@ -78,7 +78,7 @@ export function TopBar({ onClick={onSettin...
[ "app/frontend/src/components/layout/top-bar.tsx", "app/frontend/src/hooks/use-keyboard-shortcuts.ts" ]
[]
true
virattt/ai-hedge-fund
442
issue_to_patch
fix: center plus button in component items
Fixes the plus button alignment in component items. The button wasn't perfectly centered on hover. Now uses flexbox centering for proper alignment. Before: <img width="796" height="124" alt="plus-button-before" src="https://github.com/user-attachments/assets/9b27c0f6-a24b-4ed0-80d8-b57766defb66" /> After: <img wi...
c247746e9b9ef750f6036ee959a9a5d6f8551cae
f6166d820cdfb83967940b3667103c8a28c66676
diff --git a/app/frontend/src/components/panels/right/component-item.tsx b/app/frontend/src/components/panels/right/component-item.tsx index e079d88239..37573d7fb8 100644 --- a/app/frontend/src/components/panels/right/component-item.tsx +++ b/app/frontend/src/components/panels/right/component-item.tsx @@ -54,7 +54,7 @@...
[ "app/frontend/src/components/panels/right/component-item.tsx" ]
[]
true
virattt/ai-hedge-fund
440
issue_to_patch
Fix NoneType error in valuation agent working capital calculation
## Summary - Fixed TypeError when working_capital values are None in the valuation agent - Added proper None checks before performing subtraction operations - Defaults to 0 for working capital change when data is unavailable ## Problem The valuation agent was crashing with: ``` TypeError: unsupported operand type(s) f...
56343a879fef8ff4c6d2b1180fc55cee7ab29530
e8f4b85b6edd7f3c89e374b892703768ba12af0f
diff --git a/src/agents/valuation.py b/src/agents/valuation.py index 9f5f0fb331..b64c13eeca 100644 --- a/src/agents/valuation.py +++ b/src/agents/valuation.py @@ -74,7 +74,11 @@ def valuation_analyst_agent(state: AgentState, agent_id: str = "valuation_analys # --------------------------------------------------...
[ "src/agents/valuation.py" ]
[]
true
virattt/ai-hedge-fund
367
issue_to_patch
Add support for Azure OpenAI
Added support for using [Azure OpenAI](https://azure.microsoft.com/en-us/products/ai-services/openai-service) as a model provider.
6adc9b9ba4d648a4cc3080fe514f02b650e8b4eb
6d7f590b815b262da047f85bf93526db3859ab77
diff --git a/.env.example b/.env.example index c48ec197ab..eefdcf4fe3 100644 --- a/.env.example +++ b/.env.example @@ -26,4 +26,10 @@ OPENAI_API_KEY=your-openai-api-key GIGACHAT_API_KEY=your-gigachat-api-key # For running LLMs hosted by OpenRouter -OPENROUTER_API_KEY=your-openrouter-api-key \ No newline at end of f...
[ ".env.example", "src/llm/api_models.json", "src/llm/models.py" ]
[]
true
virattt/ai-hedge-fund
414
issue_to_patch
feature: support gigachat llm
Adds gigachat LLM support (from langchain_gigachat package - https://github.com/ai-forever/langchain-gigachat)
db4b7a3c5fdb9473ea7ddc2fd571e0ae41fc667d
4b028e984428021d0579a838ea56bce6429ee6ea
diff --git a/.env.example b/.env.example index c6380d8bdd..c48ec197ab 100644 --- a/.env.example +++ b/.env.example @@ -22,5 +22,8 @@ FINANCIAL_DATASETS_API_KEY=your-financial-datasets-api-key # Get your OpenAI API key from https://platform.openai.com/ OPENAI_API_KEY=your-openai-api-key +# For running LLM GigaChat +...
[ ".env.example", "README.md", "app/frontend/src/components/settings/api-keys.tsx", "pyproject.toml", "src/llm/api_models.json", "src/llm/models.py" ]
[ { "comment": "Can we explicitly pass in the API key here?\n\nAnd add support for being able to pass in the API key from the full-stack app (can use OpenAI as example above)", "path": "src/llm/models.py", "hunk": "@@ -188,3 +190,5 @@ def get_model(model_name: str, model_provider: ModelProvider, api_keys:...
true
virattt/ai-hedge-fund
414
comment_to_fix
feature: support gigachat llm
Can we explicitly pass in the API key here? And add support for being able to pass in the API key from the full-stack app (can use OpenAI as example above)
db4b7a3c5fdb9473ea7ddc2fd571e0ae41fc667d
4b028e984428021d0579a838ea56bce6429ee6ea
diff --git a/src/llm/models.py b/src/llm/models.py index 97e8f4f0b2..aea524c49f 100644 --- a/src/llm/models.py +++ b/src/llm/models.py @@ -5,6 +5,7 @@ from langchain_google_genai import ChatGoogleGenerativeAI from langchain_groq import ChatGroq from langchain_openai import ChatOpenAI +from langchain_gigachat import ...
[ "src/llm/models.py" ]
[ { "comment": "Can we explicitly pass in the API key here?\n\nAnd add support for being able to pass in the API key from the full-stack app (can use OpenAI as example above)", "path": "src/llm/models.py", "hunk": "@@ -188,3 +190,5 @@ def get_model(model_name: str, model_provider: ModelProvider, api_keys:...
true
virattt/ai-hedge-fund
414
comment_to_fix
feature: support gigachat llm
Let's keep the naming consistent (eg GIGACHAT_API_KEY) and explicitly grab the api key (see comment below)
db4b7a3c5fdb9473ea7ddc2fd571e0ae41fc667d
4b028e984428021d0579a838ea56bce6429ee6ea
diff --git a/.env.example b/.env.example index c6380d8bdd..c48ec197ab 100644 --- a/.env.example +++ b/.env.example @@ -22,5 +22,8 @@ FINANCIAL_DATASETS_API_KEY=your-financial-datasets-api-key # Get your OpenAI API key from https://platform.openai.com/ OPENAI_API_KEY=your-openai-api-key +# For running LLM GigaChat +...
[ ".env.example" ]
[ { "comment": "Let's keep the naming consistent (eg GIGACHAT_API_KEY) and explicitly grab the api key (see comment below)", "path": ".env.example", "hunk": "@@ -22,5 +22,8 @@ FINANCIAL_DATASETS_API_KEY=your-financial-datasets-api-key\n # Get your OpenAI API key from https://platform.openai.com/\n OPENAI_...
true
virattt/ai-hedge-fund
414
comment_to_fix
feature: support gigachat llm
Is this the URL to get an API key / credentials?
db4b7a3c5fdb9473ea7ddc2fd571e0ae41fc667d
4b028e984428021d0579a838ea56bce6429ee6ea
diff --git a/app/frontend/src/components/settings/api-keys.tsx b/app/frontend/src/components/settings/api-keys.tsx index 58610c414b..97f1ac257a 100644 --- a/app/frontend/src/components/settings/api-keys.tsx +++ b/app/frontend/src/components/settings/api-keys.tsx @@ -65,6 +65,13 @@ const LLM_API_KEYS: ApiKey[] = [ ...
[ "app/frontend/src/components/settings/api-keys.tsx" ]
[ { "comment": "Is this the URL to get an API key / credentials?", "path": "app/frontend/src/components/settings/api-keys.tsx", "hunk": "@@ -65,6 +65,13 @@ const LLM_API_KEYS: ApiKey[] = [\n description: 'For OpenRouter models (gpt-4o, gpt-4o-mini, etc.)',\n url: 'https://openrouter.ai/',\n pl...
true
virattt/ai-hedge-fund
407
issue_to_patch
refactor: Add Validation for Trade Price
This pull request introduces a validation improvement to the `PortfolioPosition` model in `app/backend/models/schemas.py`. The key changes ensure data integrity by adding a validation method for the `trade_price` field. ### Validation enhancement: * [`app/backend/models/schemas.py`](diffhunk://#diff-1cf0a514a411f...
60d2befc6aac6b8605d80ea6202c805c12281113
bdcd86c876d5588c21d9d0d84d31b041fa49bf04
diff --git a/app/backend/models/schemas.py b/app/backend/models/schemas.py index 7a296b4679..966732d071 100644 --- a/app/backend/models/schemas.py +++ b/app/backend/models/schemas.py @@ -1,5 +1,5 @@ from datetime import datetime, timedelta -from pydantic import BaseModel, Field +from pydantic import BaseModel, Field, ...
[ "app/backend/models/schemas.py" ]
[]
true
virattt/ai-hedge-fund
389
issue_to_patch
Refactor portfolio manager and LangGraph usage
This PR lets us create multiple teams of analysts + portfolio manager combos in a single Flow.
50b12f7e3d83fac67327673848d264d8cabd4a22
2213b226cdeada737dc01b2c729704437c668654
diff --git a/app/backend/models/schemas.py b/app/backend/models/schemas.py index 663fa82753..5ba3344014 100644 --- a/app/backend/models/schemas.py +++ b/app/backend/models/schemas.py @@ -3,6 +3,7 @@ from typing import List, Optional, Dict, Any from src.llm.models import ModelProvider from enum import Enum +from app....
[ "app/backend/models/schemas.py", "app/backend/routes/hedge_fund.py", "app/backend/services/agent_service.py", "app/backend/services/graph.py", "app/frontend/src/components/Flow.tsx", "app/frontend/src/components/Layout.tsx", "app/frontend/src/components/custom-controls.tsx", "app/frontend/src/componen...
[]
true
virattt/ai-hedge-fund
380
issue_to_patch
Switch default model from GPT-4o to GPT-4.1
## Summary Updates the default language model across the application from GPT-4o to GPT-4.1. ## Reason for change GPT-4.1 performs better than GPT-4o, is optimized for API usage, and is cheaper to operate.
9baee2e06a69e48cf500be10f71974045ea1eceb
c5400443a7464d3a5be4109572530c621b0f786e
diff --git a/app/backend/models/schemas.py b/app/backend/models/schemas.py index 1a1ab8c610..fbcb619af9 100644 --- a/app/backend/models/schemas.py +++ b/app/backend/models/schemas.py @@ -26,7 +26,7 @@ class HedgeFundRequest(BaseModel): agent_models: Optional[List[AgentModelConfig]] = None end_date: Optional[s...
[ "app/backend/models/schemas.py", "app/frontend/src/data/models.ts", "src/backtester.py", "src/llm/api_models.json", "src/main.py", "src/utils/llm.py" ]
[]
true
virattt/ai-hedge-fund
329
issue_to_patch
Add Agent for Predictive Analysis Based on Rakesh Jhunjhunwala's Investment Mindset
This pull request introduces a new Python module that simulates an AI agent modeled after the investment philosophy and mindset of Rakesh Jhunjhunwala. The agent leverages heuristics, market sentiment, and select financial indicators to make predictive assessments, inspired by Jhunjhunwala's approach to value investing...
1f48d42ca62e2c9f3cf4e791c804cc3840d55a17
70c043842d7692cdfeb025f26346e48986172adb
diff --git a/README.md b/README.md index 262456a702..e7c6b0a7f0 100644 --- a/README.md +++ b/README.md @@ -12,14 +12,15 @@ This system employs several agents working together: 6. Michael Burry Agent - The Big Short contrarian who hunts for deep value 7. Peter Lynch Agent - Practical investor who seeks "ten-baggers" i...
[ "README.md", "app/frontend/src/data/agents.ts", "src/agents/rakesh_jhunjhunwala.py", "src/utils/analysts.py" ]
[ { "comment": "Let's add this alphabetically in the list!", "path": "src/utils/analysts.py", "hunk": "@@ -87,6 +88,11 @@\n \"agent_func\": valuation_analyst_agent,\n \"order\": 13,\n },\n+ \"rakesh_jhunjhunwala\": {", "resolving_sha": "70c043842d7692cdfeb025f26346e48986172adb",...
true
virattt/ai-hedge-fund
311
issue_to_patch
Fix ModuleNotFoundError in Dockerfile
There is an error coming while running the project <img width="918" alt="Screenshot 2025-05-23 at 6 28 38β€―PM" src="https://github.com/user-attachments/assets/2c2d8a2d-9964-4e10-91bd-a0d1342f9cf1" /> Also described here - #291
db22c63fbc0a7dd395e821ae4d4a03893b49802b
ee1dea08d879b33506c84192bca968f723d8630f
diff --git a/Dockerfile b/Dockerfile index 642a6943ea..e97dd7a7c5 100644 --- a/Dockerfile +++ b/Dockerfile @@ -2,6 +2,9 @@ FROM python:3.11-slim WORKDIR /app +# Set PYTHONPATH to include the app directory +ENV PYTHONPATH=/app + # Install Poetry RUN pip install poetry==1.7.1 @@ -16,4 +19,4 @@ RUN poetry config ...
[ "Dockerfile" ]
[]
true
virattt/ai-hedge-fund
301
issue_to_patch
Added command line arguments to choose analysts
Use command line arguments to choose all or specified analysts: ``` --analysts-all --analysts michael_burry,ray_dalio,other_analyst ```
3f5af905f7d4d22480c59ac509c0336270d2a548
f29d2332782f1febda7ccd48a6741d62c1a113ad
diff --git a/src/backtester.py b/src/backtester.py index 4fc29bf1b8..33aae34acd 100644 --- a/src/backtester.py +++ b/src/backtester.py @@ -640,6 +640,17 @@ def analyze_performance(self): default=0.0, help="Margin ratio for short positions, e.g. 0.5 for 50% (default: 0.0)", ) + parser.add_argum...
[ "src/backtester.py" ]
[]
true
virattt/ai-hedge-fund
275
issue_to_patch
Handle `OPENAI_API_BASE` environment variable
LangChain's OpenAI integration doesn't support setting the base url from environment variables unlike the other integrations.
f0c9da1cae5497fdf2c0f20cd8375935a0c45b1e
8a1a72677036c433b95d34e3976bfafb9dc7e442
diff --git a/src/llm/models.py b/src/llm/models.py index 0f5c35f1b2..97433e96d8 100644 --- a/src/llm/models.py +++ b/src/llm/models.py @@ -111,11 +111,12 @@ def get_model(model_name: str, model_provider: ModelProvider) -> ChatOpenAI | Ch elif model_provider == ModelProvider.OPENAI: # Get and validate API ...
[ "src/llm/models.py" ]
[]
true
virattt/ai-hedge-fund
293
issue_to_patch
feat: add gemini-2.5-flash model to the list of available models
Add support for the gemini-2.5-flash model to the list of available models.
3f5af905f7d4d22480c59ac509c0336270d2a548
14e5d64840903f918910dd49f991fafcd45e8411
diff --git a/.env.example b/.env.example index 995fdd6f00..3bc855514c 100644 --- a/.env.example +++ b/.env.example @@ -1,6 +1,7 @@ # For running LLMs hosted by anthropic (claude-3-5-sonnet, claude-3-opus, claude-3-5-haiku) # Get your Anthropic API key from https://anthropic.com/ ANTHROPIC_API_KEY=your-anthropic-api-...
[ ".env.example", "app/frontend/src/data/models.ts", "src/llm/api_models.json" ]
[]
true
virattt/ai-hedge-fund
282
issue_to_patch
Bug Report: Floating Point Precision Issue in Sentiment Agent Confidence Score **Describe the bug** The confidence score for the "Sentiment" agent is displaying a floating-point precision issue, showing an excessive number of decimal places. In the provided screenshot, the confidence is 56.00000000000001 % instead of ...
Fix: Precision bug in confidence score
## Description Fixes floating-point precision bug in Sentiment Agent confidence score by rounding the result to 2 decimals after percentage calculation. ## Related Issue Closes [#280](https://github.com/virattt/ai-hedge-fund/issues/280)
fa95060e3e273f5162492d8d72b87cc1531a59b4
34f6d04ad15e0d793d10e3fc5a2d78b2ccde417d
diff --git a/src/agents/sentiment.py b/src/agents/sentiment.py index 2ed2e5c2d2..afb79247fd 100644 --- a/src/agents/sentiment.py +++ b/src/agents/sentiment.py @@ -70,7 +70,7 @@ def sentiment_agent(state: AgentState): total_weighted_signals = len(insider_signals) * insider_weight + len(news_signals) * news_weig...
[ "src/agents/sentiment.py" ]
[]
true
virattt/ai-hedge-fund
281
issue_to_patch
Fix confidence badge display rounding
Round the confidence value displayed in the badge to one decimal place for improved clarity.
fa95060e3e273f5162492d8d72b87cc1531a59b4
c1eb42ac2813c591f795907817cd16518e7c04d4
diff --git a/app/frontend/src/nodes/components/text-output-dialog.tsx b/app/frontend/src/nodes/components/text-output-dialog.tsx index 69868da5f3..e630c5f7a7 100644 --- a/app/frontend/src/nodes/components/text-output-dialog.tsx +++ b/app/frontend/src/nodes/components/text-output-dialog.tsx @@ -69,14 +69,13 @@ export fu...
[ "app/frontend/src/nodes/components/text-output-dialog.tsx" ]
[ { "comment": "How about just:\r\n\r\n```suggestion\r\n const rounded = Number(confidence.toFixed(1));\r\n```", "path": "app/frontend/src/nodes/components/text-output-dialog.tsx", "hunk": "@@ -69,14 +69,14 @@ export function TextOutputDialog({\n \n const getConfidenceBadge = (confidence: number) => ...
true
virattt/ai-hedge-fund
281
comment_to_fix
Fix confidence badge display rounding
How about just: ```suggestion const rounded = Number(confidence.toFixed(1)); ```
fa95060e3e273f5162492d8d72b87cc1531a59b4
c1eb42ac2813c591f795907817cd16518e7c04d4
diff --git a/app/frontend/src/nodes/components/text-output-dialog.tsx b/app/frontend/src/nodes/components/text-output-dialog.tsx index 69868da5f3..e630c5f7a7 100644 --- a/app/frontend/src/nodes/components/text-output-dialog.tsx +++ b/app/frontend/src/nodes/components/text-output-dialog.tsx @@ -69,14 +69,13 @@ export fu...
[ "app/frontend/src/nodes/components/text-output-dialog.tsx" ]
[ { "comment": "How about just:\r\n\r\n```suggestion\r\n const rounded = Number(confidence.toFixed(1));\r\n```", "path": "app/frontend/src/nodes/components/text-output-dialog.tsx", "hunk": "@@ -69,14 +69,14 @@ export function TextOutputDialog({\n \n const getConfidenceBadge = (confidence: number) => ...
true
virattt/ai-hedge-fund
274
issue_to_patch
Add custom model input
Hello πŸ‘‹ I wanted to choose the model I want so I added an input that asks for the model name for a specific provider if the custom model option is selected. ![CleanShot 2025-05-18 at 18 03 46@2x](https://github.com/user-attachments/assets/2cb7ea99-b142-4928-8f54-fb976542ad7f)
e079c6cd1bc6d8663740ac302bf9c9b422476479
a3b440f3c8b92014ac926d9e380357a4523c180f
diff --git a/src/backtester.py b/src/backtester.py index 714943de37..4fc29bf1b8 100644 --- a/src/backtester.py +++ b/src/backtester.py @@ -672,14 +672,14 @@ def analyze_performance(self): print(f"\nSelected analysts: " f"{', '.join(Fore.GREEN + choice.title().replace('_', ' ') + Style.RESET_ALL for choice in c...
[ "src/backtester.py", "src/llm/api_models.json", "src/llm/models.py", "src/llm/ollama_models.json", "src/main.py", "src/utils/llm.py" ]
[]
true
virattt/ai-hedge-fund
273
issue_to_patch
Add PYTHONPATH environment variable to all services in docker-compose
Fixed issue with docker compose : Add PYTHONPATH environment variable to all services in docker-compose.yml
7bf35d1c1f68a83420f50015f16f8ad33b38baf5
93a8293823e4af47436f1c49a34d2e703d8999e9
diff --git a/docker-compose.yml b/docker-compose.yml index 1e312f353f..64032670e9 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -24,6 +24,7 @@ services: environment: - PYTHONUNBUFFERED=1 - OLLAMA_BASE_URL=http://ollama:11434 + - PYTHONPATH=/app tty: true stdin_open: true ...
[ "docker-compose.yml" ]
[]
true
virattt/ai-hedge-fund
238
issue_to_patch
Fix: Windows model download (codec can't decode byte 0x8f) issue
### CHANGES - Replace `universal_newlines` with explicit `encoding='utf-8'`. - Add `errors='replace'` to handle undecodable characters gracefully. ### Summary This pull request updates the `download_model` function in `src/utils/ollama.py` to improve text encoding handling when running a subprocess. The chang...
acba3d2a1fd16ffbc5bd8ddf8aca9f5e0619f5e4
59386a4e29c6e2eb2f227c2d0be5251394627aac
diff --git a/src/utils/ollama.py b/src/utils/ollama.py index 62461acd97..5af70ee440 100644 --- a/src/utils/ollama.py +++ b/src/utils/ollama.py @@ -197,8 +197,16 @@ def download_model(model_name: str) -> bool: try: # Use the Ollama CLI to download the model - process = subprocess.Popen(["ollama", ...
[ "src/utils/ollama.py" ]
[ { "comment": "What does deleting `universal_newlines=True` do?", "path": "src/utils/ollama.py", "hunk": "@@ -229,7 +229,8 @@ def download_model(model_name: str) -> bool:\n stderr=subprocess.STDOUT, # Redirect stderr to stdout to capture all output\n text=True,\n bufs...
true
virattt/ai-hedge-fund
238
comment_to_fix
Fix: Windows model download (codec can't decode byte 0x8f) issue
What does deleting `universal_newlines=True` do?
acba3d2a1fd16ffbc5bd8ddf8aca9f5e0619f5e4
59386a4e29c6e2eb2f227c2d0be5251394627aac
diff --git a/src/utils/ollama.py b/src/utils/ollama.py index 62461acd97..5af70ee440 100644 --- a/src/utils/ollama.py +++ b/src/utils/ollama.py @@ -197,8 +197,16 @@ def download_model(model_name: str) -> bool: try: # Use the Ollama CLI to download the model - process = subprocess.Popen(["ollama", ...
[ "src/utils/ollama.py" ]
[ { "comment": "What does deleting `universal_newlines=True` do?", "path": "src/utils/ollama.py", "hunk": "@@ -229,7 +229,8 @@ def download_model(model_name: str) -> bool:\n stderr=subprocess.STDOUT, # Redirect stderr to stdout to capture all output\n text=True,\n bufs...
true
virattt/ai-hedge-fund
249
issue_to_patch
Support o3 and o4-mini
Add support for openai o3 and o4-mini. Remove obsolete o1 and o3-mini.
a6307729ca34b3a4d5a140ecadf147e399d0befb
d86ce91fe8e4957469be49f089628e99e872e97c
diff --git a/src/llm/models.py b/src/llm/models.py index 2593d07f23..1ea1c66410 100644 --- a/src/llm/models.py +++ b/src/llm/models.py @@ -111,13 +111,13 @@ def is_ollama(self) -> bool: provider=ModelProvider.OPENAI ), LLMModel( - display_name="[openai] o1", - model_name="o1", + ...
[ "src/llm/models.py" ]
[]
true
virattt/ai-hedge-fund
230
issue_to_patch
fix: changed 'win32' to 'windows' in ollama.py
changed 'win32' to 'windows' in ollama.py because sys.platform returns Win32 but platform.system() returns Windows
5e4baed392606968007b144ba73f8fa2aeddc367
ff64bb5b487c0651556357acd90603466edd061a
diff --git a/src/utils/ollama.py b/src/utils/ollama.py index 3a32f2ddfe..77b5168c99 100644 --- a/src/utils/ollama.py +++ b/src/utils/ollama.py @@ -13,12 +13,12 @@ OLLAMA_API_MODELS_ENDPOINT = f"{OLLAMA_SERVER_URL}/api/tags" OLLAMA_DOWNLOAD_URL = { "darwin": "https://ollama.com/download/darwin", # macOS - ...
[ "src/utils/ollama.py" ]
[]
true
vitejs/vite
22,678
issue_to_patch
chore(deps): update dependency esbuild to v0.28.1 [security]
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [esbuild](https://redirect.github.com/evanw/esbuild) | [`0.28.0` β†’ `0.28.1`](https://renovatebot.com/diffs/npm/esbuild/...
201293095cf0771e17770f0a7f0cbc360efd1bb0
2e6683b7a90a06ec36135fa6841b389554a41187
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index eef9b58b5a0ab0..a1fd4b9d447ebc 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -328,7 +328,7 @@ importers: version: 2.1.0 esbuild: specifier: ^0.28.0 - version: 0.28.0 + version: 0.28.1 escape-html: specifier: ...
[ "pnpm-lock.yaml" ]
[]
true
vitejs/vite
22,679
issue_to_patch
chore: update Code of Conduct link in issue templates
This was mentioned in #22676 refs #22557
201293095cf0771e17770f0a7f0cbc360efd1bb0
2e2c7e580ac7addaa3adce52c4da310fd6df977c
diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index ada4f1989d1920..51547308a0edbb 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -75,7 +75,7 @@ body: label: Validations description: Before submitting the issue...
[ ".github/ISSUE_TEMPLATE/bug_report.yml", ".github/ISSUE_TEMPLATE/feature_request.yml" ]
[]
true
vitejs/vite
22,663
issue_to_patch
docs: update team page
Updating to latest status some are based on https://github.com/vitest-dev/vitest/pull/9663
6ebcf6aa84d6627df40b5339142ca3c6bf5ad1d7
c5e45bf7e8669b6c39a168729657d8cb7f3a9647
diff --git a/docs/_data/team.js b/docs/_data/team.js index 0db6c439f3e3d2..cd7f397a888592 100644 --- a/docs/_data/team.js +++ b/docs/_data/team.js @@ -13,6 +13,21 @@ export const core = [ ], sponsor: 'https://github.com/sponsors/yyx990803', }, + { + avatar: 'https://github.com/sapphi-red.png', + nam...
[ "docs/_data/team.js" ]
[ { "comment": "@antfu I've updated based on the changes in https://github.com/vitest-dev/vitest/pull/9663. Let me know if you prefer other wordings", "path": "docs/_data/team.js", "hunk": "@@ -28,9 +28,9 @@ export const core = [\n avatar: 'https://www.github.com/antfu.png',\n name: 'Anthony Fu',\...
true
vitejs/vite
22,602
issue_to_patch
Watch files imported by the config on Node.js for `--configLoader native` ### Description I put my website config at `./site.config.ts`, and i import it and use it in `vite.config.ts`. Currently nothing happens if I change `./site.config.ts`. ### Suggested solution Automatically restart vite devserver and reload `v...
feat: track dependencies when loading config with native
Adds support for restarting the server when the dependency of the config file is edited for Node. This does not work in ~~deno and~~ bun as they don't support loaders. The tests are not added but it is covered on [the dep side](https://github.com/sapphi-red/fresh-import). close #21655 part of #21546
00edb41c6f3235ce0d569a0a2c5e3b4f14c6f2b0
3e741f98e602d6c5104be7bb99d2022067a6c6ce
diff --git a/packages/vite/LICENSE.md b/packages/vite/LICENSE.md index 6231fee859021c..ccf4c21380cdaf 100644 --- a/packages/vite/LICENSE.md +++ b/packages/vite/LICENSE.md @@ -990,6 +990,35 @@ Repository: https://github.com/follow-redirects/follow-redirects --------------------------------------- +## fresh-import +...
[ "packages/vite/LICENSE.md", "packages/vite/package.json", "packages/vite/src/node/config.ts", "pnpm-lock.yaml" ]
[ { "comment": "Is it possible to simplify the library API to only like this?\n\n```ts\nconst { result, dependencies } = await freshImport(\"path\")\n```\n\nIt can return undefined or throw if the runtime doesn't support the hooks. And then we can always assume adding the `t` internally. Context maybe isn't need...
true
vitejs/vite
22,602
comment_to_fix
feat: track dependencies when loading config with native
Is it possible to simplify the library API to only like this? ```ts const { result, dependencies } = await freshImport("path") ``` It can return undefined or throw if the runtime doesn't support the hooks. And then we can always assume adding the `t` internally. Context maybe isn't needed? Or we additionally add ran...
00edb41c6f3235ce0d569a0a2c5e3b4f14c6f2b0
3e741f98e602d6c5104be7bb99d2022067a6c6ce
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index 8991f6d7168112..9e6496f0222a48 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -13,6 +13,7 @@ import { } from '@voidzero-dev/vite-task-client' import colors from 'picocolors' import picomatc...
[ "packages/vite/src/node/config.ts" ]
[ { "comment": "Is it possible to simplify the library API to only like this?\n\n```ts\nconst { result, dependencies } = await freshImport(\"path\")\n```\n\nIt can return undefined or throw if the runtime doesn't support the hooks. And then we can always assume adding the `t` internally. Context maybe isn't need...
true
vitejs/vite
21,707
issue_to_patch
case insensitive matching for `import.meta.glob` ### Description You currently have to match by listing various possibilities in the pattern such as `'/path/to/assets/*.{avif,AVIF,gif,GIF,heif,HEIF,jpeg,JPEG,jpg,JPG,png,PNG,tiff,TIFF,webp,WEBP}'` ### Suggested solution An option passed to `import.meta.glob` that ma...
feat: `import.meta.glob` support `caseSensitive` option
<!-- - What is this PR solving? Write a clear and concise description. - Reference the issues it solves (e.g. `fixes #123`). - What other alternatives have you explored? - Are there any parts you think require more attention from reviewers? Also, please make sure you do the following: - Read the Contributing ...
8a13d6337eea3e74d6a7abaaa7e1d378f5b9bc49
a72d4ea1390d3b4f47c3a346bc45e7e95e37dee8
diff --git a/docs/guide/features.md b/docs/guide/features.md index a6e7efbcc124de..23e1cd11f8e8b4 100644 --- a/docs/guide/features.md +++ b/docs/guide/features.md @@ -620,6 +620,20 @@ Only the globs that are relative paths are interpreted as relative to the resolv All the resulting module keys are modified to be rel...
[ "docs/guide/features.md", "packages/vite/src/node/plugins/importMetaGlob.ts", "packages/vite/types/importGlob.d.ts", "playground/glob-import/__tests__/glob-import.spec.ts", "playground/glob-import/root/case-sensitive-dir/DATA-other.js", "playground/glob-import/root/case-sensitive-dir/data-test.js", "pla...
[]
diff --git a/playground/glob-import/__tests__/glob-import.spec.ts b/playground/glob-import/__tests__/glob-import.spec.ts index e2cf1f709fff7f..c5232205cbd7dc 100644 --- a/playground/glob-import/__tests__/glob-import.spec.ts +++ b/playground/glob-import/__tests__/glob-import.spec.ts @@ -368,6 +368,22 @@ test('import.met...
true
vitejs/vite
18,389
issue_to_patch
fix(css): support external CSS with lightningcss
### Description Tried to make external CSS work in lightningcss to provide a workaround to #18384 in a way, but found out that lightningcss does not support this (https://github.com/parcel-bundler/lightningcss/issues/479). refs #18384 refs #14505 <!-- What is this PR solving? Write a clear description or refe...
f8d75f7723aeb635126c8dc0e0c33266c72d24c0
9308e06fb2bf7d1e5c875600ae5fa3c97443f36e
diff --git a/packages/vite/src/node/plugins/css.ts b/packages/vite/src/node/plugins/css.ts index 367a97c9aa0d1f..3669462c422d53 100644 --- a/packages/vite/src/node/plugins/css.ts +++ b/packages/vite/src/node/plugins/css.ts @@ -3194,6 +3194,8 @@ function isPreProcessor(lang: any): lang is PreprocessLang { return lang...
[ "packages/vite/src/node/plugins/css.ts", "playground/css-lightningcss/__tests__/css-lightningcss.spec.ts", "playground/css-lightningcss/external.css", "playground/css-lightningcss/index.html", "playground/css-lightningcss/main.js", "playground/css/__tests__/tests.ts", "playground/css/external.css", "p...
[]
diff --git a/playground/css-lightningcss/__tests__/css-lightningcss.spec.ts b/playground/css-lightningcss/__tests__/css-lightningcss.spec.ts index ded8d9e9fd5da5..50a8548f6c1da6 100644 --- a/playground/css-lightningcss/__tests__/css-lightningcss.spec.ts +++ b/playground/css-lightningcss/__tests__/css-lightningcss.spec....
true
vitejs/vite
21,779
issue_to_patch
"ESM Integration proposal for Wasm" support ### Clear and concise description of the problem Hey! This is a feature request to add support for [wasm-bindgen](https://github.com/rustwasm/wasm-bindgen), a library to facilitate high-level interactions between Wasm modules and JavaScript for Rust. wasm-bindgen has s...
feat(wasm): direct .wasm imports (WASM ESM Integration)
Add support for importing `.wasm` files directly without the `?init` suffix, by the [WASM ESM Integration](https://github.com/WebAssembly/esm-integration) draft standard. The plugin parses wasm binary to extract imports/exports, generates appropriate glue code, and handles both dev and SSR build modes. close #4551 ...
f8d75f7723aeb635126c8dc0e0c33266c72d24c0
f5cb1c75e649e50e18909cfbd0ba8bf199928928
diff --git a/docs/guide/features.md b/docs/guide/features.md index dd0096f2f5f8a4..5dfdc67d0a8493 100644 --- a/docs/guide/features.md +++ b/docs/guide/features.md @@ -649,8 +649,25 @@ These rules are enforced to prevent accidentally importing files that are not in ## WebAssembly -Pre-compiled `.wasm` files can be ...
[ "docs/guide/features.md", "packages/vite/client.d.ts", "packages/vite/src/node/plugins/index.ts", "packages/vite/src/node/plugins/wasm.ts", "playground/ssr-wasm/__tests__/ssr-wasm.spec.ts", "playground/ssr-wasm/src/add.wasm", "playground/ssr-wasm/src/app.js", "playground/ssr-wasm/src/direct-add.js", ...
[]
diff --git a/playground/ssr-wasm/__tests__/ssr-wasm.spec.ts b/playground/ssr-wasm/__tests__/ssr-wasm.spec.ts index 5aba47e37dae80..0c0d667a646dd9 100644 --- a/playground/ssr-wasm/__tests__/ssr-wasm.spec.ts +++ b/playground/ssr-wasm/__tests__/ssr-wasm.spec.ts @@ -16,7 +16,7 @@ test('should work when output', async () =>...
true
vitejs/vite
22,587
issue_to_patch
refactor: include optional `bundledDev` in `DevEnvironment` instead of having a separate FBM `DevEnvironment`
This PR refactors how full bundle mode is handled inside Vite. Previously it was a separate environment that extended from `DevEnvironment`. Now it is a property on a `DevEnvironment`. When implementing https://github.com/vitejs/vite/pull/21626, we need to provide separate versions of a runnable/fetchable environmen...
8a13d6337eea3e74d6a7abaaa7e1d378f5b9bc49
c31c971fd42b027bc5f467e7b323e450eb0268d5
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index 8991f6d7168112..f4f287c6ac4eda 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -137,7 +137,6 @@ import { basePluginContextMeta, } from './server/pluginContainer' import { nodeResolveWithVi...
[ "packages/vite/src/node/config.ts", "packages/vite/src/node/server/bundledDev.ts", "packages/vite/src/node/server/environment.ts", "packages/vite/src/node/server/middlewares/htmlFallback.ts", "packages/vite/src/node/server/middlewares/indexHtml.ts", "packages/vite/src/node/server/middlewares/memoryFiles.t...
[ { "comment": "`isDev` is always `true` here because `fullBundle` requires it", "path": "packages/vite/src/node/server/middlewares/indexHtml.ts", "hunk": "@@ -499,9 +495,7 @@ export function indexHtmlMiddleware(\n typeof file.source === 'string'\n ? file.source\n : Buffe...
true
vitejs/vite
22,587
comment_to_fix
refactor: include optional `bundledDev` in `DevEnvironment` instead of having a separate FBM `DevEnvironment`
For some reason the TypeScript bundle generates `devEngine!` and breaks 🀷
8a13d6337eea3e74d6a7abaaa7e1d378f5b9bc49
c31c971fd42b027bc5f467e7b323e450eb0268d5
diff --git a/packages/vite/src/node/server/environments/fullBundleEnvironment.ts b/packages/vite/src/node/server/bundledDev.ts similarity index 76% rename from packages/vite/src/node/server/environments/fullBundleEnvironment.ts rename to packages/vite/src/node/server/bundledDev.ts index e1e5c9210484bd..39d5a69a6e1b2c 1...
[ "packages/vite/src/node/server/bundledDev.ts" ]
[ { "comment": "For some reason the TypeScript bundle generates `devEngine!` and breaks 🀷 ", "path": "packages/vite/src/node/server/bundledDev.ts", "hunk": "@@ -58,38 +56,39 @@ export class MemoryFiles {\n }\n }\n \n-export class FullBundleDevEnvironment extends DevEnvironment {\n- private devEngine!:...
true
vitejs/vite
22,587
comment_to_fix
refactor: include optional `bundledDev` in `DevEnvironment` instead of having a separate FBM `DevEnvironment`
I think we can set this to `true` for FBM as well ```suggestion disableFetchModule: true, ```
8a13d6337eea3e74d6a7abaaa7e1d378f5b9bc49
c31c971fd42b027bc5f467e7b323e450eb0268d5
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index 8991f6d7168112..f4f287c6ac4eda 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -137,7 +137,6 @@ import { basePluginContextMeta, } from './server/pluginContainer' import { nodeResolveWithVi...
[ "packages/vite/src/node/config.ts" ]
[ { "comment": "I think we can set this to `true` for FBM as well\n```suggestion\n disableFetchModule: true,\n```", "path": "packages/vite/src/node/config.ts", "hunk": "@@ -251,17 +250,10 @@ function defaultCreateClientDevEnvironment(\n config: ResolvedConfig,\n context: CreateDevEnvironmentContext...
true
vitejs/vite
22,593
issue_to_patch
`resolve.tsconfigPaths` misresolves paths from a symlinked shared tsconfig package ### Describe the bug Vite 8 builtin `resolve.tsconfigPaths` resolves imports incorrectly when an app `tsconfig.json` extends a shared tsconfig package through a workspace symlink. In the repro: - `packages/app/tsconfig.json` extends ...
feat: update rolldown to 1.1.1
See https://github.com/rolldown/rolldown/releases/tag/v1.1.0 & https://github.com/rolldown/rolldown/releases/tag/v1.1.1
6ebcf6aa84d6627df40b5339142ca3c6bf5ad1d7
92c759ca700008d8b67c8333fedcde99dee03dc1
diff --git a/docs/package.json b/docs/package.json index 729dff47b7b4f9..c3328ad12d3bc4 100644 --- a/docs/package.json +++ b/docs/package.json @@ -14,7 +14,7 @@ "@voidzero-dev/vitepress-theme": "^4.8.4", "feed": "^5.2.1", "markdown-it-image-size": "^15.0.1", - "oxc-minify": "^0.133.0", + "oxc-minif...
[ "docs/package.json", "package.json", "packages/vite/package.json", "playground/package.json", "pnpm-lock.yaml" ]
[ { "comment": "Critical: Using a temporary pkg.pr.new URL for rolldown dependency. This URL is not permanent and will break once the preview package expires or is removed. pkg.pr.new is intended for testing PRs, not production use.\n\n```javascript\n// Should be:\n\"rolldown\": \"1.1.0\"\n// Not:\n\"rolldown\": ...
true
vitejs/vite
22,593
comment_to_fix
feat: update rolldown to 1.1.1
Critical: Using a temporary pkg.pr.new URL for rolldown dependency. This URL is not permanent and will break once the preview package expires or is removed. pkg.pr.new is intended for testing PRs, not production use. ```javascript // Should be: "rolldown": "1.1.0" // Not: "rolldown": "https://pkg.pr.new/rolldown/rolld...
6ebcf6aa84d6627df40b5339142ca3c6bf5ad1d7
92c759ca700008d8b67c8333fedcde99dee03dc1
diff --git a/package.json b/package.json index 1ae99325457e2a..089951027e81c5 100644 --- a/package.json +++ b/package.json @@ -64,7 +64,7 @@ "oxfmt": "^0.53.0", "picocolors": "^1.1.1", "playwright-chromium": "^1.60.0", - "rolldown": "1.0.3", + "rolldown": "1.1.1", "rollup": "^4.59.0", "si...
[ "package.json" ]
[ { "comment": "Critical: Using a temporary pkg.pr.new URL for rolldown dependency. This URL is not permanent and will break once the preview package expires or is removed. pkg.pr.new is intended for testing PRs, not production use.\n\n```javascript\n// Should be:\n\"rolldown\": \"1.1.0\"\n// Not:\n\"rolldown\": ...
true
vitejs/vite
22,593
comment_to_fix
feat: update rolldown to 1.1.1
Critical: Using a temporary pkg.pr.new URL for rolldown dependency. This URL is ephemeral and will cause build failures when the preview package is removed. Use a stable version instead. ```javascript // Should be: "rolldown": "1.1.0" ``` ```suggestion "rolldown": "1.1.0", ``` *Spotted by [Graphite](https://a...
6ebcf6aa84d6627df40b5339142ca3c6bf5ad1d7
92c759ca700008d8b67c8333fedcde99dee03dc1
diff --git a/packages/vite/package.json b/packages/vite/package.json index 4f6266275b0ad3..f578429e78e407 100644 --- a/packages/vite/package.json +++ b/packages/vite/package.json @@ -76,7 +76,7 @@ "lightningcss": "^1.32.0", "picomatch": "^4.0.4", "postcss": "^8.5.15", - "rolldown": "1.0.3", + "roll...
[ "packages/vite/package.json" ]
[ { "comment": "Critical: Using a temporary pkg.pr.new URL for rolldown dependency. This URL is ephemeral and will cause build failures when the preview package is removed. Use a stable version instead.\n\n```javascript\n// Should be:\n\"rolldown\": \"1.1.0\"\n```\n```suggestion\n \"rolldown\": \"1.1.0\",\n\n`...
true
vitejs/vite
22,593
comment_to_fix
feat: update rolldown to 1.1.1
Using temporary pkg.pr.new URL instead of a stable npm version for rolldown dependency. Temporary preview packages from pkg.pr.new are not reliable for production use. ```typescript // Should be: "rolldown": "1.1.0", // Instead of: "rolldown": "https://pkg.pr.new/rolldown/rolldown@9704", ``` ```suggestion "rolldow...
6ebcf6aa84d6627df40b5339142ca3c6bf5ad1d7
92c759ca700008d8b67c8333fedcde99dee03dc1
diff --git a/playground/package.json b/playground/package.json index e3457217f4ae6c..17cd9f505bc9ff 100644 --- a/playground/package.json +++ b/playground/package.json @@ -10,6 +10,6 @@ "convert-source-map": "^2.0.0", "css-color-names": "^1.0.1", "kill-port": "^1.6.1", - "rolldown": "1.0.3" + "rolld...
[ "playground/package.json" ]
[ { "comment": "Using temporary pkg.pr.new URL instead of a stable npm version for rolldown dependency. Temporary preview packages from pkg.pr.new are not reliable for production use.\n\n```typescript\n// Should be:\n\"rolldown\": \"1.1.0\",\n// Instead of:\n\"rolldown\": \"https://pkg.pr.new/rolldown/rolldown@97...
true
vitejs/vite
22,593
comment_to_fix
feat: update rolldown to 1.1.1
```suggestion "packageManager": "pnpm@10.34.1", ``` It seems this unrelated change was included
6ebcf6aa84d6627df40b5339142ca3c6bf5ad1d7
92c759ca700008d8b67c8333fedcde99dee03dc1
diff --git a/package.json b/package.json index 1ae99325457e2a..089951027e81c5 100644 --- a/package.json +++ b/package.json @@ -64,7 +64,7 @@ "oxfmt": "^0.53.0", "picocolors": "^1.1.1", "playwright-chromium": "^1.60.0", - "rolldown": "1.0.3", + "rolldown": "1.1.1", "rollup": "^4.59.0", "si...
[ "package.json" ]
[ { "comment": "```suggestion\n \"packageManager\": \"pnpm@10.34.1\",\n```\nIt seems this unrelated change was included", "path": "package.json", "hunk": "@@ -90,7 +90,7 @@\n \"eslint --cache --fix --concurrency auto\"\n ]\n },\n- \"packageManager\": \"pnpm@10.34.1\",\n+ \"packageManager\":...
true
vitejs/vite
22,659
issue_to_patch
chore: update `create-react-app` links
Now `create-react-app` is (https://github.com/react/).
4074add63e4dbe777c30c5183a526928c0724fca
4d8243df89ebc34036e8a052f27056986c92a967
diff --git a/packages/vite/bin/openChrome.js b/packages/vite/bin/openChrome.js index 5a4aa95e94cf47..5b978057390bd4 100644 --- a/packages/vite/bin/openChrome.js +++ b/packages/vite/bin/openChrome.js @@ -3,7 +3,7 @@ Copyright (c) 2015-present, Facebook, Inc. This source code is licensed under the MIT license found in...
[ "packages/vite/bin/openChrome.js", "packages/vite/src/node/server/openBrowser.ts" ]
[]
true
vitejs/vite
22,633
issue_to_patch
docs(migration): update Oxc Minifier assumptions link
The existing link actually points to a Markdown document in the repo. This commit updates the link to save an extra click.
c13a37b53ec673e5a9053355fce3b9c4528fd917
6b9a304eb3e5cf94413f9b479efc0889550d172e
diff --git a/docs/guide/migration.md b/docs/guide/migration.md index 66546d9ebe5636..9e3dd74ec0ad9e 100644 --- a/docs/guide/migration.md +++ b/docs/guide/migration.md @@ -216,7 +216,7 @@ Property mangling and its related options ([`mangleProps`, `reserveProps`, `mang esbuild and Oxc Minifier make slightly different as...
[ "docs/guide/migration.md" ]
[]
true
vitejs/vite
22,656
issue_to_patch
chore: correct `parseAst`/`parseAstAsync` deprecation hints
The `@deprecated` JSDoc hints for the re-exported `parseAst` / `parseAstAsync` pointed to the wrong replacements: ```ts // before /** @deprecated - use `parse` instead */ export const parseAst: typeof _parseAst = _parseAst /** @deprecated - use `parseAsync` instead */ export const parseAstAsync: typeof _parseAs...
689a0669ad926461f3f1b81701cb6c01f7b2bd4a
eac0287e1cb5ee8afb3d024e225ced33a51d3f26
diff --git a/packages/vite/src/node/index.ts b/packages/vite/src/node/index.ts index 319e9649d3e514..38800dacd08420 100644 --- a/packages/vite/src/node/index.ts +++ b/packages/vite/src/node/index.ts @@ -21,9 +21,9 @@ export { type ESTree, } from 'rolldown/utils' -/** @deprecated - use `parse` instead */ +/** @dep...
[ "packages/vite/src/node/index.ts" ]
[]
true
vitejs/vite
21,409
issue_to_patch
`<script type=importmap>` is always wrongly placed closely before `<script type=module>` when building ### Describe the bug when using `transformIndexHtml` to move the `<script type=module>` to body, vite always place the `importmap` closely before the "module" on build, but all the generated `<link rel=modulepreload...
fix(html): insert import map before modulepreload that is not self-close tag
fixes #20979 I wasn't able to create a test case that actually errors. But I think the code was wrong. This regex should match not only `<link rel="modulepreload" ... />` but also`<link rel="modulepreload" ...>`.
689a0669ad926461f3f1b81701cb6c01f7b2bd4a
d8364f9a00926a2385ea320784e0f1fe3db41343
diff --git a/packages/vite/src/node/plugins/html.ts b/packages/vite/src/node/plugins/html.ts index a1ddfe00935ce3..af74f463eb4065 100644 --- a/packages/vite/src/node/plugins/html.ts +++ b/packages/vite/src/node/plugins/html.ts @@ -72,7 +72,7 @@ const importMapRE = const moduleScriptRE = /[ \t]*<script[^>]*type\s*=\...
[ "packages/vite/src/node/plugins/html.ts" ]
[]
true
vitejs/vite
22,643
issue_to_patch
fix(create-vite): remove tsconfig `moduleResolution` option
Follow up to #22592 The following error was happening. > error TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResolution' is set to 'NodeNext'. I removed the `moduleResolution` option as it will be set by `module` option. https://www.typescriptlang.org/tsconfig/#moduleResolution
01337adca3e588a88ec47ab1736e18db14d38237
c230ff391fc58abe11d055f480a1ff5f2c791083
diff --git a/packages/create-vite/template-preact-ts/tsconfig.node.json b/packages/create-vite/template-preact-ts/tsconfig.node.json index 1e970f10c33deb..8455dcbc2c9473 100644 --- a/packages/create-vite/template-preact-ts/tsconfig.node.json +++ b/packages/create-vite/template-preact-ts/tsconfig.node.json @@ -3,12 +3,1...
[ "packages/create-vite/template-preact-ts/tsconfig.node.json", "packages/create-vite/template-qwik-ts/tsconfig.node.json", "packages/create-vite/template-react-ts/tsconfig.node.json", "packages/create-vite/template-solid-ts/tsconfig.node.json", "packages/create-vite/template-svelte-ts/tsconfig.node.json", ...
[]
true
vitejs/vite
22,630
issue_to_patch
docs: correct `ssr.resolve.externalConditions` default value
## Description The documented default for `ssr.resolve.externalConditions` is out of date. The docs list: ``` - **Default:** `['node']` ``` But the source constant is `['node', 'module-sync']`: ```ts // packages/vite/src/node/constants.ts export const DEFAULT_EXTERNAL_CONDITIONS: readonly string[] = Object.freeze(...
c13a37b53ec673e5a9053355fce3b9c4528fd917
99d21ed117b3c68284ac3e28eba29ee00e7faa54
diff --git a/docs/config/ssr-options.md b/docs/config/ssr-options.md index 7ff3abb6ccac6f..240c9dc765b21b 100644 --- a/docs/config/ssr-options.md +++ b/docs/config/ssr-options.md @@ -42,7 +42,7 @@ These conditions are used in the plugin pipeline, and only affect non-externaliz ## ssr.resolve.externalConditions - **...
[ "docs/config/ssr-options.md" ]
[]
true
vitejs/vite
22,637
issue_to_patch
fix(deps): update all non-major dependencies
This PR contains the following updates: | Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) | |---|---|---|---| | [@babel/core](https://babel.dev/docs/en/next/babel-core) ([source](https://redirect.github.com/babel/babel/tree/HEAD/pa...
6b498d04cff1c874ae271f1cf089ad998574bd84
2570643c48efd60350fee78a3476d6fd82bd2b35
diff --git a/docs/package.json b/docs/package.json index 2313ef6e5ea817..729dff47b7b4f9 100644 --- a/docs/package.json +++ b/docs/package.json @@ -9,7 +9,7 @@ }, "devDependencies": { "@iconify/vue": "^5.0.1", - "@shikijs/vitepress-twoslash": "^4.1.0", + "@shikijs/vitepress-twoslash": "^4.2.0", "@t...
[ "docs/package.json", "package.json", "packages/create-vite/package.json", "packages/create-vite/template-lit-ts/package.json", "packages/create-vite/template-lit/package.json", "packages/create-vite/template-preact-ts/package.json", "packages/create-vite/template-preact/package.json", "packages/create...
[]
true
vitejs/vite
22,636
issue_to_patch
chore(deps): update actions/checkout digest to df4cb1c
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/checkout](https://redirect.github.com/actions/checkout) ([changelog](https://redirect.github.com/actions/checkout/compare/de0fac2e4500dabe0009e67214ff5f5447ce83dd..df4cb1c069e1874edd31b4311f1884172cec0e10)) | acti...
6b498d04cff1c874ae271f1cf089ad998574bd84
8c274f11583014827ac215a316b0f5a5615ebc88
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c6b3a15320a6de..5fca216097a6b0 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -39,7 +39,7 @@ jobs: steps: - name: Checkout - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6 + ...
[ ".github/workflows/ci.yml", ".github/workflows/copilot-setup-steps.yml", ".github/workflows/issue-close-require.yml", ".github/workflows/issue-labeled.yml", ".github/workflows/issue-template-check.yml", ".github/workflows/lock-closed-issues.yml", ".github/workflows/preview-release.yml", ".github/workf...
[]
true
vitejs/vite
22,603
issue_to_patch
ci: set permissions for create-github-app-token
Set permissions to limit the permission explicitly. https://docs.zizmor.sh/audits/#github-app refs https://github.com/vitejs/vite/security/code-scanning/40 refs https://github.com/actions/create-github-app-token#permission-permission-name
d58c470bfa19efa8557d49c4957a92272f911582
9af1d47f68a6871df22e940a71613f3b4e42ac1a
diff --git a/.github/workflows/ecosystem-ci-trigger.yml b/.github/workflows/ecosystem-ci-trigger.yml index 1d1650894330cf..c1fa679e3beff2 100644 --- a/.github/workflows/ecosystem-ci-trigger.yml +++ b/.github/workflows/ecosystem-ci-trigger.yml @@ -133,11 +133,13 @@ jobs: id: generate-token uses: action...
[ ".github/workflows/ecosystem-ci-trigger.yml" ]
[ { "comment": "Can we add comments for each permissions like the action permissions?\n\n\n```suggestion\n permission-issues: write # to create pr labels\n permission-pull-requests: write # to create pr labels\n permission-actions: write # to dispatch workflows\n```\n\nNot sure if we ne...
true
vitejs/vite
22,603
comment_to_fix
ci: set permissions for create-github-app-token
Can we add comments for each permissions like the action permissions? ```suggestion permission-issues: write # to create pr labels permission-pull-requests: write # to create pr labels permission-actions: write # to dispatch workflows ``` Not sure if we need `permission-issues` actually...
d58c470bfa19efa8557d49c4957a92272f911582
9af1d47f68a6871df22e940a71613f3b4e42ac1a
diff --git a/.github/workflows/ecosystem-ci-trigger.yml b/.github/workflows/ecosystem-ci-trigger.yml index 1d1650894330cf..c1fa679e3beff2 100644 --- a/.github/workflows/ecosystem-ci-trigger.yml +++ b/.github/workflows/ecosystem-ci-trigger.yml @@ -133,11 +133,13 @@ jobs: id: generate-token uses: action...
[ ".github/workflows/ecosystem-ci-trigger.yml" ]
[ { "comment": "Can we add comments for each permissions like the action permissions?\n\n\n```suggestion\n permission-issues: write # to create pr labels\n permission-pull-requests: write # to create pr labels\n permission-actions: write # to dispatch workflows\n```\n\nNot sure if we ne...
true
vitejs/vite
22,580
issue_to_patch
docs: clarify Env API docs based on feedback
Clarify some points based on the feedback at https://github.com/vitejs/vite/discussions/16358#discussioncomment-15290074
f94df87ff03b40b65e29bacdc04cc18c7bccaa4a
56062c87037a1b760d2af6f071f339171ec44bc1
diff --git a/docs/guide/api-environment-frameworks.md b/docs/guide/api-environment-frameworks.md index 2f413092c7b7d5..6afaf4d195e166 100644 --- a/docs/guide/api-environment-frameworks.md +++ b/docs/guide/api-environment-frameworks.md @@ -19,7 +19,13 @@ Since environments may run in different runtimes, communication ag...
[ "docs/guide/api-environment-frameworks.md", "docs/guide/api-environment-runtimes.md" ]
[]
true
vitejs/vite
22,614
issue_to_patch
chore: fix tailwind playground comments
Updates the Tailwind playground config comments to use the clearer wording "See ... for more details" when pointing to the related Vite PR. Validation: - `git diff --check` No tests were run because this only updates comments in playground config files.
4551a4bbc26e3434048f87035dd5c2f8be411c3e
b8f05c41e00f69cdf41d5a1518f88890dd03f5b5
diff --git a/playground/tailwind-v3/tailwind.config.ts b/playground/tailwind-v3/tailwind.config.ts index aabde1b75e7997..9cda5bde3113a0 100644 --- a/playground/tailwind-v3/tailwind.config.ts +++ b/playground/tailwind-v3/tailwind.config.ts @@ -5,7 +5,7 @@ import type { Config } from 'tailwindcss' export default { co...
[ "playground/tailwind-v3/tailwind.config.ts", "playground/tailwind/tailwind.config.ts" ]
[]
true
vitejs/vite
22,415
issue_to_patch
Support pnpm enableGlobalVirtualStore ### Description When using pnpm v11's `enableGlobalVirtualStore: true` setting, package files are stored in the global content-addressable store (e.g. `<drive>/.pnpm-store/v11/links/`) rather than inside the project's `node_modules/.pnpm/`. Vite's `server.fs.strict` blocks reques...
fix: apply correct fs restrictions for pnpm gvs
<!-- - What is this PR solving? Write a clear and concise description. - Reference the issues it solves (e.g. `fixes #123`). - What other alternatives have you explored? - Are there any parts you think require more attention from reviewers? Also, please make sure you do the following: - Read the Contributing ...
1c0655072af185c83abc1d5b2328405288e46e09
2ed96b16f555b7e4f4f4c1648d17c2cdfef44455
diff --git a/packages/vite/src/node/server/index.ts b/packages/vite/src/node/server/index.ts index 0ec61e2d4683cd..dcf1150f2e8b05 100644 --- a/packages/vite/src/node/server/index.ts +++ b/packages/vite/src/node/server/index.ts @@ -1,4 +1,5 @@ import path from 'node:path' +import fs from 'node:fs' import { execSync } ...
[ "packages/vite/src/node/server/index.ts" ]
[ { "comment": "Can we hoist this so yarn pnp also uses it?", "path": "packages/vite/src/node/server/index.ts", "hunk": "@@ -1239,6 +1240,25 @@ export async function resolveServerOptions(\n }\n }\n \n+ // pnpm's global virtual store (GVS) may place package files outside workspace root.\n+ // Read ...
true
vitejs/vite
22,415
comment_to_fix
fix: apply correct fs restrictions for pnpm gvs
Can we hoist this so yarn pnp also uses it?
1c0655072af185c83abc1d5b2328405288e46e09
2ed96b16f555b7e4f4f4c1648d17c2cdfef44455
diff --git a/packages/vite/src/node/server/index.ts b/packages/vite/src/node/server/index.ts index 0ec61e2d4683cd..dcf1150f2e8b05 100644 --- a/packages/vite/src/node/server/index.ts +++ b/packages/vite/src/node/server/index.ts @@ -1,4 +1,5 @@ import path from 'node:path' +import fs from 'node:fs' import { execSync } ...
[ "packages/vite/src/node/server/index.ts" ]
[ { "comment": "Can we hoist this so yarn pnp also uses it?", "path": "packages/vite/src/node/server/index.ts", "hunk": "@@ -1239,6 +1240,25 @@ export async function resolveServerOptions(\n }\n }\n \n+ // pnpm's global virtual store (GVS) may place package files outside workspace root.\n+ // Read ...
true
vitejs/vite
22,415
comment_to_fix
fix: apply correct fs restrictions for pnpm gvs
I'd prefer using `virtualStoreDir` instead and only adding if it starts with `..`, so we only do this for now for GVS.
1c0655072af185c83abc1d5b2328405288e46e09
2ed96b16f555b7e4f4f4c1648d17c2cdfef44455
diff --git a/packages/vite/src/node/server/index.ts b/packages/vite/src/node/server/index.ts index 0ec61e2d4683cd..dcf1150f2e8b05 100644 --- a/packages/vite/src/node/server/index.ts +++ b/packages/vite/src/node/server/index.ts @@ -1,4 +1,5 @@ import path from 'node:path' +import fs from 'node:fs' import { execSync } ...
[ "packages/vite/src/node/server/index.ts" ]
[ { "comment": "I'd prefer using `virtualStoreDir` instead and only adding if it starts with `..`, so we only do this for now for GVS.", "path": "packages/vite/src/node/server/index.ts", "hunk": "@@ -1239,6 +1240,25 @@ export async function resolveServerOptions(\n }\n }\n \n+ // pnpm's global virtu...
true
vitejs/vite
22,542
issue_to_patch
feat(deps): bump @vitejs/devtools peer dependency version
<!-- - What is this PR solving? Write a clear and concise description. - Reference the issues it solves (e.g. `fixes #123`). - What other alternatives have you explored? - Are there any parts you think require more attention from reviewers? Also, please make sure you do the following: - Read the Contributing ...
dc245c71e5007ea4d891a025e2d69ac96c736546
36274c4c6cd3536cf5ae928ceabcec9dc2d71512
diff --git a/packages/vite/package.json b/packages/vite/package.json index 668a6aef4452ad..fa6600eac64035 100644 --- a/packages/vite/package.json +++ b/packages/vite/package.json @@ -140,7 +140,7 @@ }, "peerDependencies": { "@types/node": "^20.19.0 || >=22.12.0", - "@vitejs/devtools": "^0.1.18", + "@vi...
[ "packages/vite/package.json" ]
[]
true
vitejs/vite
22,608
issue_to_patch
docs: multiple broken links (404) in documentation Hi team, I was browsing the documentation and noticed a few broken links that currently lead to 404 pages: 1. In `docs/blog/announcing-vite5-1.md` Broken: `https://github.com/vitest-dev/vitest/tree/main/packages/vite-node#readme` (Vitest reorganized their repo, so ...
docs: fix broken links
Fixes #22607 This PR resolves multiple 404 broken links in the documentation: 1. **Vite 5.1 Announcement:** Updated the dead `vite-node` Github link to point to the `vite-node` NPM package, as Vitest has reorganized their repository structure. 2. **Features Guide:** Updated the two OXC Transformer documentation links...
4551a4bbc26e3434048f87035dd5c2f8be411c3e
b9ebc52fbb46dc4a4ab131e9b2cf174f7998c661
diff --git a/docs/blog/announcing-vite5-1.md b/docs/blog/announcing-vite5-1.md index 45651fe2e0a485..e87a7fda98226a 100644 --- a/docs/blog/announcing-vite5-1.md +++ b/docs/blog/announcing-vite5-1.md @@ -54,7 +54,7 @@ The new API brings many benefits: - It doesn't depend on any node/bun/deno built-in APIs, so it can ru...
[ "docs/blog/announcing-vite5-1.md", "docs/guide/features.md" ]
[]
true
vitejs/vite
22,616
issue_to_patch
chore: clean up eslint config
- chore: avoid extglob syntax (https://github.com/vitejs/vite/commit/59fd9a0cc987ff4f7d5acd510bc4e8ad423895f8) - extglobs are not supported by oxlint. this change makes it easier to migrate to it later on - chore: use allowExperimental (https://github.com/vitejs/vite/commit/a488a9331536f991a775f5394462d1dc7022440d)...
4551a4bbc26e3434048f87035dd5c2f8be411c3e
a3bffb255eb053e2dacd5d275672c369ac309166
diff --git a/eslint.config.js b/eslint.config.js index a58c45ddd47bcd..3010cf40230e40 100644 --- a/eslint.config.js +++ b/eslint.config.js @@ -6,7 +6,6 @@ import pluginRegExp from 'eslint-plugin-regexp' import tseslint from 'typescript-eslint' import { defineConfig } from 'eslint/config' import globals from 'globals...
[ "eslint.config.js", "packages/vite/src/node/__tests__/utils.spec.ts", "playground/optimize-deps/dep-with-optional-peer-dep-cjs/index.js" ]
[]
diff --git a/packages/vite/src/node/__tests__/utils.spec.ts b/packages/vite/src/node/__tests__/utils.spec.ts index 8205a031c33d7f..391443906b1f0a 100644 --- a/packages/vite/src/node/__tests__/utils.spec.ts +++ b/packages/vite/src/node/__tests__/utils.spec.ts @@ -506,8 +506,10 @@ describe('isFileReadable', () => { ...
true
vitejs/vite
22,561
issue_to_patch
docs: clarify `loadEnv` merges `process.env`
### Description `loadEnv` filters **both** the `.env` files and `process.env` by the given `prefixes`. This second source isn't mentioned in the docs, so it's easy to assume `loadEnv` only reads `.env` files. As a result, passing `''` as `prefixes` returns the **entire** `process.env` β€” and inlining that into the clie...
f8d75f7723aeb635126c8dc0e0c33266c72d24c0
df8a8ea58699b19dbeddd37e13b812f2a221ba16
diff --git a/docs/guide/api-javascript.md b/docs/guide/api-javascript.md index ac6625ff52d154..cb17490b8f75b1 100644 --- a/docs/guide/api-javascript.md +++ b/docs/guide/api-javascript.md @@ -371,7 +371,7 @@ function loadEnv( **Related:** [`.env` Files](./env-and-mode.md#env-files) -Load `.env` files within the `en...
[ "docs/guide/api-javascript.md", "packages/vite/src/node/env.ts" ]
[ { "comment": "```suggestion\nLoad `.env` files within the `envDir` and merge them with the matching variables already present in `process.env`. By default, only env variables prefixed with `VITE_` are loaded, unless `prefixes` is changed.\n```", "path": "docs/guide/api-javascript.md", "hunk": "@@ -371,7...
true
vitejs/vite
22,561
comment_to_fix
docs: clarify `loadEnv` merges `process.env`
```suggestion Load `.env` files within the `envDir` and merge them with the matching variables already present in `process.env`. By default, only env variables prefixed with `VITE_` are loaded, unless `prefixes` is changed. ```
f8d75f7723aeb635126c8dc0e0c33266c72d24c0
df8a8ea58699b19dbeddd37e13b812f2a221ba16
diff --git a/docs/guide/api-javascript.md b/docs/guide/api-javascript.md index ac6625ff52d154..cb17490b8f75b1 100644 --- a/docs/guide/api-javascript.md +++ b/docs/guide/api-javascript.md @@ -371,7 +371,7 @@ function loadEnv( **Related:** [`.env` Files](./env-and-mode.md#env-files) -Load `.env` files within the `en...
[ "docs/guide/api-javascript.md" ]
[ { "comment": "```suggestion\nLoad `.env` files within the `envDir` and merge them with the matching variables already present in `process.env`. By default, only env variables prefixed with `VITE_` are loaded, unless `prefixes` is changed.\n```", "path": "docs/guide/api-javascript.md", "hunk": "@@ -371,7...
true
vitejs/vite
22,561
comment_to_fix
docs: clarify `loadEnv` merges `process.env`
```suggestion * Load `.env` files within the `envDir` and merge them with the matching * variables already present in `process.env`. ```
f8d75f7723aeb635126c8dc0e0c33266c72d24c0
df8a8ea58699b19dbeddd37e13b812f2a221ba16
diff --git a/packages/vite/src/node/env.ts b/packages/vite/src/node/env.ts index e80c23cd5cfe6f..13a386c98bdf9a 100644 --- a/packages/vite/src/node/env.ts +++ b/packages/vite/src/node/env.ts @@ -26,6 +26,10 @@ export function getEnvFilesForMode( return [] } +/** + * Load `.env` files within the `envDir` and merge...
[ "packages/vite/src/node/env.ts" ]
[ { "comment": "```suggestion\n * Load `.env` files within the `envDir` and merge them with the matching\n * variables already present in `process.env`.\n```", "path": "packages/vite/src/node/env.ts", "hunk": "@@ -25,6 +25,15 @@ export function getEnvFilesForMode(\n return []\n }\n \n+/**\n+ * Load `.en...
true
vitejs/vite
22,605
issue_to_patch
docs: add override banner
New banner with different gradient (and different news πŸ‘€)
00edb41c6f3235ce0d569a0a2c5e3b4f14c6f2b0
7ae6c3834f48e61666135b8bd8ab60cd856f5605
diff --git a/docs/.vitepress/config.ts b/docs/.vitepress/config.ts index f0157565dd9cab..66237eade43d64 100644 --- a/docs/.vitepress/config.ts +++ b/docs/.vitepress/config.ts @@ -1,5 +1,4 @@ import path from 'node:path' -import fs from 'node:fs' import type { HeadConfig } from 'vitepress' import { defineConfig } fro...
[ "docs/.vitepress/config.ts", "docs/.vitepress/theme/components/TopBanner.vue" ]
[]
true
vitejs/vite
22,606
issue_to_patch
docs: add "Cloudflare supports Vite's mission" post
<!-- - What is this PR solving? Write a clear and concise description. - Reference the issues it solves (e.g. `fixes #123`). - What other alternatives have you explored? - Are there any parts you think require more attention from reviewers? Also, please make sure you do the following: - Read the Contributing ...
00edb41c6f3235ce0d569a0a2c5e3b4f14c6f2b0
704dd7f6daef90b0e38fd5e6e4e79eca82b19104
diff --git a/docs/blog/cloudflare-supports-vite.md b/docs/blog/cloudflare-supports-vite.md new file mode 100644 index 00000000000000..bf6a4c726fdf74 --- /dev/null +++ b/docs/blog/cloudflare-supports-vite.md @@ -0,0 +1,61 @@ +--- +title: Cloudflare supports Vite's mission +author: + name: The Vite Team +date: 2026-06-0...
[ "docs/blog/cloudflare-supports-vite.md", "docs/public/og-image-cloudflare-supports-vite.webp" ]
[]
true
vitejs/vite
22,604
issue_to_patch
chore: bundle ViteTask client
Follow up to #22453
d58c470bfa19efa8557d49c4957a92272f911582
152449f002b90571d47a0124784ac313dd36e009
diff --git a/packages/vite/LICENSE.md b/packages/vite/LICENSE.md index b1f6800c44d932..6231fee859021c 100644 --- a/packages/vite/LICENSE.md +++ b/packages/vite/LICENSE.md @@ -369,6 +369,34 @@ Repository: https://github.com/vitest-dev/vitest --------------------------------------- +## @voidzero-dev/vite-task-client...
[ "packages/vite/LICENSE.md", "packages/vite/package.json", "pnpm-lock.yaml" ]
[]
true
vitejs/vite
22,600
issue_to_patch
docs: add ios16.4 to the documented baseline-widely-available target
## Description The documented default for `build.target` lists the resolved `'baseline-widely-available'` value as a 4-entry array, but the actual source constant is a 5-entry array β€” it's missing `'ios16.4'`. In `packages/vite/src/node/constants.ts`, `ESBUILD_BASELINE_WIDELY_AVAILABLE_TARGET` is: ```js ['chrome111'...
d1e8a78dcf5db2e983a82d30f5ee25e268a20013
934d4297ac31caf50ff15b6e3b5b1c68dcbbc01d
diff --git a/docs/config/build-options.md b/docs/config/build-options.md index c41dd9752b2977..47b49e5ebd48ad 100644 --- a/docs/config/build-options.md +++ b/docs/config/build-options.md @@ -8,7 +8,7 @@ Unless noted, the options in this section are only applied to build. - **Default:** `'baseline-widely-available'` -...
[ "docs/config/build-options.md" ]
[]
true
vitejs/vite
22,592
issue_to_patch
feat(create-vite): use `"moduleResolution": "nodenext"` for `tsconfig.node.json`
Part of https://github.com/vitejs/vite/issues/21546 `"moduleResolution": "nodenext"` is recommended for type stripping: - https://github.com/tsconfig/bases/blob/main/bases/node-ts.json - https://nodejs.org/docs/latest/api/typescript.html#type-stripping
d1e8a78dcf5db2e983a82d30f5ee25e268a20013
ed111c6f69bde1b9bcfab3997cd43b5dfd87ab2a
diff --git a/packages/create-vite/template-preact-ts/tsconfig.node.json b/packages/create-vite/template-preact-ts/tsconfig.node.json index d3c52ea64c6cd6..1e970f10c33deb 100644 --- a/packages/create-vite/template-preact-ts/tsconfig.node.json +++ b/packages/create-vite/template-preact-ts/tsconfig.node.json @@ -8,7 +8,7 ...
[ "packages/create-vite/template-preact-ts/tsconfig.node.json", "packages/create-vite/template-qwik-ts/tsconfig.node.json", "packages/create-vite/template-react-ts/tsconfig.node.json", "packages/create-vite/template-solid-ts/tsconfig.node.json", "packages/create-vite/template-svelte-ts/tsconfig.node.json", ...
[]
true
vitejs/vite
21,863
issue_to_patch
feat(types): add more precise typing for known `query` types to match known `as` types
# Summary In [Vite 5.1 (released Feb 8, 2024)](https://vite.dev/blog/announcing-vite5-1#deprecated-as-option-in-import-meta-glob), the `as` option in the `import.meta.glob` function was deprecated. The official recommendation was to switch to the `query` option, e.g.: ```diff const myGlobImports = import.meta.glob...
eb12604a0dc99cec90529e2bd13552e9a0cdef7b
a54925b837efef9d008bc2bfa9749fe3ad6a73d4
diff --git a/packages/vite/src/node/__tests_dts__/importGlob.ts b/packages/vite/src/node/__tests_dts__/importGlob.ts new file mode 100644 index 00000000000000..8a773b31339a63 --- /dev/null +++ b/packages/vite/src/node/__tests_dts__/importGlob.ts @@ -0,0 +1,101 @@ +/* eslint-disable @typescript-eslint/no-unused-vars */ ...
[ "packages/vite/src/node/__tests_dts__/importGlob.ts", "packages/vite/src/node/index.ts", "packages/vite/types/importGlob.d.ts" ]
[]
true
vitejs/vite
22,288
issue_to_patch
chore: update `es-module-lexer` to 2.0.0
<!-- - What is this PR solving? Write a clear and concise description. - Reference the issues it solves (e.g. `fixes #123`). - What other alternatives have you explored? - Are there any parts you think require more attention from reviewers? Also, please make sure you do the following: - Read the Contributing ...
dc245c71e5007ea4d891a025e2d69ac96c736546
5ed16771b4d5726f92ebb92ca8eb1b8cdefc725b
diff --git a/packages/vite/package.json b/packages/vite/package.json index 8247d31a389145..dd8934d7eec15a 100644 --- a/packages/vite/package.json +++ b/packages/vite/package.json @@ -104,7 +104,7 @@ "cors": "^2.8.6", "cross-spawn": "^7.0.6", "dotenv-expand": "^13.0.0", - "es-module-lexer": "^1.7.0", +...
[ "packages/vite/package.json", "pnpm-lock.yaml" ]
[]
true
vitejs/vite
22,558
issue_to_patch
refactor: match import glob common base by path segment correctly
### Description `getCommonBase` currently checks common directories with `startsWith`, so `/a/foo` is treated as a common base for `/a/foo` and `/a/foobar`. This can pass a too-narrow `cwd` to glob matching when directory names share a string prefix. This changes the check to require a full path segment match, and ad...
28d8e12c2620cc6a8c4426604d49606f351d6283
53ed2e4120657361789e21f0f2d489369fef506c
diff --git a/packages/vite/src/node/plugins/importMetaGlob.ts b/packages/vite/src/node/plugins/importMetaGlob.ts index 4bed9f5c8f3b78..2eb681257d42b7 100644 --- a/packages/vite/src/node/plugins/importMetaGlob.ts +++ b/packages/vite/src/node/plugins/importMetaGlob.ts @@ -702,7 +702,11 @@ export function getCommonBase(gl...
[ "packages/vite/src/node/__tests__/plugins/importGlob/utils.spec.ts", "packages/vite/src/node/plugins/importMetaGlob.ts" ]
[]
diff --git a/packages/vite/src/node/__tests__/plugins/importGlob/utils.spec.ts b/packages/vite/src/node/__tests__/plugins/importGlob/utils.spec.ts index bd91c6165f798e..c3550428490f0b 100644 --- a/packages/vite/src/node/__tests__/plugins/importGlob/utils.spec.ts +++ b/packages/vite/src/node/__tests__/plugins/importGlob...
true
vitejs/vite
22,428
issue_to_patch
Sourcemap support when optimizing dependencies ### Description Currently, source mapped stacktraces reference line numbers from the optimized dependency output file in the cache, rather than from the source files of the dependency optimization step, even though esbuild includes sourcemaps in the cache. ### Suggested...
fix(optimizer): preserve sourcemaps for transformed optimized deps with follow-up transforms
fixes https://github.com/vitejs/vite/issues/13560 <img width="3360" height="490" alt="image" src="https://github.com/user-attachments/assets/4f2da34b-d30b-48ae-a4da-762e19206944" /> On the screenshot above, we can see that `root` fails to be evaluated to the correct identifier (because it can't be properly mapped...
28d8e12c2620cc6a8c4426604d49606f351d6283
4fc692b90543b07052ec8c7290783b2c00f6d8c9
diff --git a/packages/vite/src/node/optimizer/index.ts b/packages/vite/src/node/optimizer/index.ts index c88de8003208d3..05846986800ed1 100644 --- a/packages/vite/src/node/optimizer/index.ts +++ b/packages/vite/src/node/optimizer/index.ts @@ -868,7 +868,7 @@ async function prepareRolldownOptimizerRun( return awa...
[ "packages/vite/src/node/optimizer/index.ts", "packages/vite/src/node/plugins/optimizedDeps.ts", "playground/js-sourcemap/__tests__/js-sourcemap.spec.ts", "playground/js-sourcemap/dep-class-field-sourcemap-babel/index.js", "playground/js-sourcemap/dep-class-field-sourcemap-babel/package.json", "playground/...
[ { "comment": "this is somewhat defensive... but I wasn't sure if you'd prefer a hard crash on invalid data here or how this should otherwise behave", "path": "packages/vite/src/node/plugins/optimizedDeps.ts", "hunk": "@@ -82,7 +82,20 @@ export function optimizedDepsPlugin(): Plugin {\n // load h...
diff --git a/playground/js-sourcemap/__tests__/js-sourcemap.spec.ts b/playground/js-sourcemap/__tests__/js-sourcemap.spec.ts index 92397c2789f3ba..9fd1e0d2fe5a6e 100644 --- a/playground/js-sourcemap/__tests__/js-sourcemap.spec.ts +++ b/playground/js-sourcemap/__tests__/js-sourcemap.spec.ts @@ -2,6 +2,7 @@ import { URL,...
true
vitejs/vite
22,453
issue_to_patch
feat: integrate with Vite Task for zero-config build caching
Integrates Vite with Vite Task so that `vite build` can be cached with zero configuration when run under `vp run`: Vite reports its build inputs, outputs, and tracked env vars through `@voidzero-dev/vite-task-client`, which is a no-op when Vite runs outside Vite Task. Companion PR on the Vite Task side: voidzero-dev/v...
dc245c71e5007ea4d891a025e2d69ac96c736546
bdf9921b561c3a398188b953e6a612df3ca21314
diff --git a/packages/vite/package.json b/packages/vite/package.json index 4afe92d0e43eef..ed039f9b1fcff6 100644 --- a/packages/vite/package.json +++ b/packages/vite/package.json @@ -73,6 +73,7 @@ }, "//": "READ CONTRIBUTING.md to understand what to put under deps vs. devDeps!", "dependencies": { + "@voidze...
[ "packages/vite/package.json", "packages/vite/src/node/config.ts", "packages/vite/src/node/env.ts", "packages/vite/src/node/optimizer/index.ts", "packages/vite/src/node/plugins/prepareOutDir.ts", "packages/vite/src/node/preview.ts", "packages/vite/src/node/server/index.ts", "pnpm-lock.yaml" ]
[ { "comment": "Temporarily pointed to git for easier debug. Will publish to npm after this PR is approved, before it's merged.", "path": "packages/vite/package.json", "hunk": "@@ -73,6 +73,7 @@\n },\n \"//\": \"READ CONTRIBUTING.md to understand what to put under deps vs. devDeps!\",\n \"dependenci...
true
vitejs/vite
22,453
comment_to_fix
feat: integrate with Vite Task for zero-config build caching
Since the optimizer only runs in dev and `disableCache()` is called in dev, I guess we don't need these calls.
dc245c71e5007ea4d891a025e2d69ac96c736546
bdf9921b561c3a398188b953e6a612df3ca21314
diff --git a/packages/vite/src/node/optimizer/index.ts b/packages/vite/src/node/optimizer/index.ts index 14186ddef51a71..c88de8003208d3 100644 --- a/packages/vite/src/node/optimizer/index.ts +++ b/packages/vite/src/node/optimizer/index.ts @@ -3,6 +3,7 @@ import fsp from 'node:fs/promises' import path from 'node:path' ...
[ "packages/vite/src/node/optimizer/index.ts" ]
[ { "comment": "Since the optimizer only runs in dev and `disableCache()` is called in dev, I guess we don't need these calls.", "path": "packages/vite/src/node/optimizer/index.ts", "hunk": "@@ -397,6 +398,15 @@ export async function loadCachedDepOptimizationMetadata(\n \n const depsCacheDir = getDepsCa...
true
vitejs/vite
22,453
comment_to_fix
feat: integrate with Vite Task for zero-config build caching
Should this be called for `preview` as well?
dc245c71e5007ea4d891a025e2d69ac96c736546
bdf9921b561c3a398188b953e6a612df3ca21314
diff --git a/packages/vite/src/node/server/index.ts b/packages/vite/src/node/server/index.ts index 0ec61e2d4683cd..722c19d2aba421 100644 --- a/packages/vite/src/node/server/index.ts +++ b/packages/vite/src/node/server/index.ts @@ -12,6 +12,7 @@ import colors from 'picocolors' import chokidar from 'chokidar' import la...
[ "packages/vite/src/node/server/index.ts" ]
[ { "comment": "Should this be called for `preview` as well?", "path": "packages/vite/src/node/server/index.ts", "hunk": "@@ -483,6 +484,11 @@ export async function _createServer(\n previousForceOptimizeOnRestart?: boolean\n },\n ): Promise<ViteDevServer> {\n+ // The dev server is a long-running, i...
true
vitejs/vite
22,453
comment_to_fix
feat: integrate with Vite Task for zero-config build caching
Not Vite specific, but does Vite Task take `NODE_OPTIONS` into account? If not, I guess it'd be nice to have that.
dc245c71e5007ea4d891a025e2d69ac96c736546
bdf9921b561c3a398188b953e6a612df3ca21314
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index 53bdd1ca7c1b4a..ebd09428bfc781 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -6,6 +6,11 @@ import { inspect, promisify } from 'node:util' import { performance } from 'node:perf_hooks' impor...
[ "packages/vite/src/node/config.ts" ]
[ { "comment": "Not Vite specific, but does Vite Task take `NODE_OPTIONS` into account? If not, I guess it'd be nice to have that.", "path": "packages/vite/src/node/config.ts", "hunk": "", "resolving_sha": "bdf9921b561c3a398188b953e6a612df3ca21314", "resolving_diff": "diff --git a/packages/vite/sr...
true
vitejs/vite
22,453
comment_to_fix
feat: integrate with Vite Task for zero-config build caching
It is a bit unintuitive that a function named `getEnv` has a side effect.
dc245c71e5007ea4d891a025e2d69ac96c736546
bdf9921b561c3a398188b953e6a612df3ca21314
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index 53bdd1ca7c1b4a..ebd09428bfc781 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -6,6 +6,11 @@ import { inspect, promisify } from 'node:util' import { performance } from 'node:perf_hooks' impor...
[ "packages/vite/src/node/config.ts" ]
[ { "comment": "It is a bit unintuitive that a function named `getEnv` has a side effect.", "path": "packages/vite/src/node/config.ts", "hunk": "@@ -1401,6 +1406,7 @@ export async function resolveConfig(\n \n let configFileDependencies: string[] = []\n let mode = inlineConfig.mode || defaultMode\n+ g...
true
vitejs/vite
22,453
comment_to_fix
feat: integrate with Vite Task for zero-config build caching
.
dc245c71e5007ea4d891a025e2d69ac96c736546
bdf9921b561c3a398188b953e6a612df3ca21314
diff --git a/packages/vite/package.json b/packages/vite/package.json index 4afe92d0e43eef..ed039f9b1fcff6 100644 --- a/packages/vite/package.json +++ b/packages/vite/package.json @@ -73,6 +73,7 @@ }, "//": "READ CONTRIBUTING.md to understand what to put under deps vs. devDeps!", "dependencies": { + "@voidze...
[ "packages/vite/package.json" ]
[ { "comment": ".", "path": "packages/vite/package.json", "hunk": "@@ -73,6 +73,7 @@\n },\n \"//\": \"READ CONTRIBUTING.md to understand what to put under deps vs. devDeps!\",\n \"dependencies\": {\n+ \"@voidzero-dev/vite-task-client\": \"github:voidzero-dev/vite-task#c16342348fa3c9a28074d10a338a...
true
vitejs/vite
21,357
issue_to_patch
Disabling WebSocket and HMR ### Description Some users are actively seeking ways to disable HMR (#13994). With HML enabled, and reactive components are partially rendered, it is unpredictable #18217 when page reload happens. From my personal experience, the page reloads multiple times, even during simple naviga...
feat: rename `server.hmr` options to `server.ws` options
I noticed that it's not possible to configure the ws settings when the HMR is disabled by `server.hmr: false`. This PR moves all ws related options under `server.hmr` to `server.ws`. This would make it possible to configure ws settings while disabling HMR. fixes https://github.com/vitejs/vite/issues/18489 refs http...
1c0655072af185c83abc1d5b2328405288e46e09
90c9819ebb30eb675196a05bb04718a5c4f3d431
diff --git a/docs/config/server-options.md b/docs/config/server-options.md index c9c1ca7412eb64..bf00e3545016c0 100644 --- a/docs/config/server-options.md +++ b/docs/config/server-options.md @@ -181,17 +181,45 @@ Specify server response headers. ## server.hmr -- **Type:** `boolean | { protocol?: string, host?: str...
[ "docs/config/server-options.md", "packages/vite/src/node/__tests__/config.spec.ts", "packages/vite/src/node/index.ts", "packages/vite/src/node/plugins/clientInjections.ts", "packages/vite/src/node/server/hmr.ts", "packages/vite/src/node/server/index.ts", "packages/vite/src/node/server/middlewares/__test...
[ { "comment": "```suggestion\n```\n\nseems unused", "path": "packages/vite/src/node/utils.ts", "hunk": "@@ -1398,6 +1481,10 @@ export function mergeConfig<\n }\n \n return mergeConfigRecursively(defaults, overrides, isRoot ? '' : '.')\n+ // if (isRoot && merged.server) {\n+ // setupHmrWsOptionCom...
diff --git a/packages/vite/src/node/__tests__/config.spec.ts b/packages/vite/src/node/__tests__/config.spec.ts index 6be5309c8420d2..f229921bd86b59 100644 --- a/packages/vite/src/node/__tests__/config.spec.ts +++ b/packages/vite/src/node/__tests__/config.spec.ts @@ -1,7 +1,7 @@ import http from 'node:http' import pat...
true
vitejs/vite
21,357
comment_to_fix
feat: rename `server.hmr` options to `server.ws` options
```suggestion ``` seems unused
1c0655072af185c83abc1d5b2328405288e46e09
90c9819ebb30eb675196a05bb04718a5c4f3d431
diff --git a/packages/vite/src/node/utils.ts b/packages/vite/src/node/utils.ts index 1f9fa309696595..8d538a293aae32 100644 --- a/packages/vite/src/node/utils.ts +++ b/packages/vite/src/node/utils.ts @@ -44,7 +44,7 @@ import { } from './constants' import type { DepOptimizationOptions } from './optimizer' import type ...
[ "packages/vite/src/node/utils.ts" ]
[ { "comment": "```suggestion\n```\n\nseems unused", "path": "packages/vite/src/node/utils.ts", "hunk": "@@ -1398,6 +1481,10 @@ export function mergeConfig<\n }\n \n return mergeConfigRecursively(defaults, overrides, isRoot ? '' : '.')\n+ // if (isRoot && merged.server) {\n+ // setupHmrWsOptionCom...
true
vitejs/vite
21,777
issue_to_patch
Use `node_modules/.vite` as default cacheDir when a `node_modules` directory exists ### Description Currently, Vite determines the default `cacheDir` as: - `.vite` (default) - `node_modules/.vite` when a `package.json` file is present However, some environments can create a `node_modules` directory without a `packa...
fix: use node_modules/.vite as cacheDir when node_modules exists
## Summary This PR fixes issue #21768 by checking for the existence of the directory when determining the default cache directory, not just when exists. ## Changes - Modified to check for directory existence - Added tests in to verify the new behavior ## Behavior The cacheDir resolution now follows this prior...
1c0655072af185c83abc1d5b2328405288e46e09
f0057982d1f81ebe7e5bb0a11c2945a330e94cbb
diff --git a/packages/vite/src/node/config.ts b/packages/vite/src/node/config.ts index 53bdd1ca7c1b4a..ec955a1805e321 100644 --- a/packages/vite/src/node/config.ts +++ b/packages/vite/src/node/config.ts @@ -1716,14 +1716,23 @@ export async function resolveConfig( : resolveBaseUrl(config.base, isBuild, logger) ...
[ "packages/vite/src/node/__tests__/config.spec.ts", "packages/vite/src/node/config.ts" ]
[]
diff --git a/packages/vite/src/node/__tests__/config.spec.ts b/packages/vite/src/node/__tests__/config.spec.ts index 6be5309c8420d2..24660d74741e3f 100644 --- a/packages/vite/src/node/__tests__/config.spec.ts +++ b/packages/vite/src/node/__tests__/config.spec.ts @@ -1,4 +1,5 @@ import http from 'node:http' +import os ...
true
vitejs/vite
21,748
issue_to_patch
feat(css): support lightningcss plugin dependency
Fixes this FIXME comment: https://github.com/vitejs/vite/blob/2de89f444a267daf409d2fba94b1bdef6cb4466c/playground/css/lightningcss-plugins.js#L46 requires https://github.com/parcel-bundler/lightningcss/pull/1170 to be released refs https://github.com/parcel-bundler/lightningcss/issues/877
1c0655072af185c83abc1d5b2328405288e46e09
6c3f47047b6e83cdc637227046315991d17b0951
diff --git a/packages/vite/src/node/plugins/css.ts b/packages/vite/src/node/plugins/css.ts index cf6152c9eb8ae2..cd7c2cf283c268 100644 --- a/packages/vite/src/node/plugins/css.ts +++ b/packages/vite/src/node/plugins/css.ts @@ -3347,6 +3347,24 @@ async function compileLightningCSS( let css = decoder.decode(res.code) ...
[ "packages/vite/src/node/plugins/css.ts", "playground/css/__tests__/css.spec.ts", "playground/css/__tests__/lightningcss/lightningcss.spec.ts", "playground/css/__tests__/tests.ts", "playground/css/lightningcss-plugins.js", "playground/css/vite.config-lightningcss.js" ]
[]
diff --git a/playground/css/__tests__/css.spec.ts b/playground/css/__tests__/css.spec.ts index c5506838313f49..386012743efab2 100644 --- a/playground/css/__tests__/css.spec.ts +++ b/playground/css/__tests__/css.spec.ts @@ -1,3 +1,1 @@ -import { tests } from './tests' - -tests(false) +import './tests' diff --git a/playg...
true
vitejs/vite
21,501
issue_to_patch
feat(server): support multiple hosts in __VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS
Allows `__VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS` environment variable to accept multiple comma-separated hosts instead of just a single host. ```bash # Before: single host only __VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=example.com # After: multiple hosts supported __VITE_ADDITIONAL_SERVER_ALLOWED_HOSTS=example.com...
1c0655072af185c83abc1d5b2328405288e46e09
3c9f237d3205b3185c07ea58dcc69579113955f0
diff --git a/docs/config/server-options.md b/docs/config/server-options.md index c9c1ca7412eb64..5a02566c31ff64 100644 --- a/docs/config/server-options.md +++ b/docs/config/server-options.md @@ -57,7 +57,7 @@ Setting `server.allowedHosts` to `true` allows any website to send requests to y ::: ::: details Configure ...
[ "docs/config/server-options.md", "packages/vite/src/node/__tests__/config.spec.ts", "packages/vite/src/node/server/index.ts" ]
[]
diff --git a/packages/vite/src/node/__tests__/config.spec.ts b/packages/vite/src/node/__tests__/config.spec.ts index 6be5309c8420d2..bc0bc05c112431 100644 --- a/packages/vite/src/node/__tests__/config.spec.ts +++ b/packages/vite/src/node/__tests__/config.spec.ts @@ -5,9 +5,11 @@ import { afterEach, describe, expect, te...
true