Split (1)

train · 87.9k rows

repo stringlengths 5 53	pr_number int32 1 321k	task_type stringclasses 2 values	issue_text stringlengths 0 81.2k	pr_title stringlengths 1 319	pr_body stringlengths 0 105k	base_sha stringlengths 40 40	head_sha stringlengths 40 40	gold_diff stringlengths 0 202M	changed_files listlengths 0 100	review_threads listlengths 0 100	test_patch stringlengths 0 23.4M	merged bool 1 class
vllm-project/vllm	43,606	comment_to_fix		[Render] Add `/derender` endpoints for disaggregated postprocessing	Can we reuse any of the logic for building the choices from the serving chat/completions code?	c7aa3d263049ac9eefd0f59a10f5ecc6a78927df	e2dc40963ddc2020783470994b86faddf1425346	diff --git a/vllm/entrypoints/serve/render/serving.py b/vllm/entrypoints/serve/render/serving.py index 6afb26d98435..05a291198337 100644 --- a/vllm/entrypoints/serve/render/serving.py +++ b/vllm/entrypoints/serve/render/serving.py @@ -1,5 +1,6 @@ # SPDX-License-Identifier: Apache-2.0 # SPDX-FileCopyrightText: Copyrig...	[ "vllm/entrypoints/serve/render/serving.py" ]	[ { "comment": "Can we reuse any of the logic for building the choices from the serving chat/completions code?", "path": "vllm/entrypoints/serve/render/serving.py", "hunk": "@@ -62,6 +80,90 @@\n logger = init_logger(__name__)\n \n \n+def _resolve_logprobs(\n+ logprobs: ChatCompletionLogProbs, tokenizer...		true
vllm-project/vllm	45,489	issue_to_patch		[CI] Wait for SSL cert refresher events in the test	This PR fixes a rare failure in the AMD API server job: ```text AMD: Entrypoints Integration (API Server) (mi325_1) tests/entrypoints/serve/utils/test_ssl_cert_refresher.py::test_ssl_refresher ``` Buildkite: https://buildkite.com/vllm/ci/builds/71260/canvas?sid=019eb357-0345-44d5-a052-89ed36249172&tab=output ...	17ee5b1ac5dd61fa89bc4321ef54b0a790a45db3	c9bf4c6d0ea9ab9da5baef8425139c51f0953fac		[ "tests/entrypoints/serve/utils/test_ssl_cert_refresher.py" ]	[]	diff --git a/tests/entrypoints/serve/utils/test_ssl_cert_refresher.py b/tests/entrypoints/serve/utils/test_ssl_cert_refresher.py index 57a856ce118f..8f5251374a6b 100644 --- a/tests/entrypoints/serve/utils/test_ssl_cert_refresher.py +++ b/tests/entrypoints/serve/utils/test_ssl_cert_refresher.py @@ -41,6 +41,28 @@ def to...	true
vllm-project/vllm	42,700	issue_to_patch	[Bug]: forced to hit `Fast` suffix deprecation from `qwen3_vl` import ### Your current environment <details> <summary>The output of <code>python collect_env.py</code></summary> ```text INFO 05-14 23:02:56 [nixl_utils.py:20] Setting UCX_RCACHE_MAX_UNRELEASED to '1024' to avoid a rare memory leak in UCX when using NIX...	[Bugfix] Replace deprecated Qwen2VLImageProcessorFast with Qwen2VLImageProcessor	## Purpose Closes #42688. transformers#43514 (released in transformers 5.4.0) deprecated the `Fast` suffix for image processors. Importing `qwen3_vl.py` directly, or transitively from any module that touches it, now eats a deprecation warning on every load: ``` [transformers] `Qwen2VLImageProcessorFast` is deprecated...	c38bed4248e97e5ed981569777d035d31ace5368	4998dde2056fdfd99ac6a3bc1228376f63548302	diff --git a/vllm/model_executor/models/qwen3_vl.py b/vllm/model_executor/models/qwen3_vl.py index 7df44dda590a..f59c086cee90 100644 --- a/vllm/model_executor/models/qwen3_vl.py +++ b/vllm/model_executor/models/qwen3_vl.py @@ -34,7 +34,7 @@ import torch.nn as nn import torch.nn.functional as F from transformers impo...	[ "vllm/model_executor/models/qwen3_vl.py" ]	[]		true
vllm-project/vllm	45,163	issue_to_patch		[Model] Add DiffusionGemma Support	See: https://recipes.vllm.ai/Google/diffusiongemma-26B-A4B-it Docker images are available under: `vllm-openai:gemma-cu130`	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/benchmarks/kernels/benchmark_moe.py b/benchmarks/kernels/benchmark_moe.py index f885b1e09520..5d0876f91252 100644 --- a/benchmarks/kernels/benchmark_moe.py +++ b/benchmarks/kernels/benchmark_moe.py @@ -792,6 +792,12 @@ def get_model_params(config): topk = text_config.num_experts_per_tok i...	[ "benchmarks/kernels/benchmark_moe.py", "cmake/external_projects/vllm_flash_attn.cmake", "docs/design/attention_backends.md", "tests/kernels/attention/test_mixed_causal_attn.py", "tests/models/registry.py", "tests/models/utils.py", "tests/tool_parsers/test_gemma4_tool_parser.py", "tests/v1/cudagraph/te...	[ { "comment": "Is there a reason for hardcoding this constant? ", "path": "vllm/config/diffusion.py", "hunk": "@@ -0,0 +1,25 @@\n+# SPDX-License-Identifier: Apache-2.0\n+# SPDX-FileCopyrightText: Copyright contributors to the vLLM project\n+\"\"\"Configuration for discrete diffusion (dLLM) models.\"\"\"\...	diff --git a/tests/kernels/attention/test_mixed_causal_attn.py b/tests/kernels/attention/test_mixed_causal_attn.py new file mode 100644 index 000000000000..5343f701f283 --- /dev/null +++ b/tests/kernels/attention/test_mixed_causal_attn.py @@ -0,0 +1,318 @@ +# SPDX-License-Identifier: Apache-2.0 +# SPDX-FileCopyrightTex...	true
vllm-project/vllm	45,163	comment_to_fix		[Model] Add DiffusionGemma Support	Is there a reason for hardcoding this constant?	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/vllm/config/diffusion.py b/vllm/config/diffusion.py new file mode 100644 index 000000000000..6f59c40a8366 --- /dev/null +++ b/vllm/config/diffusion.py @@ -0,0 +1,26 @@ +# SPDX-License-Identifier: Apache-2.0 +# SPDX-FileCopyrightText: Copyright contributors to the vLLM project +"""Configuration for discrete...	[ "vllm/config/diffusion.py" ]	[ { "comment": "Is there a reason for hardcoding this constant? ", "path": "vllm/config/diffusion.py", "hunk": "@@ -0,0 +1,25 @@\n+# SPDX-License-Identifier: Apache-2.0\n+# SPDX-FileCopyrightText: Copyright contributors to the vLLM project\n+\"\"\"Configuration for discrete diffusion (dLLM) models.\"\"\"\...		true
vllm-project/vllm	45,163	comment_to_fix		[Model] Add DiffusionGemma Support	I don't think this design doc is in the diff	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/vllm/model_executor/models/diffusion_gemma.py b/vllm/model_executor/models/diffusion_gemma.py new file mode 100644 index 000000000000..91dd5e6b6a5f --- /dev/null +++ b/vllm/model_executor/models/diffusion_gemma.py @@ -0,0 +1,1363 @@ +# SPDX-License-Identifier: Apache-2.0 +# SPDX-FileCopyrightText: Copyrigh...	[ "vllm/model_executor/models/diffusion_gemma.py" ]	[ { "comment": "I don't think this design doc is in the diff", "path": "vllm/model_executor/models/diffusion_gemma.py", "hunk": "@@ -0,0 +1,1369 @@\n+# SPDX-License-Identifier: Apache-2.0\n+# SPDX-FileCopyrightText: Copyright contributors to the vLLM project\n+\"\"\"DiffusionGemma model, ModelState, and S...		true
vllm-project/vllm	45,163	comment_to_fix		[Model] Add DiffusionGemma Support	```suggestion ``` nit	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/vllm/model_executor/models/diffusion_gemma.py b/vllm/model_executor/models/diffusion_gemma.py new file mode 100644 index 000000000000..91dd5e6b6a5f --- /dev/null +++ b/vllm/model_executor/models/diffusion_gemma.py @@ -0,0 +1,1363 @@ +# SPDX-License-Identifier: Apache-2.0 +# SPDX-FileCopyrightText: Copyrigh...	[ "vllm/model_executor/models/diffusion_gemma.py" ]	[ { "comment": "```suggestion\n```\nnit", "path": "vllm/model_executor/models/diffusion_gemma.py", "hunk": "@@ -0,0 +1,1367 @@\n+# SPDX-License-Identifier: Apache-2.0\n+# SPDX-FileCopyrightText: Copyright contributors to the vLLM project\n+\"\"\"DiffusionGemma model, ModelState, and Sampler for vLLM.\n+\n...		true
vllm-project/vllm	45,163	comment_to_fix		[Model] Add DiffusionGemma Support	I tried out this branch on a DGX Spark today - overlaid this branch (c0b75dc) onto the arm64 nightly image, and ran the serve command from the docs with `--attention-backend TRITON_ATTN`. Weights loaded, but the engine died during warmup on the first dummy forward pass with: ``` triton.runtime.errors.OutOfResources: o...	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/vllm/v1/attention/ops/triton_unified_attention.py b/vllm/v1/attention/ops/triton_unified_attention.py index 56f1d1c1d084..f39e44286be4 100644 --- a/vllm/v1/attention/ops/triton_unified_attention.py +++ b/vllm/v1/attention/ops/triton_unified_attention.py @@ -215,6 +215,9 @@ def kernel_unified_attention( ...	[ "vllm/v1/attention/ops/triton_unified_attention.py" ]	[ { "comment": "I tried out this branch on a DGX Spark today - overlaid this branch (c0b75dc) onto the arm64 nightly image, and ran the serve command from the docs with `--attention-backend TRITON_ATTN`. Weights loaded, but the engine died during warmup on the first dummy forward pass with:\n\n```\ntriton.runtime...		true
vllm-project/vllm	45,163	comment_to_fix		[Model] Add DiffusionGemma Support	Is this pythonic? It's a new pattern to me, can't tell if it's ugly or I've just never seen it before	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/vllm/model_executor/models/diffusion_gemma.py b/vllm/model_executor/models/diffusion_gemma.py new file mode 100644 index 000000000000..91dd5e6b6a5f --- /dev/null +++ b/vllm/model_executor/models/diffusion_gemma.py @@ -0,0 +1,1363 @@ +# SPDX-License-Identifier: Apache-2.0 +# SPDX-FileCopyrightText: Copyrigh...	[ "vllm/model_executor/models/diffusion_gemma.py" ]	[ { "comment": "Is this pythonic? It's a new pattern to me, can't tell if it's ugly or I've just never seen it before", "path": "vllm/model_executor/models/diffusion_gemma.py", "hunk": "@@ -0,0 +1,1363 @@\n+# SPDX-License-Identifier: Apache-2.0\n+# SPDX-FileCopyrightText: Copyright contributors to the vLL...		true
vllm-project/vllm	45,163	comment_to_fix		[Model] Add DiffusionGemma Support	Are these read somewhere?	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/vllm/model_executor/models/diffusion_gemma.py b/vllm/model_executor/models/diffusion_gemma.py new file mode 100644 index 000000000000..91dd5e6b6a5f --- /dev/null +++ b/vllm/model_executor/models/diffusion_gemma.py @@ -0,0 +1,1363 @@ +# SPDX-License-Identifier: Apache-2.0 +# SPDX-FileCopyrightText: Copyrigh...	[ "vllm/model_executor/models/diffusion_gemma.py" ]	[ { "comment": "Are these read somewhere?", "path": "vllm/model_executor/models/diffusion_gemma.py", "hunk": "@@ -0,0 +1,1363 @@\n+# SPDX-License-Identifier: Apache-2.0\n+# SPDX-FileCopyrightText: Copyright contributors to the vLLM project\n+\"\"\"DiffusionGemma model, ModelState, and Sampler for vLLM.\n+...		true
vllm-project/vllm	45,163	comment_to_fix		[Model] Add DiffusionGemma Support	```suggestion "google/diffusiongemma-26B-A4B-it", ``` Seems like this was a placeholder?	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/tests/models/registry.py b/tests/models/registry.py index d2d2794962fc..9efe4966292f 100644 --- a/tests/models/registry.py +++ b/tests/models/registry.py @@ -901,6 +901,10 @@ def check_available_online( ), "FuyuForCausalLM": _HfExamplesInfo("adept/fuyu-8b"), "Gemma3ForConditionalGeneration":...	[ "tests/models/registry.py" ]	[ { "comment": "```suggestion\n \"google/diffusiongemma-26B-A4B-it\",\n```\nSeems like this was a placeholder?", "path": "tests/models/registry.py", "hunk": "@@ -901,6 +901,10 @@ def check_available_online(\n ),\n \"FuyuForCausalLM\": _HfExamplesInfo(\"adept/fuyu-8b\"),\n \"Gemma3ForCon...		true
vllm-project/vllm	45,163	comment_to_fix		[Model] Add DiffusionGemma Support	another reference to "HF reference" that we may want to strip	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/vllm/model_executor/models/diffusion_gemma.py b/vllm/model_executor/models/diffusion_gemma.py new file mode 100644 index 000000000000..91dd5e6b6a5f --- /dev/null +++ b/vllm/model_executor/models/diffusion_gemma.py @@ -0,0 +1,1363 @@ +# SPDX-License-Identifier: Apache-2.0 +# SPDX-FileCopyrightText: Copyrigh...	[ "vllm/model_executor/models/diffusion_gemma.py" ]	[ { "comment": "another reference to \"HF reference\" that we may want to strip", "path": "vllm/model_executor/models/diffusion_gemma.py", "hunk": "@@ -0,0 +1,1359 @@\n+# SPDX-License-Identifier: Apache-2.0\n+# SPDX-FileCopyrightText: Copyright contributors to the vLLM project\n+\"\"\"DiffusionGemma model...		true
vllm-project/vllm	45,163	comment_to_fix		[Model] Add DiffusionGemma Support	reference to "RC0.1"	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/vllm/model_executor/models/diffusion_gemma.py b/vllm/model_executor/models/diffusion_gemma.py new file mode 100644 index 000000000000..91dd5e6b6a5f --- /dev/null +++ b/vllm/model_executor/models/diffusion_gemma.py @@ -0,0 +1,1363 @@ +# SPDX-License-Identifier: Apache-2.0 +# SPDX-FileCopyrightText: Copyrigh...	[ "vllm/model_executor/models/diffusion_gemma.py" ]	[ { "comment": "reference to \"RC0.1\"", "path": "vllm/model_executor/models/diffusion_gemma.py", "hunk": "@@ -0,0 +1,1359 @@\n+# SPDX-License-Identifier: Apache-2.0\n+# SPDX-FileCopyrightText: Copyright contributors to the vLLM project\n+\"\"\"DiffusionGemma model, ModelState, and Sampler for vLLM.\n+\n+...		true
vllm-project/vllm	45,163	comment_to_fix		[Model] Add DiffusionGemma Support	```suggestion ```	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/vllm/model_executor/models/diffusion_gemma.py b/vllm/model_executor/models/diffusion_gemma.py new file mode 100644 index 000000000000..91dd5e6b6a5f --- /dev/null +++ b/vllm/model_executor/models/diffusion_gemma.py @@ -0,0 +1,1363 @@ +# SPDX-License-Identifier: Apache-2.0 +# SPDX-FileCopyrightText: Copyrigh...	[ "vllm/model_executor/models/diffusion_gemma.py" ]	[ { "comment": "```suggestion\n```", "path": "vllm/model_executor/models/diffusion_gemma.py", "hunk": "@@ -0,0 +1,1359 @@\n+# SPDX-License-Identifier: Apache-2.0\n+# SPDX-FileCopyrightText: Copyright contributors to the vLLM project\n+\"\"\"DiffusionGemma model, ModelState, and Sampler for vLLM.\n+\n+Sing...		true
vllm-project/vllm	45,163	comment_to_fix		[Model] Add DiffusionGemma Support	remove this before landing?	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/vllm/model_executor/models/diffusion_gemma.py b/vllm/model_executor/models/diffusion_gemma.py new file mode 100644 index 000000000000..91dd5e6b6a5f --- /dev/null +++ b/vllm/model_executor/models/diffusion_gemma.py @@ -0,0 +1,1363 @@ +# SPDX-License-Identifier: Apache-2.0 +# SPDX-FileCopyrightText: Copyrigh...	[ "vllm/model_executor/models/diffusion_gemma.py" ]	[ { "comment": "remove this before landing?", "path": "vllm/model_executor/models/diffusion_gemma.py", "hunk": "@@ -0,0 +1,1359 @@\n+# SPDX-License-Identifier: Apache-2.0\n+# SPDX-FileCopyrightText: Copyright contributors to the vLLM project\n+\"\"\"DiffusionGemma model, ModelState, and Sampler for vLLM.\...		true
vllm-project/vllm	45,163	comment_to_fix		[Model] Add DiffusionGemma Support	Is this right? `prompt_len = 2 * decode_query_len`?	2ec6594db9c2397cc3c315ff3ce3b38e0d40e176	d42ae12f36d5a9136815832fc108d0f6873320e8	diff --git a/vllm/v1/worker/gpu/warmup.py b/vllm/v1/worker/gpu/warmup.py index 83d87c74a4a0..0da845a0673d 100644 --- a/vllm/v1/worker/gpu/warmup.py +++ b/vllm/v1/worker/gpu/warmup.py @@ -30,17 +30,18 @@ def warmup_kernels( pipeline parallel coordination. The first iteration simulates a prefill with requests...	[ "vllm/v1/worker/gpu/warmup.py" ]	[ { "comment": "Is this right? `prompt_len = 2 * decode_query_len`?", "path": "vllm/v1/worker/gpu/warmup.py", "hunk": "@@ -30,17 +30,18 @@ def warmup_kernels(\n pipeline parallel coordination.\n \n The first iteration simulates a prefill with requests of\n- 2 + num_spec_steps prompt tokens each...		true
vllm-project/vllm	45,376	issue_to_patch	[Bug] /v1/messages streaming: message_start drops type/role (exclude_unset) — strict Anthropic SDK clients reject the stream Follow-up from PR #45163 discussion, opened at @bbrowning's request. ### Environment - vLLM: PR #45163 branch `dgemma` @ `97de79ef3` (editable install, precompiled binaries from nightly `0...	[Bugfix] Set type/role explicitly in streaming message_start event	## Purpose Fix #45367: the `/v1/messages` streaming path builds the `message_start` event without explicitly setting the nested message's `type`/`role`, then serializes it with `model_dump_json(exclude_unset=True)`. Since `AnthropicMessagesResponse` declares `type: Literal["message"] = "message"` and `role: Literal["a...	fe042382925000e5adfe530a1cc2b91d7a125fd5	fdb48ff06c168513b710ecdc074be87769d313a1	diff --git a/vllm/entrypoints/anthropic/serving.py b/vllm/entrypoints/anthropic/serving.py index 266a3154212e..3dce10695b5d 100644 --- a/vllm/entrypoints/anthropic/serving.py +++ b/vllm/entrypoints/anthropic/serving.py @@ -678,6 +678,13 @@ def stop_and_flush() -> list[str]: type="messag...	[ "tests/entrypoints/anthropic/test_anthropic_messages_conversion.py", "vllm/entrypoints/anthropic/serving.py" ]	[]	diff --git a/tests/entrypoints/anthropic/test_anthropic_messages_conversion.py b/tests/entrypoints/anthropic/test_anthropic_messages_conversion.py index 21d5154c6756..3edc09801e8a 100644 --- a/tests/entrypoints/anthropic/test_anthropic_messages_conversion.py +++ b/tests/entrypoints/anthropic/test_anthropic_messages_con...	true
vllm-project/vllm	45,347	issue_to_patch		[BugFix] Avoid prematurely freeing cached mm encoder outputs	Can happen in async scheduling + spec decoding case. Hopefully addresses https://github.com/vllm-project/vllm/issues/38551. Claude was used for the tests.	4bc83323f2ea8e85c87ae5fb5ff2d792a8f61f9d	634442b47f92629738b1f663e3a32b37ae49e7dd	diff --git a/vllm/v1/core/sched/scheduler.py b/vllm/v1/core/sched/scheduler.py index e61b9991b210..392151df4f04 100644 --- a/vllm/v1/core/sched/scheduler.py +++ b/vllm/v1/core/sched/scheduler.py @@ -1750,9 +1750,14 @@ def _free_encoder_inputs(self, request: Request) -> None: # we know we're done with t...	[ "tests/v1/core/test_scheduler.py", "vllm/v1/core/sched/scheduler.py" ]	[]	diff --git a/tests/v1/core/test_scheduler.py b/tests/v1/core/test_scheduler.py index 4d652beec81b..48ca078bfd12 100644 --- a/tests/v1/core/test_scheduler.py +++ b/tests/v1/core/test_scheduler.py @@ -4351,6 +4351,180 @@ def test_eagle3_mm_encoder_cache_with_shift(): ) +def test_free_encoder_inputs_respects_unco...	true
vllm-project/vllm	45,322	issue_to_patch		[Perf] Use native DSA indexer decode path for next_n > 2 on SM100	## Purpose On SM100, the DeepGEMM paged MQA logits kernels support any `next_n` natively (multi-atom decomposition, FP8 and FP4 indexer caches), so the FP4 indexer cache no longer needs the flattening fallback for `next_n > 2` — flattening is kept only outside the SM100 family, where the FP8 kernel requires `next_n ...	d6fd7ce8daccb290e10c03cbf017d1eb65be4487	7b3c9c0edc22f4e3938fc74136f4cf3545c100c3	diff --git a/vllm/v1/attention/backends/mla/indexer.py b/vllm/v1/attention/backends/mla/indexer.py index 2870ec9a15c0..0bc7ca7aa414 100644 --- a/vllm/v1/attention/backends/mla/indexer.py +++ b/vllm/v1/attention/backends/mla/indexer.py @@ -231,8 +231,6 @@ def get_max_prefill_buffer_size(vllm_config: VllmConfig): clas...	[ "vllm/v1/attention/backends/mla/indexer.py" ]	[]		true
vllm-project/vllm	45,401	issue_to_patch		[Bugfix][CPU] Don't build triton-cpu on arm64 release image	## Summary The arm64 CPU release image build fails while compiling `triton-cpu`: ``` triton-cpu/third_party/cpu/runtime/cpu_runtime.cpp:33:3: error: '_Float16' does not name a type; did you mean '_FLOAT16'? ninja: build stopped: subcommand failed. ERROR: failed to solve: ... exit code: 2 ``` (seen in the v0.23.0 r...	f715f25f290d2a610b142656eb0a4c99ae0d110d	8bc88ca363a62bbe784b5601b93b560cc3e72813	diff --git a/docker/Dockerfile.cpu b/docker/Dockerfile.cpu index 4df401395fab..61bad68b4425 100644 --- a/docker/Dockerfile.cpu +++ b/docker/Dockerfile.cpu @@ -168,6 +168,12 @@ RUN --mount=type=cache,target=/root/.cache/uv \ ######################### TRITON-CPU BUILD IMAGE ######################### FROM base AS vllm-t...	[ "docker/Dockerfile.cpu" ]	[]		true
vllm-project/vllm	45,103	issue_to_patch		[ROCm][DSV4][Perf] Fuse inverse-RoPE and cache bf16 wo_a in o-projection	## Purpose The ROCm DeepSeek V4 o-projection (rocm_inv_rope_einsum, run once per decode layer) ran the inverse GPT-J RoPE as ~10 small PyTorch kernels (clone, index_select, 2x repeat_interleave, neg, stack, cat, casts) and re-dequantized the static fp8 wo_a weight every step (fp8->fp32->*scale ->bf16), which showed u...	9ff278b1d2304ae606a13e8eebab75fcde2d2281	ec930ccdb2bd7c2117f208d5d6fc5cfb89ba5aed	diff --git a/vllm/v1/attention/ops/rocm_aiter_mla_sparse.py b/vllm/v1/attention/ops/rocm_aiter_mla_sparse.py index 8104e808f670..c38a4780f784 100644 --- a/vllm/v1/attention/ops/rocm_aiter_mla_sparse.py +++ b/vllm/v1/attention/ops/rocm_aiter_mla_sparse.py @@ -874,72 +874,113 @@ def _expand_2d_block_scales( return s...	[ "tests/kernels/attention/test_rocm_triton_attn_dsv4.py", "vllm/v1/attention/ops/rocm_aiter_mla_sparse.py" ]	[ { "comment": "I have a small question. in the UT we're driving the fake rotary. And the `test_rocm_inv_rope_einsum` tests, both fused, and fallback, uses the fake rotary. But we never go against the `DeepseekV4ScalingRotaryEmbedding` as you commented here. Would it be worth testing the official DeepseekV4...	diff --git a/tests/kernels/attention/test_rocm_triton_attn_dsv4.py b/tests/kernels/attention/test_rocm_triton_attn_dsv4.py index f328f339332e..daf73b82e614 100644 --- a/tests/kernels/attention/test_rocm_triton_attn_dsv4.py +++ b/tests/kernels/attention/test_rocm_triton_attn_dsv4.py @@ -515,3 +515,218 @@ def test_sparse...	true
vllm-project/vllm	45,103	comment_to_fix		[ROCm][DSV4][Perf] Fuse inverse-RoPE and cache bf16 wo_a in o-projection	I have a small question. in the UT we're driving the fake rotary. And the `test_rocm_inv_rope_einsum` tests, both fused, and fallback, uses the fake rotary. But we never go against the `DeepseekV4ScalingRotaryEmbedding` as you commented here. Would it be worth testing the official DeepseekV4ScalingRotaryEmbedding...	9ff278b1d2304ae606a13e8eebab75fcde2d2281	ec930ccdb2bd7c2117f208d5d6fc5cfb89ba5aed	diff --git a/tests/kernels/attention/test_rocm_triton_attn_dsv4.py b/tests/kernels/attention/test_rocm_triton_attn_dsv4.py index f328f339332e..daf73b82e614 100644 --- a/tests/kernels/attention/test_rocm_triton_attn_dsv4.py +++ b/tests/kernels/attention/test_rocm_triton_attn_dsv4.py @@ -515,3 +515,218 @@ def test_sparse...	[ "tests/kernels/attention/test_rocm_triton_attn_dsv4.py" ]	[ { "comment": "I have a small question. in the UT we're driving the fake rotary. And the `test_rocm_inv_rope_einsum` tests, both fused, and fallback, uses the fake rotary. But we never go against the `DeepseekV4ScalingRotaryEmbedding` as you commented here. Would it be worth testing the official DeepseekV4...		true
vllm-project/vllm	45,103	comment_to_fix		[ROCm][DSV4][Perf] Fuse inverse-RoPE and cache bf16 wo_a in o-projection	`rocm_inv_rope_einsum` is only used for DSv4 and `_can_use_fused_inv_rope(rotary_emb, o, rope_head_dim)` is always `True` for both Flash and Pro models We should just replace `_apply_inv_rope_ref`	9ff278b1d2304ae606a13e8eebab75fcde2d2281	ec930ccdb2bd7c2117f208d5d6fc5cfb89ba5aed	diff --git a/vllm/v1/attention/ops/rocm_aiter_mla_sparse.py b/vllm/v1/attention/ops/rocm_aiter_mla_sparse.py index 8104e808f670..c38a4780f784 100644 --- a/vllm/v1/attention/ops/rocm_aiter_mla_sparse.py +++ b/vllm/v1/attention/ops/rocm_aiter_mla_sparse.py @@ -874,72 +874,113 @@ def _expand_2d_block_scales( return s...	[ "vllm/v1/attention/ops/rocm_aiter_mla_sparse.py" ]	[ { "comment": "`rocm_inv_rope_einsum` is only used for DSv4 and `_can_use_fused_inv_rope(rotary_emb, o, rope_head_dim)` is always `True` for both Flash and Pro models\n\nWe should just replace `_apply_inv_rope_ref`", "path": "vllm/v1/attention/ops/rocm_aiter_mla_sparse.py", "hunk": "@@ -951,11 +1020,42 @...		true
vllm-project/vllm	45,103	comment_to_fix		[ROCm][DSV4][Perf] Fuse inverse-RoPE and cache bf16 wo_a in o-projection	We don't need this function anymore since it is always evaluated to true for DeepSeekV4 Models.	9ff278b1d2304ae606a13e8eebab75fcde2d2281	ec930ccdb2bd7c2117f208d5d6fc5cfb89ba5aed	diff --git a/vllm/v1/attention/ops/rocm_aiter_mla_sparse.py b/vllm/v1/attention/ops/rocm_aiter_mla_sparse.py index 8104e808f670..c38a4780f784 100644 --- a/vllm/v1/attention/ops/rocm_aiter_mla_sparse.py +++ b/vllm/v1/attention/ops/rocm_aiter_mla_sparse.py @@ -874,72 +874,113 @@ def _expand_2d_block_scales( return s...	[ "vllm/v1/attention/ops/rocm_aiter_mla_sparse.py" ]	[ { "comment": "We don't need this function anymore since it is always evaluated to true for DeepSeekV4 Models.", "path": "vllm/v1/attention/ops/rocm_aiter_mla_sparse.py", "hunk": "@@ -924,22 +893,122 @@ def _apply_inv_rope_ref(\n return _apply_gptj_inv_rope_ref(x, positions, rotary_emb.cos_sin_cache,...		true
vllm-project/vllm	44,260	issue_to_patch		Add the QuantizedActivation linear-kernel contract	## Purpose First part of #43224 for quant fusion support. Introduce `QuantizedActivation`: a pre-quantized activation that fused kernel can hand directly to a linear so the linear skips its own input quant. The contract lives in `fusion/quant_activation.py` with two helpers: 1. `expose_input_quant_key`...	cc640ee8bc1e61d333ecec039b2e3f143f9d4066	f5f281a0e66e8bd884177e539030e3391911eaf3	diff --git a/vllm/model_executor/kernels/linear/base.py b/vllm/model_executor/kernels/linear/base.py index 4e9b89bb3ff1..416b6ea1c1b6 100644 --- a/vllm/model_executor/kernels/linear/base.py +++ b/vllm/model_executor/kernels/linear/base.py @@ -8,6 +8,8 @@ import torch from typing_extensions import Self +from vllm.mo...	[ ".buildkite/test_areas/quantization.yaml", "tests/fusion/__init__.py", "tests/fusion/test_quant_activation_contract.py", "vllm/model_executor/kernels/linear/base.py", "vllm/model_executor/kernels/linear/nvfp4/base.py", "vllm/model_executor/kernels/linear/nvfp4/flashinfer.py", "vllm/model_executor/kernel...	[ { "comment": "We can instead add a static method to the interface called `apply_mm` (for lack of a better name) that bypasses the quantization operation entirely. By default, this method can raise a `NotImplementedError`, ensuring that kernels modifying the layer don't inadvertently expose it. The apply_mm meth...	diff --git a/.buildkite/test_areas/quantization.yaml b/.buildkite/test_areas/quantization.yaml index 8a9a36da4481..a92ee24f4aac 100644 --- a/.buildkite/test_areas/quantization.yaml +++ b/.buildkite/test_areas/quantization.yaml @@ -21,6 +21,18 @@ steps: - uv pip install --system conch-triton-kernels - VLLM_TEST_FO...	true
vllm-project/vllm	45,295	issue_to_patch		[Kernel] Consolidate Marlin thread-tile padding across all dense Marlin paths	## Purpose Marlin GEMM/repack require the rank-local (N, K) to match a thread-tile family: (n%64, k%128) or (n%128, k%64). TP sharding can produce shapes satisfying neither — FP4/FP8 paths crash at repack (e.g. `nvidia/NVIDIA-Nemotron-3-Super-120B-A12B-NVFP4` at TP4) and GPTQ/AWQ/WNA16 reject Marlin and fall back to s...	0cd9b7af25cd3c47a84e2164392f755415c74fd2	5f865be6e2c2ecffcf81943f3950745da4fb9b8c	diff --git a/vllm/model_executor/kernels/linear/mixed_precision/marlin.py b/vllm/model_executor/kernels/linear/mixed_precision/marlin.py index eb14f9ec378c..87ed8d1b582f 100644 --- a/vllm/model_executor/kernels/linear/mixed_precision/marlin.py +++ b/vllm/model_executor/kernels/linear/mixed_precision/marlin.py @@ -13,6 ...	[ "tests/kernels/quantization/test_marlin_tile_padding.py", "vllm/model_executor/kernels/linear/mixed_precision/marlin.py", "vllm/model_executor/layers/quantization/awq_marlin.py", "vllm/model_executor/layers/quantization/modelopt.py", "vllm/model_executor/layers/quantization/utils/marlin_utils.py", "vllm/m...	[]	diff --git a/tests/kernels/quantization/test_marlin_tile_padding.py b/tests/kernels/quantization/test_marlin_tile_padding.py new file mode 100644 index 000000000000..62b18d88ac53 --- /dev/null +++ b/tests/kernels/quantization/test_marlin_tile_padding.py @@ -0,0 +1,470 @@ +# SPDX-License-Identifier: Apache-2.0 +# SPDX-F...	true
vllm-project/vllm	42,667	issue_to_patch		[Model Runner v2] Migration from v1 to v2, with Qwen and DSv2 MOE models [3/N]	## Purpose Make progress for https://github.com/vllm-project/vllm/issues/41286 ## Test Covered in CI	272c16953eac7c46db7719d284d8a0ff19e63446	7a77c30a01b049d4e9847424c1c5073ce54a882f	diff --git a/vllm/config/vllm.py b/vllm/config/vllm.py index 890d2b72e317..6122476abb8e 100644 --- a/vllm/config/vllm.py +++ b/vllm/config/vllm.py @@ -67,9 +67,11 @@ DEFAULT_V2_MODEL_RUNNER_ARCHITECTURES = frozenset( { + "Qwen3ForCausalLM", + "DeepseekV2ForCausalLM", + "Qwen2MoeForCausalLM"...	[ "tests/test_config.py", "vllm/config/vllm.py" ]	[]	diff --git a/tests/test_config.py b/tests/test_config.py index b78570e54fbd..918f89beb8fc 100644 --- a/tests/test_config.py +++ b/tests/test_config.py @@ -122,8 +122,58 @@ def test_v2_model_runner_env_tri_state(monkeypatch, env_value, expected): ), ( SimpleNamespace( - mode...	true
vllm-project/vllm	39,336	issue_to_patch		[Attention] Improve attention benchmarks: configs and profiling	## Purpose - Switch timing to Triton `do_bench`/`do_bench_cudagraph` (replaces manual CUDA-event timing; `--warmup-ms` replaces `--repeats`/`--warmup-iters`) - Add `--ncu-profile` for Nsight Compute profiling with source correlation - Support multi-parameter sweeps (override several model dims per sweep entry) - ...	b7f9b6ab271faa621f4cc438fd5ea7ecaf72db8e	8c77a5de2a8d342382b972bc90528381f3313314	diff --git a/benchmarks/attention_benchmarks/README.md b/benchmarks/attention_benchmarks/README.md index afce34433167..944ceb91af91 100644 --- a/benchmarks/attention_benchmarks/README.md +++ b/benchmarks/attention_benchmarks/README.md @@ -108,7 +108,6 @@ python benchmark.py \ --backends flash triton flashinfer \ ...	[ "benchmarks/attention_benchmarks/README.md", "benchmarks/attention_benchmarks/benchmark.py", "benchmarks/attention_benchmarks/common.py", "benchmarks/attention_benchmarks/configs/mla_decode.yaml", "benchmarks/attention_benchmarks/configs/mla_mixed_batch.yaml", "benchmarks/attention_benchmarks/configs/mla_...	[ { "comment": "![high](https://www.gstatic.com/codereviewagent/high-priority.svg)\n\nThe `ncu` re-execution logic is currently placed before the YAML configuration is loaded. This means that if `ncu_profile: true` is specified in a YAML config file but not passed as a CLI argument, the script will not automatica...		true
vllm-project/vllm	39,336	comment_to_fix		[Attention] Improve attention benchmarks: configs and profiling	![high](https://www.gstatic.com/codereviewagent/high-priority.svg) The `ncu` re-execution logic is currently placed before the YAML configuration is loaded. This means that if `ncu_profile: true` is specified in a YAML config file but not passed as a CLI argument, the script will not automatically re-execute under `nc...	b7f9b6ab271faa621f4cc438fd5ea7ecaf72db8e	8c77a5de2a8d342382b972bc90528381f3313314	diff --git a/benchmarks/attention_benchmarks/benchmark.py b/benchmarks/attention_benchmarks/benchmark.py index c4c331f7f8ef..de7cf04d81e2 100644 --- a/benchmarks/attention_benchmarks/benchmark.py +++ b/benchmarks/attention_benchmarks/benchmark.py @@ -26,6 +26,9 @@ """ import argparse +import os +import shutil +impo...	[ "benchmarks/attention_benchmarks/benchmark.py" ]	[ { "comment": "![high](https://www.gstatic.com/codereviewagent/high-priority.svg)\n\nThe `ncu` re-execution logic is currently placed before the YAML configuration is loaded. This means that if `ncu_profile: true` is specified in a YAML config file but not passed as a CLI argument, the script will not automatica...		true
vllm-project/vllm	39,336	comment_to_fix		[Attention] Improve attention benchmarks: configs and profiling	![high](https://www.gstatic.com/codereviewagent/high-priority.svg) When `value` is a dictionary (multi-parameter sweep), the default `label_format` (which is `"{backend}_{param_name}_{value}"`) will cause a `KeyError` because `param_name` is not passed to the `format` call. Including `param_name` in the format argumen...	b7f9b6ab271faa621f4cc438fd5ea7ecaf72db8e	8c77a5de2a8d342382b972bc90528381f3313314	diff --git a/benchmarks/attention_benchmarks/common.py b/benchmarks/attention_benchmarks/common.py index 74d9e239725d..106d7854804f 100644 --- a/benchmarks/attention_benchmarks/common.py +++ b/benchmarks/attention_benchmarks/common.py @@ -15,6 +15,8 @@ from rich.console import Console from rich.table import Table +...	[ "benchmarks/attention_benchmarks/common.py" ]	[ { "comment": "![high](https://www.gstatic.com/codereviewagent/high-priority.svg)\n\nWhen `value` is a dictionary (multi-parameter sweep), the default `label_format` (which is `\"{backend}_{param_name}_{value}\"`) will cause a `KeyError` because `param_name` is not passed to the `format` call. Including `param_n...		true
vllm-project/vllm	39,336	comment_to_fix		[Attention] Improve attention benchmarks: configs and profiling	![high](https://www.gstatic.com/codereviewagent/high-priority.svg) If `param_name` is `None` (which is allowed for multi-parameter sweeps) and `value` is not a dictionary, this will attempt to set `config_args[None]`, which is likely unintended and will lead to a `TypeError` when instantiating `BenchmarkConfig`. An ex...	b7f9b6ab271faa621f4cc438fd5ea7ecaf72db8e	8c77a5de2a8d342382b972bc90528381f3313314	diff --git a/benchmarks/attention_benchmarks/common.py b/benchmarks/attention_benchmarks/common.py index 74d9e239725d..106d7854804f 100644 --- a/benchmarks/attention_benchmarks/common.py +++ b/benchmarks/attention_benchmarks/common.py @@ -15,6 +15,8 @@ from rich.console import Console from rich.table import Table +...	[ "benchmarks/attention_benchmarks/common.py" ]	[ { "comment": "![high](https://www.gstatic.com/codereviewagent/high-priority.svg)\n\nIf `param_name` is `None` (which is allowed for multi-parameter sweeps) and `value` is not a dictionary, this will attempt to set `config_args[None]`, which is likely unintended and will lead to a `TypeError` when instantiating ...		true
vllm-project/vllm	39,336	comment_to_fix		[Attention] Improve attention benchmarks: configs and profiling	![high](https://www.gstatic.com/codereviewagent/high-priority.svg) Calling `set_head_size_v` on the `backend_class` modifies global state for that backend. If `config.v_head_dim` is `None` in a subsequent benchmark run within the same process, the backend will continue to use the `v_head_dim` set by a previous run. Th...	b7f9b6ab271faa621f4cc438fd5ea7ecaf72db8e	8c77a5de2a8d342382b972bc90528381f3313314	diff --git a/benchmarks/attention_benchmarks/runner.py b/benchmarks/attention_benchmarks/runner.py index aa636cd9cb53..8cd20dced179 100644 --- a/benchmarks/attention_benchmarks/runner.py +++ b/benchmarks/attention_benchmarks/runner.py @@ -9,13 +9,20 @@ """ import logging +import statistics import types from conte...	[ "benchmarks/attention_benchmarks/runner.py" ]	[ { "comment": "![high](https://www.gstatic.com/codereviewagent/high-priority.svg)\n\nCalling `set_head_size_v` on the `backend_class` modifies global state for that backend. If `config.v_head_dim` is `None` in a subsequent benchmark run within the same process, the backend will continue to use the `v_head_dim` s...		true
vllm-project/vllm	39,336	comment_to_fix		[Attention] Improve attention benchmarks: configs and profiling	Will these all 0 results be added to final metrics? Maybe we should sweep them out	b7f9b6ab271faa621f4cc438fd5ea7ecaf72db8e	8c77a5de2a8d342382b972bc90528381f3313314	diff --git a/benchmarks/attention_benchmarks/mla_runner.py b/benchmarks/attention_benchmarks/mla_runner.py index abab1e2edbac..e63b524c71ba 100644 --- a/benchmarks/attention_benchmarks/mla_runner.py +++ b/benchmarks/attention_benchmarks/mla_runner.py @@ -8,6 +8,8 @@ needing full VllmConfig integration. """ +import ...	[ "benchmarks/attention_benchmarks/mla_runner.py" ]	[ { "comment": "Will these all 0 results be added to final metrics? Maybe we should sweep them out", "path": "benchmarks/attention_benchmarks/mla_runner.py", "hunk": "@@ -839,44 +843,35 @@ def forward_fn():\n )\n return results[0] if len(results) == 1 else tuple(results)\n \n- # War...		true
vllm-project/vllm	39,336	comment_to_fix		[Attention] Improve attention benchmarks: configs and profiling	Similar here	b7f9b6ab271faa621f4cc438fd5ea7ecaf72db8e	8c77a5de2a8d342382b972bc90528381f3313314	diff --git a/benchmarks/attention_benchmarks/runner.py b/benchmarks/attention_benchmarks/runner.py index aa636cd9cb53..8cd20dced179 100644 --- a/benchmarks/attention_benchmarks/runner.py +++ b/benchmarks/attention_benchmarks/runner.py @@ -9,13 +9,20 @@ """ import logging +import statistics import types from conte...	[ "benchmarks/attention_benchmarks/runner.py" ]	[ { "comment": "Similar here", "path": "benchmarks/attention_benchmarks/runner.py", "hunk": "@@ -407,52 +423,22 @@ def _run_single_benchmark(\n attn_metadata,\n output=out,\n )\n- torch.accelerator.synchronize()\n-\n- # Optionally capture a CUDA graph afte...		true
vllm-project/vllm	45,362	issue_to_patch		[ROCm] Bump Torch to 2.11	PyTorch 2.11 on ROCm CI build with this base: https://buildkite.com/vllm/amd-ci/builds/9408	3b8fc3fe6d4afe6680cfc96f5b15fccf4bfff46f	097f1918470fdc9026881a1fbdd625141c4ad4c8	diff --git a/docker/Dockerfile.rocm_base b/docker/Dockerfile.rocm_base index 208ce863f6b3..a3b2a539bd95 100644 --- a/docker/Dockerfile.rocm_base +++ b/docker/Dockerfile.rocm_base @@ -1,7 +1,7 @@ ARG BASE_IMAGE=rocm/dev-ubuntu-22.04:7.2.3-complete -ARG TRITON_BRANCH="ba5c1517" +ARG TRITON_BRANCH="0f380657" ARG TRITON_...	[ "docker/Dockerfile.rocm_base" ]	[]		true
vllm-project/vllm	45,431	issue_to_patch		[Refactor] Deprecate ResponsesParser wrapper, inline parsing into ParsableContext	## Purpose ResponsesParser was an unnecessary indirection layer between ParsableContext and Parser. It held state (response_messages, finish_reason) that logically belongs on ParsableContext, and its process() method was just three lines delegating to Parser.parse() + build_response_output_items(). Removing it simplif...	d6fd7ce8daccb290e10c03cbf017d1eb65be4487	4b96c47451c8715047fb0511e7a4b38ec1732ca1	diff --git a/vllm/entrypoints/mcp/tool.py b/vllm/entrypoints/mcp/tool.py index 9533a1b2d236..cd25aef087f8 100644 --- a/vllm/entrypoints/mcp/tool.py +++ b/vllm/entrypoints/mcp/tool.py @@ -159,7 +159,7 @@ async def get_result_parsable_context(self, context: "ConversationContext") -> A assert isinstance(context...	[ "tests/entrypoints/openai/responses/test_parsable_context_unit.py", "vllm/entrypoints/mcp/tool.py", "vllm/entrypoints/openai/parser/responses_parser.py", "vllm/entrypoints/openai/responses/context.py", "vllm/entrypoints/openai/responses/serving.py" ]	[]	diff --git a/tests/entrypoints/openai/test_responses_parser_unified.py b/tests/entrypoints/openai/responses/test_parsable_context_unit.py similarity index 66% rename from tests/entrypoints/openai/test_responses_parser_unified.py rename to tests/entrypoints/openai/responses/test_parsable_context_unit.py index 231ccf34fc...	true
vllm-project/vllm	43,154	issue_to_patch		[Core][AMD] Propagate shutdown timeout to MultiprocExecutor	## Purpose `rocprofv3` requires a grace period during process shutdown in order to emit trace data. This PR adds the environment variable `VLLM_WORKER_SHUTDOWN_TIMEOUT_SECONDS` that sets a shutdown grace period for worker processes of `MultiProcExecutor`. The env var is also passed to the engine manager shutdown. P...	272c16953eac7c46db7719d284d8a0ff19e63446	ac6ee073ea538e90e7c64bc2c877791237e9cd2a	diff --git a/vllm/envs.py b/vllm/envs.py index dfebcd27ae82..265477ea7b93 100755 --- a/vllm/envs.py +++ b/vllm/envs.py @@ -203,6 +203,7 @@ VLLM_ENFORCE_STRICT_TOOL_CALLING: bool = True VLLM_MQ_MAX_CHUNK_BYTES_MB: int = 16 VLLM_EXECUTE_MODEL_TIMEOUT_SECONDS: int = 300 + VLLM_WORKER_SHUTDOWN_TIMEOUT_SEC...	[ "tests/v1/engine/test_core_engine_actor_manager.py", "tests/v1/executor/test_executor.py", "vllm/envs.py", "vllm/v1/engine/core_client.py", "vllm/v1/executor/multiproc_executor.py" ]	[ { "comment": "![high](https://www.gstatic.com/codereviewagent/high-priority.svg)\n\nThe `self.vllm_config.shutdown_timeout` attribute can be `None` (as indicated by the type hint in `BackgroundResources`), which will cause a `TypeError` when passed to `max()`. You should handle the `None` case by defaulting it ...	diff --git a/tests/v1/engine/test_core_engine_actor_manager.py b/tests/v1/engine/test_core_engine_actor_manager.py index f60f8c94e7e2..a986bc07a3e8 100644 --- a/tests/v1/engine/test_core_engine_actor_manager.py +++ b/tests/v1/engine/test_core_engine_actor_manager.py @@ -8,6 +8,7 @@ from pathlib import Path from types...	true
vllm-project/vllm	43,154	comment_to_fix		[Core][AMD] Propagate shutdown timeout to MultiprocExecutor	![high](https://www.gstatic.com/codereviewagent/high-priority.svg) The `self.vllm_config.shutdown_timeout` attribute can be `None` (as indicated by the type hint in `BackgroundResources`), which will cause a `TypeError` when passed to `max()`. You should handle the `None` case by defaulting it to `0` (or another appro...	272c16953eac7c46db7719d284d8a0ff19e63446	ac6ee073ea538e90e7c64bc2c877791237e9cd2a	diff --git a/vllm/v1/executor/multiproc_executor.py b/vllm/v1/executor/multiproc_executor.py index 66564bebdb67..b0100c3d66ae 100644 --- a/vllm/v1/executor/multiproc_executor.py +++ b/vllm/v1/executor/multiproc_executor.py @@ -429,7 +429,9 @@ def wait_for_termination(procs, timeout): "[shutdown] Executor: ...	[ "vllm/v1/executor/multiproc_executor.py" ]	[ { "comment": "![high](https://www.gstatic.com/codereviewagent/high-priority.svg)\n\nThe `self.vllm_config.shutdown_timeout` attribute can be `None` (as indicated by the type hint in `BackgroundResources`), which will cause a `TypeError` when passed to `max()`. You should handle the `None` case by defaulting it ...		true
vllm-project/vllm	43,154	comment_to_fix		[Core][AMD] Propagate shutdown timeout to MultiprocExecutor	![high](https://www.gstatic.com/codereviewagent/high-priority.svg) The `shutdown_timeout` attribute on `self.vllm_config` might be `None` based on the type hints added in `vllm/v1/engine/core_client.py`. Using `max()` with a `None` value will raise a `TypeError`. It is safer to provide a default value (e.g., 0) if the...	272c16953eac7c46db7719d284d8a0ff19e63446	ac6ee073ea538e90e7c64bc2c877791237e9cd2a	diff --git a/vllm/v1/executor/multiproc_executor.py b/vllm/v1/executor/multiproc_executor.py index 66564bebdb67..b0100c3d66ae 100644 --- a/vllm/v1/executor/multiproc_executor.py +++ b/vllm/v1/executor/multiproc_executor.py @@ -429,7 +429,9 @@ def wait_for_termination(procs, timeout): "[shutdown] Executor: ...	[ "vllm/v1/executor/multiproc_executor.py" ]	[ { "comment": "![high](https://www.gstatic.com/codereviewagent/high-priority.svg)\n\nThe `shutdown_timeout` attribute on `self.vllm_config` might be `None` based on the type hints added in `vllm/v1/engine/core_client.py`. Using `max()` with a `None` value will raise a `TypeError`. It is safer to provide a defaul...		true
vllm-project/vllm	43,154	comment_to_fix		[Core][AMD] Propagate shutdown timeout to MultiprocExecutor	@rjrock Can you confirm here that we won't change the default behavior? If we're always passing in the vllm_config.shutdown_timeout. Will this change the shutdown_timeout to always be non-None? I'm worried this may cause an issue if the vllm_config's values are set to 0 (https://github.com/vllm-project/vllm/blob/main...	272c16953eac7c46db7719d284d8a0ff19e63446	ac6ee073ea538e90e7c64bc2c877791237e9cd2a	diff --git a/vllm/v1/engine/core_client.py b/vllm/v1/engine/core_client.py index 195cfeecf424..d5cf1050ca44 100644 --- a/vllm/v1/engine/core_client.py +++ b/vllm/v1/engine/core_client.py @@ -20,6 +20,7 @@ import zmq import zmq.asyncio +from vllm import envs from vllm.config import VllmConfig from vllm.envs import...	[ "vllm/v1/engine/core_client.py" ]	[ { "comment": "@rjrock Can you confirm here that we won't change the default behavior? If we're always passing in the vllm_config.shutdown_timeout. Will this change the shutdown_timeout to always be non-None?\n\nI'm worried this may cause an issue if the vllm_config's values are set to 0 (https://github.com/vll...		true
vllm-project/vllm	43,154	comment_to_fix		[Core][AMD] Propagate shutdown timeout to MultiprocExecutor	it actually applies to the core engines too ```suggestion # Timeout in seconds for engine and worker process shutdown ```	272c16953eac7c46db7719d284d8a0ff19e63446	ac6ee073ea538e90e7c64bc2c877791237e9cd2a	diff --git a/vllm/envs.py b/vllm/envs.py index dfebcd27ae82..265477ea7b93 100755 --- a/vllm/envs.py +++ b/vllm/envs.py @@ -203,6 +203,7 @@ VLLM_ENFORCE_STRICT_TOOL_CALLING: bool = True VLLM_MQ_MAX_CHUNK_BYTES_MB: int = 16 VLLM_EXECUTE_MODEL_TIMEOUT_SECONDS: int = 300 + VLLM_WORKER_SHUTDOWN_TIMEOUT_SEC...	[ "vllm/envs.py" ]	[ { "comment": "it actually applies to the core engines too\n```suggestion\n # Timeout in seconds for engine and worker process shutdown\n```", "path": "vllm/envs.py", "hunk": "@@ -1639,6 +1640,11 @@ def _resolve_rust_frontend_path() -> str \| None:\n \"VLLM_EXECUTE_MODEL_TIMEOUT_SECONDS\": lambda: ...		true
vllm-project/vllm	43,154	comment_to_fix		[Core][AMD] Propagate shutdown timeout to MultiprocExecutor	perhaps we can make this 5 since the default core engine shutdown timeout was previously 5	272c16953eac7c46db7719d284d8a0ff19e63446	ac6ee073ea538e90e7c64bc2c877791237e9cd2a	diff --git a/vllm/envs.py b/vllm/envs.py index dfebcd27ae82..265477ea7b93 100755 --- a/vllm/envs.py +++ b/vllm/envs.py @@ -203,6 +203,7 @@ VLLM_ENFORCE_STRICT_TOOL_CALLING: bool = True VLLM_MQ_MAX_CHUNK_BYTES_MB: int = 16 VLLM_EXECUTE_MODEL_TIMEOUT_SECONDS: int = 300 + VLLM_WORKER_SHUTDOWN_TIMEOUT_SEC...	[ "vllm/envs.py" ]	[ { "comment": "perhaps we can make this 5 since the default core engine shutdown timeout was previously 5", "path": "vllm/envs.py", "hunk": "@@ -207,6 +207,7 @@\n VLLM_TOOL_PARSE_REGEX_TIMEOUT_SECONDS: int = 1\n VLLM_MQ_MAX_CHUNK_BYTES_MB: int = 16\n VLLM_EXECUTE_MODEL_TIMEOUT_SECONDS: int = ...		true
vllm-project/vllm	39,612	issue_to_patch		[Migration] Migrate GGUF quantization support to plugin	## Purpose After this PR, GGUF support will be migrated to https://github.com/vllm-project/vllm-gguf-plugin, you can still use GGUF models normally after plugin installation! ``` uv pip install vllm-gguf-plugin ``` - Related issues: https://github.com/vllm-project/vllm/issues/39583 and https://github.com...	fe042382925000e5adfe530a1cc2b91d7a125fd5	4750949ef01b54ccf202f7b8a5b40e7968f84ac4	diff --git a/.github/dependabot.yml b/.github/dependabot.yml index a017d69be991..944929fc55e5 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.yml @@ -21,7 +21,6 @@ updates: - dependency-name: "torchvision" - dependency-name: "xformers" - dependency-name: "lm-format-enforcer" - - d...	[ ".buildkite/test_areas/plugins.yaml", ".github/dependabot.yml", ".pre-commit-config.yaml", "CMakeLists.txt", "csrc/libtorch_stable/ops.h", "csrc/libtorch_stable/quantization/gguf/dequantize.cuh", "csrc/libtorch_stable/quantization/gguf/ggml-common.h", "csrc/libtorch_stable/quantization/gguf/gguf_kerne...	[ { "comment": "Do we have pointers to the GGUF plugin in documentation after removal of code in this repo?", "path": "docs/features/quantization/README.md", "hunk": "@@ -9,7 +9,6 @@ The following are the supported quantization formats for vLLM:\n \n - [AutoAWQ](auto_awq.md)\n - [BitsAndBytes](bnb.md)\n--...	diff --git a/.buildkite/test_areas/plugins.yaml b/.buildkite/test_areas/plugins.yaml index 591afd946d23..21e3572fc789 100644 --- a/.buildkite/test_areas/plugins.yaml +++ b/.buildkite/test_areas/plugins.yaml @@ -40,3 +40,17 @@ steps: - pytest -v -s plugins_tests/test_oot_registration_online.py # it needs a clean proc...	true
vllm-project/vllm	45,319	issue_to_patch		[Model][Dflash] Enable Dflash support for Qwen3NextForCausalLM targets	## Purpose Enable DFlash (`method="dflash"`) speculative decoding for `Qwen3NextForCausalLM`-based models (Qwen3-Next / Qwen3-Coder-Next 80B-A3B). This addresses #33329 and other failed attempts. ## Problem `method="dflash"` crashes at model-load time for any `Qwen3NextForCausalLM` target with: ``...	5a6c7b7ab569f49491b5428a7983be5b17b85378	bd32d65af2fd6557a4915bca06a26eca6f4d631d	diff --git a/vllm/model_executor/models/qwen3_next.py b/vllm/model_executor/models/qwen3_next.py index 165a2d94cfcb..2ab08290fb55 100644 --- a/vllm/model_executor/models/qwen3_next.py +++ b/vllm/model_executor/models/qwen3_next.py @@ -68,6 +68,7 @@ HasInnerState, IsHybrid, MixtureOfExperts, + Supports...	[ "tests/models/registry.py", "vllm/model_executor/models/qwen3_next.py" ]	[]	diff --git a/tests/models/registry.py b/tests/models/registry.py index d2d2794962fc..db772cfc81e9 100644 --- a/tests/models/registry.py +++ b/tests/models/registry.py @@ -1435,6 +1435,14 @@ def check_available_online( max_model_len=8192, # Reduce max len to ensure test runs in low-VRAM CI env max_num...	true
vllm-project/vllm	44,729	issue_to_patch		[Bugfix][Rust Frontend] Set a structured-output backend so requests do not 500	## Purpose With `VLLM_USE_RUST_FRONTEND=1`, every structured-output request (`response_format` json_schema/json_object, `structured_outputs` regex/choice) returns HTTP 500: the engine raises `Unsupported structured output backend: None` in `grammar_init`. The backend is normally resolved by `SamplingParams._vali...	9f153aa781f07d74b8574b57eab71551374c9498	e577e21c61ba9b7b71a3b362e6d160249dca4d2e	diff --git a/rust/src/engine-core-client/src/protocol/mod.rs b/rust/src/engine-core-client/src/protocol/mod.rs index e87bc334fd05..6fae982d2ea6 100644 --- a/rust/src/engine-core-client/src/protocol/mod.rs +++ b/rust/src/engine-core-client/src/protocol/mod.rs @@ -162,6 +162,21 @@ pub enum RequestOutputKind { FinalO...	[ "rust/src/engine-core-client/src/protocol/mod.rs" ]	[]		true
vllm-project/vllm	45,308	issue_to_patch		[Bugfix][Model] Pass revision by name in Run:ai and bitsandbytes index downloads	## Purpose `RunaiModelStreamerLoader._prepare_weights` and `BitsAndBytesModelLoader._prepare_weights` call `download_safetensors_index_file_from_hf` with `revision` as the fourth positional argument. The callee signature is: ```python download_safetensors_index_file_from_hf( model_name_or_path, in...	3b03a2cf4772838da622d81315941bb41bcc03ff	f940daf1c6acefa491007a49296187e508a7f944	diff --git a/vllm/model_executor/model_loader/bitsandbytes_loader.py b/vllm/model_executor/model_loader/bitsandbytes_loader.py index d10f3bfcbe9b..064a74023a29 100644 --- a/vllm/model_executor/model_loader/bitsandbytes_loader.py +++ b/vllm/model_executor/model_loader/bitsandbytes_loader.py @@ -140,8 +140,8 @@ def _prep...	[ "tests/model_executor/model_loader/runai_streamer_loader/test_runai_model_streamer_loader.py", "tests/models/quantization/test_bitsandbytes.py", "vllm/model_executor/model_loader/bitsandbytes_loader.py", "vllm/model_executor/model_loader/runai_streamer_loader.py" ]	[]	diff --git a/tests/model_executor/model_loader/runai_streamer_loader/test_runai_model_streamer_loader.py b/tests/model_executor/model_loader/runai_streamer_loader/test_runai_model_streamer_loader.py index c7158dae537a..82c0f8813e23 100644 --- a/tests/model_executor/model_loader/runai_streamer_loader/test_runai_model_st...	true
vllm-project/vllm	36,902	issue_to_patch		[Kernel][Helion][1/N] Add Helion kernel for per_token_group_fp8_quant	## Purpose This PR is to add Helion kernel for ```per_token_group_fp8_quant``` operation. It follows the implementation from the [vllm c version](https://github.com/vllm-project/vllm/blob/a913b612d8a85a926c50815adb969056f10b62e2/csrc/quantization/w8a8/fp8/per_token_group_quant.cu#L379). This is a subtask for https...	5edf7ff489e83616c00c64d3ac6562f81dbe5638	39bc805c0d7bac48ed137d4da38b706f658a0b8c	diff --git a/.buildkite/test-amd.yaml b/.buildkite/test-amd.yaml index 186f72225397..148aea73c7fb 100644 --- a/.buildkite/test-amd.yaml +++ b/.buildkite/test-amd.yaml @@ -398,7 +398,7 @@ steps: - tests/kernels/helion/ - vllm/platforms/rocm.py commands: - - pip install helion==1.0.0 + - pip install helion==1....	[ ".buildkite/test-amd.yaml", ".buildkite/test_areas/kernels.yaml", "setup.py", "tests/kernels/helion/test_per_token_group_fp8_quant.py", "tests/kernels/helion/test_register.py", "tests/kernels/helion/utils.py", "vllm/kernels/helion/configs/per_token_group_fp8_quant/nvidia_b200.json", "vllm/kernels/heli...	[ { "comment": "![high](https://www.gstatic.com/codereviewagent/high-priority.svg)\n\nThe `scale_ue8m0` parameter introduces a conditional logic path in the `per_token_group_fp8_quant` kernel which can have performance implications. However, the input generator for autotuning currently hardcodes `use_ue8m0` to `F...	diff --git a/.buildkite/test_areas/kernels.yaml b/.buildkite/test_areas/kernels.yaml index 10b5b7527b84..57ef0768c97a 100644 --- a/.buildkite/test_areas/kernels.yaml +++ b/.buildkite/test_areas/kernels.yaml @@ -224,7 +224,7 @@ steps: - vllm/utils/import_utils.py - tests/kernels/helion/ commands: - - pip ins...	true
vllm-project/vllm	36,902	comment_to_fix		[Kernel][Helion][1/N] Add Helion kernel for per_token_group_fp8_quant	![high](https://www.gstatic.com/codereviewagent/high-priority.svg) The `scale_ue8m0` parameter introduces a conditional logic path in the `per_token_group_fp8_quant` kernel which can have performance implications. However, the input generator for autotuning currently hardcodes `use_ue8m0` to `False`. This means that t...	5edf7ff489e83616c00c64d3ac6562f81dbe5638	39bc805c0d7bac48ed137d4da38b706f658a0b8c	diff --git a/vllm/kernels/helion/ops/per_token_group_fp8_quant.py b/vllm/kernels/helion/ops/per_token_group_fp8_quant.py new file mode 100644 index 000000000000..8b73fac4b8eb --- /dev/null +++ b/vllm/kernels/helion/ops/per_token_group_fp8_quant.py @@ -0,0 +1,232 @@ +# SPDX-License-Identifier: Apache-2.0 +# SPDX-FileCop...	[ "vllm/kernels/helion/ops/per_token_group_fp8_quant.py" ]	[ { "comment": "![high](https://www.gstatic.com/codereviewagent/high-priority.svg)\n\nThe `scale_ue8m0` parameter introduces a conditional logic path in the `per_token_group_fp8_quant` kernel which can have performance implications. However, the input generator for autotuning currently hardcodes `use_ue8m0` to `F...		true
vlucas/phpdotenv	591	issue_to_patch		Test on PHP 8.5		24ac4c74f91ee2c193fa1aaa5c249cb0822809af	be1fd7923d13afc3b035424e7e95fae956c7c352	diff --git a/.gitattributes b/.gitattributes index 7f1a1ce..bf9b56b 100644 --- a/.gitattributes +++ b/.gitattributes @@ -10,8 +10,6 @@ /phpstan-baseline.neon export-ignore /phpstan.neon.dist export-ignore /phpunit.xml.dist export-ignore -/psalm-baseline.xml export-ignore -/psalm.xml export-ignore /README.md export-...	[ ".gitattributes", ".github/workflows/static.yml", ".github/workflows/tests.yml", "Makefile", "README.md", "phpstan-baseline.neon", "psalm-baseline.xml", "psalm.xml", "src/Parser/EntryParser.php", "src/Repository/Adapter/EnvConstAdapter.php", "src/Repository/Adapter/ServerConstAdapter.php", "ve...	[]		true
vlucas/phpdotenv	572	issue_to_patch		Prepare for PHP 8.4	PHP 8.4 deprecates implicitly nullable parameter types: https://wiki.php.net/rfc/deprecate-implicitly-nullable-types	334f4952967f3ee6cdb2004e05e0bd01b525d56b	df40e7ff11ab4f79083db1bfdd8216746e472dd6	diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index f3e30e15..6e70b81c 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -11,7 +11,7 @@ jobs: strategy: matrix: - php: ['7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.3'] + php: ['7.2', '7.3', ...	[ ".github/workflows/tests.yml", "src/Dotenv.php", "src/Parser/Entry.php", "src/Repository/RepositoryBuilder.php", "src/Store/File/Reader.php", "src/Store/FileStore.php", "src/Store/StoreBuilder.php", "src/Util/Regex.php", "src/Util/Str.php" ]	[]		true
vlucas/phpdotenv	558	issue_to_patch		Document why superglobals can appear empty	I had a case on a shared hosting setup that the `$_ENV` variable was not being set. This was due to the `variables_order` setting in `php.ini`. Maybe it is a good idea to document this in the README?	1a7ea2afc49c3ee6d87061f5a233e3a035d0eae7	7a476ffed92019b437e4e870a937bc00eb3b187d	diff --git a/README.md b/README.md index 90f9436d..bc673322 100644 --- a/README.md +++ b/README.md @@ -342,6 +342,10 @@ one-time step to manually copy the `.env.example` file to `.env` and fill-in their own values (or get any sensitive values from a project co-worker). +### Troubleshooting + +In certain server set...	[ "README.md" ]	[]		true
vlucas/phpdotenv	546	issue_to_patch		[5.5] Add support for unicode variable names	Closes #540 Co-Authored-By: Thor Erik <219796+thorerik@users.noreply.github.com>	f9266951999a6a4059a6edea926a1d19f40cfc3b	d1ef2c4117329c4f179266731098606aa4e74527	diff --git a/src/Parser/EntryParser.php b/src/Parser/EntryParser.php index 6a4d54f1..e286840a 100644 --- a/src/Parser/EntryParser.php +++ b/src/Parser/EntryParser.php @@ -139,7 +139,7 @@ private static function isQuotedName(string $name) */ private static function isValidName(string $name) { - re...	[ "src/Parser/EntryParser.php", "tests/Dotenv/DotenvTest.php", "tests/Dotenv/Parser/EntryParserTest.php", "tests/fixtures/env/unicodevarnames.env" ]	[]	diff --git a/tests/Dotenv/DotenvTest.php b/tests/Dotenv/DotenvTest.php index 8baf5dd9..97ddfd73 100644 --- a/tests/Dotenv/DotenvTest.php +++ b/tests/Dotenv/DotenvTest.php @@ -335,6 +335,14 @@ public function testEmptyLoading() self::assertSame(['EMPTY_VAR' => null], $dotenv->load()); } + public funct...	true
vlucas/phpdotenv	545	issue_to_patch		[4.3] Fix issue where line ending in `="` is incorrectly marked as a multi-line start		afb6dd2e5ead7f43c4d44d33ec410d3ef2c29b5b	5561c43890a957c8e310de7859f186bef37fafbf	diff --git a/Makefile b/Makefile index c5b83976..74c84963 100644 --- a/Makefile +++ b/Makefile @@ -3,7 +3,7 @@ install: @docker run -it -w /data -v ${PWD}:/data:delegated -v ~/.composer:/root/.composer:delegated --entrypoint composer --rm registry.gitlab.com/grahamcampbell/php:8.2-base bin all update phpunit: - @r...	[ "Makefile", "src/Loader/Lines.php", "tests/Dotenv/LinesTest.php", "tests/fixtures/env/multiline.env" ]	[]	diff --git a/tests/Dotenv/LinesTest.php b/tests/Dotenv/LinesTest.php index b906a546..efa9281d 100644 --- a/tests/Dotenv/LinesTest.php +++ b/tests/Dotenv/LinesTest.php @@ -36,6 +36,7 @@ public function testProcessQuotes() 'TEST_NS=\'test\\ntest\'', 'TEST_EQD="https://vision.googleapis.com/v1/im...	true
vlucas/phpdotenv	544	issue_to_patch		[4.3] Dropped invalid tests		c349cad3c63eae4343ceaa0d404db173fc9867d1	ab84116c30785f7c9f4199885abe99bee906a8a1		[ "tests/Dotenv/LinesTest.php" ]	[]	diff --git a/tests/Dotenv/LinesTest.php b/tests/Dotenv/LinesTest.php index fbbb56ce..b906a546 100644 --- a/tests/Dotenv/LinesTest.php +++ b/tests/Dotenv/LinesTest.php @@ -40,30 +40,4 @@ public function testProcessQuotes() self::assertSame($expected, Lines::process(preg_split("/(\r\n\|\n\|\r)/", $content))); ...	true
vlucas/phpdotenv	542	issue_to_patch		[4.3] Support PHP 8.2		888448cb47d0991c2f8b959ca442263cbff9dc6c	f4b98f0bbfce636f6d74d6d37a7a46bae625f7bb	diff --git a/.github/workflows/static.yml b/.github/workflows/static.yml index 1f104e39..c650ce8d 100644 --- a/.github/workflows/static.yml +++ b/.github/workflows/static.yml @@ -7,28 +7,28 @@ on: jobs: phpstan_src: name: PHPStan Source - runs-on: ubuntu-20.04 + runs-on: ubuntu-22.04 steps: ...	[ ".github/workflows/static.yml", ".github/workflows/tests.yml", "Makefile", "composer.json", "phpstan.src.neon.dist", "src/Regex/Regex.php", "vendor-bin/phpstan/composer.json", "vendor-bin/psalm/composer.json" ]	[]		true
vlucas/phpdotenv	539	issue_to_patch		[5.5] Typofixes	Some small typofixes throughout the codebase	dd46c263f277573244c517bac125a78f67b83a98	c8dbd2f0978a3eab14d6b9b725197d5cc5445d07	diff --git a/UPGRADING.md b/UPGRADING.md index f9e59dcc..757f666f 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -78,18 +78,18 @@ Release notes for 4.0.0 are available [here](https://github.com/vlucas/phpdotenv ### Details -V4 has again changed the way you initialize the `Dotenv` class. If you want immutable load...	[ "UPGRADING.md", "src/Parser/Lines.php", "src/Repository/RepositoryBuilder.php", "src/Util/Regex.php", "tests/Dotenv/DotenvTest.php" ]	[]	diff --git a/tests/Dotenv/DotenvTest.php b/tests/Dotenv/DotenvTest.php index dc778537..8baf5dd9 100644 --- a/tests/Dotenv/DotenvTest.php +++ b/tests/Dotenv/DotenvTest.php @@ -317,7 +317,7 @@ public function testDotenvAllowsSpecialCharacters() self::assertSame('secret!@#', \getenv('SPVAR8')); } - publ...	true
vlucas/phpdotenv	541	issue_to_patch		[4.3] Made repository checks a little stricter		9f52bcbcf6493298281ddc4cf88eb3eac0cc4871	c99b5e718f6f16db0d5c866b8570cdce46d75f6f	diff --git a/src/Repository/AbstractRepository.php b/src/Repository/AbstractRepository.php index 57c7b432..04994e06 100644 --- a/src/Repository/AbstractRepository.php +++ b/src/Repository/AbstractRepository.php @@ -46,8 +46,8 @@ public function __construct($immutable) */ public function get($name) { - ...	[ "src/Repository/AbstractRepository.php", "src/Repository/Adapter/ApacheAdapter.php", "src/Repository/Adapter/ArrayAdapter.php", "src/Repository/Adapter/EnvConstAdapter.php", "src/Repository/Adapter/PutenvAdapter.php", "src/Repository/Adapter/ReaderInterface.php", "src/Repository/Adapter/ServerConstAdapt...	[]	diff --git a/tests/Dotenv/RepositoryTest.php b/tests/Dotenv/RepositoryTest.php index ffef3db3..1f2fe295 100644 --- a/tests/Dotenv/RepositoryTest.php +++ b/tests/Dotenv/RepositoryTest.php @@ -141,15 +141,26 @@ public function testGettingVariableByName() /** * @expectedException \InvalidArgumentException - ...	true
vlucas/phpdotenv	543	issue_to_patch		[4.3] Fixed static analysis runs		5fd7cbfad203ea792b4737e26535528d361b2233	b3ad2ae14e2fbb6fe24699646faa02b00d4bd505	diff --git a/composer.json b/composer.json index 2a0dc7ad..ef427293 100644 --- a/composer.json +++ b/composer.json @@ -47,6 +47,10 @@ "preferred-install": "dist" }, "extra": { + "bamarni-bin": { + "bin-links": true, + "forward-command": true + }, "branch-a...	[ "composer.json", "vendor-bin/phpstan/composer.json", "vendor-bin/psalm/composer.json" ]	[]		true
vlucas/phpdotenv	496	issue_to_patch		Added support for PHP 8.1		b786088918a884258c9e3e27405c6a4cf2ee246e	cb40429a4dc86dcc7d2a851e6cd6d73e497b9405	diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index ef29302b..a818cfc6 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -11,7 +11,7 @@ jobs: strategy: matrix: - php: ['5.3', '5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0'] + ...	[ ".github/workflows/tests.yml", ".gitignore", "composer.json", "phpunit.xml.dist", "src/Loader.php", "tests/Dotenv/DotenvTest.php", "tests/Dotenv/LoaderTest.php", "tests/Dotenv/ValidatorBooleanTest.php" ]	[]	diff --git a/tests/Dotenv/DotenvTest.php b/tests/Dotenv/DotenvTest.php index 8c11d0a3..50f44d0f 100644 --- a/tests/Dotenv/DotenvTest.php +++ b/tests/Dotenv/DotenvTest.php @@ -10,7 +10,10 @@ class DotenvTest extends TestCase / private $fixturesFolder; - public function setUp() + /* + * @before +...	true
vlucas/phpdotenv	506	issue_to_patch		Reduce confusion	Minor change aimed at making the changes easier to understand.	d98a9889d86c149f6fa35e182d6e849d168b0ca3	5e3c7fe49c7a9a86d9beb0abe2fbb08484a194d4	diff --git a/UPGRADING.md b/UPGRADING.md index 7fd0a82e..f9e59dcc 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -10,8 +10,8 @@ Release notes for 5.0.0 are available [here](https://github.com/vlucas/phpdotenv ### Details -1. The `Dotenv\Dotenv::createImmutable` and `Dotenv\Dotenv::createMutable` methods no longer...	[ "UPGRADING.md" ]	[]		true
vlucas/phpdotenv	505	issue_to_patch		Set allow-plugins for Composer 2.2	This new configuration has been introduced with Composer 2.2: https://github.com/composer/composer/releases/tag/2.2.0-RC1	77e974614d2ead521f18069dccc571696f52b8dc	90c51506f49b1687a6231059a499731c3d859509	diff --git a/composer.json b/composer.json index a30f9c04..2a0dc7ad 100644 --- a/composer.json +++ b/composer.json @@ -41,6 +41,9 @@ "ext-pcre": "Required to use most of the library." }, "config": { + "allow-plugins": { + "bamarni/composer-bin-plugin": true + }, "pre...	[ "composer.json" ]	[]		true
vlucas/phpdotenv	501	issue_to_patch	Add support for BOM-signed env files Hi! I was working on a Laravel project that has a .env file. But I faced an error that says: `The environment file is invalid!` `Failed to parse dotenv file due to an invalid name. Failed at [APP_NAME].` After some time for debugging, I realized the problem is come from enc...	Add support for BOM-signed env files	Fix https://github.com/vlucas/phpdotenv/issues/500	accaddf133651d4b5cf81a119f25296736ffc850	58193cd1f5183ed84e51272becddde4cb2c0807d	diff --git a/src/Util/Str.php b/src/Util/Str.php index 582c2144..087e236a 100644 --- a/src/Util/Str.php +++ b/src/Util/Str.php @@ -41,11 +41,19 @@ public static function utf8(string $input, string $encoding = null) \sprintf('Illegal character encoding [%s] specified.', $encoding) ); ...	[ "src/Util/Str.php", "tests/Dotenv/Store/StoreTest.php", "tests/fixtures/env/utf8-with-bom-encoding.env" ]	[]	diff --git a/tests/Dotenv/Store/StoreTest.php b/tests/Dotenv/Store/StoreTest.php index 0d953bdc..6b4d9672 100644 --- a/tests/Dotenv/Store/StoreTest.php +++ b/tests/Dotenv/Store/StoreTest.php @@ -127,4 +127,15 @@ public function testFileReadMultipleWithoutShortCircuitMode() $builder->make()->read() ...	true
vlucas/phpdotenv	478	issue_to_patch		Adding safeLoad() information on README.md file	As mentioned on #84, nowhere in the README.md file contains any information regarding the safeLoad() method which allows users to suppress exceptions when no `.env` file is found.	b3eac5c7ac896e52deab4a99068e3f4ab12d9e56	fff610e365aedaf06f50dbd327b512f15f06afef	diff --git a/README.md b/README.md index 4a6c1eec..e58c69bd 100644 --- a/README.md +++ b/README.md @@ -98,6 +98,13 @@ $dotenv = Dotenv\Dotenv::createImmutable(__DIR__); $dotenv->load(); ``` +To suppress the exception that is thrown when there is no `.env` file, you can: + +```php +$dotenv = Dotenv\Dotenv::createImm...	[ "README.md" ]	[]		true
vlucas/phpdotenv	467	issue_to_patch		[2.6] Test on PHP 8.1 too		919c01abf122aa8cbd58e8836fba076892a0a5f9	20f2b2c930ab9a9594dda7bb61f6ad6260b3502f	diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml index ef29302b..bb2b5e8f 100644 --- a/.github/workflows/tests.yml +++ b/.github/workflows/tests.yml @@ -11,7 +11,7 @@ jobs: strategy: matrix: - php: ['5.3', '5.4', '5.5', '5.6', '7.0', '7.1', '7.2', '7.3', '7.4', '8.0'] + ...	[ ".github/workflows/tests.yml" ]	[]		true
vlucas/phpdotenv	465	issue_to_patch		Fixed typos in the upgrading guide		fba64139db67123c7a57072e5f8d3db10d160b66	6b6ee5648d9ad67cca72436b7802f7d22a2905e3	diff --git a/UPGRADING.md b/UPGRADING.md index 2712388c..7fd0a82e 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -13,7 +13,7 @@ Release notes for 5.0.0 are available [here](https://github.com/vlucas/phpdotenv 1. The `Dotenv\Dotenv::createImmutable` and `Dotenv\Dotenv::createMutable` methods no longer call will result...	[ "UPGRADING.md" ]	[]		true
vlucas/phpdotenv	457	issue_to_patch		[5.2] Support boolean values in $_ENV and $_SERVER		3af4965da310c7495736a977756ce6edb7053063	cdbf509422fb904e6c7f0a672eda9d5891f5d043	diff --git a/src/Repository/Adapter/EnvConstAdapter.php b/src/Repository/Adapter/EnvConstAdapter.php index c2b7af84..9ef7fb4d 100644 --- a/src/Repository/Adapter/EnvConstAdapter.php +++ b/src/Repository/Adapter/EnvConstAdapter.php @@ -40,9 +40,20 @@ public static function create() public function read(string $name...	[ "src/Repository/Adapter/EnvConstAdapter.php", "src/Repository/Adapter/ServerConstAdapter.php", "tests/Dotenv/Repository/Adapter/EnvConstAdapterTest.php", "tests/Dotenv/Repository/Adapter/ServerConstAdapterTest.php" ]	[]	diff --git a/tests/Dotenv/Repository/Adapter/EnvConstAdapterTest.php b/tests/Dotenv/Repository/Adapter/EnvConstAdapterTest.php index bea69e9b..592f304e 100644 --- a/tests/Dotenv/Repository/Adapter/EnvConstAdapterTest.php +++ b/tests/Dotenv/Repository/Adapter/EnvConstAdapterTest.php @@ -17,6 +17,22 @@ public function te...	true
vlucas/phpdotenv	453	issue_to_patch		[5.2] Fixed wording		448c76d7a9e30c341ff5bc367a923af74ae18467	e5a9ffc69ed8e5d626a02654d635ac2bf3ba4bab	diff --git a/README.md b/README.md index 357f3f80..4a6c1eec 100644 --- a/README.md +++ b/README.md @@ -117,7 +117,7 @@ $s3_bucket = $_SERVER['S3_BUCKET']; ### Putenv and Getenv -Using `getenv()` and `putenv()` is strongly discurraged due to the fact that +Using `getenv()` and `putenv()` is strongly discouraged due...	[ "README.md" ]	[]		true
vlucas/phpdotenv	451	issue_to_patch		Apply fixes from StyleCI		331dea7bf72d8cc67a461a7e61535b750d947d67	62dc1acc30a551f2b87c927bb8154f7240055fef	diff --git a/src/Parser/EntryParser.php b/src/Parser/EntryParser.php index c236b086..64df9a02 100644 --- a/src/Parser/EntryParser.php +++ b/src/Parser/EntryParser.php @@ -92,8 +92,8 @@ private static function splitStringIntoParts(string $line) */ private static function parseName(string $name) { - ...	[ "src/Parser/EntryParser.php", "src/Parser/Lexer.php", "src/Repository/RepositoryBuilder.php", "src/Util/Str.php", "tests/Dotenv/DotenvTest.php" ]	[]	diff --git a/tests/Dotenv/DotenvTest.php b/tests/Dotenv/DotenvTest.php index e9fe489f..b927d9ba 100644 --- a/tests/Dotenv/DotenvTest.php +++ b/tests/Dotenv/DotenvTest.php @@ -155,8 +155,8 @@ public function testLargeDotenvLoadsEnvironmentVars() { $dotenv = Dotenv::createMutable(self::$folder, 'large.env')...	true
vlucas/phpdotenv	440	issue_to_patch		[5.0] Use multibyte string functions		c62d0bab46b3b0ccc7731ccec8d6d3ed9d79fbcb	f198349fabda93b8396ddb968da391ca6ce0cb1f	diff --git a/src/Loader/Resolver.php b/src/Loader/Resolver.php index e844d51a..c05c7919 100644 --- a/src/Loader/Resolver.php +++ b/src/Loader/Resolver.php @@ -37,7 +37,7 @@ private function __construct() public static function resolve(RepositoryInterface $repository, Value $value) { return array_redu...	[ "src/Loader/Resolver.php", "src/Parser/EntryParser.php", "src/Parser/Lines.php", "src/Parser/Value.php", "src/Validator.php" ]	[]		true
vlucas/phpdotenv	441	issue_to_patch		[5.x] Support for multibyte values	Closes https://github.com/vlucas/phpdotenv/issues/439.	8fff75b9ab316a36d1d1343aae4f745728c09a2a	d58ea7630a2c01f212a6299e42b9699c76e22216	diff --git a/composer.json b/composer.json index 0c640838..84b6a5a5 100644 --- a/composer.json +++ b/composer.json @@ -20,8 +20,9 @@ "ext-pcre": "*", "graham-campbell/result-type": "^1.0", "phpoption/phpoption": "^1.7.3", - "symfony/polyfill-ctype": "^1.9", - "symfony/polyfill-p...	[ "composer.json", "phpstan.src.neon.dist", "src/Dotenv.php", "src/Exception/InvalidEncodingException.php", "src/Loader/Resolver.php", "src/Parser/EntryParser.php", "src/Parser/Lines.php", "src/Parser/Parser.php", "src/Parser/Value.php", "src/Store/File/Reader.php", "src/Store/FileStore.php", "s...	[]	diff --git a/tests/Dotenv/DotenvTest.php b/tests/Dotenv/DotenvTest.php index 01980e41..47be8fcb 100644 --- a/tests/Dotenv/DotenvTest.php +++ b/tests/Dotenv/DotenvTest.php @@ -5,6 +5,7 @@ namespace Dotenv\Tests; use Dotenv\Dotenv; +use Dotenv\Exception\InvalidEncodingException; use Dotenv\Exception\InvalidPathExcep...	true
vlucas/phpdotenv	436	issue_to_patch		Fixed readme typo		539bb6927c101a5605d31d11a2d17185a2ce2bf1	7aa2035aedfab09156ae11853b7e0b41ba394f89	diff --git a/README.md b/README.md index f78adc7c..48902d58 100644 --- a/README.md +++ b/README.md @@ -183,7 +183,7 @@ $dotenv->load(); Behind the scenes, this is instructing the "repository" to allow immutability or not. By default, the repository is configured to allow overwriting existing -values by default, whi...	[ "README.md" ]	[]		true
vlucas/phpdotenv	431	issue_to_patch		Apply fixes from StyleCI		04822e8b83a777e24a34ea6e38eb2fa502f8b886	65368e98760915b07f4dadd3073781b8abdc9a7b	diff --git a/src/Parser/Parser.php b/src/Parser/Parser.php index b264efb4..800a7bd2 100644 --- a/src/Parser/Parser.php +++ b/src/Parser/Parser.php @@ -6,8 +6,8 @@ use Dotenv\Exception\InvalidFileException; use Dotenv\Regex\Regex; -use GrahamCampbell\ResultType\Success; use GrahamCampbell\ResultType\Result; +use Gr...	[ "src/Parser/Parser.php", "tests/Dotenv/Parser/ParserTest.php" ]	[]	diff --git a/tests/Dotenv/Parser/ParserTest.php b/tests/Dotenv/Parser/ParserTest.php index ad2c2974..84a65496 100644 --- a/tests/Dotenv/Parser/ParserTest.php +++ b/tests/Dotenv/Parser/ParserTest.php @@ -9,7 +9,6 @@ use Dotenv\Parser\Parser; use Dotenv\Parser\ParserInterface; use Dotenv\Parser\Value; -use GrahamCampb...	true
vlucas/phpdotenv	428	issue_to_patch		[5.0] Apply fixes from StyleCI		085cdd331ff3061c8a60da4e36fa9d5c586c0681	413ae004f1db742c58325de40997c5a337b37331	diff --git a/src/Loader/Loader.php b/src/Loader/Loader.php index e9a7d971..c2cd1ee9 100644 --- a/src/Loader/Loader.php +++ b/src/Loader/Loader.php @@ -6,8 +6,8 @@ use Dotenv\Exception\InvalidFileException; use Dotenv\Parser\Entry; -use Dotenv\Parser\Value; use Dotenv\Parser\ParserInterface; +use Dotenv\Parser\Valu...	[ "src/Loader/Loader.php", "src/Repository/Adapter/ArrayAdapter.php", "src/Repository/Adapter/EnvConstAdapter.php", "src/Repository/Adapter/ReplacingWriter.php", "src/Repository/Adapter/ServerConstAdapter.php", "src/Repository/RepositoryBuilder.php" ]	[]		true
vlucas/phpdotenv	427	issue_to_patch		[3.6] Test on HHVM 3.30 too		884ab15c7c355b2033d51eb5a38b5835c3b0da28	2987fd0774a447c18362e524f66936f8163da8cc	diff --git a/.travis.yml b/.travis.yml index 9cf3ed05..a780c1e3 100644 --- a/.travis.yml +++ b/.travis.yml @@ -4,6 +4,14 @@ matrix: dist: trusty language: php php: hhvm-3.18 + before_install: travis_retry composer require "phpunit/phpunit:^5.7.27" --dev --no-update -n + install: travis_re...	[ ".travis.yml" ]	[]		true
vlucas/phpdotenv	426	issue_to_patch		[2.6] Revert PHP 5.3 break		db354ca6baa3bc0deeb7e92e93a3a1112ae1e10d	8e139589c4ddfa0ed0bacd95b3b58ed9a59207de	diff --git a/src/Parser.php b/src/Parser.php index 92e50399..67a5c4d5 100644 --- a/src/Parser.php +++ b/src/Parser.php @@ -38,9 +38,9 @@ public static function parseValue($value) if ($value === '') { return ''; } elseif ($value[0] === '"' \|\| $value[0] === '\'') { - return self:...	[ "src/Parser.php" ]	[]		true
vlucas/phpdotenv	425	issue_to_patch		[2.6] Support PHP 7.4		8bdc950f42eac74be73df082a13f9b9596df8ef4	1395d91cc9f2c2701ce92f0f50cc1f11fbc788fb	diff --git a/.travis.yml b/.travis.yml index f839840f..cb6c159f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -11,7 +11,9 @@ php: - 7.1 - 7.2 - 7.3 - - hhvm + - 7.4 + - hhvm-3.18 + - hhvm-3.30 matrix: include:	[ ".travis.yml" ]	[]		true
vlucas/phpdotenv	424	issue_to_patch		[2.6] Apply fixes from StyleCI		4f3a400bcebad284cc9597891ce0bd1fe5a74aee	8b970b107013185e0274aedb3d1f0f5f3cfdeb66	diff --git a/src/Loader.php b/src/Loader.php index 9e8183ba..496ce75c 100644 --- a/src/Loader.php +++ b/src/Loader.php @@ -52,6 +52,7 @@ public function __construct($filePath, $immutable = false) * Set immutable value. * * @param bool $immutable + * * @return $this */ public funct...	[ "src/Loader.php", "src/Parser.php", "src/Validator.php", "tests/Dotenv/LoaderTest.php", "tests/Dotenv/ValidatorBooleanTest.php" ]	[]	diff --git a/tests/Dotenv/LoaderTest.php b/tests/Dotenv/LoaderTest.php index 3915b2b1..c52011d6 100644 --- a/tests/Dotenv/LoaderTest.php +++ b/tests/Dotenv/LoaderTest.php @@ -17,7 +17,7 @@ class LoaderTest extends TestCase public function setUp() { - $folder = dirname(__DIR__) . '/fixtures/env'; + ...	true
vlucas/phpdotenv	423	issue_to_patch		[2.6] Added missing extension soft requirements		2a7dcf7e3e02dc5e701004e51a6f304b713107d5	cc01d5c9df6dc3ff7ea19396c89483f136d575e3	diff --git a/composer.json b/composer.json index 2db50fef..d04ddde1 100644 --- a/composer.json +++ b/composer.json @@ -11,9 +11,12 @@ } ], "require": { - "php": ">=5.3.9" + "php": ">=5.3.9", + "symfony/polyfill-ctype": "^1.9" }, "require-dev": { + "ext-filter": "...	[ "composer.json" ]	[]		true
vlucas/phpdotenv	422	issue_to_patch		[3.6] Apply fixes from StyleCI		eea090db1f84f11e540111969cddb6d1318787bb	e0b0892e54c7c9ec9f214a9f6a3116c347acf3e6	diff --git a/src/Environment/AbstractVariables.php b/src/Environment/AbstractVariables.php index 44f41053..9a9669ab 100644 --- a/src/Environment/AbstractVariables.php +++ b/src/Environment/AbstractVariables.php @@ -64,7 +64,7 @@ public function get($name) * * @return string\|null */ - protected abst...	[ "src/Environment/AbstractVariables.php", "src/Parser.php", "src/Validator.php", "tests/Dotenv/LinesTest.php" ]	[]	diff --git a/tests/Dotenv/LinesTest.php b/tests/Dotenv/LinesTest.php index 5a0fb349..fdb9ba34 100644 --- a/tests/Dotenv/LinesTest.php +++ b/tests/Dotenv/LinesTest.php @@ -30,7 +30,7 @@ public function testProcessQuotes() $expected = [ "TEST=\"test\n test\\\"test\\\"\n test\"", - ...	true
vlucas/phpdotenv	421	issue_to_patch		[3.6] Added names to travis builds		8f7961f7b9deb3b432452c18093cf16f88205902	31621bf0351948dffa5ee24c3a3cf21d94507657	diff --git a/.travis.yml b/.travis.yml index 88f86a64..9cf3ed05 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,40 +1,50 @@ matrix: include: - - dist: trusty + - name: HHVM 3.18 + dist: trusty language: php php: hhvm-3.18 install: travis_retry composer install --no-suggest --prefer-...	[ ".travis.yml" ]	[]		true
vlucas/phpdotenv	420	issue_to_patch		[3.6] Fixed allowedValues when not present	Closes #418. Closes #419.	8f7961f7b9deb3b432452c18093cf16f88205902	6b615ad69505997a4526c9590b0ccd5308b54fb8	diff --git a/src/Validator.php b/src/Validator.php index d8cdef47..3fb047e7 100644 --- a/src/Validator.php +++ b/src/Validator.php @@ -133,6 +133,10 @@ public function allowedValues(array $choices) { return $this->assertCallback( function ($value) use ($choices) { + if ($value ...	[ "src/Validator.php", "tests/Dotenv/ValidatorTest.php" ]	[]	diff --git a/tests/Dotenv/ValidatorTest.php b/tests/Dotenv/ValidatorTest.php index bf0edc01..eba6d8c4 100644 --- a/tests/Dotenv/ValidatorTest.php +++ b/tests/Dotenv/ValidatorTest.php @@ -39,6 +39,14 @@ public function testDotenvAllowedValuesIfPresent() $this->assertTrue(true); } + public function tes...	true
vlucas/phpdotenv	415	issue_to_patch		[4.1] Fix wrong namespace	A little namespace mistake	32bd5ca5a4170f88e27073353013d210a3354ae9	c133f20f99ad22cdf91a5c47ea1b41e508493492	diff --git a/UPGRADING.md b/UPGRADING.md index 0d0d4a08..662a73a5 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -15,7 +15,7 @@ The `getEnvironmentVariableNames` method is no longer available. This is because There have been various internal refactorings. Appart from what has already been mentioned, the only other ch...	[ "UPGRADING.md" ]	[]		true
vlucas/phpdotenv	413	issue_to_patch		Apply fixes from StyleCI		43f3fd77ef91ea87f3ceed4bb45c8ca558e4b3b3	2623ea2a85805b4a9c7ccc6e8e8a76c930bdb309	diff --git a/src/Dotenv.php b/src/Dotenv.php index 62d62837..022d47e9 100644 --- a/src/Dotenv.php +++ b/src/Dotenv.php @@ -9,7 +9,6 @@ use Dotenv\Loader\LoaderInterface; use Dotenv\Repository\RepositoryBuilder; use Dotenv\Repository\RepositoryInterface; -use Dotenv\Store\FileStore; use Dotenv\Store\StoreBuilder; u...	[ "src/Dotenv.php", "src/Loader/Loader.php", "src/Loader/Parser.php", "src/Repository/Adapter/PutenvAdapter.php", "src/Repository/RepositoryBuilder.php", "tests/Dotenv/LoaderTest.php", "tests/Dotenv/ParserTest.php" ]	[]	diff --git a/tests/Dotenv/LoaderTest.php b/tests/Dotenv/LoaderTest.php index 11a23a37..09077712 100644 --- a/tests/Dotenv/LoaderTest.php +++ b/tests/Dotenv/LoaderTest.php @@ -46,7 +46,7 @@ public function testLoaderWithGarbage() $this->expectException(InvalidFileException::class); $this->expectExcepti...	true
vlucas/phpdotenv	407	issue_to_patch		[4.1] Bumped minimum phpstan version		53d71b0f06da74743fd07b2eb8f295ab38f20210	74f5d200c387db0bff3120c412055236d2bc5755	diff --git a/vendor-bin/phpstan/composer.json b/vendor-bin/phpstan/composer.json index 4c238994..3acad44c 100644 --- a/vendor-bin/phpstan/composer.json +++ b/vendor-bin/phpstan/composer.json @@ -1,5 +1,5 @@ { "require": { - "phpstan/phpstan": "^0.12.3" + "phpstan/phpstan": "^0.12.5" } }	[ "vendor-bin/phpstan/composer.json" ]	[]		true
vlucas/phpdotenv	404	issue_to_patch		[4.1] Create .editorconfig		8d53579036bde1563f53e62926bb0dd86c6d38d2	e7561af8945a6a3ba8e32069e5759c101f411ef3	diff --git a/.editorconfig b/.editorconfig new file mode 100644 index 00000000..6537ca46 --- /dev/null +++ b/.editorconfig @@ -0,0 +1,15 @@ +root = true + +[] +charset = utf-8 +end_of_line = lf +insert_final_newline = true +indent_style = space +indent_size = 4 +trim_trailing_whitespace = true + +[.md] +trim_trailing...	[ ".editorconfig", ".gitattributes" ]	[]		true
vlucas/phpdotenv	402	issue_to_patch		Updated README header	// cc @vlucas	420a2a871e0e35ffb5f3336ddb51a9b547810066	917463b4a4a7ea38a5df0ce3a7bcc3b478df0a7d	diff --git a/README.md b/README.md index a11e21a4..025882c0 100644 --- a/README.md +++ b/README.md @@ -1,13 +1,55 @@ PHP dotenv ========== -Loads environment variables from `.env` to `getenv()`, `$_ENV` and -`$_SERVER` automagically. +Loads environment variables from `.env` to `getenv()`, `$_ENV` and `$_SERVER` aut...	[ "README.md" ]	[]		true
vlucas/phpdotenv	398	issue_to_patch		[4.1] Implement variable name whitelist	It is now possible to tell the loader to only allow a predefined set of variables to be loaded. Since whitelisting is a kinda edge case requirement, I'll not be adding special `create` methods, like I did for choosing between mutable and immutable. Directly newing up `Dotenv` will be required. This is to keep the inter...	6cd4f015a8d0ebb4501dad9ffa4245e6fed47118	6c8d174d3fe9471e28bdc97a84c86b3259b34a44	diff --git a/src/Loader/Loader.php b/src/Loader/Loader.php index b0b5a457..cce7c34c 100644 --- a/src/Loader/Loader.php +++ b/src/Loader/Loader.php @@ -8,6 +8,25 @@ class Loader implements LoaderInterface { + /** + * The variable name whitelist. + * + * @var string[]\|null + */ + protected $whit...	[ "src/Loader/Loader.php", "tests/Dotenv/LoaderTest.php" ]	[]	diff --git a/tests/Dotenv/LoaderTest.php b/tests/Dotenv/LoaderTest.php index eea7ce12..8c541824 100644 --- a/tests/Dotenv/LoaderTest.php +++ b/tests/Dotenv/LoaderTest.php @@ -20,6 +20,18 @@ public function testLoaderWithNoReaders() $this->assertSame($expected, $loader->load($repository, $content)); } + ...	true
vlucas/phpdotenv	399	issue_to_patch		[4.1] PHPStan Analysis		a6142d226aa3609a5573a343a62d377e03d5de97	fd21064cfa27f7d56ceedb5e148341451794020e	diff --git a/.gitattributes b/.gitattributes index 10e9ded6..44ad9edd 100644 --- a/.gitattributes +++ b/.gitattributes @@ -5,6 +5,8 @@ /.github export-ignore /.gitignore export-ignore /.travis.yml export-ignore +/phpstan.neon.dist export-ignore /phpunit.xml.dist export-ignore /README.md export-ignore /UPGRADING.m...	[ ".gitattributes", ".travis.yml", "composer.json", "phpstan.neon.dist", "src/Loader/Lines.php", "src/Loader/Loader.php", "src/Loader/Parser.php", "src/Regex/Regex.php", "src/Repository/Adapter/ApacheAdapter.php", "src/Repository/Adapter/ArrayAdapter.php", "src/Repository/Adapter/EnvConstAdapter.p...	[]		true
vlucas/phpdotenv	397	issue_to_patch		[4.1] Made store builder easier to use		a909e48d3197c7fefeb329dfd34c524974b2075b	1ceb8d3c7f8a0fdc666375305d949d6d48cf47c6	diff --git a/src/Dotenv.php b/src/Dotenv.php index 67179019..337becd3 100644 --- a/src/Dotenv.php +++ b/src/Dotenv.php @@ -60,7 +60,7 @@ public function __construct(LoaderInterface $loader, RepositoryInterface $reposi */ public static function create(RepositoryInterface $repository, $paths, $names = null, $s...	[ "src/Dotenv.php", "src/Store/StoreBuilder.php" ]	[]		true
vlucas/phpdotenv	395	issue_to_patch		[4.1] Refactor to use stores	I wasn't quite happy with the last PR. // cc @KarelWintersky, @sebastiansulinski. Changes since the last PR: 1. `Dotenv\File` namespace moved to `Dotenv\Store\File`. 2. `Dotenv\Dotenv` constructor final param now expects an instance of `Dotenv\Store\StoreInterface` or an array of paths (`string[]`). There are no...	a6bd169c0c29e4f204b6b1fdb15100f912dbe989	7738fec1fc5c5808b38ddb78c997a34476f5339f	diff --git a/UPGRADING.md b/UPGRADING.md index 6ceb882a..0d0d4a08 100644 --- a/UPGRADING.md +++ b/UPGRADING.md @@ -1,5 +1,9 @@ # Upgrading Guide +## V4.0 to V4.1 + +There are no breaking changes in this release, but the `Dotenv\Dotenv` constructor now expects either an array of file paths as the third parameter, or ...	[ "UPGRADING.md", "src/Dotenv.php", "src/Store/File/Paths.php", "src/Store/File/Reader.php", "src/Store/FileStore.php", "src/Store/StoreBuilder.php", "src/Store/StoreInterface.php", "tests/Dotenv/FileTest.php", "tests/Dotenv/StoreTest.php" ]	[]	diff --git a/tests/Dotenv/FileTest.php b/tests/Dotenv/FileTest.php deleted file mode 100644 index 6aaf463d..00000000 --- a/tests/Dotenv/FileTest.php +++ /dev/null @@ -1,56 +0,0 @@ -<?php - -use Dotenv\File\Paths; -use Dotenv\File\Reader; -use PHPUnit\Framework\TestCase; - -class FileTest extends TestCase -{ - /** - ...	true
vlucas/phpdotenv	396	issue_to_patch		[4.1] Apply fixes from StyleCI		2b967581194065f3ae74b6aaef9467625727355d	67bbd4b5aaca707615a1c37183aef3a5bb09524a	diff --git a/src/Dotenv.php b/src/Dotenv.php index f0396bf7..67179019 100644 --- a/src/Dotenv.php +++ b/src/Dotenv.php @@ -8,7 +8,6 @@ use Dotenv\Repository\RepositoryBuilder; use Dotenv\Repository\RepositoryInterface; use Dotenv\Store\StoreBuilder; -use PhpOption\Option; class Dotenv { diff --git a/src/Store/Fi...	[ "src/Dotenv.php", "src/Store/File/Paths.php", "tests/Dotenv/StoreTest.php" ]	[]	diff --git a/tests/Dotenv/StoreTest.php b/tests/Dotenv/StoreTest.php index 537fefbd..f746fa43 100644 --- a/tests/Dotenv/StoreTest.php +++ b/tests/Dotenv/StoreTest.php @@ -70,7 +70,7 @@ public function testFileReadMultipleWithoutShortCircuitModeDirect() { $this->assertSame( [ - ...	true
vlucas/phpdotenv	394	issue_to_patch	Add ability to load multiply _ENV files Pls, add ability to load multiply env files, smth like this: ``` $dotenv = \Dotenv\Dotenv::create(__DIR__, ['_env', '_env.db'] ); $dotenv->load(); ``` P.S. it NOT a duplicate of #205 , it is a feature request	[4.1] Support multiple file names and disabling short circuit file loading	It is now possible to specify multiple file names, as well as multiple directories to search. By default, we'll stop looking for files as soon as we find one, like we did when there were multiple directories. To disable this behaviour, and load all files in order, one can disable "short circuit" file loading with a new...	55dc9010920405c6fcf440667ab70a6a6f9a2ac7	a58c32fdf2e845853a02c54de96b05308c6c8f43	diff --git a/composer.json b/composer.json index 359ed65b..50360c8b 100644 --- a/composer.json +++ b/composer.json @@ -30,7 +30,7 @@ }, "extra": { "branch-alias": { - "dev-master": "4.0-dev" + "dev-master": "4.1-dev" } } } diff --git a/src/Dotenv.php b/src/Dotenv....	[ "composer.json", "src/Dotenv.php", "src/File/Paths.php", "src/File/Reader.php", "src/Loader/Loader.php", "src/Loader/LoaderInterface.php", "src/Repository/Adapter/ArrayAdapter.php", "tests/Dotenv/DotenvTest.php", "tests/Dotenv/FileTest.php", "tests/fixtures/.env", "tests/fixtures/env/example.env...	[]	diff --git a/tests/Dotenv/DotenvTest.php b/tests/Dotenv/DotenvTest.php index 8646281e..9f0d98a1 100644 --- a/tests/Dotenv/DotenvTest.php +++ b/tests/Dotenv/DotenvTest.php @@ -51,6 +51,12 @@ public function testDotenvTriesPathsToLoad() $this->assertCount(4, $dotenv->load()); } + public function testDo...	true
vlucas/phpdotenv	366	issue_to_patch		[3.5] Test on PHP 7.4		4b94724b2b01773ea0979ef1fddb10d118ee2d70	6d12c229e5b309ccbe57657a5d03dfbaf396c221	diff --git a/.travis.yml b/.travis.yml index af657215..88f86a64 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,18 +1,40 @@ -language: php -dist: trusty -sudo: false - -php: - - 5.4 - - 5.5 - - 5.5.9 - - 5.6 - - 7.0 - - 7.1 - - 7.2 - - 7.3 - - hhvm-3.18 - -install: travis_retry composer install --no-interacti...	[ ".travis.yml" ]	[]		true
vlucas/phpdotenv	367	issue_to_patch	Validator Methods Is there a way to run Validator methods such as notEmpty(), isInteger(), isBoolean(), allowedValues(), etc on environmental variables which are not required? In other words, the variable is not required, but if it exists, it should conform to the validation method. I have a use case for this, but ...	[3.5] Implemented ifPresent validation	Closes #365.	909287496de1f18e3bc283f10c558cc752c9a231	3b2f56150450b491fdbebb9f366c4b5d375ef5bf	diff --git a/src/Dotenv.php b/src/Dotenv.php index c4d22b79..41a2d3d5 100644 --- a/src/Dotenv.php +++ b/src/Dotenv.php @@ -135,6 +135,18 @@ public function required($variables) return new Validator((array) $variables, $this->loader); } + /** + * Returns a new validator object that won't check if ...	[ "src/Dotenv.php", "src/Validator.php", "tests/Dotenv/ValidatorTest.php" ]	[]	diff --git a/tests/Dotenv/ValidatorTest.php b/tests/Dotenv/ValidatorTest.php index 8750808a..1967d037 100644 --- a/tests/Dotenv/ValidatorTest.php +++ b/tests/Dotenv/ValidatorTest.php @@ -31,6 +31,14 @@ public function testDotenvAllowedValues() $this->assertTrue(true); } + public function testDotenvAl...	true
vlucas/phpdotenv	368	issue_to_patch		[3.5] Handle additional quoted escape sequences such as "\n"	Thanks to @danmichaelo for the implementation. Closes #363.	d320ce5b11348502ddf8561ecb93f1e85a1ea691	92ba1f6e3a37b6af52dd03a7b90560c662af6d50	diff --git a/src/Parser.php b/src/Parser.php index 62ec5559..0d8d46a5 100644 --- a/src/Parser.php +++ b/src/Parser.php @@ -134,6 +134,8 @@ private static function parseValue($value) case self::ESCAPE_STATE: if ($char === $value[0] \|\| $char === '\\') { retur...	[ "src/Parser.php", "tests/Dotenv/DotenvTest.php", "tests/Dotenv/LinesTest.php", "tests/Dotenv/ParserTest.php", "tests/fixtures/env/multiline.env" ]	[]	diff --git a/tests/Dotenv/DotenvTest.php b/tests/Dotenv/DotenvTest.php index 53eeb5d7..63184f4c 100644 --- a/tests/Dotenv/DotenvTest.php +++ b/tests/Dotenv/DotenvTest.php @@ -229,6 +229,9 @@ public function testMutlilineLoading() $dotenv = Dotenv::create($this->fixturesFolder, 'multiline.env'); $doten...	true
vlucas/phpdotenv	369	issue_to_patch		[3.6] Allow PHPUnit 7	Dropping PHPUnit 4 and supporting 8 and 9 can only happen once we drop support for PHP 5.4 and 5.5. For now, I won't do this, but if this becomes necessary to support PHP 8, I will.	95cb0fa6c025f7f0db7fc60f81e9fb231eb2d222	1c82347dcc4cb8ecc1d3a0a88b59492ba26c0c39	diff --git a/composer.json b/composer.json index 4b8e5b37..ad10f1bb 100644 --- a/composer.json +++ b/composer.json @@ -21,7 +21,7 @@ "symfony/polyfill-ctype": "^1.9" }, "require-dev": { - "phpunit/phpunit": "^4.8.35 \|\| ^5.0 \|\| ^6.0" + "phpunit/phpunit": "^4.8.35 \|\| ^5.0 \|\| ^6.0 \|\| ^7.0"...	[ "composer.json" ]	[]		true
vlucas/phpdotenv	371	issue_to_patch		[3.6] Added Validator::allowedRegexValues	Closes #370.	8e53d9a069c784dfc769903178454060fef15a93	2827bc55ead378e8692fc2c1f98e5506b570f091	diff --git a/README.md b/README.md index 1ad50618..2f8c9b2f 100644 --- a/README.md +++ b/README.md @@ -257,6 +257,11 @@ One or more environment variables failed assertions: SESSION_STORE is not an allowed value ``` +It is also possible to define a regex that your environment variable should be. +```php +$dotenv->re...	[ "README.md", "src/Regex/Regex.php", "src/Regex/Result.php", "src/Regex/Success.php", "src/Validator.php", "tests/Dotenv/ValidatorTest.php" ]	[]	diff --git a/tests/Dotenv/ValidatorTest.php b/tests/Dotenv/ValidatorTest.php index 1967d037..bf0edc01 100644 --- a/tests/Dotenv/ValidatorTest.php +++ b/tests/Dotenv/ValidatorTest.php @@ -408,4 +408,42 @@ public function testIfPresentIntegerNonExist() $dotenv->ifPresent(['VAR_DOES_NOT_EXIST_234782462764'])->isI...	true
vlucas/phpdotenv	385	issue_to_patch		[4.0] Drop PHP 5.4 and HHVM		e9b60fd90d7cf5037d34f62e6ffc6e07e89eb2dc	eea641d648922830e9e7c73fcd8a506fe1a5a682	diff --git a/.travis.yml b/.travis.yml index 88f86a64..bc3cba1d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,15 +1,5 @@ matrix: include: - - dist: trusty - language: php - php: hhvm-3.18 - install: travis_retry composer install --no-suggest --prefer-dist -n -o - script: vendor/bin/phpunit...	[ ".travis.yml", "composer.json" ]	[]		true
vnpy/vnpy	3,757	issue_to_patch		[Fix] mypy related warning	建议每次发起的PR内容尽可能精简，复杂的修改请拆分为多次PR，便于管理合并。 ## 改进内容 1. 2. 3. ## 相关的Issue号（如有） Close #	9b846dbddd19225d77a6030708718438ca871e1d	9fa3d43110b57b99da718a2f7fc12632940547e6	diff --git a/pyproject.toml b/pyproject.toml index bf1e4d0fda..37413b6909 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -53,6 +53,7 @@ alpha = [ ] dev = [ "pandas-stubs>=2.2.3.250308", + "scipy-stubs>=1.16.3.0", "hatchling>=1.27.0", "babel>=2.17.0", ] diff --git a/vnpy/alpha/dataset/ta_functi...	[ "pyproject.toml", "vnpy/alpha/dataset/ta_function.py", "vnpy/alpha/dataset/ts_function.py", "vnpy/alpha/model/models/mlp_model.py", "vnpy/alpha/strategy/backtesting.py" ]	[]		true
vnpy/vnpy	3,756	issue_to_patch		[Mod] refine dependabot config and harden workflow	建议每次发起的PR内容尽可能精简，复杂的修改请拆分为多次PR，便于管理合并。 ## 改进内容 1. 2. 3. ## 相关的Issue号（如有） Close #	384b2e4309123218fbd67579e46fbdb1811ba104	25ff0b4c27f2508635b2e3b0046fa173aed95d16	diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000000..782c7b7b4c --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,1 @@ +* @vnpy diff --git a/.github/dependabot.yml b/.github/dependabot.yml index ef9db44d04..a6189ae6f5 100644 --- a/.github/dependabot.yml +++ b/.github/dependabot.ym...	[ ".github/CODEOWNERS", ".github/dependabot.yml", ".github/workflows/pythonapp.yml" ]	[]		true

Subsets and Splits

No community queries yet

The top public SQL queries from the community will appear here once available.