repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
vuejs/core
14,899
comment_to_fix
refactor(runtime-vapor): simplify slot fallback model
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Hydrated slot vnode refresh leaves fallback validity stale.** This callback only refreshes `frag.nodes`. After hydration, `fallbackState.isContentValid()` and `frag.isBlockValid()` still read the old `contentState.valid`, so a hydrated slot-root branch that flips va...
b438f7aad03500484fcac015ba5b13fbcebb6dab
886aabb16439a14893162d378092bc8fc7f75a31
diff --git a/packages/runtime-vapor/src/vdomInterop.ts b/packages/runtime-vapor/src/vdomInterop.ts index dbfc6feae16..6ed93aa0c72 100644 --- a/packages/runtime-vapor/src/vdomInterop.ts +++ b/packages/runtime-vapor/src/vdomInterop.ts @@ -74,6 +74,7 @@ import { remove, } from './block' import { + EMPTY_ARR, EMPT...
[ "packages/runtime-vapor/src/vdomInterop.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Hydrated slot vnode refresh leaves fallback validity stale.**\n\nThis callback only refreshes `frag.nodes`. After hydration, `fallbackState.isContentValid()` and `frag.isBlockValid()` still read the old `contentState.valid`, so a hydrated slot...
true
vuejs/core
14,890
issue_to_patch
refactor(vapor): remove withVaporCtx slot wrapping
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Refactor** * Removed `withVaporCtx` helper from the public API. Internal slot context management has been refactored to streamline implementation while maintaining backward compatibility for standard slot usage...
6b2bf08ea67f3d98f6ff061b8334ebb8514a72af
731850aab02ab105fa040a5e7094a698e9ae95ee
diff --git a/packages/compiler-vapor/src/generators/component.ts b/packages/compiler-vapor/src/generators/component.ts index b9a0e6e640b..901bb6caae0 100644 --- a/packages/compiler-vapor/src/generators/component.ts +++ b/packages/compiler-vapor/src/generators/component.ts @@ -7,12 +7,8 @@ import { } from '@vue/shared'...
[ "packages/compiler-vapor/__tests__/__snapshots__/compile.spec.ts.snap", "packages/compiler-vapor/__tests__/transforms/__snapshots__/transformElement.spec.ts.snap", "packages/compiler-vapor/__tests__/transforms/__snapshots__/vSlot.spec.ts.snap", "packages/compiler-vapor/__tests__/transforms/vSlot.spec.ts", "...
[]
diff --git a/packages/compiler-vapor/__tests__/__snapshots__/compile.spec.ts.snap b/packages/compiler-vapor/__tests__/__snapshots__/compile.spec.ts.snap index b3fa2e79c67..490a65eca4c 100644 --- a/packages/compiler-vapor/__tests__/__snapshots__/compile.spec.ts.snap +++ b/packages/compiler-vapor/__tests__/__snapshots__/...
true
vuejs/core
14,896
issue_to_patch
fix(transition): avoid move transition for hidden v-show group children
align to #14895 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed a bug where elements entering via `v-show` inside a `transition-group` were incorrectly triggering move-transition effects. * **Tests** * Added end-to-end test cases to ve...
9691bc5a8d772ef02ce0096c9254283757b35ce2
0330c44b90cac167a667aae343789582caa4449c
diff --git a/packages-private/vapor-e2e-test/transition-group/cases/vapor-transition-group/v-show-enter-does-not-also-run-move-transition.vue b/packages-private/vapor-e2e-test/transition-group/cases/vapor-transition-group/v-show-enter-does-not-also-run-move-transition.vue new file mode 100644 index 00000000000..0bbce6d...
[ "packages-private/vapor-e2e-test/__tests__/transition-group.spec.ts", "packages-private/vapor-e2e-test/transition-group/cases/vapor-transition-group/v-show-enter-does-not-also-run-move-transition.vue", "packages/runtime-vapor/src/components/TransitionGroup.ts" ]
[]
diff --git a/packages-private/vapor-e2e-test/__tests__/transition-group.spec.ts b/packages-private/vapor-e2e-test/__tests__/transition-group.spec.ts index d37b7d82a67..97f06fa3d82 100644 --- a/packages-private/vapor-e2e-test/__tests__/transition-group.spec.ts +++ b/packages-private/vapor-e2e-test/__tests__/transition-g...
true
vuejs/core
14,905
issue_to_patch
[minor] scheduler performance issue ### Vue version 3.6.0-beta.13 ### Link to minimal reproduction https://github.com/vuejs/core/blob/minor/packages/runtime-core/src/scheduler.ts ### Steps to reproduce 1. `jobs` will never be truncated after flush, maybe for performance reason. 2. But `queueJobWorker` may grow `j...
fix(scheduler): reset job queue length after flush
Closes #14903 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed scheduler job queue memory management to ensure proper cleanup after flush operations. * **Tests** * Added test case to verify the job queue remains bounded during splice ope...
9691bc5a8d772ef02ce0096c9254283757b35ce2
231b573fa06cc7c443e6fde8ebb0650c85b275fb
diff --git a/packages/runtime-core/src/scheduler.ts b/packages/runtime-core/src/scheduler.ts index cf2abb920d2..c9f3fab20b3 100644 --- a/packages/runtime-core/src/scheduler.ts +++ b/packages/runtime-core/src/scheduler.ts @@ -294,6 +294,7 @@ function flushJobs(seen?: CountMap) { flushIndex = 0 jobsLength = 0...
[ "packages/runtime-core/__tests__/scheduler.spec.ts", "packages/runtime-core/src/scheduler.ts" ]
[]
diff --git a/packages/runtime-core/__tests__/scheduler.spec.ts b/packages/runtime-core/__tests__/scheduler.spec.ts index 90b27eaf4e3..19b675ecc23 100644 --- a/packages/runtime-core/__tests__/scheduler.spec.ts +++ b/packages/runtime-core/__tests__/scheduler.spec.ts @@ -110,6 +110,44 @@ describe('scheduler', () => { ...
true
vuejs/core
14,889
issue_to_patch
fix(runtime-vapor): avoid fast remove for component v-for
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed component unmounting issue when clearing v-for lists with fast removal optimization enabled. * Improved handling of default values in v-for destructuring patterns for correct updates. * E...
0e4c27901ffd566915fa701a546d404beef2b182
04c6153354c1f45113e129b037bded5c9350021a
diff --git a/packages/compiler-vapor/src/generators/for.ts b/packages/compiler-vapor/src/generators/for.ts index a3b908a59c0..8b0588cec5c 100644 --- a/packages/compiler-vapor/src/generators/for.ts +++ b/packages/compiler-vapor/src/generators/for.ts @@ -319,10 +319,10 @@ export function parseValueDestructure( ...
[ "packages/compiler-vapor/__tests__/transforms/__snapshots__/vFor.spec.ts.snap", "packages/compiler-vapor/__tests__/transforms/__snapshots__/vSlot.spec.ts.snap", "packages/compiler-vapor/__tests__/transforms/vFor.spec.ts", "packages/compiler-vapor/__tests__/transforms/vSlot.spec.ts", "packages/compiler-vapor...
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Warning text does not match accepted boundary.**\n\nLine 770 says “positive integer”, but Line 768 accepts `0` (no warning). Please align wording with behavior (or tighten the condition if strict positivity is intended).\n\n \n\n<details>\n<su...
diff --git a/packages/compiler-vapor/__tests__/transforms/__snapshots__/vFor.spec.ts.snap b/packages/compiler-vapor/__tests__/transforms/__snapshots__/vFor.spec.ts.snap index d5dbd314911..df8817b451e 100644 --- a/packages/compiler-vapor/__tests__/transforms/__snapshots__/vFor.spec.ts.snap +++ b/packages/compiler-vapor/...
true
vuejs/core
14,889
comment_to_fix
fix(runtime-vapor): avoid fast remove for component v-for
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ **Warning text does not match accepted boundary.** Line 770 says “positive integer”, but Line 768 accepts `0` (no warning). Please align wording with behavior (or tighten the condition if strict positivity is intended). <details> <summary>Suggested fix</summary> ...
0e4c27901ffd566915fa701a546d404beef2b182
04c6153354c1f45113e129b037bded5c9350021a
diff --git a/packages/runtime-vapor/src/apiCreateFor.ts b/packages/runtime-vapor/src/apiCreateFor.ts index 46232c69e24..8cf65e6ec2e 100644 --- a/packages/runtime-vapor/src/apiCreateFor.ts +++ b/packages/runtime-vapor/src/apiCreateFor.ts @@ -119,8 +119,9 @@ export const createFor = ( const frag = new ForFragment(ol...
[ "packages/runtime-vapor/src/apiCreateFor.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Warning text does not match accepted boundary.**\n\nLine 770 says “positive integer”, but Line 768 accepts `0` (no warning). Please align wording with behavior (or tighten the condition if strict positivity is intended).\n\n \n\n<details>\n<su...
true
vuejs/core
14,888
issue_to_patch
fix(runtime-vapor): preserve v-for item keys in transition group
<!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **New Features** * Added proper transition support for v-for loops, ensuring animated elements correctly inherit per-item keys during dynamic list updates. <!-- review_stack_entry_start --> [![Review Change Sta...
0354f880f52be7ded4d5b7b2eef097b509b0d5be
e91d0110e400cf889df365d4657e01cc188e773d
diff --git a/packages/runtime-vapor/src/apiCreateFor.ts b/packages/runtime-vapor/src/apiCreateFor.ts index 28035103e5b..46232c69e24 100644 --- a/packages/runtime-vapor/src/apiCreateFor.ts +++ b/packages/runtime-vapor/src/apiCreateFor.ts @@ -62,6 +62,7 @@ import { resetInsertionState, } from './insertionState' impo...
[ "packages/runtime-vapor/__tests__/components/TransitionGroup.spec.ts", "packages/runtime-vapor/src/apiCreateFor.ts" ]
[]
diff --git a/packages/runtime-vapor/__tests__/components/TransitionGroup.spec.ts b/packages/runtime-vapor/__tests__/components/TransitionGroup.spec.ts index ccd8df51994..f5f6068ab51 100644 --- a/packages/runtime-vapor/__tests__/components/TransitionGroup.spec.ts +++ b/packages/runtime-vapor/__tests__/components/Transit...
true
vuejs/core
14,821
issue_to_patch
perf(server-renderer): avoid materializing iterables in ssrRenderList
## Summary This PR removes an unnecessary intermediate array allocation in `ssrRenderList` when iterating over iterable sources (generators, `Set`, `Map`, custom iterables). ## Problem `ssrRenderList` handles `v-for` iteration during SSR. When the source is an object implementing `Symbol.iterator`, the current...
1ce598eb0ac7bed5bdc14857244424520498d29d
cbd77719a6ea32b8623c2e0b2023d1fb17478190
diff --git a/packages/server-renderer/src/helpers/ssrRenderList.ts b/packages/server-renderer/src/helpers/ssrRenderList.ts index 93bb8984764..6ee310eed62 100644 --- a/packages/server-renderer/src/helpers/ssrRenderList.ts +++ b/packages/server-renderer/src/helpers/ssrRenderList.ts @@ -21,9 +21,9 @@ export function ssrRe...
[ "packages/server-renderer/__tests__/ssrRenderList.spec.ts", "packages/server-renderer/src/helpers/ssrRenderList.ts" ]
[]
diff --git a/packages/server-renderer/__tests__/ssrRenderList.spec.ts b/packages/server-renderer/__tests__/ssrRenderList.spec.ts index 75ce66a7cfb..104aa9842fd 100644 --- a/packages/server-renderer/__tests__/ssrRenderList.spec.ts +++ b/packages/server-renderer/__tests__/ssrRenderList.spec.ts @@ -65,6 +65,45 @@ describe...
true
vuejs/core
14,877
issue_to_patch
Teleport + Suspense: unmount crashes on pending teleport with component child (regression since 3.5.31) ### Vue version 3.5.34 ### Link to minimal reproduction https://github.com/pont1s/vue-teleport-unmount-crashes ### Steps to reproduce #### Option 1 — Browser (primary) ```bash pnpm dev ``` 1. Open the browser...
fix(teleport): skip child unmount when pending mount discarded (#14876)
close #14876 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Resolved an issue where deferred teleports inside Suspense could attempt to mount or unmount discarded content when removed before completion, preventing stray or duplicate DOM updates...
bbdf86dcc6e3a8108c6313484ddfb52019b3e0e8
90743d71946014461e2993bc49f1810754210a4c
diff --git a/packages/runtime-core/src/components/Teleport.ts b/packages/runtime-core/src/components/Teleport.ts index 8e251bb70a4..236824fec31 100644 --- a/packages/runtime-core/src/components/Teleport.ts +++ b/packages/runtime-core/src/components/Teleport.ts @@ -331,15 +331,14 @@ export const TeleportImpl = { ...
[ "packages/runtime-core/__tests__/components/Suspense.spec.ts", "packages/runtime-core/__tests__/components/Teleport.spec.ts", "packages/runtime-core/src/components/Teleport.ts" ]
[ { "comment": "`hostRemove(anchor!)` uses a non-null assertion and only removes `anchor` before returning early. In this pending-mount discard case, returning early skips the rest of Teleport's remove logic; if placeholder nodes in the main view (e.g., start/end anchors) were already inserted, this can leak DOM ...
diff --git a/packages/runtime-core/__tests__/components/Suspense.spec.ts b/packages/runtime-core/__tests__/components/Suspense.spec.ts index 24954baca33..63560ce81da 100644 --- a/packages/runtime-core/__tests__/components/Suspense.spec.ts +++ b/packages/runtime-core/__tests__/components/Suspense.spec.ts @@ -2520,6 +252...
true
vuejs/core
14,865
issue_to_patch
`after-enter` event triggered even when `transition` wrapped in `keep-alive` never shows its child ### Vue version 3.5.22 ### Link to minimal reproduction https://play.vuejs.org/#eNp9UstOwzAQ/BXjS4tEkwOckFvxUA9wAAQcfQnppjV1bMt2SqUo/86u05Ty6iGxvTs7O2tPy6+dyzYN8EsuQumViyxAbNxMGlU76yNrmYeKdazytmYjhI72qVtbu108y+lATJiWp...
fix(runtime-core): skip idle persisted transition hooks in keep-alive moves
Fixes #14031. When a `<keep-alive>` activates or deactivates a cached child, the renderer's `move` function calls `transition.beforeEnter` / `transition.enter` (or `leave`) on every element vnode that carries a transition. For a normal transition this is correct, but for a persisted transition (the flag the template c...
d6c73713fe20c325e805583d9b2e595b8cd8a111
660751e566ba513fdec5c0005bd361142f7ef585
diff --git a/packages/runtime-core/src/renderer.ts b/packages/runtime-core/src/renderer.ts index f97ca24f143..cca3667d641 100644 --- a/packages/runtime-core/src/renderer.ts +++ b/packages/runtime-core/src/renderer.ts @@ -2082,9 +2082,16 @@ function baseCreateRenderer( transition if (needTransition) { ...
[ "packages/runtime-core/__tests__/components/BaseTransition.spec.ts", "packages/runtime-core/src/renderer.ts", "packages/vue/__tests__/e2e/Transition.spec.ts" ]
[ { "comment": "Requesting changes because the fix does address #14031, but the current blanket guard regresses the existing #13153 KeepAlive + pending v-show leave behavior.", "path": "packages/runtime-core/src/renderer.ts", "hunk": "@@ -2076,10 +2076,13 @@ function baseCreateRenderer(\n }\n \n /...
diff --git a/packages/runtime-core/__tests__/components/BaseTransition.spec.ts b/packages/runtime-core/__tests__/components/BaseTransition.spec.ts index 18cd43b0001..c541d5fc4c2 100644 --- a/packages/runtime-core/__tests__/components/BaseTransition.spec.ts +++ b/packages/runtime-core/__tests__/components/BaseTransition...
true
vuejs/core
14,861
issue_to_patch
compiler-core: <template v-for> + non-identifier :key + v-memo crashes with "Cannot read properties of undefined (reading 'trim')" ### Vue version `3.5.32` — also reproduces on every `3.5.13` through `3.5.34` (current `latest`), and on `3.6.0-beta.12`. Last working version is `3.5.12`. ### Link to minimal reproducti...
fix(compiler-core): avoid double processing v-for keys with v-memo
fix #14859 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Added snapshot tests covering memoization with v-for on elements and templates; expanded v-for key tests to include simple key expressions. * **Refactor** * Adjusted compiler handling of m...
1ce598eb0ac7bed5bdc14857244424520498d29d
d2f94e4377a77ae1d56c8dd891f9f4a970fe0b1f
diff --git a/packages/compiler-core/src/transforms/vFor.ts b/packages/compiler-core/src/transforms/vFor.ts index 6c466538714..21396dc31e1 100644 --- a/packages/compiler-core/src/transforms/vFor.ts +++ b/packages/compiler-core/src/transforms/vFor.ts @@ -71,33 +71,27 @@ export const transformFor: NodeTransform = createSt...
[ "packages/compiler-core/__tests__/transforms/__snapshots__/vMemo.spec.ts.snap", "packages/compiler-core/__tests__/transforms/vFor.spec.ts", "packages/compiler-core/__tests__/transforms/vMemo.spec.ts", "packages/compiler-core/src/transforms/vFor.ts" ]
[]
diff --git a/packages/compiler-core/__tests__/transforms/__snapshots__/vMemo.spec.ts.snap b/packages/compiler-core/__tests__/transforms/__snapshots__/vMemo.spec.ts.snap index 19222fd2360..5fc14defb43 100644 --- a/packages/compiler-core/__tests__/transforms/__snapshots__/vMemo.spec.ts.snap +++ b/packages/compiler-core/_...
true
vuejs/core
14,828
issue_to_patch
perf(runtime-dom): optimize array event handler dispatch
## Summary - Avoid per-dispatch `Array.map` and wrapper closure allocations for runtime-dom event handler arrays. - Preserve `stopImmediatePropagation()` behavior by stopping later handlers in the same array. - Add regression coverage for the allocation path and stop-immediate behavior. - Add a runtime-dom event dispa...
1ce598eb0ac7bed5bdc14857244424520498d29d
94babcf23cc0cda6195342bd2deec08f2448eee7
diff --git a/packages/runtime-dom/src/modules/events.ts b/packages/runtime-dom/src/modules/events.ts index 600b0840cde..fd973d024ae 100644 --- a/packages/runtime-dom/src/modules/events.ts +++ b/packages/runtime-dom/src/modules/events.ts @@ -112,12 +112,37 @@ function createInvoker( } else if (e._vts <= invoker.att...
[ "packages/runtime-dom/__tests__/patchEvents.spec.ts", "packages/runtime-dom/src/modules/events.ts" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Snapshot handler array length before iterating**\n\nIterating with `i < value.length` makes dispatch observe in-loop mutations to the same handler array, which changes previous behavior and can hang the event l...
diff --git a/packages/runtime-dom/__tests__/patchEvents.spec.ts b/packages/runtime-dom/__tests__/patchEvents.spec.ts index f70bf327aff..1578f7ba06c 100644 --- a/packages/runtime-dom/__tests__/patchEvents.spec.ts +++ b/packages/runtime-dom/__tests__/patchEvents.spec.ts @@ -43,6 +43,29 @@ describe(`runtime-dom: events pa...
true
vuejs/core
14,828
comment_to_fix
perf(runtime-dom): optimize array event handler dispatch
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Snapshot handler array length before iterating** Iterating with `i < value.length` makes dispatch observe in-loop mutations to the same handler array, which changes previous behavior and can hang the event loop. If a handler append...
1ce598eb0ac7bed5bdc14857244424520498d29d
94babcf23cc0cda6195342bd2deec08f2448eee7
diff --git a/packages/runtime-dom/src/modules/events.ts b/packages/runtime-dom/src/modules/events.ts index 600b0840cde..fd973d024ae 100644 --- a/packages/runtime-dom/src/modules/events.ts +++ b/packages/runtime-dom/src/modules/events.ts @@ -112,12 +112,37 @@ function createInvoker( } else if (e._vts <= invoker.att...
[ "packages/runtime-dom/src/modules/events.ts" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Snapshot handler array length before iterating**\n\nIterating with `i < value.length` makes dispatch observe in-loop mutations to the same handler array, which changes previous behavior and can hang the event l...
true
vuejs/core
14,860
issue_to_patch
perf(reactivity): skip type checks for cached proxies
## Summary - Check the existing proxy cache before computing the target raw type in createReactiveObject. - Preserve the markRaw / non-extensible early return before the cache lookup. - Add benchmarks for cached reactive objects and nested reactive property access. ## Test Plan - pnpm exec vitest run --project=unit ...
1ce598eb0ac7bed5bdc14857244424520498d29d
bc25d3d3b25861778526cb642ea492ee6e94157d
diff --git a/packages/reactivity/__benchmarks__/reactiveObject.bench.ts b/packages/reactivity/__benchmarks__/reactiveObject.bench.ts index 1b444d4fec6..c1284fc5966 100644 --- a/packages/reactivity/__benchmarks__/reactiveObject.bench.ts +++ b/packages/reactivity/__benchmarks__/reactiveObject.bench.ts @@ -5,6 +5,14 @@ be...
[ "packages/reactivity/__benchmarks__/reactiveObject.bench.ts", "packages/reactivity/src/reactive.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Benchmark body does not match nested-access intent.**\n\nThe case labeled “read nested reactive obj property” currently reads only `r.a`. It should read the nested property to measure the intended path (Line 26).\n\n \n\n<details>\n<summary>Su...
true
vuejs/core
14,860
comment_to_fix
perf(reactivity): skip type checks for cached proxies
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ **Benchmark body does not match nested-access intent.** The case labeled “read nested reactive obj property” currently reads only `r.a`. It should read the nested property to measure the intended path (Line 26). <details> <summary>Suggested fix</summary> ```diff ...
1ce598eb0ac7bed5bdc14857244424520498d29d
bc25d3d3b25861778526cb642ea492ee6e94157d
diff --git a/packages/reactivity/__benchmarks__/reactiveObject.bench.ts b/packages/reactivity/__benchmarks__/reactiveObject.bench.ts index 1b444d4fec6..c1284fc5966 100644 --- a/packages/reactivity/__benchmarks__/reactiveObject.bench.ts +++ b/packages/reactivity/__benchmarks__/reactiveObject.bench.ts @@ -5,6 +5,14 @@ be...
[ "packages/reactivity/__benchmarks__/reactiveObject.bench.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Benchmark body does not match nested-access intent.**\n\nThe case labeled “read nested reactive obj property” currently reads only `r.a`. It should read the nested property to measure the intended path (Line 26).\n\n \n\n<details>\n<summary>Su...
true
vuejs/core
14,857
issue_to_patch
logMismatchError() called redundantly in loop when SSR has excess child nodes ### Version 3.6.0-beta.12 ### Reproduction link [github.com](https://github.com/vuejs/core/blob/main/packages/runtime-core/src/hydration.ts#L431-L450) ### Steps to reproduce 1. Open packages/runtime-core/src/hydration.ts 2. Find the ...
fix(runtime-core): avoid repeated hydration mismatch checks
close #14855 <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Fixed duplicate warning messages during SSR hydration mismatches. Diagnostics are now emitted only once per mismatch event, reducing console noise and improving debugging clarity. * *...
1ce598eb0ac7bed5bdc14857244424520498d29d
b50e0b2ca9e5aa18c8b54d582a70fc893348e24f
diff --git a/packages/runtime-core/src/hydration.ts b/packages/runtime-core/src/hydration.ts index a687d28d380..464db7519b6 100644 --- a/packages/runtime-core/src/hydration.ts +++ b/packages/runtime-core/src/hydration.ts @@ -427,23 +427,16 @@ export function createHydrationFunctions( slotScopeIds, ...
[ "packages/runtime-core/__tests__/hydration.spec.ts", "packages/runtime-core/src/hydration.ts" ]
[]
diff --git a/packages/runtime-core/__tests__/hydration.spec.ts b/packages/runtime-core/__tests__/hydration.spec.ts index 92b2edb7833..2fe64910403 100644 --- a/packages/runtime-core/__tests__/hydration.spec.ts +++ b/packages/runtime-core/__tests__/hydration.spec.ts @@ -2143,6 +2143,53 @@ describe('SSR hydration', () => ...
true
vuejs/core
14,805
issue_to_patch
`addTypeTemplate` prevents the exported types of added files from being resolved by compiler-sfc ### Environment - Operating System: `Darwin` - Node Version: `v24.10.0` - Nuxt Version: `4.2.1` - CLI Version: `3.30.0` - Nitro Version: `2.12.9` - Package Manager: `pnpm@10.21.0` - Builder: `-` ...
fix(compiler-sfc): resolve top-level exports from files registered as global types
resolves nuxt/nuxt#33694 the issue is that files registered as `globalTypeFiles` that contain plain top-level `export` declarations (no `declare global { ... }`) were cached with an empty TypeScope and that cached scope was then reused for regular `import { Foo } from '...'` resolution, so imports of those types fai...
57545e958ae28ed17aa9e0ed321abcd8dc99f752
4147eabf75c7153cd9fa78406125702a4b439f4a
diff --git a/packages/compiler-sfc/src/script/resolveType.ts b/packages/compiler-sfc/src/script/resolveType.ts index a7f16711bc8..33a461d0b68 100644 --- a/packages/compiler-sfc/src/script/resolveType.ts +++ b/packages/compiler-sfc/src/script/resolveType.ts @@ -1193,7 +1193,12 @@ function loadTSConfig( return res } ...
[ "packages/compiler-sfc/__tests__/compileScript/resolveType.spec.ts", "packages/compiler-sfc/src/script/resolveType.ts" ]
[]
diff --git a/packages/compiler-sfc/__tests__/compileScript/resolveType.spec.ts b/packages/compiler-sfc/__tests__/compileScript/resolveType.spec.ts index f7eb3b7c9e0..18eb3cc6b22 100644 --- a/packages/compiler-sfc/__tests__/compileScript/resolveType.spec.ts +++ b/packages/compiler-sfc/__tests__/compileScript/resolveType...
true
vuejs/core
14,804
issue_to_patch
render issues does not throw in SSR ### Environment - Operating System: Windows_NT - Node Version: v21.7.3 - Nuxt Version: 3.12.2 - CLI Version: 3.12.0 - Nitro Version: 2.9.6 - Package Manager: pnpm@9.2.0 - Builder: - - User Config: - - Runtime Modules: - - Build Modules: ...
fix(server-renderer): propagate sync errors from `ssrRenderSuspense`
resolves nuxt/nuxt#28162 we want errors when rendering to throw - but at the moment a sync throw inside the default slot gets converted by the async-function machinery into a rejected `Promise<void>` that is then thrown away... <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary b...
57545e958ae28ed17aa9e0ed321abcd8dc99f752
1065869512fed670f96787f96405152020cb7b06
diff --git a/packages/server-renderer/src/helpers/ssrRenderSuspense.ts b/packages/server-renderer/src/helpers/ssrRenderSuspense.ts index 1c6823afa95..1f41d00aa5f 100644 --- a/packages/server-renderer/src/helpers/ssrRenderSuspense.ts +++ b/packages/server-renderer/src/helpers/ssrRenderSuspense.ts @@ -1,9 +1,12 @@ impor...
[ "packages/server-renderer/__tests__/ssrSuspense.spec.ts", "packages/server-renderer/src/helpers/ssrRenderSuspense.ts" ]
[]
diff --git a/packages/server-renderer/__tests__/ssrSuspense.spec.ts b/packages/server-renderer/__tests__/ssrSuspense.spec.ts index eef642d0042..5f8cecaf986 100644 --- a/packages/server-renderer/__tests__/ssrSuspense.spec.ts +++ b/packages/server-renderer/__tests__/ssrSuspense.spec.ts @@ -1,5 +1,7 @@ -import { Suspense,...
true
vuejs/vue-cli
7,443
issue_to_patch
Add missing default __VUE_PROD_HYDRATION_MISMATCH_DETAILS__
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
f0f254e4bc81ed322eeb9f7de346e987e845068e
47e69867fd60a72defd5f7524953054fa30dd756
diff --git a/packages/@vue/cli-service/lib/config/base.js b/packages/@vue/cli-service/lib/config/base.js index 5326590e8a..a1ff9c3a82 100644 --- a/packages/@vue/cli-service/lib/config/base.js +++ b/packages/@vue/cli-service/lib/config/base.js @@ -158,7 +158,8 @@ module.exports = (api, options) => { .plugin('fe...
[ "packages/@vue/cli-service/lib/config/base.js" ]
[]
true
vuejs/vue-cli
6,307
issue_to_patch
feat(GeneratorAPI): `forceOverwrite` option for `extendPackage`
Sometimes we need to force using an older version of a dependency, such as in the webpack-4 plugin. **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, please describe: **D...
9e5b194abff34c6bd05ac92fceb18cac1c803f01
c3248398488ac1fbbd07f95e16e712eda096fae2
diff --git a/packages/@vue/cli-plugin-webpack-4/generator.js b/packages/@vue/cli-plugin-webpack-4/generator.js index 83d10e9165..ae0ea29973 100644 --- a/packages/@vue/cli-plugin-webpack-4/generator.js +++ b/packages/@vue/cli-plugin-webpack-4/generator.js @@ -44,7 +44,8 @@ module.exports = (api) => { return toMer...
[ "packages/@vue/cli-plugin-webpack-4/generator.js", "packages/@vue/cli/__tests__/Generator.spec.js", "packages/@vue/cli/lib/GeneratorAPI.js", "packages/@vue/cli/lib/util/mergeDeps.js", "packages/@vue/cli/types/cli-test.ts", "packages/@vue/cli/types/index.d.ts" ]
[]
diff --git a/packages/@vue/cli/__tests__/Generator.spec.js b/packages/@vue/cli/__tests__/Generator.spec.js index 63ed6ea858..a7f4334574 100644 --- a/packages/@vue/cli/__tests__/Generator.spec.js +++ b/packages/@vue/cli/__tests__/Generator.spec.js @@ -523,6 +523,41 @@ test('api: extendPackage + { warnIncompatibleVersion...
true
vuejs/vue-cli
6,487
issue_to_patch
update deployment.md
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [x] Docs - [ ] Underlying tools - [ ] Other, ...
c64798dce3c93e8de2dad702f5df656d6d3beb81
06ee988f6621589466081fcc1db9748798ceda40
diff --git a/docs/zh/guide/deployment.md b/docs/zh/guide/deployment.md index 57fdad7e9f..c723562db9 100644 --- a/docs/zh/guide/deployment.md +++ b/docs/zh/guide/deployment.md @@ -19,7 +19,7 @@ serve -s dist ### 使用 `history.pushState` 的路由 -如果你在 `history` 模式下使用 Vue Router,是无法搭配简单的静态文件服务器的。例如,如果你使用 Vue Router 为 `/tod...
[ "docs/zh/guide/deployment.md" ]
[]
true
vuejs/vue-cli
4,275
issue_to_patch
feat!: confirm before invoke/add/upgrade if project has uncommitted changes
9be9b6c4cd4d3ba41bb02fb7ea7564f5ac52130a
72d632045e4f9f8e2513f6873aecdb83aa394d32
diff --git a/packages/@vue/cli/lib/add.js b/packages/@vue/cli/lib/add.js index 8f6b989c63..a10b49cc6e 100644 --- a/packages/@vue/cli/lib/add.js +++ b/packages/@vue/cli/lib/add.js @@ -10,8 +10,13 @@ const { resolvePluginId, resolveModule } = require('@vue/cli-shared-utils') +const confirmIfGitDirty = require('./u...
[ "packages/@vue/cli/__tests__/invoke.spec.js", "packages/@vue/cli/lib/add.js", "packages/@vue/cli/lib/invoke.js", "packages/@vue/cli/lib/upgrade.js", "packages/@vue/cli/lib/util/confirmIfGitDirty.js", "scripts/testSetup.js" ]
[]
diff --git a/packages/@vue/cli/__tests__/invoke.spec.js b/packages/@vue/cli/__tests__/invoke.spec.js index 82cc0f26b3..ab3f1888ee 100644 --- a/packages/@vue/cli/__tests__/invoke.spec.js +++ b/packages/@vue/cli/__tests__/invoke.spec.js @@ -149,3 +149,20 @@ test('invoking a plugin that renames files', async () => { aw...
true
vuejs/vue-cli
6,411
issue_to_patch
feat: implement plugin execution order
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> - [x] test - [ ] doc If there is nothing wrong with the code and design, I can try to add documentation **What kind of change does this PR introduce?** (check at least one) - [ ] Bu...
ee9a8d259806a6733036d8f55ae7ccd8a8fc751c
a60ccef07a59d3f9be870a5049cc47b6ef8dcd09
diff --git a/packages/@vue/cli-plugin-typescript/generator/index.js b/packages/@vue/cli-plugin-typescript/generator/index.js index dc776d10b8..2c86584e18 100644 --- a/packages/@vue/cli-plugin-typescript/generator/index.js +++ b/packages/@vue/cli-plugin-typescript/generator/index.js @@ -71,3 +71,5 @@ module.exports = ( ...
[ "packages/@vue/cli-plugin-typescript/__tests__/tsGenerator.spec.js", "packages/@vue/cli-plugin-typescript/generator/index.js", "packages/@vue/cli-service/__tests__/Service.spec.js", "packages/@vue/cli-service/lib/Service.js", "packages/@vue/cli-shared-utils/__tests__/pluginOrder.spec.js", "packages/@vue/c...
[]
diff --git a/packages/@vue/cli-plugin-typescript/__tests__/tsGenerator.spec.js b/packages/@vue/cli-plugin-typescript/__tests__/tsGenerator.spec.js index a745786439..f2fd642900 100644 --- a/packages/@vue/cli-plugin-typescript/__tests__/tsGenerator.spec.js +++ b/packages/@vue/cli-plugin-typescript/__tests__/tsGenerator.s...
true
vuejs/vue-cli
7,222
issue_to_patch
fix: add "devServer.server.type" to "useHttps" judgement
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
4a0655f7ac09b64d2b47506e7f21e7923d43262b
9027e4cbe0dec26d6ed3355e43eff4b79c2a3967
diff --git a/packages/@vue/cli-service/lib/commands/serve.js b/packages/@vue/cli-service/lib/commands/serve.js index b0063cb6cc..aef507398c 100644 --- a/packages/@vue/cli-service/lib/commands/serve.js +++ b/packages/@vue/cli-service/lib/commands/serve.js @@ -108,7 +108,8 @@ module.exports = (api, options) => { con...
[ "packages/@vue/cli-service/lib/commands/serve.js" ]
[]
true
vuejs/vue-cli
6,645
issue_to_patch
fix(cli-service): wrong property name (typo)
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [x] Other, ...
ded81c6057d5605728aab34dc2ee47500671d17c
b2f70c3822864553d1f2de6971b7059a08975115
diff --git a/packages/@vue/cli-service/lib/commands/build/resolveAppConfig.js b/packages/@vue/cli-service/lib/commands/build/resolveAppConfig.js index d990598fa2..42534f3603 100644 --- a/packages/@vue/cli-service/lib/commands/build/resolveAppConfig.js +++ b/packages/@vue/cli-service/lib/commands/build/resolveAppConfig....
[ "packages/@vue/cli-service/lib/commands/build/resolveAppConfig.js" ]
[]
true
vuejs/vue-cli
6,714
issue_to_patch
feat(cli-plugin-eslint): use ESLint class instead of CLIEngine
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> This PR replaces CLIEngine with the ESLint class. CLIEngine will be removed in eslint v8 and must be replaced with the ESLint class to support eslint v8. **What kind of change does this P...
3f0b782bca7df17740b72509c42e5e2ea6562ac9
a00287507436c743f769d21f20e81aaebf9256ee
diff --git a/packages/@vue/cli-plugin-eslint/generator/index.js b/packages/@vue/cli-plugin-eslint/generator/index.js index 01f39dde44..7bdfb31213 100644 --- a/packages/@vue/cli-plugin-eslint/generator/index.js +++ b/packages/@vue/cli-plugin-eslint/generator/index.js @@ -69,8 +69,8 @@ module.exports = (api, { config, li...
[ "packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js", "packages/@vue/cli-plugin-eslint/generator/index.js", "packages/@vue/cli-plugin-eslint/index.js", "packages/@vue/cli-plugin-eslint/lint.js", "packages/@vue/cli-service/types/cli-service-test.ts", "scripts/buildEditorConfig.js", "scripts/r...
[ { "comment": "With\r\n```\r\nenv: ['overrideConfig', 'env'],\r\nglobal: ['overrideConfig', 'globals'],\r\n```\r\n\r\n`--env browser --global window` gets normalized to\r\n```\r\n{\r\n overrideConfig: {},\r\n env: ['browser'],\r\n globals: ['window']\r\n}\r\n```\r\nIs this the intended result?\r\nBecause in m...
diff --git a/packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js b/packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js index 6245a034c0..1538c20841 100644 --- a/packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js +++ b/packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js @@ -2...
true
vuejs/vue-cli
6,817
issue_to_patch
feat: generate `vue.config.js` with `defineConfig` wrapper
So that users can have better IntelliSense by default. **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, please describe: **Does this PR introduce a breaking change?** (chec...
5e9fa1ebebd2c3c7b93cc8348c698b35c7d5fcb1
dc7bc8674d3065b44b49a74505e7af8e180c0094
diff --git a/packages/@vue/cli/lib/util/configTransforms.js b/packages/@vue/cli/lib/util/configTransforms.js index adf4c08ad5..73aea4e997 100644 --- a/packages/@vue/cli/lib/util/configTransforms.js +++ b/packages/@vue/cli/lib/util/configTransforms.js @@ -18,7 +18,7 @@ const transformJS = { return null } ...
[ "packages/@vue/cli/__tests__/Generator.spec.js", "packages/@vue/cli/lib/util/__tests__/extendJSConfig.spec.js", "packages/@vue/cli/lib/util/configTransforms.js", "packages/@vue/cli/lib/util/extendJSConfig.js" ]
[]
diff --git a/packages/@vue/cli/__tests__/Generator.spec.js b/packages/@vue/cli/__tests__/Generator.spec.js index 0183d9f54e..0f537b046b 100644 --- a/packages/@vue/cli/__tests__/Generator.spec.js +++ b/packages/@vue/cli/__tests__/Generator.spec.js @@ -1012,7 +1012,9 @@ test('api: addConfigTransform transform vue warn', ...
true
vuejs/vue-cli
7,324
issue_to_patch
chore(deps): bump loader-utils from 1.4.0 to 1.4.1
Bumps [loader-utils](https://github.com/webpack/loader-utils) from 1.4.0 to 1.4.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/webpack/loader-utils/releases">loader-utils's releases</a>.</em></p> <blockquote> <h2>v1.4.1</h2> <h3><a href="https://github.com/webpack/loader-u...
ea4c98ae84f20d410126707a1defc58a33998e8b
00b3ff12f4d56757fa20374cfcfed352b7c7c6cf
diff --git a/yarn.lock b/yarn.lock index c48eacde12..cb1bbd2f41 100644 --- a/yarn.lock +++ b/yarn.lock @@ -13886,9 +13886,9 @@ loader-runner@^4.1.0, loader-runner@^4.2.0: integrity sha512-92+huvxMvYlMzMt0iIOukcwYBFpkYJdpl2xsZ7LrlayO7E8SOv+JJUEK17B/dJIHAOLMfh2dZZ/Y18WgmGtYNw== loader-utils@^1.0.2, loader-utils@^1....
[ "yarn.lock" ]
[]
true
vuejs/vue-cli
2,932
issue_to_patch
chore(eslint-config-prettier): Upgrade prettier and extend configuration
This PR updates the prettier and related packages, as well as extends eslint configuration, so it doesn't conflict with `eslint-plugin-vue` visual rules.
5d49d5796648cc92277cef79616cc66aa6148f73
fbb55f40e4c0ea1ca91707a1a81db5f0a516cc4b
diff --git a/packages/@vue/eslint-config-prettier/index.js b/packages/@vue/eslint-config-prettier/index.js index 38787a0358..5c7acff094 100644 --- a/packages/@vue/eslint-config-prettier/index.js +++ b/packages/@vue/eslint-config-prettier/index.js @@ -2,7 +2,8 @@ module.exports = { plugins: ['prettier'], extends: ...
[ "packages/@vue/eslint-config-prettier/index.js", "packages/@vue/eslint-config-prettier/package.json", "yarn.lock" ]
[]
true
vuejs/vue-cli
3,485
issue_to_patch
Add .mjs files as transpileable files
I'm not 100% sure but the option transpileDependencies in vue.config.js did not work for dependencies that use .mjs files. This small regex change fixes that problem.
c078633be1127b0dd19b0ccb1b6cb6022288d960
77ba634594944b6f71bac364e4e0608d6cfd05b8
diff --git a/packages/@vue/cli-plugin-babel/index.js b/packages/@vue/cli-plugin-babel/index.js index e5d1870e64..55ea4e6c7d 100644 --- a/packages/@vue/cli-plugin-babel/index.js +++ b/packages/@vue/cli-plugin-babel/index.js @@ -25,7 +25,7 @@ module.exports = (api, options) => { const jsRule = webpackConfig.module...
[ "packages/@vue/cli-plugin-babel/index.js" ]
[]
true
vuejs/vue-cli
7,265
issue_to_patch
fix: pnpm v7 install error
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
e63681735f01e5f22f0791251683c8418aa2aa8e
d7baae2bf2a44cd81acc17f3dc159fdbd7a79926
diff --git a/packages/@vue/cli/lib/Creator.js b/packages/@vue/cli/lib/Creator.js index 05e1754ecd..d502972517 100644 --- a/packages/@vue/cli/lib/Creator.js +++ b/packages/@vue/cli/lib/Creator.js @@ -167,7 +167,8 @@ module.exports = class Creator extends EventEmitter { // generate a .npmrc file for pnpm, to persist...
[ "packages/@vue/cli/lib/Creator.js" ]
[]
true
vuejs/vue-cli
7,210
issue_to_patch
Security vulnerability in dicer / busboy dependency of apollo-server 2.x used by @vue/cli ### Version 5.0.6 ### Reproduction link [github.com](https://github.com/apollographql/apollo-server/security/advisories/GHSA-2p3c-p3qw-69r4) ### Environment info ``` @vue/cli 5.0.6 and 4.5.18 ``` ### Steps...
chore: upgrade to apollo-server-express 3.x
Fixes #7198 **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [x] Other, please describe: **Does this PR introduce a breaking change?** (check one) - [ ] Yes - [x] No **Other ...
ef08a08c41b028a2484f262414a8c91d151febc7
e7a408bbb8029dcfa5f8a6117b4f3fb1e9cc4810
diff --git a/packages/@vue/cli-ui/graphql-server.js b/packages/@vue/cli-ui/graphql-server.js index 1215994fde..38cc173f52 100644 --- a/packages/@vue/cli-ui/graphql-server.js +++ b/packages/@vue/cli-ui/graphql-server.js @@ -19,7 +19,7 @@ function autoCall (fn, ...context) { return fn } -module.exports = (options, ...
[ "packages/@vue/cli-ui/graphql-server.js", "packages/@vue/cli-ui/package.json", "packages/@vue/cli/lib/ui.js", "yarn.lock" ]
[]
true
vuejs/vue-cli
7,202
issue_to_patch
fix: optimize the judgment on whether HTTPS has been set in options
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
ef08a08c41b028a2484f262414a8c91d151febc7
acc81e65f7603012254d6c6eba0b6526633b6528
diff --git a/packages/@vue/cli-service/lib/commands/serve.js b/packages/@vue/cli-service/lib/commands/serve.js index cc66855e8b..c4fad51798 100644 --- a/packages/@vue/cli-service/lib/commands/serve.js +++ b/packages/@vue/cli-service/lib/commands/serve.js @@ -101,7 +101,11 @@ module.exports = (api, options) => { } ...
[ "packages/@vue/cli-service/lib/commands/serve.js" ]
[]
true
vuejs/vue-cli
7,101
issue_to_patch
fix: add XMLSerializer to the global scope
In @vue/test-utils 2.0.0rc18, The usage of `XMLSerializer` was introduced: https://github.com/vuejs/test-utils/blob/d86cbc333de7b2ec1208f5d3c65e0879671dd01e/src/utils/stringifyNode.ts#L4 `XMLSerializer` needs to be available as a global so `cli-plugin-unit-mocha` will stay compatible with newer versions of @vue/test...
940e4363a55f76013d0509de7c1433b03619585e
535fff69b8e77b4010559df2af6164d05f6a251a
diff --git a/packages/@vue/cli-plugin-unit-mocha/setup.js b/packages/@vue/cli-plugin-unit-mocha/setup.js index df81b0b514..accf1e4405 100644 --- a/packages/@vue/cli-plugin-unit-mocha/setup.js +++ b/packages/@vue/cli-plugin-unit-mocha/setup.js @@ -6,3 +6,6 @@ window.Date = Date global.ShadowRoot = window.ShadowRoot ...
[ "packages/@vue/cli-plugin-unit-mocha/setup.js" ]
[]
true
vuejs/vue-cli
7,167
issue_to_patch
Running vue upgrade changes package.json structure ### Version 4.4.4 ### Reproduction link [https://github.com/mcfarljw/vue-cli-upgrade-issue](https://github.com/mcfarljw/vue-cli-upgrade-issue) ### Environment info ``` System: OS: macOS 10.15.5 CPU: (20) x64 Intel(R) Xeon(R) W-2150B CPU @ 3...
feat(upgrade): prevent changing the structure of package.json file during upgrade
close #5577 <!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools...
ce97e62304e884c4277aaa1b605f735253e4205b
7a0cca67c69f54c68fe9ec4ea40d4563824010dc
diff --git a/packages/@vue/cli/lib/Generator.js b/packages/@vue/cli/lib/Generator.js index 5b26ee78cc..9766a82295 100644 --- a/packages/@vue/cli/lib/Generator.js +++ b/packages/@vue/cli/lib/Generator.js @@ -192,7 +192,8 @@ module.exports = class Generator { async generate ({ extractConfigFiles = false, - c...
[ "packages/@vue/cli/lib/Generator.js", "packages/@vue/cli/lib/migrate.js" ]
[]
true
vuejs/vue-cli
7,158
issue_to_patch
eliminate calling deprecated method: close() in cli-plugin-e2e-cypress and cli-plugin-e2e-nightwatch ### Version 5.0.4 ### Environment info ``` System: OS: Linux 5.15 Ubuntu 22.04 LTS 22.04 LTS (Jammy Jellyfish) CPU: (8) x64 Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz Binaries: Node: 1...
fix: eliminate calling deprecated function in cli-plugin-e2e-cypress and cli-plugin-e2e-nightwatch
Due to webpack-dev-server's close() method became deprecated in version v4.0.0, currently vue-cli is using version ^4.7.3, everytime when cli-plugin-e2e-cypress or cli-plugin-e2e-nightwatch ran any tests a deprecation warning appeared. From now on method stop() is called instead of close() as advised by the deprecat...
ce97e62304e884c4277aaa1b605f735253e4205b
9daeb7b7e82d03886e78f1735222d2146d32bf80
diff --git a/packages/@vue/cli-plugin-e2e-cypress/index.js b/packages/@vue/cli-plugin-e2e-cypress/index.js index 6b81b68de9..4a21712b5d 100644 --- a/packages/@vue/cli-plugin-e2e-cypress/index.js +++ b/packages/@vue/cli-plugin-e2e-cypress/index.js @@ -36,8 +36,8 @@ module.exports = (api, options) => { resolveModu...
[ "packages/@vue/cli-plugin-e2e-cypress/index.js", "packages/@vue/cli-plugin-e2e-nightwatch/index.js" ]
[]
true
vuejs/vue-cli
2,981
issue_to_patch
feat!: manifest.json should be generated by cli-plugin-pwa
English description provided by Google Translate. 中文在下方 ### English description `manifest.json` should be generated by `cli-plugin-pwa` and should not be copied directly from the `public` folder. `manifest.json` is a separate file that cannot be modified by `vue.config.js`, and these values are very suitable fo...
cdec606587437018644f7bcefaf1bec72b3da5c5
db4c23babe01f1257e0c0b9adbcaa9871f564d4a
diff --git a/packages/@vue/cli-plugin-pwa/README.md b/packages/@vue/cli-plugin-pwa/README.md index 8a65cfba79..af28355c43 100644 --- a/packages/@vue/cli-plugin-pwa/README.md +++ b/packages/@vue/cli-plugin-pwa/README.md @@ -54,7 +54,7 @@ file, or the `"vue"` field in `package.json`. - Default: `'default'` - **pwa....
[ "packages/@vue/cli-plugin-pwa/README.md", "packages/@vue/cli-plugin-pwa/generator/template/public/manifest.json", "packages/@vue/cli-plugin-pwa/lib/HtmlPwaPlugin.js" ]
[]
true
vuejs/vue-cli
6,662
issue_to_patch
feat!: update cypress to 8.3 and require it to be a peer dependency
I thought it was already landed. Turns out not yet. **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, please describe: **Does this PR introduce a breaking change?** (check o...
c8833d37c2376a8e356fde83b0ce725d4014ea0d
e746279577e7d1912997593eaab0f0a61dd0f727
diff --git a/docs/migrations/migrate-from-v4.md b/docs/migrations/migrate-from-v4.md index 88a99dfce1..9b28a76863 100644 --- a/docs/migrations/migrate-from-v4.md +++ b/docs/migrations/migrate-from-v4.md @@ -121,7 +121,7 @@ Please consider switching to ESLint. You can check out [`tslint-to-eslint-config ### E2E-Cypress...
[ "docs/migrations/migrate-from-v4.md", "packages/@vue/cli-plugin-e2e-cypress/generator/index.js", "packages/@vue/cli-plugin-e2e-cypress/migrator/index.js", "packages/@vue/cli-plugin-e2e-cypress/package.json", "yarn.lock" ]
[]
true
vuejs/vue-cli
7,023
issue_to_patch
fix: windows vue.config.mjs support
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
f7dc46d0692c2d8a07f5c8b0580177de81c150b0
c863efce9f29fbc6902db493eb1a85ea4e177946
diff --git a/packages/@vue/cli-service/lib/util/loadFileConfig.js b/packages/@vue/cli-service/lib/util/loadFileConfig.js index ab01117d94..4452cc2b6e 100644 --- a/packages/@vue/cli-service/lib/util/loadFileConfig.js +++ b/packages/@vue/cli-service/lib/util/loadFileConfig.js @@ -1,6 +1,6 @@ const fs = require('fs') co...
[ "packages/@vue/cli-service/lib/util/loadFileConfig.js" ]
[]
true
vuejs/vue-cli
7,044
issue_to_patch
fix(cli-service): devServer proxy should be optional
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
f7dc46d0692c2d8a07f5c8b0580177de81c150b0
c9eefaab2b0c5de5e3bfcfe2bb310dda12b0efaf
diff --git a/packages/@vue/cli-service/types/ProjectOptions.d.ts b/packages/@vue/cli-service/types/ProjectOptions.d.ts index 8dc81eaf8b..47e7823d3f 100644 --- a/packages/@vue/cli-service/types/ProjectOptions.d.ts +++ b/packages/@vue/cli-service/types/ProjectOptions.d.ts @@ -111,7 +111,7 @@ interface ProjectOptions { ...
[ "packages/@vue/cli-service/types/ProjectOptions.d.ts" ]
[]
true
vuejs/vue-cli
7,005
issue_to_patch
Better handling of `publicPath: 'auto'`
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
dd53f26bc0c51fec7c5fb2c18f4769de984ad79c
e9c4080a82477fc9b2729993843169ca685598b4
diff --git a/packages/@vue/cli-service/lib/commands/serve.js b/packages/@vue/cli-service/lib/commands/serve.js index 6ed4ee8b2c..cc66855e8b 100644 --- a/packages/@vue/cli-service/lib/commands/serve.js +++ b/packages/@vue/cli-service/lib/commands/serve.js @@ -5,6 +5,7 @@ const { hasProjectPnpm, IpcMessenger } = r...
[ "packages/@vue/cli-service/lib/commands/serve.js", "packages/@vue/cli-service/lib/util/getBaseUrl.js", "packages/@vue/cli-service/lib/util/resolveClientEnv.js" ]
[]
true
vuejs/vue-cli
6,285
issue_to_patch
feat(cli-service): provide jsconfig.json in no-ts template
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
4ce7edd3754c3856c760d126f7fa3928f120aa2e
5db1055449d63f5eb6183abec6a7f6b42681013b
diff --git a/packages/@vue/cli-service/generator/index.js b/packages/@vue/cli-service/generator/index.js index c36edede16..05a497a5e8 100644 --- a/packages/@vue/cli-service/generator/index.js +++ b/packages/@vue/cli-service/generator/index.js @@ -1,6 +1,7 @@ module.exports = (api, options) => { api.render('./templa...
[ "packages/@vue/cli-service/generator/index.js", "packages/@vue/cli-service/generator/template/jsconfig.json" ]
[]
true
vuejs/vue-cli
7,039
issue_to_patch
chore: add scss to LoaderOptions
**What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, please describe: **Does this PR introduce a breaking change?** (check one) - [ ] Yes - [x] No **Other information:** ...
f7dc46d0692c2d8a07f5c8b0580177de81c150b0
aacefedeb7943b13385496cade33d013f7a06200
diff --git a/packages/@vue/cli-service/types/ProjectOptions.d.ts b/packages/@vue/cli-service/types/ProjectOptions.d.ts index df7daa2ddf..3ac61361ba 100644 --- a/packages/@vue/cli-service/types/ProjectOptions.d.ts +++ b/packages/@vue/cli-service/types/ProjectOptions.d.ts @@ -11,6 +11,7 @@ interface PageConfig { interfa...
[ "packages/@vue/cli-service/types/ProjectOptions.d.ts" ]
[]
true
vuejs/vue-cli
5,794
issue_to_patch
fix(cli): resolve plugins relative to the package context
`@vue/cli-service` is trying to resolve plugins on behalf of itself instead of the `pkgContext` which makes it rely on hoisting to bring it to an accessible location which is not guaranteed, especially in monorepos https://yarnpkg.com/advanced/rulebook#packages-should-only-ever-require-what-they-formally-list-in-the...
e1eba098ae557b1e8408134fd9d299213f63394c
a6655b93f44bdf8aee6f6530f52a6be650f74cf5
diff --git a/packages/@vue/cli-service/lib/Service.js b/packages/@vue/cli-service/lib/Service.js index 4fb59cd8a5..a477177a07 100644 --- a/packages/@vue/cli-service/lib/Service.js +++ b/packages/@vue/cli-service/lib/Service.js @@ -7,7 +7,7 @@ const PluginAPI = require('./PluginAPI') const dotenv = require('dotenv') c...
[ "packages/@vue/cli-service/lib/Service.js", "packages/@vue/cli-shared-utils/lib/module.js" ]
[ { "comment": "Is it better to use `loadModule` directly? `require(resolveModule(..` looks a little redundant to me", "path": "packages/@vue/cli-service/lib/Service.js", "hunk": "@@ -178,14 +178,14 @@ module.exports = class Service {\n ) {\n let apply = () => {}\n try {...
true
vuejs/vue-cli
5,794
comment_to_fix
fix(cli): resolve plugins relative to the package context
Is it better to use `loadModule` directly? `require(resolveModule(..` looks a little redundant to me
e1eba098ae557b1e8408134fd9d299213f63394c
a6655b93f44bdf8aee6f6530f52a6be650f74cf5
diff --git a/packages/@vue/cli-service/lib/Service.js b/packages/@vue/cli-service/lib/Service.js index 4fb59cd8a5..a477177a07 100644 --- a/packages/@vue/cli-service/lib/Service.js +++ b/packages/@vue/cli-service/lib/Service.js @@ -7,7 +7,7 @@ const PluginAPI = require('./PluginAPI') const dotenv = require('dotenv') c...
[ "packages/@vue/cli-service/lib/Service.js" ]
[ { "comment": "Is it better to use `loadModule` directly? `require(resolveModule(..` looks a little redundant to me", "path": "packages/@vue/cli-service/lib/Service.js", "hunk": "@@ -178,14 +178,14 @@ module.exports = class Service {\n ) {\n let apply = () => {}\n try {...
true
vuejs/vue-cli
5,794
comment_to_fix
fix(cli): resolve plugins relative to the package context
`idToPlugin(resolveModule(id, this.pkgContext))` is better for me. And we don't need to modify the `idToPlugin` function.
e1eba098ae557b1e8408134fd9d299213f63394c
a6655b93f44bdf8aee6f6530f52a6be650f74cf5
diff --git a/packages/@vue/cli-service/lib/Service.js b/packages/@vue/cli-service/lib/Service.js index 4fb59cd8a5..a477177a07 100644 --- a/packages/@vue/cli-service/lib/Service.js +++ b/packages/@vue/cli-service/lib/Service.js @@ -7,7 +7,7 @@ const PluginAPI = require('./PluginAPI') const dotenv = require('dotenv') c...
[ "packages/@vue/cli-service/lib/Service.js" ]
[ { "comment": "`idToPlugin(resolveModule(id, this.pkgContext))` is better for me. And we don't need to modify the `idToPlugin` function.", "path": "packages/@vue/cli-service/lib/Service.js", "hunk": "@@ -178,14 +178,14 @@ module.exports = class Service {\n ) {\n let apply = () => {}...
true
vuejs/vue-cli
6,972
issue_to_patch
--skip-plugins is not removed from args ### Version 5.0.0-rc.2 ### Environment info ```text System: OS: Linux 5.13 Ubuntu 20.04.3 LTS (Focal Fossa) CPU: (8) x64 Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz Binaries: Node: 16.13.2 Yarn: 1.22.17 npm: 8.3.2 Browsers: Chrome: 9...
Remove --skip-plugin from arguments
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [X] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
7f3d51133635114528848b29e27084ee89d53e1c
6f76898a84695df7ac60449ab68c7b7c01350be4
diff --git a/docs/guide/cli-service.md b/docs/guide/cli-service.md index c76a697e78..84e2dc1040 100644 --- a/docs/guide/cli-service.md +++ b/docs/guide/cli-service.md @@ -135,10 +135,10 @@ npx vue-cli-service build --skip-plugins pwa This option is available for _every_ `vue-cli-service` command, including custom ones...
[ "docs/guide/cli-service.md", "packages/@vue/cli-service/__tests__/Service.spec.js", "packages/@vue/cli-service/lib/Service.js" ]
[]
diff --git a/packages/@vue/cli-service/__tests__/Service.spec.js b/packages/@vue/cli-service/__tests__/Service.spec.js index 1f8e219d84..a8077e13f2 100644 --- a/packages/@vue/cli-service/__tests__/Service.spec.js +++ b/packages/@vue/cli-service/__tests__/Service.spec.js @@ -208,6 +208,62 @@ test('api: --skip-plugins', ...
true
vuejs/vue-cli
6,993
issue_to_patch
chore(deps): bump follow-redirects from 1.14.7 to 1.14.8
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.7 to 1.14.8. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/follow-redirects/follow-redirects/commit/3d81dc3237b4ffe8b722bb3d1c70a7866657166e"><code>3d81dc3</code></a> Release version 1.14.8 of the npm pa...
2d8fa268ed3882e6bef7d1c131225d93277bf389
6c5d28a81f4ea806da948ec46fd026ffded4c149
diff --git a/yarn.lock b/yarn.lock index a8ea8d5213..469da5bc7a 100644 --- a/yarn.lock +++ b/yarn.lock @@ -10093,9 +10093,9 @@ focus-visible@^5.2.0: integrity sha512-Rwix9pBtC1Nuy5wysTmKy+UjbDJpIfg8eHjw0rjZ1mX4GNLz1Bmd16uDpI3Gk1i70Fgcs8Csg2lPm8HULFg9DQ== follow-redirects@^1.0.0, follow-redirects@^1.14.0, follow-r...
[ "yarn.lock" ]
[]
true
vuejs/vue-cli
6,987
issue_to_patch
fix: update mini-css-extract-plugin to ^2.5.3
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> Basically, just removing the temporary workaround introduced in https://github.com/vuejs/vue-cli/pull/6944 (`v5.0.0-rc.2`) due to an accidental breaking change added in `mini-css-extract-plug...
7a17d98fe7c26efcefbf10d029bb627b2315275f
262b9b403c37d1b6bf6dfefc08bf6d42fb769ba4
diff --git a/packages/@vue/cli-service/package.json b/packages/@vue/cli-service/package.json index 6a2a366d1c..124c8eee65 100644 --- a/packages/@vue/cli-service/package.json +++ b/packages/@vue/cli-service/package.json @@ -59,7 +59,7 @@ "launch-editor-middleware": "^2.2.1", "lodash.defaultsdeep": "^4.6.1", ...
[ "packages/@vue/cli-service/package.json" ]
[]
true
vuejs/vue-cli
6,944
issue_to_patch
fix: set mini-css-extract-plugin to 2.4.5
Workaround for https://github.com/vuejs/vue-cli/discussions/6943 Source cause https://github.com/webpack-contrib/mini-css-extract-plugin/issues/896 <!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR in...
4dacae53fa1ca07452b41995636d0edff1e74a2e
4470f87318aae7b8066f1a9c389132e340805d24
diff --git a/packages/@vue/cli-service/package.json b/packages/@vue/cli-service/package.json index 17a6a20fb5..d012ff8941 100644 --- a/packages/@vue/cli-service/package.json +++ b/packages/@vue/cli-service/package.json @@ -61,7 +61,7 @@ "launch-editor-middleware": "^2.2.1", "lodash.defaultsdeep": "^4.6.1", ...
[ "packages/@vue/cli-service/package.json" ]
[]
true
vuejs/vue-cli
6,985
issue_to_patch
feat!: make `cache-loader` optional
To get rid of the annoying peer dependency warning. This might slightly affect the build performance so users can still install it on their own by running `npm add -D cache-loader` **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [ ] Code style update - [ ] R...
342c386c863e32146b5beadcdd2210d558432770
b62894539650768544bab7a45fcd2f8bf2592181
diff --git a/packages/@vue/cli-plugin-typescript/index.js b/packages/@vue/cli-plugin-typescript/index.js index 224758008a..54af685a4c 100644 --- a/packages/@vue/cli-plugin-typescript/index.js +++ b/packages/@vue/cli-plugin-typescript/index.js @@ -30,15 +30,19 @@ module.exports = (api, projectOptions) => { tsxRul...
[ "packages/@vue/cli-plugin-typescript/index.js", "packages/@vue/cli-plugin-typescript/package.json", "packages/@vue/cli-service/lib/config/base.js", "packages/@vue/cli-service/package.json" ]
[]
true
vuejs/vue-cli
6,964
issue_to_patch
Fix typo
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [ ] Feature - [x] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
7f3d51133635114528848b29e27084ee89d53e1c
851575d96e0a1a6ade7eb4e6b08f6a9a4e64d520
diff --git a/packages/@vue/cli-ui/src/components/content/TerminalView.vue b/packages/@vue/cli-ui/src/components/content/TerminalView.vue index 61c697c81a..f5f4f608da 100644 --- a/packages/@vue/cli-ui/src/components/content/TerminalView.vue +++ b/packages/@vue/cli-ui/src/components/content/TerminalView.vue @@ -231,7 +23...
[ "packages/@vue/cli-ui/src/components/content/TerminalView.vue" ]
[]
true
vuejs/vue-cli
6,980
issue_to_patch
feat: add build stats hash support
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
97ff15817c5facd629894ae4956d989e32bf89f0
50a923af33a8c8e50659f1e544b7127948968e1b
diff --git a/packages/@vue/cli-service/lib/commands/build/formatStats.js b/packages/@vue/cli-service/lib/commands/build/formatStats.js index a6dec9554f..42ccbc71c7 100644 --- a/packages/@vue/cli-service/lib/commands/build/formatStats.js +++ b/packages/@vue/cli-service/lib/commands/build/formatStats.js @@ -68,5 +68,10 @...
[ "packages/@vue/cli-service/lib/commands/build/formatStats.js" ]
[]
true
vuejs/vue-cli
6,520
issue_to_patch
feat: Upgraded Nightwatch to 2.0, updated distribued config
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
aaa7eb05874ee8edd3d97b95c44779b8055a3c3d
99a9f0e036e76c5d1f0843465348f532c81e8551
diff --git a/packages/@vue/cli-plugin-e2e-nightwatch/index.js b/packages/@vue/cli-plugin-e2e-nightwatch/index.js index cb1a595a79..9175fee366 100644 --- a/packages/@vue/cli-plugin-e2e-nightwatch/index.js +++ b/packages/@vue/cli-plugin-e2e-nightwatch/index.js @@ -127,7 +127,7 @@ async function loadNightwatchConfig (rawA...
[ "packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js", "packages/@vue/cli-plugin-e2e-nightwatch/index.js", "packages/@vue/cli-plugin-e2e-nightwatch/nightwatch.conf.js", "packages/@vue/cli-plugin-e2e-nightwatch/nightwatch.config.js", "packages/@vue/cli-plugin-e2e-nightwatch/package.jso...
[ { "comment": "Cucumber-js example is not available in nightwatch 1.7, please remove this.", "path": "packages/@vue/cli-plugin-e2e-nightwatch/nightwatch.conf.js", "hunk": "@@ -0,0 +1,360 @@\n+// Autogenerated by Nightwatch\n+// Refer to the online docs for more details: https://nightwatchjs.org/gettingst...
diff --git a/packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js b/packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js index a27daf6ac4..a7716f7627 100644 --- a/packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js +++ b/packages/@vue/cli-plugin-e2e-nig...
true
vuejs/vue-cli
6,520
comment_to_fix
feat: Upgraded Nightwatch to 2.0, updated distribued config
Cucumber-js example is not available in nightwatch 1.7, please remove this.
aaa7eb05874ee8edd3d97b95c44779b8055a3c3d
99a9f0e036e76c5d1f0843465348f532c81e8551
diff --git a/packages/@vue/cli-plugin-e2e-nightwatch/nightwatch.conf.js b/packages/@vue/cli-plugin-e2e-nightwatch/nightwatch.conf.js new file mode 100644 index 0000000000..ad710a2824 --- /dev/null +++ b/packages/@vue/cli-plugin-e2e-nightwatch/nightwatch.conf.js @@ -0,0 +1,360 @@ +// Autogenerated by Nightwatch +// Refe...
[ "packages/@vue/cli-plugin-e2e-nightwatch/nightwatch.conf.js" ]
[ { "comment": "Cucumber-js example is not available in nightwatch 1.7, please remove this.", "path": "packages/@vue/cli-plugin-e2e-nightwatch/nightwatch.conf.js", "hunk": "@@ -0,0 +1,360 @@\n+// Autogenerated by Nightwatch\n+// Refer to the online docs for more details: https://nightwatchjs.org/gettingst...
true
vuejs/vue-cli
6,978
issue_to_patch
chore: remove dep @types/webpack-dev-server (no longer required)
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [x] Other: ...
97ff15817c5facd629894ae4956d989e32bf89f0
05472daaf23b9c6a17de3fce69df98a4d09cee9d
diff --git a/packages/@vue/cli-service/package.json b/packages/@vue/cli-service/package.json index 51a47c4f44..b9d1a654a0 100644 --- a/packages/@vue/cli-service/package.json +++ b/packages/@vue/cli-service/package.json @@ -27,7 +27,6 @@ "@soda/friendly-errors-webpack-plugin": "^1.8.0", "@soda/get-current-scri...
[ "packages/@vue/cli-service/package.json", "yarn.lock" ]
[]
true
vuejs/vue-cli
6,969
issue_to_patch
fix: remove non standard rel=shortcut
`shortcut` is used by IE6 which is dead and not supported anymore https://github.com/vuejs/vue-cli/issues/5232 <!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x]...
7f3d51133635114528848b29e27084ee89d53e1c
590e7934db7888087f86b7fe30781a4ab402d820
diff --git a/packages/@vue/cli-ui/public/index.html b/packages/@vue/cli-ui/public/index.html index 96098ec9c7..8ca063da4a 100644 --- a/packages/@vue/cli-ui/public/index.html +++ b/packages/@vue/cli-ui/public/index.html @@ -4,7 +4,7 @@ <meta charset="utf-8"> <meta http-equiv="X-UA-Compatible" content="IE=edge"...
[ "packages/@vue/cli-ui/public/index.html" ]
[]
true
vuejs/vue-cli
6,094
issue_to_patch
@vue/cli-plugin-eslint needs to update eslint-loader[deprecated] to eslint-webpack-plugin ### Version 4.5.6 ### Environment info ``` Environment Info: System: OS: Windows 10 10.0.18363 CPU: (8) x64 Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz Binaries: Node: 12.16.1 - C:\Program Fil...
feat: replace eslint-loader by eslint-webpack-plugin
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [x] Underlying tools - [ ] Other, ...
2dbe0be8406e5c432dacc559a54b270a5670d652
2d6134086fac357cd42139f99f7844c6e8cfb99e
diff --git a/packages/@vue/cli-plugin-eslint/index.js b/packages/@vue/cli-plugin-eslint/index.js index c514daafca..246736746f 100644 --- a/packages/@vue/cli-plugin-eslint/index.js +++ b/packages/@vue/cli-plugin-eslint/index.js @@ -1,33 +1,26 @@ const path = require('path') +const eslintWebpackPlugin = require('eslint-...
[ "packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js", "packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js", "packages/@vue/cli-plugin-eslint/index.js", "packages/@vue/cli-plugin-eslint/package.json", "packages/@vue/cli-service-global/__tests__/globalService.spec.js", "p...
[]
diff --git a/packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js b/packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js index 0eab736cff..a27daf6ac4 100644 --- a/packages/@vue/cli-plugin-e2e-nightwatch/__tests__/nightwatchPlugin.spec.js +++ b/packages/@vue/cli-plugin-e2e-nig...
true
vuejs/vue-cli
6,926
issue_to_patch
fix: Update cypress api link to the latest
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [x] Docs - [ ] Underlying tools - [ ] Other, ...
15da794317f238680acd0fdb9bdc86538390926f
d10605ff331c5fe25c32d3e8ccf5f2b0d42f88b4
[ "packages/@vue/cli-plugin-e2e-cypress/generator/template/tests/e2e/specs/test.js" ]
[]
diff --git a/packages/@vue/cli-plugin-e2e-cypress/generator/template/tests/e2e/specs/test.js b/packages/@vue/cli-plugin-e2e-cypress/generator/template/tests/e2e/specs/test.js index 8da9091397..b2ff0448eb 100644 --- a/packages/@vue/cli-plugin-e2e-cypress/generator/template/tests/e2e/specs/test.js +++ b/packages/@vue/cli...
true
vuejs/vue-cli
6,917
issue_to_patch
feat!: make Vue 3 the default version for `vue create`
**What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, please describe: **Does this PR introduce a breaking change?** (check one) - [x] Yes - [ ] No **Other information:** ...
042f48a8fce9735d8b9267dce683f27c6ebcd15f
16294eefbae339a823f7e77d1008a7672eebcd71
diff --git a/packages/@vue/cli/lib/Creator.js b/packages/@vue/cli/lib/Creator.js index 4931cbf869..05e1754ecd 100644 --- a/packages/@vue/cli/lib/Creator.js +++ b/packages/@vue/cli/lib/Creator.js @@ -77,7 +77,7 @@ module.exports = class Creator extends EventEmitter { preset = await this.resolvePreset(cliOptions...
[ "packages/@vue/cli-ui/tests/e2e/specs/g1-projects.js", "packages/@vue/cli/__tests__/Creator.spec.js", "packages/@vue/cli/lib/Creator.js", "packages/@vue/cli/lib/options.js", "packages/@vue/cli/lib/promptModules/vueVersion.js" ]
[]
diff --git a/packages/@vue/cli-ui/tests/e2e/specs/g1-projects.js b/packages/@vue/cli-ui/tests/e2e/specs/g1-projects.js index 199adfcfaf..84caf918b3 100644 --- a/packages/@vue/cli-ui/tests/e2e/specs/g1-projects.js +++ b/packages/@vue/cli-ui/tests/e2e/specs/g1-projects.js @@ -38,10 +38,19 @@ describe('Vue project manager...
true
vuejs/vue-cli
6,907
issue_to_patch
@vue/cli-service@5.0.0-rc.1 causes deprecation warning with webpack-dev-server ### Version 5.0.0-rc.1 ### Environment info ``` System: OS: Windows 10 10.0.19043 CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz Binaries: Node: 14.17.5 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.5 -...
fix: use `setupMiddlewares`, avoid dev server deprecation warnings
Closes https://github.com/vuejs/vue-cli/issues/6896 **What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, please describe: **Does this PR introduce a breaking change?** (check o...
042f48a8fce9735d8b9267dce683f27c6ebcd15f
35de49c487c9861d737d8ddc078f8740a0e732cf
diff --git a/packages/@vue/cli-service/lib/commands/serve.js b/packages/@vue/cli-service/lib/commands/serve.js index 3c5bc9648d..6ed4ee8b2c 100644 --- a/packages/@vue/cli-service/lib/commands/serve.js +++ b/packages/@vue/cli-service/lib/commands/serve.js @@ -219,22 +219,23 @@ module.exports = (api, options) => { ...
[ "packages/@vue/cli-service/lib/commands/serve.js" ]
[]
true
vuejs/vue-cli
6,669
issue_to_patch
feat!: upgrade to webpack-dev-server v4
**What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, please describe: <!-- Note: When submitting documentation PRs, please target the `master` branch (https://cli.vuejs.org) o...
662153bc6ad5255ecdcbd0a776a64b5aff78d898
d31f19ef41d36047e38be735c79dddc5abb2ccb1
diff --git a/docs/migrations/migrate-from-v4.md b/docs/migrations/migrate-from-v4.md index e3b9fbbc5d..c761088e38 100644 --- a/docs/migrations/migrate-from-v4.md +++ b/docs/migrations/migrate-from-v4.md @@ -60,7 +60,17 @@ Besides the internal changes that are only noticeable for custom configurations, 1. Named exports...
[ "docs/migrations/migrate-from-v4.md", "packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js", "packages/@vue/cli-service/__tests__/multiPage.spec.js", "packages/@vue/cli-service/__tests__/serve.spec.js", "packages/@vue/cli-service/lib/commands/serve.js", "packages/@vue/cli-service/package.json",...
[]
diff --git a/packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js b/packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js index ea43a06ac0..6245a034c0 100644 --- a/packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js +++ b/packages/@vue/cli-plugin-eslint/__tests__/eslintPlugin.spec.js @@ -2...
true
vuejs/vue-cli
6,865
issue_to_patch
docs(next): fix algolia search
the CLI documentation search index hasn't been updated to the new version of docsearch (which vitepress requires). So I migrated some of the code from the vuepress version to use docsearch.js 2.x instead. **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [ ] Feature - [ ] Code...
b0e7bf07d6d7e086985475df713b593cb42ef878
586f5745d2f0592a76e33dafeb620788e8955e77
diff --git a/docs/.vitepress/theme/AlgoliaSearchBox.vue b/docs/.vitepress/theme/AlgoliaSearchBox.vue new file mode 100644 index 0000000000..0da8a506b5 --- /dev/null +++ b/docs/.vitepress/theme/AlgoliaSearchBox.vue @@ -0,0 +1,325 @@ +<script setup lang="ts"> +import 'docsearch.js/dist/cdn/docsearch.min.css' +import docs...
[ "docs/.vitepress/theme/AlgoliaSearchBox.vue", "docs/.vitepress/theme/index.js", "docs/.vitepress/theme/search.svg", "package.json", "yarn.lock" ]
[]
true
vuejs/vue-cli
6,872
issue_to_patch
chore: use vue-loader v17
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [x] Underlying tools - [ ] Other, ...
b0e7bf07d6d7e086985475df713b593cb42ef878
b01d32ed343e1f6e35baf1848880f9118042d933
diff --git a/packages/@vue/cli-service/package.json b/packages/@vue/cli-service/package.json index 8a59f550fc..17a6a20fb5 100644 --- a/packages/@vue/cli-service/package.json +++ b/packages/@vue/cli-service/package.json @@ -71,7 +71,7 @@ "ssri": "^8.0.1", "terser-webpack-plugin": "^5.1.1", "thread-loader"...
[ "packages/@vue/cli-service/package.json", "yarn.lock" ]
[]
true
vuejs/vue-cli
6,753
issue_to_patch
Add `getters:{}` to cli-plugin-vuex template
**What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [x] Other, please describe: modified cli-plugin-vuex template **Does this PR introduce a breaking change?** (check one) - [ ] Yes - [...
100402073e613ecb01707bed39d8b2f5213015e4
b4b6ed95772a253a7be7af268401ebcbcb9f80b6
diff --git a/packages/@vue/cli-plugin-vuex/generator/template-vue3/src/store/index.js b/packages/@vue/cli-plugin-vuex/generator/template-vue3/src/store/index.js index 5f05f19391..7f5b89c73b 100644 --- a/packages/@vue/cli-plugin-vuex/generator/template-vue3/src/store/index.js +++ b/packages/@vue/cli-plugin-vuex/generato...
[ "packages/@vue/cli-plugin-vuex/generator/template-vue3/src/store/index.js", "packages/@vue/cli-plugin-vuex/generator/template/src/store/index.js" ]
[]
true
vuejs/vue-cli
6,826
issue_to_patch
Image file name has duplicate dots in extension due to #6771 ### Version 5.0.0-beta.7 ### Reproduction link [github.com](https://github.com/TwiN/vue-img-file-name-dd-repro) ### Environment info ``` System: OS: Windows 10 10.0.19043 CPU: (8) x64 Intel(R) Core(TM) i7-9700K CPU @ 3.60GHz ...
fix: [ext] in asset modules already contains a leading dot
Fixes #6825 <!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools...
aa85cb01199b9cb0db5107307945796554802d06
db49080976765c17db8e927ffa242cdeab04bb60
diff --git a/packages/@vue/cli-service/lib/config/assets.js b/packages/@vue/cli-service/lib/config/assets.js index bc30e25b47..8bc0839bcc 100644 --- a/packages/@vue/cli-service/lib/config/assets.js +++ b/packages/@vue/cli-service/lib/config/assets.js @@ -5,7 +5,7 @@ module.exports = (api, options) => { const genAsse...
[ "packages/@vue/cli-service/lib/config/assets.js" ]
[]
true
vuejs/vue-cli
6,829
issue_to_patch
fix: require webpack 5.54+
Because `xxhash64` is only supported in 5.54+ Fixes issues like https://github.com/vuejs/vue-cli/issues/6806#issuecomment-963375201 **What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ...
aa85cb01199b9cb0db5107307945796554802d06
a18d76c648bfd9f9002b5bfae8b86cdea78d39bf
diff --git a/package.json b/package.json index 7e6511c443..7f92645376 100644 --- a/package.json +++ b/package.json @@ -70,7 +70,7 @@ "verdaccio": "^5.0.1", "vite-plugin-pwa": "^0.11.3", "vitepress": "^0.20.1", - "webpack": "^5.22.0", + "webpack": "^5.54.0", "yorkie": "^2.0.0" }, "resolut...
[ "package.json", "packages/@vue/cli-plugin-babel/package.json", "packages/@vue/cli-plugin-eslint/package.json", "packages/@vue/cli-plugin-pwa/package.json", "packages/@vue/cli-plugin-typescript/package.json", "packages/@vue/cli-service/package.json", "yarn.lock" ]
[]
true
vuejs/vue-cli
6,824
issue_to_patch
feat: update npm.taobao.org to npmmirror.com
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugfix - [x] Feature - [ ] Code style update - [ ] Refactor - [x] Docs - [ ] Underlying tools - [ ] Other, ...
787efaabda35dce1ef58aafbdd34d9971087d5aa
89259cadfde3814a716b671cea5606ac50bcd903
diff --git a/docs/guide/creating-a-project.md b/docs/guide/creating-a-project.md index 6183a92cd3..9c3e05df2e 100644 --- a/docs/guide/creating-a-project.md +++ b/docs/guide/creating-a-project.md @@ -28,7 +28,7 @@ If you chose to manually select features, at the end of the prompts you also hav ::: tip ~/.vuerc Saved p...
[ "docs/guide/creating-a-project.md", "docs/ru/guide/creating-a-project.md", "docs/zh/guide/creating-a-project.md", "packages/@vue/cli/lib/util/registries.js" ]
[]
true
vuejs/vue-cli
6,821
issue_to_patch
docs: replace vuepress with vitepress
Vuepress didn't work well with the project at the moment, maybe due to the conflicting webpack versions. The Netlify deployment was failing. Notable changes after switching to Vitepress: 1. The default theme doesn't support nested nav links, so I have to revert #5655 to use a single-level dropdown for "plugins". 2...
787efaabda35dce1ef58aafbdd34d9971087d5aa
6f6e579c83706885eba1745197d04c08ddcd02f2
diff --git a/docs/.vitepress/config.js b/docs/.vitepress/config.js new file mode 100644 index 0000000000..7e949dbdf6 --- /dev/null +++ b/docs/.vitepress/config.js @@ -0,0 +1,678 @@ +const { VitePWA } = require('vite-plugin-pwa') + +module.exports = { + locales: { + '/': { + lang: 'en-US', + title: 'Vue CL...
[ "docs/.vitepress/config.js", "docs/.vitepress/theme/custom.css", "docs/.vitepress/theme/index.js", "docs/.vuepress/config.js", "docs/.vuepress/styles/index.styl", "docs/README.md", "docs/config/index.md", "docs/core-plugins/babel.md", "docs/core-plugins/e2e-cypress.md", "docs/core-plugins/e2e-nigh...
[]
true
vuejs/vue-cli
6,812
issue_to_patch
fix: improve accessibility of the navigation elements
<!-- Please don't delete this template --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Docs - [ ] Underlying tools - [ ] Other, ...
66c9190fe5c78490bd04fc040d5f5c58bf34b9d1
a184615a70d71777ab84f69c5ea31622c67e5568
diff --git a/packages/@vue/cli-plugin-router/generator/template-vue3/src/App.vue b/packages/@vue/cli-plugin-router/generator/template-vue3/src/App.vue index 1ca554712f..69d93f7d3c 100644 --- a/packages/@vue/cli-plugin-router/generator/template-vue3/src/App.vue +++ b/packages/@vue/cli-plugin-router/generator/template-vu...
[ "packages/@vue/cli-plugin-router/generator/template-vue3/src/App.vue", "packages/@vue/cli-plugin-router/generator/template/src/App.vue" ]
[]
true
vuejs/vue-cli
6,815
issue_to_patch
chore(deps): bump vm2 from 3.9.3 to 3.9.5
Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.3 to 3.9.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/patriksimek/vm2/releases">vm2's releases</a>.</em></p> <blockquote> <h2>3.9.5</h2> <p><strong>New Features</strong></p> <p>d9af94ca3a701b9ba6283264fafeef4827786...
60140af5ba029e30d433ebf5afd442f754ee87e5
b8528e0c75d5668764a43d74d67e6fbee48757d1
diff --git a/yarn.lock b/yarn.lock index d2e69938b0..120aadfc47 100644 --- a/yarn.lock +++ b/yarn.lock @@ -21885,9 +21885,9 @@ vm-browserify@^1.0.1: integrity sha512-2ham8XPWTONajOR0ohOKOHXkm3+gaBmGut3SRuu75xLd/RRaY6vqgh8NBYYk7+RW3u5AtzPQZG8F10LHkl0lAQ== vm2@^3.9.3: - version "3.9.3" - resolved "https://registr...
[ "yarn.lock" ]
[]
true
vuejs/vue
13,216
issue_to_patch
fixed spelling mistakes
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugf...
73486cb5f5862a443b42c2aff68b82320218cbcd
71c0b0b34d418c0d7ec3572d6955f9b302c82ec7
diff --git a/CHANGELOG.md b/CHANGELOG.md index 028dddab44f..d040c2c85b8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,7 +3,7 @@ ### Bug Fixes -* **lifecycle:** esnure component effect scopes are disconnected ([56ce7f8](https://github.com/vuejs/vue/commit/56ce7f8c573116ed6683149206cf35c987249d42)), closes [#13...
[ "CHANGELOG.md" ]
[]
true
vuejs/vue
5,645
issue_to_patch
make vm.$watch api consistent with watch option(#5604)
#5604 <!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) ...
8d56a498f3d95660e2cafff4ed3c1e1da23494d1
5aac170816c4870a4367401647d23723e86537e5
diff --git a/src/core/instance/state.js b/src/core/instance/state.js index d2d8fa14998..1ba0ff0ec11 100644 --- a/src/core/instance/state.js +++ b/src/core/instance/state.js @@ -247,8 +247,12 @@ function initWatch (vm: Component, watch: Object) { } } -function createWatcher (vm: Component, key: string, handler: an...
[ "src/core/instance/state.js", "test/unit/features/instance/methods-data.spec.js" ]
[]
diff --git a/test/unit/features/instance/methods-data.spec.js b/test/unit/features/instance/methods-data.spec.js index eb63bf4274d..49e9b6f5009 100644 --- a/test/unit/features/instance/methods-data.spec.js +++ b/test/unit/features/instance/methods-data.spec.js @@ -21,14 +21,17 @@ describe('Instance methods data', () =>...
true
vuejs/vue
1,165
issue_to_patch
mini change: removed unnecessary spaces
before comment of `resolveDynamicComponent` in `src/directives/repeat.js`
794214a3ffca378a8cdefe3f08acea46c7f33b98
2ae787855125fb2790c4a3d2a3d55ba30b0ad8bf
diff --git a/src/directives/repeat.js b/src/directives/repeat.js index c8372ad99e6..c82f2d7ec0c 100644 --- a/src/directives/repeat.js +++ b/src/directives/repeat.js @@ -142,7 +142,7 @@ module.exports = { }, this)) }, - /** + /** * Resolve a dynamic component to use for an instance. * The tricky pa...
[ "src/directives/repeat.js" ]
[]
true
vuejs/vue
13,192
issue_to_patch
chore: fix link broken
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [ ] Bugf...
e428d891456eeb6d34cfac070c423694dcda8806
2e33f3a9ab63aa41393a087403dfcc915e56abeb
diff --git a/packages/template-compiler/README.md b/packages/template-compiler/README.md index fa0a64bb78e..ac14f72e9fc 100644 --- a/packages/template-compiler/README.md +++ b/packages/template-compiler/README.md @@ -130,7 +130,7 @@ This is only useful at runtime with pre-configured builds, so it doesn't accept Same...
[ "packages/template-compiler/README.md" ]
[ { "comment": "```suggestion\r\nThis is used by default in `vue-loader@>=12` and can be disabled using the [`optimizeSSR`](https://vue-loader.vuejs.org/options.html#optimizessr) option.\r\n```", "path": "packages/template-compiler/README.md", "hunk": "@@ -130,7 +130,7 @@ This is only useful at runtime wi...
true
vuejs/vue
13,192
comment_to_fix
chore: fix link broken
```suggestion This is used by default in `vue-loader@>=12` and can be disabled using the [`optimizeSSR`](https://vue-loader.vuejs.org/options.html#optimizessr) option. ```
e428d891456eeb6d34cfac070c423694dcda8806
2e33f3a9ab63aa41393a087403dfcc915e56abeb
diff --git a/packages/template-compiler/README.md b/packages/template-compiler/README.md index fa0a64bb78e..ac14f72e9fc 100644 --- a/packages/template-compiler/README.md +++ b/packages/template-compiler/README.md @@ -130,7 +130,7 @@ This is only useful at runtime with pre-configured builds, so it doesn't accept Same...
[ "packages/template-compiler/README.md" ]
[ { "comment": "```suggestion\r\nThis is used by default in `vue-loader@>=12` and can be disabled using the [`optimizeSSR`](https://vue-loader.vuejs.org/options.html#optimizessr) option.\r\n```", "path": "packages/template-compiler/README.md", "hunk": "@@ -130,7 +130,7 @@ This is only useful at runtime wi...
true
vuejs/vue
13,187
issue_to_patch
Update README.md (browser compatibility reference)
Updated Browser Compatibility reference. The previous currently returns HTTP 404. <!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> ...
bed04a77e575d6c4c1d903f60087dca874f7213e
5e34ac1c78a54fd3d9a6af6d0d51f11e50a7c469
diff --git a/README.md b/README.md index 4da8b3c4d96..274642ee3ae 100644 --- a/README.md +++ b/README.md @@ -45,7 +45,7 @@ Vue (pronounced `/vjuː/`, like view) is a **progressive framework** for buildin #### Browser Compatibility -Vue.js supports all browsers that are [ES5-compliant](https://kangax.github.io/compa...
[ "README.md" ]
[]
true
vuejs/vue
13,142
issue_to_patch
chore: eol readme
cdcc4f0c667ca4166f87034c6105514ba7b004cc
641c37059b3a93ca3023cb5ee55d14f23fa9ec78
diff --git a/README.md b/README.md index f247373f2b7..4da8b3c4d96 100644 --- a/README.md +++ b/README.md @@ -1,3 +1,11 @@ +## Vue 2 has reached End of Life + +**You are looking at the now inactive repository for Vue 2. The actively maintained repository for the latest version of Vue is [vuejs/core](https://github.com/v...
[ "README.md" ]
[]
true
vuejs/vue
12,985
issue_to_patch
Regression(vue@>=2.7.11): Imported `ref`s are not returned in `setup()` when used for template ref ### Version vue@>=2.7.11 ### Reproduction link [stackblitz.com](https://stackblitz.com/edit/vitejs-vite-tfue6t?file=vite.config.js,src%2Fmain.js,package.json,src%2FApp.vue&terminal=dev) ### Steps to r...
fix(sfc): check template `ref` usage, fix #12984
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> Fixes #12984 **What kind of change does this PR introduce?** (check at least o...
25f97a5033187372e7b8c591c79336197ee5c833
be73e4ea49d0e0d7b684baeec49d71daa4527207
diff --git a/packages/compiler-sfc/src/compileScript.ts b/packages/compiler-sfc/src/compileScript.ts index db04dbef333..6ee54818c7a 100644 --- a/packages/compiler-sfc/src/compileScript.ts +++ b/packages/compiler-sfc/src/compileScript.ts @@ -1815,6 +1815,8 @@ function resolveTemplateUsageCheckString(sfc: SFCDescriptor, ...
[ "packages/compiler-sfc/src/compileScript.ts", "packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap", "packages/compiler-sfc/test/compileScript.spec.ts" ]
[]
diff --git a/packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap b/packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap index bb52a66b907..82b305c4255 100644 --- a/packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap +++ b/packages/compiler-sfc/test/__snapshots__/compileScr...
true
vuejs/vue
13,067
issue_to_patch
fix: type VNodeChildren supports type number
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugf...
25f97a5033187372e7b8c591c79336197ee5c833
3099c879b60f6bd1dbdc0bf15010ed26580403b8
diff --git a/types/vnode.d.ts b/types/vnode.d.ts index d6f23ec3b67..533e61f169b 100644 --- a/types/vnode.d.ts +++ b/types/vnode.d.ts @@ -22,6 +22,7 @@ type ScopedSlotReturnValue = | VNode | string | boolean + | number | null | undefined | ScopedSlotReturnArray @@ -37,6 +38,7 @@ export type VNodeChild...
[ "types/vnode.d.ts" ]
[]
true
vuejs/vue
12,979
issue_to_patch
shallowRef's return type should match ref's ### Version 2.7.14 ### Reproduction link [codesandbox.io](https://codesandbox.io/s/unruffled-ramanujan-w51m8g?file=/src/index.ts) (this is a typescript bug, it's not visible on the sfc playground) ### Steps to reproduce - Use shallowRef with a generic type para...
fix#12978 shallowRef's return type
close #12978 **What kind of change does this PR introduce?** (check at least one) - [X] Bugfix - [ ] Feature - [ ] Code style update - [ ] Refactor - [ ] Build-related changes - [ ] Other, please describe: **Does this PR introduce a breaking change?** (check one) - [ ] Yes - [X] No If yes, please d...
25f97a5033187372e7b8c591c79336197ee5c833
a987bc1b98281d3fd37d7a879aac1202d9dfa652
diff --git a/src/v3/reactivity/ref.ts b/src/v3/reactivity/ref.ts index 244acc9b0d4..33495806da1 100644 --- a/src/v3/reactivity/ref.ts +++ b/src/v3/reactivity/ref.ts @@ -40,9 +40,7 @@ export function isRef(r: any): r is Ref { return !!(r && (r as Ref).__v_isRef === true) } -export function ref<T extends object>( -...
[ "src/v3/reactivity/ref.ts", "types/test/v3/reactivity-test.ts", "types/test/v3/watch-test.ts" ]
[]
diff --git a/types/test/v3/reactivity-test.ts b/types/test/v3/reactivity-test.ts index dd1b2a4d8b6..c357bf8d5c7 100644 --- a/types/test/v3/reactivity-test.ts +++ b/types/test/v3/reactivity-test.ts @@ -15,7 +15,7 @@ import { set, del } from '../../index' -import { describe, expectType } from '../utils' +import { ...
true
vuejs/vue
13,107
issue_to_patch
Type augmentation is broken when using typescript's moduleResolution: "Bundler" option ### Version 2.7.15 ### Reproduction link [codesandbox.io](https://codesandbox.io/p/sandbox/bold-resonance-ssg894) ### Steps to reproduce ```bash yarn install yarn test ``` ### What is expected? The projec...
fix: type augmentation and compiler-sfc types w/moduleResolution: bundler (fix #13106)
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [X] Bugf...
81598ea2f3bdbc81ae50f2fa9b9e547efc6b6261
cbb59cf67ea16bf80d31a4fd92b3a7a3f087d6ef
diff --git a/package.json b/package.json index b294d8bb6ae..c0f16275078 100644 --- a/package.json +++ b/package.json @@ -18,19 +18,20 @@ ], "exports": { ".": { + "types": "./types/index.d.ts", "import": { "node": "./dist/vue.runtime.mjs", "default": "./dist/vue.runtime.esm.js" ...
[ "package.json" ]
[ { "comment": "To help clarify the conversion from import name to file lookups, I tried to follow the pseudo-code from the documentation [here](https://www.typescriptlang.org/docs/handbook/modules/reference.html#packagejson-exports) and list out what would happen in the following scenarios:\r\n\r\nBefore this ch...
true
vuejs/vue
13,053
issue_to_patch
compiler-sfc not compatible with prettier v3 ### Version 2.7.14 ### Reproduction link I think it's not necessary as it's obvious in source code ### Steps to reproduce Install prettier v3 in a project depending on vue/compiler-sfc v2 ### What is expected? No error ### What is actually happening? F...
chore(compiler-sfc): specify prettier version (fix #13052)
close: #13052 <!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least o...
81598ea2f3bdbc81ae50f2fa9b9e547efc6b6261
786acf9d810a4ef60735ca14d9ccc44b1385488c
diff --git a/packages/compiler-sfc/package.json b/packages/compiler-sfc/package.json index d4081bd5b54..9565e724ddc 100644 --- a/packages/compiler-sfc/package.json +++ b/packages/compiler-sfc/package.json @@ -30,5 +30,8 @@ "pug": "^3.0.2", "sass": "^1.52.3", "stylus": "^0.58.1" + }, + "optionalDependen...
[ "packages/compiler-sfc/package.json", "pnpm-lock.yaml" ]
[]
true
vuejs/vue
10,085
issue_to_patch
Memory leak with component with input with v-model ### Version 2.6.10 ### Reproduction ```html <!DOCTYPE html> <html lang="en"> <head> <meta charset="UTF-8" /> <meta name="viewport" content="width=device-width, initial-scale=1.0" /> <meta http-equiv="X-UA-Compatible" content="ie=edge" /> ...
fix(v-on): add removing all dom event listeners when vnode destroyed
Add removing all dom event listeners when vnode destroyed fixes #10083 fixes #10004 <!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box)...
ff911c9ffef16c591b25df05cb2322ee737d13e0
877ba9ec1af6e947da32a3d77af186e55ddb85e6
diff --git a/src/platforms/web/runtime/modules/events.js b/src/platforms/web/runtime/modules/events.js index ecb08af32de..3c60fd5d1a3 100644 --- a/src/platforms/web/runtime/modules/events.js +++ b/src/platforms/web/runtime/modules/events.js @@ -5,6 +5,7 @@ import { updateListeners } from 'core/vdom/helpers/index' impo...
[ "src/platforms/web/runtime/modules/events.js", "test/unit/features/component/component-keep-alive.spec.js" ]
[]
diff --git a/test/unit/features/component/component-keep-alive.spec.js b/test/unit/features/component/component-keep-alive.spec.js index a2cdf6a4f09..b7794625129 100644 --- a/test/unit/features/component/component-keep-alive.spec.js +++ b/test/unit/features/component/component-keep-alive.spec.js @@ -1182,5 +1182,37 @@ ...
true
vuejs/vue
12,905
issue_to_patch
fix(patch): clone insert hooks to avoid being mutated during iteration
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugf...
2e570617666983ababcfd167dfa50208f5dfd45a
8da0b1562390637fb57b53875ec3f9bdce377403
diff --git a/src/core/vdom/patch.ts b/src/core/vdom/patch.ts index d0594863e3b..173840787bc 100644 --- a/src/core/vdom/patch.ts +++ b/src/core/vdom/patch.ts @@ -878,8 +878,11 @@ export function createPatchFunction(backend) { const insert = ancestor.data.hook.insert if (insert.merged) { ...
[ "src/core/vdom/patch.ts", "test/unit/modules/vdom/patch/edge-cases.spec.ts" ]
[]
diff --git a/test/unit/modules/vdom/patch/edge-cases.spec.ts b/test/unit/modules/vdom/patch/edge-cases.spec.ts index f9295533b1e..1b27f2b630c 100644 --- a/test/unit/modules/vdom/patch/edge-cases.spec.ts +++ b/test/unit/modules/vdom/patch/edge-cases.spec.ts @@ -467,4 +467,42 @@ describe('vdom patch: edge cases', () => {...
true
vuejs/vue
12,879
issue_to_patch
fix(compiler-sfc): add semicolon after `defineProps` statement
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugf...
9dd006b481b4299462e044741bac0861c0b1775c
1d42c25a4e34ccdbcfc49f33616890aacaf70e1b
diff --git a/packages/compiler-sfc/src/compileScript.ts b/packages/compiler-sfc/src/compileScript.ts index db04dbef333..21fc3eb2ad1 100644 --- a/packages/compiler-sfc/src/compileScript.ts +++ b/packages/compiler-sfc/src/compileScript.ts @@ -1122,7 +1122,7 @@ export function compileScript( startOffset, `\n...
[ "packages/compiler-sfc/src/compileScript.ts", "packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap" ]
[]
diff --git a/packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap b/packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap index bb52a66b907..8cf67a1a3d4 100644 --- a/packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap +++ b/packages/compiler-sfc/test/__snapshots__/compileScr...
true
vuejs/vue
12,862
issue_to_patch
fix(compiler-sfc): resolve object expression parsing errors in `v-on`
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> Be align with Vue3 [#6652](https://github.com/vuejs/core/pull/6652) **What kind...
6d9aac8bd38f6d30a6db70b51fa46f27cbeac559
0d3965281d41a67e62ae8a4e6e77062635ee6e5d
diff --git a/packages/compiler-sfc/src/compileScript.ts b/packages/compiler-sfc/src/compileScript.ts index 548fc592423..e9b747d5b77 100644 --- a/packages/compiler-sfc/src/compileScript.ts +++ b/packages/compiler-sfc/src/compileScript.ts @@ -1836,7 +1836,7 @@ function processExp(exp: string, isTS: boolean, dir?: string)...
[ "packages/compiler-sfc/src/compileScript.ts" ]
[]
true
vuejs/vue
12,873
issue_to_patch
fix(compiler-sfc): fix macro usage in multi-variable declaration
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugf...
6d9aac8bd38f6d30a6db70b51fa46f27cbeac559
077450ed181a8938164537f526585580e131cf8b
diff --git a/packages/compiler-sfc/src/compileScript.ts b/packages/compiler-sfc/src/compileScript.ts index 548fc592423..8a0749690a1 100644 --- a/packages/compiler-sfc/src/compileScript.ts +++ b/packages/compiler-sfc/src/compileScript.ts @@ -907,11 +907,11 @@ export function compileScript( } else { ...
[ "packages/compiler-sfc/src/compileScript.ts", "packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap", "packages/compiler-sfc/test/compileScript.spec.ts" ]
[]
diff --git a/packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap b/packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap index bb52a66b907..6d9a1a2a85a 100644 --- a/packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap +++ b/packages/compiler-sfc/test/__snapshots__/compileScr...
true
vuejs/vue
12,851
issue_to_patch
fix(compiler-sfc): Optimize the value of emitIdentifier
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugf...
6d9aac8bd38f6d30a6db70b51fa46f27cbeac559
71f5636cb2122e9917f2f0498660fa973b0109d6
diff --git a/packages/compiler-sfc/src/compileScript.ts b/packages/compiler-sfc/src/compileScript.ts index 548fc592423..e2a3fbe5726 100644 --- a/packages/compiler-sfc/src/compileScript.ts +++ b/packages/compiler-sfc/src/compileScript.ts @@ -414,7 +414,10 @@ export function compileScript( } if (declId) { - ...
[ "packages/compiler-sfc/src/compileScript.ts", "packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap", "packages/compiler-sfc/test/compileScript.spec.ts" ]
[]
diff --git a/packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap b/packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap index bb52a66b907..bcecdb4efb5 100644 --- a/packages/compiler-sfc/test/__snapshots__/compileScript.spec.ts.snap +++ b/packages/compiler-sfc/test/__snapshots__/compileScr...
true
vuejs/vue
12,872
issue_to_patch
fix(sfc/types): improve the type inference using `withDefaults`
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> Be align with [Vue3 #6764](https://github.com/vuejs/core/pull/6764) <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind...
6d9aac8bd38f6d30a6db70b51fa46f27cbeac559
95a374c41b6ff005aac81a61b950d28795f37b0f
diff --git a/types/v3-setup-helpers.d.ts b/types/v3-setup-helpers.d.ts index 6a62fd16fe1..165605ee51b 100644 --- a/types/v3-setup-helpers.d.ts +++ b/types/v3-setup-helpers.d.ts @@ -110,7 +110,11 @@ type InferDefault<P, T> = T extends : (props: P) => T type PropsWithDefaults<Base, Defaults> = Base & { - [K in key...
[ "types/test/setup-helpers-test.ts", "types/v3-setup-helpers.d.ts" ]
[]
diff --git a/types/test/setup-helpers-test.ts b/types/test/setup-helpers-test.ts index 744c2a5336f..4876154b67d 100644 --- a/types/test/setup-helpers-test.ts +++ b/types/test/setup-helpers-test.ts @@ -19,15 +19,19 @@ describe('defineProps w/ type declaration + withDefaults', () => { arr?: string[] obj?: {...
true
vuejs/vue
13,068
issue_to_patch
serverPrefetch's `this` type doesn't include component properties ### Version 2.6.14 ### Reproduction link [codesandbox.io](https://codesandbox.io/s/vue-typescript-example-forked-yvrrbl?file=/src/App.vue:473-560) ### Steps to reproduce Comment the `helloWorld` method, then uncomment it. This will tr...
fix(types): serverPrefetch's this type doesn't include component properties
Fix #12488 <!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one)...
49b6bd4264c25ea41408f066a1835f38bf6fe9f1
1d0ebe7dd277f3ec15cf204996ed7a372ee573cd
diff --git a/types/options.d.ts b/types/options.d.ts index 19c339f7450..458bc9f2b94 100644 --- a/types/options.d.ts +++ b/types/options.d.ts @@ -210,7 +210,7 @@ export interface ComponentOptions< activated?(): void deactivated?(): void errorCaptured?(err: Error, vm: Vue, info: string): boolean | void - server...
[ "types/options.d.ts" ]
[]
true
vuejs/vue
13,070
issue_to_patch
fix(lifecycle): scope might changed when call hook
<!-- Please make sure to read the Pull Request Guidelines: https://github.com/vuejs/vue/blob/dev/.github/CONTRIBUTING.md#pull-request-guidelines --> <!-- PULL REQUEST TEMPLATE --> <!-- (Update "[ ]" to "[x]" to check a box) --> **What kind of change does this PR introduce?** (check at least one) - [x] Bugf...
49b6bd4264c25ea41408f066a1835f38bf6fe9f1
7a2b541f186dd9a724eda17717b0bd9831e86116
diff --git a/src/core/instance/lifecycle.ts b/src/core/instance/lifecycle.ts index 94f42e27eb5..d1b5a76d990 100644 --- a/src/core/instance/lifecycle.ts +++ b/src/core/instance/lifecycle.ts @@ -18,6 +18,7 @@ import { invokeWithErrorHandling } from '../util/index' import { currentInstance, setCurrentInstance } from ...
[ "src/core/instance/lifecycle.ts", "test/unit/features/v3/reactivity/effectScope.spec.ts" ]
[]
diff --git a/test/unit/features/v3/reactivity/effectScope.spec.ts b/test/unit/features/v3/reactivity/effectScope.spec.ts index 6b837e67cdc..78966e42e4d 100644 --- a/test/unit/features/v3/reactivity/effectScope.spec.ts +++ b/test/unit/features/v3/reactivity/effectScope.spec.ts @@ -1,3 +1,4 @@ +import Vue from 'vue' imp...
true
vuejs/vuex
2,257
issue_to_patch
docs: augment `vue` rather than `@vue/runtime-core`
https://github.com/nuxt/nuxt/issues/28373#issuecomment-2373531197 This updates the docs to use the currently recommended way to augment component custom properties in Vue 3.
7b024d8bc7ed8e273b8bd853b1e23ec78ab1b045
83e161e13f1d19f22bda6d511ccdc63fd4b2bf5e
diff --git a/docs/guide/migrating-to-4-0-from-3-x.md b/docs/guide/migrating-to-4-0-from-3-x.md index 891ee9d58..3cda020e1 100644 --- a/docs/guide/migrating-to-4-0-from-3-x.md +++ b/docs/guide/migrating-to-4-0-from-3-x.md @@ -58,7 +58,7 @@ Place the following code in your project to allow `this.$store` to be typed corr ...
[ "docs/guide/migrating-to-4-0-from-3-x.md", "docs/guide/typescript-support.md", "docs/ja/guide/migrating-to-4-0-from-3-x.md", "docs/ja/guide/typescript-support.md", "docs/ptbr/guide/migrating-to-4-0-from-3-x.md", "docs/ptbr/guide/typescript-support.md", "docs/zh/guide/migrating-to-4-0-from-3-x.md", "do...
[]
true
vuejs/vuex
2,229
issue_to_patch
fix:error in Vuex document link
Vuex's document, edit this page on GitHub, link to error. This bug comes from the configuration issue with VuePress. The original configured document branch was 4.0, but this branch is no longer visible. This pr changed it to the default branch. issue : https://github.com/vuejs/vuex/issues/2230
0fa7e866d3597db208905b2e6d036d6c5aa59e4c
370d03d2583d6f94d17549012337375cd625857e
diff --git a/docs/.vitepress/config.js b/docs/.vitepress/config.js index 9f7824ae9..e5f9f9432 100644 --- a/docs/.vitepress/config.js +++ b/docs/.vitepress/config.js @@ -36,7 +36,7 @@ module.exports = { themeConfig: { repo: 'vuejs/vuex', docsDir: 'docs', - docsBranch: '4.0', + docsBranch: 'main', ...
[ "docs/.vitepress/config.js" ]
[]
true
vuejs/vuex
2,048
issue_to_patch
Fix deprecated warning in package.json export module (fix #2047)
As mentioned in #2047 Using the `"./": "./"` is being deprecated and it should be changed to `"./*": "./*"` in the future. Adding both to the `package.json` will make it ready for the deprecation and remove the `DeprecationWarning` in the current version.
329828dba41dec59a6880e69a32f9da36c62f3bd
c55665b3cac9457c995700cf6d274aa13030e4e2
diff --git a/package.json b/package.json index e81255924..409ed1d4b 100644 --- a/package.json +++ b/package.json @@ -9,6 +9,7 @@ "require": "./dist/vuex.common.js", "import": "./dist/vuex.mjs" }, + "./*": "./*", "./": "./" }, "module": "dist/vuex.esm.js",
[ "package.json" ]
[]
true
vuejs/vuex
2,207
issue_to_patch
docs: fix links to v2.vuejs.org
close https://github.com/vuejs-translations/docs-zh-cn/issues/623 Notice: I only updated the English and Chinese versions. For others I didn't since I was not quite sure about their own status. Thanks.
28630911b847ac36ac96e73fed7df9c07611defb
ab214ef4b464512d9367c9175861184603f98720
diff --git a/docs/README.md b/docs/README.md index 682df03f3..e57041f27 100644 --- a/docs/README.md +++ b/docs/README.md @@ -66,6 +66,6 @@ If you want to learn Vuex in an interactive way you can check out this [Vuex cou Vuex helps us deal with shared state management with the cost of more concepts and boilerplate. I...
[ "docs/README.md", "docs/api/README.md", "docs/fr/README.md", "docs/guide/state.md", "docs/zh/README.md", "docs/zh/api/README.md", "docs/zh/guide/state.md" ]
[]
true
vuejs/vuex
1,883
issue_to_patch
fix: fix getters being destroyed on component destroy (#1878)
fix #1878 This PR aims to fix #1878, but at the moment this is just adding failing test case. The problem we have is that when component gets destroyed, the getters (`computed`) get's destroyed via Vue. Hence if we call `registerModule` inside a component, any newly registered `computed` will disappear when that ...
3c56e9a7c714c2cb39c72c13f13bf7c684d2bb08
0501bcad2aaac2479e828a6aa512b2f79c8ddc7f
diff --git a/package.json b/package.json index 3aae30a88..b6899b03e 100644 --- a/package.json +++ b/package.json @@ -52,7 +52,7 @@ }, "homepage": "https://github.com/vuejs/vuex#readme", "peerDependencies": { - "vue": "^3.0.2" + "vue": "^3.2.0" }, "dependencies": { "@vue/devtools-api": "^6.0.0-...
[ "package.json", "src/store-util.js", "src/store.js", "test/helpers.js", "test/unit/modules.spec.js", "yarn.lock" ]
[ { "comment": "Can be\r\n```suggestion\r\n component.render = component.render || (() => {})\r\n```", "path": "test/helpers.js", "hunk": "@@ -4,7 +4,7 @@ import puppeteer from 'puppeteer'\n export function mount (store, component) {\n const el = createElement()\n \n- component.render = () => {}\n+ c...
diff --git a/test/helpers.js b/test/helpers.js index 004fabcc7..1c6b82b52 100644 --- a/test/helpers.js +++ b/test/helpers.js @@ -4,7 +4,7 @@ import puppeteer from 'puppeteer' export function mount (store, component) { const el = createElement() - component.render = () => {} + component.render = component.render...
true
vuejs/vuex
1,883
comment_to_fix
fix: fix getters being destroyed on component destroy (#1878)
Can be ```suggestion component.render = component.render || (() => {}) ```
3c56e9a7c714c2cb39c72c13f13bf7c684d2bb08
0501bcad2aaac2479e828a6aa512b2f79c8ddc7f
diff --git a/test/helpers.js b/test/helpers.js index 004fabcc7..1c6b82b52 100644 --- a/test/helpers.js +++ b/test/helpers.js @@ -4,7 +4,7 @@ import puppeteer from 'puppeteer' export function mount (store, component) { const el = createElement() - component.render = () => {} + component.render = component.render...
[ "test/helpers.js" ]
[ { "comment": "Can be\r\n```suggestion\r\n component.render = component.render || (() => {})\r\n```", "path": "test/helpers.js", "hunk": "@@ -4,7 +4,7 @@ import puppeteer from 'puppeteer'\n export function mount (store, component) {\n const el = createElement()\n \n- component.render = () => {}\n+ c...
true
vuejs/vuex
1,883
comment_to_fix
fix: fix getters being destroyed on component destroy (#1878)
You could also pass a spy and count the number of times it's called
3c56e9a7c714c2cb39c72c13f13bf7c684d2bb08
0501bcad2aaac2479e828a6aa512b2f79c8ddc7f
diff --git a/test/unit/modules.spec.js b/test/unit/modules.spec.js index 17a09857b..9c6e96e46 100644 --- a/test/unit/modules.spec.js +++ b/test/unit/modules.spec.js @@ -1,4 +1,5 @@ -import { nextTick } from 'vue' +import { h, nextTick } from 'vue' +import { mount } from 'test/helpers' import Vuex from '@/index' con...
[ "test/unit/modules.spec.js" ]
[ { "comment": "You could also pass a spy and count the number of times it's called", "path": "test/unit/modules.spec.js", "hunk": "@@ -124,6 +125,49 @@ describe('Modules', () => {\n store.commit('a/foo')\n expect(mutationSpy).toHaveBeenCalled()\n })\n+\n+ it('should keep getters when c...
true
vuejs/vuex
1,883
comment_to_fix
fix: fix getters being destroyed on component destroy (#1878)
You can also destroy the `vm` and mount it again
3c56e9a7c714c2cb39c72c13f13bf7c684d2bb08
0501bcad2aaac2479e828a6aa512b2f79c8ddc7f
diff --git a/test/unit/modules.spec.js b/test/unit/modules.spec.js index 17a09857b..9c6e96e46 100644 --- a/test/unit/modules.spec.js +++ b/test/unit/modules.spec.js @@ -1,4 +1,5 @@ -import { nextTick } from 'vue' +import { h, nextTick } from 'vue' +import { mount } from 'test/helpers' import Vuex from '@/index' con...
[ "test/unit/modules.spec.js" ]
[ { "comment": "You can also destroy the `vm` and mount it again", "path": "test/unit/modules.spec.js", "hunk": "@@ -124,6 +125,49 @@ describe('Modules', () => {\n store.commit('a/foo')\n expect(mutationSpy).toHaveBeenCalled()\n })\n+\n+ it('should keep getters when component gets destr...
true