repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
w7corp/easywechat
2,944
issue_to_patch
Add comprehensive HTTP client logging documentation for 6.x
Addresses the need for custom HTTP client logging documentation after the default logging functionality was removed in version 6.x. While users can still implement logging through the `LoggerAwareInterface` pattern in `InteractWithHttpClient.php`, there was no documentation explaining how to do this. ## What's Added ...
a804ac545e868a856f0bb1871645ffeea2b21743
7678cd9217bc3f0811e336700e24c00b3d045c57
diff --git a/docs/src/6.x/logging.md b/docs/src/6.x/logging.md index c104790bd..feab50de7 100644 --- a/docs/src/6.x/logging.md +++ b/docs/src/6.x/logging.md @@ -54,3 +54,189 @@ $app->getLogger()->extend('mylog', function($app, $config){ ], ], ``` + +## 自定义 HTTP 客户端日志 + +在 6.x 版本中,虽然移除了默认的日志功能,但用户仍然可以通过自定义 HTTP 客...
[ "docs/src/6.x/logging.md" ]
[]
true
w7corp/easywechat
2,943
issue_to_patch
Add comprehensive custom cache documentation for EasyWeChat 6.x
This PR adds comprehensive documentation for custom cache configuration in EasyWeChat 6.x, addressing the need for updated caching guidance that reflects the new architecture introduced in version 6.x. ## What's Added ### New Documentation File - **`docs/src/6.x/cache.md`** - Complete guide to custom caching in 6.x w...
4cf531507825d24f9abbaaaedfa0ad9d966a685b
7533a4ba8410b5becf131452a219f8bbc6a9806c
diff --git a/docs/src/6.x/cache.md b/docs/src/6.x/cache.md new file mode 100644 index 000000000..15679bdd4 --- /dev/null +++ b/docs/src/6.x/cache.md @@ -0,0 +1,518 @@ +# 缓存 + +EasyWeChat 6.x 使用 [symfony/cache](https://github.com/symfony/cache) 组件来处理缓存,它支持目前几乎所有主流的缓存引擎。 + +在 SDK 中,所有缓存默认使用文件系统缓存,缓存路径取决于 PHP 的临时目录。如果你需要自...
[ "docs/src/6.x/cache.md", "docs/src/6.x/sidebar.js" ]
[]
true
w7corp/easywechat
2,936
issue_to_patch
feat 增加企微智能机器人回调支持
企微新增智能机器人相关回调,消息格式和加密方法有所不同。 此次更新增加对机器人回调的支持。
12f0175cd2fee4a3fe14638c2be06bca74990685
761ff90e2d47043f7bcb67b23d05f2530a91f029
diff --git a/docs/src/6.x/work/server.md b/docs/src/6.x/work/server.md index 6c8024a29..4011deba1 100755 --- a/docs/src/6.x/work/server.md +++ b/docs/src/6.x/work/server.md @@ -93,6 +93,30 @@ $server->handleUserTagUpdated(function($message, \Closure $next) { }); ``` +### 智能机器人事件 +因智能机器人消息变更为JSON格式,需要在获取 `server` 对象...
[ "docs/src/6.x/work/server.md", "src/Kernel/Encryptor.php", "src/Kernel/Message.php", "src/Kernel/Traits/DecryptJsonMessage.php", "src/Kernel/Traits/RespondJsonMessage.php", "src/Work/Application.php", "src/Work/Server.php" ]
[]
true
w7corp/easywechat
2,522
issue_to_patch
修复无法通过 withFile 方式上传文件的小问题
85a49397713662c5b98d661a5a9ad8f5566042c4
ab3a70117f458ce42d9a037cef7a283d34626ac1
diff --git a/src/Kernel/HttpClient/RequestWithPresets.php b/src/Kernel/HttpClient/RequestWithPresets.php index 94e431ab3..a47806db7 100644 --- a/src/Kernel/HttpClient/RequestWithPresets.php +++ b/src/Kernel/HttpClient/RequestWithPresets.php @@ -95,19 +95,15 @@ public function withFile(string $pathOrContents, string $fo...
[ "src/Kernel/HttpClient/RequestWithPresets.php" ]
[]
true
w7corp/easywechat
2,935
issue_to_patch
build(deps): bump form-data from 4.0.3 to 4.0.4 in /docs in the npm_and_yarn group across 1 directory
Bumps the npm_and_yarn group with 1 update in the /docs directory: [form-data](https://github.com/form-data/form-data). Updates `form-data` from 4.0.3 to 4.0.4 <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/form-data/form-data/blob/master/CHANGELOG.md">form-data's changelog</a>....
646aa9d328dbb2914530b6e2223bb5be259f93e7
f41114b0913276acd3e4ec3063c0f39cefe807c3
diff --git a/docs/pnpm-lock.yaml b/docs/pnpm-lock.yaml index 47e73b601..f841917af 100644 --- a/docs/pnpm-lock.yaml +++ b/docs/pnpm-lock.yaml @@ -309,6 +309,9 @@ packages: resolution: {integrity: sha512-O8jcjabXaleOG9DQ0+ARXWZBTfnP4WNAqzuiJK7ll44AmxGKv/J2M4TPjxjY3znBCfvBXFzucm1twdyFybFqEA==} engines: {node: '>...
[ "docs/pnpm-lock.yaml" ]
[]
true
w7corp/easywechat
2,930
issue_to_patch
fix: 修复PHP8.4下隐式 nullable 参数声明弃用的问题(5.x)
在PHP8.4下隐式 nullable 参数声明会导致弃用警告:`Implicitly marking parameter $token as nullable is deprecated, the explicit nullable type must be used instead`
967bcaebdbe5748f950da5a6052d68755ba71bbc
3ea1818c93542e8f03e638aa7bd87c83dbf75167
diff --git a/src/BasicService/Jssdk/Client.php b/src/BasicService/Jssdk/Client.php index 0c0a2fa22..1712447be 100644 --- a/src/BasicService/Jssdk/Client.php +++ b/src/BasicService/Jssdk/Client.php @@ -55,7 +55,7 @@ class Client extends BaseClient * @throws \Psr\SimpleCache\InvalidArgumentException * @throws...
[ "src/BasicService/Jssdk/Client.php", "src/Kernel/BaseClient.php", "src/Kernel/Encryptor.php", "src/Kernel/Exceptions/HttpException.php", "src/Kernel/Messages/Transfer.php", "src/Kernel/ServiceContainer.php", "src/Kernel/Support/Arr.php", "src/Kernel/Traits/HasHttpRequests.php", "src/MiniProgram/AppC...
[]
diff --git a/tests/Kernel/BaseClientTest.php b/tests/Kernel/BaseClientTest.php index ed3d8528b..809b0d326 100644 --- a/tests/Kernel/BaseClientTest.php +++ b/tests/Kernel/BaseClientTest.php @@ -23,7 +23,7 @@ class BaseClientTest extends TestCase { - public function makeClient($methods = [], ServiceContainer $app ...
true
w7corp/easywechat
2,929
issue_to_patch
增加草稿箱的文档(5.x)
发现5.x文档缺少了草稿箱相关文档, 因此补上
357cf4874f0251a2a592a967e085174822ecb241
05cc5652df1b72d348f9cfa2279ea9cecdbd39f7
diff --git a/docs/src/5.x/official-account/draft.md b/docs/src/5.x/official-account/draft.md new file mode 100644 index 000000000..b5a4b6218 --- /dev/null +++ b/docs/src/5.x/official-account/draft.md @@ -0,0 +1,76 @@ +# 草稿箱 + +草稿箱提供了公众号文章的草稿管理功能,你可以通过草稿箱 API 添加、获取或删除草稿。 + +### 添加草稿 + +```php +use EasyWeChat\Kernel\Mess...
[ "docs/src/5.x/official-account/draft.md", "docs/src/5.x/sidebar.js" ]
[]
true
w7corp/easywechat
2,928
issue_to_patch
docs: typo `getRequestMessage` ref #2927, upgrade deps
fixed #2927 ```diff - $message = $server->getReqeustMessage(); + $message = $server->getRequestMessage(); ```
b6856db2d7404f0d132d24c5df5ed0c6969df2bc
9f0efe8d155c68a337c86d1798294529bd2883e0
diff --git a/docs/package.json b/docs/package.json index fb9bfd9a6..6a0533ceb 100644 --- a/docs/package.json +++ b/docs/package.json @@ -16,7 +16,7 @@ }, "devDependencies": { "@types/markdown-it": "^14.1.2", - "@types/node": "^22.15.29", + "@types/node": "^22.15.31", "postcss": "^8.5.4", "pos...
[ "docs/package.json", "docs/pnpm-lock.yaml", "docs/src/6.x/pay/server.md" ]
[]
true
w7corp/easywechat
2,926
issue_to_patch
docs: upgrade deps and typo `purge-caches` directive
更新依赖包版本及修正单词拼写
33968dd79a235a77f221aaed62c5d47f0d2b5eee
54d59666ceb452a3a732c565bac87a20c854a754
diff --git a/docs/package.json b/docs/package.json index 22a2b7b3a..fb9bfd9a6 100644 --- a/docs/package.json +++ b/docs/package.json @@ -4,22 +4,22 @@ "dev": "vitepress dev", "build": "vitepress build", "serve": "vitepress serve", - "pure-caches": "./purge-caches", + "purge-caches": "./purge-caches...
[ "docs/package.json", "docs/pnpm-lock.yaml" ]
[]
true
w7corp/easywechat
2,923
issue_to_patch
fix docs: fix the jssdk demo was missed the left angle bracket
修复demo示例错误
128e30df03411099440e3c1098732697caab78d4
b93f042960757aee7d9d917c22c3afdd072214b5
diff --git a/docs/src/6.x/pay/utils.md b/docs/src/6.x/pay/utils.md index b29f8c046..18711fdb2 100644 --- a/docs/src/6.x/pay/utils.md +++ b/docs/src/6.x/pay/utils.md @@ -1,3 +1,8 @@ +--- +title: 工具 | 微信支付 +aside: false +--- + # 工具 提供各种支付需要的配置生成方法。 @@ -39,7 +44,7 @@ WeixinJSBridge.invoke( { timeStamp: "<?= $c...
[ "docs/src/6.x/pay/utils.md" ]
[]
true
w7corp/easywechat
2,922
issue_to_patch
docs: fix the broken links(on the `pay.weixin` subdomain)
修正微信支付官方文档链接
2e148a4a53b75862a16db995d95f7e933bc005eb
d7d19d1230d9037b84a517815571ab7c5ed064ef
diff --git a/docs/package.json b/docs/package.json index b14bc7a18..22a2b7b3a 100644 --- a/docs/package.json +++ b/docs/package.json @@ -16,10 +16,10 @@ }, "devDependencies": { "@types/markdown-it": "^14.1.2", - "@types/node": "^22.13.14", + "@types/node": "^22.14.1", "postcss": "^8.5.3", "po...
[ "docs/package.json", "docs/pnpm-lock.yaml", "docs/src/6.x/client.md", "docs/src/6.x/contributing.md", "docs/src/6.x/mini-app/config.md", "docs/src/6.x/mini-app/server.md", "docs/src/6.x/official-account/config.md", "docs/src/6.x/pay/index.md", "docs/src/6.x/pay/media.md", "docs/src/6.x/pay/server....
[]
true
w7corp/easywechat
2,919
issue_to_patch
Update server.md
第三方封装了request请求的框架踩坑笔记
0c4722a2d1e8ff23080418ca997b0f161a118c47
e4beff0b957532d8884d8b797d6717e582e48dc9
diff --git a/docs/src/6.x/official-account/server.md b/docs/src/6.x/official-account/server.md index 7f0a88ae4..4f62ec09f 100755 --- a/docs/src/6.x/official-account/server.md +++ b/docs/src/6.x/official-account/server.md @@ -203,3 +203,4 @@ return $response; ``` > `$response` 是一个 [Psr\Http\Message\ResponseInterface...
[ "docs/src/6.x/official-account/server.md" ]
[]
true
w7corp/easywechat
2,918
issue_to_patch
Update index.md
新手避坑
0c4722a2d1e8ff23080418ca997b0f161a118c47
81e33609c647367c72c182102111d903dfcc3ae0
diff --git a/docs/src/6.x/work/index.md b/docs/src/6.x/work/index.md index e24386d43..7f80852cd 100755 --- a/docs/src/6.x/work/index.md +++ b/docs/src/6.x/work/index.md @@ -13,6 +13,9 @@ $config = [ 'secret' => 'f1c242f4f28f735d4687abb469072axx', 'token' => 'easywechat', 'aes_key' => '35d4687abb469072a29f1c242...
[ "docs/src/6.x/work/index.md" ]
[]
true
w7corp/easywechat
2,916
issue_to_patch
InteractWithConfig.php中的@throws InvalidArgumentException注释需要修改 在文件 `src/Kernel/Traits/InteractWithConfig.php` 中,第20行的注释标注了 `@throws InvalidArgumentException`,但实际上代码并不会抛出这个异常,因为 `Config` 并没有配置 `requiredKeys`。 这个注释会误导写单元测试时多一个 `InvalidArgumentException` 的测试。为了保持代码文档的准确性,建议移除或修改这个注释。 相关代码位置: https://github.com/w7corp/e...
Cleanup the `@throws` code comments
做了一点点代码清洁, close #2915
ea6460149b20a0a31d614d18c5c8cbe77414c4ca
a91a770997b6543e0fd9a03c17cfb0512ca9ed0d
diff --git a/docs/package.json b/docs/package.json index 19ed45788..b14bc7a18 100644 --- a/docs/package.json +++ b/docs/package.json @@ -8,7 +8,7 @@ "preinstall": "npx only-allow pnpm" }, "dependencies": { - "autoprefixer": "^10.4.20", + "autoprefixer": "^10.4.21", "clipboard": "^2.0.11", "dy...
[ "docs/package.json", "docs/pnpm-lock.yaml", "src/Kernel/Contracts/Server.php", "src/Kernel/Encryptor.php", "src/Kernel/Form/File.php", "src/Kernel/HttpClient/AccessTokenAwareClient.php", "src/Kernel/HttpClient/RequestUtil.php", "src/Kernel/HttpClient/Response.php", "src/Kernel/Support/AesCbc.php", ...
[]
true
w7corp/easywechat
2,907
issue_to_patch
chore: free the `ext-sodium` dependency
The `6.x` won't need `ext-sodium` anymore.
c51c2683c4adb5f6130a3e2ae60446c4405b8965
8f52db6700a49764765a7d0a9e4cf9cd6eb15b14
diff --git a/composer.json b/composer.json index 47cdf92b2..2746ddfda 100644 --- a/composer.json +++ b/composer.json @@ -20,7 +20,6 @@ "ext-fileinfo": "*", "ext-openssl": "*", "ext-simplexml": "*", - "ext-sodium": "*", "ext-libxml": "*", "ext-curl": "*", "nyholm/psr7": "^1.5", @@ -41,7 ...
[ "composer.json" ]
[]
true
w7corp/easywechat
2,904
issue_to_patch
fix: 示例错误,shipping_list应该是一个对象数组
shipping_list应该是一个对象数组,直接复制示例过去改,调试了很久才发现问题所在。更正以方便他人。 ![文档截图](https://github.com/user-attachments/assets/a8a54f5b-8500-4ed4-afba-d540b6429e69)
994a75faefcdf4a2b58e931773c23ad00b647b16
fd0e1b7481c2e1cda031da317cf5a2c29a9972ba
diff --git a/docs/src/5.x/mini-program/shipping.md b/docs/src/5.x/mini-program/shipping.md index 679ec4f10..e26973cf4 100644 --- a/docs/src/5.x/mini-program/shipping.md +++ b/docs/src/5.x/mini-program/shipping.md @@ -15,13 +15,15 @@ $data = [ 'logistics_type' => 4, 'delivery_mode' => 1, 'shipping_list' =...
[ "docs/src/5.x/mini-program/shipping.md" ]
[]
true
w7corp/easywechat
2,903
issue_to_patch
doc: refined the code samples
2a06eda0e316bb48e32cca05f948cb2befa4bfaf
b85f4537ca27155f18ce69d4a055a9b1c3509d25
diff --git a/docs/src/6.x/index.md b/docs/src/6.x/index.md index 87db69a64..cf9ba1409 100755 --- a/docs/src/6.x/index.md +++ b/docs/src/6.x/index.md @@ -20,8 +20,8 @@ EasyWeChat 是一个开源的 [微信](http://www.wechat.com) 非官方 SDK。 ::: -```shell -composer require w7corp/easywechat:^6.7 +```shell:no-line-numbers +composer re...
[ "docs/src/6.x/index.md", "docs/src/6.x/introduction.md", "docs/src/6.x/mini-app/examples.md", "docs/src/6.x/official-account/examples.md", "docs/src/6.x/open-platform/examples.md", "docs/src/6.x/open-work/examples.md", "docs/src/6.x/pay/examples.md", "docs/src/6.x/work/examples.md" ]
[]
true
w7corp/easywechat
2,902
issue_to_patch
doc: upgrade `tenyun`@`^0.12.0` for `purge-caches`
511e15d86008b1ff730277e1d305cdaef18e25d2
b197e2fc4e8d2636b486b6d65e0487dec9788fbc
diff --git a/docs/package.json b/docs/package.json index 8ae9f669f..19ed45788 100644 --- a/docs/package.json +++ b/docs/package.json @@ -16,10 +16,10 @@ }, "devDependencies": { "@types/markdown-it": "^14.1.2", - "@types/node": "^22.13.4", + "@types/node": "^22.13.7", "postcss": "^8.5.3", "pos...
[ "docs/package.json", "docs/pnpm-lock.yaml" ]
[]
true
w7corp/easywechat
2,901
issue_to_patch
给 getClient() 增加 Client 类型的返回
1edcacd7efdd354ea816a52dccef8e6fdc13afb0
841d5fe52907a8150c67380a1228e6b8e1f93138
diff --git a/src/Pay/Application.php b/src/Pay/Application.php index f7f958969..76452b369 100644 --- a/src/Pay/Application.php +++ b/src/Pay/Application.php @@ -119,7 +119,7 @@ public function getConfig(): ConfigInterface * @throws \EasyWeChat\Kernel\Exceptions\InvalidArgumentException * @throws \EasyWeChat...
[ "src/Pay/Application.php" ]
[]
true
w7corp/easywechat
2,900
issue_to_patch
renamed & optim `purge-caches`
with `cdn.DescribePurgeTasks` chain
1daaa3f1d0724da360929cef00fde1a08cf5d8d6
874b64ef46e304aced1b7b591954e6dd2d0f0833
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 52d203b4a..9efe7af04 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -69,4 +69,4 @@ jobs: if: env.COS_SECRET_ID env: COS_SECRET_KEY: ${{secrets.COS_SECRET_KEY}} - run: ./doc...
[ ".github/workflows/deploy.yml", "docs/package.json", "docs/pure-caches", "docs/purge-caches" ]
[]
true
w7corp/easywechat
2,899
issue_to_patch
fill deploy.steps.setup-node.cache-dependency-path
ebfe7c4beb5131ff10ecbe08ef8bae43ef4bee38
479eac55319c4b58ae4cd96cf1df5e3c48d6f272
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 6c63d3eb3..52d203b4a 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -7,6 +7,10 @@ on: # Triggers the workflow on push event but only for the 6.x branch(required the secrets environment) push: branc...
[ ".github/workflows/deploy.yml" ]
[]
true
w7corp/easywechat
2,898
issue_to_patch
fix `pnpm install` on wrong folder
35779bc061bee801d8626c966bd7bf3bd8ac424a
1dc8c770477f02d98200b4570eff85eb78bcf257
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index ce3cef34c..6c63d3eb3 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -40,11 +40,10 @@ jobs: with: node-version: '>=22.12.0' cache: 'pnpm' - - name: Install dependencies - ...
[ ".github/workflows/deploy.yml" ]
[]
true
w7corp/easywechat
2,897
issue_to_patch
doc: use `node>=22.12` onto the deploy
870220f1619a2aaab43aa11bde30d45b4fb973ab
f812a9e8a28ca5e4b72ce4cd6b68ee1b22717ea6
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 5460ea9cf..ce3cef34c 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -35,7 +35,13 @@ jobs: - uses: pnpm/action-setup@v4 with: version: 10 - run_install: true + run_...
[ ".github/workflows/deploy.yml" ]
[]
true
w7corp/easywechat
2,896
issue_to_patch
doc: upgrade `tenyun@^0.11.5` for `pure-caches`
c7ad615bd6237ec524ecd0cd858d9d906d610a4b
ebbc6b63b9e18a0439c5fc686b32bda9f3bf73b0
diff --git a/docs/package.json b/docs/package.json index 88b8a5bdd..3e25653e5 100644 --- a/docs/package.json +++ b/docs/package.json @@ -17,9 +17,9 @@ "devDependencies": { "@types/markdown-it": "^14.1.2", "@types/node": "^22.13.4", - "postcss": "^8.5.2", + "postcss": "^8.5.3", "postcss-import": ...
[ "docs/package.json", "docs/pnpm-lock.yaml" ]
[]
true
w7corp/easywechat
2,894
issue_to_patch
doc: fix pure caches with realpath
rt
3978f40811d4e5f1cb9c76b4a29785ec932e5099
064fa3760a39d3a8e073ddcd6dcd1eb6cab55a8c
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 2b653d576..0d2153522 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -56,4 +56,6 @@ jobs: if: env.COS_SECRET_ID env: COS_SECRET_KEY: ${{secrets.COS_SECRET_KEY}} - run: pnpm ...
[ ".github/workflows/deploy.yml" ]
[]
true
w7corp/easywechat
2,895
issue_to_patch
fix `docs/pure-caches` in cjs mode
and won't need chdir on `./docs/pure-caches` on deploy.yml
3fc8a921815752b71c071d1f603a8854e549385e
72fc6cbed036082b99c8dd3c05d61b79c6baee9d
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index 0d2153522..5460ea9cf 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -56,6 +56,4 @@ jobs: if: env.COS_SECRET_ID env: COS_SECRET_KEY: ${{secrets.COS_SECRET_KEY}} - run: | - ...
[ ".github/workflows/deploy.yml", "docs/pure-caches" ]
[]
true
w7corp/easywechat
2,893
issue_to_patch
refresh the tencent cdn cachess by npm:tenyun pkg
- enabled `vitepress.metaChunk` = true - use `pure-caches` to pure the tencentcloud cdn caches
025cc177e6e8c6a00599c39c084dfccf6e1e86a8
ba11179ba077687ee91e85750483d96f801a8f13
diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml index b181ca7cd..2b653d576 100644 --- a/.github/workflows/deploy.yml +++ b/.github/workflows/deploy.yml @@ -34,7 +34,7 @@ jobs: - uses: actions/checkout@v4 - uses: pnpm/action-setup@v4 with: - version: 9 + ...
[ ".github/workflows/deploy.yml", "docs/.vitepress/config.ts", "docs/package.json", "docs/pnpm-lock.yaml", "docs/pure-caches" ]
[]
true
w7corp/easywechat
2,892
issue_to_patch
doc: fix vercel deploy
this bug https://github.com/vuejs/vitepress/pull/4128 was there a looooong time, it is blocked the vercel default deploy. hence go back without the custom-css-notation.
ae099bcccc387f67e9ab035bb575efff4e5b560e
c2f95182e7908fad3066c04095c83f8f926c00ac
diff --git a/docs/src/6.x/work/examples.md b/docs/src/6.x/work/examples.md index 0d86a6b3f..09192cb73 100644 --- a/docs/src/6.x/work/examples.md +++ b/docs/src/6.x/work/examples.md @@ -4,7 +4,7 @@ ## [被动回复](https://developer.work.weixin.qq.com/document/path/90241) {#server-mode} -::: details 被动回复一个图片信息 {open .bg-t...
[ "docs/src/6.x/work/examples.md" ]
[]
true
w7corp/easywechat
2,891
issue_to_patch
怎样被动回复非文本信息? 在企微应用里面发文本信息后,后端在收到处理完成,想发图文等等其他类型信息,要怎样做?现在直接return的string就是回复内容。不满足需求
doc: typo `EasyWeChat\Work\Message` on `work/server.md`
close w7corp/easywechat#2884
6679b254572c2045d534875b7c09e08f68439b2b
dcf810a1acd81511740e342b38d3e872c5a4e615
diff --git a/docs/.vitepress/theme/styles/pages.css b/docs/.vitepress/theme/styles/pages.css index 4721cec9b..0fc0fedae 100644 --- a/docs/.vitepress/theme/styles/pages.css +++ b/docs/.vitepress/theme/styles/pages.css @@ -13,3 +13,7 @@ .vt-doc.sponsor h3 .header-anchor { display: none; } + +.custom-block.details.bg...
[ "docs/.vitepress/theme/styles/pages.css", "docs/src/6.x/work/examples.md", "docs/src/6.x/work/server.md" ]
[]
true
wagoodman/dive
586
issue_to_patch
Failed to Create Container After Upgrading to 0.13.0 ## Problem Description After upgrading to version 0.13.0, container creation fails with the following error: ``` failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "s...
Use alpine as basis for docker image
There are multiple users that are using dive as a container image and are expecting to be able to exec in and run other commands. This PR restores the alpine image as the base instead of using scratch. - Fixes #582 - Fixes #580 - Fixes #576
8483e30080fa766113e1485f499b1e0f71c8b0c7
5170a62310929eb4bf704c1f545a02768dec752e
diff --git a/Dockerfile b/Dockerfile index f0792d02..8c347e22 100644 --- a/Dockerfile +++ b/Dockerfile @@ -6,7 +6,6 @@ RUN wget -O- https://download.docker.com/linux/static/stable/$(uname -m)/docker- COPY dive /usr/local/bin/ -FROM scratch -COPY --from=base /usr/local/bin /usr/local/bin - +# though we could make t...
[ "Dockerfile" ]
[]
true
wagoodman/dive
481
issue_to_patch
[Vulnerabilities] Update Dockerfile Alpine Image from alpine:3.12 => alpine:3.18
Hi, I am proposing an upgrade of the alpine image to patch discovered vulnerabilities. Trivy Report showing vunlarability: WARN This OS version is no longer supported by the distribution: alpine 3.12.12 │ zlib │ CVE-2022-37434 │ CRITICAL │ fixed │ 1.2.12-r0 │ 1.2.12-r2 | https://avd.aquasec.com/nv...
fd526464b27c48c31afa4754a2af7f39d53ba64e
98b018a0f7b93e8bc9372ee9988305f8f40c020e
diff --git a/Dockerfile b/Dockerfile index 24056d83..42cdaa25 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,4 +1,4 @@ -FROM alpine:3.12 +FROM alpine:3.18 ARG DOCKER_CLI_VERSION=${DOCKER_CLI_VERSION} RUN wget -O- https://download.docker.com/linux/static/stable/$(uname -m)/docker-${DOCKER_CLI_VERSION}.tgz | \
[ "Dockerfile" ]
[]
true
wagoodman/dive
535
issue_to_patch
chore(deps): Update dependencies
### Features * Update go.mod to 1.21 * Update Go dependencies * Update build dependencies * Update GitHub Actions * Build and release with Go 1.22 * Update alpine to 3.20 * Simplify Dockerfile and squash layers * Configure Dependabot to update go.mod, Dockerfile and GitHub Actions * Fix 3 security vulnerabilit...
e65b32c4d7c72b12e96783064aa3c224a5dd7aba
841ba7b0d948d1e887ae066eeb0a0a063a44b727
diff --git a/.github/dependabot.yaml b/.github/dependabot.yaml new file mode 100644 index 00000000..0405f8e5 --- /dev/null +++ b/.github/dependabot.yaml @@ -0,0 +1,14 @@ +version: 2 +updates: + - package-ecosystem: "gomod" + directory: "/" + schedule: + interval: "weekly" + - package-ecosystem: "docker" + ...
[ ".github/dependabot.yaml" ]
[]
true
wagoodman/dive
574
issue_to_patch
fix: Login to GHCR as owner not actor
The official docs do document the login step with `username: ${{ github.actor }}`, which will be the user that triggered a workflow event. For consistency, prefer `${{ github.repository_owner }}` instead, which will be specific to the repo that the workflow is running at.
270f321d2337100adfd02224925a848d490215c3
b03436663d0c04220463a486489c7d126c994847
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 17e54180..bc132916 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -111,7 +111,7 @@ jobs: uses: docker/login-action@v3 with: registry: ${{ env.REGISTRY }} - userna...
[ ".github/workflows/release.yaml" ]
[]
true
wagoodman/dive
577
issue_to_patch
Publish dive to ghcr.io **What happened**: I tried out: ``` docker pull ghcr.io/wagoodman/dive ``` and got this response: ``` Error response from daemon: Head "https://ghcr.io/v2/wagoodman/dive/manifests/latest": denied ``` **What you expected to happen**: The image to be pulled. **How to reproduce it (as minim...
Update docker image release definitions
The following changes were made to the release pipeline: - removed the need to install qemu and buildx as the same functionality is now built into docker natively - removed REGISTRY references to swap out where the image is being pushed to - pushes to both `ghcr.io` and `docker.io` registries - tags built include `...
90317a6c66571cd64b9d99c49d9449d2acadf151
6cc21417858183390a743da1dd0652554d0c491e
diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index bc132916..d10a1678 100644 --- a/.github/workflows/release.yaml +++ b/.github/workflows/release.yaml @@ -83,9 +83,6 @@ jobs: contents: write # for pushing container images packages: write - env: - REGISTRY: gh...
[ ".github/workflows/release.yaml", ".goreleaser.yaml", "Makefile", "README.md" ]
[]
true
wagoodman/dive
578
issue_to_patch
Bump github.com/docker/cli from 28.0.1+incompatible to 28.0.2+incompatible
Bumps [github.com/docker/cli](https://github.com/docker/cli) from 28.0.1+incompatible to 28.0.2+incompatible. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/docker/cli/commit/0442a7378f37ef9482ade1c8addf618cb8becb00"><code>0442a73</code></a> Merge pull request <a href="https://redirect.github...
55713768e8a5ac677babfefeade98af1c9ebd8b9
5959439a054d79d396a92b4f551671492442ca61
diff --git a/go.mod b/go.mod index 95383087..ecb2cff0 100644 --- a/go.mod +++ b/go.mod @@ -6,7 +6,7 @@ require ( github.com/awesome-gocui/gocui v1.1.0 github.com/awesome-gocui/keybinding v1.0.1-0.20211011072933-86029037a63f github.com/cespare/xxhash/v2 v2.3.0 - github.com/docker/cli v28.0.1+incompatible + github....
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
584
issue_to_patch
chore: Port from using Makefile to Taskfile
This is a little bit of cleanup, primarily removing the use of the Makefile when running tasks. This also brings in binny to manage tools used within these tasks.
2342d85e26f8c4ddfd73ba993b75b070bb403972
4e959d684402b8867dfa4261cf96ee4845632fe7
diff --git a/.binny.yaml b/.binny.yaml new file mode 100644 index 00000000..b03f4d98 --- /dev/null +++ b/.binny.yaml @@ -0,0 +1,64 @@ +tools: + # we want to use a pinned version of binny to manage the toolchain (so binny manages itself!) + - name: binny + version: + want: v0.9.0 + method: github-release + ...
[ ".binny.yaml", ".github/actions/bootstrap/action.yaml", ".github/scripts/ci-check.sh", ".github/scripts/go-mod-tidy-check.sh", ".gitignore", "Makefile", "Taskfile.yaml" ]
[]
true
wagoodman/dive
585
issue_to_patch
Fix layer selection to select only one layer at a time
It looks like some of the time I'm seeing the layers view become a little overzealous when it comes to selecting a single layer: <img width="653" alt="Screenshot 2025-03-29 at 10 18 54 AM" src="https://github.com/user-attachments/assets/6dc9479c-f360-496e-9733-0e27c5e29d28" /> This forces any formatting function ...
dd450a74749ed301fd5f002f8c7d94dcb0c81d43
f33bf0e98966a1fc5ddf8103b12465e56301e4e6
diff --git a/runtime/ui/format/format.go b/runtime/ui/format/format.go index e0b804fd..7ef08129 100644 --- a/runtime/ui/format/format.go +++ b/runtime/ui/format/format.go @@ -46,17 +46,25 @@ var ( StatusControlNormal func(...interface{}) string CompareTop func(...interface{}) string CompareBottom ...
[ "runtime/ui/format/format.go", "runtime/ui/view/layer.go" ]
[]
true
wagoodman/dive
597
issue_to_patch
Bump go.uber.org/atomic from 1.9.0 to 1.11.0
Bumps [go.uber.org/atomic](https://github.com/uber-go/atomic) from 1.9.0 to 1.11.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/uber-go/atomic/releases">go.uber.org/atomic's releases</a>.</em></p> <blockquote> <h2>v1.11.0</h2> <h3>Fixed</h3> <ul> <li>Fix <code>Swap</code> ...
86f7c1506b8ed02d8f7eb9db0d493a5a767afc5e
bf250d1b3cff56b53a7fa2c2492f0f023436e3f2
diff --git a/go.mod b/go.mod index ed9a07a2..616d628e 100644 --- a/go.mod +++ b/go.mod @@ -27,7 +27,7 @@ require ( github.com/stretchr/testify v1.10.0 github.com/wagoodman/go-partybus v0.0.0-20230516145632-8ccac152c651 github.com/wagoodman/go-progress v0.0.0-20230925121702-07e42b3cdba0 - go.uber.org/atomic v1.9.0...
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
600
issue_to_patch
Bump github.com/docker/cli from 28.0.4+incompatible to 28.1.1+incompatible
Bumps [github.com/docker/cli](https://github.com/docker/cli) from 28.0.4+incompatible to 28.1.1+incompatible. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/docker/cli/commit/4eba3773274f9d21ba90ae5bc719c3f1e4bb07a1"><code>4eba377</code></a> Merge pull request <a href="https://redirect.github...
c22c76f997085e06e88508305d0e2faeed331ded
f502ae569976277c1dc533a9913d3d29b926a2d7
diff --git a/go.mod b/go.mod index 05a9b657..b4fcca87 100644 --- a/go.mod +++ b/go.mod @@ -9,7 +9,7 @@ require ( github.com/awesome-gocui/keybinding v1.0.1-0.20211011072933-86029037a63f github.com/cespare/xxhash/v2 v2.3.0 github.com/charmbracelet/lipgloss v1.1.0 - github.com/docker/cli v28.0.4+incompatible + gith...
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
603
issue_to_patch
Bump golang.org/x/net from 0.39.0 to 0.40.0
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.39.0 to 0.40.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/net/commit/7d6e62ace5ed100018bd82d1967d2d98cff6fbae"><code>7d6e62a</code></a> go.mod: update golang.org/x dependencies</li> <li><a href="https://github.com/gola...
c22c76f997085e06e88508305d0e2faeed331ded
7990cbc05d4228d808f3364cd672849659abe799
diff --git a/go.mod b/go.mod index 05a9b657..af294f2a 100644 --- a/go.mod +++ b/go.mod @@ -28,7 +28,7 @@ require ( github.com/wagoodman/go-partybus v0.0.0-20230516145632-8ccac152c651 github.com/wagoodman/go-progress v0.0.0-20230925121702-07e42b3cdba0 go.uber.org/atomic v1.9.0 - golang.org/x/net v0.39.0 + golang.o...
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
598
issue_to_patch
Bump golang.org/x/net from 0.38.0 to 0.39.0
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.38.0 to 0.39.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/net/commit/b8d88774daf2a7cf137dad5173fc9bb981fc18fb"><code>b8d8877</code></a> go.mod: update golang.org/x dependencies</li> <li>See full diff in <a href="https:...
788fcd383407818ab64ef53a70bda0bec695de8e
184bb6c93d535073eabf4f6bc7bdfe568e6bdd1f
diff --git a/go.mod b/go.mod index 79f8fb99..066018f0 100644 --- a/go.mod +++ b/go.mod @@ -28,7 +28,7 @@ require ( github.com/wagoodman/go-partybus v0.0.0-20230516145632-8ccac152c651 github.com/wagoodman/go-progress v0.0.0-20230925121702-07e42b3cdba0 go.uber.org/atomic v1.9.0 - golang.org/x/net v0.38.0 + golang.o...
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
601
issue_to_patch
Bump github.com/docker/docker from 28.0.4+incompatible to 28.1.1+incompatible
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 28.0.4+incompatible to 28.1.1+incompatible. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/docker/docker/releases">github.com/docker/docker's releases</a>.</em></p> <blockquote> <h2>v28.1.1</h2> <h2>28.1....
788fcd383407818ab64ef53a70bda0bec695de8e
750a2550c24b9f53c33ae62bf4a507929da63a4a
diff --git a/go.mod b/go.mod index 79f8fb99..cb70c857 100644 --- a/go.mod +++ b/go.mod @@ -10,7 +10,7 @@ require ( github.com/cespare/xxhash/v2 v2.3.0 github.com/charmbracelet/lipgloss v1.1.0 github.com/docker/cli v28.0.4+incompatible - github.com/docker/docker v28.0.4+incompatible + github.com/docker/docker v28....
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
587
issue_to_patch
chore: refactor command structure
This PR aims to make no functional changes. Instead this is a quality-of-life change to make it easier to work with the CLI options and decoupling a lot of the just-in-time config parsing mixed in with the business logic (in CI rule and ui packages). Now all of the config/viper configuration parsing lives purely under ...
5fc8c99e29042289e4f07ae1f15cf726a8885e27
c4f57f1d5cb4e3ad996b44b9fbffe10aeeaa1fd0
diff --git a/.dockerignore b/.dockerignore index 1021b60a..37212b5f 100644 --- a/.dockerignore +++ b/.dockerignore @@ -4,7 +4,7 @@ /dist !/dist/dive_linux_amd64 /ui -/utils +/internal/utils /image /cmd /build diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml index 8174581a..d7d5066f 100...
[ ".dockerignore", ".github/workflows/release.yaml", ".gitignore", ".goreleaser.yaml", "Taskfile.yaml", "cmd/analyze.go", "cmd/build.go", "cmd/ci.go", "cmd/dive/cli/cli.go", "cmd/dive/cli/cli_build_test.go", "cmd/dive/cli/cli_ci_test.go", "cmd/dive/cli/cli_config_test.go", "cmd/dive/cli/cli_js...
[]
diff --git a/cmd/dive/cli/cli_build_test.go b/cmd/dive/cli/cli_build_test.go new file mode 100644 index 00000000..feabe911 --- /dev/null +++ b/cmd/dive/cli/cli_build_test.go @@ -0,0 +1,91 @@ +package cli + +import ( + "github.com/stretchr/testify/assert" + "github.com/stretchr/testify/require" + "regexp" + "testing" +)...
true
wagoodman/dive
593
issue_to_patch
Fix error message returned from getFileList
The PR fixes typo in error messages.
5fc8c99e29042289e4f07ae1f15cf726a8885e27
7fa2181a5b3d3eb181298dd36091918493934318
diff --git a/dive/image/docker/image_archive.go b/dive/image/docker/image_archive.go index f2c018bf..4abdb2ca 100644 --- a/dive/image/docker/image_archive.go +++ b/dive/image/docker/image_archive.go @@ -237,9 +237,9 @@ func getFileList(tarReader *tar.Reader) ([]filetree.FileInfo, error) { switch header.Typeflag { ...
[ "dive/image/docker/image_archive.go" ]
[]
true
wagoodman/dive
594
issue_to_patch
Reference homebrew core over tap in documentation
With the merge of #213, the package was added to Homebrew core, and the README was updated accordingly to remove the manual tap. However, with the merge of #570, the README reverted to recommending the tap instead of the core package. I couldn't find any reason for this change, and I personally try to avoid unnecess...
5fc8c99e29042289e4f07ae1f15cf726a8885e27
2d365dbe062cd5328318c06c82bf606e75805c3a
diff --git a/README.md b/README.md index 829127b6..a97bdf42 100644 --- a/README.md +++ b/README.md @@ -136,8 +136,7 @@ pacman -S dive If you use [Homebrew](https://brew.sh): ```bash -brew tap wagoodman/dive -brew install wagoodman/dive/dive +brew install dive ``` If you use [MacPorts](https://www.macports.org):...
[ "README.md" ]
[]
true
wagoodman/dive
588
issue_to_patch
Add support for Containerfile in `build` command **What happened**: ``` $ dive build my-folder -t my-img:v0.1 Building image... [+] Building 0.1s (1/1) FINISHED docker:desktop-linux => [i...
Add Containerfile support for dive build command (#536)
This commit adds `Containerfile` discovery for `dive build` command for docker engine. By default, docker uses `Dockerfile` and will fail if the build context contains `Containerfile` instead. This commit fixes it. This fixes #536 .
77e136d1ec218d7add9e4583a682c233f7551c82
28ef20041cd49bb85846fbfc2fc00ab1b29f8485
diff --git a/dive/image/docker/build.go b/dive/image/docker/build.go index 935029f2..09119899 100644 --- a/dive/image/docker/build.go +++ b/dive/image/docker/build.go @@ -1,27 +1,84 @@ package docker import ( - "os" + "fmt" + "path/filepath" + "strings" + + "github.com/scylladb/go-set/strset" + "github.com/spf13/af...
[ "dive/image/docker/build.go", "dive/image/docker/build_test.go", "dive/image/docker/engine_resolver.go", "go.mod", "go.sum" ]
[]
diff --git a/dive/image/docker/build_test.go b/dive/image/docker/build_test.go new file mode 100644 index 00000000..64081e42 --- /dev/null +++ b/dive/image/docker/build_test.go @@ -0,0 +1,231 @@ +package docker + +import ( + "github.com/stretchr/testify/require" + "path/filepath" + "testing" + + "github.com/spf13/afero...
true
wagoodman/dive
591
issue_to_patch
Bump golang.org/x/net from 0.37.0 to 0.38.0
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.37.0 to 0.38.0. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golang/net/commit/e1fcd82abba34df74614020343be8eb1fe85f0d9"><code>e1fcd82</code></a> html: properly handle trailing solidus in unquoted attribute value in foreign...</...
0dcb2fc776e4fba707741d1b346ac4c038bf86b9
5952b00c7eaed16f679327b0a16509933e7a14b9
diff --git a/go.mod b/go.mod index fa511ca0..8ff5a32a 100644 --- a/go.mod +++ b/go.mod @@ -21,7 +21,7 @@ require ( github.com/spf13/afero v1.14.0 github.com/spf13/cobra v1.9.1 github.com/spf13/viper v1.20.1 - golang.org/x/net v0.37.0 + golang.org/x/net v0.38.0 ) require ( diff --git a/go.sum b/go.sum index c4...
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
589
issue_to_patch
Bump github.com/docker/cli from 28.0.2+incompatible to 28.0.4+incompatible
Bumps [github.com/docker/cli](https://github.com/docker/cli) from 28.0.2+incompatible to 28.0.4+incompatible. <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/docker/cli/commit/b8034c0ed70494a90c133461d145cd072d920d7c"><code>b8034c0</code></a> Merge pull request <a href="https://redirect.github...
b6b3668b06ea318d7131fbdbc72486485ad44f92
1f873b2e21e5099a06847ff8f381125854fb93a0
diff --git a/go.mod b/go.mod index 9a2b8a0b..ed6f8868 100644 --- a/go.mod +++ b/go.mod @@ -6,7 +6,7 @@ require ( github.com/awesome-gocui/gocui v1.1.0 github.com/awesome-gocui/keybinding v1.0.1-0.20211011072933-86029037a63f github.com/cespare/xxhash/v2 v2.3.0 - github.com/docker/cli v28.0.2+incompatible + github....
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
590
issue_to_patch
Bump github.com/spf13/viper from 1.20.0 to 1.20.1
Bumps [github.com/spf13/viper](https://github.com/spf13/viper) from 1.20.0 to 1.20.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/spf13/viper/releases">github.com/spf13/viper's releases</a>.</em></p> <blockquote> <h2>v1.20.1</h2> <!-- raw HTML omitted --> <h2>What's Change...
b6b3668b06ea318d7131fbdbc72486485ad44f92
922e2369beb4d2b6f78246636fcab9f65ddf7097
diff --git a/go.mod b/go.mod index 9a2b8a0b..4a63699e 100644 --- a/go.mod +++ b/go.mod @@ -20,7 +20,7 @@ require ( github.com/sirupsen/logrus v1.9.3 github.com/spf13/afero v1.14.0 github.com/spf13/cobra v1.9.1 - github.com/spf13/viper v1.20.0 + github.com/spf13/viper v1.20.1 golang.org/x/net v0.37.0 ) diff -...
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
550
issue_to_patch
README.md: Add x-cmd method to install dive
- Hi, we have implemented a lightweight [package manager using shell and awk](https://www.x-cmd.com/pkg/). It helps you download dive release packages from the internet and extract them into a unified directory for management, without requiring root permissions. - **I mean, can the installation method provided by x-...
925cdd86482edec42185794620a1e616b79bbee5
8b097c5a9539b3a5a308746cd9363ec01f424596
diff --git a/README.md b/README.md index e245925b..6699a396 100644 --- a/README.md +++ b/README.md @@ -164,6 +164,13 @@ On non-NixOS (Linux, Mac) nix-env -iA nixpkgs.dive ``` +**X-CMD** + +[x-cmd](https://www.x-cmd.com/) is a **toolbox for Posix Shell**, offering a lightweight package manager built using shell and ...
[ "README.md" ]
[]
true
wagoodman/dive
579
issue_to_patch
Bump github.com/docker/docker from 28.0.1+incompatible to 28.0.2+incompatible
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 28.0.1+incompatible to 28.0.2+incompatible. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/docker/docker/releases">github.com/docker/docker's releases</a>.</em></p> <blockquote> <h2>v28.0.2</h2> <h2>28.0....
cc7c01e918b49d4d2362073d86d1050dbb768288
9ff22576c531c1b2cfb45f373d25670e37673ed9
diff --git a/go.mod b/go.mod index ecb2cff0..9a2b8a0b 100644 --- a/go.mod +++ b/go.mod @@ -7,7 +7,7 @@ require ( github.com/awesome-gocui/keybinding v1.0.1-0.20211011072933-86029037a63f github.com/cespare/xxhash/v2 v2.3.0 github.com/docker/cli v28.0.2+incompatible - github.com/docker/docker v28.0.1+incompatible +...
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
565
issue_to_patch
Update README.md with DOCKER_HOST env var instructions
I had an error pulling local images. Setting the DOCKER_HOST env var fixed this problem for me. This has has been mentioned in issues such as https://github.com/wagoodman/dive/issues/542#issuecomment-2267720375 Related to #542
925cdd86482edec42185794620a1e616b79bbee5
d340b5bc7bfbdc6a8d650eed3e8980cc5036d399
diff --git a/README.md b/README.md index e245925b..5da98328 100644 --- a/README.md +++ b/README.md @@ -200,6 +200,10 @@ docker run --rm -it \ -e DOCKER_API_VERSION=1.37 \ wagoodman/dive:latest <dive arguments...> ``` +if you are using an alternative runtime (Colima etc) then you may need to specify the docke...
[ "README.md" ]
[]
true
wagoodman/dive
570
issue_to_patch
More keys to control I would like to propose more keys to control dive `j` to down `k` to up `h` and `l` to switch view `/` to start Filter files `esc` to stop Filter files for now and those are all inspired by vim keybindings does not work with colima engine I built the same image on colima and docker des...
Reintegrate fork joschi/dive
All commits from https://github.com/wagoodman/dive/compare/main...joschi:dive:main with some changes reverted: - Reverted back to module name github.com/wagoodman/dive - Removed Renovate configuration Refs #568 Integrates the following PRs: - #551 @pooja0805 - #511 @Maddog2050 - #531 @kianmeng - #470 @Ok...
925cdd86482edec42185794620a1e616b79bbee5
b742aa052cf86fb666f1e311b93e6ba99caf174d
diff --git a/.bouncer.yaml b/.bouncer.yaml index 9ee31212..659945a4 100644 --- a/.bouncer.yaml +++ b/.bouncer.yaml @@ -5,6 +5,7 @@ permit: - MPL.* - ISC - WTFPL + - Unlicense ignore-packages: # crypto/internal/boring is released under the openSSL license as a part of the Golang Standard Library diff --g...
[ ".bouncer.yaml", ".data/Dockerfile.minimal", ".data/test-estargz-image.tar", ".data/test-gzip-image.tar", ".data/test-oci-estargz-image.tar", ".data/test-oci-gzip-image.tar", ".data/test-oci-uncompressed-image.tar", ".data/test-oci-zstd-image.tar", ".data/test-uncompressed-image.tar", ".data/test-...
[]
diff --git a/dive/filetree/efficiency_test.go b/dive/filetree/efficiency_test.go index 831ceb57..1662efad 100644 --- a/dive/filetree/efficiency_test.go +++ b/dive/filetree/efficiency_test.go @@ -10,7 +10,7 @@ func checkError(t *testing.T, err error, message string) { } } -func TestEfficency(t *testing.T) { +func T...
true
wagoodman/dive
500
issue_to_patch
Unable to analyze the image using dive **What happened**: I am using RHEL9 free tier from AWS and installed the dive with below steps by referring the github page https://github.com/wagoodman/dive and the version is dive 0.11.0 i have downloaded the Docker image "nginx:latest" by using "docker pull nginx" command ...
Fix compatibility with Docker 25+
Add support for OCI-compatible Docker images. Fixes #498
3ef1dd2c74c6952064d866adc2b225048d939f83
39b2e60d48d0a81ececb49a6966d4cf23f2c7107
diff --git a/.data/test-oci-docker-image.tar b/.data/test-oci-docker-image.tar new file mode 100644 index 00000000..d8ea90de Binary files /dev/null and b/.data/test-oci-docker-image.tar differ diff --git a/dive/image/docker/image_archive.go b/dive/image/docker/image_archive.go index 3a818737..827b58ba 100644 --- a/dive...
[ ".data/test-oci-docker-image.tar", "dive/image/docker/image_archive.go" ]
[ { "comment": "I have a counter-example that's breaking this assumption, here's the layer from an image manifest that I've provided as a repro in #507 \r\n\r\n```jsonc\r\n{\r\n \"schemaVersion\": 2,\r\n \"mediaType\": \"application/vnd.oci.image.manifest.v1+json\",\r\n \"config\" { ... },\r\n \"layers\": [\r...
true
wagoodman/dive
503
issue_to_patch
fix(sec): upgrade golang.org/x/net to 0.17.0
### What happened? There are 1 security vulnerabilities found in golang.org/x/net v0.11.0 - [CVE-2023-39325](https://www.oscs1024.com/hd/CVE-2023-39325) ### What did I do? Upgrade golang.org/x/net from v0.11.0 to 0.17.0 for vulnerability fix ### What did you expect to happen? Ideally, no insecure libs should be used...
3ef1dd2c74c6952064d866adc2b225048d939f83
e66d2d957bcb9861f724c78c36a5e70eeefbee04
diff --git a/go.mod b/go.mod index aeac34ed..8f7bec9b 100644 --- a/go.mod +++ b/go.mod @@ -20,7 +20,7 @@ require ( github.com/spf13/afero v1.2.2 github.com/spf13/cobra v0.0.5 github.com/spf13/viper v1.4.0 - golang.org/x/net v0.11.0 + golang.org/x/net v0.17.0 ) require ( @@ -52,9 +52,9 @@ require ( github.co...
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
483
issue_to_patch
Bump github.com/docker/docker from 24.0.2+incompatible to 24.0.7+incompatible
Bumps [github.com/docker/docker](https://github.com/docker/docker) from 24.0.2+incompatible to 24.0.7+incompatible. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/docker/docker/releases">github.com/docker/docker's releases</a>.</em></p> <blockquote> <h2>v24.0.7</h2> <h2>24.0....
3ef1dd2c74c6952064d866adc2b225048d939f83
aa11ba4d5d35c75a161c3171810abd6e3542a583
diff --git a/go.mod b/go.mod index aeac34ed..82ab1b18 100644 --- a/go.mod +++ b/go.mod @@ -7,7 +7,7 @@ require ( github.com/awesome-gocui/keybinding v1.0.1-0.20190805183143-864552bd36b7 github.com/cespare/xxhash v1.1.0 github.com/docker/cli v0.0.0-20190906153656-016a3232168d - github.com/docker/docker v24.0.2+inc...
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
492
issue_to_patch
DIVE_VERSION does not need to be exported
The value of the variable DIVE_VERSION is not needed in a spawned subprocess. Thus, the variable does not necessarily need to be exported. Arguably, the environment is less polluted if it is not exported.
3ef1dd2c74c6952064d866adc2b225048d939f83
d59f2a5b5c37a4631cee797fc4ea79be5255f91e
diff --git a/README.md b/README.md index fd636be0..a334a2f7 100644 --- a/README.md +++ b/README.md @@ -95,14 +95,14 @@ With valid `source` options as such: **Ubuntu/Debian** ```bash -export DIVE_VERSION=$(curl -sL "https://api.github.com/repos/wagoodman/dive/releases/latest" | grep '"tag_name":' | sed -E 's/.*"v([^...
[ "README.md" ]
[]
true
wagoodman/dive
484
issue_to_patch
docs: Adds instructions for snap installation
## Description This PR adds instructions for installing the dive snap. ## Reference - https://snapcraft.io/dive - https://github.com/gruyaume/dive-snap
3ef1dd2c74c6952064d866adc2b225048d939f83
8ffbbce8bdb5dd63679eb7b9d7f7580e0a086e63
diff --git a/README.md b/README.md index fd636be0..19362a9f 100644 --- a/README.md +++ b/README.md @@ -94,12 +94,22 @@ With valid `source` options as such: ## Installation **Ubuntu/Debian** + +Using debs: ```bash export DIVE_VERSION=$(curl -sL "https://api.github.com/repos/wagoodman/dive/releases/latest" | grep '...
[ "README.md" ]
[]
true
wagoodman/dive
424
issue_to_patch
feat: add support for alternative ordering strategies
Addresses https://github.com/wagoodman/dive/issues/341. Adds a default hotkey of `ctrl+o` to flip between A-Z sort order and numerical sort-by-size-desc on the right-side pane. The approach to implementing this feature was to find all of the places in code that enforce the *order* in which file-system nodes in th...
d5e8a9296882f113e3990daca5e6b16109f512b8
512868478f0df8a54bd20b4a4c04177f2efff259
diff --git a/cmd/root.go b/cmd/root.go index 27412d96..5074bbeb 100644 --- a/cmd/root.go +++ b/cmd/root.go @@ -86,6 +86,7 @@ func initConfig() { // keybindings: filetree view viper.SetDefault("keybinding.toggle-collapse-dir", "space") viper.SetDefault("keybinding.toggle-collapse-all-dir", "ctrl+space") + viper.Se...
[ "cmd/root.go", "dive/filetree/efficiency.go", "dive/filetree/file_node.go", "dive/filetree/file_tree.go", "dive/filetree/order_strategy.go", "runtime/ui/view/filetree.go", "runtime/ui/viewmodel/filetree.go", "runtime/ui/viewmodel/filetree_test.go" ]
[]
diff --git a/runtime/ui/viewmodel/filetree_test.go b/runtime/ui/viewmodel/filetree_test.go index 668eb1e6..f315b417 100644 --- a/runtime/ui/viewmodel/filetree_test.go +++ b/runtime/ui/viewmodel/filetree_test.go @@ -73,7 +73,7 @@ func assertTestData(t *testing.T, actualBytes []byte) { helperCheckDiff(t, expectedBytes,...
true
wagoodman/dive
390
issue_to_patch
dive with podman on MacOS I'm trying to use dive with podman on MacOS. ``` $ dive version dive 0.10.0 ``` I'm using a local build of podman, since there was a bug fixed upstream that hasn't been released yet: ``` $ podman version Client: Version: 4.0.0-dev API Version: 4.0.0-dev Go Version: go1.16.2...
Support podman in macOS
With [a fix][1] in [podman v3.4.3][2], these commands now work as expected in macOS. Potentially, it might make sense to version check podman to ensure that the minimum version is met, but I'm not sure that's needed because it's unlikely that people have an older version installed _and_ wish to use this tool. I'm un...
c7d121b3d72aeaded26d5731819afaf49b686df6
7dfef036c75c6f85d0a2fd56adb3f36decb90505
diff --git a/dive/image/podman/build.go b/dive/image/podman/build.go index bfebc492..617f1468 100644 --- a/dive/image/podman/build.go +++ b/dive/image/podman/build.go @@ -1,4 +1,4 @@ -// +build linux +// +build linux darwin package podman diff --git a/dive/image/podman/cli.go b/dive/image/podman/cli.go index 83523...
[ "dive/image/podman/build.go", "dive/image/podman/cli.go", "dive/image/podman/resolver.go", "dive/image/podman/resolver_unsupported.go" ]
[]
true
wagoodman/dive
461
issue_to_patch
Bump to more recent go version, remove no longer required overrides
This fixes the following error when building in nixpkgs ``` dive> vendor/golang.org/x/sys/unix/syscall.go:83:16: unsafe.Slice requires go1.17 or later (-lang was set to go1.16; check go.mod) dive> vendor/golang.org/x/sys/unix/syscall_linux.go:1018:20: unsafe.Slice requires go1.17 or later (-lang was set to go1.16;...
559e5e2dbe84a9a9df3bd5a2dbe9a01c9c11d9a6
555555d777f961ad0a2d1bb843e87f434d731dba
diff --git a/go.mod b/go.mod index 22ae94dc..aeac34ed 100644 --- a/go.mod +++ b/go.mod @@ -1,62 +1,61 @@ module github.com/wagoodman/dive -go 1.13 +go 1.19 require ( - github.com/Microsoft/go-winio v0.4.14 // indirect github.com/awesome-gocui/gocui v1.1.0 github.com/awesome-gocui/keybinding v1.0.1-0.201908051...
[ "go.mod", "go.sum" ]
[]
true
wagoodman/dive
399
issue_to_patch
Allow for vertical and horizontal scrolling on all views This relates to #176, but additionally should allow scrolling in the detail view. If there is conflict with keybindings, then the view should detect overflow and scroll on arrow keys... when there is no longer any overflow, then the original keybinding for the v...
GUI rework
This should make `dive` much more user friendly, in the sense that all the information is now available, irregardless of the number of layers, or the length of a certain command. The `Layer Details` and `Image Details` panes are now selectable with the arrow keys (left and right) and can be scrolled with the arrow k...
c7d121b3d72aeaded26d5731819afaf49b686df6
2aad87c37e76d7e6e9d76dafa9eda20801b0c1fb
diff --git a/dive/image/layer.go b/dive/image/layer.go index 550eba18..ac963639 100644 --- a/dive/image/layer.go +++ b/dive/image/layer.go @@ -2,6 +2,8 @@ package image import ( "fmt" + "strings" + "github.com/dustin/go-humanize" "github.com/wagoodman/dive/dive/filetree" ) @@ -39,5 +41,5 @@ func (l *Layer) St...
[ "dive/image/layer.go", "runtime/ui/app.go", "runtime/ui/controller.go", "runtime/ui/layout/compound/layer_details_column.go", "runtime/ui/view/details.go", "runtime/ui/view/filetree.go", "runtime/ui/view/filter.go", "runtime/ui/view/image_details.go", "runtime/ui/view/layer.go", "runtime/ui/view/l...
[ { "comment": "Consider using the solution from https://github.com/wagoodman/dive/pull/443 instead - replace newlines with the ↵ character but still show the whole command, in case the first line isn't very informative.\r\n\r\n(Also, FYI, `strings.Split(...)[0]` is equivalent to `strings.Cut`)", "path": "div...
true
wagoodman/dive
348
issue_to_patch
Add Nix/NixOS package installation instructions
Just added NixOS and nix (cross-platform linux/mac) installation instructions in the README
64880972b0726ec2ff2b005b0cc97801067c1bb5
b5b377444ebc02214d83b7f59ccdc5023ffd2f55
diff --git a/README.md b/README.md index d625df5b..71717a30 100644 --- a/README.md +++ b/README.md @@ -131,6 +131,17 @@ go get github.com/wagoodman/dive ``` *Note*: installing in this way you will not see a proper version when running `dive -v`. +**Nix/NixOS** + +On NixOS: +```bash +nix-env -iA nixos.dive +``` +On ...
[ "README.md" ]
[]
true
wagoodman/dive
401
issue_to_patch
Allow for autodetecting both `.yaml` and `.yml` config files
c7d121b3d72aeaded26d5731819afaf49b686df6
4fad38207edc78f0fa2a2799b20db2be25c589fc
diff --git a/README.md b/README.md index 941be823..15c45fe0 100644 --- a/README.md +++ b/README.md @@ -275,3 +275,5 @@ dive will search for configs in the following locations: - `$XDG_CONFIG_DIRS/dive/*.yaml` - `~/.config/dive/*.yaml` - `~/.dive.yaml` + +`.yml` can be used instead of `.yaml` if desired. diff --git a...
[ "README.md", "cmd/root.go" ]
[]
true
wagoodman/dive
460
issue_to_patch
Rework CI validation workflow and makefile
Port from circle CI to github actions validation pipeline. Adds initial release workflow, however, it is functionally disabled until it can be properly tested.
8a10c0d46b7482124f310ac54ad39443b3fb70f1
6ec22ae373ac9c3608bb17ec3a9a25b9179428fd
diff --git a/.bouncer.yaml b/.bouncer.yaml new file mode 100644 index 00000000..9ee31212 --- /dev/null +++ b/.bouncer.yaml @@ -0,0 +1,12 @@ +permit: + - BSD.* + - MIT.* + - Apache.* + - MPL.* + - ISC + - WTFPL + +ignore-packages: + # crypto/internal/boring is released under the openSSL license as a part of the G...
[ ".bouncer.yaml", ".circleci/config.yml", ".github/FUNDING.yml", ".github/ISSUE_TEMPLATE/bug_report.md", ".github/ISSUE_TEMPLATE/feature_request.md", ".github/actions/bootstrap/action.yaml", ".github/scripts/ci-check.sh", ".github/scripts/coverage.py", ".github/scripts/go-mod-tidy-check.sh", ".gith...
[]
diff --git a/runtime/ci/evaluator_test.go b/runtime/ci/evaluator_test.go index d929452d..c513adf6 100644 --- a/runtime/ci/evaluator_test.go +++ b/runtime/ci/evaluator_test.go @@ -1,11 +1,12 @@ package ci import ( - "github.com/wagoodman/dive/dive/image/docker" "strings" "testing" "github.com/spf13/viper" + ...
true
wagoodman/dive
443
issue_to_patch
Fix rendering for multi-line commands
Heredocs can be used to create multi-line commands, which broke rendering. Details about heredocs: https://www.docker.com/blog/introduction-to-heredocs-in-dockerfiles/ Before: ![image](https://user-images.githubusercontent.com/8140/232047088-f049ecee-addf-42e6-a3d0-bbeb1cb05dca.png) After: ![image](http...
67aa2f1bf8fd1049500904fef907f3fd99dcbf4b
ceb9688d9289e185b925f8e7447f5dd2a326fd29
diff --git a/dive/image/layer.go b/dive/image/layer.go index ac963639..8c7fa6a3 100644 --- a/dive/image/layer.go +++ b/dive/image/layer.go @@ -33,6 +33,12 @@ func (l *Layer) ShortId() string { return id } +func (l *Layer) commandPreview() string { + // Layers using heredocs can be multiple lines; rendering relies ...
[ "dive/image/layer.go" ]
[]
true
wagoodman/dive
349
issue_to_patch
Fix stream podman command hanging
I found that using an image that is not in podman locally would hang dive. It seems like this writer not being closed on the streamPodmanCmd function was the culprit. To test this issue, fist make sure ubuntu is not in podman and then the outputs should be: Before: ``` $ dive podman://docker.io/library/ubuntu Im...
64880972b0726ec2ff2b005b0cc97801067c1bb5
4d5b2824eed20f5c22c33b8cd2a702700b79ce3b
diff --git a/dive/image/podman/cli.go b/dive/image/podman/cli.go index 83523afc..56e17449 100644 --- a/dive/image/podman/cli.go +++ b/dive/image/podman/cli.go @@ -40,6 +40,7 @@ func streamPodmanCmd(args ...string) (error, io.Reader) { if err != nil { return err, nil } + defer writer.Close() cmd.Stdout = writ...
[ "dive/image/podman/cli.go" ]
[]
true
wagoodman/dive
459
issue_to_patch
Update the link for the Arch Linux package
README.md was updated in #428 but the package link was outdated due to the merge of the repositories.
8a10c0d46b7482124f310ac54ad39443b3fb70f1
ec5528bce5e428b2094a594da6fe39ec3fc04393
diff --git a/README.md b/README.md index b50c5a02..30275000 100644 --- a/README.md +++ b/README.md @@ -107,7 +107,7 @@ rpm -i dive_0.9.2_linux_amd64.rpm **Arch Linux** -Available in the [community repository](https://archlinux.org/packages/community/x86_64/dive/) and can be installed via [pacman](https://wiki.arch...
[ "README.md" ]
[]
true
wagoodman/dive
354
issue_to_patch
Quit on `q` I tried to add this, but it fails with the error. ``` Building cache... could not parse keybinding ' q' from request 'ctrl+c, q': unsupported keybinding: KeyQ ``` ```diff diff --git a/cmd/root.go b/cmd/root.go index 03086b1..6a6a278 100644 --- a/cmd/root.go +++ b/cmd/root.go @@ -77,7 +77,7 @@ f...
Fix #352. Quit on `q`
This uses latest `github.com/awesome-gocui/keybinding`. Fixes #352.
2a99dd25fe6490a3918221d5f084e71a6349ad5f
f17140f8ce2da67735a68c609d88f0ae78477baa
diff --git a/README.md b/README.md index 15c45fe0..25c1e165 100644 --- a/README.md +++ b/README.md @@ -193,7 +193,7 @@ You can override the CI config path with the `--ci-config` option. Key Binding | Description -------------------------------------------|-----------------------------...
[ "README.md", "cmd/root.go", "go.mod", "go.sum" ]
[]
true
wagoodman/dive
457
issue_to_patch
Fix CI
* Catch pipefail errors in Makefile https://stackoverflow.com/questions/33925523/how-to-set-pipefail-in-a-makefile * Update failing CI tools install scripts * Update failing release configuration
361037f2728f6f1b0282a01311976c176a933a5b
dfe9a8c5c96685259cc0fa0e2963c26434660b75
diff --git a/.goreleaser.yml b/.goreleaser.yml index a76f7581..b83bbef9 100644 --- a/.goreleaser.yml +++ b/.goreleaser.yml @@ -14,7 +14,7 @@ builds: ldflags: -s -w -X main.version={{.Version}} -X main.commit={{.Commit}} -X main.buildTime={{.Date}}`. brews: - - github: + - repository: owner: wagoodman ...
[ ".goreleaser.yml", "Makefile" ]
[]
true
wagoodman/dive
403
issue_to_patch
ubuntu install latest version script
a70b7acffcd7cbd49701db97f3f45c66d94de3ce
6ba95122a52f65ae11aa897e8bf418b619a36fb6
diff --git a/README.md b/README.md index 17a272c9..b50c5a02 100644 --- a/README.md +++ b/README.md @@ -93,13 +93,15 @@ With valid `source` options as such: **Ubuntu/Debian** ```bash -curl -OL https://github.com/wagoodman/dive/releases/download/v0.9.2/dive_0.9.2_linux_amd64.deb -sudo apt install ./dive_0.9.2_linux_a...
[ "README.md" ]
[]
true
wagoodman/dive
447
issue_to_patch
Support Ctrl-Z for job control. It looks to me like pressing <kbd>Ctrl-Z</kbd> does nothing, when in fact that should pause the process. Would it be possible to have that going to the shell instead of capturing all keypresses? The same issue is with <kbd>Ctrl-L</kbd> which should ideally refresh the screen (why's that...
Feat: add ctrl-z support
implement feat-req https://github.com/wagoodman/dive/issues/297 Changes: - update gocui to v1.1.0 // in order to suspend/resume - fix layer cursor move // adapt for gocui v1.x - add `ctrl+z` support only tested on ubuntu22, build with go1.18
32c1c1b7bfe81280cd5879fed080404dc7c37e8e
e9169b9ccdad03b5b9d0617eaa5ac222992afc49
diff --git a/go.mod b/go.mod index 14c1fe5b..22ae94dc 100644 --- a/go.mod +++ b/go.mod @@ -4,7 +4,7 @@ go 1.13 require ( github.com/Microsoft/go-winio v0.4.14 // indirect - github.com/awesome-gocui/gocui v0.6.0 + github.com/awesome-gocui/gocui v1.1.0 github.com/awesome-gocui/keybinding v1.0.1-0.20190805183143-86...
[ "go.mod", "go.sum", "runtime/ui/app.go", "runtime/ui/view/layer.go" ]
[]
true
wagoodman/dive
429
issue_to_patch
Updated the deprecated ioutil dependency
The ioutil package has been deprecated as of Go v1.16: https://go.dev/doc/go1.16#ioutil This commit replaces ioutil functions with their respective io/os functions.
bf39a82f2a8cd3225a0b68d7d1135a222a6b549d
ae996cd718aac37d87d3fef985627911752f474f
diff --git a/cmd/ci.go b/cmd/ci.go index 28a08679..07938f6f 100644 --- a/cmd/ci.go +++ b/cmd/ci.go @@ -3,7 +3,6 @@ package cmd import ( "bytes" "fmt" - "io/ioutil" "os" "strconv" @@ -21,7 +20,7 @@ func configureCi() (bool, *viper.Viper, error) { if _, err := os.Stat(ciConfigFile); !os.IsNotExist(err) { ...
[ "cmd/ci.go", "cmd/root.go", "dive/image/docker/build.go", "dive/image/docker/image_archive.go", "dive/image/podman/build.go", "dive/image/podman/resolver.go", "runtime/ui/viewmodel/filetree_test.go" ]
[]
diff --git a/runtime/ui/viewmodel/filetree_test.go b/runtime/ui/viewmodel/filetree_test.go index 4e1c0c07..cf321a0f 100644 --- a/runtime/ui/viewmodel/filetree_test.go +++ b/runtime/ui/viewmodel/filetree_test.go @@ -4,7 +4,6 @@ import ( "bytes" "github.com/wagoodman/dive/dive/image/docker" "github.com/wagoodman/di...
true
wagoodman/dive
428
issue_to_patch
Update README.md about installation on Arch Linux
`dive` is moved to the community repository: https://archlinux.org/packages/community/x86_64/dive/
bf39a82f2a8cd3225a0b68d7d1135a222a6b549d
25a226d51d75c6ad2c62f382c287a2046fb6ae35
diff --git a/README.md b/README.md index 15c45fe0..2fcea6f8 100644 --- a/README.md +++ b/README.md @@ -96,14 +96,12 @@ rpm -i dive_0.9.2_linux_amd64.rpm **Arch Linux** -Available as [dive](https://aur.archlinux.org/packages/dive/) in the Arch User Repository (AUR). +Available in the [community repository](https://...
[ "README.md" ]
[]
true
wagoodman/dive
400
issue_to_patch
Correct installation instruction for Ubuntu/Debian
The below command is written in README as an installation instruction for Ubuntu/Debian. ```sh wget https://github.com/wagoodman/dive/releases/download/v0.9.2/dive_0.9.2_linux_amd64.deb ``` This command creates a file whose name is not `dive_0.9.2_linux_amd64.deb` but `5db79280-4b50-11ea-8123-47efdc093285?X-Amz...
c7d121b3d72aeaded26d5731819afaf49b686df6
f359b8a9d72da45198589f76f68f3d3b271a93d8
diff --git a/README.md b/README.md index 941be823..cdd243c4 100644 --- a/README.md +++ b/README.md @@ -84,7 +84,7 @@ With valid `source` options as such: **Ubuntu/Debian** ```bash -wget https://github.com/wagoodman/dive/releases/download/v0.9.2/dive_0.9.2_linux_amd64.deb +curl -OL https://github.com/wagoodman/dive/...
[ "README.md" ]
[]
true
wagoodman/dive
344
issue_to_patch
improve README with new docker run command
So you don't need manually install `dive`, just run with `docker run` as alias
64880972b0726ec2ff2b005b0cc97801067c1bb5
b7d32324e6f1bcc10df6a9b94ea5866bd77de2b3
diff --git a/README.md b/README.md index d625df5b..612cbf6a 100644 --- a/README.md +++ b/README.md @@ -12,6 +12,15 @@ To analyze a Docker image simply run dive with an image tag/id/digest: dive <your-image-tag> ``` +or you can dive with docker command directly +``` +alias dive="docker run -ti --rm -v /var/run/dock...
[ "README.md" ]
[]
true
wagoodman/dive
395
issue_to_patch
Dive is crashing when browsing layers of paketobuildpacks/run:base-cnb image Using dive 0.10.0 How to repro issue: - pull paketobuildpacks/run:base-cnb image - dive <paketobuildpacks/run:base-cnb image id> - scroll down the layers, dive will end up crashing (see Golang crash dump below) ![image](https://use...
Fix error on Layer section and reduce information on one line per step.
When scrolling through commands in `Layers` section, in the case of multiline commands, the user could cause an index out of bounds error by scrolling to much. Here is an example: ![dive_wrong](https://user-images.githubusercontent.com/15312927/164769550-e6f91d4f-aa0c-475e-9750-03703abb5f1b.gif) and Dockerfile us...
c7d121b3d72aeaded26d5731819afaf49b686df6
4146421e604c8255a8eddc500066ed003da28600
diff --git a/dive/image/layer.go b/dive/image/layer.go index 550eba18..ac963639 100644 --- a/dive/image/layer.go +++ b/dive/image/layer.go @@ -2,6 +2,8 @@ package image import ( "fmt" + "strings" + "github.com/dustin/go-humanize" "github.com/wagoodman/dive/dive/filetree" ) @@ -39,5 +41,5 @@ func (l *Layer) St...
[ "dive/image/layer.go" ]
[]
true
wagoodman/dive
455
issue_to_patch
Bump module versions to resolve vulnerabilities
Before: ```console $ make clean build >/dev/null && grype -q ./dist/dive_linux_amd64/dive NAME INSTALLED FIXED-IN TYPE VULNERABILITY SEVERITY github.com/docker/distribution v2.7.0-rc.0.0.2...
c7d121b3d72aeaded26d5731819afaf49b686df6
1a22e8967651578fcbbd107120d0b4a375fd1eb1
diff --git a/.circleci/config.yml b/.circleci/config.yml index 06ad82ce..35375e81 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -7,7 +7,7 @@ jobs: type: string working_directory: /home/circleci/app docker: - - image: circleci/golang:<< parameters.version >> + - image: cimg...
[ ".circleci/config.yml", ".github/workflows/pipeline.yml", ".gitignore", "Makefile", "go.mod", "go.sum" ]
[]
true
wagoodman/dive
339
issue_to_patch
Document MacPorts install
Expanded installation documentation with how to install when using MacPorts.
b8d2d3d7250569d649b75907aa76b83f45fa9661
4457be08bc8c8d1ba759b2d4d4267ccaa5850272
diff --git a/README.md b/README.md index 9ef97580..d625df5b 100644 --- a/README.md +++ b/README.md @@ -105,11 +105,19 @@ The above example assumes [`yay`](https://aur.archlinux.org/packages/yay/) as th **Mac** +If you use [Homebrew](https://brew.sh): + ```bash brew install dive ``` -or download the latest Dar...
[ "README.md" ]
[]
true
wailsapp/wails
5,601
issue_to_patch
feat: Add experimental `wails3 setup` wizard
> **Replaces #4906** — the original branch was 498 commits behind master, making the diff unreadable. This PR is rebased on current master with all conflicts resolved and review comments addressed. ## Summary Adds an experimental interactive setup wizard (`wails3 setup`) that guides users through: - **Dependency che...
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/.github/workflows/build-cross-image.yml b/.github/workflows/build-cross-image.yml index d4d1d52f743..9ec25622288 100644 --- a/.github/workflows/build-cross-image.yml +++ b/.github/workflows/build-cross-image.yml @@ -30,6 +30,9 @@ on: paths: - 'v3/internal/commands/build_assets/docker/Dockerfile...
[ ".github/workflows/build-cross-image.yml", "docs/astro.config.mjs", "docs/public/d2/docs/DEVELOPER_GUIDE-0.svg", "docs/public/d2/docs/DEVELOPER_GUIDE-1.svg", "docs/src/components/MorphText.astro", "docs/src/content/docs/getting-started/installation.mdx", "docs/src/content/docs/getting-started/setup.mdx"...
[ { "comment": "`python3` is used to parse Zig's `index.json` (line 38), but it isn't installed in the apt-get layer. This will fail the cross-image build when `python3` is missing from the base image.", "path": "v3/internal/commands/build_assets/docker/Dockerfile.cross", "hunk": "@@ -27,12 +27,20 @@ RUN ...
diff --git a/v3/internal/commands/init_test.go b/v3/internal/commands/init_test.go index cb1b30d48f3..1ebf95abb6f 100644 --- a/v3/internal/commands/init_test.go +++ b/v3/internal/commands/init_test.go @@ -2,6 +2,10 @@ package commands import ( "testing" + "time" + + "github.com/wailsapp/wails/v3/internal/defaults"...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
`python3` is used to parse Zig's `index.json` (line 38), but it isn't installed in the apt-get layer. This will fail the cross-image build when `python3` is missing from the base image.
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/v3/internal/commands/build_assets/docker/Dockerfile.cross b/v3/internal/commands/build_assets/docker/Dockerfile.cross index 46c274f4d02..a9be99e0c13 100644 --- a/v3/internal/commands/build_assets/docker/Dockerfile.cross +++ b/v3/internal/commands/build_assets/docker/Dockerfile.cross @@ -20,19 +20,27 @@ ARG...
[ "v3/internal/commands/build_assets/docker/Dockerfile.cross" ]
[ { "comment": "`python3` is used to parse Zig's `index.json` (line 38), but it isn't installed in the apt-get layer. This will fail the cross-image build when `python3` is missing from the base image.", "path": "v3/internal/commands/build_assets/docker/Dockerfile.cross", "hunk": "@@ -27,12 +27,20 @@ RUN ...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
`omitempty` has no effect on non-pointer struct fields with `encoding/json`, so `signing` (and its nested `darwin/windows/linux`) will always be emitted in `wails3 doctor --json` even when no signing config exists. If signing is meant to be optional, consider making these fields pointers (and handling nils) so empty si...
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/v3/internal/defaults/defaults.go b/v3/internal/defaults/defaults.go index 69e99f3e624..53920b10dae 100644 --- a/v3/internal/defaults/defaults.go +++ b/v3/internal/defaults/defaults.go @@ -18,6 +18,9 @@ type GlobalDefaults struct { // Default project settings Project ProjectDefaults `json:"project" ya...
[ "v3/internal/defaults/defaults.go" ]
[ { "comment": "`omitempty` has no effect on non-pointer struct fields with `encoding/json`, so `signing` (and its nested `darwin/windows/linux`) will always be emitted in `wails3 doctor --json` even when no signing config exists. If signing is meant to be optional, consider making these fields pointers (and hand...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
Dependency output order is nondeterministic because `mapKeys` isn't sorted before iterating. This makes `wails3 doctor` output noisy/diff-unfriendly and inconsistent with other tables in this command that do sort keys.
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/v3/internal/doctor/doctor.go b/v3/internal/doctor/doctor.go index 88d7f4f7a30..d71e037b0f2 100644 --- a/v3/internal/doctor/doctor.go +++ b/v3/internal/doctor/doctor.go @@ -2,7 +2,9 @@ package doctor import ( "bytes" + "encoding/json" "fmt" + "os" "os/exec" "path/filepath" "regexp" @@ -24,52 +2...
[ "v3/internal/doctor/doctor.go" ]
[ { "comment": "Dependency output order is nondeterministic because `mapKeys` isn't sorted before iterating. This makes `wails3 doctor` output noisy/diff-unfriendly and inconsistent with other tables in this command that do sort keys.", "path": "v3/internal/doctor/doctor.go", "hunk": "@@ -83,173 +118,163 ...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
Signing rows are built by ranging over a map, so the table order will vary run-to-run. For stable CLI output, render in a fixed order (macOS, Windows, Linux) or sort the keys.
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/v3/internal/doctor/doctor.go b/v3/internal/doctor/doctor.go index 88d7f4f7a30..d71e037b0f2 100644 --- a/v3/internal/doctor/doctor.go +++ b/v3/internal/doctor/doctor.go @@ -2,7 +2,9 @@ package doctor import ( "bytes" + "encoding/json" "fmt" + "os" "os/exec" "path/filepath" "regexp" @@ -24,52 +2...
[ "v3/internal/doctor/doctor.go" ]
[ { "comment": "Signing rows are built by ranging over a map, so the table order will vary run-to-run. For stable CLI output, render in a fixed order (macOS, Windows, Linux) or sort the keys.", "path": "v3/internal/doctor/doctor.go", "hunk": "@@ -83,173 +118,163 @@ func Run() (err error) {\n \t\t}\n \t}\n...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
This sentence names a specific macOS SDK source repo, but the actual cross-image Dockerfile currently pulls the SDK from a different location. To avoid docs drifting from implementation, consider wording this more generically (or update docs + Dockerfile together).
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/docs/src/content/docs/guides/build/cross-platform.mdx b/docs/src/content/docs/guides/build/cross-platform.mdx index 0685834d460..7f640a9e235 100644 --- a/docs/src/content/docs/guides/build/cross-platform.mdx +++ b/docs/src/content/docs/guides/build/cross-platform.mdx @@ -179,19 +179,246 @@ You can check if...
[ "docs/src/content/docs/guides/build/cross-platform.mdx" ]
[ { "comment": "This sentence names a specific macOS SDK source repo, but the actual cross-image Dockerfile currently pulls the SDK from a different location. To avoid docs drifting from implementation, consider wording this more generically (or update docs + Dockerfile together).", "path": "docs/src/content/...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
`applyGlobalDefaults` currently overwrites `options.UseInterfaces` unconditionally, which makes `wails3 init --useinterfaces=false` ineffective (it will be replaced by the value from defaults). If the intent is that CLI flags can override defaults, this should only apply the default when the user didn't explicitly disa...
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/v3/internal/commands/init.go b/v3/internal/commands/init.go index f95dd9d3891..371ae537392 100644 --- a/v3/internal/commands/init.go +++ b/v3/internal/commands/init.go @@ -80,37 +80,40 @@ func initGitRepository(projectDir string, gitURL string) error { return nil } -// applyGlobalDefaults applies glob...
[ "v3/internal/commands/init.go" ]
[ { "comment": "`applyGlobalDefaults` currently overwrites `options.UseInterfaces` unconditionally, which makes `wails3 init --useinterfaces=false` ineffective (it will be replaced by the value from defaults). If the intent is that CLI flags can override defaults, this should only apply the default when the user ...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Narrow package write permission to the `build` job only.** `packages: write` at workflow scope over-grants token rights to jobs that don’t publish images. Keep workflow defaults read-only and grant write only where pushing happens. <details> <summary>🔐 Suggested l...
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/.github/workflows/build-cross-image.yml b/.github/workflows/build-cross-image.yml index d4d1d52f743..9ec25622288 100644 --- a/.github/workflows/build-cross-image.yml +++ b/.github/workflows/build-cross-image.yml @@ -30,6 +30,9 @@ on: paths: - 'v3/internal/commands/build_assets/docker/Dockerfile...
[ ".github/workflows/build-cross-image.yml" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Narrow package write permission to the `build` job only.**\n\n`packages: write` at workflow scope over-grants token rights to jobs that don’t publish images. Keep workflow defaults read-only and grant write only where pushing happens.\n\n<deta...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ **Fix internal docs links that use a `/docs` prefix.** Line 123 likely points to a non-existent route. Use root-relative docs paths instead. The same prefix issue also appears in `docs/src/content/docs/getting-started/setup.mdx` (Line 13). <details> <summary>Pro...
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/docs/src/content/docs/getting-started/installation.mdx b/docs/src/content/docs/getting-started/installation.mdx index 673058abc46..3221d58daad 100644 --- a/docs/src/content/docs/getting-started/installation.mdx +++ b/docs/src/content/docs/getting-started/installation.mdx @@ -5,7 +5,7 @@ sidebar: order: ...
[ "docs/src/content/docs/getting-started/installation.mdx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Fix internal docs links that use a `/docs` prefix.**\n\nLine 123 likely points to a non-existent route. Use root-relative docs paths instead. The same prefix issue also appears in `docs/src/content/docs/getting-started/setup.mdx` (Line 13).\n\...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ **Avoid hard-coding `14.5` in the “Use Your Own SDK” replacement block.** This snippet pins `MacOSX14.5` paths, so readers who follow the previous `MACOS_SDK_VERSION=15.0` example can hit a failing `mv` command. Add guidance to replace both `14.5` occurrences with the...
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/docs/src/content/docs/guides/build/cross-platform.mdx b/docs/src/content/docs/guides/build/cross-platform.mdx index 0685834d460..7f640a9e235 100644 --- a/docs/src/content/docs/guides/build/cross-platform.mdx +++ b/docs/src/content/docs/guides/build/cross-platform.mdx @@ -179,19 +179,246 @@ You can check if...
[ "docs/src/content/docs/guides/build/cross-platform.mdx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Avoid hard-coding `14.5` in the “Use Your Own SDK” replacement block.**\n\nThis snippet pins `MacOSX14.5` paths, so readers who follow the previous `MACOS_SDK_VERSION=15.0` example can hit a failing `mv` command. Add guidance to replace both `...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
_⚠️ Potential issue_ | _🔴 Critical_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash set -euo pipefail # Find bindings command definitions and flag wiring. rg -n -C4 --type=go '\bgenerate bindings\b|UseInterfaces|Typescript|BoolVar|"-i"|"-ts"' v3/cmd v3/internal # Locate the...
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/v3/internal/commands/build_assets/Taskfile.tmpl.yml b/v3/internal/commands/build_assets/Taskfile.tmpl.yml index fefa1e1b368..41cfbcec466 100644 --- a/v3/internal/commands/build_assets/Taskfile.tmpl.yml +++ b/v3/internal/commands/build_assets/Taskfile.tmpl.yml @@ -188,7 +188,7 @@ tasks: generates: ...
[ "v3/internal/commands/build_assets/Taskfile.tmpl.yml" ]
[ { "comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\nset -euo pipefail\n\n# Find bindings command definitions and flag wiring.\nrg -n -C4 --type=go '\\bgenerate bindings\\b|UseInterfaces|Typescript|BoolVar|\"-i\"|\...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **`handleSave` does not indicate success or failure to callers.** The function sets `saveError` state on failure but returns `void`. Callers like line 580 check `saveError` state after awaiting, but this reads stale state due to React's async state updates. <detai...
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/v3/internal/setupwizard/frontend/src/components/SigningStep.tsx b/v3/internal/setupwizard/frontend/src/components/SigningStep.tsx new file mode 100644 index 00000000000..6041fb3c369 --- /dev/null +++ b/v3/internal/setupwizard/frontend/src/components/SigningStep.tsx @@ -0,0 +1,829 @@ +import { useState, use...
[ "v3/internal/setupwizard/frontend/src/components/SigningStep.tsx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**`handleSave` does not indicate success or failure to callers.**\n\nThe function sets `saveError` state on failure but returns `void`. Callers like line 580 check `saveError` state after awaiting, but this reads stale state due to React's async...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **Password visible in process listing.** Passing the app-specific password as a command-line argument (`--password`, line 1313) exposes it to any user who can run `ps` on the system. Consider using stdin to pass the password instead. Note: `xcrun notarytool store-cre...
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/v3/internal/setupwizard/wizard.go b/v3/internal/setupwizard/wizard.go index dc72ab913a5..c774b8a3994 100644 --- a/v3/internal/setupwizard/wizard.go +++ b/v3/internal/setupwizard/wizard.go @@ -4,16 +4,20 @@ import ( "context" "embed" "encoding/json" + "errors" "fmt" + "io" "io/fs" "net" "net/h...
[ "v3/internal/setupwizard/wizard.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**Password visible in process listing.**\n\nPassing the app-specific password as a command-line argument (`--password`, line 1313) exposes it to any user who can run `ps` on the system. Consider using stdin to pass the password instead.\n\nNote:...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_ **`DisableColor()` no longer guarantees plain output for header/section.** `Header` (Line 21) and `Section` (Line 90) now inject lipgloss ANSI styling directly, so `DisableColor()` (Line 93-95) only affects `pterm` and can’t fully disable colorized output. <deta...
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/v3/internal/term/term.go b/v3/internal/term/term.go index 9127ff08aac..b2137cb9a11 100644 --- a/v3/internal/term/term.go +++ b/v3/internal/term/term.go @@ -4,6 +4,8 @@ import ( "fmt" "os" + "github.com/charmbracelet/lipgloss" + "github.com/muesli/termenv" "github.com/pterm/pterm" "github.com/wail...
[ "v3/internal/term/term.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_ | _⚡ Quick win_\n\n**`DisableColor()` no longer guarantees plain output for header/section.**\n\n`Header` (Line 21) and `Section` (Line 90) now inject lipgloss ANSI styling directly, so `DisableColor()` (Line 93-95) only affects `pterm` and can’t fully disable col...
true
wailsapp/wails
5,601
comment_to_fix
feat: Add experimental `wails3 setup` wizard
_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_ **Clarify the link text or target for the setup guide.** The link text says "manual setup guide" but points to `/getting-started/setup`, which documents the experimental setup wizard rather than manual installation steps. Users encountering issues with `wails3 setup` ...
0570da8cc9b25d20a86305c97862622ff5c2c399
38088937fa050e5dc5ac8afbab08889b33710c02
diff --git a/docs/src/content/docs/index.mdx b/docs/src/content/docs/index.mdx index 0199fe68da3..669149786e0 100644 --- a/docs/src/content/docs/index.mdx +++ b/docs/src/content/docs/index.mdx @@ -6,7 +6,7 @@ banner: Wails v3 is in ALPHA. <a href="https://wails.io">v2 docs</a> template: splash hero: - tagli...
[ "docs/src/content/docs/index.mdx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_ | _⚡ Quick win_\n\n**Clarify the link text or target for the setup guide.**\n\nThe link text says \"manual setup guide\" but points to `/getting-started/setup`, which documents the experimental setup wizard rather than manual installation steps. Users encountering...
true
wailsapp/wails
5,559
issue_to_patch
[v3] bug(windows): min size constraints are lost after dragging a maximized frameless window to restore ### Description On Windows, a frameless window with `MinWidth` and `MinHeight` set can lose its minimum size constraints after being restored from maximized state via native titlebar drag. This happens when all of...
fix(v3/windows): restore size constraints after drag-restoring frameless window
<!-- ********************************************************************* * PLEASE READ BEFORE SUBMITTING YOUR PR * * YOUR PR MAY BE REJECTED IF IT DOES NOT FOLLOW THESE STEPS * ********************************************************************* - *DO NOT* submit bugs for...
77e82c3f4f7b148986e2facffdcf99fe06a7a55c
c98ebca5c734e32980ede2aa65a260716f0a4771
diff --git a/v3/pkg/application/webview_window.go b/v3/pkg/application/webview_window.go index 9003e3cc77f..fb56c6b93f8 100644 --- a/v3/pkg/application/webview_window.go +++ b/v3/pkg/application/webview_window.go @@ -11,8 +11,8 @@ import ( "encoding/json" - "github.com/wailsapp/wails/v3/internal/optional" "gith...
[ "v3/pkg/application/webview_window.go", "v3/pkg/application/webview_window_test.go", "v3/pkg/application/webview_window_windows.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Search for accesses to constraint-related options fields to verify synchronization patterns\n\necho \"=== Direct modifications to options constraint fields ===...
diff --git a/v3/pkg/application/webview_window_test.go b/v3/pkg/application/webview_window_test.go index 8231046cd13..6557c50a917 100644 --- a/v3/pkg/application/webview_window_test.go +++ b/v3/pkg/application/webview_window_test.go @@ -136,3 +136,50 @@ func TestDisableSizeConstraintsDoesNotOverwriteSavedValues(t *test...
true
wailsapp/wails
5,559
comment_to_fix
fix(v3/windows): restore size constraints after drag-restoring frameless window
_⚠️ Potential issue_ | _🔴 Critical_ <details> <summary>🧩 Analysis chain</summary> 🏁 Script executed: ```shell #!/bin/bash # Search for accesses to constraint-related options fields to verify synchronization patterns echo "=== Direct modifications to options constraint fields ===" rg -n 'w\.options\.(Min|Max)(Wid...
77e82c3f4f7b148986e2facffdcf99fe06a7a55c
c98ebca5c734e32980ede2aa65a260716f0a4771
diff --git a/v3/pkg/application/webview_window.go b/v3/pkg/application/webview_window.go index 9003e3cc77f..fb56c6b93f8 100644 --- a/v3/pkg/application/webview_window.go +++ b/v3/pkg/application/webview_window.go @@ -11,8 +11,8 @@ import ( "encoding/json" - "github.com/wailsapp/wails/v3/internal/optional" "gith...
[ "v3/pkg/application/webview_window.go" ]
[ { "comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🏁 Script executed:\n\n```shell\n#!/bin/bash\n# Search for accesses to constraint-related options fields to verify synchronization patterns\n\necho \"=== Direct modifications to options constraint fields ===...
true
wailsapp/wails
5,597
issue_to_patch
fix(webview2): never treat a failed SetSize/PutBounds as fatal
## Description Follow-up to #5572 (which fixed the rasterization-scale drift) and #5453/#5568 (which made `Eval` and `Focus` non-fatal). `PutBounds` — called from `SetSize` → `ResizeWithBounds` during every WM_SIZE event — can return `RESOURCE_NOT_IN_CORRECT_STATE` while the WebView2 browser process is reconfiguring ...
7ff968732355d7c1ab74de55a9ccbcac5ef1987e
dcb3eb60b05fecfff67223970456095ab0b265d6
diff --git a/webview2/pkg/edge/chromium_386.go b/webview2/pkg/edge/chromium_386.go index e5093040d4f..3ff0fa23f0f 100644 --- a/webview2/pkg/edge/chromium_386.go +++ b/webview2/pkg/edge/chromium_386.go @@ -4,9 +4,11 @@ package edge import ( + "log" + "unsafe" + "github.com/wailsapp/wails/webview2/internal/w32" "...
[ "webview2/pkg/edge/chromium_386.go", "webview2/pkg/edge/chromium_amd64.go", "webview2/pkg/edge/chromium_arm64.go" ]
[]
true
wailsapp/wails
5,596
issue_to_patch
[v3] Unpainted white areas remain after window resize ### Description After starting the application, resizing the window leaves portions of the client area permanently white instead of displaying the configured background. ### To Reproduce Create a new Wails V3 app using: ```bash wails3 init -n WailsV3 ``` Add th...
fix(v3/windows): remove ResizeDebounceMS and fix resize background painting
## Summary Fixes #5594 — white areas appear after window resize on Windows. - **Remove `ResizeDebounceMS`** from `WindowsWindow` options. The debounce delayed WebView2 resizing for performance, but inherently left newly-exposed areas undrawn for the debounce period — a content gap no amount of mitigation can fully hi...
2d5cd758824b75683bf63b50eb58a81db2d4e16a
c4139b55e86245e475c16dd3646b25a36dc027b4
diff --git a/v3/pkg/application/webview_window_options.go b/v3/pkg/application/webview_window_options.go index 694beecf5c7..041a8914b30 100644 --- a/v3/pkg/application/webview_window_options.go +++ b/v3/pkg/application/webview_window_options.go @@ -344,11 +344,6 @@ type WindowsWindow struct { // Default: false Wind...
[ "v3/pkg/application/webview_window_options.go", "v3/pkg/application/webview_window_windows.go" ]
[]
true
wailsapp/wails
5,600
issue_to_patch
fix(v3/ci): quote pipe in 'wails3 tool has gcc|clang' Taskfile command
## Root cause Commit #5533 (`0464978ce`) changed the Linux build Taskfile from: \`\`\`yaml sh: 'wails3 tool has-cc' \`\`\` to: \`\`\`yaml sh: 'wails3 tool has gcc|clang' \`\`\` When Task runs a `sh:` value, it passes it to `/bin/sh -c`. The shell interprets the bare `|` as a **pipe**, running: - `wails3 tool has gcc`...
78cde81e204dc7567429b45ac30b1f3b9455b7b3
26af4a0f9c9b5940b5dd953c72501be4c7d3a3f1
diff --git a/.github/workflows/build-and-test-v3.yml b/.github/workflows/build-and-test-v3.yml index 1a0c617d724..e0f6f205f57 100644 --- a/.github/workflows/build-and-test-v3.yml +++ b/.github/workflows/build-and-test-v3.yml @@ -284,6 +284,9 @@ jobs: # Replace @wailsio/runtime version with local tarball ...
[ ".github/workflows/build-and-test-v3.yml", "v3/internal/commands/build_assets/linux/Taskfile.yml" ]
[]
true
wailsapp/wails
26
issue_to_patch
Move headless capability into own library
a6489a1044ba99bcaeadd3f9bd37a9508b1c490f
6e011e75c30456df48cc8f3c8a76b4b01240cef1
diff --git a/a_wails-packr.go b/a_wails-packr.go index 10b3ca4a764..821cd0820f8 100644 --- a/a_wails-packr.go +++ b/a_wails-packr.go @@ -11,5 +11,13 @@ func init() { packr.PackJSONBytes("./assets/default", "jquery.3.3.1.min.js", "\"LyohIGpRdWVyeSB2My4zLjEgLWFqYXgsLWFqYXgvanNvbnAsLWFqYXgvbG9hZCwtYWpheC9wYXJzZVhNTCwtYW...
[ "a_wails-packr.go", "app.go", "assets/bridge/wailsbridge.js", "assets/bridge/wailsbridge.prod.js", "assets/headless/index.html", "cmd/templates/vuewebpack/frontend/src/components/Quote.vue", "cmd/templates/vuewebpack/frontend/src/main.js", "cmd/templates/vuewebpack/frontend/src/wailsbridge.js", "cmd...
[]
true