repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
woltapp/blurhash | 198 | issue_to_patch | Fix npm version | 83398bd729653c7afebb521b53d337581510c860 | fefd173c9969507730e9662922e74fe1ee80a9e6 | diff --git a/TypeScript/package.json b/TypeScript/package.json
index 83e86b29..11903450 100644
--- a/TypeScript/package.json
+++ b/TypeScript/package.json
@@ -1,6 +1,6 @@
{
"name": "blurhash",
- "version": "2.0.0",
+ "version": "1.2.0",
"description": "Encoder and decoder for the Wolt BlurHash algorithm.",
... | [
"TypeScript/package.json",
"Website/package-lock.json"
] | [] | true | |||
woltapp/blurhash | 195 | issue_to_patch | Add reference to Zig implementation in README.md | 💙 | 1f7afa0db25f26aee8a9bdb64af5e00f8b3a79d1 | a412ddc9e2e0ae88a373f4f82d1c2026513c4616 | diff --git a/Readme.md b/Readme.md
index e7de3f71..15088a69 100644
--- a/Readme.md
+++ b/Readme.md
@@ -65,6 +65,7 @@ These cover our use cases, but could probably use polishing, extending and impro
* [JavaScript](https://github.com/mad-gooze/fast-blurhash) - Tiny optimized decoder implementation JS.
* [Xojo](https://... | [
"Readme.md"
] | [] | true | ||
woltapp/blurhash | 192 | issue_to_patch | Bump terser from 5.14.1 to 5.14.2 in /Website | Bumps [terser](https://github.com/terser/terser) from 5.14.1 to 5.14.2.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/terser/terser/blob/master/CHANGELOG.md">terser's changelog</a>.</em></p>
<blockquote>
<h2>v5.14.2</h2>
<ul>
<li>Security fix for RegExps that should not be evalu... | 55426a1730e2d0a8b7fb73e7581d3bca1bae88cb | 19e520851ed610f029c859d4c84ea7519fe61d95 | diff --git a/Website/package-lock.json b/Website/package-lock.json
index 5472d5f1..a2a374af 100644
--- a/Website/package-lock.json
+++ b/Website/package-lock.json
@@ -34,7 +34,7 @@
},
"../TypeScript": {
"name": "blurhash",
- "version": "1.1.5",
+ "version": "2.0.0",
"license": "MIT",
... | [
"Website/package-lock.json"
] | [] | true | ||
woltapp/blurhash | 191 | issue_to_patch | Bump terser from 5.14.1 to 5.14.2 in /TypeScript | Bumps [terser](https://github.com/terser/terser) from 5.14.1 to 5.14.2.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/terser/terser/blob/master/CHANGELOG.md">terser's changelog</a>.</em></p>
<blockquote>
<h2>v5.14.2</h2>
<ul>
<li>Security fix for RegExps that should not be evalu... | 55426a1730e2d0a8b7fb73e7581d3bca1bae88cb | 16478a7a1498623a8bf596699564afa566772c0e | diff --git a/TypeScript/yarn.lock b/TypeScript/yarn.lock
index 48536793..6a2f022a 100644
--- a/TypeScript/yarn.lock
+++ b/TypeScript/yarn.lock
@@ -536,9 +536,9 @@ browserslist@^4.14.5:
update-browserslist-db "^1.0.4"
buffer-from@^1.0.0:
- version "1.1.1"
- resolved "https://registry.yarnpkg.com/buffer-from/-/... | [
"TypeScript/yarn.lock"
] | [] | true | ||
woltapp/blurhash | 190 | issue_to_patch | TypeScript: Modern bundling | This PR introduces modern bundling of the npm package using `tsup`. | fd8dfb5b2832997b4d178f655f3dfcbcf3c26d82 | 703d432ba4259e56eed167c3a222be3175c20d19 | diff --git a/TypeScript/package.json b/TypeScript/package.json
index cab19f60..34b69789 100644
--- a/TypeScript/package.json
+++ b/TypeScript/package.json
@@ -5,21 +5,29 @@
"main": "dist/index.js",
"module": "dist/esm/index.js",
"types": "dist/index.d.ts",
+ "exports": {
+ ".": {
+ "require": "./dist/... | [
"TypeScript/package.json",
"TypeScript/tsup.config.ts",
"TypeScript/yarn.lock",
"Website/package-lock.json",
"Website/package.json",
"Website/src/sections/demo.js",
"Website/src/sections/hero.js"
] | [
{
"comment": "😗 👌 ",
"path": "Website/src/sections/demo.js",
"hunk": "@@ -71,7 +71,7 @@ function renderSelectedImage() {\n const firstPredefinedImage = document.querySelector('.predefined input:checked + img');\n originalCanvas.classList.remove('visible');\n fileInput.value = '';\n- renderImage... | true | ||
woltapp/blurhash | 150 | issue_to_patch | Optimize multiplyBasisFunction by caching math operations | I have optimized some operations to avoid re-computation. | f9589f03ee4ee0ce4a729f4c292d6a0e48a95d7f | 3554906d81169b2d5ac93190bb6c4a2890912bb2 | diff --git a/TypeScript/src/encode.ts b/TypeScript/src/encode.ts
index 363e4403..449ae8b1 100644
--- a/TypeScript/src/encode.ts
+++ b/TypeScript/src/encode.ts
@@ -18,14 +18,17 @@ const multiplyBasisFunction = (
const bytesPerRow = width * bytesPerPixel;
for (let x = 0; x < width; x++) {
+ const bytesPerPixel... | [
"TypeScript/src/encode.ts"
] | [
{
"comment": "Can you remove the parenteses? ",
"path": "TypeScript/src/encode.ts",
"hunk": "@@ -18,14 +18,17 @@ const multiplyBasisFunction = (\n const bytesPerRow = width * bytesPerPixel;\n \n for (let x = 0; x < width; x++) {\n+ const bytesPerPixelX = bytesPerPixel * x;\n+\n for (let y = 0... | true | ||
woltapp/blurhash | 181 | issue_to_patch | TypeScript implementation encodes non-zero DC component for all-black images
From the README:
> Also, the average colour of the entire image is just the DC component
However, when you try a completely black picture on the homepage (all pixels are 0), the DC component will be `09jvf`, so not 0, and not the avera... | Fix DC decoding | This PR fixes decode of the DC component by truncating instead of round the value.
## Before
## After
 => {
export const linearTosRGB = (value: number) => {
let v = Math.max(0, Math.min(1, value));
i... | [
"TypeScript/src/utils.ts"
] | [] | true | |
woltapp/blurhash | 180 | issue_to_patch | Share friendly website
Please make the website share-friendly: https://twitter.com/szepeviktor/status/1147848608512970752 | Add meta tags for open graph protocol and twitter cards | Lets https://blurha.sh more share friendly, adding meta tags.
Fixes #5. | abcf69fa15829b6500110e9cd973123afe15b558 | 77f9b4ff043300f19cb10fe5ff5a8255f3e334c6 | diff --git a/Website/src/index.ejs b/Website/src/index.ejs
index 235bfa34..8cf4bffe 100644
--- a/Website/src/index.ejs
+++ b/Website/src/index.ejs
@@ -7,6 +7,15 @@
content="width=device-width, initial-scale=1.0, minimum-scale=1, maximum-scale=1, user-scalable=0, shrink-to-fit=no"
/>
<title><%= htmlWebp... | [
"Website/src/index.ejs"
] | [
{
"comment": "AFAIK twitter specific tags are not needed any more, OG is enough",
"path": "Website/src/index.ejs",
"hunk": "@@ -7,6 +7,15 @@\n content=\"width=device-width, initial-scale=1.0, minimum-scale=1, maximum-scale=1, user-scalable=0, shrink-to-fit=no\"\n />\n <title><%= htmlWebpac... | true | |
woltapp/blurhash | 178 | issue_to_patch | Website: Cleanup package and dependencies | This PR cleans up the website package and update dependencies. | afc2219531fca4f7c5c0962d982e820bea20faa3 | 549cd4233db57ce97b48d0cce9aa8ad1b8979dbf | diff --git a/Website/assets/svg/wolt-logo.svg b/Website/assets/svg/wolt-logo.svg
index 0d2d0f63..fad3c6aa 100644
--- a/Website/assets/svg/wolt-logo.svg
+++ b/Website/assets/svg/wolt-logo.svg
@@ -1,6 +1,6 @@
-<svg xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" width="64" height="30" viewBo... | [
"Website/assets/svg/wolt-logo.svg",
"Website/package-lock.json",
"Website/package.json",
"Website/src/index.scss",
"Website/webpack.config.js"
] | [] | true | ||
woltapp/blurhash | 97 | issue_to_patch | Add unused files to .npmignore | These files were [published to npm](
https://unpkg.com/browse/blurhash@1.1.3/) but they are not necessary.
This PR prevents publishing unnecessary files to npm. | f41a23cc50fba7af5650920d3e7ed4315a21d4c3 | 50809ee080cbdbb599ebe2ba064ad85c77746342 | diff --git a/TypeScript/.npmignore b/TypeScript/.npmignore
index ae735b9a..66fbd98e 100644
--- a/TypeScript/.npmignore
+++ b/TypeScript/.npmignore
@@ -1,3 +1,6 @@
+.DS_Store
+.prettierrc
tsconfig.json
src
demo
+webpack.config.js
| [
"TypeScript/.npmignore"
] | [] | true | ||
woltapp/blurhash | 177 | issue_to_patch | Update package.json, update dependencies | This PR does some general tidying of the package.json and updates dependencies. | c266c6bf2d339dce0edbcfbcabd30c4cda717082 | fac0065d5cd2ac2869c03b6a94c15e8216a994c2 | diff --git a/TypeScript/package.json b/TypeScript/package.json
index 1f51a383..cab19f60 100644
--- a/TypeScript/package.json
+++ b/TypeScript/package.json
@@ -10,7 +10,7 @@
"type": "git",
"url": "https://github.com/woltapp/blurhash/tree/master/TypeScript"
},
- "homepage": "http://blurhash.com",
+ "homepa... | [
"TypeScript/package.json",
"TypeScript/src/base83.ts",
"TypeScript/src/decode.ts",
"TypeScript/src/demo.ts",
"TypeScript/src/encode.ts",
"TypeScript/webpack.config.js",
"TypeScript/yarn.lock"
] | [] | true | ||
woltapp/blurhash | 175 | issue_to_patch | Xojo implementation reference and attribution | 2255813559a092d56d1f1fe349557bc4b15b1cd2 | 51a64907cb687c6daa4dc60aca862ca17d21d192 | diff --git a/Readme.md b/Readme.md
index 4de94c54..e7de3f71 100644
--- a/Readme.md
+++ b/Readme.md
@@ -63,6 +63,7 @@ These cover our use cases, but could probably use polishing, extending and impro
* [Elixir](https://github.com/perzanko/blurhash-elixir) - Encoder implementation in pure Elixir.
* [ReScript](https://gi... | [
"Readme.md"
] | [] | true | |||
woltapp/blurhash | 176 | issue_to_patch | docs: Add react-native-blurhash | Adds the React Native UI component implementation | 11cbf6ce79a66e686d2a8e7e5b810e7d41d1f576 | 52d6b9a9c098b89517fd4b30bf54b9b57e4d460a | diff --git a/Readme.md b/Readme.md
index 2c41a314..4de94c54 100644
--- a/Readme.md
+++ b/Readme.md
@@ -63,6 +63,7 @@ These cover our use cases, but could probably use polishing, extending and impro
* [Elixir](https://github.com/perzanko/blurhash-elixir) - Encoder implementation in pure Elixir.
* [ReScript](https://gi... | [
"Readme.md"
] | [] | true | ||
woltapp/blurhash | 173 | issue_to_patch | Add a link to GH search for "blurhash" repos in the readme | ecc5565f7a661bc3452d119e6b9379e3e91a6b5f | f28d1ae001b6682a21a85c65554771c914dd7c15 | diff --git a/Readme.md b/Readme.md
index 76057d99..2c41a314 100644
--- a/Readme.md
+++ b/Readme.md
@@ -65,6 +65,8 @@ These cover our use cases, but could probably use polishing, extending and impro
* [JavaScript](https://github.com/mad-gooze/fast-blurhash) - Tiny optimized decoder implementation JS.
+Can't find th... | [
"Readme.md"
] | [] | true | |||
woltapp/blurhash | 52 | issue_to_patch | Add BlurHashSharp to README | Alternative C# implementation | f6cd350bc11cf72db2c846c05eb8b9f5ce8dd5b5 | 7ba29b5bacc63aade3971cd907f5295d2331b801 | diff --git a/Readme.md b/Readme.md
index 0b52210b..276aaf56 100644
--- a/Readme.md
+++ b/Readme.md
@@ -56,6 +56,7 @@ These cover our use cases, but could probably use polishing, extending and impro
* [Elm](https://github.com/WhileTruu/elm-blurhash) - Encoder and decoder in Elm.
* [Dart](https://github.com/justacid/bl... | [
"Readme.md"
] | [] | true | ||
woltapp/blurhash | 49 | issue_to_patch | Added pure JS implementation reference | Adds pure JS implementation reference (#47) | 27ba0ce090b02e57c6b024bc22969714dc7a9401 | df358338f0b482028ff82a1212fb588839353a1c | diff --git a/Readme.md b/Readme.md
index 276aaf56..76057d99 100644
--- a/Readme.md
+++ b/Readme.md
@@ -56,6 +56,7 @@ These cover our use cases, but could probably use polishing, extending and impro
* [Elm](https://github.com/WhileTruu/elm-blurhash) - Encoder and decoder in Elm.
* [Dart](https://github.com/justacid/bl... | [
"Readme.md"
] | [] | true | ||
woltapp/blurhash | 59 | issue_to_patch | Add Crystal implementation to README | Adds encoder implementation for [Crystal](https://crystal-lang.org/) language. | 55e01bef705835f7fc9da7ccd1bd0edddb6d1d24 | 11c9ea18780ba0e2931df2de994a45176a823bea | diff --git a/Readme.md b/Readme.md
index db9419b9..8c972d27 100644
--- a/Readme.md
+++ b/Readme.md
@@ -52,6 +52,7 @@ These cover our use cases, but could probably use polishing, extending and impro
* [Nim](https://github.com/SolitudeSF/blurhash) - Encoder and decoder implementation in pure Nim.
* [Rust and WebAssembl... | [
"Readme.md"
] | [] | true | ||
woltapp/blurhash | 61 | issue_to_patch | Haskell implementation reference and attribution | ae448e0b4e85d5357b5fa7c9f0da7fdd6721a796 | b92779ebdacb316808fe83f5c2bf3b173ebc3dd2 | diff --git a/Readme.md b/Readme.md
index f31cd0c5..40a7bd4f 100644
--- a/Readme.md
+++ b/Readme.md
@@ -55,6 +55,7 @@ These cover our use cases, but could probably use polishing, extending and impro
* [Elm](https://github.com/WhileTruu/elm-blurhash) - Encoder and decoder in Elm.
* [Dart](https://github.com/justacid/bl... | [
"Readme.md"
] | [] | true | |||
woltapp/blurhash | 62 | issue_to_patch | Add Scala implementation to readme | Added Scala implementation | dd1986b561c582e10e5f19bdde8482df709d58b3 | 1a3a0a5b412f9322a19d36df28a47f81e9a89f1a | diff --git a/Readme.md b/Readme.md
index 9553a80f..f31cd0c5 100644
--- a/Readme.md
+++ b/Readme.md
@@ -55,6 +55,7 @@ These cover our use cases, but could probably use polishing, extending and impro
* [Elm](https://github.com/WhileTruu/elm-blurhash) - Encoder and decoder in Elm.
* [Dart](https://github.com/justacid/bl... | [
"Readme.md"
] | [] | true | ||
woltapp/blurhash | 78 | issue_to_patch | C: Add `-Ofast` compiler flag to Makefile | Includes options such as `-ffast-math` which should help speed things up (See: [gcc optimization flags](https://gcc.gnu.org/onlinedocs/gcc/Optimize-Options.html)) | 6d9bc1ffd1f84593b078e7d1bb35a93123a3ae55 | d1ad7d5e9143e71bd4a48322bdbfaf2763e37739 | diff --git a/C/Makefile b/C/Makefile
index a47273bb..33dddaa4 100644
--- a/C/Makefile
+++ b/C/Makefile
@@ -1,10 +1,10 @@
PROGRAM=blurhash_encoder
DECODER=blurhash_decoder
$(PROGRAM): encode_stb.c encode.c encode.h stb_image.h common.h
- $(CC) -o $@ encode_stb.c encode.c -lm
+ $(CC) -o $@ encode_stb.c encode.c -lm -O... | [
"C/Makefile"
] | [] | true | ||
woltapp/blurhash | 81 | issue_to_patch | Elixir implementation of encoder | Github repo: https://github.com/perzanko/blurhash-elixir
Documentation on hexdocs: https://hexdocs.pm/blurhash
Ref: https://github.com/woltapp/blurhash/issues/44 | 5c8db9963bf300dcbc9672746ed3a72590daaeef | 295e95bf188fb051a8b25cc0695d8c50279ea226 | diff --git a/Readme.md b/Readme.md
index 8ddee2c2..9553a80f 100644
--- a/Readme.md
+++ b/Readme.md
@@ -55,6 +55,7 @@ These cover our use cases, but could probably use polishing, extending and impro
* [Elm](https://github.com/WhileTruu/elm-blurhash) - Encoder and decoder in Elm.
* [Dart](https://github.com/justacid/bl... | [
"Readme.md"
] | [] | true | ||
woltapp/blurhash | 91 | issue_to_patch | Update Readme.md | 7a10d9ecc5cf395eff60355c65cdff878aff7252 | 53d9bbc3817c572fa5528fed7e880265c3a35e9c | diff --git a/Readme.md b/Readme.md
index ee47b275..8ddee2c2 100644
--- a/Readme.md
+++ b/Readme.md
@@ -160,5 +160,7 @@ to see what you can come up with!
* [Hendrik Schnepel](https://github.com/hsch) - Java encoder implementation
* [Tuomo Virolainen](https://github.com/tvirolai) - Clojure implementation
* [Fotis Papa... | [
"Readme.md"
] | [] | true | |||
woltapp/blurhash | 92 | issue_to_patch | Add ReScript (BuckleScript) implementation | This implementation in [ReScript language](https://rescript-lang.org/) can be used in ReScript or ReasonML projects such as ReasonReact.
I also provide a js bundle which can be used in plain html by simply inserting a script tag and add `data-blurhash` attribute to an image. | cf6dadbfa264b4c3bad76b52c8a8f74563026b2d | 33ddb035585dd2dc67d47ba7b9e1ea72df7794af | diff --git a/Readme.md b/Readme.md
index dafa83ff..ee47b275 100644
--- a/Readme.md
+++ b/Readme.md
@@ -55,8 +55,10 @@ These cover our use cases, but could probably use polishing, extending and impro
* [Elm](https://github.com/WhileTruu/elm-blurhash) - Encoder and decoder in Elm.
* [Dart](https://github.com/justacid/b... | [
"Readme.md"
] | [] | true | ||
woltapp/blurhash | 103 | issue_to_patch | c: fix define identifier name | 6d9bc1ffd1f84593b078e7d1bb35a93123a3ae55 | 109c39dfaa3ce81326c9154fa2696c6f1e8e880c | diff --git a/C/decode.h b/C/decode.h
index 62dfb8ee..0d380e81 100644
--- a/C/decode.h
+++ b/C/decode.h
@@ -1,6 +1,6 @@
#ifndef __BLURHASH_DECODE_H__
-#define __BLURHASH_DECODE_H
+#define __BLURHASH_DECODE_H__
#include <math.h>
#include <stdbool.h>
| [
"C/decode.h"
] | [] | true | |||
woltapp/blurhash | 113 | issue_to_patch | add fast-blurhash reference | Hi!
I created a smaller and faster decoder implementation in JS and I'd like to share a link to it. | 6d9bc1ffd1f84593b078e7d1bb35a93123a3ae55 | d6265e78abbaddc443e739576c34e0bc0d0ceb21 | diff --git a/Readme.md b/Readme.md
index db9419b9..eb4e4380 100644
--- a/Readme.md
+++ b/Readme.md
@@ -55,6 +55,7 @@ These cover our use cases, but could probably use polishing, extending and impro
* [Elm](https://github.com/WhileTruu/elm-blurhash) - Encoder and decoder in Elm.
* [Dart](https://github.com/justacid/bl... | [
"Readme.md"
] | [] | true | ||
woltapp/blurhash | 127 | issue_to_patch | Corrects formatting in /C/Readme.md | CLI Decoder usage was not rendering as a code block, and there were unescaped strikethrough
Before:
After:
![image](https://user-images.githubusercontent.com/8635304/118535652-f5b70b00-b707-11eb-9d7c-a... | 6d9bc1ffd1f84593b078e7d1bb35a93123a3ae55 | cbb2b8d02dc1f05665a053608d91ca623c28eeeb | diff --git a/C/Readme.md b/C/Readme.md
index 5ee86c0e..3364a9fc 100644
--- a/C/Readme.md
+++ b/C/Readme.md
@@ -34,5 +34,6 @@ Nevertheless, if you want to try it out quickly, simply run:
LaJHjmVu8_~po#smR+a~xaoLWCRj
If you want to try out the decoder, simply run:
+
$ make blurhash_decoder
- $ ./blurhash_decoder "... | [
"C/Readme.md"
] | [] | true | ||
wuyouzhuguli/SpringAll | 23 | issue_to_patch | fix name miss | 1415eadc705c3a8ba379b1cd85c1fd092335c355 | 77cd8fc95db1516a6b750ab33b1b7b6f849b859c | diff --git a/18.Spring-Boot-Jackson/src/main/java/com/example/controller/TestJsonController.java b/18.Spring-Boot-Jackson/src/main/java/com/example/controller/TestJsonController.java
index 14440f21..a2b6502c 100644
--- a/18.Spring-Boot-Jackson/src/main/java/com/example/controller/TestJsonController.java
+++ b/18.Spring... | [
"18.Spring-Boot-Jackson/src/main/java/com/example/controller/TestJsonController.java"
] | [] | true | |||
xM4ddy/OFGB | 32 | issue_to_patch | Correct the link of .NET 8.0 SDK in README.md | 284aa3567b16e93aeaa51ede2bb0f15e366dad57 | cdec89429ea40a3dc219380a8029355e825b192c | diff --git a/README.md b/README.md
index ba01098..a7310ee 100644
--- a/README.md
+++ b/README.md
@@ -13,7 +13,7 @@ On April 23, 2024, Microsoft released an [update](https://support.microsoft.com/
To download the latest version of OFGB, [click here](https://github.com/xM4ddy/OFGB/releases/latest) or click the "Releases... | [
"README.md"
] | [] | true | |||
xM4ddy/OFGB | 21 | issue_to_patch | Correct the README and other in-app text | I've rewritten the README changing the style from title case to standard case and corrected messages in the program itself.
Some people, especially not so tech-savvy ones, might find the strange style of the README to be quite suspicious, thus making them believe this tool is not legit.
I also have renamed `ico.i... | 48fe3e2e43a813561021ff9c0f22ee75acb066e7 | e357107e40f86948af6ae5171e13bbdb167afe2c | diff --git a/Assets/ico.ico b/Assets/icon.ico
similarity index 100%
rename from Assets/ico.ico
rename to Assets/icon.ico
diff --git a/MainWindow.xaml b/MainWindow.xaml
index 8b3d2be..e240689 100644
--- a/MainWindow.xaml
+++ b/MainWindow.xaml
@@ -23,17 +23,17 @@
<Button Content="" FontSize="10" Panel.ZI... | [
"Assets/icon.ico",
"MainWindow.xaml",
"MainWindow.xaml.cs",
"OFGB.csproj",
"README.md"
] | [] | true | ||
xM4ddy/OFGB | 8 | issue_to_patch | Crashfix | dd077c2968196445bba3795b9e4d31b7822a2716 | 01d6936f28f640b25a6aec11e2ce8d8126f49c0f | diff --git a/MainWindow.xaml b/MainWindow.xaml
index db1e99e..656b508 100644
--- a/MainWindow.xaml
+++ b/MainWindow.xaml
@@ -5,7 +5,7 @@
xmlns:mc="http://schemas.openxmlformats.org/markup-compatibility/2006"
mc:Ignorable="d"
ResizeMode="NoResize"
- Title="OFGB - Version 0.1" Height="26... | [
"MainWindow.xaml",
"MainWindow.xaml.cs"
] | [] | true | |||
xai-org/grok-1 | 194 | issue_to_patch | replaced cuda12_pip with cuda12-pip | The `cuda12-pip` package was wrongly named `cuda12_pip` so I fix in the name has been applied. | d6d9447e2d3c9bd81da571dc8681ea60009e4c03 | 5046abecf68190de744582672a90cd9e21fdfece | diff --git a/requirements.txt b/requirements.txt
index f6d124e1..a6126871 100644
--- a/requirements.txt
+++ b/requirements.txt
@@ -1,4 +1,4 @@
dm_haiku==0.0.12
-jax[cuda12_pip]==0.4.25 -f https://storage.googleapis.com/jax-releases/jax_cuda_releases.html
+jax[cuda12-pip]==0.4.25 -f https://storage.googleapis.com/jax-r... | [
"requirements.txt"
] | [] | true | ||
xai-org/grok-1 | 1 | issue_to_patch | Minor fixes and clean-up | ce81a1668e4d34b6971cf8d971faded9a9043172 | e288ce35cbeb5abd344bb2e9aaaf4b9d0abe8d03 | diff --git a/checkpoint.py b/checkpoint.py
index 07aafab2..5068635d 100644
--- a/checkpoint.py
+++ b/checkpoint.py
@@ -23,7 +23,6 @@
import shutil
import tempfile
from concurrent.futures import ThreadPoolExecutor, wait
-from functools import partial
from typing import Any, Optional
import jax
@@ -143,7 +142,6 @@... | [
"checkpoint.py",
"model.py",
"pyproject.toml",
"requirements.txt",
"run.py",
"runners.py"
] | [] | true | |||
xai-org/grok-1 | 155 | issue_to_patch | Make download instruction more clear | e50578b5f50e4c10c6e7cff31af1ef2bedb3beb8 | 48094e5c68eb90a0a57dec4b7b871e13cb63244d | diff --git a/README.md b/README.md
index eaded5cf..12570d79 100644
--- a/README.md
+++ b/README.md
@@ -2,7 +2,8 @@
This repository contains JAX example code for loading and running the Grok-1 open-weights model.
-Make sure to download the checkpoint and place `ckpt-0` directory in `checkpoint`.
+Make sure to downl... | [
"README.md"
] | [] | true | |||
xai-org/grok-1 | 149 | issue_to_patch | Create .gitignore for checkpoints | ignore the checkpoints files | e50578b5f50e4c10c6e7cff31af1ef2bedb3beb8 | d0043955d2f1d174c3bb97344c5b7b3d9b786cf4 | diff --git a/.gitignore b/.gitignore
new file mode 100644
index 00000000..24d0d7e3
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,2 @@
+checkpoints/*
+!checkpoints/README.md
| [
".gitignore"
] | [] | true | ||
xai-org/grok-1 | 27 | issue_to_patch | Update README with Model Specifications | Added an overview of the model as discussed in response to #14.
Adding more info on the the model specs before they proceed to download the checkpoints should help folks ensure they have the necessary resources to effectively utilize Grok-1.
| e50578b5f50e4c10c6e7cff31af1ef2bedb3beb8 | 84d5ae1a9309ba2b54c82e150f88cda8c2d90fba | diff --git a/README.md b/README.md
index eaded5cf..fc3423cc 100644
--- a/README.md
+++ b/README.md
@@ -17,9 +17,26 @@ The script loads the checkpoint and samples from the model on a test input.
Due to the large size of the model (314B parameters), a machine with enough GPU memory is required to test the model with the... | [
"README.md"
] | [] | true | ||
xi-editor/xi-editor | 1,348 | issue_to_patch | Bump commonmarker from 0.23.9 to 0.23.10 in /docs | Bumps [commonmarker](https://github.com/gjtorikian/commonmarker) from 0.23.9 to 0.23.10.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/gjtorikian/commonmarker/releases">commonmarker's releases</a>.</em></p>
<blockquote>
<h2>v0.23.10</h2>
<h2>What's Changed</h2>
<ul>
<li>Upda... | 19ba86a9a621e061cbd27ed9a5df33d3f2f640c8 | 73c6fe87f2bc185462e8d068141e5dae8463cc36 | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index bb558c9ee..33b228123 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -16,7 +16,7 @@ GEM
execjs
coffee-script-source (1.11.1)
colorator (1.1.0)
- commonmarker (0.23.9)
+ commonmarker (0.23.10)
concurrent-ruby (1.2.0)
dnsr... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,346 | issue_to_patch | Bump xml-rs from 0.8.3 to 0.8.14 in /rust | Bumps [xml-rs](https://github.com/kornelski/xml-rs) from 0.8.3 to 0.8.14.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/kornelski/xml-rs/blob/main/Changelog.md">xml-rs's changelog</a>.</em></p>
<blockquote>
<h2>Version 0.8.7</h2>
<ul>
<li>Basic parsing of DTD internal subset</li... | ec9bf9161cf8579e3c80f1c336f6482a6c0c66d9 | 081ed10d29fb5e889219b55af22876d4cc0a8719 | diff --git a/rust/Cargo.lock b/rust/Cargo.lock
index 6e7b13eab..820096357 100644
--- a/rust/Cargo.lock
+++ b/rust/Cargo.lock
@@ -1510,9 +1510,9 @@ version = "0.3.0"
[[package]]
name = "xml-rs"
-version = "0.8.3"
+version = "0.8.14"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "b07db... | [
"rust/Cargo.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,345 | issue_to_patch | Bump nokogiri from 1.14.1 to 1.14.3 in /docs | Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.14.1 to 1.14.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sparklemotion/nokogiri/releases">nokogiri's releases</a>.</em></p>
<blockquote>
<h2>1.14.3 / 2023-04-11</h2>
<h3>Security</h3>
<ul>
<li>[CRuby] Ve... | c6231000f207045e33fb17a833987e96e006b6be | 6fb97fcbdf4de20661c646410cc333e28e72f21d | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index aacfe4c7f..9d947ddab 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -234,7 +234,7 @@ GEM
jekyll-seo-tag (~> 2.1)
minitest (5.17.0)
multipart-post (2.1.1)
- nokogiri (1.14.1)
+ nokogiri (1.14.3)
mini_portile2 (~> 2.8.0)
... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,344 | issue_to_patch | Bump commonmarker from 0.23.7 to 0.23.9 in /docs | Bumps [commonmarker](https://github.com/gjtorikian/commonmarker) from 0.23.7 to 0.23.9.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/gjtorikian/commonmarker/releases">commonmarker's releases</a>.</em></p>
<blockquote>
<h2>v0.23.9</h2>
<h2>What's Changed</h2>
<ul>
<li>Update... | c6231000f207045e33fb17a833987e96e006b6be | 16baece415281c8a855bc8e8ee58bc106d8e4131 | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index aacfe4c7f..ea7e9a6ce 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -16,7 +16,7 @@ GEM
execjs
coffee-script-source (1.11.1)
colorator (1.1.0)
- commonmarker (0.23.7)
+ commonmarker (0.23.9)
concurrent-ruby (1.2.0)
dnsru... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,343 | issue_to_patch | Bump time from 0.1.43 to 0.2.0 in /rust | Bumps [time](https://github.com/time-rs/time) from 0.1.43 to 0.2.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/time-rs/time/releases">time's releases</a>.</em></p>
<blockquote>
<h2>v0.2.0</h2>
<p>See <a href="https://redirect.github.com/time-rs/time/issues/190">#190</a> f... | d027769cec36c3b479ead6a5e963fb5a664149a9 | 98d0ba3f770b729910e169dc2ee57cadf86d3195 | diff --git a/rust/Cargo.lock b/rust/Cargo.lock
index e083db57b..6e7b13eab 100644
--- a/rust/Cargo.lock
+++ b/rust/Cargo.lock
@@ -176,7 +176,7 @@ checksum = "80094f509cf8b5ae86a4966a39b3ff66cd7e2a3e594accec3743ff3fabeab5b2"
dependencies = [
"num-integer",
"num-traits",
- "time",
+ "time 0.1.45",
]
[[package]]
@... | [
"rust/Cargo.lock",
"rust/core-lib/Cargo.toml",
"rust/trace/Cargo.toml"
] | [] | true | ||
xi-editor/xi-editor | 1,342 | issue_to_patch | Bump nokogiri from 1.13.6 to 1.14.1 in /docs | Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.6 to 1.14.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sparklemotion/nokogiri/releases">nokogiri's releases</a>.</em></p>
<blockquote>
<h2>1.14.1 / 2023-01-30</h2>
<h3>Fixed</h3>
<ul>
<li>Serializing d... | 6cefd9008abd1ca9c3a90be355510805751a0cce | 5f6e6b8e337cb4d6599ee431cb1941e9e3f05a95 | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index 060eb3775..aacfe4c7f 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -227,14 +227,14 @@ GEM
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
mercenary (0.3.6)
- mini_portile2 (2.8.0)
+ mini_portile2 (2.8.1)
mi... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,341 | issue_to_patch | Bump activesupport from 6.0.4.7 to 6.0.6.1 in /docs | Bumps [activesupport](https://github.com/rails/rails) from 6.0.4.7 to 6.0.6.1.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/rails/rails/releases">activesupport's releases</a>.</em></p>
<blockquote>
<h2>v6.0.6.1</h2>
<h2>Active Support</h2>
<ul>
<li>No changes.</li>
</ul>
<h... | 613e6247d8bb5e86f5f68e35f68463af341d0b8d | e4aa31daf57d3f710111c3606e39023371231437 | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index b93c01185..060eb3775 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -1,7 +1,7 @@
GEM
remote: https://rubygems.org/
specs:
- activesupport (6.0.4.7)
+ activesupport (6.0.6.1)
concurrent-ruby (~> 1.0, >= 1.0.2)
i18n (>= 0.7, < ... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,340 | issue_to_patch | Bump commonmarker from 0.23.6 to 0.23.7 in /docs | Bumps [commonmarker](https://github.com/gjtorikian/commonmarker) from 0.23.6 to 0.23.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/gjtorikian/commonmarker/releases">commonmarker's releases</a>.</em></p>
<blockquote>
<h2>v0.23.7</h2>
<h2>What's Changed</h2>
<ul>
<li>C API ... | 1fce0ee0aae87c166035083e59ed60f9be04d364 | 6ec03a0bc47f7e104292c1e61cd864d938cfff00 | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index 6efb28668..b93c01185 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -16,7 +16,7 @@ GEM
execjs
coffee-script-source (1.11.1)
colorator (1.1.0)
- commonmarker (0.23.6)
+ commonmarker (0.23.7)
concurrent-ruby (1.1.10)
dnsr... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,339 | issue_to_patch | Add discontinuation notice to the Xi editor | I know we like our "we may work again on this in the future" notices and to keep possibilities open, but as discussed on Zulip, we're extremely unlikely to actually do any meaningful work on this project in the next few years (or ever, arguably), and having a note that implies the opposite feels a bit dishonest.
Thi... | f3b4d3909da66b24adfac1c4613923491df0d846 | 3370967f1e1887cfd537d8eee461502d5aa17d4f | diff --git a/README.md b/README.md
index 9b3f32d34..cefced8d0 100644
--- a/README.md
+++ b/README.md
@@ -1,16 +1,6 @@
-<h1 align="center">
- <a href="https://github.com/xi-editor/xi-editor"><img src="icons/xi-editor.png" alt="Xi Editor" width="256" height="256"/></a><br>
- <a href="https://github.com/xi-editor/xi-edi... | [
"README.md"
] | [] | true | ||
xi-editor/xi-editor | 1,337 | issue_to_patch | Bump commonmarker from 0.23.4 to 0.23.6 in /docs | Bumps [commonmarker](https://github.com/gjtorikian/commonmarker) from 0.23.4 to 0.23.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/gjtorikian/commonmarker/releases">commonmarker's releases</a>.</em></p>
<blockquote>
<h2>v0.23.6</h2>
<h2>What's Changed</h2>
<p>This release... | c44e2bd011aed7c2d4d625b6a59bb2682a4654c0 | c2c759768b77d4fe2c187835a089fba58b667f3a | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index 490b8e627..6efb28668 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -16,7 +16,7 @@ GEM
execjs
coffee-script-source (1.11.1)
colorator (1.1.0)
- commonmarker (0.23.4)
+ commonmarker (0.23.6)
concurrent-ruby (1.1.10)
dnsr... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,336 | issue_to_patch | Bump tzinfo from 1.2.9 to 1.2.10 in /docs | Bumps [tzinfo](https://github.com/tzinfo/tzinfo) from 1.2.9 to 1.2.10.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/tzinfo/tzinfo/releases">tzinfo's releases</a>.</em></p>
<blockquote>
<h2>v1.2.10</h2>
<ul>
<li>Fixed a relative path traversal bug that could cause arbitrary ... | ceed58dcc50d710d6104c6fe7ffc41a07bce725d | 267974be999cc27f0b1ec75cc2f2fe004c15fdd0 | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index 1006bd98a..490b8e627 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -270,7 +270,7 @@ GEM
thread_safe (0.3.6)
typhoeus (1.4.0)
ethon (>= 0.9.0)
- tzinfo (1.2.9)
+ tzinfo (1.2.10)
thread_safe (~> 0.1)
unf (0.1.4)
... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,332 | issue_to_patch | Bump generic-array from 0.12.3 to 0.12.4 in /rust | Bumps [generic-array](https://github.com/fizyk20/generic-array) from 0.12.3 to 0.12.4.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/fizyk20/generic-array/blob/0.12.4/CHANGELOG.md">generic-array's changelog</a>.</em></p>
<blockquote>
<ul>
<li>
<p><strong><code>0.12.4</code></str... | 4f3f7811db49e1ff495a3cf474fd506f1e5fda0a | 751eb9b54cf40bdd68bd41519c653eabc4cb0d22 | diff --git a/rust/Cargo.lock b/rust/Cargo.lock
index 237277d4d..2d0978829 100644
--- a/rust/Cargo.lock
+++ b/rust/Cargo.lock
@@ -391,9 +391,9 @@ checksum = "3dcaa9ae7725d12cdb85b3ad99a434db70b468c09ded17e012d86b5c1010f7a7"
[[package]]
name = "generic-array"
-version = "0.12.3"
+version = "0.12.4"
source = "registr... | [
"rust/Cargo.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,327 | issue_to_patch | Bump nokogiri from 1.13.4 to 1.13.6 in /docs | Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.4 to 1.13.6.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sparklemotion/nokogiri/releases">nokogiri's releases</a>.</em></p>
<blockquote>
<h2>1.13.6 / 2022-05-08</h2>
<h3>Security</h3>
<ul>
<li>[CRuby] Ad... | cb6b0b13cc6614b9d7532a7ed1bbfad22ff351da | 1d3fe61f76f0d2558abf424f7a0bb47546dee23b | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index e08b5d621..1006bd98a 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -234,7 +234,7 @@ GEM
jekyll-seo-tag (~> 2.1)
minitest (5.15.0)
multipart-post (2.1.1)
- nokogiri (1.13.4)
+ nokogiri (1.13.6)
mini_portile2 (~> 2.8.0)
... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,331 | issue_to_patch | Bump miow from 0.2.1 to 0.2.2 in /rust | Bumps [miow](https://github.com/yoshuawuyts/miow) from 0.2.1 to 0.2.2.
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/yoshuawuyts/miow/commit/6fd7b9cfb5f5998dc6772803354b05815e579bb8"><code>6fd7b9c</code></a> Bump version to 0.2.2</li>
<li><a href="https://github.com/yoshuawuyts/miow/commit/5... | cb6b0b13cc6614b9d7532a7ed1bbfad22ff351da | 07ab97895e7d18b62bd46c67929a085d7d11ac5b | diff --git a/rust/Cargo.lock b/rust/Cargo.lock
index 06e96179f..8afe1202c 100644
--- a/rust/Cargo.lock
+++ b/rust/Cargo.lock
@@ -587,9 +587,9 @@ dependencies = [
[[package]]
name = "miow"
-version = "0.2.1"
+version = "0.2.2"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "8c1f2f3b1cf... | [
"rust/Cargo.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,329 | issue_to_patch | Bump crossbeam-utils from 0.7.2 to 0.8.7 in /rust | Bumps [crossbeam-utils](https://github.com/crossbeam-rs/crossbeam) from 0.7.2 to 0.8.7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/crossbeam-rs/crossbeam/releases">crossbeam-utils's releases</a>.</em></p>
<blockquote>
<h2>crossbeam-utils 0.8.7</h2>
<ul>
<li>Add <code>Atom... | cb6b0b13cc6614b9d7532a7ed1bbfad22ff351da | 407b1116292bdbf778e805bf916dc688aa10604b | diff --git a/rust/Cargo.lock b/rust/Cargo.lock
index 06e96179f..237277d4d 100644
--- a/rust/Cargo.lock
+++ b/rust/Cargo.lock
@@ -152,6 +152,12 @@ version = "0.1.10"
source = "registry+https://github.com/rust-lang/crates.io-index"
checksum = "4785bdd1c96b2a846b2bd7cc02e86b6b3dbf14e7e53446c4f54c92a361040822"
+[[packa... | [
"rust/Cargo.lock",
"rust/rpc/Cargo.toml"
] | [] | true | ||
xi-editor/xi-editor | 1,324 | issue_to_patch | Minor tweaks in xi-unicode | I started investigating #1322, and ended up spending some time reverse engineering the old scripts for generating various parts of the `xi-unicode` crate.
I was trying to update to the unicode 14 data files, but ended up running into a bunch of failing tests (with the new test data) and I don't have the bandwidth to... | ab32ee01287e2a35edfda346948a35369493c942 | 4dedc76da3775c55016c7d40ea0ddadd89af322f | diff --git a/rust/unicode/README.md b/rust/unicode/README.md
new file mode 100644
index 000000000..db2a07b68
--- /dev/null
+++ b/rust/unicode/README.md
@@ -0,0 +1,34 @@
+# xi-unicode
+
+This crate contains unicode utilites adapted for working with non-contiguous
+bytes (such as a rope.)
+
+Much of the contents of this ... | [
"rust/unicode/README.md",
"rust/unicode/src/emoji.rs",
"rust/unicode/src/lib.rs",
"rust/unicode/src/tables.rs",
"rust/unicode/tools/mk_tables.py"
] | [] | true | ||
xi-editor/xi-editor | 1,326 | issue_to_patch | Update /docs Gemfile | I frankly have no idea how any of this works, and there is at least a
50% chance that I have damaged something irreperably. On the plus side,
perhaps github will stop yelling at my about 'security' 'vulnerabilities' for a
little while?
| ab32ee01287e2a35edfda346948a35369493c942 | fd84765343419fad9123a544e4c0c6edb085a2fc | diff --git a/docs/Gemfile b/docs/Gemfile
index 594faba1e..898e6f108 100644
--- a/docs/Gemfile
+++ b/docs/Gemfile
@@ -1,5 +1,5 @@
source 'https://rubygems.org'
-gem 'github-pages', "~> 209", group: :jekyll_plugins
-gem 'therubyracer'
+gem 'github-pages'
gem 'octopress-autoprefixer'
+#gem 'therubyracer' # what did th... | [
"docs/Gemfile",
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,325 | issue_to_patch | Some clippy | Might as well do this while i have the repo open 🤷 | b52fde704b8abb4caaf97f29b804d8fa549c68cc | 4c8f9df9d88a7bd98374b26ad5a602ade4bf8c58 | diff --git a/rust/core-lib/src/annotations.rs b/rust/core-lib/src/annotations.rs
index 5143d52c5..37b364870 100644
--- a/rust/core-lib/src/annotations.rs
+++ b/rust/core-lib/src/annotations.rs
@@ -152,11 +152,7 @@ impl AnnotationStore {
/// Invalidates and removes all annotations in the range of the interval.
... | [
"rust/core-lib/src/annotations.rs",
"rust/core-lib/src/editor.rs",
"rust/core-lib/src/layers.rs",
"rust/core-lib/src/plugins/manifest.rs",
"rust/lsp-lib/src/conversion_utils.rs",
"rust/syntect-plugin/src/main.rs",
"rust/trace/src/chrome_trace_dump.rs",
"rust/trace/src/lib.rs",
"rust/unicode/src/lib.... | [] | true | ||
xi-editor/xi-editor | 1,316 | issue_to_patch | Bump addressable from 2.7.0 to 2.8.0 in /docs | Bumps [addressable](https://github.com/sporkmonger/addressable) from 2.7.0 to 2.8.0.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/sporkmonger/addressable/blob/main/CHANGELOG.md">addressable's changelog</a>.</em></p>
<blockquote>
<h1>Addressable 2.8.0</h1>
<ul>
<li>fixes ReDoS v... | 849c0b1d3a0918b55a92726c771e119cd4bf3c9f | 3864c452f0ba47565cc33c043394e64c60273196 | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index f07ddfd52..c4f43dfb1 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -7,7 +7,7 @@ GEM
minitest (~> 5.1)
tzinfo (~> 1.1)
zeitwerk (~> 2.2, >= 2.2.2)
- addressable (2.7.0)
+ addressable (2.8.0)
public_suffix (>= 2.0.2, < ... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,323 | issue_to_patch | Bump nokogiri from 1.13.3 to 1.13.4 in /docs | Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.13.3 to 1.13.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sparklemotion/nokogiri/releases">nokogiri's releases</a>.</em></p>
<blockquote>
<h2>1.13.4 / 2022-04-11</h2>
<h3>Security</h3>
<ul>
<li>Address <a... | 323e284ea96307c510f990f5d12facc694ce15ab | 868087e4e9d269a741173537403e4aa8d82c7079 | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index 4e77118f5..1a472f73a 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -215,7 +215,7 @@ GEM
jekyll-seo-tag (~> 2.1)
minitest (5.14.3)
multipart-post (2.1.1)
- nokogiri (1.13.3)
+ nokogiri (1.13.4)
mini_portile2 (~> 2.8.0)
... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,321 | issue_to_patch | Bump nokogiri from 1.12.5 to 1.13.3 in /docs | Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.12.5 to 1.13.3.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sparklemotion/nokogiri/releases">nokogiri's releases</a>.</em></p>
<blockquote>
<h2>1.13.3 / 2022-02-21</h2>
<h3>Fixed</h3>
<ul>
<li>[CRuby] Rever... | 4aa3d8e23efcbcfd37df362fc5ccf8a3141f26b4 | 9ab95d5c6289411b9086d5802e72b368b1a49b1e | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index 047ba2276..4e77118f5 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -208,15 +208,15 @@ GEM
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
mercenary (0.3.6)
- mini_portile2 (2.6.1)
+ mini_portile2 (2.8.0)
mi... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,319 | issue_to_patch | Bump nokogiri from 1.11.4 to 1.12.5 in /docs | Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.11.4 to 1.12.5.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sparklemotion/nokogiri/releases">nokogiri's releases</a>.</em></p>
<blockquote>
<h2>1.12.5 / 2021-09-27</h2>
<h3>Security</h3>
<p>[JRuby] Address ... | 7cd12f4ef6fb94cc78c521a853bbca8821482454 | f72ecfacff478c93f93b7324076f5ce19b308ff1 | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index f07ddfd52..047ba2276 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -208,15 +208,15 @@ GEM
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
mercenary (0.3.6)
- mini_portile2 (2.5.1)
+ mini_portile2 (2.6.1)
mi... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,318 | issue_to_patch | warnings + clippy | - [ ] I have responded to reviews and made changes where appropriate.
- [x] I have tested the code with `cargo test --all` / `./rust/run_all_checks`.
- [x] I have updated comments / documentation related to the changes I made.
- [x] I have rebased my PR branch onto xi-editor/master.
| 849c0b1d3a0918b55a92726c771e119cd4bf3c9f | b627ce6c298d76574db51827e87db50b97c2bb78 | diff --git a/rust/core-lib/src/backspace.rs b/rust/core-lib/src/backspace.rs
index 4d7fc6a64..9b76461c0 100644
--- a/rust/core-lib/src/backspace.rs
+++ b/rust/core-lib/src/backspace.rs
@@ -26,7 +26,7 @@ pub fn offset_for_delete_backwards(region: &SelRegion, text: &Rope, config: &Buf
region.min()
} else {
... | [
"rust/core-lib/src/backspace.rs",
"rust/core-lib/src/client.rs",
"rust/core-lib/src/config.rs",
"rust/core-lib/src/edit_ops.rs",
"rust/core-lib/src/editor.rs",
"rust/core-lib/src/event_context.rs",
"rust/core-lib/src/find.rs",
"rust/core-lib/src/layers.rs",
"rust/core-lib/src/line_ending.rs",
"rus... | [
{
"comment": "Does this really have the same semantics? AFAIC the for loop will loop through all elements that are Some while the while loop will abort on the first element that isn’t Some",
"path": "rust/rope/src/delta.rs",
"hunk": "@@ -673,7 +673,7 @@ impl<'a, N: NodeInfo> Iterator for DeletionsIter<'... | diff --git a/rust/core-lib/tests/rpc.rs b/rust/core-lib/tests/rpc.rs
index 00a9042a3..a3b2bf326 100644
--- a/rust/core-lib/tests/rpc.rs
+++ b/rust/core-lib/tests/rpc.rs
@@ -154,16 +154,15 @@ fn test_invalidate() {
|| op["op"].as_str().unwrap() == "skip")
.next()
... | true | |
xi-editor/xi-editor | 1,318 | comment_to_fix | warnings + clippy | Does this really have the same semantics? AFAIC the for loop will loop through all elements that are Some while the while loop will abort on the first element that isn’t Some | 849c0b1d3a0918b55a92726c771e119cd4bf3c9f | b627ce6c298d76574db51827e87db50b97c2bb78 | diff --git a/rust/rope/src/delta.rs b/rust/rope/src/delta.rs
index 30ed61c8e..e3b377695 100644
--- a/rust/rope/src/delta.rs
+++ b/rust/rope/src/delta.rs
@@ -643,7 +643,7 @@ impl<'a, N: NodeInfo> Iterator for InsertsIter<'a, N> {
fn next(&mut self) -> Option<Self::Item> {
let mut result = None;
- ... | [
"rust/rope/src/delta.rs"
] | [
{
"comment": "Does this really have the same semantics? AFAIC the for loop will loop through all elements that are Some while the while loop will abort on the first element that isn’t Some",
"path": "rust/rope/src/delta.rs",
"hunk": "@@ -673,7 +673,7 @@ impl<'a, N: NodeInfo> Iterator for DeletionsIter<'... | true | ||
xi-editor/xi-editor | 1,315 | issue_to_patch | add `#![feature(stdsimd)]` to the crate attributes to enable
Hi, I can't run the test in multiset.rs on my m1 macbook pro. rustc 1.53.0-nightly (07e0e2ec2 2021-03-24)
The error show below:
error[E0... | Check arch before is_x86_feature_detected | closes #1311
| 0f946636b8fb1575364a3184821584fa0c17ca23 | bbc3ec5dab3bf214d374272e1e68b7ca5dc74106 | diff --git a/rust/rope/src/compare.rs b/rust/rope/src/compare.rs
index 36da4b990..402a68ce6 100644
--- a/rust/rope/src/compare.rs
+++ b/rust/rope/src/compare.rs
@@ -482,9 +482,13 @@ mod tests {
];
assert_eq!(ne_idx_rev_fallback(one, two), Some(1));
- if is_x86_feature_detected!("sse4.2") {
- ... | [
"rust/rope/src/compare.rs"
] | [] | true | |
xi-editor/xi-editor | 1,313 | issue_to_patch | Bump nokogiri from 1.11.1 to 1.11.4 in /docs | Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.11.1 to 1.11.4.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/sparklemotion/nokogiri/releases">nokogiri's releases</a>.</em></p>
<blockquote>
<h2>1.11.4 / 2021-05-14</h2>
<h3>Security</h3>
<p>[CRuby] Vendored... | 52bf34368e52369106d8eca6096a4839f7629e1e | e2ca2acf8603a576b9936cce9b8f4d9aba2debdb | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index 224ce4aed..2a3ad437d 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -208,14 +208,14 @@ GEM
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
mercenary (0.3.6)
- mini_portile2 (2.5.0)
+ mini_portile2 (2.5.1)
mi... | [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,312 | issue_to_patch | Bump rexml from 3.2.4 to 3.2.5 in /docs | Bumps [rexml](https://github.com/ruby/rexml) from 3.2.4 to 3.2.5.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a href="https://github.com/ruby/rexml/blob/master/NEWS.md">rexml's changelog</a>.</em></p>
<blockquote>
<h2>3.2.5 - 2021-04-05 {#version-3-2-5}</h2>
<h3>Improvements</h3>
<ul>
<li>
<p>Add more v... | 52bf34368e52369106d8eca6096a4839f7629e1e | 1890013a720c9e21d97fe34f6624e53995f01d5b | diff --git a/docs/Gemfile.lock b/docs/Gemfile.lock
index 224ce4aed..8f0a85790 100644
--- a/docs/Gemfile.lock
+++ b/docs/Gemfile.lock
@@ -232,7 +232,7 @@ GEM
rb-inotify (0.10.1)
ffi (~> 1.0)
ref (2.0.0)
- rexml (3.2.4)
+ rexml (3.2.5)
rouge (3.23.0)
ruby-enum (0.8.0)
i18n
| [
"docs/Gemfile.lock"
] | [] | true | ||
xi-editor/xi-editor | 1,314 | issue_to_patch | Clippy fixups | This also includes updating our Cargo.lock to the new format.
I was in the codebase anyway and thought I might as well clean this up. 🤷 | 616bc01425702a09b1a89977e2c18ba83a5f65b0 | 3d6474eb6d4895cb37df907c280e73dc4f6ee43b | diff --git a/rust/Cargo.lock b/rust/Cargo.lock
index 1a576137d..06e96179f 100644
--- a/rust/Cargo.lock
+++ b/rust/Cargo.lock
@@ -1,596 +1,673 @@
# This file is automatically @generated by Cargo.
# It is not intended for manual editing.
+version = 3
+
[[package]]
name = "adler32"
version = "1.0.4"
source = "regist... | [
"rust/Cargo.lock",
"rust/core-lib/src/backspace.rs",
"rust/core-lib/src/config.rs",
"rust/core-lib/src/event_context.rs",
"rust/core-lib/src/linewrap.rs",
"rust/core-lib/src/selection.rs",
"rust/core-lib/src/styles.rs",
"rust/core-lib/src/tabs.rs",
"rust/core-lib/src/view.rs",
"rust/core-lib/src/w... | [] | true | ||
xi-editor/xi-editor | 1,300 | issue_to_patch | fixed small error | <!---
Welcome to the xi-editor project! We're very excited for your contribution to become a part of the editor.
This template provides some basic instructions on how to format a pull request, so we can more easily understand it.
Anything within this commented block will not be a part of the visible text.
The fir... | 2bc11ab9dd49b4ab71244f5fa2916f13976b35d8 | c0b0bd9e56817185508cb26de2243250066c32ec | diff --git a/docs/docs/fuchsia-ledger-crdts.md b/docs/docs/fuchsia-ledger-crdts.md
index bda236cd6..1231ba29b 100644
--- a/docs/docs/fuchsia-ledger-crdts.md
+++ b/docs/docs/fuchsia-ledger-crdts.md
@@ -17,7 +17,7 @@ When you open a document that is synced with the ledger you want to do a few thi
1. Get that page and ca... | [
"docs/docs/fuchsia-ledger-crdts.md"
] | [] | true | ||
xi-editor/xi-editor | 1,293 | issue_to_patch | Expose push_subseq method on TreeBuilder | It's cleaner to have this method on TreeBuilder than Tree. It's also a
useful an important method; the general template for any incremental
algorithm is to use a TreeBuilder to assemble its result, and I think we
should encourage its use.
- [ ] I have responded to reviews and made changes where appropriate.
- [x... | 8e07fb50ba11eda17e75fb1673bb10542dc8c3a7 | 16899daeab3c2e8e87762556ea5dfb6f7202feca | diff --git a/rust/rope/src/delta.rs b/rust/rope/src/delta.rs
index a90421764..7b3260a50 100644
--- a/rust/rope/src/delta.rs
+++ b/rust/rope/src/delta.rs
@@ -138,7 +138,7 @@ impl<N: NodeInfo> Delta<N> {
let mut b = TreeBuilder::new();
for elem in &self.els {
match *elem {
- ... | [
"rust/rope/src/delta.rs",
"rust/rope/src/multiset.rs",
"rust/rope/src/tree.rs"
] | [
{
"comment": "This should be clearer about what the `iv` argument is.",
"path": "rust/rope/src/tree.rs",
"hunk": "@@ -569,6 +541,35 @@ impl<N: NodeInfo> TreeBuilder<N> {\n }\n }\n \n+ /// Push a subsequence of a rope.",
"resolving_sha": "16899daeab3c2e8e87762556ea5dfb6f7202feca",
... | true | ||
xi-editor/xi-editor | 1,307 | issue_to_patch | specify that `set_language` need syntect to work | <!---
Welcome to the xi-editor project! We're very excited for your contribution to become a part of the editor.
This template provides some basic instructions on how to format a pull request, so we can more easily understand it.
Anything within this commented block will not be a part of the visible text.
The fir... | 78c024d1635f49fbd29b3657382340f35c483b30 | f8738f5942241f1d058736cfc8e07cdde8b5e0e9 | diff --git a/docs/docs/frontend-protocol.md b/docs/docs/frontend-protocol.md
index d785fe209..d49584ae8 100644
--- a/docs/docs/frontend-protocol.md
+++ b/docs/docs/frontend-protocol.md
@@ -79,7 +79,7 @@ will receive a `theme_changed` notification.
### set_language
`set_language {"view-id":"view-id-1", "language_id":"... | [
"docs/docs/frontend-protocol.md"
] | [
{
"comment": "I assume this is a mistake?",
"path": "docs/docs/frontend-protocol.md",
"hunk": "@@ -736,7 +736,7 @@ Updates existing scope spans starting at offset `start` until offset `len`.\n \n ### update_annotations\n \n-`update_annotations {\"start\": 0, \"len\": 20, \"spans\": [{ \"start\": 0, \"en... | true | ||
xi-editor/xi-editor | 1,307 | comment_to_fix | specify that `set_language` need syntect to work | I assume this is a mistake? | 78c024d1635f49fbd29b3657382340f35c483b30 | f8738f5942241f1d058736cfc8e07cdde8b5e0e9 | diff --git a/docs/docs/frontend-protocol.md b/docs/docs/frontend-protocol.md
index d785fe209..d49584ae8 100644
--- a/docs/docs/frontend-protocol.md
+++ b/docs/docs/frontend-protocol.md
@@ -79,7 +79,7 @@ will receive a `theme_changed` notification.
### set_language
`set_language {"view-id":"view-id-1", "language_id":"... | [
"docs/docs/frontend-protocol.md"
] | [
{
"comment": "I assume this is a mistake?",
"path": "docs/docs/frontend-protocol.md",
"hunk": "@@ -736,7 +736,7 @@ Updates existing scope spans starting at offset `start` until offset `len`.\n \n ### update_annotations\n \n-`update_annotations {\"start\": 0, \"len\": 20, \"spans\": [{ \"start\": 0, \"en... | true | ||
xi-editor/xi-editor | 1,307 | comment_to_fix | specify that `set_language` need syntect to work | ```suggestion
`update_annotations {"start": 0, "len": 20, "spans": [{ "start": 0, "end": 4, "data": null }], "annotation_type": "find", "rev": 3 }`
``` | 78c024d1635f49fbd29b3657382340f35c483b30 | f8738f5942241f1d058736cfc8e07cdde8b5e0e9 | diff --git a/docs/docs/frontend-protocol.md b/docs/docs/frontend-protocol.md
index d785fe209..d49584ae8 100644
--- a/docs/docs/frontend-protocol.md
+++ b/docs/docs/frontend-protocol.md
@@ -79,7 +79,7 @@ will receive a `theme_changed` notification.
### set_language
`set_language {"view-id":"view-id-1", "language_id":"... | [
"docs/docs/frontend-protocol.md"
] | [
{
"comment": "```suggestion\r\n`update_annotations {\"start\": 0, \"len\": 20, \"spans\": [{ \"start\": 0, \"end\": 4, \"data\": null }], \"annotation_type\": \"find\", \"rev\": 3 }`\r\n```",
"path": "docs/docs/frontend-protocol.md",
"hunk": "@@ -736,7 +736,7 @@ Updates existing scope spans starting at ... | true | ||
xi-editor/xi-editor | 1,309 | issue_to_patch | Mention maintenance status in readme | I feel like it's worth including something like this in the readme, at this point. | 78c024d1635f49fbd29b3657382340f35c483b30 | 27d925afce5db50a7b679857d3ab534ef5a174b1 | diff --git a/README.md b/README.md
index 5f8237937..9b3f32d34 100644
--- a/README.md
+++ b/README.md
@@ -7,6 +7,12 @@
<h4 align="center">A modern editor with a backend written in Rust.</h4>
+***Maintenance status:*** *The xi-editor project is not currently under active
+development. Although we will happily accept... | [
"README.md"
] | [] | true | ||
xi-editor/xi-editor | 1,302 | issue_to_patch | Frontend protocol: why cursor updates are bundled with text updates?
Hi,
I think I probably found a behavioral issue in the frontend protocol.
The question is, why does the protocol bundle the cursor updates with text updates?
For instance, here are the notifications sent by xi-core when I move the cursor down ... | Implement UpdateOp::update and fix line invalidation in the middle of the cache | ## Summary
This change introduces a new UpdateOp, "update", in addition to "copy", "insert", "invalidate" and "skip".
This UpdateOp was outlined in the design docs before me but was never actually implemented.
UpdateOp::update will be sent by View::send_update_for_plan() in case of an update of a line cache shad... | 2bc11ab9dd49b4ab71244f5fa2916f13976b35d8 | 742e5ad208126cf269385166f680e06b61e1d447 | diff --git a/docs/docs/frontend-protocol.md b/docs/docs/frontend-protocol.md
index 74c059844..d785fe209 100644
--- a/docs/docs/frontend-protocol.md
+++ b/docs/docs/frontend-protocol.md
@@ -553,9 +553,10 @@ in more detail below. For this op, `n` must equal `lines.length` (alternative:
make n optional in this case). It ... | [
"docs/docs/frontend-protocol.md",
"rust/Cargo.lock",
"rust/Cargo.toml",
"rust/core-lib/Cargo.toml",
"rust/core-lib/src/client.rs",
"rust/core-lib/src/core.rs",
"rust/core-lib/src/plugins/manifest.rs",
"rust/core-lib/src/syntax.rs",
"rust/core-lib/src/view.rs",
"rust/core-lib/tests/rpc.rs",
"rust... | [
{
"comment": "Have you talked about these two with @cmyr or @raphlinus ? I have to admit I don't know the inner workings of xi too well, so not sure if this doesn't have unintended effects",
"path": "rust/core-lib/src/view.rs",
"hunk": "@@ -612,28 +612,40 @@ impl View {\n !self.selection.regions... | diff --git a/rust/core-lib/tests/rpc.rs b/rust/core-lib/tests/rpc.rs
index 29c9a989e..00a9042a3 100644
--- a/rust/core-lib/tests/rpc.rs
+++ b/rust/core-lib/tests/rpc.rs
@@ -92,6 +92,97 @@ fn test_state() {
}
}
+/// Test whether xi-core invalidates cache lines upon a cursor motion.
+#[test]
+fn test_invalidate()... | true |
xi-editor/xi-editor | 1,302 | comment_to_fix | Implement UpdateOp::update and fix line invalidation in the middle of the cache | Have you talked about these two with @cmyr or @raphlinus ? I have to admit I don't know the inner workings of xi too well, so not sure if this doesn't have unintended effects | 2bc11ab9dd49b4ab71244f5fa2916f13976b35d8 | 742e5ad208126cf269385166f680e06b61e1d447 | diff --git a/rust/core-lib/src/view.rs b/rust/core-lib/src/view.rs
index 33d6cf9cf..24283d2d9 100644
--- a/rust/core-lib/src/view.rs
+++ b/rust/core-lib/src/view.rs
@@ -612,28 +612,30 @@ impl View {
!self.selection.regions_in_range(offset, offset).is_empty()
}
- // Render a single line, and advance c... | [
"rust/core-lib/src/view.rs"
] | [
{
"comment": "Have you talked about these two with @cmyr or @raphlinus ? I have to admit I don't know the inner workings of xi too well, so not sure if this doesn't have unintended effects",
"path": "rust/core-lib/src/view.rs",
"hunk": "@@ -612,28 +612,40 @@ impl View {\n !self.selection.regions... | true | ||
xi-editor/xi-editor | 1,302 | comment_to_fix | Implement UpdateOp::update and fix line invalidation in the middle of the cache | Untested, but imho something like this would be nicer than having the temporary variable `l_str`:
```suggestion
if let Some(text) = text.map(|s| s.slice_to_cow(start_pos..pos)) {
result["text"] = json!(&text);
}
``` | 2bc11ab9dd49b4ab71244f5fa2916f13976b35d8 | 742e5ad208126cf269385166f680e06b61e1d447 | diff --git a/rust/core-lib/src/view.rs b/rust/core-lib/src/view.rs
index 33d6cf9cf..24283d2d9 100644
--- a/rust/core-lib/src/view.rs
+++ b/rust/core-lib/src/view.rs
@@ -612,28 +612,30 @@ impl View {
!self.selection.regions_in_range(offset, offset).is_empty()
}
- // Render a single line, and advance c... | [
"rust/core-lib/src/view.rs"
] | [
{
"comment": "Untested, but imho something like this would be nicer than having the temporary variable `l_str`:\r\n\r\n```suggestion\r\n if let Some(text) = text.map(|s| s.slice_to_cow(start_pos..pos)) {\r\n result[\"text\"] = json!(&text);\r\n }\r\n```",
"path": "rust/core-lib/src/... | true | ||
xi-editor/xi-editor | 1,302 | comment_to_fix | Implement UpdateOp::update and fix line invalidation in the middle of the cache | Isn't this the sme as on line 827? Could we factor this out into a seperate function or similiar so we don't have the same code twice? | 2bc11ab9dd49b4ab71244f5fa2916f13976b35d8 | 742e5ad208126cf269385166f680e06b61e1d447 | diff --git a/rust/core-lib/src/view.rs b/rust/core-lib/src/view.rs
index 33d6cf9cf..24283d2d9 100644
--- a/rust/core-lib/src/view.rs
+++ b/rust/core-lib/src/view.rs
@@ -612,28 +612,30 @@ impl View {
!self.selection.regions_in_range(offset, offset).is_empty()
}
- // Render a single line, and advance c... | [
"rust/core-lib/src/view.rs"
] | [
{
"comment": "Isn't this the sme as on line 827? Could we factor this out into a seperate function or similiar so we don't have the same code twice?",
"path": "rust/core-lib/src/view.rs",
"hunk": "@@ -790,51 +805,112 @@ impl View {\n b.add_span(seg.n, 0, 0);\n }\n ... | true | ||
xi-editor/xi-editor | 1,302 | comment_to_fix | Implement UpdateOp::update and fix line invalidation in the middle of the cache | Ah, just one more thing: Do you plan to do additional changes? If so, it might be worth it to delay 0.4 until after you made those. | 2bc11ab9dd49b4ab71244f5fa2916f13976b35d8 | 742e5ad208126cf269385166f680e06b61e1d447 | diff --git a/rust/core-lib/Cargo.toml b/rust/core-lib/Cargo.toml
index 0d4e2213a..b5ad9577e 100644
--- a/rust/core-lib/Cargo.toml
+++ b/rust/core-lib/Cargo.toml
@@ -1,6 +1,6 @@
[package]
name = "xi-core-lib"
-version = "0.3.0"
+version = "0.4.0"
license = "Apache-2.0"
authors = ["Raph Levien <raph@google.com>"]
de... | [
"rust/core-lib/Cargo.toml"
] | [
{
"comment": "Ah, just one more thing: Do you plan to do additional changes? If so, it might be worth it to delay 0.4 until after you made those.",
"path": "rust/core-lib/Cargo.toml",
"hunk": "@@ -1,6 +1,6 @@\n [package]\n name = \"xi-core-lib\"\n-version = \"0.3.0\"\n+version = \"0.4.0\"",
"resolvi... | true | ||
xi-editor/xi-editor | 1,291 | issue_to_patch | xi-unicode: detecting break at end of string
`xi_unicode::LineBreakIterator` always reports a hard-break at the end of its input. Fine, but I need to know (for `kas-text`; also affects @alexheretic's `glyph-brush-layout`) whether my document ends with an explicit line-break or not. Is there a clean way to do this?
... | [xi-unicode] Explicit breaks at end of text | Instead of always indicating end of text as a hard break, report whether
the text ends with an explicit line break.
Document the behavior.
Document the line break properties, and also make the ordering
consistent with ICU.
This is a breaking change but hopefully should be useful and not cause
too much troub... | 1c95252fa39e225dcfa4fd93b04111921d1ccf0d | 3ef7a8634e0f59ca8d41130be285800e6bec8a16 | diff --git a/rust/Cargo.lock b/rust/Cargo.lock
index 95e45d650..751092171 100644
--- a/rust/Cargo.lock
+++ b/rust/Cargo.lock
@@ -1208,7 +1208,7 @@ dependencies = [
"xi-rope 0.3.0",
"xi-rpc 0.3.0",
"xi-trace 0.2.0",
- "xi-unicode 0.2.0",
+ "xi-unicode 0.3.0",
]
[[package]]
@@ -1330,7 +1330,7 @@ dependencies = ... | [
"rust/Cargo.lock",
"rust/core-lib/Cargo.toml",
"rust/unicode/Cargo.toml",
"rust/unicode/src/lib.rs",
"rust/unicode/src/tables.rs",
"rust/unicode/tools/mk_tables.py"
] | [
{
"comment": "Is it worth having an actual enum for this? could be `#[repr(u8)]`.",
"path": "rust/unicode/src/lib.rs",
"hunk": "@@ -23,6 +23,10 @@ use core::cmp::Ordering;\n \n use crate::tables::*;\n \n+/// The Unicode line breaking property of the given code point.\n+///\n+/// This is given as a numer... | true | |
xi-editor/xi-editor | 1,295 | issue_to_patch | More base cases in rope diffing. | Extracted from #1284, this patch allows the rope diffing algorithm to finish early in more situations.
Includes a bechmark:
```
Before patch:
test simple_insertion ... bench: 208,509 ns/iter (+/- 21,198)
test simple_deletion ... bench: 185,520 ns/iter (+/- 23,425)
After patch:
test simple_insertion ..... | 8e07fb50ba11eda17e75fb1673bb10542dc8c3a7 | abf80d710d834ed75b4c7afa517df7c0509a79d0 | diff --git a/rust/rope/benches/diff.rs b/rust/rope/benches/diff.rs
index acd764280..3de43c745 100644
--- a/rust/rope/benches/diff.rs
+++ b/rust/rope/benches/diff.rs
@@ -170,3 +170,31 @@ fn hash_diff_big(b: &mut Bencher) {
let _result = delta.unwrap().apply(&one);
assert_eq!(String::from(_result), String::from... | [
"rust/rope/benches/diff.rs",
"rust/rope/src/diff.rs"
] | [] | true | ||
xi-editor/xi-editor | 1,292 | issue_to_patch | [rope] Faster tree builder | This patch is a rewrite of the TreeBuilder to be more aggressive in maintaining a stack of partially-built trees rather than basically delegating everything to a pairwise concat. In some cases (benchmarks to follow in a comment) the performance is significantly improved. I should note there are minor performance regres... | 1cf944e67082252971dd6b138bee64cae925af40 | 6f1b76f3f747bc8496013a3358374c3954822381 | diff --git a/rust/rope/src/rope.rs b/rust/rope/src/rope.rs
index 3819e2d18..b678bb1b1 100644
--- a/rust/rope/src/rope.rs
+++ b/rust/rope/src/rope.rs
@@ -578,7 +578,8 @@ impl TreeBuilder<RopeInfo> {
/// Push a string on the accumulating tree in the naive way.
///
/// Splits the provided string in chunks t... | [
"rust/rope/src/rope.rs",
"rust/rope/src/tree.rs"
] | [
{
"comment": "I might find this cleaner as a map + unwrap_or? but ymmv, this works fine.",
"path": "rust/rope/src/tree.rs",
"hunk": "@@ -472,71 +497,118 @@ impl<N: NodeInfo> Default for Node<N> {\n }\n }\n \n-pub struct TreeBuilder<N: NodeInfo>(Option<Node<N>>);\n+/// A builder for creating new tree... | true | ||
xi-editor/xi-editor | 1,286 | issue_to_patch | Bump minimum rust version in readme | This change follows https://github.com/xi-editor/xi-editor/commit/44152e50778624af5e51f83b19369f0fc058780a | bf9f67f7f90a5c8ae5e60b14ef489fa92ede138c | dbd478e232fb77c40dbbc38030dac1921ad219fe | diff --git a/README.md b/README.md
index 725df4f1e..5f8237937 100644
--- a/README.md
+++ b/README.md
@@ -46,7 +46,7 @@ below.
### Building the core
Xi-editor targets 'recent stable Rust'. We recommend installing via [rustup](https://www.rustup.rs).
-The current minimum supported version is 1.31.
+The current minimu... | [
"README.md"
] | [] | true | ||
xi-editor/xi-editor | 1,283 | issue_to_patch | Xi-syntect panicking in background but no client crash
Im consistently able to recreate this issue but only with a huge file with ~110K lines. To recreate the issue:
- Open the file and select all.
- Hit backspace to empty the file.
- Save the file.
If you look at the log file you see stacktrace similar to
... | Stay within cache boundaries in `base_cache.rs`. | When recieving a delta, the plugin library would sometimes try to adjust its cache so it doesn't have to be discarded.
It does this without properly checking the delta's bounds, resulting in a panic like in #1136.
This PR fixes this and thus fixes #1136 .
- [x] I have responded to reviews and made changes where ap... | bf9f67f7f90a5c8ae5e60b14ef489fa92ede138c | 2ba2766273f733c67eee820da0d424fe7fdc1e97 | diff --git a/rust/plugin-lib/src/base_cache.rs b/rust/plugin-lib/src/base_cache.rs
index 3f948476a..ba421252c 100644
--- a/rust/plugin-lib/src/base_cache.rs
+++ b/rust/plugin-lib/src/base_cache.rs
@@ -333,6 +333,9 @@ impl ChunkCache {
if start < self.offset || start > self.offset + self.contents.len() {
... | [
"rust/plugin-lib/src/base_cache.rs"
] | [
{
"comment": "```suggestion\r\n let end = end.min(self.offset + self.contents.len());\r\n self.simple_delete(start, end);\r\n```",
"path": "rust/plugin-lib/src/base_cache.rs",
"hunk": "@@ -333,7 +333,7 @@ impl ChunkCache {\n if start < self.offset || start > self.offset + s... | true | |
xi-editor/xi-editor | 1,282 | issue_to_patch | Fix is_identity | There was a second case in which applying a delta would not result in any change: deleting everyting while the rope is empty.
- [x] I have responded to reviews and made changes where appropriate.
- [x] I have tested the code with `cargo test --all` / `./rust/run_all_checks`.
- [x] I have updated comments / documen... | 32d7878ef3c5460bf4d6202347160be525da6448 | 84c67d654cbbffbe1edf00a77ceabbeb8554783f | diff --git a/rust/rope/src/delta.rs b/rust/rope/src/delta.rs
index 465b5b085..0ee75981e 100644
--- a/rust/rope/src/delta.rs
+++ b/rust/rope/src/delta.rs
@@ -116,13 +116,16 @@ impl<N: NodeInfo> Delta<N> {
/// Returns `true` if applying the delta will cause no change.
pub fn is_identity(&self) -> bool {
- ... | [
"rust/rope/src/delta.rs"
] | [] | true | ||
xi-editor/xi-editor | 1,280 | issue_to_patch | Fix panic in is_simple_delete | In `is_simple_delete`, it is possible that `els.is_empty()` is true while `self.base_len > 0` is false - it can occur when the buffer is empty and the user tries to delete something.
In that case the statement in the `if let` below will then try to access a nonexisting element, causing a panic.
This PR fixes this.
... | 72528844374bc901f9b6e00dede15993c305b7bd | 5d7c92a54a68c30b768305926ac194219f36ee85 | diff --git a/rust/rope/src/delta.rs b/rust/rope/src/delta.rs
index 465b5b085..42f526c6b 100644
--- a/rust/rope/src/delta.rs
+++ b/rust/rope/src/delta.rs
@@ -89,10 +89,13 @@ impl<N: NodeInfo> Delta<N> {
}
/// Returns `true` if this delta represents a single deletion without
- /// any insertions. Note that... | [
"rust/rope/src/delta.rs"
] | [
{
"comment": "```suggestion\r\n /// Returns `true` if this delta represents a single deletion without\r\n /// any insertions.\r\n ///\r\n /// Note that this is `false` for the trivial delta, as well as for a deletion\r\n /// from an empty `Rope`.\r\n```",
"path": "rust/rope/src/delta.rs",
... | true | ||
xi-editor/xi-editor | 1,280 | comment_to_fix | Fix panic in is_simple_delete | ```suggestion
/// Returns `true` if this delta represents a single deletion without
/// any insertions.
///
/// Note that this is `false` for the trivial delta, as well as for a deletion
/// from an empty `Rope`.
``` | 72528844374bc901f9b6e00dede15993c305b7bd | 5d7c92a54a68c30b768305926ac194219f36ee85 | diff --git a/rust/rope/src/delta.rs b/rust/rope/src/delta.rs
index 465b5b085..42f526c6b 100644
--- a/rust/rope/src/delta.rs
+++ b/rust/rope/src/delta.rs
@@ -89,10 +89,13 @@ impl<N: NodeInfo> Delta<N> {
}
/// Returns `true` if this delta represents a single deletion without
- /// any insertions. Note that... | [
"rust/rope/src/delta.rs"
] | [
{
"comment": "```suggestion\r\n /// Returns `true` if this delta represents a single deletion without\r\n /// any insertions.\r\n ///\r\n /// Note that this is `false` for the trivial delta, as well as for a deletion\r\n /// from an empty `Rope`.\r\n```",
"path": "rust/rope/src/delta.rs",
... | true | ||
xi-editor/xi-editor | 1,281 | issue_to_patch | Fix panics in `do_insert_tab` | This PR resolves some regressions introduced in PR #1263.
- [ ] I have responded to reviews and made changes where appropriate.
- [x] I have tested the code with `cargo test --all` / `./rust/run_all_checks`.
- [x] I have updated comments / documentation related to the changes I made.
- [ ] I have rebased my PR br... | 9743487c92ceea53771fba9435f4274d29e0d457 | 6b1f45a8bcb18f490008c99810d8493146148b96 | diff --git a/rust/core-lib/src/editor.rs b/rust/core-lib/src/editor.rs
index fc31299bf..26e4bdb47 100644
--- a/rust/core-lib/src/editor.rs
+++ b/rust/core-lib/src/editor.rs
@@ -31,7 +31,7 @@ use crate::edit_ops::{self, IndentDirection};
use crate::edit_types::BufferEvent;
use crate::event_context::MAX_SIZE_LIMIT;
us... | [
"rust/core-lib/src/editor.rs",
"rust/core-lib/src/event_context.rs"
] | [] | true | ||
xi-editor/xi-editor | 1,279 | issue_to_patch | clippy nits | See above.
- [ ] I have responded to reviews and made changes where appropriate.
- [x] I have tested the code with `cargo test --all` / `./rust/run_all_checks`.
- [x] I have updated comments / documentation related to the changes I made.
- [x] I have rebased my PR branch onto xi-editor/master.
| 9743487c92ceea53771fba9435f4274d29e0d457 | 8694517f48c0de3d32123678de5a78aeafc9eec2 | diff --git a/rust/core-lib/src/recorder.rs b/rust/core-lib/src/recorder.rs
index 5c955d4fa..3afffd497 100644
--- a/rust/core-lib/src/recorder.rs
+++ b/rust/core-lib/src/recorder.rs
@@ -109,7 +109,7 @@ impl Recorder {
/// on each event.
pub(crate) fn play<F>(&self, recording_name: &str, action: F)
where
-... | [
"rust/core-lib/src/recorder.rs"
] | [] | true | ||
xi-editor/xi-editor | 1,238 | issue_to_patch | Copy lines when updating annotations | This PR attempts to fix the issue described in https://github.com/xi-editor/xi-editor/pull/1236#issuecomment-545373431
@c4eater
## Review Checklist
<!---
Here is a list of the things everyone should make sure they do before they want their PR to be merged.
--->
- [ ] I have responded to reviews and made chan... | a58509934eeab8dc10a0ccf8b68b6d10c78a856c | b0e1671d853488f259c1ee7b3f28407d99143dba | diff --git a/rust/core-lib/src/view.rs b/rust/core-lib/src/view.rs
index e4675bca3..2c1460083 100644
--- a/rust/core-lib/src/view.rs
+++ b/rust/core-lib/src/view.rs
@@ -750,7 +750,9 @@ impl View {
.collect::<Vec<_>>();
if !self.lc_shadow.needs_render(plan) {
- let update = Update { op... | [
"rust/core-lib/src/view.rs"
] | [] | true | ||
xi-editor/xi-editor | 1,277 | issue_to_patch | Can xi-unicode be published with a new version? | I made the `no_std` PR back in March and I would like to use `xi-unicode` it from crates.io with that :3. Could a maintainer increment the version and mark a release onto crates?
| 44152e50778624af5e51f83b19369f0fc058780a | f377281238e224cc97f0c8eacc80fe68efcdfa2a | diff --git a/rust/unicode/Cargo.toml b/rust/unicode/Cargo.toml
index aaeb4c5cf..137e30ca2 100644
--- a/rust/unicode/Cargo.toml
+++ b/rust/unicode/Cargo.toml
@@ -1,6 +1,6 @@
[package]
name = "xi-unicode"
-version = "0.2.0"
+version = "0.2.1"
license = "Apache-2.0"
authors = ["Raph Levien <raph@google.com>"]
reposit... | [
"rust/unicode/Cargo.toml"
] | [] | true | ||
xi-editor/xi-editor | 1,274 | issue_to_patch | Minimum rust version
I had rust(c) version 1.36.0, and got this error with `cargo build`:
```
Compiling bincode v1.2.1
Compiling toml v0.5.6
Compiling xi-rope v0.3.0 (/home/hoijui/src/xi-editor/rust/rope)
error[E0425]: cannot find function `take` in module `mem`
--> rope/src/breaks.rs:228:29
|... | declare minimum rust version as 1.40.0 (for `mem::take`) | In practice, this has little effect,
as this setting is only supported in the latest cargo versions anyway,
so users with an outdated rust setup
will still not get a nice error message.
It does not hurt though,
and maybe they stumble over it in the config file.
closes #1273
| 72ce488f0c17462dc4b5637648120076fa5cc6fb | 1a8bee910066ba8dca6dcfd3132e614f3b2be2e3 | diff --git a/rust/Cargo.toml b/rust/Cargo.toml
index 528e4b252..bc5b5d9e4 100644
--- a/rust/Cargo.toml
+++ b/rust/Cargo.toml
@@ -7,6 +7,7 @@ description = "Main process for xi-core, based on json-rpc"
categories = ["text-editors"]
repository = "https://github.com/xi-editor/xi-editor"
edition = '2018'
+rust = "1.40"
... | [
"rust/Cargo.toml"
] | [] | true | |
xi-editor/xi-editor | 1,270 | issue_to_patch | chore(deps): update | add9e3e2f74c1324e85d1e2208f361b435b3fe2f | d4713be25797d7310cf807568f3a191b1b90a592 | diff --git a/rust/Cargo.lock b/rust/Cargo.lock
index 7fec64de6..95e45d650 100644
--- a/rust/Cargo.lock
+++ b/rust/Cargo.lock
@@ -7,10 +7,10 @@ source = "registry+https://github.com/rust-lang/crates.io-index"
[[package]]
name = "aho-corasick"
-version = "0.7.6"
+version = "0.7.10"
source = "registry+https://github.... | [
"rust/Cargo.lock",
"rust/Cargo.toml"
] | [] | true | |||
xi-editor/xi-editor | 1,263 | issue_to_patch | Add an edit_ops.rs file | ## Summary
This PR does the following:
* It moves central editing operation away from editor.rs, closing #1199.
* Said operations no longer require a `View` to operate, but take a `&[SelRegion]` instead.
* This will help with #1198, as someone working with raw selections no
longer has to construct a `View... | 65911d91eb1dcc3dac5b94ace31fad8058011526 | d3395c879380381bc082442dd39f4b52270b314d | diff --git a/rust/core-lib/src/backspace.rs b/rust/core-lib/src/backspace.rs
index c3e643fea..79dc391ea 100644
--- a/rust/core-lib/src/backspace.rs
+++ b/rust/core-lib/src/backspace.rs
@@ -16,23 +16,17 @@
use xi_rope::{Cursor, Rope};
use crate::config::BufferItems;
-use crate::line_offset::LineOffset;
+use crate::l... | [
"rust/core-lib/src/backspace.rs",
"rust/core-lib/src/edit_ops.rs",
"rust/core-lib/src/editor.rs",
"rust/core-lib/src/lib.rs",
"rust/core-lib/src/line_offset.rs",
"rust/core-lib/src/tabs.rs",
"rust/core-lib/src/view.rs",
"rust/lsp-lib/src/lsp_plugin.rs",
"rust/rope/src/delta.rs",
"rust/trace/src/li... | [
{
"comment": "`visual` is an important distinction, here; it indicates a distinction from 'logical' lines, which are just lines that end in a newline character. a 'visual' line may not end in a line break, and may be the result of word wrap.\r\n\r\nI guess this whole comment is slightly out of date, having been... | true | ||
xi-editor/xi-editor | 1,263 | comment_to_fix | Add an edit_ops.rs file | what's the rationale for this? I'd prefer to fix whatever the problem was. | 65911d91eb1dcc3dac5b94ace31fad8058011526 | d3395c879380381bc082442dd39f4b52270b314d | diff --git a/rust/core-lib/src/tabs.rs b/rust/core-lib/src/tabs.rs
index 2220831b1..85bed501f 100644
--- a/rust/core-lib/src/tabs.rs
+++ b/rust/core-lib/src/tabs.rs
@@ -816,7 +816,7 @@ impl CoreState {
.iter()
.map(|plugin| ClientPluginInfo { name: plugin.name.clone(), running: true })... | [
"rust/core-lib/src/tabs.rs"
] | [
{
"comment": "what's the rationale for this? I'd prefer to fix whatever the problem was.",
"path": "rust/core-lib/src/tabs.rs",
"hunk": "@@ -19,6 +19,8 @@\n //! This file is called 'tabs' for historical reasons, and should probably\n //! be renamed.\n \n+#![allow(clippy::clone_on_copy)]",
"resolving... | true | ||
xi-editor/xi-editor | 1,263 | comment_to_fix | Add an edit_ops.rs file | again I would prefer us to fix the lint rather than allow it, unless there's a good reason not to. | 65911d91eb1dcc3dac5b94ace31fad8058011526 | d3395c879380381bc082442dd39f4b52270b314d | diff --git a/rust/core-lib/src/line_offset.rs b/rust/core-lib/src/line_offset.rs
index 568b909ec..1a3d1ee37 100644
--- a/rust/core-lib/src/line_offset.rs
+++ b/rust/core-lib/src/line_offset.rs
@@ -12,15 +12,21 @@
// See the License for the specific language governing permissions and
// limitations under the License.
... | [
"rust/core-lib/src/line_offset.rs"
] | [
{
"comment": "again I would prefer us to fix the lint rather than allow it, unless there's a good reason not to.",
"path": "rust/core-lib/src/line_offset.rs",
"hunk": "@@ -12,15 +12,21 @@\n // See the License for the specific language governing permissions and\n // limitations under the License.\n \n-us... | true | ||
xi-editor/xi-editor | 1,267 | issue_to_patch | multi selection polish
pulling out some todos from #188.
- [x] Copy-paste of multiple lines into an equal number of cursors should paste one line per cursor. Current behavior is to paste all lines (separated by newline) into all cursors
- [x] Transpose (^T) should rotate the contents of selection (non-caret) reg... | Merging selections now preserves the direction of the most recent | <!---
Welcome to the xi-editor project! We're very excited for your contribution to become a part of the editor.
This template provides some basic instructions on how to format a pull request, so we can more easily understand it.
Anything within this commented block will not be a part of the visible text.
The fir... | 2d117bc40c004c24edb82ffe36e93ad2367a0d70 | c8de822b4583579a7f804a32876271fad6d60919 | diff --git a/rust/core-lib/src/selection.rs b/rust/core-lib/src/selection.rs
index d706853a5..acde5660b 100644
--- a/rust/core-lib/src/selection.rs
+++ b/rust/core-lib/src/selection.rs
@@ -103,7 +103,7 @@ impl Selection {
let mut end_ix = ix;
if self.regions[ix].min() <= region.min() {
if... | [
"rust/core-lib/src/selection.rs"
] | [] | true | |
xi-editor/xi-editor | 1,266 | issue_to_patch | Add Tree::ptr_eq, for use by druid | This is a fairly cheap way of letting druid use xi-rope without being particularly fancy. | d126753c6675fc834330df9ff39f00b17bf94fc7 | 933ff5bc071e15f92b634929bd13600d53e24485 | diff --git a/rust/rope/src/tree.rs b/rust/rope/src/tree.rs
index be3fcabee..05eb2f398 100644
--- a/rust/rope/src/tree.rs
+++ b/rust/rope/src/tree.rs
@@ -221,6 +221,14 @@ impl<N: NodeInfo> Node<N> {
self.len() == 0
}
+ /// Returns `true` if these two `Node`s share the same underlying data.
+ ///
+ ... | [
"rust/rope/src/tree.rs"
] | [] | true | ||
xi-editor/xi-editor | 1,264 | issue_to_patch | New rust fixups | hopefully getting CI to pass again? 🤞 | 4f93edbbd924e6da0a347299fcbada66a24f23d1 | b6e394917123e35f58fe4b7f2d89323ccddba901 | diff --git a/rust/Cargo.toml b/rust/Cargo.toml
index 5e754ce94..ff7f2bc89 100644
--- a/rust/Cargo.toml
+++ b/rust/Cargo.toml
@@ -36,9 +36,6 @@ members = [
"unicode",
]
-[profile.bench]
-lto = true
-
# Avoid libllvm/libclang dep. See https://github.com/rust-onig/rust-onig/pull/108
[patch.crates-io]
onig = { git... | [
"rust/Cargo.toml",
"rust/core-lib/src/config.rs",
"rust/core-lib/src/core.rs",
"rust/core-lib/src/plugins/catalog.rs",
"rust/core-lib/src/plugins/mod.rs",
"rust/core-lib/src/recorder.rs",
"rust/core-lib/src/width_cache.rs",
"rust/lsp-lib/src/language_server_client.rs",
"rust/lsp-lib/src/lsp_plugin.r... | [] | true | ||
xi-editor/xi-editor | 1,261 | issue_to_patch | document 'View' |
- [ ] I have responded to reviews and made changes where appropriate.
- [x] I have tested the code with `cargo test --all` / `./rust/run_all_checks`.
- [x] I have updated comments / documentation related to the changes I made.
- [x] I have rebased my PR branch onto xi-editor/master.
| 9afd0acefc76ce649b432fa06df0f101775e535f | 9f3c2e1004edb582267d77dfb3ec0238e590de0a | diff --git a/rust/.gitignore b/rust/.gitignore
index d27a61b45..2bc308017 100644
--- a/rust/.gitignore
+++ b/rust/.gitignore
@@ -7,3 +7,4 @@ build
# Editor configs
.idea/
+.vscode/
diff --git a/rust/core-lib/src/view.rs b/rust/core-lib/src/view.rs
index ee5149464..7870f6dc3 100644
--- a/rust/core-lib/src/view.rs
++... | [
"rust/.gitignore",
"rust/core-lib/src/view.rs"
] | [] | true | ||
xkcoding/spring-boot-demo | 232 | issue_to_patch | :memo: remove ad | Remove unpaid ads | 83eba991517b9850465ebcd84d2da8f827419f89 | b40293fd259ecb25433bfab2a670409b7afa3e9b | diff --git a/README.md b/README.md
index b0204d145..f65c7e4b1 100644
--- a/README.md
+++ b/README.md
@@ -56,10 +56,6 @@
## 其他
-### 团队纳新
-
-组内招人啦，HC 巨多，Base 杭州，感兴趣的小伙伴，查看 [岗位详情](./jd.md)
-
### 开源推荐
![11628591293_.pic_hd](https://static.aliyun.xkcoding.com/2021/08/14/11628591293pichd.jpg?x-oss-process=style/tag... | [
"README.md"
] | [] | true | ||
xkcoding/spring-boot-demo | 182 | issue_to_patch | Update README | 修改文案 + 错别字。
| 5c3fb220a584a95f5ca663912dfc2cca5a87d7ec | 90daebd32fccade2597b6589cf8c931c8162bc6a | diff --git a/README.md b/README.md
index 2d9b99a36..65c43b815 100644
--- a/README.md
+++ b/README.md
@@ -47,7 +47,7 @@
3. 在 IDEA 中 Maven Projects 的面板导入项目根目录下 的 `pom.xml` 文件
4. Maven Projects 找不到的童鞋，可以勾上 IDEA 顶部工具栏的 View -> Tool Buttons ，然后 Maven Projects 的面板就会出现在 IDEA 的右侧
5. 找到各个 Module 的 Application 类就可以运行各个 demo 了... | [
"README.md"
] | [] | true | ||
xkcoding/spring-boot-demo | 177 | issue_to_patch | 新增nacos整合SpringBootDemo
### 你在什么场景下需要该功能？
服务注册，配置管理 | SpringBoot整合nacos案例 | SpringBoot整合nacos案例，使用场景：服务注册，发现，配置管理等。 | dc519fbc1d8acbfae3c10aab7b130c231d7d0ff7 | 7a1013302c1ff502f48cdee4574f12a06294cfbc | diff --git a/demo-nacos/pom.xml b/demo-nacos/pom.xml
new file mode 100644
index 000000000..4711ffaa0
--- /dev/null
+++ b/demo-nacos/pom.xml
@@ -0,0 +1,57 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ ... | [
"demo-nacos/pom.xml",
"demo-nacos/src/main/java/com/xkcoding/nacos/SpringBootDemoNacosApplication.java",
"demo-nacos/src/main/java/com/xkcoding/nacos/config/ConfigController.java",
"demo-nacos/src/main/java/com/xkcoding/nacos/discover/DiscoveryController.java",
"demo-nacos/src/main/resources/application.pro... | [
{
"comment": "这个 module 需要去掉一下哦~",
"path": "pom.xml",
"hunk": "@@ -70,6 +70,8 @@\n <module>demo-https</module>\n <module>demo-flyway</module>\n <module>demo-pay</module>\n+ <module>self-email</module>",
"resolving_sha": "7a1013302c1ff502f48cdee4574f12a06294cfbc",
"resolving_diff":... | true | |
xkcoding/spring-boot-demo | 177 | comment_to_fix | SpringBoot整合nacos案例 | 这个 module 需要去掉一下哦~ | dc519fbc1d8acbfae3c10aab7b130c231d7d0ff7 | 7a1013302c1ff502f48cdee4574f12a06294cfbc | diff --git a/pom.xml b/pom.xml
index 0110e6452..e8cc2bdcc 100644
--- a/pom.xml
+++ b/pom.xml
@@ -70,6 +70,7 @@
<module>demo-https</module>
<module>demo-flyway</module>
<module>demo-pay</module>
+ <module>demo-nacos</module>
</modules>
<packaging>pom</packaging>
@@ -87,6 +88,7 @@
<hutool.v... | [
"pom.xml"
] | [
{
"comment": "这个 module 需要去掉一下哦~",
"path": "pom.xml",
"hunk": "@@ -70,6 +70,8 @@\n <module>demo-https</module>\n <module>demo-flyway</module>\n <module>demo-pay</module>\n+ <module>self-email</module>",
"resolving_sha": "7a1013302c1ff502f48cdee4574f12a06294cfbc",
"resolving_diff":... | true | ||
xkcoding/spring-boot-demo | 170 | issue_to_patch | [FEATURE] 完善日志切面功能 | * `issue`[[FEATURE] 完善日志切面功能](https://github.com/xkcoding/spring-boot-demo/issues/167)
* 新增日志打印json参数
* 多线程情况下封装日志参数打印 | 3547f84d046b105e5b034aab9c64eb4e437edcb2 | d8935e6969c1d7886f0bcf9f082058d21f5d5754 | diff --git a/demo-log-aop/README.md b/demo-log-aop/README.md
index 526a7da29..14fea8048 100644
--- a/demo-log-aop/README.md
+++ b/demo-log-aop/README.md
@@ -30,6 +30,11 @@
</properties>
<dependencies>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId... | [
"demo-log-aop/README.md",
"demo-log-aop/pom.xml",
"demo-log-aop/src/main/java/com/xkcoding/log/aop/aspectj/AopLog.java",
"demo-log-aop/src/main/java/com/xkcoding/log/aop/controller/TestController.java"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.