repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
xkcoding/spring-boot-demo
149
issue_to_patch
feat: edit spring-boot-demo-helloworld Readme.md
* PR 修复缺陷请先开 `issue` **[报告缺陷](https://github.com/xkcoding/spring-boot-demo/issues/new?template=bug_report.md)** * PR 提交新特性请先开 `issue` **[报告新特性](https://github.com/xkcoding/spring-boot-demo/issues/new?template=feature_request.md)** * PR 请提交到 `dev` 开发分支上 * 我们对编码风格有着较为严格的要求,请在阅读代码后模仿类似风格提交 * 欢迎通过 PR 给我们补充案例
9b9a24d7dcc37dbfc97cd845ab35409ec8b3c347
bba23dc26697a563d07d22a3727ad62473f2ffd3
diff --git a/spring-boot-demo-helloworld/README.md b/spring-boot-demo-helloworld/README.md index c5428eccc..1e42f538b 100644 --- a/spring-boot-demo-helloworld/README.md +++ b/spring-boot-demo-helloworld/README.md @@ -1,8 +1,14 @@ # spring-boot-demo-helloworld +## Runing spring boot demo helloworld + +```sh + $ mvn s...
[ "spring-boot-demo-helloworld/README.md" ]
[]
true
xkcoding/spring-boot-demo
151
issue_to_patch
[BUG] 生成的mapper.xml文件中jdbcType取的是java类型,已完善为jdbc类型并提交pull request 望采纳
修改mapper.xml文件生成格式-->实现jdbcType无须手动修改
修改mapper.xml文件生成格式-->实现jdbcType无须手动修改
9b9a24d7dcc37dbfc97cd845ab35409ec8b3c347
4c2e51d018832a5fa5ad3d772f9df90a987877fc
diff --git a/spring-boot-demo-codegen/pom.xml b/spring-boot-demo-codegen/pom.xml index 552f5eeec..b3ea06dcd 100644 --- a/spring-boot-demo-codegen/pom.xml +++ b/spring-boot-demo-codegen/pom.xml @@ -9,13 +9,6 @@ <name>spring-boot-demo-codegen</name> <description>Demo project for Spring Boot</description> - - ...
[ "spring-boot-demo-codegen/pom.xml", "spring-boot-demo-codegen/src/main/java/com/xkcoding/codegen/entity/ColumnEntity.java", "spring-boot-demo-codegen/src/main/java/com/xkcoding/codegen/utils/CodeGenUtil.java", "spring-boot-demo-codegen/src/main/resources/jdbc_type.properties", "spring-boot-demo-codegen/src/...
[]
true
xkcoding/spring-boot-demo
89
issue_to_patch
添加 https 集成
* PR 修复缺陷请先开 `issue` **[报告缺陷](https://github.com/xkcoding/spring-boot-demo/issues/new?template=bug_report.md)** * PR 提交新特性请先开 `issue` **[报告新特性](https://github.com/xkcoding/spring-boot-demo/issues/new?template=feature_request.md)** * PR 请提交到 `dev` 开发分支上 * 我们对编码风格有着较为严格的要求,请在阅读代码后模仿类似风格提交 * 欢迎通过 PR 给我们补充案例 第一次fork...
75c7236ad5945167662cbfb053a0cd44b023849f
72ffe33136fa6fffab0a19afa77c028f45cbc92c
diff --git a/pom.xml b/pom.xml index 64089db87..b68fabbf3 100644 --- a/pom.xml +++ b/pom.xml @@ -67,6 +67,7 @@ <module>spring-boot-demo-ratelimit-guava</module> <module>spring-boot-demo-ratelimit-redis</module> <module>spring-boot-demo-elasticsearch-rest-high-level-client</module> + <module>spring-boo...
[ "pom.xml", "spring-boot-demo-https/.gitignore", "spring-boot-demo-https/.mvn/wrapper/MavenWrapperDownloader.java", "spring-boot-demo-https/.mvn/wrapper/maven-wrapper.jar", "spring-boot-demo-https/.mvn/wrapper/maven-wrapper.properties", "spring-boot-demo-https/README.md", "spring-boot-demo-https/pom.xml"...
[]
diff --git a/spring-boot-demo-https/src/test/java/com/xkcoding/springbootdemohttps/SpringBootDemoHttpsApplicationTests.java b/spring-boot-demo-https/src/test/java/com/xkcoding/springbootdemohttps/SpringBootDemoHttpsApplicationTests.java new file mode 100644 index 000000000..ce62f8353 --- /dev/null +++ b/spring-boot-dem...
true
xkcoding/spring-boot-demo
86
issue_to_patch
:sparkles: Add spring-boot-demo-oauth-resource-server.
spring boot oauth2 资源服务器,同 授权服务器 一起使用。 - JWT 解密,远程公钥获取 - 基于角色访问控制 - 基于应用授权域访问控制
75c7236ad5945167662cbfb053a0cd44b023849f
a989d01e45887c5debf1f797bc6fed56fed939e6
diff --git a/pom.xml b/pom.xml index 64089db87..8311573dd 100644 --- a/pom.xml +++ b/pom.xml @@ -86,6 +86,20 @@ <user.agent.version>1.20</user.agent.version> </properties> + <repositories> + <repository> + <id>aliyun</id> + <name>aliyun</name> + <url>https://maven.aliyun.com/repository/publ...
[ "pom.xml", "spring-boot-demo-oauth/pom.xml", "spring-boot-demo-oauth/spring-boot-demo-oauth-authorization-server/README.adoc", "spring-boot-demo-oauth/spring-boot-demo-oauth-authorization-server/image/Code.png", "spring-boot-demo-oauth/spring-boot-demo-oauth-authorization-server/image/Confirm.png", "sprin...
[]
diff --git a/spring-boot-demo-oauth/spring-boot-demo-oauth-authorization-server/src/test/java/com/xkcoding/oauth/PasswordEncodeTest.java b/spring-boot-demo-oauth/spring-boot-demo-oauth-authorization-server/src/test/java/com/xkcoding/oauth/PasswordEncodeTest.java new file mode 100644 index 000000000..3dc8233a4 --- /dev/...
true
xkcoding/spring-boot-demo
84
issue_to_patch
:sparkles: Add spring-boot-demo-oauth-authorization-server.
spring boot oauth2 授权服务器 - 授权码模式、密码模式、刷新令牌 - 自定义 UserDetailService - 自定义 ClientDetailService - jwt 非对称加密 - 自定义登录授权页面
0378ad012f2b1cbcd23f21de83e9c829f07539d1
dcfeb4f4dec08af75419aa9b8d517cc83a6c012b
diff --git a/pom.xml b/pom.xml index 64089db87..8311573dd 100644 --- a/pom.xml +++ b/pom.xml @@ -86,6 +86,20 @@ <user.agent.version>1.20</user.agent.version> </properties> + <repositories> + <repository> + <id>aliyun</id> + <name>aliyun</name> + <url>https://maven.aliyun.com/repository/publ...
[ "pom.xml", "spring-boot-demo-oauth/pom.xml", "spring-boot-demo-oauth/spring-boot-demo-oauth-authorization-server/README.adoc", "spring-boot-demo-oauth/spring-boot-demo-oauth-authorization-server/image/Code.png", "spring-boot-demo-oauth/spring-boot-demo-oauth-authorization-server/image/Confirm.png", "sprin...
[]
diff --git a/spring-boot-demo-oauth/spring-boot-demo-oauth-authorization-server/src/test/java/com/xkcoding/oauth/PasswordEncodeTest.java b/spring-boot-demo-oauth/spring-boot-demo-oauth-authorization-server/src/test/java/com/xkcoding/oauth/PasswordEncodeTest.java new file mode 100644 index 000000000..3dc8233a4 --- /dev/...
true
xkcoding/spring-boot-demo
59
issue_to_patch
jpa增加部门上下级自关联,用户部门多对多关联
* PR 修复缺陷请先开 `issue` **[报告缺陷](https://github.com/xkcoding/spring-boot-demo/issues/new?template=bug_report.md)** * PR 提交新特性请先开 `issue` **[报告新特性](https://github.com/xkcoding/spring-boot-demo/issues/new?template=feature_request.md)** * PR 请提交到 `dev` 开发分支上 * 我们对编码风格有着较为严格的要求,请在阅读代码后模仿类似风格提交 * 欢迎通过 PR 给我们补充案例 我日志打印用了...
23a5cba7e70d760f0cfdbb1dc3cb65874df785ec
02e4162854c2383e19e61c2c2e1a613db2efafed
diff --git a/spring-boot-demo-orm-jpa/pom.xml b/spring-boot-demo-orm-jpa/pom.xml index acb25480c..7a846debb 100644 --- a/spring-boot-demo-orm-jpa/pom.xml +++ b/spring-boot-demo-orm-jpa/pom.xml @@ -59,6 +59,12 @@ <artifactId>lombok</artifactId> <optional>true</optional> </dependency> +...
[ "spring-boot-demo-orm-jpa/pom.xml", "spring-boot-demo-orm-jpa/src/main/java/com/xkcoding/orm/jpa/entity/Department.java", "spring-boot-demo-orm-jpa/src/main/java/com/xkcoding/orm/jpa/entity/User.java", "spring-boot-demo-orm-jpa/src/main/java/com/xkcoding/orm/jpa/repository/DepartmentDao.java", "spring-boot-...
[]
diff --git a/spring-boot-demo-orm-jpa/src/test/java/com/xkcoding/orm/jpa/repository/DepartmentDaoTest.java b/spring-boot-demo-orm-jpa/src/test/java/com/xkcoding/orm/jpa/repository/DepartmentDaoTest.java new file mode 100644 index 000000000..8dba3ccca --- /dev/null +++ b/spring-boot-demo-orm-jpa/src/test/java/com/xkcodi...
true
xkcoding/spring-boot-demo
51
issue_to_patch
Elasticsearch 7.X elasticsearch-rest-high-level-client CURD 基本操作 demo
Elasticsearch 7.X elasticsearch-rest-high-level-client CURD 基本操作 demo
1e4bc731a9f65842e37e31df93e020f5d7bd1fc8
8736ad218696e36b93b63eebf9bf2b931d4e435a
diff --git a/pom.xml b/pom.xml index 0ced8b35a..412062757 100644 --- a/pom.xml +++ b/pom.xml @@ -65,6 +65,7 @@ <module>spring-boot-demo-ldap</module> <module>spring-boot-demo-dynamic-datasource</module> <module>spring-boot-demo-ratelimit-guava</module> + <module>spring-boot-demo-elasticsearch-rest-hig...
[ "pom.xml", "spring-boot-demo-elasticsearch-rest-high-level-client/.gitignore", "spring-boot-demo-elasticsearch-rest-high-level-client/README.md", "spring-boot-demo-elasticsearch-rest-high-level-client/pom.xml", "spring-boot-demo-elasticsearch-rest-high-level-client/src/main/java/com/xkcoding/elasticsearch/E...
[ { "comment": "该版本号在父pom中已经指定,可以省略的~", "path": "spring-boot-demo-elasticsearch-rest-high-level-client/pom.xml", "hunk": "@@ -0,0 +1,99 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\"\n+ xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\...
diff --git a/spring-boot-demo-elasticsearch-rest-high-level-client/src/test/java/com/xkcoding/elasticsearch/ElasticsearchApplicationTests.java b/spring-boot-demo-elasticsearch-rest-high-level-client/src/test/java/com/xkcoding/elasticsearch/ElasticsearchApplicationTests.java new file mode 100644 index 000000000..21f901c...
true
xkcoding/spring-boot-demo
51
comment_to_fix
Elasticsearch 7.X elasticsearch-rest-high-level-client CURD 基本操作 demo
该版本号在父pom中已经指定,可以省略的~
1e4bc731a9f65842e37e31df93e020f5d7bd1fc8
8736ad218696e36b93b63eebf9bf2b931d4e435a
diff --git a/spring-boot-demo-elasticsearch-rest-high-level-client/pom.xml b/spring-boot-demo-elasticsearch-rest-high-level-client/pom.xml new file mode 100644 index 000000000..7a4a9d4db --- /dev/null +++ b/spring-boot-demo-elasticsearch-rest-high-level-client/pom.xml @@ -0,0 +1,99 @@ +<?xml version="1.0" encoding="UTF...
[ "spring-boot-demo-elasticsearch-rest-high-level-client/pom.xml" ]
[ { "comment": "该版本号在父pom中已经指定,可以省略的~", "path": "spring-boot-demo-elasticsearch-rest-high-level-client/pom.xml", "hunk": "@@ -0,0 +1,99 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<project xmlns=\"http://maven.apache.org/POM/4.0.0\"\n+ xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\...
true
xkcoding/spring-boot-demo
34
issue_to_patch
增加 springboot ldap demo 示例模块
875117339c13659fe593fa89b1ab9f98ec66de29
ee355b89a501349e089ea9d7b9a960758bdaab89
diff --git a/pom.xml b/pom.xml index 5455297cb..1ee5d3719 100644 --- a/pom.xml +++ b/pom.xml @@ -62,6 +62,7 @@ <module>spring-boot-demo-tio</module> <module>spring-boot-demo-codegen</module> <module>spring-boot-demo-graylog</module> + <module>spring-boot-demo-ldap</module> </modules> <packaging>...
[ "pom.xml", "spring-boot-demo-ldap/README.md", "spring-boot-demo-ldap/pom.xml", "spring-boot-demo-ldap/src/main/java/com/xkcoding/ldap/LdapDemoApplication.java", "spring-boot-demo-ldap/src/main/java/com/xkcoding/ldap/entity/Person.java", "spring-boot-demo-ldap/src/main/java/com/xkcoding/ldap/entity/Result....
[]
diff --git a/spring-boot-demo-ldap/src/test/java/com/xkcoding/ldap/LdapDemoApplicationTests.java b/spring-boot-demo-ldap/src/test/java/com/xkcoding/ldap/LdapDemoApplicationTests.java new file mode 100644 index 000000000..b9517771e --- /dev/null +++ b/spring-boot-demo-ldap/src/test/java/com/xkcoding/ldap/LdapDemoApplica...
true
xkcoding/spring-boot-demo
33
issue_to_patch
Update pom.xml
解决关于spring-boot-demo-properties项目获取不到pom的值的问题
97a677b4b057dcec2b4f0a31ae294b515feb7cec
7e2194e60e125ee0adbf98d839a75018696b5ce4
diff --git a/spring-boot-demo-properties/pom.xml b/spring-boot-demo-properties/pom.xml index 1bb7e8992..93210d31a 100644 --- a/spring-boot-demo-properties/pom.xml +++ b/spring-boot-demo-properties/pom.xml @@ -64,6 +64,12 @@ <artifactId>spring-boot-maven-plugin</artifactId> </plugin> </plugins> + <resourc...
[ "spring-boot-demo-properties/pom.xml" ]
[]
true
xkcoding/spring-boot-demo
30
issue_to_patch
Upgrade dependencies version
hutool -> 4.6.3 see https://github.com/looly/hutool/blob/v4-master/CHANGELOG.md guava -> 28.0-jre see https://github.com/google/guava/releases
f908805f879321def8357d1b08fd0ba8e3d032db
40b69273317e0f258c9305575f3e8f68069ae4d5
diff --git a/pom.xml b/pom.xml index 1cdce617e..5455297cb 100644 --- a/pom.xml +++ b/pom.xml @@ -76,8 +76,8 @@ <maven.compiler.target>1.8</maven.compiler.target> <spring.boot.version>2.1.0.RELEASE</spring.boot.version> <mysql.version>8.0.12</mysql.version> - <hutool.version>4.5.1</hutool.version> - ...
[ "pom.xml" ]
[]
true
xkcoding/spring-boot-demo
28
issue_to_patch
spring-boot-admin-server和spring-boot-admin-client服务
1、spring-boot-admin版本低于spring-boot版本,导致项目启动失败 2、spring-boot-admin-server配置context-path需修改至server.servlet下,否则启动后无法正常使用
e1d55817242d735f32c8da1d5a8c649a83182f3c
8eac180e27f05fe56e16e78fb36728cd28dd78c0
diff --git a/spring-boot-demo-admin-client/pom.xml b/spring-boot-demo-admin-client/pom.xml index 682adbb2c..9b8d814dc 100644 --- a/spring-boot-demo-admin-client/pom.xml +++ b/spring-boot-demo-admin-client/pom.xml @@ -20,7 +20,7 @@ <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> <project.reporti...
[ "spring-boot-demo-admin-client/pom.xml", "spring-boot-demo-admin-server/pom.xml", "spring-boot-demo-admin-server/src/main/resources/application.yml" ]
[]
true
xpipe-io/xpipe
846
issue_to_patch
Fix trying to open "Programs" folder in C:\Program Files
Programs are not typically installed into a Programs folder inside the the Program Files folder. The Programs folder is only used when installing into the local app data folder e.g. %LocalAppData%\Programs\Microsoft VS Code\ This is causing editors installed in C:\Program Files to not be detected
25f3372dfb25e500f5c76d6db909a700af943a23
7ead120fe6e340e6a121c85d9d5accd47591c17f
diff --git a/app/src/main/java/io/xpipe/app/prefs/ExternalEditorType.java b/app/src/main/java/io/xpipe/app/prefs/ExternalEditorType.java index 94a4211a6..d84c1bca9 100644 --- a/app/src/main/java/io/xpipe/app/prefs/ExternalEditorType.java +++ b/app/src/main/java/io/xpipe/app/prefs/ExternalEditorType.java @@ -65,7 +65,6 ...
[ "app/src/main/java/io/xpipe/app/prefs/ExternalEditorType.java" ]
[]
true
xpipe-io/xpipe
821
issue_to_patch
fix(FilePath): getBaseName crashes on hidden files like .bashrc
Found a small bug in `FilePath.getBaseName` while going through the codebase. For hidden files like `.bashrc` the `contains(".")" check passes since the leading dot counts, then `lastIndexOf(".")` returns 0 and `substring(0, 0)` produces an empty string. `FilePath.of("")` then throws `IllegalArgumentException`. Happy...
da8ca7bce5fb711d732c61334b7c2db56cd44a22
f244df78b20f2c7d0670eb9cf650298c0caf57ab
diff --git a/core/src/main/java/io/xpipe/core/FilePath.java b/core/src/main/java/io/xpipe/core/FilePath.java index e305d160c..1b5e6b08a 100644 --- a/core/src/main/java/io/xpipe/core/FilePath.java +++ b/core/src/main/java/io/xpipe/core/FilePath.java @@ -118,7 +118,12 @@ public String getFileName() { } public...
[ "core/src/main/java/io/xpipe/core/FilePath.java" ]
[]
true
xpipe-io/xpipe
781
issue_to_patch
Various improvements and bug fixes for 21.x
This pull request introduces two main improvements: the addition of Neovim as a supported external editor across all platforms, and the implementation of a new Gradle run menu option in the file browser. It also includes enhancements to WezTerm terminal integration and a minor update to the AUR installation process. ...
c2a54c4d90b50409f762ab11b43bcd8e9de03108
82e7005fec7c89d757308f90c40aa5e0c56f87dc
diff --git a/app/src/main/java/io/xpipe/app/browser/menu/impl/GradleRunMenuProvider.java b/app/src/main/java/io/xpipe/app/browser/menu/impl/GradleRunMenuProvider.java new file mode 100644 index 0000000000..0b44ec3766 --- /dev/null +++ b/app/src/main/java/io/xpipe/app/browser/menu/impl/GradleRunMenuProvider.java @@ -0,0...
[ "app/src/main/java/io/xpipe/app/browser/menu/impl/GradleRunMenuProvider.java", "app/src/main/java/io/xpipe/app/prefs/ExternalEditorType.java", "app/src/main/java/io/xpipe/app/terminal/WezTerminalType.java", "app/src/main/java/io/xpipe/app/update/AppDistributionType.java", "app/src/main/java/module-info.java...
[]
true
xpipe-io/xpipe
792
issue_to_patch
terminal: pass title to ptyxis tabs/windows
## Summary - add `--title` when launching Ptyxis from XPipe - pass XPipe's computed connection title via `configuration.getColoredTitle()` - keep existing tab/window behavior (`--tab` / `--new-window`) unchanged ## Why Ptyxis supports `--title` for new tabs/windows, but XPipe's Ptyxis launcher did not pass it. T...
18566322454c1cb77eb00acdbdec70c46816c787
444596d827de920fcb0a35bccee6543a3162791f
diff --git a/app/src/main/java/io/xpipe/app/terminal/PtyxisTerminalType.java b/app/src/main/java/io/xpipe/app/terminal/PtyxisTerminalType.java index 5f5df526d3..b6ba873e19 100644 --- a/app/src/main/java/io/xpipe/app/terminal/PtyxisTerminalType.java +++ b/app/src/main/java/io/xpipe/app/terminal/PtyxisTerminalType.java @...
[ "app/src/main/java/io/xpipe/app/terminal/PtyxisTerminalType.java" ]
[]
true
xpipe-io/xpipe
728
issue_to_patch
Update Several Translations
8995072557430fce0c5623a0ace46e01195043ee
95abe84c51533566e26575dd7bec588f5ccb13fb
diff --git a/lang/strings/translations_da.properties b/lang/strings/translations_da.properties index 423ba59863..deb54d6b94 100644 --- a/lang/strings/translations_da.properties +++ b/lang/strings/translations_da.properties @@ -420,7 +420,7 @@ retry=Forsøg igen retryAll=Prøv igen alle replace=Udskift replaceAll=Ersta...
[ "lang/strings/translations_da.properties", "lang/strings/translations_de.properties", "lang/strings/translations_en.properties", "lang/strings/translations_es.properties", "lang/strings/translations_fr.properties", "lang/strings/translations_id.properties", "lang/strings/translations_it.properties", "...
[]
true
xpipe-io/xpipe
720
issue_to_patch
Bug: Context menu should be closed when renaming the file version 19.1 ## Steps to Reproduce 1. right-click on file to open the context menu<br/><img width="509" height="419" alt="Image" src="https://github.com/user-attachments/assets/cd1e4c5c-3129-4133-bbae-c5f6c0b303df" /> 2. press `Ctrl+R` to rename the file<br/>...
Fix: Context menu should be closed when renaming the file (#719)
This is my first contribution, please lmk if there's any problem! Closes #719
cd6b180d2f017568cd737661540a3b5fa8eab53c
29afecdaed98d2be1c1eda2f0a9943a9785fb06f
diff --git a/app/src/main/java/io/xpipe/app/browser/file/BrowserContextMenu.java b/app/src/main/java/io/xpipe/app/browser/file/BrowserContextMenu.java index 19c18a25e5..8e65b2d2ec 100644 --- a/app/src/main/java/io/xpipe/app/browser/file/BrowserContextMenu.java +++ b/app/src/main/java/io/xpipe/app/browser/file/BrowserCo...
[ "app/src/main/java/io/xpipe/app/browser/file/BrowserContextMenu.java", "app/src/main/java/io/xpipe/app/browser/file/BrowserFileListComp.java" ]
[]
true
xpipe-io/xpipe
714
issue_to_patch
Update hibernateBehaviour in translations_de.properties
Updated translation for hibernateBehaviour to the correct german word (which is already used in the description).
4a2c33351179c252189b7027654a4baa043c0d90
9cdd57c30dcd36cdc9b7290d6913814285793394
diff --git a/lang/strings/translations_de.properties b/lang/strings/translations_de.properties index 1d5fe51043..61bda67bb8 100644 --- a/lang/strings/translations_de.properties +++ b/lang/strings/translations_de.properties @@ -423,7 +423,8 @@ retryAll=Alle Versuche wiederholen replace=Ersetze replaceAll=Ersetze alle ...
[ "lang/strings/translations_de.properties" ]
[]
true
xpipe-io/xpipe
659
issue_to_patch
Fix chinese translations
DeepL will translate some proper nouns, for example Shell will literally be translated into “外壳” (“the shell of a seashell”) and it also doesn’t follow Chinese word order, making it feel like you can read it yet still not really understand it. Also refined many translations according to their in‑context meaning.
672911f2ae0033c98bffc5ad28dd0e20a00b10fa
08824993d30403f1b92d78150328c1ab9d6f6095
diff --git a/lang/strings/translations_zh.properties b/lang/strings/translations_zh.properties index 33fe5418b6..29abdba102 100644 --- a/lang/strings/translations_zh.properties +++ b/lang/strings/translations_zh.properties @@ -1,29 +1,39 @@ delete=删除 properties=属性 -usedDate=已使用$DATE$ #custom +usedDate=使用日期 $DATE$ o...
[ "lang/strings/translations_zh.properties" ]
[]
true
xpipe-io/xpipe
609
issue_to_patch
Update translations_ru.properties
Hello! I would like to make changes to the Russian translation. Most of the translations (those that I use myself) were edited. Thank you!
b23f5d5993b04e6ca453049e50bcbf1e02fd88a6
643ad01e04eeb14b49cb64c89de9b2eba1cc4928
diff --git a/lang/strings/translations_ru.properties b/lang/strings/translations_ru.properties index ed77bd49d6..c96fecd080 100644 --- a/lang/strings/translations_ru.properties +++ b/lang/strings/translations_ru.properties @@ -26,7 +26,7 @@ addService=Сервис ... addScript=Скрипт ... addHost=Удаленный хост ... addShe...
[ "lang/strings/translations_ru.properties" ]
[]
true
xpipe-io/xpipe
578
issue_to_patch
Size column sort in Browser File List sorts alphabetically instead of by actual size. Steps to reproduce 1. Browse a folder on a remote host. 2. Click the "Size" column to sort by size. I noticed in this code we are not setting a custom comparator for the `sizeCol`, so maybe its using the default comparator from the...
Set comparator for sizeCol to compare the Long value of the size.
1. Fixes #577 2. Tried to minimize change impact by only setting the comparator of the `sizeCol` `TableColumn` 3. Checks for null values in case it is a directory and correctly puts the directory on top. 4. If we fail to parse the Long from the size string we fallback to string compare. 5. All the tests are passin...
0a40eedf18edd1b8b709e6ac804aeb09359dffe3
196681080ed21bc03e415b5528e25c7d478252c8
diff --git a/app/src/main/java/io/xpipe/app/browser/file/BrowserFileListComp.java b/app/src/main/java/io/xpipe/app/browser/file/BrowserFileListComp.java index 400aaf7666..7f2074abc1 100644 --- a/app/src/main/java/io/xpipe/app/browser/file/BrowserFileListComp.java +++ b/app/src/main/java/io/xpipe/app/browser/file/Browse...
[ "app/src/main/java/io/xpipe/app/browser/file/BrowserFileListComp.java" ]
[]
true
xpipe-io/xpipe
568
issue_to_patch
Fix French translations for various strings properties
Updates French translations in the `translations_fr.properties` file. * Corrected phrasing in `teleportClusterDescription` to fix a grammatical error ("lequelle" → "lequel"). * Updated `vaultUserLegacy` to use "coffre-fort" instead of "chambre forte" for better terminology consistency. * Changed `enpassVaultFile` ...
3e317bf2f4da1d486360aac92de217f86086c9b4
0412cf9a11e2fe5a507ab160241d965c0d942ee7
diff --git a/lang/strings/translations_fr.properties b/lang/strings/translations_fr.properties index 835960ef2d..b337312a61 100644 --- a/lang/strings/translations_fr.properties +++ b/lang/strings/translations_fr.properties @@ -209,7 +209,8 @@ print=Imprimer whatsNew=Nouveautés de la version $VERSION$ ($DATE$) antivir...
[ "lang/strings/translations_fr.properties" ]
[]
true
xpipe-io/xpipe
538
issue_to_patch
Fix french translations
There are some bad french translations, 1. "History" means "Historique" in this context but "histoire" corresponds to "story" 2. "Vault" means "Coffre-fort" but "voûte" is not appropriate (it's an architectural work) 3. "Move to" means "Déplacer vers", "Aller à" corresponds to "Go to"
ab71d178f371f5442d30707a9aa77643dacb0935
afc589ffe274db2ad96e8f5b9f55f1eff4b76bac
diff --git a/lang/strings/translations_fr.properties b/lang/strings/translations_fr.properties index c61bc37b64..ffe8e9c32b 100644 --- a/lang/strings/translations_fr.properties +++ b/lang/strings/translations_fr.properties @@ -18,7 +18,7 @@ addShellTitle=Ajouter une connexion Shell savedConnections=Connexions sauvegar...
[ "lang/strings/translations_fr.properties" ]
[]
true
xpipe-io/xpipe
528
issue_to_patch
PL translation fixes and EN source disambiguations
There is some ambiguity in "name", "me", and "value" that impact translations in various languages. - I assumed "name" is for inanimate objects specifically as in Polish there is a different translation of a person's "name". - I assumed "me" is in dative case. DE reference is in nominative but DA reference is in da...
ab71d178f371f5442d30707a9aa77643dacb0935
6afc93bb12c21738c13177ae5fca54b61ba835ad
diff --git a/lang/strings/translations_en.properties b/lang/strings/translations_en.properties index 4331bcf080..ac90cb1eb9 100644 --- a/lang/strings/translations_en.properties +++ b/lang/strings/translations_en.properties @@ -40,6 +40,7 @@ selectTypeDescription=Select connection type selectShellType=Shell Type #cont...
[ "lang/strings/translations_en.properties", "lang/strings/translations_pl.properties" ]
[]
true
xpipe-io/xpipe
498
issue_to_patch
Update translations_zh.properties
Update Chinese for translation errors and some optimizations
7e2663c6eab16e18b771f69dddfe9864bf6c2646
0b88243d161fe60975779554823ef092b2805d1f
diff --git a/lang/strings/translations_zh.properties b/lang/strings/translations_zh.properties index 07f2911ac7..09f4b7f83e 100644 --- a/lang/strings/translations_zh.properties +++ b/lang/strings/translations_zh.properties @@ -1,10 +1,12 @@ delete=删除 properties=属性 usedDate=已使用$DATE$ -openDir=开放目录 +#custom +openDir=打...
[ "lang/strings/translations_zh.properties" ]
[]
true
xpipe-io/xpipe
493
issue_to_patch
docs: update contact_ja.md
markdown fix
25e2ddd2a38c188912ee0015e5071a37434ddb95
c0fc0ed9af05a0a835c9052eb88676ec12716012
diff --git a/lang/texts/contact_ja.md b/lang/texts/contact_ja.md index e59e55d8dd..50805fd11c 100644 --- a/lang/texts/contact_ja.md +++ b/lang/texts/contact_ja.md @@ -1,6 +1,6 @@ ご質問がある場合、問題が発生した場合、その他何でも、私たちに連絡することができる: -- hello@xpipe.io](mailto://hello@xpipe.io) までメールを送る。 -- XPipe Discord Server](https://discord.g...
[ "lang/texts/contact_ja.md" ]
[]
true
xpipe-io/xpipe
449
issue_to_patch
Update Chinese translations for Tailscale terms
Tailscale and tailnet should not be translated.
d8155769d9e4fa2cbddef4343fa2dd6351b67c02
4fb4b415a1117d9cda0cddf286c15c1089eb0085
diff --git a/lang/strings/translations_zh.properties b/lang/strings/translations_zh.properties index b893c10185..9b3511a66c 100644 --- a/lang/strings/translations_zh.properties +++ b/lang/strings/translations_zh.properties @@ -1240,15 +1240,22 @@ clearUserDataTitle=用户数据删除 clearUserDataContent=这将删除 xpipe 的所有本地用户数据并重新启动...
[ "lang/strings/translations_zh.properties" ]
[]
true
xpipe-io/xpipe
439
issue_to_patch
Update links to xpipe.io
Path structure of xpipe.io website changed. I have checked all the links and updated all those that return HTTP status code 404.
99383f23c0a61382eaadde21a053cda6299c05ca
bde74c71f9fcf272944bd9bb91ca9cffe7be6158
diff --git a/app/src/main/java/io/xpipe/app/util/Hyperlinks.java b/app/src/main/java/io/xpipe/app/util/Hyperlinks.java index fcc829ce49..3d6297d924 100644 --- a/app/src/main/java/io/xpipe/app/util/Hyperlinks.java +++ b/app/src/main/java/io/xpipe/app/util/Hyperlinks.java @@ -4,15 +4,15 @@ public class Hyperlinks { ...
[ "app/src/main/java/io/xpipe/app/util/Hyperlinks.java" ]
[]
true
xpipe-io/xpipe
428
issue_to_patch
Fix hyper link in README.md
minor fix
1db6c4edc4d35bdcb0dfb5de9f42a10101a8f98b
5bee7f88c042e23127ab4b5cfa87977b684eac9b
diff --git a/README.md b/README.md index 77e803309e..1ef525db26 100644 --- a/README.md +++ b/README.md @@ -14,7 +14,7 @@ XPipe fully integrates with your tools such as your favourite text/code editors, It currently supports: - [SSH](https://www.ssh.com/academy/ssh/protocol) connections, config files, and tunnels --...
[ "README.md" ]
[]
true
xpipe-io/xpipe
391
issue_to_patch
Update of some lang FR files
Focus on updating the French translations in various properties files. - `lang/app/strings/translations_fr.properties` - `lang/base/strings/translations_fr.properties` - `lang/proc/strings/translations_fr.properties`
cc8b74be9dabdc8ba3e893cea2ce9d4e11d77904
0778d024a648d3d2e831b326aba12bf6ae6b535e
diff --git a/lang/app/strings/translations_fr.properties b/lang/app/strings/translations_fr.properties index 772fde5408..363553ec3a 100644 --- a/lang/app/strings/translations_fr.properties +++ b/lang/app/strings/translations_fr.properties @@ -14,7 +14,8 @@ stored=Sauvegardé troubleshootingOptions=Outils de dépannage ...
[ "lang/app/strings/translations_fr.properties", "lang/base/strings/translations_fr.properties", "lang/proc/strings/translations_fr.properties" ]
[]
true
xpipe-io/xpipe
263
issue_to_patch
DA lang - 9.2 check
0d989431ae14794ed12284df52809d3689bdcf5c
0e49f23d051a3dedfc72e473dea467c9903ea5ba
diff --git a/lang/README.md b/lang/README.md index cf96c23b19..c1c0194df7 100644 --- a/lang/README.md +++ b/lang/README.md @@ -41,4 +41,4 @@ Here you can see the current status of the translations. Verified means that the |----------|----------------| | English | Reference | | German | Verified @ 9.0 | -| Da...
[ "lang/README.md", "lang/app/strings/translations_da.properties", "lang/base/strings/translations_da.properties", "lang/proc/strings/translations_da.properties", "lang/uacc/strings/translations_da.properties", "lang/uacc/texts/contact_da.md" ]
[]
true
xpipe-io/xpipe
245
issue_to_patch
DA lang context fix "hibernation option"
Added the correct text context. It will prob. be changed with time, but for now it's WAY better than "hvælving" = Arch.
48e9ece152021d311a139996401595056df0fc71
db4dc20c7099f15ea951d45844d54461c91af249
diff --git a/lang/app/strings/translations_da.properties b/lang/app/strings/translations_da.properties index b2087b5942..c124c29ee3 100644 --- a/lang/app/strings/translations_da.properties +++ b/lang/app/strings/translations_da.properties @@ -443,5 +443,7 @@ retryAll=Prøv igen alle replace=Erstat replaceAll=Udskift a...
[ "lang/app/strings/translations_da.properties" ]
[]
true
xpipe-io/xpipe
233
issue_to_patch
fixes on tr translatıon
bc3a4fcf15aa71010bee76368572f6dc69fb8eff
67059394f6b3361447c7081dc7dbb86516427aad
diff --git a/lang/app/strings/translations_tr.properties b/lang/app/strings/translations_tr.properties index 5f5af12fcb..77df866204 100644 --- a/lang/app/strings/translations_tr.properties +++ b/lang/app/strings/translations_tr.properties @@ -317,7 +317,7 @@ system=Sistem application=Uygulama storage=Depolama runOnS...
[ "lang/app/strings/translations_tr.properties", "lang/jdbc/strings/translations_tr.properties" ]
[]
true
xpipe-io/xpipe
238
issue_to_patch
Danish 🇩🇰 lang corrections
I've done some UX QA, some strings may be wrong depending on the context. But they are grammatically correct at least. e.g the app string for "finish" is incorrect due to context. But since it's current translation setup is the way it is, it's not possible to change it to "Gem" when you add a SSH connection due to r...
bc3a4fcf15aa71010bee76368572f6dc69fb8eff
1f8e411c1e6b3faa5ca96889efab232087282211
diff --git a/lang/README.md b/lang/README.md index 2dca9ba33b..cf96c23b19 100644 --- a/lang/README.md +++ b/lang/README.md @@ -40,4 +40,5 @@ Here you can see the current status of the translations. Verified means that the | Language | Status | |----------|----------------| | English | Reference | -| Ge...
[ "lang/README.md", "lang/app/strings/translations_da.properties", "lang/base/strings/translations_da.properties", "lang/proc/strings/translations_da.properties", "lang/proc/texts/elevation_da.md", "lang/proc/texts/environmentScript_da.md", "lang/uacc/strings/translations_da.properties", "lang/uacc/text...
[]
true
xpipe-io/xpipe
111
issue_to_patch
Update preferences_en.properties - fix typo
fix typo: add `IDEA`
9b9fed3ec681beb6bec90f8231926810cb6dad15
21b3dcd9218cadcaa767b77bbbf0b67fa1d89da1
diff --git a/app/src/main/resources/io/xpipe/app/resources/lang/preferences_en.properties b/app/src/main/resources/io/xpipe/app/resources/lang/preferences_en.properties index 778bfb7666..dd528f2241 100644 --- a/app/src/main/resources/io/xpipe/app/resources/lang/preferences_en.properties +++ b/app/src/main/resources/io/...
[ "app/src/main/resources/io/xpipe/app/resources/lang/preferences_en.properties" ]
[]
true
xpipe-io/xpipe
91
issue_to_patch
doc(README): remove typo
## Description: This Pull Request fixes a typographical error in the README.md file. ## Changes Made: - Corrected "sever" to "server" in the README.md file. ## Additional Information: This fix is not related to any existing issue. It's a minor typo that I noticed while reviewing the README. Thank you for co...
15088095e2cd59617ff7377d5dc31e39212e560f
fb9b398d7e5e4aaee52e7dc6cdc16bdbcdf8584e
diff --git a/README.md b/README.md index 7ca57a10b4..304a57722b 100644 --- a/README.md +++ b/README.md @@ -2,7 +2,7 @@ ### A brand-new shell connection hub and remote file manager -XPipe is a new type of shell connection hub and remote file manager that allows you to access your entire sever infrastructure from yo...
[ "README.md" ]
[]
true
xyflow/xyflow
5,804
issue_to_patch
Enable all linting rules and fix
1279a4c02c623ed877f497b9e41c46e19f1c64db
b66072b6975f054b08c5df37424885796a444405
diff --git a/packages/react/src/additional-components/Controls/Controls.tsx b/packages/react/src/additional-components/Controls/Controls.tsx index 5863e80ed5..3b9431d7c2 100644 --- a/packages/react/src/additional-components/Controls/Controls.tsx +++ b/packages/react/src/additional-components/Controls/Controls.tsx @@ -4...
[ "packages/react/src/additional-components/Controls/Controls.tsx", "packages/react/src/additional-components/MiniMap/MiniMap.tsx", "packages/react/src/additional-components/MiniMap/MiniMapNodes.tsx", "packages/react/src/additional-components/MiniMap/types.ts", "packages/react/src/components/BatchProvider/ind...
[ { "comment": "we might be able to remove this. but we need to make a decision about React18/19", "path": "packages/react/src/utils/general.ts", "hunk": "@@ -55,6 +55,5 @@ export const isEdge = <EdgeType extends Edge = Edge>(element: unknown): element\n export function fixedForwardRef<T, P = {}>(", "...
true
xyflow/xyflow
5,800
issue_to_patch
Upgrade to Zustand 5
Tasks - [x] Upgrade to Zustand 5 - [x] Migrate from `zustand/traditional` to `useShallow` - [x] Fix the types for the Store API - [x] Check the custom diff function if it works as expected - [ ] Check for performance & potential rerender issues
479082d5a397e9701e2f2a5ad0eadc7c9af3a9ca
7d27304356276b3ce9e2cbff29d8d8dccea3c6a0
diff --git a/.changeset/lovely-nights-scream.md b/.changeset/lovely-nights-scream.md new file mode 100644 index 0000000000..f3778bdbb3 --- /dev/null +++ b/.changeset/lovely-nights-scream.md @@ -0,0 +1,6 @@ +--- +"@xyflow/react": major +--- + +useStore is now a Zustand 5 store. Use useShallow instead of passing equality...
[ ".changeset/lovely-nights-scream.md", ".changeset/witty-rules-cough.md", "examples/react/cypress/components/reactflow/storeAvailabilityOnRemount.cy.tsx", "examples/react/src/examples/CancelConnection/index.tsx", "examples/react/src/examples/DevTools/DevTools/ChangeLogger.tsx", "examples/react/src/examples...
[]
true
xyflow/xyflow
5,768
issue_to_patch
Release packages
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will ...
f35f53f0307eef37c3ccbcbff64b4f333ad2c610
6970ded32ff745e8fb6ecc97eb6b78956d7cc016
diff --git a/.changeset/chilled-otters-reply.md b/.changeset/chilled-otters-reply.md deleted file mode 100644 index bac3dbecd..000000000 --- a/.changeset/chilled-otters-reply.md +++ /dev/null @@ -1,5 +0,0 @@ ---- -'@xyflow/svelte': patch ---- - -Fix control button props not being reactive diff --git a/.changeset/clean-...
[ ".changeset/chilled-otters-reply.md", ".changeset/clean-eyes-sleep.md", ".changeset/clean-pianos-count.md", ".changeset/curly-hornets-notice.md", ".changeset/eighty-crabs-shake.md", ".changeset/fresh-cats-mate.md", ".changeset/fresh-fans-pump.md", ".changeset/fuzzy-crews-vanish.md", ".changeset/gree...
[]
true
xyflow/xyflow
5,803
issue_to_patch
Refactor/reset node drag state on abort
0611435149b7eaf116657183c338ffea85ecf845
737194d571894dd84ce7cbab02f2a4d0b779d018
diff --git a/.changeset/fresh-fans-pump.md b/.changeset/fresh-fans-pump.md new file mode 100644 index 000000000..ed705924f --- /dev/null +++ b/.changeset/fresh-fans-pump.md @@ -0,0 +1,5 @@ +--- +'@xyflow/system': patch +--- + +Reset node drag state when drag is aborted diff --git a/packages/system/src/xydrag/XYDrag.ts ...
[ ".changeset/fresh-fans-pump.md", "packages/system/src/xydrag/XYDrag.ts" ]
[]
true
xyflow/xyflow
5,793
issue_to_patch
Svelte Flow errors mention React Flow <img width="582" height="41" alt="Image" src="https://github.com/user-attachments/assets/26a4bcf6-c642-4e2f-80c7-e5978d45aaa8" />
fix: svelte flow errors mention react flow
f4f8e1fa1cad02d60abf735a405f2c7c6186361f
49fc4c613d3d8a965539125d89c7364033acab01
diff --git a/.changeset/curly-hornets-notice.md b/.changeset/curly-hornets-notice.md new file mode 100644 index 0000000000..0147536538 --- /dev/null +++ b/.changeset/curly-hornets-notice.md @@ -0,0 +1,8 @@ +--- +"@xyflow/react": patch +"@xyflow/svelte": patch +"@xyflow/system": patch +--- + +Dev Warnings now use librar...
[ ".changeset/curly-hornets-notice.md", "packages/react/src/components/Handle/index.tsx", "packages/react/src/hooks/useStore.ts", "packages/react/src/index.ts", "packages/react/src/store/initialState.ts", "packages/react/src/utils/edges.ts", "packages/react/src/utils/index.ts", "packages/svelte/src/lib/...
[ { "comment": "this seems to be an error meant to be used for a node but it's about an edge in this case.", "path": "packages/svelte/src/lib/store/index.ts", "hunk": "@@ -298,7 +298,7 @@ export function createStore<NodeType extends Node = Node, EdgeType extends Edge\n const edge = store.edgeLookup.ge...
true
xyflow/xyflow
5,801
issue_to_patch
Missing aria-label on the node in @xyflow/svelte ### What platform were you using when you found the bug? - React Flow / Svelte Flow version: @xyflow/svelte 1.5.2 - Browser and version: Brave 1.88.136 - OS and version: MacOS Tahoe 26.3.1 ### Live code example https://stackblitz.com/edit/svelte-flow-ts-scmwbxma?file...
fix(svelte): pass ariaLabel to node wrapper
## Summary This PR fixes an issue in `@xyflow/svelte` where the `ariaLabel` property defined on a node was not passed to the rendered DOM element. ### Changes - Added `aria-label={node.ariaLabel}` to `NodeWrapper.svelte` ### Result Nodes configured with an `ariaLabel` now correctly render an `aria-label`...
7e972983b392b747342cda68ece4e5bf082860a1
536ff5f51e503ea70251f0075e4efcdbcc84dfee
diff --git a/.changeset/green-dryers-cough.md b/.changeset/green-dryers-cough.md new file mode 100644 index 000000000..d38b70104 --- /dev/null +++ b/.changeset/green-dryers-cough.md @@ -0,0 +1,5 @@ +--- +'@xyflow/svelte': patch +--- + +Pass aria label to node dom element diff --git a/packages/svelte/src/lib/components/...
[ ".changeset/green-dryers-cough.md", "packages/svelte/src/lib/components/NodeWrapper/NodeWrapper.svelte" ]
[]
true
xyflow/xyflow
5,638
issue_to_patch
It doesn’t work in mobile Chrome when trying to select multiple elements using a selection box. ### What platform were you using when you found the bug? - React Flow / Svelte Flow version: React Flow - Browser and version: Chrome 142 - OS and version: Android ### Live code example https://codesandbox.io/p/sandbox/...
Fix selection box issue on mobile devices
Add touch-action: none to react-flow__pane to prevent default touch behavior from interfering with selection functionality on mobile devices fix: https://github.com/xyflow/xyflow/issues/5639
d33360b5c7a308c45287dc9879fd1a1ee534a1ce
40660cdb054fb1a110799a3ad7cecbf51371727f
diff --git a/.changeset/fuzzy-crews-vanish.md b/.changeset/fuzzy-crews-vanish.md new file mode 100644 index 0000000000..81d952d4e5 --- /dev/null +++ b/.changeset/fuzzy-crews-vanish.md @@ -0,0 +1,5 @@ +--- +"@xyflow/system": patch +--- + +Fix selection box issue on mobile devices by adding `touch-action:none` diff --git...
[ ".changeset/fuzzy-crews-vanish.md", "packages/system/src/styles/init.css" ]
[]
true
xyflow/xyflow
5,795
issue_to_patch
Fix/svelte astro
e52bb557888fbae0237432300142180aaca1774f
d06cec7758e6fcd831976e9f515dca08a9c2782e
diff --git a/.changeset/yellow-ads-attend.md b/.changeset/yellow-ads-attend.md new file mode 100644 index 000000000..cfda2f103 --- /dev/null +++ b/.changeset/yellow-ads-attend.md @@ -0,0 +1,6 @@ +--- +"@xyflow/svelte": patch +--- + +Check if window is defined before calling browser functions + \ No newline at end of ...
[ ".changeset/yellow-ads-attend.md", "packages/svelte/src/lib/container/Pane/Pane.svelte" ]
[]
true
xyflow/xyflow
5,755
issue_to_patch
`@xyflow/react` fails with pnpm strict mode — missing peerDependency on `@types/react` `@xyflow/react@12.10.1` ships `.d.ts` files that import from `react`: ```ts import { ComponentType } from 'react'; ``` TypeScript resolves these types through `@types/react`, but `@xyflow/react` only declares `react` and `react-do...
fix(react): add @types/react to peer dependencies
## Summary Adds `@types/react` and `@types/react-dom` as optional peer dependencies of `@xyflow/react` so TypeScript can resolve the shipped `.d.ts` types under pnpm strict mode (`hoist: false`). ## Issue Fixes #5738 ## Changes - `packages/react/package.json`: declare `@types/react` / `@types/react-dom` in `peerDepen...
a58568f11bc0e1a1bdca1b3549e959e2e1ca0cdd
392149c7dbf3ca1265c8518dfca3d166c70cb929
diff --git a/.changeset/react-types-peer-dep.md b/.changeset/react-types-peer-dep.md new file mode 100644 index 0000000000..1fde0948af --- /dev/null +++ b/.changeset/react-types-peer-dep.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Add `@types/react` and `@types/react-dom` as optional peer dependencies to pr...
[ ".changeset/react-types-peer-dep.md", "packages/react/package.json" ]
[]
true
xyflow/xyflow
5,105
issue_to_patch
feat(system): updates generic typings for xydrag & xyhandle
## Summary Similar to https://github.com/xyflow/xyflow/pull/5102 -- this PR updates the existing generic typing for XYDrag as I saw there were gaps in it. This one could perhaps be more sensitive than the other change as it was more additive in nature compared to this one. I'm uncertain about the sensitivity of the ...
ad4a90e8266cd39981ff8c502fe75e93ba2e16a5
4806e7cde6d69cd7570098ecca86523666b80175
diff --git a/.changeset/clean-pianos-count.md b/.changeset/clean-pianos-count.md new file mode 100644 index 0000000000..431b84a847 --- /dev/null +++ b/.changeset/clean-pianos-count.md @@ -0,0 +1,5 @@ +--- +'@xyflow/svelte': patch +--- + +Improve generic types on useSvelteFlow to better reflect custom node & edge data d...
[ ".changeset/clean-pianos-count.md", ".changeset/lazy-insects-count.md", ".changeset/rich-houses-develop.md", "packages/react/src/types/nodes.ts", "packages/svelte/src/lib/actions/drag/index.ts", "packages/svelte/src/lib/container/SvelteFlow/types.ts", "packages/svelte/src/lib/hooks/useSvelteFlow.svelte....
[ { "comment": "I was definitely keen on removing references to `any` here. Hopefully the adjustments I made won't be breaking for consumers. To mitigate that, we lean on default type assignments for the generics.", "path": "packages/system/src/xydrag/XYDrag.ts", "hunk": "@@ -87,14 +94,13 @@ export type D...
true
xyflow/xyflow
5,105
comment_to_fix
feat(system): updates generic typings for xydrag & xyhandle
I was definitely keen on removing references to `any` here. Hopefully the adjustments I made won't be breaking for consumers. To mitigate that, we lean on default type assignments for the generics.
ad4a90e8266cd39981ff8c502fe75e93ba2e16a5
4806e7cde6d69cd7570098ecca86523666b80175
diff --git a/packages/system/src/xydrag/XYDrag.ts b/packages/system/src/xydrag/XYDrag.ts index c78e103506..fca7a72a04 100644 --- a/packages/system/src/xydrag/XYDrag.ts +++ b/packages/system/src/xydrag/XYDrag.ts @@ -28,17 +28,28 @@ import type { InternalNodeBase, } from '../types'; -export type OnDrag = ( +export ...
[ "packages/system/src/xydrag/XYDrag.ts" ]
[ { "comment": "I was definitely keen on removing references to `any` here. Hopefully the adjustments I made won't be breaking for consumers. To mitigate that, we lean on default type assignments for the generics.", "path": "packages/system/src/xydrag/XYDrag.ts", "hunk": "@@ -87,14 +94,13 @@ export type D...
true
xyflow/xyflow
5,105
comment_to_fix
feat(system): updates generic typings for xydrag & xyhandle
This is what I converted the original `OnDrag` type generic to that was originally defined using `any`.
ad4a90e8266cd39981ff8c502fe75e93ba2e16a5
4806e7cde6d69cd7570098ecca86523666b80175
diff --git a/packages/system/src/xydrag/XYDrag.ts b/packages/system/src/xydrag/XYDrag.ts index c78e103506..fca7a72a04 100644 --- a/packages/system/src/xydrag/XYDrag.ts +++ b/packages/system/src/xydrag/XYDrag.ts @@ -28,17 +28,28 @@ import type { InternalNodeBase, } from '../types'; -export type OnDrag = ( +export ...
[ "packages/system/src/xydrag/XYDrag.ts" ]
[ { "comment": "This is what I converted the original `OnDrag` type generic to that was originally defined using `any`.", "path": "packages/system/src/xydrag/XYDrag.ts", "hunk": "@@ -29,17 +29,24 @@ import type {\n InternalNodeBase,\n } from '../types';\n \n-export type OnDrag = (\n+export type OnDrag<N...
true
xyflow/xyflow
5,105
comment_to_fix
feat(system): updates generic typings for xydrag & xyhandle
It would be better to pass EdgeType here too, so that we can pass it to XYDragParams instead of having to type `getStoreItems` directly.
ad4a90e8266cd39981ff8c502fe75e93ba2e16a5
4806e7cde6d69cd7570098ecca86523666b80175
diff --git a/packages/system/src/xydrag/XYDrag.ts b/packages/system/src/xydrag/XYDrag.ts index c78e103506..fca7a72a04 100644 --- a/packages/system/src/xydrag/XYDrag.ts +++ b/packages/system/src/xydrag/XYDrag.ts @@ -28,17 +28,28 @@ import type { InternalNodeBase, } from '../types'; -export type OnDrag = ( +export ...
[ "packages/system/src/xydrag/XYDrag.ts" ]
[ { "comment": "It would be better to pass EdgeType here too, so that we can pass it to XYDragParams instead of having to type `getStoreItems` directly. ", "path": "packages/system/src/xydrag/XYDrag.ts", "hunk": "@@ -87,14 +94,13 @@ export type DragUpdateParams = {\n nodeClickDistance?: number;\n };\n ...
true
xyflow/xyflow
5,105
comment_to_fix
feat(system): updates generic typings for xydrag & xyhandle
Hopefully this wont be a problem as `UpdateNodePositions` accepts a generic type based on `InternalNodeBase` and this time we're passing the `NodeType` info through along with it.
ad4a90e8266cd39981ff8c502fe75e93ba2e16a5
4806e7cde6d69cd7570098ecca86523666b80175
diff --git a/packages/system/src/xydrag/XYDrag.ts b/packages/system/src/xydrag/XYDrag.ts index c78e103506..fca7a72a04 100644 --- a/packages/system/src/xydrag/XYDrag.ts +++ b/packages/system/src/xydrag/XYDrag.ts @@ -28,17 +28,28 @@ import type { InternalNodeBase, } from '../types'; -export type OnDrag = ( +export ...
[ "packages/system/src/xydrag/XYDrag.ts" ]
[ { "comment": "Hopefully this wont be a problem as `UpdateNodePositions` accepts a generic type based on `InternalNodeBase` and this time we're passing the `NodeType` info through along with it.", "path": "packages/system/src/xydrag/XYDrag.ts", "hunk": "@@ -52,23 +59,23 @@ type StoreItems<OnNodeDrag> = {...
true
xyflow/xyflow
5,105
comment_to_fix
feat(system): updates generic typings for xydrag & xyhandle
Now we're passing both NodeType + EdgeType to `XYDragParams` which will type the underlying store getter as well.
ad4a90e8266cd39981ff8c502fe75e93ba2e16a5
4806e7cde6d69cd7570098ecca86523666b80175
diff --git a/packages/system/src/xydrag/XYDrag.ts b/packages/system/src/xydrag/XYDrag.ts index c78e103506..fca7a72a04 100644 --- a/packages/system/src/xydrag/XYDrag.ts +++ b/packages/system/src/xydrag/XYDrag.ts @@ -28,17 +28,28 @@ import type { InternalNodeBase, } from '../types'; -export type OnDrag = ( +export ...
[ "packages/system/src/xydrag/XYDrag.ts" ]
[ { "comment": "Now we're passing both NodeType + EdgeType to `XYDragParams` which will type the underlying store getter as well.", "path": "packages/system/src/xydrag/XYDrag.ts", "hunk": "@@ -87,14 +94,13 @@ export type DragUpdateParams = {\n nodeClickDistance?: number;\n };\n \n-// eslint-disable-next...
true
xyflow/xyflow
5,778
issue_to_patch
Svelte Flow with Tailwind - Remove scoped styles There are some [odd component style definitions](https://github.com/xyflow/xyflow/blob/1eb9aad2aaa26a9bdb12b93e07eff1dbc8192c6c/packages/svelte/src/lib/container/SvelteFlow/Wrapper.svelte#L143) in the code that prevent tailwind classes from taking precedent even when sc...
Remove unused css variables
fixes #5774 **TODO** We should actually move all of the css into the imported css layer, so we will never run into issues of preventing users from overwriting styles.
0f247a2429e4e4c75047a6c65fe433f8efe46701
109ba13e51fb59fc1b1252cc9acb7c6a6c3d7b61
diff --git a/.changeset/humble-pianos-attack.md b/.changeset/humble-pianos-attack.md new file mode 100644 index 000000000..388d038b1 --- /dev/null +++ b/.changeset/humble-pianos-attack.md @@ -0,0 +1,5 @@ +--- +'@xyflow/svelte': patch +--- + +Remove unused `background-color` CSS variable diff --git a/examples/svelte/src...
[ ".changeset/humble-pianos-attack.md", "examples/svelte/src/routes/examples/overview/Flow.svelte", "packages/svelte/src/lib/container/SvelteFlow/Wrapper.svelte" ]
[]
true
xyflow/xyflow
5,784
issue_to_patch
NodeResizer allows resizing node beyond `node.extent` ### What platform were you using when you found the bug? - React Flow / Svelte Flow version: 12.10.1 - Browser and version: browsers tested (Arc 146.0.7680.76, Chrome 146, Safari 26.3.1 (21623.2.7.11.7)) - OS and version: MacOS 26.3.1 ### Live code example https...
Fix node resizer again
closes #5728 Note: I had to update Svelte & Svelte Kit in the examples to fix an issue
ad4a90e8266cd39981ff8c502fe75e93ba2e16a5
316079afb30f868a2e9e2683b633a61932651e68
diff --git a/.changeset/stupid-planets-warn.md b/.changeset/stupid-planets-warn.md new file mode 100644 index 0000000000..932cd54e05 --- /dev/null +++ b/.changeset/stupid-planets-warn.md @@ -0,0 +1,7 @@ +--- +'@xyflow/system': patch +'@xyflow/react': patch +'@xyflow/svelte': patch +--- + +Fix node resizing possible bey...
[ ".changeset/stupid-planets-warn.md", ".github/workflows/playwright.yml", "examples/astro-xyflow/package.json", "examples/react/package.json", "examples/react/src/examples/NodeResizer/FixedExtentNode.tsx", "examples/react/src/examples/NodeResizer/index.tsx", "examples/react/vite.config.ts", "examples/s...
[]
true
xyflow/xyflow
5,785
issue_to_patch
remove useless promise.resolve calls in async functions
~Merge this only after we have reworked our linting, as it a good example for additional rules~ ~closes https://github.com/xyflow/internal/issues/246~ We decided to merge it now
f5b69701e2495cbfa8937e0c570a971b737239cc
fc16634f9fba0649df1fa6e5f82f07e2d4761829
diff --git a/examples/react/src/examples/UseReactFlow/index.tsx b/examples/react/src/examples/UseReactFlow/index.tsx index 3e1d8f926b..6d5c99f095 100644 --- a/examples/react/src/examples/UseReactFlow/index.tsx +++ b/examples/react/src/examples/UseReactFlow/index.tsx @@ -153,6 +153,7 @@ const UseZoomPanHelperFlow = () =...
[ "examples/react/src/examples/UseReactFlow/index.tsx", "packages/react/src/hooks/useViewportHelper.ts", "packages/react/src/store/index.ts", "packages/svelte/src/lib/hooks/useSvelteFlow.svelte.ts", "packages/svelte/src/lib/store/index.ts", "packages/system/src/utils/graph.ts", "packages/system/src/utils/...
[]
true
xyflow/xyflow
5,791
issue_to_patch
Allow usage of handleId inside of useNodeConnections without specifiying handleType ### Please describe the feature that you want to propose Hi, thank you so much for this great library, just one small suggestion. Currently it is not possible to get all connections to or from a handle if you do not know the handleTy...
fix: add type error when handleId is used without handleType in useNodeConnections
Peter and I chatted, and we decided the best solution to this would be to keep the functionality of useNodeConnections the same and just add a type error to point users in the right direction.
ad4a90e8266cd39981ff8c502fe75e93ba2e16a5
4ea4446aae6eafe1cee40f5dda24d2940ef77f6c
diff --git a/.changeset/clean-eyes-sleep.md b/.changeset/clean-eyes-sleep.md new file mode 100644 index 000000000..edbb46aad --- /dev/null +++ b/.changeset/clean-eyes-sleep.md @@ -0,0 +1,7 @@ +--- +"@xyflow/react": patch +"@xyflow/svelte": patch +"@xyflow/system": patch +--- + +Adds a type error when `handleId` is used...
[ ".changeset/clean-eyes-sleep.md", "packages/react/src/hooks/useNodeConnections.ts", "packages/react/src/index.ts", "packages/svelte/src/lib/hooks/useNodeConnections.svelte.ts", "packages/svelte/src/lib/index.ts", "packages/system/src/types/general.ts" ]
[]
true
xyflow/xyflow
5,790
issue_to_patch
Svelte: fix warnings & control button props
ad4a90e8266cd39981ff8c502fe75e93ba2e16a5
735d2598c1113cf35352cadde5a3f0c29ed7c646
diff --git a/.changeset/chilled-otters-reply.md b/.changeset/chilled-otters-reply.md new file mode 100644 index 0000000000..bac3dbecda --- /dev/null +++ b/.changeset/chilled-otters-reply.md @@ -0,0 +1,5 @@ +--- +'@xyflow/svelte': patch +--- + +Fix control button props not being reactive diff --git a/packages/svelte/src...
[ ".changeset/chilled-otters-reply.md", "packages/svelte/src/lib/components/NodeWrapper/NodeWrapper.svelte", "packages/svelte/src/lib/plugins/Controls/Controls.svelte" ]
[]
true
xyflow/xyflow
5,782
issue_to_patch
chore(gh-actions): cleanup
0f247a2429e4e4c75047a6c65fe433f8efe46701
43c3a39fceb0edc81b6f511e01077ad4046dc53c
diff --git a/.github/actions/ci-checks/action.yml b/.github/actions/ci-checks/action.yml index d4a87a8654..a40ee8364b 100644 --- a/.github/actions/ci-checks/action.yml +++ b/.github/actions/ci-checks/action.yml @@ -1,4 +1,5 @@ name: 'CI checks' +description: 'Checks if the code builds and typechecks' runs: using...
[ ".github/actions/ci-checks/action.yml", ".github/actions/ci-setup/action.yml", ".github/workflows/release.yml" ]
[]
true
xyflow/xyflow
5,776
issue_to_patch
chore(libs): export NodeHandle type
1eb9aad2aaa26a9bdb12b93e07eff1dbc8192c6c
0441e9f9471380b5ba057fc0a6a8cbdc6ff5ed7b
diff --git a/.changeset/fresh-cats-mate.md b/.changeset/fresh-cats-mate.md new file mode 100644 index 000000000..2d41b24dd --- /dev/null +++ b/.changeset/fresh-cats-mate.md @@ -0,0 +1,6 @@ +--- +'@xyflow/react': patch +'@xyflow/svelte': patch +--- + +Export `NodeHandle` type diff --git a/packages/react/src/index.ts b/p...
[ ".changeset/fresh-cats-mate.md", "packages/react/src/index.ts", "packages/svelte/src/lib/index.ts" ]
[]
true
xyflow/xyflow
5,643
issue_to_patch
Generate provenance statement on release to increase security
Following recent hacks on npm packages, it would be greatly appreciated if you could increase the trust level of the npm packages. I added generation of provenance statements as outlined in this guide from npm: https://docs.npmjs.com/generating-provenance-statements
25341c6078d630e40862e75bdde5aa1823d5981c
55340e5e826f2f92bfcafdac6911f7407a4fa5fa
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index bd16a85490..4df4437ff2 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -7,6 +7,9 @@ on: concurrency: ${{ github.workflow }}-${{ github.ref }} +permissions: + id-token: write + jobs: release: ...
[ ".github/workflows/release.yml" ]
[]
true
xyflow/xyflow
5,770
issue_to_patch
chore(gh-actions): update
5ff18c939d6e4f570ba84824d12cc3ed5f2ff57a
34899901b850c7e156f043cf9dff4553173c8889
diff --git a/.github/actions/ci-setup/action.yml b/.github/actions/ci-setup/action.yml index 5ac0769936..902a602895 100644 --- a/.github/actions/ci-setup/action.yml +++ b/.github/actions/ci-setup/action.yml @@ -4,11 +4,11 @@ runs: using: 'composite' steps: - name: Setup pnpm - uses: pnpm/action-setup@v4...
[ ".github/actions/ci-setup/action.yml", ".github/workflows/codespell.yml", ".github/workflows/dispatchWebsiteUpdate.yaml", ".github/workflows/playwright.yml", ".github/workflows/release.yml" ]
[]
true
xyflow/xyflow
5,769
issue_to_patch
Chore/store updater effects
1466dcc8b7ddb0baaae2e4e1a2553fd01c29e027
ad4d547724a1c2debf8eb7c6e117aabbfd601934
diff --git a/.changeset/sweet-terms-exist.md b/.changeset/sweet-terms-exist.md new file mode 100644 index 0000000000..d0603e327a --- /dev/null +++ b/.changeset/sweet-terms-exist.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Use `useEffect` for StoreUpdater to restore previous behaviour diff --git a/packages/r...
[ ".changeset/sweet-terms-exist.md", "packages/react/src/components/StoreUpdater/index.tsx" ]
[]
true
xyflow/xyflow
5,677
issue_to_patch
Does React flow selection rectangle streach and viewport auto panning like https://miro.com/ ?/ ### Please describe the feature that you want to propose i search this but not found any can you add this feature like autoPanOnNodeDrag is in ReactctFlow?? it is like viewport pans when selection start and streach the...
Autopan on rectangle selection
https://github.com/xyflow/xyflow/issues/5597
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/.changeset/eighty-crabs-shake.md b/.changeset/eighty-crabs-shake.md new file mode 100644 index 0000000000..7e7a86c13c --- /dev/null +++ b/.changeset/eighty-crabs-shake.md @@ -0,0 +1,7 @@ +--- +'@xyflow/react': minor +'@xyflow/svelte': minor +'@xyflow/system': patch +--- + +Add `autoPanOnSelection` to auto-...
[ ".changeset/eighty-crabs-shake.md", "examples/react/src/examples/Basic/index.tsx", "examples/svelte/src/routes/examples/overview/Flow.svelte", "packages/react/src/container/FlowRenderer/index.tsx", "packages/react/src/container/GraphView/index.tsx", "packages/react/src/container/Pane/index.tsx", "packag...
[ { "comment": "Hardcoded `true` condition with a comment indicating temporary change. This should either be properly implemented with the correct conditional logic or removed if the condition is no longer needed.\n```suggestion\n if (!userSelectionActive) {\n```", "path": "packages/system/src/xypanzoom/XY...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
Variable declared with `let` instead of `const` for a ref that is never reassigned. Should use `const autoPanId = useRef<number>(0);` ```suggestion const autoPanId = useRef<number>(0); ```
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/react/src/container/Pane/index.tsx b/packages/react/src/container/Pane/index.tsx index 32a0e6df37..8552cbf4d7 100644 --- a/packages/react/src/container/Pane/index.tsx +++ b/packages/react/src/container/Pane/index.tsx @@ -1,4 +1,5 @@ import { + useEffect, useRef, type MouseEventHandler, ...
[ "packages/react/src/container/Pane/index.tsx" ]
[ { "comment": "Variable declared with `let` instead of `const` for a ref that is never reassigned. Should use `const autoPanId = useRef<number>(0);`\n```suggestion\n const autoPanId = useRef<number>(0);\n```", "path": "packages/react/src/container/Pane/index.tsx", "hunk": "@@ -75,8 +80,12 @@ export func...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
The destructured values `setViewport` and `getViewport` from `useReactFlow()` are not used anywhere in the component. Remove this unused destructuring.
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/react/src/container/Pane/index.tsx b/packages/react/src/container/Pane/index.tsx index 32a0e6df37..8552cbf4d7 100644 --- a/packages/react/src/container/Pane/index.tsx +++ b/packages/react/src/container/Pane/index.tsx @@ -1,4 +1,5 @@ import { + useEffect, useRef, type MouseEventHandler, ...
[ "packages/react/src/container/Pane/index.tsx" ]
[ { "comment": "The destructured values `setViewport` and `getViewport` from `useReactFlow()` are not used anywhere in the component. Remove this unused destructuring.", "path": "packages/react/src/container/Pane/index.tsx", "hunk": "@@ -87,6 +96,12 @@ export function Pane({\n // Used to prevent click e...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
React public prop name is introduced as `autopanOnSelection`, but existing props use `autoPan...` (e.g. `autoPanOnConnect`, `autoPanOnNodeDrag`) and Svelte uses `autoPanOnSelection`. This inconsistency will be confusing for consumers and makes the API harder to discover; consider renaming to `autoPanOnSelection` and up...
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/react/src/types/component-props.ts b/packages/react/src/types/component-props.ts index effc7ca66c..4ff095b24f 100644 --- a/packages/react/src/types/component-props.ts +++ b/packages/react/src/types/component-props.ts @@ -634,6 +634,12 @@ export interface ReactFlowProps<NodeType extends Node = Node...
[ "packages/react/src/types/component-props.ts" ]
[ { "comment": "React public prop name is introduced as `autopanOnSelection`, but existing props use `autoPan...` (e.g. `autoPanOnConnect`, `autoPanOnNodeDrag`) and Svelte uses `autoPanOnSelection`. This inconsistency will be confusing for consumers and makes the API harder to discover; consider renaming to `auto...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
`autopanOnSelection` is threaded through the React component tree, but the naming is inconsistent with existing `autoPan...` props and the Svelte implementation (`autoPanOnSelection`). If this is meant to be the same feature across packages, consider renaming this prop to `autoPanOnSelection` everywhere (including exam...
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/react/src/container/ReactFlow/index.tsx b/packages/react/src/container/ReactFlow/index.tsx index b04f295589..ab7834c16f 100644 --- a/packages/react/src/container/ReactFlow/index.tsx +++ b/packages/react/src/container/ReactFlow/index.tsx @@ -132,6 +132,7 @@ function ReactFlow<NodeType extends Node ...
[ "packages/react/src/container/ReactFlow/index.tsx" ]
[ { "comment": "`autopanOnSelection` is threaded through the React component tree, but the naming is inconsistent with existing `autoPan...` props and the Svelte implementation (`autoPanOnSelection`). If this is meant to be the same feature across packages, consider renaming this prop to `autoPanOnSelection` ever...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
The auto-pan loop calls `panBy({ x, y })` and then unconditionally recomputes/commits the selection rectangle in the `.then(...)` callback. When `calcAutoPan` returns `[0, 0]` (cursor not near edges), `panBy` resolves `false` (no viewport change), but `commitUserSelectionRect` will still run every animation frame, pote...
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/react/src/container/Pane/index.tsx b/packages/react/src/container/Pane/index.tsx index 32a0e6df37..8552cbf4d7 100644 --- a/packages/react/src/container/Pane/index.tsx +++ b/packages/react/src/container/Pane/index.tsx @@ -1,4 +1,5 @@ import { + useEffect, useRef, type MouseEventHandler, ...
[ "packages/react/src/container/Pane/index.tsx" ]
[ { "comment": "The auto-pan loop calls `panBy({ x, y })` and then unconditionally recomputes/commits the selection rectangle in the `.then(...)` callback. When `calcAutoPan` returns `[0, 0]` (cursor not near edges), `panBy` resolves `false` (no viewport change), but `commitUserSelectionRect` will still run every...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
Typo in comment: "screen cordinates" → "screen coordinates".
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/react/src/container/Pane/index.tsx b/packages/react/src/container/Pane/index.tsx index 32a0e6df37..8552cbf4d7 100644 --- a/packages/react/src/container/Pane/index.tsx +++ b/packages/react/src/container/Pane/index.tsx @@ -1,4 +1,5 @@ import { + useEffect, useRef, type MouseEventHandler, ...
[ "packages/react/src/container/Pane/index.tsx" ]
[ { "comment": "Typo in comment: \"screen cordinates\" → \"screen coordinates\".", "path": "packages/react/src/container/Pane/index.tsx", "hunk": "@@ -157,45 +183,34 @@ export function Pane({\n }\n };\n \n- const onPointerMove = (event: ReactPointerEvent): void => {\n+ // We commit the user select...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
SvelteFlowProps JSDoc says `autoPanOnSelection` defaults to `true`, but `SvelteFlow.svelte` currently defaults it to `false` and passes it down, so the documented default doesn’t match runtime behavior. Either change the default in `SvelteFlow.svelte` to `true` or update this doc comment to `@default false` (and ensure...
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/svelte/src/lib/container/SvelteFlow/types.ts b/packages/svelte/src/lib/container/SvelteFlow/types.ts index 8e5c6c8c52..ba22fddd66 100644 --- a/packages/svelte/src/lib/container/SvelteFlow/types.ts +++ b/packages/svelte/src/lib/container/SvelteFlow/types.ts @@ -353,6 +353,12 @@ export type SvelteFl...
[ "packages/svelte/src/lib/container/SvelteFlow/types.ts" ]
[ { "comment": "SvelteFlowProps JSDoc says `autoPanOnSelection` defaults to `true`, but `SvelteFlow.svelte` currently defaults it to `false` and passes it down, so the documented default doesn’t match runtime behavior. Either change the default in `SvelteFlow.svelte` to `true` or update this doc comment to `@defa...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
The auto-pan loop calls `store.panBy({ x, y })` and then recomputes/commits the selection rectangle in the `.then(...)` callback even when `calcAutoPan` returns `[0, 0]`. This can trigger unnecessary selection computations and store updates on every animation frame while selecting. Consider skipping `panBy`/`commitUser...
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/svelte/src/lib/container/Pane/Pane.svelte b/packages/svelte/src/lib/container/Pane/Pane.svelte index b7de8cfac6..2728dff560 100644 --- a/packages/svelte/src/lib/container/Pane/Pane.svelte +++ b/packages/svelte/src/lib/container/Pane/Pane.svelte @@ -39,7 +39,16 @@ </script> <script lang="ts" ge...
[ "packages/svelte/src/lib/container/Pane/Pane.svelte" ]
[ { "comment": "The auto-pan loop calls `store.panBy({ x, y })` and then recomputes/commits the selection rectangle in the `.then(...)` callback even when `calcAutoPan` returns `[0, 0]`. This can trigger unnecessary selection computations and store updates on every animation frame while selecting. Consider skippi...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
The example uses `autopanOnSelection`, but the intended public prop name should likely match the existing `autoPan...` naming scheme (`autoPanOnConnect`, `autoPanOnNodeDrag`) and the Svelte prop (`autoPanOnSelection`). If the prop is renamed for consistency, please update this example accordingly. ```suggestion ...
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/examples/react/src/examples/Basic/index.tsx b/examples/react/src/examples/Basic/index.tsx index a24c908c89..ac86be9735 100644 --- a/examples/react/src/examples/Basic/index.tsx +++ b/examples/react/src/examples/Basic/index.tsx @@ -162,6 +162,7 @@ const BasicFlow = () => { selectNodesOnDrag={false} ...
[ "examples/react/src/examples/Basic/index.tsx" ]
[ { "comment": "The example uses `autopanOnSelection`, but the intended public prop name should likely match the existing `autoPan...` naming scheme (`autoPanOnConnect`, `autoPanOnNodeDrag`) and the Svelte prop (`autoPanOnSelection`). If the prop is renamed for consistency, please update this example accordingly....
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
`autoPan()` schedules the next `requestAnimationFrame` immediately after starting `store.panBy(...)`. If `panBy` is async (as in the system store), this can overlap multiple pan operations and cause selection-rect commits to run out of order. Consider awaiting the pan promise (or using an `inFlight` guard) before sched...
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/svelte/src/lib/container/Pane/Pane.svelte b/packages/svelte/src/lib/container/Pane/Pane.svelte index b7de8cfac6..2728dff560 100644 --- a/packages/svelte/src/lib/container/Pane/Pane.svelte +++ b/packages/svelte/src/lib/container/Pane/Pane.svelte @@ -39,7 +39,16 @@ </script> <script lang="ts" ge...
[ "packages/svelte/src/lib/container/Pane/Pane.svelte" ]
[ { "comment": "`autoPan()` schedules the next `requestAnimationFrame` immediately after starting `store.panBy(...)`. If `panBy` is async (as in the system store), this can overlap multiple pan operations and cause selection-rect commits to run out of order. Consider awaiting the pan promise (or using an `inFligh...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
_⚠️ Potential issue_ | _🔴 Critical_ **Don't reschedule auto-pan after pointer-up.** `onPointerUp()` cancels the current frame, but an already in-flight `store.panBy().then(...)` still queues a fresh RAF here after `userSelectionFlowOrigin` has been cleared. That can leave auto-pan running against the stale `position...
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/svelte/src/lib/container/Pane/Pane.svelte b/packages/svelte/src/lib/container/Pane/Pane.svelte index b7de8cfac6..2728dff560 100644 --- a/packages/svelte/src/lib/container/Pane/Pane.svelte +++ b/packages/svelte/src/lib/container/Pane/Pane.svelte @@ -39,7 +39,16 @@ </script> <script lang="ts" ge...
[ "packages/svelte/src/lib/container/Pane/Pane.svelte" ]
[ { "comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n**Don't reschedule auto-pan after pointer-up.**\n\n`onPointerUp()` cancels the current frame, but an already in-flight `store.panBy().then(...)` still queues a fresh RAF here after `userSelectionFlowOrigin` has been cleared. That can leave auto-pan running a...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
`autoPan()` schedules `requestAnimationFrame` from within a `panBy(...).then(...)` callback, but the only cancellation is in `onPointerUp`. If the pointer is cancelled (e.g. touch gesture/OS interruption) or the component unmounts during an active selection, the RAF loop can continue running and keep calling `panBy`. C...
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/react/src/container/Pane/index.tsx b/packages/react/src/container/Pane/index.tsx index 32a0e6df37..8552cbf4d7 100644 --- a/packages/react/src/container/Pane/index.tsx +++ b/packages/react/src/container/Pane/index.tsx @@ -1,4 +1,5 @@ import { + useEffect, useRef, type MouseEventHandler, ...
[ "packages/react/src/container/Pane/index.tsx" ]
[ { "comment": "`autoPan()` schedules `requestAnimationFrame` from within a `panBy(...).then(...)` callback, but the only cancellation is in `onPointerUp`. If the pointer is cancelled (e.g. touch gesture/OS interruption) or the component unmounts during an active selection, the RAF loop can continue running and k...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
`autoPan()` calls `panBy({ x, y })` every animation frame, even when `calcAutoPan(...)` returns `[0, 0]`. `panBySystem` will early-return, but this still creates a Promise + microtask per frame. Consider skipping the `panBy` call when both deltas are zero and directly scheduling the next `requestAnimationFrame` to redu...
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/react/src/container/Pane/index.tsx b/packages/react/src/container/Pane/index.tsx index 32a0e6df37..8552cbf4d7 100644 --- a/packages/react/src/container/Pane/index.tsx +++ b/packages/react/src/container/Pane/index.tsx @@ -1,4 +1,5 @@ import { + useEffect, useRef, type MouseEventHandler, ...
[ "packages/react/src/container/Pane/index.tsx" ]
[ { "comment": "`autoPan()` calls `panBy({ x, y })` every animation frame, even when `calcAutoPan(...)` returns `[0, 0]`. `panBySystem` will early-return, but this still creates a Promise + microtask per frame. Consider skipping the `panBy` call when both deltas are zero and directly scheduling the next `requestA...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
`autoPan()` schedules a `requestAnimationFrame` loop and is only cancelled in `onPointerUp`. If the pointer is cancelled (touch gesture/OS interruption) or the component is destroyed while a selection is active, the RAF loop can continue and keep calling `store.panBy`. Consider adding an `onpointercancel` handler that ...
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/svelte/src/lib/container/Pane/Pane.svelte b/packages/svelte/src/lib/container/Pane/Pane.svelte index b7de8cfac6..2728dff560 100644 --- a/packages/svelte/src/lib/container/Pane/Pane.svelte +++ b/packages/svelte/src/lib/container/Pane/Pane.svelte @@ -39,7 +39,16 @@ </script> <script lang="ts" ge...
[ "packages/svelte/src/lib/container/Pane/Pane.svelte" ]
[ { "comment": "`autoPan()` schedules a `requestAnimationFrame` loop and is only cancelled in `onPointerUp`. If the pointer is cancelled (touch gesture/OS interruption) or the component is destroyed while a selection is active, the RAF loop can continue and keep calling `store.panBy`. Consider adding an `onpointe...
true
xyflow/xyflow
5,677
comment_to_fix
Autopan on rectangle selection
`autoPan()` calls `store.panBy({ x, y })` every animation frame, even when `calcAutoPan(...)` returns `[0, 0]`. `panBySystem` will early-return, but this still adds a Promise/microtask per frame. Consider skipping the `panBy` call when both deltas are zero and directly scheduling the next `requestAnimationFrame` to red...
6ec8214cf3aab8da3092261d8bbedcfedef44746
41d05240d32f87848ec8f6b36f4b62ea3ef09236
diff --git a/packages/svelte/src/lib/container/Pane/Pane.svelte b/packages/svelte/src/lib/container/Pane/Pane.svelte index b7de8cfac6..2728dff560 100644 --- a/packages/svelte/src/lib/container/Pane/Pane.svelte +++ b/packages/svelte/src/lib/container/Pane/Pane.svelte @@ -39,7 +39,16 @@ </script> <script lang="ts" ge...
[ "packages/svelte/src/lib/container/Pane/Pane.svelte" ]
[ { "comment": "`autoPan()` calls `store.panBy({ x, y })` every animation frame, even when `calcAutoPan(...)` returns `[0, 0]`. `panBySystem` will early-return, but this still adds a Promise/microtask per frame. Consider skipping the `panBy` call when both deltas are zero and directly scheduling the next `request...
true
xyflow/xyflow
5,731
issue_to_patch
Release packages
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will ...
613ad309998563c1009397d5312e23f302670554
ba0a3612fdec69bd3e63046cb25c2b94d30ea672
diff --git a/.changeset/allow-undefined-builtin-node-type.md b/.changeset/allow-undefined-builtin-node-type.md deleted file mode 100644 index b89e83b1b5..0000000000 --- a/.changeset/allow-undefined-builtin-node-type.md +++ /dev/null @@ -1,6 +0,0 @@ ---- -"@xyflow/react": patch -"@xyflow/svelte": patch ---- - -Allow `ty...
[ ".changeset/allow-undefined-builtin-node-type.md", ".changeset/brown-shrimps-exist.md", ".changeset/dull-cows-sneeze.md", ".changeset/fix-smoothstep-edge-rounding.md", ".changeset/fix-store-reset-timing.md", ".changeset/good-lamps-think.md", "packages/react/CHANGELOG.md", "packages/react/package.json"...
[]
true
xyflow/xyflow
5,733
issue_to_patch
fix(react): prevent empty store during ReactFlow remount
## Problem When `<ReactFlow>` unmounts, `StoreUpdater`'s cleanup calls `reset()` which empties the store (nodes, edges, nodeLookup, etc.). On the subsequent mount, custom node effects that read from the store see empty data because `StoreUpdater` hasn't repopulated it yet. Remounts can happen in real applications for...
916c557144c6da2eeb376d5b61701099aa9abe03
64115cd086d2c04235f1cae80acb45455fd0de49
diff --git a/.changeset/fix-store-reset-timing.md b/.changeset/fix-store-reset-timing.md new file mode 100644 index 0000000000..bbb4027171 --- /dev/null +++ b/.changeset/fix-store-reset-timing.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Fix empty store during ReactFlow remount by reordering StoreUpdater bef...
[ ".changeset/fix-store-reset-timing.md", "examples/react/cypress/components/reactflow/storeAvailabilityOnRemount.cy.tsx", "packages/react/src/components/StoreUpdater/index.tsx", "packages/react/src/container/ReactFlow/index.tsx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Assert a fresh post-remount invocation.**\n\nThese checks can still pass if the click never produces another `CheckerNode` effect, because they keep matching the calls from the initial mount. Reset the spy history (or assert the call count increases) before c...
true
xyflow/xyflow
5,733
comment_to_fix
fix(react): prevent empty store during ReactFlow remount
_⚠️ Potential issue_ | _🟡 Minor_ **Assert a fresh post-remount invocation.** These checks can still pass if the click never produces another `CheckerNode` effect, because they keep matching the calls from the initial mount. Reset the spy history (or assert the call count increases) before clicking so this actually p...
916c557144c6da2eeb376d5b61701099aa9abe03
64115cd086d2c04235f1cae80acb45455fd0de49
diff --git a/examples/react/cypress/components/reactflow/storeAvailabilityOnRemount.cy.tsx b/examples/react/cypress/components/reactflow/storeAvailabilityOnRemount.cy.tsx new file mode 100644 index 0000000000..af1a2acb87 --- /dev/null +++ b/examples/react/cypress/components/reactflow/storeAvailabilityOnRemount.cy.tsx @...
[ "examples/react/cypress/components/reactflow/storeAvailabilityOnRemount.cy.tsx" ]
[ { "comment": "_⚠️ Potential issue_ | _🟡 Minor_\n\n**Assert a fresh post-remount invocation.**\n\nThese checks can still pass if the click never produces another `CheckerNode` effect, because they keep matching the calls from the initial mount. Reset the spy history (or assert the call count increases) before c...
true
xyflow/xyflow
5,735
issue_to_patch
Explicitly allow missing `type` field in BuiltInNode type definition
This improves the DX in cases like this: ```ts const initialNodes: BuiltInNode[] = [ // ~~~~~~~~~~~~~ // TS error here currently, because these nodes // don't explicitly set `type: "default"` { id: "1", position: { x: 0, y: 0 }, data: { label: "Node 1" } },...
f2831bdf31ae4cd1c19eaa2bda6617f3d651f88a
a6c938fb2e5ed030512ef75d665ac80dc3a66bc6
diff --git a/.changeset/allow-undefined-builtin-node-type.md b/.changeset/allow-undefined-builtin-node-type.md new file mode 100644 index 0000000000..b89e83b1b5 --- /dev/null +++ b/.changeset/allow-undefined-builtin-node-type.md @@ -0,0 +1,6 @@ +--- +"@xyflow/react": patch +"@xyflow/svelte": patch +--- + +Allow `type` ...
[ ".changeset/allow-undefined-builtin-node-type.md", "packages/react/src/types/nodes.ts", "packages/svelte/src/lib/types/nodes.ts" ]
[]
true
xyflow/xyflow
5,727
issue_to_patch
Set `nodesSelectionActive` to `false` when zero selected nodes remain in flow
This is an attempt at resolving https://github.com/xyflow/xyflow/issues/5726 ### Context It is possible to end up in a state where you no longer have any selected nodes in the flow, but the internal `nodesSelectionActive` flag remains true. As a result, programmatically selecting a new node with a select node chang...
916c557144c6da2eeb376d5b61701099aa9abe03
0e48d846fa6e10ac7eed48bf19312ead2274f3ae
diff --git a/.changeset/good-lamps-think.md b/.changeset/good-lamps-think.md new file mode 100644 index 0000000000..fa33aaa46d --- /dev/null +++ b/.changeset/good-lamps-think.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Ensure visual nodes selection state is cleared when zero selected nodes remain in the flo...
[ ".changeset/good-lamps-think.md", "packages/react/src/store/index.ts", "packages/react/src/store/initialState.ts", "packages/svelte/src/lib/store/initial-store.svelte.ts", "packages/system/src/utils/store.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n**Don't gate the state repair behind selection-change listeners.**\n\nThis reset only runs when `SelectionListenerInner` is mounted, but `SelectionListener` returns it only if `onSelectionChange` or `onSelectionChangeHandlers` exist (Lines 74-76). In flows that...
true
xyflow/xyflow
5,718
issue_to_patch
Add easing option to setZoom function
6ec8214cf3aab8da3092261d8bbedcfedef44746
f31f819a1b616ff2d56ec74c8db38ce641c0d7cd
diff --git a/packages/svelte/src/lib/hooks/useSvelteFlow.svelte.ts b/packages/svelte/src/lib/hooks/useSvelteFlow.svelte.ts index 19307f1fb..a8a031e66 100644 --- a/packages/svelte/src/lib/hooks/useSvelteFlow.svelte.ts +++ b/packages/svelte/src/lib/hooks/useSvelteFlow.svelte.ts @@ -343,7 +343,7 @@ export function useSvel...
[ "packages/svelte/src/lib/hooks/useSvelteFlow.svelte.ts" ]
[]
true
xyflow/xyflow
5,730
issue_to_patch
Not all edge breaks are rounded ### What platform were you using when you found the bug? - React Flow version: `"@xyflow/react": "^12.10.0"` - Browser and version: Chrome latest stable - OS and version: Mac OS ### Live code example _No response_ ### Describe the Bug Hello We are using custom edge component where...
Fix missing border radius on smooth step edge bends
Fixes #5705 ## Problem When using `getSmoothStepPath` with extreme `stepPosition` values (e.g. `1` or `0`), some edge bends are rendered with sharp corners instead of rounded ones. ## Root Cause Extreme `stepPosition` values cause intermediate path points to overlap with the gapped source/target points. Whe...
6ec8214cf3aab8da3092261d8bbedcfedef44746
f91ef16e83f8f18426eb047fe82d5449f67d08ef
diff --git a/.changeset/fix-smoothstep-edge-rounding.md b/.changeset/fix-smoothstep-edge-rounding.md new file mode 100644 index 0000000000..d768cb1225 --- /dev/null +++ b/.changeset/fix-smoothstep-edge-rounding.md @@ -0,0 +1,5 @@ +--- +"@xyflow/system": patch +--- + +Fix missing border radius on `getSmoothStepPath` edg...
[ ".changeset/fix-smoothstep-edge-rounding.md", "packages/system/src/utils/edges/smoothstep-edge.ts" ]
[]
true
xyflow/xyflow
5,720
issue_to_patch
Add codespell support with configuration and fixes
Add codespell configuration and fix existing typos. More about codespell: https://github.com/codespell-project/codespell I personally introduced it to dozens if not hundreds of projects already and so far only positive feedback. CI workflow has 'permissions' set only to 'read' so also should be safe. ## Cha...
6ec8214cf3aab8da3092261d8bbedcfedef44746
b29e9a8ae4929c772abff6d35c9d5044e7259f91
diff --git a/.codespellrc b/.codespellrc new file mode 100644 index 0000000000..74930595dd --- /dev/null +++ b/.codespellrc @@ -0,0 +1,8 @@ +[codespell] +# Ref: https://github.com/codespell-project/codespell#using-a-config-file +skip = .git,.gitattributes,.gitignore,package-lock.json,*-lock.yaml,*.css,.codespellrc,.npm...
[ ".codespellrc", ".github/workflows/codespell.yml", ".gitignore", "CODE_OF_CONDUCT.md", "examples/README.md", "examples/svelte/src/routes/examples/add-node-on-drop/Flow.svelte", "packages/react/CHANGELOG.md", "packages/react/src/hooks/useHandleConnections.ts", "packages/react/src/store/index.ts", "...
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`codespell skip glob pattern .git* matching behavior documentation`\n\n💡 Result:\n\n`codespell --skip` takes a comma-separated list of glob patterns. (The README just says “It accepts globs as...
diff --git a/tests/playwright/README.md b/tests/playwright/README.md index 7b705968c8..5277454d1c 100644 --- a/tests/playwright/README.md +++ b/tests/playwright/README.md @@ -1,5 +1,5 @@ # End-to-End with Playwright -Here you can find our framework independant E2E tests written with [playwright](https://playwright.dev...
true
xyflow/xyflow
5,720
comment_to_fix
Add codespell support with configuration and fixes
_⚠️ Potential issue_ | _🟠 Major_ <details> <summary>🧩 Analysis chain</summary> 🌐 Web query: `codespell skip glob pattern .git* matching behavior documentation` 💡 Result: `codespell --skip` takes a comma-separated list of glob patterns. (The README just says “It accepts globs as well.”) [1] The actual matching...
6ec8214cf3aab8da3092261d8bbedcfedef44746
b29e9a8ae4929c772abff6d35c9d5044e7259f91
diff --git a/.codespellrc b/.codespellrc new file mode 100644 index 0000000000..74930595dd --- /dev/null +++ b/.codespellrc @@ -0,0 +1,8 @@ +[codespell] +# Ref: https://github.com/codespell-project/codespell#using-a-config-file +skip = .git,.gitattributes,.gitignore,package-lock.json,*-lock.yaml,*.css,.codespellrc,.npm...
[ ".codespellrc" ]
[ { "comment": "_⚠️ Potential issue_ | _🟠 Major_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n🌐 Web query:\n\n`codespell skip glob pattern .git* matching behavior documentation`\n\n💡 Result:\n\n`codespell --skip` takes a comma-separated list of glob patterns. (The README just says “It accepts globs as...
true
xyflow/xyflow
5,722
issue_to_patch
fix: screenToFlowPosition add snapGrid types
# Changes fix screenToFlowPosition type Definition, add `snapGrid` params in the options # Summary when I use `useReactFlow().screenToFlowPosition`, It give me a type error, Refer **useViewportHelper.ts** <img width="486" height="208" alt="image" src="https://github.com/user-attachments/assets/0ba537fd-d65b-4...
6ec8214cf3aab8da3092261d8bbedcfedef44746
8c9b7e726e0bb79871c85017dace0f1ccf1b478c
diff --git a/.changeset/brown-shrimps-exist.md b/.changeset/brown-shrimps-exist.md new file mode 100644 index 0000000000..269cd85126 --- /dev/null +++ b/.changeset/brown-shrimps-exist.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Add `snapGrid` to `screenToFlowPosition` options diff --git a/packages/react/src...
[ ".changeset/brown-shrimps-exist.md", "packages/react/src/types/general.ts" ]
[]
true
xyflow/xyflow
5,723
issue_to_patch
Pass options to viewport helper functions
6ec8214cf3aab8da3092261d8bbedcfedef44746
77cb125952eecb229be3081ffa3b4a61e2137b63
diff --git a/.changeset/dull-cows-sneeze.md b/.changeset/dull-cows-sneeze.md new file mode 100644 index 0000000000..4ad1e4b186 --- /dev/null +++ b/.changeset/dull-cows-sneeze.md @@ -0,0 +1,6 @@ +--- +'@xyflow/react': patch +'@xyflow/svelte': patch +--- + +Pass options to useReactFlow/useSvelteFlow viewport helper funct...
[ ".changeset/dull-cows-sneeze.md", "packages/react/src/hooks/useViewportHelper.ts", "packages/svelte/src/lib/hooks/useSvelteFlow.svelte.ts" ]
[]
true
xyflow/xyflow
5,691
issue_to_patch
Release packages
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will ...
ac89f9fa631d2374ddbede0b230762c38aa05ed7
81a284a27c53c9d1279e5081d4fc73cd31396293
diff --git a/.changeset/blue-shirts-beg.md b/.changeset/blue-shirts-beg.md deleted file mode 100644 index 21713fb514..0000000000 --- a/.changeset/blue-shirts-beg.md +++ /dev/null @@ -1,6 +0,0 @@ ---- -'@xyflow/react': patch -'@xyflow/svelte': patch ---- - -Keep `onConnectEnd` and `isValidConnection` up to date in an on...
[ ".changeset/blue-shirts-beg.md", ".changeset/empty-paws-cough.md", ".changeset/friendly-grapes-lay.md", ".changeset/old-laws-melt.md", ".changeset/strong-suns-grow.md", ".changeset/tender-ways-attend.md", ".changeset/wicked-sloths-greet.md", "packages/react/CHANGELOG.md", "packages/react/package.jso...
[]
true
xyflow/xyflow
5,684
issue_to_patch
Rectangular selection blocks dragging new preselected nodes ### What platform were you using when you found the bug? - React Flow / Svelte Flow version: 12.3.5 - Browser and version: Firefox 132.0.2 (64-bit) - OS and version: Windows 11 Pro 23H2 ### Live code example https://codesandbox.io/p/sandbox/upbeat-vaug...
fix: ensure drag handlers update when nodes selection changes programmatically
Fixes #4841 ## Problem When a selection rectangle was already displayed (e.g., after box selection), and then nodes were programmatically selected (e.g., adding a new node with `selected: true`), the selection rectangle would move to the new node's position but dragging it would not work. ## Root Cause The ...
cf2d4be3f57047ae02d08eed49dc640e89a2ef14
cb41f444eb51354c477681447c363084d507e953
diff --git a/.changeset/tender-ways-attend.md b/.changeset/tender-ways-attend.md new file mode 100644 index 0000000000..5973788497 --- /dev/null +++ b/.changeset/tender-ways-attend.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Consolidate drag handler effects in useDrag to fix programmatic selection issues di...
[ ".changeset/tender-ways-attend.md", "examples/react/src/App/routes.ts", "examples/react/src/examples/NodeSelectionBug/index.tsx", "packages/react/src/components/NodesSelection/index.tsx", "packages/react/src/hooks/useDrag.ts" ]
[]
true
xyflow/xyflow
5,704
issue_to_patch
Regression: onConnectEnd points to old reference (#2841) ### What platform were you using when you found the bug? - React Flow / Svelte Flow version: @xyflow/react 12.0.0 - current (12.9.2) - Browser and version: Firefox 144.0 / Chromium 141.0.7390.122 - OS and version: manjaro linux ### Live code example https://...
Fix old callback references passed to XYHandle
closes #5608 Possibly also happens for `onNodesChange` but I weren't able to reproduce it yet.
7813d07345250d38b6fb292cbf4da58cc9f6a5df
e3c1f42e9a32b07f1f1ef65ee9685a1c34fa017d
diff --git a/.changeset/blue-shirts-beg.md b/.changeset/blue-shirts-beg.md new file mode 100644 index 0000000000..21713fb514 --- /dev/null +++ b/.changeset/blue-shirts-beg.md @@ -0,0 +1,6 @@ +--- +'@xyflow/react': patch +'@xyflow/svelte': patch +--- + +Keep `onConnectEnd` and `isValidConnection` up to date in an ongoin...
[ ".changeset/blue-shirts-beg.md", "packages/react/src/components/EdgeWrapper/EdgeUpdateAnchors.tsx", "packages/react/src/components/Handle/index.tsx", "packages/svelte/src/lib/components/EdgeReconnectAnchor/EdgeReconnectAnchor.svelte", "packages/svelte/src/lib/components/Handle/Handle.svelte" ]
[]
true
xyflow/xyflow
5,703
issue_to_patch
useNodesData type not narrowed down properly ### What platform were you using when you found the bug? - React Flow version: 12.10.0 - Browser and version: Chromium 143.0.7499.40 - OS and version: Arch Linux - Typescript 5.9.3; node 22.14 ### Live code example https://reactflow.dev/learn/advanced-use/typescript#hoo...
Improve return type of useNodesData
closes #5657
7813d07345250d38b6fb292cbf4da58cc9f6a5df
ce6c869df40b2b013484808c742ca508da4a591f
diff --git a/.changeset/old-laws-melt.md b/.changeset/old-laws-melt.md new file mode 100644 index 0000000000..9025e00d0f --- /dev/null +++ b/.changeset/old-laws-melt.md @@ -0,0 +1,8 @@ +--- +'@xyflow/react': patch +'@xyflow/svelte': patch +'@xyflow/system': patch +--- + +Improve return type of useNodesData. Now you can...
[ ".changeset/old-laws-melt.md", "examples/react/src/examples/UseNodesData/TextNode.tsx", "examples/react/src/examples/UseNodesData/UppercaseNode.tsx", "examples/svelte/src/routes/examples/usenodesdata/UppercaseNode.svelte", "packages/react/src/hooks/useNodesData.ts", "packages/svelte/src/lib/hooks/useNodes...
[]
true
xyflow/xyflow
5,698
issue_to_patch
Svelte Flow child nodes not updated correctly in minimap ### What platform were you using when you found the bug? - React Flow / Svelte Flow version: - Browser and version: - OS and version: ### Live code example _No response_ ### Describe the Bug - ### Steps to reproduce the bug or issue - ### Expected beh...
Fix/svelte subflow minimap
closes #5653
be40c34010e8069f0249f50607df4320339936f8
7eeebc9c04ce88f821363e3ea83e4dae36e04c45
diff --git a/.changeset/wicked-sloths-greet.md b/.changeset/wicked-sloths-greet.md new file mode 100644 index 0000000000..5c3b6fd6b9 --- /dev/null +++ b/.changeset/wicked-sloths-greet.md @@ -0,0 +1,5 @@ +--- +'@xyflow/svelte': patch +--- + +Fix child nodes not updating on the Minimap when parent is dragged diff --git a...
[ ".changeset/wicked-sloths-greet.md", "packages/svelte/src/lib/plugins/Minimap/Minimap.svelte", "packages/svelte/src/lib/plugins/Minimap/MinimapNode.svelte", "packages/svelte/src/lib/plugins/Minimap/types.ts" ]
[]
true
xyflow/xyflow
5,682
issue_to_patch
Prevent unnecessary updates when selectNodesOnDrag = false
Updated `unselectNodesAndEdges` so it changes only those nodes and edges that are selected and skips those that are unselected. This prevents re-rendering of all nodes and edges on drag start when `selectNodesOnDrag` is set to `false`. It fixes this performance issue – https://github.com/xyflow/xyflow/issues/1876#is...
cf2d4be3f57047ae02d08eed49dc640e89a2ef14
89062ef506a0235f15be46412b8689c3051d32a3
diff --git a/.changeset/friendly-grapes-lay.md b/.changeset/friendly-grapes-lay.md new file mode 100644 index 0000000000..b092cc2547 --- /dev/null +++ b/.changeset/friendly-grapes-lay.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Prevent unnecessary updates when selectNodesOnDrag = false diff --git a/packages...
[ ".changeset/friendly-grapes-lay.md", "packages/react/src/store/index.ts" ]
[]
true
xyflow/xyflow
5,688
issue_to_patch
Error thrown on nodeLookup access when conditionally rendering a React Flow instance ### What platform were you using when you found the bug? - React Flow / Svelte Flow version: 12.10.0 - Browser and version: Chrome version - OS and version: Windows 11 Pro OS Build 26100.7171 ### Live code example https://github....
handle undefined node in NodeComponentWrapperInner
This PR attempts to fix #5651. It seems that when ReactFlow unmounts, the store gets reset and nodeLookup is cleared. The MiniMap selector appears to still run one more time against the empty lookup, and the non-null assertion on nodeLookup.get(id)! throws. The bug was likely already present, recent changes probably ...
cf2d4be3f57047ae02d08eed49dc640e89a2ef14
2db23d9eab24c34441d8452c1b992b9c5a520a46
diff --git a/packages/react/src/additional-components/MiniMap/MiniMapNodes.tsx b/packages/react/src/additional-components/MiniMap/MiniMapNodes.tsx index e96dd9f611..0d217943dc 100644 --- a/packages/react/src/additional-components/MiniMap/MiniMapNodes.tsx +++ b/packages/react/src/additional-components/MiniMap/MiniMapNod...
[ "packages/react/src/additional-components/MiniMap/MiniMapNodes.tsx" ]
[]
true
xyflow/xyflow
5,692
issue_to_patch
Fix exception unmounting
53dd004ab79e0ca0fe2a0519ded9836fd1bd8ac5
49646858f951455921aedbb83725b4225dbdef9d
diff --git a/.changeset/strong-suns-grow.md b/.changeset/strong-suns-grow.md new file mode 100644 index 0000000000..67d773bcba --- /dev/null +++ b/.changeset/strong-suns-grow.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Handle undefined node in mini map diff --git a/packages/react/src/additional-components/M...
[ ".changeset/strong-suns-grow.md", "packages/react/src/additional-components/MiniMap/MiniMapNodes.tsx" ]
[]
true
xyflow/xyflow
5,687
issue_to_patch
Pinch-to-zoom lags in Safari if panOnScroll is enabled ### What platform were you using when you found the bug? - React Flow / Svelte Flow version: React Flow 12.10.0 - Browser and version: Safari 26.2 - OS and version: macOS Tahoe 26.2 ### Live code example https://codesandbox.io/p/devbox/fast-bird-xnskv8?workspac...
Optimize zooming when panOnScroll is enabled
It partially fixes #5683. `store.setState({ paneDragging })` triggers all selector functions to run for each wheel event handler when pinch-to-zoom is used. We can avoid this by passing the updater function to setState and returning the previous state if nothing needs to be updated. Before: https://github.com...
cf2d4be3f57047ae02d08eed49dc640e89a2ef14
c029cd1a2845eec2433e0b9b3cdd38be813d2bb7
diff --git a/.changeset/empty-paws-cough.md b/.changeset/empty-paws-cough.md new file mode 100644 index 0000000000..6642232e42 --- /dev/null +++ b/.changeset/empty-paws-cough.md @@ -0,0 +1,5 @@ +--- +'@xyflow/react': patch +--- + +Optimize zooming performance when panOnScroll mode is enabled diff --git a/packages/react...
[ ".changeset/empty-paws-cough.md", "packages/react/src/container/ZoomPane/index.tsx" ]
[]
true
xyflow/xyflow
5,637
issue_to_patch
feat(nodes-edges): add zIndexMode
Add a zIndexMode to have more control about how the zindices get calculated.
ae0bb24e360bd90590a4ce4d10e195fd4cd638dc
594a286b0d9064d7da1e40e48fd10b65970fd27b
diff --git a/.changeset/breezy-gorillas-accept.md b/.changeset/breezy-gorillas-accept.md new file mode 100644 index 0000000000..920cfac72e --- /dev/null +++ b/.changeset/breezy-gorillas-accept.md @@ -0,0 +1,7 @@ +--- +'@xyflow/react': minor +'@xyflow/svelte': minor +'@xyflow/system': patch +--- + +Add `zIndexMode` to c...
[ ".changeset/breezy-gorillas-accept.md", "examples/react/src/App/routes.ts", "examples/react/src/examples/ColorMode/index.tsx", "examples/react/src/examples/ColorMode/style.css", "examples/react/src/examples/ZIndexMode/index.tsx", "packages/react/src/components/EdgeWrapper/index.tsx", "packages/react/src...
[ { "comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n**zIndexMode propagation through updateNodeInternals and absolute position updates looks correct**\n\n`updateNodeInternals` now:\n\n- Reads `zIndexMode` from state.\n- Passes it into `updateNodeInternalsSyst...
true
xyflow/xyflow
5,637
comment_to_fix
feat(nodes-edges): add zIndexMode
_⚠️ Potential issue_ | _🔴 Critical_ <details> <summary>🧩 Analysis chain</summary> **zIndexMode propagation through updateNodeInternals and absolute position updates looks correct** `updateNodeInternals` now: - Reads `zIndexMode` from state. - Passes it into `updateNodeInternalsSystem` along with `nodeExtent`. - C...
ae0bb24e360bd90590a4ce4d10e195fd4cd638dc
594a286b0d9064d7da1e40e48fd10b65970fd27b
diff --git a/packages/react/src/store/index.ts b/packages/react/src/store/index.ts index fa1b5e3d01..1c5bdd3dc2 100644 --- a/packages/react/src/store/index.ts +++ b/packages/react/src/store/index.ts @@ -16,6 +16,7 @@ import { fitViewport, getHandlePosition, Position, + ZIndexMode } from '@xyflow/system'; ...
[ "packages/react/src/store/index.ts" ]
[ { "comment": "_⚠️ Potential issue_ | _🔴 Critical_\n\n<details>\n<summary>🧩 Analysis chain</summary>\n\n**zIndexMode propagation through updateNodeInternals and absolute position updates looks correct**\n\n`updateNodeInternals` now:\n\n- Reads `zIndexMode` from state.\n- Passes it into `updateNodeInternalsSyst...
true