repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
xyflow/xyflow | 5,637 | comment_to_fix | feat(nodes-edges): add zIndexMode | _π οΈ Refactor suggestion_ | _π Major_
**Add JSDoc documentation for the new public prop.**
The `zIndexMode` prop is a new public API that controls z-index behavior. Users need clear documentation to understand:
- What the prop does
- When to use `'auto'` vs `'manual'`
- The default value
- How it relates to `elevate... | ae0bb24e360bd90590a4ce4d10e195fd4cd638dc | 594a286b0d9064d7da1e40e48fd10b65970fd27b | diff --git a/packages/react/src/types/component-props.ts b/packages/react/src/types/component-props.ts
index 3e534aaaf0..effc7ca66c 100644
--- a/packages/react/src/types/component-props.ts
+++ b/packages/react/src/types/component-props.ts
@@ -23,6 +23,7 @@ import type {
OnReconnect,
AriaLabelConfig,
FinalConne... | [
"packages/react/src/types/component-props.ts"
] | [
{
"comment": "_π οΈ Refactor suggestion_ | _π Major_\n\n**Add JSDoc documentation for the new public prop.**\n\nThe `zIndexMode` prop is a new public API that controls z-index behavior. Users need clear documentation to understand:\n- What the prop does\n- When to use `'auto'` vs `'manual'`\n- The default value... | true | ||
xyflow/xyflow | 5,617 | issue_to_patch | Feature request: Allow getEdgeId to be overridden
### Please describe the feature that you want to propose
Hi all, thanks for the great work on this project.
I have my own custom implementation of `getEdgeId` that I need to remember to call anytime I add a new edge or update an existing one.
`reconnectEdge` and `ad... | Allow getEdgeId to be overridden | Fixes #5180 | 57a2134b526658cfa1702f2f356eae797ffaf2e5 | 487c3470f997fd405fea1cc55013a3c88bf7e116 | diff --git a/.changeset/custom-edge-id-generator.md b/.changeset/custom-edge-id-generator.md
new file mode 100644
index 0000000000..439d729cbe
--- /dev/null
+++ b/.changeset/custom-edge-id-generator.md
@@ -0,0 +1,5 @@
+---
+'@xyflow/system': patch
+---
+
+Allow custom `getEdgeId` function in `addEdge` and `reconnectEdg... | [
".changeset/custom-edge-id-generator.md",
"packages/system/src/utils/edges/general.ts"
] | [
{
"comment": "I'm positive this naming convention is wrong (not enough lobsters π¦ ) but happy to rename",
"path": ".changeset/custom-edge-id-generator.md",
"hunk": "@@ -0,0 +1,5 @@\n+---",
"resolving_sha": "487c3470f997fd405fea1cc55013a3c88bf7e116",
"resolving_diff": "diff --git a/.changeset/cu... | true | |
xyflow/xyflow | 5,551 | issue_to_patch | refactor(selection): make it possible to start a selection above a node | #5342
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **New Features**
* Start a drag multi-select even when beginning above or over a node.
* **Bug Fixes**
* Elements marked to ignore selection (e.g., nokey) no longer start selection.
* Improved pointer/c... | d9de28214a36b581790f1f994e0dc224c05a0c1a | c688daa1b38ce7f932bfa411fd26b364eca2badb | diff --git a/.changeset/fresh-groups-kneel.md b/.changeset/fresh-groups-kneel.md
new file mode 100644
index 0000000000..776c97a154
--- /dev/null
+++ b/.changeset/fresh-groups-kneel.md
@@ -0,0 +1,7 @@
+---
+'@xyflow/svelte': minor
+'@xyflow/system': patch
+'@xyflow/react': minor
+---
+
+Allow to start a selection above ... | [
".changeset/fresh-groups-kneel.md",
"examples/react/src/examples/CustomNode/ColorSelectorNode.tsx",
"examples/svelte/src/routes/examples/customnode/CustomNode.svelte",
"packages/react/src/container/Pane/index.tsx",
"packages/svelte/src/lib/container/Pane/Pane.svelte",
"packages/system/src/utils/dom.ts"
] | [
{
"comment": "_π οΈ Refactor suggestion_ | _π Major_\n\n<details>\n<summary>𧩠Analysis chain</summary>\n\n**Solid click suppression and selection start; add primary-pointer check and capture on container.**\n\n- onClickCapture stopPropagation + pointerdown preventDefault/stopPropagation align with the spec and... | true | ||
xyflow/xyflow | 5,551 | comment_to_fix | refactor(selection): make it possible to start a selection above a node | _π οΈ Refactor suggestion_ | _π Major_
<details>
<summary>𧩠Analysis chain</summary>
**Solid click suppression and selection start; add primary-pointer check and capture on container.**
- onClickCapture stopPropagation + pointerdown preventDefault/stopPropagation align with the spec and the PR comment.
- Add a prim... | d9de28214a36b581790f1f994e0dc224c05a0c1a | c688daa1b38ce7f932bfa411fd26b364eca2badb | diff --git a/packages/react/src/container/Pane/index.tsx b/packages/react/src/container/Pane/index.tsx
index 4d2e392a25..ef86be3f2d 100644
--- a/packages/react/src/container/Pane/index.tsx
+++ b/packages/react/src/container/Pane/index.tsx
@@ -1,7 +1,3 @@
-/**
- * The user selection rectangle gets displayed when a user ... | [
"packages/react/src/container/Pane/index.tsx"
] | [
{
"comment": "_π οΈ Refactor suggestion_ | _π Major_\n\n<details>\n<summary>𧩠Analysis chain</summary>\n\n**Solid click suppression and selection start; add primary-pointer check and capture on container.**\n\n- onClickCapture stopPropagation + pointerdown preventDefault/stopPropagation align with the spec and... | true | ||
xyflow/xyflow | 5,631 | issue_to_patch | Release packages | This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will ... | f15bc01f99771f5fce01e5764d97fc9e926eb903 | c0ed3c33a3498877ab2a5755299ff84ee659782e | diff --git a/.changeset/beige-emus-deny.md b/.changeset/beige-emus-deny.md
deleted file mode 100644
index 1898679968..0000000000
--- a/.changeset/beige-emus-deny.md
+++ /dev/null
@@ -1,5 +0,0 @@
----
-'@xyflow/svelte': patch
----
-
-Refactor internal use of contexts
diff --git a/.changeset/breezy-gorillas-accept.md b/.... | [
".changeset/beige-emus-deny.md",
".changeset/breezy-gorillas-accept.md",
".changeset/curly-snails-do.md",
".changeset/custom-edge-id-generator.md",
".changeset/dry-seahorses-deliver.md",
".changeset/selfish-nails-sing.md",
".changeset/young-roses-shout.md",
"packages/react/CHANGELOG.md",
"packages/r... | [] | true | ||
xyflow/xyflow | 5,649 | issue_to_patch | chore(edges): always use edge zIndex | 501a791dcd8bd2248739bc8ba7bdafff5b4b5db3 | a213216e6a0089badfa9d9c7275c17159a0708c6 | diff --git a/packages/system/src/utils/edges/general.ts b/packages/system/src/utils/edges/general.ts
index 25719c3d6c..c08c8758e4 100644
--- a/packages/system/src/utils/edges/general.ts
+++ b/packages/system/src/utils/edges/general.ts
@@ -49,21 +49,17 @@ export function getElevatedEdgeZIndex({
sourceNode,
targetN... | [
"packages/system/src/utils/edges/general.ts"
] | [] | true | |||
xyflow/xyflow | 5,596 | issue_to_patch | Chore/svelte typed context | ae0bb24e360bd90590a4ce4d10e195fd4cd638dc | 45fdd9a55088b647936325cbfee07eb27461c4bb | diff --git a/.changeset/beige-emus-deny.md b/.changeset/beige-emus-deny.md
new file mode 100644
index 0000000000..1898679968
--- /dev/null
+++ b/.changeset/beige-emus-deny.md
@@ -0,0 +1,5 @@
+---
+'@xyflow/svelte': patch
+---
+
+Refactor internal use of contexts
diff --git a/examples/svelte/.eslintignore b/examples/sve... | [
".changeset/beige-emus-deny.md",
"examples/svelte/.eslintignore",
"examples/svelte/.eslintrc.cjs",
"examples/svelte/.gitignore",
"examples/svelte/.npmrc",
"examples/svelte/eslint.config.js",
"examples/svelte/package.json",
"examples/svelte/src/routes/examples/edge-toolbar/CustomEdge.svelte",
"exampl... | [
{
"comment": "_β οΈ Potential issue_ | _π΄ Critical_\n\n<details>\n<summary>𧩠Analysis chain</summary>\n\n**Verify compatibility of major version updates.**\n\nThe package includes significant version updates across multiple tool chains:\n- ESLint 9.x (requires flat config format)\n- Svelte 5.41.1 and SvelteKit ... | true | |||
xyflow/xyflow | 5,596 | comment_to_fix | Chore/svelte typed context | _π οΈ Refactor suggestion_ | _π Major_
**Remove unused import.**
The `getContext` import from Svelte is no longer used after refactoring to `getEdgeIdContext`.
Apply this diff to remove the unused import:
```diff
import { EdgeLabel } from '$lib/components/EdgeLabel';
import type { EdgeToolbarProps } from '.... | ae0bb24e360bd90590a4ce4d10e195fd4cd638dc | 45fdd9a55088b647936325cbfee07eb27461c4bb | diff --git a/packages/svelte/src/lib/plugins/EdgeToolbar/EdgeToolbar.svelte b/packages/svelte/src/lib/plugins/EdgeToolbar/EdgeToolbar.svelte
index 6a063acb91..8a559e8fec 100644
--- a/packages/svelte/src/lib/plugins/EdgeToolbar/EdgeToolbar.svelte
+++ b/packages/svelte/src/lib/plugins/EdgeToolbar/EdgeToolbar.svelte
@@ -2... | [
"packages/svelte/src/lib/plugins/EdgeToolbar/EdgeToolbar.svelte"
] | [
{
"comment": "_π οΈ Refactor suggestion_ | _π Major_\n\n**Remove unused import.**\n\nThe `getContext` import from Svelte is no longer used after refactoring to `getEdgeIdContext`.\n\n\n\nApply this diff to remove the unused import:\n\n```diff\n import { EdgeLabel } from '$lib/components/EdgeLabel';\n import... | true | ||
xyflow/xyflow | 5,484 | issue_to_patch | Experimental `useOnNodesChangeMiddleware` |
<!-- This is an auto-generated comment: release notes by coderabbit.ai -->
## Summary by CodeRabbit
* **New Features**
* Introduced experimental hooks to intercept and transform node and edge change events, enabling custom behaviors such as restricting node movement within defined bounds.
* Enhanced flexibility ... | 25341c6078d630e40862e75bdde5aa1823d5981c | 2b77a1e228bf54e5e422fea8f4c473a37bf8e361 | diff --git a/.changeset/selfish-nails-sing.md b/.changeset/selfish-nails-sing.md
new file mode 100644
index 0000000000..9cbc5b8150
--- /dev/null
+++ b/.changeset/selfish-nails-sing.md
@@ -0,0 +1,5 @@
+---
+'@xyflow/react': minor
+---
+
+Add `experimental_useOnNodesChangeMiddleware` hook
diff --git a/examples/react/src/... | [
".changeset/selfish-nails-sing.md",
"examples/react/src/App/routes.ts",
"examples/react/src/examples/Middlewares/RestrictExtent.tsx",
"examples/react/src/examples/Middlewares/index.tsx",
"packages/react/src/components/BatchProvider/index.tsx",
"packages/react/src/hooks/useOnEdgesChangeMiddleware.ts",
"p... | [
{
"comment": "_β οΈ Potential issue_ | _π‘ Minor_\n\n**Commented code references undeclared variable.**\n\nThe commented-out code at lines 60-62 references `nodeSyncMiddleware`, but this variable is not destructured from the store state (lines 31-39). If this code is uncommented without adding `nodeSyncMiddleware... | true | ||
xyflow/xyflow | 5,484 | comment_to_fix | Experimental `useOnNodesChangeMiddleware` | _β οΈ Potential issue_ | _π‘ Minor_
**Commented code references undeclared variable.**
The commented-out code at lines 60-62 references `nodeSyncMiddleware`, but this variable is not destructured from the store state (lines 31-39). If this code is uncommented without adding `nodeSyncMiddleware` to the destructuring sta... | 25341c6078d630e40862e75bdde5aa1823d5981c | 2b77a1e228bf54e5e422fea8f4c473a37bf8e361 | diff --git a/packages/react/src/components/BatchProvider/index.tsx b/packages/react/src/components/BatchProvider/index.tsx
index b2ed270fce..f6c6436ce4 100644
--- a/packages/react/src/components/BatchProvider/index.tsx
+++ b/packages/react/src/components/BatchProvider/index.tsx
@@ -28,7 +28,15 @@ export function BatchP... | [
"packages/react/src/components/BatchProvider/index.tsx"
] | [
{
"comment": "_β οΈ Potential issue_ | _π‘ Minor_\n\n**Commented code references undeclared variable.**\n\nThe commented-out code at lines 60-62 references `nodeSyncMiddleware`, but this variable is not destructured from the store state (lines 31-39). If this code is uncommented without adding `nodeSyncMiddleware... | true | ||
xyflow/xyflow | 5,592 | issue_to_patch | Avoid modifying `node.measured` object, create copy instead | When working with immutable `node` data, modifying in-place `node.measured` properties is not allowed. Since we perform a shallow copy, we need to create a new `measured` object to populate `width` and `height`.
I'm using Immer to layout the nodes, and I started getting the following error after upgrade to v12:
```... | 905ab996f5bbb69c8fb843d27a0074ddc2c89ea6 | 38dbf41c464550cc803b946a4ad1f46982385a03 | diff --git a/.changeset/dry-seahorses-deliver.md b/.changeset/dry-seahorses-deliver.md
new file mode 100644
index 0000000000..1125ea3ea3
--- /dev/null
+++ b/.changeset/dry-seahorses-deliver.md
@@ -0,0 +1,5 @@
+---
+'@xyflow/react': patch
+---
+
+Always create a new measured object in apply changes.
diff --git a/package... | [
".changeset/dry-seahorses-deliver.md",
"packages/react/src/utils/changes.ts"
] | [] | true | ||
xyflow/xyflow | 5,635 | issue_to_patch | Fix #5633 | This pull request closes issue #5633 that I opened.
I edited the svelte and react stores to update the `from` position of the `ConnectionState` when a node's position changes and also when the mouse moves : Why ? Because the `XYHandle` function uses a `ConnectionState` synchronized with the store via the `updateConn... | d33360b5c7a308c45287dc9879fd1a1ee534a1ce | 2d7fa40e2684a0fcdd4eca7800ccf2c34338e549 | diff --git a/.changeset/young-roses-shout.md b/.changeset/young-roses-shout.md
new file mode 100644
index 0000000000..f1f6a8880f
--- /dev/null
+++ b/.changeset/young-roses-shout.md
@@ -0,0 +1,7 @@
+---
+'@xyflow/react': patch
+'@xyflow/svelte': patch
+'@xyflow/system': patch
+---
+
+Update an ongoing connection when us... | [
".changeset/young-roses-shout.md",
"packages/react/src/store/index.ts",
"packages/svelte/src/lib/store/index.ts",
"packages/system/src/xyhandle/XYHandle.ts"
] | [
{
"comment": "_β οΈ Potential issue_ | _π‘ Minor_\n\n**Use strict equality and improve formatting.**\n\nThe logic correctly updates the connection origin when the source node is dragged. However, there are two code quality issues:\n\n1. Line 200 uses loose equality (`==`) instead of strict equality (`===`)\n2. Li... | true | ||
xyflow/xyflow | 5,635 | comment_to_fix | Fix #5633 | _β οΈ Potential issue_ | _π‘ Minor_
**Use strict equality and improve formatting.**
The logic correctly updates the connection origin when the source node is dragged. However, there are two code quality issues:
1. Line 200 uses loose equality (`==`) instead of strict equality (`===`)
2. Line 202 has formatting issues ... | d33360b5c7a308c45287dc9879fd1a1ee534a1ce | 2d7fa40e2684a0fcdd4eca7800ccf2c34338e549 | diff --git a/packages/react/src/store/index.ts b/packages/react/src/store/index.ts
index 3254bdfabe..d6ff3b6086 100644
--- a/packages/react/src/store/index.ts
+++ b/packages/react/src/store/index.ts
@@ -14,6 +14,8 @@ import {
NodeOrigin,
CoordinateExtent,
fitViewport,
+ getHandlePosition,
+ Position,
} from... | [
"packages/react/src/store/index.ts"
] | [
{
"comment": "_β οΈ Potential issue_ | _π‘ Minor_\n\n**Use strict equality and improve formatting.**\n\nThe logic correctly updates the connection origin when the source node is dragged. However, there are two code quality issues:\n\n1. Line 200 uses loose equality (`==`) instead of strict equality (`===`)\n2. Li... | true | ||
xyflow/xyflow | 5,635 | comment_to_fix | Fix #5633 | _β οΈ Potential issue_ | _π Major_
<details>
<summary>𧩠Analysis chain</summary>
**Verify connection property and eliminate redundant node lookup.**
There are several issues with this implementation:
1. **Potential bug**: Line 58-61 updates `store.connection` directly, but the `updateConnection` function at line 37... | d33360b5c7a308c45287dc9879fd1a1ee534a1ce | 2d7fa40e2684a0fcdd4eca7800ccf2c34338e549 | diff --git a/packages/svelte/src/lib/store/index.ts b/packages/svelte/src/lib/store/index.ts
index 798e87d8e2..30bcafc16a 100644
--- a/packages/svelte/src/lib/store/index.ts
+++ b/packages/svelte/src/lib/store/index.ts
@@ -15,7 +15,9 @@ import {
updateAbsolutePositions,
snapPosition,
calculateNodePosition,
- ... | [
"packages/svelte/src/lib/store/index.ts"
] | [
{
"comment": "_β οΈ Potential issue_ | _π Major_\n\n<details>\n<summary>𧩠Analysis chain</summary>\n\n**Verify connection property and eliminate redundant node lookup.**\n\nThere are several issues with this implementation:\n\n1. **Potential bug**: Line 58-61 updates `store.connection` directly, but the `update... | true | ||
xyflow/xyflow | 5,629 | issue_to_patch | Prevent re-render on every store update by using shallow in FlowRendererComponent useStore | While doing perf optimization I noticed that FlowRenderer seemed to re-render for no apparent reason.
It's because on every store update, the current selector creates a new object which don't pass the equality check of zustand.
I fixed it the same way as other components in the app, by passing shallow as the equality... | 0984dbb05a3cf06dff8e2df2e2bc71fdb01f5f1d | 0102be3babc11ed1a5fdb883393bfdaa9bfbef45 | diff --git a/.changeset/curly-snails-do.md b/.changeset/curly-snails-do.md
new file mode 100644
index 0000000000..5560b33bcb
--- /dev/null
+++ b/.changeset/curly-snails-do.md
@@ -0,0 +1,5 @@
+---
+'@xyflow/react': patch
+---
+
+Prevent unnecessary re-render in `FlowRenderer`
diff --git a/packages/react/src/container/Fl... | [
".changeset/curly-snails-do.md",
"packages/react/src/container/FlowRenderer/index.tsx"
] | [] | true | ||
xyflow/xyflow | 5,630 | issue_to_patch | Typo README.md | 0984dbb05a3cf06dff8e2df2e2bc71fdb01f5f1d | fb4d081364b8c6d00bf09ed6dca008f4b40c7e35 | diff --git a/README.md b/README.md
index 3ed80c4bf6..116e99c700 100644
--- a/README.md
+++ b/README.md
@@ -156,7 +156,7 @@ For releasing packages we are using [changesets](https://github.com/changesets/c
1. create PRs for new features, updates and fixes (with a changeset if relevant for changelog)
2. merge into mai... | [
"README.md"
] | [] | true | |||
yahoo/CMAK | 532 | issue_to_patch | I added sasl.mechanism, and sasl.jaas.config for each cluster. and fix some bugs [#528, #513,#502,#479,#477,#471] | Hi
I added sasl.mechanism, and sasl.jaas.config for each cluster. and fix some bugs [#528, #513,#502,#479,#477,#471]
I tested this new functions, mechanism includes PLAIN,GSSAPI,SCRAM-SHA-256,SCRAM-SHA-512.
and sasl.jaas.config is a optional string, such as: "org.apache.kafka.common.security.plain.PlainLoginModule ... | cc1761476173275fee96387c9ff374f9ea1943bd | f779d1ffca28b46eba5d84cbc41fd652030ecf1c | diff --git a/app/controllers/Cluster.scala b/app/controllers/Cluster.scala
index 7a3427c8a..85faed1f2 100644
--- a/app/controllers/Cluster.scala
+++ b/app/controllers/Cluster.scala
@@ -75,6 +75,14 @@ class Cluster (val messagesApi: MessagesApi, val kafkaManagerContext: KafkaManag
case Success(_) => Valid
}
... | [
"app/controllers/Cluster.scala",
"app/kafka/manager/KafkaManager.scala",
"app/kafka/manager/actor/KafkaManagerActor.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/model.scala",
"app/models/form/ClusterOperation.scala",
"app/views/cluster/addCluster.scala.html",... | [
{
"comment": "why is this field required? If I am not using SASL, then why would we want the user to fill this in.",
"path": "app/controllers/Cluster.scala",
"hunk": "@@ -114,6 +122,8 @@ class Cluster (val messagesApi: MessagesApi, val kafkaManagerContext: KafkaManag\n )(ClusterTuning.apply)(Cl... | diff --git a/test/controller/api/TestKafkaStateCheck.scala b/test/controller/api/TestKafkaStateCheck.scala
index b9de16471..f8e212ebb 100644
--- a/test/controller/api/TestKafkaStateCheck.scala
+++ b/test/controller/api/TestKafkaStateCheck.scala
@@ -76,7 +76,7 @@ class TestKafkaStateCheck extends CuratorAwareTest with K... | true | |
yahoo/CMAK | 881 | issue_to_patch | Add latest kafka versions 3.1.1 and 3.2.0 | Same procedure like in
https://github.com/yahoo/CMAK/pull/871
https://github.com/yahoo/CMAK/commit/204288bc41f407640ffc3cbe816cd8eb1219be7c
Signed-off-by: JΓΌrgen Walter <juergen.walter@sap.com>
I confirm that this contribution is made under the terms of the license found in the root directory of this repository... | 4dcc6887bfda73ef3d9b0adcf0d349b631280f0d | 9c06b68cfd0152be2b4beecda018f99afa7fcd74 | diff --git a/app/controllers/Logkafka.scala b/app/controllers/Logkafka.scala
index cd755d17..dbecd01a 100644
--- a/app/controllers/Logkafka.scala
+++ b/app/controllers/Logkafka.scala
@@ -125,6 +125,10 @@ class Logkafka (val cc: ControllerComponents, val kafkaManagerContext: KafkaMana
LogkafkaNewConfigs.configMaps(... | [
"app/controllers/Logkafka.scala",
"app/controllers/Topic.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/model.scala",
"app/kafka/manager/utils/LogkafkaNewConfigs.scala",
"app/kafka/manager/utils/TopicConfigs.scala",
"build.sbt",
"test/kafka/manager/TestKafkaM... | [] | diff --git a/test/kafka/manager/TestKafkaManagerActor.scala b/test/kafka/manager/TestKafkaManagerActor.scala
index f82ad92e..3afc0adb 100644
--- a/test/kafka/manager/TestKafkaManagerActor.scala
+++ b/test/kafka/manager/TestKafkaManagerActor.scala
@@ -69,7 +69,7 @@ class TestKafkaManagerActor extends CuratorAwareTest wi... | true | |
yahoo/CMAK | 837 | issue_to_patch | Implement LDAP + StartTLS in CMAK | Signed-off-by: Parth Kolekar <parthkolekar@indeed.com>
<!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contrib... | 8e16403c65009280ae30e9fd1b2bfc0dcdd7d714 | c83d8dcb88ba603e3b132e976e16b423baf1fdb9 | diff --git a/README.md b/README.md
index f82fa22a0..e82f422e1 100644
--- a/README.md
+++ b/README.md
@@ -134,20 +134,29 @@ LDAP support is through the basic authentication filter.
- basicAuthentication.iv="some-hex-string-representing-byte-array"
- basicAuthentication.secret="my-secret-string"
-3. Configure LDAP/LD... | [
"README.md",
"app/controllers/BasicAuthenticationFilter.scala",
"conf/application.conf"
] | [] | true | ||
yahoo/CMAK | 856 | issue_to_patch | Broker dynamic configs support | <!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
add a page for br... | 8e16403c65009280ae30e9fd1b2bfc0dcdd7d714 | 5a050fb037fff743ac3610963f9ae77ab75e473f | diff --git a/app/controllers/Cluster.scala b/app/controllers/Cluster.scala
index 5e002cca3..1d423ab81 100644
--- a/app/controllers/Cluster.scala
+++ b/app/controllers/Cluster.scala
@@ -5,9 +5,14 @@
package controllers
+import java.util.Properties
+
import features.{ApplicationFeatures, KMClusterManagerFeature}
i... | [
"app/controllers/Cluster.scala",
"app/kafka/manager/KafkaManager.scala",
"app/kafka/manager/actor/cluster/ClusterManagerActor.scala",
"app/kafka/manager/actor/cluster/KafkaCommandActor.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/ActorModel.scala",
"app/kafka... | [] | diff --git a/test/kafka/manager/TestKafkaManager.scala b/test/kafka/manager/TestKafkaManager.scala
index ca070c319..94fe80e41 100644
--- a/test/kafka/manager/TestKafkaManager.scala
+++ b/test/kafka/manager/TestKafkaManager.scala
@@ -391,6 +391,32 @@ class TestKafkaManager extends CuratorAwareTest with BaseTest {
}... | true | |
yahoo/CMAK | 874 | issue_to_patch | create screwdriver build pipeline | <!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
| 82a3aba76bdbc6e9a5d282274e887ad6f0ea5eda | 09b137fb3714e5245d3774ac6b7fbf1a72e13387 | diff --git a/screwdriver.yaml b/screwdriver.yaml
new file mode 100644
index 00000000..f43cefb2
--- /dev/null
+++ b/screwdriver.yaml
@@ -0,0 +1,21 @@
+shared:
+ annotations:
+ screwdriver.cd/cpu: TURBO
+ screwdriver.cd/ram: TURBO
+ image: hseeberger/scala-sbt:11.0.14.1_1.6.2_2.12.15
+ #environment:
+ #Fetche... | [
"screwdriver.yaml"
] | [] | true | ||
yahoo/CMAK | 871 | issue_to_patch | Add latest kafka versions | Added latest kafka versions (2.7.0, 2.8.0, 2.8.1, 3.0.0, 3.1.0)
<!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this ... | c1868b6d08c24f6be0015c3937f59219b30199b2 | 204288bc41f407640ffc3cbe816cd8eb1219be7c | diff --git a/app/controllers/Logkafka.scala b/app/controllers/Logkafka.scala
index cc37e60d0..cd755d17e 100644
--- a/app/controllers/Logkafka.scala
+++ b/app/controllers/Logkafka.scala
@@ -115,6 +115,16 @@ class Logkafka (val cc: ControllerComponents, val kafkaManagerContext: KafkaMana
LogkafkaNewConfigs.configMap... | [
"app/controllers/Logkafka.scala",
"app/controllers/Topic.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/model.scala",
"app/kafka/manager/utils/LogkafkaNewConfigs.scala",
"app/kafka/manager/utils/TopicConfigs.scala",
"build.sbt",
"sbt",
"test/kafka/manager/T... | [
{
"comment": "@pranavbhole @patelh Could you please make github release for the changed app version?",
"path": "build.sbt",
"hunk": "@@ -5,7 +5,7 @@\n name := \"\"\"cmak\"\"\"\n \n /* For packaging purposes, -SNAPSHOT MUST contain a digit */\n-version := \"3.0.0.5\"\n+version := \"3.0.0.6\"",
"resol... | diff --git a/test/kafka/manager/TestKafkaManagerActor.scala b/test/kafka/manager/TestKafkaManagerActor.scala
index d5f52af85..f82ad92e5 100644
--- a/test/kafka/manager/TestKafkaManagerActor.scala
+++ b/test/kafka/manager/TestKafkaManagerActor.scala
@@ -69,7 +69,7 @@ class TestKafkaManagerActor extends CuratorAwareTest ... | true | |
yahoo/CMAK | 858 | issue_to_patch | Upgrade JQuery
According to the self-reported version in the script, the version of JQuery hosted on the remote web server is greater than or equal to 1.2 and prior to 3.5.0. It is, therefore, affected by multiple cross-site scripting vulnerabilities.
It violates below CVEs
JQuery 3.3.1 < 3.5.0 - CVE-2020-11022, ... | fix(jquery): Upgrade Jquery version | Resolves #855
<!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
| 8e16403c65009280ae30e9fd1b2bfc0dcdd7d714 | 71232eee50849adadce97d35b4d5a775b14bf68e | diff --git a/build.sbt b/build.sbt
index e3e01c3f8..7643104f1 100644
--- a/build.sbt
+++ b/build.sbt
@@ -28,7 +28,7 @@ libraryDependencies ++= Seq(
"com.google.code.findbugs" % "jsr305" % "3.0.2",
"org.webjars" %% "webjars-play" % "2.6.3",
"org.webjars" % "bootstrap" % "4.3.1",
- "org.webjars" % "jquery" % "3... | [
"build.sbt"
] | [] | true | |
yahoo/CMAK | 769 | issue_to_patch | Support OAUTHBEARER SASL mechanism | CMAK currently does not support using OAUTHBEARER for the sasl.mechanism in the cluster configuration UI. This PR adds that support.
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make th... | 2b3ca92c6750ab37604dac1ce28a89a7e81c25ce | 313425440ccb1a4bd43b52f3278f4018f2f6400b | diff --git a/app/kafka/manager/model/model.scala b/app/kafka/manager/model/model.scala
index a7dd4a7c1..fb2cf35b4 100644
--- a/app/kafka/manager/model/model.scala
+++ b/app/kafka/manager/model/model.scala
@@ -513,12 +513,17 @@ case object SASL_MECHANISM_SCRAM512 extends SASLmechanism {
val stringId = "SCRAM-SHA-512"... | [
"app/kafka/manager/model/model.scala"
] | [] | true | ||
yahoo/CMAK | 811 | issue_to_patch | http -> https | <!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
| 8e16403c65009280ae30e9fd1b2bfc0dcdd7d714 | 5788b6b431ea296145fadd369fb20b58a6cf497b | diff --git a/project/plugins.sbt b/project/plugins.sbt
index 8a983bf20..1aac201bb 100644
--- a/project/plugins.sbt
+++ b/project/plugins.sbt
@@ -7,13 +7,13 @@ logLevel := Level.Info
resolvers += Resolver.url(
"bintray-sbt-plugin-releases",
- url("http://dl.bintray.com/content/sbt/sbt-plugin-releases"))(
+ url("... | [
"project/plugins.sbt"
] | [] | true | ||
yahoo/CMAK | 582 | issue_to_patch | Feature/dockerization | by running `sbt docker`, you will get a docker image `kafka-manager:<version>` locally.
then by running `docker run -d -e<ENV VARS> kafka-manager:<version>`, you will have a running kafka-manager instance listening to port 9000.
port could be mapped to any other port with `-p<any port>:9000` in docker run option. | 63c5804a8dc896840a557f781813d322481cda91 | fe34f76ebe1847a29dd9baed0be614f9b3efdcde | diff --git a/build.sbt b/build.sbt
index bbfbbc9d7..40cc3083e 100644
--- a/build.sbt
+++ b/build.sbt
@@ -67,6 +67,34 @@ enablePlugins(SbtNativePackager)
enablePlugins(SystemdPlugin)
+
+enablePlugins(sbtdocker.DockerPlugin)
+dockerfile in docker := {
+ val zipFile: File = dist.value
+
+ new Dockerfile {
+ from... | [
"build.sbt",
"project/plugins.sbt"
] | [
{
"comment": "You are using jdk8 while the minimum requirements is 11+ in project readme",
"path": "build.sbt",
"hunk": "@@ -67,6 +67,34 @@ enablePlugins(SbtNativePackager)\n \n enablePlugins(SystemdPlugin)\n \n+\n+enablePlugins(sbtdocker.DockerPlugin)\n+dockerfile in docker := {\n+ val zipFile: File =... | true | ||
yahoo/CMAK | 746 | issue_to_patch | Set RPM compression to preserve backwards compatability | Building RPM on newer systems defaults RPM compression is ZSTD which prevents older systems from installing rpm
<!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and... | 2b3ca92c6750ab37604dac1ce28a89a7e81c25ce | 97f62636c7dd44a4d97e0e0f3371d67b28522a9a | diff --git a/build.sbt b/build.sbt
index 9ac722133..4af59f9cc 100644
--- a/build.sbt
+++ b/build.sbt
@@ -136,4 +136,9 @@ rpmUrl := Some("https://github.com/yahoo/cmak")
rpmLicense := Some("Apache")
rpmGroup := Some("cmak")
+import RpmConstants._
+maintainerScripts in Rpm := maintainerScriptsAppend((maintainerScript... | [
"build.sbt"
] | [] | true | ||
yahoo/CMAK | 743 | issue_to_patch | cluster new/edit page duplicate security protocol SASL_PLAINTEXT fix | <!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
from https://gith... | 2b3ca92c6750ab37604dac1ce28a89a7e81c25ce | cea3b57afcaf769a208a2e2b6a87157f28f8f541 | diff --git a/app/kafka/manager/model/model.scala b/app/kafka/manager/model/model.scala
index a7dd4a7c1..17f45cd29 100644
--- a/app/kafka/manager/model/model.scala
+++ b/app/kafka/manager/model/model.scala
@@ -485,7 +485,7 @@ case object PLAINTEXT extends SecurityProtocol {
object SecurityProtocol {
private[this] va... | [
"app/kafka/manager/model/model.scala"
] | [] | true | ||
yahoo/CMAK | 793 | issue_to_patch | Add missing versions | Adding drop down support for versions:
2.2.1
2.2.2
2.3.0
2.3.1
2.4.0
2.4.1
2.5.0
2.5.1
2.6.0
However, the unit tests and the jar artifact used for kafka only work up to 2.4.1. They will connect to kafka brokers/clusters running newer versions, but in order to bundle the jar file for 2.5.1 and later will ... | eba0b95ac4e4469b536a36c8ee2c46cfde2278a4 | c3b5140937814c5d6716eef7860d951b1bacda8e | diff --git a/app/controllers/Logkafka.scala b/app/controllers/Logkafka.scala
index 0b7eba2e7..cc37e60d0 100644
--- a/app/controllers/Logkafka.scala
+++ b/app/controllers/Logkafka.scala
@@ -97,8 +97,24 @@ class Logkafka (val cc: ControllerComponents, val kafkaManagerContext: KafkaMana
LogkafkaNewConfigs.configMaps(... | [
"app/controllers/Logkafka.scala",
"app/controllers/Topic.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/model.scala",
"app/kafka/manager/utils/LogkafkaNewConfigs.scala",
"app/kafka/manager/utils/TopicConfigs.scala",
"build.sbt",
"test/controller/api/TestKafka... | [] | diff --git a/test/controller/api/TestKafkaStateCheck.scala b/test/controller/api/TestKafkaStateCheck.scala
index 5905fd061..371bc351c 100644
--- a/test/controller/api/TestKafkaStateCheck.scala
+++ b/test/controller/api/TestKafkaStateCheck.scala
@@ -78,7 +78,7 @@ class TestKafkaStateCheck extends CuratorAwareTest with K... | true | |
yahoo/CMAK | 742 | issue_to_patch | Create a new option to trust all non-expired certificates during LDAP authentication |
Signed-off-by: Parth Kolekar <parthkolekar@indeed.com>
<!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contr... | 2b3ca92c6750ab37604dac1ce28a89a7e81c25ce | 5d385884b334c86d3dc762c9a1329cc5dd6dabad | diff --git a/README.md b/README.md
index 81475da46..f82fa22a0 100644
--- a/README.md
+++ b/README.md
@@ -147,6 +147,7 @@ LDAP support is through the basic authentication filter.
4. (Optional) Limit access to a specific LDAP Group
- basicAuthentication.ldap.group-filter=< LDAP group filter>
+- basicAuthentication.ld... | [
"README.md",
"app/controllers/BasicAuthenticationFilter.scala",
"conf/application.conf"
] | [] | true | ||
yahoo/CMAK | 779 | issue_to_patch | Sort topics in consumer view | This will sort the list of topics a consumer is assigned to.
Two minor changes as well, change the repositories to https (removes the sbt warning about that) and some whitespace changes, which my editor is doing by default. If required I can revert those easily.
Thank you!
<!-- The following line must be inc... | 2b3ca92c6750ab37604dac1ce28a89a7e81c25ce | 5446a78b200bca3e4fe512528d90a234aa90e834 | diff --git a/app/kafka/manager/model/ActorModel.scala b/app/kafka/manager/model/ActorModel.scala
index 2881b4fe4..1d4a328da 100644
--- a/app/kafka/manager/model/ActorModel.scala
+++ b/app/kafka/manager/model/ActorModel.scala
@@ -19,6 +19,7 @@ import scala.collection.immutable.Queue
import scala.util.Try
import scalaz... | [
"app/kafka/manager/model/ActorModel.scala",
"project/plugins.sbt"
] | [] | true | ||
yahoo/CMAK | 630 | issue_to_patch | Feature for scheduling preferred replica leader election | We recently worked on adding a feature (new tab & REST APIs) to Kafka Manager which would allow users to schedule the replica leader election. We thought it might be helpful for other users as well so would like to share it here and preferably merge it upstream ([yahoo/kafka-manager](https://github.com/yahoo/kafka-mana... | 6733e8894af31a4f5fc9a417b26fddccf634e2d7 | 7f0a1f5cfc52370de467f4c738b680c82182200f | diff --git a/app/controllers/PreferredReplicaElection.scala b/app/controllers/PreferredReplicaElection.scala
index f7ddd171e..27b5e6e26 100644
--- a/app/controllers/PreferredReplicaElection.scala
+++ b/app/controllers/PreferredReplicaElection.scala
@@ -5,7 +5,7 @@
package controllers
-import features.{ApplicationF... | [
"app/controllers/PreferredReplicaElection.scala",
"app/features/ApplicationFeature.scala",
"app/kafka/manager/KafkaManager.scala",
"app/kafka/manager/actor/KafkaManagerActor.scala",
"app/kafka/manager/actor/cluster/ClusterManagerActor.scala",
"app/kafka/manager/model/ActorModel.scala",
"app/kafka/manage... | [
{
"comment": "Some",
"path": "app/models/navigation/Menus.scala",
"hunk": "@@ -50,6 +50,12 @@ class Menus(implicit applicationFeatures: ApplicationFeatures) {\n } else None\n }\n \n+ private[this] def scheduleLeaderElectionMenu(cluster: String) : Option[Menu] = {\n+ if (applicationFeatures.f... | diff --git a/test/kafka/manager/TestKafkaManager.scala b/test/kafka/manager/TestKafkaManager.scala
index b4da3dd01..553fdd63e 100644
--- a/test/kafka/manager/TestKafkaManager.scala
+++ b/test/kafka/manager/TestKafkaManager.scala
@@ -7,6 +7,7 @@ package kafka.manager
import java.util.Properties
import java.util.concur... | true | |
yahoo/CMAK | 630 | comment_to_fix | Feature for scheduling preferred replica leader election | Some | 6733e8894af31a4f5fc9a417b26fddccf634e2d7 | 7f0a1f5cfc52370de467f4c738b680c82182200f | diff --git a/app/models/navigation/Menus.scala b/app/models/navigation/Menus.scala
index 2c6afbcb1..8489f7084 100644
--- a/app/models/navigation/Menus.scala
+++ b/app/models/navigation/Menus.scala
@@ -5,7 +5,7 @@
package models.navigation
-import features.{KMTopicManagerFeature, KMClusterManagerFeature, KMPreferre... | [
"app/models/navigation/Menus.scala"
] | [
{
"comment": "Some",
"path": "app/models/navigation/Menus.scala",
"hunk": "@@ -50,6 +50,12 @@ class Menus(implicit applicationFeatures: ApplicationFeatures) {\n } else None\n }\n \n+ private[this] def scheduleLeaderElectionMenu(cluster: String) : Option[Menu] = {\n+ if (applicationFeatures.f... | true | ||
yahoo/CMAK | 630 | comment_to_fix | Feature for scheduling preferred replica leader election | use val | 6733e8894af31a4f5fc9a417b26fddccf634e2d7 | 7f0a1f5cfc52370de467f4c738b680c82182200f | diff --git a/app/controllers/PreferredReplicaElection.scala b/app/controllers/PreferredReplicaElection.scala
index f7ddd171e..27b5e6e26 100644
--- a/app/controllers/PreferredReplicaElection.scala
+++ b/app/controllers/PreferredReplicaElection.scala
@@ -5,7 +5,7 @@
package controllers
-import features.{ApplicationF... | [
"app/controllers/PreferredReplicaElection.scala"
] | [
{
"comment": "use val",
"path": "app/controllers/PreferredReplicaElection.scala",
"hunk": "@@ -85,4 +86,103 @@ class PreferredReplicaElection (val messagesApi: MessagesApi, val kafkaManagerCo\n )\n }\n }\n+\n+ def handleScheduledIntervalAPI(cluster: String): Action[AnyContent] = Action.asyn... | true | ||
yahoo/CMAK | 630 | comment_to_fix | Feature for scheduling preferred replica leader election | make it def | 6733e8894af31a4f5fc9a417b26fddccf634e2d7 | 7f0a1f5cfc52370de467f4c738b680c82182200f | diff --git a/app/controllers/PreferredReplicaElection.scala b/app/controllers/PreferredReplicaElection.scala
index f7ddd171e..27b5e6e26 100644
--- a/app/controllers/PreferredReplicaElection.scala
+++ b/app/controllers/PreferredReplicaElection.scala
@@ -5,7 +5,7 @@
package controllers
-import features.{ApplicationF... | [
"app/controllers/PreferredReplicaElection.scala"
] | [
{
"comment": "make it def",
"path": "app/controllers/PreferredReplicaElection.scala",
"hunk": "@@ -85,4 +86,103 @@ class PreferredReplicaElection (val messagesApi: MessagesApi, val kafkaManagerCo\n )\n }\n }\n+\n+ def handleScheduledIntervalAPI(cluster: String): Action[AnyContent] = Action.... | true | ||
yahoo/CMAK | 630 | comment_to_fix | Feature for scheduling preferred replica leader election | Suggestion: Refrain to use var to avoid side effects, use pattern match or declare like def or [functor](https://blog.knoldus.com/functors/) EITHER. | 6733e8894af31a4f5fc9a417b26fddccf634e2d7 | 7f0a1f5cfc52370de467f4c738b680c82182200f | diff --git a/app/controllers/PreferredReplicaElection.scala b/app/controllers/PreferredReplicaElection.scala
index f7ddd171e..27b5e6e26 100644
--- a/app/controllers/PreferredReplicaElection.scala
+++ b/app/controllers/PreferredReplicaElection.scala
@@ -5,7 +5,7 @@
package controllers
-import features.{ApplicationF... | [
"app/controllers/PreferredReplicaElection.scala"
] | [
{
"comment": "Suggestion: Refrain to use var to avoid side effects, use pattern match or declare like def or [functor](https://blog.knoldus.com/functors/) EITHER.",
"path": "app/controllers/PreferredReplicaElection.scala",
"hunk": "@@ -85,4 +86,103 @@ class PreferredReplicaElection (val messagesApi: Me... | true | ||
yahoo/CMAK | 630 | comment_to_fix | Feature for scheduling preferred replica leader election | define this implicit outside if you don't any specific reason | 6733e8894af31a4f5fc9a417b26fddccf634e2d7 | 7f0a1f5cfc52370de467f4c738b680c82182200f | diff --git a/app/kafka/manager/KafkaManager.scala b/app/kafka/manager/KafkaManager.scala
index 7e563c3d2..ad092988f 100644
--- a/app/kafka/manager/KafkaManager.scala
+++ b/app/kafka/manager/KafkaManager.scala
@@ -7,8 +7,9 @@ package kafka.manager
import java.util.Properties
import java.util.concurrent.{LinkedBlocki... | [
"app/kafka/manager/KafkaManager.scala"
] | [
{
"comment": "define this implicit outside if you don't any specific reason",
"path": "app/kafka/manager/KafkaManager.scala",
"hunk": "@@ -910,4 +959,28 @@ class KafkaManager(akkaConfig: Config) extends Logging {\n )\n }\n }\n+\n+ def initialiseSchedulePreferredLeaderElection(): Unit = {\n+... | true | ||
yahoo/CMAK | 727 | issue_to_patch | Update kafka dependency to 2.4 | <!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
| 555167a358ceb25689bb0c1078bd7dc00fd80c33 | 72acd31c47455f27643f9b15c3147ce02855d1d5 | diff --git a/README.md b/README.md
index e1704c6ad..f99e18026 100644
--- a/README.md
+++ b/README.md
@@ -172,15 +172,15 @@ The command below will create a zip file which can be used to deploy the applica
Please refer to play framework documentation on [production deployment/configuration](https://www.playframework.com... | [
"README.md",
"app/kafka/manager/actor/cluster/ClusterManagerActor.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/ActorModel.scala",
"app/kafka/manager/utils/ZkUtils.scala",
"app/kafka/manager/utils/one10/GroupMetadataManager.scala",
"app/kafka/manager/utils/one... | [] | diff --git a/test/kafka/manager/TestKafkaManager.scala b/test/kafka/manager/TestKafkaManager.scala
index 195a92422..90a610d5b 100644
--- a/test/kafka/manager/TestKafkaManager.scala
+++ b/test/kafka/manager/TestKafkaManager.scala
@@ -54,7 +54,6 @@ class TestKafkaManager extends CuratorAwareTest with BaseTest {
over... | true | |
yahoo/CMAK | 726 | issue_to_patch | Rename config keys to cmak to address issue#713 | Rename config keys to be prefixed with "cmak." instead of "kafka-manager." to address [this issue](https://github.com/yahoo/CMAK/issues/713).
<!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this ... | b38d85bbe7adf07cc57b49c3651f0477f1ba7785 | 5a4a96ddefb09d98fa1fa0f28f24e81565f5136a | diff --git a/README.md b/README.md
index 8341bba40..e1704c6ad 100644
--- a/README.md
+++ b/README.md
@@ -76,11 +76,11 @@ The minimum configuration is the zookeeper hosts which are to be used for CMAK (
This can be found in the application.conf file in conf directory. The same file will be packaged
in the distributio... | [
"README.md",
"app/kafka/manager/KafkaManager.scala",
"conf/application.conf",
"test/controller/api/TestKafkaStateCheck.scala",
"test/kafka/manager/TestKafkaManager.scala"
] | [] | diff --git a/test/controller/api/TestKafkaStateCheck.scala b/test/controller/api/TestKafkaStateCheck.scala
index 81736a252..5905fd061 100644
--- a/test/controller/api/TestKafkaStateCheck.scala
+++ b/test/controller/api/TestKafkaStateCheck.scala
@@ -45,8 +45,8 @@ class TestKafkaStateCheck extends CuratorAwareTest with K... | true | |
yahoo/CMAK | 720 | issue_to_patch | Add support Kafka 2.4.0 | This adds support for Kafka 2.4.0 similar to previous PRs.
| 20cbcf07d3dab344a1fc08354492386d08a4cf48 | d09508ead20e7ead452f5ecc8a90b1bb9d506694 | diff --git a/app/controllers/Logkafka.scala b/app/controllers/Logkafka.scala
index 441f93892..0b7eba2e7 100644
--- a/app/controllers/Logkafka.scala
+++ b/app/controllers/Logkafka.scala
@@ -97,6 +97,8 @@ class Logkafka (val cc: ControllerComponents, val kafkaManagerContext: KafkaMana
LogkafkaNewConfigs.configMaps(K... | [
"app/controllers/Logkafka.scala",
"app/controllers/Topic.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/model.scala",
"app/kafka/manager/utils/LogkafkaNewConfigs.scala",
"app/kafka/manager/utils/TopicConfigs.scala",
"test/controller/api/TestKafkaStateCheck.scal... | [] | diff --git a/test/controller/api/TestKafkaStateCheck.scala b/test/controller/api/TestKafkaStateCheck.scala
index 672fda694..81736a252 100644
--- a/test/controller/api/TestKafkaStateCheck.scala
+++ b/test/controller/api/TestKafkaStateCheck.scala
@@ -78,7 +78,7 @@ class TestKafkaStateCheck extends CuratorAwareTest with K... | true | |
yahoo/CMAK | 724 | issue_to_patch | Change to java 11, rename to cmak | <!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
| 20cbcf07d3dab344a1fc08354492386d08a4cf48 | ec4dbb434381791250e7d819fb1f1c2cbc365f2d | diff --git a/.travis.yml b/.travis.yml
index f1f0baa28..156812ec9 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,10 +1,10 @@
language: scala
sudo: true
-jdk: openjdk8
+jdk: openjdk11
install: true
script: travis_wait 30 ./sbt clean coverage assembly
scala:
- - 2.12.8
+ - 2.12.10
#after_success:
# - sbt cove... | [
".travis.yml",
"README.md",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/package.scala",
"app/kafka/manager/utils/logkafka81/LogConfig.scala",
"app/kafka/manager/utils/logkafka82/LogConfig.scala",
"app/kafka/manager/utils/zero10/LogConfig.scala",
"app/kafka/manager/utils... | [] | true | ||
yahoo/CMAK | 698 | issue_to_patch | LDAP authentication does not support colons in password
It seems LDAP authentication backend is unable to verify passwords containing colon character. I believe the code `credentials.split(":").toList` should be replaced with splitting string by the first colon only.
https://github.com/yahoo/kafka-manager/blob/mast... | Fix LDAP authentication does not support colons in password | Fixes #696
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
| 8ac50db09b60f15f80facde5911e48feb48964de | 8f01939a4b159fe13dff0f4f1efd318bdd93983d | diff --git a/app/controllers/BasicAuthenticationFilter.scala b/app/controllers/BasicAuthenticationFilter.scala
index 84915de89..b615b1445 100644
--- a/app/controllers/BasicAuthenticationFilter.scala
+++ b/app/controllers/BasicAuthenticationFilter.scala
@@ -172,7 +172,7 @@ case class LDAPAuthenticator(config: LDAPAuthen... | [
"app/controllers/BasicAuthenticationFilter.scala"
] | [] | true | |
yahoo/CMAK | 718 | issue_to_patch | Remove use of apache logo | Fixing #717
<!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
| 64461429945a29b36630e96bae355cfb853d880a | 7356569dba748c02bf301ace930f870e89655024 | diff --git a/img/broker-list.png b/img/broker-list.png
index f78b405ac..7c669b5c9 100644
Binary files a/img/broker-list.png and b/img/broker-list.png differ
diff --git a/img/broker.png b/img/broker.png
index 93bc260cf..9c7688fe7 100644
Binary files a/img/broker.png and b/img/broker.png differ
diff --git a/img/cluster.p... | [
"img/broker-list.png",
"img/broker.png",
"img/cluster.png",
"img/consumed-topic.png",
"img/topic-list.png",
"public/images/favicon.png"
] | [] | true | ||
yahoo/CMAK | 716 | issue_to_patch | updated README to reflect name change | <!-- The following line must be included in your pull request -->
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.
| 2a3d13c7b2c3a5806b5b8576960557a7f64f82ee | 97c973cf69dd567cc1044c56bd69751947736836 | diff --git a/README.md b/README.md
index f93e59c84..22e54681c 100644
--- a/README.md
+++ b/README.md
@@ -1,9 +1,10 @@
-Kafka Manager
+CMAK (Cluster Manager for Apache Kafka, previously known as Kafka Manager)
=============
-A tool for managing [Apache Kafka](http://kafka.apache.org).
+CMAK (previously known as Kafka... | [
"README.md"
] | [] | true | ||
yahoo/CMAK | 710 | issue_to_patch | Re-adding unzip to Docker via apt-get; changing Travis build to use OpenJDK8 | An update to `openjdk:8-jre-slim` earlier this year ( docker-library/openjdk#322 ) removed the `unzip` package in the base image, which the current generated dockerfile relies on.
No associated issues were found, but ran into this while building a fresh docker image locally, and could prevent future updates from ge... | a8896d7ff07443261f599b2096bd9c6d2c24be8b | 774a5f5d8fdcb8b7948fa0b5d20f3af1108b5652 | diff --git a/.travis.yml b/.travis.yml
index 4450f76e9..f1f0baa28 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -1,6 +1,6 @@
language: scala
sudo: true
-jdk: oraclejdk8
+jdk: openjdk8
install: true
script: travis_wait 30 ./sbt clean coverage assembly
scala:
diff --git a/build.sbt b/build.sbt
index 42b8a98a3..4e822... | [
".travis.yml",
"build.sbt"
] | [] | true | ||
yahoo/CMAK | 645 | issue_to_patch | Add Group Filter | This PR adds the capability to limit access to members of a defined LDAP or AD Group.
If the config key is empty, access is not limited. | 6733e8894af31a4f5fc9a417b26fddccf634e2d7 | c949ff27a8c1702ec1cbfdfe74c0f2fb78743059 | diff --git a/README.md b/README.md
index b0381346a..f93e59c84 100644
--- a/README.md
+++ b/README.md
@@ -144,6 +144,9 @@ LDAP support is through the basic authentication filter.
- basicAuthentication.ldap.connection-pool-size=< number of connection to LDAP server>
- basicAuthentication.ldap.ssl=< Boolean flag to enab... | [
"README.md",
"app/controllers/BasicAuthenticationFilter.scala",
"conf/application.conf"
] | [] | true | ||
yahoo/CMAK | 674 | issue_to_patch | Add Secondary Sort by partition ID for assignment view | For the `Request Data` section in the `/clusters/$CLUSTER_NAME/assignment` page, this change make it so it also sorts by the partition ID after sorting by topic:
<img width="869" alt="Reassign_Partitions" src="https://user-images.githubusercontent.com/165785/62743467-5247ab00-b9f7-11e9-8103-6fa0b36f5b8a.png">
We ... | 6733e8894af31a4f5fc9a417b26fddccf634e2d7 | d2859b1bbeeb62faf9686c5fa16b332f25cd4b5e | diff --git a/app/views/reassignPartitions.scala.html b/app/views/reassignPartitions.scala.html
index bd93f3a6a..892b690c3 100644
--- a/app/views/reassignPartitions.scala.html
+++ b/app/views/reassignPartitions.scala.html
@@ -47,7 +47,7 @@
<tr><th>Topic</th><th>Partition</th><th>Replica Assignment</th></tr>... | [
"app/views/reassignPartitions.scala.html"
] | [] | true | ||
yahoo/CMAK | 486 | issue_to_patch | Reassign partitions with replication factor option | The current feature for reassigning partitions doesn't allow you to update the replication factor, in case you've wrongly created a topic with an undesired replication. This offers you a way to change that in the `Generate Partition Assignments` step, by specifying the desired replication factor within the optional fie... | d187627e4bd7b9534a26f9b96fb43077bb169a78 | 69c605e3c290200f5ca3e867a2593339ac90199a | diff --git a/app/controllers/ReassignPartitions.scala b/app/controllers/ReassignPartitions.scala
index a5656f509..81c238764 100644
--- a/app/controllers/ReassignPartitions.scala
+++ b/app/controllers/ReassignPartitions.scala
@@ -77,7 +77,8 @@ class ReassignPartitions (val cc: ControllerComponents, val kafkaManagerConte... | [
"app/controllers/ReassignPartitions.scala",
"app/kafka/manager/KafkaManager.scala",
"app/kafka/manager/actor/cluster/ClusterManagerActor.scala",
"app/kafka/manager/model/ActorModel.scala",
"app/models/form/ReassignPartitionOperation.scala",
"app/views/topic/confirmAssignment.scala.html",
"test/kafka/man... | [] | diff --git a/test/kafka/manager/TestKafkaManager.scala b/test/kafka/manager/TestKafkaManager.scala
index 8f0c12172..b4da3dd01 100644
--- a/test/kafka/manager/TestKafkaManager.scala
+++ b/test/kafka/manager/TestKafkaManager.scala
@@ -262,6 +262,22 @@ class TestKafkaManager extends CuratorAwareTest with BaseTest {
T... | true | |
yahoo/CMAK | 624 | issue_to_patch | Improve "not recommended for large number of consumers" message | Resolves #524 | 08a03329607026dd09381af12b492a22ce264119 | 5c9cd4b09aacff98150680c54a23778f38ca1c56 | diff --git a/app/views/cluster/addCluster.scala.html b/app/views/cluster/addCluster.scala.html
index 41014a484..acf42ee84 100644
--- a/app/views/cluster/addCluster.scala.html
+++ b/app/views/cluster/addCluster.scala.html
@@ -32,7 +32,7 @@
@b4.text(form("jmxPass"), '_label -> "JMX Auth Password")
@b4.c... | [
"app/views/cluster/addCluster.scala.html",
"app/views/cluster/updateCluster.scala.html"
] | [] | true | ||
yahoo/CMAK | 632 | issue_to_patch | Add "PLAINTEXTSASL" in model.scala to support HDP kafka | as [ https://community.hortonworks.com/questions/85754/why-ambari-is-setting-the-security-protocol-of-the.html](url) sayοΌ
> Kafka security is developed by Hortonworks. Before it shipped into Apache Kafka we shipped it in HDP. At that time we called the SASL protocol as PLAINTEXTSASL which later changed SASL_PLAINTEX... | 2ca848bfdf542bf1da8fc860db9bbcc99548f89d | c63f1ccc8bcdfaefed28e21a2f0c23ad0a2290a6 | diff --git a/app/kafka/manager/model/model.scala b/app/kafka/manager/model/model.scala
index d269b00ba..631da7434 100644
--- a/app/kafka/manager/model/model.scala
+++ b/app/kafka/manager/model/model.scala
@@ -456,6 +456,10 @@ case object SASL_PLAINTEXT extends SecurityProtocol {
val stringId = "SASL_PLAINTEXT"
va... | [
"app/kafka/manager/model/model.scala"
] | [] | true | ||
yahoo/CMAK | 627 | issue_to_patch | Upgrade dependencies, upgrade version | This is a major upgrade to reflect new versions of play, bootstrap, akka, curator, jackson, json4s, kafka, etc. Play framework deprecated it's Crypto functionality so there were changes to basic auth and basic auth with LDAP.
Need further testing to ensure UI elements are working correctly with bootstrap 4. Also n... | 59a84e7a24ec69b82cd96ef2f68cc8853b840c46 | 451cf334f065d95ed3cb59557e4077fbecf77700 | diff --git a/.travis.yml b/.travis.yml
index 4f53b9abd..4450f76e9 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -4,13 +4,13 @@ jdk: oraclejdk8
install: true
script: travis_wait 30 ./sbt clean coverage assembly
scala:
- - 2.11.7
+ - 2.12.8
#after_success:
# - sbt coverageReport coveralls
cache:
directories... | [
".travis.yml",
"README.md",
"app/controllers/ApiHealth.scala",
"app/controllers/Application.scala",
"app/controllers/BasicAuthenticationFilter.scala",
"app/controllers/Cluster.scala",
"app/controllers/Consumer.scala",
"app/controllers/Logkafka.scala",
"app/controllers/PreferredReplicaElection.scala"... | [] | diff --git a/test/controller/api/TestKafkaStateCheck.scala b/test/controller/api/TestKafkaStateCheck.scala
index 01d3af487..672fda694 100644
--- a/test/controller/api/TestKafkaStateCheck.scala
+++ b/test/controller/api/TestKafkaStateCheck.scala
@@ -1,30 +1,31 @@
/**
- * Copyright 2015 Yahoo Inc. Licensed under the Apa... | true | |
yahoo/CMAK | 626 | issue_to_patch | Support Kafka 2.2.0 | This adds support for Kafka 2.2.0 similar to previous PRs. | 2ca848bfdf542bf1da8fc860db9bbcc99548f89d | 53dcff120b89d4f827115a7297da4d5a44730979 | diff --git a/app/controllers/Logkafka.scala b/app/controllers/Logkafka.scala
index a64813729..f348c4f6e 100644
--- a/app/controllers/Logkafka.scala
+++ b/app/controllers/Logkafka.scala
@@ -96,6 +96,8 @@ class Logkafka (val messagesApi: MessagesApi, val kafkaManagerContext: KafkaMana
LogkafkaNewConfigs.configMaps(K... | [
"app/controllers/Logkafka.scala",
"app/controllers/Topic.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/model.scala",
"app/kafka/manager/utils/LogkafkaNewConfigs.scala",
"app/kafka/manager/utils/TopicConfigs.scala",
"test/controller/api/TestKafkaStateCheck.scal... | [] | diff --git a/test/controller/api/TestKafkaStateCheck.scala b/test/controller/api/TestKafkaStateCheck.scala
index 7c171734c..01d3af487 100644
--- a/test/controller/api/TestKafkaStateCheck.scala
+++ b/test/controller/api/TestKafkaStateCheck.scala
@@ -76,7 +76,7 @@ class TestKafkaStateCheck extends CuratorAwareTest with K... | true | |
yahoo/CMAK | 620 | issue_to_patch | Add support for Kafka 2.1.0 and 2.1.1 | Doing the same thing as everything for `2.0.0`, just for `2.1.0` now. Seems it passes tests... | 4ee373d12c0d4627aa2268dc3d47bc35eaccb675 | 259868b21a98c99b315d134321f831da1df88ded | diff --git a/app/controllers/Logkafka.scala b/app/controllers/Logkafka.scala
index 1fd3ae0ac..a64813729 100644
--- a/app/controllers/Logkafka.scala
+++ b/app/controllers/Logkafka.scala
@@ -92,6 +92,10 @@ class Logkafka (val messagesApi: MessagesApi, val kafkaManagerContext: KafkaMana
LogkafkaNewConfigs.configMaps(... | [
"app/controllers/Logkafka.scala",
"app/controllers/Topic.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/model.scala",
"app/kafka/manager/utils/LogkafkaNewConfigs.scala",
"app/kafka/manager/utils/TopicConfigs.scala",
"test/controller/api/TestKafkaStateCheck.scal... | [] | diff --git a/test/controller/api/TestKafkaStateCheck.scala b/test/controller/api/TestKafkaStateCheck.scala
index dd8f61fcf..7c171734c 100644
--- a/test/controller/api/TestKafkaStateCheck.scala
+++ b/test/controller/api/TestKafkaStateCheck.scala
@@ -76,7 +76,7 @@ class TestKafkaStateCheck extends CuratorAwareTest with K... | true | |
yahoo/CMAK | 618 | issue_to_patch | slim down docker image size | Propose:
we use the `openjdk:8-jre-slim` instead of the `openjdk:8-jre` to slim down the size of the docker images.
effect:
size of the image decreased from 600+MB to 400MB. | f671f1bf89368dbace4ce92f6f55b352ef4cc168 | 35139243989126bca70d09852c24b22299896501 | diff --git a/build.sbt b/build.sbt
index 6a09d62d2..0639245a5 100644
--- a/build.sbt
+++ b/build.sbt
@@ -74,7 +74,7 @@ dockerfile in docker := {
val zipFile: File = dist.value
new Dockerfile {
- from("openjdk:8-jre")
+ from("openjdk:8-jre-slim")
add(zipFile, file("/opt/kafka-manager.zip"))
workD... | [
"build.sbt"
] | [] | true | ||
yahoo/CMAK | 605 | issue_to_patch | Fix typo in views.consumer.consumerList script tag | f3823469537d577f2b1a32455b5cb32cd826a95c | 7ede1d35ec314f14a802f752dbd3fbbde784061e | diff --git a/app/views/consumer/consumerList.scala.html b/app/views/consumer/consumerList.scala.html
index 946662c0d..dbe859298 100644
--- a/app/views/consumer/consumerList.scala.html
+++ b/app/views/consumer/consumerList.scala.html
@@ -12,7 +12,7 @@
}
@consumerScripts = {
- <script ype="text/javascript">
+ <... | [
"app/views/consumer/consumerList.scala.html"
] | [] | true | |||
yahoo/CMAK | 607 | issue_to_patch | Fix Issue #606 | f3823469537d577f2b1a32455b5cb32cd826a95c | f0ebc84c83998856b425dc60dff134950aef8eb0 | diff --git a/app/kafka/manager/actor/cluster/KafkaStateActor.scala b/app/kafka/manager/actor/cluster/KafkaStateActor.scala
index 7654e261f..ec1effcb1 100644
--- a/app/kafka/manager/actor/cluster/KafkaStateActor.scala
+++ b/app/kafka/manager/actor/cluster/KafkaStateActor.scala
@@ -1209,7 +1209,7 @@ class KafkaStateActor... | [
"app/kafka/manager/actor/cluster/KafkaStateActor.scala"
] | [] | true | |||
yahoo/CMAK | 608 | issue_to_patch | Update json4s to 3.6.3 to get rid of vulnerable jackson version | According to [CVE details](https://www.cvedetails.com/vulnerability-list/vendor_id-15866/product_id-42991/Fasterxml-Jackson-databind.html), jackson-databind versions prior to 2.9.x are considered vulnerable.
This PR updates json4s to 3.6.3 and jackson-databind is transitively updated to 2.9.6. | f3823469537d577f2b1a32455b5cb32cd826a95c | 38f934ee78b7eaf03cefe9e783927364bc146735 | diff --git a/build.sbt b/build.sbt
index 6a90fc378..6a09d62d2 100644
--- a/build.sbt
+++ b/build.sbt
@@ -30,8 +30,8 @@ libraryDependencies ++= Seq(
"org.webjars" % "dustjs-linkedin" % "2.6.1-1",
"org.apache.curator" % "curator-framework" % "2.10.0" exclude("log4j","log4j") exclude("org.slf4j", "slf4j-log4j12") fo... | [
"build.sbt"
] | [] | true | ||
yahoo/CMAK | 600 | issue_to_patch | Basic authentication with ldap support | Update BasicAuthenticationFilter to work with Active Directory service | 04b585eddd81768b03b6989efcfb5032307a1888 | 8697396397b4dfcbb514c8e082c7069b7d463b53 | diff --git a/README.md b/README.md
index 4471bbb74..a8ff75483 100644
--- a/README.md
+++ b/README.md
@@ -117,6 +117,37 @@ You should increase the above for large # of consumers with consumer polling ena
Kafka managed consumer offset is now consumed by KafkaManagedOffsetCache from the "__consumer_offsets" topic. Not... | [
"README.md",
"app/controllers/BasicAuthenticationFilter.scala",
"build.sbt",
"conf/application.conf"
] | [
{
"comment": "Would you want to log the error message here as debug or trace in case you need to debug?",
"path": "app/controllers/BasicAuthenticationFilter.scala",
"hunk": "@@ -20,33 +20,80 @@ import play.api.mvc.Results.Unauthorized\n \n import scala.collection.JavaConverters._\n import scala.concurre... | true | ||
yahoo/CMAK | 600 | comment_to_fix | Basic authentication with ldap support | Would you want to log the error message here as debug or trace in case you need to debug? | 04b585eddd81768b03b6989efcfb5032307a1888 | 8697396397b4dfcbb514c8e082c7069b7d463b53 | diff --git a/app/controllers/BasicAuthenticationFilter.scala b/app/controllers/BasicAuthenticationFilter.scala
index ce08446fa..ee4feac90 100644
--- a/app/controllers/BasicAuthenticationFilter.scala
+++ b/app/controllers/BasicAuthenticationFilter.scala
@@ -2,11 +2,11 @@ package controllers
import com.typesafe.conf... | [
"app/controllers/BasicAuthenticationFilter.scala"
] | [
{
"comment": "Would you want to log the error message here as debug or trace in case you need to debug?",
"path": "app/controllers/BasicAuthenticationFilter.scala",
"hunk": "@@ -20,33 +20,80 @@ import play.api.mvc.Results.Unauthorized\n \n import scala.collection.JavaConverters._\n import scala.concurre... | true | ||
yahoo/CMAK | 600 | comment_to_fix | Basic authentication with ldap support | Any reason to make this lazy since it is always evaluated on line 68? | 04b585eddd81768b03b6989efcfb5032307a1888 | 8697396397b4dfcbb514c8e082c7069b7d463b53 | diff --git a/app/controllers/BasicAuthenticationFilter.scala b/app/controllers/BasicAuthenticationFilter.scala
index ce08446fa..ee4feac90 100644
--- a/app/controllers/BasicAuthenticationFilter.scala
+++ b/app/controllers/BasicAuthenticationFilter.scala
@@ -2,11 +2,11 @@ package controllers
import com.typesafe.conf... | [
"app/controllers/BasicAuthenticationFilter.scala"
] | [
{
"comment": "Any reason to make this lazy since it is always evaluated on line 68?",
"path": "app/controllers/BasicAuthenticationFilter.scala",
"hunk": "@@ -20,33 +20,80 @@ import play.api.mvc.Results.Unauthorized\n \n import scala.collection.JavaConverters._\n import scala.concurrent.Future\n+import s... | true | ||
yahoo/CMAK | 462 | issue_to_patch | Sort topicSummary JSON by partition number | Currently, the results can be returned in a random order, which makes the
per-partition stats less useful than they could be. | aa640ad130315e546fa1543b2ac39ddf1f130f4e | 77e311487bb1d2457d88ba683e295ed97b99c270 | diff --git a/app/controllers/api/KafkaStateCheck.scala b/app/controllers/api/KafkaStateCheck.scala
index 2fe89dc66..08e1c26fc 100644
--- a/app/controllers/api/KafkaStateCheck.scala
+++ b/app/controllers/api/KafkaStateCheck.scala
@@ -116,7 +116,12 @@ class KafkaStateCheck (val messagesApi: MessagesApi, val kafkaManagerC... | [
"app/controllers/api/KafkaStateCheck.scala"
] | [] | true | ||
yahoo/CMAK | 511 | issue_to_patch | consumer lag in the consumer summary | I want to use the kafka manager to monitor the consumer lag. Currently I need to call the `groupSummary` for every single consumer group to get their current lag. The lag of all consumers is available in the context of `consumersSummary`, it's just not returned. So I extended the API to also return the lag. There are o... | 1aaa75b1867be8fb7a3f34bdab6ebccf9714e6a6 | 6b0c38e6088f2bd75f53a5713b28991b5a51b0cd | diff --git a/app/controllers/api/KafkaStateCheck.scala b/app/controllers/api/KafkaStateCheck.scala
index a655d5408..99fa731f8 100644
--- a/app/controllers/api/KafkaStateCheck.scala
+++ b/app/controllers/api/KafkaStateCheck.scala
@@ -145,7 +145,16 @@ class KafkaStateCheck (val messagesApi: MessagesApi, val kafkaManagerC... | [
"app/controllers/api/KafkaStateCheck.scala"
] | [] | true | ||
yahoo/CMAK | 579 | issue_to_patch | Web Application Potentially Vulnerable to Clickjacking For Nessus | The Security vulnerabilities of Web Application Potentially Vulnerable to Clickjacking Scan By Nessus | 63c5804a8dc896840a557f781813d322481cda91 | 1fdc1e1f5a12a77e5802e73a29cae3b3b0f15941 | diff --git a/app/controllers/ApiHealth.scala b/app/controllers/ApiHealth.scala
index dcc593dc1..40b2c82cb 100644
--- a/app/controllers/ApiHealth.scala
+++ b/app/controllers/ApiHealth.scala
@@ -6,7 +6,7 @@ import play.api.mvc._
class ApiHealth(val messagesApi: MessagesApi) extends Controller with I18nSupport {
def... | [
"app/controllers/ApiHealth.scala",
"app/controllers/Application.scala",
"app/controllers/Cluster.scala",
"app/controllers/Consumer.scala",
"app/controllers/Logkafka.scala",
"app/controllers/PreferredReplicaElection.scala",
"app/controllers/ReassignPartitions.scala",
"app/controllers/Topic.scala",
"a... | [] | true | ||
yahoo/CMAK | 598 | issue_to_patch | Remove navigation menu items when features are absent | When features `KMPreferredReplicaElectionFeature` and `KMReassignPartitionsFeature` are removed, the menu navigation buttons for the corresponding features are visible but non-functional.
Let's remove these menu items when the features are absent. | 4273fc0e8a1cd730bfea512bda447aafe3f0dc00 | 4d5176b32ccd4a1b385a57502569e3717879e76f | diff --git a/app/models/navigation/Menus.scala b/app/models/navigation/Menus.scala
index dc7120bbe..2c6afbcb1 100644
--- a/app/models/navigation/Menus.scala
+++ b/app/models/navigation/Menus.scala
@@ -5,7 +5,7 @@
package models.navigation
-import features.{KMTopicManagerFeature, KMClusterManagerFeature, Applicatio... | [
"app/models/navigation/Menus.scala"
] | [] | true | ||
yahoo/CMAK | 599 | issue_to_patch | Remove zookeeper info when cluster-manager feature absent | When operating Kafka-manager for multiple tenants, its not uncommon to remove the `KMClusterManagerFeature` feature in order to make Kafka-manager read-only and hide details about the setup. I'd suggest that this also includes the ZooKeeper-connect information. However, the ZooKeeper ensemble is _always_ displayed in t... | 4273fc0e8a1cd730bfea512bda447aafe3f0dc00 | 27ac3d12758492224f2637f295c1fdff23bdad43 | diff --git a/app/views/cluster/clusterViewContent.scala.html b/app/views/cluster/clusterViewContent.scala.html
index 629d7436f..f63264085 100644
--- a/app/views/cluster/clusterViewContent.scala.html
+++ b/app/views/cluster/clusterViewContent.scala.html
@@ -2,15 +2,18 @@
* Copyright 2015 Yahoo Inc. Licensed under the A... | [
"app/views/cluster/clusterViewContent.scala.html"
] | [] | true | ||
yahoo/CMAK | 596 | issue_to_patch | Add support for kafka v1.1.1 | Added support for kafka v1.1.1.
All `sbt test` passed. | 6951836b0432a75d068a0291cee3a7ca4926e511 | e4fd1361f87fd7917a216eae22a9dd7479a736f8 | diff --git a/app/controllers/Logkafka.scala b/app/controllers/Logkafka.scala
index 511b7cf13..1a8c4fb3d 100644
--- a/app/controllers/Logkafka.scala
+++ b/app/controllers/Logkafka.scala
@@ -88,6 +88,8 @@ class Logkafka (val messagesApi: MessagesApi, val kafkaManagerContext: KafkaMana
LogkafkaNewConfigs.configMaps(K... | [
"app/controllers/Logkafka.scala",
"app/controllers/Topic.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/model.scala",
"app/kafka/manager/utils/LogkafkaNewConfigs.scala",
"app/kafka/manager/utils/TopicConfigs.scala",
"test/kafka/manager/TestKafkaMetrics.scala",
... | [] | diff --git a/test/kafka/manager/TestKafkaMetrics.scala b/test/kafka/manager/TestKafkaMetrics.scala
index d57d66363..c49c10bf6 100644
--- a/test/kafka/manager/TestKafkaMetrics.scala
+++ b/test/kafka/manager/TestKafkaMetrics.scala
@@ -6,7 +6,7 @@
package kafka.manager
import kafka.manager.jmx.KafkaMetrics
-import kaf... | true | |
yahoo/CMAK | 544 | issue_to_patch | Added 2.0.0 as valid version | Simply add 2.0.0 as valid version and some tests. | 63c5804a8dc896840a557f781813d322481cda91 | aba9eda1516f4d0c3721973ff2877cf8c85581cf | diff --git a/app/controllers/Logkafka.scala b/app/controllers/Logkafka.scala
index ce4dc56ed..511b7cf13 100644
--- a/app/controllers/Logkafka.scala
+++ b/app/controllers/Logkafka.scala
@@ -88,6 +88,8 @@ class Logkafka (val messagesApi: MessagesApi, val kafkaManagerContext: KafkaMana
LogkafkaNewConfigs.configMaps(K... | [
"app/controllers/Logkafka.scala",
"app/controllers/Topic.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/model.scala",
"app/kafka/manager/utils/LogkafkaNewConfigs.scala",
"app/kafka/manager/utils/TopicConfigs.scala",
"test/controller/api/TestKafkaStateCheck.scal... | [] | diff --git a/test/controller/api/TestKafkaStateCheck.scala b/test/controller/api/TestKafkaStateCheck.scala
index f8e212ebb..dd8f61fcf 100644
--- a/test/controller/api/TestKafkaStateCheck.scala
+++ b/test/controller/api/TestKafkaStateCheck.scala
@@ -76,7 +76,7 @@ class TestKafkaStateCheck extends CuratorAwareTest with K... | true | |
yahoo/CMAK | 593 | issue_to_patch | allow functionality with Kafka 2.12-2.1.0 | 2140b5ebe64028f8ce300ea712999053a82a95fe | f1a338ae081abd49635fca5f76e903aa9b209c52 | diff --git a/app/kafka/manager/utils/one10/GroupMetadataManager.scala b/app/kafka/manager/utils/one10/GroupMetadataManager.scala
index 85771cdf1..db503b075 100644
--- a/app/kafka/manager/utils/one10/GroupMetadataManager.scala
+++ b/app/kafka/manager/utils/one10/GroupMetadataManager.scala
@@ -285,7 +285,6 @@ class Group... | [
"app/kafka/manager/utils/one10/GroupMetadataManager.scala"
] | [] | true | |||
yahoo/CMAK | 533 | issue_to_patch | Read securityprotocol from cluster config | 1f7e58e7a6ed7609abae3dc2053b2cd0ecd405fe | 9596b99d530a4a509887cf5317804bbbfeb9149d | diff --git a/app/kafka/manager/actor/cluster/KafkaStateActor.scala b/app/kafka/manager/actor/cluster/KafkaStateActor.scala
index 8fc18a8d8..5d17469db 100644
--- a/app/kafka/manager/actor/cluster/KafkaStateActor.scala
+++ b/app/kafka/manager/actor/cluster/KafkaStateActor.scala
@@ -1455,8 +1455,7 @@ class KafkaStateActor... | [
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"build.sbt"
] | [] | true | |||
yahoo/CMAK | 531 | issue_to_patch | Use secure communication if broker supports it | 8dcdbf8fabb0001691c9b52b447b656f498b4d7b | fb1bfdd6f22a7d10f947e7061bf5ecbff1daec04 | diff --git a/app/kafka/manager/actor/cluster/KafkaStateActor.scala b/app/kafka/manager/actor/cluster/KafkaStateActor.scala
index e5a0c6716..8fc18a8d8 100644
--- a/app/kafka/manager/actor/cluster/KafkaStateActor.scala
+++ b/app/kafka/manager/actor/cluster/KafkaStateActor.scala
@@ -46,6 +46,7 @@ import scala.util.{Failur... | [
"app/kafka/manager/actor/cluster/KafkaStateActor.scala"
] | [] | true | |||
yahoo/CMAK | 526 | issue_to_patch | Use caffeine | d4cd461a175b847e36f75c11ee632c843e669cd9 | 324411dd32ee4f75093aa7084d82358f1b25476a | diff --git a/app/controllers/Cluster.scala b/app/controllers/Cluster.scala
index 679202c17..7a3427c8a 100644
--- a/app/controllers/Cluster.scala
+++ b/app/controllers/Cluster.scala
@@ -108,6 +108,9 @@ class Cluster (val messagesApi: MessagesApi, val kafkaManagerContext: KafkaManag
, "offsetCacheThreadPoolQue... | [
"app/controllers/Cluster.scala",
"app/kafka/manager/KafkaManager.scala",
"app/kafka/manager/actor/KafkaManagerActor.scala",
"app/kafka/manager/actor/cluster/ClusterManagerActor.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/ActorModel.scala",
"app/kafka/manager... | [] | diff --git a/test/kafka/manager/BaseTest.scala b/test/kafka/manager/BaseTest.scala
index 7b24f25ca..8b975933a 100644
--- a/test/kafka/manager/BaseTest.scala
+++ b/test/kafka/manager/BaseTest.scala
@@ -1,5 +1,6 @@
package kafka.manager
+import kafka.manager.actor.cluster.KafkaManagedOffsetCacheConfig
import kafka.ma... | true | ||
yahoo/CMAK | 522 | issue_to_patch | Make all the test passing | This complement pull request https://github.com/yahoo/kafka-manager/pull/519 in order to have successful tests and to add 1.0.1 version added everywhere | bf068d079e8b1828708e4b441458372911475ef3 | cf8f81f71f96519a13ef6b7f0f013a452b4103f4 | diff --git a/app/controllers/Logkafka.scala b/app/controllers/Logkafka.scala
index b16a0dae8..ce4dc56ed 100644
--- a/app/controllers/Logkafka.scala
+++ b/app/controllers/Logkafka.scala
@@ -84,6 +84,10 @@ class Logkafka (val messagesApi: MessagesApi, val kafkaManagerContext: KafkaMana
LogkafkaNewConfigs.configMaps(... | [
"app/controllers/Logkafka.scala",
"app/controllers/Topic.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/ActorModel.scala",
"app/kafka/manager/model/model.scala",
"app/kafka/manager/utils/LogkafkaNewConfigs.scala",
"app/kafka/manager/utils/TopicConfigs.scala",
... | [] | diff --git a/test/controller/api/TestKafkaStateCheck.scala b/test/controller/api/TestKafkaStateCheck.scala
index 7ae4efa0a..b9de16471 100644
--- a/test/controller/api/TestKafkaStateCheck.scala
+++ b/test/controller/api/TestKafkaStateCheck.scala
@@ -5,23 +5,24 @@
package controller.api
-import com.typesafe.config.{... | true | |
yahoo/CMAK | 519 | issue_to_patch | Upgrade to Kafka 1.1.0 | bf068d079e8b1828708e4b441458372911475ef3 | 55c2ab86f4fcacdc470b203bd1e6357089127231 | diff --git a/app/controllers/Logkafka.scala b/app/controllers/Logkafka.scala
index b16a0dae8..dc033fc6d 100644
--- a/app/controllers/Logkafka.scala
+++ b/app/controllers/Logkafka.scala
@@ -84,6 +84,8 @@ class Logkafka (val messagesApi: MessagesApi, val kafkaManagerContext: KafkaMana
LogkafkaNewConfigs.configMaps(K... | [
"app/controllers/Logkafka.scala",
"app/controllers/Topic.scala",
"app/kafka/manager/actor/cluster/KafkaStateActor.scala",
"app/kafka/manager/model/ActorModel.scala",
"app/kafka/manager/model/model.scala",
"app/kafka/manager/utils/LogkafkaNewConfigs.scala",
"app/kafka/manager/utils/TopicConfigs.scala",
... | [
{
"comment": "Is this expected to commented out?",
"path": "test/kafka/manager/TestKafkaManager.scala",
"hunk": "@@ -94,6 +96,11 @@ class TestKafkaManager extends CuratorAwareTest with BaseTest {\n })\n simpleProducerThread.foreach(_.start())\n Thread.sleep(1000)\n+\n+ //val future = kafk... | diff --git a/test/controller/api/TestKafkaStateCheck.scala b/test/controller/api/TestKafkaStateCheck.scala
index 7ae4efa0a..2efe2bab5 100644
--- a/test/controller/api/TestKafkaStateCheck.scala
+++ b/test/controller/api/TestKafkaStateCheck.scala
@@ -5,23 +5,24 @@
package controller.api
-import com.typesafe.config.{... | true | ||
yangshun/tech-interview-handbook | 732 | issue_to_patch | content: fix resume font size recommendation from 10 px to 10 pt
# Description
In the resume chapter of the website, specifically under the section ["Only use standard fonts of readable sizes"](https://www.techinterviewhandbook.org/resume/#only-use-standard-fonts-of-readable-sizes), **the guide currently recommends a... | content: fix resume font size recommendation from 10 px to 10 pt | # Description
Fixes the recommended minimum font size in the chapter ["Writing your software engineer resume"](https://www.techinterviewhandbook.org/resume/).
# Context
Previously, the guide recommended a minimum of 10 px. Since resumes are supposed to be written in standard word processors like Microsoft Word... | 0c3369896c26f8c0a0ef1cd95a18b028bc54143d | fd99c6842a6d6fb8c8cbea1ee1e60ef3b766921b | diff --git a/apps/website/contents/resume.md b/apps/website/contents/resume.md
index 5650f7a7e..ba3da172b 100644
--- a/apps/website/contents/resume.md
+++ b/apps/website/contents/resume.md
@@ -69,7 +69,7 @@ They also offer resume examples/references from candidates who have received mul
New fonts may convert letters... | [
"apps/website/contents/resume.md"
] | [] | true | |
yangshun/tech-interview-handbook | 1 | issue_to_patch | Fix link | f6c2b983d9735adf23567f8977c56ff1ee759846 | 2c4c416b1cb1118af3dd0108d7bac4556fcbc3f6 | diff --git a/preparing/README.md b/preparing/README.md
index 428127017e..7fb25582bb 100644
--- a/preparing/README.md
+++ b/preparing/README.md
@@ -17,7 +17,7 @@ One exception to the convention of allowing you to "pick any programming languag
If you have been out of college for a while, it will be highly advisable to... | [
"preparing/README.md"
] | [] | true | |||
yangshun/tech-interview-handbook | 750 | issue_to_patch | docs: update current VoIP platforms | `BlueJeans` - Defunct on MarchΒ 29,Β 2024
`Skype` - shut down on May 5, 2025
`Google Hangouts` - shutting down on November 1, 2022 -> `Google Meet/Google Chat`
| 37d533e4de82cf19989fef10336b2aeba48448f4 | c0ca75acf4df9d74a785fea783b9c02b59825484 | diff --git a/apps/website/contents/software-engineering-interview-guide.md b/apps/website/contents/software-engineering-interview-guide.md
index c0a1424ec..e86b34bc7 100644
--- a/apps/website/contents/software-engineering-interview-guide.md
+++ b/apps/website/contents/software-engineering-interview-guide.md
@@ -88,7 +8... | [
"apps/website/contents/software-engineering-interview-guide.md"
] | [] | true | ||
yangshun/tech-interview-handbook | 685 | issue_to_patch | contents/graph: use popleft() instead of pop() in Topological sort queue | 5dd02b1d47d351c58ee7464466b02827553104b2 | dc3f915ce39e032b323a1e27e9da228c0e00d086 | diff --git a/apps/website/contents/algorithms/graph.md b/apps/website/contents/algorithms/graph.md
index 5da3ec592c..1fc214bb5f 100644
--- a/apps/website/contents/algorithms/graph.md
+++ b/apps/website/contents/algorithms/graph.md
@@ -180,7 +180,7 @@ def graph_topo_sort(num_nodes, edges):
if nodes[node_id]['in... | [
"apps/website/contents/algorithms/graph.md"
] | [] | true | |||
yangshun/tech-interview-handbook | 635 | issue_to_patch | Update text tree.md | - update bold style for the text | 3365eda7775f94b2da75cde801cf9a50b6d2ce12 | 6c37b79d415d6664922ce3c429f5126f9b4db69c | diff --git a/apps/website/contents/algorithms/tree.md b/apps/website/contents/algorithms/tree.md
index 5b10cbc080..a6c8355ca7 100644
--- a/apps/website/contents/algorithms/tree.md
+++ b/apps/website/contents/algorithms/tree.md
@@ -50,7 +50,7 @@ Trees are commonly used to represent hierarchical data, e.g. file systems, ... | [
"apps/website/contents/algorithms/tree.md"
] | [] | true | ||
yangshun/tech-interview-handbook | 634 | issue_to_patch | contents/matrix: transposition snippet (python) | `zip`ping the matrix is a nice trick but it doesn't always produce what you need (a matrix) in a time-sensitive interview environment. The output of `zip` is an iterator of tuples which doesn't allow accessing elements by index. Converting the iterator of tuples to matrix takes the same amount of code as transposing th... | 3365eda7775f94b2da75cde801cf9a50b6d2ce12 | 3f66dc7e13d58f9669be4e9d1a422ad7fd3fd8e4 | diff --git a/apps/website/contents/algorithms/matrix.md b/apps/website/contents/algorithms/matrix.md
index 321464e332..8866fb6644 100644
--- a/apps/website/contents/algorithms/matrix.md
+++ b/apps/website/contents/algorithms/matrix.md
@@ -59,7 +59,7 @@ Many grid-based games can be modeled as a matrix, such as Tic-Tac-T... | [
"apps/website/contents/algorithms/matrix.md"
] | [] | true | ||
yangshun/tech-interview-handbook | 633 | issue_to_patch | contents: use Python deque instead of queue | Queue is designed for synchronous communication between threads, e.g. `get()` is a blocking call.
https://docs.python.org/3/library/queue.html#module-queue
The most appropriate class for both stack and queue would be `deque`
https://docs.python.org/3/library/collections.html#collections.deque | 3365eda7775f94b2da75cde801cf9a50b6d2ce12 | 5785ad98faf3419b6942fe44f31b38379eb2189b | diff --git a/apps/website/contents/algorithms/queue.md b/apps/website/contents/algorithms/queue.md
index 7341992f31..cb1df981ef 100644
--- a/apps/website/contents/algorithms/queue.md
+++ b/apps/website/contents/algorithms/queue.md
@@ -40,7 +40,7 @@ Breadth-first search is commonly implemented using queues.
| --- | ---... | [
"apps/website/contents/algorithms/queue.md"
] | [] | true | ||
yangshun/tech-interview-handbook | 740 | issue_to_patch | Update binary.md: Correct shift direction | Correct bit shift direction for setting kth binary bit. | 0c3369896c26f8c0a0ef1cd95a18b028bc54143d | ea9ea958039b5892ccd0f8b12cf2bda87c675fb9 | diff --git a/apps/website/contents/algorithms/binary.md b/apps/website/contents/algorithms/binary.md
index 367049a19..4ae720246 100644
--- a/apps/website/contents/algorithms/binary.md
+++ b/apps/website/contents/algorithms/binary.md
@@ -47,7 +47,7 @@ Some helpful utility snippets:
| Technique | Code |
| --- | --- |
... | [
"apps/website/contents/algorithms/binary.md"
] | [] | true | ||
yangshun/tech-interview-handbook | 731 | issue_to_patch | blog: fix typos in "Take Control Over Your Coding Interview" | ## Fix typos in blog post
Fixed two spelling errors in the blog post "Take Control Over Your Coding Interview":
- Line 99: `quetsions` β `questions`
- Line 145: `seperately` β `separately` | 75a575ef5c921c1fd6484bb699e9ce70889113c9 | 1589984b4eb09240ece5cf8167b7e32a4afba707 | diff --git a/apps/website/blog/2022-04-20-take-control-over-your-coding-interview copy.md b/apps/website/blog/2022-04-20-take-control-over-your-coding-interview.md
similarity index 96%
rename from apps/website/blog/2022-04-20-take-control-over-your-coding-interview copy.md
rename to apps/website/blog/2022-04-20-take-co... | [
"apps/website/blog/2022-04-20-take-control-over-your-coding-interview.md"
] | [] | true | ||
yangshun/tech-interview-handbook | 729 | issue_to_patch | chore: Update outdated GitHub Actions versions | This PR updates outdated GitHub Action versions.
- Updated `actions/setup-node` from `v3` to `v6` in `.github/workflows/tsc.yml`
- Updated `actions/setup-node` from `v3` to `v6` in `.github/workflows/lint.yml`
- Updated `actions/checkout` from `v3` to `v6` in `.github/workflows/tsc.yml`
- Updated `actions/checkout` fr... | 9430396f989730fab83f3ccba16b4955577f107d | 8e5881de14c28b559806bd9929657aabc4c5e887 | diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml
index 7c2fd46d47..f15cc42227 100644
--- a/.github/workflows/lint.yml
+++ b/.github/workflows/lint.yml
@@ -30,9 +30,9 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout
- uses: actions/checkout@v3
+ uses: actions/che... | [
".github/workflows/lint.yml",
".github/workflows/tsc.yml"
] | [] | true | ||
yangshun/tech-interview-handbook | 721 | issue_to_patch | Outdated information: Powersort is the default sort implementation since Python 3.11
context:
- https://github.com/yangshun/tech-interview-handbook/blob/main/apps/website/contents/algorithms/sorting-searching.md
- https://www.techinterviewhandbook.org/algorithms/sorting-searching/#things-to-look-out-for-during-interv... | contents: update default Python sort to Powersort | Automated fix for issue #715 in yangshun/tech-interview-handbook.
## Changes
This PR addresses issue #715.
Closes #715 | 1d62b88a435d0f49d777131c0bf76719966787e3 | 9b141b5338a863b09a54f5122b75b35353fec397 | diff --git a/apps/portal/src/components/global/GoogleAnalytics.tsx b/apps/portal/src/components/global/GoogleAnalytics.tsx
index 472e31a50b..48ca57a35d 100644
--- a/apps/portal/src/components/global/GoogleAnalytics.tsx
+++ b/apps/portal/src/components/global/GoogleAnalytics.tsx
@@ -71,7 +71,7 @@ export default function... | [
"apps/portal/src/components/global/GoogleAnalytics.tsx",
"apps/portal/src/components/offers/offersSubmission/OffersSubmissionAnalysis.tsx",
"apps/portal/src/server/router/offers/offers-admin-router.ts",
"apps/portal/src/server/router/offers/offers-analysis-router.ts",
"apps/portal/src/server/router/offers/o... | [] | true | |
yangshun/tech-interview-handbook | 720 | issue_to_patch | contents: correct the link to self introduction in behavioral-interview.md | 95785f2760cd80c14dff3443d65455df0b4ac060 | 416c6dc156c98625e1d41c122ae9091d322d0b55 | diff --git a/apps/website/contents/behavioral-interview.md b/apps/website/contents/behavioral-interview.md
index b9b7dfcaa..f5f83f842 100644
--- a/apps/website/contents/behavioral-interview.md
+++ b/apps/website/contents/behavioral-interview.md
@@ -110,7 +110,7 @@ Construct a STAR(R) story for each project as an exerci... | [
"apps/website/contents/behavioral-interview.md"
] | [] | true | |||
yangshun/tech-interview-handbook | 717 | issue_to_patch | contents: add additional behavioral interview content | - Complete some missing pieces of the general behavioral sections and adjust framing to better fit what Iβve experienced in my coaching practice
- Example: preparing general stories + targeting Big Three questions before jumping into 30 common questions
- Add content specifically for senior engineers
- Sprinkle ... | c5b41471322481b513d150dce9ef0c0f8f8713f4 | cea61889d86e806d38bec5513d067cbc0a391758 | diff --git a/apps/website/contents/behavioral-interview-senior-candidates.md b/apps/website/contents/behavioral-interview-senior-candidates.md
new file mode 100644
index 000000000..8f7b74ce4
--- /dev/null
+++ b/apps/website/contents/behavioral-interview-senior-candidates.md
@@ -0,0 +1,111 @@
+---
+id: behavioral-interv... | [
"apps/website/contents/behavioral-interview-senior-candidates.md",
"apps/website/contents/behavioral-interview.md",
"apps/website/contents/self-introduction.md",
"apps/website/sidebars.js"
] | [] | true | ||
yangshun/tech-interview-handbook | 58 | issue_to_patch | Update stack.md | df1c15de0564f81a3c08d686f86b903efb7887f1 | 388dbc1121b2b7a376888b65c946ba6ff87c8c67 | diff --git a/algorithms/stack.md b/algorithms/stack.md
index 627ee2c61d..063e3a645f 100644
--- a/algorithms/stack.md
+++ b/algorithms/stack.md
@@ -6,3 +6,4 @@ Stack
- Write an algorithm to determine if all of the delimiters in an expression are matched and closed.
- E.g. `{ac[bb]}`, `[dklf(df(kl))d]{}` and `{[[[]]]... | [
"algorithms/stack.md"
] | [] | true | |||
yangshun/tech-interview-handbook | 714 | issue_to_patch | seo: fix HTML lang attribute missing | app.techinterviewhandbook.org slugs were missing HTML lang attribute | 7f39500d5d1cb726d3f21d56f94cc9f386bcd6b1 | 76540116e31e21bc75f4b1c16504bac01fd6b3f2 | diff --git a/apps/portal/src/pages/_document.tsx b/apps/portal/src/pages/_document.tsx
index 016ecd1a2..cb9b54f17 100644
--- a/apps/portal/src/pages/_document.tsx
+++ b/apps/portal/src/pages/_document.tsx
@@ -2,7 +2,7 @@ import { Head, Html, Main, NextScript } from 'next/document';
export default function Document()... | [
"apps/portal/src/pages/_document.tsx"
] | [] | true | ||
yangshun/tech-interview-handbook | 713 | issue_to_patch | seo: fix page has links to redirect issue | Dealt with extra links flagged out after crawl from the first pass of fixing this issue | 7f39500d5d1cb726d3f21d56f94cc9f386bcd6b1 | 150783d44601eadc1cd4c80bf7e222a1a4fd35c1 | diff --git a/apps/portal/src/pages/resumes/about.tsx b/apps/portal/src/pages/resumes/about.tsx
index 09d9f8e97..92f820841 100644
--- a/apps/portal/src/pages/resumes/about.tsx
+++ b/apps/portal/src/pages/resumes/about.tsx
@@ -87,7 +87,7 @@ export default function AboutUsPage() {
Submit your feedback
... | [
"apps/portal/src/pages/resumes/about.tsx",
"apps/website/contents/algorithms/graph.md",
"apps/website/contents/algorithms/hash-table.md",
"apps/website/contents/algorithms/heap.md",
"apps/website/contents/algorithms/oop.md",
"apps/website/contents/algorithms/queue.md",
"apps/website/contents/algorithms/... | [] | true | ||
yangshun/tech-interview-handbook | 712 | issue_to_patch | seo: fix orphan page issues | There are a few orphan page slugs namely,
1) `/algorithms/oop/`
2) `/search/`
3) `/resume-overview/`
4) `/blog/archive/`
Removed them from the sitemap as 1) seems to be incomplete, 2) a dedicated search page where the top right search will suffice, 3) `/resume` already exists which is in itself already a comp... | 7f39500d5d1cb726d3f21d56f94cc9f386bcd6b1 | dd9e1851ef243e0461212b585f6ec76021d818b7 | diff --git a/apps/website/docusaurus.config.js b/apps/website/docusaurus.config.js
index 085ffa0d4..908591148 100755
--- a/apps/website/docusaurus.config.js
+++ b/apps/website/docusaurus.config.js
@@ -208,6 +208,10 @@ module.exports = {
'/blog/tags/career/',
'/blog/tags/meta/',
'/... | [
"apps/website/docusaurus.config.js"
] | [] | true | ||
yangshun/tech-interview-handbook | 708 | issue_to_patch | seo: fix page has links to redirect | Fix "Page has links to redirect" issue.
**Special Notes**
Affiliate links for the various Grokking courses were changed, for e.g.
`https://designgurus.org/link/kJSIoU?url=https%3A%2F%2Fdesigngurus.org%2Fcourse%3Fcourseid%3Dgrokking-the-coding-interview` to `https://www.designgurus.io/course/grokking-the-coding-... | ea9d14a658332d93406a7ddad93e3254b704c47d | 25c254a9a903d4f5e401e68cd09403b4255acc37 | diff --git a/README.md b/README.md
index b82baa6a8a..fd6916d7b0 100644
--- a/README.md
+++ b/README.md
@@ -9,7 +9,7 @@
<a href="https://www.techinterviewhandbook.org/">Read on the website</a>
</h3>
<p>
- Join/follow us on <a href="https://discord.gg/usMqNaPczq" target="_blank">Discord</a> | <a href="https... | [
"README.md",
"apps/portal/src/pages/offers/about.tsx",
"apps/portal/src/pages/offers/features.tsx",
"apps/website/blog/2021-10-30-my-experience-working-as-a-meta-engineer.md",
"apps/website/blog/2022-07-09-getting-a-tech-job-as-an-undergraduate.md",
"apps/website/contents/_components/QuestionGroups.json",... | [] | true | ||
yangshun/tech-interview-handbook | 710 | issue_to_patch | seo: fix 3xx redirects issue | Ensure all grind 75 links are `https://www.techinterviewhandbook.org/grind75/` mostly by adding trailing slashes, added www for one link | ea9d14a658332d93406a7ddad93e3254b704c47d | 1e447c68dde7d35e5492b4457a6d4efaace55fba | diff --git a/apps/website/blog/2022-07-09-getting-a-tech-job-as-an-undergraduate.md b/apps/website/blog/2022-07-09-getting-a-tech-job-as-an-undergraduate.md
index 3c8541ce75..55bf5c6713 100644
--- a/apps/website/blog/2022-07-09-getting-a-tech-job-as-an-undergraduate.md
+++ b/apps/website/blog/2022-07-09-getting-a-tech-... | [
"apps/website/blog/2022-07-09-getting-a-tech-job-as-an-undergraduate.md",
"apps/website/contents/best-practice-questions.md",
"apps/website/contents/coding-interview-prep.md",
"apps/website/contents/software-engineering-interview-guide.md",
"apps/website/docusaurus.config.js",
"apps/website/src/data/succe... | [] | true | ||
yangshun/tech-interview-handbook | 709 | issue_to_patch | seo: fix page has links to broken page issue | Removed 404 links | ea9d14a658332d93406a7ddad93e3254b704c47d | 33a85669e28ff1ab488cb2c550dc014c60fbfed2 | diff --git a/apps/website/blog/2019-11-03-are-front-end-development-enough-for-a-career.md b/apps/website/blog/2019-11-03-are-front-end-development-enough-for-a-career.md
index 4516b87fb..e1afefaca 100644
--- a/apps/website/blog/2019-11-03-are-front-end-development-enough-for-a-career.md
+++ b/apps/website/blog/2019-11... | [
"apps/website/blog/2019-11-03-are-front-end-development-enough-for-a-career.md",
"apps/website/blog/2021-12-23-front-end-vs-back-end-system-design-interviews.md"
] | [] | true | ||
yangshun/tech-interview-handbook | 707 | issue_to_patch | seo: fix non canonical page in sitemap | Excluded non-canonical pages from sitemap | 9e4909cbf7ecac6bbad0906e4f783a3f812cfa69 | 94a67589f890c399e9ac33aaa0a5426d6ba73b0d | diff --git a/apps/website/docusaurus.config.js b/apps/website/docusaurus.config.js
index af0b36985..6a872524d 100755
--- a/apps/website/docusaurus.config.js
+++ b/apps/website/docusaurus.config.js
@@ -196,6 +196,20 @@ module.exports = {
blog: {
blogSidebarCount: 15,
},
+ sitemap: {
+... | [
"apps/website/docusaurus.config.js"
] | [] | true | ||
yangshun/tech-interview-handbook | 706 | issue_to_patch | seo: fix page has broken image issue | Zhenghao's image link was broken, copied how FEIH used his image with a local copy | 9e4909cbf7ecac6bbad0906e4f783a3f812cfa69 | 8fa0f7e5caec7b78915b26691241aec4bd465fdc | diff --git a/apps/website/blog/2021-12-23-front-end-vs-back-end-system-design-interviews.md b/apps/website/blog/2021-12-23-front-end-vs-back-end-system-design-interviews.md
index aef0d3503b..5eb43560b3 100644
--- a/apps/website/blog/2021-12-23-front-end-vs-back-end-system-design-interviews.md
+++ b/apps/website/blog/20... | [
"apps/website/blog/2021-12-23-front-end-vs-back-end-system-design-interviews.md",
"apps/website/blog/2022-04-20-take-control-over-your-coding-interview copy.md",
"apps/website/blog/2022-04-21-why-you-should-include-debugging-in-the-interview-process.md",
"apps/website/static/img/authors/zhenghao.jpg"
] | [] | true | ||
yangshun/tech-interview-handbook | 705 | issue_to_patch | app/resumes: fix title tag missing | Added a title tag for https://app.techinterviewhandbook.org/resumes/about | 9e4909cbf7ecac6bbad0906e4f783a3f812cfa69 | 40d9b410279b1726d08141a269be689d741ec42a | diff --git a/apps/portal/src/pages/resumes/about.tsx b/apps/portal/src/pages/resumes/about.tsx
index 8eb6a5f746..09d9f8e97b 100644
--- a/apps/portal/src/pages/resumes/about.tsx
+++ b/apps/portal/src/pages/resumes/about.tsx
@@ -1,3 +1,5 @@
+import Head from 'next/head';
+
import Container from '~/components/shared/Cont... | [
"apps/portal/src/pages/resumes/about.tsx"
] | [] | true | ||
yangshun/tech-interview-handbook | 704 | issue_to_patch | seo: fix canonical points to 4xx issue | Some of Zhenghao's blog posts that were canonical links seem to be removed, removed the corresponding canonical links | 9e4909cbf7ecac6bbad0906e4f783a3f812cfa69 | 5c59628f8a86f8497f4c268222644edef87d9a6a | diff --git a/apps/website/blog/2021-12-23-front-end-vs-back-end-system-design-interviews.md b/apps/website/blog/2021-12-23-front-end-vs-back-end-system-design-interviews.md
index aef0d3503b..a69e6202d9 100644
--- a/apps/website/blog/2021-12-23-front-end-vs-back-end-system-design-interviews.md
+++ b/apps/website/blog/20... | [
"apps/website/blog/2021-12-23-front-end-vs-back-end-system-design-interviews.md",
"apps/website/blog/2022-04-20-take-control-over-your-coding-interview copy.md"
] | [] | true | ||
yangshun/tech-interview-handbook | 703 | issue_to_patch | seo: fix canonical points to redirect issue | Rectify Ahrefs issue for Canonical points to redirect by using final links after redirect chains for canonical links | 9e4909cbf7ecac6bbad0906e4f783a3f812cfa69 | 75cce2c061316170c008c34acca2ae28d54d51f2 | diff --git a/apps/website/blog/2019-11-03-are-front-end-development-enough-for-a-career.md b/apps/website/blog/2019-11-03-are-front-end-development-enough-for-a-career.md
index e6136139eb..4516b87fb7 100644
--- a/apps/website/blog/2019-11-03-are-front-end-development-enough-for-a-career.md
+++ b/apps/website/blog/2019-... | [
"apps/website/blog/2019-11-03-are-front-end-development-enough-for-a-career.md",
"apps/website/blog/2021-04-12-importance-of-communicating-effectively-as-an-engineer.md",
"apps/website/blog/2021-08-19-facebook-career-questions-and-answers.md",
"apps/website/blog/2021-08-28-front-end-career-questions.md",
"a... | [] | true | ||
yangshun/tech-interview-handbook | 692 | issue_to_patch | contents/algorithms: fix incorrect time complexity for anagrams | 5dd02b1d47d351c58ee7464466b02827553104b2 | 906c48f6a9759d70c1609030343861643a872441 | diff --git a/apps/website/contents/algorithms/string.md b/apps/website/contents/algorithms/string.md
index 74472413de..c7c183f498 100644
--- a/apps/website/contents/algorithms/string.md
+++ b/apps/website/contents/algorithms/string.md
@@ -95,7 +95,7 @@ An anagram is word switch or word play. It is the result of rearran... | [
"apps/website/contents/algorithms/string.md"
] | [] | true | |||
yangshun/tech-interview-handbook | 700 | issue_to_patch | [fix] remove extra word 'the' , invalid grammar. | f02a5fac49d4257c7946f21062a4ea5fadc46eff | 11555db7dcc26b9e6d5dc439497020489b7ae262 | diff --git a/apps/website/contents/behavioral-interview-rubrics.md b/apps/website/contents/behavioral-interview-rubrics.md
index d1064b612..12084fffb 100644
--- a/apps/website/contents/behavioral-interview-rubrics.md
+++ b/apps/website/contents/behavioral-interview-rubrics.md
@@ -37,7 +37,7 @@ To assess these focus are... | [
"apps/website/contents/behavioral-interview-rubrics.md"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.