url stringlengths 50 53 | repository_url stringclasses 1 value | labels_url stringlengths 64 67 | comments_url stringlengths 59 62 | events_url stringlengths 57 60 | html_url stringlengths 38 43 | id int64 597k 2.65B | node_id stringlengths 18 32 | number int64 1 6.83k | title stringlengths 1 296 | user dict | labels listlengths 0 5 | state stringclasses 2 values | locked bool 2 classes | assignee dict | assignees listlengths 0 4 | milestone dict | comments int64 0 211 | created_at stringlengths 20 20 | updated_at stringlengths 20 20 | closed_at stringlengths 20 20 ⌀ | author_association stringclasses 3 values | active_lock_reason stringclasses 4 values | body stringlengths 0 65.6k ⌀ | closed_by dict | reactions dict | timeline_url stringlengths 59 62 | performed_via_github_app null | state_reason stringclasses 3 values | draft bool 2 classes | pull_request dict | is_pull_request bool 2 classes | issue_comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/1830 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1830/labels{/name} | https://api.github.com/repos/psf/requests/issues/1830/comments | https://api.github.com/repos/psf/requests/issues/1830/events | https://github.com/psf/requests/pull/1830 | 24,812,998 | MDExOlB1bGxSZXF1ZXN0MTExMDg4Njk= | 1,830 | Requests must be installed as root when using pip to avoid errors | {
"avatar_url": "https://avatars.githubusercontent.com/u/3462055?v=4",
"events_url": "https://api.github.com/users/NickGeek/events{/privacy}",
"followers_url": "https://api.github.com/users/NickGeek/followers",
"following_url": "https://api.github.com/users/NickGeek/following{/other_user}",
"gists_url": "https://api.github.com/users/NickGeek/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/NickGeek",
"id": 3462055,
"login": "NickGeek",
"node_id": "MDQ6VXNlcjM0NjIwNTU=",
"organizations_url": "https://api.github.com/users/NickGeek/orgs",
"received_events_url": "https://api.github.com/users/NickGeek/received_events",
"repos_url": "https://api.github.com/users/NickGeek/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/NickGeek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/NickGeek/subscriptions",
"type": "User",
"url": "https://api.github.com/users/NickGeek",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-12-27T08:37:25Z | 2021-09-08T22:01:07Z | 2013-12-27T09:39:03Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1830/reactions"
} | https://api.github.com/repos/psf/requests/issues/1830/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1830.diff",
"html_url": "https://github.com/psf/requests/pull/1830",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1830.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1830"
} | true | [
"I wouldn't recommend doing this at all. If at all possible always install your packages to virtualenvs and avoid using sudo as much as you can.\n",
"@NickGeek This is simply not true. _Sometimes_ Requests must be installed using `sudo`: if you install directly into the site packages and you don't have the correc... | |
https://api.github.com/repos/psf/requests/issues/1829 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1829/labels{/name} | https://api.github.com/repos/psf/requests/issues/1829/comments | https://api.github.com/repos/psf/requests/issues/1829/events | https://github.com/psf/requests/issues/1829 | 24,775,814 | MDU6SXNzdWUyNDc3NTgxNA== | 1,829 | r.text exception in Python 3.x | {
"avatar_url": "https://avatars.githubusercontent.com/u/1488134?v=4",
"events_url": "https://api.github.com/users/douglarek/events{/privacy}",
"followers_url": "https://api.github.com/users/douglarek/followers",
"following_url": "https://api.github.com/users/douglarek/following{/other_user}",
"gists_url": "https://api.github.com/users/douglarek/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/douglarek",
"id": 1488134,
"login": "douglarek",
"node_id": "MDQ6VXNlcjE0ODgxMzQ=",
"organizations_url": "https://api.github.com/users/douglarek/orgs",
"received_events_url": "https://api.github.com/users/douglarek/received_events",
"repos_url": "https://api.github.com/users/douglarek/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/douglarek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/douglarek/subscriptions",
"type": "User",
"url": "https://api.github.com/users/douglarek",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-12-26T02:05:39Z | 2021-09-09T00:28:22Z | 2013-12-26T02:16:21Z | NONE | resolved | I use `r.context`, it is `bytes` type, then I use `r = requests.get('http://github.com'); print(r.text)`, but an error occurs as below:
```
UnicodeEncodeError: 'ascii' codec can't encode character '\xb7' in position 235: ordinal not in range(128)
```
is it a bug in python 3 ? I use requests 2.1.0 version in openSUSE 13.1 x86_64.
Thanks
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1829/reactions"
} | https://api.github.com/repos/psf/requests/issues/1829/timeline | null | completed | null | null | false | [
"This is not the place to ask questions. Please ask your questions on [StackOverflow](http://stackoverflow.com/questions/tagged/python-requests).\n",
"@sigmavirus24 Ok, maybe my title confused you, now it is ok.\n",
"I was not confused and it's not a bug in `requests`. Your standard out encoding is `ascii`. Sta... |
https://api.github.com/repos/psf/requests/issues/1828 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1828/labels{/name} | https://api.github.com/repos/psf/requests/issues/1828/comments | https://api.github.com/repos/psf/requests/issues/1828/events | https://github.com/psf/requests/issues/1828 | 24,761,644 | MDU6SXNzdWUyNDc2MTY0NA== | 1,828 | Incorrect Timezone | {
"avatar_url": "https://avatars.githubusercontent.com/u/2215059?v=4",
"events_url": "https://api.github.com/users/intrixs/events{/privacy}",
"followers_url": "https://api.github.com/users/intrixs/followers",
"following_url": "https://api.github.com/users/intrixs/following{/other_user}",
"gists_url": "https://api.github.com/users/intrixs/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/intrixs",
"id": 2215059,
"login": "intrixs",
"node_id": "MDQ6VXNlcjIyMTUwNTk=",
"organizations_url": "https://api.github.com/users/intrixs/orgs",
"received_events_url": "https://api.github.com/users/intrixs/received_events",
"repos_url": "https://api.github.com/users/intrixs/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/intrixs/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/intrixs/subscriptions",
"type": "User",
"url": "https://api.github.com/users/intrixs",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-12-25T05:15:22Z | 2021-09-09T00:28:21Z | 2013-12-25T09:13:36Z | NONE | resolved | Recently, I tried to crawl some data from www.soccerway.com using 'requests' + 'beautifulsoup'.
Crawling went very smoothly until I found out that all of the time has been offset by 7 hours. (see below comparison)
So I was thinking maybe 'requests' didn't have the right time zone settings. Because the website said that match time will be converted to visitor's local time.
Any idea on how I can change the time-zone settings in 'requests' would be much appreciated.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1828/reactions"
} | https://api.github.com/repos/psf/requests/issues/1828/timeline | null | completed | null | null | false | [
"Sorry, I just found out this issue has nothing to do with 'requests'.The same thing happened when I tried to crawl page with 'urllib2'.\n\nTo anyone who know how to solve the time-zone difference when crawling a webpage, please help.\n\nThanks.\n",
"The best place to ask that question is probably StackOverflow. ... |
https://api.github.com/repos/psf/requests/issues/1827 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1827/labels{/name} | https://api.github.com/repos/psf/requests/issues/1827/comments | https://api.github.com/repos/psf/requests/issues/1827/events | https://github.com/psf/requests/pull/1827 | 24,742,200 | MDExOlB1bGxSZXF1ZXN0MTEwNzIwNDk= | 1,827 | Use adapter pool size for proxies | {
"avatar_url": "https://avatars.githubusercontent.com/u/168609?v=4",
"events_url": "https://api.github.com/users/pepijndevos/events{/privacy}",
"followers_url": "https://api.github.com/users/pepijndevos/followers",
"following_url": "https://api.github.com/users/pepijndevos/following{/other_user}",
"gists_url": "https://api.github.com/users/pepijndevos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pepijndevos",
"id": 168609,
"login": "pepijndevos",
"node_id": "MDQ6VXNlcjE2ODYwOQ==",
"organizations_url": "https://api.github.com/users/pepijndevos/orgs",
"received_events_url": "https://api.github.com/users/pepijndevos/received_events",
"repos_url": "https://api.github.com/users/pepijndevos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pepijndevos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pepijndevos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pepijndevos",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2013-12-24T10:25:28Z | 2021-09-08T23:08:29Z | 2014-01-08T18:50:00Z | CONTRIBUTOR | resolved | I was doing hundreds of parallel requests, and kept seeing warnings about dropped connections because the connection pool was full.
So I increased the connection pool on the adapter, and increased it some more. And then even more. It did not help.
Then I noticed that only my proxy connections where dropped.
Some investigation revealed that proxy connections use their own pool subclass.
However, this pool is created without respecting the pool size setting.
This PR simply propagates the pool kwargs to the proxy pool.
I contemplated adding additional kwargs for the proxy pool size, but this seems uneccecery complexity.
If there is a use case for using one Session for proxied and direct requests, and the proxies needs a different pool size than the direct connections, I could add that.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1827/reactions"
} | https://api.github.com/repos/psf/requests/issues/1827/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1827.diff",
"html_url": "https://github.com/psf/requests/pull/1827",
"merged_at": "2014-01-08T18:50:00Z",
"patch_url": "https://github.com/psf/requests/pull/1827.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1827"
} | true | [
"Thanks for this!\n\nI like this solution, I think it's the correct approach. We can quite safely overload these kwargs, and I think doing so provides the nicer interface.\n\nOnce again, it's annoying that we can't easily test this, but I'm happy with this solution as-is. @sigmavirus24?\n",
"Yea, I looked at writ... |
https://api.github.com/repos/psf/requests/issues/1826 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1826/labels{/name} | https://api.github.com/repos/psf/requests/issues/1826/comments | https://api.github.com/repos/psf/requests/issues/1826/events | https://github.com/psf/requests/issues/1826 | 24,699,060 | MDU6SXNzdWUyNDY5OTA2MA== | 1,826 | SSLError exception leak | {
"avatar_url": "https://avatars.githubusercontent.com/u/303476?v=4",
"events_url": "https://api.github.com/users/zbb42/events{/privacy}",
"followers_url": "https://api.github.com/users/zbb42/followers",
"following_url": "https://api.github.com/users/zbb42/following{/other_user}",
"gists_url": "https://api.github.com/users/zbb42/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zbb42",
"id": 303476,
"login": "zbb42",
"node_id": "MDQ6VXNlcjMwMzQ3Ng==",
"organizations_url": "https://api.github.com/users/zbb42/orgs",
"received_events_url": "https://api.github.com/users/zbb42/received_events",
"repos_url": "https://api.github.com/users/zbb42/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zbb42/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zbb42/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zbb42",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-12-23T09:18:56Z | 2021-09-09T00:10:13Z | 2014-01-29T19:27:06Z | NONE | resolved | My program caught an ssl.SSLError which is not RequestException and I think it may be an uncaught exception? Requests version is 2.0.0.
Traceback:
```
......
r = requests.post(self._token_url, data=data, timeout=self._timeout)
File "/data/poi-op/env/python/lib/python2.7/site-packages/requests/api.py", line 88, in post
return request('post', url, data=data, **kwargs)
File "/data/poi-op/env/python/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/data/poi-op/env/python/lib/python2.7/site-packages/requests/sessions.py", line 357, in request
resp = self.send(prep, **send_kwargs)
File "/data/poi-op/env/python/lib/python2.7/site-packages/requests/sessions.py", line 460, in send
r = adapter.send(request, **kwargs)
File "/data/poi-op/env/python/lib/python2.7/site-packages/requests/adapters.py", line 367, in send
r.content
File "/data/poi-op/env/python/lib/python2.7/site-packages/requests/models.py", line 633, in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
File "/data/poi-op/env/python/lib/python2.7/site-packages/requests/models.py", line 572, in generate
decode_content=True):
File "/data/poi-op/env/python/lib/python2.7/site-packages/requests/packages/urllib3/response.py", line 225, in stream
data = self.read(amt=amt, decode_content=decode_content)
File "/data/poi-op/env/python/lib/python2.7/site-packages/requests/packages/urllib3/response.py", line 174, in read
data = self._fp.read(amt)
File "/usr/local/python27/lib/python2.7/httplib.py", line 543, in read
return self._read_chunked(amt)
File "/usr/local/python27/lib/python2.7/httplib.py", line 585, in _read_chunked
line = self.fp.readline(_MAXLINE + 1)
File "/usr/local/python27/lib/python2.7/socket.py", line 476, in readline
data = self._sock.recv(self._rbufsize)
File "/usr/local/python27/lib/python2.7/ssl.py", line 241, in recv
return self.read(buflen)
File "/usr/local/python27/lib/python2.7/ssl.py", line 160, in read
return self._sslobj.read(len)
SSLError: The read operation timed out
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1826/reactions"
} | https://api.github.com/repos/psf/requests/issues/1826/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nThis was originally spotted in #1787, and should be fixed in `master`. Try using the GitHub version of Requests to see if you can still hit it.\n",
"Closed due to inactivity.\n"
] |
https://api.github.com/repos/psf/requests/issues/1825 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1825/labels{/name} | https://api.github.com/repos/psf/requests/issues/1825/comments | https://api.github.com/repos/psf/requests/issues/1825/events | https://github.com/psf/requests/issues/1825 | 24,690,993 | MDU6SXNzdWUyNDY5MDk5Mw== | 1,825 | Session hook is ignored | {
"avatar_url": "https://avatars.githubusercontent.com/u/1894766?v=4",
"events_url": "https://api.github.com/users/akhomchenko/events{/privacy}",
"followers_url": "https://api.github.com/users/akhomchenko/followers",
"following_url": "https://api.github.com/users/akhomchenko/following{/other_user}",
"gists_url": "https://api.github.com/users/akhomchenko/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/akhomchenko",
"id": 1894766,
"login": "akhomchenko",
"node_id": "MDQ6VXNlcjE4OTQ3NjY=",
"organizations_url": "https://api.github.com/users/akhomchenko/orgs",
"received_events_url": "https://api.github.com/users/akhomchenko/received_events",
"repos_url": "https://api.github.com/users/akhomchenko/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/akhomchenko/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akhomchenko/subscriptions",
"type": "User",
"url": "https://api.github.com/users/akhomchenko",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-12-23T00:36:25Z | 2021-09-09T00:28:22Z | 2013-12-23T07:49:31Z | CONTRIBUTOR | resolved | Hello.
My English is not so good, sorry.
Problem example:
```
def fail_on_error(r, *args, **kwargs):
r.raise_for_status()
s = requests.session()
s.hooks.update(dict(response=fail_on_error))
r = s.get('http://httpbin.org/status/404')
```
This code doesn't raise an Exception. Is wasn't too obvious for me. Is it ok?
It is caused by `merge_setting` if this a problem, which overrides `Session` hooks with default `Request` hooks.
Thanks.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1825/reactions"
} | https://api.github.com/repos/psf/requests/issues/1825/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nI can't reproduce this on my machine. Can you tell me what version of Requests you're using? You can find this out by getting `requests.__version__` in a Python shell.\n",
"This was fixed in version 2.1.0 of requests. \n\nI, like @Lukasa, see this work properly when tried intera... |
https://api.github.com/repos/psf/requests/issues/1824 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1824/labels{/name} | https://api.github.com/repos/psf/requests/issues/1824/comments | https://api.github.com/repos/psf/requests/issues/1824/events | https://github.com/psf/requests/issues/1824 | 24,618,972 | MDU6SXNzdWUyNDYxODk3Mg== | 1,824 | Invalid ~/.netrc file does not raise any warnings or errors from requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/102495?v=4",
"events_url": "https://api.github.com/users/ssbarnea/events{/privacy}",
"followers_url": "https://api.github.com/users/ssbarnea/followers",
"following_url": "https://api.github.com/users/ssbarnea/following{/other_user}",
"gists_url": "https://api.github.com/users/ssbarnea/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ssbarnea",
"id": 102495,
"login": "ssbarnea",
"node_id": "MDQ6VXNlcjEwMjQ5NQ==",
"organizations_url": "https://api.github.com/users/ssbarnea/orgs",
"received_events_url": "https://api.github.com/users/ssbarnea/received_events",
"repos_url": "https://api.github.com/users/ssbarnea/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ssbarnea/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssbarnea/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ssbarnea",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-12-20T12:17:49Z | 2021-09-09T00:10:14Z | 2014-01-29T19:26:14Z | CONTRIBUTOR | resolved | I end-up with a case where requests behaves very strange, because it does not load the credentials from .netrc file and it's extremely hard to discover when is using credentials and where is taking them from.
The debug level output is identical in all 3 cases: no auth, auth from netrc or auth manually specified.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1824/reactions"
} | https://api.github.com/repos/psf/requests/issues/1824/timeline | null | completed | null | null | false | [
"I've explained to you, at least twice ([1st](https://github.com/kennethreitz/requests/issues/1297#issuecomment-16130288), [2nd](https://github.com/kennethreitz/requests/pull/1302#commitcomment-2984789)) that requests performs **no logging** whatsoever. With those reminders brought up, I'll reiterate once more that... |
https://api.github.com/repos/psf/requests/issues/1823 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1823/labels{/name} | https://api.github.com/repos/psf/requests/issues/1823/comments | https://api.github.com/repos/psf/requests/issues/1823/events | https://github.com/psf/requests/pull/1823 | 24,611,868 | MDExOlB1bGxSZXF1ZXN0MTEwMDQ4MjE= | 1,823 | Update docs to highlight the value of r.encoding. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-12-20T09:16:45Z | 2021-09-08T23:11:01Z | 2013-12-20T14:21:04Z | MEMBER | resolved | This should help address the concerns raised in #1795.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1823/reactions"
} | https://api.github.com/repos/psf/requests/issues/1823/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1823.diff",
"html_url": "https://github.com/psf/requests/pull/1823",
"merged_at": "2013-12-20T14:21:04Z",
"patch_url": "https://github.com/psf/requests/pull/1823.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1823"
} | true | [
"LGTM. :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/1822 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1822/labels{/name} | https://api.github.com/repos/psf/requests/issues/1822/comments | https://api.github.com/repos/psf/requests/issues/1822/events | https://github.com/psf/requests/issues/1822 | 24,602,748 | MDU6SXNzdWUyNDYwMjc0OA== | 1,822 | UnicodeEncodeError: 'latin-1' codec can't encode characters | {
"avatar_url": "https://avatars.githubusercontent.com/u/1450977?v=4",
"events_url": "https://api.github.com/users/xjsender/events{/privacy}",
"followers_url": "https://api.github.com/users/xjsender/followers",
"following_url": "https://api.github.com/users/xjsender/following{/other_user}",
"gists_url": "https://api.github.com/users/xjsender/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/xjsender",
"id": 1450977,
"login": "xjsender",
"node_id": "MDQ6VXNlcjE0NTA5Nzc=",
"organizations_url": "https://api.github.com/users/xjsender/orgs",
"received_events_url": "https://api.github.com/users/xjsender/received_events",
"repos_url": "https://api.github.com/users/xjsender/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/xjsender/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xjsender/subscriptions",
"type": "User",
"url": "https://api.github.com/users/xjsender",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-12-20T02:56:35Z | 2021-09-08T02:10:09Z | 2013-12-20T08:45:48Z | NONE | resolved | Requests is the latest version.
When I try to post the data which contains Chinese character, this exception is thrown.
```
Traceback (most recent call last):
File "X/threading.py", line 639, in _bootstrap_inner
File "X/threading.py", line 596, in run
File "C:\Users\Administrator\Dropbox\Sublime3056\Data\Packages\SublimeApex\salesforce\api.py", line 546, in execute_anonymous
headers=headers)
File "C:\Users\Administrator\Dropbox\Sublime3056\Data\Packages\SublimeApex\requests\api.py", line 88, in post
return request('post', url, data=data, **kwargs)
File "C:\Users\Administrator\Dropbox\Sublime3056\Data\Packages\SublimeApex\requests\api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "C:\Users\Administrator\Dropbox\Sublime3056\Data\Packages\SublimeApex\requests\sessions.py", line 338, in request
resp = self.send(prep, **send_kwargs)
File "C:\Users\Administrator\Dropbox\Sublime3056\Data\Packages\SublimeApex\requests\sessions.py", line 441, in send
r = adapter.send(request, **kwargs)
File "C:\Users\Administrator\Dropbox\Sublime3056\Data\Packages\SublimeApex\requests\adapters.py", line 292, in send
timeout=timeout
File "C:\Users\Administrator\Dropbox\Sublime3056\Data\Packages\SublimeApex\requests\packages\urllib3\connectionpool.py", line 428, in urlopen
body=body, headers=headers)
File "C:\Users\Administrator\Dropbox\Sublime3056\Data\Packages\SublimeApex\requests\packages\urllib3\connectionpool.py", line 280, in _make_request
conn.request(method, url, **httplib_request_kw)
File "X/http/client.py", line 1049, in request
File "X/http/client.py", line 1086, in _send_request
UnicodeEncodeError: 'latin-1' codec can't encode characters in position 1632-1633: ordinal not in range(256)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1822/reactions"
} | https://api.github.com/repos/psf/requests/issues/1822/timeline | null | completed | null | null | false | [
"> File \"X/http/client.py\"\n\nDid you write `X` because that's a path to a local file? If so, your directory structure may be confusing urllib3. If not, then you should probably raise this with on bugs.python.org since this is not something I think requests should be handling. This looks like it's rising from `ht... |
https://api.github.com/repos/psf/requests/issues/1821 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1821/labels{/name} | https://api.github.com/repos/psf/requests/issues/1821/comments | https://api.github.com/repos/psf/requests/issues/1821/events | https://github.com/psf/requests/issues/1821 | 24,583,485 | MDU6SXNzdWUyNDU4MzQ4NQ== | 1,821 | SSL verify failed though cert appears to be OK | {
"avatar_url": "https://avatars.githubusercontent.com/u/82214?v=4",
"events_url": "https://api.github.com/users/sradu/events{/privacy}",
"followers_url": "https://api.github.com/users/sradu/followers",
"following_url": "https://api.github.com/users/sradu/following{/other_user}",
"gists_url": "https://api.github.com/users/sradu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sradu",
"id": 82214,
"login": "sradu",
"node_id": "MDQ6VXNlcjgyMjE0",
"organizations_url": "https://api.github.com/users/sradu/orgs",
"received_events_url": "https://api.github.com/users/sradu/received_events",
"repos_url": "https://api.github.com/users/sradu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sradu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sradu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sradu",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-12-19T19:55:17Z | 2021-09-09T00:01:10Z | 2013-12-19T20:01:36Z | NONE | resolved | I'm trying to call a simple URL from a Debian stable server and I'm getting a certificate error:
> > > import requests
> > > r = requests.get('https://mobile.amber.io')
> > > [..]
> > > requests.exceptions.SSLError: [Errno 1] _ssl.c:504: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
The certificate should be valid. I've tried all SSL online checks, it works on all platforms.
On my mac though it might be unrelated I'm getting SSL hosts don't match (there are a couple of hosts on that server with different certs).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/82214?v=4",
"events_url": "https://api.github.com/users/sradu/events{/privacy}",
"followers_url": "https://api.github.com/users/sradu/followers",
"following_url": "https://api.github.com/users/sradu/following{/other_user}",
"gists_url": "https://api.github.com/users/sradu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sradu",
"id": 82214,
"login": "sradu",
"node_id": "MDQ6VXNlcjgyMjE0",
"organizations_url": "https://api.github.com/users/sradu/orgs",
"received_events_url": "https://api.github.com/users/sradu/received_events",
"repos_url": "https://api.github.com/users/sradu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sradu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sradu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sradu",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1821/reactions"
} | https://api.github.com/repos/psf/requests/issues/1821/timeline | null | completed | null | null | false | [
"My psychic powers tell me that you're using Python 2.7, which doesn't support SNI out of the box. See [this StackOverflow answer](http://stackoverflow.com/questions/18578439/using-requests-with-tls-doesnt-give-sni-support/18579484#18579484) for instructions on how to add SNI support.\n\nAm I right?\n",
"That fix... |
https://api.github.com/repos/psf/requests/issues/1820 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1820/labels{/name} | https://api.github.com/repos/psf/requests/issues/1820/comments | https://api.github.com/repos/psf/requests/issues/1820/events | https://github.com/psf/requests/issues/1820 | 24,582,960 | MDU6SXNzdWUyNDU4Mjk2MA== | 1,820 | How to set the post parameters order? | {
"avatar_url": "https://avatars.githubusercontent.com/u/127591?v=4",
"events_url": "https://api.github.com/users/ogrishman/events{/privacy}",
"followers_url": "https://api.github.com/users/ogrishman/followers",
"following_url": "https://api.github.com/users/ogrishman/following{/other_user}",
"gists_url": "https://api.github.com/users/ogrishman/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ogrishman",
"id": 127591,
"login": "ogrishman",
"node_id": "MDQ6VXNlcjEyNzU5MQ==",
"organizations_url": "https://api.github.com/users/ogrishman/orgs",
"received_events_url": "https://api.github.com/users/ogrishman/received_events",
"repos_url": "https://api.github.com/users/ogrishman/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ogrishman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ogrishman/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ogrishman",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-12-19T19:47:01Z | 2021-09-09T00:28:25Z | 2013-12-19T19:55:42Z | NONE | resolved | This is part of my code:
```
files = {'FileData': ("01.avi", open("H:\\Dropbox\\temp\\test\\videos\\01.avi", 'rb'), "application/octet-stream")}
url = "http://upload.test.com/api/upload_form_data"
headers = {
"User-Agent": "Shockwave Flash",
"Accept": "text/*",
"Connection": "Keep-Alive",
"Pragma": "no-cache",
"Host": "upload.test.com"
}
data = {
"Filename": upload_me_name,
"upload_token": upload_token,
"client": "flash",
"Upload": "Submit Query"
}
r = s.post(url, proxies = proxies, headers = headers, files = files, data = data)
```
I use fiddler to trace the post process and I got the following result.
```
POST http://upload.test.com/api/upload_form_data HTTP/1.1
Accept-Encoding: gzip, deflate, compress
Accept: text/*
Content-Type: multipart/form-data; boundary=35b35bbdadc54949a1e280d19fa85850
Connection: Keep-Alive
Pragma: no-cache
Host: upload.test.com
Cookie: yktk=1%7C1387481091%7C15%7CaWQ6NjMxMDQwMjksbm465ZCR5L2g6IKa5a2Q5LiK5ouN5LiA5o6MLHZpcDpmYWxzZSx5dGlkOjAsdGlkOjA%3D%7Ce2af70d5dc486fb7daf96eb31011bf65%7Cda22 5886e18eff748b67f650accb1b75810e42d1%7C1; u=%E5%90%91%E4%BD%A0%E8%82%9A%E5%AD%90%E4%B8%8A%E6%8B%8D%E4%B8%80%E6%8E%8C; ykss=fd47b352415e60cf5699819e; _l_lgi=63104029
User-Agent: Shockwave Flash
Content-Length: 162469
--35b35bbdadc54949a1e280d19fa85850
Content-Disposition: form-data; name="upload_token"
MTg0ODQ4NjgwXzAxMDA2NDNBQTI1MkFGNTQ1QUJBRUMwM0MyRTQxRERFNjA0NUUyLTg4QUEtQ0Q5Ny1BNkRBLUQ2MkIyOTA3Rjk4N18xXzdmYWI3ZGU0MDkzYzdhMTA0OTkyMmM1NjczNThkMWYw
--35b35bbdadc54949a1e280d19fa85850
Content-Disposition: form-data; name="client"
flash
--35b35bbdadc54949a1e280d19fa85850
Content-Disposition: form-data; name="Upload"
Submit Query
--35b35bbdadc54949a1e280d19fa85850
Content-Disposition: form-data; name="Filename"
01.avi
--35b35bbdadc54949a1e280d19fa85850
Content-Disposition: form-data; name="FileData"; filename="01.avi"
Content-Type: application/octet-stream
<File data .....................>
```
However, that's not what exactly I want. I need the parameters in different order like this:
```
POST http://upload.test.com/api/upload_form_data HTTP/1.1
Accept-Encoding: gzip, deflate, compress
Accept: text/*
Content-Type: multipart/form-data; boundary=35b35bbdadc54949a1e280d19fa85850
Connection: Keep-Alive
Pragma: no-cache
Host: upload.test.com
Cookie: yktk=1%7C1387481091%7C15%7CaWQ6NjMxMDQwMjksbm465ZCR5L2g6IKa5a2Q5LiK5ouN5LiA5o6MLHZpcDpmYWxzZSx5dGlkOjAsdGlkOjA%3D%7Ce2af70d5dc486fb7daf96eb31011bf65%7Cda22 5886e18eff748b67f650accb1b75810e42d1%7C1; u=%E5%90%91%E4%BD%A0%E8%82%9A%E5%AD%90%E4%B8%8A%E6%8B%8D%E4%B8%80%E6%8E%8C; ykss=fd47b352415e60cf5699819e; _l_lgi=63104029
User-Agent: Shockwave Flash
Content-Length: 162469
--35b35bbdadc54949a1e280d19fa85850
Content-Disposition: form-data; name="upload_token"
MTg0ODQ4NjgwXzAxMDA2NDNBQTI1MkFGNTQ1QUJBRUMwM0MyRTQxRERFNjA0NUUyLTg4QUEtQ0Q5Ny1BNkRBLUQ2MkIyOTA3Rjk4N18xXzdmYWI3ZGU0MDkzYzdhMTA0OTkyMmM1NjczNThkMWYw
--35b35bbdadc54949a1e280d19fa85850
Content-Disposition: form-data; name="client"
flash
--35b35bbdadc54949a1e280d19fa85850
Content-Disposition: form-data; name="Filename"
01.avi
--35b35bbdadc54949a1e280d19fa85850
Content-Disposition: form-data; name="FileData"; filename="01.avi"
Content-Type: application/octet-stream
<File data .....................>
--35b35bbdadc54949a1e280d19fa85850
Content-Disposition: form-data; name="Upload"
Submit Query
```
How to do this in requests? Thank you!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1820/reactions"
} | https://api.github.com/repos/psf/requests/issues/1820/timeline | null | completed | null | null | false | [
"Firstly, the correct place to ask this question is not here: this is for tracking bugs only. You should ask your question at StackOverflow, and use the \"python-requests\" tag.\n\nSecondly, why does the order matter? It shouldn't affect the remote web site at all.\n\nFinally, the correct code is this:\n\n``` pytho... |
https://api.github.com/repos/psf/requests/issues/1819 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1819/labels{/name} | https://api.github.com/repos/psf/requests/issues/1819/comments | https://api.github.com/repos/psf/requests/issues/1819/events | https://github.com/psf/requests/issues/1819 | 24,577,571 | MDU6SXNzdWUyNDU3NzU3MQ== | 1,819 | How to disable (not send it at all) a request header? | {
"avatar_url": "https://avatars.githubusercontent.com/u/127591?v=4",
"events_url": "https://api.github.com/users/ogrishman/events{/privacy}",
"followers_url": "https://api.github.com/users/ogrishman/followers",
"following_url": "https://api.github.com/users/ogrishman/following{/other_user}",
"gists_url": "https://api.github.com/users/ogrishman/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ogrishman",
"id": 127591,
"login": "ogrishman",
"node_id": "MDQ6VXNlcjEyNzU5MQ==",
"organizations_url": "https://api.github.com/users/ogrishman/orgs",
"received_events_url": "https://api.github.com/users/ogrishman/received_events",
"repos_url": "https://api.github.com/users/ogrishman/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ogrishman/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ogrishman/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ogrishman",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-12-19T18:54:24Z | 2021-09-09T00:28:24Z | 2013-12-19T18:58:38Z | NONE | resolved | I'm using requests writing a program and it added the following header to my custom header:
```
Accept-Encoding: gzip, deflate, compress
```
My custom header is:
```
headers = {
"User-Agent": "Shockwave Flash",
"Accept": "text/*",
"Connection": "Keep-Alive",
"Pragma": "no-cache",
"Host": "upload.youku.com"
}
```
Is it possible to disable the added header at all?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1819/reactions"
} | https://api.github.com/repos/psf/requests/issues/1819/timeline | null | completed | null | null | false | [
"Yup. Like this:\n\n``` python\nr = requests.get(url, headers={'Accept-Encoding': None})\n```\n",
"@ogrishman, @Lukasa explained on #1820 that this is a bug tracker and not a question and answer forum. Further questions you ask here will be closed without answer.\n"
] |
https://api.github.com/repos/psf/requests/issues/1818 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1818/labels{/name} | https://api.github.com/repos/psf/requests/issues/1818/comments | https://api.github.com/repos/psf/requests/issues/1818/events | https://github.com/psf/requests/issues/1818 | 24,571,748 | MDU6SXNzdWUyNDU3MTc0OA== | 1,818 | Removal of TLSv1 from the webserver gives socket.error: [Errno 54] Connection reset by peer error to python requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/102495?v=4",
"events_url": "https://api.github.com/users/ssbarnea/events{/privacy}",
"followers_url": "https://api.github.com/users/ssbarnea/followers",
"following_url": "https://api.github.com/users/ssbarnea/following{/other_user}",
"gists_url": "https://api.github.com/users/ssbarnea/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ssbarnea",
"id": 102495,
"login": "ssbarnea",
"node_id": "MDQ6VXNlcjEwMjQ5NQ==",
"organizations_url": "https://api.github.com/users/ssbarnea/orgs",
"received_events_url": "https://api.github.com/users/ssbarnea/received_events",
"repos_url": "https://api.github.com/users/ssbarnea/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ssbarnea/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssbarnea/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ssbarnea",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-12-19T17:40:43Z | 2021-09-09T00:28:24Z | 2013-12-20T02:40:49Z | CONTRIBUTOR | resolved | I discovered that if I force nginx to use only TLSv1.2 and TLSv1.1 protocols, it will prevent the requests library from working.
Other browsers are able to deal with this, including CURL but request doesn't, at least when is used on OS X with Python 2.7
Reproduce, reconfigure webserver to use only recent SSL protocols:
ssl_protocols TLSv1.2 TLSv1.1;
```
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='example.com', port=443): Max retries exceeded with url: /some/url (Caused by <class 'socket.error'>: [Errno 54] Connection reset by peer)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1818/reactions"
} | https://api.github.com/repos/psf/requests/issues/1818/timeline | null | completed | null | null | false | [
"This sounds like a bug in urllib3. @shazow opinions?\n",
"Actually following the conversation on #171 this is not a bug in requests but in Python as @Lukasa explained.\n",
"My favourite.\n"
] |
https://api.github.com/repos/psf/requests/issues/1817 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1817/labels{/name} | https://api.github.com/repos/psf/requests/issues/1817/comments | https://api.github.com/repos/psf/requests/issues/1817/events | https://github.com/psf/requests/issues/1817 | 24,556,852 | MDU6SXNzdWUyNDU1Njg1Mg== | 1,817 | Losing cookies in redirects after HTTPS POST | {
"avatar_url": "https://avatars.githubusercontent.com/u/5185185?v=4",
"events_url": "https://api.github.com/users/rbock/events{/privacy}",
"followers_url": "https://api.github.com/users/rbock/followers",
"following_url": "https://api.github.com/users/rbock/following{/other_user}",
"gists_url": "https://api.github.com/users/rbock/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/rbock",
"id": 5185185,
"login": "rbock",
"node_id": "MDQ6VXNlcjUxODUxODU=",
"organizations_url": "https://api.github.com/users/rbock/orgs",
"received_events_url": "https://api.github.com/users/rbock/received_events",
"repos_url": "https://api.github.com/users/rbock/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/rbock/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/rbock/subscriptions",
"type": "User",
"url": "https://api.github.com/users/rbock",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-12-19T13:45:42Z | 2021-09-09T00:28:25Z | 2013-12-19T13:53:44Z | NONE | resolved | Hi,
in a session, I am sending HTTPS GET request, followed by a HTTPS POST request which results in a series of 302-redirects. I monitor traffic via mitmproxy, but the results are the same whether I use the proxy or not.
With allow_redirect=True, most of the cookies get lost between the first and second redirect (4 out of 6 got lost in my case).
With allow_redirect=False for the POST, I initiate the GET with allow_redirect=True and everything works just fine.
Here's the boiled-down code:
```
self.session = requests.Session()
self.session.get(get_url, headers=self.headers, proxies=self.proxies, verify=False)
self.session.post(post_url, data=payload, headers=self.headers, proxies=self.proxies, verify=False)
```
I cannot give you all details about the URL or the parameters since it is a login procedure, but I can certainly answer questions or experiment if you tell me what to do.
Edit: This happens in 2.1.0. But it works fine in 2.0.1.
Regards,
Roland
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1817/reactions"
} | https://api.github.com/repos/psf/requests/issues/1817/timeline | null | completed | null | null | false | [
"Thanks for raising this issue! In future, however, please take a quick look through both the open and the closed issues before opening yours. This issue has been reported twice already (in #1805 and #1809) and is fixed in the current master branch by #1808. You can either wait until the next release for the fix, o... |
https://api.github.com/repos/psf/requests/issues/1816 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1816/labels{/name} | https://api.github.com/repos/psf/requests/issues/1816/comments | https://api.github.com/repos/psf/requests/issues/1816/events | https://github.com/psf/requests/pull/1816 | 24,544,211 | MDExOlB1bGxSZXF1ZXN0MTA5NjY3OTg= | 1,816 | Re-raise DecodeError | {
"avatar_url": "https://avatars.githubusercontent.com/u/3482660?v=4",
"events_url": "https://api.github.com/users/daftshady/events{/privacy}",
"followers_url": "https://api.github.com/users/daftshady/followers",
"following_url": "https://api.github.com/users/daftshady/following{/other_user}",
"gists_url": "https://api.github.com/users/daftshady/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/daftshady",
"id": 3482660,
"login": "daftshady",
"node_id": "MDQ6VXNlcjM0ODI2NjA=",
"organizations_url": "https://api.github.com/users/daftshady/orgs",
"received_events_url": "https://api.github.com/users/daftshady/received_events",
"repos_url": "https://api.github.com/users/daftshady/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/daftshady/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/daftshady/subscriptions",
"type": "User",
"url": "https://api.github.com/users/daftshady",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 1 | 2013-12-19T09:07:16Z | 2021-09-08T23:06:02Z | 2013-12-19T20:38:34Z | CONTRIBUTOR | resolved | Re-raise DecodeError in urllib3 for https://github.com/kennethreitz/requests/issues/1815.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1816/reactions"
} | https://api.github.com/repos/psf/requests/issues/1816/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1816.diff",
"html_url": "https://github.com/psf/requests/pull/1816",
"merged_at": "2013-12-19T20:38:34Z",
"patch_url": "https://github.com/psf/requests/pull/1816.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1816"
} | true | [
"LGTM! Thanks so much @daftshady! :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/1815 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1815/labels{/name} | https://api.github.com/repos/psf/requests/issues/1815/comments | https://api.github.com/repos/psf/requests/issues/1815/events | https://github.com/psf/requests/issues/1815 | 24,536,184 | MDU6SXNzdWUyNDUzNjE4NA== | 1,815 | urllib3.exceptions.DecodeError being raised | {
"avatar_url": "https://avatars.githubusercontent.com/u/2161601?v=4",
"events_url": "https://api.github.com/users/adamsc/events{/privacy}",
"followers_url": "https://api.github.com/users/adamsc/followers",
"following_url": "https://api.github.com/users/adamsc/following{/other_user}",
"gists_url": "https://api.github.com/users/adamsc/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/adamsc",
"id": 2161601,
"login": "adamsc",
"node_id": "MDQ6VXNlcjIxNjE2MDE=",
"organizations_url": "https://api.github.com/users/adamsc/orgs",
"received_events_url": "https://api.github.com/users/adamsc/received_events",
"repos_url": "https://api.github.com/users/adamsc/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/adamsc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adamsc/subscriptions",
"type": "User",
"url": "https://api.github.com/users/adamsc",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-12-19T04:18:21Z | 2021-09-09T00:28:23Z | 2013-12-20T09:01:37Z | NONE | resolved | I have been getting a `requests.packages.urllib3.exceptions.DecodeError` exception raised. From my understanding of the documentation, shouldn't this be translated to a Requests exception which inherits from `requests.exceptions.RequestException`?
This occurred using Requests 2.1.0 when making a GET request through a misconfigured HTTP proxy.
Here is the stack trace:
```
Traceback (most recent call last):
File "proxy-manager.py", line 94, in <module>
good, comment = is_good(proxy, base_headers, base_latency * 10)
File "proxy-manager.py", line 42, in is_good
headers = get_header_data(proxy)
File "proxy-manager.py", line 14, in get_header_data
r = requests.get('http://proxyjudge.us/azenv.php', proxies=proxies, timeout=timeout)
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 382, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 485, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 388, in send
r.content
File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 676, in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
File "/usr/local/lib/python2.7/dist-packages/requests/models.py", line 615, in generate
decode_content=True):
File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/response.py", line 236, in stream
data = self.read(amt=amt, decode_content=decode_content)
File "/usr/local/lib/python2.7/dist-packages/requests/packages/urllib3/response.py", line 204, in read
e)
requests.packages.urllib3.exceptions.DecodeError: ('Received response with content-encoding: gzip, but failed to decode it.', error('Error -3 while decompressing: incorrect header check',))
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1815/reactions"
} | https://api.github.com/repos/psf/requests/issues/1815/timeline | null | completed | null | null | false | [
"Thanks for raising this! Yeah, it probably should.\n",
"Fixed by #1816.\n"
] |
https://api.github.com/repos/psf/requests/issues/1814 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1814/labels{/name} | https://api.github.com/repos/psf/requests/issues/1814/comments | https://api.github.com/repos/psf/requests/issues/1814/events | https://github.com/psf/requests/pull/1814 | 24,535,176 | MDExOlB1bGxSZXF1ZXN0MTA5NjE3ODM= | 1,814 | make requests compatible with SAE | {
"avatar_url": "https://avatars.githubusercontent.com/u/170430?v=4",
"events_url": "https://api.github.com/users/tg123/events{/privacy}",
"followers_url": "https://api.github.com/users/tg123/followers",
"following_url": "https://api.github.com/users/tg123/following{/other_user}",
"gists_url": "https://api.github.com/users/tg123/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tg123",
"id": 170430,
"login": "tg123",
"node_id": "MDQ6VXNlcjE3MDQzMA==",
"organizations_url": "https://api.github.com/users/tg123/orgs",
"received_events_url": "https://api.github.com/users/tg123/received_events",
"repos_url": "https://api.github.com/users/tg123/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tg123/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tg123/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tg123",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-12-19T03:36:49Z | 2021-09-08T22:01:07Z | 2013-12-19T03:40:45Z | NONE | resolved | make requests compatible with SAE
Sina App Engine conn has a None valued sock
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1814/reactions"
} | https://api.github.com/repos/psf/requests/issues/1814/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1814.diff",
"html_url": "https://github.com/psf/requests/pull/1814",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1814.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1814"
} | true | [
"Hey @tg123 this PR belongs on [shazow/urllib3](/shazow/urllib3) as was noted in the [README in the packages directory](https://github.com/tg123/requests/tree/fa34ab816aa03a009ceb86db7e55f16ca6687ba4/requests/packages). Please be more careful next time.\n",
"sorry about that\n",
"No worries! Thanks for sending ... |
https://api.github.com/repos/psf/requests/issues/1813 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1813/labels{/name} | https://api.github.com/repos/psf/requests/issues/1813/comments | https://api.github.com/repos/psf/requests/issues/1813/events | https://github.com/psf/requests/issues/1813 | 24,522,453 | MDU6SXNzdWUyNDUyMjQ1Mw== | 1,813 | Allow Content-Disposition header to be overridden per-field | {
"avatar_url": "https://avatars.githubusercontent.com/u/97720?v=4",
"events_url": "https://api.github.com/users/orokusaki/events{/privacy}",
"followers_url": "https://api.github.com/users/orokusaki/followers",
"following_url": "https://api.github.com/users/orokusaki/following{/other_user}",
"gists_url": "https://api.github.com/users/orokusaki/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/orokusaki",
"id": 97720,
"login": "orokusaki",
"node_id": "MDQ6VXNlcjk3NzIw",
"organizations_url": "https://api.github.com/users/orokusaki/orgs",
"received_events_url": "https://api.github.com/users/orokusaki/received_events",
"repos_url": "https://api.github.com/users/orokusaki/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/orokusaki/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/orokusaki/subscriptions",
"type": "User",
"url": "https://api.github.com/users/orokusaki",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2013-12-18T22:12:35Z | 2021-09-09T00:28:26Z | 2013-12-18T22:15:37Z | NONE | resolved | `make_multipart` overrides the `Content-Disposition` header (see https://github.com/kennethreitz/requests/blob/54ad646067a3e023fd4dcf40c0937ec46069871f/requests/packages/urllib3/fields.py#L165), even when explicitly set (using the new per-field headers feature).
Is there any reason why the code couldn't be updated to allow this header to be explicitly set when providing files as 4-tuples containing the filename, content, content type and content disposition? The reason for wanting this feature is to allow working with REST APIs that do it all wrong (can't name names, sorry).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1813/reactions"
} | https://api.github.com/repos/psf/requests/issues/1813/timeline | null | completed | null | null | false | [
"@orokusaki In principle there's no reason. I suggest raising the issue on urllib3 and seeing what @shazow thinks. =)\n",
"+1 on moving this discussion to urllib3, but a cursory comment: The tuple format is generally deprecated in urllib3 (only remains there as a shortcut, for now), constructing RequestField obje... |
https://api.github.com/repos/psf/requests/issues/1812 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1812/labels{/name} | https://api.github.com/repos/psf/requests/issues/1812/comments | https://api.github.com/repos/psf/requests/issues/1812/events | https://github.com/psf/requests/pull/1812 | 24,496,949 | MDExOlB1bGxSZXF1ZXN0MTA5Mzg3NjY= | 1,812 | Removed the bundled charade and urllib3. | {
"avatar_url": "https://avatars.githubusercontent.com/u/151924?v=4",
"events_url": "https://api.github.com/users/sontek/events{/privacy}",
"followers_url": "https://api.github.com/users/sontek/followers",
"following_url": "https://api.github.com/users/sontek/following{/other_user}",
"gists_url": "https://api.github.com/users/sontek/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sontek",
"id": 151924,
"login": "sontek",
"node_id": "MDQ6VXNlcjE1MTkyNA==",
"organizations_url": "https://api.github.com/users/sontek/orgs",
"received_events_url": "https://api.github.com/users/sontek/received_events",
"repos_url": "https://api.github.com/users/sontek/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sontek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sontek/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sontek",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 20 | 2013-12-18T15:34:21Z | 2014-09-27T19:52:56Z | 2013-12-18T15:55:40Z | NONE | null | This removes the bundled versions of charade and urllib3, allowing
users to upgrade those packages separately. This also provides a
nice way for Linux distro packages to be able to package requests
and have it depend on their packaged version of those libraries.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1812/reactions"
} | https://api.github.com/repos/psf/requests/issues/1812/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1812.diff",
"html_url": "https://github.com/psf/requests/pull/1812",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1812.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1812"
} | true | [
":+1: \n",
"These projects are vendored for a reasons that I discuss publicly on a regular basis.\n\nAlso, my code decisions are not be influenced by the random decisions of Linux distros :)\n",
"Although, the work of said distros is much appreciated :)\n",
"@kennethreitz Any write-ups/blogs you can point to ... |
https://api.github.com/repos/psf/requests/issues/1811 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1811/labels{/name} | https://api.github.com/repos/psf/requests/issues/1811/comments | https://api.github.com/repos/psf/requests/issues/1811/events | https://github.com/psf/requests/issues/1811 | 24,495,646 | MDU6SXNzdWUyNDQ5NTY0Ng== | 1,811 | Stop bundling urllib3, just add it to install_requires | {
"avatar_url": "https://avatars.githubusercontent.com/u/151924?v=4",
"events_url": "https://api.github.com/users/sontek/events{/privacy}",
"followers_url": "https://api.github.com/users/sontek/followers",
"following_url": "https://api.github.com/users/sontek/following{/other_user}",
"gists_url": "https://api.github.com/users/sontek/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sontek",
"id": 151924,
"login": "sontek",
"node_id": "MDQ6VXNlcjE1MTkyNA==",
"organizations_url": "https://api.github.com/users/sontek/orgs",
"received_events_url": "https://api.github.com/users/sontek/received_events",
"repos_url": "https://api.github.com/users/sontek/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sontek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sontek/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sontek",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2013-12-18T15:14:38Z | 2021-09-08T23:00:55Z | 2013-12-18T16:07:39Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1811/reactions"
} | https://api.github.com/repos/psf/requests/issues/1811/timeline | null | completed | null | null | false | [
"We have discussed this issue with users several times in the past. A search of the issues that are closed would show that. Our opinion has not changed, nor has our reasoning. By vendoring urllib3 we have a very specific version that we have tested against that may include unreleased bug fixes and does not put pres... | |
https://api.github.com/repos/psf/requests/issues/1810 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1810/labels{/name} | https://api.github.com/repos/psf/requests/issues/1810/comments | https://api.github.com/repos/psf/requests/issues/1810/events | https://github.com/psf/requests/pull/1810 | 24,493,853 | MDExOlB1bGxSZXF1ZXN0MTA5MzY5MTU= | 1,810 | Swap charade for chardet | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 3 | 2013-12-18T14:47:36Z | 2021-09-08T23:08:31Z | 2013-12-18T15:52:55Z | CONTRIBUTOR | resolved | Fixes #1800
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1810/reactions"
} | https://api.github.com/repos/psf/requests/issues/1810/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1810.diff",
"html_url": "https://github.com/psf/requests/pull/1810",
"merged_at": "2013-12-18T15:52:55Z",
"patch_url": "https://github.com/psf/requests/pull/1810.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1810"
} | true | [
"This shouldn't affect any of the tests @kennethreitz and should be merged before the next release.\n",
"What's the difference between the projects?\n\nAlso, NOTICES needs to be updated.\n",
"oh I see your explanation in the history now. :)\n"
] |
https://api.github.com/repos/psf/requests/issues/1809 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1809/labels{/name} | https://api.github.com/repos/psf/requests/issues/1809/comments | https://api.github.com/repos/psf/requests/issues/1809/events | https://github.com/psf/requests/issues/1809 | 24,475,554 | MDU6SXNzdWUyNDQ3NTU1NA== | 1,809 | Redirection fails if redirect url contains semicolon | {
"avatar_url": "https://avatars.githubusercontent.com/u/71184?v=4",
"events_url": "https://api.github.com/users/adriaant/events{/privacy}",
"followers_url": "https://api.github.com/users/adriaant/followers",
"following_url": "https://api.github.com/users/adriaant/following{/other_user}",
"gists_url": "https://api.github.com/users/adriaant/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/adriaant",
"id": 71184,
"login": "adriaant",
"node_id": "MDQ6VXNlcjcxMTg0",
"organizations_url": "https://api.github.com/users/adriaant/orgs",
"received_events_url": "https://api.github.com/users/adriaant/received_events",
"repos_url": "https://api.github.com/users/adriaant/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/adriaant/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/adriaant/subscriptions",
"type": "User",
"url": "https://api.github.com/users/adriaant",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-12-18T08:24:44Z | 2021-09-09T00:28:26Z | 2013-12-18T09:01:29Z | NONE | resolved | URLs can contain a semicolon as per http://www.ietf.org/rfc/rfc1738.txt
The website http://www.vd.nl/ redirects as follows (using curl):
```
curl -IL 'http://www.vd.nl/'
HTTP/1.1 302 Moved Temporarily
Server: Unknown
Vary: Accept-Encoding
Content-Type: text/plain
Date: Wed, 18 Dec 2013 08:21:31 GMT
Location: http://www.vd.nl/index.jsf?noCookieCheck=true
Transfer-Encoding: chunked
Connection: Keep-Alive
Set-Cookie: JSESSIONID=509416AD306056112AD4457880BC7FBD.mirvd110; Domain=www.vd.nl; Path=/;HttpOnly
Set-Cookie: X-Mapping-egldpcee=00BA6EB61567615AFB15FACB74D67EE1; path=/
HTTP/1.1 302 Moved Temporarily
Server: Unknown
Vary: Accept-Encoding
Content-Type: text/plain
Date: Wed, 18 Dec 2013 08:21:31 GMT
Location: http://www.vd.nl/index.jsf;jsessionid=7B0827ACDBDA874DD62277173C1709B3.mirvd112
Transfer-Encoding: chunked
Connection: Keep-Alive
Set-Cookie: JSESSIONID=7B0827ACDBDA874DD62277173C1709B3.mirvd112; Domain=www.vd.nl; Path=/;HttpOnly
Set-Cookie: X-Mapping-egldpcee=309EF29094DD6794869AC642FE42E744; path=/
HTTP/1.1 200 OK
Server: Unknown
Vary: Accept-Encoding
Content-Type: text/html;charset=UTF-8
Date: Wed, 18 Dec 2013 08:21:31 GMT
Transfer-Encoding: chunked
Connection: Keep-Alive
Set-Cookie: X-Mapping-egldpcee=75FACE26A300BA579BA2B1C5BE336FA3; path=/
X-Powered-By: JSF/1.2
```
Requests 2.1.0, however, strips the url right at the semicolon, making it go into a redirect loop:
```
1: redirect to http://www.vd.nl/index.jsf?noCookieCheck=true [302]
2: redirect to http://www.vd.nl/index.jsf [302]
3: redirect to http://www.vd.nl/ [301]
4: redirect to http://www.vd.nl/index.jsf?noCookieCheck=true [302]
5: redirect to http://www.vd.nl/index.jsf [302]
6: redirect to http://www.vd.nl/ [301]
7: redirect to http://www.vd.nl/index.jsf?noCookieCheck=true [302]
8: redirect to http://www.vd.nl/index.jsf [302]
etc.
```
using sample code:
```
import requests
url = 'http://www.vd.nl/'
headers = {
'Accept-Encoding': 'identity, deflate, compress, gzip',
'Accept': '*/*',
'Connection': 'close',
'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_5) AppleWebKit/536.30.1 (KHTML, like Gecko) Version/6.0.5 Safari/536.30.1'
}
s = requests.session()
s.keep_alive = False
response = s.get(url, verify=False, timeout=30, headers=headers, stream=True, allow_redirects=False)
responsecode = response.status_code
if responsecode >= 300 and responsecode < 400 and response.headers.get('location'):
redirect_counter = 1
print " %d: redirect to %s [%d]" % (redirect_counter, response.headers.get('location'), responsecode)
for redirect in s.resolve_redirects(response, response.request):
redirect_counter += 1
responsecode = redirect.status_code
new_location = redirect.headers.get('location')
if responsecode >= 300 and responsecode < 400 and new_location:
print " %d: redirect to %s [%d]" % (redirect_counter, new_location, responsecode)
else:
break
response.close()
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1809/reactions"
} | https://api.github.com/repos/psf/requests/issues/1809/timeline | null | completed | null | null | false | [
"Thanks for raising this issue! However, I disagree with your assessment: I think this is actually the same issue as #1805, and will be fixed by #1808. Checking out the code in #1808 confirms that diagnosis.\n\nIn the future, there are a couple of ways you could have spotted this. Firstly, it's worth noting that th... |
https://api.github.com/repos/psf/requests/issues/1808 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1808/labels{/name} | https://api.github.com/repos/psf/requests/issues/1808/comments | https://api.github.com/repos/psf/requests/issues/1808/events | https://github.com/psf/requests/pull/1808 | 24,469,924 | MDExOlB1bGxSZXF1ZXN0MTA5MjMzMDY= | 1,808 | Fixes #1805 | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 2 | 2013-12-18T04:55:25Z | 2021-09-08T23:07:31Z | 2013-12-18T15:56:30Z | CONTRIBUTOR | resolved | Sure cookies are persisted to the session, but those new cookies are not added
to the next prepared request. We need to update that new request's CookieJar
with the new cookies.
/cc @teleyinex
This allows me to fetch the URL you specified quite quickly.
TODO:
- [ ] Find a way to reliably test this. Perhaps introduce [Betamax](https://github.com/sigmavirus24/betamax) to make this test reproducible.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1808/reactions"
} | https://api.github.com/repos/psf/requests/issues/1808/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1808.diff",
"html_url": "https://github.com/psf/requests/pull/1808",
"merged_at": "2013-12-18T15:56:30Z",
"patch_url": "https://github.com/psf/requests/pull/1808.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1808"
} | true | [
"Looks reasonable to me. Testing is going to be a pain though.\n",
"Looks good too! Thanks for fixing it so quickly @sigmavirus24 \n"
] |
https://api.github.com/repos/psf/requests/issues/1807 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1807/labels{/name} | https://api.github.com/repos/psf/requests/issues/1807/comments | https://api.github.com/repos/psf/requests/issues/1807/events | https://github.com/psf/requests/pull/1807 | 24,466,796 | MDExOlB1bGxSZXF1ZXN0MTA5MjE4MDU= | 1,807 | cookiejar.iteritems() is broken after 2.1.0 update | {
"avatar_url": "https://avatars.githubusercontent.com/u/314085?v=4",
"events_url": "https://api.github.com/users/code-of-kpp/events{/privacy}",
"followers_url": "https://api.github.com/users/code-of-kpp/followers",
"following_url": "https://api.github.com/users/code-of-kpp/following{/other_user}",
"gists_url": "https://api.github.com/users/code-of-kpp/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/code-of-kpp",
"id": 314085,
"login": "code-of-kpp",
"node_id": "MDQ6VXNlcjMxNDA4NQ==",
"organizations_url": "https://api.github.com/users/code-of-kpp/orgs",
"received_events_url": "https://api.github.com/users/code-of-kpp/received_events",
"repos_url": "https://api.github.com/users/code-of-kpp/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/code-of-kpp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/code-of-kpp/subscriptions",
"type": "User",
"url": "https://api.github.com/users/code-of-kpp",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-12-18T03:03:21Z | 2021-09-08T23:06:15Z | 2013-12-19T20:38:52Z | NONE | resolved | ```
Python 2.7.5+ (default, Sep 19 2013, 13:48:49)
[GCC 4.8.1] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> requests.__version__
'2.1.0'
>>> r = requests.get('http://google.com')
>>> r.cookies
<<class 'requests.cookies.RequestsCookieJar'>[Cookie(version=0, name='NID', value='67=WbyIM1gU91bGQ5Y3SjPHQ8_fqtStHiMWGJQ5n2Bt_PwytcmPii7fV7AELJ95cqfSmhAHSJCtFm0bBDZJJoTzQHGGQvk6PT8h78PrwWi96r0K7R9N0KsNCZkkrgJW94dV', port=None, port_specified=False, domain='.google.ru', domain_specified=True, domain_initial_dot=True, path='/', path_specified=True, secure=False, expires=1403146705, discard=False, comment=None, comment_url=None, rest={'HttpOnly': None}, rfc2109=False), Cookie(version=0, name='PREF', value='ID=7c3265d2706e8bea:FF=0:NW=1:TM=1387335505:LM=1387335505:S=LsdqbwGuUdHENT0m', port=None, port_specified=False, domain='.google.ru', domain_specified=True, domain_initial_dot=True, path='/', path_specified=True, secure=False, expires=1450407505, discard=False, comment=None, comment_url=None, rest={}, rfc2109=False)]>
>>> dict(r.cookies)
{'PREF': 'ID=7c3265d2706e8bea:FF=0:NW=1:TM=1387335505:LM=1387335505:S=LsdqbwGuUdHENT0m', 'NID': '67=WbyIM1gU91bGQ5Y3SjPHQ8_fqtStHiMWGJQ5n2Bt_PwytcmPii7fV7AELJ95cqfSmhAHSJCtFm0bBDZJJoTzQHGGQvk6PT8h78PrwWi96r0K7R9N0KsNCZkkrgJW94dV'}
>>> r.cookies.items()
[('NID', '67=WbyIM1gU91bGQ5Y3SjPHQ8_fqtStHiMWGJQ5n2Bt_PwytcmPii7fV7AELJ95cqfSmhAHSJCtFm0bBDZJJoTzQHGGQvk6PT8h78PrwWi96r0K7R9N0KsNCZkkrgJW94dV'), ('PREF', 'ID=7c3265d2706e8bea:FF=0:NW=1:TM=1387335505:LM=1387335505:S=LsdqbwGuUdHENT0m')]
>>> r.cookies.iteritems()
<generator object iteritems at 0x1940dc0>
>>> list(r.cookies.iteritems())
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/kpp/build/trng_social/venv/lib/python2.7/_abcoll.py", line 387, in iteritems
yield (key, self[key])
File "/home/kpp/build/trng_social/venv/local/lib/python2.7/site-packages/requests/cookies.py", line 267, in __getitem__
return self._find_no_duplicates(name)
File "/home/kpp/build/trng_social/venv/local/lib/python2.7/site-packages/requests/cookies.py", line 322, in _find_no_duplicates
raise KeyError('name=%r, domain=%r, path=%r' % (name, domain, path))
KeyError: "name=Cookie(version=0, name='NID', value='67=WbyIM1gU91bGQ5Y3SjPHQ8_fqtStHiMWGJQ5n2Bt_PwytcmPii7fV7AELJ95cqfSmhAHSJCtFm0bBDZJJoTzQHGGQvk6PT8h78PrwWi96r0K7R9N0KsNCZkkrgJW94dV', port=None, port_specified=False, domain='.google.ru', domain_specified=True, domain_initial_dot=True, path='/', path_specified=True, secure=False, expires=1403146705, discard=False, comment=None, comment_url=None, rest={'HttpOnly': None}, rfc2109=False), domain=None, path=None"
```
Because of this one can't for example build `OrderedDict` from `RequestCookieJar`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1807/reactions"
} | https://api.github.com/repos/psf/requests/issues/1807/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1807.diff",
"html_url": "https://github.com/psf/requests/pull/1807",
"merged_at": "2013-12-19T20:38:52Z",
"patch_url": "https://github.com/psf/requests/pull/1807.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1807"
} | true | [
"If you can reduce the number of changes to what is absolutely necessary I will be :+1: but as it stands you've added a lot of complexity and python version checking which is unnecessary. Much of the functionality you wrote is provided by `collections.MutableMapping`, the issue is to make that work, not duplicate c... |
https://api.github.com/repos/psf/requests/issues/1806 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1806/labels{/name} | https://api.github.com/repos/psf/requests/issues/1806/comments | https://api.github.com/repos/psf/requests/issues/1806/events | https://github.com/psf/requests/issues/1806 | 24,442,724 | MDU6SXNzdWUyNDQ0MjcyNA== | 1,806 | Need a way to disable SSL verification for all requests calls | {
"avatar_url": "https://avatars.githubusercontent.com/u/102495?v=4",
"events_url": "https://api.github.com/users/ssbarnea/events{/privacy}",
"followers_url": "https://api.github.com/users/ssbarnea/followers",
"following_url": "https://api.github.com/users/ssbarnea/following{/other_user}",
"gists_url": "https://api.github.com/users/ssbarnea/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ssbarnea",
"id": 102495,
"login": "ssbarnea",
"node_id": "MDQ6VXNlcjEwMjQ5NQ==",
"organizations_url": "https://api.github.com/users/ssbarnea/orgs",
"received_events_url": "https://api.github.com/users/ssbarnea/received_events",
"repos_url": "https://api.github.com/users/ssbarnea/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ssbarnea/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssbarnea/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ssbarnea",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-12-17T19:06:18Z | 2021-09-09T00:28:27Z | 2013-12-18T19:14:40Z | CONTRIBUTOR | resolved | If you are using a 3rd party library or just have lots of requests calls inside your code it's almost impossible to to use `verify=False`.
We need a way to disable this for all requests calls, probbly an environment variable.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1806/reactions"
} | https://api.github.com/repos/psf/requests/issues/1806/timeline | null | completed | null | null | false | [
"We used to have a way to globally configure the library like this in v0.x. We intentionally and viciously removed it in v1.x. We've not added it back and we will not add anything similar back, especially not to disable SSL verification and especially not in an environment variable.\n",
"I'm waiting for @Lukasa t... |
https://api.github.com/repos/psf/requests/issues/1805 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1805/labels{/name} | https://api.github.com/repos/psf/requests/issues/1805/comments | https://api.github.com/repos/psf/requests/issues/1805/events | https://github.com/psf/requests/issues/1805 | 24,422,782 | MDU6SXNzdWUyNDQyMjc4Mg== | 1,805 | Getting a public Google Spreadsheet doc gives you the too many redirects error | {
"avatar_url": "https://avatars.githubusercontent.com/u/131838?v=4",
"events_url": "https://api.github.com/users/teleyinex/events{/privacy}",
"followers_url": "https://api.github.com/users/teleyinex/followers",
"following_url": "https://api.github.com/users/teleyinex/following{/other_user}",
"gists_url": "https://api.github.com/users/teleyinex/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/teleyinex",
"id": 131838,
"login": "teleyinex",
"node_id": "MDQ6VXNlcjEzMTgzOA==",
"organizations_url": "https://api.github.com/users/teleyinex/orgs",
"received_events_url": "https://api.github.com/users/teleyinex/received_events",
"repos_url": "https://api.github.com/users/teleyinex/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/teleyinex/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/teleyinex/subscriptions",
"type": "User",
"url": "https://api.github.com/users/teleyinex",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-12-17T14:12:55Z | 2021-09-09T00:10:04Z | 2013-12-18T15:56:31Z | NONE | resolved | In version 2.0.0 when you try to get a document like this:
``` python
import requests
r = requests.get('https://docs.google.com/spreadsheet/ccc?key=0AsNlt0WgPAHwdEczcWduOXRUb1JUc1VGMmJtc2xXaXc&usp=sharing&output=csv')
print r.text
```
You get the CSV content, however with 2.1.0 you get the TooManyRedirects error (it tries 30 times), so it is not possible to download the document. Any idea where could it broken?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1805/reactions"
} | https://api.github.com/repos/psf/requests/issues/1805/timeline | null | completed | null | null | false | [
"Ooh, this is weird: I don't even see that request get off my system.\n",
"Which is clearly a problem with my wireshark, since it definitely does. We seem to be spinning in a redirect loop, which it's hard to imagine is the fault of a Requests version.\n",
"But it is, because all is well in 2.0.1.\n",
"Then, ... |
https://api.github.com/repos/psf/requests/issues/1804 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1804/labels{/name} | https://api.github.com/repos/psf/requests/issues/1804/comments | https://api.github.com/repos/psf/requests/issues/1804/events | https://github.com/psf/requests/issues/1804 | 24,342,176 | MDU6SXNzdWUyNDM0MjE3Ng== | 1,804 | requests seems to expect more content until it is forcibly closed by the remote host [Errno 10054] | {
"avatar_url": "https://avatars.githubusercontent.com/u/1075126?v=4",
"events_url": "https://api.github.com/users/ChristopherHackett/events{/privacy}",
"followers_url": "https://api.github.com/users/ChristopherHackett/followers",
"following_url": "https://api.github.com/users/ChristopherHackett/following{/other_user}",
"gists_url": "https://api.github.com/users/ChristopherHackett/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ChristopherHackett",
"id": 1075126,
"login": "ChristopherHackett",
"node_id": "MDQ6VXNlcjEwNzUxMjY=",
"organizations_url": "https://api.github.com/users/ChristopherHackett/orgs",
"received_events_url": "https://api.github.com/users/ChristopherHackett/received_events",
"repos_url": "https://api.github.com/users/ChristopherHackett/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ChristopherHackett/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ChristopherHackett/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ChristopherHackett",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | null | [] | null | 13 | 2013-12-16T10:55:58Z | 2021-09-08T20:00:51Z | 2015-01-19T09:24:12Z | NONE | resolved | I have noticed that requests seems to have some sort of issue with www.sainsburysbank.co.uk
It will block for 2+ mins despite having already received the content. Other tools like curl have no issue.
Below is the console and I have taken a WireShark dump (screenshot attached). If you need the pcapng file then let me know.
```
Python 2.7.3 (default, Apr 10 2012, 23:24:47) [MSC v.1500 64 bit (AMD64)] on win 32
>>>import requests
>>> requests.get('http://www.sainsburysbank.co.uk')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "C:\Python27\lib\site-packages\requests\api.py", line 55, in get
return request('get', url, **kwargs)
File "C:\Python27\lib\site-packages\requests\api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 279, in request
resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 374, in send
r = adapter.send(request, **kwargs)
File "C:\Python27\lib\site-packages\requests\adapters.py", line 222, in send
r.content
File "C:\Python27\lib\site-packages\requests\models.py", line 550, in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
File "C:\Python27\lib\site-packages\requests\models.py", line 496, in generate
chunk = self.raw.read(chunk_size)
File "C:\Python27\lib\site-packages\requests\packages\urllib3\response.py", line 148, in read
return self._fp.read(amt)
File "C:\Python27\Lib\httplib.py", line 561, in read
s = self.fp.read(amt)
File "C:\Python27\Lib\socket.py", line 380, in read
data = self._sock.recv(left)
socket.error: [Errno 10054] An existing connection was forcibly closed by the remote host
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1804/reactions"
} | https://api.github.com/repos/psf/requests/issues/1804/timeline | null | completed | null | null | false | [
"Gah, well. There's all kinds of fun here. First, Sainsbury's Bank is using chunked encoding to return the response to us. Not the end of the world, but a potential source of fun. According to Wireshark they have terminated it properly though, so that's something. Also, their headers are ill-formatted:\n\n```\nCach... |
https://api.github.com/repos/psf/requests/issues/1803 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1803/labels{/name} | https://api.github.com/repos/psf/requests/issues/1803/comments | https://api.github.com/repos/psf/requests/issues/1803/events | https://github.com/psf/requests/issues/1803 | 24,341,307 | MDU6SXNzdWUyNDM0MTMwNw== | 1,803 | Timeouts do not occur when stream == True. | {
"avatar_url": "https://avatars.githubusercontent.com/u/997507?v=4",
"events_url": "https://api.github.com/users/tylercrompton/events{/privacy}",
"followers_url": "https://api.github.com/users/tylercrompton/followers",
"following_url": "https://api.github.com/users/tylercrompton/following{/other_user}",
"gists_url": "https://api.github.com/users/tylercrompton/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/tylercrompton",
"id": 997507,
"login": "tylercrompton",
"node_id": "MDQ6VXNlcjk5NzUwNw==",
"organizations_url": "https://api.github.com/users/tylercrompton/orgs",
"received_events_url": "https://api.github.com/users/tylercrompton/received_events",
"repos_url": "https://api.github.com/users/tylercrompton/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/tylercrompton/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/tylercrompton/subscriptions",
"type": "User",
"url": "https://api.github.com/users/tylercrompton",
"user_view_type": "public"
} | [
{
"color": "5319e7",
"default": false,
"description": null,
"id": 67760318,
"name": "Fixed",
"node_id": "MDU6TGFiZWw2Nzc2MDMxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Fixed"
}
] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | {
"closed_at": "2014-12-25T16:11:51Z",
"closed_issues": 1,
"created_at": "2013-12-19T08:24:14Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/22",
"id": 517411,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/22/labels",
"node_id": "MDk6TWlsZXN0b25lNTE3NDEx",
"number": 22,
"open_issues": 0,
"state": "closed",
"title": "2.2",
"updated_at": "2014-12-25T16:11:51Z",
"url": "https://api.github.com/repos/psf/requests/milestones/22"
} | 22 | 2013-12-16T10:38:27Z | 2021-09-08T07:00:27Z | 2014-10-05T17:27:28Z | NONE | resolved | As stated in the [docs](http://requests.readthedocs.org/en/latest/user/quickstart/#timeouts):
> `timeout` is not a time limit on the entire response download; rather, an exception is raised if the server has not issued a response for `timeout` seconds (more precisely, if no bytes have been received on the underlying socket for `timeout` seconds).
With that said, it should still be possible to timeout when `stream == True`.
The following command times out as expected.
```
$ python3 -c "import requests; response = requests.request('GET', 'http://httpbin.org/delay/3', timeout=1); print(response)"
```
The following command does not timeout. A timeout is expected.
```
$ python3 -c "import requests; response = requests.request('GET', 'http://httpbin.org/delay/3', stream=True, timeout=1); print(response)"
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1803/reactions"
} | https://api.github.com/repos/psf/requests/issues/1803/timeline | null | completed | null | null | false | [
"Thanks for raising this issue! Currently in stream mode we only apply the timeout to the connection attempt, not to the read. This will probably change in future (for instance, #1801 removes this limitation), but there's no strict timescale on this.\n",
"Once again @Lukasa is 100% correct. This isn't an issue or... |
https://api.github.com/repos/psf/requests/issues/1802 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1802/labels{/name} | https://api.github.com/repos/psf/requests/issues/1802/comments | https://api.github.com/repos/psf/requests/issues/1802/events | https://github.com/psf/requests/pull/1802 | 24,331,108 | MDExOlB1bGxSZXF1ZXN0MTA4NDQzOTI= | 1,802 | Add as_http() method to print out HTTP response as a string | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2013-12-16T05:41:53Z | 2021-09-08T10:01:10Z | 2013-12-16T14:08:23Z | CONTRIBUTOR | resolved | When a HTTP response doesn't contain the content that I expect, most times I find that the simplest debugging information I want is the actual HTTP content that was sent over the wire. Instead of having to construct all of this manually I thought it would be nice to add this information as a convenience `as_http()` request.
Example:
``` python
>>> r = requests.get('https://api.twilio.com/2010-04-01.json')
>>> print r.as_http()
HTTP/1.1 200 OK
content-length: 109
x-powered-by: AT-5000
connection: close
etag:
date: Mon, 16 Dec 2013 05:39:55 GMT
x-shenanigans: none
access-control-allow-origin: https://www.twilio.com
content-type: application/json
{"name":"2010-04-01","uri":"\/2010-04-01.json","subresource_uris":{"accounts":"\/2010-04-01\/Accounts.json"}}
```
This PR also passes through version information as an attribute on the `Response` object, and adds tests for this method.
I asked about this in IRC last week, didn't get much feedback, figured it wouldn't be too hard to just write it up and submit a PR.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1802/reactions"
} | https://api.github.com/repos/psf/requests/issues/1802/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1802.diff",
"html_url": "https://github.com/psf/requests/pull/1802",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1802.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1802"
} | true | [
"Gah, tests are broken due to a Python3 encoding issue. Let me know if this is a desirable feature for the library and I'll put the work in to fix the tests.\n",
"Thanks for the pull request @kevinburke!\n\nUnfortunately, I'm -1 on this feature. My problems with this feature are as follows:\n1. It's misleading. Y... |
https://api.github.com/repos/psf/requests/issues/1801 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1801/labels{/name} | https://api.github.com/repos/psf/requests/issues/1801/comments | https://api.github.com/repos/psf/requests/issues/1801/events | https://github.com/psf/requests/pull/1801 | 24,329,258 | MDExOlB1bGxSZXF1ZXN0MTA4NDM0NDU= | 1,801 | Connect timeout | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 36 | 2013-12-16T04:10:00Z | 2021-09-08T11:00:53Z | 2014-08-23T21:22:02Z | CONTRIBUTOR | resolved | Per discussion with @sigmavirus24 in IRC, this PR kills the Timeout class and adds support for connect timeouts via a simple tuple interface:
``` python
r = requests.get('https://api.twilio.com', timeout=(3.05, 27))
```
Sometimes you try to connect to a dead host (this happens to us all the time, because of AWS) and you would like to fail fairly quickly in this case; the request has no chance of succeeding. However, once the connection succeeds, you'd like to give the server a fairly long time to process the request and return a response.
The attached tests and documentation have more information. Hope this is okay!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1801/reactions"
} | https://api.github.com/repos/psf/requests/issues/1801/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1801.diff",
"html_url": "https://github.com/psf/requests/pull/1801",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1801.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1801"
} | true | [
"I'm generally +1 on the idea and the API. I haven't combed over the diff though and a quick skim makes me think there's more there than needs to be. Also, did I see \"TimeoutSauce\"? Is there any reason to not simply call it \"Timeout\"?\n",
"In principle I'm +0.5 on this. It's a nice extension. However, as memo... |
https://api.github.com/repos/psf/requests/issues/1800 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1800/labels{/name} | https://api.github.com/repos/psf/requests/issues/1800/comments | https://api.github.com/repos/psf/requests/issues/1800/events | https://github.com/psf/requests/issues/1800 | 24,304,647 | MDU6SXNzdWUyNDMwNDY0Nw== | 1,800 | Move off of charade to erikrose/chardet | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
}
] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 1 | 2013-12-15T03:16:53Z | 2021-09-09T00:28:27Z | 2013-12-18T15:52:55Z | CONTRIBUTOR | resolved | @dan-blanchard has taken over maintenance of [chardet](erikrose/chardet). We've merged charade into chardet so that chardet will now work on python2 and python3 without needing separate versions. I'd like to get rid of charade since it's been a responsibility that I had neglected and has been more trouble than it has been worth.
We should start using chardet proper again when they have it ready. (In all candor it should already be ready)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1800/reactions"
} | https://api.github.com/repos/psf/requests/issues/1800/timeline | null | completed | null | null | false | [
"A new release of chardet is available with all the features we ever needed from charade. I'll throw together a PR to close this issue in a few minutes.\n"
] |
https://api.github.com/repos/psf/requests/issues/1799 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1799/labels{/name} | https://api.github.com/repos/psf/requests/issues/1799/comments | https://api.github.com/repos/psf/requests/issues/1799/events | https://github.com/psf/requests/pull/1799 | 24,298,739 | MDExOlB1bGxSZXF1ZXN0MTA4MzI4ODA= | 1,799 | Issue a warning when using apparent_encoding. | {
"avatar_url": "https://avatars.githubusercontent.com/u/78768?v=4",
"events_url": "https://api.github.com/users/martinblech/events{/privacy}",
"followers_url": "https://api.github.com/users/martinblech/followers",
"following_url": "https://api.github.com/users/martinblech/following{/other_user}",
"gists_url": "https://api.github.com/users/martinblech/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/martinblech",
"id": 78768,
"login": "martinblech",
"node_id": "MDQ6VXNlcjc4NzY4",
"organizations_url": "https://api.github.com/users/martinblech/orgs",
"received_events_url": "https://api.github.com/users/martinblech/received_events",
"repos_url": "https://api.github.com/users/martinblech/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/martinblech/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/martinblech/subscriptions",
"type": "User",
"url": "https://api.github.com/users/martinblech",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2013-12-14T20:11:04Z | 2021-09-08T22:01:06Z | 2013-12-15T04:20:07Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/78768?v=4",
"events_url": "https://api.github.com/users/martinblech/events{/privacy}",
"followers_url": "https://api.github.com/users/martinblech/followers",
"following_url": "https://api.github.com/users/martinblech/following{/other_user}",
"gists_url": "https://api.github.com/users/martinblech/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/martinblech",
"id": 78768,
"login": "martinblech",
"node_id": "MDQ6VXNlcjc4NzY4",
"organizations_url": "https://api.github.com/users/martinblech/orgs",
"received_events_url": "https://api.github.com/users/martinblech/received_events",
"repos_url": "https://api.github.com/users/martinblech/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/martinblech/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/martinblech/subscriptions",
"type": "User",
"url": "https://api.github.com/users/martinblech",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1799/reactions"
} | https://api.github.com/repos/psf/requests/issues/1799/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1799.diff",
"html_url": "https://github.com/psf/requests/pull/1799",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1799.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1799"
} | true | [
"I'm something in the region of -0 on this. @sigmavirus24?\n",
"I'm moreso in the half-open interval [-1, -0) on this if only because the warning will likely only be displayed once per detected encoding and not once per response if I remember the way they work correctly.\n\nAn example is like so:\n\n``` python\nd... | |
https://api.github.com/repos/psf/requests/issues/1798 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1798/labels{/name} | https://api.github.com/repos/psf/requests/issues/1798/comments | https://api.github.com/repos/psf/requests/issues/1798/events | https://github.com/psf/requests/issues/1798 | 24,296,455 | MDU6SXNzdWUyNDI5NjQ1NQ== | 1,798 | Add params in custom authentication | {
"avatar_url": "https://avatars.githubusercontent.com/u/554079?v=4",
"events_url": "https://api.github.com/users/juanriaza/events{/privacy}",
"followers_url": "https://api.github.com/users/juanriaza/followers",
"following_url": "https://api.github.com/users/juanriaza/following{/other_user}",
"gists_url": "https://api.github.com/users/juanriaza/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/juanriaza",
"id": 554079,
"login": "juanriaza",
"node_id": "MDQ6VXNlcjU1NDA3OQ==",
"organizations_url": "https://api.github.com/users/juanriaza/orgs",
"received_events_url": "https://api.github.com/users/juanriaza/received_events",
"repos_url": "https://api.github.com/users/juanriaza/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/juanriaza/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/juanriaza/subscriptions",
"type": "User",
"url": "https://api.github.com/users/juanriaza",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2013-12-14T18:05:19Z | 2021-09-09T00:28:27Z | 2013-12-14T18:44:06Z | CONTRIBUTOR | resolved | Modifying the request params in a custom authentication implementation raises a `AttributeError: 'PreparedRequest' object has no attribute 'params'`.
Example:
``` python
class CustomAuth(requests.auth.AuthBase):
def __call__(self, r):
r.params['key'] = 'my_api_key'
return r
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1798/reactions"
} | https://api.github.com/repos/psf/requests/issues/1798/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nThis fails because you aren't modifying a `Request` object, you're modifying a `PreparedRequest` object. That only has a `url` property. You'll have to edit that manually. The API documentation for `PreparedRequest` objects is [here](http://docs.python-requests.org/en/latest/api/#... |
https://api.github.com/repos/psf/requests/issues/1797 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1797/labels{/name} | https://api.github.com/repos/psf/requests/issues/1797/comments | https://api.github.com/repos/psf/requests/issues/1797/events | https://github.com/psf/requests/issues/1797 | 24,293,616 | MDU6SXNzdWUyNDI5MzYxNg== | 1,797 | Socket timeout exception thrown instead of RequestException | {
"avatar_url": "https://avatars.githubusercontent.com/u/1663259?v=4",
"events_url": "https://api.github.com/users/joepie91/events{/privacy}",
"followers_url": "https://api.github.com/users/joepie91/followers",
"following_url": "https://api.github.com/users/joepie91/following{/other_user}",
"gists_url": "https://api.github.com/users/joepie91/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/joepie91",
"id": 1663259,
"login": "joepie91",
"node_id": "MDQ6VXNlcjE2NjMyNTk=",
"organizations_url": "https://api.github.com/users/joepie91/orgs",
"received_events_url": "https://api.github.com/users/joepie91/received_events",
"repos_url": "https://api.github.com/users/joepie91/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/joepie91/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/joepie91/subscriptions",
"type": "User",
"url": "https://api.github.com/users/joepie91",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-12-14T15:13:52Z | 2021-09-09T00:28:28Z | 2013-12-14T16:05:48Z | NONE | resolved | When running the following code....
``` python
response = requests.get(result, timeout=10)
```
Where `result` was http://63.224.204.109:8085/browse/category/allbooks, the following exception was thrown after hanging for a few minutes (and apparently disregarding the `timeout` argument?):
```
Traceback (most recent call last):
File "find-calibre.py", line 34, in <module>
response = requests.get(result, timeout=10)
File "/usr/lib/python2.7/site-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 357, in request
resp = self.send(prep, **send_kwargs)
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 460, in send
r = adapter.send(request, **kwargs)
File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 367, in send
r.content
File "/usr/lib/python2.7/site-packages/requests/models.py", line 633, in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
File "/usr/lib/python2.7/site-packages/requests/models.py", line 572, in generate
decode_content=True):
File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/response.py", line 225, in stream
data = self.read(amt=amt, decode_content=decode_content)
File "/usr/lib/python2.7/site-packages/requests/packages/urllib3/response.py", line 174, in read
data = self._fp.read(amt)
File "/usr/lib64/python2.7/httplib.py", line 561, in read
s = self.fp.read(amt)
File "/usr/lib64/python2.7/socket.py", line 380, in read
data = self._sock.recv(left)
socket.timeout: timed out
```
Shouldn't this be caught by Requests, and passed on as a RequestException instead?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1797/reactions"
} | https://api.github.com/repos/psf/requests/issues/1797/timeline | null | completed | null | null | false | [
"Same issue is already opened.\nSee https://github.com/kennethreitz/requests/issues/1787\n",
"As @daftshady points out, please check the issues tracker before opening a new issue.\n",
"Thanks for opening this @joepie91 and thank you @daftshady for taking the time to find the already opened issue.\n"
] |
https://api.github.com/repos/psf/requests/issues/1796 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1796/labels{/name} | https://api.github.com/repos/psf/requests/issues/1796/comments | https://api.github.com/repos/psf/requests/issues/1796/events | https://github.com/psf/requests/pull/1796 | 24,285,315 | MDExOlB1bGxSZXF1ZXN0MTA4MjgyMDY= | 1,796 | Expose apparent_encoding_confidence. | {
"avatar_url": "https://avatars.githubusercontent.com/u/78768?v=4",
"events_url": "https://api.github.com/users/martinblech/events{/privacy}",
"followers_url": "https://api.github.com/users/martinblech/followers",
"following_url": "https://api.github.com/users/martinblech/following{/other_user}",
"gists_url": "https://api.github.com/users/martinblech/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/martinblech",
"id": 78768,
"login": "martinblech",
"node_id": "MDQ6VXNlcjc4NzY4",
"organizations_url": "https://api.github.com/users/martinblech/orgs",
"received_events_url": "https://api.github.com/users/martinblech/received_events",
"repos_url": "https://api.github.com/users/martinblech/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/martinblech/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/martinblech/subscriptions",
"type": "User",
"url": "https://api.github.com/users/martinblech",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2013-12-14T03:50:35Z | 2021-09-08T22:01:06Z | 2013-12-14T20:11:51Z | NONE | resolved | When there's no encoding in the headers and it has to be autodetected from the
contents using charade, the Response object should expose the confidence value
so the user can decide whether the value of Response.text should be trusted or
not.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/78768?v=4",
"events_url": "https://api.github.com/users/martinblech/events{/privacy}",
"followers_url": "https://api.github.com/users/martinblech/followers",
"following_url": "https://api.github.com/users/martinblech/following{/other_user}",
"gists_url": "https://api.github.com/users/martinblech/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/martinblech",
"id": 78768,
"login": "martinblech",
"node_id": "MDQ6VXNlcjc4NzY4",
"organizations_url": "https://api.github.com/users/martinblech/orgs",
"received_events_url": "https://api.github.com/users/martinblech/received_events",
"repos_url": "https://api.github.com/users/martinblech/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/martinblech/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/martinblech/subscriptions",
"type": "User",
"url": "https://api.github.com/users/martinblech",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1796/reactions"
} | https://api.github.com/repos/psf/requests/issues/1796/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1796.diff",
"html_url": "https://github.com/psf/requests/pull/1796",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1796.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1796"
} | true | [
"Thanks for this @martinblech!\n\nUnfortunately, I'm opposed to this change. Not anything to do with the code itself, but I don't think adding this parameter to the `Response` object adds sufficient value to justify including it. If people _really_ want this information they can get it (by running `charade`/`charde... |
https://api.github.com/repos/psf/requests/issues/1795 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1795/labels{/name} | https://api.github.com/repos/psf/requests/issues/1795/comments | https://api.github.com/repos/psf/requests/issues/1795/events | https://github.com/psf/requests/issues/1795 | 24,267,957 | MDU6SXNzdWUyNDI2Nzk1Nw== | 1,795 | Incorrect encoding detected for UTF-8 XML response. | {
"avatar_url": "https://avatars.githubusercontent.com/u/78768?v=4",
"events_url": "https://api.github.com/users/martinblech/events{/privacy}",
"followers_url": "https://api.github.com/users/martinblech/followers",
"following_url": "https://api.github.com/users/martinblech/following{/other_user}",
"gists_url": "https://api.github.com/users/martinblech/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/martinblech",
"id": 78768,
"login": "martinblech",
"node_id": "MDQ6VXNlcjc4NzY4",
"organizations_url": "https://api.github.com/users/martinblech/orgs",
"received_events_url": "https://api.github.com/users/martinblech/received_events",
"repos_url": "https://api.github.com/users/martinblech/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/martinblech/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/martinblech/subscriptions",
"type": "User",
"url": "https://api.github.com/users/martinblech",
"user_view_type": "public"
} | [
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 191274,
"name": "Contributor Friendly",
"node_id": "MDU6TGFiZWwxOTEyNzQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Contributor%20Friendly"
}
] | closed | true | null | [] | null | 13 | 2013-12-13T19:43:19Z | 2021-09-09T00:28:23Z | 2013-12-22T16:01:02Z | NONE | resolved | Requests decodes the UTF-8 response as TIS-620:
``` python
>>> response = requests.get('http://lyrics.wikia.com/api.php', params={'artist': 'Javiera Mena', 'song': 'Al Siguiente Nivel', 'fmt': 'xml'})
>>> print response.text
<?xml version="1.0" encoding="UTF-8"?>
<LyricsResult>
[...]
<lyrics>Esa visiรณn estรก
[...]
</LyricsResult>
```
Forcing UTF-8 yields the correct value, "Esa visión está", instead of "Esa visiรณn estรก":
``` python
>>> print response.content.decode('utf8')
<?xml version="1.0" encoding="UTF-8"?>
[...]
<lyrics>Esa visión está
[...]
</LyricsResult>
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1795/reactions"
} | https://api.github.com/repos/psf/requests/issues/1795/timeline | null | completed | null | null | false | [
"Requests is a HTTP library: we only consider HTTP headers when attempting to work out text encodings. We think it sets a dangerous precedent to attempt to parse body content. If you want to do something specific for a given content type, you have to do it yourself.\n",
"@Lukasa Absolutely agree: I wouldn't expec... |
https://api.github.com/repos/psf/requests/issues/1794 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1794/labels{/name} | https://api.github.com/repos/psf/requests/issues/1794/comments | https://api.github.com/repos/psf/requests/issues/1794/events | https://github.com/psf/requests/pull/1794 | 24,219,475 | MDExOlB1bGxSZXF1ZXN0MTA3OTAyODI= | 1,794 | Fixed pickle support for requests.adapters.HTTPAdapter | {
"avatar_url": "https://avatars.githubusercontent.com/u/113129?v=4",
"events_url": "https://api.github.com/users/erikcw/events{/privacy}",
"followers_url": "https://api.github.com/users/erikcw/followers",
"following_url": "https://api.github.com/users/erikcw/following{/other_user}",
"gists_url": "https://api.github.com/users/erikcw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/erikcw",
"id": 113129,
"login": "erikcw",
"node_id": "MDQ6VXNlcjExMzEyOQ==",
"organizations_url": "https://api.github.com/users/erikcw/orgs",
"received_events_url": "https://api.github.com/users/erikcw/received_events",
"repos_url": "https://api.github.com/users/erikcw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/erikcw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erikcw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/erikcw",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-12-13T00:26:27Z | 2021-09-08T22:01:06Z | 2013-12-14T04:29:58Z | CONTRIBUTOR | resolved | Fixed issue https://github.com/kennethreitz/requests/issues/1777 by adding unpickle support to the HTTPAdapter.
While unpickleing, the class will now set `proxy_manager` to an empty dictionary.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1794/reactions"
} | https://api.github.com/repos/psf/requests/issues/1794/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1794.diff",
"html_url": "https://github.com/psf/requests/pull/1794",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1794.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1794"
} | true | [
"This fix is a subset of the fix in #1793. You and @sigmavirus24 should work out which fix we apply (maybe a merged set of the fixes).\n",
"My fix initializes those attributes ahead of time in the event that they ever get added to the `__attrs__` list. It seems the most fool-proof way at the moment and far less c... |
https://api.github.com/repos/psf/requests/issues/1793 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1793/labels{/name} | https://api.github.com/repos/psf/requests/issues/1793/comments | https://api.github.com/repos/psf/requests/issues/1793/events | https://github.com/psf/requests/pull/1793 | 24,200,478 | MDExOlB1bGxSZXF1ZXN0MTA3Nzg2MjU= | 1,793 | Prevent error when using proxies after picking an Adapter | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 2 | 2013-12-12T19:04:51Z | 2021-09-08T08:01:06Z | 2014-01-08T18:53:42Z | CONTRIBUTOR | resolved | @Lukasa if you'd like to add tests for this you can. I'm not exactly certain if we already had tests for pickling objects and didn't have the time to check right now. I'll check when I get home though (unless you've already added tests).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1793/reactions"
} | https://api.github.com/repos/psf/requests/issues/1793/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1793.diff",
"html_url": "https://github.com/psf/requests/pull/1793",
"merged_at": "2014-01-08T18:53:42Z",
"patch_url": "https://github.com/psf/requests/pull/1793.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1793"
} | true | [
"@Lukasa any further comments?\n",
"Nope, this looks good to me. Thanks guys! :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/1792 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1792/labels{/name} | https://api.github.com/repos/psf/requests/issues/1792/comments | https://api.github.com/repos/psf/requests/issues/1792/events | https://github.com/psf/requests/pull/1792 | 24,189,411 | MDExOlB1bGxSZXF1ZXN0MTA3NzIyMTc= | 1,792 | Fixup changelog with missing breaking change. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2013-12-12T16:21:35Z | 2021-09-08T23:05:26Z | 2013-12-12T16:21:38Z | MEMBER | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1792/reactions"
} | https://api.github.com/repos/psf/requests/issues/1792/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1792.diff",
"html_url": "https://github.com/psf/requests/pull/1792",
"merged_at": "2013-12-12T16:21:38Z",
"patch_url": "https://github.com/psf/requests/pull/1792.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1792"
} | true | [] | |
https://api.github.com/repos/psf/requests/issues/1791 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1791/labels{/name} | https://api.github.com/repos/psf/requests/issues/1791/comments | https://api.github.com/repos/psf/requests/issues/1791/events | https://github.com/psf/requests/issues/1791 | 24,187,641 | MDU6SXNzdWUyNDE4NzY0MQ== | 1,791 | Requests 2.1.0 regression - cookies set on session.get are not remembered anymore for subsequent requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/198355?v=4",
"events_url": "https://api.github.com/users/avallen/events{/privacy}",
"followers_url": "https://api.github.com/users/avallen/followers",
"following_url": "https://api.github.com/users/avallen/following{/other_user}",
"gists_url": "https://api.github.com/users/avallen/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/avallen",
"id": 198355,
"login": "avallen",
"node_id": "MDQ6VXNlcjE5ODM1NQ==",
"organizations_url": "https://api.github.com/users/avallen/orgs",
"received_events_url": "https://api.github.com/users/avallen/received_events",
"repos_url": "https://api.github.com/users/avallen/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/avallen/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/avallen/subscriptions",
"type": "User",
"url": "https://api.github.com/users/avallen",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2013-12-12T15:57:23Z | 2021-09-09T00:28:29Z | 2013-12-12T16:22:24Z | NONE | resolved | The following line that made it happen has disappeared from Session.request:
```
# Add param cookies to session cookies
self.cookies = cookiejar_from_dict(cookies, cookiejar=self.cookies, overwrite=False)
```
If this was on purpose then some documentation of breaking changes such as this one would be nice to have.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1791/reactions"
} | https://api.github.com/repos/psf/requests/issues/1791/timeline | null | completed | null | null | false | [
"That line is replaced with `self.cookies = merge_cookies(self.cookies, cookies)` in 2.1.0.\nIs your problem happens when you provides cookies with `cookieJar`? \n",
"Apologies, this was on purpose. See Issue #1728, which was fixed in #1729 (though actually merged as part of #1776). I'm very sorry that it got mis... |
https://api.github.com/repos/psf/requests/issues/1790 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1790/labels{/name} | https://api.github.com/repos/psf/requests/issues/1790/comments | https://api.github.com/repos/psf/requests/issues/1790/events | https://github.com/psf/requests/issues/1790 | 24,158,307 | MDU6SXNzdWUyNDE1ODMwNw== | 1,790 | Auto convert data into json if Content-type is set to 'application/json' | {
"avatar_url": "https://avatars.githubusercontent.com/u/311929?v=4",
"events_url": "https://api.github.com/users/kracekumar/events{/privacy}",
"followers_url": "https://api.github.com/users/kracekumar/followers",
"following_url": "https://api.github.com/users/kracekumar/following{/other_user}",
"gists_url": "https://api.github.com/users/kracekumar/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kracekumar",
"id": 311929,
"login": "kracekumar",
"node_id": "MDQ6VXNlcjMxMTkyOQ==",
"organizations_url": "https://api.github.com/users/kracekumar/orgs",
"received_events_url": "https://api.github.com/users/kracekumar/received_events",
"repos_url": "https://api.github.com/users/kracekumar/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kracekumar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kracekumar/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kracekumar",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2013-12-12T05:16:45Z | 2021-09-09T00:28:30Z | 2013-12-12T13:18:20Z | CONTRIBUTOR | resolved | ```
>>> r = requests.get('https://api.github.com/user', auth=('user', 'pass'))
>>> r.status_code
200
>>> r.headers['content-type']
'application/json; charset=utf8'
>>> r.encoding
'utf-8'
>>> r.text
u'{"type":"User"...'
>>> r.json()
{u'private_gists': 419, u'total_private_repos': 77, ...}
```
If the response is `json`, requests auto converts to `dict`.
```
import requests
data = {'name': 'kracekumar', 'lang': ['python', 'go']}
headers = {'Content-type': 'application/json'}
r = requests.post("http://api.someserver.com/v1/profile/update", headers=headers, data=data)
```
Here I have set `content-type` to `json`, but forgot to encode the data to `json` (made this mistake multiple times), server will complain.
I think auto converting `data` to `json` will bring consistency to requests since `json` is converted to `dict` in response.
### Implementation
If `content-type` is set to `application/json` and data is `dict`, do `json.dumps(data)`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1790/reactions"
} | https://api.github.com/repos/psf/requests/issues/1790/timeline | null | completed | null | null | false | [
"Hey, thanks for thi @kracekumar!\n\nI don't think this is a good idea, however. The key reason is that auto-converting outgoing data is upsettingly magic. As much as possible, what you put in one parameter to the request function (e.g. `headers`) should not affect what happens to something that came in on another ... |
https://api.github.com/repos/psf/requests/issues/1789 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1789/labels{/name} | https://api.github.com/repos/psf/requests/issues/1789/comments | https://api.github.com/repos/psf/requests/issues/1789/events | https://github.com/psf/requests/issues/1789 | 24,111,608 | MDU6SXNzdWUyNDExMTYwOA== | 1,789 | Requests on PYPY 2.21 is over twice as slow as on CPython | {
"avatar_url": "https://avatars.githubusercontent.com/u/456254?v=4",
"events_url": "https://api.github.com/users/handloomweaver/events{/privacy}",
"followers_url": "https://api.github.com/users/handloomweaver/followers",
"following_url": "https://api.github.com/users/handloomweaver/following{/other_user}",
"gists_url": "https://api.github.com/users/handloomweaver/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/handloomweaver",
"id": 456254,
"login": "handloomweaver",
"node_id": "MDQ6VXNlcjQ1NjI1NA==",
"organizations_url": "https://api.github.com/users/handloomweaver/orgs",
"received_events_url": "https://api.github.com/users/handloomweaver/received_events",
"repos_url": "https://api.github.com/users/handloomweaver/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/handloomweaver/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/handloomweaver/subscriptions",
"type": "User",
"url": "https://api.github.com/users/handloomweaver",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-12-11T14:55:35Z | 2021-09-09T00:10:10Z | 2014-02-03T11:02:44Z | NONE | resolved | A get request between two local servers in same data center that is typically 15ms on CPython is more like 33ms on the same box with latest PYPY.
Why should this be?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1789/reactions"
} | https://api.github.com/repos/psf/requests/issues/1789/timeline | null | completed | null | null | false | [
"Before I go digging into this, what's your sample? I would want a fairly conclusive demonstration that this is actually a problem: that means something like doing 1000 requests to something on a local network (or even the same box) in CPython and the same again in PyPy, then checking the _average_ execution time f... |
https://api.github.com/repos/psf/requests/issues/1788 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1788/labels{/name} | https://api.github.com/repos/psf/requests/issues/1788/comments | https://api.github.com/repos/psf/requests/issues/1788/events | https://github.com/psf/requests/pull/1788 | 24,086,100 | MDExOlB1bGxSZXF1ZXN0MTA3MTQ2NDY= | 1,788 | fixed https connection to be able to handle SSL_v3 when using it with Op... | {
"avatar_url": "https://avatars.githubusercontent.com/u/281777?v=4",
"events_url": "https://api.github.com/users/AtlasPilotPuppy/events{/privacy}",
"followers_url": "https://api.github.com/users/AtlasPilotPuppy/followers",
"following_url": "https://api.github.com/users/AtlasPilotPuppy/following{/other_user}",
"gists_url": "https://api.github.com/users/AtlasPilotPuppy/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/AtlasPilotPuppy",
"id": 281777,
"login": "AtlasPilotPuppy",
"node_id": "MDQ6VXNlcjI4MTc3Nw==",
"organizations_url": "https://api.github.com/users/AtlasPilotPuppy/orgs",
"received_events_url": "https://api.github.com/users/AtlasPilotPuppy/received_events",
"repos_url": "https://api.github.com/users/AtlasPilotPuppy/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/AtlasPilotPuppy/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/AtlasPilotPuppy/subscriptions",
"type": "User",
"url": "https://api.github.com/users/AtlasPilotPuppy",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-12-11T05:01:57Z | 2021-09-09T00:01:25Z | 2013-12-11T06:58:29Z | NONE | resolved | ...enSSL
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1788/reactions"
} | https://api.github.com/repos/psf/requests/issues/1788/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1788.diff",
"html_url": "https://github.com/psf/requests/pull/1788",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1788.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1788"
} | true | [
"This is `urllib3` change, not requests.\nYou should open PR in `urllib3` not here.\n",
"Good point.\nOn Dec 10, 2013 10:26 PM, \"Park Ilsu\" notifications@github.com wrote:\n\n> This is urllib3 change, not requests.\n> You should open PR in urllib3 not here.\n> \n> —\n> Reply to this email directly or view it on... |
https://api.github.com/repos/psf/requests/issues/1787 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1787/labels{/name} | https://api.github.com/repos/psf/requests/issues/1787/comments | https://api.github.com/repos/psf/requests/issues/1787/events | https://github.com/psf/requests/issues/1787 | 24,066,907 | MDU6SXNzdWUyNDA2NjkwNw== | 1,787 | socket.timeout exception | {
"avatar_url": "https://avatars.githubusercontent.com/u/179599?v=4",
"events_url": "https://api.github.com/users/ThiefMaster/events{/privacy}",
"followers_url": "https://api.github.com/users/ThiefMaster/followers",
"following_url": "https://api.github.com/users/ThiefMaster/following{/other_user}",
"gists_url": "https://api.github.com/users/ThiefMaster/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ThiefMaster",
"id": 179599,
"login": "ThiefMaster",
"node_id": "MDQ6VXNlcjE3OTU5OQ==",
"organizations_url": "https://api.github.com/users/ThiefMaster/orgs",
"received_events_url": "https://api.github.com/users/ThiefMaster/received_events",
"repos_url": "https://api.github.com/users/ThiefMaster/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ThiefMaster/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ThiefMaster/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ThiefMaster",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | null | [] | null | 31 | 2013-12-10T21:27:49Z | 2021-09-08T23:06:06Z | 2015-01-19T09:24:40Z | CONTRIBUTOR | resolved | I think that exception should be handled/wrapped internally and be reraised as a `RequestException`-based exception.
```
Traceback (most recent call last):
File "X:\dev\rotaryboard\daemon\testdaemon.py", line 117, in <module>
res = foobar_cmd()
File "X:\dev\rotaryboard\daemon\testdaemon.py", line 53, in foobar_cmd
return requests.get(url, params=params, auth=('foobar', 'meow'), timeout=0.1).json()
File "F:\Python27\lib\site-packages\requests\api.py", line 55, in get
return request('get', url, **kwargs)
File "F:\Python27\lib\site-packages\requests\api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "F:\Python27\lib\site-packages\requests\sessions.py", line 382, in request
resp = self.send(prep, **send_kwargs)
File "F:\Python27\lib\site-packages\requests\sessions.py", line 485, in send
r = adapter.send(request, **kwargs)
File "F:\Python27\lib\site-packages\requests\adapters.py", line 388, in send
r.content
File "F:\Python27\lib\site-packages\requests\models.py", line 676, in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
File "F:\Python27\lib\site-packages\requests\models.py", line 615, in generate
decode_content=True):
File "F:\Python27\lib\site-packages\requests\packages\urllib3\response.py", line 236, in stream
data = self.read(amt=amt, decode_content=decode_content)
File "F:\Python27\lib\site-packages\requests\packages\urllib3\response.py", line 183, in read
data = self._fp.read(amt)
File "F:\Python27\lib\httplib.py", line 552, in read
s = self.fp.read(amt)
File "F:\Python27\lib\httplib.py", line 1288, in read
return s + self._file.read(amt - len(s))
File "F:\Python27\lib\socket.py", line 378, in read
data = self._sock.recv(left)
socket.timeout: timed out
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1787/reactions"
} | https://api.github.com/repos/psf/requests/issues/1787/timeline | null | completed | null | null | false | [
"Ok, seems to be a duplicate of #1236... still annoying.\n",
"With the latest version this no longer seems to show. The socket exception has been wrapped with a requests.exceptions.TimeoutException . \nI think it is fair to say this can be closed?\n",
"It happened with requests 2.1.0. So if that's the \"latest ... |
https://api.github.com/repos/psf/requests/issues/1786 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1786/labels{/name} | https://api.github.com/repos/psf/requests/issues/1786/comments | https://api.github.com/repos/psf/requests/issues/1786/events | https://github.com/psf/requests/issues/1786 | 23,897,795 | MDU6SXNzdWUyMzg5Nzc5NQ== | 1,786 | Certificate Revocation List (CRL) support with https | {
"avatar_url": "https://avatars.githubusercontent.com/u/33690?v=4",
"events_url": "https://api.github.com/users/chutz/events{/privacy}",
"followers_url": "https://api.github.com/users/chutz/followers",
"following_url": "https://api.github.com/users/chutz/following{/other_user}",
"gists_url": "https://api.github.com/users/chutz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/chutz",
"id": 33690,
"login": "chutz",
"node_id": "MDQ6VXNlcjMzNjkw",
"organizations_url": "https://api.github.com/users/chutz/orgs",
"received_events_url": "https://api.github.com/users/chutz/received_events",
"repos_url": "https://api.github.com/users/chutz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/chutz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chutz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/chutz",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 12 | 2013-12-07T02:23:46Z | 2021-09-03T00:10:42Z | 2013-12-09T19:12:17Z | NONE | resolved | Currently requests doesn't support checking if a certificate has been revokes in a CRL when using verify=True, it would be quite useful if this was supported.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1786/reactions"
} | https://api.github.com/repos/psf/requests/issues/1786/timeline | null | completed | null | null | false | [
"Have you encountered a certificate that should have been revoked which wasn't? I'm 90% sure that Kenneth curates the list carefully to remove revoked certs.\n",
"We have a new policy thanks to the security-conscious guys handling Requests' integration with `pip`. Each release we update our list of certs, which i... |
https://api.github.com/repos/psf/requests/issues/1785 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1785/labels{/name} | https://api.github.com/repos/psf/requests/issues/1785/comments | https://api.github.com/repos/psf/requests/issues/1785/events | https://github.com/psf/requests/pull/1785 | 23,880,585 | MDExOlB1bGxSZXF1ZXN0MTA2MDU5OTU= | 1,785 | Made default_user_agent reusable | {
"avatar_url": "https://avatars.githubusercontent.com/u/1580136?v=4",
"events_url": "https://api.github.com/users/smallcode/events{/privacy}",
"followers_url": "https://api.github.com/users/smallcode/followers",
"following_url": "https://api.github.com/users/smallcode/following{/other_user}",
"gists_url": "https://api.github.com/users/smallcode/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/smallcode",
"id": 1580136,
"login": "smallcode",
"node_id": "MDQ6VXNlcjE1ODAxMzY=",
"organizations_url": "https://api.github.com/users/smallcode/orgs",
"received_events_url": "https://api.github.com/users/smallcode/received_events",
"repos_url": "https://api.github.com/users/smallcode/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/smallcode/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/smallcode/subscriptions",
"type": "User",
"url": "https://api.github.com/users/smallcode",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "e11d21",
"default": false,
"descrip... | closed | true | null | [] | null | 3 | 2013-12-06T19:46:03Z | 2021-09-08T22:01:05Z | 2013-12-07T05:55:44Z | NONE | resolved | make the version reusable too.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1580136?v=4",
"events_url": "https://api.github.com/users/smallcode/events{/privacy}",
"followers_url": "https://api.github.com/users/smallcode/followers",
"following_url": "https://api.github.com/users/smallcode/following{/other_user}",
"gists_url": "https://api.github.com/users/smallcode/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/smallcode",
"id": 1580136,
"login": "smallcode",
"node_id": "MDQ6VXNlcjE1ODAxMzY=",
"organizations_url": "https://api.github.com/users/smallcode/orgs",
"received_events_url": "https://api.github.com/users/smallcode/received_events",
"repos_url": "https://api.github.com/users/smallcode/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/smallcode/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/smallcode/subscriptions",
"type": "User",
"url": "https://api.github.com/users/smallcode",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1785/reactions"
} | https://api.github.com/repos/psf/requests/issues/1785/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1785.diff",
"html_url": "https://github.com/psf/requests/pull/1785",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1785.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1785"
} | true | [
"I'm now -1 on this. I was neutral on the previous change, but each additional changeable value takes us one step closer to the logical endpoint of this trend, which is every parameter is editable. I think we should stop changing this, and just let people reimplement the totally trivial logic of this function if th... |
https://api.github.com/repos/psf/requests/issues/1784 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1784/labels{/name} | https://api.github.com/repos/psf/requests/issues/1784/comments | https://api.github.com/repos/psf/requests/issues/1784/events | https://github.com/psf/requests/issues/1784 | 23,845,672 | MDU6SXNzdWUyMzg0NTY3Mg== | 1,784 | Can't upload file larger than 2GB to webdav by requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/2759502?v=4",
"events_url": "https://api.github.com/users/wchang/events{/privacy}",
"followers_url": "https://api.github.com/users/wchang/followers",
"following_url": "https://api.github.com/users/wchang/following{/other_user}",
"gists_url": "https://api.github.com/users/wchang/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/wchang",
"id": 2759502,
"login": "wchang",
"node_id": "MDQ6VXNlcjI3NTk1MDI=",
"organizations_url": "https://api.github.com/users/wchang/orgs",
"received_events_url": "https://api.github.com/users/wchang/received_events",
"repos_url": "https://api.github.com/users/wchang/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/wchang/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wchang/subscriptions",
"type": "User",
"url": "https://api.github.com/users/wchang",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 25 | 2013-12-06T09:20:32Z | 2021-09-09T00:28:30Z | 2013-12-11T12:34:35Z | NONE | resolved | Dear Sir,
I can't upload file larger than 2GB to webdav server by requests, and the following is the error message. Any idea about how to solve this problem ? Thanks a lot for your help.
OS: SL5,SL6
Python version:2.6.6
requests version:2.1.0
raceback (most recent call last):
File "upload.py", line 5, in <module>
File "/opt/rucio/.venv/lib64/python2.6/site-packages/requests/api.py", line 99, in put
return request('put', url, data=data, *_kwargs)
File "/opt/rucio/.venv/lib64/python2.6/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, *_kwargs)
File "/opt/rucio/.venv/lib64/python2.6/site-packages/requests/sessions.py", line 361, in request
resp = self.send(prep, *_send_kwargs)
File "/opt/rucio/.venv/lib64/python2.6/site-packages/requests/sessions.py", line 464, in send
r = adapter.send(request, *_kwargs)
File "/opt/rucio/.venv/lib64/python2.6/site-packages/requests/adapters.py", line 363, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 5] _ssl.c:1217: Some I/O error occurred
Best Regards,
Evan Chang
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1784/reactions"
} | https://api.github.com/repos/psf/requests/issues/1784/timeline | null | completed | null | null | false | [
"Hi: can I see the line of code you're using to send the file?\n",
"Hi,\nIt's my simple code:\nimport requests\nfile=open('/home/evan/file_2.5G_01','rb')\ndata=file.read()\nrequests.put('https://my/webdav/server/file_2.5G_01', data=data, verify=False, cert=('/tmp/evan.proxy','/tmp/evan.proxy'))\n\nThanks,\nEvan C... |
https://api.github.com/repos/psf/requests/issues/1783 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1783/labels{/name} | https://api.github.com/repos/psf/requests/issues/1783/comments | https://api.github.com/repos/psf/requests/issues/1783/events | https://github.com/psf/requests/pull/1783 | 23,822,752 | MDExOlB1bGxSZXF1ZXN0MTA1NzM3Njg= | 1,783 | jenkins test 2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2013-12-05T22:21:05Z | 2021-09-08T23:05:08Z | 2013-12-05T22:26:45Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1783/reactions"
} | https://api.github.com/repos/psf/requests/issues/1783/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1783.diff",
"html_url": "https://github.com/psf/requests/pull/1783",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1783.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1783"
} | true | [] | |
https://api.github.com/repos/psf/requests/issues/1782 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1782/labels{/name} | https://api.github.com/repos/psf/requests/issues/1782/comments | https://api.github.com/repos/psf/requests/issues/1782/events | https://github.com/psf/requests/pull/1782 | 23,822,484 | MDExOlB1bGxSZXF1ZXN0MTA1NzM2MTA= | 1,782 | Fake PR for testing | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2013-12-05T22:16:57Z | 2021-09-08T23:06:26Z | 2013-12-05T22:20:43Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1782/reactions"
} | https://api.github.com/repos/psf/requests/issues/1782/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1782.diff",
"html_url": "https://github.com/psf/requests/pull/1782",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1782.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1782"
} | true | [] | |
https://api.github.com/repos/psf/requests/issues/1781 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1781/labels{/name} | https://api.github.com/repos/psf/requests/issues/1781/comments | https://api.github.com/repos/psf/requests/issues/1781/events | https://github.com/psf/requests/pull/1781 | 23,817,778 | MDExOlB1bGxSZXF1ZXN0MTA1NzA5NTY= | 1,781 | Clean up #1779. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-12-05T21:07:54Z | 2021-09-08T23:11:09Z | 2013-12-05T22:00:59Z | MEMBER | resolved | The unicode literals are a time bomb, let's just be rid of them.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1781/reactions"
} | https://api.github.com/repos/psf/requests/issues/1781/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1781.diff",
"html_url": "https://github.com/psf/requests/pull/1781",
"merged_at": "2013-12-05T22:00:59Z",
"patch_url": "https://github.com/psf/requests/pull/1781.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1781"
} | true | [
"Probably I would have fixed it if a message was left like \"Clean up the unicode, then we are good to merge\". \n",
"@kracekumar I know. =) The only reason I did this was because Kenneth got eager to push out a release last night, and I wanted to make sure we didn't slow him down. =) Your PR was a good one, than... |
https://api.github.com/repos/psf/requests/issues/1780 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1780/labels{/name} | https://api.github.com/repos/psf/requests/issues/1780/comments | https://api.github.com/repos/psf/requests/issues/1780/events | https://github.com/psf/requests/issues/1780 | 23,775,370 | MDU6SXNzdWUyMzc3NTM3MA== | 1,780 | Specifying POST body content-type | {
"avatar_url": "https://avatars.githubusercontent.com/u/343998?v=4",
"events_url": "https://api.github.com/users/bow/events{/privacy}",
"followers_url": "https://api.github.com/users/bow/followers",
"following_url": "https://api.github.com/users/bow/following{/other_user}",
"gists_url": "https://api.github.com/users/bow/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bow",
"id": 343998,
"login": "bow",
"node_id": "MDQ6VXNlcjM0Mzk5OA==",
"organizations_url": "https://api.github.com/users/bow/orgs",
"received_events_url": "https://api.github.com/users/bow/received_events",
"repos_url": "https://api.github.com/users/bow/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bow/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bow/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bow",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-12-05T09:29:11Z | 2021-09-08T09:00:36Z | 2013-12-09T19:12:38Z | NONE | resolved | I was using requests to submit POST requests to a third-party website when I noticed that the `files` parameter can also accept a three- or four-element tuple that denotes body content-type (and another header?) (https://github.com/kennethreitz/requests/blob/master/requests/models.py#L120) instead of just two as noted in the docs.
Is there a reason this is not yet mentioned in the docs or can I expect this interface may break in future releases?
I'm on Requests version 2.0.1, by the way :).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1780/reactions"
} | https://api.github.com/repos/psf/requests/issues/1780/timeline | null | completed | null | null | false | [
"It's not mentioned in the docs primarily out of laziness. We do talk about it elsewhere, such as on Stack Overflow. I think more generally we're not very happy with that interface, so we're always considering changing it, but I think we'd be happy to accept a docs pull request anyway. =)\n",
"Is there any reason... |
https://api.github.com/repos/psf/requests/issues/1779 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1779/labels{/name} | https://api.github.com/repos/psf/requests/issues/1779/comments | https://api.github.com/repos/psf/requests/issues/1779/events | https://github.com/psf/requests/pull/1779 | 23,769,423 | MDExOlB1bGxSZXF1ZXN0MTA1NDM2Mjk= | 1,779 | Made default_user_agent reusable | {
"avatar_url": "https://avatars.githubusercontent.com/u/311929?v=4",
"events_url": "https://api.github.com/users/kracekumar/events{/privacy}",
"followers_url": "https://api.github.com/users/kracekumar/followers",
"following_url": "https://api.github.com/users/kracekumar/following{/other_user}",
"gists_url": "https://api.github.com/users/kracekumar/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kracekumar",
"id": 311929,
"login": "kracekumar",
"node_id": "MDQ6VXNlcjMxMTkyOQ==",
"organizations_url": "https://api.github.com/users/kracekumar/orgs",
"received_events_url": "https://api.github.com/users/kracekumar/received_events",
"repos_url": "https://api.github.com/users/kracekumar/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kracekumar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kracekumar/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kracekumar",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-12-05T06:41:57Z | 2021-09-08T23:06:31Z | 2013-12-05T19:44:06Z | CONTRIBUTOR | resolved | This is not exciting change, but will help for people who wants to change name of user agent alone. Also name can be unicode.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1779/reactions"
} | https://api.github.com/repos/psf/requests/issues/1779/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1779.diff",
"html_url": "https://github.com/psf/requests/pull/1779",
"merged_at": "2013-12-05T19:44:06Z",
"patch_url": "https://github.com/psf/requests/pull/1779.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1779"
} | true | [
"I'm strongly +0 on this change. I can see how it's useful, but it's hidden away in an undocumented library function that we never planned to expose to the world, so I'm quite happy to let this change go unmerged as well. It's not hard to construct a User-Agent on your own. =)\n\nMore importantly, the code isn't ri... |
https://api.github.com/repos/psf/requests/issues/1778 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1778/labels{/name} | https://api.github.com/repos/psf/requests/issues/1778/comments | https://api.github.com/repos/psf/requests/issues/1778/events | https://github.com/psf/requests/issues/1778 | 23,764,500 | MDU6SXNzdWUyMzc2NDUwMA== | 1,778 | Browser compatible redirects don't work for APIs | {
"avatar_url": "https://avatars.githubusercontent.com/u/416057?v=4",
"events_url": "https://api.github.com/users/jamielennox/events{/privacy}",
"followers_url": "https://api.github.com/users/jamielennox/followers",
"following_url": "https://api.github.com/users/jamielennox/following{/other_user}",
"gists_url": "https://api.github.com/users/jamielennox/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jamielennox",
"id": 416057,
"login": "jamielennox",
"node_id": "MDQ6VXNlcjQxNjA1Nw==",
"organizations_url": "https://api.github.com/users/jamielennox/orgs",
"received_events_url": "https://api.github.com/users/jamielennox/received_events",
"repos_url": "https://api.github.com/users/jamielennox/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jamielennox/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jamielennox/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jamielennox",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-12-05T03:28:14Z | 2021-09-09T00:28:31Z | 2013-12-09T19:12:46Z | NONE | resolved | In the redirection code there are a couple of special rules for handling redirections:
kennethreitz/requests@4bceb312f1b99d36a25f2985b5606e98b6f0d8cd/requests/sessions.py#L127 shows handling of rfc2616 and some browser specific handling for https://en.wikipedia.org/wiki/Post/Redirect/Get
I understand why that is the default, but for writing code that talks to APIs this doesn't work.
Could we introduce a flag or something that we can set to be 'api_compatible' and do more predictable redirect handling?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1778/reactions"
} | https://api.github.com/repos/psf/requests/issues/1778/timeline | null | completed | null | null | false | [
"If you want to override Requests' redirect logic, the way to do it is to set `allow_redirects` to false.\n\nIt's also unclear to me why APIs would ignore that set of behaviours. Writing an API that assumes that a 301/302 will keep the verb the same on redirect is willfully blind, especially when two other status c... |
https://api.github.com/repos/psf/requests/issues/1777 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1777/labels{/name} | https://api.github.com/repos/psf/requests/issues/1777/comments | https://api.github.com/repos/psf/requests/issues/1777/events | https://github.com/psf/requests/issues/1777 | 23,736,831 | MDU6SXNzdWUyMzczNjgzMQ== | 1,777 | AttributeError: 'HTTPAdapter' object has no attribute 'proxy_manager' | {
"avatar_url": "https://avatars.githubusercontent.com/u/113129?v=4",
"events_url": "https://api.github.com/users/erikcw/events{/privacy}",
"followers_url": "https://api.github.com/users/erikcw/followers",
"following_url": "https://api.github.com/users/erikcw/following{/other_user}",
"gists_url": "https://api.github.com/users/erikcw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/erikcw",
"id": 113129,
"login": "erikcw",
"node_id": "MDQ6VXNlcjExMzEyOQ==",
"organizations_url": "https://api.github.com/users/erikcw/orgs",
"received_events_url": "https://api.github.com/users/erikcw/received_events",
"repos_url": "https://api.github.com/users/erikcw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/erikcw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/erikcw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/erikcw",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-12-04T18:48:11Z | 2021-09-09T00:10:11Z | 2014-02-03T11:02:16Z | CONTRIBUTOR | resolved | I'm running requests version 2.0.1 on OSX 10.9 and proxying through Charles Proxy.
I've been getting the following traceback when trying query an API. Looks like the `proxy_manager` is not getting set in the object.
``` python
# requests session is setup like this:
headers = {
'User-Agent': 'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9) AppleWebKit/537.71 (KHTML, like Gecko) Version/7.0 Safari/537.71',
'Content-type': 'application/json',
}
proxies = {
"http": "http://127.0.0.1:8888",
"https": "http://127.0.0.1:8888",
}
s = requests.session()
s.headers.update(headers)
s.proxies = proxies
s.get(url) # pseudo code
File "/Users/erik/.virtualenvs/proj/lib/python2.7/site-packages/IPython/core/interactiveshell.py", line 2827, in run_code
exec code_obj in self.user_global_ns, self.user_ns
File "<ipython-input-6-db63d61cf602>", line 1, in <module>
tasks.process_transparency_report(r.pk)
File "/Users/erik/.virtualenvs/proj/lib/python2.7/site-packages/celery/local.py", line 165, in <lambda>
__call__ = lambda x, *a, **kw: x._get_current_object()(*a, **kw)
File "/Users/erik/.virtualenvs/proj/lib/python2.7/site-packages/celery/app/task.py", line 409, in __call__
return self.run(*args, **kwargs)
File "/Users/erik/Dropbox/home/git/proj/anx/tasks.py", line 417, in process_transparency_report
resp = report_job.check_report_job_status()
File "/Users/erik/Dropbox/home/git/proj/portal/models.py", line 4437, in check_report_job_status
resp = anx.report_service.report_job_status(self.report_id)
File "/Users/erik/Dropbox/home/git/proj/anx/api.py", line 784, in report_job_status
resp = self.get(url, params=params)
File "/Users/erik/Dropbox/home/git/proj/anx/api.py", line 124, in get
resp = self.browser.get(url, params=params, **kwargs)
File "/Users/erik/.virtualenvs/proj/lib/python2.7/site-packages/requests/sessions.py", line 373, in get
return self.request('GET', url, **kwargs)
File "/Users/erik/.virtualenvs/proj/lib/python2.7/site-packages/requests/sessions.py", line 361, in request
resp = self.send(prep, **send_kwargs)
File "/Users/erik/.virtualenvs/proj/lib/python2.7/site-packages/requests/sessions.py", line 464, in send
r = adapter.send(request, **kwargs)
File "/Users/erik/.virtualenvs/proj/lib/python2.7/site-packages/requests/adapters.py", line 296, in send
conn = self.get_connection(request.url, proxies)
File "/Users/erik/.virtualenvs/proj/lib/python2.7/site-packages/requests/adapters.py", line 202, in get_connection
if not proxy in self.proxy_manager:
AttributeError: 'HTTPAdapter' object has no attribute 'proxy_manager'
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1777/reactions"
} | https://api.github.com/repos/psf/requests/issues/1777/timeline | null | completed | null | null | false | [
"You're going to have to use some real code, I'm afraid, because that simply shouldn't be possible. Initialising the `HTTPAdapter` object also initialises `proxy_manager` to an empty dictionary, so it should be impossible for that `AttributeError` to be raised.\n",
"@erikcw Any updates on this issue? I'm really c... |
https://api.github.com/repos/psf/requests/issues/1776 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1776/labels{/name} | https://api.github.com/repos/psf/requests/issues/1776/comments | https://api.github.com/repos/psf/requests/issues/1776/events | https://github.com/psf/requests/pull/1776 | 23,713,024 | MDExOlB1bGxSZXF1ZXN0MTA1MTEzNzI= | 1,776 | Fix 1728 (Fixed up from #1729) | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 1 | 2013-12-04T12:46:50Z | 2021-09-08T23:06:15Z | 2013-12-05T22:26:58Z | CONTRIBUTOR | resolved | This is just @gazpachoking's PR #1729 in a mergable state and with the PR feedback that @Lukasa left on it.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1776/reactions"
} | https://api.github.com/repos/psf/requests/issues/1776/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1776.diff",
"html_url": "https://github.com/psf/requests/pull/1776",
"merged_at": "2013-12-05T22:26:58Z",
"patch_url": "https://github.com/psf/requests/pull/1776.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1776"
} | true | [
"LGTM. =) :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/1775 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1775/labels{/name} | https://api.github.com/repos/psf/requests/issues/1775/comments | https://api.github.com/repos/psf/requests/issues/1775/events | https://github.com/psf/requests/pull/1775 | 23,649,105 | MDExOlB1bGxSZXF1ZXN0MTA0NzQ5OTQ= | 1,775 | Add README to requests/packages | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 15 | 2013-12-03T15:19:22Z | 2021-09-08T23:10:59Z | 2013-12-04T01:02:25Z | CONTRIBUTOR | resolved | - Hopefully people will read this before making changes to vendored libraries
Hopefully this will prevent PRs like: #1773
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1775/reactions"
} | https://api.github.com/repos/psf/requests/issues/1775/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1775.diff",
"html_url": "https://github.com/psf/requests/pull/1775",
"merged_at": "2013-12-04T01:02:25Z",
"patch_url": "https://github.com/psf/requests/pull/1775.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1775"
} | true | [
"I approve this message. I don't approve the fact that Travis CI tested it instead of Jenkins.\n",
"@kennethreitz can you turn off the Travis integration hook altogether? This is annoying. I'd be willing to guess that they both ran this but Travis ran it last and got precendence over the other.\n",
"uh, i thoug... |
https://api.github.com/repos/psf/requests/issues/1774 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1774/labels{/name} | https://api.github.com/repos/psf/requests/issues/1774/comments | https://api.github.com/repos/psf/requests/issues/1774/events | https://github.com/psf/requests/issues/1774 | 23,643,925 | MDU6SXNzdWUyMzY0MzkyNQ== | 1,774 | Response should not return 'ISO-8859-1' as default encoding | {
"avatar_url": "https://avatars.githubusercontent.com/u/494412?v=4",
"events_url": "https://api.github.com/users/weiqiyiji/events{/privacy}",
"followers_url": "https://api.github.com/users/weiqiyiji/followers",
"following_url": "https://api.github.com/users/weiqiyiji/following{/other_user}",
"gists_url": "https://api.github.com/users/weiqiyiji/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/weiqiyiji",
"id": 494412,
"login": "weiqiyiji",
"node_id": "MDQ6VXNlcjQ5NDQxMg==",
"organizations_url": "https://api.github.com/users/weiqiyiji/orgs",
"received_events_url": "https://api.github.com/users/weiqiyiji/received_events",
"repos_url": "https://api.github.com/users/weiqiyiji/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/weiqiyiji/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/weiqiyiji/subscriptions",
"type": "User",
"url": "https://api.github.com/users/weiqiyiji",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2013-12-03T13:59:38Z | 2021-09-08T23:10:44Z | 2013-12-03T14:07:09Z | NONE | resolved | Hi, the code that get encoding, when fetching http://lianxu.me/blog/2012/11/14/10-cocoa-objc-newbie-problems/, it will return default encoding 'ISO-8859-1' (The page's content-type is `text/html`, not `text/html; charset=utf-8`)
```
def get_encoding_from_headers(headers):
"""Returns encodings from given HTTP Header Dict.
:param headers: dictionary to extract encoding from.
"""
content_type = headers.get('content-type')
if not content_type:
return None
content_type, params = cgi.parse_header(content_type)
if 'charset' in params:
return params['charset'].strip("'\"")
if 'text' in content_type:
return 'ISO-8859-1'
```
And then, encoding is 'ISO-8859-1', so the text will call unicode(content, 'ISO-8859-1'), but the content is already utf-8 encoded, so this will return an invalid unicode string that I cannot call `unicode.decode('utf-8')` on it.
```
@property
def text(self):
"""Content of the response, in unicode.
if Response.encoding is None and chardet module is available, encoding
will be guessed.
"""
# Try charset from content-type
content = None
encoding = self.encoding
if not self.content:
return str('')
# Fallback to auto-detected encoding.
if self.encoding is None:
encoding = self.apparent_encoding
# Decode unicode from given encoding.
try:
content = str(self.content, encoding, errors='replace')
except (LookupError, TypeError):
# A LookupError is raised if the encoding was not found which could
# indicate a misspelling or similar mistake.
#
# A TypeError can be raised if encoding is None
#
# So we try blindly encoding.
content = str(self.content, errors='replace')
return content
```
I'll show you the code
```
resp = requests.get('http://lianxu.me/blog/2012/11/14/10-cocoa-objc-newbie-problems/')
resp.apprent_encoding # == 'utf-8'
resp.encoding # == 'ISO-8859-1'
resp.content # is byte array encoded in 'utf-8'
resp.text # is a unicode string that wrap content in 'ISO-8859-1'
```
I think requests should return None when no encoding found, otherwise this will lead wrong text that user cannot decode on it
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1774/reactions"
} | https://api.github.com/repos/psf/requests/issues/1774/timeline | null | completed | null | null | false | [
"I'm 90% sure we just received a similar issue. Let me find it before I give you what I think I remember as the conclusion\n",
"And [the issue I was thinking of](https://github.com/kennethreitz/requests/issues/1737) is still open. I'm closing this to centralize discussion over there with the added request that yo... |
https://api.github.com/repos/psf/requests/issues/1773 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1773/labels{/name} | https://api.github.com/repos/psf/requests/issues/1773/comments | https://api.github.com/repos/psf/requests/issues/1773/events | https://github.com/psf/requests/pull/1773 | 23,639,960 | MDExOlB1bGxSZXF1ZXN0MTA0Njk5NTg= | 1,773 | Ensure sockets are properly closed on object destruction | {
"avatar_url": "https://avatars.githubusercontent.com/u/3353832?v=4",
"events_url": "https://api.github.com/users/vincentxb/events{/privacy}",
"followers_url": "https://api.github.com/users/vincentxb/followers",
"following_url": "https://api.github.com/users/vincentxb/following{/other_user}",
"gists_url": "https://api.github.com/users/vincentxb/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vincentxb",
"id": 3353832,
"login": "vincentxb",
"node_id": "MDQ6VXNlcjMzNTM4MzI=",
"organizations_url": "https://api.github.com/users/vincentxb/orgs",
"received_events_url": "https://api.github.com/users/vincentxb/received_events",
"repos_url": "https://api.github.com/users/vincentxb/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vincentxb/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vincentxb/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vincentxb",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-12-03T12:44:55Z | 2021-09-08T23:10:54Z | 2013-12-03T14:10:19Z | NONE | resolved | Fix issue @tardyp reported on #239
We have not been able to reproduce on a simple testcase. We can only make it happen on our complex environment; involving buildbot, twisted and txrequests.
This fix no longer exhibits the issue. Please, give us a feedback whether this solutions is correct.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1773/reactions"
} | https://api.github.com/repos/psf/requests/issues/1773/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1773.diff",
"html_url": "https://github.com/psf/requests/pull/1773",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1773.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1773"
} | true | [
"It's certainly possible that the fixes are correct, but all your changes are in urllib3. This is actually a third party library that is maintained separately from Requests, and we simply include a direct copy of their code. Can I suggest you raise the issue at [shazow/urllib3](https://github.com/shazow/urllib3)?\n... |
https://api.github.com/repos/psf/requests/issues/1772 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1772/labels{/name} | https://api.github.com/repos/psf/requests/issues/1772/comments | https://api.github.com/repos/psf/requests/issues/1772/events | https://github.com/psf/requests/pull/1772 | 23,618,218 | MDExOlB1bGxSZXF1ZXN0MTA0NTgyNzI= | 1,772 | Make morsel_to_cookie more pythonic | {
"avatar_url": "https://avatars.githubusercontent.com/u/1069047?v=4",
"events_url": "https://api.github.com/users/mdbecker/events{/privacy}",
"followers_url": "https://api.github.com/users/mdbecker/followers",
"following_url": "https://api.github.com/users/mdbecker/following{/other_user}",
"gists_url": "https://api.github.com/users/mdbecker/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mdbecker",
"id": 1069047,
"login": "mdbecker",
"node_id": "MDQ6VXNlcjEwNjkwNDc=",
"organizations_url": "https://api.github.com/users/mdbecker/orgs",
"received_events_url": "https://api.github.com/users/mdbecker/received_events",
"repos_url": "https://api.github.com/users/mdbecker/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mdbecker/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mdbecker/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mdbecker",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 16 | 2013-12-03T02:56:53Z | 2021-09-08T23:07:16Z | 2013-12-06T15:38:12Z | CONTRIBUTOR | resolved | Fix a pep8 error. Prior to fixing this, I implemented some tests to cover the code I was fixing. This should help prevent regression issues.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1772/reactions"
} | https://api.github.com/repos/psf/requests/issues/1772/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1772.diff",
"html_url": "https://github.com/psf/requests/pull/1772",
"merged_at": "2013-12-06T15:38:12Z",
"patch_url": "https://github.com/psf/requests/pull/1772.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1772"
} | true | [
"@sigmavirus24 - Pushed the changes we discussed. Let me know if you have anything else!\n\nThanks!\n",
"With the exception that the diff is a bit noisy due to @mdbecker alphabetizing portions (imports and one functions params), this is good to merge in my opinion.\n\nFor those who don't care to read :+1: :shipit... |
https://api.github.com/repos/psf/requests/issues/1771 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1771/labels{/name} | https://api.github.com/repos/psf/requests/issues/1771/comments | https://api.github.com/repos/psf/requests/issues/1771/events | https://github.com/psf/requests/issues/1771 | 23,618,167 | MDU6SXNzdWUyMzYxODE2Nw== | 1,771 | Object type comparison in morsel_to_cookie is unpythonic | {
"avatar_url": "https://avatars.githubusercontent.com/u/1069047?v=4",
"events_url": "https://api.github.com/users/mdbecker/events{/privacy}",
"followers_url": "https://api.github.com/users/mdbecker/followers",
"following_url": "https://api.github.com/users/mdbecker/following{/other_user}",
"gists_url": "https://api.github.com/users/mdbecker/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mdbecker",
"id": 1069047,
"login": "mdbecker",
"node_id": "MDQ6VXNlcjEwNjkwNDc=",
"organizations_url": "https://api.github.com/users/mdbecker/orgs",
"received_events_url": "https://api.github.com/users/mdbecker/received_events",
"repos_url": "https://api.github.com/users/mdbecker/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mdbecker/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mdbecker/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mdbecker",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-12-03T02:55:18Z | 2021-09-09T00:34:14Z | 2013-12-03T03:14:22Z | CONTRIBUTOR | resolved | Found this one via the pep8 tool:
requests/cookies.py:386:26: E721 do not compare types, use 'isinstance()'
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1771/reactions"
} | https://api.github.com/repos/psf/requests/issues/1771/timeline | null | completed | null | null | false | [
"Closing to centralize discussion on #1772\n"
] |
https://api.github.com/repos/psf/requests/issues/1770 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1770/labels{/name} | https://api.github.com/repos/psf/requests/issues/1770/comments | https://api.github.com/repos/psf/requests/issues/1770/events | https://github.com/psf/requests/pull/1770 | 23,604,803 | MDExOlB1bGxSZXF1ZXN0MTA0NTA1Njc= | 1,770 | Implemetation of IP address ranges for no_proxy environment variable | {
"avatar_url": "https://avatars.githubusercontent.com/u/3167253?v=4",
"events_url": "https://api.github.com/users/kmadac/events{/privacy}",
"followers_url": "https://api.github.com/users/kmadac/followers",
"following_url": "https://api.github.com/users/kmadac/following{/other_user}",
"gists_url": "https://api.github.com/users/kmadac/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kmadac",
"id": 3167253,
"login": "kmadac",
"node_id": "MDQ6VXNlcjMxNjcyNTM=",
"organizations_url": "https://api.github.com/users/kmadac/orgs",
"received_events_url": "https://api.github.com/users/kmadac/received_events",
"repos_url": "https://api.github.com/users/kmadac/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kmadac/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kmadac/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kmadac",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-12-02T21:55:18Z | 2021-09-08T23:07:17Z | 2013-12-05T22:40:44Z | CONTRIBUTOR | resolved | Hello,
During OpenStack implementation we found out that it is not possible to use IP ranges in no_proxy environment variable. We needed to exclude whole range of IP addresses (172.28.1.0/24), not only domain names or particular IP addresses.
Now it is possible to specify no_proxy like
```
no_proxy=127.0.0.1,192.168.0.0/24
```
and request to http://192.168.0.20:5000/ won't go through http proxy.
I added tests for no_proxy function as well.
Kamil
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1770/reactions"
} | https://api.github.com/repos/psf/requests/issues/1770/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1770.diff",
"html_url": "https://github.com/psf/requests/pull/1770",
"merged_at": "2013-12-05T22:40:44Z",
"patch_url": "https://github.com/psf/requests/pull/1770.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1770"
} | true | [
"Hi Kamil, thanks for this work! Unfortunately, there are a number of problems that would need to be addressed before we could merge this pull request.\n1. You've checked in an Intellij IDEA file, `.idea/dictionaries/kmadac.xml`. This needs to be removed.\n2. `netaddr` is a third-party module that isn't part of the... |
https://api.github.com/repos/psf/requests/issues/1769 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1769/labels{/name} | https://api.github.com/repos/psf/requests/issues/1769/comments | https://api.github.com/repos/psf/requests/issues/1769/events | https://github.com/psf/requests/issues/1769 | 23,563,843 | MDU6SXNzdWUyMzU2Mzg0Mw== | 1,769 | Requests failing over integer in cookie | {
"avatar_url": "https://avatars.githubusercontent.com/u/2722815?v=4",
"events_url": "https://api.github.com/users/CarstVaartjes/events{/privacy}",
"followers_url": "https://api.github.com/users/CarstVaartjes/followers",
"following_url": "https://api.github.com/users/CarstVaartjes/following{/other_user}",
"gists_url": "https://api.github.com/users/CarstVaartjes/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/CarstVaartjes",
"id": 2722815,
"login": "CarstVaartjes",
"node_id": "MDQ6VXNlcjI3MjI4MTU=",
"organizations_url": "https://api.github.com/users/CarstVaartjes/orgs",
"received_events_url": "https://api.github.com/users/CarstVaartjes/received_events",
"repos_url": "https://api.github.com/users/CarstVaartjes/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/CarstVaartjes/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/CarstVaartjes/subscriptions",
"type": "User",
"url": "https://api.github.com/users/CarstVaartjes",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-12-02T10:35:37Z | 2021-09-09T00:34:14Z | 2013-12-02T10:46:54Z | NONE | resolved | Hi,
I described it here:
http://stackoverflow.com/questions/20325571/python-requests-failing-over-integer-in-cookie
But basically this creates an error:
```
import requests
r = requests.get('http://www.c1000.nl/kies-uw-winkel.aspx')
...
File "/srv/www/li/venv/local/lib/python2.7/site-packages/requests/cookies.py", line 270, in set_cookie
if cookie.value.startswith('"') and cookie.value.endswith('"'):
AttributeError: 'int' object has no attribute 'startswith'
```
Is this a known issue? Is there any workaround? (i.e. do not parse cookies?)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1769/reactions"
} | https://api.github.com/repos/psf/requests/issues/1769/timeline | null | completed | null | null | false | [
"Hi there!\n\nFirst, the answer. Yes, this is a known issue, and a fix is already present in master.\n\nNow, some notes. Asking this question on Stack Overflow was exactly the right thing to do. When you do that, please wait more than 30 minutes before moving to this issue tracker. Both I and @sigmavirus24 regularl... |
https://api.github.com/repos/psf/requests/issues/1768 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1768/labels{/name} | https://api.github.com/repos/psf/requests/issues/1768/comments | https://api.github.com/repos/psf/requests/issues/1768/events | https://github.com/psf/requests/pull/1768 | 23,535,179 | MDExOlB1bGxSZXF1ZXN0MTA0MTUwMDg= | 1,768 | Unencode usernames and passwords taken from URLs. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "207de5",
"default": false,
"description": null,
"id": 60620163,
"name": "Minion Seal of Approval",
"node_id": "MDU6TGFiZWw2MDYyMDE2Mw==",
"url": "https://api.github.com/repos/psf/requests/labels/Minion%20Seal%20of%20Approval"
}
] | closed | true | null | [] | null | 2 | 2013-12-01T11:34:25Z | 2021-09-08T23:08:18Z | 2013-12-04T01:36:00Z | MEMBER | resolved | Fixes #1767.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1768/reactions"
} | https://api.github.com/repos/psf/requests/issues/1768/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1768.diff",
"html_url": "https://github.com/psf/requests/pull/1768",
"merged_at": "2013-12-04T01:36:00Z",
"patch_url": "https://github.com/psf/requests/pull/1768.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1768"
} | true | [
":+1:\n",
"good call!\n"
] |
https://api.github.com/repos/psf/requests/issues/1767 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1767/labels{/name} | https://api.github.com/repos/psf/requests/issues/1767/comments | https://api.github.com/repos/psf/requests/issues/1767/events | https://github.com/psf/requests/issues/1767 | 23,533,930 | MDU6SXNzdWUyMzUzMzkzMA== | 1,767 | HTTP Basic Auth credentials extracted from URL are %-encoded | {
"avatar_url": "https://avatars.githubusercontent.com/u/120810?v=4",
"events_url": "https://api.github.com/users/lw/events{/privacy}",
"followers_url": "https://api.github.com/users/lw/followers",
"following_url": "https://api.github.com/users/lw/following{/other_user}",
"gists_url": "https://api.github.com/users/lw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lw",
"id": 120810,
"login": "lw",
"node_id": "MDQ6VXNlcjEyMDgxMA==",
"organizations_url": "https://api.github.com/users/lw/orgs",
"received_events_url": "https://api.github.com/users/lw/received_events",
"repos_url": "https://api.github.com/users/lw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lw",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "5319e7",
"default": false,
"description": null,
"id": 67760318,
... | closed | true | null | [] | null | 2 | 2013-12-01T09:22:15Z | 2021-09-09T00:34:14Z | 2013-12-04T01:36:00Z | NONE | resolved | I was relying on credential auto-extraction from the hostname [1] to perform HTTP Basic Auth but I was getting "401 Unauthorized": the spaces in the password were substituted by `%20`. Manually extracting them with `urlsplit` and passing them to the `auth` parameter as a tuple works.
[1] http://docs.python-requests.org/en/latest/user/authentication/#netrc-authentication (second paragraph)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1767/reactions"
} | https://api.github.com/repos/psf/requests/issues/1767/timeline | null | completed | null | null | false | [
"Hmm, that behaviour feels wrong to me. Probably should fix this. =) Thanks! :cake:\n",
"Thanks for reporting this @lerks \n"
] |
https://api.github.com/repos/psf/requests/issues/1766 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1766/labels{/name} | https://api.github.com/repos/psf/requests/issues/1766/comments | https://api.github.com/repos/psf/requests/issues/1766/events | https://github.com/psf/requests/pull/1766 | 23,480,226 | MDExOlB1bGxSZXF1ZXN0MTAzODg0ODk= | 1,766 | Quote qop values in digest auth. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "207de5",
"default": false,
"description": null,
"id": 60620163,
"name": "Minion Seal of Approval",
"node_id": "MDU6TGFiZWw2MDYyMDE2Mw==",
"url": "https://api.github.com/repos/psf/requests/labels/Minion%20Seal%20of%20Approval"
}
] | closed | true | null | [] | null | 4 | 2013-11-29T08:38:09Z | 2021-09-09T00:01:16Z | 2013-12-04T01:33:59Z | MEMBER | resolved | Resolves #1765.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1766/reactions"
} | https://api.github.com/repos/psf/requests/issues/1766/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1766.diff",
"html_url": "https://github.com/psf/requests/pull/1766",
"merged_at": "2013-12-04T01:33:59Z",
"patch_url": "https://github.com/psf/requests/pull/1766.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1766"
} | true | [
"#1765 was already a PR, why did you open this one? We could have added tests after the fact. Can you rebase this to work off of #1765 so that @bicycle1885 gets some credit?\n",
"Uh, yeah, that's because I'm an idiot and didn't spot it. Like a moron.\n",
"> Uh, yeah, that's because I'm an idiot and didn't spot ... |
https://api.github.com/repos/psf/requests/issues/1765 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1765/labels{/name} | https://api.github.com/repos/psf/requests/issues/1765/comments | https://api.github.com/repos/psf/requests/issues/1765/events | https://github.com/psf/requests/pull/1765 | 23,477,378 | MDExOlB1bGxSZXF1ZXN0MTAzODY5MDM= | 1,765 | quote qop options in Digest Auth | {
"avatar_url": "https://avatars.githubusercontent.com/u/905683?v=4",
"events_url": "https://api.github.com/users/bicycle1885/events{/privacy}",
"followers_url": "https://api.github.com/users/bicycle1885/followers",
"following_url": "https://api.github.com/users/bicycle1885/following{/other_user}",
"gists_url": "https://api.github.com/users/bicycle1885/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bicycle1885",
"id": 905683,
"login": "bicycle1885",
"node_id": "MDQ6VXNlcjkwNTY4Mw==",
"organizations_url": "https://api.github.com/users/bicycle1885/orgs",
"received_events_url": "https://api.github.com/users/bicycle1885/received_events",
"repos_url": "https://api.github.com/users/bicycle1885/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bicycle1885/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bicycle1885/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bicycle1885",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2013-11-29T06:45:00Z | 2021-09-09T00:01:15Z | 2013-11-29T16:47:12Z | CONTRIBUTOR | resolved | Based on RFC2617 (http://tools.ietf.org/html/rfc2617), the value of
'qop-options' directive should be quoted with double quotes:
```
qop-options
This directive is optional, but is made so only for backward
compatibility with RFC 2069 [6]; it SHOULD be used by all
implementations compliant with this version of the Digest
scheme. If present, it is a quoted string of one or more
tokens indicating the "quality of protection" values supported by
the server. The value "auth" indicates authentication; the
value "auth-int" indicates authentication with
integrity protection; see the
```
curl comamnd-line tool also appends these quotes. You can see this
by `curl -v --digest --user user:passwd http://example.com/digest-auth`.
Unfortunately, some minor server-side implementations seem to be sensitive
on this difference.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1765/reactions"
} | https://api.github.com/repos/psf/requests/issues/1765/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1765.diff",
"html_url": "https://github.com/psf/requests/pull/1765",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1765.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1765"
} | true | [
"These are packet dumps from wireshark. Please note the difference of quotes around the value of qop options.\n\ncurl:\n\n```\n0050 69 3f 6d 6f 64 65 3d 31 20 48 54 54 50 2f 31 2e i?mode=1 HTTP/1.\n0060 31 0d 0a 41 75 74 68 6f 72 69 7a 61 74 69 6f 6e 1..Authorization\n0070 3a 20 44 69 67 65 73 74 20 75 73 65... |
https://api.github.com/repos/psf/requests/issues/1764 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1764/labels{/name} | https://api.github.com/repos/psf/requests/issues/1764/comments | https://api.github.com/repos/psf/requests/issues/1764/events | https://github.com/psf/requests/pull/1764 | 23,463,487 | MDExOlB1bGxSZXF1ZXN0MTAzODAxMTg= | 1,764 | Prepare new release (2.1.0)? | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-11-28T18:36:29Z | 2021-09-08T23:07:33Z | 2013-12-04T01:35:02Z | MEMBER | resolved | There are a few nasty bugs that we've fixed since the last release, including the broken SNI support. It'd be good to get another release out. I think a few things have changed dramatically enough that this is probably a minor release (e.g. takes us to 2.1.0). Thoughts? /cc @kennethreitz @sigmavirus24
Still to do:
- [ ] Merge outstanding PRs (definitely ~~#1713, #1657, #1768, and #1766~~; maybe #1729, #1628 and #1743 depending on how @kennethreitz feels).
- [ ] Update changelog to match those PRs.
If nothing else Runscope could do with this release, so it'd be nice to be in good shape.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1764/reactions"
} | https://api.github.com/repos/psf/requests/issues/1764/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1764.diff",
"html_url": "https://github.com/psf/requests/pull/1764",
"merged_at": "2013-12-04T01:35:02Z",
"patch_url": "https://github.com/psf/requests/pull/1764.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1764"
} | true | [
"2.1.0 is a little overdue so I'm :+1:. I'll review the PRs you listed and provide feedback again just to be safe (in case I missed any of them).\n",
"I would say \"definitely\" #1766. That shouldn't be a \"maybe\"\n",
"Looking over the PRs listed above now:\n- #1713 :+1: merge it\n- #1657 :+1: merge it\n- #172... |
https://api.github.com/repos/psf/requests/issues/1763 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1763/labels{/name} | https://api.github.com/repos/psf/requests/issues/1763/comments | https://api.github.com/repos/psf/requests/issues/1763/events | https://github.com/psf/requests/issues/1763 | 23,445,810 | MDU6SXNzdWUyMzQ0NTgxMA== | 1,763 | Requests to a domain name defined in /etc/hosts fails. | {
"avatar_url": "https://avatars.githubusercontent.com/u/229453?v=4",
"events_url": "https://api.github.com/users/Natim/events{/privacy}",
"followers_url": "https://api.github.com/users/Natim/followers",
"following_url": "https://api.github.com/users/Natim/following{/other_user}",
"gists_url": "https://api.github.com/users/Natim/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Natim",
"id": 229453,
"login": "Natim",
"node_id": "MDQ6VXNlcjIyOTQ1Mw==",
"organizations_url": "https://api.github.com/users/Natim/orgs",
"received_events_url": "https://api.github.com/users/Natim/received_events",
"repos_url": "https://api.github.com/users/Natim/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Natim/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Natim/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Natim",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-11-28T11:58:29Z | 2021-09-09T00:34:15Z | 2013-11-28T12:05:57Z | NONE | resolved | ```
~/workspace/venv/local/lib/python2.7/site-packages/requests/api.py line 55 in get
return request('get', url, **kwargs)
~/workspace/venv/local/lib/python2.7/site-packages/requests/api.py line 44 in request
return session.request(method=method, url=url, **kwargs)
~/workspace/venv/local/lib/python2.7/site-packages/requests/sessions.py line 335 in request
resp = self.send(prep, **send_kwargs)
~/workspace/venv/local/lib/python2.7/site-packages/requests/sessions.py line 438 in send
r = adapter.send(request, **kwargs)
~/workspace/venv/local/lib/python2.7/site-packages/requests/adapters.py line 327 in send
raise ConnectionError(e)
ConnectionError: HTTPConnectionPool(host='myserver.dev', port=80): Max retries exceeded with url: /accounts/ (Caused by <class 'socket.gaierror'>: [Errno -2] Name or service not known)
```
`myserver.dev` is defined in `/etc/hosts`
**Edit:** Rewrite bug request.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1763/reactions"
} | https://api.github.com/repos/psf/requests/issues/1763/timeline | null | completed | null | null | false | [
"Why is this a requests bug?\n",
"Ok let me explain it differently. I had the problem before and the fix was to use gevent master. Since gevent has been released, the bug came back.\n",
"Your references were useful, so I'm going to reproduce them here: surfly/gevent#271 and surfly/gevent#21.\n\nBoth of those re... |
https://api.github.com/repos/psf/requests/issues/1762 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1762/labels{/name} | https://api.github.com/repos/psf/requests/issues/1762/comments | https://api.github.com/repos/psf/requests/issues/1762/events | https://github.com/psf/requests/pull/1762 | 23,363,879 | MDExOlB1bGxSZXF1ZXN0MTAzMjQ3OTA= | 1,762 | Update urllib3 to 929f1586 | {
"avatar_url": "https://avatars.githubusercontent.com/u/145979?v=4",
"events_url": "https://api.github.com/users/dstufft/events{/privacy}",
"followers_url": "https://api.github.com/users/dstufft/followers",
"following_url": "https://api.github.com/users/dstufft/following{/other_user}",
"gists_url": "https://api.github.com/users/dstufft/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dstufft",
"id": 145979,
"login": "dstufft",
"node_id": "MDQ6VXNlcjE0NTk3OQ==",
"organizations_url": "https://api.github.com/users/dstufft/orgs",
"received_events_url": "https://api.github.com/users/dstufft/received_events",
"repos_url": "https://api.github.com/users/dstufft/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dstufft/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dstufft/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dstufft",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 1 | 2013-11-27T02:42:29Z | 2021-09-08T23:05:16Z | 2013-11-27T17:23:40Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1762/reactions"
} | https://api.github.com/repos/psf/requests/issues/1762/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1762.diff",
"html_url": "https://github.com/psf/requests/pull/1762",
"merged_at": "2013-11-27T17:23:40Z",
"patch_url": "https://github.com/psf/requests/pull/1762.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1762"
} | true | [
"Always good! :cake:\n"
] | |
https://api.github.com/repos/psf/requests/issues/1761 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1761/labels{/name} | https://api.github.com/repos/psf/requests/issues/1761/comments | https://api.github.com/repos/psf/requests/issues/1761/events | https://github.com/psf/requests/issues/1761 | 23,306,845 | MDU6SXNzdWUyMzMwNjg0NQ== | 1,761 | binary file upload fails with python 2.7 under windows | {
"avatar_url": "https://avatars.githubusercontent.com/u/6039820?v=4",
"events_url": "https://api.github.com/users/kloodf/events{/privacy}",
"followers_url": "https://api.github.com/users/kloodf/followers",
"following_url": "https://api.github.com/users/kloodf/following{/other_user}",
"gists_url": "https://api.github.com/users/kloodf/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kloodf",
"id": 6039820,
"login": "kloodf",
"node_id": "MDQ6VXNlcjYwMzk4MjA=",
"organizations_url": "https://api.github.com/users/kloodf/orgs",
"received_events_url": "https://api.github.com/users/kloodf/received_events",
"repos_url": "https://api.github.com/users/kloodf/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kloodf/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kloodf/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kloodf",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2013-11-26T10:57:13Z | 2021-09-09T00:34:16Z | 2013-11-26T14:17:42Z | NONE | resolved | Following three lines cause a decoding error under windows.
somehow something seems to attempt decoding the binary file contents.
Same code works fine on Linux ( with a real url of course ;-) )
```
#!/usr/bin/env python
import requests
files = { 'file' : ( 'raw.dat', '\xff' ) }
requests.post('http://example.dies.before.url.is.used', files=files)
```
```
c:\tmp>python reqbug.py
Traceback (most recent call last):
File "reqbug.py", line 4, in <module>
requests.post(my_url, files=files)
File "C:\Python27\lib\site-packages\requests\api.py", line 88, in post
return request('post', url, data=data, **kwargs)
File "C:\Python27\lib\site-packages\requests\api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 361, in request
resp = self.send(prep, **send_kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 464, in send
r = adapter.send(request, **kwargs)
File "C:\Python27\lib\site-packages\requests\adapters.py", line 321, in send
timeout=timeout
File "C:\Python27\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 471, in urlopen
body=body, headers=headers)
File "C:\Python27\lib\site-packages\requests\packages\urllib3\connectionpool.py", line 285, in _make_request
conn.request(method, url, **httplib_request_kw)
File "C:\Python27\lib\httplib.py", line 946, in request
self._send_request(method, url, body, headers)
File "C:\Python27\lib\httplib.py", line 987, in _send_request
self.endheaders(body)
File "C:\Python27\lib\httplib.py", line 940, in endheaders
self._send_output(message_body)
File "C:\Python27\lib\httplib.py", line 801, in _send_output
msg += message_body
UnicodeDecodeError: 'ascii' codec can't decode byte 0xff in position 103: ordinal not in range(128)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1761/reactions"
} | https://api.github.com/repos/psf/requests/issues/1761/timeline | null | completed | null | null | false | [
"Not for me it doesn't: Windows 7, Python 2.7.4, Requests 2.0.1. Can you provide the versions of all of your software as well?\n",
"By the way, the overwhelming cause of this is having a unicode string as either the method or in the headers. Make sure that you don't do either of those things. =)\n",
"d:\\work\\... |
https://api.github.com/repos/psf/requests/issues/1760 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1760/labels{/name} | https://api.github.com/repos/psf/requests/issues/1760/comments | https://api.github.com/repos/psf/requests/issues/1760/events | https://github.com/psf/requests/pull/1760 | 23,245,156 | MDExOlB1bGxSZXF1ZXN0MTAyNjEwMDI= | 1,760 | Fix hangs on streaming uploads with HTTPDigestAuth | {
"avatar_url": "https://avatars.githubusercontent.com/u/53781?v=4",
"events_url": "https://api.github.com/users/akitada/events{/privacy}",
"followers_url": "https://api.github.com/users/akitada/followers",
"following_url": "https://api.github.com/users/akitada/following{/other_user}",
"gists_url": "https://api.github.com/users/akitada/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/akitada",
"id": 53781,
"login": "akitada",
"node_id": "MDQ6VXNlcjUzNzgx",
"organizations_url": "https://api.github.com/users/akitada/orgs",
"received_events_url": "https://api.github.com/users/akitada/received_events",
"repos_url": "https://api.github.com/users/akitada/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/akitada/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akitada/subscriptions",
"type": "User",
"url": "https://api.github.com/users/akitada",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 2 | 2013-11-25T14:26:36Z | 2021-09-08T23:05:27Z | 2013-11-25T19:40:10Z | CONTRIBUTOR | resolved | When using Digest Authentication, the client resends the same request
after the server responds with the 401 "Unauthorized". However, when
doing streaming uploads, it gets stuck because the body data (a
file-like object) is already consumed at the initial request.
The patch fixes this by rewinding the file-like object before
resending the request.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1760/reactions"
} | https://api.github.com/repos/psf/requests/issues/1760/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1760.diff",
"html_url": "https://github.com/psf/requests/pull/1760",
"merged_at": "2013-11-25T19:40:10Z",
"patch_url": "https://github.com/psf/requests/pull/1760.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1760"
} | true | [
"This fixes #1755\n",
"LGTM. Thanks for this! :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/1759 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1759/labels{/name} | https://api.github.com/repos/psf/requests/issues/1759/comments | https://api.github.com/repos/psf/requests/issues/1759/events | https://github.com/psf/requests/issues/1759 | 23,235,742 | MDU6SXNzdWUyMzIzNTc0Mg== | 1,759 | builtin_str in python2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/747262?v=4",
"events_url": "https://api.github.com/users/nahuelange/events{/privacy}",
"followers_url": "https://api.github.com/users/nahuelange/followers",
"following_url": "https://api.github.com/users/nahuelange/following{/other_user}",
"gists_url": "https://api.github.com/users/nahuelange/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nahuelange",
"id": 747262,
"login": "nahuelange",
"node_id": "MDQ6VXNlcjc0NzI2Mg==",
"organizations_url": "https://api.github.com/users/nahuelange/orgs",
"received_events_url": "https://api.github.com/users/nahuelange/received_events",
"repos_url": "https://api.github.com/users/nahuelange/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nahuelange/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nahuelange/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nahuelange",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-11-25T11:18:58Z | 2021-09-09T00:34:16Z | 2013-11-25T14:51:00Z | NONE | resolved | builtin_str should be defined as unicode for py2 version OR in models.py (line 107) don't re-encode data.
When passing files & datas, datas are réencoded from unicode to str, and raise an UnicodeEncodeError.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/747262?v=4",
"events_url": "https://api.github.com/users/nahuelange/events{/privacy}",
"followers_url": "https://api.github.com/users/nahuelange/followers",
"following_url": "https://api.github.com/users/nahuelange/following{/other_user}",
"gists_url": "https://api.github.com/users/nahuelange/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nahuelange",
"id": 747262,
"login": "nahuelange",
"node_id": "MDQ6VXNlcjc0NzI2Mg==",
"organizations_url": "https://api.github.com/users/nahuelange/orgs",
"received_events_url": "https://api.github.com/users/nahuelange/received_events",
"repos_url": "https://api.github.com/users/nahuelange/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nahuelange/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nahuelange/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nahuelange",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1759/reactions"
} | https://api.github.com/repos/psf/requests/issues/1759/timeline | null | completed | null | null | false | [
"`builtin_str` means literally natural `str` type of python. So, there is no reason that `builtin_str` should be defined as `unicode` in python2.\nCan you explain in detail about how you passed data to `requests`?\n",
"It's not clear to me what your problem is here. You've provided fixes, but not indicated what t... |
https://api.github.com/repos/psf/requests/issues/1757 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1757/labels{/name} | https://api.github.com/repos/psf/requests/issues/1757/comments | https://api.github.com/repos/psf/requests/issues/1757/events | https://github.com/psf/requests/issues/1757 | 23,213,540 | MDU6SXNzdWUyMzIxMzU0MA== | 1,757 | partial download using range header not working | {
"avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4",
"events_url": "https://api.github.com/users/ghost/events{/privacy}",
"followers_url": "https://api.github.com/users/ghost/followers",
"following_url": "https://api.github.com/users/ghost/following{/other_user}",
"gists_url": "https://api.github.com/users/ghost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ghost",
"id": 10137,
"login": "ghost",
"node_id": "MDQ6VXNlcjEwMTM3",
"organizations_url": "https://api.github.com/users/ghost/orgs",
"received_events_url": "https://api.github.com/users/ghost/received_events",
"repos_url": "https://api.github.com/users/ghost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ghost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ghost",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2013-11-24T21:42:18Z | 2021-09-09T00:34:15Z | 2013-11-27T06:45:07Z | NONE | resolved | This is supposed to download a partial chunk of the URL (bytes 1000 to 2000)
```
target = 'http://10.0.0.10/words.txt'
headers = {'Range':'bytes=1000-2000'}
r = requests.get (target, headers=headers)
print r.text
```
It's not working and I get the whole file.
It does however work with the standard library's urllib2. I believe the problem is in the way requests is sending the request, since the server's logs show a difference in the response code.
The full code and some server configuration information here (I've tried the commented out things). I've also shown the code I use for urllib2.
http://bpaste.net/show/dWrjTbxBZKRxjSGZEma7/
I am using 2.0.1 of requests.
```
>>> import requests
>>> requests.__version__
'2.0.1'
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1757/reactions"
} | https://api.github.com/repos/psf/requests/issues/1757/timeline | null | completed | null | null | false | [
"I suspect the server is at fault here.\n\n``` python\n>>> import requests\n>>> url = 'http://mirrors.manchester.m247.com/ubuntu-releases//precise/ubuntu-12.04.3-desktop-amd64.iso'\n>>> r = requests.get(url, headers={'Range': 'bytes=1000-2000'}, stream=True)\n>>> r.status_code\n206\n```\n\nIf you believe the differ... |
https://api.github.com/repos/psf/requests/issues/1756 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1756/labels{/name} | https://api.github.com/repos/psf/requests/issues/1756/comments | https://api.github.com/repos/psf/requests/issues/1756/events | https://github.com/psf/requests/issues/1756 | 23,209,412 | MDU6SXNzdWUyMzIwOTQxMg== | 1,756 | import error if ndg-httpsclient and pyasn1 are installed | {
"avatar_url": "https://avatars.githubusercontent.com/u/662249?v=4",
"events_url": "https://api.github.com/users/dimaqq/events{/privacy}",
"followers_url": "https://api.github.com/users/dimaqq/followers",
"following_url": "https://api.github.com/users/dimaqq/following{/other_user}",
"gists_url": "https://api.github.com/users/dimaqq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dimaqq",
"id": 662249,
"login": "dimaqq",
"node_id": "MDQ6VXNlcjY2MjI0OQ==",
"organizations_url": "https://api.github.com/users/dimaqq/orgs",
"received_events_url": "https://api.github.com/users/dimaqq/received_events",
"repos_url": "https://api.github.com/users/dimaqq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dimaqq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dimaqq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dimaqq",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-11-24T17:50:02Z | 2021-09-09T00:34:17Z | 2013-11-24T17:51:54Z | NONE | resolved | Supposedly these dependencies are needed for SNI support in python2.
However requests doesn't even import when these dependencies are installed.
virtualenv-2.7 testX; . testX/bin/activate
pip install ipython requests ndg-httpsclient pyasn1
```
In [1]: import requests
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
<ipython-input-1-686486c241c8> in <module>()
----> 1 import requests
/Users/dima/testr/testX/lib/python2.7/site-packages/requests/__init__.py in <module>()
51 # Attempt to enable urllib3's SNI support, if possible
52 try:
---> 53 from .packages.urllib3.contrib import pyopenssl
54 pyopenssl.inject_into_urllib3()
55 except ImportError:
/Users/dima/testr/testX/lib/python2.7/site-packages/requests/packages/urllib3/contrib/pyopenssl.py in <module>()
53
54 orig_util_HAS_SNI = util.HAS_SNI
---> 55 orig_connectionpool_ssl_wrap_socket = connectionpool.ssl_wrap_socket
56
57
AttributeError: 'module' object has no attribute 'ssl_wrap_socket'
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1756/reactions"
} | https://api.github.com/repos/psf/requests/issues/1756/timeline | null | completed | null | null | false | [
"Please check the open issues before you raise one. This is being tracked in #1732.\n",
"thanks for catching this. glad to see it already got some attention!\n"
] |
https://api.github.com/repos/psf/requests/issues/1755 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1755/labels{/name} | https://api.github.com/repos/psf/requests/issues/1755/comments | https://api.github.com/repos/psf/requests/issues/1755/events | https://github.com/psf/requests/issues/1755 | 23,204,417 | MDU6SXNzdWUyMzIwNDQxNw== | 1,755 | Streaming uploads with HTTPBasicAuth causes stuck on resending the request | {
"avatar_url": "https://avatars.githubusercontent.com/u/53781?v=4",
"events_url": "https://api.github.com/users/akitada/events{/privacy}",
"followers_url": "https://api.github.com/users/akitada/followers",
"following_url": "https://api.github.com/users/akitada/following{/other_user}",
"gists_url": "https://api.github.com/users/akitada/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/akitada",
"id": 53781,
"login": "akitada",
"node_id": "MDQ6VXNlcjUzNzgx",
"organizations_url": "https://api.github.com/users/akitada/orgs",
"received_events_url": "https://api.github.com/users/akitada/received_events",
"repos_url": "https://api.github.com/users/akitada/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/akitada/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/akitada/subscriptions",
"type": "User",
"url": "https://api.github.com/users/akitada",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "5319e7",
"default": false,
"description": null,
"id": 67760318,
... | closed | true | null | [] | null | 5 | 2013-11-24T12:30:06Z | 2021-09-09T00:28:34Z | 2013-12-05T23:04:56Z | CONTRIBUTOR | resolved | `HTTPBasicAuth` seems to have the same issue described in requests/requests-kerberos#23.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1755/reactions"
} | https://api.github.com/repos/psf/requests/issues/1755/timeline | null | completed | null | null | false | [
"Resolved by #1760\n",
"@akitada please don't close your own issues. We'll close them when we are ready to.\n",
"Oh, sorry! I'm not familiar with the process.\n",
"No need to apologize @akitada \n",
"Fixed in 2.1.0.\n"
] |
https://api.github.com/repos/psf/requests/issues/1754 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1754/labels{/name} | https://api.github.com/repos/psf/requests/issues/1754/comments | https://api.github.com/repos/psf/requests/issues/1754/events | https://github.com/psf/requests/pull/1754 | 23,203,552 | MDExOlB1bGxSZXF1ZXN0MTAyNDEzNjU= | 1,754 | Match the HTTPbis on HTTP 301. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "207de5",
"default": false,
"description": null,
"id": 60620163,
"name": "Minion Seal of Approval",
"node_id": "MDU6TGFiZWw2MDYyMDE2Mw==",
"url": "https://api.github.com/repos/psf/requests/labels/Minion%20Seal%20of%20Approval"
}
] | closed | true | null | [] | null | 1 | 2013-11-24T11:20:20Z | 2021-09-08T23:05:26Z | 2013-11-25T19:40:00Z | MEMBER | resolved | See the discussion on issue #1704.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1754/reactions"
} | https://api.github.com/repos/psf/requests/issues/1754/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1754.diff",
"html_url": "https://github.com/psf/requests/pull/1754",
"merged_at": "2013-11-25T19:40:00Z",
"patch_url": "https://github.com/psf/requests/pull/1754.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1754"
} | true | [
":+1:\n"
] |
https://api.github.com/repos/psf/requests/issues/1753 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1753/labels{/name} | https://api.github.com/repos/psf/requests/issues/1753/comments | https://api.github.com/repos/psf/requests/issues/1753/events | https://github.com/psf/requests/issues/1753 | 23,193,409 | MDU6SXNzdWUyMzE5MzQwOQ== | 1,753 | Support method to gzip or otherwise compress HTTP request body? | {
"avatar_url": "https://avatars.githubusercontent.com/u/77864?v=4",
"events_url": "https://api.github.com/users/dkador/events{/privacy}",
"followers_url": "https://api.github.com/users/dkador/followers",
"following_url": "https://api.github.com/users/dkador/following{/other_user}",
"gists_url": "https://api.github.com/users/dkador/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dkador",
"id": 77864,
"login": "dkador",
"node_id": "MDQ6VXNlcjc3ODY0",
"organizations_url": "https://api.github.com/users/dkador/orgs",
"received_events_url": "https://api.github.com/users/dkador/received_events",
"repos_url": "https://api.github.com/users/dkador/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dkador/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dkador/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dkador",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2013-11-23T20:22:39Z | 2018-08-31T22:42:22Z | 2013-11-27T02:24:26Z | NONE | resolved | It doesn't appear that requests currently supports any built-in mechanism for automatically compressing a given HTTP body payload (e.g. JSON). Correct me if I missed something terribly obvious here, and apologies if I did.
I could certainly just implement the compression part myself, but I was wondering if the requests community thinks that a feature like this would be useful in general or is too specific to each integration's problem domain and so should remain there?
If people think this sounds interesting I'd be happy to take a stab at implementing it. Thanks!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/1753/reactions"
} | https://api.github.com/repos/psf/requests/issues/1753/timeline | null | completed | null | null | false | [
"I think it is a good idea to at least have methods for doing this documented (if not packaged in a separate library) but I'm pretty sure it doesn't belong in requests proper. \n",
"Agreed. The fact of the matter is that it isn't very hard to compress a request body yourself, and it's hard to see how we'd have a ... |
https://api.github.com/repos/psf/requests/issues/1752 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1752/labels{/name} | https://api.github.com/repos/psf/requests/issues/1752/comments | https://api.github.com/repos/psf/requests/issues/1752/events | https://github.com/psf/requests/issues/1752 | 23,122,581 | MDU6SXNzdWUyMzEyMjU4MQ== | 1,752 | Fails to make some https connections with PyPy 2.2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-11-22T07:51:22Z | 2021-09-09T00:28:30Z | 2013-12-09T19:12:53Z | CONTRIBUTOR | resolved | This is effecting Pip pretty aggressively.
Also being tracked by PyPy: https://bugs.pypy.org/issue1645
/cc @Lukasa @sigmavirus24
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1752/reactions"
} | https://api.github.com/repos/psf/requests/issues/1752/timeline | null | completed | null | null | false | [
"Are both communities seeing the same bug? Because it looks like Alex fixed it [here](https://bitbucket.org/pypy/pypy/commits/963c6d6d7d6c8cb32d1e338ef620e9edd9e479fa). He's certainly marked it as fixed in the PyPy bug tracker.\n"
] |
https://api.github.com/repos/psf/requests/issues/1751 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1751/labels{/name} | https://api.github.com/repos/psf/requests/issues/1751/comments | https://api.github.com/repos/psf/requests/issues/1751/events | https://github.com/psf/requests/issues/1751 | 23,112,906 | MDU6SXNzdWUyMzExMjkwNg== | 1,751 | Add option to limit response downloads by size. | {
"avatar_url": "https://avatars.githubusercontent.com/u/23648?v=4",
"events_url": "https://api.github.com/users/skorokithakis/events{/privacy}",
"followers_url": "https://api.github.com/users/skorokithakis/followers",
"following_url": "https://api.github.com/users/skorokithakis/following{/other_user}",
"gists_url": "https://api.github.com/users/skorokithakis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/skorokithakis",
"id": 23648,
"login": "skorokithakis",
"node_id": "MDQ6VXNlcjIzNjQ4",
"organizations_url": "https://api.github.com/users/skorokithakis/orgs",
"received_events_url": "https://api.github.com/users/skorokithakis/received_events",
"repos_url": "https://api.github.com/users/skorokithakis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/skorokithakis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skorokithakis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/skorokithakis",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 19 | 2013-11-22T01:55:19Z | 2021-09-09T00:10:00Z | 2013-11-22T08:29:38Z | NONE | resolved | Would it be possible to add a "limit" argument that will limit downloads to a certain size? I want my users to be able to make requests to URLs, but I don't want them to download gigabytes through them, I want the request to end after, say, 1 KB.
This will complement the "timeout" argument.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/23648?v=4",
"events_url": "https://api.github.com/users/skorokithakis/events{/privacy}",
"followers_url": "https://api.github.com/users/skorokithakis/followers",
"following_url": "https://api.github.com/users/skorokithakis/following{/other_user}",
"gists_url": "https://api.github.com/users/skorokithakis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/skorokithakis",
"id": 23648,
"login": "skorokithakis",
"node_id": "MDQ6VXNlcjIzNjQ4",
"organizations_url": "https://api.github.com/users/skorokithakis/orgs",
"received_events_url": "https://api.github.com/users/skorokithakis/received_events",
"repos_url": "https://api.github.com/users/skorokithakis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/skorokithakis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/skorokithakis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/skorokithakis",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/1751/reactions"
} | https://api.github.com/repos/psf/requests/issues/1751/timeline | null | completed | null | null | false | [
"The API is frozen so the short answer is no.\n\nA longer answer can probably be found on other discussions of this exact same feature. If you want to do this for your users you can use the `stream` parameter and measure what you've downloaded thus far yourself. After you've hit your limit, you can close the connec... |
https://api.github.com/repos/psf/requests/issues/1750 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1750/labels{/name} | https://api.github.com/repos/psf/requests/issues/1750/comments | https://api.github.com/repos/psf/requests/issues/1750/events | https://github.com/psf/requests/issues/1750 | 23,111,514 | MDU6SXNzdWUyMzExMTUxNA== | 1,750 | sessions.request not processing cookies properly | {
"avatar_url": "https://avatars.githubusercontent.com/u/704592?v=4",
"events_url": "https://api.github.com/users/glennbach/events{/privacy}",
"followers_url": "https://api.github.com/users/glennbach/followers",
"following_url": "https://api.github.com/users/glennbach/following{/other_user}",
"gists_url": "https://api.github.com/users/glennbach/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/glennbach",
"id": 704592,
"login": "glennbach",
"node_id": "MDQ6VXNlcjcwNDU5Mg==",
"organizations_url": "https://api.github.com/users/glennbach/orgs",
"received_events_url": "https://api.github.com/users/glennbach/received_events",
"repos_url": "https://api.github.com/users/glennbach/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/glennbach/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/glennbach/subscriptions",
"type": "User",
"url": "https://api.github.com/users/glennbach",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-11-22T01:17:26Z | 2021-09-09T00:34:18Z | 2013-11-22T01:34:12Z | NONE | resolved | we do a post, passing the cookies from the previous response as the cookies:
requests.post(...,cookies=resp.cookies...)
the request function of the Session class appears to be presuming the cookies are always a dict, even though the comments indicate it could also be a cookiejar.
self.cookies = cookiejar_from_dict(cookies, cookiejar=self.cookies, overwrite=False)
the only way we can get it to work is if we use:
requests.post(...,cookies=resp.cookies.get_dict...)
Thanks
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1750/reactions"
} | https://api.github.com/repos/psf/requests/issues/1750/timeline | null | completed | null | null | false | [
"This is a duplicate of #1711.\n",
"Thanks for reporting it!\n",
"Excellent. Can I get an updated version from git? It doesn’t appear to be in master. I’m seeing other cookie problems, and I’d like to try the latest code.\n\nThanks!\n\nGlenn\n\nOn Nov 21, 2013, at 5:34 PM, Ian Cordasco notifications@github.com ... |
https://api.github.com/repos/psf/requests/issues/1749 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1749/labels{/name} | https://api.github.com/repos/psf/requests/issues/1749/comments | https://api.github.com/repos/psf/requests/issues/1749/events | https://github.com/psf/requests/issues/1749 | 23,094,666 | MDU6SXNzdWUyMzA5NDY2Ng== | 1,749 | The method resolve_redirects should also prepare_auth again so OAuth1 would work | {
"avatar_url": "https://avatars.githubusercontent.com/u/372914?v=4",
"events_url": "https://api.github.com/users/metatoaster/events{/privacy}",
"followers_url": "https://api.github.com/users/metatoaster/followers",
"following_url": "https://api.github.com/users/metatoaster/following{/other_user}",
"gists_url": "https://api.github.com/users/metatoaster/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/metatoaster",
"id": 372914,
"login": "metatoaster",
"node_id": "MDQ6VXNlcjM3MjkxNA==",
"organizations_url": "https://api.github.com/users/metatoaster/orgs",
"received_events_url": "https://api.github.com/users/metatoaster/received_events",
"repos_url": "https://api.github.com/users/metatoaster/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/metatoaster/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/metatoaster/subscriptions",
"type": "User",
"url": "https://api.github.com/users/metatoaster",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-11-21T20:22:21Z | 2021-09-09T00:10:11Z | 2014-02-03T11:01:44Z | NONE | resolved | Whenever a request made with an OAuth1 auth object results in a redirect to a new location, it would then result in the Authorization header becoming invalid (wrong signature) thus making the function provided by `allow_redirect` ultimately useless in the context of an OAuth1 session. A potential fix is to call `prepare_auth` again after the `prepare_cookies` in the `resolve_redirects` loop, but I have no idea what potential side effects are and how to begin writing a test in that gigantic method within a loop so no pull requests from me, for now.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1749/reactions"
} | https://api.github.com/repos/psf/requests/issues/1749/timeline | null | completed | null | null | false | [
"Also this is reported under requests/requests-oauthlib#94.\n",
"So, the initial evaluation is that `prepare_auth` can't be placed there. We throw the authentication object away, we aren't carrying it around. The question is: do we think we should re-evaluate authentication for each new request? If we do, how sho... |
https://api.github.com/repos/psf/requests/issues/1748 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1748/labels{/name} | https://api.github.com/repos/psf/requests/issues/1748/comments | https://api.github.com/repos/psf/requests/issues/1748/events | https://github.com/psf/requests/issues/1748 | 23,054,631 | MDU6SXNzdWUyMzA1NDYzMQ== | 1,748 | Make charade library optional | {
"avatar_url": "https://avatars.githubusercontent.com/u/414336?v=4",
"events_url": "https://api.github.com/users/guettli/events{/privacy}",
"followers_url": "https://api.github.com/users/guettli/followers",
"following_url": "https://api.github.com/users/guettli/following{/other_user}",
"gists_url": "https://api.github.com/users/guettli/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/guettli",
"id": 414336,
"login": "guettli",
"node_id": "MDQ6VXNlcjQxNDMzNg==",
"organizations_url": "https://api.github.com/users/guettli/orgs",
"received_events_url": "https://api.github.com/users/guettli/received_events",
"repos_url": "https://api.github.com/users/guettli/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/guettli/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guettli/subscriptions",
"type": "User",
"url": "https://api.github.com/users/guettli",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-11-21T09:44:57Z | 2021-09-09T00:34:18Z | 2013-11-21T11:27:46Z | NONE | resolved | The charade library in the packages directory is quite big (500kByte)
It is only needed if you give a response not encoding. I think this is an error in the code which uses the request library.
Zen of Python "In the face of ambiguity, refuse the temptation to guess."
I think the library should be optional, and not in this repository.
I prefer an exception, if I don't give encoding, since I would get this exception during development.
With the current implementation the guess could be good during development, and wrong in the live system.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1748/reactions"
} | https://api.github.com/repos/psf/requests/issues/1748/timeline | null | completed | null | null | false | [
"Charade _is_ optional. As you've spotted, if you set the encoding yourself, we won't use it.\n\nAs for making the charade download itself optional, that doesn't fit Requests' policy of making the common use case easy. We're strongly disinclined to force people to go out and download charade to make encoding guessi... |
https://api.github.com/repos/psf/requests/issues/1747 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1747/labels{/name} | https://api.github.com/repos/psf/requests/issues/1747/comments | https://api.github.com/repos/psf/requests/issues/1747/events | https://github.com/psf/requests/pull/1747 | 22,903,571 | MDExOlB1bGxSZXF1ZXN0MTAwODQyMDg= | 1,747 | #1746 don't lowercase the whole url | {
"avatar_url": "https://avatars.githubusercontent.com/u/3482660?v=4",
"events_url": "https://api.github.com/users/daftshady/events{/privacy}",
"followers_url": "https://api.github.com/users/daftshady/followers",
"following_url": "https://api.github.com/users/daftshady/following{/other_user}",
"gists_url": "https://api.github.com/users/daftshady/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/daftshady",
"id": 3482660,
"login": "daftshady",
"node_id": "MDQ6VXNlcjM0ODI2NjA=",
"organizations_url": "https://api.github.com/users/daftshady/orgs",
"received_events_url": "https://api.github.com/users/daftshady/received_events",
"repos_url": "https://api.github.com/users/daftshady/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/daftshady/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/daftshady/subscriptions",
"type": "User",
"url": "https://api.github.com/users/daftshady",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 3 | 2013-11-19T11:01:25Z | 2021-09-08T23:06:26Z | 2013-11-20T09:05:15Z | CONTRIBUTOR | resolved | #1746
Modified adapters not to lowercase the whole url.
Because `urlparse` automatically makes scheme lowercase, `scheme.lower()` is unnecessary.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1747/reactions"
} | https://api.github.com/repos/psf/requests/issues/1747/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1747.diff",
"html_url": "https://github.com/psf/requests/pull/1747",
"merged_at": "2013-11-20T09:05:15Z",
"patch_url": "https://github.com/psf/requests/pull/1747.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1747"
} | true | [
"Heh, so it does. Good spot!\n\nI'm happy with this, :+1:.\n",
"Not sure if this is useful, but in the course of investigating urlparse/ursplit for my own purposes, I thought an explicit comment here might be good for the long term -- the standard library docs don't seem to mention at all that urlparse/urlsplit l... |
https://api.github.com/repos/psf/requests/issues/1746 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1746/labels{/name} | https://api.github.com/repos/psf/requests/issues/1746/comments | https://api.github.com/repos/psf/requests/issues/1746/events | https://github.com/psf/requests/issues/1746 | 22,895,987 | MDU6SXNzdWUyMjg5NTk4Nw== | 1,746 | Don't lowercase the whole URL when opening a connection | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "5319e7",
"default": false,
"description": null,
"id": 67760318,
... | closed | true | null | [] | null | 8 | 2013-11-19T08:53:32Z | 2021-09-09T00:28:34Z | 2013-12-05T23:05:08Z | MEMBER | resolved | As mentioned [here](https://github.com/kennethreitz/requests/commit/01993d21dc7d6fa8f0acf657425d2fead9b2ddea).
The specific line of code in question is [here](https://github.com/kennethreitz/requests/blob/master/requests/adapters.py#L209). We're lowercasing the whole URL. This _should_ be fine, but in practice there are clearly servers that will expect the `Host` header to match a specific case (because they're stupid).
We should fix this, especially as fixing it is so easy (we only want to lowercase the scheme) and doesn't hurt us at all.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1746/reactions"
} | https://api.github.com/repos/psf/requests/issues/1746/timeline | null | completed | null | null | false | [
"I agree; it probably should have just been an URL with lowered() scheme, leaving the rest intact. My apologies for this.\n",
"@ViktorHaag we will never forgive you. You've broken requests in such an irreparable way that you are banned for life. (I'm kidding of course. It isn't a big deal at all. We all make mist... |
https://api.github.com/repos/psf/requests/issues/1745 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1745/labels{/name} | https://api.github.com/repos/psf/requests/issues/1745/comments | https://api.github.com/repos/psf/requests/issues/1745/events | https://github.com/psf/requests/pull/1745 | 22,869,125 | MDExOlB1bGxSZXF1ZXN0MTAwNjY2MDM= | 1,745 | Small fix broken cookie parse | {
"avatar_url": "https://avatars.githubusercontent.com/u/5973312?v=4",
"events_url": "https://api.github.com/users/nonm/events{/privacy}",
"followers_url": "https://api.github.com/users/nonm/followers",
"following_url": "https://api.github.com/users/nonm/following{/other_user}",
"gists_url": "https://api.github.com/users/nonm/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nonm",
"id": 5973312,
"login": "nonm",
"node_id": "MDQ6VXNlcjU5NzMzMTI=",
"organizations_url": "https://api.github.com/users/nonm/orgs",
"received_events_url": "https://api.github.com/users/nonm/received_events",
"repos_url": "https://api.github.com/users/nonm/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nonm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nonm/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nonm",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-11-18T21:35:38Z | 2021-09-08T23:06:19Z | 2013-11-20T08:58:21Z | CONTRIBUTOR | resolved | Code:
``` python
import requests
resp = requests.get('http://www.servanegaxotte.com')
# or khvigra.ru, nastersrl.ru, spcentre2000.ru etc.
```
Raised exception:
```
File "C:\Python27\lib\cookielib.py", line 1645, in extract_cookies
self.set_cookie(cookie)
File "C:\Python27\lib\site-packages\requests\cookies.py", line 270, in set_cookie
if cookie.value.startswith('"') and cookie.value.endswith('"'):
AttributeError: 'NoneType' object has no attribute 'startswith'
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1745/reactions"
} | https://api.github.com/repos/psf/requests/issues/1745/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1745.diff",
"html_url": "https://github.com/psf/requests/pull/1745",
"merged_at": "2013-11-20T08:58:21Z",
"patch_url": "https://github.com/psf/requests/pull/1745.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1745"
} | true | [
"IMHO, is it better to check whether `cookie.value` is not None or catching AttributeError instead of using `hasattr`?\n",
"Ordinary I'd insist on catching `AttributeError`. However, because of short-circuit logical evaluation, in this case I think `hasattr` is the better way to go.\n",
" :sparkles: :cookie: :... |
https://api.github.com/repos/psf/requests/issues/1744 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1744/labels{/name} | https://api.github.com/repos/psf/requests/issues/1744/comments | https://api.github.com/repos/psf/requests/issues/1744/events | https://github.com/psf/requests/issues/1744 | 22,831,484 | MDU6SXNzdWUyMjgzMTQ4NA== | 1,744 | Upgrade to 2.0.1 breaks existing code wherever cookies are passed as keyword arguments. | {
"avatar_url": "https://avatars.githubusercontent.com/u/3863128?v=4",
"events_url": "https://api.github.com/users/auworkshare/events{/privacy}",
"followers_url": "https://api.github.com/users/auworkshare/followers",
"following_url": "https://api.github.com/users/auworkshare/following{/other_user}",
"gists_url": "https://api.github.com/users/auworkshare/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/auworkshare",
"id": 3863128,
"login": "auworkshare",
"node_id": "MDQ6VXNlcjM4NjMxMjg=",
"organizations_url": "https://api.github.com/users/auworkshare/orgs",
"received_events_url": "https://api.github.com/users/auworkshare/received_events",
"repos_url": "https://api.github.com/users/auworkshare/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/auworkshare/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/auworkshare/subscriptions",
"type": "User",
"url": "https://api.github.com/users/auworkshare",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2013-11-18T12:29:48Z | 2021-09-09T00:34:19Z | 2013-11-18T15:46:30Z | NONE | resolved | We use request to run regression tests on restful services.
I upgraded to 2.0.1 now I get a Keyword error , wherever cookies are passed as keyword arguments.
Simple stacktrace:
self.result = requests.get(url, params=params, headers={'content-type':'application/json'}, cookies=self.cookies)
KeyError("name=Cookie(version=0, name='qa_session_id', value='e32393932842fba755d57f359ac1b0ae', port=None, port_specified=False, domain='.workshare.com', domain_specified=True, domain_initial_dot=True, path='/', path_specified=True, secure=True, expires=None, discard=True, comment=None, comment_url=None, rest={'HttpOnly': None}, rfc2109=False), domain=None, path=None",)
Error in C:\Users\automation\FeatureTest\libraries\ApiAutomation.py on line 177
Error in C:\Users\automation\FeatureTest\libraries\RequestsSupport.py on line 44
Error in C:\PYTHON27\lib\site-packages\requests\api.py on line 55
Error in C:\PYTHON27\lib\site-packages\requests\api.py on line 44
Error in C:\PYTHON27\lib\site-packages\requests\sessions.py on line 327
Error in C:\PYTHON27\lib\site-packages\requests\cookies.py on line 410
Error in C:\PYTHON27\lib\site-packages\requests\cookies.py on line 256
Error in C:\PYTHON27\lib\site-packages\requests\cookies.py on line 311
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1744/reactions"
} | https://api.github.com/repos/psf/requests/issues/1744/timeline | null | completed | null | null | false | [
"Tell me, is `self.cookies` in your example a `CookieJar`?\n",
"The cookie is obtained from a successful login which is done via requests post .. so whatever object that returns\nBTW I have reverted to version 1.2.3 and everything is working fine again\n\nFrom: Cory Benfield [mailto:notifications@github.com]\n... |
https://api.github.com/repos/psf/requests/issues/1743 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1743/labels{/name} | https://api.github.com/repos/psf/requests/issues/1743/comments | https://api.github.com/repos/psf/requests/issues/1743/events | https://github.com/psf/requests/pull/1743 | 22,821,719 | MDExOlB1bGxSZXF1ZXN0MTAwNDE3MTU= | 1,743 | Separate connect timeouts | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "e11d21",
"default": false,
"descrip... | closed | true | null | [] | null | 11 | 2013-11-18T08:54:49Z | 2021-09-08T23:06:28Z | 2013-12-05T22:29:56Z | CONTRIBUTOR | resolved | Support separate connect timeouts in Requests by allowing you to write something like
``` python
import requests.structures.Timeout
t = Timeout(connect=3, read=7)
requests.get('https://api.twilio.com', timeout=t)
```
Adds tests, docs and some new exceptions for this functionality.
Please note, this kills the current `stream` based branching of timeouts. The `timeout` value applies only to the amount of time between bytes sent by the server. So, if a read timeout is set to 20 seconds and the server streams one byte every 15 seconds, the read timeout will never get hit. This means long streaming downloads are ok and won't hit the read timeout even if it's specified.
It is perfectly valid to set a read timeout on a streaming request - if the request doesn't start streaming in 15 seconds, then raise an error. With the current master, this is impossible.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1743/reactions"
} | https://api.github.com/repos/psf/requests/issues/1743/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1743.diff",
"html_url": "https://github.com/psf/requests/pull/1743",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1743.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1743"
} | true | [
"I'm 100% sitting on the fence here. This is an API change, so we need to see if @kennethreitz likes it or not. =)\n",
"I don't think this is needed, personally. I appreciate the contribution, though.\n\nPerhaps we should automatically enforce the timeout for the first bytes being sent for the stream. Would this ... |
https://api.github.com/repos/psf/requests/issues/1742 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1742/labels{/name} | https://api.github.com/repos/psf/requests/issues/1742/comments | https://api.github.com/repos/psf/requests/issues/1742/events | https://github.com/psf/requests/pull/1742 | 22,812,245 | MDExOlB1bGxSZXF1ZXN0MTAwMzcwMzA= | 1,742 | Add make target to build the documentation | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 2 | 2013-11-18T02:39:07Z | 2021-09-08T11:00:52Z | 2013-11-20T09:02:38Z | CONTRIBUTOR | resolved | Hooray makefiles :)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1742/reactions"
} | https://api.github.com/repos/psf/requests/issues/1742/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1742.diff",
"html_url": "https://github.com/psf/requests/pull/1742",
"merged_at": "2013-11-20T09:02:38Z",
"patch_url": "https://github.com/psf/requests/pull/1742.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1742"
} | true | [
"Sure, why not? :+1:\n",
"this is super cool! thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/1741 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1741/labels{/name} | https://api.github.com/repos/psf/requests/issues/1741/comments | https://api.github.com/repos/psf/requests/issues/1741/events | https://github.com/psf/requests/pull/1741 | 22,785,659 | MDExOlB1bGxSZXF1ZXN0MTAwMjc0MDc= | 1,741 | Significantly reduce library footprint | {
"avatar_url": "https://avatars.githubusercontent.com/u/5554910?v=4",
"events_url": "https://api.github.com/users/lordjabez/events{/privacy}",
"followers_url": "https://api.github.com/users/lordjabez/followers",
"following_url": "https://api.github.com/users/lordjabez/following{/other_user}",
"gists_url": "https://api.github.com/users/lordjabez/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lordjabez",
"id": 5554910,
"login": "lordjabez",
"node_id": "MDQ6VXNlcjU1NTQ5MTA=",
"organizations_url": "https://api.github.com/users/lordjabez/orgs",
"received_events_url": "https://api.github.com/users/lordjabez/received_events",
"repos_url": "https://api.github.com/users/lordjabez/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lordjabez/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lordjabez/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lordjabez",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2013-11-16T21:50:05Z | 2021-09-08T23:05:07Z | 2013-11-16T21:52:44Z | NONE | resolved | Closes #1. Closes #2.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5554910?v=4",
"events_url": "https://api.github.com/users/lordjabez/events{/privacy}",
"followers_url": "https://api.github.com/users/lordjabez/followers",
"following_url": "https://api.github.com/users/lordjabez/following{/other_user}",
"gists_url": "https://api.github.com/users/lordjabez/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lordjabez",
"id": 5554910,
"login": "lordjabez",
"node_id": "MDQ6VXNlcjU1NTQ5MTA=",
"organizations_url": "https://api.github.com/users/lordjabez/orgs",
"received_events_url": "https://api.github.com/users/lordjabez/received_events",
"repos_url": "https://api.github.com/users/lordjabez/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lordjabez/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lordjabez/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lordjabez",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1741/reactions"
} | https://api.github.com/repos/psf/requests/issues/1741/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1741.diff",
"html_url": "https://github.com/psf/requests/pull/1741",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1741.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1741"
} | true | [
"Oops, this was supposed to be a local pull request to my own fork. Sorry!\n",
"Err, what's going on?\n\nEdit: nvm :D \n"
] |
https://api.github.com/repos/psf/requests/issues/1740 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1740/labels{/name} | https://api.github.com/repos/psf/requests/issues/1740/comments | https://api.github.com/repos/psf/requests/issues/1740/events | https://github.com/psf/requests/pull/1740 | 22,745,473 | MDExOlB1bGxSZXF1ZXN0MTAwMDY5MjI= | 1,740 | Added multipart param, to be used in post request (harmless otherwise) | {
"avatar_url": "https://avatars.githubusercontent.com/u/657989?v=4",
"events_url": "https://api.github.com/users/bafio/events{/privacy}",
"followers_url": "https://api.github.com/users/bafio/followers",
"following_url": "https://api.github.com/users/bafio/following{/other_user}",
"gists_url": "https://api.github.com/users/bafio/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bafio",
"id": 657989,
"login": "bafio",
"node_id": "MDQ6VXNlcjY1Nzk4OQ==",
"organizations_url": "https://api.github.com/users/bafio/orgs",
"received_events_url": "https://api.github.com/users/bafio/received_events",
"repos_url": "https://api.github.com/users/bafio/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bafio/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bafio/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bafio",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-11-15T17:12:17Z | 2021-09-08T22:01:05Z | 2013-11-15T17:16:45Z | NONE | resolved | basic usage:
r = requests.post(url, data=data, multipart=True)
it will behave same as
r = requests.post(url, data=data, files={'filename':data})
whithout having ----> ; filename="filename" <----- in the Content-Disposition's multipart body
this somethimes will not be accepted:
Content-Disposition: form-data; name="data"; filename="filename"
this it should:
Content-Disposition: form-data; name="data"
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1740/reactions"
} | https://api.github.com/repos/psf/requests/issues/1740/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1740.diff",
"html_url": "https://github.com/psf/requests/pull/1740",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1740.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1740"
} | true | [
"Thanks for this! However, we are almost never going to accept new parameters in the Requests functional API, especially not ones that are simply True/False. =)\n\nThe expected method for doing what you're trying to do [can be found here](http://stackoverflow.com/a/19974452/1401686). Basically what you want is:\n\n... |
https://api.github.com/repos/psf/requests/issues/1739 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1739/labels{/name} | https://api.github.com/repos/psf/requests/issues/1739/comments | https://api.github.com/repos/psf/requests/issues/1739/events | https://github.com/psf/requests/pull/1739 | 22,734,687 | MDExOlB1bGxSZXF1ZXN0MTAwMDA3Mjc= | 1,739 | add coverage make target | {
"avatar_url": "https://avatars.githubusercontent.com/u/1533151?v=4",
"events_url": "https://api.github.com/users/coldfire-x/events{/privacy}",
"followers_url": "https://api.github.com/users/coldfire-x/followers",
"following_url": "https://api.github.com/users/coldfire-x/following{/other_user}",
"gists_url": "https://api.github.com/users/coldfire-x/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/coldfire-x",
"id": 1533151,
"login": "coldfire-x",
"node_id": "MDQ6VXNlcjE1MzMxNTE=",
"organizations_url": "https://api.github.com/users/coldfire-x/orgs",
"received_events_url": "https://api.github.com/users/coldfire-x/received_events",
"repos_url": "https://api.github.com/users/coldfire-x/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/coldfire-x/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coldfire-x/subscriptions",
"type": "User",
"url": "https://api.github.com/users/coldfire-x",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 3 | 2013-11-15T14:22:03Z | 2021-09-08T22:01:04Z | 2013-11-15T18:51:47Z | CONTRIBUTOR | resolved | [issue 1545](https://github.com/kennethreitz/requests/issues/1545), setup code coverage.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1739/reactions"
} | https://api.github.com/repos/psf/requests/issues/1739/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1739.diff",
"html_url": "https://github.com/psf/requests/pull/1739",
"merged_at": "2013-11-15T18:51:47Z",
"patch_url": "https://github.com/psf/requests/pull/1739.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1739"
} | true | [
"Sweet, this looks reasonable to me. Thanks so much for this! :+1:\n",
"i love py.test :)\n",
"i also love you, @pengfei-xue :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/1738 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1738/labels{/name} | https://api.github.com/repos/psf/requests/issues/1738/comments | https://api.github.com/repos/psf/requests/issues/1738/events | https://github.com/psf/requests/pull/1738 | 22,723,903 | MDExOlB1bGxSZXF1ZXN0OTk5NDQ3MQ== | 1,738 | add coverage make target | {
"avatar_url": "https://avatars.githubusercontent.com/u/1533151?v=4",
"events_url": "https://api.github.com/users/coldfire-x/events{/privacy}",
"followers_url": "https://api.github.com/users/coldfire-x/followers",
"following_url": "https://api.github.com/users/coldfire-x/following{/other_user}",
"gists_url": "https://api.github.com/users/coldfire-x/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/coldfire-x",
"id": 1533151,
"login": "coldfire-x",
"node_id": "MDQ6VXNlcjE1MzMxNTE=",
"organizations_url": "https://api.github.com/users/coldfire-x/orgs",
"received_events_url": "https://api.github.com/users/coldfire-x/received_events",
"repos_url": "https://api.github.com/users/coldfire-x/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/coldfire-x/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coldfire-x/subscriptions",
"type": "User",
"url": "https://api.github.com/users/coldfire-x",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 44501305,
"name": "Not Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTMwNQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Not%20Ready%20To%20Merge"
}
] | closed | true | null | [] | null | 2 | 2013-11-15T10:16:41Z | 2021-09-08T23:05:11Z | 2013-11-15T14:24:16Z | CONTRIBUTOR | resolved | [issue 1545](https://github.com/kennethreitz/requests/issues/1545), setup code coverage.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1533151?v=4",
"events_url": "https://api.github.com/users/coldfire-x/events{/privacy}",
"followers_url": "https://api.github.com/users/coldfire-x/followers",
"following_url": "https://api.github.com/users/coldfire-x/following{/other_user}",
"gists_url": "https://api.github.com/users/coldfire-x/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/coldfire-x",
"id": 1533151,
"login": "coldfire-x",
"node_id": "MDQ6VXNlcjE1MzMxNTE=",
"organizations_url": "https://api.github.com/users/coldfire-x/orgs",
"received_events_url": "https://api.github.com/users/coldfire-x/received_events",
"repos_url": "https://api.github.com/users/coldfire-x/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/coldfire-x/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/coldfire-x/subscriptions",
"type": "User",
"url": "https://api.github.com/users/coldfire-x",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1738/reactions"
} | https://api.github.com/repos/psf/requests/issues/1738/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1738.diff",
"html_url": "https://github.com/psf/requests/pull/1738",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1738.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1738"
} | true | [
"Can you rebase against master? Some pull requests got accepted this morning that mean your `requirements.txt` is out of date. =)\n",
"@Lukasa i created another pull reuqest, please close this out thanks.\n"
] |
https://api.github.com/repos/psf/requests/issues/1737 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1737/labels{/name} | https://api.github.com/repos/psf/requests/issues/1737/comments | https://api.github.com/repos/psf/requests/issues/1737/events | https://github.com/psf/requests/issues/1737 | 22,655,515 | MDU6SXNzdWUyMjY1NTUxNQ== | 1,737 | [Suggestion] Simplify charset handling | {
"avatar_url": "https://avatars.githubusercontent.com/u/142512?v=4",
"events_url": "https://api.github.com/users/itsadok/events{/privacy}",
"followers_url": "https://api.github.com/users/itsadok/followers",
"following_url": "https://api.github.com/users/itsadok/following{/other_user}",
"gists_url": "https://api.github.com/users/itsadok/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/itsadok",
"id": 142512,
"login": "itsadok",
"node_id": "MDQ6VXNlcjE0MjUxMg==",
"organizations_url": "https://api.github.com/users/itsadok/orgs",
"received_events_url": "https://api.github.com/users/itsadok/received_events",
"repos_url": "https://api.github.com/users/itsadok/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/itsadok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itsadok/subscriptions",
"type": "User",
"url": "https://api.github.com/users/itsadok",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "eb6420",
"default": false,
"descrip... | open | false | null | [] | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 6 | 2013-11-14T10:56:19Z | 2014-10-05T17:26:54Z | null | CONTRIBUTOR | null | To cut to the chase, here are my suggestions:
- Remove automatic character set detection (charade) from the library
- Have response.encoding represent the charset from the Content-Type header
- Mention the caveat in the documentation
### Long version
There seems to be a lot of confusion regarding how the `.text` property works. After getting into some trouble with it myself, I searched the issues list, and found a dozen or so issues, all boiling down to the same mismatch between users' expectations and the intent of the library designers.
#147 - bytecode string returned when page has charset=UTF-8
#156 - get_unicode_from_response does not check charsets from meta tags
#592 - Internal encoding detection doesn't match external chardet call
#654 - requests.get() ignores charset=UTF-8 and BOM
#765 - Chardet sometimes fails and force the wrong encoding
#861 - parsing encoding utf-8 page doesn't as expected
#1087 - Encodings from content
#1150 - On some pages requests detect encoding incorrectly
#1546 - use a default encoding in Response's text property
#1589 - Make sure content is checked when setting encoding
#1604 - Response.text returns improperly decoded text
#1683 - models.text Behaviour (encoding choice)
(It must be tiring to have the same conversation over and over again. I hope I'm being helpful here and not just piling on).
The argument seems to be:
- As an HTTP library, requests should not know or care about HTML and META attributes
- RFC 2616 states that if no charset is defined, "text/*" media types should be regarded as ISO-8859-1
I accept both these arguments. However, the documentation seems a bit coy, saying that "Requests makes an educated guess about the encoding", implying chardet/charade. In practice, for any content with a "text" media subtype, charade will not be used unless the user explicitly sets the `response.encoding` to None before reading the `.text` property.
Additionally, while ISO-8859-1 can be used as a default, won't it make more sense to handle that default in `.text` and not in the `get_encoding_from_headers` method? This way, the `encoding` property will be None if indeed no encoding is specified, allowing the user to make the decision on how to proceed.
If you're going to keep the `.text` property, I think it should do a simple decoding if the charset is specified in the headers, and throw an exception otherwise. This way is much less confusing than the state of affairs now. Additionally, the documentation should contain a warning not to use it for arbitrary web pages, and perhaps a code sample showing the proper way to do it.
``` python
import re
import charade
import requests
def get_encodings_from_content(content):
charset_re = re.compile(r'<meta.*?charset=["\']*(.+?)["\'>]', flags=re.I)
pragma_re = re.compile(r'<meta.*?content=["\']*;?charset=(.+?)["\'>]', flags=re.I)
xml_re = re.compile(r'^<\?xml.*?encoding=["\']*(.+?)["\'>]')
# FIXME: Does not work in python 3
return (charset_re.findall(content) +
pragma_re.findall(content) +
xml_re.findall(content))
r = requests.get('https://example.com/page.html')
if "charset" not in r.headers.get("content-type", ""):
encodings = get_encodings_from_content(r.content)
if encodings:
r.encoding = encodings[0]
else:
r.encoding = charade.detect(r.content)['encoding']
html = r.text
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/142512?v=4",
"events_url": "https://api.github.com/users/itsadok/events{/privacy}",
"followers_url": "https://api.github.com/users/itsadok/followers",
"following_url": "https://api.github.com/users/itsadok/following{/other_user}",
"gists_url": "https://api.github.com/users/itsadok/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/itsadok",
"id": 142512,
"login": "itsadok",
"node_id": "MDQ6VXNlcjE0MjUxMg==",
"organizations_url": "https://api.github.com/users/itsadok/orgs",
"received_events_url": "https://api.github.com/users/itsadok/received_events",
"repos_url": "https://api.github.com/users/itsadok/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/itsadok/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/itsadok/subscriptions",
"type": "User",
"url": "https://api.github.com/users/itsadok",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1737/reactions"
} | https://api.github.com/repos/psf/requests/issues/1737/timeline | null | null | null | null | false | [
"You've got lots of good suggestions here. I'll respond to some of them. In no particular order:\n1. `Response.text` should never ever ever ever throw an exception if we can possibly avoid it. Properties throwing exceptions is bad. If we were going to start throwing exceptions from `Response.text` I'd want it to be... |
https://api.github.com/repos/psf/requests/issues/1736 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1736/labels{/name} | https://api.github.com/repos/psf/requests/issues/1736/comments | https://api.github.com/repos/psf/requests/issues/1736/events | https://github.com/psf/requests/issues/1736 | 22,645,627 | MDU6SXNzdWUyMjY0NTYyNw== | 1,736 | Accept per-field headers in multipart POST requests (and create multipart/mixed requests) | {
"avatar_url": "https://avatars.githubusercontent.com/u/141436?v=4",
"events_url": "https://api.github.com/users/JanJakes/events{/privacy}",
"followers_url": "https://api.github.com/users/JanJakes/followers",
"following_url": "https://api.github.com/users/JanJakes/following{/other_user}",
"gists_url": "https://api.github.com/users/JanJakes/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/JanJakes",
"id": 141436,
"login": "JanJakes",
"node_id": "MDQ6VXNlcjE0MTQzNg==",
"organizations_url": "https://api.github.com/users/JanJakes/orgs",
"received_events_url": "https://api.github.com/users/JanJakes/received_events",
"repos_url": "https://api.github.com/users/JanJakes/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/JanJakes/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/JanJakes/subscriptions",
"type": "User",
"url": "https://api.github.com/users/JanJakes",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2013-11-14T06:39:24Z | 2021-09-09T00:34:17Z | 2013-11-24T10:53:11Z | NONE | resolved | Currently there is no way of doing such requests:
``` bash
POST /api/ HTTP/1.1
Host: 127.0.0.1:5000
Content-Type: multipart/form-data; boundary=495b38322a354377913185cb452518fd
--495b38322a354377913185cb452518fd
Content-Disposition: form-data; name="data"
Content-Type: application/json; charset=UTF-8
{"key2": "value2", "key1": "value1"}
--495b38322a354377913185cb452518fd
Content-Disposition: form-data; name="file"; filename="image.jpg"
...image data...
--495b38322a354377913185cb452518fd--
```
Sending a file along with a JSON encoded metadata is a very typical task for API implementations.
What is even is weirder that we can do this for files but not for other fields that are sent with the files.
Also, is there any way to compose a multipart POST request with `multipart/mixed` header? (With keeping the possibility to choose the fields and their headers.)
Thanks, Jan
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1736/reactions"
} | https://api.github.com/repos/psf/requests/issues/1736/timeline | null | completed | null | null | false | [
"Yes there is. Take a look at the [changelog](https://github.com/kennethreitz/requests/blob/master/HISTORY.rst#201-2013-10-24).\n\nThe syntax for doing this and including things that aren't files (like some JSON) is a bit of a pain, but here it is:\n\n``` python\nimport json\nfrom cStringIO import StringIO\n\nmetad... |
https://api.github.com/repos/psf/requests/issues/1735 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1735/labels{/name} | https://api.github.com/repos/psf/requests/issues/1735/comments | https://api.github.com/repos/psf/requests/issues/1735/events | https://github.com/psf/requests/pull/1735 | 22,599,396 | MDExOlB1bGxSZXF1ZXN0OTkzMzg0MQ== | 1,735 | Wheel | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 8 | 2013-11-13T15:39:09Z | 2021-09-08T22:01:18Z | 2013-11-15T09:33:38Z | MEMBER | resolved | Let's get ourselves green on [this list](http://pythonwheels.com/). We're pure python, so this should be totally trivial for us. I'll try to provide a PR tonight.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1735/reactions"
} | https://api.github.com/repos/psf/requests/issues/1735/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1735.diff",
"html_url": "https://github.com/psf/requests/pull/1735",
"merged_at": "2013-11-15T09:33:38Z",
"patch_url": "https://github.com/psf/requests/pull/1735.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1735"
} | true | [
"Alright, I've extended the Makefile so that it should be possible to just start doing this transparently. =) Let me know what we think!\n",
":+1:\n\nCan we add \"wheel\" to the (dev-)?requirements file? This means that any virtualenv will be fully equipped to deploy it. Then again not everyone needs it.\n",
"S... |
https://api.github.com/repos/psf/requests/issues/1734 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1734/labels{/name} | https://api.github.com/repos/psf/requests/issues/1734/comments | https://api.github.com/repos/psf/requests/issues/1734/events | https://github.com/psf/requests/issues/1734 | 22,397,098 | MDU6SXNzdWUyMjM5NzA5OA== | 1,734 | UnicodeDecodeError on a multipart file upload | {
"avatar_url": "https://avatars.githubusercontent.com/u/1396111?v=4",
"events_url": "https://api.github.com/users/gcq/events{/privacy}",
"followers_url": "https://api.github.com/users/gcq/followers",
"following_url": "https://api.github.com/users/gcq/following{/other_user}",
"gists_url": "https://api.github.com/users/gcq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gcq",
"id": 1396111,
"login": "gcq",
"node_id": "MDQ6VXNlcjEzOTYxMTE=",
"organizations_url": "https://api.github.com/users/gcq/orgs",
"received_events_url": "https://api.github.com/users/gcq/received_events",
"repos_url": "https://api.github.com/users/gcq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gcq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gcq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gcq",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2013-11-10T00:54:47Z | 2021-09-09T00:34:23Z | 2013-11-10T07:38:25Z | NONE | resolved | Since im in python3.3 and requests takes a file-like object as the file argument on a post request, why is there an Unicode error? What should i do to be able to upload a multimedia file using requests?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1734/reactions"
} | https://api.github.com/repos/psf/requests/issues/1734/timeline | null | completed | null | null | false | [
"Questions belong on [StackOverflow](http://stackoverflow.com/questions/tagged/python-requests). In general though, multimedia files will not be Unicode compatible because it will attempt to read sequences of bytes in the file object as Unicode multi-byte sequences instead. Ostensibly there's inherent string additi... |
https://api.github.com/repos/psf/requests/issues/1733 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1733/labels{/name} | https://api.github.com/repos/psf/requests/issues/1733/comments | https://api.github.com/repos/psf/requests/issues/1733/events | https://github.com/psf/requests/pull/1733 | 22,395,404 | MDExOlB1bGxSZXF1ZXN0OTgyNDE3Nw== | 1,733 | Response and Request objects are pickleable. | {
"avatar_url": "https://avatars.githubusercontent.com/u/509830?v=4",
"events_url": "https://api.github.com/users/ionrock/events{/privacy}",
"followers_url": "https://api.github.com/users/ionrock/followers",
"following_url": "https://api.github.com/users/ionrock/following{/other_user}",
"gists_url": "https://api.github.com/users/ionrock/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ionrock",
"id": 509830,
"login": "ionrock",
"node_id": "MDQ6VXNlcjUwOTgzMA==",
"organizations_url": "https://api.github.com/users/ionrock/orgs",
"received_events_url": "https://api.github.com/users/ionrock/received_events",
"repos_url": "https://api.github.com/users/ionrock/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ionrock/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ionrock/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ionrock",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 3 | 2013-11-09T22:49:23Z | 2021-09-08T23:11:06Z | 2013-11-20T09:01:26Z | CONTRIBUTOR | resolved | Includes a basic test. More could be add to confirm known attributes
that could cause problems.
This should fix #1367.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/1733/reactions"
} | https://api.github.com/repos/psf/requests/issues/1733/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1733.diff",
"html_url": "https://github.com/psf/requests/pull/1733",
"merged_at": "2013-11-20T09:01:26Z",
"patch_url": "https://github.com/psf/requests/pull/1733.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1733"
} | true | [
"Looks fine in principle to me, but I'd want @sigmavirus24 to take a look. =)\n",
"If you feel you want to add more tests @ionrock then go ahead but I'm happy with this as it is. :+1:\n",
":pickle: (this should be a thing)\n\nThanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/1732 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1732/labels{/name} | https://api.github.com/repos/psf/requests/issues/1732/comments | https://api.github.com/repos/psf/requests/issues/1732/events | https://github.com/psf/requests/issues/1732 | 22,382,764 | MDU6SXNzdWUyMjM4Mjc2NA== | 1,732 | SNI support broken on Python 2.X in 2.0.1. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "5319e7",
"default": false,
"description": null,
"id": 67760318,
... | closed | true | null | [] | {
"closed_at": "2014-12-25T16:11:49Z",
"closed_issues": 1,
"created_at": "2013-11-09T08:57:36Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/19",
"id": 479442,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/19/labels",
"node_id": "MDk6TWlsZXN0b25lNDc5NDQy",
"number": 19,
"open_issues": 0,
"state": "closed",
"title": "2.0.2",
"updated_at": "2014-12-25T16:11:49Z",
"url": "https://api.github.com/repos/psf/requests/milestones/19"
} | 3 | 2013-11-09T08:57:36Z | 2021-09-08T23:08:00Z | 2013-12-05T23:05:18Z | MEMBER | resolved | `urllib3` had a bug, we accidentally pulled it in, we didn't catch it because we don't test with SNI support (should we have that as a separate build?). Happily the awesome @t-8ch has already provided us with a patch, which is already merged, so we don't necessarily have an action on this: it'll be quietly fixed in the next release. Just raising this issue so that people who look on the issue tracker see it.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1732/reactions"
} | https://api.github.com/repos/psf/requests/issues/1732/timeline | null | completed | null | null | false | [
"I bumped into this today, adding a little background to help some people who might have the same issue:\n\nIt's not just that SNI support is broken ; if you have the relevant dependencies installed, it will be impossible to install requests 2.0.1. To reproduce, do the following in a new virtualenv:\n- pip install ... |
https://api.github.com/repos/psf/requests/issues/1731 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1731/labels{/name} | https://api.github.com/repos/psf/requests/issues/1731/comments | https://api.github.com/repos/psf/requests/issues/1731/events | https://github.com/psf/requests/issues/1731 | 22,370,370 | MDU6SXNzdWUyMjM3MDM3MA== | 1,731 | SSL certificate verify failed | {
"avatar_url": "https://avatars.githubusercontent.com/u/1396111?v=4",
"events_url": "https://api.github.com/users/gcq/events{/privacy}",
"followers_url": "https://api.github.com/users/gcq/followers",
"following_url": "https://api.github.com/users/gcq/following{/other_user}",
"gists_url": "https://api.github.com/users/gcq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gcq",
"id": 1396111,
"login": "gcq",
"node_id": "MDQ6VXNlcjEzOTYxMTE=",
"organizations_url": "https://api.github.com/users/gcq/orgs",
"received_events_url": "https://api.github.com/users/gcq/received_events",
"repos_url": "https://api.github.com/users/gcq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gcq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gcq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gcq",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 11 | 2013-11-08T23:07:02Z | 2021-09-09T00:28:13Z | 2013-11-09T12:06:20Z | NONE | resolved | When using requests on https://cloudconvert.org/ i get this Exception, but Firefox says the certificate is alright.
I alredy notified cloudconvert, and wil update this accordingly, but as far as i know this can be a requests issue.
```
Traceback (most recent call last):
File "C:\Users\Gcq\Documents\GitHub\python-cloudconvert\CloudConvert.py", line 75, in <module>
print requests.get("https://cloudconvert.org/contact").text
File "C:\Python27\lib\site-packages\requests\api.py", line 55, in get
return request('get', url, **kwargs)
File "C:\Python27\lib\site-packages\requests\api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 335, in request
resp = self.send(prep, **send_kwargs)
File "C:\Python27\lib\site-packages\requests\sessions.py", line 438, in send
r = adapter.send(request, **kwargs)
File "C:\Python27\lib\site-packages\requests\adapters.py", line 331, in send
raise SSLError(e)
SSLError: [Errno 1] _ssl.c:510: error:14090086:SSL routines:SSL3_GET_SERVER_CERTIFICATE:certificate verify failed
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1396111?v=4",
"events_url": "https://api.github.com/users/gcq/events{/privacy}",
"followers_url": "https://api.github.com/users/gcq/followers",
"following_url": "https://api.github.com/users/gcq/following{/other_user}",
"gists_url": "https://api.github.com/users/gcq/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gcq",
"id": 1396111,
"login": "gcq",
"node_id": "MDQ6VXNlcjEzOTYxMTE=",
"organizations_url": "https://api.github.com/users/gcq/orgs",
"received_events_url": "https://api.github.com/users/gcq/received_events",
"repos_url": "https://api.github.com/users/gcq/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gcq/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gcq/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gcq",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1731/reactions"
} | https://api.github.com/repos/psf/requests/issues/1731/timeline | null | completed | null | null | false | [
"Firstly, what version of Requests are you using? Requests 2.0.1 was released recently that contains a number of updates to our baked-in certificates.\n\nUsing 2.0.1, I get different behaviour to you. In Python 3, everything works perfectly out of the box. In Python 2, you'll need to install the requirements for SN... |
https://api.github.com/repos/psf/requests/issues/1730 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1730/labels{/name} | https://api.github.com/repos/psf/requests/issues/1730/comments | https://api.github.com/repos/psf/requests/issues/1730/events | https://github.com/psf/requests/pull/1730 | 22,324,227 | MDExOlB1bGxSZXF1ZXN0OTc4ODA0MQ== | 1,730 | lowercase cookie names when check | {
"avatar_url": "https://avatars.githubusercontent.com/u/542246?v=4",
"events_url": "https://api.github.com/users/solos/events{/privacy}",
"followers_url": "https://api.github.com/users/solos/followers",
"following_url": "https://api.github.com/users/solos/following{/other_user}",
"gists_url": "https://api.github.com/users/solos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/solos",
"id": 542246,
"login": "solos",
"node_id": "MDQ6VXNlcjU0MjI0Ng==",
"organizations_url": "https://api.github.com/users/solos/orgs",
"received_events_url": "https://api.github.com/users/solos/received_events",
"repos_url": "https://api.github.com/users/solos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/solos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/solos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/solos",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-11-08T08:47:55Z | 2021-09-08T22:01:03Z | 2013-11-08T10:08:26Z | NONE | resolved | lowercase cookie names when check badargs
| {
"avatar_url": "https://avatars.githubusercontent.com/u/542246?v=4",
"events_url": "https://api.github.com/users/solos/events{/privacy}",
"followers_url": "https://api.github.com/users/solos/followers",
"following_url": "https://api.github.com/users/solos/following{/other_user}",
"gists_url": "https://api.github.com/users/solos/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/solos",
"id": 542246,
"login": "solos",
"node_id": "MDQ6VXNlcjU0MjI0Ng==",
"organizations_url": "https://api.github.com/users/solos/orgs",
"received_events_url": "https://api.github.com/users/solos/received_events",
"repos_url": "https://api.github.com/users/solos/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/solos/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/solos/subscriptions",
"type": "User",
"url": "https://api.github.com/users/solos",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1730/reactions"
} | https://api.github.com/repos/psf/requests/issues/1730/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1730.diff",
"html_url": "https://github.com/psf/requests/pull/1730",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1730.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1730"
} | true | [
"I'm +1 on the replacing of `type` with `isinstance`. It's less clear to me that we need to lowercase all the keyword arguments to `create_cookie`. Why is this a problem?\n",
"I want to pass the badargs check and set a cookie which contains upper-case letter. I just lowercase cookie names when checking badargs.\n... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.