url stringlengths 50 53 | repository_url stringclasses 1 value | labels_url stringlengths 64 67 | comments_url stringlengths 59 62 | events_url stringlengths 57 60 | html_url stringlengths 38 43 | id int64 597k 2.65B | node_id stringlengths 18 32 | number int64 1 6.83k | title stringlengths 1 296 | user dict | labels listlengths 0 5 | state stringclasses 2 values | locked bool 2 classes | assignee dict | assignees listlengths 0 4 | milestone dict | comments int64 0 211 | created_at stringlengths 20 20 | updated_at stringlengths 20 20 | closed_at stringlengths 20 20 ⌀ | author_association stringclasses 3 values | active_lock_reason stringclasses 4 values | body stringlengths 0 65.6k ⌀ | closed_by dict | reactions dict | timeline_url stringlengths 59 62 | performed_via_github_app null | state_reason stringclasses 3 values | draft bool 2 classes | pull_request dict | is_pull_request bool 2 classes | issue_comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/2030 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2030/labels{/name} | https://api.github.com/repos/psf/requests/issues/2030/comments | https://api.github.com/repos/psf/requests/issues/2030/events | https://github.com/psf/requests/issues/2030 | 32,637,686 | MDU6SXNzdWUzMjYzNzY4Ng== | 2,030 | Session proxies not used | {
"avatar_url": "https://avatars.githubusercontent.com/u/5490133?v=4",
"events_url": "https://api.github.com/users/galfan/events{/privacy}",
"followers_url": "https://api.github.com/users/galfan/followers",
"following_url": "https://api.github.com/users/galfan/following{/other_user}",
"gists_url": "https://api.github.com/users/galfan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/galfan",
"id": 5490133,
"login": "galfan",
"node_id": "MDQ6VXNlcjU0OTAxMzM=",
"organizations_url": "https://api.github.com/users/galfan/orgs",
"received_events_url": "https://api.github.com/users/galfan/received_events",
"repos_url": "https://api.github.com/users/galfan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/galfan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/galfan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/galfan",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-05-01T18:50:31Z | 2021-09-09T00:01:03Z | 2014-05-01T18:58:12Z | NONE | resolved | In:
s = requests.Session()
s.proxies["http"] = ""
s.proxies["https"] = ""
s.get("http://server/",proxies=s.proxies)
I'd expect "proxies=s.proxies" to be redundant.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2030/reactions"
} | https://api.github.com/repos/psf/requests/issues/2030/timeline | null | completed | null | null | false | [
"What makes you think it isn't?\n",
"Guess ...\n",
"I shouldn't have to guess. =) Bug reports are not a guessing game, they're a report of a fault: you should say what you did, what you expected to happen, and what actually happened.\n",
"I thought I did exactly that.\nWithout the proxies it would use my envi... |
https://api.github.com/repos/psf/requests/issues/2029 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2029/labels{/name} | https://api.github.com/repos/psf/requests/issues/2029/comments | https://api.github.com/repos/psf/requests/issues/2029/events | https://github.com/psf/requests/issues/2029 | 32,602,791 | MDU6SXNzdWUzMjYwMjc5MQ== | 2,029 | Is it possible to specify an SSL timeout? | {
"avatar_url": "https://avatars.githubusercontent.com/u/1440143?v=4",
"events_url": "https://api.github.com/users/GP89/events{/privacy}",
"followers_url": "https://api.github.com/users/GP89/followers",
"following_url": "https://api.github.com/users/GP89/following{/other_user}",
"gists_url": "https://api.github.com/users/GP89/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/GP89",
"id": 1440143,
"login": "GP89",
"node_id": "MDQ6VXNlcjE0NDAxNDM=",
"organizations_url": "https://api.github.com/users/GP89/orgs",
"received_events_url": "https://api.github.com/users/GP89/received_events",
"repos_url": "https://api.github.com/users/GP89/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/GP89/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/GP89/subscriptions",
"type": "User",
"url": "https://api.github.com/users/GP89",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-05-01T08:54:42Z | 2021-09-08T23:11:01Z | 2014-06-08T09:51:45Z | NONE | resolved | Not really an issue I guess,
But I'm noticing on some logs that I'm receiving an SSLError 'The read operation timed out' just over a second after all the data has been read and uploaded from a file during a PUT upload request.
I've tried increasing the timeout by passing a higher value requests.put(url, filename, timeout=60), but I guess this isn't getting passed to the SSL part of the underlying library? as it still times out at just over a second as it did before.
Is there a way to increase the timeout for the SSL part of the request from 1 second (it appears to be 1 second anyway)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2029/reactions"
} | https://api.github.com/repos/psf/requests/issues/2029/timeline | null | completed | null | null | false | [
"I've honestly got no idea. @t-8ch, does the underlying ssl library not time out based on the socket timeout?\n",
"@GP89 which SSL backend and Python interpreter are you using?\nI can't reproduce a SSLError on read timeout, only with a handshake using the stdlib. The handshake with PyOpenSSL never times out...\n"... |
https://api.github.com/repos/psf/requests/issues/2028 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2028/labels{/name} | https://api.github.com/repos/psf/requests/issues/2028/comments | https://api.github.com/repos/psf/requests/issues/2028/events | https://github.com/psf/requests/issues/2028 | 32,534,123 | MDU6SXNzdWUzMjUzNDEyMw== | 2,028 | ImportError: cannot import name certs | {
"avatar_url": "https://avatars.githubusercontent.com/u/1942093?v=4",
"events_url": "https://api.github.com/users/poolski/events{/privacy}",
"followers_url": "https://api.github.com/users/poolski/followers",
"following_url": "https://api.github.com/users/poolski/following{/other_user}",
"gists_url": "https://api.github.com/users/poolski/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/poolski",
"id": 1942093,
"login": "poolski",
"node_id": "MDQ6VXNlcjE5NDIwOTM=",
"organizations_url": "https://api.github.com/users/poolski/orgs",
"received_events_url": "https://api.github.com/users/poolski/received_events",
"repos_url": "https://api.github.com/users/poolski/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/poolski/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/poolski/subscriptions",
"type": "User",
"url": "https://api.github.com/users/poolski",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 17 | 2014-04-30T13:25:55Z | 2021-09-06T00:06:38Z | 2014-05-25T09:57:47Z | NONE | resolved | When using Requests in a very basic function, it won't even start as it can't load "certs"
```
import requests
import django.utils.simplejson as json
def getFeed(user_id):
jsonURL = "https://feed.whatever.net/json"
resp = requests.get(jsonURL)
result = json.load(r.json())
import pdb; pdb.set_trace()
return result
```
I get
```
File "/home/vagrant/dev/python/team-calendar/team_calendar/calendar/json.py", line 1, in <module>
import requests
File "/home/vagrant/.virtualenvs/teamcalendar/local/lib/python2.7/site-packages/requests/__init__.py", line 58, in <module>
from . import utils
File "/home/vagrant/.virtualenvs/teamcalendar/local/lib/python2.7/site-packages/requests/utils.py", line 24, in <module>
from . import certs
ImportError: cannot import name certs
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2028/reactions"
} | https://api.github.com/repos/psf/requests/issues/2028/timeline | null | completed | null | null | false | [
"What version of requests are you using and where did you install it from?\n",
"There's no need to answer that: this is another manifestation of #2026. =)\n",
"@sigmavirus24 @Lukasa I'm using 2.2.1 from pypi...\n\nI saw in #2026 that it was \"fixed\" by installing 2.2.1 from pypi, but mine IS a normal, vanilla ... |
https://api.github.com/repos/psf/requests/issues/2027 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2027/labels{/name} | https://api.github.com/repos/psf/requests/issues/2027/comments | https://api.github.com/repos/psf/requests/issues/2027/events | https://github.com/psf/requests/issues/2027 | 32,453,236 | MDU6SXNzdWUzMjQ1MzIzNg== | 2,027 | Chunk Size - Question -- Not issue | {
"avatar_url": "https://avatars.githubusercontent.com/u/6764126?v=4",
"events_url": "https://api.github.com/users/patelgr/events{/privacy}",
"followers_url": "https://api.github.com/users/patelgr/followers",
"following_url": "https://api.github.com/users/patelgr/following{/other_user}",
"gists_url": "https://api.github.com/users/patelgr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/patelgr",
"id": 6764126,
"login": "patelgr",
"node_id": "MDQ6VXNlcjY3NjQxMjY=",
"organizations_url": "https://api.github.com/users/patelgr/orgs",
"received_events_url": "https://api.github.com/users/patelgr/received_events",
"repos_url": "https://api.github.com/users/patelgr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/patelgr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/patelgr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/patelgr",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-04-29T15:01:22Z | 2021-09-09T00:01:03Z | 2014-04-29T15:51:43Z | NONE | resolved | Is there any guideline on selecting chunk size?
I tried different chunk size but none of them give download speed comparable to browser or wget download speed
here is snapshot of my code
r = requests.get(url, headers = headers,stream=True)
total_length = int(r.headers.get('content-length'))
if not total_length is None: # no content length header
for chunk in r.iter_content(1024):
f.write(chunk)
Any help would be appreciated.?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2027/reactions"
} | https://api.github.com/repos/psf/requests/issues/2027/timeline | null | completed | null | null | false | [
"Hi @gauravp2003,\n\nMuch of the documentation around requests, including the [README](https://github.com/kennethreitz/requests#contribute), suggests that the issue tracker is for bugs or feature requests, not questions. If you have questions, the should be asked on [StackOverflow](https://stackoverflow.com/questio... |
https://api.github.com/repos/psf/requests/issues/2026 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2026/labels{/name} | https://api.github.com/repos/psf/requests/issues/2026/comments | https://api.github.com/repos/psf/requests/issues/2026/events | https://github.com/psf/requests/pull/2026 | 32,407,944 | MDExOlB1bGxSZXF1ZXN0MTUzMDI1OTg= | 2,026 | ImportError: No module named 'requests.packages.urllib3.util' | {
"avatar_url": "https://avatars.githubusercontent.com/u/3210446?v=4",
"events_url": "https://api.github.com/users/zacharysarah/events{/privacy}",
"followers_url": "https://api.github.com/users/zacharysarah/followers",
"following_url": "https://api.github.com/users/zacharysarah/following{/other_user}",
"gists_url": "https://api.github.com/users/zacharysarah/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zacharysarah",
"id": 3210446,
"login": "zacharysarah",
"node_id": "MDQ6VXNlcjMyMTA0NDY=",
"organizations_url": "https://api.github.com/users/zacharysarah/orgs",
"received_events_url": "https://api.github.com/users/zacharysarah/received_events",
"repos_url": "https://api.github.com/users/zacharysarah/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zacharysarah/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zacharysarah/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zacharysarah",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2014-04-28T23:23:24Z | 2021-09-09T00:01:26Z | 2014-05-02T19:09:39Z | NONE | resolved | I'm using Python 3.4. I get this error from `import requests`:
```
Traceback (most recent call last):
File "devwiki.py", line 4, in <module>
import requests
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests-2.3.0-py3.4.egg/requests/__init__.py", line 58, in <module>
from . import utils
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests-2.3.0-py3.4.egg/requests/utils.py", line 25, in <module>
from .compat import parse_http_list as _parse_list_header
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests-2.3.0-py3.4.egg/requests/compat.py", line 7, in <module>
from .packages import chardet
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests-2.3.0-py3.4.egg/requests/packages/__init__.py", line 3, in <module>
from . import urllib3
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests-2.3.0-py3.4.egg/requests/packages/urllib3/__init__.py", line 16, in <module>
from .connectionpool import (
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests-2.3.0-py3.4.egg/requests/packages/urllib3/connectionpool.py", line 36, in <module>
from .connection import (
File "/Library/Frameworks/Python.framework/Versions/3.4/lib/python3.4/site-packages/requests-2.3.0-py3.4.egg/requests/packages/urllib3/connection.py", line 43, in <module>
from .util import (
ImportError: No module named 'requests.packages.urllib3.util'
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2026/reactions"
} | https://api.github.com/repos/psf/requests/issues/2026/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2026.diff",
"html_url": "https://github.com/psf/requests/pull/2026",
"merged_at": "2014-05-02T19:09:39Z",
"patch_url": "https://github.com/psf/requests/pull/2026.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2026"
} | true | [
"@zakcalrissian how did you install requests? Your traceback seems to say that you have version 2.3.0 installed when no such version has been released.\n",
"I got an email about this as well. Installing directly from Github reveals this problem, but it's very specific: you need to install the package and then run... |
https://api.github.com/repos/psf/requests/issues/2025 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2025/labels{/name} | https://api.github.com/repos/psf/requests/issues/2025/comments | https://api.github.com/repos/psf/requests/issues/2025/events | https://github.com/psf/requests/issues/2025 | 32,402,696 | MDU6SXNzdWUzMjQwMjY5Ng== | 2,025 | JSON Upload | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 19127... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 11 | 2014-04-28T21:58:28Z | 2021-09-08T23:07:57Z | 2014-10-05T16:46:09Z | CONTRIBUTOR | resolved | We download it but don't upload it. Asymmetrical.
```
r = requests.post('http://httpbin.org/post', json={'life': 42'})
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2025/reactions"
} | https://api.github.com/repos/psf/requests/issues/2025/timeline | null | completed | null | null | false | [
"This is really easy to do. I'm curious though, what made you change your mind about this?\n",
"Tagging this as contributor friendly because it's perfect for @sigmavirus24 to pair with a new developer on.\n",
"cool!\n",
"Did anyone already start working on it ? If not, I would be interested in giving it a try... |
https://api.github.com/repos/psf/requests/issues/2024 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2024/labels{/name} | https://api.github.com/repos/psf/requests/issues/2024/comments | https://api.github.com/repos/psf/requests/issues/2024/events | https://github.com/psf/requests/issues/2024 | 32,385,865 | MDU6SXNzdWUzMjM4NTg2NQ== | 2,024 | Response.close doesn't really close the connection | {
"avatar_url": "https://avatars.githubusercontent.com/u/167414?v=4",
"events_url": "https://api.github.com/users/ctheiss/events{/privacy}",
"followers_url": "https://api.github.com/users/ctheiss/followers",
"following_url": "https://api.github.com/users/ctheiss/following{/other_user}",
"gists_url": "https://api.github.com/users/ctheiss/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ctheiss",
"id": 167414,
"login": "ctheiss",
"node_id": "MDQ6VXNlcjE2NzQxNA==",
"organizations_url": "https://api.github.com/users/ctheiss/orgs",
"received_events_url": "https://api.github.com/users/ctheiss/received_events",
"repos_url": "https://api.github.com/users/ctheiss/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ctheiss/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ctheiss/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ctheiss",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-04-28T18:30:51Z | 2021-09-09T00:01:04Z | 2014-04-28T18:34:23Z | NONE | resolved | The docs for `Response.close` say: "Closes the underlying file descriptor and releases the connection back to the pool.", and the code is: `self.raw.release_conn()`.
I think this should be `self.raw.close`, as releasing the connection (https://github.com/kennethreitz/requests/blob/826667a54c608d72d8813c3eddb75b27ab26c988/requests/packages/urllib3/response.py#L121) and closing the response's underlying file descriptor (https://github.com/kennethreitz/requests/blob/826667a54c608d72d8813c3eddb75b27ab26c988/requests/packages/urllib3/response.py#L279) are different.
It's a little difficult making out all the implications, but I believe releasing the connection will close the connection _when that connection is used again from the pool_, which is different than the docs suggest.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2024/reactions"
} | https://api.github.com/repos/psf/requests/issues/2024/timeline | null | completed | null | null | false | [
"Thanks for raising this!\n\nThis has come up before, and we don't agree with your assessment. From requests' perspective, connection pooling is A Good Thing, and we want to enable that as much as possible. For that reason, we allow urllib3 to manage the lifetime of our underlying connections, which it does very we... |
https://api.github.com/repos/psf/requests/issues/2023 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2023/labels{/name} | https://api.github.com/repos/psf/requests/issues/2023/comments | https://api.github.com/repos/psf/requests/issues/2023/events | https://github.com/psf/requests/pull/2023 | 32,298,236 | MDExOlB1bGxSZXF1ZXN0MTUyMDYzMTA= | 2,023 | show which ssl backend we are using | {
"avatar_url": "https://avatars.githubusercontent.com/u/717901?v=4",
"events_url": "https://api.github.com/users/t-8ch/events{/privacy}",
"followers_url": "https://api.github.com/users/t-8ch/followers",
"following_url": "https://api.github.com/users/t-8ch/following{/other_user}",
"gists_url": "https://api.github.com/users/t-8ch/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/t-8ch",
"id": 717901,
"login": "t-8ch",
"node_id": "MDQ6VXNlcjcxNzkwMQ==",
"organizations_url": "https://api.github.com/users/t-8ch/orgs",
"received_events_url": "https://api.github.com/users/t-8ch/received_events",
"repos_url": "https://api.github.com/users/t-8ch/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/t-8ch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/t-8ch/subscriptions",
"type": "User",
"url": "https://api.github.com/users/t-8ch",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 11 | 2014-04-26T21:12:48Z | 2021-09-08T23:11:07Z | 2014-05-12T18:57:10Z | CONTRIBUTOR | resolved | This is meant to be used when triaging bugs, without requiring deep knowledge
about the internals from reporters.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2023/reactions"
} | https://api.github.com/repos/psf/requests/issues/2023/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2023.diff",
"html_url": "https://github.com/psf/requests/pull/2023",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2023.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2023"
} | true | [
"LGTM, can only be helpful. =) :cake:\n",
"Did someone need this?\n",
"@kennethreitz this will help a great deal when debugging issues where people are running into errors with HTTPS connections.\n",
"Specifically #2022 would have been easier to debug if we had this information readily available to us\n",
"... |
https://api.github.com/repos/psf/requests/issues/2022 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2022/labels{/name} | https://api.github.com/repos/psf/requests/issues/2022/comments | https://api.github.com/repos/psf/requests/issues/2022/events | https://github.com/psf/requests/issues/2022 | 32,294,037 | MDU6SXNzdWUzMjI5NDAzNw== | 2,022 | https GET request fails with "handshake failure" | {
"avatar_url": "https://avatars.githubusercontent.com/u/101148?v=4",
"events_url": "https://api.github.com/users/jaddison/events{/privacy}",
"followers_url": "https://api.github.com/users/jaddison/followers",
"following_url": "https://api.github.com/users/jaddison/following{/other_user}",
"gists_url": "https://api.github.com/users/jaddison/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jaddison",
"id": 101148,
"login": "jaddison",
"node_id": "MDQ6VXNlcjEwMTE0OA==",
"organizations_url": "https://api.github.com/users/jaddison/orgs",
"received_events_url": "https://api.github.com/users/jaddison/received_events",
"repos_url": "https://api.github.com/users/jaddison/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jaddison/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jaddison/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jaddison",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 76 | 2014-04-26T17:42:19Z | 2018-06-15T02:16:34Z | 2014-04-26T21:08:02Z | NONE | resolved | Related to #1083, perhaps. Standard `requests.get()` for this particular site/page `https://docs.apitools.com/2014/04/24/a-small-router-for-openresty.html` results in:
```
>>> import requests
>>> requests.get('https://docs.apitools.com/2014/04/24/a-small-router-for-openresty.html')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 383, in request
resp = self.send(prep, **send_kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 486, in send
r = adapter.send(request, **kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/adapters.py", line 385, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 1] _ssl.c:504: error:14077410:SSL routines:SSL23_GET_SERVER_HELLO:sslv3 alert handshake failure
```
Using `request-toolbelt`'s `SSLAdapter` to try various ssl versions, they all fail, it would seem... see following tracebacks.
TLSv1:
```
>>> adapter = SSLAdapter('TLSv1')
>>> s = requests.Session()
>>> s.mount('https://', adapter)
>>> s.get('https://docs.apitools.com/2014/04/24/a-small-router-for-openresty.html')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 395, in get
return self.request('GET', url, **kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 383, in request
resp = self.send(prep, **send_kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 486, in send
r = adapter.send(request, **kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/adapters.py", line 385, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 1] _ssl.c:504: error:14094410:SSL routines:SSL3_READ_BYTES:sslv3 alert handshake failure
```
SSLv3:
```
>>> adapter = SSLAdapter('SSLv3')
>>> s = requests.Session()
>>> s.mount('https://', adapter)
>>> s.get('https://docs.apitools.com/2014/04/24/a-small-router-for-openresty.html')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 395, in get
return self.request('GET', url, **kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 383, in request
resp = self.send(prep, **send_kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 486, in send
r = adapter.send(request, **kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/adapters.py", line 385, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 1] _ssl.c:504: error:14094410:SSL routines:SSL3_READ_BYTES:sslv3 alert handshake failure
```
SSLv2:
```
>>> adapter = SSLAdapter('SSLv2')
>>> s = requests.Session()
>>> s.mount('https://', adapter)
>>> s.get('https://docs.apitools.com/2014/04/24/a-small-router-for-openresty.html')
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 395, in get
return self.request('GET', url, **kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 383, in request
resp = self.send(prep, **send_kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 486, in send
r = adapter.send(request, **kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/adapters.py", line 378, in send
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='docs.apitools.com', port=443): Max retries exceeded with url: /2014/04/24/a-small-router-for-openresty.html (Caused by <class 'socket.error'>: [Errno 54] Connection reset by peer)
```
Note the last one gives a `Connection reset by peer` error, which differs from the others, but I'm pretty sure SSLv2 isn't supported by the server anyhow.
For fun, I tried to pass through some more appropriate headers through on the last request as well:
```
>>> headers = {
... 'Accept': u"text/html,application/xhtml+xml,application/xml",
... 'User-Agent': u"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_9_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/34.0.1847.131 Safari/537.36",
... 'Accept-Encoding': u"gzip,deflate",
... 'Accept-Language': u"en-US,en;q=0.8"
... }
>>> adapter = SSLAdapter('SSLv2')
>>> s = requests.Session()
>>> s.mount('https://', adapter)
>>> s.get('https://docs.apitools.com/2014/04/24/a-small-router-for-openresty.html', headers=headers)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 395, in get
return self.request('GET', url, **kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 383, in request
resp = self.send(prep, **send_kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/sessions.py", line 486, in send
r = adapter.send(request, **kwargs)
File "/Users/jaddison/.virtualenvs/techtown/lib/python2.7/site-packages/requests/adapters.py", line 378, in send
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='docs.apitools.com', port=443): Max retries exceeded with url: /2014/04/24/a-small-router-for-openresty.html (Caused by <class 'socket.error'>: [Errno 54] Connection reset by peer)
```
No dice there either. Here's what the HTTPS connection info in Chrome on Mac looks like:
I'm not positive, but some googling indicates it's likely a cipher list issue, which is more urllib3, I think?
I tried to modify `DEFAULT_CIPHER_LIST` in `pyopenssl`, but started running into import errors. At this point it seemed like things were just broken, and there wasn't really a proper way to approach fixing this yet.
Version information:
OSX Mavericks
Python 2.7.5
OpenSSL 0.9.8y 5 Feb 2013 - (from `python -c "import ssl; print ssl.OPENSSL_VERSION"`)
requests 2.2.1
requests-toolbelt 0.2.0
urllib3 1.8
| {
"avatar_url": "https://avatars.githubusercontent.com/u/101148?v=4",
"events_url": "https://api.github.com/users/jaddison/events{/privacy}",
"followers_url": "https://api.github.com/users/jaddison/followers",
"following_url": "https://api.github.com/users/jaddison/following{/other_user}",
"gists_url": "https://api.github.com/users/jaddison/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jaddison",
"id": 101148,
"login": "jaddison",
"node_id": "MDQ6VXNlcjEwMTE0OA==",
"organizations_url": "https://api.github.com/users/jaddison/orgs",
"received_events_url": "https://api.github.com/users/jaddison/received_events",
"repos_url": "https://api.github.com/users/jaddison/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jaddison/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jaddison/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jaddison",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2022/reactions"
} | https://api.github.com/repos/psf/requests/issues/2022/timeline | null | completed | null | null | false | [
"Sadly, this is unrelated to the issue you identified, and entirely down to the crappy OpenSSL that OS X ships with by default. Version 0.9.8y has some real problems with performing SSL handshakes, and some servers don't tolerate it well. Using Python 3 on my OS X box (therefore using a newer OpenSSL) reveals that ... |
https://api.github.com/repos/psf/requests/issues/2021 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2021/labels{/name} | https://api.github.com/repos/psf/requests/issues/2021/comments | https://api.github.com/repos/psf/requests/issues/2021/events | https://github.com/psf/requests/pull/2021 | 32,287,867 | MDExOlB1bGxSZXF1ZXN0MTUyMDE5MzU= | 2,021 | Don't repopulate proxies if we don't trust the environment. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 1 | 2014-04-26T12:10:01Z | 2021-09-08T23:08:21Z | 2014-04-28T21:49:28Z | MEMBER | resolved | This should resolve the problems raised in #2018.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2021/reactions"
} | https://api.github.com/repos/psf/requests/issues/2021/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2021.diff",
"html_url": "https://github.com/psf/requests/pull/2021",
"merged_at": "2014-04-28T21:49:28Z",
"patch_url": "https://github.com/psf/requests/pull/2021.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2021"
} | true | [
"LGTM. Merge when ready @kennethreitz \n"
] |
https://api.github.com/repos/psf/requests/issues/2020 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2020/labels{/name} | https://api.github.com/repos/psf/requests/issues/2020/comments | https://api.github.com/repos/psf/requests/issues/2020/events | https://github.com/psf/requests/issues/2020 | 32,263,500 | MDU6SXNzdWUzMjI2MzUwMA== | 2,020 | Iterating over chunks that are not terminated by new lines | {
"avatar_url": "https://avatars.githubusercontent.com/u/13951?v=4",
"events_url": "https://api.github.com/users/pkaeding/events{/privacy}",
"followers_url": "https://api.github.com/users/pkaeding/followers",
"following_url": "https://api.github.com/users/pkaeding/following{/other_user}",
"gists_url": "https://api.github.com/users/pkaeding/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pkaeding",
"id": 13951,
"login": "pkaeding",
"node_id": "MDQ6VXNlcjEzOTUx",
"organizations_url": "https://api.github.com/users/pkaeding/orgs",
"received_events_url": "https://api.github.com/users/pkaeding/received_events",
"repos_url": "https://api.github.com/users/pkaeding/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pkaeding/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pkaeding/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pkaeding",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 17 | 2014-04-25T20:21:57Z | 2021-09-08T12:00:57Z | 2014-04-25T20:23:56Z | NONE | resolved | I would like to iterator over chunks coming from a service, where each chunk is a JSON blob (similar to the example in the docs). However, in this service, there are no newlines after each chunk. As a result, it seems that `iter_lines` only yields one line, which is the entire response (not chunked), and `iter_content` yields one character at a time.
Is it possible to use this library to stream data from this service?
Thanks!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2020/reactions"
} | https://api.github.com/repos/psf/requests/issues/2020/timeline | null | completed | null | null | false | [
"`iter_content()` takes an argument, the [chunk size](http://docs.python-requests.org/en/latest/api/#requests.Response.iter_content). Set this larger and you'll get back larger chunks. =)\n",
"Right, but isn't the chunk size determined by the server? Before each chunk, the server sends the size of the next chunk... |
https://api.github.com/repos/psf/requests/issues/2019 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2019/labels{/name} | https://api.github.com/repos/psf/requests/issues/2019/comments | https://api.github.com/repos/psf/requests/issues/2019/events | https://github.com/psf/requests/issues/2019 | 32,241,617 | MDU6SXNzdWUzMjI0MTYxNw== | 2,019 | Unable to POST large files | {
"avatar_url": "https://avatars.githubusercontent.com/u/6054881?v=4",
"events_url": "https://api.github.com/users/jvaleo/events{/privacy}",
"followers_url": "https://api.github.com/users/jvaleo/followers",
"following_url": "https://api.github.com/users/jvaleo/following{/other_user}",
"gists_url": "https://api.github.com/users/jvaleo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jvaleo",
"id": 6054881,
"login": "jvaleo",
"node_id": "MDQ6VXNlcjYwNTQ4ODE=",
"organizations_url": "https://api.github.com/users/jvaleo/orgs",
"received_events_url": "https://api.github.com/users/jvaleo/received_events",
"repos_url": "https://api.github.com/users/jvaleo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jvaleo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jvaleo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jvaleo",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-04-25T15:27:18Z | 2021-09-09T00:01:04Z | 2014-04-25T16:09:00Z | NONE | resolved | When trying to POST a large binary file > 2GB, I see the following error. I've tried on multiple web severs all with the same result:
```
bash-3.2# du -h AirGuitarNation-Quicktime_H.264.mp4
2.4G AirGuitarNation-Quicktime_H.264.mp4
....
2014-04-24 17:26:41,600 ERROR Exception caught in upload_file HTTPConnectionPool(host='REDACTED', port=80): Max retries exceeded with url: /uploader_rails/upload.py?signature= REDACTED&username= REDACTED&site_id=763&validate=localhost%3A29125 (Caused by <class 'socket.error'>: [Errno 22] Invalid argument)
```
Here is my code:
``` python
file_path = os.path.join(ROOT_PATH, 'uploads', file_name)
files = {'file': open(file_path, 'rb')}
logger.info('Starting upload for {}'.format(file_name))
try:
post = requests.post(upload_url, files=files)
except Exception as e:
logger.error('Exception caught in upload_file {}'.format(e.message))
```
Smaller files work without issue, it seems to be anything over 2GB.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/6054881?v=4",
"events_url": "https://api.github.com/users/jvaleo/events{/privacy}",
"followers_url": "https://api.github.com/users/jvaleo/followers",
"following_url": "https://api.github.com/users/jvaleo/following{/other_user}",
"gists_url": "https://api.github.com/users/jvaleo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jvaleo",
"id": 6054881,
"login": "jvaleo",
"node_id": "MDQ6VXNlcjYwNTQ4ODE=",
"organizations_url": "https://api.github.com/users/jvaleo/orgs",
"received_events_url": "https://api.github.com/users/jvaleo/received_events",
"repos_url": "https://api.github.com/users/jvaleo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jvaleo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jvaleo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jvaleo",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2019/reactions"
} | https://api.github.com/repos/psf/requests/issues/2019/timeline | null | completed | null | null | false | [
"Hmm, I suspect the problem here is because the multipart body is greater than 2GB in size and we try to POST the whole thing.\n\nWant to try using the [Streaming Multipart Uploader from the toolbelt](http://toolbelt.readthedocs.org/en/latest/user.html#streaming-multipart-data-encoder)?\n",
"That's the ticket! Th... |
https://api.github.com/repos/psf/requests/issues/2018 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2018/labels{/name} | https://api.github.com/repos/psf/requests/issues/2018/comments | https://api.github.com/repos/psf/requests/issues/2018/events | https://github.com/psf/requests/issues/2018 | 32,203,116 | MDU6SXNzdWUzMjIwMzExNg== | 2,018 | Re-order proxy precedence. | {
"avatar_url": "https://avatars.githubusercontent.com/u/392047?v=4",
"events_url": "https://api.github.com/users/ouroborus/events{/privacy}",
"followers_url": "https://api.github.com/users/ouroborus/followers",
"following_url": "https://api.github.com/users/ouroborus/following{/other_user}",
"gists_url": "https://api.github.com/users/ouroborus/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ouroborus",
"id": 392047,
"login": "ouroborus",
"node_id": "MDQ6VXNlcjM5MjA0Nw==",
"organizations_url": "https://api.github.com/users/ouroborus/orgs",
"received_events_url": "https://api.github.com/users/ouroborus/received_events",
"repos_url": "https://api.github.com/users/ouroborus/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ouroborus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ouroborus/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ouroborus",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"... | open | false | null | [] | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 16 | 2014-04-25T03:09:20Z | 2022-02-17T19:17:32Z | null | NONE | null | `Session.trust_env = False` turns off the checking of environment variables for options including proxy settings (`*_proxy`). But `urllib` picks up and uses these environment proxy settings anyway. `requests` should pass the `trust_env` setting on to `urllib`. (Although I'm not sure if `urllib` has a similar override.)
(Proxy setting precedence should be sorted out here as well. They way it is now, environment proxy settings will interfere with (rather than be over-ridden by) the `proxies` argument in `Session.request` or `requests.request` calls and the `Session.proxies` config regardless of `trust_env` settings.)
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2018/reactions"
} | https://api.github.com/repos/psf/requests/issues/2018/timeline | null | null | null | null | false | [
"I've taken a quick look at the code in urllib3 and I can't find any reference to the `*_PROXY` environment variables there. Can you point to where in the code urllib3 grabs that information?\n\nAs for proxy setting precedence, what do you mean by 'interfere with'? We don't override any settings already in the prox... |
https://api.github.com/repos/psf/requests/issues/2017 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2017/labels{/name} | https://api.github.com/repos/psf/requests/issues/2017/comments | https://api.github.com/repos/psf/requests/issues/2017/events | https://github.com/psf/requests/pull/2017 | 32,175,162 | MDExOlB1bGxSZXF1ZXN0MTUxMzU0NjM= | 2,017 | Update urllib to 1.8.2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/111427?v=4",
"events_url": "https://api.github.com/users/alpire/events{/privacy}",
"followers_url": "https://api.github.com/users/alpire/followers",
"following_url": "https://api.github.com/users/alpire/following{/other_user}",
"gists_url": "https://api.github.com/users/alpire/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alpire",
"id": 111427,
"login": "alpire",
"node_id": "MDQ6VXNlcjExMTQyNw==",
"organizations_url": "https://api.github.com/users/alpire/orgs",
"received_events_url": "https://api.github.com/users/alpire/received_events",
"repos_url": "https://api.github.com/users/alpire/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alpire/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alpire/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alpire",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-04-24T18:49:17Z | 2021-09-08T23:07:22Z | 2014-04-26T03:04:54Z | CONTRIBUTOR | resolved | Hi,
The update enables https request on the google app engine dev server (see https://github.com/shazow/urllib3/issues/356 and https://github.com/kennethreitz/requests/issues/1961).
Thanks,
Alex
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2017/reactions"
} | https://api.github.com/repos/psf/requests/issues/2017/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2017.diff",
"html_url": "https://github.com/psf/requests/pull/2017",
"merged_at": "2014-04-26T03:04:54Z",
"patch_url": "https://github.com/psf/requests/pull/2017.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2017"
} | true | [
"Thanks!\n"
] |
https://api.github.com/repos/psf/requests/issues/2016 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2016/labels{/name} | https://api.github.com/repos/psf/requests/issues/2016/comments | https://api.github.com/repos/psf/requests/issues/2016/events | https://github.com/psf/requests/issues/2016 | 32,155,482 | MDU6SXNzdWUzMjE1NTQ4Mg== | 2,016 | App Engine Error: AttributeError: 'ApplicationError' object has no attribute 'errno' | {
"avatar_url": "https://avatars.githubusercontent.com/u/1918510?v=4",
"events_url": "https://api.github.com/users/sdog869/events{/privacy}",
"followers_url": "https://api.github.com/users/sdog869/followers",
"following_url": "https://api.github.com/users/sdog869/following{/other_user}",
"gists_url": "https://api.github.com/users/sdog869/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sdog869",
"id": 1918510,
"login": "sdog869",
"node_id": "MDQ6VXNlcjE5MTg1MTA=",
"organizations_url": "https://api.github.com/users/sdog869/orgs",
"received_events_url": "https://api.github.com/users/sdog869/received_events",
"repos_url": "https://api.github.com/users/sdog869/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sdog869/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sdog869/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sdog869",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-04-24T14:53:23Z | 2021-09-09T00:01:05Z | 2014-04-24T14:55:27Z | NONE | resolved | I'm not sure if this is a urllib3 error or a requests issue, but when trying to use requests on live app engine I see the stack trace:
line 55, in get
return request('get', url, *_kwargs)
line 44, in request
return session.request(method=method, url=url, *_kwargs)
/libs/requests/sessions.py", line 452, in request
resp = self.send(prep, *_send_kwargs)
/libs/requests/sessions.py", line 555, in send
r = adapter.send(request, *_kwargs)
/libs/requests/adapters.py", line 327, in send
timeout=timeout
/libs/requests/packages/urllib3/connectionpool.py", line 493, in urlopen
body=body, headers=headers)
/libs/requests/packages/urllib3/connectionpool.py", line 291, in _make_request
conn.request(method, url, *_httplib_request_kw)
File "/base/data/home/runtimes/python27/python27_dist/lib/python2.7/python_std_lib/httplib.py", line 973, in request
self._send_request(method, url, body, headers)
File "/base/data/home/runtimes/python27/python27_dist/lib/python2.7/python_std_lib/httplib.py", line 1007, in _send_request
self.endheaders(body)
File "/base/data/home/runtimes/python27/python27_dist/lib/python2.7/python_std_lib/httplib.py", line 969, in endheaders
self._send_output(message_body)
File "/base/data/home/runtimes/python27/python27_dist/lib/python2.7/python_std_lib/httplib.py", line 829, in _send_output
self.send(msg)
File "/base/data/home/runtimes/python27/python27_dist/lib/python2.7/python_std_lib/httplib.py", line 791, in send
self.connect()
/libs/requests/packages/urllib3/connection.py", line 156, in connect
*_self.conn_kw)
File "/base/data/home/runtimes/python27/python27_dist/lib/python2.7/socket.py", line 560, in create_connection
sock.connect(sa, host)
File "/base/data/home/runtimes/python27/python27_dist/lib/python2.7/socket.py", line 222, in meth
return getattr(self._sock,name)(*args)
File "/base/data/home/runtimes/python27/python27_lib/versions/1/google/appengine/api/remote_socket/_remote_socket.py", line 776, in connect
if translated_e.errno == errno.EISCONN:
AttributeError: 'ApplicationError' object has no attribute 'errno'
This was working up until recently, so I'm not sure what happened, thanks for the help!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2016/reactions"
} | https://api.github.com/repos/psf/requests/issues/2016/timeline | null | completed | null | null | false | [
"Thanks for raising this, but please don't raise an issue both here and on urllib3 at the same time. urllib3 and requests work very closely together and I was already looking at the urllib3 issue, so don't worry about it getting missed: we'll move the issue if necessary.\n",
"This matches shazow/urllib3#377.\n",
... |
https://api.github.com/repos/psf/requests/issues/2015 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2015/labels{/name} | https://api.github.com/repos/psf/requests/issues/2015/comments | https://api.github.com/repos/psf/requests/issues/2015/events | https://github.com/psf/requests/issues/2015 | 32,065,596 | MDU6SXNzdWUzMjA2NTU5Ng== | 2,015 | requests.get really slow when stream=True | {
"avatar_url": "https://avatars.githubusercontent.com/u/25111?v=4",
"events_url": "https://api.github.com/users/cournape/events{/privacy}",
"followers_url": "https://api.github.com/users/cournape/followers",
"following_url": "https://api.github.com/users/cournape/following{/other_user}",
"gists_url": "https://api.github.com/users/cournape/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cournape",
"id": 25111,
"login": "cournape",
"node_id": "MDQ6VXNlcjI1MTEx",
"organizations_url": "https://api.github.com/users/cournape/orgs",
"received_events_url": "https://api.github.com/users/cournape/received_events",
"repos_url": "https://api.github.com/users/cournape/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cournape/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cournape/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cournape",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-04-23T14:30:08Z | 2021-09-09T00:01:06Z | 2014-04-23T14:35:59Z | NONE | resolved | I noticed that using stream=True is really slow in some cases. Code that shows the issue:
```
import requests
url = "https://api.enthought.com/eggs/rh5-64/numpy-1.8.0-1.egg"
target = "numpy-1.8.0-1.egg"
use_streaming = True
if use_streaming:
resp = requests.get(url, stream=True)
else:
resp = requests.get(url)
resp.raise_for_status()
with open(target, "wb") as target:
if use_streaming:
for chunk in resp.iter_content():
target.write(chunk)
else:
target.write(resp.content)
```
With use_streaming=True, it takes around 40 sec, and only 2 sec when False. Running this script with strace, it looks like the chunk size is 1 byte:
```
...
recvfrom(4, "\345", 1, 0, NULL, NULL) = 1 # I see many lines like this
```
Looks like for some reason the chunk size is ridiculously small ?
I am using requests 2.2.1 on python 2.7 on debian.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2015/reactions"
} | https://api.github.com/repos/psf/requests/issues/2015/timeline | null | completed | null | null | false | [
"Hm, if I read the documentation correctly, I would have seen that the default chunk size is 1 byte... so nvm.\n\nIs there a rationale for such a small size ?\n",
"As you've spotted, by default `iter_content()`'s chunk size is 1, ensuring that it returns as rapidly as possible. This favours responsiveness over th... |
https://api.github.com/repos/psf/requests/issues/2014 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2014/labels{/name} | https://api.github.com/repos/psf/requests/issues/2014/comments | https://api.github.com/repos/psf/requests/issues/2014/events | https://github.com/psf/requests/issues/2014 | 32,051,740 | MDU6SXNzdWUzMjA1MTc0MA== | 2,014 | RuntimeWarning: Parent module 'requests' not found while handling absolute import | {
"avatar_url": "https://avatars.githubusercontent.com/u/260438?v=4",
"events_url": "https://api.github.com/users/dcarley/events{/privacy}",
"followers_url": "https://api.github.com/users/dcarley/followers",
"following_url": "https://api.github.com/users/dcarley/following{/other_user}",
"gists_url": "https://api.github.com/users/dcarley/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dcarley",
"id": 260438,
"login": "dcarley",
"node_id": "MDQ6VXNlcjI2MDQzOA==",
"organizations_url": "https://api.github.com/users/dcarley/orgs",
"received_events_url": "https://api.github.com/users/dcarley/received_events",
"repos_url": "https://api.github.com/users/dcarley/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dcarley/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dcarley/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dcarley",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 11 | 2014-04-23T11:14:11Z | 2018-04-23T14:41:42Z | 2014-06-08T09:59:44Z | NONE | resolved | I get this warning when running `nosetests` against a project:
```
$ nosetests
............../home/travis/virtualenv/python2.7/local/lib/python2.7/site-packages/requests/utils.py:72: RuntimeWarning: Parent module 'requests' not found while handling absolute import
from netrc import netrc, NetrcParseError
```
However I can't seem to reproduce it in a much simpler example, so I don't know if it's some specific combination of imports or something that nose/mock is doing. You can see that test here:
- https://travis-ci.org/gds-operations/collectd-cdn/jobs/23515951#L48
Going back to v2.0.0 prior to a501b0ca81e340fb2c968e1cabc37565187006f7 doesn't produce the same warning.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2014/reactions"
} | https://api.github.com/repos/psf/requests/issues/2014/timeline | null | completed | null | null | false | [
"Bizarre. Does this occur reproducibly when running your tests?\n",
"Yeah, everytime.\n\nYou should be able to reproduce it by cloning gds-operations/collectd-cdn@e9dc75523f77461d589ce251dc0fc662d48e1006 and running `tox`.\n",
"It's hugely confusing: it seems like requests is being removed from `sys.path`. Does... |
https://api.github.com/repos/psf/requests/issues/2013 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2013/labels{/name} | https://api.github.com/repos/psf/requests/issues/2013/comments | https://api.github.com/repos/psf/requests/issues/2013/events | https://github.com/psf/requests/pull/2013 | 32,017,810 | MDExOlB1bGxSZXF1ZXN0MTUwNDA3OTE= | 2,013 | eval compatible repr for `Request` | {
"avatar_url": "https://avatars.githubusercontent.com/u/175882?v=4",
"events_url": "https://api.github.com/users/cheecheeo/events{/privacy}",
"followers_url": "https://api.github.com/users/cheecheeo/followers",
"following_url": "https://api.github.com/users/cheecheeo/following{/other_user}",
"gists_url": "https://api.github.com/users/cheecheeo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cheecheeo",
"id": 175882,
"login": "cheecheeo",
"node_id": "MDQ6VXNlcjE3NTg4Mg==",
"organizations_url": "https://api.github.com/users/cheecheeo/orgs",
"received_events_url": "https://api.github.com/users/cheecheeo/received_events",
"repos_url": "https://api.github.com/users/cheecheeo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cheecheeo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cheecheeo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cheecheeo",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-04-22T22:46:44Z | 2021-09-08T22:01:15Z | 2014-04-23T06:24:30Z | NONE | resolved | After this change:
In [1]: from requests import Request
In [2]: eval(repr(Request('GET', 'http://x.org')))
Out[2]: Request(method='GET', url='http://x.org')
In [3]: eval(repr(Request('GET', 'http://x.org', auth=('hello', 'world'))))
Out[3]: Request(method='GET', url='http://x.org', auth=('hello', 'world'))
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2013/reactions"
} | https://api.github.com/repos/psf/requests/issues/2013/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2013.diff",
"html_url": "https://github.com/psf/requests/pull/2013",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/2013.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2013"
} | true | [
"Hey @cheecheeo, thanks for opening this!\n\nYour code is fine and the idea is valid. The problem is that this makes the rest of the library inconsistent and it is _not_ desired behaviour. We have no intent to implement this and we have never intended for the a Request's representation to be used like this.\n\nI'll... |
https://api.github.com/repos/psf/requests/issues/2012 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2012/labels{/name} | https://api.github.com/repos/psf/requests/issues/2012/comments | https://api.github.com/repos/psf/requests/issues/2012/events | https://github.com/psf/requests/issues/2012 | 31,940,963 | MDU6SXNzdWUzMTk0MDk2Mw== | 2,012 | Received "HTTP header is larger than 8192 bytes" but only given short one with requests. | {
"avatar_url": "https://avatars.githubusercontent.com/u/4996057?v=4",
"events_url": "https://api.github.com/users/hxuanji/events{/privacy}",
"followers_url": "https://api.github.com/users/hxuanji/followers",
"following_url": "https://api.github.com/users/hxuanji/following{/other_user}",
"gists_url": "https://api.github.com/users/hxuanji/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hxuanji",
"id": 4996057,
"login": "hxuanji",
"node_id": "MDQ6VXNlcjQ5OTYwNTc=",
"organizations_url": "https://api.github.com/users/hxuanji/orgs",
"received_events_url": "https://api.github.com/users/hxuanji/received_events",
"repos_url": "https://api.github.com/users/hxuanji/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hxuanji/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hxuanji/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hxuanji",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-04-22T02:30:37Z | 2021-09-09T00:01:05Z | 2014-04-23T10:47:03Z | NONE | resolved | Hi all,
I'm using requests 2.2.1. I encounter a problem as follows.
In ordinary situation, it all works fine. I use requests to do some communications with server and all the header I use is:
```
{"Connection": "close"}
```
But "occasionally" I got the exception as follows:
```
File "/share/HDA_DATA/package/lib/python2.7/site-packages/requests/api.py", line 88, in post
return request('post', url, data=data, **kwargs)
File "/share/HDA_DATA/package/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/share/HDA_DATA/package/lib/python2.7/site-packages/requests/sessions.py", line 383, in request
resp = self.send(prep, **send_kwargs)
File "/share/HDA_DATA/package/lib/python2.7/site-packages/requests/sessions.py", line 486, in send
r = adapter.send(request, **kwargs)
File "/share/HDA_DATA/package/lib/python2.7/site-packages/requests/adapters.py", line 378, in send
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='localhost', port=9200): Max retries exceeded with url: /cate/main/3719e564ece2ad3a267ecac0f4d8db6e74333046/ (Caused by <class 'socket.error'>: [Errno 104] Connection reset by peer)
```
And then I check the server log, I found the error log:
```
handler.codec.frame.TooLongFrameException: HTTP header is larger than 8192 bytes.
```
It's strange, because the header is less than 8k apparently and this situation does not always happen.
Does the requests append some extra http header?
Any suggestions?
cheers,
Ivan
| {
"avatar_url": "https://avatars.githubusercontent.com/u/4996057?v=4",
"events_url": "https://api.github.com/users/hxuanji/events{/privacy}",
"followers_url": "https://api.github.com/users/hxuanji/followers",
"following_url": "https://api.github.com/users/hxuanji/following{/other_user}",
"gists_url": "https://api.github.com/users/hxuanji/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hxuanji",
"id": 4996057,
"login": "hxuanji",
"node_id": "MDQ6VXNlcjQ5OTYwNTc=",
"organizations_url": "https://api.github.com/users/hxuanji/orgs",
"received_events_url": "https://api.github.com/users/hxuanji/received_events",
"repos_url": "https://api.github.com/users/hxuanji/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hxuanji/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hxuanji/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hxuanji",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2012/reactions"
} | https://api.github.com/repos/psf/requests/issues/2012/timeline | null | completed | null | null | false | [
"Requests adds a number of extra headers, but the only one that is plausibly going to be that long is cookies reflected back to the server.\n\nI recommend using Wireshark or tcpdump to determine which header the server is complaining about. \n",
"Ok, I think this might not be related to requests module. Thanks.\n... |
https://api.github.com/repos/psf/requests/issues/2011 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2011/labels{/name} | https://api.github.com/repos/psf/requests/issues/2011/comments | https://api.github.com/repos/psf/requests/issues/2011/events | https://github.com/psf/requests/issues/2011 | 31,903,837 | MDU6SXNzdWUzMTkwMzgzNw== | 2,011 | Feature Request: Add timeout to session | {
"avatar_url": "https://avatars.githubusercontent.com/u/167414?v=4",
"events_url": "https://api.github.com/users/ctheiss/events{/privacy}",
"followers_url": "https://api.github.com/users/ctheiss/followers",
"following_url": "https://api.github.com/users/ctheiss/following{/other_user}",
"gists_url": "https://api.github.com/users/ctheiss/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ctheiss",
"id": 167414,
"login": "ctheiss",
"node_id": "MDQ6VXNlcjE2NzQxNA==",
"organizations_url": "https://api.github.com/users/ctheiss/orgs",
"received_events_url": "https://api.github.com/users/ctheiss/received_events",
"repos_url": "https://api.github.com/users/ctheiss/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ctheiss/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ctheiss/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ctheiss",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 11 | 2014-04-21T16:01:43Z | 2021-08-31T00:06:54Z | 2014-04-21T16:04:32Z | NONE | resolved | It seems that every optional parameter that goes into send is also settable on the Session (e.g. verify, stream, etc.). Except timeout.
Would it be possible to change the behaviour so that timeout gets merged in from session just like all the other arguments?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/2011/reactions"
} | https://api.github.com/repos/psf/requests/issues/2011/timeline | null | completed | null | null | false | [
"@ctheiss Hey, thanks for raising this issue!\n\nThis is something that's come up before, most recently in #1987 but also in #1130 and #1563 (all this year). Kenneth has generally expressed a lack of interest in making this change, expecting that it'd be done using Transport Adapters. If you're interested in gettin... |
https://api.github.com/repos/psf/requests/issues/2010 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2010/labels{/name} | https://api.github.com/repos/psf/requests/issues/2010/comments | https://api.github.com/repos/psf/requests/issues/2010/events | https://github.com/psf/requests/pull/2010 | 31,808,782 | MDExOlB1bGxSZXF1ZXN0MTQ5MjQyMjc= | 2,010 | [WIP] Update philosophy section | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "fef2c0",
"default": false,
"descrip... | closed | true | null | [] | null | 7 | 2014-04-18T16:30:32Z | 2021-09-09T00:01:26Z | 2014-04-21T16:25:01Z | MEMBER | resolved | As @kennethreitz and I discussed at PyCon, this is a first pass at a rewrite of part of the Philosophy section of the docs, attempting to explain Requests' slightly unusual management style. I'd like some feedback.
Some ideas:
- should @shazow be mentioned? I felt like he should but I wasn't sure how best to explain the relationship.
- is there anything major that I've missed?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2010/reactions"
} | https://api.github.com/repos/psf/requests/issues/2010/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2010.diff",
"html_url": "https://github.com/psf/requests/pull/2010",
"merged_at": "2014-04-21T16:25:01Z",
"patch_url": "https://github.com/psf/requests/pull/2010.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2010"
} | true | [
"I'm like Requests' spouse.\n\nMrs. Requests.\n\n#jkpleasedontsaythat\n",
"=D\n\nI want to mention you, because I feel like you don't get enough credit. =)\n",
"❤\n",
"FYI, I made these changes a few days ago: http://docs.python-requests.org/en/latest/dev/authors/#core-contributors\n",
"@kennethreitz Yeah, ... |
https://api.github.com/repos/psf/requests/issues/2009 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2009/labels{/name} | https://api.github.com/repos/psf/requests/issues/2009/comments | https://api.github.com/repos/psf/requests/issues/2009/events | https://github.com/psf/requests/pull/2009 | 31,805,603 | MDExOlB1bGxSZXF1ZXN0MTQ5MjI0NTI= | 2,009 | Fix my name | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-04-18T15:36:05Z | 2021-09-08T23:06:03Z | 2014-04-18T16:13:17Z | CONTRIBUTOR | resolved | 24 not 42 ;)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2009/reactions"
} | https://api.github.com/repos/psf/requests/issues/2009/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2009.diff",
"html_url": "https://github.com/psf/requests/pull/2009",
"merged_at": "2014-04-18T16:13:17Z",
"patch_url": "https://github.com/psf/requests/pull/2009.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2009"
} | true | [
"10/10 would merge again. :cake:\n",
"42/24 would PR again. :grinning: \n"
] |
https://api.github.com/repos/psf/requests/issues/2008 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2008/labels{/name} | https://api.github.com/repos/psf/requests/issues/2008/comments | https://api.github.com/repos/psf/requests/issues/2008/events | https://github.com/psf/requests/issues/2008 | 31,783,205 | MDU6SXNzdWUzMTc4MzIwNQ== | 2,008 | urllib3 has been updated to new version 1.8.1, "source_address" is supported. May the requests lib support it? | {
"avatar_url": "https://avatars.githubusercontent.com/u/7300843?v=4",
"events_url": "https://api.github.com/users/bofortitude/events{/privacy}",
"followers_url": "https://api.github.com/users/bofortitude/followers",
"following_url": "https://api.github.com/users/bofortitude/following{/other_user}",
"gists_url": "https://api.github.com/users/bofortitude/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bofortitude",
"id": 7300843,
"login": "bofortitude",
"node_id": "MDQ6VXNlcjczMDA4NDM=",
"organizations_url": "https://api.github.com/users/bofortitude/orgs",
"received_events_url": "https://api.github.com/users/bofortitude/received_events",
"repos_url": "https://api.github.com/users/bofortitude/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bofortitude/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bofortitude/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bofortitude",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 32 | 2014-04-18T06:07:16Z | 2018-03-23T02:08:42Z | 2014-04-18T09:34:09Z | NONE | off-topic | New version urllib3 has been updated to 1.8.1 which support the "source_address"(in Python v2.7). Could you do something change to support it. It's really useful and needed. I will appreciate it very much.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2008/reactions"
} | https://api.github.com/repos/psf/requests/issues/2008/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nRequests doesn't plan to add this to the main API, it's simply not commonly used enough to justify the increased complexity. My recommendation is that you use our [Transport Adapter abstraction](http://docs.python-requests.org/en/latest/user/advanced/#transport-adapters) to provid... |
https://api.github.com/repos/psf/requests/issues/2007 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2007/labels{/name} | https://api.github.com/repos/psf/requests/issues/2007/comments | https://api.github.com/repos/psf/requests/issues/2007/events | https://github.com/psf/requests/issues/2007 | 31,683,974 | MDU6SXNzdWUzMTY4Mzk3NA== | 2,007 | Update PyPi to v2.3.0 | {
"avatar_url": "https://avatars.githubusercontent.com/u/310419?v=4",
"events_url": "https://api.github.com/users/kromped/events{/privacy}",
"followers_url": "https://api.github.com/users/kromped/followers",
"following_url": "https://api.github.com/users/kromped/following{/other_user}",
"gists_url": "https://api.github.com/users/kromped/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kromped",
"id": 310419,
"login": "kromped",
"node_id": "MDQ6VXNlcjMxMDQxOQ==",
"organizations_url": "https://api.github.com/users/kromped/orgs",
"received_events_url": "https://api.github.com/users/kromped/received_events",
"repos_url": "https://api.github.com/users/kromped/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kromped/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kromped/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kromped",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-04-16T22:01:45Z | 2021-09-09T00:01:07Z | 2014-04-16T22:04:10Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2007/reactions"
} | https://api.github.com/repos/psf/requests/issues/2007/timeline | null | completed | null | null | false | [
"2.3.0 does not exist yet: see #1968. It's a mismatch in the docs. =)\n"
] | |
https://api.github.com/repos/psf/requests/issues/2006 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2006/labels{/name} | https://api.github.com/repos/psf/requests/issues/2006/comments | https://api.github.com/repos/psf/requests/issues/2006/events | https://github.com/psf/requests/issues/2006 | 31,674,336 | MDU6SXNzdWUzMTY3NDMzNg== | 2,006 | Feature request: automatic auth type detection | {
"avatar_url": "https://avatars.githubusercontent.com/u/837573?v=4",
"events_url": "https://api.github.com/users/untitaker/events{/privacy}",
"followers_url": "https://api.github.com/users/untitaker/followers",
"following_url": "https://api.github.com/users/untitaker/following{/other_user}",
"gists_url": "https://api.github.com/users/untitaker/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/untitaker",
"id": 837573,
"login": "untitaker",
"node_id": "MDQ6VXNlcjgzNzU3Mw==",
"organizations_url": "https://api.github.com/users/untitaker/orgs",
"received_events_url": "https://api.github.com/users/untitaker/received_events",
"repos_url": "https://api.github.com/users/untitaker/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/untitaker/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/untitaker/subscriptions",
"type": "User",
"url": "https://api.github.com/users/untitaker",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2014-04-16T20:01:08Z | 2021-09-08T23:11:02Z | 2014-06-08T09:49:14Z | CONTRIBUTOR | resolved | requests could figure out whether it needs to use `digest` or `basic` auth by inspecting the `WWW-Authenticate` header.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2006/reactions"
} | https://api.github.com/repos/psf/requests/issues/2006/timeline | null | completed | null | null | false | [
"This is an interesting idea @untitaker! It does feel like it'd be useful.\n\nI wonder if we should trial it in [the toolbelt](https://github.com/sigmavirus24/requests-toolbelt) first, see if it's useful. @sigmavirus24?\n",
"IIRC you said (in IRC or so) that request sends the auth headers preemptively, which mean... |
https://api.github.com/repos/psf/requests/issues/2005 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2005/labels{/name} | https://api.github.com/repos/psf/requests/issues/2005/comments | https://api.github.com/repos/psf/requests/issues/2005/events | https://github.com/psf/requests/pull/2005 | 31,650,540 | MDExOlB1bGxSZXF1ZXN0MTQ4MjgyNTA= | 2,005 | SVG logo version | {
"avatar_url": "https://avatars.githubusercontent.com/u/1292133?v=4",
"events_url": "https://api.github.com/users/ap-Codkelden/events{/privacy}",
"followers_url": "https://api.github.com/users/ap-Codkelden/followers",
"following_url": "https://api.github.com/users/ap-Codkelden/following{/other_user}",
"gists_url": "https://api.github.com/users/ap-Codkelden/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ap-Codkelden",
"id": 1292133,
"login": "ap-Codkelden",
"node_id": "MDQ6VXNlcjEyOTIxMzM=",
"organizations_url": "https://api.github.com/users/ap-Codkelden/orgs",
"received_events_url": "https://api.github.com/users/ap-Codkelden/received_events",
"repos_url": "https://api.github.com/users/ap-Codkelden/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ap-Codkelden/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ap-Codkelden/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ap-Codkelden",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-04-16T15:14:41Z | 2021-09-08T23:06:08Z | 2014-04-16T19:37:29Z | CONTRIBUTOR | resolved | SVG version of Requests logo for users, which have not Palatino-Roman fonts and so on.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2005/reactions"
} | https://api.github.com/repos/psf/requests/issues/2005/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/2005.diff",
"html_url": "https://github.com/psf/requests/pull/2005",
"merged_at": "2014-04-16T19:37:29Z",
"patch_url": "https://github.com/psf/requests/pull/2005.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/2005"
} | true | [
"Hooray! :+1: :cake:\n",
":sparkles: :typeface: :sparkles:\n",
":koala:\n"
] |
https://api.github.com/repos/psf/requests/issues/2004 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2004/labels{/name} | https://api.github.com/repos/psf/requests/issues/2004/comments | https://api.github.com/repos/psf/requests/issues/2004/events | https://github.com/psf/requests/issues/2004 | 31,607,340 | MDU6SXNzdWUzMTYwNzM0MA== | 2,004 | ResourceWarnings | {
"avatar_url": "https://avatars.githubusercontent.com/u/681260?v=4",
"events_url": "https://api.github.com/users/giampaolo/events{/privacy}",
"followers_url": "https://api.github.com/users/giampaolo/followers",
"following_url": "https://api.github.com/users/giampaolo/following{/other_user}",
"gists_url": "https://api.github.com/users/giampaolo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/giampaolo",
"id": 681260,
"login": "giampaolo",
"node_id": "MDQ6VXNlcjY4MTI2MA==",
"organizations_url": "https://api.github.com/users/giampaolo/orgs",
"received_events_url": "https://api.github.com/users/giampaolo/received_events",
"repos_url": "https://api.github.com/users/giampaolo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/giampaolo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/giampaolo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/giampaolo",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-04-16T02:13:50Z | 2021-09-09T00:01:08Z | 2014-04-16T10:08:26Z | NONE | resolved | ```
$ python3.4 -W "a" -c "import requests; requests.get('http://google.com')"
-c:1: ResourceWarning: unclosed <socket.socket fd=5, family=AddressFamily.AF_INET, type=SocketType.SOCK_STREAM, proto=6, laddr=('192.168.1.2', 60578), raddr=('173.194.35.151', 80)>
-c:1: ResourceWarning: unclosed <socket.socket fd=4, family=AddressFamily.AF_INET, type=SocketType.SOCK_STREAM, proto=6, laddr=('192.168.1.2', 36102), raddr=('173.194.35.46', 80)>
```
Same thing happens if I close() the object returned by request.get().
Unfortunately the traceback is not very helpful for determining _where_ exactly this occurs.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2004/reactions"
} | https://api.github.com/repos/psf/requests/issues/2004/timeline | null | completed | null | null | false | [
"@giampaolo This is an artifact of our connection pooling. The socket objects aren't being explicitly closed because reusing them is cheaper than making new syscalls and reassembling the object. This is tracked in #1882.\n",
"Is there any way to tell requests/urllib3 to close the socket pool? \nNote: I need this ... |
https://api.github.com/repos/psf/requests/issues/2003 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2003/labels{/name} | https://api.github.com/repos/psf/requests/issues/2003/comments | https://api.github.com/repos/psf/requests/issues/2003/events | https://github.com/psf/requests/issues/2003 | 31,525,291 | MDU6SXNzdWUzMTUyNTI5MQ== | 2,003 | auth kwarg cannot be used to authenticate an HTTPS request through a HTTP proxy | {
"avatar_url": "https://avatars.githubusercontent.com/u/638?v=4",
"events_url": "https://api.github.com/users/pjjw/events{/privacy}",
"followers_url": "https://api.github.com/users/pjjw/followers",
"following_url": "https://api.github.com/users/pjjw/following{/other_user}",
"gists_url": "https://api.github.com/users/pjjw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/pjjw",
"id": 638,
"login": "pjjw",
"node_id": "MDQ6VXNlcjYzOA==",
"organizations_url": "https://api.github.com/users/pjjw/orgs",
"received_events_url": "https://api.github.com/users/pjjw/received_events",
"repos_url": "https://api.github.com/users/pjjw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/pjjw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/pjjw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/pjjw",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"... | closed | true | null | [] | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 7 | 2014-04-15T04:18:58Z | 2021-09-08T13:05:39Z | 2016-12-17T17:00:48Z | NONE | resolved | i mean so this is probably more of a rant than an issue, but that was 3 hours i won't get back.
was trying to pipe requests through a squid proxy in a lights-out environment. credentials come from a data store separate from configuration, so seemed reasonable to use requests.auth.HTTPProxyAuth(l, p) as the auth kwarg as (what i thought) a supplement to the proxies dict fed to the proxies kwarg. this works fine for http requests, but this seems to be by accident- it falls apart when making an https request through a proxy, when urllib3 uses the CONNECT verb to encapsulate the request.
basically requests.auth.HTTPProxyAuth doesn't make it clear that it's not the correct (always working) way to authenticate to a proxy, but that you must put the credentials into the proxy url in the proxies dict. deprecation/removal of that class would probably make the interface cleaner- failing that, a note in the source would be nice.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2003/reactions"
} | https://api.github.com/repos/psf/requests/issues/2003/timeline | null | completed | null | null | false | [
"Yeah, agreed: I think we should aim to remove `HTTPProxyAuth` in version 3.0.\n",
":+1: for 3.0 removal.\n",
"Are we still in agreement that this should be on it's way?",
"@nateprewitt I am in agreement, but I would be unsurprised if Cory changed his mind. Since he's on holiday, why don't you hold off on wor... |
https://api.github.com/repos/psf/requests/issues/2002 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2002/labels{/name} | https://api.github.com/repos/psf/requests/issues/2002/comments | https://api.github.com/repos/psf/requests/issues/2002/events | https://github.com/psf/requests/issues/2002 | 31,505,086 | MDU6SXNzdWUzMTUwNTA4Ng== | 2,002 | bool(failure response) is False | {
"avatar_url": "https://avatars.githubusercontent.com/u/98610?v=4",
"events_url": "https://api.github.com/users/slinkp/events{/privacy}",
"followers_url": "https://api.github.com/users/slinkp/followers",
"following_url": "https://api.github.com/users/slinkp/following{/other_user}",
"gists_url": "https://api.github.com/users/slinkp/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/slinkp",
"id": 98610,
"login": "slinkp",
"node_id": "MDQ6VXNlcjk4NjEw",
"organizations_url": "https://api.github.com/users/slinkp/orgs",
"received_events_url": "https://api.github.com/users/slinkp/received_events",
"repos_url": "https://api.github.com/users/slinkp/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/slinkp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/slinkp/subscriptions",
"type": "User",
"url": "https://api.github.com/users/slinkp",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "eb6420",
"default": false,
"description": null... | open | false | null | [] | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 20 | 2014-04-14T21:09:55Z | 2016-04-15T21:39:43Z | null | NONE | null | This is rather surprising, and not documented that I've seen (though I could certainly have missed it):
```
>>> r = requests.request('get', 'http://google.com/aopsdufsaf')
>>> r
<Response [404]>
>>> bool(r)
False
```
To me, "failure = false" is neither intuitive nor expected.
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2002/reactions"
} | https://api.github.com/repos/psf/requests/issues/2002/timeline | null | null | null | null | false | [
"+1\n\nA common pattern is\n\n``` python\nresp = None\n\ntry:\n resp = requests.get(...)\nexcept:\n log.exception(\"ruh roh\")\n\nif resp:\n print(\"we got somethin'!\")\n handle_resp(resp)\n```\n\nThe current implementation of `__bool__` makes this intuitive pattern very tricky when writing code that a... |
https://api.github.com/repos/psf/requests/issues/2001 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2001/labels{/name} | https://api.github.com/repos/psf/requests/issues/2001/comments | https://api.github.com/repos/psf/requests/issues/2001/events | https://github.com/psf/requests/issues/2001 | 31,429,074 | MDU6SXNzdWUzMTQyOTA3NA== | 2,001 | Pull latest [urllib3] to fix HTTPSConnection Redirect Loop on AppEngine | {
"avatar_url": "https://avatars.githubusercontent.com/u/423702?v=4",
"events_url": "https://api.github.com/users/soelinn/events{/privacy}",
"followers_url": "https://api.github.com/users/soelinn/followers",
"following_url": "https://api.github.com/users/soelinn/following{/other_user}",
"gists_url": "https://api.github.com/users/soelinn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/soelinn",
"id": 423702,
"login": "soelinn",
"node_id": "MDQ6VXNlcjQyMzcwMg==",
"organizations_url": "https://api.github.com/users/soelinn/orgs",
"received_events_url": "https://api.github.com/users/soelinn/received_events",
"repos_url": "https://api.github.com/users/soelinn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/soelinn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/soelinn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/soelinn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-04-14T01:15:11Z | 2021-09-08T23:11:00Z | 2014-06-08T10:02:36Z | NONE | resolved | HTTPSConnection is going out as HTTP on AppEngine 1.9.0 and causing a redirect loop error.
Please pull the latest version of [urllib3]. Here is the commit for the urllib3 that fixes this issue.
https://github.com/shazow/urllib3/commit/627fc7a897e8e52b59d8ca2eb3d5ebccbe66ac7a
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2001/reactions"
} | https://api.github.com/repos/psf/requests/issues/2001/timeline | null | completed | null | null | false | [
"This is resolved and should be in 2.3.0.\n"
] |
https://api.github.com/repos/psf/requests/issues/2000 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/2000/labels{/name} | https://api.github.com/repos/psf/requests/issues/2000/comments | https://api.github.com/repos/psf/requests/issues/2000/events | https://github.com/psf/requests/issues/2000 | 31,425,191 | MDU6SXNzdWUzMTQyNTE5MQ== | 2,000 | Requests.get() will void SIGINT if it's in a thread | {
"avatar_url": "https://avatars.githubusercontent.com/u/1433949?v=4",
"events_url": "https://api.github.com/users/steven-shi/events{/privacy}",
"followers_url": "https://api.github.com/users/steven-shi/followers",
"following_url": "https://api.github.com/users/steven-shi/following{/other_user}",
"gists_url": "https://api.github.com/users/steven-shi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/steven-shi",
"id": 1433949,
"login": "steven-shi",
"node_id": "MDQ6VXNlcjE0MzM5NDk=",
"organizations_url": "https://api.github.com/users/steven-shi/orgs",
"received_events_url": "https://api.github.com/users/steven-shi/received_events",
"repos_url": "https://api.github.com/users/steven-shi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/steven-shi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/steven-shi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/steven-shi",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-04-13T21:58:29Z | 2021-09-09T00:01:08Z | 2014-04-13T22:30:14Z | NONE | resolved | Hi, I would like to have a gentle way to shutdown the Thread by hooking SIGINT, but noticed once Requests been used in Thread, it will void Signal handler. Please test following example, and you will notice you cannot shut down by CTRL+C even the SIGINT has been hooked.
``` python
import requests
import signal
import time
from threading import Thread
import sys
def shutdownHandler(signal, frame):
print "Shutting down..."
sys.exit(0)
def test_load():
x=requests.get('http://www.google.com')
x.close()
time.sleep(200000)
if __name__ == '__main__':
signal.signal(signal.SIGINT, shutdownHandler)
t=Thread(target = test_load)
t.start()
signal.pause()
t.join()
```
If you comment out
``` python
x=requests.get('http://www.google.com')
x.close()
```
Then run again, and press Ctrl+C, the process will be shutting down.
Any idea what's going in Requests?
Thanks a lot
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/2000/reactions"
} | https://api.github.com/repos/psf/requests/issues/2000/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nRequests uses httplib under the covers, which is known to have the problem of consuming SIGINT. You can see this [here](http://cuddihyd.bitbucket.org/tm/python-ctrl-c.html). Unfortunately there's nothing we can do about this directly, you'd need to fix the bug in Python itself. Th... |
https://api.github.com/repos/psf/requests/issues/1999 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1999/labels{/name} | https://api.github.com/repos/psf/requests/issues/1999/comments | https://api.github.com/repos/psf/requests/issues/1999/events | https://github.com/psf/requests/pull/1999 | 31,388,342 | MDExOlB1bGxSZXF1ZXN0MTQ2ODc2MTA= | 1,999 | Font layer in logo convert to curves | {
"avatar_url": "https://avatars.githubusercontent.com/u/1292133?v=4",
"events_url": "https://api.github.com/users/ap-Codkelden/events{/privacy}",
"followers_url": "https://api.github.com/users/ap-Codkelden/followers",
"following_url": "https://api.github.com/users/ap-Codkelden/following{/other_user}",
"gists_url": "https://api.github.com/users/ap-Codkelden/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ap-Codkelden",
"id": 1292133,
"login": "ap-Codkelden",
"node_id": "MDQ6VXNlcjEyOTIxMzM=",
"organizations_url": "https://api.github.com/users/ap-Codkelden/orgs",
"received_events_url": "https://api.github.com/users/ap-Codkelden/received_events",
"repos_url": "https://api.github.com/users/ap-Codkelden/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ap-Codkelden/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ap-Codkelden/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ap-Codkelden",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 5 | 2014-04-12T18:21:34Z | 2021-09-08T22:01:14Z | 2014-04-16T14:56:44Z | CONTRIBUTOR | resolved | Some users may not have Palatino-Roman font, but in curves form they can use logo.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1999/reactions"
} | https://api.github.com/repos/psf/requests/issues/1999/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1999.diff",
"html_url": "https://github.com/psf/requests/pull/1999",
"merged_at": "2014-04-16T14:56:44Z",
"patch_url": "https://github.com/psf/requests/pull/1999.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1999"
} | true | [
"This looks great to me, thanks! :cake: @kennethreitz, are you happy with this?\n",
"Sorry, wrong answer in gmail. Thanks for approve!\n\n2014-04-12 21:37 GMT+03:00 Cory Benfield notifications@github.com:\n\n> This looks great to me, thanks! [image: :cake:]@kennethreitzhttps://github.com/kennethreitz,\n> are you ... |
https://api.github.com/repos/psf/requests/issues/1998 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1998/labels{/name} | https://api.github.com/repos/psf/requests/issues/1998/comments | https://api.github.com/repos/psf/requests/issues/1998/events | https://github.com/psf/requests/pull/1998 | 31,212,137 | MDExOlB1bGxSZXF1ZXN0MTQ1ODU2Nzk= | 1,998 | Fix typo | {
"avatar_url": "https://avatars.githubusercontent.com/u/66017?v=4",
"events_url": "https://api.github.com/users/kapyshin/events{/privacy}",
"followers_url": "https://api.github.com/users/kapyshin/followers",
"following_url": "https://api.github.com/users/kapyshin/following{/other_user}",
"gists_url": "https://api.github.com/users/kapyshin/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kapyshin",
"id": 66017,
"login": "kapyshin",
"node_id": "MDQ6VXNlcjY2MDE3",
"organizations_url": "https://api.github.com/users/kapyshin/orgs",
"received_events_url": "https://api.github.com/users/kapyshin/received_events",
"repos_url": "https://api.github.com/users/kapyshin/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kapyshin/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kapyshin/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kapyshin",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-04-10T03:11:30Z | 2021-09-08T22:01:15Z | 2014-04-10T05:46:05Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1998/reactions"
} | https://api.github.com/repos/psf/requests/issues/1998/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1998.diff",
"html_url": "https://github.com/psf/requests/pull/1998",
"merged_at": "2014-04-10T05:46:05Z",
"patch_url": "https://github.com/psf/requests/pull/1998.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1998"
} | true | [
"Thanks for this! :cake:\n"
] | |
https://api.github.com/repos/psf/requests/issues/1997 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1997/labels{/name} | https://api.github.com/repos/psf/requests/issues/1997/comments | https://api.github.com/repos/psf/requests/issues/1997/events | https://github.com/psf/requests/issues/1997 | 31,173,167 | MDU6SXNzdWUzMTE3MzE2Nw== | 1,997 | boundary for custom 'Content-Type: multipart/form-data' header | {
"avatar_url": "https://avatars.githubusercontent.com/u/319736?v=4",
"events_url": "https://api.github.com/users/jcfrank/events{/privacy}",
"followers_url": "https://api.github.com/users/jcfrank/followers",
"following_url": "https://api.github.com/users/jcfrank/following{/other_user}",
"gists_url": "https://api.github.com/users/jcfrank/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jcfrank",
"id": 319736,
"login": "jcfrank",
"node_id": "MDQ6VXNlcjMxOTczNg==",
"organizations_url": "https://api.github.com/users/jcfrank/orgs",
"received_events_url": "https://api.github.com/users/jcfrank/received_events",
"repos_url": "https://api.github.com/users/jcfrank/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jcfrank/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jcfrank/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jcfrank",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 14 | 2014-04-09T16:35:42Z | 2021-08-31T00:06:42Z | 2014-06-08T10:03:37Z | NONE | resolved | # Test Script
Send a muli-part post file request with custom boundary.
```
import requests
import os.path
filepath = '/tmp/test.tgz'
with open(filepath, 'rb') as f:
files = {'file':f}
headers = {'Content-Type':'multipart/form-data;boundary=***someboundary***'}
r = requests.post('http://127.0.0.1:56500/', files=files, headers=headers)
```
# Actual Result
```
$ nc -p 56500 -l
POST / HTTP/1.1
Host: 127.0.0.1:56500
Accept-Encoding: gzip, deflate, compress
User-Agent: python-requests/2.2.1 CPython/3.4.0 Linux/3.8.0-35-generic
Content-Length: 277
Content-Type: multipart/form-data;boundary=***someboundary***
Accept: */*
--84989444e2484915a216e1718e0f93f0
Content-Disposition: form-data; name="file"; filename="test.tgz"
VlES�
��aws9���"ـ����E�)f��i�>.!;қ�>1ܼ5��I�<���Q���|lf���S���~ �8�C
--84989444e2484915a216e1718e0f93f0--
```
# Expected Result
```
$ nc -p 56500 -l
POST / HTTP/1.1
Host: 127.0.0.1:56500
Accept-Encoding: gzip, deflate, compress
User-Agent: python-requests/2.2.1 CPython/3.4.0 Linux/3.8.0-35-generic
Content-Length: 277
Content-Type: multipart/form-data;boundary=***someboundary***
Accept: */*
--***someboundary***
Content-Disposition: form-data; name="file"; filename="test.tgz"
VlES�
��aws9���"ـ����E�)f��i�>.!;қ�>1ܼ5��I�<���Q���|lf���S���~ �8�C
--***someboundary***--
```
'boundary' is a parameter required by multipart entities. However, when I specify the custom boundary in headers, the sent request still uses generated boundary. It dosen't help even if I remove the 'boundary=...' part.
The only way to avoid this issue is to **not** specify the custom **Content-Type** as multipart in headers and let the scripts themselves generate it.
I am new to this package and the issue got me stuck for hours. So... maybe there should be a warning about this in document or maybe the customized boundary part should be implemented?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 3,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 2,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 5,
"url": "https://api.github.com/repos/psf/requests/issues/1997/reactions"
} | https://api.github.com/repos/psf/requests/issues/1997/timeline | null | completed | null | null | false | [
"This is similar to problems many people have when coming from less useful HTTP libraries. However, the documentation is very clear about how to [post multipart files](http://docs.python-requests.org/en/latest/user/quickstart/#post-a-multipart-encoded-file). Otherwise, all we could reasonably do is have a general n... |
https://api.github.com/repos/psf/requests/issues/1996 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1996/labels{/name} | https://api.github.com/repos/psf/requests/issues/1996/comments | https://api.github.com/repos/psf/requests/issues/1996/events | https://github.com/psf/requests/issues/1996 | 31,021,562 | MDU6SXNzdWUzMTAyMTU2Mg== | 1,996 | MIME type no longer set on file upload | {
"avatar_url": "https://avatars.githubusercontent.com/u/3502082?v=4",
"events_url": "https://api.github.com/users/wtip/events{/privacy}",
"followers_url": "https://api.github.com/users/wtip/followers",
"following_url": "https://api.github.com/users/wtip/following{/other_user}",
"gists_url": "https://api.github.com/users/wtip/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/wtip",
"id": 3502082,
"login": "wtip",
"node_id": "MDQ6VXNlcjM1MDIwODI=",
"organizations_url": "https://api.github.com/users/wtip/orgs",
"received_events_url": "https://api.github.com/users/wtip/received_events",
"repos_url": "https://api.github.com/users/wtip/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/wtip/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wtip/subscriptions",
"type": "User",
"url": "https://api.github.com/users/wtip",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "fad8c7",
"default": false,
"descrip... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 6 | 2014-04-07T20:58:49Z | 2021-09-08T23:04:50Z | 2015-05-03T15:11:13Z | NONE | resolved | I have the following code that was working fine with requests 1.2.0 but is not working with 2.2.1
``` python
while True:
try: # Try to upload the image
f = open (img_name,'rb')
r = requests.post(url='http://myurl.com/post', data = {'Upload':'upload'}, files = {'userfile':f}, timeout=30)
print r.status_code
r.raise_for_status()
break # If the upload completes without errors break out of the loop
except requests.exceptions.RequestException:
print "Something went wrong, waiting and then trying again"
time.sleep(30)
```
The code runs without errors but the image is not uploaded. The upload page rejects the post due to unsupported file type. I did a tcpdump capture while running the code with both versions of requests. The main difference I saw was that requests 1.2.0 properly sets Content-Type: image/jpeg while with requests 2.2.1 I did not see Content-Type header.
Am I doing something wrong or is this a bug?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1996/reactions"
} | https://api.github.com/repos/psf/requests/issues/1996/timeline | null | completed | null | null | false | [
"Are you expecting the `Content-Type` header on the request or on one of the parts of the multipart upload?\n",
"I am expecting Content-Type on the second part of the multipart upload. This is properly done with requests 1.2.0\n",
"Hmm, yup, from looking at the code it's clear that we no longer guess the MIME t... |
https://api.github.com/repos/psf/requests/issues/1995 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1995/labels{/name} | https://api.github.com/repos/psf/requests/issues/1995/comments | https://api.github.com/repos/psf/requests/issues/1995/events | https://github.com/psf/requests/issues/1995 | 30,949,718 | MDU6SXNzdWUzMDk0OTcxOA== | 1,995 | Create an Extra for Better SSL Support | {
"avatar_url": "https://avatars.githubusercontent.com/u/145979?v=4",
"events_url": "https://api.github.com/users/dstufft/events{/privacy}",
"followers_url": "https://api.github.com/users/dstufft/followers",
"following_url": "https://api.github.com/users/dstufft/following{/other_user}",
"gists_url": "https://api.github.com/users/dstufft/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dstufft",
"id": 145979,
"login": "dstufft",
"node_id": "MDQ6VXNlcjE0NTk3OQ==",
"organizations_url": "https://api.github.com/users/dstufft/orgs",
"received_events_url": "https://api.github.com/users/dstufft/received_events",
"repos_url": "https://api.github.com/users/dstufft/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dstufft/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dstufft/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dstufft",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 19127... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 11 | 2014-04-06T22:00:00Z | 2018-10-15T12:22:04Z | 2014-09-04T18:36:56Z | CONTRIBUTOR | resolved | So right now the SSL connections when you use pyOpenSSL, ndg-httspclient, and pyasn1 are more secure than if you just use the stdlib options. However it's hard to actually remember those three things. It would be cool if requests would add an extra to it's setup.py so that people can install requests with betterssl, something like:
``` python
setup(
extras_require={
"betterssl": ["pyOpenSSL", "ndg-httpsclient", "pyasn1"],
},
)
```
Would make it so people can install requests like `pip install requests[betterssl]` and get all of those dependencies without having to manually track those down. It also means people could depend on `requests[betterssl]` instead of just `requests` in their own setup.py's.
Extra name can of course be bikeshed here :)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1995/reactions"
} | https://api.github.com/repos/psf/requests/issues/1995/timeline | null | completed | null | null | false | [
"Also by default requests can't connect to some sites on OSX because of ancient OpenSSL. Using the above 3 packages makes it possible.\n\n```\nPython 2.7.5 (default, Sep 12 2013, 21:33:34)\n[GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68)] on darwin\nType \"help\", \"copyright\", \"credits\" or \"license\" for... |
https://api.github.com/repos/psf/requests/issues/1994 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1994/labels{/name} | https://api.github.com/repos/psf/requests/issues/1994/comments | https://api.github.com/repos/psf/requests/issues/1994/events | https://github.com/psf/requests/pull/1994 | 30,915,811 | MDExOlB1bGxSZXF1ZXN0MTQ0MTUyMzg= | 1,994 | Make it more clear where install commands are run | {
"avatar_url": "https://avatars.githubusercontent.com/u/129501?v=4",
"events_url": "https://api.github.com/users/ionelmc/events{/privacy}",
"followers_url": "https://api.github.com/users/ionelmc/followers",
"following_url": "https://api.github.com/users/ionelmc/following{/other_user}",
"gists_url": "https://api.github.com/users/ionelmc/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ionelmc",
"id": 129501,
"login": "ionelmc",
"node_id": "MDQ6VXNlcjEyOTUwMQ==",
"organizations_url": "https://api.github.com/users/ionelmc/orgs",
"received_events_url": "https://api.github.com/users/ionelmc/received_events",
"repos_url": "https://api.github.com/users/ionelmc/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ionelmc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ionelmc/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ionelmc",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 15 | 2014-04-05T13:40:47Z | 2021-09-08T22:01:14Z | 2014-04-05T15:35:16Z | CONTRIBUTOR | resolved | so that newbies don't run them in the REPL, I've seen it happen :smile:
| {
"avatar_url": "https://avatars.githubusercontent.com/u/129501?v=4",
"events_url": "https://api.github.com/users/ionelmc/events{/privacy}",
"followers_url": "https://api.github.com/users/ionelmc/followers",
"following_url": "https://api.github.com/users/ionelmc/following{/other_user}",
"gists_url": "https://api.github.com/users/ionelmc/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ionelmc",
"id": 129501,
"login": "ionelmc",
"node_id": "MDQ6VXNlcjEyOTUwMQ==",
"organizations_url": "https://api.github.com/users/ionelmc/orgs",
"received_events_url": "https://api.github.com/users/ionelmc/received_events",
"repos_url": "https://api.github.com/users/ionelmc/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ionelmc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ionelmc/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ionelmc",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1994/reactions"
} | https://api.github.com/repos/psf/requests/issues/1994/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1994.diff",
"html_url": "https://github.com/psf/requests/pull/1994",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1994.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1994"
} | true | [
"@ionelmc Thanks for this! Leave the '$' signs in (we like it stylistically) and I'll happily merge it. =)\n",
"It's poor style - it's not clear for newbies what the \"$\" stands for.\n",
"And frankly, it just makes things harder to copy-paste, even if you know the obscure story about \"$\"\n",
"You'll note t... |
https://api.github.com/repos/psf/requests/issues/1993 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1993/labels{/name} | https://api.github.com/repos/psf/requests/issues/1993/comments | https://api.github.com/repos/psf/requests/issues/1993/events | https://github.com/psf/requests/pull/1993 | 30,910,114 | MDExOlB1bGxSZXF1ZXN0MTQ0MTI5NzY= | 1,993 | Format doc section header | {
"avatar_url": "https://avatars.githubusercontent.com/u/5571478?v=4",
"events_url": "https://api.github.com/users/RichVisual/events{/privacy}",
"followers_url": "https://api.github.com/users/RichVisual/followers",
"following_url": "https://api.github.com/users/RichVisual/following{/other_user}",
"gists_url": "https://api.github.com/users/RichVisual/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/RichVisual",
"id": 5571478,
"login": "RichVisual",
"node_id": "MDQ6VXNlcjU1NzE0Nzg=",
"organizations_url": "https://api.github.com/users/RichVisual/orgs",
"received_events_url": "https://api.github.com/users/RichVisual/received_events",
"repos_url": "https://api.github.com/users/RichVisual/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/RichVisual/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RichVisual/subscriptions",
"type": "User",
"url": "https://api.github.com/users/RichVisual",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-04-05T06:51:07Z | 2021-09-08T22:01:13Z | 2014-04-05T07:19:48Z | NONE | resolved | Seemed like this should have been formatted as a header (it was just
regular text) to avoid confusion.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1993/reactions"
} | https://api.github.com/repos/psf/requests/issues/1993/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1993.diff",
"html_url": "https://github.com/psf/requests/pull/1993",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1993.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1993"
} | true | [
"No, it's not just regular text. See [the relevant docs section](http://docs.python-requests.org/en/latest/user/advanced/#session-objects). We want it that way: it shouldn't be its own section, it's just a useful way to highlight the value of that section.\n\nThanks though! :cake:\n",
"Thanks for your patience wi... |
https://api.github.com/repos/psf/requests/issues/1992 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1992/labels{/name} | https://api.github.com/repos/psf/requests/issues/1992/comments | https://api.github.com/repos/psf/requests/issues/1992/events | https://github.com/psf/requests/pull/1992 | 30,908,261 | MDExOlB1bGxSZXF1ZXN0MTQ0MTIxMzE= | 1,992 | Master | {
"avatar_url": "https://avatars.githubusercontent.com/u/5571478?v=4",
"events_url": "https://api.github.com/users/RichVisual/events{/privacy}",
"followers_url": "https://api.github.com/users/RichVisual/followers",
"following_url": "https://api.github.com/users/RichVisual/following{/other_user}",
"gists_url": "https://api.github.com/users/RichVisual/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/RichVisual",
"id": 5571478,
"login": "RichVisual",
"node_id": "MDQ6VXNlcjU1NzE0Nzg=",
"organizations_url": "https://api.github.com/users/RichVisual/orgs",
"received_events_url": "https://api.github.com/users/RichVisual/received_events",
"repos_url": "https://api.github.com/users/RichVisual/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/RichVisual/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/RichVisual/subscriptions",
"type": "User",
"url": "https://api.github.com/users/RichVisual",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-04-05T04:08:12Z | 2021-09-08T22:01:14Z | 2014-04-05T07:33:55Z | NONE | resolved | Changed requests/docs/user/advanced.rst after the 1st section in that doc:
Remove a Value From a Dict Parameter
It's a distinct section from the rest of the neighboring text.
EDIT: OK, I'm just learning about commits, and I did the edit on that doc in the browser, and now it's going to the wrong branch. Just to be clear, I don't have anything else to commit/change other than the doc issue I cited above. Sorry for the confusion. What's the best way to fix any problems this has caused?
EDIT2: I figured out what happened and will submit it the right (I think) way this time. Sorry again for any confusion as I'm just starting to learn how this works. The submit seemed to go through on the other, so this pull can be disregarded in lieu of the other I made just now.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1992/reactions"
} | https://api.github.com/repos/psf/requests/issues/1992/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1992.diff",
"html_url": "https://github.com/psf/requests/pull/1992",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1992.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1992"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/1991 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1991/labels{/name} | https://api.github.com/repos/psf/requests/issues/1991/comments | https://api.github.com/repos/psf/requests/issues/1991/events | https://github.com/psf/requests/pull/1991 | 30,908,143 | MDExOlB1bGxSZXF1ZXN0MTQ0MTIwNjM= | 1,991 | replace reference to crate.io | {
"avatar_url": "https://avatars.githubusercontent.com/u/219470?v=4",
"events_url": "https://api.github.com/users/benjaminp/events{/privacy}",
"followers_url": "https://api.github.com/users/benjaminp/followers",
"following_url": "https://api.github.com/users/benjaminp/following{/other_user}",
"gists_url": "https://api.github.com/users/benjaminp/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/benjaminp",
"id": 219470,
"login": "benjaminp",
"node_id": "MDQ6VXNlcjIxOTQ3MA==",
"organizations_url": "https://api.github.com/users/benjaminp/orgs",
"received_events_url": "https://api.github.com/users/benjaminp/received_events",
"repos_url": "https://api.github.com/users/benjaminp/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/benjaminp/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/benjaminp/subscriptions",
"type": "User",
"url": "https://api.github.com/users/benjaminp",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-04-05T03:58:22Z | 2021-09-08T23:07:19Z | 2014-04-08T14:19:40Z | CONTRIBUTOR | resolved | crate.io is gone, so a different mirror should be used as an example. Also, the list of PyPI mirrors should be mentioned.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1991/reactions"
} | https://api.github.com/repos/psf/requests/issues/1991/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1991.diff",
"html_url": "https://github.com/psf/requests/pull/1991",
"merged_at": "2014-04-08T14:19:40Z",
"patch_url": "https://github.com/psf/requests/pull/1991.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1991"
} | true | [
"This is great, thanks! Can we just update this to link to the mirrors, though, rather than calling any one in particular out? We linked to Crate because it was awesome, so now that it's gone we should just point to the mirrors in general.\n",
"We should remove all reference of the mirrors. PyPI is at the point n... |
https://api.github.com/repos/psf/requests/issues/1990 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1990/labels{/name} | https://api.github.com/repos/psf/requests/issues/1990/comments | https://api.github.com/repos/psf/requests/issues/1990/events | https://github.com/psf/requests/pull/1990 | 30,790,148 | MDExOlB1bGxSZXF1ZXN0MTQzNDA0NjE= | 1,990 | Maintain DELETE method on 302 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1002315?v=4",
"events_url": "https://api.github.com/users/kuxi/events{/privacy}",
"followers_url": "https://api.github.com/users/kuxi/followers",
"following_url": "https://api.github.com/users/kuxi/following{/other_user}",
"gists_url": "https://api.github.com/users/kuxi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kuxi",
"id": 1002315,
"login": "kuxi",
"node_id": "MDQ6VXNlcjEwMDIzMTU=",
"organizations_url": "https://api.github.com/users/kuxi/orgs",
"received_events_url": "https://api.github.com/users/kuxi/received_events",
"repos_url": "https://api.github.com/users/kuxi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kuxi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kuxi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kuxi",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-04-03T16:18:22Z | 2021-09-08T22:01:13Z | 2014-04-03T22:09:32Z | NONE | resolved | When resolving redirects, all methods except HEAD were being converted to GET to mimic browser behavior.
This change maintains the DELETE method when resolving 302 redirects.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1002315?v=4",
"events_url": "https://api.github.com/users/kuxi/events{/privacy}",
"followers_url": "https://api.github.com/users/kuxi/followers",
"following_url": "https://api.github.com/users/kuxi/following{/other_user}",
"gists_url": "https://api.github.com/users/kuxi/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kuxi",
"id": 1002315,
"login": "kuxi",
"node_id": "MDQ6VXNlcjEwMDIzMTU=",
"organizations_url": "https://api.github.com/users/kuxi/orgs",
"received_events_url": "https://api.github.com/users/kuxi/received_events",
"repos_url": "https://api.github.com/users/kuxi/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kuxi/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kuxi/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kuxi",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1990/reactions"
} | https://api.github.com/repos/psf/requests/issues/1990/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1990.diff",
"html_url": "https://github.com/psf/requests/pull/1990",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1990.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1990"
} | true | [
"Thanks for this!\n\nWhat's your justification for making this change?\n",
"I had problems using python-swiftclient, which depends on requests in the environment at work. We had a swift cluster proxy redirecting HTTP requests to HTTPS and I couldn't delete using the client because DELETE requests were being conve... |
https://api.github.com/repos/psf/requests/issues/1989 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1989/labels{/name} | https://api.github.com/repos/psf/requests/issues/1989/comments | https://api.github.com/repos/psf/requests/issues/1989/events | https://github.com/psf/requests/pull/1989 | 30,736,794 | MDExOlB1bGxSZXF1ZXN0MTQzMDkxNjk= | 1,989 | Make note of the fact that we fixed some CVEs | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 0 | 2014-04-03T00:05:43Z | 2021-09-08T22:01:12Z | 2014-04-03T05:51:07Z | CONTRIBUTOR | resolved | Just a doc change. If anyone thinks they deserve separate items let me know. /cc @dstufft
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1989/reactions"
} | https://api.github.com/repos/psf/requests/issues/1989/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1989.diff",
"html_url": "https://github.com/psf/requests/pull/1989",
"merged_at": "2014-04-03T05:51:07Z",
"patch_url": "https://github.com/psf/requests/pull/1989.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1989"
} | true | [] |
https://api.github.com/repos/psf/requests/issues/1988 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1988/labels{/name} | https://api.github.com/repos/psf/requests/issues/1988/comments | https://api.github.com/repos/psf/requests/issues/1988/events | https://github.com/psf/requests/issues/1988 | 30,623,371 | MDU6SXNzdWUzMDYyMzM3MQ== | 1,988 | Support for RFC 2549 | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "e102d8",
"default": false,
"description": null... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 2 | 2014-04-01T18:13:24Z | 2021-09-09T00:01:09Z | 2014-04-02T14:46:12Z | CONTRIBUTOR | resolved | We should start supporting https://tools.ietf.org/html/rfc2549
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1988/reactions"
} | https://api.github.com/repos/psf/requests/issues/1988/timeline | null | completed | null | null | false | [
"I'd love to add support for RFC 2549, but the state of the avian interface modules in Python is awful. We'll need some serious upstream work in PyOpenPigeon.\n",
"Would be awesome to get my first PR merged into PyOpen:bird:!\n"
] |
https://api.github.com/repos/psf/requests/issues/1987 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1987/labels{/name} | https://api.github.com/repos/psf/requests/issues/1987/comments | https://api.github.com/repos/psf/requests/issues/1987/events | https://github.com/psf/requests/issues/1987 | 30,596,264 | MDU6SXNzdWUzMDU5NjI2NA== | 1,987 | Allow setting timeout on the Session | {
"avatar_url": "https://avatars.githubusercontent.com/u/145979?v=4",
"events_url": "https://api.github.com/users/dstufft/events{/privacy}",
"followers_url": "https://api.github.com/users/dstufft/followers",
"following_url": "https://api.github.com/users/dstufft/following{/other_user}",
"gists_url": "https://api.github.com/users/dstufft/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dstufft",
"id": 145979,
"login": "dstufft",
"node_id": "MDQ6VXNlcjE0NTk3OQ==",
"organizations_url": "https://api.github.com/users/dstufft/orgs",
"received_events_url": "https://api.github.com/users/dstufft/received_events",
"repos_url": "https://api.github.com/users/dstufft/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dstufft/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dstufft/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dstufft",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-04-01T12:59:57Z | 2021-09-09T00:01:07Z | 2014-04-01T13:43:01Z | CONTRIBUTOR | resolved | This came up in the requests IRC channel, it's something I think is generally useful (at least pip has implemented it in our Session subclass) but basically it'd be nice if the Session object had a timeout attribute that could be set to globally set a timeout instead of needing to pass it in for each request or do your own subclassing.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/1987/reactions"
} | https://api.github.com/repos/psf/requests/issues/1987/timeline | null | completed | null | null | false | [
"I'm basically in favour of this, and I'm happy to do the legwork required for it, but I want to know if @kennethreitz wants it or not.\n",
"I'd love to help out pip in anyway possible but this has been discussed twice in the last year:\n- https://github.com/kennethreitz/requests/issues/1130\n- https://github.com... |
https://api.github.com/repos/psf/requests/issues/1986 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1986/labels{/name} | https://api.github.com/repos/psf/requests/issues/1986/comments | https://api.github.com/repos/psf/requests/issues/1986/events | https://github.com/psf/requests/issues/1986 | 30,536,440 | MDU6SXNzdWUzMDUzNjQ0MA== | 1,986 | AppEngine HTTPS POST not working | {
"avatar_url": "https://avatars.githubusercontent.com/u/220959?v=4",
"events_url": "https://api.github.com/users/drakon/events{/privacy}",
"followers_url": "https://api.github.com/users/drakon/followers",
"following_url": "https://api.github.com/users/drakon/following{/other_user}",
"gists_url": "https://api.github.com/users/drakon/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/drakon",
"id": 220959,
"login": "drakon",
"node_id": "MDQ6VXNlcjIyMDk1OQ==",
"organizations_url": "https://api.github.com/users/drakon/orgs",
"received_events_url": "https://api.github.com/users/drakon/received_events",
"repos_url": "https://api.github.com/users/drakon/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/drakon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/drakon/subscriptions",
"type": "User",
"url": "https://api.github.com/users/drakon",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-03-31T18:27:22Z | 2021-09-09T00:01:09Z | 2014-03-31T18:39:44Z | NONE | resolved | HTTPS posts requests don't work on AppEngine.
Specifically the code here:
http://documentation.mailgun.com/user_manual.html#sending-via-api
(I removed the parts not making a difference):
```
requests.post("https://api.mailgun.net/v2/samples.mailgun.org/messages")
```
Results in a 404 (not found), which is wrong since it is clearly available.
I read a lot about requests' AppEngine support and the problems with urllib3 but I came to the conclusion that according to what I read it should work now. :)
Unfortunately I couldn't find any other service, where I can test a HTTPS Post.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1986/reactions"
} | https://api.github.com/repos/psf/requests/issues/1986/timeline | null | completed | null | null | false | [
"If you've been reading up on our AppEngine support you know that we don't have any. =) The official position of the requests project is that AppEngine is not Python. AppEngine has got all sorts of weird stuff going on in its network libraries, and we just cannot guarantee that they're doing anything even remotely ... |
https://api.github.com/repos/psf/requests/issues/1985 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1985/labels{/name} | https://api.github.com/repos/psf/requests/issues/1985/comments | https://api.github.com/repos/psf/requests/issues/1985/events | https://github.com/psf/requests/issues/1985 | 30,521,740 | MDU6SXNzdWUzMDUyMTc0MA== | 1,985 | requests doen't work with IPv6 addresses that contains the '%' sign | {
"avatar_url": "https://avatars.githubusercontent.com/u/2158258?v=4",
"events_url": "https://api.github.com/users/costinb7/events{/privacy}",
"followers_url": "https://api.github.com/users/costinb7/followers",
"following_url": "https://api.github.com/users/costinb7/following{/other_user}",
"gists_url": "https://api.github.com/users/costinb7/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/costinb7",
"id": 2158258,
"login": "costinb7",
"node_id": "MDQ6VXNlcjIxNTgyNTg=",
"organizations_url": "https://api.github.com/users/costinb7/orgs",
"received_events_url": "https://api.github.com/users/costinb7/received_events",
"repos_url": "https://api.github.com/users/costinb7/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/costinb7/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/costinb7/subscriptions",
"type": "User",
"url": "https://api.github.com/users/costinb7",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 22 | 2014-03-31T15:28:14Z | 2021-09-08T14:00:43Z | 2014-03-31T15:47:14Z | NONE | resolved | Some IPv6 addresses contains the '%' sign ( link-local addresses : ex. fe80::21b:63ff:feab:e6a6%eth0 or [fe80::21b:63ff:feab:e6a6%eth0] )
When using this addresses the requests library raises the fallowing exception: "requests.exceptions.InvalidURL: Invalid percent-escape sequence: 'et'"
(raised by the function unquote_unreserved() from the utils.py).
If I put as first line in this function the "return uri" line (in other words if I pass over this function), everything works ok.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1985/reactions"
} | https://api.github.com/repos/psf/requests/issues/1985/timeline | null | completed | null | null | false | [
"The % character is reserved in a URI. This causes us no end of trouble because people expect us to magically know whether we should leave a % sequence alone or transform the % to its percent-encoded form. Realistically, we have no way of being able to do that correctly.\n\nOur concession is to say that we can sort... |
https://api.github.com/repos/psf/requests/issues/1984 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1984/labels{/name} | https://api.github.com/repos/psf/requests/issues/1984/comments | https://api.github.com/repos/psf/requests/issues/1984/events | https://github.com/psf/requests/issues/1984 | 30,484,042 | MDU6SXNzdWUzMDQ4NDA0Mg== | 1,984 | auth removes the post body | {
"avatar_url": "https://avatars.githubusercontent.com/u/710024?v=4",
"events_url": "https://api.github.com/users/nathanathan/events{/privacy}",
"followers_url": "https://api.github.com/users/nathanathan/followers",
"following_url": "https://api.github.com/users/nathanathan/following{/other_user}",
"gists_url": "https://api.github.com/users/nathanathan/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nathanathan",
"id": 710024,
"login": "nathanathan",
"node_id": "MDQ6VXNlcjcxMDAyNA==",
"organizations_url": "https://api.github.com/users/nathanathan/orgs",
"received_events_url": "https://api.github.com/users/nathanathan/received_events",
"repos_url": "https://api.github.com/users/nathanathan/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nathanathan/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nathanathan/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nathanathan",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2014-03-31T04:01:34Z | 2021-09-08T23:11:00Z | 2014-06-08T10:04:46Z | NONE | resolved | I'm using Requests 2.2.1 and when I use an auth header like so:
```
r = requests.post(URL,
auth=("user", "pass"),
data=json.dumps(data)
)
print r.request.body
```
...there is no data in the body. However, if I remove the auth header this snippet prints out all the data in the body.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1984/reactions"
} | https://api.github.com/repos/psf/requests/issues/1984/timeline | null | completed | null | null | false | [
"Uh, I can't reproduce this:\n\n``` python\n>>> r = requests.post('http://www.httpbin.org/post', auth=('test', 'test'), data=json.dumps({'hi': 'there'}))\n>>> r.request.body\n'{\"hi\": \"there\"}'\n```\n\nCan you confirm that you are actually sending data in both cases?\n",
"The body only disappears if the reques... |
https://api.github.com/repos/psf/requests/issues/1983 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1983/labels{/name} | https://api.github.com/repos/psf/requests/issues/1983/comments | https://api.github.com/repos/psf/requests/issues/1983/events | https://github.com/psf/requests/issues/1983 | 30,465,887 | MDU6SXNzdWUzMDQ2NTg4Nw== | 1,983 | Referrers | {
"avatar_url": "https://avatars.githubusercontent.com/u/5372304?v=4",
"events_url": "https://api.github.com/users/luceatnobis/events{/privacy}",
"followers_url": "https://api.github.com/users/luceatnobis/followers",
"following_url": "https://api.github.com/users/luceatnobis/following{/other_user}",
"gists_url": "https://api.github.com/users/luceatnobis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/luceatnobis",
"id": 5372304,
"login": "luceatnobis",
"node_id": "MDQ6VXNlcjUzNzIzMDQ=",
"organizations_url": "https://api.github.com/users/luceatnobis/orgs",
"received_events_url": "https://api.github.com/users/luceatnobis/received_events",
"repos_url": "https://api.github.com/users/luceatnobis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/luceatnobis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/luceatnobis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/luceatnobis",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-03-30T14:10:53Z | 2021-09-09T00:01:09Z | 2014-03-30T14:17:30Z | NONE | resolved | I have noticed that requests sessions don't send referrer links, at least in what I tried, nor have I found any mention of referrers in the documentation. The only mention of referrers in the entire request source happens in the http://hg.python.org/cpython/file/3.4/Lib/http/server.py#l1088 file.
Can anyone give information about the status of this header field?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1983/reactions"
} | https://api.github.com/repos/psf/requests/issues/1983/timeline | null | completed | null | null | false | [
"Correct, we don't. We send the minimal number of header fields to prevent servers tripping up on what we do, but we don't realistically know what you're doing. This means that it's reckless to assert that the last page you looked up via this `Session` should be the referrer: they could be totally unrelated!\n\nIf ... |
https://api.github.com/repos/psf/requests/issues/1982 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1982/labels{/name} | https://api.github.com/repos/psf/requests/issues/1982/comments | https://api.github.com/repos/psf/requests/issues/1982/events | https://github.com/psf/requests/issues/1982 | 30,444,988 | MDU6SXNzdWUzMDQ0NDk4OA== | 1,982 | Adding socks5 support | {
"avatar_url": "https://avatars.githubusercontent.com/u/5372304?v=4",
"events_url": "https://api.github.com/users/luceatnobis/events{/privacy}",
"followers_url": "https://api.github.com/users/luceatnobis/followers",
"following_url": "https://api.github.com/users/luceatnobis/following{/other_user}",
"gists_url": "https://api.github.com/users/luceatnobis/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/luceatnobis",
"id": 5372304,
"login": "luceatnobis",
"node_id": "MDQ6VXNlcjUzNzIzMDQ=",
"organizations_url": "https://api.github.com/users/luceatnobis/orgs",
"received_events_url": "https://api.github.com/users/luceatnobis/received_events",
"repos_url": "https://api.github.com/users/luceatnobis/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/luceatnobis/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/luceatnobis/subscriptions",
"type": "User",
"url": "https://api.github.com/users/luceatnobis",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-03-29T14:36:57Z | 2021-09-09T00:01:10Z | 2014-03-29T14:41:51Z | NONE | resolved | Hey, would there be any chance to have socks4a/socks5 proxy support added to requests in the near future? For Python2 there was a module called requesocks which provided that functionality, but apparently that one is unmaintained and has not been ported to python3 yet.
Would that be within the goals of the library?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1982/reactions"
} | https://api.github.com/repos/psf/requests/issues/1982/timeline | null | completed | null | null | false | [
"Requests is open to having SOCKS support, but it's limited by `urllib3`, which provides lots of our underlying HTTP functionality. There's an open issue there (shazow/urllib3#284) which needs some work, and has been open for a long time: if you think there's help you can provide you should swing by and offer it!\n... |
https://api.github.com/repos/psf/requests/issues/1981 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1981/labels{/name} | https://api.github.com/repos/psf/requests/issues/1981/comments | https://api.github.com/repos/psf/requests/issues/1981/events | https://github.com/psf/requests/pull/1981 | 30,430,912 | MDExOlB1bGxSZXF1ZXN0MTQxMzY1MTI= | 1,981 | Update urllib to 1.8 (8a8c601bee) | {
"avatar_url": "https://avatars.githubusercontent.com/u/963826?v=4",
"events_url": "https://api.github.com/users/stanhu/events{/privacy}",
"followers_url": "https://api.github.com/users/stanhu/followers",
"following_url": "https://api.github.com/users/stanhu/following{/other_user}",
"gists_url": "https://api.github.com/users/stanhu/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/stanhu",
"id": 963826,
"login": "stanhu",
"node_id": "MDQ6VXNlcjk2MzgyNg==",
"organizations_url": "https://api.github.com/users/stanhu/orgs",
"received_events_url": "https://api.github.com/users/stanhu/received_events",
"repos_url": "https://api.github.com/users/stanhu/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/stanhu/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/stanhu/subscriptions",
"type": "User",
"url": "https://api.github.com/users/stanhu",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-03-28T23:42:34Z | 2021-09-08T22:01:12Z | 2014-03-31T14:29:30Z | CONTRIBUTOR | resolved | I noticed this version of urllib3 was attempting to use RC4 as the cipher, and SSL connections using pyOpenSSL would fail to servers that did not support RC4. Update to v1.8 version of urllib3 to get the new cipher settings pushed in https://github.com/shazow/urllib3/commit/2088570a293df42b1623dd74fcff0174d0565af5.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1981/reactions"
} | https://api.github.com/repos/psf/requests/issues/1981/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1981.diff",
"html_url": "https://github.com/psf/requests/pull/1981",
"merged_at": "2014-03-31T14:29:30Z",
"patch_url": "https://github.com/psf/requests/pull/1981.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1981"
} | true | [
"Thanks for this! We don't really need the Pull Request though, we update urllib3 in each release. =) I'll leave it open because Kenneth may just want to merge it anyway.\n",
"@Lukasa that is not true :)\n"
] |
https://api.github.com/repos/psf/requests/issues/1980 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1980/labels{/name} | https://api.github.com/repos/psf/requests/issues/1980/comments | https://api.github.com/repos/psf/requests/issues/1980/events | https://github.com/psf/requests/pull/1980 | 30,417,272 | MDExOlB1bGxSZXF1ZXN0MTQxMjc4NDY= | 1,980 | Create Request.links_multi and utils function for properly parsing Link headers | {
"avatar_url": "https://avatars.githubusercontent.com/u/711371?v=4",
"events_url": "https://api.github.com/users/alekstorm/events{/privacy}",
"followers_url": "https://api.github.com/users/alekstorm/followers",
"following_url": "https://api.github.com/users/alekstorm/following{/other_user}",
"gists_url": "https://api.github.com/users/alekstorm/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alekstorm",
"id": 711371,
"login": "alekstorm",
"node_id": "MDQ6VXNlcjcxMTM3MQ==",
"organizations_url": "https://api.github.com/users/alekstorm/orgs",
"received_events_url": "https://api.github.com/users/alekstorm/received_events",
"repos_url": "https://api.github.com/users/alekstorm/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alekstorm/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alekstorm/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alekstorm",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "207de5",
"default": false,
"descrip... | closed | true | null | [] | null | 12 | 2014-03-28T19:49:10Z | 2021-09-08T10:01:13Z | 2014-08-22T13:12:40Z | NONE | resolved | The current `Request.links` property has a few problems: it assumes there will only be a single link for a given relation type, and that each link has only a single relation type (see [RFC 5988](http://tools.ietf.org/html/rfc5988)); and the `utils.parse_header_links()` function it relies on does not properly parse inputs containing commas or semicolons within quoted strings. However, since I'm not sure of the proper way to fix either function without breaking backwards compatibility, I've instead created `Requests.links_multi` and `utils.parse_header_links_full`, if only to solicit feedback on the logic itself; the factoring can be changed in any way the maintainers prefer.
Specifically, `parse_header_links_full` returns a list of the new `Link` `namedtuple`s with `uri` and `attrs` attributes. Internally, it delegates to a new `tokenize` function, which splits a string into a list of tokens (identifiers, "specials", and quoted strings) according to the rules in [RFC 2616](http://tools.ietf.org/html/rfc2616#section-2.2), which makes the parsing itself quite straightforward with some application of `itertools`. In addition, `parse_header_links` is reimplemented in terms of this, to at least properly handle quoted delimiters.
`Request.links_multi`, in turn, returns a `CaseInsensitiveDict` keyed on the relation type (`Request.links` has been updated to do this as well), whose values are a list of all the links with that relation type. If a link has multiple relation types (e.g. `rel="foo bar"`), it will be added to the lists for each relation type.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1980/reactions"
} | https://api.github.com/repos/psf/requests/issues/1980/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1980.diff",
"html_url": "https://github.com/psf/requests/pull/1980",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1980.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1980"
} | true | [
"Wow, this is a serious chunk of work: thankyou!\n\nI have to get around to reviewing this, which I haven't done yet, but it seems like it's a good enhancement. I'm not going to speculate on how @kennethreitz will want to handle the API change: whether he'll want extra properties or to hold off until Semver lets us... |
https://api.github.com/repos/psf/requests/issues/1979 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1979/labels{/name} | https://api.github.com/repos/psf/requests/issues/1979/comments | https://api.github.com/repos/psf/requests/issues/1979/events | https://github.com/psf/requests/issues/1979 | 30,379,429 | MDU6SXNzdWUzMDM3OTQyOQ== | 1,979 | Authentication Handlers lost on redirect. | {
"avatar_url": "https://avatars.githubusercontent.com/u/2158258?v=4",
"events_url": "https://api.github.com/users/costinb7/events{/privacy}",
"followers_url": "https://api.github.com/users/costinb7/followers",
"following_url": "https://api.github.com/users/costinb7/following{/other_user}",
"gists_url": "https://api.github.com/users/costinb7/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/costinb7",
"id": 2158258,
"login": "costinb7",
"node_id": "MDQ6VXNlcjIxNTgyNTg=",
"organizations_url": "https://api.github.com/users/costinb7/orgs",
"received_events_url": "https://api.github.com/users/costinb7/received_events",
"repos_url": "https://api.github.com/users/costinb7/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/costinb7/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/costinb7/subscriptions",
"type": "User",
"url": "https://api.github.com/users/costinb7",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 18 | 2014-03-28T11:20:48Z | 2021-09-08T13:05:39Z | 2016-12-14T16:35:09Z | NONE | resolved | I'am trying to use the requests library by making a redirection with Digest authentication method, but the response is 401. I mention that it works with basic authentication. I've captured the packets with wireshark, and noticed that the first HTTP request is without the Authorization header, the 401 unauthorized answered is received, and after that the traffic continues as it should be, the Authorization header is added, the 302 answer is received, and after that with the https cyphers exchange. I don't know why the requests.send method returns 401.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1979/reactions"
} | https://api.github.com/repos/psf/requests/issues/1979/timeline | null | completed | null | null | false | [
"Wait, I'm confused. Your description of the wireshark trace suggests that everything is happening as expected, but you're getting an unexpected status code?\n",
"Yes, but in fact, I don't know if it is happening _exactlly_ as it should be. I tried to make a redirection from http to https. When I try with a brows... |
https://api.github.com/repos/psf/requests/issues/1978 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1978/labels{/name} | https://api.github.com/repos/psf/requests/issues/1978/comments | https://api.github.com/repos/psf/requests/issues/1978/events | https://github.com/psf/requests/issues/1978 | 30,347,364 | MDU6SXNzdWUzMDM0NzM2NA== | 1,978 | Handle httplib IncompleteRead exception | {
"avatar_url": "https://avatars.githubusercontent.com/u/452575?v=4",
"events_url": "https://api.github.com/users/hackdna/events{/privacy}",
"followers_url": "https://api.github.com/users/hackdna/followers",
"following_url": "https://api.github.com/users/hackdna/following{/other_user}",
"gists_url": "https://api.github.com/users/hackdna/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hackdna",
"id": 452575,
"login": "hackdna",
"node_id": "MDQ6VXNlcjQ1MjU3NQ==",
"organizations_url": "https://api.github.com/users/hackdna/orgs",
"received_events_url": "https://api.github.com/users/hackdna/received_events",
"repos_url": "https://api.github.com/users/hackdna/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hackdna/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hackdna/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hackdna",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2014-03-27T22:15:56Z | 2021-09-08T23:10:59Z | 2014-06-08T10:06:33Z | NONE | resolved | Requests version 1.2.3
Relevant part of traceback:
```
File "/srv/scc/virtualenvs/refinery-platform/lib/python2.7/site-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/srv/scc/virtualenvs/refinery-platform/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/srv/scc/virtualenvs/refinery-platform/lib/python2.7/site-packages/requests/sessions.py", line 335, in request
resp = self.send(prep, **send_kwargs)
File "/srv/scc/virtualenvs/refinery-platform/lib/python2.7/site-packages/requests/sessions.py", line 438, in send
r = adapter.send(request, **kwargs)
File "/srv/scc/virtualenvs/refinery-platform/lib/python2.7/site-packages/requests/adapters.py", line 340, in send
r.content
File "/srv/scc/virtualenvs/refinery-platform/lib/python2.7/site-packages/requests/models.py", line 594, in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
File "/srv/scc/virtualenvs/refinery-platform/lib/python2.7/site-packages/requests/models.py", line 541, in generate
chunk = self.raw.read(chunk_size, decode_content=True)
File "/srv/scc/virtualenvs/refinery-platform/lib/python2.7/site-packages/requests/packages/urllib3/response.py", line 171, in read
data = self._fp.read(amt)
File "/n/sw/python-2.7.3_slib/lib/python2.7/httplib.py", line 541, in read
return self._read_chunked(amt)
File "/n/sw/python-2.7.3_slib/lib/python2.7/httplib.py", line 586, in _read_chunked
raise IncompleteRead(''.join(value))
IncompleteRead: IncompleteRead(4303 bytes read)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1978/reactions"
} | https://api.github.com/repos/psf/requests/issues/1978/timeline | null | completed | null | null | false | [
"Requests v1.2.3 is several versions out of date and not supported: I suggest you try upgrading. =)\n",
"Is IncompleteRead exception handled in the latest version?\n",
"That depends. If the server has sent you less data than the Content-Length header says they have, then no.\n",
"OK, so would it be possible t... |
https://api.github.com/repos/psf/requests/issues/1977 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1977/labels{/name} | https://api.github.com/repos/psf/requests/issues/1977/comments | https://api.github.com/repos/psf/requests/issues/1977/events | https://github.com/psf/requests/issues/1977 | 30,323,043 | MDU6SXNzdWUzMDMyMzA0Mw== | 1,977 | SSL Wildcard Cert Issue | {
"avatar_url": "https://avatars.githubusercontent.com/u/2682247?v=4",
"events_url": "https://api.github.com/users/athoik/events{/privacy}",
"followers_url": "https://api.github.com/users/athoik/followers",
"following_url": "https://api.github.com/users/athoik/following{/other_user}",
"gists_url": "https://api.github.com/users/athoik/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/athoik",
"id": 2682247,
"login": "athoik",
"node_id": "MDQ6VXNlcjI2ODIyNDc=",
"organizations_url": "https://api.github.com/users/athoik/orgs",
"received_events_url": "https://api.github.com/users/athoik/received_events",
"repos_url": "https://api.github.com/users/athoik/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/athoik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athoik/subscriptions",
"type": "User",
"url": "https://api.github.com/users/athoik",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-03-27T17:28:26Z | 2021-09-09T00:01:10Z | 2014-03-27T18:44:22Z | NONE | resolved | Hello,
I am trying to open https://ia600301.us.archive.org/ with `requests` and i am receiving an `SSLError`
```
>>> import requests
>>> requests.get("https://ia600301.us.archive.org/")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/lib/python2.7/site-packages/requests/api.py", line 55, in get
File "/usr/lib/python2.7/site-packages/requests/api.py", line 44, in request
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 335, in request
File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 438, in send
File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 331, in send
requests.exceptions.SSLError: hostname 'ia600301.us.archive.org' doesn't match either of '*.archive.org', 'archive.org'
>>> requests.__version__
'1.2.3'
>>>
>>> import requests
>>> requests.get("https://ia600301.us.archive.org/")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/dist-packages/requests-2.0.1-py2.7.egg/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests-2.0.1-py2.7.egg/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests-2.0.1-py2.7.egg/requests/sessions.py", line 361, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests-2.0.1-py2.7.egg/requests/sessions.py", line 464, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests-2.0.1-py2.7.egg/requests/adapters.py", line 363, in send
raise SSLError(e)
requests.exceptions.SSLError: hostname 'ia600301.us.archive.org' doesn't match either of '*.archive.org', 'archive.org'
>>> requests.__version__
'2.0.1'
>>> import requests
>>> requests.get("https://ia600301.us.archive.org/")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/usr/local/lib/python2.7/dist-packages/requests-2.2.1-py2.7.egg/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests-2.2.1-py2.7.egg/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests-2.2.1-py2.7.egg/requests/sessions.py", line 383, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests-2.2.1-py2.7.egg/requests/sessions.py", line 486, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests-2.2.1-py2.7.egg/requests/adapters.py", line 385, in send
raise SSLError(e)
requests.exceptions.SSLError: hostname 'ia600301.us.archive.org' doesn't match either of '*.archive.org', 'archive.org'
>>> requests.__version__
'2.2.1'
```
The same Cert doesn't compain on my browser, also it looks ok here http://www.sslshopper.com/ssl-checker.html#hostname=https://ia600301.us.archive.org/
| {
"avatar_url": "https://avatars.githubusercontent.com/u/2682247?v=4",
"events_url": "https://api.github.com/users/athoik/events{/privacy}",
"followers_url": "https://api.github.com/users/athoik/followers",
"following_url": "https://api.github.com/users/athoik/following{/other_user}",
"gists_url": "https://api.github.com/users/athoik/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/athoik",
"id": 2682247,
"login": "athoik",
"node_id": "MDQ6VXNlcjI2ODIyNDc=",
"organizations_url": "https://api.github.com/users/athoik/orgs",
"received_events_url": "https://api.github.com/users/athoik/received_events",
"repos_url": "https://api.github.com/users/athoik/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/athoik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/athoik/subscriptions",
"type": "User",
"url": "https://api.github.com/users/athoik",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1977/reactions"
} | https://api.github.com/repos/psf/requests/issues/1977/timeline | null | completed | null | null | false | [
"Afaik wildcards are not supposed to be recursive.\nI don't have time right now, but I'll write a proper answer later.\n",
"@t-8ch @athoik \n\nwildcard certs support only one level wildcard-ish. \n\nBut: The SSL certificate on hostname `ia600301.us.archive.org` is issued on the name `*.us.archive.org`. \n\nThe er... |
https://api.github.com/repos/psf/requests/issues/1976 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1976/labels{/name} | https://api.github.com/repos/psf/requests/issues/1976/comments | https://api.github.com/repos/psf/requests/issues/1976/events | https://github.com/psf/requests/pull/1976 | 30,209,715 | MDExOlB1bGxSZXF1ZXN0MTQwMDM4NDE= | 1,976 | The expected value changed for the proxies keyword | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 5 | 2014-03-26T13:13:26Z | 2021-09-08T23:06:27Z | 2014-03-26T15:34:36Z | CONTRIBUTOR | resolved | It used to be None but a recent PR changed that before my last one was merged
Fixes #1975
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1976/reactions"
} | https://api.github.com/repos/psf/requests/issues/1976/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1976.diff",
"html_url": "https://github.com/psf/requests/pull/1976",
"merged_at": "2014-03-26T15:34:36Z",
"patch_url": "https://github.com/psf/requests/pull/1976.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1976"
} | true | [
":+1: Totally safe, thanks!\n",
"In related news, @kennethreitz is there an email address that the Jenkins server emails when tests fail? If not, could you add @Lukasa and/or me to the notifications? Assuming Jenkins runs on pushes to master (i.e., when you merge a PR) I would have seen this and fixed it sooner.\... |
https://api.github.com/repos/psf/requests/issues/1975 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1975/labels{/name} | https://api.github.com/repos/psf/requests/issues/1975/comments | https://api.github.com/repos/psf/requests/issues/1975/events | https://github.com/psf/requests/issues/1975 | 30,190,349 | MDU6SXNzdWUzMDE5MDM0OQ== | 1,975 | Testsuite Failure: test_requests_are_updated_each_time | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-03-26T07:24:03Z | 2021-09-09T00:01:11Z | 2014-03-26T15:34:36Z | MEMBER | resolved | From Jenkins:
```
============================= test session starts ==============================
platform linux -- Python 3.3.2 -- pytest-2.3.4
plugins: cov
collected 125 items
test_requests.py ...........................................................................................................................F.
=================================== FAILURES ===================================
______________ TestRedirects.test_requests_are_updated_each_time _______________
self = <test_requests.TestRedirects object at 0x2aca5b721dd0>
def test_requests_are_updated_each_time(self):
session = RedirectSession([303, 307])
prep = requests.Request('POST', 'http://httpbin.org/post').prepare()
r0 = session.send(prep)
assert r0.request.method == 'POST'
assert session.calls[-1] == SendCall((r0.request,), {})
redirect_generator = session.resolve_redirects(r0, prep)
for response in redirect_generator:
assert response.request.method == 'GET'
send_call = SendCall((response.request,),
TestRedirects.default_keyword_args)
> assert session.calls[-1] == send_call
E assert SendCall(args...ects': False}) == SendCall(args=...ects': False})
E At index 1 diff: {'stream': False, 'timeout': None, 'cert': None, 'proxies': {}, 'verify': True, 'allow_redirects': False} != {'stream': False, 'timeout': None, 'cert': None, 'proxies': None, 'verify': True, 'allow_redirects': False}
test_requests.py:1277: AssertionError
generated xml file: /var/lib/jenkins/jobs/requests-pr/workspace/PYTHON/3.3/junit.xml
==================== 1 failed, 124 passed in 10.27 seconds =====================
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1975/reactions"
} | https://api.github.com/repos/psf/requests/issues/1975/timeline | null | completed | null | null | false | [
"Fixed in b92f4ec\n"
] |
https://api.github.com/repos/psf/requests/issues/1974 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1974/labels{/name} | https://api.github.com/repos/psf/requests/issues/1974/comments | https://api.github.com/repos/psf/requests/issues/1974/events | https://github.com/psf/requests/issues/1974 | 30,084,364 | MDU6SXNzdWUzMDA4NDM2NA== | 1,974 | Payload in array | {
"avatar_url": "https://avatars.githubusercontent.com/u/440320?v=4",
"events_url": "https://api.github.com/users/guori12321/events{/privacy}",
"followers_url": "https://api.github.com/users/guori12321/followers",
"following_url": "https://api.github.com/users/guori12321/following{/other_user}",
"gists_url": "https://api.github.com/users/guori12321/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/guori12321",
"id": 440320,
"login": "guori12321",
"node_id": "MDQ6VXNlcjQ0MDMyMA==",
"organizations_url": "https://api.github.com/users/guori12321/orgs",
"received_events_url": "https://api.github.com/users/guori12321/received_events",
"repos_url": "https://api.github.com/users/guori12321/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/guori12321/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/guori12321/subscriptions",
"type": "User",
"url": "https://api.github.com/users/guori12321",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2014-03-24T23:15:22Z | 2021-09-09T00:09:54Z | 2014-03-25T09:11:12Z | NONE | resolved | When I studied the HTTP Post in the Google Flight, I found the Request Payload is like the following:
[,[[,"aa","[,2,\"S\"]","18563594632275",5]],[,[[,"b_al","no:73"],[,"b_ahr","no:s"],[,"b_am","aa"],[,"b_qu","0"],[,"b_qc","1"]]]]
However, Python does allow None in array, that means, var = [None, 'something'] is right in Python, but var = [ , 'something'] is wrong. What's more, when I post something via lib requests, there is an error :
TypeError: 'NoneType' object is not iterable
So, could you please give me some suggestions of how to deal with the Payload? I searched about it, but in other cases the Payload is a list rather than a array like [, 'something'].
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1974/reactions"
} | https://api.github.com/repos/psf/requests/issues/1974/timeline | null | completed | null | null | false | [
"Uh, can I see the body as it went over the wire? Because that payload doesn't look like anything I've ever seen before.\n",
"1. For instance,\n https://www.google.fr/flights/#search;f=CFE;t=ORY,CDG;d=2014-04-10;r=2014-04-14.\n When you input the city name (Paris in this example), you will get the\n followi... |
https://api.github.com/repos/psf/requests/issues/1973 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1973/labels{/name} | https://api.github.com/repos/psf/requests/issues/1973/comments | https://api.github.com/repos/psf/requests/issues/1973/events | https://github.com/psf/requests/issues/1973 | 30,071,513 | MDU6SXNzdWUzMDA3MTUxMw== | 1,973 | Sockets remain in CLOSE_WAIT | {
"avatar_url": "https://avatars.githubusercontent.com/u/454718?v=4",
"events_url": "https://api.github.com/users/gosom/events{/privacy}",
"followers_url": "https://api.github.com/users/gosom/followers",
"following_url": "https://api.github.com/users/gosom/following{/other_user}",
"gists_url": "https://api.github.com/users/gosom/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gosom",
"id": 454718,
"login": "gosom",
"node_id": "MDQ6VXNlcjQ1NDcxOA==",
"organizations_url": "https://api.github.com/users/gosom/orgs",
"received_events_url": "https://api.github.com/users/gosom/received_events",
"repos_url": "https://api.github.com/users/gosom/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gosom/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gosom/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gosom",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 20 | 2014-03-24T20:21:18Z | 2021-09-09T00:09:54Z | 2014-03-25T14:48:15Z | NONE | resolved | ```
Python 2.7.4 (default, Sep 26 2013, 03:20:56)
[GCC 4.7.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> requests.__version__
'2.1.0'
>>> response = requests.get('http://www.yahoo.de')
```
then check:
```
$ lsof -i
python 22881 xubuntu 6u IPv4 545643 0t0 TCP 192.168.1.242:47049->ir2.fp.vip.ir2.yahoo.com:http (ESTABLISHED)
```
then :
```
>>response.close()
```
and check again lsof -i
```
python 22881 xubuntu 6u IPv4 545643 0t0 TCP 192.168.1.242:47049->ir2.fp.vip.ir2.yahoo.com:http (CLOSE_WAIT)
```
the sockets close only when I exit the interpreter !
Doing the same with urllib2:
```
>>res = urllib2.urlopen('http://yahoo.de')
```
lsof -i
```
python 22881 xubuntu 4u IPv4 546690 0t0 TCP 192.168.1.242:48715->ir1.fp.vip.ir2.yahoo.com:http (ESTABLISHED)
>>res.close()
```
now the socket is closed!
Can somebody explains this behavior?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1973/reactions"
} | https://api.github.com/repos/psf/requests/issues/1973/timeline | null | completed | null | null | false | [
"Yes. =) Requests uses connection pooling to avoid the overhead of repeatedly creating and connecting sockets. This saves substantial system resources at the cost of keeping a few file descriptors open. Put another way: this is working exactly as designed. =)\n",
"Thanks for the response.\nBut what if I am doing ... |
https://api.github.com/repos/psf/requests/issues/1972 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1972/labels{/name} | https://api.github.com/repos/psf/requests/issues/1972/comments | https://api.github.com/repos/psf/requests/issues/1972/events | https://github.com/psf/requests/pull/1972 | 29,972,184 | MDExOlB1bGxSZXF1ZXN0MTM4NzE5NjE= | 1,972 | Add __str__ to case insensitive dict | {
"avatar_url": "https://avatars.githubusercontent.com/u/873597?v=4",
"events_url": "https://api.github.com/users/avidas/events{/privacy}",
"followers_url": "https://api.github.com/users/avidas/followers",
"following_url": "https://api.github.com/users/avidas/following{/other_user}",
"gists_url": "https://api.github.com/users/avidas/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/avidas",
"id": 873597,
"login": "avidas",
"node_id": "MDQ6VXNlcjg3MzU5Nw==",
"organizations_url": "https://api.github.com/users/avidas/orgs",
"received_events_url": "https://api.github.com/users/avidas/received_events",
"repos_url": "https://api.github.com/users/avidas/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/avidas/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/avidas/subscriptions",
"type": "User",
"url": "https://api.github.com/users/avidas",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "207de5",
"default": false,
"descrip... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 9 | 2014-03-22T20:45:36Z | 2021-09-09T00:01:15Z | 2014-05-12T19:08:31Z | CONTRIBUTOR | resolved | Logging headers for debugging purposes is often necessary, and the currently logging the headers would be using **repr** which would log the implementation detail of headers, caseinsensitivedict. Adding str to case insensitive dict makes the headers of the response object more log friendly, by logging only the request itself and not implementation details.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1972/reactions"
} | https://api.github.com/repos/psf/requests/issues/1972/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1972.diff",
"html_url": "https://github.com/psf/requests/pull/1972",
"merged_at": "2014-05-12T19:08:31Z",
"patch_url": "https://github.com/psf/requests/pull/1972.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1972"
} | true | [
"In principle I'd be happy to take this, but you broke the build. =) Some sample output is [here](http://ci.kennethreitz.org/job/requests-pr/263/PYTHON=3.3/console): mind fixing that up?\n",
"Whoops, that's embarrassing. Fixed now!\n",
"Cool, LGTM. Thanks for this! :cake:\n",
"@sigmavirus24 Sure updated now\n... |
https://api.github.com/repos/psf/requests/issues/1971 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1971/labels{/name} | https://api.github.com/repos/psf/requests/issues/1971/comments | https://api.github.com/repos/psf/requests/issues/1971/events | https://github.com/psf/requests/issues/1971 | 29,945,341 | MDU6SXNzdWUyOTk0NTM0MQ== | 1,971 | r.url in request.post is same as request.get | {
"avatar_url": "https://avatars.githubusercontent.com/u/6764126?v=4",
"events_url": "https://api.github.com/users/patelgr/events{/privacy}",
"followers_url": "https://api.github.com/users/patelgr/followers",
"following_url": "https://api.github.com/users/patelgr/following{/other_user}",
"gists_url": "https://api.github.com/users/patelgr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/patelgr",
"id": 6764126,
"login": "patelgr",
"node_id": "MDQ6VXNlcjY3NjQxMjY=",
"organizations_url": "https://api.github.com/users/patelgr/orgs",
"received_events_url": "https://api.github.com/users/patelgr/received_events",
"repos_url": "https://api.github.com/users/patelgr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/patelgr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/patelgr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/patelgr",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-03-21T22:45:03Z | 2021-09-09T00:09:56Z | 2014-03-21T22:47:46Z | NONE | resolved | In [24]: params = {
'f':'nopghc1xva2jkp5p6rer5j4dyr1s7r6r7b4t8j1s', #tags
's':"+".join(stocklist[:10])
}
In [25]:
r = requests.post("http://finance.yahoo.com/d/quotes.csv",params = params)
In [29]: r.url
Out[29]:
u'http://download.finance.yahoo.com/d/quotes.csv?s=A%2BB%2BC%2BD%2BE%2BF%2BG%2BH%2BI%2BK&f=nopghc1xva2jkp5p6rer5j4dyr1s7r6r7b4t8j1s'
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1971/reactions"
} | https://api.github.com/repos/psf/requests/issues/1971/timeline | null | completed | null | null | false | [
"In requests, `params` is always query string parameters. If you want to put something in the request body, use the `data` argument: `requests.post(url, data=data)`.\n",
"thanks\n"
] |
https://api.github.com/repos/psf/requests/issues/1970 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1970/labels{/name} | https://api.github.com/repos/psf/requests/issues/1970/comments | https://api.github.com/repos/psf/requests/issues/1970/events | https://github.com/psf/requests/issues/1970 | 29,878,434 | MDU6SXNzdWUyOTg3ODQzNA== | 1,970 | SNI support seemingly still broken on OS X 10.9 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1225294?v=4",
"events_url": "https://api.github.com/users/FiloSottile/events{/privacy}",
"followers_url": "https://api.github.com/users/FiloSottile/followers",
"following_url": "https://api.github.com/users/FiloSottile/following{/other_user}",
"gists_url": "https://api.github.com/users/FiloSottile/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/FiloSottile",
"id": 1225294,
"login": "FiloSottile",
"node_id": "MDQ6VXNlcjEyMjUyOTQ=",
"organizations_url": "https://api.github.com/users/FiloSottile/orgs",
"received_events_url": "https://api.github.com/users/FiloSottile/received_events",
"repos_url": "https://api.github.com/users/FiloSottile/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/FiloSottile/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/FiloSottile/subscriptions",
"type": "User",
"url": "https://api.github.com/users/FiloSottile",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-03-21T04:12:00Z | 2021-09-08T19:00:30Z | 2014-03-21T06:51:57Z | NONE | resolved | The following does NOT reproduce with Python 3 or on Linux hosts.
Jump to the bottom for the actual error. I just attached logs of the venv setup.
```
bash-3.2$ virtualenv venv
New python executable in venv/bin/python
Installing Setuptools..............................................................................................................................................................................................................................done.
Installing Pip.....................................................................................................................................................................................................................................................................................................................................done.
bash-3.2$ venv/bin/pip install requests urllib3 pyasn1 ndg-httpsclient pyopenssl
Downloading/unpacking requests
Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fr%2Frequests%2Frequests-2.2.1.tar.gz
Running setup.py egg_info for package requests
Downloading/unpacking urllib3
Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fu%2Furllib3%2Furllib3-1.8.tar.gz
Running setup.py egg_info for package urllib3
Downloading/unpacking pyasn1
Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fp%2Fpyasn1%2Fpyasn1-0.1.7.tar.gz
Running setup.py egg_info for package pyasn1
Downloading/unpacking ndg-httpsclient
Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fn%2Fndg-httpsclient%2Fndg_httpsclient-0.3.2.tar.gz
Running setup.py egg_info for package ndg-httpsclient
Downloading/unpacking pyopenssl
Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fp%2FpyOpenSSL%2FpyOpenSSL-0.14.tar.gz
Running setup.py egg_info for package pyopenssl
warning: no previously-included files matching '*.pyc' found anywhere in distribution
no previously-included directories found matching 'doc/_build'
Downloading/unpacking cryptography>=0.2.1 (from pyopenssl)
Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fc%2Fcryptography%2Fcryptography-0.2.2.tar.gz
Running setup.py egg_info for package cryptography
no previously-included directories found matching 'documentation/_build'
zip_safe flag not set; analyzing archive contents...
six: module references __file__
six: module references __path__
Installed /Users/filosottile/tmp/venv/build/cryptography/six-1.6.1-py2.7.egg
Searching for cffi>=0.8
Reading https://pypi.python.org/simple/cffi/
Best match: cffi 0.8.2
Downloading https://pypi.python.org/packages/source/c/cffi/cffi-0.8.2.tar.gz#md5=37fc88c62f40d04e8a18192433f951ec
Processing cffi-0.8.2.tar.gz
Writing /var/folders/t7/mkv9kpmd4094fb3gfqgkjp640000gn/T/easy_install-zzgElT/cffi-0.8.2/setup.cfg
Running cffi-0.8.2/setup.py -q bdist_egg --dist-dir /var/folders/t7/mkv9kpmd4094fb3gfqgkjp640000gn/T/easy_install-zzgElT/cffi-0.8.2/egg-dist-tmp-_RWs2A
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
OS/X: confusion between 'cc' versus 'gcc' (see issue 123)
will not use '__thread' in the C code
Installed /Users/filosottile/tmp/venv/build/cryptography/cffi-0.8.2-py2.7-macosx-10.8-x86_64.egg
Searching for pycparser
Reading https://pypi.python.org/simple/pycparser/
Best match: pycparser 2.10
Downloading https://pypi.python.org/packages/source/p/pycparser/pycparser-2.10.tar.gz#md5=d87aed98c8a9f386aa56d365fe4d515f
Processing pycparser-2.10.tar.gz
Writing /var/folders/t7/mkv9kpmd4094fb3gfqgkjp640000gn/T/easy_install-1JE3Je/pycparser-2.10/setup.cfg
Running pycparser-2.10/setup.py -q bdist_egg --dist-dir /var/folders/t7/mkv9kpmd4094fb3gfqgkjp640000gn/T/easy_install-1JE3Je/pycparser-2.10/egg-dist-tmp-AjEMEf
zip_safe flag not set; analyzing archive contents...
Installed /Users/filosottile/tmp/venv/build/cryptography/pycparser-2.10-py2.7.egg
building '_cffi__x36bf4a13xfba2f231' extension
clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.c -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/primitives/__pycache__/cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.o
clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/primitives/__pycache__/cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.o -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.so
building '_cffi__xa1394602x4a8b9ec1' extension
clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.c -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/primitives/__pycache__/cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.o
clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/primitives/__pycache__/cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.o -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.so
building '_cffi__x5eaa210axf0ae7e21' extension
clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.c -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/bindings/__pycache__/cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.o
clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/bindings/__pycache__/cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.o -lcrypto -lssl -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.so
building '_cffi__x64a6e44fx21ac8a22' extension
clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.c -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/bindings/__pycache__/cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.o
clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/bindings/__pycache__/cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.o -o /Users/filosottile/tmp/venv/build/cryptography/cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.so
Downloading/unpacking six>=1.5.2 (from pyopenssl)
Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fs%2Fsix%2Fsix-1.6.1.tar.gz
Running setup.py egg_info for package six
no previously-included directories found matching 'documentation/_build'
Downloading/unpacking cffi>=0.8 (from cryptography>=0.2.1->pyopenssl)
Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fc%2Fcffi%2Fcffi-0.8.2.tar.gz
Running setup.py egg_info for package cffi
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
OS/X: confusion between 'cc' versus 'gcc' (see issue 123)
will not use '__thread' in the C code
Downloading/unpacking pycparser (from cffi>=0.8->cryptography>=0.2.1->pyopenssl)
Using download cache from /Users/filosottile/.pip-download-cache/https%3A%2F%2Fpypi.python.org%2Fpackages%2Fsource%2Fp%2Fpycparser%2Fpycparser-2.10.tar.gz
Running setup.py egg_info for package pycparser
Installing collected packages: requests, urllib3, pyasn1, ndg-httpsclient, pyopenssl, cryptography, six, cffi, pycparser
Running setup.py install for requests
Running setup.py install for urllib3
Running setup.py install for pyasn1
Running setup.py install for ndg-httpsclient
Skipping installation of /Users/filosottile/tmp/venv/lib/python2.7/site-packages/ndg/__init__.py (namespace package)
Installing /Users/filosottile/tmp/venv/lib/python2.7/site-packages/ndg_httpsclient-0.3.2-py2.7-nspkg.pth
Installing ndg_httpclient script to /Users/filosottile/tmp/venv/bin
Running setup.py install for pyopenssl
warning: no previously-included files matching '*.pyc' found anywhere in distribution
no previously-included directories found matching 'doc/_build'
Running setup.py install for cryptography
building '_cffi__x5eaa210axf0ae7e21' extension
clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.c -o build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.o
clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/bindings/__pycache__/_cffi__x5eaa210axf0ae7e21.o -lcrypto -lssl -o build/lib.macosx-10.8-x86_64-2.7/cryptography/_cffi__x5eaa210axf0ae7e21.so
building '_cffi__x36bf4a13xfba2f231' extension
clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.c -o build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.o
clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/primitives/__pycache__/_cffi__x36bf4a13xfba2f231.o -o build/lib.macosx-10.8-x86_64-2.7/cryptography/_cffi__x36bf4a13xfba2f231.so
building '_cffi__xa1394602x4a8b9ec1' extension
clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.c -o build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.o
clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/primitives/__pycache__/_cffi__xa1394602x4a8b9ec1.o -o build/lib.macosx-10.8-x86_64-2.7/cryptography/_cffi__xa1394602x4a8b9ec1.so
building '_cffi__x64a6e44fx21ac8a22' extension
clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.c -o build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.o
clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib build/temp.macosx-10.8-x86_64-2.7/cryptography/hazmat/bindings/__pycache__/_cffi__x64a6e44fx21ac8a22.o -o build/lib.macosx-10.8-x86_64-2.7/cryptography/_cffi__x64a6e44fx21ac8a22.so
Running setup.py install for six
no previously-included directories found matching 'documentation/_build'
Running setup.py install for cffi
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
Package libffi was not found in the pkg-config search path.
Perhaps you should add the directory containing `libffi.pc'
to the PKG_CONFIG_PATH environment variable
No package 'libffi' found
OS/X: confusion between 'cc' versus 'gcc' (see issue 123)
will not use '__thread' in the C code
building '_cffi_backend' extension
clang -fno-strict-aliasing -fno-common -dynamic -I/usr/local/include -I/usr/local/opt/sqlite/include -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -I/usr/include/ffi -I/usr/include/libffi -I/usr/local/Cellar/python/2.7.6/Frameworks/Python.framework/Versions/2.7/include/python2.7 -c c/_cffi_backend.c -o build/temp.macosx-10.8-x86_64-2.7/c/_cffi_backend.o
clang -bundle -undefined dynamic_lookup -L/usr/local/lib -L/usr/local/opt/sqlite/lib build/temp.macosx-10.8-x86_64-2.7/c/_cffi_backend.o -lffi -o build/lib.macosx-10.8-x86_64-2.7/_cffi_backend.so
Running setup.py install for pycparser
Successfully installed requests urllib3 pyasn1 ndg-httpsclient pyopenssl cryptography six cffi pycparser
Cleaning up...
bash-3.2$ venv/bin/pip freeze
cffi==0.8.2
cryptography==0.2.2
ndg-httpsclient==0.3.2
pyOpenSSL==0.14
pyasn1==0.1.7
pycparser==2.10
requests==2.2.1
six==1.6.1
urllib3==1.8
wsgiref==0.1.2
bash-3.2$ venv/bin/python
Python 2.7.6 (default, Dec 4 2013, 18:45:48)
[GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.2.75)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests
>>> requests.get("https://transport03-rts03-iad01.transport.home.nest.com:443/")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/filosottile/tmp/venv/lib/python2.7/site-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/Users/filosottile/tmp/venv/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/Users/filosottile/tmp/venv/lib/python2.7/site-packages/requests/sessions.py", line 383, in request
resp = self.send(prep, **send_kwargs)
File "/Users/filosottile/tmp/venv/lib/python2.7/site-packages/requests/sessions.py", line 486, in send
r = adapter.send(request, **kwargs)
File "/Users/filosottile/tmp/venv/lib/python2.7/site-packages/requests/adapters.py", line 385, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno bad handshake] (-1, 'Unexpected EOF')
>>>
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1970/reactions"
} | https://api.github.com/repos/psf/requests/issues/1970/timeline | null | completed | null | null | false | [
"I don't think this has anything to do with SNI, and instead has everything to do with the OpenSSL that ships on OS X being braindead and stupid. I've run this on 2.7.6 and 3.3.4, both on OS X. In both cases, the SNI extension is being correctly sent to the remote server. The difference is that the server, in the P... |
https://api.github.com/repos/psf/requests/issues/1969 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1969/labels{/name} | https://api.github.com/repos/psf/requests/issues/1969/comments | https://api.github.com/repos/psf/requests/issues/1969/events | https://github.com/psf/requests/issues/1969 | 29,796,801 | MDU6SXNzdWUyOTc5NjgwMQ== | 1,969 | Better Document SNI and PyOpenSSL Support | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 19127... | closed | true | null | [] | null | 13 | 2014-03-20T06:30:46Z | 2021-09-08T09:00:43Z | 2017-05-29T20:56:52Z | MEMBER | resolved | It looks like the standard library [might start directing more people our way in order to get SNI on Python 2.7](http://bugs.python.org/issue5639#msg214170). This is great, but right now we don't really document it, and we don't test it. I think we should do both.
This means
- new CI environment that installs our SNI dependencies and actually tries to use it.
- better docs.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1969/reactions"
} | https://api.github.com/repos/psf/requests/issues/1969/timeline | null | completed | null | null | false | [
":+1: \n",
"No guarantees, actually, I've seen chats on Twitter that suggest that Nick Coghlan might be chatting with Christian and Alex about fixing 2.7. We're a bit in limbo here.\n",
"Until python 2.7 supports SNI, maybe we can make use of https://github.com/trevp/tlslite ?\n",
"We do support SNI. =) We ju... |
https://api.github.com/repos/psf/requests/issues/1968 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1968/labels{/name} | https://api.github.com/repos/psf/requests/issues/1968/comments | https://api.github.com/repos/psf/requests/issues/1968/events | https://github.com/psf/requests/issues/1968 | 29,777,700 | MDU6SXNzdWUyOTc3NzcwMA== | 1,968 | latest version mismatch | {
"avatar_url": "https://avatars.githubusercontent.com/u/475147?v=4",
"events_url": "https://api.github.com/users/lanterndev/events{/privacy}",
"followers_url": "https://api.github.com/users/lanterndev/followers",
"following_url": "https://api.github.com/users/lanterndev/following{/other_user}",
"gists_url": "https://api.github.com/users/lanterndev/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lanterndev",
"id": 475147,
"login": "lanterndev",
"node_id": "MDQ6VXNlcjQ3NTE0Nw==",
"organizations_url": "https://api.github.com/users/lanterndev/orgs",
"received_events_url": "https://api.github.com/users/lanterndev/received_events",
"repos_url": "https://api.github.com/users/lanterndev/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lanterndev/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lanterndev/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lanterndev",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 12 | 2014-03-19T22:14:04Z | 2021-09-08T23:10:59Z | 2014-06-08T10:43:19Z | NONE | resolved | http://docs.python-requests.org/en/latest/ currently corresponds to "Release v2.3.0". But running "pip install requests" gives
```
$ pip install -v requests
Downloading/unpacking requests
Using version 2.2.1 (newest of versions: 2.2.1, 2.2.1, 2.2.0, 2.2.0, 2.1.0, 2.1.0, 2.0.1, 2.0.1, 2.0.0, 2.0.0, 1.2.3, 1.2.2, 1.2.1, 1.2.0, 1.1.0, 1.0.4, 1.0.3, 1.0.2, 1.0.1, 1.0.0, 0.14.2, 0.14.1, 0.14.0, 0.13.9, 0.13.8, 0.13.7, 0.13.6, 0.13.5, 0.13.4, 0.13.3, 0.13.2, 0.13.1, 0.13.0, 0.12.1, 0.12.0, 0.11.2, 0.11.1, 0.10.8, 0.10.7, 0.10.6, 0.10.4, 0.10.3, 0.10.2, 0.10.1, 0.10.0, 0.9.3, 0.9.2, 0.9.1, 0.9.0, 0.8.9, 0.8.8, 0.8.7, 0.8.6, 0.8.5, 0.8.4, 0.8.3, 0.8.2, 0.8.1, 0.8.0, 0.7.6, 0.7.5, 0.7.4, 0.7.3, 0.7.2, 0.7.1, 0.7.0, 0.6.6, 0.6.5, 0.6.4, 0.6.3, 0.6.2, 0.6.1, 0.6.0, 0.5.1, 0.5.0, 0.4.1, 0.4.0, 0.3.4, 0.3.3, 0.3.2, 0.3.1, 0.3.0, 0.2.4, 0.2.3, 0.2.2, 0.2.1, 0.2.0)
Downloading requests-2.2.1-py2.py3-none-any.whl (625kB):
...
```
Is 2.3.0 not in fact released yet, or has it just not yet been uploaded to PyPI?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1968/reactions"
} | https://api.github.com/repos/psf/requests/issues/1968/timeline | null | completed | null | null | false | [
"Looks like there's no 2.3.0 tag at https://github.com/kennethreitz/requests/tags yet, so I take it 2.2.1 is in fact the latest version, and the http://docs.python-requests.org/en/latest/ page is showing an incorrect latest version.\n",
"Correct, 2.3.0 is a long way off. In a breach of the way we normally do thin... |
https://api.github.com/repos/psf/requests/issues/1967 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1967/labels{/name} | https://api.github.com/repos/psf/requests/issues/1967/comments | https://api.github.com/repos/psf/requests/issues/1967/events | https://github.com/psf/requests/issues/1967 | 29,760,771 | MDU6SXNzdWUyOTc2MDc3MQ== | 1,967 | Running a single connection with pool_block == True, hangs the application | {
"avatar_url": "https://avatars.githubusercontent.com/u/5100824?v=4",
"events_url": "https://api.github.com/users/DoxaLogosGit/events{/privacy}",
"followers_url": "https://api.github.com/users/DoxaLogosGit/followers",
"following_url": "https://api.github.com/users/DoxaLogosGit/following{/other_user}",
"gists_url": "https://api.github.com/users/DoxaLogosGit/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DoxaLogosGit",
"id": 5100824,
"login": "DoxaLogosGit",
"node_id": "MDQ6VXNlcjUxMDA4MjQ=",
"organizations_url": "https://api.github.com/users/DoxaLogosGit/orgs",
"received_events_url": "https://api.github.com/users/DoxaLogosGit/received_events",
"repos_url": "https://api.github.com/users/DoxaLogosGit/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DoxaLogosGit/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DoxaLogosGit/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DoxaLogosGit",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 35 | 2014-03-19T18:41:56Z | 2021-09-09T00:01:11Z | 2014-03-26T15:46:23Z | NONE | resolved | I have a problem where I'm trying to create a python script to test a single-threaded web server on an embedded device. I was having performance problems until I realized that I could only support one connection per session. When I made my own HTTP adapter to only use one connection with pool_block equal to True, one request got sent, then the script hung trying to send the next request.
If I comment out line 533 (the "if release_conn:") in request/package/urllib3/connectionpool.py, my problems go away. The script performances super duper fast as expected compared against a cURL bash script.
However, I'm not sure this is the proper fix for the problem, since I'm a special case. I need a way to configure this to run this single connection from the top-level api without getting blocked.
BTW, if I turn blocking off (pool_block == False), I get the same horrible performance. Basically, it has to do retries and slows down, because the web server can only handle one connection at a time.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5100824?v=4",
"events_url": "https://api.github.com/users/DoxaLogosGit/events{/privacy}",
"followers_url": "https://api.github.com/users/DoxaLogosGit/followers",
"following_url": "https://api.github.com/users/DoxaLogosGit/following{/other_user}",
"gists_url": "https://api.github.com/users/DoxaLogosGit/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/DoxaLogosGit",
"id": 5100824,
"login": "DoxaLogosGit",
"node_id": "MDQ6VXNlcjUxMDA4MjQ=",
"organizations_url": "https://api.github.com/users/DoxaLogosGit/orgs",
"received_events_url": "https://api.github.com/users/DoxaLogosGit/received_events",
"repos_url": "https://api.github.com/users/DoxaLogosGit/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/DoxaLogosGit/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/DoxaLogosGit/subscriptions",
"type": "User",
"url": "https://api.github.com/users/DoxaLogosGit",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1967/reactions"
} | https://api.github.com/repos/psf/requests/issues/1967/timeline | null | completed | null | null | false | [
"Are you reading the full response from the request?\n",
"As far as I know, I thought I was. I just get or post, and parse the\nresponse in a separate variable. Is there something else that needs to be\ndone?\n\nOn Wed, Mar 19, 2014 at 1:52 PM, Cory Benfield notifications@github.comwrote:\n\n> Are you reading t... |
https://api.github.com/repos/psf/requests/issues/1966 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1966/labels{/name} | https://api.github.com/repos/psf/requests/issues/1966/comments | https://api.github.com/repos/psf/requests/issues/1966/events | https://github.com/psf/requests/issues/1966 | 29,675,021 | MDU6SXNzdWUyOTY3NTAyMQ== | 1,966 | response unconnected with stream=True for some SSL sites | {
"avatar_url": "https://avatars.githubusercontent.com/u/1279658?v=4",
"events_url": "https://api.github.com/users/wummel/events{/privacy}",
"followers_url": "https://api.github.com/users/wummel/followers",
"following_url": "https://api.github.com/users/wummel/following{/other_user}",
"gists_url": "https://api.github.com/users/wummel/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/wummel",
"id": 1279658,
"login": "wummel",
"node_id": "MDQ6VXNlcjEyNzk2NTg=",
"organizations_url": "https://api.github.com/users/wummel/orgs",
"received_events_url": "https://api.github.com/users/wummel/received_events",
"repos_url": "https://api.github.com/users/wummel/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/wummel/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wummel/subscriptions",
"type": "User",
"url": "https://api.github.com/users/wummel",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2014-03-18T19:06:56Z | 2021-09-09T00:01:08Z | 2014-04-07T17:02:14Z | NONE | resolved | Hi,
with some SSL sites and stream=True the SSL socket seems to be unconnected. Calling connect() manually helps (see test script output below).
I expected that the behaviour is consistent, ie. after calling requests.get() the socket is connected but with no data read because of stream=True.
The test script:
```
import requests
url = "https://github.com/"
response = requests.get(url, stream=True)
print url, "sock", response.raw._connection.sock
url = "https://www.ahold.com/"
response = requests.get(url, stream=True)
print url, "sock", response.raw._connection.sock
response.raw._connection.connect()
print url, "sock after connect", response.raw._connection.sock
```
Output:
```
https://github.com/ sock <ssl.SSLSocket object at 0x27792a8>
https://www.ahold.com/ sock None
https://www.ahold.com/ sock after connect <ssl.SSLSocket object at 0x7ff033a83578>
```
Version info:
It's a Debian Linux wheezy system.
```
Python 2.7.3 (default, Mar 13 2014, 11:03:55)
[GCC 4.7.2] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests; print requests.__version__
2.2.1
>>>
```
ps: maybe this is an urllib3 problem - I'm not sure.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1279658?v=4",
"events_url": "https://api.github.com/users/wummel/events{/privacy}",
"followers_url": "https://api.github.com/users/wummel/followers",
"following_url": "https://api.github.com/users/wummel/following{/other_user}",
"gists_url": "https://api.github.com/users/wummel/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/wummel",
"id": 1279658,
"login": "wummel",
"node_id": "MDQ6VXNlcjEyNzk2NTg=",
"organizations_url": "https://api.github.com/users/wummel/orgs",
"received_events_url": "https://api.github.com/users/wummel/received_events",
"repos_url": "https://api.github.com/users/wummel/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/wummel/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/wummel/subscriptions",
"type": "User",
"url": "https://api.github.com/users/wummel",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1966/reactions"
} | https://api.github.com/repos/psf/requests/issues/1966/timeline | null | completed | null | null | false | [
"What effect does this have when using `requests`? Does it impede your ability to read data?\n",
"I can reproduce this but I have the same question as @Lukasa \n",
"I use requests for link checking. Every check first connects to the http(s) site, then if there are no errors and the content should be read (this ... |
https://api.github.com/repos/psf/requests/issues/1965 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1965/labels{/name} | https://api.github.com/repos/psf/requests/issues/1965/comments | https://api.github.com/repos/psf/requests/issues/1965/events | https://github.com/psf/requests/pull/1965 | 29,517,628 | MDExOlB1bGxSZXF1ZXN0MTM2MTI3MjM= | 1,965 | Create new Session method `prepare_redirected_request`. | {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "e11d21",
"default": false,
"descrip... | closed | true | null | [] | null | 7 | 2014-03-16T14:28:24Z | 2021-09-08T23:11:01Z | 2014-05-12T18:59:59Z | CONTRIBUTOR | resolved | This is almost entirely moving code around: the new method is
most of the code that used to be the loop body of `resolve_redirects`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1965/reactions"
} | https://api.github.com/repos/psf/requests/issues/1965/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1965.diff",
"html_url": "https://github.com/psf/requests/pull/1965",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1965.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1965"
} | true | [
"Why are we removing the redirect mixin?\n",
"It becomes obvious when you break up `resolve_redirects` this way that both halves rely on internal Session data and therefore ought to be Session methods.\n\nTBH I don't really understand why the mixin existed in the first place - it's not providing a useful conceptu... |
https://api.github.com/repos/psf/requests/issues/1964 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1964/labels{/name} | https://api.github.com/repos/psf/requests/issues/1964/comments | https://api.github.com/repos/psf/requests/issues/1964/events | https://github.com/psf/requests/pull/1964 | 29,500,005 | MDExOlB1bGxSZXF1ZXN0MTM2MDY0MjE= | 1,964 | Fix violations of PEP 8(Style Guide). | {
"avatar_url": "https://avatars.githubusercontent.com/u/5206607?v=4",
"events_url": "https://api.github.com/users/jayanthkoushik/events{/privacy}",
"followers_url": "https://api.github.com/users/jayanthkoushik/followers",
"following_url": "https://api.github.com/users/jayanthkoushik/following{/other_user}",
"gists_url": "https://api.github.com/users/jayanthkoushik/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jayanthkoushik",
"id": 5206607,
"login": "jayanthkoushik",
"node_id": "MDQ6VXNlcjUyMDY2MDc=",
"organizations_url": "https://api.github.com/users/jayanthkoushik/orgs",
"received_events_url": "https://api.github.com/users/jayanthkoushik/received_events",
"repos_url": "https://api.github.com/users/jayanthkoushik/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jayanthkoushik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jayanthkoushik/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jayanthkoushik",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2014-03-15T19:53:41Z | 2021-09-08T22:01:12Z | 2014-03-16T04:11:20Z | NONE | resolved | This commit fixes various violations of PEP 8. Most of the changes are shortening of lines longer than 79 characters. Compatibility to PEP 8 was checked using Flake-8 and the vim plugin (vim-flake8). Violations because of 'modules being imported and not used' were left as it is. These are mostly 'unfixable'.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5206607?v=4",
"events_url": "https://api.github.com/users/jayanthkoushik/events{/privacy}",
"followers_url": "https://api.github.com/users/jayanthkoushik/followers",
"following_url": "https://api.github.com/users/jayanthkoushik/following{/other_user}",
"gists_url": "https://api.github.com/users/jayanthkoushik/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jayanthkoushik",
"id": 5206607,
"login": "jayanthkoushik",
"node_id": "MDQ6VXNlcjUyMDY2MDc=",
"organizations_url": "https://api.github.com/users/jayanthkoushik/orgs",
"received_events_url": "https://api.github.com/users/jayanthkoushik/received_events",
"repos_url": "https://api.github.com/users/jayanthkoushik/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jayanthkoushik/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jayanthkoushik/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jayanthkoushik",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1964/reactions"
} | https://api.github.com/repos/psf/requests/issues/1964/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1964.diff",
"html_url": "https://github.com/psf/requests/pull/1964",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1964.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1964"
} | true | [
"Thanks for this. Unfortunately requests does not follow pep8 because of Kenneth's personal style preferences. If you search the past issues there are several similar PRs and issues that have been closed.\n\nFor what it is worth, as the flake8 maintainer, I sincerely appreciate the effort you put forth. I am confid... |
https://api.github.com/repos/psf/requests/issues/1963 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1963/labels{/name} | https://api.github.com/repos/psf/requests/issues/1963/comments | https://api.github.com/repos/psf/requests/issues/1963/events | https://github.com/psf/requests/pull/1963 | 29,497,541 | MDExOlB1bGxSZXF1ZXN0MTM2MDUzOTc= | 1,963 | Fix #1955: Do not use original request in redirect | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 7 | 2014-03-15T17:42:11Z | 2021-09-08T23:08:12Z | 2014-03-24T15:44:14Z | CONTRIBUTOR | resolved | The original request was never being properly overriden in resolve_redirects.
As such being having a POST request respond with a 303 would generate a GET
request. If the GET request encountered another redirect to something like a
307, then it would use the original request and generate another POST request.
There are two parts to this fix:
- The fix itself
- The test infrastructure to ensure it does not regress because HTTPBin is
insufficient
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1963/reactions"
} | https://api.github.com/repos/psf/requests/issues/1963/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1963.diff",
"html_url": "https://github.com/psf/requests/pull/1963",
"merged_at": "2014-03-24T15:44:14Z",
"patch_url": "https://github.com/psf/requests/pull/1963.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1963"
} | true | [
"The code change seems correct to me.\n\nRe the test infrastructure, though, may I suggest you write a mock adapter object rather than a mock session object? That may be a bit more work, but it would be a more \"natural\" test (in the sense that more of the normal logic is exercised), and it would be more easily g... |
https://api.github.com/repos/psf/requests/issues/1962 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1962/labels{/name} | https://api.github.com/repos/psf/requests/issues/1962/comments | https://api.github.com/repos/psf/requests/issues/1962/events | https://github.com/psf/requests/pull/1962 | 29,496,160 | MDExOlB1bGxSZXF1ZXN0MTM2MDQ4MjM= | 1,962 | Fix #1960: A Response's history should be a list | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 5 | 2014-03-15T16:35:33Z | 2021-09-08T23:08:27Z | 2014-03-24T15:45:06Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1962/reactions"
} | https://api.github.com/repos/psf/requests/issues/1962/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1962.diff",
"html_url": "https://github.com/psf/requests/pull/1962",
"merged_at": "2014-03-24T15:45:06Z",
"patch_url": "https://github.com/psf/requests/pull/1962.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1962"
} | true | [
"@Lukasa I was considering calling `list(r.history)` instead of `tuple(r.history)` but I cannot see a case there where it wouldn't be a list.\n",
"LGTM. :shipit:\n",
"@kennethreitz thoughts?\n",
"@sigmavirus24 you seem to really be in a rush lately.\n",
"This is a great evolution.\n"
] | |
https://api.github.com/repos/psf/requests/issues/1961 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1961/labels{/name} | https://api.github.com/repos/psf/requests/issues/1961/comments | https://api.github.com/repos/psf/requests/issues/1961/events | https://github.com/psf/requests/issues/1961 | 29,496,060 | MDU6SXNzdWUyOTQ5NjA2MA== | 1,961 | HTTPS requests reverts to HTTP on Google App Engine dev server (1.9) | {
"avatar_url": "https://avatars.githubusercontent.com/u/6943095?v=4",
"events_url": "https://api.github.com/users/cboscolo/events{/privacy}",
"followers_url": "https://api.github.com/users/cboscolo/followers",
"following_url": "https://api.github.com/users/cboscolo/following{/other_user}",
"gists_url": "https://api.github.com/users/cboscolo/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cboscolo",
"id": 6943095,
"login": "cboscolo",
"node_id": "MDQ6VXNlcjY5NDMwOTU=",
"organizations_url": "https://api.github.com/users/cboscolo/orgs",
"received_events_url": "https://api.github.com/users/cboscolo/received_events",
"repos_url": "https://api.github.com/users/cboscolo/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cboscolo/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cboscolo/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cboscolo",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 615414998,
"name": "GAE Support",
"node_id": "MDU6TGFiZWw2MTU0MTQ5OTg=",
"url": "https://api.github.com/repos/psf/requests/labels/GAE%20Support"
}
] | closed | true | null | [] | null | 5 | 2014-03-15T16:30:49Z | 2021-09-08T09:00:46Z | 2014-03-15T16:54:50Z | NONE | resolved | When using requests lib on Google App Engine, requests to sites over HTTPS on 443 were actually going out as HTTP on port 80. The problem appears to be an incompatibility with the version of httplib on GAE. I am new to GAE (and python for that matter), so I am not clear as to which lib is responsible for fixing it. To see the problem just do this in the GAE console:
```
import requests
s = requests.Session()
r = s.get("https://www.somewebsite.com/")
```
The request will go out over http instead of https. I was able to work around the issue with this patch:
```
--- a/requests/packages/urllib3/connection.py
+++ b/requests/packages/urllib3/connection.py
@@ -99,6 +99,10 @@ class HTTPSConnection(HTTPConnection):
HTTPConnection.__init__(self, host, port, strict, timeout, source_address)
except TypeError: # Python 2.6
HTTPConnection.__init__(self, host, port, strict, timeout)
+
+ # This fixes an issue on Google App Engine 1.9.0 causing https requests to go out as http
+ self._protocol = "https"
+
self.key_file = key_file
self.cert_file = cert_file
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1961/reactions"
} | https://api.github.com/repos/psf/requests/issues/1961/timeline | null | completed | null | null | false | [
"Care to send a pull request? This seems minor enough to fall under what was documented [here](https://github.com/kennethreitz/requests/blob/54ad646067a3e023fd4dcf40c0937ec46069871f/docs/dev/todo.rst#runtime-environments).\n",
"That patch is in urllib3, so needs to be opened over there. \n\n> On 15 Mar 2014, at 1... |
https://api.github.com/repos/psf/requests/issues/1960 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1960/labels{/name} | https://api.github.com/repos/psf/requests/issues/1960/comments | https://api.github.com/repos/psf/requests/issues/1960/events | https://github.com/psf/requests/issues/1960 | 29,495,243 | MDU6SXNzdWUyOTQ5NTI0Mw== | 1,960 | request.history can be either a list or a tuple | {
"avatar_url": "https://avatars.githubusercontent.com/u/410452?v=4",
"events_url": "https://api.github.com/users/sylvinus/events{/privacy}",
"followers_url": "https://api.github.com/users/sylvinus/followers",
"following_url": "https://api.github.com/users/sylvinus/following{/other_user}",
"gists_url": "https://api.github.com/users/sylvinus/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sylvinus",
"id": 410452,
"login": "sylvinus",
"node_id": "MDQ6VXNlcjQxMDQ1Mg==",
"organizations_url": "https://api.github.com/users/sylvinus/orgs",
"received_events_url": "https://api.github.com/users/sylvinus/received_events",
"repos_url": "https://api.github.com/users/sylvinus/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sylvinus/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sylvinus/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sylvinus",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-03-15T15:54:39Z | 2021-09-09T00:09:55Z | 2014-03-24T15:45:07Z | NONE | resolved | IMHO r.history should always be a list for least surprise. In _some_ cases, it is returned as a tuple:
https://github.com/kennethreitz/requests/blob/master/requests/sessions.py#L530
Thanks!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1960/reactions"
} | https://api.github.com/repos/psf/requests/issues/1960/timeline | null | completed | null | null | false | [
"I was going to close this but there is no other issue currently open for it, even though it's a known bug.\n\nI'm curious why is it least surprising for history to be a list?\n",
"I was doing response1.history + response2.history, and both should always be the same type or python will raise an unexpected error f... |
https://api.github.com/repos/psf/requests/issues/1959 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1959/labels{/name} | https://api.github.com/repos/psf/requests/issues/1959/comments | https://api.github.com/repos/psf/requests/issues/1959/events | https://github.com/psf/requests/pull/1959 | 29,417,757 | MDExOlB1bGxSZXF1ZXN0MTM1NjE0Nzg= | 1,959 | support request tuple data | {
"avatar_url": "https://avatars.githubusercontent.com/u/1502489?v=4",
"events_url": "https://api.github.com/users/Feng23/events{/privacy}",
"followers_url": "https://api.github.com/users/Feng23/followers",
"following_url": "https://api.github.com/users/Feng23/following{/other_user}",
"gists_url": "https://api.github.com/users/Feng23/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Feng23",
"id": 1502489,
"login": "Feng23",
"node_id": "MDQ6VXNlcjE1MDI0ODk=",
"organizations_url": "https://api.github.com/users/Feng23/orgs",
"received_events_url": "https://api.github.com/users/Feng23/received_events",
"repos_url": "https://api.github.com/users/Feng23/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Feng23/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Feng23/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Feng23",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 15 | 2014-03-14T08:37:24Z | 2021-09-08T23:11:00Z | 2014-03-31T14:30:36Z | CONTRIBUTOR | resolved | I have wrote this:
r = requests.post(url, data=post_data, timeout=10)
Then I found the data param does not support tuple type, but it should do.
So I add one line in the requests/models.py to fix this problem and add some unittest to it.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1959/reactions"
} | https://api.github.com/repos/psf/requests/issues/1959/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1959.diff",
"html_url": "https://github.com/psf/requests/pull/1959",
"merged_at": "2014-03-31T14:30:36Z",
"patch_url": "https://github.com/psf/requests/pull/1959.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1959"
} | true | [
"Thanks for this! Looks good to me. :cake:\n",
"However, the test changes need some work.\n\nFirst, there's no reason to break out a new test file at this stage: keep adding to the one we have. =) This way your tests are covered as part of our CI system.\n\nSecondly, we're using `py.test`, so we use tests in that... |
https://api.github.com/repos/psf/requests/issues/1958 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1958/labels{/name} | https://api.github.com/repos/psf/requests/issues/1958/comments | https://api.github.com/repos/psf/requests/issues/1958/events | https://github.com/psf/requests/issues/1958 | 29,379,196 | MDU6SXNzdWUyOTM3OTE5Ng== | 1,958 | urllib3 exceptions "leak" under some conditions | {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-03-13T18:57:44Z | 2021-09-09T00:09:59Z | 2014-03-13T19:09:29Z | CONTRIBUTOR | resolved | I said in #1957 that I would like a guarantee that
```
try:
resp = requests.get("...")
except requests.exceptions.RequestException as e:
# recover
```
is sufficient to trap all exceptions that may occur as a result of "Weird Shit coming off the network" -- this should be understood broadly: anything other than a successful DNS lookup followed by a successful connection to a server that actually speaks HTTP(S) on that port and returns (a chain of valid redirections culminating in) a valid HTTP response. #1957 covers one class of problems in that area. This is the other: urllib3 is supposed to be just an implementation detail to the user of Requests, but under some conditions, some of its exceptions can "leak" out to the user. I have observed urllib3.exceptions.MaxRetryError and urllib3.exceptions.LocationParseError. Unfortunately, I do not have enough information to pin down exactly what causes these.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1958/reactions"
} | https://api.github.com/repos/psf/requests/issues/1958/timeline | null | completed | null | null | false | [
"We really just need tracebacks to find these. This is an open issue in #1572, so I'm closing this to centralise there.\n"
] |
https://api.github.com/repos/psf/requests/issues/1957 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1957/labels{/name} | https://api.github.com/repos/psf/requests/issues/1957/comments | https://api.github.com/repos/psf/requests/issues/1957/events | https://github.com/psf/requests/issues/1957 | 29,378,104 | MDU6SXNzdWUyOTM3ODEwNA== | 1,957 | Poor handling of redirection to invalid URLs | {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-03-13T18:44:31Z | 2021-09-09T00:09:58Z | 2014-03-13T19:13:54Z | CONTRIBUTOR | resolved | If you get redirected to a syntactically invalid URL, most of the time it is the send() for the next outgoing request that will fail, and with a reasonably plausible exception. For instance:
```
>>> import requests
>>> requests.get("http://httpbin.org/redirect-to?url=htto://example.com/")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File ".../requests/api.py", line 55, in get
return request('get', url, **kwargs)
File ".../requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File ".../requests/sessions.py", line 382, in request
resp = self.send(prep, **send_kwargs)
File ".../requests/sessions.py", line 505, in send
history = [resp for resp in gen] if allow_redirects else []
File ".../requests/sessions.py", line 505, in <listcomp>
history = [resp for resp in gen] if allow_redirects else []
File ".../requests/sessions.py", line 167, in resolve_redirects
allow_redirects=False,
File ".../requests/sessions.py", line 480, in send
adapter = self.get_adapter(url=request.url)
File ".../requests/sessions.py", line 525, in get_adapter
raise InvalidSchema("No connection adapters were found for '%s'" % url)
requests.exceptions.InvalidSchema:
No connection adapters were found for 'htto://example.com/'
```
But a sufficiently mangled URL can produce exceptions that don't make nearly as much sense:
```
>>> requests.get("http://httpbin.org/redirect-to?url=http://@")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File ".../requests/api.py", line 55, in get
return request('get', url, **kwargs)
File ".../requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File ".../requests/sessions.py", line 383, in request
resp = self.send(prep, **send_kwargs)
File ".../requests/sessions.py", line 506, in send
history = [resp for resp in gen] if allow_redirects else []
File ".../requests/sessions.py", line 506, in <listcomp>
history = [resp for resp in gen] if allow_redirects else []
File ".../requests/sessions.py", line 168, in resolve_redirects
allow_redirects=False,
File ".../requests/sessions.py", line 486, in send
r = adapter.send(request, **kwargs)
File ".../requests/adapters.py", line 305, in send
conn = self.get_connection(request.url, proxies)
File ".../requests/adapters.py", line 222, in get_connection
conn = self.poolmanager.connection_from_url(url)
File ".../urllib3/poolmanager.py", line 133, in connection_from_url
return self.connection_from_host(u.host, port=u.port, scheme=u.scheme)
File ".../urllib3/poolmanager.py", line 119, in connection_from_host
pool = self._new_pool(scheme, host, port)
File ".../urllib3/poolmanager.py", line 86, in _new_pool
return pool_cls(host, port, **kwargs)
File ".../urllib3/connectionpool.py", line 226, in __init__
ConnectionPool.__init__(self, host, port)
File ".../urllib3/connectionpool.py", line 156, in __init__
host = host.strip('[]')
AttributeError: 'NoneType' object has no attribute 'strip'
```
(This one is arguably a bug in urllib3.) Or you can get an exception from the guts of `urlsplit`:
```
>>> requests.get("http://httpbin.org/redirect-to?url=http://example[.com/")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File ".../requests/api.py", line 55, in get
return request('get', url, **kwargs)
File ".../requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File ".../requests/sessions.py", line 383, in request
resp = self.send(prep, **send_kwargs)
File ".../requests/sessions.py", line 506, in send
history = [resp for resp in gen] if allow_redirects else []
File ".../requests/sessions.py", line 506, in <listcomp>
history = [resp for resp in gen] if allow_redirects else []
File ".../requests/sessions.py", line 113, in resolve_redirects
parsed = urlparse(url)
File ".../urllib/parse.py", line 293, in urlparse
splitresult = urlsplit(url, scheme, allow_fragments)
File ".../urllib/parse.py", line 343, in urlsplit
raise ValueError("Invalid IPv6 URL")
ValueError: Invalid IPv6 URL
```
(The current urllib.parse module _appears_ only to throw exceptions, as used in Requests, when the netloc part of an URL contains an unmatched square bracket, but perhaps it might get pickier in the future.)
I'm pretty agnostic about what the actual fix should be here, but I do think that it should entail a guarantee that
```
try:
resp = requests.get("...")
except requests.exceptions.RequestException as e:
# recover
```
is sufficient to trap all exceptions that may occur as a result of Weird Shit coming off the network. (Getting TypeError, ValueError, AttributeError, etc. as a result of _programming errors in the application_ is fine.)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1957/reactions"
} | https://api.github.com/repos/psf/requests/issues/1957/timeline | null | completed | null | null | false | [
"Is that a highly generic exception? It seems very clear to me.\n",
"Generic in the sense that `ValueError` gets thrown for many other reasons; but really that's not the issue; the issue is that catching `RequestException` isn't sufficient to intercept all possible server misbehavior.\n",
"In which case this is... |
https://api.github.com/repos/psf/requests/issues/1956 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1956/labels{/name} | https://api.github.com/repos/psf/requests/issues/1956/comments | https://api.github.com/repos/psf/requests/issues/1956/events | https://github.com/psf/requests/issues/1956 | 29,365,980 | MDU6SXNzdWUyOTM2NTk4MA== | 1,956 | `Session.send` accepts arbitrary kwargs for the adapter, `.resolve_redirects` doesn't | {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | [
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"name": "Planned",
"node_id": "MDU6TGFiZWwxMTc3NDU=",
"url": "https://api.github.com/repos/psf/requests/labels/Planned"
},
{
"color": "0b02e1",
"default": false,
"description": null,
"id": 19127... | closed | true | null | [] | null | 14 | 2014-03-13T16:31:23Z | 2021-09-08T23:05:01Z | 2015-04-20T05:46:59Z | CONTRIBUTOR | resolved | In addition to its documented set of optional arguments (`stream=`, `verify=`, `cert=`, `proxies=`), `Session.send` accepts arbitrary keyword arguments, which are passed directly to the adapter's `send` method. (For instance, `HTTPAdapter.send` also accepts a `timeout` argument.) `resolve_redirects` logically ought to do the same, but it does not: it only accepts stream/verify/cert/proxies. This may, for instance, cause a timeout manually specified in a `send` call to get applied only to the first request and not to subsequent redirections. If you are not manually walking redirections, you presumably want your `send` kwargs to get applied to all redirections in the chain; if you _are_ manually walking redirections, you may want to be able to control all of the adapter's supported `send` kwargs at each step.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1956/reactions"
} | https://api.github.com/repos/psf/requests/issues/1956/timeline | null | completed | null | null | false | [
"Yeah, we should be passing all the keyword arguments through.\n",
":+1: Nice find.\n",
"Just to clarify, if i change:\n`def resolve_redirects(self, resp, req, stream=False, timeout=None, verify=True, cert=None, proxies=None):`\nto:\n`def resolve_redirects(self, resp, req, **kwargs):`\nI need to add in the line... |
https://api.github.com/repos/psf/requests/issues/1955 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1955/labels{/name} | https://api.github.com/repos/psf/requests/issues/1955/comments | https://api.github.com/repos/psf/requests/issues/1955/events | https://github.com/psf/requests/issues/1955 | 29,365,191 | MDU6SXNzdWUyOTM2NTE5MQ== | 1,955 | `Session.resolve_redirects` copies the original request for all subsequent requests, can cause incorrect method selection | {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 4 | 2014-03-13T16:23:27Z | 2021-09-09T00:09:56Z | 2014-03-24T15:44:14Z | CONTRIBUTOR | resolved | Consider the following redirection chain:
```
POST /do_something HTTP/1.1
Host: server.example.com
...
HTTP/1.1 303 See Other
Location: /new_thing_1513
GET /new_thing_1513
Host: server.example.com
...
HTTP/1.1 307 Temporary Redirect
Location: //failover.example.com/new_thing_1513
```
The intermediate 303 See Other has caused the POST to be converted to
a GET. The subsequent 307 should preserve the GET. However, because
`Session.resolve_redirects` starts each iteration by copying the _original_
request object, Requests will issue a POST!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1955/reactions"
} | https://api.github.com/repos/psf/requests/issues/1955/timeline | null | completed | null | null | false | [
"Uh, yes, that's a bug. =D\n",
"This is also a good example of something that there's no good way to write a test for with httpbin as-is.\n",
"This can be tested though, without httpbin, and I'll tackle this one tonight or this weekend. I've tinkered with `resolve_redirects` enough to be certain enough that I c... |
https://api.github.com/repos/psf/requests/issues/1954 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1954/labels{/name} | https://api.github.com/repos/psf/requests/issues/1954/comments | https://api.github.com/repos/psf/requests/issues/1954/events | https://github.com/psf/requests/issues/1954 | 29,364,213 | MDU6SXNzdWUyOTM2NDIxMw== | 1,954 | `Session.resolve_redirects` allows you to shoot yourself in the foot by passing the wrong PreparedRequest | {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-03-13T16:12:26Z | 2021-09-09T00:09:58Z | 2014-03-14T16:41:02Z | CONTRIBUTOR | resolved | `Session.resolve_redirects` requires you to pass in both the initial response, and the PreparedRequest that produced that response, even though the latter is available as the `.request` property of the former. If you pass in a _different_ PreparedRequest object, the redirection information in the response is merged with the PreparedRequest you supplied. This cannot cause you to be sent to the wrong _URL_, because the original URL is taken from the _response_, but it may cause you to supply the wrong X-headers, HTTP method, or anything else drawn directly from the request.
I suggest that `Session.resolve_redirects` should continue to accept the `req` argument for backward compatibility, but it should be made optional (i.e. `req=None` in the signature) and should be ignored in favor of `resp.request`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1954/reactions"
} | https://api.github.com/repos/psf/requests/issues/1954/timeline | null | completed | null | null | false | [
"I actually disagree with this one: the ability to pass arbitrary `PreparedRequest` objects makes this method easier to test. =)\n",
"Hm, can you give an example? Perhaps we can find a better way.\n",
"I'm with @Lukasa on this one and I'll work on an example. That said, we allow the user to shoot themselves in... |
https://api.github.com/repos/psf/requests/issues/1953 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1953/labels{/name} | https://api.github.com/repos/psf/requests/issues/1953/comments | https://api.github.com/repos/psf/requests/issues/1953/events | https://github.com/psf/requests/issues/1953 | 29,363,729 | MDU6SXNzdWUyOTM2MzcyOQ== | 1,953 | The iterable produced by `Session.resolve_redirects` does not include the very first response | {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
}
] | open | false | null | [] | null | 14 | 2014-03-13T16:06:54Z | 2015-08-31T06:50:04Z | null | CONTRIBUTOR | null | If you are manually walking over redirects, you probably want to structure your code like this:
```
redirect_sequence = session.send_with_manual_redirect_walking(request, ...)
for resp in redirect_sequence:
# do something with 'resp'
```
The existing API does not let you do that. You must write either
```
first_response = session.send(request, ..., allow_redirects=False)
# do something with 'first_response'
for resp in session.resolve_redirects(first_response, request, ...)
# do something with 'resp'
```
which involves writing the same "do something with" code in two places, or
```
resp = session.send(request, ..., allow_redirects=False)
redir_iter = session.resolve_redirects(resp, request, ...)
while True:
# do something with 'resp'
if not resp.is_redirect: break
resp = next(redir_iter)
```
which is un-Pythonic loop structure.
Since `Session.resolve_redirects` must remain as is for compatibility's sake, the only way to fix this is to add either a new mode to `send` (`allow_redirects=MANUAL`?) or a new Session method (perhaps in fact called `send_with_manual_redirect_walking`) which returns an iterable that _does_ include the very first response. I do not particularly care which, or what the new method is called in the second case.
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1953/reactions"
} | https://api.github.com/repos/psf/requests/issues/1953/timeline | null | null | null | null | false | [
"It seems like the best approach is the second with a better method name.\n",
"What do you think a better method name would be? I am chronically bad at names.\n",
"Heh, there's not really a good one here, but could be `iter_send()`. Matches an established trend in requests to use `iter_x`.\n",
"Wouldn't `ite... |
https://api.github.com/repos/psf/requests/issues/1952 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1952/labels{/name} | https://api.github.com/repos/psf/requests/issues/1952/comments | https://api.github.com/repos/psf/requests/issues/1952/events | https://github.com/psf/requests/issues/1952 | 29,362,145 | MDU6SXNzdWUyOTM2MjE0NQ== | 1,952 | In `stream=True` mode, redirect-following crashes when body already consumed | {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | [
{
"color": "5319e7",
"default": false,
"description": null,
"id": 67760318,
"name": "Fixed",
"node_id": "MDU6TGFiZWw2Nzc2MDMxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Fixed"
}
] | closed | true | null | [] | null | 2 | 2014-03-13T15:49:42Z | 2021-09-08T23:06:11Z | 2015-01-18T20:33:02Z | CONTRIBUTOR | resolved | `Session.resolve_redirects` unconditionally accesses `Response.content`, to make sure that all of the content _has_ been consumed, so the socket can be reused. If you are manually following redirects, and you have set `stream=True`, and you use `Response.iter_content` to consume the entire body of a redirect before cycling to the next one, this access of `.content` will throw a `RuntimeError`.
This appears to be fixed by pull request #1944; I'm filing this bug anyway to record that it _is_ a bug (and to make clear why "`except RuntimeError: pass`" is needed).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1952/reactions"
} | https://api.github.com/repos/psf/requests/issues/1952/timeline | null | completed | null | null | false | [
"Thanks for this, I'm marking this issue as fixed. =)\n",
"@zackw can you please give more detailed steps to reproduce (code example or test case). \n"
] |
https://api.github.com/repos/psf/requests/issues/1951 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1951/labels{/name} | https://api.github.com/repos/psf/requests/issues/1951/comments | https://api.github.com/repos/psf/requests/issues/1951/events | https://github.com/psf/requests/pull/1951 | 29,293,841 | MDExOlB1bGxSZXF1ZXN0MTM0ODkxMjk= | 1,951 | Re-evaluate proxy authorization. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 7 | 2014-03-12T19:26:15Z | 2021-09-08T23:07:19Z | 2014-03-23T14:51:48Z | MEMBER | resolved | This pull request falls into three commits.
The first is a refactoring of the `get_environ_proxies` method to make it possible to evaluate whether a given URL is in the NO_PROXY list.
The second is a refactoring of the `resolve_redirects` method to move rebuilding the `Authorization` header to its own method.
Both of these commits are intended to set the stage for the third, which is a new method that re-evaluates proxy configuration on a redirect, and re-evaluates proxy authorization as well.
I don't want this merged yet, but it's a pretty sizeable change and I'd like to get eyes on it as early as possible. The key problem right now is that I don't have tests, though it should be possible for me to test this fairly easily. I'll want to add tests before we merge this.
@sigmavirus24, do you mind taking a look?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1951/reactions"
} | https://api.github.com/repos/psf/requests/issues/1951/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1951.diff",
"html_url": "https://github.com/psf/requests/pull/1951",
"merged_at": "2014-03-23T14:51:48Z",
"patch_url": "https://github.com/psf/requests/pull/1951.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1951"
} | true | [
"I was skeptical of this at first, but I particularly like the changes to `resolve_redirects`.\n",
"At least I'd prefer it if you changed the second `try`/`except` block. After that :shipit: unless there's more to do.\n",
"Our inability to easily test our proxy function is a pain in the neck. One day I'll inves... |
https://api.github.com/repos/psf/requests/issues/1950 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1950/labels{/name} | https://api.github.com/repos/psf/requests/issues/1950/comments | https://api.github.com/repos/psf/requests/issues/1950/events | https://github.com/psf/requests/issues/1950 | 29,282,347 | MDU6SXNzdWUyOTI4MjM0Nw== | 1,950 | content length differ on requests with same data, method and url | {
"avatar_url": "https://avatars.githubusercontent.com/u/22042?v=4",
"events_url": "https://api.github.com/users/jms/events{/privacy}",
"followers_url": "https://api.github.com/users/jms/followers",
"following_url": "https://api.github.com/users/jms/following{/other_user}",
"gists_url": "https://api.github.com/users/jms/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jms",
"id": 22042,
"login": "jms",
"node_id": "MDQ6VXNlcjIyMDQy",
"organizations_url": "https://api.github.com/users/jms/orgs",
"received_events_url": "https://api.github.com/users/jms/received_events",
"repos_url": "https://api.github.com/users/jms/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jms/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jms/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jms",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-03-12T17:11:02Z | 2021-09-09T00:10:00Z | 2014-03-12T18:27:16Z | NONE | resolved | Hi, i was testing requests against a rest web service(sugarcrm) and notice the content length differ on same request using different api call for example
what's the different between using "prepared request" and "normal request", the content length should be the same or not ?
``` python
import requests
import hashlib
import json
username = 'admin'
password = 'facil'
a = {
'user_auth': {
'user_name': username,
'password': hashlib.md5(password).hexdigest()
}
}
method = 'login'
data = json.dumps(a)
payload = {
'method': method,
'input_type': 'json',
'response_type' : 'json',
'rest_data' : data
}
sugarurl = 'http://192.168.100.138/crm/service/v4_1/rest.php'
# first request
s = requests.Session()
r = requests.Request('GET', sugarurl, params=payload)
response = s.send(r.prepare())
# second request, same data
x = requests.get(sugarurl, params=payload)
```
this is the traffic capture for the 2 requests.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1950/reactions"
} | https://api.github.com/repos/psf/requests/issues/1950/timeline | null | completed | null | null | false | [
"The way you've used them they will not be the same, because the second request gets the `Session` headers put on it.\n\nYou can get the same length by replacing `response = s.send(r.prepare())` with `response = s.send(s.prepare_request(r))`.\n"
] |
https://api.github.com/repos/psf/requests/issues/1949 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1949/labels{/name} | https://api.github.com/repos/psf/requests/issues/1949/comments | https://api.github.com/repos/psf/requests/issues/1949/events | https://github.com/psf/requests/pull/1949 | 29,280,827 | MDExOlB1bGxSZXF1ZXN0MTM0ODY2NTU= | 1,949 | Pickled Responses should include a None value for the raw attribute | {
"avatar_url": "https://avatars.githubusercontent.com/u/509830?v=4",
"events_url": "https://api.github.com/users/ionrock/events{/privacy}",
"followers_url": "https://api.github.com/users/ionrock/followers",
"following_url": "https://api.github.com/users/ionrock/following{/other_user}",
"gists_url": "https://api.github.com/users/ionrock/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ionrock",
"id": 509830,
"login": "ionrock",
"node_id": "MDQ6VXNlcjUwOTgzMA==",
"organizations_url": "https://api.github.com/users/ionrock/orgs",
"received_events_url": "https://api.github.com/users/ionrock/received_events",
"repos_url": "https://api.github.com/users/ionrock/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ionrock/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ionrock/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ionrock",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 5 | 2014-03-12T16:54:19Z | 2021-09-08T22:01:11Z | 2014-03-12T20:18:58Z | CONTRIBUTOR | resolved | I received [this issue](https://github.com/ionrock/cachecontrol/issues/16) in CacheControl where a pickled response throws an error because there is no raw attribute on the response object. The `__setstate__` function should set this explicitly to an empty `urllib3.response.HTTPResponse`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1949/reactions"
} | https://api.github.com/repos/psf/requests/issues/1949/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1949.diff",
"html_url": "https://github.com/psf/requests/pull/1949",
"merged_at": "2014-03-12T20:18:58Z",
"patch_url": "https://github.com/psf/requests/pull/1949.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1949"
} | true | [
"Yep, this is a good catch. We should fix this up.\n",
"I don't think we should add a `HTTPResponse` object because it violates Kenneth's condition about being too tied to urllib3. It also makes an incorrect assumption that `urllib3` is always being used to provide a `raw` response, which is simply untrue.\n\nI'd... |
https://api.github.com/repos/psf/requests/issues/1948 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1948/labels{/name} | https://api.github.com/repos/psf/requests/issues/1948/comments | https://api.github.com/repos/psf/requests/issues/1948/events | https://github.com/psf/requests/issues/1948 | 29,254,181 | MDU6SXNzdWUyOTI1NDE4MQ== | 1,948 | iter_content doesn't honour the timeout | {
"avatar_url": "https://avatars.githubusercontent.com/u/1308999?v=4",
"events_url": "https://api.github.com/users/mortoray/events{/privacy}",
"followers_url": "https://api.github.com/users/mortoray/followers",
"following_url": "https://api.github.com/users/mortoray/following{/other_user}",
"gists_url": "https://api.github.com/users/mortoray/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mortoray",
"id": 1308999,
"login": "mortoray",
"node_id": "MDQ6VXNlcjEzMDg5OTk=",
"organizations_url": "https://api.github.com/users/mortoray/orgs",
"received_events_url": "https://api.github.com/users/mortoray/received_events",
"repos_url": "https://api.github.com/users/mortoray/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mortoray/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mortoray/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mortoray",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-03-12T11:11:37Z | 2021-09-09T00:10:01Z | 2014-03-12T11:20:03Z | NONE | resolved | It appears that `iter_content` does not honour `timeout` set in the initial `request` call. I can't see any option to provide a timeout on streamed data.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1948/reactions"
} | https://api.github.com/repos/psf/requests/issues/1948/timeline | null | completed | null | null | false | [
"This is an outstanding issue already: see #1803.\n",
"And, in fact, @ceaess has already provided a Pull Request that fixes this in #1935, which will be in the next release.\n"
] |
https://api.github.com/repos/psf/requests/issues/1947 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1947/labels{/name} | https://api.github.com/repos/psf/requests/issues/1947/comments | https://api.github.com/repos/psf/requests/issues/1947/events | https://github.com/psf/requests/issues/1947 | 29,221,075 | MDU6SXNzdWUyOTIyMTA3NQ== | 1,947 | Optionally depend on certifi | {
"avatar_url": "https://avatars.githubusercontent.com/u/145979?v=4",
"events_url": "https://api.github.com/users/dstufft/events{/privacy}",
"followers_url": "https://api.github.com/users/dstufft/followers",
"following_url": "https://api.github.com/users/dstufft/following{/other_user}",
"gists_url": "https://api.github.com/users/dstufft/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dstufft",
"id": 145979,
"login": "dstufft",
"node_id": "MDQ6VXNlcjE0NTk3OQ==",
"organizations_url": "https://api.github.com/users/dstufft/orgs",
"received_events_url": "https://api.github.com/users/dstufft/received_events",
"repos_url": "https://api.github.com/users/dstufft/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dstufft/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dstufft/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dstufft",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-03-11T22:37:50Z | 2021-09-08T23:04:51Z | 2015-05-03T15:10:08Z | CONTRIBUTOR | resolved | Right now requests (afaik) doesn't issue security releases for old versions or have any sort of support period for any versions of requests other than the latest. This is problematic because requests bundles the CA bundle as part of the code base. This means that people _must_ upgrade requests in order to get access to the latest certificates. This becomes even more problematic when people are on older requests that cross a major version boundary.
I know requests used to depend on certifi and I assume it stopped doing so for some reason, likely ease of vendoring, so what I would like to suggest is for requests to know what version of certifi it's internal certificates corresponds to, and if there is a higher version certifi available requests will use that instead.
This will allow people to easily update the certificates of requests without having to upgrade requests, which might require coding to cross a compatibility breakage.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1947/reactions"
} | https://api.github.com/repos/psf/requests/issues/1947/timeline | null | completed | null | null | false | [
"@kennethreitz I'm open to doing the work here if this is something you think you'd like.\n",
"Requests now automatically picks up certifi if present.\n"
] |
https://api.github.com/repos/psf/requests/issues/1946 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1946/labels{/name} | https://api.github.com/repos/psf/requests/issues/1946/comments | https://api.github.com/repos/psf/requests/issues/1946/events | https://github.com/psf/requests/issues/1946 | 29,132,856 | MDU6SXNzdWUyOTEzMjg1Ng== | 1,946 | Testsuite failure | {
"avatar_url": "https://avatars.githubusercontent.com/u/216539?v=4",
"events_url": "https://api.github.com/users/ttanner/events{/privacy}",
"followers_url": "https://api.github.com/users/ttanner/followers",
"following_url": "https://api.github.com/users/ttanner/following{/other_user}",
"gists_url": "https://api.github.com/users/ttanner/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ttanner",
"id": 216539,
"login": "ttanner",
"node_id": "MDQ6VXNlcjIxNjUzOQ==",
"organizations_url": "https://api.github.com/users/ttanner/orgs",
"received_events_url": "https://api.github.com/users/ttanner/received_events",
"repos_url": "https://api.github.com/users/ttanner/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ttanner/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ttanner/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ttanner",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2014-03-10T21:08:06Z | 2021-09-08T23:07:00Z | 2014-11-13T19:11:28Z | NONE | resolved | Python 2.7.6 / macports, OS X 10.8.5, requests 2.2.1
```
======================================================================
FAIL: test_mixed_case_scheme_acceptable (test_requests.RequestsTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
File "requests/test_requests.py", line 104, in test_mixed_case_scheme_acceptable
assert r.status_code == 200, 'failed for scheme {0}'.format(scheme)
AssertionError: failed for scheme HTTP://
'HTTP://httpbin.org/get' = 'HTTP://' + ParseResult(scheme='http', netloc='httpbin.org', path='/get', params='', query='', fragment='').netloc + ParseResult(scheme='http', netloc='httpbin.org', path='/get', params='', query='', fragment='').path
<Response [404]> = <module 'requests' from 'requests/requests/__init__.pyc'>.Request('GET', 'HTTP://httpbin.org/get')
<Response [404]> = <requests.sessions.Session object at 0x110931e10>.send(<Response [404]>.prepare())
>> assert <Response [404]>.status_code == 200, 'failed for scheme {0}'.format('HTTP://')
-------------------- >> begin captured logging << --------------------
requests.packages.urllib3.connectionpool: INFO: Starting new HTTP connection (1): 127.0.0.1
requests.packages.urllib3.connectionpool: DEBUG: "GET http://httpbin.org/get HTTP/1.1" 200 212
requests.packages.urllib3.connectionpool: DEBUG: "GET HTTP://httpbin.org/get HTTP/1.1" 404 2963
--------------------- >> end captured logging << ---------------------
----------------------------------------------------------------------
Ran 1 test in 0.504s
FAILED (failures=1)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/216539?v=4",
"events_url": "https://api.github.com/users/ttanner/events{/privacy}",
"followers_url": "https://api.github.com/users/ttanner/followers",
"following_url": "https://api.github.com/users/ttanner/following{/other_user}",
"gists_url": "https://api.github.com/users/ttanner/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ttanner",
"id": 216539,
"login": "ttanner",
"node_id": "MDQ6VXNlcjIxNjUzOQ==",
"organizations_url": "https://api.github.com/users/ttanner/orgs",
"received_events_url": "https://api.github.com/users/ttanner/received_events",
"repos_url": "https://api.github.com/users/ttanner/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ttanner/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ttanner/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ttanner",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1946/reactions"
} | https://api.github.com/repos/psf/requests/issues/1946/timeline | null | completed | null | null | false | [
"I can't reproduce this on my Mac (10.9.2, Python 2.7.6 (homebrew), Requests 2.2.1) and our continuous integration didn't fail either. Does this reproducibly fail for you?\n",
"yes, it is reproducible, however, only if Glimmerblocker (1.5.3) is activated.\nAll other programm (e.g. curl) can download from HTTP://h... |
https://api.github.com/repos/psf/requests/issues/1945 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1945/labels{/name} | https://api.github.com/repos/psf/requests/issues/1945/comments | https://api.github.com/repos/psf/requests/issues/1945/events | https://github.com/psf/requests/pull/1945 | 29,126,369 | MDExOlB1bGxSZXF1ZXN0MTMzODk4Nzc= | 1,945 | SSL certificate CN and fingerprint verification support | {
"avatar_url": "https://avatars.githubusercontent.com/u/216539?v=4",
"events_url": "https://api.github.com/users/ttanner/events{/privacy}",
"followers_url": "https://api.github.com/users/ttanner/followers",
"following_url": "https://api.github.com/users/ttanner/following{/other_user}",
"gists_url": "https://api.github.com/users/ttanner/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ttanner",
"id": 216539,
"login": "ttanner",
"node_id": "MDQ6VXNlcjIxNjUzOQ==",
"organizations_url": "https://api.github.com/users/ttanner/orgs",
"received_events_url": "https://api.github.com/users/ttanner/received_events",
"repos_url": "https://api.github.com/users/ttanner/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ttanner/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ttanner/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ttanner",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 13 | 2014-03-10T19:46:26Z | 2021-09-08T10:01:05Z | 2014-03-12T20:59:05Z | NONE | resolved | This PR adds support for SSL CommonName and fingerprint verification provided by urllib3.
In contrast to https://github.com/kennethreitz/requests/pull/1606 it is minimally invasive and does not require new API parameters. Instead, it allows "verify" to be a dictionary with extra parameters.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1945/reactions"
} | https://api.github.com/repos/psf/requests/issues/1945/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1945.diff",
"html_url": "https://github.com/psf/requests/pull/1945",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1945.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1945"
} | true | [
"Thanks for this!\n\nI have no strong opinions, it looks fine. =) +0.5. @sigmavirus24?\n",
"I have a couple concerns. The first is that you're introducing yet another way for the user to set the CA bundle. You did not state that in your description. I assume you want this in order to specify the path that you wou... |
https://api.github.com/repos/psf/requests/issues/1944 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1944/labels{/name} | https://api.github.com/repos/psf/requests/issues/1944/comments | https://api.github.com/repos/psf/requests/issues/1944/events | https://github.com/psf/requests/pull/1944 | 29,076,466 | MDExOlB1bGxSZXF1ZXN0MTMzNjA5MTg= | 1,944 | Catch errors while handling redirects | {
"avatar_url": "https://avatars.githubusercontent.com/u/238652?v=4",
"events_url": "https://api.github.com/users/schlamar/events{/privacy}",
"followers_url": "https://api.github.com/users/schlamar/followers",
"following_url": "https://api.github.com/users/schlamar/following{/other_user}",
"gists_url": "https://api.github.com/users/schlamar/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/schlamar",
"id": 238652,
"login": "schlamar",
"node_id": "MDQ6VXNlcjIzODY1Mg==",
"organizations_url": "https://api.github.com/users/schlamar/orgs",
"received_events_url": "https://api.github.com/users/schlamar/received_events",
"repos_url": "https://api.github.com/users/schlamar/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/schlamar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/schlamar/subscriptions",
"type": "User",
"url": "https://api.github.com/users/schlamar",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 37 | 2014-03-10T07:24:49Z | 2021-09-08T10:01:22Z | 2014-05-12T20:50:33Z | CONTRIBUTOR | resolved | This is my proposal which fixes #1939 completely.
@sigmavirus24 missed one possible exception in #1940 (ChunkedEncodingError) and didn't handle RuntimeError correctly (because this means that the content is already consumed).
This also addresses the issue that a decoding error is already thrown in Adapter.send by moving the content reading part at the end of Session.send.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1944/reactions"
} | https://api.github.com/repos/psf/requests/issues/1944/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1944.diff",
"html_url": "https://github.com/psf/requests/pull/1944",
"merged_at": "2014-05-12T20:50:33Z",
"patch_url": "https://github.com/psf/requests/pull/1944.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1944"
} | true | [
":+1: \n",
"@maxcountryman Does this fix your issue (https://github.com/shazow/urllib3/issues/206)?\n",
"@schlamar it looks like it should. I can't test it at the moment. A little later on I'll see if I have time to give it a proper run with Photobucket.\n",
"This looks reasonable to me. I'll let @sigmavirus2... |
https://api.github.com/repos/psf/requests/issues/1943 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1943/labels{/name} | https://api.github.com/repos/psf/requests/issues/1943/comments | https://api.github.com/repos/psf/requests/issues/1943/events | https://github.com/psf/requests/pull/1943 | 29,074,124 | MDExOlB1bGxSZXF1ZXN0MTMzNTk2ODg= | 1,943 | add timout control for all requests of a Session | {
"avatar_url": "https://avatars.githubusercontent.com/u/3880627?v=4",
"events_url": "https://api.github.com/users/junfenglx/events{/privacy}",
"followers_url": "https://api.github.com/users/junfenglx/followers",
"following_url": "https://api.github.com/users/junfenglx/following{/other_user}",
"gists_url": "https://api.github.com/users/junfenglx/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/junfenglx",
"id": 3880627,
"login": "junfenglx",
"node_id": "MDQ6VXNlcjM4ODA2Mjc=",
"organizations_url": "https://api.github.com/users/junfenglx/orgs",
"received_events_url": "https://api.github.com/users/junfenglx/received_events",
"repos_url": "https://api.github.com/users/junfenglx/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/junfenglx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/junfenglx/subscriptions",
"type": "User",
"url": "https://api.github.com/users/junfenglx",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 4 | 2014-03-10T05:55:50Z | 2021-09-08T22:01:11Z | 2014-03-10T11:21:52Z | NONE | resolved | When work with a pool proxy,It doesn't close connection when except errors.Then request get block forever.
I don't want add timeout arg for every request.So I opened this pull request.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/3880627?v=4",
"events_url": "https://api.github.com/users/junfenglx/events{/privacy}",
"followers_url": "https://api.github.com/users/junfenglx/followers",
"following_url": "https://api.github.com/users/junfenglx/following{/other_user}",
"gists_url": "https://api.github.com/users/junfenglx/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/junfenglx",
"id": 3880627,
"login": "junfenglx",
"node_id": "MDQ6VXNlcjM4ODA2Mjc=",
"organizations_url": "https://api.github.com/users/junfenglx/orgs",
"received_events_url": "https://api.github.com/users/junfenglx/received_events",
"repos_url": "https://api.github.com/users/junfenglx/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/junfenglx/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/junfenglx/subscriptions",
"type": "User",
"url": "https://api.github.com/users/junfenglx",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1943/reactions"
} | https://api.github.com/repos/psf/requests/issues/1943/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1943.diff",
"html_url": "https://github.com/psf/requests/pull/1943",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1943.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1943"
} | true | [
"Thanks for this!\n\nI want to warn you right now, we're technically in feature freeze, so it's possible this won't get accepted. That said, it's a pretty minor change.\n",
"feature freeze in this version or forever?\n",
"Feature freeze at the discretion of the BDFL. =)\n\nDon't worry, it's not a very hard line... |
https://api.github.com/repos/psf/requests/issues/1942 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1942/labels{/name} | https://api.github.com/repos/psf/requests/issues/1942/comments | https://api.github.com/repos/psf/requests/issues/1942/events | https://github.com/psf/requests/issues/1942 | 28,960,015 | MDU6SXNzdWUyODk2MDAxNQ== | 1,942 | Requests, YCM, and FreeBSD error | {
"avatar_url": "https://avatars.githubusercontent.com/u/610865?v=4",
"events_url": "https://api.github.com/users/ashemedai/events{/privacy}",
"followers_url": "https://api.github.com/users/ashemedai/followers",
"following_url": "https://api.github.com/users/ashemedai/following{/other_user}",
"gists_url": "https://api.github.com/users/ashemedai/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ashemedai",
"id": 610865,
"login": "ashemedai",
"node_id": "MDQ6VXNlcjYxMDg2NQ==",
"organizations_url": "https://api.github.com/users/ashemedai/orgs",
"received_events_url": "https://api.github.com/users/ashemedai/received_events",
"repos_url": "https://api.github.com/users/ashemedai/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ashemedai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashemedai/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ashemedai",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 17 | 2014-03-07T11:50:07Z | 2021-09-09T00:09:57Z | 2014-03-07T17:16:22Z | NONE | resolved | Using the [YouCompleteMe (YCM)](https://github.com/Valloric/YouCompleteMe) project with vim I ran into a [problem](https://github.com/Valloric/YouCompleteMe/issues/804) that seems to come from Requests and running on FreeBSD 9.2-STABLE. The traceback I am running into:
``` python
Exception in thread Thread-10 (most likely raised during interpreter shutdown):
Traceback (most recent call last):
File "/usr/local/lib/python2.7/threading.py", line 810, in __bootstrap_inner
File "/usr/local/lib/python2.7/threading.py", line 763, in run
File "/usr/home/asmodai/.vim/bundle/YouCompleteMe/autoload/../python/ycm/unsafe_thread_pool_executor.py", line 55, in _worker
File "/usr/home/asmodai/.vim/bundle/YouCompleteMe/autoload/../python/ycm/unsafe_thread_pool_executor.py", line 43, in run
File "/usr/home/asmodai/.vim/bundle/YouCompleteMe/third_party/requests/requests/sessions.py", line 357, in request
File "/usr/home/asmodai/.vim/bundle/YouCompleteMe/third_party/requests/requests/sessions.py", line 460, in send
File "/usr/home/asmodai/.vim/bundle/YouCompleteMe/third_party/requests/requests/adapters.py", line 350, in send
<type 'exceptions.AttributeError'>: 'NoneType' object has no attribute 'error'
```
Requests is embedded within YCM as a Subproject, currently @ 3373548.
What kind of additional information do I need to provide to be able to track down what goes wrong here?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/610865?v=4",
"events_url": "https://api.github.com/users/ashemedai/events{/privacy}",
"followers_url": "https://api.github.com/users/ashemedai/followers",
"following_url": "https://api.github.com/users/ashemedai/following{/other_user}",
"gists_url": "https://api.github.com/users/ashemedai/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ashemedai",
"id": 610865,
"login": "ashemedai",
"node_id": "MDQ6VXNlcjYxMDg2NQ==",
"organizations_url": "https://api.github.com/users/ashemedai/orgs",
"received_events_url": "https://api.github.com/users/ashemedai/received_events",
"repos_url": "https://api.github.com/users/ashemedai/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ashemedai/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ashemedai/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ashemedai",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1942/reactions"
} | https://api.github.com/repos/psf/requests/issues/1942/timeline | null | completed | null | null | false | [
"Is that really the whole traceback? I'm finding it bears no relationship to the actual code in Requests.\n\nNevertheless, assuming it does, the only place we could raise an uncaught `AttributeError` of this type would have to be in the except block where we attempt to get `socket.error`. Surely `socket` provides `... |
https://api.github.com/repos/psf/requests/issues/1941 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1941/labels{/name} | https://api.github.com/repos/psf/requests/issues/1941/comments | https://api.github.com/repos/psf/requests/issues/1941/events | https://github.com/psf/requests/issues/1941 | 28,886,450 | MDU6SXNzdWUyODg4NjQ1MA== | 1,941 | nested dict to simple | {
"avatar_url": "https://avatars.githubusercontent.com/u/1665055?v=4",
"events_url": "https://api.github.com/users/VVhiteCoder/events{/privacy}",
"followers_url": "https://api.github.com/users/VVhiteCoder/followers",
"following_url": "https://api.github.com/users/VVhiteCoder/following{/other_user}",
"gists_url": "https://api.github.com/users/VVhiteCoder/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/VVhiteCoder",
"id": 1665055,
"login": "VVhiteCoder",
"node_id": "MDQ6VXNlcjE2NjUwNTU=",
"organizations_url": "https://api.github.com/users/VVhiteCoder/orgs",
"received_events_url": "https://api.github.com/users/VVhiteCoder/received_events",
"repos_url": "https://api.github.com/users/VVhiteCoder/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/VVhiteCoder/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/VVhiteCoder/subscriptions",
"type": "User",
"url": "https://api.github.com/users/VVhiteCoder",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-03-06T15:18:48Z | 2021-09-09T00:10:01Z | 2014-03-06T16:49:05Z | NONE | resolved | is there a tool that can convert this:
{'firstname': u'MyName', 'lastname': u'MyLast', 'phone_numbers': [{'number': u'3413241234', 'public': 1}]}
to this:
{'firstname': u'MyName', 'lastname': u'MyLast', 'phone_numbers[0][number]': u'3413241234', 'phone_number[0][public]': 1}]}
for form-encoded
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1941/reactions"
} | https://api.github.com/repos/psf/requests/issues/1941/timeline | null | completed | null | null | false | [
"Not that I am aware of.\n\n@sigmavirus24, is this worth putting in the toolbelt? `flatten_and_form_encode`?\n",
"yes will be very good tool :\nit's must convert nested dicts with different depth\n",
"@Lukasa sounds like a worthwhile addition.\n",
"Let's close this and continue the discussion over on the [too... |
https://api.github.com/repos/psf/requests/issues/1940 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1940/labels{/name} | https://api.github.com/repos/psf/requests/issues/1940/comments | https://api.github.com/repos/psf/requests/issues/1940/events | https://github.com/psf/requests/pull/1940 | 28,761,716 | MDExOlB1bGxSZXF1ZXN0MTMxOTQ1Mzg= | 1,940 | Handle both exceptions possible while consuming a socket | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 5 | 2014-03-05T03:08:13Z | 2021-09-08T23:08:30Z | 2014-03-11T13:19:35Z | CONTRIBUTOR | resolved | This fixes #1939 and part of @zackw's rehaul of redirection.
To better test this, I'd like to add Betamax as a test dependency. Also, as a separate PR I plan to kill the usage of `RuntimeError` in `Response#content`. That's awful and the community consensus is that nothing should ever raise that.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1940/reactions"
} | https://api.github.com/repos/psf/requests/issues/1940/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1940.diff",
"html_url": "https://github.com/psf/requests/pull/1940",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1940.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1940"
} | true | [
"And yes, I know I'm using a pattern that I absolutely abhor. That aside, there's no other way to catch the decode error.\n\nI wonder, however, if there's a better way to handle this. I'll sleep on it. :)\n",
"The actual point of raising the exception is here: https://github.com/kennethreitz/requests/blob/master/... |
https://api.github.com/repos/psf/requests/issues/1939 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1939/labels{/name} | https://api.github.com/repos/psf/requests/issues/1939/comments | https://api.github.com/repos/psf/requests/issues/1939/events | https://github.com/psf/requests/issues/1939 | 28,759,127 | MDU6SXNzdWUyODc1OTEyNw== | 1,939 | Why decode the response body of a redirect? | {
"avatar_url": "https://avatars.githubusercontent.com/u/1093862?v=4",
"events_url": "https://api.github.com/users/mechanical-snail/events{/privacy}",
"followers_url": "https://api.github.com/users/mechanical-snail/followers",
"following_url": "https://api.github.com/users/mechanical-snail/following{/other_user}",
"gists_url": "https://api.github.com/users/mechanical-snail/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mechanical-snail",
"id": 1093862,
"login": "mechanical-snail",
"node_id": "MDQ6VXNlcjEwOTM4NjI=",
"organizations_url": "https://api.github.com/users/mechanical-snail/orgs",
"received_events_url": "https://api.github.com/users/mechanical-snail/received_events",
"repos_url": "https://api.github.com/users/mechanical-snail/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mechanical-snail/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mechanical-snail/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mechanical-snail",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2014-03-05T01:58:01Z | 2021-09-09T00:00:59Z | 2014-05-12T20:50:33Z | NONE | resolved | Requests fails on the URL `http://www.whatbird.com/forum/index.php?/gallery/image/291517-foo/`, which is a 301 redirect to
```
http://www.whatbird.com/forum/index.php?/gallery/image/291517-title-paused-jewel-allens-hummingbird-a-backyard-bird-painting-in-oil-by-camille-engel/
```
. The issue seems to be that the server's initial 301 response has a header falsely claiming that the response body (a simple HTML page) is gzipped, when it's actually uncompressed.
When resolving redirects, Requests does (in `requests.sessions.resolve_redirects`):
```
resp.content # Consume socket so it can be released
```
which attempts to decode
One could legitimately say this is the server's problem. However, conceptually, why decode the response body of a redirect, which won't get returned? Other programs (Chromium, Firefox, `curl`) don't do this. For example, `curl` gives an error, as expected, when not following redirects:
```
$ curl --compressed 'http://www.whatbird.com/forum/index.php?/gallery/image/291517-foo/'
curl: (61) Error while processing content unencoding: invalid code lengths set
```
whereas it works if you add the `--location` flag (follow redirects).
# Example of error
```
Python 3.3.2+ (default, Oct 9 2013, 14:56:03)
[GCC 4.8.1] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import requests ; requests.get('http://www.whatbird.com/forum/index.php?/gallery/image/291517-foo/')
Traceback (most recent call last):
File "./requests/packages/urllib3/response.py", line 199, in read
data = self._decoder.decompress(data)
zlib.error: Error -3 while decompressing data: incorrect header check
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "./requests/models.py", line 629, in generate
for chunk in self.raw.stream(chunk_size, decode_content=True):
File "./requests/packages/urllib3/response.py", line 236, in stream
data = self.read(amt=amt, decode_content=decode_content)
File "./requests/packages/urllib3/response.py", line 204, in read
e)
requests.packages.urllib3.exceptions.DecodeError: ('Received response with content-encoding: gzip, but failed to decode it.', error('Error -3 while decompressing data: incorrect header check',))
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "./requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "./requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "./requests/sessions.py", line 393, in request
resp = self.send(prep, **send_kwargs)
File "./requests/sessions.py", line 496, in send
r = adapter.send(request, **kwargs)
File "./requests/adapters.py", line 391, in send
r.content
File "./requests/models.py", line 691, in content
self._content = bytes().join(self.iter_content(CONTENT_CHUNK_SIZE)) or bytes()
File "./requests/models.py", line 634, in generate
raise ContentDecodingError(e)
requests.exceptions.ContentDecodingError: ('Received response with content-encoding: gzip, but failed to decode it.', error('Error -3 while decompressing data: incorrect header check',))
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1939/reactions"
} | https://api.github.com/repos/psf/requests/issues/1939/timeline | null | completed | null | null | false | [
"You answered your own question when you pasted that line. The comment explains exactly why we consume the content. If we do not, then a user handling a great deal of redirects will run out of available connections that can be made. Sockets will sit in the ready state waiting to be read from. I think it also has th... |
https://api.github.com/repos/psf/requests/issues/1938 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1938/labels{/name} | https://api.github.com/repos/psf/requests/issues/1938/comments | https://api.github.com/repos/psf/requests/issues/1938/events | https://github.com/psf/requests/issues/1938 | 28,744,210 | MDU6SXNzdWUyODc0NDIxMA== | 1,938 | Support content-length checking | {
"avatar_url": "https://avatars.githubusercontent.com/u/308610?v=4",
"events_url": "https://api.github.com/users/jaraco/events{/privacy}",
"followers_url": "https://api.github.com/users/jaraco/followers",
"following_url": "https://api.github.com/users/jaraco/following{/other_user}",
"gists_url": "https://api.github.com/users/jaraco/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jaraco",
"id": 308610,
"login": "jaraco",
"node_id": "MDQ6VXNlcjMwODYxMA==",
"organizations_url": "https://api.github.com/users/jaraco/orgs",
"received_events_url": "https://api.github.com/users/jaraco/received_events",
"repos_url": "https://api.github.com/users/jaraco/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jaraco/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jaraco/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jaraco",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2014-03-04T21:48:58Z | 2021-09-09T00:10:02Z | 2014-03-05T14:54:13Z | CONTRIBUTOR | resolved | I have an application that wants to do some content length validation based on the Content-Length reported by the server. Currently, if the response has more or fewer bytes than indicated by the Content-Length, there's no error and due to encoding, it's not possible to detect the length of the payload actually read. Consider:
```
#!/usr/bin/env python3
import requests
resp = requests.get('http://en.wikipedia.org/wiki/Snowman', stream=True)
lines = list(resp.iter_lines(decode_unicode=True))
# this will fail if the content contains multi-byte characters
assert sum(map(len, lines)) == int(resp.headers['Content-Length'])
```
Of course, it would be possible if decoding of content is disabled, but then the reader is responsible for decoding. It would be preferable if there were a hook or attribute to enable the user to do the byte checking without forgoing decoding support.
Two suggestions:
- Have requests supply a 'bytes_read' on the Response object, which will be updated on any read operation.
- Provide a hook in the request allowing the user to supply a custom Response subclass for customizing response handling behavior.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/308610?v=4",
"events_url": "https://api.github.com/users/jaraco/events{/privacy}",
"followers_url": "https://api.github.com/users/jaraco/followers",
"following_url": "https://api.github.com/users/jaraco/following{/other_user}",
"gists_url": "https://api.github.com/users/jaraco/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jaraco",
"id": 308610,
"login": "jaraco",
"node_id": "MDQ6VXNlcjMwODYxMA==",
"organizations_url": "https://api.github.com/users/jaraco/orgs",
"received_events_url": "https://api.github.com/users/jaraco/received_events",
"repos_url": "https://api.github.com/users/jaraco/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jaraco/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jaraco/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jaraco",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1938/reactions"
} | https://api.github.com/repos/psf/requests/issues/1938/timeline | null | completed | null | null | false | [
"Hi there! Thanks for raising this issue!\n\nI assume your logic application logic is not the same as your example, because if it were I'd simply say you should avoid using `stream=True`. That way we store the data off and you can access it at your leisure using `Response.content` and `Response.text`.\n\nThe bigger... |
https://api.github.com/repos/psf/requests/issues/1937 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1937/labels{/name} | https://api.github.com/repos/psf/requests/issues/1937/comments | https://api.github.com/repos/psf/requests/issues/1937/events | https://github.com/psf/requests/pull/1937 | 28,743,376 | MDExOlB1bGxSZXF1ZXN0MTMxODM0MTU= | 1,937 | Improved decoding support for Response.iter_content and iter_lines | {
"avatar_url": "https://avatars.githubusercontent.com/u/308610?v=4",
"events_url": "https://api.github.com/users/jaraco/events{/privacy}",
"followers_url": "https://api.github.com/users/jaraco/followers",
"following_url": "https://api.github.com/users/jaraco/following{/other_user}",
"gists_url": "https://api.github.com/users/jaraco/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jaraco",
"id": 308610,
"login": "jaraco",
"node_id": "MDQ6VXNlcjMwODYxMA==",
"organizations_url": "https://api.github.com/users/jaraco/orgs",
"received_events_url": "https://api.github.com/users/jaraco/received_events",
"repos_url": "https://api.github.com/users/jaraco/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jaraco/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jaraco/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jaraco",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-03-04T21:38:30Z | 2021-09-08T23:06:26Z | 2014-05-12T19:04:35Z | CONTRIBUTOR | resolved | This PR adds basic documentation for the decode_unicode parameter to iter_content (and implicitly for iter_lines). It also ensures the now-documented behavior is correct and consistent, specifically by honoring the parameter in all cases and not just in some (previously only apparent by reading the source).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1937/reactions"
} | https://api.github.com/repos/psf/requests/issues/1937/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1937.diff",
"html_url": "https://github.com/psf/requests/pull/1937",
"merged_at": "2014-05-12T19:04:35Z",
"patch_url": "https://github.com/psf/requests/pull/1937.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1937"
} | true | [
"Thanks for this!\n\nIn general this fix looks great, thanks! Would you mind providing a test? One that confirms that you get back `unicode` in the cases in question would be good enough.\n",
":sparkles: :cake: :sparkles:\n"
] |
https://api.github.com/repos/psf/requests/issues/1936 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1936/labels{/name} | https://api.github.com/repos/psf/requests/issues/1936/comments | https://api.github.com/repos/psf/requests/issues/1936/events | https://github.com/psf/requests/issues/1936 | 28,535,365 | MDU6SXNzdWUyODUzNTM2NQ== | 1,936 | feature request: module-level configuration of ssl certs | {
"avatar_url": "https://avatars.githubusercontent.com/u/5677962?v=4",
"events_url": "https://api.github.com/users/thkang2/events{/privacy}",
"followers_url": "https://api.github.com/users/thkang2/followers",
"following_url": "https://api.github.com/users/thkang2/following{/other_user}",
"gists_url": "https://api.github.com/users/thkang2/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/thkang2",
"id": 5677962,
"login": "thkang2",
"node_id": "MDQ6VXNlcjU2Nzc5NjI=",
"organizations_url": "https://api.github.com/users/thkang2/orgs",
"received_events_url": "https://api.github.com/users/thkang2/received_events",
"repos_url": "https://api.github.com/users/thkang2/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/thkang2/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/thkang2/subscriptions",
"type": "User",
"url": "https://api.github.com/users/thkang2",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-02-28T21:41:10Z | 2021-09-09T00:10:03Z | 2014-02-28T22:18:24Z | NONE | resolved | there are some python 'freezers' like `cx_Freeze` are used to create executable that doesn't depend on system-wide python (and relevant packages) installs. However, when you freeze a script, many of them love to bundle every package on which script depends into a single zip file.
this doesn't play nice with `requests` - (on windows) when zipimported, it fails to load `cacert.pem` that is necessary for https connections. unless you disable ssl cert verification, you can't open any https connection.
since requests is a versatile and elegant http/s library for python, many other packages depend on it. which means that if you try to zipimport and use `somepackage` which depends on `requests`, and both modules are in a zip, then your `somepackage` will fail to use ssl.
I know there are many workarounds for this problem - one would be monkey patching `requests.get` (or other methods) like this:
```
import requests
import sys
import functools
_get = sys.modules['requests'].get
cert_path = <path-to-cacert.pem>
sys.modules['requests'].get = functools.partial(_get, verify=cert_path)
```
which works, but undeniably an ugly 'hack'. would you consider a module-level ssl certificates handling, that we can cope with failures to import system CA pem files? like:
```
import requests
requests.add_certs('certs.pem')
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1936/reactions"
} | https://api.github.com/repos/psf/requests/issues/1936/timeline | null | completed | null | null | false | [
"This is very similar to #1896 which we have already rejected. There are a couple serious issues with this functionality. The most worrisome of these issues is that developers who wish to do something malicious can easily package their own malicious certificate PEM file and distribute it. A naïve user would never q... |
https://api.github.com/repos/psf/requests/issues/1935 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1935/labels{/name} | https://api.github.com/repos/psf/requests/issues/1935/comments | https://api.github.com/repos/psf/requests/issues/1935/events | https://github.com/psf/requests/pull/1935 | 28,512,228 | MDExOlB1bGxSZXF1ZXN0MTMwNTcyNTE= | 1,935 | Add timeout to stream with testing | {
"avatar_url": "https://avatars.githubusercontent.com/u/4336127?v=4",
"events_url": "https://api.github.com/users/ceaess/events{/privacy}",
"followers_url": "https://api.github.com/users/ceaess/followers",
"following_url": "https://api.github.com/users/ceaess/following{/other_user}",
"gists_url": "https://api.github.com/users/ceaess/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ceaess",
"id": 4336127,
"login": "ceaess",
"node_id": "MDQ6VXNlcjQzMzYxMjc=",
"organizations_url": "https://api.github.com/users/ceaess/orgs",
"received_events_url": "https://api.github.com/users/ceaess/received_events",
"repos_url": "https://api.github.com/users/ceaess/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ceaess/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ceaess/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ceaess",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 17 | 2014-02-28T16:11:18Z | 2021-09-08T11:00:46Z | 2014-03-03T18:14:37Z | NONE | resolved | Fixes Issue #1803
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1935/reactions"
} | https://api.github.com/repos/psf/requests/issues/1935/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1935.diff",
"html_url": "https://github.com/psf/requests/pull/1935",
"merged_at": "2014-03-03T18:14:37Z",
"patch_url": "https://github.com/psf/requests/pull/1935.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1935"
} | true | [
"Hey @Lukasa can we have some :eyes: on this? I paired with @cjstapleton on this PR this morning. Let us know what you think.\n",
"Thanks for this, @cjstapleton! It looks great. =) I've made a couple of tiny stylistic notes inline, but the substance of this change is perfect.\n\nIt's worth noting that this implem... |
https://api.github.com/repos/psf/requests/issues/1934 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1934/labels{/name} | https://api.github.com/repos/psf/requests/issues/1934/comments | https://api.github.com/repos/psf/requests/issues/1934/events | https://github.com/psf/requests/pull/1934 | 28,504,383 | MDExOlB1bGxSZXF1ZXN0MTMwNTI3NzY= | 1,934 | Charade -> Chardet and Add cacert.pem license | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 5 | 2014-02-28T14:29:58Z | 2021-09-08T23:01:03Z | 2014-03-02T09:34:55Z | CONTRIBUTOR | resolved | - Charade is gone, long live Chardet.
- cacert.pem is now taken wholesale from Mozilla so we need to display that
itis licensed under the MPL2.0
Closes #1933
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1934/reactions"
} | https://api.github.com/repos/psf/requests/issues/1934/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1934.diff",
"html_url": "https://github.com/psf/requests/pull/1934",
"merged_at": "2014-03-02T09:34:55Z",
"patch_url": "https://github.com/psf/requests/pull/1934.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1934"
} | true | [
"@Lukasa this is essentially a documentation change. I included the other information about cacert.pem but I'm not sure it is entirely necessary in the NOTICE file. I'll happily remove it if you share the same doubts.\n",
"That extra bit of cacert.pem you included is actually part of the first certificate. =) We ... |
https://api.github.com/repos/psf/requests/issues/1933 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1933/labels{/name} | https://api.github.com/repos/psf/requests/issues/1933/comments | https://api.github.com/repos/psf/requests/issues/1933/events | https://github.com/psf/requests/issues/1933 | 28,492,727 | MDU6SXNzdWUyODQ5MjcyNw== | 1,933 | NOTICE file looks incorrect | {
"avatar_url": "https://avatars.githubusercontent.com/u/238622?v=4",
"events_url": "https://api.github.com/users/fdev31/events{/privacy}",
"followers_url": "https://api.github.com/users/fdev31/followers",
"following_url": "https://api.github.com/users/fdev31/following{/other_user}",
"gists_url": "https://api.github.com/users/fdev31/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/fdev31",
"id": 238622,
"login": "fdev31",
"node_id": "MDQ6VXNlcjIzODYyMg==",
"organizations_url": "https://api.github.com/users/fdev31/orgs",
"received_events_url": "https://api.github.com/users/fdev31/received_events",
"repos_url": "https://api.github.com/users/fdev31/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/fdev31/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/fdev31/subscriptions",
"type": "User",
"url": "https://api.github.com/users/fdev31",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-02-28T10:59:53Z | 2021-09-09T00:10:03Z | 2014-03-02T09:34:55Z | NONE | resolved | Looks like the NOTICE file wasn't updated after charade/chardet refactors.
Also, the PEM file license seems out of sync.
To be short, the licensing looks currently inconsistent.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1933/reactions"
} | https://api.github.com/repos/psf/requests/issues/1933/timeline | null | completed | null | null | false | [
"Good catch!\n\nThe charade/chardet switch is easy, but the fact that the PEM file is licensed under the MPL is a bit awkward: the easiest thing to do is to just whack the MPL text from the PEM file into NOTICE as well.\n"
] |
https://api.github.com/repos/psf/requests/issues/1932 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1932/labels{/name} | https://api.github.com/repos/psf/requests/issues/1932/comments | https://api.github.com/repos/psf/requests/issues/1932/events | https://github.com/psf/requests/pull/1932 | 28,399,387 | MDExOlB1bGxSZXF1ZXN0MTI5OTEwNjg= | 1,932 | Fix relative import which will fail on Python 3.X | {
"avatar_url": "https://avatars.githubusercontent.com/u/1407472?v=4",
"events_url": "https://api.github.com/users/Cosmius/events{/privacy}",
"followers_url": "https://api.github.com/users/Cosmius/followers",
"following_url": "https://api.github.com/users/Cosmius/following{/other_user}",
"gists_url": "https://api.github.com/users/Cosmius/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Cosmius",
"id": 1407472,
"login": "Cosmius",
"node_id": "MDQ6VXNlcjE0MDc0NzI=",
"organizations_url": "https://api.github.com/users/Cosmius/orgs",
"received_events_url": "https://api.github.com/users/Cosmius/received_events",
"repos_url": "https://api.github.com/users/Cosmius/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Cosmius/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Cosmius/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Cosmius",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-02-27T07:30:27Z | 2021-09-08T23:01:07Z | 2014-02-27T07:43:07Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1932/reactions"
} | https://api.github.com/repos/psf/requests/issues/1932/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1932.diff",
"html_url": "https://github.com/psf/requests/pull/1932",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1932.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1932"
} | true | [
"Thanks for this! Unfortunately, this change is in urllib3, which we take as-is from upstream, so you'd normally need to open your fixes there. However, this was actually fixed by shazow/urllib3#338, and so will be in the next version of Requests. =)\n\nThanks!\n"
] | |
https://api.github.com/repos/psf/requests/issues/1931 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1931/labels{/name} | https://api.github.com/repos/psf/requests/issues/1931/comments | https://api.github.com/repos/psf/requests/issues/1931/events | https://github.com/psf/requests/issues/1931 | 28,303,622 | MDU6SXNzdWUyODMwMzYyMg== | 1,931 | Upgrade to the latest verison of urllib3 | {
"avatar_url": "https://avatars.githubusercontent.com/u/8818?v=4",
"events_url": "https://api.github.com/users/hamish/events{/privacy}",
"followers_url": "https://api.github.com/users/hamish/followers",
"following_url": "https://api.github.com/users/hamish/following{/other_user}",
"gists_url": "https://api.github.com/users/hamish/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hamish",
"id": 8818,
"login": "hamish",
"node_id": "MDQ6VXNlcjg4MTg=",
"organizations_url": "https://api.github.com/users/hamish/orgs",
"received_events_url": "https://api.github.com/users/hamish/received_events",
"repos_url": "https://api.github.com/users/hamish/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hamish/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hamish/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hamish",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 615414998,
"name": "GAE Support",
"node_id": "MDU6TGFiZWw2MTU0MTQ5OTg=",
"url": "https://api.github.com/repos/psf/requests/labels/GAE%20Support"
}
] | closed | true | null | [] | null | 1 | 2014-02-26T02:18:25Z | 2021-09-08T09:00:48Z | 2014-02-26T07:21:04Z | NONE | resolved | When using the requests framework to connect to the xero accounting service from within Google App Engine (using pyxero), I get an error 'Exceeded 30 redirects.' After upgrading the included version of urllib3 to the latest version (1.7.1) the error did not occur any more, and the connection was successful.
More details here:
https://github.com/freakboy3742/pyxero/issues/23
Reproducible case here (this has the upgraded urllib3, you will need to revert to reproduce the problem):
https://github.com/hamish/gae_xero
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1931/reactions"
} | https://api.github.com/repos/psf/requests/issues/1931/timeline | null | completed | null | null | false | [
"@hamish This is a per-release action for us, so the next release should have the newest version of urllib3 in it. =)\n"
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.