url stringlengths 50 53 | repository_url stringclasses 1 value | labels_url stringlengths 64 67 | comments_url stringlengths 59 62 | events_url stringlengths 57 60 | html_url stringlengths 38 43 | id int64 597k 2.65B | node_id stringlengths 18 32 | number int64 1 6.83k | title stringlengths 1 296 | user dict | labels listlengths 0 5 | state stringclasses 2 values | locked bool 2 classes | assignee dict | assignees listlengths 0 4 | milestone dict | comments int64 0 211 | created_at stringlengths 20 20 | updated_at stringlengths 20 20 | closed_at stringlengths 20 20 ⌀ | author_association stringclasses 3 values | active_lock_reason stringclasses 4 values | body stringlengths 0 65.6k ⌀ | closed_by dict | reactions dict | timeline_url stringlengths 59 62 | performed_via_github_app null | state_reason stringclasses 3 values | draft bool 2 classes | pull_request dict | is_pull_request bool 2 classes | issue_comments listlengths 0 30 |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
https://api.github.com/repos/psf/requests/issues/1930 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1930/labels{/name} | https://api.github.com/repos/psf/requests/issues/1930/comments | https://api.github.com/repos/psf/requests/issues/1930/events | https://github.com/psf/requests/pull/1930 | 28,298,817 | MDExOlB1bGxSZXF1ZXN0MTI5MzI2MTk= | 1,930 | Candidate "improve manual redirect-walking" core API change. | {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 44501305,
"name": "Not Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTMwNQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Not%20Ready%20To%20Merge"
}
] | closed | true | null | [] | null | 18 | 2014-02-26T00:34:55Z | 2021-09-08T23:06:07Z | 2014-03-12T20:36:16Z | CONTRIBUTOR | resolved | Sorry for dropping off the face of the earth for a while, folks. After reading the reaction to my previous pull request, I realized that the bugfixes I want to get in will be easier, cleaner, and make more sense in context if I make the big API change _first_. So this is the proposed big API change. It is not fully baked -- if nothing else, it needs tests -- but I'd like to get your opinion on the idea first.
- Session.send now offers a new mode, `iter_redirects=True`, in which
it returns an iterator over redirects _instead of_ the first response.
In this mode, the first request does not actually fire until you call
next() on the iterator the first time. Unlike the legacy
Session.resolve_redirects, the first response is included in the
generated sequence.
- Session.resolve_redirects is preserved and works as it always has, but
is now clearly documented as not the API you want. (The docstring for
Session.send itself probably needs some improvement as well.) Its
calling convention has been slightly polished: the request argument is
now optional (defaults to `resp.redirect`), it will accept arbitrary
kwargs to be passed to the adapter, and it defaults the same set of kwargs
from session settings as `send` itself does.
- The `allow_redirects=False` mode of `Session.send` also still works just
as it always has. If both allow_redirects=False and iter_redirects=True
are specified, allow_redirects=False wins.
- SessionRedirectMixin has been replaced by a RedirectIterator class
which is not a parent of Session.
- Response.history is now always a list.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1930/reactions"
} | https://api.github.com/repos/psf/requests/issues/1930/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1930.diff",
"html_url": "https://github.com/psf/requests/pull/1930",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1930.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1930"
} | true | [
"> Session.send now offers a new mode, `iter_redirects=True`, in which\n> it returns an iterator over redirects instead of the first response. [...] If both allow_redirects=False and iter_redirects=True are specified, allow_redirects=False wins.\n\nAah! Nope, that's not the way to do this. That last sentence should... |
https://api.github.com/repos/psf/requests/issues/1929 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1929/labels{/name} | https://api.github.com/repos/psf/requests/issues/1929/comments | https://api.github.com/repos/psf/requests/issues/1929/events | https://github.com/psf/requests/issues/1929 | 28,291,820 | MDU6SXNzdWUyODI5MTgyMA== | 1,929 | Previous requests in redirect chain don't track their history | {
"avatar_url": "https://avatars.githubusercontent.com/u/772?v=4",
"events_url": "https://api.github.com/users/alex/events{/privacy}",
"followers_url": "https://api.github.com/users/alex/followers",
"following_url": "https://api.github.com/users/alex/following{/other_user}",
"gists_url": "https://api.github.com/users/alex/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alex",
"id": 772,
"login": "alex",
"node_id": "MDQ6VXNlcjc3Mg==",
"organizations_url": "https://api.github.com/users/alex/orgs",
"received_events_url": "https://api.github.com/users/alex/received_events",
"repos_url": "https://api.github.com/users/alex/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alex/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alex/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alex",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-02-25T22:40:13Z | 2021-09-08T23:07:55Z | 2014-10-10T19:20:59Z | MEMBER | resolved | Example:
``` pycon
>>> response = requests.get("http://djangoproject.com")
>>> response.history
(<Response [301]>, <Response [301]>)
>>> response.history[0].history
[]
>>> response.history[1].history
[]
```
I would have expected the first of the two items in `history` to have a `history` of its own.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1929/reactions"
} | https://api.github.com/repos/psf/requests/issues/1929/timeline | null | completed | null | null | false | [
"Thanks for this @alex! Assuming #1919 gets cleaned up this should be fixed by that pull request. =)\n",
"I'm actually thinking it'll be better to do stuff in a different order, see pull request #1930, but yeah, this is definitely on my todo list.\n",
"@alex fixed!\n"
] |
https://api.github.com/repos/psf/requests/issues/1928 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1928/labels{/name} | https://api.github.com/repos/psf/requests/issues/1928/comments | https://api.github.com/repos/psf/requests/issues/1928/events | https://github.com/psf/requests/issues/1928 | 28,078,839 | MDU6SXNzdWUyODA3ODgzOQ== | 1,928 | Limit overall execution time | {
"avatar_url": "https://avatars.githubusercontent.com/u/1811535?v=4",
"events_url": "https://api.github.com/users/andrewtryder/events{/privacy}",
"followers_url": "https://api.github.com/users/andrewtryder/followers",
"following_url": "https://api.github.com/users/andrewtryder/following{/other_user}",
"gists_url": "https://api.github.com/users/andrewtryder/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/andrewtryder",
"id": 1811535,
"login": "andrewtryder",
"node_id": "MDQ6VXNlcjE4MTE1MzU=",
"organizations_url": "https://api.github.com/users/andrewtryder/orgs",
"received_events_url": "https://api.github.com/users/andrewtryder/received_events",
"repos_url": "https://api.github.com/users/andrewtryder/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/andrewtryder/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/andrewtryder/subscriptions",
"type": "User",
"url": "https://api.github.com/users/andrewtryder",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | null | [] | null | 14 | 2014-02-21T22:39:54Z | 2015-01-31T16:18:40Z | 2015-01-19T09:21:42Z | NONE | null | This seems known but timeout in the .get() function only works if the server doesn't respond. Is there a way to have this also apply to the entire request? (grab a MP3 stream, file too large, site is responding but is too slow?) I'm utilizing requests in an application that grabs only 1MB of each page via .iter_content() for detecting MIME but have some issues where sites are so entirely slow that grabbing the 1MB (or whatever the page is until it completes) can easily take >60s.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1928/reactions"
} | https://api.github.com/repos/psf/requests/issues/1928/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nThe answer is 'yes', sort of. When not streaming the download we apply the supplied `timeout` value to both the connection attempt and the read. However, currently, when streaming the download we only apply the timeout to the connection attempt.\n\nThere's an ongoing discussion ab... |
https://api.github.com/repos/psf/requests/issues/1927 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1927/labels{/name} | https://api.github.com/repos/psf/requests/issues/1927/comments | https://api.github.com/repos/psf/requests/issues/1927/events | https://github.com/psf/requests/issues/1927 | 28,077,065 | MDU6SXNzdWUyODA3NzA2NQ== | 1,927 | cannot import pyopenssl | {
"avatar_url": "https://avatars.githubusercontent.com/u/960264?v=4",
"events_url": "https://api.github.com/users/flibbertigibbet/events{/privacy}",
"followers_url": "https://api.github.com/users/flibbertigibbet/followers",
"following_url": "https://api.github.com/users/flibbertigibbet/following{/other_user}",
"gists_url": "https://api.github.com/users/flibbertigibbet/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/flibbertigibbet",
"id": 960264,
"login": "flibbertigibbet",
"node_id": "MDQ6VXNlcjk2MDI2NA==",
"organizations_url": "https://api.github.com/users/flibbertigibbet/orgs",
"received_events_url": "https://api.github.com/users/flibbertigibbet/received_events",
"repos_url": "https://api.github.com/users/flibbertigibbet/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/flibbertigibbet/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/flibbertigibbet/subscriptions",
"type": "User",
"url": "https://api.github.com/users/flibbertigibbet",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-02-21T22:11:00Z | 2021-09-09T00:10:04Z | 2014-02-21T22:14:33Z | NONE | resolved | ```
from requests.packages.urllib3.contrib import pyopenssl
```
results in the error:
```
ImportError: No module named ndg.httpsclient.ssl_peer_verification
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1927/reactions"
} | https://api.github.com/repos/psf/requests/issues/1927/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nYou are not expected to be importing anything from `urllib3`'s `pyopenssl` module yourself, so it's not hugely surprising that this doesn't work. Nevertheless, if you really want to, you can go ahead and do it by installing the necessary dependencies, as included in [this StackOve... |
https://api.github.com/repos/psf/requests/issues/1926 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1926/labels{/name} | https://api.github.com/repos/psf/requests/issues/1926/comments | https://api.github.com/repos/psf/requests/issues/1926/events | https://github.com/psf/requests/issues/1926 | 27,885,873 | MDU6SXNzdWUyNzg4NTg3Mw== | 1,926 | UnicodeEncodeError when auth parameters are outside of latin-1encoding | {
"avatar_url": "https://avatars.githubusercontent.com/u/38861?v=4",
"events_url": "https://api.github.com/users/oinopion/events{/privacy}",
"followers_url": "https://api.github.com/users/oinopion/followers",
"following_url": "https://api.github.com/users/oinopion/following{/other_user}",
"gists_url": "https://api.github.com/users/oinopion/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/oinopion",
"id": 38861,
"login": "oinopion",
"node_id": "MDQ6VXNlcjM4ODYx",
"organizations_url": "https://api.github.com/users/oinopion/orgs",
"received_events_url": "https://api.github.com/users/oinopion/received_events",
"repos_url": "https://api.github.com/users/oinopion/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/oinopion/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oinopion/subscriptions",
"type": "User",
"url": "https://api.github.com/users/oinopion",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-02-19T16:01:55Z | 2021-09-09T00:01:06Z | 2014-03-23T11:51:13Z | NONE | resolved | To reproduce:
```
>>> import requests
>>> requests.get('http://example.com', auth=(u'żółty', u'jaźń'))
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/home/paczkowski/.virtualenvs/tmp-8a0b7916bbc9fce4/local/lib/python2.7/site-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/home/paczkowski/.virtualenvs/tmp-8a0b7916bbc9fce4/local/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/home/paczkowski/.virtualenvs/tmp-8a0b7916bbc9fce4/local/lib/python2.7/site-packages/requests/sessions.py", line 349, in request
prep = self.prepare_request(req)
File "/home/paczkowski/.virtualenvs/tmp-8a0b7916bbc9fce4/local/lib/python2.7/site-packages/requests/sessions.py", line 287, in prepare_request
hooks=merge_hooks(request.hooks, self.hooks),
File "/home/paczkowski/.virtualenvs/tmp-8a0b7916bbc9fce4/local/lib/python2.7/site-packages/requests/models.py", line 291, in prepare
self.prepare_auth(auth, url)
File "/home/paczkowski/.virtualenvs/tmp-8a0b7916bbc9fce4/local/lib/python2.7/site-packages/requests/models.py", line 470, in prepare_auth
r = auth(self)
File "/home/paczkowski/.virtualenvs/tmp-8a0b7916bbc9fce4/local/lib/python2.7/site-packages/requests/auth.py", line 48, in __call__
r.headers['Authorization'] = _basic_auth_str(self.username, self.password)
File "/home/paczkowski/.virtualenvs/tmp-8a0b7916bbc9fce4/local/lib/python2.7/site-packages/requests/auth.py", line 31, in _basic_auth_str
return 'Basic ' + b64encode(('%s:%s' % (username, password)).encode('latin1')).strip().decode('latin1')
UnicodeEncodeError: 'latin-1' codec can't encode character u'\u017c' in position 0: ordinal not in range(256)
```
I am not sure what behaviour is correct here, but rising `UnicodeEncodeError` is probably not the best.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1926/reactions"
} | https://api.github.com/repos/psf/requests/issues/1926/timeline | null | completed | null | null | false | [
"I don't have the time to find the spec but I think Headers are supposed to be encoded as latin strings (and that's how basic authentication and digest authentication is specified for the server). If Python cannot coerce your unicode credentials to Latin we should raise an exception. UnicodeEncodeError is a good on... |
https://api.github.com/repos/psf/requests/issues/1925 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1925/labels{/name} | https://api.github.com/repos/psf/requests/issues/1925/comments | https://api.github.com/repos/psf/requests/issues/1925/events | https://github.com/psf/requests/issues/1925 | 27,826,854 | MDU6SXNzdWUyNzgyNjg1NA== | 1,925 | Use ujson if available | {
"avatar_url": "https://avatars.githubusercontent.com/u/866147?v=4",
"events_url": "https://api.github.com/users/ntucker/events{/privacy}",
"followers_url": "https://api.github.com/users/ntucker/followers",
"following_url": "https://api.github.com/users/ntucker/following{/other_user}",
"gists_url": "https://api.github.com/users/ntucker/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ntucker",
"id": 866147,
"login": "ntucker",
"node_id": "MDQ6VXNlcjg2NjE0Nw==",
"organizations_url": "https://api.github.com/users/ntucker/orgs",
"received_events_url": "https://api.github.com/users/ntucker/received_events",
"repos_url": "https://api.github.com/users/ntucker/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ntucker/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ntucker/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ntucker",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-02-18T20:53:33Z | 2021-09-08T23:10:45Z | 2014-02-18T21:12:42Z | NONE | resolved | Benchmarks on the internet seem to suggest that ujson is the fastest json parser (e.g., http://www.justinfx.com/2012/07/25/python-2-7-3-serializer-speed-comparisons/).
Maybe try importing ujson first, then simplejson, then json?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1925/reactions"
} | https://api.github.com/repos/psf/requests/issues/1925/timeline | null | completed | null | null | false | [
"Thanks for reporting!\nHowever this seems to be a duplicate of #1595, where the same suggestion has been dismissed before.\n",
"@t-8ch Correct. =)\n\n@ntucker Thanks for the suggestion! Unfortunately, this is not a direction we're prepared to go. As I said [in the linked issue](https://github.com/kennethreitz/re... |
https://api.github.com/repos/psf/requests/issues/1924 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1924/labels{/name} | https://api.github.com/repos/psf/requests/issues/1924/comments | https://api.github.com/repos/psf/requests/issues/1924/events | https://github.com/psf/requests/pull/1924 | 27,796,661 | MDExOlB1bGxSZXF1ZXN0MTI2NTI1OTQ= | 1,924 | Default proxy scheme to HTTP | {
"avatar_url": "https://avatars.githubusercontent.com/u/238652?v=4",
"events_url": "https://api.github.com/users/schlamar/events{/privacy}",
"followers_url": "https://api.github.com/users/schlamar/followers",
"following_url": "https://api.github.com/users/schlamar/following{/other_user}",
"gists_url": "https://api.github.com/users/schlamar/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/schlamar",
"id": 238652,
"login": "schlamar",
"node_id": "MDQ6VXNlcjIzODY1Mg==",
"organizations_url": "https://api.github.com/users/schlamar/orgs",
"received_events_url": "https://api.github.com/users/schlamar/received_events",
"repos_url": "https://api.github.com/users/schlamar/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/schlamar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/schlamar/subscriptions",
"type": "User",
"url": "https://api.github.com/users/schlamar",
"user_view_type": "public"
} | [] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 10 | 2014-02-18T14:27:19Z | 2021-09-09T00:01:20Z | 2014-05-12T19:05:56Z | CONTRIBUTOR | resolved | See #1622.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1924/reactions"
} | https://api.github.com/repos/psf/requests/issues/1924/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1924.diff",
"html_url": "https://github.com/psf/requests/pull/1924",
"merged_at": "2014-05-12T19:05:56Z",
"patch_url": "https://github.com/psf/requests/pull/1924.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1924"
} | true | [
"I am happy enough to take this. =)\n",
"Note that this would have to go into 2.3.0.\n",
"@Lukasa I assume this stalled until 2.3 is in sight? Any rough ETA?\n",
"Kenneth is responsible for merging any code change, so he owns this I'm afraid. This will get merged when he has time. =)\n",
"Don't you usually ... |
https://api.github.com/repos/psf/requests/issues/1923 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1923/labels{/name} | https://api.github.com/repos/psf/requests/issues/1923/comments | https://api.github.com/repos/psf/requests/issues/1923/events | https://github.com/psf/requests/pull/1923 | 27,679,046 | MDExOlB1bGxSZXF1ZXN0MTI1OTM5MjU= | 1,923 | The timeout is in seconds. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-02-16T19:01:11Z | 2021-09-09T00:01:21Z | 2014-02-16T19:02:05Z | MEMBER | resolved | Resolves #1922.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1923/reactions"
} | https://api.github.com/repos/psf/requests/issues/1923/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1923.diff",
"html_url": "https://github.com/psf/requests/pull/1923",
"merged_at": "2014-02-16T19:02:05Z",
"patch_url": "https://github.com/psf/requests/pull/1923.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1923"
} | true | [
"I honestly don't know why I created this instead of committing directly. Note that this documentation change is pretending that #1801 doesn't exist for the moment.\n",
":cake: :shipit: (I know it's already shipped :P)\n"
] |
https://api.github.com/repos/psf/requests/issues/1922 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1922/labels{/name} | https://api.github.com/repos/psf/requests/issues/1922/comments | https://api.github.com/repos/psf/requests/issues/1922/events | https://github.com/psf/requests/issues/1922 | 27,678,958 | MDU6SXNzdWUyNzY3ODk1OA== | 1,922 | The documentation does not tell you what units timeout is specified in | {
"avatar_url": "https://avatars.githubusercontent.com/u/1394710?v=4",
"events_url": "https://api.github.com/users/colons/events{/privacy}",
"followers_url": "https://api.github.com/users/colons/followers",
"following_url": "https://api.github.com/users/colons/following{/other_user}",
"gists_url": "https://api.github.com/users/colons/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/colons",
"id": 1394710,
"login": "colons",
"node_id": "MDQ6VXNlcjEzOTQ3MTA=",
"organizations_url": "https://api.github.com/users/colons/orgs",
"received_events_url": "https://api.github.com/users/colons/received_events",
"repos_url": "https://api.github.com/users/colons/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/colons/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/colons/subscriptions",
"type": "User",
"url": "https://api.github.com/users/colons",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-02-16T18:56:17Z | 2021-09-09T00:10:06Z | 2014-02-16T19:02:05Z | NONE | resolved | I correctly assumed seconds, but not with enough confidence that I didn't have to dig about in the source until I found [this](https://github.com/kennethreitz/requests/blob/a5b3719967e685afe9e96359e69177fda0a10d44/requests/packages/urllib3/util.py#L108) to be sure, and even that isn't explicit.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1922/reactions"
} | https://api.github.com/repos/psf/requests/issues/1922/timeline | null | completed | null | null | false | [
"Thanks for raising this! I just pushed a fix, the documentation should be updated shortly. =)\n",
"Awesome, thanks.\n"
] |
https://api.github.com/repos/psf/requests/issues/1921 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1921/labels{/name} | https://api.github.com/repos/psf/requests/issues/1921/comments | https://api.github.com/repos/psf/requests/issues/1921/events | https://github.com/psf/requests/pull/1921 | 27,629,545 | MDExOlB1bGxSZXF1ZXN0MTI1NzQ5NzM= | 1,921 | Do not set headers with None value | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "207de5",
"default": false,
"description": null,
"id": 60620163,
"name": "Minion Seal of Approval",
"node_id": "MDU6TGFiZWw2MDYyMDE2Mw==",
"url": "https://api.github.com/repos/psf/requests/labels/Minion%20Seal%20of%20Approval"
}
] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 5 | 2014-02-14T22:15:56Z | 2021-09-08T23:06:12Z | 2014-03-03T18:13:13Z | CONTRIBUTOR | resolved | - Regardless of whether they are on the session or not
- Fixes #1920
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1921/reactions"
} | https://api.github.com/repos/psf/requests/issues/1921/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1921.diff",
"html_url": "https://github.com/psf/requests/pull/1921",
"merged_at": "2014-03-03T18:13:13Z",
"patch_url": "https://github.com/psf/requests/pull/1921.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1921"
} | true | [
"Assigning to @Lukasa for review and once past that, I will assign it to Kenneth.\n",
"LGTM. :+1:\n",
"FWIW, I think we used to do this back in 1.x but someone recently rewrote the `merge_setting` function (also they moved which file it is in so I couldn't find it at first =P) and they dropped this functionalit... |
https://api.github.com/repos/psf/requests/issues/1920 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1920/labels{/name} | https://api.github.com/repos/psf/requests/issues/1920/comments | https://api.github.com/repos/psf/requests/issues/1920/events | https://github.com/psf/requests/issues/1920 | 27,601,965 | MDU6SXNzdWUyNzYwMTk2NQ== | 1,920 | Removing a default header of a session | {
"avatar_url": "https://avatars.githubusercontent.com/u/34607?v=4",
"events_url": "https://api.github.com/users/miikka/events{/privacy}",
"followers_url": "https://api.github.com/users/miikka/followers",
"following_url": "https://api.github.com/users/miikka/following{/other_user}",
"gists_url": "https://api.github.com/users/miikka/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/miikka",
"id": 34607,
"login": "miikka",
"node_id": "MDQ6VXNlcjM0NjA3",
"organizations_url": "https://api.github.com/users/miikka/orgs",
"received_events_url": "https://api.github.com/users/miikka/received_events",
"repos_url": "https://api.github.com/users/miikka/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/miikka/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/miikka/subscriptions",
"type": "User",
"url": "https://api.github.com/users/miikka",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-02-14T15:18:04Z | 2021-09-09T00:10:02Z | 2014-03-03T18:13:13Z | CONTRIBUTOR | resolved | [The docs](http://docs.python-requests.org/en/latest/user/advanced/#session-objects) say that you can prevent sending a session header by setting the headers value to None in the method's arguments. You would expect (as [discussed on IRC](https://botbot.me/freenode/python-requests/msg/10788170/)) that this would work for session's default headers, too:
``` python
session = requests.Session()
# Do not send Accept-Encoding
session.headers['Accept-Encoding'] = None
```
What happens is that "None" gets sent as the value of header.
```
Accept-Encoding: None
```
For the reference, here is a way that works:
``` python
del session.headers['Accept-Encoding']
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1920/reactions"
} | https://api.github.com/repos/psf/requests/issues/1920/timeline | null | completed | null | null | false | [
"We _could_ do this, but I'm actually increasingly believing that the default headers dict is the right call here.\n",
"> We could do this, but I'm actually increasingly believing that the default headers dict is the right call here.\n\nI'm not sure what you're talking about.\n",
"@sigmavirus24 Sorry, I had th... |
https://api.github.com/repos/psf/requests/issues/1919 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1919/labels{/name} | https://api.github.com/repos/psf/requests/issues/1919/comments | https://api.github.com/repos/psf/requests/issues/1919/events | https://github.com/psf/requests/pull/1919 | 27,561,104 | MDExOlB1bGxSZXF1ZXN0MTI1MzQ5MDg= | 1,919 | Redirection-related bugfixes. | {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-02-13T23:15:35Z | 2021-09-09T00:01:22Z | 2014-02-26T00:50:42Z | CONTRIBUTOR | resolved | This pull request contains the subset of #1913 which (IMNSHO) consists entirely of bugfixes, with no question about backward compatibility or what the best behavior should be.
- `Session.resolve_redirects` no longer crashes, when responses are
being loaded in `stream=True` mode, if `Response.iter_content`
is used to consume the entire stream before advancing the generator.
- `Response.history` is now always a list, not a tuple.
- Each response in a chain of redirects now has a filled-out history
property, consisting of all responses up to but not including itself.
And I didn't bother mentioning it in HISTORY.rst, but `Session.send` doesn't create the redirection resolution generator anymore if it's not going to use it, and `resolve_redirects` doesn't extract cookies anymore that `send` has already extracted, both of which should make things ever so slightly more efficient.
Some of the new tests are pretty grody, and raise the question of whether the response-modification hook should really be _allowed_ to modify history, but there's specific code in `send` to support them, so this seems to have been a desired feature...
| {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1919/reactions"
} | https://api.github.com/repos/psf/requests/issues/1919/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1919.diff",
"html_url": "https://github.com/psf/requests/pull/1919",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1919.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1919"
} | true | [
"IYNSHO? =D Are you sure you're not a Requests core developer? You certainly have the attitude of one. ;)\n\nI'll try to code review this today, but shouldn't do it this morning, I have too many bugs at work. A quick note, though: we allow Response-modifying hooks to modify history because we use them for authentic... |
https://api.github.com/repos/psf/requests/issues/1918 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1918/labels{/name} | https://api.github.com/repos/psf/requests/issues/1918/comments | https://api.github.com/repos/psf/requests/issues/1918/events | https://github.com/psf/requests/pull/1918 | 27,545,275 | MDExOlB1bGxSZXF1ZXN0MTI1MjUxMzE= | 1,918 | New Response property, .is_redirect. | {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | [
{
"color": "207de5",
"default": false,
"description": null,
"id": 60620163,
"name": "Minion Seal of Approval",
"node_id": "MDU6TGFiZWw2MDYyMDE2Mw==",
"url": "https://api.github.com/repos/psf/requests/labels/Minion%20Seal%20of%20Approval"
}
] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 5 | 2014-02-13T19:31:51Z | 2021-09-08T23:05:24Z | 2014-02-13T21:03:37Z | CONTRIBUTOR | resolved | Here's a fresh pull request containing only the new `.is_redirect` property for Response objects.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1918/reactions"
} | https://api.github.com/repos/psf/requests/issues/1918/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1918.diff",
"html_url": "https://github.com/psf/requests/pull/1918",
"merged_at": "2014-02-13T21:03:37Z",
"patch_url": "https://github.com/psf/requests/pull/1918.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1918"
} | true | [
"This is a totally uncontroversial change. :+1: =D\n",
":shipit: \n",
":sparkles: :cake: :sparkles:\n",
"Excited about this.\n",
"I've discovered the flow for getting @kennethreitz to merge things faster. /Social Coding Hacking/\n"
] |
https://api.github.com/repos/psf/requests/issues/1917 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1917/labels{/name} | https://api.github.com/repos/psf/requests/issues/1917/comments | https://api.github.com/repos/psf/requests/issues/1917/events | https://github.com/psf/requests/issues/1917 | 27,516,802 | MDU6SXNzdWUyNzUxNjgwMg== | 1,917 | Documentation on the response from a streamed upload | {
"avatar_url": "https://avatars.githubusercontent.com/u/2115079?v=4",
"events_url": "https://api.github.com/users/techdragon/events{/privacy}",
"followers_url": "https://api.github.com/users/techdragon/followers",
"following_url": "https://api.github.com/users/techdragon/following{/other_user}",
"gists_url": "https://api.github.com/users/techdragon/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/techdragon",
"id": 2115079,
"login": "techdragon",
"node_id": "MDQ6VXNlcjIxMTUwNzk=",
"organizations_url": "https://api.github.com/users/techdragon/orgs",
"received_events_url": "https://api.github.com/users/techdragon/received_events",
"repos_url": "https://api.github.com/users/techdragon/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/techdragon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/techdragon/subscriptions",
"type": "User",
"url": "https://api.github.com/users/techdragon",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-02-13T13:14:56Z | 2021-09-09T00:10:07Z | 2014-02-13T23:48:25Z | NONE | resolved | When using this functionality http://docs.python-requests.org/en/latest/user/advanced/#streaming-uploads
there does not appear to be a response returned. I get nothing back when I try to assign the output of the function like so
```
with open('massive-body') as f:
response = requests.post('http://some.url/streamed', data=f)
print response
```
How can i get the response back from a request made like this.
I want to use this on some very large file uploads and was hoping to use the response to avoid having to issue get requests after the upload to confirm the file properties changed in order to know if the upload worked.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/2115079?v=4",
"events_url": "https://api.github.com/users/techdragon/events{/privacy}",
"followers_url": "https://api.github.com/users/techdragon/followers",
"following_url": "https://api.github.com/users/techdragon/following{/other_user}",
"gists_url": "https://api.github.com/users/techdragon/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/techdragon",
"id": 2115079,
"login": "techdragon",
"node_id": "MDQ6VXNlcjIxMTUwNzk=",
"organizations_url": "https://api.github.com/users/techdragon/orgs",
"received_events_url": "https://api.github.com/users/techdragon/received_events",
"repos_url": "https://api.github.com/users/techdragon/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/techdragon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/techdragon/subscriptions",
"type": "User",
"url": "https://api.github.com/users/techdragon",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1917/reactions"
} | https://api.github.com/repos/psf/requests/issues/1917/timeline | null | completed | null | null | false | [
"That's unexpected, since it works fine for me:\n\n``` python\n>>> import requests\n>>> with open('get-pip.py', 'r') as f:\n... response = requests.post('http://httpbin.org/post', data=f)\n...\n>>> print response\n<Response [200]>\n```\n\nCan you print `requests.__version__` and provide the version of Python yo... |
https://api.github.com/repos/psf/requests/issues/1916 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1916/labels{/name} | https://api.github.com/repos/psf/requests/issues/1916/comments | https://api.github.com/repos/psf/requests/issues/1916/events | https://github.com/psf/requests/pull/1916 | 27,502,464 | MDExOlB1bGxSZXF1ZXN0MTI1MDA0ODg= | 1,916 | Fix Accept-Encoding in default headers | {
"avatar_url": "https://avatars.githubusercontent.com/u/238652?v=4",
"events_url": "https://api.github.com/users/schlamar/events{/privacy}",
"followers_url": "https://api.github.com/users/schlamar/followers",
"following_url": "https://api.github.com/users/schlamar/following{/other_user}",
"gists_url": "https://api.github.com/users/schlamar/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/schlamar",
"id": 238652,
"login": "schlamar",
"node_id": "MDQ6VXNlcjIzODY1Mg==",
"organizations_url": "https://api.github.com/users/schlamar/orgs",
"received_events_url": "https://api.github.com/users/schlamar/received_events",
"repos_url": "https://api.github.com/users/schlamar/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/schlamar/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/schlamar/subscriptions",
"type": "User",
"url": "https://api.github.com/users/schlamar",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 15 | 2014-02-13T08:49:54Z | 2021-09-08T23:06:13Z | 2014-03-12T20:37:27Z | CONTRIBUTOR | resolved | urllib3 doesn't support "compress" anyway...
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1916/reactions"
} | https://api.github.com/repos/psf/requests/issues/1916/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1916.diff",
"html_url": "https://github.com/psf/requests/pull/1916",
"merged_at": "2014-03-12T20:37:27Z",
"patch_url": "https://github.com/psf/requests/pull/1916.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1916"
} | true | [
"This seems reasonable enough to me. =) :+1:\n",
"No objections here.\n",
":+1: one fewer thing for me to override to match real browsers.\n",
":shipit: \n",
"I think this just makes the code harder to read. Let's just remove 'compress' instead.\n",
"I don't want to be too coupled to urllib3. \n",
"> I ... |
https://api.github.com/repos/psf/requests/issues/1915 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1915/labels{/name} | https://api.github.com/repos/psf/requests/issues/1915/comments | https://api.github.com/repos/psf/requests/issues/1915/events | https://github.com/psf/requests/issues/1915 | 27,491,365 | MDU6SXNzdWUyNzQ5MTM2NQ== | 1,915 | TypeError: getresponse() got an unexpected keyword argument 'buffering' | {
"avatar_url": "https://avatars.githubusercontent.com/u/1447160?v=4",
"events_url": "https://api.github.com/users/jcea/events{/privacy}",
"followers_url": "https://api.github.com/users/jcea/followers",
"following_url": "https://api.github.com/users/jcea/following{/other_user}",
"gists_url": "https://api.github.com/users/jcea/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jcea",
"id": 1447160,
"login": "jcea",
"node_id": "MDQ6VXNlcjE0NDcxNjA=",
"organizations_url": "https://api.github.com/users/jcea/orgs",
"received_events_url": "https://api.github.com/users/jcea/received_events",
"repos_url": "https://api.github.com/users/jcea/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jcea/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jcea/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jcea",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 36 | 2014-02-13T03:00:34Z | 2017-03-16T09:35:23Z | 2014-02-13T12:50:10Z | NONE | null | Requests 2.2.1. Same thing happens in 1.2.3 (I upgraded from that).
I get this traceback:
```
Traceback (most recent call last):
File "/usr/local/lib/python3.3/site-packages/requests/packages/urllib3/connectionpool.py", line 313, in _make_request
httplib_response = conn.getresponse(buffering=True)
TypeError: getresponse() got an unexpected keyword argument 'buffering'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.3/site-packages/requests/packages/urllib3/connectionpool.py", line 480, in urlopen
body=body, headers=headers)
File "/usr/local/lib/python3.3/site-packages/requests/packages/urllib3/connectionpool.py", line 315, in _make_request
httplib_response = conn.getresponse()
File "/usr/local/lib/python3.3/http/client.py", line 1147, in getresponse
response.begin()
File "/usr/local/lib/python3.3/http/client.py", line 358, in begin
version, status, reason = self._read_status()
File "/usr/local/lib/python3.3/http/client.py", line 328, in _read_status
raise BadStatusLine(line)
http.client.BadStatusLine: ''
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/usr/local/lib/python3.3/site-packages/requests/adapters.py", line 330, in send
timeout=timeout
File "/usr/local/lib/python3.3/site-packages/requests/packages/urllib3/connectionpool.py", line 530, in urlopen
raise MaxRetryError(self, url, e)
requests.packages.urllib3.exceptions.MaxRetryError: HTTPSConnectionPool(host='heimdallr.jcea.es', port=443): Max retries exceeded with url: /PANICO (Caused by <class 'http.client.BadStatusLine'>: '')
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "./heimdallr.py", line 203, in <module>
module.start()
File "__main__", line 59, in start
File "main", line 23, in start
File "panic_report", line 17, in envia_tb_pendiente
File "/usr/local/lib/python3.3/site-packages/requests/sessions.py", line 425, in post
return self.request('POST', url, data=data, **kwargs)
File "auth_http", line 48, in request
File "/usr/local/lib/python3.3/site-packages/requests/sessions.py", line 383, in request
resp = self.send(prep, **send_kwargs)
File "/usr/local/lib/python3.3/site-packages/requests/sessions.py", line 486, in send
r = adapter.send(request, **kwargs)
File "/usr/local/lib/python3.3/site-packages/requests/adapters.py", line 378, in send
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPSConnectionPool(host='heimdallr.jcea.es', port=443): Max retries exceeded with url: /PANICO (Caused by <class 'http.client.BadStatusLine'>: '')
Makefile:69: recipe for target 'run' failed
make: *** [run] Error 1
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1915/reactions"
} | https://api.github.com/repos/psf/requests/issues/1915/timeline | null | completed | null | null | false | [
"For my own reference: this is 100% reproductible in changeset \"2e3cbe6aed98\" in my \"heimdallr\" Mercurial project, when running on master Raspberry PI.\n",
"@jcea did you search other issues on the project? Your ticket reminded me of https://github.com/kennethreitz/requests/issues/1289 but I searched for `get... |
https://api.github.com/repos/psf/requests/issues/1914 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1914/labels{/name} | https://api.github.com/repos/psf/requests/issues/1914/comments | https://api.github.com/repos/psf/requests/issues/1914/events | https://github.com/psf/requests/pull/1914 | 27,478,611 | MDExOlB1bGxSZXF1ZXN0MTI0ODc2MTQ= | 1,914 | Ensuring that the first argument to ConnectionError is a string | {
"avatar_url": "https://avatars.githubusercontent.com/u/14958?v=4",
"events_url": "https://api.github.com/users/hobbeswalsh/events{/privacy}",
"followers_url": "https://api.github.com/users/hobbeswalsh/followers",
"following_url": "https://api.github.com/users/hobbeswalsh/following{/other_user}",
"gists_url": "https://api.github.com/users/hobbeswalsh/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hobbeswalsh",
"id": 14958,
"login": "hobbeswalsh",
"node_id": "MDQ6VXNlcjE0OTU4",
"organizations_url": "https://api.github.com/users/hobbeswalsh/orgs",
"received_events_url": "https://api.github.com/users/hobbeswalsh/received_events",
"repos_url": "https://api.github.com/users/hobbeswalsh/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hobbeswalsh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hobbeswalsh/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hobbeswalsh",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 44501305,
"name": "Not Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTMwNQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Not%20Ready%20To%20Merge"
}
] | closed | true | null | [] | null | 6 | 2014-02-12T22:58:35Z | 2021-09-08T23:01:15Z | 2014-02-13T19:26:54Z | NONE | resolved | Putting an exception (or another type) as the first argument
to an Exception is confusing and makes it so that a caller's
"e.message" returns an Exception type rather than a string.
We spent quite a long time on this bug today -- a fix would be
much appreciated. Thanks!
--Robin
| {
"avatar_url": "https://avatars.githubusercontent.com/u/14958?v=4",
"events_url": "https://api.github.com/users/hobbeswalsh/events{/privacy}",
"followers_url": "https://api.github.com/users/hobbeswalsh/followers",
"following_url": "https://api.github.com/users/hobbeswalsh/following{/other_user}",
"gists_url": "https://api.github.com/users/hobbeswalsh/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hobbeswalsh",
"id": 14958,
"login": "hobbeswalsh",
"node_id": "MDQ6VXNlcjE0OTU4",
"organizations_url": "https://api.github.com/users/hobbeswalsh/orgs",
"received_events_url": "https://api.github.com/users/hobbeswalsh/received_events",
"repos_url": "https://api.github.com/users/hobbeswalsh/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hobbeswalsh/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hobbeswalsh/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hobbeswalsh",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1914/reactions"
} | https://api.github.com/repos/psf/requests/issues/1914/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1914.diff",
"html_url": "https://github.com/psf/requests/pull/1914",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1914.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1914"
} | true | [
"Thanks for raising this!\n\nWe actually quite like this behaviour, though: it means you can examine the exception object we wrapped. I'm going to let @sigmavirus24 weigh in here, but I think we're happy as-is.\n",
"Some of the exception objects that are nested inside of others at this point have much more debugg... |
https://api.github.com/repos/psf/requests/issues/1913 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1913/labels{/name} | https://api.github.com/repos/psf/requests/issues/1913/comments | https://api.github.com/repos/psf/requests/issues/1913/events | https://github.com/psf/requests/pull/1913 | 27,383,342 | MDExOlB1bGxSZXF1ZXN0MTI0MzM2NDE= | 1,913 | Improve API for manual redirection-following | {
"avatar_url": "https://avatars.githubusercontent.com/u/325899?v=4",
"events_url": "https://api.github.com/users/zackw/events{/privacy}",
"followers_url": "https://api.github.com/users/zackw/followers",
"following_url": "https://api.github.com/users/zackw/following{/other_user}",
"gists_url": "https://api.github.com/users/zackw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zackw",
"id": 325899,
"login": "zackw",
"node_id": "MDQ6VXNlcjMyNTg5OQ==",
"organizations_url": "https://api.github.com/users/zackw/orgs",
"received_events_url": "https://api.github.com/users/zackw/received_events",
"repos_url": "https://api.github.com/users/zackw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zackw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zackw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zackw",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "e11d21",
"default": false,
"descrip... | closed | true | null | [] | null | 24 | 2014-02-11T20:33:32Z | 2021-09-08T23:06:27Z | 2014-03-12T20:59:23Z | CONTRIBUTOR | resolved | I'd like to propose a bunch of bugfixes and API improvements to redirection resolution, particularly when it's being done manually (i.e. `allow_redirects=False` on the initial `send()`). These are all motivated by problems I encountered while trying to chase redirects for every single URL in the Alexa top million, which, as you might imagine, contains an awful lot of misconfiguredness (up to and including IMAP and SMTP servers on ports 80 and 443!)
The most significant change is the new `Session.resolve_one_redirect` method, which does what it says - it resolves _one_ redirect. This turns out to be substantially more convenient for applications that need to do complicated processing on each redirect as it happens, than the existing `Session.resolve_redirects` generator. It goes along with `Response.is_redirect`, a new property that is the canonical home for the "is this a redirect" predicate.
The second most significant change is that each response in a redirection chain now has an accurate `.history` property, containing all responses up to but not including itself. As a side effect, I anti-resolved issue #1898 - `.history` is now always a _list_.
The third most significant change is that `resolve_one_redirect` and `resolve_redirects` do not need to be passed a bunch of arguments that were already passed to the initial `send`; concretely, all of `send`'s kwargs are cached on the `PreparedRequest` and reused thereafter.
Everything else is bugfixes, generally in the service of greater robustness against Weird Shit coming off the network.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1913/reactions"
} | https://api.github.com/repos/psf/requests/issues/1913/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1913.diff",
"html_url": "https://github.com/psf/requests/pull/1913",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1913.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1913"
} | true | [
"Wow, this is a substantial change, and an impressive bit of work. I'm not going to dive into code review at this moment for two reasons: I don't have time, and I think we'll want @kennethreitz involved early in the discussion on this pull request.\n\nNevertheless, there'll definitely be a couple of code review com... |
https://api.github.com/repos/psf/requests/issues/1912 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1912/labels{/name} | https://api.github.com/repos/psf/requests/issues/1912/comments | https://api.github.com/repos/psf/requests/issues/1912/events | https://github.com/psf/requests/pull/1912 | 27,367,857 | MDExOlB1bGxSZXF1ZXN0MTI0MjQ2MzY= | 1,912 | Make a Response's history always a tuple | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-02-11T17:16:33Z | 2021-09-08T23:06:21Z | 2014-02-13T12:53:36Z | CONTRIBUTOR | resolved | Real fix for #1898
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1912/reactions"
} | https://api.github.com/repos/psf/requests/issues/1912/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1912.diff",
"html_url": "https://github.com/psf/requests/pull/1912",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1912.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1912"
} | true | [
"I realize this is a bit late, but I think this is going in the wrong direction: Response.history should always be a _list_, not a tuple. I think this because it starts out as an empty list, and if you're manually processing redirections or if you set a response-modification hook, you will encounter it that way ev... |
https://api.github.com/repos/psf/requests/issues/1911 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1911/labels{/name} | https://api.github.com/repos/psf/requests/issues/1911/comments | https://api.github.com/repos/psf/requests/issues/1911/events | https://github.com/psf/requests/issues/1911 | 27,359,003 | MDU6SXNzdWUyNzM1OTAwMw== | 1,911 | Boto/Route53 + GAE Compatibility Issue | {
"avatar_url": "https://avatars.githubusercontent.com/u/858881?v=4",
"events_url": "https://api.github.com/users/TFenby/events{/privacy}",
"followers_url": "https://api.github.com/users/TFenby/followers",
"following_url": "https://api.github.com/users/TFenby/following{/other_user}",
"gists_url": "https://api.github.com/users/TFenby/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/TFenby",
"id": 858881,
"login": "TFenby",
"node_id": "MDQ6VXNlcjg1ODg4MQ==",
"organizations_url": "https://api.github.com/users/TFenby/orgs",
"received_events_url": "https://api.github.com/users/TFenby/received_events",
"repos_url": "https://api.github.com/users/TFenby/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/TFenby/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/TFenby/subscriptions",
"type": "User",
"url": "https://api.github.com/users/TFenby",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 615414998,
"name": "GAE Support",
"node_id": "MDU6TGFiZWw2MTU0MTQ5OTg=",
"url": "https://api.github.com/repos/psf/requests/labels/GAE%20Support"
}
] | closed | true | null | [] | null | 4 | 2014-02-11T16:00:51Z | 2021-09-08T09:00:48Z | 2014-02-11T16:10:50Z | NONE | resolved | The issue described [here](http://stackoverflow.com/questions/21556587/connecting-to-route53-api-from-google-app-engine-using-boto/) applies to both Boto and gtaylor/python-route53.
Basically, when running Boto or Route53 on GAE, the way in which Requests extends httplib doesn't work with Google's httplib, which uses urlfetch instead of self.sock/self.connect. (Assuming I understood everything correctly in my quick debugging.) This causes the connection, despite being created as an HTTPS connection, to be established as HTTP, which Amazon refuses.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1911/reactions"
} | https://api.github.com/repos/psf/requests/issues/1911/timeline | null | completed | null | null | false | [
"We will not support GAE as we have frequently discussed on the issue tracker (most recently on https://github.com/kennethreitz/requests/issues/1905). Please search the bug tracker before opening requests in the future.\n\nCheers!\n",
"Ah, my bad. Thanks.\n",
"Almighty requests developer,\n\nNow that the underl... |
https://api.github.com/repos/psf/requests/issues/1910 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1910/labels{/name} | https://api.github.com/repos/psf/requests/issues/1910/comments | https://api.github.com/repos/psf/requests/issues/1910/events | https://github.com/psf/requests/issues/1910 | 27,339,679 | MDU6SXNzdWUyNzMzOTY3OQ== | 1,910 | 100% processor usage during GET have to wait 60s for response | {
"avatar_url": "https://avatars.githubusercontent.com/u/1621941?v=4",
"events_url": "https://api.github.com/users/e-manuel/events{/privacy}",
"followers_url": "https://api.github.com/users/e-manuel/followers",
"following_url": "https://api.github.com/users/e-manuel/following{/other_user}",
"gists_url": "https://api.github.com/users/e-manuel/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/e-manuel",
"id": 1621941,
"login": "e-manuel",
"node_id": "MDQ6VXNlcjE2MjE5NDE=",
"organizations_url": "https://api.github.com/users/e-manuel/orgs",
"received_events_url": "https://api.github.com/users/e-manuel/received_events",
"repos_url": "https://api.github.com/users/e-manuel/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/e-manuel/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/e-manuel/subscriptions",
"type": "User",
"url": "https://api.github.com/users/e-manuel",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 39 | 2014-02-11T11:11:44Z | 2021-09-08T23:08:01Z | 2014-03-23T11:49:27Z | NONE | resolved | When GET request have to wait 60s for remote service response, processor usage increases to 100% - version 1 of "requests" worked in this case better.
GET is configured with "cert" data and "timeout=120" over SSL connection.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1910/reactions"
} | https://api.github.com/repos/psf/requests/issues/1910/timeline | null | completed | null | null | false | [
"Do you have a publicly-accessible URL that I can test against?\n",
"More details: GET is fired by sub-process (multiprocessing) - GET is calling API exposed by GSM operator - by this API I am receiving SMS and MMS. Other tasks fired by sub-proceses are using CPU below 1% (server with 2 Xeons).\nI can expose on m... |
https://api.github.com/repos/psf/requests/issues/1909 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1909/labels{/name} | https://api.github.com/repos/psf/requests/issues/1909/comments | https://api.github.com/repos/psf/requests/issues/1909/events | https://github.com/psf/requests/issues/1909 | 27,312,448 | MDU6SXNzdWUyNzMxMjQ0OA== | 1,909 | Header output when debugging is poorly formatted and missing values | {
"avatar_url": "https://avatars.githubusercontent.com/u/308610?v=4",
"events_url": "https://api.github.com/users/jaraco/events{/privacy}",
"followers_url": "https://api.github.com/users/jaraco/followers",
"following_url": "https://api.github.com/users/jaraco/following{/other_user}",
"gists_url": "https://api.github.com/users/jaraco/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jaraco",
"id": 308610,
"login": "jaraco",
"node_id": "MDQ6VXNlcjMwODYxMA==",
"organizations_url": "https://api.github.com/users/jaraco/orgs",
"received_events_url": "https://api.github.com/users/jaraco/received_events",
"repos_url": "https://api.github.com/users/jaraco/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jaraco/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jaraco/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jaraco",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-02-10T23:36:19Z | 2021-09-09T00:10:09Z | 2014-02-10T23:59:59Z | CONTRIBUTOR | resolved | Consider this script:
```
import logging
import requests
def setup_requests_logging(level):
requests_log = logging.getLogger("requests.packages.urllib3")
requests_log.setLevel(level)
requests_log.propagate = True
# enable debugging at httplib level
requests.packages.urllib3.connectionpool.HTTPConnection.debuglevel = level <= logging.DEBUG
logging.basicConfig(level=logging.DEBUG)
setup_requests_logging(logging.getLogger().level)
requests.get('http://google.com')
```
If I run that script on Python 3.4.0rc1, the output is clumsy and less than fully helpful:
```
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): google.com
send: b'GET / HTTP/1.1\r\nHost: google.com\r\nAccept-Encoding: gzip, deflate, compress\r\nAccept: */*\r\nUser-Agent: python-requests/2.2.1 CPython/3.4.0b3 Windows/8\r\n\r\n'
reply: 'HTTP/1.1 301 Moved Permanently\r\n'
DEBUG:requests.packages.urllib3.connectionpool:"GET / HTTP/1.1" 301 219
INFO:requests.packages.urllib3.connectionpool:Starting new HTTP connection (1): www.google.com
header: Location header: Content-Type header: Date header: Expires header: Cache-Control header: Server header: Content-Length header: X-XSS-Protection header: X-Frame-Options header: Alternate-Protocol send: b'GET / HTTP/1.1\r\nHost: www.google.com\r\nUser-Agent: python-requests/2.2.1 CPython/3.4.0b3 Windows/8\r\nAccept: */*\r\nAccept-Encoding: gzip, deflate, compress\r\n\r\n'
reply: 'HTTP/1.1 200 OK\r\n'
DEBUG:requests.packages.urllib3.connectionpool:"GET / HTTP/1.1" 200 None
header: Date header: Expires header: Cache-Control header: Content-Type header: Set-Cookie header: Set-Cookie header: P3P header: Server header: X-XSS-Protection header: X-Frame-Options header: Alternate-Protocol header: Transfer-Encoding
```
Note, that formatting is how the output is logged. Header names are printed but not their values, and there's only a space following the name. It would be much preferable if the headers were printed line-by-line with their values, or if they were printed as a repr(dict) or json representation. As they are, the output isn't very helpful.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1909/reactions"
} | https://api.github.com/repos/psf/requests/issues/1909/timeline | null | completed | null | null | false | [
"Requests is 2.2.1.\n",
"If you look at the output closely you'll see that all of the information is being printed by `requests.packages.urllib3.connectionpool` and none of it is actually produced by something inside of `requests` proper. This is because `requests` does no logging in its code at all. This was rem... |
https://api.github.com/repos/psf/requests/issues/1908 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1908/labels{/name} | https://api.github.com/repos/psf/requests/issues/1908/comments | https://api.github.com/repos/psf/requests/issues/1908/events | https://github.com/psf/requests/pull/1908 | 27,206,730 | MDExOlB1bGxSZXF1ZXN0MTIzNDQ0NTg= | 1,908 | Removed unnecessary if-statements | {
"avatar_url": "https://avatars.githubusercontent.com/u/174994?v=4",
"events_url": "https://api.github.com/users/benediktkr/events{/privacy}",
"followers_url": "https://api.github.com/users/benediktkr/followers",
"following_url": "https://api.github.com/users/benediktkr/following{/other_user}",
"gists_url": "https://api.github.com/users/benediktkr/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/benediktkr",
"id": 174994,
"login": "benediktkr",
"node_id": "MDQ6VXNlcjE3NDk5NA==",
"organizations_url": "https://api.github.com/users/benediktkr/orgs",
"received_events_url": "https://api.github.com/users/benediktkr/received_events",
"repos_url": "https://api.github.com/users/benediktkr/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/benediktkr/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/benediktkr/subscriptions",
"type": "User",
"url": "https://api.github.com/users/benediktkr",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-02-08T19:20:40Z | 2021-09-08T22:01:19Z | 2014-02-08T19:27:24Z | NONE | resolved | Passes all unit tests like this.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1908/reactions"
} | https://api.github.com/repos/psf/requests/issues/1908/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1908.diff",
"html_url": "https://github.com/psf/requests/pull/1908",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1908.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1908"
} | true | [
"Those conditionals are 100% necessary. `verify` can be (and frequently is) `False` or a path to a certificate bundle. We must conditionally set the values. Consider the paths through this code: \n1. `verify` is `True`: then `cert_loc` will be the default bundle\n2. `verify` is `False`: then `cert_loc` will be `Fal... |
https://api.github.com/repos/psf/requests/issues/1907 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1907/labels{/name} | https://api.github.com/repos/psf/requests/issues/1907/comments | https://api.github.com/repos/psf/requests/issues/1907/events | https://github.com/psf/requests/pull/1907 | 27,139,403 | MDExOlB1bGxSZXF1ZXN0MTIzMTQ0MTM= | 1,907 | Use by default SSL CA certificate bundle from the platform | {
"avatar_url": "https://avatars.githubusercontent.com/u/1174343?v=4",
"events_url": "https://api.github.com/users/ticosax/events{/privacy}",
"followers_url": "https://api.github.com/users/ticosax/followers",
"following_url": "https://api.github.com/users/ticosax/following{/other_user}",
"gists_url": "https://api.github.com/users/ticosax/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ticosax",
"id": 1174343,
"login": "ticosax",
"node_id": "MDQ6VXNlcjExNzQzNDM=",
"organizations_url": "https://api.github.com/users/ticosax/orgs",
"received_events_url": "https://api.github.com/users/ticosax/received_events",
"repos_url": "https://api.github.com/users/ticosax/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ticosax/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ticosax/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ticosax",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 20 | 2014-02-07T14:50:28Z | 2021-09-08T23:06:02Z | 2014-02-08T13:35:06Z | NONE | resolved | If pyopenssl is available and you give an empty ca_certs to urllib3,
it will use the default CA of the current platform.
Not ready for merging as this feature requires a bleeding edge version of urllib3 (https://github.com/shazow/urllib3/commit/5c25a73dfb48e4260c44e19e3a50fb5d46832c52)
I post this PR now, to discuss about its implementation and testing improvements.
About testing we could run the project with tox and iterate among different versions of python and with or without dependencies of urllib3.contrib.pyopenssl.
```
pyOpenSSL
ndg-httpsclient
pyasn1
```
thx
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1174343?v=4",
"events_url": "https://api.github.com/users/ticosax/events{/privacy}",
"followers_url": "https://api.github.com/users/ticosax/followers",
"following_url": "https://api.github.com/users/ticosax/following{/other_user}",
"gists_url": "https://api.github.com/users/ticosax/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ticosax",
"id": 1174343,
"login": "ticosax",
"node_id": "MDQ6VXNlcjExNzQzNDM=",
"organizations_url": "https://api.github.com/users/ticosax/orgs",
"received_events_url": "https://api.github.com/users/ticosax/received_events",
"repos_url": "https://api.github.com/users/ticosax/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ticosax/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ticosax/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ticosax",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1907/reactions"
} | https://api.github.com/repos/psf/requests/issues/1907/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1907.diff",
"html_url": "https://github.com/psf/requests/pull/1907",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1907.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1907"
} | true | [
"Ok, let's think about how this works from the perspective of the standard Requests API. It's intended to be used in one of these ways:\n\n``` python\n# Verify certs using the bundled cacerts.\nr = requests.get('https://somesslurl.com/')\n\n# Use your own cacerts.\nr = requests.get('https://somesslurl.com/', verify... |
https://api.github.com/repos/psf/requests/issues/1906 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1906/labels{/name} | https://api.github.com/repos/psf/requests/issues/1906/comments | https://api.github.com/repos/psf/requests/issues/1906/events | https://github.com/psf/requests/issues/1906 | 27,125,706 | MDU6SXNzdWUyNzEyNTcwNg== | 1,906 | OpenSSL.SSL.Error: [('SSL routines', 'SSL3_GET_RECORD', 'decryption failed or bad record mac')] | {
"avatar_url": "https://avatars.githubusercontent.com/u/102495?v=4",
"events_url": "https://api.github.com/users/ssbarnea/events{/privacy}",
"followers_url": "https://api.github.com/users/ssbarnea/followers",
"following_url": "https://api.github.com/users/ssbarnea/following{/other_user}",
"gists_url": "https://api.github.com/users/ssbarnea/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ssbarnea",
"id": 102495,
"login": "ssbarnea",
"node_id": "MDQ6VXNlcjEwMjQ5NQ==",
"organizations_url": "https://api.github.com/users/ssbarnea/orgs",
"received_events_url": "https://api.github.com/users/ssbarnea/received_events",
"repos_url": "https://api.github.com/users/ssbarnea/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ssbarnea/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ssbarnea/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ssbarnea",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 136589914,
"name": "Needs Info",
"node_id": "MDU6TGFiZWwxMzY1ODk5MTQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20Info"
},
{
"color": "f7c6c7",
"default": false,
"description": null,
... | closed | true | null | [] | null | 49 | 2014-02-07T10:31:07Z | 2021-09-08T08:00:38Z | 2015-01-19T09:22:04Z | CONTRIBUTOR | resolved | It seems that latest requests (2.2.1) is also affected by bug:
OpenSSL.SSL.Error: [('SSL routines', 'SSL3_GET_RECORD', 'decryption failed or bad record mac')]
It seems to be an workaround here http://stackoverflow.com/questions/21497591/urllib2-reading-https-url-failure but I don't know how to apply it to requests.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1906/reactions"
} | https://api.github.com/repos/psf/requests/issues/1906/timeline | null | completed | null | null | false | [
"Thanks for this!\n\nYeah, this isn't really a request bug, as the SO question highlights: it's a Debian or OpenSSL bug.\n\nWith that said, a possible workaround would be an extension of the transport adapter demonstrated on my blog, here: https://lukasa.co.uk/2013/01/Choosing_SSL_Version_In_Requests/\n",
"It's a... |
https://api.github.com/repos/psf/requests/issues/1905 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1905/labels{/name} | https://api.github.com/repos/psf/requests/issues/1905/comments | https://api.github.com/repos/psf/requests/issues/1905/events | https://github.com/psf/requests/issues/1905 | 27,056,980 | MDU6SXNzdWUyNzA1Njk4MA== | 1,905 | HTTPS not working on Google App Engine | {
"avatar_url": "https://avatars.githubusercontent.com/u/2834052?v=4",
"events_url": "https://api.github.com/users/cpavon/events{/privacy}",
"followers_url": "https://api.github.com/users/cpavon/followers",
"following_url": "https://api.github.com/users/cpavon/following{/other_user}",
"gists_url": "https://api.github.com/users/cpavon/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cpavon",
"id": 2834052,
"login": "cpavon",
"node_id": "MDQ6VXNlcjI4MzQwNTI=",
"organizations_url": "https://api.github.com/users/cpavon/orgs",
"received_events_url": "https://api.github.com/users/cpavon/received_events",
"repos_url": "https://api.github.com/users/cpavon/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cpavon/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cpavon/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cpavon",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 615414998,
"name": "GAE Support",
"node_id": "MDU6TGFiZWw2MTU0MTQ5OTg=",
"url": "https://api.github.com/repos/psf/requests/labels/GAE%20Support"
}
] | closed | true | null | [] | null | 13 | 2014-02-06T15:22:35Z | 2021-09-08T09:00:47Z | 2014-02-06T17:12:38Z | NONE | resolved | Take a look here: http://stackoverflow.com/questions/21605328/python-requests-on-google-app-engine-not-working-for-https
Thanks!
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1905/reactions"
} | https://api.github.com/repos/psf/requests/issues/1905/timeline | null | completed | null | null | false | [
"Unfortunately, Requests explicitly doesn't support GAE. It's just not Python. =)\n",
"I guess directing OP to some details on why/how _GAE is not Python_ would be appreciated :)\n",
"Heh, this is a fair point.\n\nThe short answer is that GAE doesn't use the same standard library as core Python does. This is pa... |
https://api.github.com/repos/psf/requests/issues/1904 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1904/labels{/name} | https://api.github.com/repos/psf/requests/issues/1904/comments | https://api.github.com/repos/psf/requests/issues/1904/events | https://github.com/psf/requests/pull/1904 | 26,981,151 | MDExOlB1bGxSZXF1ZXN0MTIyMzE4NzE= | 1,904 | Document the `Response.reason` attribute. | {
"avatar_url": "https://avatars.githubusercontent.com/u/46775?v=4",
"events_url": "https://api.github.com/users/mjpieters/events{/privacy}",
"followers_url": "https://api.github.com/users/mjpieters/followers",
"following_url": "https://api.github.com/users/mjpieters/following{/other_user}",
"gists_url": "https://api.github.com/users/mjpieters/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mjpieters",
"id": 46775,
"login": "mjpieters",
"node_id": "MDQ6VXNlcjQ2Nzc1",
"organizations_url": "https://api.github.com/users/mjpieters/orgs",
"received_events_url": "https://api.github.com/users/mjpieters/received_events",
"repos_url": "https://api.github.com/users/mjpieters/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mjpieters/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mjpieters/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mjpieters",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-02-05T17:31:31Z | 2021-09-08T23:11:09Z | 2014-02-05T18:32:16Z | CONTRIBUTOR | resolved | Made `.status_code` and `.reason` consistent with one another, adding some examples. Addresses #1225.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1904/reactions"
} | https://api.github.com/repos/psf/requests/issues/1904/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1904.diff",
"html_url": "https://github.com/psf/requests/pull/1904",
"merged_at": "2014-02-05T18:32:16Z",
"patch_url": "https://github.com/psf/requests/pull/1904.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1904"
} | true | [
"This is a purely documentation change, so I'm going to go ahead and merge it.\n\nThanks! :cake: Thanks for all your work over on SO as well. =3\n"
] |
https://api.github.com/repos/psf/requests/issues/1903 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1903/labels{/name} | https://api.github.com/repos/psf/requests/issues/1903/comments | https://api.github.com/repos/psf/requests/issues/1903/events | https://github.com/psf/requests/issues/1903 | 26,869,676 | MDU6SXNzdWUyNjg2OTY3Ng== | 1,903 | Requests can't handle HTTPS proxy requests. | {
"avatar_url": "https://avatars.githubusercontent.com/u/5655555?v=4",
"events_url": "https://api.github.com/users/richmilne/events{/privacy}",
"followers_url": "https://api.github.com/users/richmilne/followers",
"following_url": "https://api.github.com/users/richmilne/following{/other_user}",
"gists_url": "https://api.github.com/users/richmilne/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/richmilne",
"id": 5655555,
"login": "richmilne",
"node_id": "MDQ6VXNlcjU2NTU1NTU=",
"organizations_url": "https://api.github.com/users/richmilne/orgs",
"received_events_url": "https://api.github.com/users/richmilne/received_events",
"repos_url": "https://api.github.com/users/richmilne/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/richmilne/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/richmilne/subscriptions",
"type": "User",
"url": "https://api.github.com/users/richmilne",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-02-04T09:45:52Z | 2021-09-08T23:08:02Z | 2014-02-04T10:35:02Z | NONE | resolved | Consider this snippet of code:
``` python
import requests
from requests.auth import HTTPProxyAuth
auth = HTTPProxyAuth('username', 'password')
proxy = {'https': 'https://192.168.0.1/'}
req = requests.get('http://www.google.com', proxies=proxy, auth=auth)
```
What I expect the code to do is to send an encrypted request (as implied by http_S_ to the proxy URL (192.168.0.1), the payload of which is the URL I want to retrieve (www.google.com).
What Requests does instead is send a query directly to the target (Google), with the proxy credentials, Base64 encoded, in the header! The request does not go near the proxy, which you can check by entering invalid credentials in the snippet above (which should result in some 40\* error, but passes silently.)
If the proxy URL is changed to "HTTP", the transfer works as expected (credentials sent to proxy, proxy fetches target URL), only the conversation is not encrypted.
This was tested under Requests v1.2.0, and the latest version, 2.2.1
Am I just using the module incorrectly, or is this a bug in Requests?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1903/reactions"
} | https://api.github.com/repos/psf/requests/issues/1903/timeline | null | completed | null | null | false | [
"The answer is complicated, let me address it in stages.\n\nFirst, you're misusing the library. Consider the proxies dictionary. It has this form: `{scheme: proxyURL}`. When you made a request, we look at the scheme for the URL you've asked for, and see if you've asked for proxies on that scheme. In your example ab... |
https://api.github.com/repos/psf/requests/issues/1902 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1902/labels{/name} | https://api.github.com/repos/psf/requests/issues/1902/comments | https://api.github.com/repos/psf/requests/issues/1902/events | https://github.com/psf/requests/pull/1902 | 26,803,306 | MDExOlB1bGxSZXF1ZXN0MTIxMzMyMDk= | 1,902 | Remove unused loggers. | {
"avatar_url": "https://avatars.githubusercontent.com/u/46775?v=4",
"events_url": "https://api.github.com/users/mjpieters/events{/privacy}",
"followers_url": "https://api.github.com/users/mjpieters/followers",
"following_url": "https://api.github.com/users/mjpieters/following{/other_user}",
"gists_url": "https://api.github.com/users/mjpieters/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mjpieters",
"id": 46775,
"login": "mjpieters",
"node_id": "MDQ6VXNlcjQ2Nzc1",
"organizations_url": "https://api.github.com/users/mjpieters/orgs",
"received_events_url": "https://api.github.com/users/mjpieters/received_events",
"repos_url": "https://api.github.com/users/mjpieters/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mjpieters/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mjpieters/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mjpieters",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 4 | 2014-02-03T13:45:16Z | 2021-09-08T23:05:05Z | 2014-02-07T02:32:41Z | CONTRIBUTOR | resolved | Logging has been removed long ago, the import and `log` object are dead code to be pruned with a vengeance.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1902/reactions"
} | https://api.github.com/repos/psf/requests/issues/1902/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1902.diff",
"html_url": "https://github.com/psf/requests/pull/1902",
"merged_at": "2014-02-07T02:32:41Z",
"patch_url": "https://github.com/psf/requests/pull/1902.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1902"
} | true | [
":+1:\n",
":+1: \n",
"Dear Jenkins: please rebuild this pull request.\n",
"Well that failed spectacularly.\n"
] |
https://api.github.com/repos/psf/requests/issues/1901 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1901/labels{/name} | https://api.github.com/repos/psf/requests/issues/1901/comments | https://api.github.com/repos/psf/requests/issues/1901/events | https://github.com/psf/requests/pull/1901 | 26,803,055 | MDExOlB1bGxSZXF1ZXN0MTIxMzMwNTg= | 1,901 | One last Charade reference to remove here. | {
"avatar_url": "https://avatars.githubusercontent.com/u/46775?v=4",
"events_url": "https://api.github.com/users/mjpieters/events{/privacy}",
"followers_url": "https://api.github.com/users/mjpieters/followers",
"following_url": "https://api.github.com/users/mjpieters/following{/other_user}",
"gists_url": "https://api.github.com/users/mjpieters/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mjpieters",
"id": 46775,
"login": "mjpieters",
"node_id": "MDQ6VXNlcjQ2Nzc1",
"organizations_url": "https://api.github.com/users/mjpieters/orgs",
"received_events_url": "https://api.github.com/users/mjpieters/received_events",
"repos_url": "https://api.github.com/users/mjpieters/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mjpieters/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mjpieters/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mjpieters",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-02-03T13:40:24Z | 2021-09-08T23:05:07Z | 2014-02-04T08:53:53Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1901/reactions"
} | https://api.github.com/repos/psf/requests/issues/1901/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1901.diff",
"html_url": "https://github.com/psf/requests/pull/1901",
"merged_at": "2014-02-04T08:53:53Z",
"patch_url": "https://github.com/psf/requests/pull/1901.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1901"
} | true | [
"This is an obvious :+1:. =D\n",
"This amounts to essentially a documentation change. I don't see why it shouldn't be merged immediately (or as soon as the build passes).\n",
"Looks like the CI server is having a tough time, I haven't seen any of these builds pass.\n",
"It notifies people in IRC right? Freeno... | |
https://api.github.com/repos/psf/requests/issues/1900 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1900/labels{/name} | https://api.github.com/repos/psf/requests/issues/1900/comments | https://api.github.com/repos/psf/requests/issues/1900/events | https://github.com/psf/requests/pull/1900 | 26,797,484 | MDExOlB1bGxSZXF1ZXN0MTIxMzAxOTQ= | 1,900 | Reinstate falling back to self.text for JSON responses | {
"avatar_url": "https://avatars.githubusercontent.com/u/46775?v=4",
"events_url": "https://api.github.com/users/mjpieters/events{/privacy}",
"followers_url": "https://api.github.com/users/mjpieters/followers",
"following_url": "https://api.github.com/users/mjpieters/following{/other_user}",
"gists_url": "https://api.github.com/users/mjpieters/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mjpieters",
"id": 46775,
"login": "mjpieters",
"node_id": "MDQ6VXNlcjQ2Nzc1",
"organizations_url": "https://api.github.com/users/mjpieters/orgs",
"received_events_url": "https://api.github.com/users/mjpieters/received_events",
"repos_url": "https://api.github.com/users/mjpieters/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mjpieters/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mjpieters/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mjpieters",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2014-02-03T12:01:10Z | 2021-09-08T23:05:09Z | 2014-02-11T16:55:21Z | CONTRIBUTOR | resolved | A JSON response that has no encoding specified will be decoded with a detected UTF codec (compliant with the JSON RFC), but if that fails, we guessed wrong and need to fall back to charade character detection (via `self.text`). Kenneth removed this functionality (by accident?) in 1451ba0c6d395c41f86da35036fa361c3a41bc90, this reinstates it again and adds a log warning.
Fixes #1674
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1900/reactions"
} | https://api.github.com/repos/psf/requests/issues/1900/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1900.diff",
"html_url": "https://github.com/psf/requests/pull/1900",
"merged_at": "2014-02-11T16:55:21Z",
"patch_url": "https://github.com/psf/requests/pull/1900.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1900"
} | true | [
"Hooray! :+1: :cake:\n",
"> Nowhere else in the file is logging used. Can you remove this line and the import at the top of the file please?\n\nRest of the `logging` references excised in #1902. \n",
"Thanks @mjpieters! :cake: \n",
"Lets kick the CI server and get this rebuilt shall we?\n",
"@Lukasa for the... |
https://api.github.com/repos/psf/requests/issues/1899 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1899/labels{/name} | https://api.github.com/repos/psf/requests/issues/1899/comments | https://api.github.com/repos/psf/requests/issues/1899/events | https://github.com/psf/requests/issues/1899 | 26,765,137 | MDU6SXNzdWUyNjc2NTEzNw== | 1,899 | PEP8 Compliance | {
"avatar_url": "https://avatars.githubusercontent.com/u/1371925?v=4",
"events_url": "https://api.github.com/users/cli248/events{/privacy}",
"followers_url": "https://api.github.com/users/cli248/followers",
"following_url": "https://api.github.com/users/cli248/following{/other_user}",
"gists_url": "https://api.github.com/users/cli248/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cli248",
"id": 1371925,
"login": "cli248",
"node_id": "MDQ6VXNlcjEzNzE5MjU=",
"organizations_url": "https://api.github.com/users/cli248/orgs",
"received_events_url": "https://api.github.com/users/cli248/received_events",
"repos_url": "https://api.github.com/users/cli248/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cli248/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cli248/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cli248",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 12 | 2014-02-02T17:28:56Z | 2021-09-08T23:07:56Z | 2014-10-05T17:24:31Z | NONE | resolved | I checked `PEP8` compliance using following command,
```
pep8 --statistics --ignore=E501 --exclude='requests/packages/*' requests test_requests.py
```
The stats are
- 2 **E125** continuation line does not distinguish itself from next logical line
- 6 **E126** continuation line over-indented for hanging indent
- 30 **E128** continuation line under-indented for visual indent
- 1 **E203** whitespace before ':'
- 2 **E226** missing whitespace around arithmetic operator
- 2 **E23** missing whitespace after ','
- 2 **E241** multiple spaces after ','
- 22 **E251** unexpected spaces around keyword / parameter equals
- 1 **E261** at least two spaces before inline comment
- 3 **E303** too many blank lines (2)
- 1 **W293** blank line contains whitespace
I plan to make `requests` more `PEP8` compliant, and I am wondering which errors should I ignore beside **E501**.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1899/reactions"
} | https://api.github.com/repos/psf/requests/issues/1899/timeline | null | completed | null | null | false | [
"This has been proposed in the past and @kennethreitz vastly dislikes most of pep8 from my experience. I've never been able to tell exactly what style he likes to follow but it's very much his call. Until he can get around to replying to this, I would hold off on your efforts so you do not expend too much energy.\n... |
https://api.github.com/repos/psf/requests/issues/1898 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1898/labels{/name} | https://api.github.com/repos/psf/requests/issues/1898/comments | https://api.github.com/repos/psf/requests/issues/1898/events | https://github.com/psf/requests/pull/1898 | 26,763,596 | MDExOlB1bGxSZXF1ZXN0MTIxMTU4NDc= | 1,898 | Made .history type consistent (tuples only) | {
"avatar_url": "https://avatars.githubusercontent.com/u/81353?v=4",
"events_url": "https://api.github.com/users/zopieux/events{/privacy}",
"followers_url": "https://api.github.com/users/zopieux/followers",
"following_url": "https://api.github.com/users/zopieux/following{/other_user}",
"gists_url": "https://api.github.com/users/zopieux/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/zopieux",
"id": 81353,
"login": "zopieux",
"node_id": "MDQ6VXNlcjgxMzUz",
"organizations_url": "https://api.github.com/users/zopieux/orgs",
"received_events_url": "https://api.github.com/users/zopieux/received_events",
"repos_url": "https://api.github.com/users/zopieux/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/zopieux/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/zopieux/subscriptions",
"type": "User",
"url": "https://api.github.com/users/zopieux",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 44501305,
"name": "Not Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTMwNQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Not%20Ready%20To%20Merge"
}
] | closed | true | null | [] | null | 5 | 2014-02-02T16:09:22Z | 2021-09-08T23:06:24Z | 2014-02-11T16:56:32Z | NONE | resolved | An empty history was represented by an empty list whereas a non-empty history was a tuple.
Now the type of .history is always a tuple, so it does not break code such as `req.history + (req,)`.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1898/reactions"
} | https://api.github.com/repos/psf/requests/issues/1898/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1898.diff",
"html_url": "https://github.com/psf/requests/pull/1898",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1898.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1898"
} | true | [
"Six test cases failed. See details on this [page](http://ci.kennethreitz.org/job/requests-pr/PYTHON=3.3/lastBuild/console)\n\n```\n> _r.history.append(r)\nE AttributeError: 'tuple' object has no attribute 'append'\n\nrequests/auth.py:179: AttributeError\n```\n",
"This is not a totally unreaso... |
https://api.github.com/repos/psf/requests/issues/1897 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1897/labels{/name} | https://api.github.com/repos/psf/requests/issues/1897/comments | https://api.github.com/repos/psf/requests/issues/1897/events | https://github.com/psf/requests/pull/1897 | 26,757,766 | MDExOlB1bGxSZXF1ZXN0MTIxMTM3MTk= | 1,897 | Document requirements for SNI support on Python2 | {
"avatar_url": "https://avatars.githubusercontent.com/u/48501?v=4",
"events_url": "https://api.github.com/users/aliles/events{/privacy}",
"followers_url": "https://api.github.com/users/aliles/followers",
"following_url": "https://api.github.com/users/aliles/following{/other_user}",
"gists_url": "https://api.github.com/users/aliles/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/aliles",
"id": 48501,
"login": "aliles",
"node_id": "MDQ6VXNlcjQ4NTAx",
"organizations_url": "https://api.github.com/users/aliles/orgs",
"received_events_url": "https://api.github.com/users/aliles/received_events",
"repos_url": "https://api.github.com/users/aliles/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/aliles/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/aliles/subscriptions",
"type": "User",
"url": "https://api.github.com/users/aliles",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 11 | 2014-02-02T09:18:43Z | 2021-09-08T23:10:55Z | 2014-02-11T16:55:33Z | NONE | resolved | Adds a section to Request's advanced usage guide on what Server Name
Indication is, its purpose, and how to enable it on Python2.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1897/reactions"
} | https://api.github.com/repos/psf/requests/issues/1897/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1897.diff",
"html_url": "https://github.com/psf/requests/pull/1897",
"merged_at": "2014-02-11T16:55:33Z",
"patch_url": "https://github.com/psf/requests/pull/1897.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1897"
} | true | [
"Thanks for this!\n\nHowever, I'm on the fence. So far we've made a conscious decision not to _officially_ document this support in Requests, because we don't adequately test it. We don't have an SNI environment in our CI system, we've regressed this support in the past and we'll probably do it again.\n\nWe should ... |
https://api.github.com/repos/psf/requests/issues/1896 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1896/labels{/name} | https://api.github.com/repos/psf/requests/issues/1896/comments | https://api.github.com/repos/psf/requests/issues/1896/events | https://github.com/psf/requests/pull/1896 | 26,680,468 | MDExOlB1bGxSZXF1ZXN0MTIwNzc0ODA= | 1,896 | Provide a pythonic way to inject your won where() function | {
"avatar_url": "https://avatars.githubusercontent.com/u/1174343?v=4",
"events_url": "https://api.github.com/users/ticosax/events{/privacy}",
"followers_url": "https://api.github.com/users/ticosax/followers",
"following_url": "https://api.github.com/users/ticosax/following{/other_user}",
"gists_url": "https://api.github.com/users/ticosax/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ticosax",
"id": 1174343,
"login": "ticosax",
"node_id": "MDQ6VXNlcjExNzQzNDM=",
"organizations_url": "https://api.github.com/users/ticosax/orgs",
"received_events_url": "https://api.github.com/users/ticosax/received_events",
"repos_url": "https://api.github.com/users/ticosax/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ticosax/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ticosax/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ticosax",
"user_view_type": "public"
} | [
{
"color": "e11d21",
"default": false,
"description": null,
"id": 78002701,
"name": "Do Not Merge",
"node_id": "MDU6TGFiZWw3ODAwMjcwMQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Do%20Not%20Merge"
}
] | closed | true | null | [] | null | 12 | 2014-01-31T13:18:33Z | 2021-09-08T23:01:08Z | 2014-01-31T14:16:47Z | NONE | resolved | If a module called `requests_extension` define a function called
where(); this function will be used instead of requests.certs.where()
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1896/reactions"
} | https://api.github.com/repos/psf/requests/issues/1896/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1896.diff",
"html_url": "https://github.com/psf/requests/pull/1896",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1896.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1896"
} | true | [
"Thanks for this!\n\nI'm -0.5 on this change, because I believe it to be a security risk. It is upsettingly easy to create a situation where such a module is installed that defines a `where()` function that returns arbitrary certificates, and such behaviour would not be noticed. Monkeypatching makes this behaviour ... |
https://api.github.com/repos/psf/requests/issues/1895 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1895/labels{/name} | https://api.github.com/repos/psf/requests/issues/1895/comments | https://api.github.com/repos/psf/requests/issues/1895/events | https://github.com/psf/requests/issues/1895 | 26,645,863 | MDU6SXNzdWUyNjY0NTg2Mw== | 1,895 | PreparedRequest.prepare_body should not add a Transfer-Encoding header when manually supplied with a Content-Length | {
"avatar_url": "https://avatars.githubusercontent.com/u/92943?v=4",
"events_url": "https://api.github.com/users/gholms/events{/privacy}",
"followers_url": "https://api.github.com/users/gholms/followers",
"following_url": "https://api.github.com/users/gholms/following{/other_user}",
"gists_url": "https://api.github.com/users/gholms/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/gholms",
"id": 92943,
"login": "gholms",
"node_id": "MDQ6VXNlcjkyOTQz",
"organizations_url": "https://api.github.com/users/gholms/orgs",
"received_events_url": "https://api.github.com/users/gholms/received_events",
"repos_url": "https://api.github.com/users/gholms/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/gholms/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/gholms/subscriptions",
"type": "User",
"url": "https://api.github.com/users/gholms",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-01-30T23:58:13Z | 2021-09-09T00:10:05Z | 2014-02-17T14:39:25Z | NONE | resolved | I need to use a PUT request to upload sys.stdin to Amazon S3, but since S3 does not support chunked transfer encoding I have to supply a `Content-Length` header myself. Doing so seemed to successfully prevent HTTPAdapter.send from trying to do chunking, but S3 rejected the request anyway because PreparedRequest.prepare_body noticed that the body was iterable and set a `Transfer-Encoding` header on its own. A user-supplied `Content-Length` should prevent the latter from happening as well.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1895/reactions"
} | https://api.github.com/repos/psf/requests/issues/1895/timeline | null | completed | null | null | false | [
"Thanks for raising this!\n\nThere's an open issue that contains a substantial discussion on this point, #1648. The short of it, however, is that we almost never expect people to provide their own Content-Length header.\n\nI have a question though: how are you able to set Content-Length when reading from sys.stdin?... |
https://api.github.com/repos/psf/requests/issues/1894 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1894/labels{/name} | https://api.github.com/repos/psf/requests/issues/1894/comments | https://api.github.com/repos/psf/requests/issues/1894/events | https://github.com/psf/requests/pull/1894 | 26,597,677 | MDExOlB1bGxSZXF1ZXN0MTIwMzQ4MTk= | 1,894 | Make 'raise_for_status' return the response object | {
"avatar_url": "https://avatars.githubusercontent.com/u/28710?v=4",
"events_url": "https://api.github.com/users/vmalloc/events{/privacy}",
"followers_url": "https://api.github.com/users/vmalloc/followers",
"following_url": "https://api.github.com/users/vmalloc/following{/other_user}",
"gists_url": "https://api.github.com/users/vmalloc/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/vmalloc",
"id": 28710,
"login": "vmalloc",
"node_id": "MDQ6VXNlcjI4NzEw",
"organizations_url": "https://api.github.com/users/vmalloc/orgs",
"received_events_url": "https://api.github.com/users/vmalloc/received_events",
"repos_url": "https://api.github.com/users/vmalloc/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/vmalloc/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/vmalloc/subscriptions",
"type": "User",
"url": "https://api.github.com/users/vmalloc",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2014-01-30T13:26:25Z | 2017-02-10T13:31:28Z | 2014-01-30T17:25:23Z | NONE | null | This would make simple usages simpler:
``` python
result = requests.get("http://api.server.com/path").raise_for_status().json()
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1894/reactions"
} | https://api.github.com/repos/psf/requests/issues/1894/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1894.diff",
"html_url": "https://github.com/psf/requests/pull/1894",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1894.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1894"
} | true | [
"Thanks for this @vmalloc! I do not think we'll accept it at this time though. I'm on my phone at the moment but I'll be happy to give a more detailed explanation in a short while.\n",
"Ok, is it because it's incomplete or because this behaviour isn't desirable? \n",
"This is a pretty drastic API change, and we... |
https://api.github.com/repos/psf/requests/issues/1893 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1893/labels{/name} | https://api.github.com/repos/psf/requests/issues/1893/comments | https://api.github.com/repos/psf/requests/issues/1893/events | https://github.com/psf/requests/pull/1893 | 26,545,712 | MDExOlB1bGxSZXF1ZXN0MTIwMDU2OTA= | 1,893 | Avoid breaking crappy distribution methods. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "207de5",
"default": false,
"description": null,
"id": 60620163,
"name": "Minion Seal of Approval",
"node_id": "MDU6TGFiZWw2MDYyMDE2Mw==",
"url": "https://api.github.com/repos/psf/requests/labels/Minion%20Seal%20of%20Approval"
}
] | closed | true | null | [] | null | 4 | 2014-01-29T19:23:36Z | 2021-09-08T23:11:10Z | 2014-01-30T17:23:57Z | MEMBER | resolved | Apparently RPM doesn't like us having the full license text in the 'license' section, as in #1878. Seems innocuous to change this, because realistically who the hell cares?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1893/reactions"
} | https://api.github.com/repos/psf/requests/issues/1893/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1893.diff",
"html_url": "https://github.com/psf/requests/pull/1893",
"merged_at": "2014-01-30T17:23:57Z",
"patch_url": "https://github.com/psf/requests/pull/1893.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1893"
} | true | [
"LGTM :+1: \n",
"Before, this was important because it was a lovely feature of crate.io. \n\nLong live crate.io.\n",
"One day, crate.io will return as pypi.python.org. Unless @dstufft explodes in a ball of caremad.\n",
"Oh, but he _is_ a ball of caremad! That's his secret power.\n"
] |
https://api.github.com/repos/psf/requests/issues/1892 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1892/labels{/name} | https://api.github.com/repos/psf/requests/issues/1892/comments | https://api.github.com/repos/psf/requests/issues/1892/events | https://github.com/psf/requests/pull/1892 | 26,545,045 | MDExOlB1bGxSZXF1ZXN0MTIwMDUyODQ= | 1,892 | Repopulate ~/.netrc auth. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "207de5",
"default": false,
"description": null,
"id": 60620163,
"name": "Minion Seal of Approval",
"node_id": "MDU6TGFiZWw2MDYyMDE2Mw==",
"url": "https://api.github.com/repos/psf/requests/labels/Minion%20Seal%20of%20Approval"
}
] | closed | true | null | [] | null | 21 | 2014-01-29T19:15:37Z | 2021-09-08T23:07:28Z | 2014-01-31T17:19:53Z | MEMBER | resolved | This should be a fix for #1885.
@sigmavirus24, can you give me some code review? =)
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1892/reactions"
} | https://api.github.com/repos/psf/requests/issues/1892/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1892.diff",
"html_url": "https://github.com/psf/requests/pull/1892",
"merged_at": "2014-01-31T17:19:53Z",
"patch_url": "https://github.com/psf/requests/pull/1892.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1892"
} | true | [
"One comment otherwise LGTM.\n\nYou don't need to write a test for this, but I have an idea that I'd like to test it with.\n",
"Done and done.\n",
":shipit: \n",
"I need to think about this. \n",
"@kennethreitz we absolutely cannot continue reusing authorizations on redirects to sites that are not the same ... |
https://api.github.com/repos/psf/requests/issues/1891 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1891/labels{/name} | https://api.github.com/repos/psf/requests/issues/1891/comments | https://api.github.com/repos/psf/requests/issues/1891/events | https://github.com/psf/requests/pull/1891 | 26,493,847 | MDExOlB1bGxSZXF1ZXN0MTE5NzU5NTc= | 1,891 | Add request to RequestException | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "207de5",
"default": false,
"description": null,
"id": 60620163,
"name": "Minion Seal of Approval",
"node_id": "MDU6TGFiZWw2MDYyMDE2Mw==",
"url": "https://api.github.com/repos/psf/requests/labels/Minion%20Seal%20of%20Approval"
}
] | closed | true | null | [] | null | 7 | 2014-01-29T02:16:48Z | 2021-09-08T23:06:23Z | 2014-02-11T16:58:23Z | CONTRIBUTOR | resolved | Pass request objects in `HTTPAdapter`.
Fixes #1890
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1891/reactions"
} | https://api.github.com/repos/psf/requests/issues/1891/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1891.diff",
"html_url": "https://github.com/psf/requests/pull/1891",
"merged_at": "2014-02-11T16:58:23Z",
"patch_url": "https://github.com/psf/requests/pull/1891.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1891"
} | true | [
"LGTM, I'm happy with this. :cake:\n",
"Uh, maybe.\n",
"@kennethreitz I have no strong opinion on this either way frankly. #1890 seemed like a reasonable feature request though. The decision is all yours.\n",
"In the context of grequests, I think this will be nice. Let's just not make a habit of this :)\n",
... |
https://api.github.com/repos/psf/requests/issues/1890 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1890/labels{/name} | https://api.github.com/repos/psf/requests/issues/1890/comments | https://api.github.com/repos/psf/requests/issues/1890/events | https://github.com/psf/requests/issues/1890 | 26,490,372 | MDU6SXNzdWUyNjQ5MDM3Mg== | 1,890 | include Request object as attribute on RequestExceptions | {
"avatar_url": "https://avatars.githubusercontent.com/u/83819?v=4",
"events_url": "https://api.github.com/users/keturn/events{/privacy}",
"followers_url": "https://api.github.com/users/keturn/followers",
"following_url": "https://api.github.com/users/keturn/following{/other_user}",
"gists_url": "https://api.github.com/users/keturn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/keturn",
"id": 83819,
"login": "keturn",
"node_id": "MDQ6VXNlcjgzODE5",
"organizations_url": "https://api.github.com/users/keturn/orgs",
"received_events_url": "https://api.github.com/users/keturn/received_events",
"repos_url": "https://api.github.com/users/keturn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/keturn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/keturn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/keturn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-01-29T00:53:11Z | 2021-09-09T00:10:08Z | 2014-02-11T16:58:23Z | NONE | resolved | It'd be handy if you could check RequestException.request to find out about the request that caused the error.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1890/reactions"
} | https://api.github.com/repos/psf/requests/issues/1890/timeline | null | completed | null | null | false | [
"Isn't the response included? That should have the request on it already.\n",
"Whoops. That's only for `HTTPError`s. The issue is that you do not necessarily always have a request object that can be passed in. I'm working on a PR to add the attribute when possible. (Same for response objects.)\n"
] |
https://api.github.com/repos/psf/requests/issues/1889 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1889/labels{/name} | https://api.github.com/repos/psf/requests/issues/1889/comments | https://api.github.com/repos/psf/requests/issues/1889/events | https://github.com/psf/requests/issues/1889 | 26,480,608 | MDU6SXNzdWUyNjQ4MDYwOA== | 1,889 | logging KeyError: '<key>' | {
"avatar_url": "https://avatars.githubusercontent.com/u/4558966?v=4",
"events_url": "https://api.github.com/users/dkavraal/events{/privacy}",
"followers_url": "https://api.github.com/users/dkavraal/followers",
"following_url": "https://api.github.com/users/dkavraal/following{/other_user}",
"gists_url": "https://api.github.com/users/dkavraal/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dkavraal",
"id": 4558966,
"login": "dkavraal",
"node_id": "MDQ6VXNlcjQ1NTg5NjY=",
"organizations_url": "https://api.github.com/users/dkavraal/orgs",
"received_events_url": "https://api.github.com/users/dkavraal/received_events",
"repos_url": "https://api.github.com/users/dkavraal/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dkavraal/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dkavraal/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dkavraal",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 5 | 2014-01-28T22:04:04Z | 2021-09-08T12:01:00Z | 2014-01-28T22:06:12Z | NONE | resolved | If the main logger of the application has "extra" fields on, the error loggings inside urllib3 makes the error "KeyError" to occur. Here is a sample snippet to try:
``` python
import requests
import logging
logger = logging.getLogger()
logStdOut = logging.StreamHandler()
LOGFORMATCNSL=logging.Formatter("%(asctime)s %(message)s %(aVar)s %(bVar)s")
logStdOut.setFormatter(LOGFORMATCNSL)
logStdOut.setLevel(logging.DEBUG)
logger.setLevel(logging.NOTSET)
logger.addHandler(logStdOut)
def tryThis():
logger.error("deneme", extra={"aVar": "aVal", "bVar": "bVal"})
conn = requests.get("http://www.google.com")
conn.close()
tryThis()
```
And I get this result:
```
2014-01-28 23:54:16,270 deneme aVal bVal
Traceback (most recent call last):
File "/usr/lib/python3.3/logging/__init__.py", line 937, in emit
msg = self.format(record)
File "/usr/lib/python3.3/logging/__init__.py", line 808, in format
return fmt.format(record)
File "/usr/lib/python3.3/logging/__init__.py", line 549, in format
s = self.formatMessage(record)
File "/usr/lib/python3.3/logging/__init__.py", line 518, in formatMessage
return self._style.format(record)
File "/usr/lib/python3.3/logging/__init__.py", line 364, in format
return self._fmt % record.__dict__
KeyError: 'aVar'
Logged from file connectionpool.py, line 172
Traceback (most recent call last):
File "/usr/lib/python3.3/logging/__init__.py", line 937, in emit
msg = self.format(record)
File "/usr/lib/python3.3/logging/__init__.py", line 808, in format
return fmt.format(record)
File "/usr/lib/python3.3/logging/__init__.py", line 549, in format
s = self.formatMessage(record)
File "/usr/lib/python3.3/logging/__init__.py", line 518, in formatMessage
return self._style.format(record)
File "/usr/lib/python3.3/logging/__init__.py", line 364, in format
return self._fmt % record.__dict__
KeyError: 'aVar'
Logged from file connectionpool.py, line 345
Traceback (most recent call last):
File "/usr/lib/python3.3/logging/__init__.py", line 937, in emit
msg = self.format(record)
File "/usr/lib/python3.3/logging/__init__.py", line 808, in format
return fmt.format(record)
File "/usr/lib/python3.3/logging/__init__.py", line 549, in format
s = self.formatMessage(record)
File "/usr/lib/python3.3/logging/__init__.py", line 518, in formatMessage
return self._style.format(record)
File "/usr/lib/python3.3/logging/__init__.py", line 364, in format
return self._fmt % record.__dict__
KeyError: 'aVar'
Logged from file connectionpool.py, line 172
Traceback (most recent call last):
File "/usr/lib/python3.3/logging/__init__.py", line 937, in emit
msg = self.format(record)
File "/usr/lib/python3.3/logging/__init__.py", line 808, in format
return fmt.format(record)
File "/usr/lib/python3.3/logging/__init__.py", line 549, in format
s = self.formatMessage(record)
File "/usr/lib/python3.3/logging/__init__.py", line 518, in formatMessage
return self._style.format(record)
File "/usr/lib/python3.3/logging/__init__.py", line 364, in format
return self._fmt % record.__dict__
KeyError: 'aVar'
Logged from file connectionpool.py, line 345
[Finished in 1.6s]
```
However, if we change the formatting line of the test snippet into this, there is no exception like the above:
```
LOGFORMATCNSL=logging.Formatter("%(asctime)s %(message)s")
```
So, does the NullHandler() for the libraries logging make this, or there is sth else going on. Because, a library must not try to log anything into my application logging, without extra effort of mine I guess.
Here is my system info:
```
# uname -a
Linux myhostname 3.8.0-35-generic #50-Ubuntu SMP Tue Dec 3 01:24:59 UTC 2013 x86_64 x86_64 x86_64 GNU/Linux
# lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=13.04
DISTRIB_CODENAME=raring
DISTRIB_DESCRIPTION="Ubuntu 13.04"
# python
Python 3.3.1 (default, Sep 25 2013, 19:29:01)
[GCC 4.7.3] on linux
# pip3 list
-lxc (0.1)
apturl (0.5.2ubuntu1)
Brlapi (0.5.7)
cchardet (0.3.5)
chardet (2.2.1)
command-not-found (0.3)
defer (1.0.6)
dirspec (4.2.0)
distribute (0.6.34)
friends (0.1)
httplib2 (0.7.7)
jusText (2.0.0)
language-selector (0.1)
louis (2.4.1)
lxml (3.1.0)
nose (1.3.0)
oauthlib (0.3.7)
onboard (0.99.0-alpha1-tr1190)
oneconf (0.3.3)
piston-mini-client (0.7.5)
pycrypto (2.6)
pygobject (3.8.2)
pymongo (2.6.3)
python-apt (0.8.8ubuntu6)
python-debian (0.1.21-nmu2ubuntu1)
pyxdg (0.25)
requests (2.2.1)
six (1.2.0)
software-center-aptd-plugins (0.0.0)
thin-client-config-agent (0.7)
ubuntu-drivers-common (0.0.0)
ufw (0.33-0ubuntu3)
unattended-upgrades (0.1)
unity-scope-gdrive (0.7)
usb-creator (0.2.23)
virtkey (0.63.0)
Werkzeug (0.9.4)
xdiagnose (3.5.1)
xkit (0.0.0)
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1889/reactions"
} | https://api.github.com/repos/psf/requests/issues/1889/timeline | null | completed | null | null | false | [
"Hi there! Thanks for raising this!\n\nWe bring urllib3 in to Requests wholesale without changes, so can I ask you to open this issue over there? That will lead to a fix for Requests _and_ a fix for urllib3. =)\n",
"BTW,\n\n``` python\nlogger.setLevel(logging.ERROR)\n```\n\nmakes that exceptions disappear, I know... |
https://api.github.com/repos/psf/requests/issues/1888 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1888/labels{/name} | https://api.github.com/repos/psf/requests/issues/1888/comments | https://api.github.com/repos/psf/requests/issues/1888/events | https://github.com/psf/requests/pull/1888 | 26,459,018 | MDExOlB1bGxSZXF1ZXN0MTE5NTU1MDY= | 1,888 | Fix for 301 redirect and latest PyOpenSSL. | {
"avatar_url": "https://avatars.githubusercontent.com/u/456007?v=4",
"events_url": "https://api.github.com/users/kouk/events{/privacy}",
"followers_url": "https://api.github.com/users/kouk/followers",
"following_url": "https://api.github.com/users/kouk/following{/other_user}",
"gists_url": "https://api.github.com/users/kouk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kouk",
"id": 456007,
"login": "kouk",
"node_id": "MDQ6VXNlcjQ1NjAwNw==",
"organizations_url": "https://api.github.com/users/kouk/orgs",
"received_events_url": "https://api.github.com/users/kouk/received_events",
"repos_url": "https://api.github.com/users/kouk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kouk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kouk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kouk",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-01-28T17:18:12Z | 2021-09-08T23:10:57Z | 2014-01-28T20:14:38Z | CONTRIBUTOR | resolved | Fixes #1887
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1888/reactions"
} | https://api.github.com/repos/psf/requests/issues/1888/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1888.diff",
"html_url": "https://github.com/psf/requests/pull/1888",
"merged_at": "2014-01-28T20:14:38Z",
"patch_url": "https://github.com/psf/requests/pull/1888.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1888"
} | true | [
"This seems like a reasonable fix to me. Unfortunately, the unit test is not a particularly good one because most people don't use the SNI build of Requests in their development systems. Additionally, we don't do it in our CI server (though we probably should, I'll bring it up with @kennethreitz). Leave it there fo... |
https://api.github.com/repos/psf/requests/issues/1887 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1887/labels{/name} | https://api.github.com/repos/psf/requests/issues/1887/comments | https://api.github.com/repos/psf/requests/issues/1887/events | https://github.com/psf/requests/issues/1887 | 26,458,175 | MDU6SXNzdWUyNjQ1ODE3NQ== | 1,887 | 301 redirect broken with latest pyopenssl/SNI | {
"avatar_url": "https://avatars.githubusercontent.com/u/456007?v=4",
"events_url": "https://api.github.com/users/kouk/events{/privacy}",
"followers_url": "https://api.github.com/users/kouk/followers",
"following_url": "https://api.github.com/users/kouk/following{/other_user}",
"gists_url": "https://api.github.com/users/kouk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kouk",
"id": 456007,
"login": "kouk",
"node_id": "MDQ6VXNlcjQ1NjAwNw==",
"organizations_url": "https://api.github.com/users/kouk/orgs",
"received_events_url": "https://api.github.com/users/kouk/received_events",
"repos_url": "https://api.github.com/users/kouk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kouk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kouk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kouk",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 0 | 2014-01-28T17:07:07Z | 2021-09-08T23:10:39Z | 2014-01-28T20:14:38Z | CONTRIBUTOR | resolved | With the latest pyopenssl on Windows 64bit:
```
cryptography==0.2.dev1
ndg-httpsclient==0.3.2
pyOpenSSL==0.13
pyasn1==0.1.7
```
I get an exception raised when `GET`ing a `301` response to a HTTPS request. I see that after the redirect is received the returned URL is [decoded to a Unicode string](https://github.com/kennethreitz/requests/blob/master/requests/adapters.py#L181). Then requests passes the response to `resolve_redirects` which uses the url to make a new request. This leads to a Unicode string being passed to urllib3 and eventually pyopenssl. And because in pyopenssl they now check that the data is of type bytes, an exception is thrown.
I Wrote this test:
```
def test_pyopenssl_redirect(self):
requests.get('https://httpbin.org/status/301')
```
and this is the result of py.test:
```
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self = <OpenSSL.SSL.Connection object at 0x000000000345CC50>
buf = u'GET /redirect/1 HTTP/1.1\r\nHost: httpbin.org\r\nAccept-Encoding: gzip, defl...cept: */*\r\nUser-Agent: python-r
equests/2.2.1 CPython/2.7.6 Windows/8\r\n\r\n'
flags = 0
def sendall(self, buf, flags=0):
"""
Send "all" data on the connection. This calls send() repeatedly until
all data is sent. If an error occurs, it's impossible to tell how much
data has been sent.
:param buf: The string to send
:param flags: (optional) Included for compatibility with the socket
API, the value is ignored
:return: The number of bytes written
"""
if isinstance(buf, _memoryview):
buf = buf.tobytes()
if not isinstance(buf, bytes):
> raise TypeError("buf must be a byte string")
E TypeError: buf must be a byte string
..\testreq\lib\site-packages\OpenSSL\SSL.py:968: TypeError
=================================== 117 tests deselected by '-kpyopenssl_redirect' ====================================
====================================== 1 failed, 117 deselected in 4.47 seconds =======================================
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1887/reactions"
} | https://api.github.com/repos/psf/requests/issues/1887/timeline | null | completed | null | null | false | [] |
https://api.github.com/repos/psf/requests/issues/1886 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1886/labels{/name} | https://api.github.com/repos/psf/requests/issues/1886/comments | https://api.github.com/repos/psf/requests/issues/1886/events | https://github.com/psf/requests/pull/1886 | 26,424,623 | MDExOlB1bGxSZXF1ZXN0MTE5Mzc3NjM= | 1,886 | Added info about posted files headers | {
"avatar_url": "https://avatars.githubusercontent.com/u/975689?v=4",
"events_url": "https://api.github.com/users/meteozond/events{/privacy}",
"followers_url": "https://api.github.com/users/meteozond/followers",
"following_url": "https://api.github.com/users/meteozond/following{/other_user}",
"gists_url": "https://api.github.com/users/meteozond/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/meteozond",
"id": 975689,
"login": "meteozond",
"node_id": "MDQ6VXNlcjk3NTY4OQ==",
"organizations_url": "https://api.github.com/users/meteozond/orgs",
"received_events_url": "https://api.github.com/users/meteozond/received_events",
"repos_url": "https://api.github.com/users/meteozond/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/meteozond/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/meteozond/subscriptions",
"type": "User",
"url": "https://api.github.com/users/meteozond",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-01-28T09:04:11Z | 2021-09-08T23:08:14Z | 2014-01-28T09:07:24Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1886/reactions"
} | https://api.github.com/repos/psf/requests/issues/1886/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1886.diff",
"html_url": "https://github.com/psf/requests/pull/1886",
"merged_at": "2014-01-28T09:07:24Z",
"patch_url": "https://github.com/psf/requests/pull/1886.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1886"
} | true | [
"LGTM, thanks for this! :cake:\n"
] | |
https://api.github.com/repos/psf/requests/issues/1885 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1885/labels{/name} | https://api.github.com/repos/psf/requests/issues/1885/comments | https://api.github.com/repos/psf/requests/issues/1885/events | https://github.com/psf/requests/issues/1885 | 26,373,742 | MDU6SXNzdWUyNjM3Mzc0Mg== | 1,885 | Redirect can expose netrc password | {
"avatar_url": "https://avatars.githubusercontent.com/u/212279?v=4",
"events_url": "https://api.github.com/users/eriol/events{/privacy}",
"followers_url": "https://api.github.com/users/eriol/followers",
"following_url": "https://api.github.com/users/eriol/following{/other_user}",
"gists_url": "https://api.github.com/users/eriol/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/eriol",
"id": 212279,
"login": "eriol",
"node_id": "MDQ6VXNlcjIxMjI3OQ==",
"organizations_url": "https://api.github.com/users/eriol/orgs",
"received_events_url": "https://api.github.com/users/eriol/received_events",
"repos_url": "https://api.github.com/users/eriol/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/eriol/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eriol/subscriptions",
"type": "User",
"url": "https://api.github.com/users/eriol",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 20 | 2014-01-27T17:10:13Z | 2021-09-08T23:08:08Z | 2014-09-12T20:03:14Z | CONTRIBUTOR | resolved | Hello,
Jakub Wilk reported this on the Debian Bug Tracker[¹]:
```
If site A redirects to site B, and user had a password for site A in
their ~/.netrc, then requests would send authorization information both
to site A and to site B.
```
Jakub wrote also some tests to show the issue, you can find them attached on the Debian Bug Tracker.
I have already updated requests Debian package (it's ready for the upload) and I can confirm that the issue is present also in requests 2.2.1.
Cheers!
[¹] http://bugs.debian.org/733108
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1885/reactions"
} | https://api.github.com/repos/psf/requests/issues/1885/timeline | null | completed | null | null | false | [
"Thanks for this!\n\nRight now we don't strip authentication information of any kind on redirects. We could, but we can't ask the user for new credentials, we can only really go to `~/. Thoughts @sigmavirus24?\n",
"[We delete any Cookies set.](https://github.com/kennethreitz/requests/blob/master/requests/sessions... |
https://api.github.com/repos/psf/requests/issues/1884 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1884/labels{/name} | https://api.github.com/repos/psf/requests/issues/1884/comments | https://api.github.com/repos/psf/requests/issues/1884/events | https://github.com/psf/requests/pull/1884 | 26,341,350 | MDExOlB1bGxSZXF1ZXN0MTE4OTQ4Njc= | 1,884 | Add initial Jython support | {
"avatar_url": "https://avatars.githubusercontent.com/u/737634?v=4",
"events_url": "https://api.github.com/users/darjus-amzn/events{/privacy}",
"followers_url": "https://api.github.com/users/darjus-amzn/followers",
"following_url": "https://api.github.com/users/darjus-amzn/following{/other_user}",
"gists_url": "https://api.github.com/users/darjus-amzn/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/darjus-amzn",
"id": 737634,
"login": "darjus-amzn",
"node_id": "MDQ6VXNlcjczNzYzNA==",
"organizations_url": "https://api.github.com/users/darjus-amzn/orgs",
"received_events_url": "https://api.github.com/users/darjus-amzn/received_events",
"repos_url": "https://api.github.com/users/darjus-amzn/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/darjus-amzn/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/darjus-amzn/subscriptions",
"type": "User",
"url": "https://api.github.com/users/darjus-amzn",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 17 | 2014-01-27T09:52:43Z | 2021-09-08T10:01:24Z | 2014-01-27T17:38:53Z | CONTRIBUTOR | resolved | Currently only works for http as ssl module is not yet fully functional.
Ran the tests, with some (expectedly) failing on ssl support
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1884/reactions"
} | https://api.github.com/repos/psf/requests/issues/1884/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1884.diff",
"html_url": "https://github.com/psf/requests/pull/1884",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1884.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1884"
} | true | [
"Thanks for this! Jython is weird. =)\n\nI think before we merge this we should set up our CI server with a Jython build. If we're going to support Jython, let's do it properly. @kennethreitz do you want to do that yourself, or would you rather one of @sigmavirus24 or I did it?\n",
"@kennethreitz controls the Jen... |
https://api.github.com/repos/psf/requests/issues/1883 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1883/labels{/name} | https://api.github.com/repos/psf/requests/issues/1883/comments | https://api.github.com/repos/psf/requests/issues/1883/events | https://github.com/psf/requests/pull/1883 | 26,319,895 | MDExOlB1bGxSZXF1ZXN0MTE4ODQ3Mjk= | 1,883 | Update PyOpenSSL contrib DEFAULT_SSL_CIPHER_LIST | {
"avatar_url": "https://avatars.githubusercontent.com/u/161495?v=4",
"events_url": "https://api.github.com/users/reaperhulk/events{/privacy}",
"followers_url": "https://api.github.com/users/reaperhulk/followers",
"following_url": "https://api.github.com/users/reaperhulk/following{/other_user}",
"gists_url": "https://api.github.com/users/reaperhulk/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/reaperhulk",
"id": 161495,
"login": "reaperhulk",
"node_id": "MDQ6VXNlcjE2MTQ5NQ==",
"organizations_url": "https://api.github.com/users/reaperhulk/orgs",
"received_events_url": "https://api.github.com/users/reaperhulk/received_events",
"repos_url": "https://api.github.com/users/reaperhulk/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/reaperhulk/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/reaperhulk/subscriptions",
"type": "User",
"url": "https://api.github.com/users/reaperhulk",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-01-26T19:01:39Z | 2021-09-08T22:01:11Z | 2014-01-26T19:03:16Z | NONE | resolved | The default cipher suites set in the pyopenssl contrib are now slightly out of date. SSLLabs has updated their recommendations and now suggests not using RC4 (see: [Is BEAST still a threat?](http://blog.ivanristic.com/2013/09/is-beast-still-a-threat.html).
This particular suite has been lifted from the [current master of twisted](https://github.com/twisted/twisted/blob/trunk/twisted/internet/_sslverify.py#L995), but provides a whitelist that prefers forward secrecy for key exchange, AES-GCM for encryption (with fallbacks for CBC and 3DES if AES is unavailable), and disables null auth, etc. This was derived by @hynek, so if there questions about it we can drag him in to answer.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1883/reactions"
} | https://api.github.com/repos/psf/requests/issues/1883/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1883.diff",
"html_url": "https://github.com/psf/requests/pull/1883",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1883.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1883"
} | true | [
"Thanks for this! This is an excellent addition, but you're providing it in the wrong place. We vendor that file straight in from urllib3. Can I get you to open this Pull Request over there?\n",
"Whoops :) Will do.\n",
"Thanks so much! :cake:\n"
] |
https://api.github.com/repos/psf/requests/issues/1882 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1882/labels{/name} | https://api.github.com/repos/psf/requests/issues/1882/comments | https://api.github.com/repos/psf/requests/issues/1882/events | https://github.com/psf/requests/issues/1882 | 26,299,355 | MDU6SXNzdWUyNjI5OTM1NQ== | 1,882 | ResourceWarning in python 3.2+ | {
"avatar_url": "https://avatars.githubusercontent.com/u/48100?v=4",
"events_url": "https://api.github.com/users/bboe/events{/privacy}",
"followers_url": "https://api.github.com/users/bboe/followers",
"following_url": "https://api.github.com/users/bboe/following{/other_user}",
"gists_url": "https://api.github.com/users/bboe/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/bboe",
"id": 48100,
"login": "bboe",
"node_id": "MDQ6VXNlcjQ4MTAw",
"organizations_url": "https://api.github.com/users/bboe/orgs",
"received_events_url": "https://api.github.com/users/bboe/received_events",
"repos_url": "https://api.github.com/users/bboe/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/bboe/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/bboe/subscriptions",
"type": "User",
"url": "https://api.github.com/users/bboe",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 15 | 2014-01-25T19:31:08Z | 2021-09-08T04:00:41Z | 2014-11-12T17:34:14Z | CONTRIBUTOR | resolved | Requests issues a ResourceWarning in python 3.2+ as sockets are not explicitly closed before garbage collection occurs. While ResourceWarnings are not displayed by default, it can be a distraction to some developers when working with warnings enabled.
File: test.py
``` python
import requests
def make_request():
resp = requests.get('http://google.com')
resp.close() # this appears to have no effect, even though the function exists
make_request()
```
```
$ python -Wall test.py
test.py:7: ResourceWarning: unclosed <socket.socket object, fd=4, family=2, type=1, proto=6>
make_request()
test.py:7: ResourceWarning: unclosed <socket.socket object, fd=3, family=2, type=1, proto=6>
make_request()
```
It would be great if there was a way to prevent the ResourceWarning from occurring, without issuing a `Connection:close` header.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/1882/reactions"
} | https://api.github.com/repos/psf/requests/issues/1882/timeline | null | completed | null | null | false | [
"Thanks for this!\n\nThis is actually a behaviour in urllib3. I'm going to summon @shazow into this conversation, but I believe this is a deliberate design decision. We can often reuse the socket object to reconnect to the same host without the overhead of recreating the object. This makes this deliberate. I wonder... |
https://api.github.com/repos/psf/requests/issues/1881 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1881/labels{/name} | https://api.github.com/repos/psf/requests/issues/1881/comments | https://api.github.com/repos/psf/requests/issues/1881/events | https://github.com/psf/requests/pull/1881 | 26,289,205 | MDExOlB1bGxSZXF1ZXN0MTE4NzI0MTc= | 1,881 | s/soley/solely | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-01-25T08:21:26Z | 2021-09-08T11:00:50Z | 2014-01-25T13:38:39Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1881/reactions"
} | https://api.github.com/repos/psf/requests/issues/1881/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1881.diff",
"html_url": "https://github.com/psf/requests/pull/1881",
"merged_at": "2014-01-25T13:38:39Z",
"patch_url": "https://github.com/psf/requests/pull/1881.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1881"
} | true | [
":cake: Thank you!\n"
] | |
https://api.github.com/repos/psf/requests/issues/1880 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1880/labels{/name} | https://api.github.com/repos/psf/requests/issues/1880/comments | https://api.github.com/repos/psf/requests/issues/1880/events | https://github.com/psf/requests/issues/1880 | 26,288,980 | MDU6SXNzdWUyNjI4ODk4MA== | 1,880 | Document how to test Requests without going over the wire | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [
{
"color": "fad8c7",
"default": false,
"description": null,
"id": 136616769,
"name": "Documentation",
"node_id": "MDU6TGFiZWwxMzY2MTY3Njk=",
"url": "https://api.github.com/repos/psf/requests/labels/Documentation"
}
] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}... | null | 9 | 2014-01-25T08:03:00Z | 2023-03-31T00:02:59Z | 2022-03-30T17:57:01Z | CONTRIBUTOR | resolved | If I am writing unit tests that exercise HTTP requests, it may be useful to mock or stub the external service call, so that the unit tests don't go over the network and introduce latency or fail on a train or a plane.
It would be useful if Requests provided best practice documentation for:
- how to intercept the request before it goes over the wire, and return a custom response
- how to determine what Requests was actually ready to send over the wire (potentially by mocking urllib3.connectionpool.HTTP(S)Connection.urlopen?)
Betamax may be appropriate here but it would also be good to explain how to do this without introducing dependencies.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/5271761?v=4",
"events_url": "https://api.github.com/users/nateprewitt/events{/privacy}",
"followers_url": "https://api.github.com/users/nateprewitt/followers",
"following_url": "https://api.github.com/users/nateprewitt/following{/other_user}",
"gists_url": "https://api.github.com/users/nateprewitt/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/nateprewitt",
"id": 5271761,
"login": "nateprewitt",
"node_id": "MDQ6VXNlcjUyNzE3NjE=",
"organizations_url": "https://api.github.com/users/nateprewitt/orgs",
"received_events_url": "https://api.github.com/users/nateprewitt/received_events",
"repos_url": "https://api.github.com/users/nateprewitt/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/nateprewitt/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/nateprewitt/subscriptions",
"type": "User",
"url": "https://api.github.com/users/nateprewitt",
"user_view_type": "public"
} | {
"+1": 1,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 1,
"url": "https://api.github.com/repos/psf/requests/issues/1880/reactions"
} | https://api.github.com/repos/psf/requests/issues/1880/timeline | null | completed | null | null | false | [
"Unless you're on 3.3+ mock is an external dependency so your last sentence is quite wrong. Frankly, if you're performing any parsing of the response and the service is subject to change, e.g. the GitHub API, then mocking is error prone and an awful idea. That aside I still use mocking but not to stub out responses... |
https://api.github.com/repos/psf/requests/issues/1879 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1879/labels{/name} | https://api.github.com/repos/psf/requests/issues/1879/comments | https://api.github.com/repos/psf/requests/issues/1879/events | https://github.com/psf/requests/issues/1879 | 26,274,964 | MDU6SXNzdWUyNjI3NDk2NA== | 1,879 | params no longer work for non-http URLs | {
"avatar_url": "https://avatars.githubusercontent.com/u/1754002?v=4",
"events_url": "https://api.github.com/users/ibuildthecloud/events{/privacy}",
"followers_url": "https://api.github.com/users/ibuildthecloud/followers",
"following_url": "https://api.github.com/users/ibuildthecloud/following{/other_user}",
"gists_url": "https://api.github.com/users/ibuildthecloud/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ibuildthecloud",
"id": 1754002,
"login": "ibuildthecloud",
"node_id": "MDQ6VXNlcjE3NTQwMDI=",
"organizations_url": "https://api.github.com/users/ibuildthecloud/orgs",
"received_events_url": "https://api.github.com/users/ibuildthecloud/received_events",
"repos_url": "https://api.github.com/users/ibuildthecloud/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ibuildthecloud/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ibuildthecloud/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ibuildthecloud",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 26 | 2014-01-24T22:09:40Z | 2021-09-09T00:10:15Z | 2014-01-27T00:05:23Z | NONE | resolved | Commit b149be5d specifically removed all processing of non-HTTP(s) URLs. Previous to this commit if you were to pass in params, it would be appended to the URL. Since this commit it no longer works. Specifically I ran into this issue when running docker-py against a unix socket.
I understand that for non standard URLs you don't want to parse them. It seems that if the params were passed, then you should still append them. I'll gladly put in a pull request for this if it seems like a valid issue. A simple fix would be the below
``` python
# Don't do any URL preparation for oddball schemes
if ':' in url and not url.lower().startswith('http'):
encoded_params = self._encode_params(params)
if len(encoded_params) > 0:
if url.find('?') == -1:
url = '%s?%s' % (url, encoded_params)
else:
url = '%s&%s' % (url, encoded_params)
self.url = url
return
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1879/reactions"
} | https://api.github.com/repos/psf/requests/issues/1879/timeline | null | completed | null | null | false | [
"Hmmm.\n\nHmmm.\n\nI'm very much on the fence here. On the one hand, I can see your argument, and it makes plenty of sense. There's definitely utility in being able to pass 'params' to requests and have it do the right thing.\n\nUnfortunately, it violates the distinction we drew when we accepted that change. The na... |
https://api.github.com/repos/psf/requests/issues/1878 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1878/labels{/name} | https://api.github.com/repos/psf/requests/issues/1878/comments | https://api.github.com/repos/psf/requests/issues/1878/events | https://github.com/psf/requests/issues/1878 | 26,238,927 | MDU6SXNzdWUyNjIzODkyNw== | 1,878 | Used method of including license breaks distutils bdist | {
"avatar_url": "https://avatars.githubusercontent.com/u/2114993?v=4",
"events_url": "https://api.github.com/users/verwilst/events{/privacy}",
"followers_url": "https://api.github.com/users/verwilst/followers",
"following_url": "https://api.github.com/users/verwilst/following{/other_user}",
"gists_url": "https://api.github.com/users/verwilst/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/verwilst",
"id": 2114993,
"login": "verwilst",
"node_id": "MDQ6VXNlcjIxMTQ5OTM=",
"organizations_url": "https://api.github.com/users/verwilst/orgs",
"received_events_url": "https://api.github.com/users/verwilst/received_events",
"repos_url": "https://api.github.com/users/verwilst/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/verwilst/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/verwilst/subscriptions",
"type": "User",
"url": "https://api.github.com/users/verwilst",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-01-24T12:56:31Z | 2021-09-09T00:10:10Z | 2014-02-03T11:03:09Z | NONE | resolved | Hi,
Because the LICENSE file is included in its total form in setup.py, "python setup.py bdist --format=rpm" for example bails out with the following errors:
copying dist/requests-2.2.1.tar.gz -> build/bdist.linux-x86_64/rpm/SOURCES
building RPMs
error: line 14: Unknown tag: Licensed under the Apache License, Version 2.0 (the "License");
error: query of specfile build/bdist.linux-x86_64/rpm/SPECS/requests.spec failed, can't parse
error: Failed to execute: "rpm -q --qf '%{name}-%{version}-%{release}.src.rpm %{arch}/%{name}-%{version}-%{release}.%{arch}.rpm\n' --specfile 'build/bdist.linux-x86_64/rpm/SPECS/requests.spec'"
The fix is to 'hardcode' the license to a small string, and not the whole text.
Fix for same problem in other project:
https://github.com/nedap/pypuppetdb/commit/4ae1338f39a220bc96f8c5ee33bc3100428bebda
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1878/reactions"
} | https://api.github.com/repos/psf/requests/issues/1878/timeline | null | completed | null | null | false | [
"Thanks for this! We'll fix it up. =)\n",
"Resolved by #1893.\n"
] |
https://api.github.com/repos/psf/requests/issues/1877 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1877/labels{/name} | https://api.github.com/repos/psf/requests/issues/1877/comments | https://api.github.com/repos/psf/requests/issues/1877/events | https://github.com/psf/requests/issues/1877 | 26,208,046 | MDU6SXNzdWUyNjIwODA0Ng== | 1,877 | Add a .multipart() method to Response for auto-decoding multipart/* responses | {
"avatar_url": "https://avatars.githubusercontent.com/u/55704?v=4",
"events_url": "https://api.github.com/users/mythguided/events{/privacy}",
"followers_url": "https://api.github.com/users/mythguided/followers",
"following_url": "https://api.github.com/users/mythguided/following{/other_user}",
"gists_url": "https://api.github.com/users/mythguided/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/mythguided",
"id": 55704,
"login": "mythguided",
"node_id": "MDQ6VXNlcjU1NzA0",
"organizations_url": "https://api.github.com/users/mythguided/orgs",
"received_events_url": "https://api.github.com/users/mythguided/received_events",
"repos_url": "https://api.github.com/users/mythguided/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/mythguided/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/mythguided/subscriptions",
"type": "User",
"url": "https://api.github.com/users/mythguided",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-01-23T23:30:44Z | 2021-09-09T00:10:16Z | 2014-01-24T06:52:54Z | NONE | resolved | It would be useful if `Response` objects provided a `.multipart()` method analogous to the `.json()` method for dealing with responses whose `Content-Type` is `multipart/*`, such as is common for geospatial web services.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1877/reactions"
} | https://api.github.com/repos/psf/requests/issues/1877/timeline | null | completed | null | null | false | [
"Considering you're the first person in over 2 years to request this, it seems as though this is not something that is popular enough to belong in the core of requests. A feature like this would need to be requested a whole lot more for us to even consider adding this method.\n\nOn the other hand though, you could ... |
https://api.github.com/repos/psf/requests/issues/1876 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1876/labels{/name} | https://api.github.com/repos/psf/requests/issues/1876/comments | https://api.github.com/repos/psf/requests/issues/1876/events | https://github.com/psf/requests/pull/1876 | 26,115,734 | MDExOlB1bGxSZXF1ZXN0MTE3NzE1Mjk= | 1,876 | Update urllib3 to 9346c5c | {
"avatar_url": "https://avatars.githubusercontent.com/u/145979?v=4",
"events_url": "https://api.github.com/users/dstufft/events{/privacy}",
"followers_url": "https://api.github.com/users/dstufft/followers",
"following_url": "https://api.github.com/users/dstufft/following{/other_user}",
"gists_url": "https://api.github.com/users/dstufft/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dstufft",
"id": 145979,
"login": "dstufft",
"node_id": "MDQ6VXNlcjE0NTk3OQ==",
"organizations_url": "https://api.github.com/users/dstufft/orgs",
"received_events_url": "https://api.github.com/users/dstufft/received_events",
"repos_url": "https://api.github.com/users/dstufft/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dstufft/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dstufft/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dstufft",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 2 | 2014-01-22T19:28:54Z | 2021-09-08T23:08:28Z | 2014-01-23T18:22:21Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1876/reactions"
} | https://api.github.com/repos/psf/requests/issues/1876/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1876.diff",
"html_url": "https://github.com/psf/requests/pull/1876",
"merged_at": "2014-01-23T18:22:21Z",
"patch_url": "https://github.com/psf/requests/pull/1876.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1876"
} | true | [
"Awesome, let's do this.\n",
"@kennethreitz :cake: :+1: :shipit: \n"
] | |
https://api.github.com/repos/psf/requests/issues/1875 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1875/labels{/name} | https://api.github.com/repos/psf/requests/issues/1875/comments | https://api.github.com/repos/psf/requests/issues/1875/events | https://github.com/psf/requests/issues/1875 | 26,092,793 | MDU6SXNzdWUyNjA5Mjc5Mw== | 1,875 | Provide 2.2.1 release. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 7 | 2014-01-22T14:23:52Z | 2021-09-08T23:10:48Z | 2014-01-23T18:22:35Z | MEMBER | resolved | Needed for `pip`, because they need [this](https://github.com/shazow/urllib3/pull/318) to fix [this](https://github.com/pypa/pip/issues/1488).
Mandatory:
- [x] Bring in a version of urllib3 that contains the above fix ~~(revision not yet known)~~. This is as simple as merging #1876
- [x] Update changelog using [this](https://github.com/kennethreitz/requests/compare/v2.2.0...master). (done in 2a6b835a5e08c7365b8a4d3bfea4dcd98ad2d205).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1875/reactions"
} | https://api.github.com/repos/psf/requests/issues/1875/timeline | null | completed | null | null | false | [
":heart: our release manager @Lukasa \n",
"Awesome, thanks. Y'all are awesome.\n",
"https://github.com/kennethreitz/requests/pull/1876 verified that it fixes the pip issue as well.\n",
"Edited the issue to make it clear that the first TODO could be accomplished by merging #1876.\n",
"Unofficial official \n"... |
https://api.github.com/repos/psf/requests/issues/1874 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1874/labels{/name} | https://api.github.com/repos/psf/requests/issues/1874/comments | https://api.github.com/repos/psf/requests/issues/1874/events | https://github.com/psf/requests/pull/1874 | 26,021,269 | MDExOlB1bGxSZXF1ZXN0MTE3MjQ0ODA= | 1,874 | Typo in History | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-01-21T18:18:22Z | 2021-09-08T22:01:10Z | 2014-01-21T18:24:37Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1874/reactions"
} | https://api.github.com/repos/psf/requests/issues/1874/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1874.diff",
"html_url": "https://github.com/psf/requests/pull/1874",
"merged_at": "2014-01-21T18:24:37Z",
"patch_url": "https://github.com/psf/requests/pull/1874.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1874"
} | true | [
"Wait, credentions isn't a word?\n\nThanks! :cake:\n"
] | |
https://api.github.com/repos/psf/requests/issues/1873 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1873/labels{/name} | https://api.github.com/repos/psf/requests/issues/1873/comments | https://api.github.com/repos/psf/requests/issues/1873/events | https://github.com/psf/requests/pull/1873 | 26,020,979 | MDExOlB1bGxSZXF1ZXN0MTE3MjQzMTY= | 1,873 | Disable TCP_NODELAY for requests to non-proxies | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 4 | 2014-01-21T18:14:14Z | 2021-09-08T22:01:10Z | 2014-01-22T19:31:01Z | CONTRIBUTOR | resolved | Adds a short discussion of the change to HISTORY.rst
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1873/reactions"
} | https://api.github.com/repos/psf/requests/issues/1873/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1873.diff",
"html_url": "https://github.com/psf/requests/pull/1873",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1873.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1873"
} | true | [
"I have no objection to bringing this in. =) LGTM. :+1:\n",
"This is actually going to be superseded by #1876, and we don't really need the substantial header comment, so I'm closing this.\n\nThanks for your work on urllib3 though! :cake:\n",
"I suppose, though anyone doing a tcpdump or ngrep on a requests requ... |
https://api.github.com/repos/psf/requests/issues/1872 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1872/labels{/name} | https://api.github.com/repos/psf/requests/issues/1872/comments | https://api.github.com/repos/psf/requests/issues/1872/events | https://github.com/psf/requests/pull/1872 | 25,959,662 | MDExOlB1bGxSZXF1ZXN0MTE2OTc0NTg= | 1,872 | Manage urllib3 and chardet with git submodule | {
"avatar_url": "https://avatars.githubusercontent.com/u/1488134?v=4",
"events_url": "https://api.github.com/users/douglarek/events{/privacy}",
"followers_url": "https://api.github.com/users/douglarek/followers",
"following_url": "https://api.github.com/users/douglarek/following{/other_user}",
"gists_url": "https://api.github.com/users/douglarek/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/douglarek",
"id": 1488134,
"login": "douglarek",
"node_id": "MDQ6VXNlcjE0ODgxMzQ=",
"organizations_url": "https://api.github.com/users/douglarek/orgs",
"received_events_url": "https://api.github.com/users/douglarek/received_events",
"repos_url": "https://api.github.com/users/douglarek/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/douglarek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/douglarek/subscriptions",
"type": "User",
"url": "https://api.github.com/users/douglarek",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-01-21T01:54:24Z | 2021-09-08T22:01:10Z | 2014-01-21T02:33:18Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1488134?v=4",
"events_url": "https://api.github.com/users/douglarek/events{/privacy}",
"followers_url": "https://api.github.com/users/douglarek/followers",
"following_url": "https://api.github.com/users/douglarek/following{/other_user}",
"gists_url": "https://api.github.com/users/douglarek/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/douglarek",
"id": 1488134,
"login": "douglarek",
"node_id": "MDQ6VXNlcjE0ODgxMzQ=",
"organizations_url": "https://api.github.com/users/douglarek/orgs",
"received_events_url": "https://api.github.com/users/douglarek/received_events",
"repos_url": "https://api.github.com/users/douglarek/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/douglarek/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/douglarek/subscriptions",
"type": "User",
"url": "https://api.github.com/users/douglarek",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1872/reactions"
} | https://api.github.com/repos/psf/requests/issues/1872/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1872.diff",
"html_url": "https://github.com/psf/requests/pull/1872",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1872.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1872"
} | true | [
"Ok, ignore it; git can not checkout directory\n",
"Thanks for trying at least. For what it is worth, we probably would not have accepted the change but we appreciate your effort! :cake: \n"
] | |
https://api.github.com/repos/psf/requests/issues/1871 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1871/labels{/name} | https://api.github.com/repos/psf/requests/issues/1871/comments | https://api.github.com/repos/psf/requests/issues/1871/events | https://github.com/psf/requests/issues/1871 | 25,912,107 | MDU6SXNzdWUyNTkxMjEwNw== | 1,871 | Our use of urllib3's ConnectionPools is not threadsafe. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "e10c02",
"default": false,
"description": null,
"id": 117744,
"name": "Bug",
"node_id": "MDU6TGFiZWwxMTc3NDQ=",
"url": "https://api.github.com/repos/psf/requests/labels/Bug"
},
{
"color": "e102d8",
"default": false,
"description": null,
"id": 117745,
"... | closed | true | null | [] | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 27 | 2014-01-20T11:09:18Z | 2021-08-30T00:06:12Z | 2018-02-24T14:55:18Z | MEMBER | resolved | We use a `PoolManager` to provide us with connection pools from urllib3. However, we don't actually run our requests through it: instead we get a suitable `ConnectionPool` and then use `urlopen` on that instead.
This _can_ lead to bugs when using threads and hitting a large number of hosts from one `Session` object. Each host creates a new `ConnectionPool` in the `PoolManager`: if too many are created, the least recently used one is evicted.
If that eviction happens in between us getting hold of the `ConnectionPool` and us actually trying to send a request, we can try to send on a closed connection pool. That's pretty lame. You can see the discussion on IRC that led to this issue [here](https://botbot.me/freenode/python-requests/msg/9980059/).
We can either try to make that section thread safe, or try to reconnect when we hit closed pool errors. Thoughts?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 2,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/psf/requests/issues/1871/reactions"
} | https://api.github.com/repos/psf/requests/issues/1871/timeline | null | completed | null | null | false | [
"Note that we may not want to do anything.\n\nMy general advice has always been \"one session per thread\". If that advice remains true we don't have to do anything.\n",
"Another option is to use a `threading.local` internally for some critical state, that way you effectively, automaticaly and trivially have one ... |
https://api.github.com/repos/psf/requests/issues/1870 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1870/labels{/name} | https://api.github.com/repos/psf/requests/issues/1870/comments | https://api.github.com/repos/psf/requests/issues/1870/events | https://github.com/psf/requests/pull/1870 | 25,874,498 | MDExOlB1bGxSZXF1ZXN0MTE2NTM5NzE= | 1,870 | Add a small note about requests-toolbelt | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-01-19T04:48:47Z | 2021-09-09T00:01:14Z | 2014-01-23T18:54:08Z | CONTRIBUTOR | resolved | We can add more info to discuss the inclusion of @lukasa's `SSLAdapter`. Are there any objections to adding this information to requests' documentation?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1870/reactions"
} | https://api.github.com/repos/psf/requests/issues/1870/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1870.diff",
"html_url": "https://github.com/psf/requests/pull/1870",
"merged_at": "2014-01-23T18:54:08Z",
"patch_url": "https://github.com/psf/requests/pull/1870.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1870"
} | true | [
"None from me.\n",
":cake:\n",
"We may want to have a better \"community projects\" showcase in the future, but this looks great for now. \n"
] |
https://api.github.com/repos/psf/requests/issues/1869 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1869/labels{/name} | https://api.github.com/repos/psf/requests/issues/1869/comments | https://api.github.com/repos/psf/requests/issues/1869/events | https://github.com/psf/requests/issues/1869 | 25,819,295 | MDU6SXNzdWUyNTgxOTI5NQ== | 1,869 | Why don't we send `strict` to urllib3? | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "fbca04",
"default": false,
"description": null,
"id": 44501249,
"name": "Needs BDFL Input",
"node_id": "MDU6TGFiZWw0NDUwMTI0OQ==",
"url": "https://api.github.com/repos/psf/requests/labels/Needs%20BDFL%20Input"
},
{
"color": "eb6420",
"default": false,
"descrip... | closed | true | null | [] | {
"closed_at": null,
"closed_issues": 29,
"created_at": "2013-11-17T11:29:34Z",
"creator": {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
},
"description": null,
"due_on": null,
"html_url": "https://github.com/psf/requests/milestone/20",
"id": 487518,
"labels_url": "https://api.github.com/repos/psf/requests/milestones/20/labels",
"node_id": "MDk6TWlsZXN0b25lNDg3NTE4",
"number": 20,
"open_issues": 12,
"state": "open",
"title": "3.0.0",
"updated_at": "2024-05-19T18:43:00Z",
"url": "https://api.github.com/repos/psf/requests/milestones/20"
} | 12 | 2014-01-17T16:37:25Z | 2021-09-08T23:06:10Z | 2015-01-18T20:36:17Z | MEMBER | resolved | I was trawling the Python core bugtracker when I spotted [this](http://bugs.python.org/issue17849) beauty. It looks like it should be impossible to hit this if `strict` is set to `True`, but we don't pass that parameter to `urllib3`. Is there a good design reason we don't do this? If there isn't, are we open to a PR that does set that argument?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1869/reactions"
} | https://api.github.com/repos/psf/requests/issues/1869/timeline | null | completed | null | null | false | [
"If it doesn't cause issues, I don't see why not.\n",
"`strict` was deprecated in Python3. With that the `LineAndFileWrapper` was removed because HTTP/1.x is assumed. The fact that the `LineAndFileWrapper` is created means that the proxy must be returning some malformed status line or is using HTTP/0.9. Or at lea... |
https://api.github.com/repos/psf/requests/issues/1868 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1868/labels{/name} | https://api.github.com/repos/psf/requests/issues/1868/comments | https://api.github.com/repos/psf/requests/issues/1868/events | https://github.com/psf/requests/issues/1868 | 25,768,601 | MDU6SXNzdWUyNTc2ODYwMQ== | 1,868 | Cookie Not Set on 303 | {
"avatar_url": "https://avatars.githubusercontent.com/u/1467590?v=4",
"events_url": "https://api.github.com/users/creese/events{/privacy}",
"followers_url": "https://api.github.com/users/creese/followers",
"following_url": "https://api.github.com/users/creese/following{/other_user}",
"gists_url": "https://api.github.com/users/creese/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/creese",
"id": 1467590,
"login": "creese",
"node_id": "MDQ6VXNlcjE0Njc1OTA=",
"organizations_url": "https://api.github.com/users/creese/orgs",
"received_events_url": "https://api.github.com/users/creese/received_events",
"repos_url": "https://api.github.com/users/creese/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/creese/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/creese/subscriptions",
"type": "User",
"url": "https://api.github.com/users/creese",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-01-16T21:54:24Z | 2021-09-09T00:10:16Z | 2014-01-18T22:31:26Z | NONE | resolved | I'm making a request to a server that sets an httponly cookie and returns a 303. When I look in `response.headers`, I see the cookie. When I look in `session.cookies`, I don't see the cookie. Why isn't the cookie getting set?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1467590?v=4",
"events_url": "https://api.github.com/users/creese/events{/privacy}",
"followers_url": "https://api.github.com/users/creese/followers",
"following_url": "https://api.github.com/users/creese/following{/other_user}",
"gists_url": "https://api.github.com/users/creese/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/creese",
"id": 1467590,
"login": "creese",
"node_id": "MDQ6VXNlcjE0Njc1OTA=",
"organizations_url": "https://api.github.com/users/creese/orgs",
"received_events_url": "https://api.github.com/users/creese/received_events",
"repos_url": "https://api.github.com/users/creese/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/creese/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/creese/subscriptions",
"type": "User",
"url": "https://api.github.com/users/creese",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1868/reactions"
} | https://api.github.com/repos/psf/requests/issues/1868/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nCan you be a bit more specific? There are a number of things that could affect this behaviour. We need to know what version of Requests you're using and whether you're setting `allow_redirects` to False. If you aren't, can you also provide the output of `for h in r.history: print(... |
https://api.github.com/repos/psf/requests/issues/1867 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1867/labels{/name} | https://api.github.com/repos/psf/requests/issues/1867/comments | https://api.github.com/repos/psf/requests/issues/1867/events | https://github.com/psf/requests/pull/1867 | 25,710,070 | MDExOlB1bGxSZXF1ZXN0MTE1NjkzODk= | 1,867 | Document contextlib.closing. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-01-16T08:39:35Z | 2021-09-09T00:01:24Z | 2014-01-16T22:16:05Z | MEMBER | resolved | From #1493. Provides a way to use the `Response` object as a context manager without adding the conceptual overhead to the `Response` class.
I'm still on the fence about whether we should document this or just make `Response`s context managers, but this seems the least controversial option so lets do this first.
Review: @sigmavirus24, @pepijndevos.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1867/reactions"
} | https://api.github.com/repos/psf/requests/issues/1867/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1867.diff",
"html_url": "https://github.com/psf/requests/pull/1867",
"merged_at": "2014-01-16T22:16:05Z",
"patch_url": "https://github.com/psf/requests/pull/1867.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1867"
} | true | [
"I dig it. \n"
] |
https://api.github.com/repos/psf/requests/issues/1866 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1866/labels{/name} | https://api.github.com/repos/psf/requests/issues/1866/comments | https://api.github.com/repos/psf/requests/issues/1866/events | https://github.com/psf/requests/issues/1866 | 25,662,134 | MDU6SXNzdWUyNTY2MjEzNA== | 1,866 | Digest auth for proxy | {
"avatar_url": "https://avatars.githubusercontent.com/u/38861?v=4",
"events_url": "https://api.github.com/users/oinopion/events{/privacy}",
"followers_url": "https://api.github.com/users/oinopion/followers",
"following_url": "https://api.github.com/users/oinopion/following{/other_user}",
"gists_url": "https://api.github.com/users/oinopion/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/oinopion",
"id": 38861,
"login": "oinopion",
"node_id": "MDQ6VXNlcjM4ODYx",
"organizations_url": "https://api.github.com/users/oinopion/orgs",
"received_events_url": "https://api.github.com/users/oinopion/received_events",
"repos_url": "https://api.github.com/users/oinopion/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/oinopion/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/oinopion/subscriptions",
"type": "User",
"url": "https://api.github.com/users/oinopion",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-01-15T16:57:55Z | 2021-09-09T00:10:14Z | 2014-01-29T19:24:15Z | NONE | resolved | It would be nice to have digest auth support for proxies.
I've hit same problem as described in this SO post:
http://stackoverflow.com/questions/13506455/how-to-pass-proxy-authentication-requires-digest-auth-by-using-python-requests
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1866/reactions"
} | https://api.github.com/repos/psf/requests/issues/1866/timeline | null | completed | null | null | false | [
"Hi @oinopion, thanks for raising this issue!\n\nIt's an understandable thing to want. However, putting this in Requests by default is a trade-off: each additional authentication option added to Requests is an additional bit of code and maintenance cost. It also adds confusion to the API.\n\nFor this reason, Reques... |
https://api.github.com/repos/psf/requests/issues/1865 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1865/labels{/name} | https://api.github.com/repos/psf/requests/issues/1865/comments | https://api.github.com/repos/psf/requests/issues/1865/events | https://github.com/psf/requests/issues/1865 | 25,648,329 | MDU6SXNzdWUyNTY0ODMyOQ== | 1,865 | Support Certificate Revocation Lists where possible | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "e102d8",
"default": false,
"description": null... | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url... | null | 14 | 2014-01-15T13:51:50Z | 2021-09-09T00:10:16Z | 2014-01-23T18:57:09Z | MEMBER | resolved | In 3.4 the standard library's previously woeful `ssl` module is being vastly improved, and one of the nice things it is getting is [support for Certificate Revocation Lists](http://docs.python.org/3.4/library/ssl.html#ssl.SSLContext.load_verify_locations). I'd like us to investigate supporting CRLs in versions of Python where they are available. If we can do this, it'll continue the ongoing trend of Requests being the single most secure way to do HTTP in Python.
It's highly probable that this will need to be a two-pronged approach: urllib3 will probably want to support some genericised CRL options, with Requests pasting over the genericness with a built-in "correct" behaviour. For that reason, I want to start a discussion with the relevant people to work out how we can do this.
Requests people: @kennethreitz, @sigmavirus24
urllib3 people: @shazow
Our SSL guy: @t-8ch.
People who might be interested in either helping or providing insight and code review (to make sure we don't get this wrong) are @tiran (heavily involved with the standard library's `ssl` module) and @alex (currently on a big crypto kick). If either of you two are actually not interested that's totally fine. =)
Initial views: how should we split this work up, and how safe can Requests' defaults be?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1865/reactions"
} | https://api.github.com/repos/psf/requests/issues/1865/timeline | null | completed | null | null | false | [
"Also, which version(s) of python are we targetting? Just 3.4? Perhaps the better question to ask is: \"Which version(s) of Python can we reasonably target?\" Is 2.6 an option?\n",
"With the standard library we're limited to 3.4.\n",
"With the caveat that I know nothing of how the CRLs have been (or should be) ... |
https://api.github.com/repos/psf/requests/issues/1864 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1864/labels{/name} | https://api.github.com/repos/psf/requests/issues/1864/comments | https://api.github.com/repos/psf/requests/issues/1864/events | https://github.com/psf/requests/issues/1864 | 25,624,842 | MDU6SXNzdWUyNTYyNDg0Mg== | 1,864 | HTTPDigestAuth Does not send Authorization headers | {
"avatar_url": "https://avatars.githubusercontent.com/u/6405968?v=4",
"events_url": "https://api.github.com/users/luflores/events{/privacy}",
"followers_url": "https://api.github.com/users/luflores/followers",
"following_url": "https://api.github.com/users/luflores/following{/other_user}",
"gists_url": "https://api.github.com/users/luflores/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/luflores",
"id": 6405968,
"login": "luflores",
"node_id": "MDQ6VXNlcjY0MDU5Njg=",
"organizations_url": "https://api.github.com/users/luflores/orgs",
"received_events_url": "https://api.github.com/users/luflores/received_events",
"repos_url": "https://api.github.com/users/luflores/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/luflores/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/luflores/subscriptions",
"type": "User",
"url": "https://api.github.com/users/luflores",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2014-01-15T03:54:34Z | 2021-09-09T00:28:13Z | 2014-01-15T14:30:47Z | NONE | resolved | Hi I am working on a simple program to get a token-id from a router using REST API. The problem that I am facing, is that I do not see the Authorization headers when I use HTTPDigestAuth. When I use the Google App POSTMAN, I can see the headers and it work. What I am missing in my code?
My code:
```
import requests
from requests.auth import HTTPBasicAuth, HTTPDigestAuth
user = 'pod1u1'
passwd = 'pass'
url = 'https://10.0.236.188/api/v1/auth/token-services'
auth = HTTPDigestAuth(user, passwd)
r = requests.post(url, auth=auth, verify=False)
print 'Request headers:', r.request.headers
print 'Status Code: ', r.status_code
print 'response Headers: ', r.headers
print '######################################'
auth = HTTPBasicAuth(user, passwd)
r = requests.post(url, auth=auth, verify=False)
print 'Request headers:', r.request.headers
print 'Status Code: ', r.status_code
print 'response Headers: ', r.headers
```
Shell commands w/ output:
My script --
```
$python digest.py
Request headers: CaseInsensitiveDict({'Content-Length': '0', 'Accept-Encoding': 'gzip, deflate, compress', 'Accept': '*/*', 'User-Agent': 'python-requests/2.2.0 CPython/2.7.5 Darwin/13.0.0'})
Status Code: 401
response Headers: CaseInsensitiveDict({'date': 'Tue, 14 Jan 2014 00:28:27 GMT', 'content-length': '83', 'content-type': 'application/json', 'connection': 'keep-alive', 'server': 'nginx/1.4.2'})
######################################
Request headers: CaseInsensitiveDict({'Accept': '*/*', 'Content-Length': '0', 'Accept- Encoding': 'gzip, deflate, compress', 'Authorization': u'Basic cG9kMXUxOkMxc2NvTDF2Mw==', 'User-Agent': 'python-requests/2.2.0 CPython/2.7.5 Darwin/13.0.0'})
Status Code: 401
response Headers: CaseInsensitiveDict({'date': 'Tue, 14 Jan 2014 00:28:27 GMT', 'content-length': '448', 'content-type': 'text/html', 'connection': 'keep-alive', 'server': 'nginx/1.4.2'})
POSTMAN
POST /api/v1/auth/token-services HTTP/1.1
Host: 10.0.236.188
Authorization: Digest username="pod1u1", realm="pod1u1@ecatsrtpdmz.cisco.com", nonce="", uri="/api/v1/auth/token-services", response="08ac88b7f5e0533986e9fc974f132258", opaque=""
Cache-Control: no-cache
{
"kind": "object#auth-token",
"expiry-time": "Tue Jan 14 00:09:27 2014",
"token-id": "Vj7mYUMTrsuljaiXEPoNJNiXLzf8UeDsRnEgh3DvQcU=",
"link": "https://10.0.236.188/api/v1/auth/token-services/9552418862"
}
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1864/reactions"
} | https://api.github.com/repos/psf/requests/issues/1864/timeline | null | completed | null | null | false | [
"Since we can't examine the service you're running, can you provide similar logging information like so:\n\n``` python\nimport requests\nfrom requests.auth import HTTPDigestAuth\n\nuser = 'pod1u1'\npasswd = 'pass'\n\ndef log_info(response):\n print 'Request headers: ', r.request.headers\n print 'Status Code: ... |
https://api.github.com/repos/psf/requests/issues/1863 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1863/labels{/name} | https://api.github.com/repos/psf/requests/issues/1863/comments | https://api.github.com/repos/psf/requests/issues/1863/events | https://github.com/psf/requests/issues/1863 | 25,527,437 | MDU6SXNzdWUyNTUyNzQzNw== | 1,863 | Error catch/reraise loses some info about the stack | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2014-01-13T20:55:35Z | 2021-09-09T00:28:14Z | 2014-01-14T05:31:01Z | CONTRIBUTOR | resolved | On my mac,
``` python
import requests
r = requests.get("https://www.howsmyssl.com/a/check")
```
generates this stack trace:
``` python
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "requests/sessions.py", line 383, in request
resp = self.send(prep, **send_kwargs)
File "requests/sessions.py", line 486, in send
r = adapter.send(request, **kwargs)
File "requests/adapters.py", line 389, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 1] _ssl.c:507: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version
```
which seems to skip a few lines that raised the exception in urllib3. Perhaps we could use `six.reraise()` here for python2/python3 compatibility?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1863/reactions"
} | https://api.github.com/repos/psf/requests/issues/1863/timeline | null | completed | null | null | false | [
"Thanks for raising this @kevinburke!\n\nThat area is very carefully designed. We aren't reraising exceptions, we're wrapping them. This means we don't want the urllib3 exception to be raised, we want to raise the `requests.exceptions.SSLError`. In principle we could attach the traceback from the previous exception... |
https://api.github.com/repos/psf/requests/issues/1862 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1862/labels{/name} | https://api.github.com/repos/psf/requests/issues/1862/comments | https://api.github.com/repos/psf/requests/issues/1862/events | https://github.com/psf/requests/pull/1862 | 25,494,344 | MDExOlB1bGxSZXF1ZXN0MTE0NDk1MDM= | 1,862 | Fixed parsing of username and password encoded in the URI | {
"avatar_url": "https://avatars.githubusercontent.com/u/1894878?v=4",
"events_url": "https://api.github.com/users/sybeck2k/events{/privacy}",
"followers_url": "https://api.github.com/users/sybeck2k/followers",
"following_url": "https://api.github.com/users/sybeck2k/following{/other_user}",
"gists_url": "https://api.github.com/users/sybeck2k/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sybeck2k",
"id": 1894878,
"login": "sybeck2k",
"node_id": "MDQ6VXNlcjE4OTQ4Nzg=",
"organizations_url": "https://api.github.com/users/sybeck2k/orgs",
"received_events_url": "https://api.github.com/users/sybeck2k/received_events",
"repos_url": "https://api.github.com/users/sybeck2k/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sybeck2k/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sybeck2k/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sybeck2k",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
}
] | closed | true | null | [] | null | 6 | 2014-01-13T12:39:59Z | 2021-09-08T23:08:28Z | 2014-01-14T19:56:04Z | CONTRIBUTOR | resolved | As per #1856, fixes the parsing of URI encoded usernames and password. Also fixes a bogus test where the username in the URI was not correctly encoded.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1862/reactions"
} | https://api.github.com/repos/psf/requests/issues/1862/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1862.diff",
"html_url": "https://github.com/psf/requests/pull/1862",
"merged_at": "2014-01-14T19:56:04Z",
"patch_url": "https://github.com/psf/requests/pull/1862.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1862"
} | true | [
"Did you not notice #1858 \n",
"This looks fine to me. =)\n",
"thanks @Lukasa sorry I didn't notice your weekend work..!\n",
"@sybeck2k It's really not a problem at all. =) Ego is a dangerous thing in open source so I try to check mine; and besides, you did the very generous thing of merging my changes with y... |
https://api.github.com/repos/psf/requests/issues/1861 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1861/labels{/name} | https://api.github.com/repos/psf/requests/issues/1861/comments | https://api.github.com/repos/psf/requests/issues/1861/events | https://github.com/psf/requests/pull/1861 | 25,474,818 | MDExOlB1bGxSZXF1ZXN0MTE0Mzk0Njc= | 1,861 | Guess content type | {
"avatar_url": "https://avatars.githubusercontent.com/u/290496?v=4",
"events_url": "https://api.github.com/users/lepture/events{/privacy}",
"followers_url": "https://api.github.com/users/lepture/followers",
"following_url": "https://api.github.com/users/lepture/following{/other_user}",
"gists_url": "https://api.github.com/users/lepture/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/lepture",
"id": 290496,
"login": "lepture",
"node_id": "MDQ6VXNlcjI5MDQ5Ng==",
"organizations_url": "https://api.github.com/users/lepture/orgs",
"received_events_url": "https://api.github.com/users/lepture/received_events",
"repos_url": "https://api.github.com/users/lepture/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/lepture/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/lepture/subscriptions",
"type": "User",
"url": "https://api.github.com/users/lepture",
"user_view_type": "public"
} | [
{
"color": "02e10c",
"default": false,
"description": null,
"id": 76800,
"name": "Feature Request",
"node_id": "MDU6TGFiZWw3NjgwMA==",
"url": "https://api.github.com/repos/psf/requests/labels/Feature%20Request"
},
{
"color": "fbca04",
"default": false,
"description": null... | closed | true | null | [] | null | 27 | 2014-01-13T01:59:16Z | 2021-09-08T22:01:09Z | 2014-01-16T12:53:31Z | NONE | resolved | Guess content type for posting files, just like what urllib3 does.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1861/reactions"
} | https://api.github.com/repos/psf/requests/issues/1861/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1861.diff",
"html_url": "https://github.com/psf/requests/pull/1861",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1861.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1861"
} | true | [
"Thanks for this!\n\nIn principle this looks fine. My only worry is that technically this changes what our multipart requests look like on the wire, and I worry about breaking currently functional code. I'm interested to see if @sigmavirus24 is as worried about that as me.\n",
"@Lukasa \n\n> My only worry is that... |
https://api.github.com/repos/psf/requests/issues/1860 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1860/labels{/name} | https://api.github.com/repos/psf/requests/issues/1860/comments | https://api.github.com/repos/psf/requests/issues/1860/events | https://github.com/psf/requests/pull/1860 | 25,469,172 | MDExOlB1bGxSZXF1ZXN0MTE0MzcxMDc= | 1,860 | Use calendar.timegm when calculating cookie expiration | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 12 | 2014-01-12T20:28:11Z | 2021-09-08T05:00:59Z | 2015-12-18T09:18:26Z | CONTRIBUTOR | resolved | Fixes #1859
Credit: @lukasa
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1860/reactions"
} | https://api.github.com/repos/psf/requests/issues/1860/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1860.diff",
"html_url": "https://github.com/psf/requests/pull/1860",
"merged_at": "2015-12-18T09:18:26Z",
"patch_url": "https://github.com/psf/requests/pull/1860.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1860"
} | true | [
"We need to confirm that this will match the actual parsing logic of cookies before we merge this: we don't want to start messing up cookies created in this way.\n",
"That's a good point @Lukasa. I'm guessing @gazpachoking might have a good idea. I'm just too tired to think this hard right now =P\n",
"Me too, I... |
https://api.github.com/repos/psf/requests/issues/1859 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1859/labels{/name} | https://api.github.com/repos/psf/requests/issues/1859/comments | https://api.github.com/repos/psf/requests/issues/1859/events | https://github.com/psf/requests/issues/1859 | 25,459,684 | MDU6SXNzdWUyNTQ1OTY4NA== | 1,859 | Brittle test | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 25 | 2014-01-12T09:52:49Z | 2021-09-08T23:10:55Z | 2014-02-03T13:18:46Z | MEMBER | resolved | The test `test_expires_valid_str` fails on my OS X box, in Python 2.7:
``` python
============================= test session starts ==============================
platform darwin -- Python 2.7.5 -- pytest-2.3.4
plugins: cov
collected 116 items
test_requests.py .................................................................................................................F..
=================================== FAILURES ===================================
_______________ TestMorselToCookieExpires.test_expires_valid_str _______________
self = <test_requests.TestMorselToCookieExpires testMethod=test_expires_valid_str>
def test_expires_valid_str(self):
"""Test case where we convert expires from string time."""
morsel = Morsel()
morsel['expires'] = 'Thu, 01-Jan-1970 00:00:01 GMT'
cookie = morsel_to_cookie(morsel)
> assert cookie.expires == 1
E AssertionError: assert -3599 == 1
E + where -3599 = Cookie(version=0, name=None, value=None, port=None, port_specified=False, domain='', domain_specified=False, domain_in...False, secure=False, expires=-3599, discard=False, comment='', comment_url=False, rest={'HttpOnly': ''}, rfc2109=False).expires
test_requests.py:1111: AssertionError
==================== 1 failed, 115 passed in 23.32 seconds =====================
```
I've not yet got a good theory for this, though I think it's telling that the error is one hour. I don't know _what_ it's telling though, because time is complicated.
Anyway, this test needs to be rewritten to be more accepting of breakage. It's also possible that the intermittent failure of this test represents a problem with the `morsel_to_cookie` function itself, in which case that needs rewriting.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1859/reactions"
} | https://api.github.com/repos/psf/requests/issues/1859/timeline | null | completed | null | null | false | [
"Is that test case fails anytime in your OS X box?\n",
"Currently it fails consistently on my OS X box. I'll try my other systems as well to see if it's OS X-specific or something more general.\n",
"It passes for me on OSX right now, and I'll try my Linux box later. I expect it passes on Jenkins since we've had... |
https://api.github.com/repos/psf/requests/issues/1858 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1858/labels{/name} | https://api.github.com/repos/psf/requests/issues/1858/comments | https://api.github.com/repos/psf/requests/issues/1858/events | https://github.com/psf/requests/pull/1858 | 25,440,856 | MDExOlB1bGxSZXF1ZXN0MTE0MjYyNTk= | 1,858 | Unquote the auth after splitting the url. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2014-01-11T10:00:52Z | 2021-09-08T22:01:09Z | 2014-01-13T13:10:10Z | MEMBER | resolved | This _should_ resolve #1856. /cc @sigmavirus24 @t-8ch.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1858/reactions"
} | https://api.github.com/repos/psf/requests/issues/1858/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1858.diff",
"html_url": "https://github.com/psf/requests/pull/1858",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1858.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1858"
} | true | [
"Just left one note that's a matter of stylistic preference more than anything else. That is not a reason to prevent anyone from merging this though. \n\n:+1: :shipit: :cake: :beer: :smiley_cat: \n",
"#rewrite\n",
"So as part of my research I found this: https://github.com/kennethreitz/requests/blob/ac4e05874a1... |
https://api.github.com/repos/psf/requests/issues/1857 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1857/labels{/name} | https://api.github.com/repos/psf/requests/issues/1857/comments | https://api.github.com/repos/psf/requests/issues/1857/events | https://github.com/psf/requests/issues/1857 | 25,412,094 | MDU6SXNzdWUyNTQxMjA5NA== | 1,857 | Disable SSL compression for security reasons. | {
"avatar_url": "https://avatars.githubusercontent.com/u/717901?v=4",
"events_url": "https://api.github.com/users/t-8ch/events{/privacy}",
"followers_url": "https://api.github.com/users/t-8ch/followers",
"following_url": "https://api.github.com/users/t-8ch/following{/other_user}",
"gists_url": "https://api.github.com/users/t-8ch/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/t-8ch",
"id": 717901,
"login": "t-8ch",
"node_id": "MDQ6VXNlcjcxNzkwMQ==",
"organizations_url": "https://api.github.com/users/t-8ch/orgs",
"received_events_url": "https://api.github.com/users/t-8ch/received_events",
"repos_url": "https://api.github.com/users/t-8ch/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/t-8ch/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/t-8ch/subscriptions",
"type": "User",
"url": "https://api.github.com/users/t-8ch",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | null | [] | null | 15 | 2014-01-10T18:14:42Z | 2021-09-08T23:06:06Z | 2015-01-19T09:22:27Z | CONTRIBUTOR | resolved | After the recent discussion about SSL compression both in shazow/urllib3#109
and kennethreitz/requests#1583 (this issue was about performance reason, it got me to look at other projects, performance is _not_ the reason for this issue) I looked at the behaviour of other popular open source projects. It turned out that the following projects disable the compression by default for [security reasons](https://en.wikipedia.org/wiki/CRIME_(security_exploit\)):
- Nginx, July 2012 ([version 1.2.2](http://nginx.org/en/CHANGES-1.2), [version 1.3.2, the development version to 1.4](http://nginx.org/en/CHANGES-1.4)
- Apache2, ([version 2.2.25](https://httpd.apache.org/docs/2.2/mod/mod_ssl.html#sslcompression), [version 2.4.4](https://httpd.apache.org/docs/2.4/mod/mod_ssl.html#sslcompression))
- The upcoming version 2.7 of the Pound reverse proxy (the `CHANGELOG` file in the source archive: http://www.apsis.ch/pound/Pound-2.7b.tgz)
- [Curl 7.28.1](http://curl.haxx.se/changes.html#7_28_1) July 2012
- CPython >= 3.4 (http://hg.python.org/cpython/rev/98eb88d3d94e)
This are the only projects I have looked at. I am sure we can find more if necessary.
As the stdlib `ssl` module does not allow us to change this parameter before 3.3
I propose to raise the issue on the CPython bug tracker, so that SSL
compression will be disabled by default (with the possibility to manually
enable it on 3.3 and later).
The current handlich of CPython 3.4 and up only disables compression on openssl
1.0 and up, as the relevant constant has not introduced before. However the
nginx changelog claims to also disable compression on earlier versions. I will
look into this.
This issue is meant to gather feedback and momentum before raising the issue with CPython (and maybe also the other implementations)
/cc @lukasa @sigmavirus24 @shazow @alex @jmhodges
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1857/reactions"
} | https://api.github.com/repos/psf/requests/issues/1857/timeline | null | completed | null | null | false | [
"Fwiw, urllib3 _just_ merged a PR which disables this by default in Py32+ and PyOpenSSL, big thanks to @dbrgn for bringing it up and writing the patch. https://github.com/shazow/urllib3/pull/309\n",
"Ah, I linked the wrong urllib3 issue. This should of course have been issue 309.\n",
"I'm 100% in favour of this... |
https://api.github.com/repos/psf/requests/issues/1856 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1856/labels{/name} | https://api.github.com/repos/psf/requests/issues/1856/comments | https://api.github.com/repos/psf/requests/issues/1856/events | https://github.com/psf/requests/issues/1856 | 25,400,819 | MDU6SXNzdWUyNTQwMDgxOQ== | 1,856 | Broken parsing of authenticated URI for Proxy | {
"avatar_url": "https://avatars.githubusercontent.com/u/1894878?v=4",
"events_url": "https://api.github.com/users/sybeck2k/events{/privacy}",
"followers_url": "https://api.github.com/users/sybeck2k/followers",
"following_url": "https://api.github.com/users/sybeck2k/following{/other_user}",
"gists_url": "https://api.github.com/users/sybeck2k/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sybeck2k",
"id": 1894878,
"login": "sybeck2k",
"node_id": "MDQ6VXNlcjE4OTQ4Nzg=",
"organizations_url": "https://api.github.com/users/sybeck2k/orgs",
"received_events_url": "https://api.github.com/users/sybeck2k/received_events",
"repos_url": "https://api.github.com/users/sybeck2k/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sybeck2k/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sybeck2k/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sybeck2k",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 10 | 2014-01-10T15:18:35Z | 2021-09-09T00:10:17Z | 2014-01-16T09:07:50Z | CONTRIBUTOR | resolved | Hello,
when passing a proxy with authentication, and where the password contains the character '#', the parsing of the URI is broken. For instance:
```
proxy = "http://user:%23Cpassword%23C:server:port"
ParseResult(scheme='http', netloc='user:', path='', params='', query='', fragment=password#@server:port0')
```
This is caused by the `url = unquote(url)` done before the parsing in `utils.py`.
I believe the URI should not be unquoted before the parsing, rather the username and password should be quoted after the parsing. What do you think?
Thank you
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1894878?v=4",
"events_url": "https://api.github.com/users/sybeck2k/events{/privacy}",
"followers_url": "https://api.github.com/users/sybeck2k/followers",
"following_url": "https://api.github.com/users/sybeck2k/following{/other_user}",
"gists_url": "https://api.github.com/users/sybeck2k/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sybeck2k",
"id": 1894878,
"login": "sybeck2k",
"node_id": "MDQ6VXNlcjE4OTQ4Nzg=",
"organizations_url": "https://api.github.com/users/sybeck2k/orgs",
"received_events_url": "https://api.github.com/users/sybeck2k/received_events",
"repos_url": "https://api.github.com/users/sybeck2k/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sybeck2k/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sybeck2k/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sybeck2k",
"user_view_type": "public"
} | {
"+1": 3,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 3,
"url": "https://api.github.com/repos/psf/requests/issues/1856/reactions"
} | https://api.github.com/repos/psf/requests/issues/1856/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nIt's hard to see how unquoting before parsing the URL is really helping us. We can almost certainly defer the unquote step until after parsing the URL, applying unquote only to the username and password. @sigmavirus24, can you think of any reason that's not going to be ok?\n",
"... |
https://api.github.com/repos/psf/requests/issues/1855 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1855/labels{/name} | https://api.github.com/repos/psf/requests/issues/1855/comments | https://api.github.com/repos/psf/requests/issues/1855/events | https://github.com/psf/requests/issues/1855 | 25,371,488 | MDU6SXNzdWUyNTM3MTQ4OA== | 1,855 | When Content-Length differs from received message body length, an exception should be raised | {
"avatar_url": "https://avatars.githubusercontent.com/u/577694?v=4",
"events_url": "https://api.github.com/users/patricklaw/events{/privacy}",
"followers_url": "https://api.github.com/users/patricklaw/followers",
"following_url": "https://api.github.com/users/patricklaw/following{/other_user}",
"gists_url": "https://api.github.com/users/patricklaw/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/patricklaw",
"id": 577694,
"login": "patricklaw",
"node_id": "MDQ6VXNlcjU3NzY5NA==",
"organizations_url": "https://api.github.com/users/patricklaw/orgs",
"received_events_url": "https://api.github.com/users/patricklaw/received_events",
"repos_url": "https://api.github.com/users/patricklaw/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/patricklaw/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/patricklaw/subscriptions",
"type": "User",
"url": "https://api.github.com/users/patricklaw",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2014-01-10T02:26:22Z | 2021-09-09T00:10:13Z | 2014-01-29T21:03:30Z | NONE | resolved | The HTTP 1.1 RFC specifies:
"When a Content-Length is given in a message where a message-body is allowed, its field value MUST exactly match the number of OCTETs in the message-body. HTTP/1.1 user agents MUST notify the user when an invalid length is received and detected."
See: http://www.w3.org/Protocols/rfc2616/rfc2616-sec4.html#sec4.4
Here is a simple repro. It seems like the call to `requests.get` should raise an exception rather than silently succeed. Note that python 2.x `urllib2` has identical behavior to `requests` here, but I believe that constitutes a bug in `urllib2`. `curl`, on the other hand, outputs the message body but has a return code of 18 ("Partial file. Only a part of the file was transferred."). In python 3.3 (and presumably earlier releases of python 3.x) `urllib.request` raises `http.client.IncompleteRead: IncompleteRead(5 bytes read, 15 more expected)`, which is in line with the spec.
``` python
import SocketServer as socketserver
import threading
import requests
import time
class MyTCPHandler(socketserver.BaseRequestHandler):
def handle(self):
self.data = self.request.recv(1024)
self.request.sendall('HTTP/1.1 200 OK\r\n'
'Server: truncator/0.0\r\n'
'Content-Length: 20\r\n'
'Connection: close\r\n\r\n'
'12345')
server = None
def background_server():
global server
HOST, PORT = "localhost", 9999
server = socketserver.TCPServer((HOST, PORT), MyTCPHandler)
server.serve_forever()
if __name__ == "__main__":
t = threading.Thread(target=background_server)
t.daemon = True
t.start()
time.sleep(1)
r = requests.get('http://localhost:9999')
print(r.content)
server.shutdown()
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 2,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 2,
"url": "https://api.github.com/repos/psf/requests/issues/1855/reactions"
} | https://api.github.com/repos/psf/requests/issues/1855/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nI have mixed feelings. Firstly, I'd argue that Requests is not technically a user-agent, it's a library. This frees us from some of the constraints of user-agent behaviour (and in fact we take that liberty elsewhere in the library, like with our behaviour on redirects).\n\nSecondl... |
https://api.github.com/repos/psf/requests/issues/1854 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1854/labels{/name} | https://api.github.com/repos/psf/requests/issues/1854/comments | https://api.github.com/repos/psf/requests/issues/1854/events | https://github.com/psf/requests/pull/1854 | 25,343,918 | MDExOlB1bGxSZXF1ZXN0MTEzNzM1MzE= | 1,854 | Changelog for 2.2.0. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2014-01-09T19:11:21Z | 2021-09-08T23:05:06Z | 2014-01-09T19:14:45Z | MEMBER | resolved | As discussed in IRC.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1854/reactions"
} | https://api.github.com/repos/psf/requests/issues/1854/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1854.diff",
"html_url": "https://github.com/psf/requests/pull/1854",
"merged_at": "2014-01-09T19:14:45Z",
"patch_url": "https://github.com/psf/requests/pull/1854.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1854"
} | true | [
":100: \n"
] |
https://api.github.com/repos/psf/requests/issues/1853 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1853/labels{/name} | https://api.github.com/repos/psf/requests/issues/1853/comments | https://api.github.com/repos/psf/requests/issues/1853/events | https://github.com/psf/requests/issues/1853 | 25,329,134 | MDU6SXNzdWUyNTMyOTEzNA== | 1,853 | Allow to disable SSL compression. | {
"avatar_url": "https://avatars.githubusercontent.com/u/98980?v=4",
"events_url": "https://api.github.com/users/chmouel/events{/privacy}",
"followers_url": "https://api.github.com/users/chmouel/followers",
"following_url": "https://api.github.com/users/chmouel/following{/other_user}",
"gists_url": "https://api.github.com/users/chmouel/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/chmouel",
"id": 98980,
"login": "chmouel",
"node_id": "MDQ6VXNlcjk4OTgw",
"organizations_url": "https://api.github.com/users/chmouel/orgs",
"received_events_url": "https://api.github.com/users/chmouel/received_events",
"repos_url": "https://api.github.com/users/chmouel/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/chmouel/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/chmouel/subscriptions",
"type": "User",
"url": "https://api.github.com/users/chmouel",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 14 | 2014-01-09T15:54:45Z | 2021-09-09T00:28:15Z | 2014-01-09T22:12:26Z | NONE | resolved | For certain use cases disabling SSL compression gets us better performances while staying secure, it would be nice if requests allow to do that
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1853/reactions"
} | https://api.github.com/repos/psf/requests/issues/1853/timeline | null | completed | null | null | false | [
"I don't believe we offer SSL compression.\n\nI tested the following scenarios on my local machine (Windows 7) against a webserver I control ([here](https://pyrc-web.com/), running nginx v1.4.1 with default settings):\n- Python 2.7 default settings: offer uses SSLv2, server negotiates to TLSv1, chooses the null com... |
https://api.github.com/repos/psf/requests/issues/1852 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1852/labels{/name} | https://api.github.com/repos/psf/requests/issues/1852/comments | https://api.github.com/repos/psf/requests/issues/1852/events | https://github.com/psf/requests/pull/1852 | 25,296,608 | MDExOlB1bGxSZXF1ZXN0MTEzNTAwODU= | 1,852 | TA example for SSL version. | {
"avatar_url": "https://avatars.githubusercontent.com/u/715626?v=4",
"events_url": "https://api.github.com/users/dsoprea/events{/privacy}",
"followers_url": "https://api.github.com/users/dsoprea/followers",
"following_url": "https://api.github.com/users/dsoprea/following{/other_user}",
"gists_url": "https://api.github.com/users/dsoprea/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dsoprea",
"id": 715626,
"login": "dsoprea",
"node_id": "MDQ6VXNlcjcxNTYyNg==",
"organizations_url": "https://api.github.com/users/dsoprea/orgs",
"received_events_url": "https://api.github.com/users/dsoprea/received_events",
"repos_url": "https://api.github.com/users/dsoprea/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dsoprea/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dsoprea/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dsoprea",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 12 | 2014-01-09T05:44:17Z | 2021-09-08T22:01:08Z | 2014-01-09T19:46:49Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1852/reactions"
} | https://api.github.com/repos/psf/requests/issues/1852/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1852.diff",
"html_url": "https://github.com/psf/requests/pull/1852",
"merged_at": "2014-01-09T19:46:49Z",
"patch_url": "https://github.com/psf/requests/pull/1852.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1852"
} | true | [
"Thanks for this!\n\nI've made a couple of suggestions inline in the diff. Can you take a look at them for me? =)\n",
"You can also rebase all of those commits to one. If you're unfamiliar with rebasing I can send instructions \n",
"I didn't think I could rebase if I already pushed. Not the case?\n\nDustin\n\nO... | |
https://api.github.com/repos/psf/requests/issues/1851 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1851/labels{/name} | https://api.github.com/repos/psf/requests/issues/1851/comments | https://api.github.com/repos/psf/requests/issues/1851/events | https://github.com/psf/requests/pull/1851 | 25,215,633 | MDExOlB1bGxSZXF1ZXN0MTEzMTE0MDI= | 1,851 | implement "send" hook for right before sending a Request | {
"avatar_url": "https://avatars.githubusercontent.com/u/2734?v=4",
"events_url": "https://api.github.com/users/eklitzke/events{/privacy}",
"followers_url": "https://api.github.com/users/eklitzke/followers",
"following_url": "https://api.github.com/users/eklitzke/following{/other_user}",
"gists_url": "https://api.github.com/users/eklitzke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/eklitzke",
"id": 2734,
"login": "eklitzke",
"node_id": "MDQ6VXNlcjI3MzQ=",
"organizations_url": "https://api.github.com/users/eklitzke/orgs",
"received_events_url": "https://api.github.com/users/eklitzke/received_events",
"repos_url": "https://api.github.com/users/eklitzke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/eklitzke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/eklitzke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/eklitzke",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-01-08T04:33:20Z | 2021-09-08T22:01:08Z | 2014-01-08T07:54:40Z | NONE | resolved | This implements a `send` hook, which is called right before a `Request` object is sent.
My motivation here is for a profiler I've written that automatically records request timing information (by recording a timestamp before a request is sent, and after), but I think there are probably a lot of other use cases, such as automagically munging request headers or whatnot.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1851/reactions"
} | https://api.github.com/repos/psf/requests/issues/1851/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1851.diff",
"html_url": "https://github.com/psf/requests/pull/1851",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1851.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1851"
} | true | [
"Thanks for this work!\n\nWe used to have a `send` hook (and a number of others), but we got rid of almost all of them. This is because the recommended way of implementing things like this is now to use [custom Transport Adapters](http://docs.python-requests.org/en/latest/user/advanced/#transport-adapters). If you ... |
https://api.github.com/repos/psf/requests/issues/1850 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1850/labels{/name} | https://api.github.com/repos/psf/requests/issues/1850/comments | https://api.github.com/repos/psf/requests/issues/1850/events | https://github.com/psf/requests/pull/1850 | 25,195,426 | MDExOlB1bGxSZXF1ZXN0MTEyOTk0NTE= | 1,850 | Force SSLv3. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2014-01-07T20:38:25Z | 2021-09-09T00:01:12Z | 2014-01-07T20:50:21Z | MEMBER | resolved | This is a _possible_ fix for #1847.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1850/reactions"
} | https://api.github.com/repos/psf/requests/issues/1850/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1850.diff",
"html_url": "https://github.com/psf/requests/pull/1850",
"merged_at": null,
"patch_url": "https://github.com/psf/requests/pull/1850.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1850"
} | true | [
"According to the table on http://docs.python.org/2/library/ssl.html#ssl.wrap_socket this is going to blow up on more mordern servers. (At least it is supposed to)\n",
"Is that true? http://docs.python.org/2/library/ssl.html#ssl.PROTOCOL_SSLv3\n",
"Based on my reading of that table, selecting `SSLv3` will work ... |
https://api.github.com/repos/psf/requests/issues/1849 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1849/labels{/name} | https://api.github.com/repos/psf/requests/issues/1849/comments | https://api.github.com/repos/psf/requests/issues/1849/events | https://github.com/psf/requests/pull/1849 | 25,195,068 | MDExOlB1bGxSZXF1ZXN0MTEyOTkyNTA= | 1,849 | Update urllib3 to 232f496 | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-01-07T20:32:39Z | 2021-09-08T11:00:50Z | 2014-01-07T23:22:24Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1849/reactions"
} | https://api.github.com/repos/psf/requests/issues/1849/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1849.diff",
"html_url": "https://github.com/psf/requests/pull/1849",
"merged_at": "2014-01-07T23:22:24Z",
"patch_url": "https://github.com/psf/requests/pull/1849.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1849"
} | true | [
"This fixes issue #1842.\n",
"This isn't necessary since @kennethreitz pulls in a fresh copy of urllib3 before each release I think. But thanks, this will hopefully ensure he pulls in the right version again.\n",
"No, this is great! I normally get urllib3 updates from PRs actually :)\n",
"Whoops! I misspoke! ... | |
https://api.github.com/repos/psf/requests/issues/1848 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1848/labels{/name} | https://api.github.com/repos/psf/requests/issues/1848/comments | https://api.github.com/repos/psf/requests/issues/1848/events | https://github.com/psf/requests/issues/1848 | 25,193,046 | MDU6SXNzdWUyNTE5MzA0Ng== | 1,848 | API for reporting failing URLs | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"color": "f7c6c7",
"default": false,
"description": null,
"id": 167537670,
"name": "Propose Close",
"node_id": "MDU6TGFiZWwxNjc1Mzc2NzA=",
"url": "https://api.github.com/repos/psf/requests/labels/Propose%20Close"
}
] | closed | true | {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | [
{
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}... | null | 9 | 2014-01-07T20:02:23Z | 2021-09-08T18:00:52Z | 2016-04-16T04:16:15Z | CONTRIBUTOR | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1848/reactions"
} | https://api.github.com/repos/psf/requests/issues/1848/timeline | null | completed | null | null | false | [
"Hm?\n",
"Like a place to POST to http://report.python-requests.org/ when you have a URL that doesn't behave properly.\n",
"Ah okay\n",
"Failing in what sense? Non-conformant, serving 500's...\n",
"On Fri, Jan 10, 2014 at 04:48:02PM -0800, Kevin Burke wrote:\n\n> Failing in what sense? Non-conformant, servi... | |
https://api.github.com/repos/psf/requests/issues/1847 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1847/labels{/name} | https://api.github.com/repos/psf/requests/issues/1847/comments | https://api.github.com/repos/psf/requests/issues/1847/events | https://github.com/psf/requests/issues/1847 | 25,192,314 | MDU6SXNzdWUyNTE5MjMxNA== | 1,847 | SSL error when trying to open a webpage | {
"avatar_url": "https://avatars.githubusercontent.com/u/772?v=4",
"events_url": "https://api.github.com/users/alex/events{/privacy}",
"followers_url": "https://api.github.com/users/alex/followers",
"following_url": "https://api.github.com/users/alex/following{/other_user}",
"gists_url": "https://api.github.com/users/alex/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/alex",
"id": 772,
"login": "alex",
"node_id": "MDQ6VXNlcjc3Mg==",
"organizations_url": "https://api.github.com/users/alex/orgs",
"received_events_url": "https://api.github.com/users/alex/received_events",
"repos_url": "https://api.github.com/users/alex/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/alex/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/alex/subscriptions",
"type": "User",
"url": "https://api.github.com/users/alex",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 31 | 2014-01-07T19:53:54Z | 2021-09-08T23:00:49Z | 2014-01-07T21:26:03Z | MEMBER | resolved | ``` pycon
>>> requests.get("https://www.howsmyssl.com/a/check")
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "/Users/alex_gaynor/.virtualenvs/tempenv-6827228677281/lib/python2.7/site-packages/requests/api.py", line 55, in get
return request('get', url, **kwargs)
File "/Users/alex_gaynor/.virtualenvs/tempenv-6827228677281/lib/python2.7/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/Users/alex_gaynor/.virtualenvs/tempenv-6827228677281/lib/python2.7/site-packages/requests/sessions.py", line 382, in request
resp = self.send(prep, **send_kwargs)
File "/Users/alex_gaynor/.virtualenvs/tempenv-6827228677281/lib/python2.7/site-packages/requests/sessions.py", line 485, in send
r = adapter.send(request, **kwargs)
File "/Users/alex_gaynor/.virtualenvs/tempenv-6827228677281/lib/python2.7/site-packages/requests/adapters.py", line 379, in send
raise SSLError(e)
requests.exceptions.SSLError: [Errno 1] _ssl.c:504: error:1407742E:SSL routines:SSL23_GET_SERVER_HELLO:tlsv1 alert protocol version
```
This page loads fine in my browser or when using `treq` with Twisted.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1847/reactions"
} | https://api.github.com/repos/psf/requests/issues/1847/timeline | null | completed | null | null | false | [
"Yeah, discussed this on Twitter already. It's worth noting that I'm fairly sure that anyone who uses SSL in Python from the stdlib will encounter this problem. I'll confirm by testing with httplib.\n",
"Yes, you can reproduce this with `urllib` as well -- I believe this does not affect Python 3.\n",
"@kennethr... |
https://api.github.com/repos/psf/requests/issues/1846 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1846/labels{/name} | https://api.github.com/repos/psf/requests/issues/1846/comments | https://api.github.com/repos/psf/requests/issues/1846/events | https://github.com/psf/requests/pull/1846 | 25,176,672 | MDExOlB1bGxSZXF1ZXN0MTEyOTA2NTk= | 1,846 | get_netrc_auth should handle os.path.expanduser failing | {
"avatar_url": "https://avatars.githubusercontent.com/u/46565?v=4",
"events_url": "https://api.github.com/users/acdha/events{/privacy}",
"followers_url": "https://api.github.com/users/acdha/followers",
"following_url": "https://api.github.com/users/acdha/following{/other_user}",
"gists_url": "https://api.github.com/users/acdha/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/acdha",
"id": 46565,
"login": "acdha",
"node_id": "MDQ6VXNlcjQ2NTY1",
"organizations_url": "https://api.github.com/users/acdha/orgs",
"received_events_url": "https://api.github.com/users/acdha/received_events",
"repos_url": "https://api.github.com/users/acdha/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/acdha/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/acdha/subscriptions",
"type": "User",
"url": "https://api.github.com/users/acdha",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2014-01-07T16:05:34Z | 2021-09-01T00:11:41Z | 2014-01-08T18:57:09Z | CONTRIBUTOR | resolved | https://github.com/toastdriven/django-haystack/issues/924 has a problem report from a user who appears to be running inside a process which does not have `$HOME` defined and is running under a UID which is either not in /etc/passwd or does not have permission to access it.
This causes [utils.get_netrc_auth](https://github.com/kennethreitz/requests/blob/v2.1.0/requests/utils.py#L73) to raise an unexpected `KeyError`. The easiest fix would be to simply add that to the except block at the bottom but that's probably too dangerous – I'd probably handle the `KeyError` right at the source until this can be fixed upstream.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1846/reactions"
} | https://api.github.com/repos/psf/requests/issues/1846/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1846.diff",
"html_url": "https://github.com/psf/requests/pull/1846",
"merged_at": "2014-01-08T18:57:09Z",
"patch_url": "https://github.com/psf/requests/pull/1846.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1846"
} | true | [
"Upstream Python bug report: http://bugs.python.org/issue20164\n",
"Well this makes me very sad. Thanks for raising this!\n\nGiven that upstream is not going to fix this on 2.6 _for sure_, even if they do implement a fix elsewhere, I think we need to handle this. The correct behaviour is that `get_netrc_auth` sho... |
https://api.github.com/repos/psf/requests/issues/1845 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1845/labels{/name} | https://api.github.com/repos/psf/requests/issues/1845/comments | https://api.github.com/repos/psf/requests/issues/1845/events | https://github.com/psf/requests/pull/1845 | 25,156,352 | MDExOlB1bGxSZXF1ZXN0MTEyNzg5NDA= | 1,845 | Resolve proxy_bypass problems. | {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-01-07T09:40:58Z | 2021-09-09T00:01:18Z | 2014-01-08T18:51:08Z | MEMBER | resolved | This resolves the sad, sad 2.6.x problems in `proxy_bypass` as reported in #1844 and #1841.
The nature of this fix is that, fundamentally, we don't care enough to let this call stop us. Assume that if it fails we aren't bypassing the proxy (usually we won't be) and move on with our lives.
I'm only catching the specific exceptions we've seen. I'm open to wrapping this in a generic `except` block if we want to.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1845/reactions"
} | https://api.github.com/repos/psf/requests/issues/1845/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1845.diff",
"html_url": "https://github.com/psf/requests/pull/1845",
"merged_at": "2014-01-08T18:51:08Z",
"patch_url": "https://github.com/psf/requests/pull/1845.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1845"
} | true | [
"Will get the issue reporter to test this asap\n",
"So the issue reporter said he got a different error, but the other old 2.6 issue (the _tunnel_host one). So I'd say that this is probably fixed with this change, and this should be fixed in entirity once both changes happen. I'm happy to have him test once this ... |
https://api.github.com/repos/psf/requests/issues/1844 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1844/labels{/name} | https://api.github.com/repos/psf/requests/issues/1844/comments | https://api.github.com/repos/psf/requests/issues/1844/events | https://github.com/psf/requests/issues/1844 | 25,154,275 | MDU6SXNzdWUyNTE1NDI3NQ== | 1,844 | Proxy Bypass Fails in Python <=2.6.5 | {
"avatar_url": "https://avatars.githubusercontent.com/u/145979?v=4",
"events_url": "https://api.github.com/users/dstufft/events{/privacy}",
"followers_url": "https://api.github.com/users/dstufft/followers",
"following_url": "https://api.github.com/users/dstufft/following{/other_user}",
"gists_url": "https://api.github.com/users/dstufft/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dstufft",
"id": 145979,
"login": "dstufft",
"node_id": "MDQ6VXNlcjE0NTk3OQ==",
"organizations_url": "https://api.github.com/users/dstufft/orgs",
"received_events_url": "https://api.github.com/users/dstufft/received_events",
"repos_url": "https://api.github.com/users/dstufft/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dstufft/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dstufft/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dstufft",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2014-01-07T08:46:47Z | 2021-09-09T00:28:15Z | 2014-01-10T11:13:14Z | CONTRIBUTOR | resolved | It appears that when using a proxy bypass with an IP wthout a netmask causes an exception to be raised from requests in python <= 2.6.5. This is due to a bug in the stdlib which was fixed in 2.6.6.
Python bugs: http://bugs.python.org/issue10643 http://bugs.python.org/issue8883
More information: https://github.com/pypa/pip/issues/1429
This is another issue that pip hit with the recent 1.5 release that is occuring on older 2.6 releases.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1844/reactions"
} | https://api.github.com/repos/psf/requests/issues/1844/timeline | null | completed | null | null | false | [
"For ease of reading, here's the exception:\n\n```\n/Users/jerith/.virtualenvs/txTwitter/bin/pip run on Mon Jan 6 21:15:03 2014\nDownloading/unpacking Twisted\n Getting page https://pypi.python.org/simple/Twisted/\nCleaning up...\n Removing temporary dir /Users/jerith/.virtualenvs/txTwitter/build...\nException:\... |
https://api.github.com/repos/psf/requests/issues/1843 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1843/labels{/name} | https://api.github.com/repos/psf/requests/issues/1843/comments | https://api.github.com/repos/psf/requests/issues/1843/events | https://github.com/psf/requests/issues/1843 | 25,153,520 | MDU6SXNzdWUyNTE1MzUyMA== | 1,843 | Allow bypassing decoding with iter_content | {
"avatar_url": "https://avatars.githubusercontent.com/u/145979?v=4",
"events_url": "https://api.github.com/users/dstufft/events{/privacy}",
"followers_url": "https://api.github.com/users/dstufft/followers",
"following_url": "https://api.github.com/users/dstufft/following{/other_user}",
"gists_url": "https://api.github.com/users/dstufft/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dstufft",
"id": 145979,
"login": "dstufft",
"node_id": "MDQ6VXNlcjE0NTk3OQ==",
"organizations_url": "https://api.github.com/users/dstufft/orgs",
"received_events_url": "https://api.github.com/users/dstufft/received_events",
"repos_url": "https://api.github.com/users/dstufft/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dstufft/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dstufft/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dstufft",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 6 | 2014-01-07T08:24:19Z | 2021-09-09T00:28:16Z | 2014-01-07T09:38:41Z | CONTRIBUTOR | resolved | When servers send a `Content-Encoding` header requests (actually urllib3, but because of decode_content=True kwarg requests passes) will automatically decode the response. In pip this is causing a breakage for servers that serve a .tar.gz with a `Content-Encoding: gzip` header. Would it be at all possible to have iter_content support a `content_decode` kwarg that just get's passed through to urllib3?
| {
"avatar_url": "https://avatars.githubusercontent.com/u/145979?v=4",
"events_url": "https://api.github.com/users/dstufft/events{/privacy}",
"followers_url": "https://api.github.com/users/dstufft/followers",
"following_url": "https://api.github.com/users/dstufft/following{/other_user}",
"gists_url": "https://api.github.com/users/dstufft/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dstufft",
"id": 145979,
"login": "dstufft",
"node_id": "MDQ6VXNlcjE0NTk3OQ==",
"organizations_url": "https://api.github.com/users/dstufft/orgs",
"received_events_url": "https://api.github.com/users/dstufft/received_events",
"repos_url": "https://api.github.com/users/dstufft/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dstufft/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dstufft/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dstufft",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1843/reactions"
} | https://api.github.com/repos/psf/requests/issues/1843/timeline | null | completed | null | null | false | [
"For reference this is in pip's issues as https://github.com/pypa/pip/issues/1419 and https://github.com/pypa/pip/issues/1421\n",
"I'm obviously tempted to argue that `pip` should be able to spot this and handle it (that is, any compliant server would signal `Content-Encoding: gzip` and `Content-Type: application... |
https://api.github.com/repos/psf/requests/issues/1842 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1842/labels{/name} | https://api.github.com/repos/psf/requests/issues/1842/comments | https://api.github.com/repos/psf/requests/issues/1842/events | https://github.com/psf/requests/issues/1842 | 25,128,192 | MDU6SXNzdWUyNTEyODE5Mg== | 1,842 | HTTPS connections with requests incompatible with python 2.6.(0-2) | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 8 | 2014-01-06T20:41:32Z | 2021-09-09T00:28:15Z | 2014-01-06T20:57:50Z | CONTRIBUTOR | resolved | Creating this for tracking purposes... urllib3 attempts to access an attribute that was added in 2.6.3, breaking older Python 2.6's.
https://github.com/shazow/urllib3/pull/307 fixes this issue, once that's merged the dependency in requests should probably be updated.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1842/reactions"
} | https://api.github.com/repos/psf/requests/issues/1842/timeline | null | completed | null | null | false | [
"@sigmavirus24 and I are in favour of not supporting very old patch releases of 2.6. For perspective, 2.6.0 was released in 2008 and 2.6.2 was released in April 2009.\n\nObviously, we'll take the fix in urllib3, but I see no reason for Requests to rush into supporting a five year old release of Python. Anyone who f... |
https://api.github.com/repos/psf/requests/issues/1841 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1841/labels{/name} | https://api.github.com/repos/psf/requests/issues/1841/comments | https://api.github.com/repos/psf/requests/issues/1841/events | https://github.com/psf/requests/issues/1841 | 25,098,751 | MDU6SXNzdWUyNTA5ODc1MQ== | 1,841 | URL with port causing socket.gaierror | {
"avatar_url": "https://avatars.githubusercontent.com/u/10137?v=4",
"events_url": "https://api.github.com/users/ghost/events{/privacy}",
"followers_url": "https://api.github.com/users/ghost/followers",
"following_url": "https://api.github.com/users/ghost/following{/other_user}",
"gists_url": "https://api.github.com/users/ghost/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/ghost",
"id": 10137,
"login": "ghost",
"node_id": "MDQ6VXNlcjEwMTM3",
"organizations_url": "https://api.github.com/users/ghost/orgs",
"received_events_url": "https://api.github.com/users/ghost/received_events",
"repos_url": "https://api.github.com/users/ghost/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/ghost/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/ghost/subscriptions",
"type": "User",
"url": "https://api.github.com/users/ghost",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2014-01-06T12:19:16Z | 2021-09-08T04:00:47Z | 2014-01-06T16:56:39Z | NONE | resolved | The following is not working:
```
import requests
requests.post('http://localhost:8080/', data={"hello": "world"})
```
This works:
``````
import requests
requests.post('http://localhost/', data={"hello": "world"})```
``````
This works too:
``````
$ export HTTP_PROXY="http://localhost:8080"
$ python
import requests
requests.post('http://localhost/', data={"hello": "world"})```
``````
Requests 2.1.0
Python 2.6.1
Mac OS X 10.6.8
httpie debug:
```
requests.request({'allow_redirects': False,
'auth': None,
'data': {},
'files': {},
'headers': CaseInsensitiveDict({'User-Agent': 'HTTPie/0.8.0-dev'}),
'method': 'post',
'params': {},
'proxies': {},
'stream': True,
'timeout': 30,
'url': 'http://localhost:8080/xxx/rest/product/',
'verify': True})
Traceback (most recent call last):
File "/Users/andi/.virtualenvs/xxxx/bin/http", line 8, in <module>
load_entry_point('httpie==0.8.0-dev', 'console_scripts', 'http')()
File "/Users/andi/.virtualenvs/xxxx/lib/python2.6/site-packages/httpie/core.py", line 95, in main
response = get_response(args, config_dir=env.config.directory)
File "/Users/andi/.virtualenvs/xxxx/lib/python2.6/site-packages/httpie/client.py", line 27, in get_response
response = requests.request(**requests_kwargs)
File "/Users/andi/.virtualenvs/xxxx/lib/python2.6/site-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, **kwargs)
File "/Users/andi/.virtualenvs/xxxx/lib/python2.6/site-packages/requests/sessions.py", line 355, in request
env_proxies = get_environ_proxies(url) or {}
File "/Users/andi/.virtualenvs/xxxx/lib/python2.6/site-packages/requests/utils.py", line 490, in get_environ_proxies
if proxy_bypass(netloc):
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib.py", line 1567, in proxy_bypass
return proxy_bypass_macosx_sysconf(host)
File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/urllib.py", line 1433, in proxy_bypass_macosx_sysconf
hostIP = socket.gethostbyname(host)
socket.gaierror: [Errno 8] nodename nor servname provided, or not known
```
| null | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1841/reactions"
} | https://api.github.com/repos/psf/requests/issues/1841/timeline | null | completed | null | null | false | [
"Hmm, that stack trace is interesting. I don't have a copy of Python 2.6.1 sitting around, but in 2.7 that code is subtly different, and explicitly splits the host and port. I wonder if early versions of 2.6 had a bug in their `proxy_bypass` code.\n",
"2.6.1 _is_ ancient. I think the latest release is 2.6.9 or so... |
https://api.github.com/repos/psf/requests/issues/1840 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1840/labels{/name} | https://api.github.com/repos/psf/requests/issues/1840/comments | https://api.github.com/repos/psf/requests/issues/1840/events | https://github.com/psf/requests/issues/1840 | 25,064,220 | MDU6SXNzdWUyNTA2NDIyMA== | 1,840 | server cookies (not set by me) not saved within a Session | {
"avatar_url": "https://avatars.githubusercontent.com/u/6320683?v=4",
"events_url": "https://api.github.com/users/dvasseur/events{/privacy}",
"followers_url": "https://api.github.com/users/dvasseur/followers",
"following_url": "https://api.github.com/users/dvasseur/following{/other_user}",
"gists_url": "https://api.github.com/users/dvasseur/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/dvasseur",
"id": 6320683,
"login": "dvasseur",
"node_id": "MDQ6VXNlcjYzMjA2ODM=",
"organizations_url": "https://api.github.com/users/dvasseur/orgs",
"received_events_url": "https://api.github.com/users/dvasseur/received_events",
"repos_url": "https://api.github.com/users/dvasseur/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/dvasseur/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/dvasseur/subscriptions",
"type": "User",
"url": "https://api.github.com/users/dvasseur",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 18 | 2014-01-05T01:59:08Z | 2021-09-09T00:28:16Z | 2014-01-05T09:21:01Z | NONE | resolved | Using a Session, when a server is setting some cookie on a 301/302 response, the cookie is not saved
Update: could not find a public site to show the issue, hope this will be enough!
Update 2: see here http://blog.dubbelboer.com/2012/11/25/302-cookie.html
``` python
http_session = requests.Session()
http_session.headers.update({'User-Agent': 'Mozilla/5.0 (Windows NT 6.1; WOW64;$
url = 'http://dubbelboer.com/302cookie.php'
r = http_session.get(url)
print(r.history)
print(r.url)
print(r.text)
for cookie in r.cookies:
print(cookie)
# ---
(Response [302],)
http://dubbelboer.com/302cookie.php?show=1388887790.4324
Cookie was: NOT SET<br><a href="?a=1388887790.4493">try again</a>
<Cookie test= for dubbelboer.com/>
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1840/reactions"
} | https://api.github.com/repos/psf/requests/issues/1840/timeline | null | completed | null | null | false | [
"@dvasseur I updated your issue to use code blocks so that it's highlighted properly.\n\nCan you let us know which version of requests you're using?\n",
"FWIW, On the latest requests this is not an issue for me:\n\n``` pycon\n>>> import requests\n>>> s = requests.Session()\n>>> r = s.get('http://dubbelboer.com/30... |
https://api.github.com/repos/psf/requests/issues/1839 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1839/labels{/name} | https://api.github.com/repos/psf/requests/issues/1839/comments | https://api.github.com/repos/psf/requests/issues/1839/events | https://github.com/psf/requests/issues/1839 | 25,042,360 | MDU6SXNzdWUyNTA0MjM2MA== | 1,839 | Unquote+Quote cycle prohibits urls required by salesforce.com | {
"avatar_url": "https://avatars.githubusercontent.com/u/493648?v=4",
"events_url": "https://api.github.com/users/jsullivanlive/events{/privacy}",
"followers_url": "https://api.github.com/users/jsullivanlive/followers",
"following_url": "https://api.github.com/users/jsullivanlive/following{/other_user}",
"gists_url": "https://api.github.com/users/jsullivanlive/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/jsullivanlive",
"id": 493648,
"login": "jsullivanlive",
"node_id": "MDQ6VXNlcjQ5MzY0OA==",
"organizations_url": "https://api.github.com/users/jsullivanlive/orgs",
"received_events_url": "https://api.github.com/users/jsullivanlive/received_events",
"repos_url": "https://api.github.com/users/jsullivanlive/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/jsullivanlive/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/jsullivanlive/subscriptions",
"type": "User",
"url": "https://api.github.com/users/jsullivanlive",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 9 | 2014-01-03T23:31:28Z | 2021-09-09T00:09:57Z | 2014-01-29T19:25:04Z | NONE | resolved | Salesforce.com requires you %hex encode period (.) and slash (/) to issue a PATCH.
The unquote+quote cycle in `requote_uri(uri)` disallows this: https://github.com/kennethreitz/requests/blob/master/requests/utils.py#L398
Since it's not prohibited by the http spec (see uri comparison at http://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html#sec3.2.2) but some web services like salesforce.com won't allow the unquoted values for period or slash, could this be disabled? I'm glad to issue a pull request for disabling it but figured that I'd ask first for background before assuming I knew why this was here.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1839/reactions"
} | https://api.github.com/repos/psf/requests/issues/1839/timeline | null | completed | null | null | false | [
"Thanks for raising this issue!\n\nFirstly, I think the slashes are a non-starter. We always urlencode them if you pass them in the `params` dict, so that's not a problem. The sole problem seems to be with periods.\n\nHappily, the answer is that you can disable it if you use the [PreparedRequest](http://docs.python... |
https://api.github.com/repos/psf/requests/issues/1838 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1838/labels{/name} | https://api.github.com/repos/psf/requests/issues/1838/comments | https://api.github.com/repos/psf/requests/issues/1838/events | https://github.com/psf/requests/issues/1838 | 25,035,380 | MDU6SXNzdWUyNTAzNTM4MA== | 1,838 | Session Uses Wrong Method When Making Requests | {
"avatar_url": "https://avatars.githubusercontent.com/u/1467590?v=4",
"events_url": "https://api.github.com/users/creese/events{/privacy}",
"followers_url": "https://api.github.com/users/creese/followers",
"following_url": "https://api.github.com/users/creese/following{/other_user}",
"gists_url": "https://api.github.com/users/creese/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/creese",
"id": 1467590,
"login": "creese",
"node_id": "MDQ6VXNlcjE0Njc1OTA=",
"organizations_url": "https://api.github.com/users/creese/orgs",
"received_events_url": "https://api.github.com/users/creese/received_events",
"repos_url": "https://api.github.com/users/creese/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/creese/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/creese/subscriptions",
"type": "User",
"url": "https://api.github.com/users/creese",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-01-03T20:57:07Z | 2021-09-09T00:28:19Z | 2014-01-03T21:46:18Z | NONE | resolved | When making a request with a session, such as:
```
response = session.post("some_url", form_data)
```
the value of `response.request.method` can sometimes be a `GET` with a `response.request.body` that's empty.
This happens with surprisingly high frequency (appox. 1 in 10 requests).
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1467590?v=4",
"events_url": "https://api.github.com/users/creese/events{/privacy}",
"followers_url": "https://api.github.com/users/creese/followers",
"following_url": "https://api.github.com/users/creese/following{/other_user}",
"gists_url": "https://api.github.com/users/creese/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/creese",
"id": 1467590,
"login": "creese",
"node_id": "MDQ6VXNlcjE0Njc1OTA=",
"organizations_url": "https://api.github.com/users/creese/orgs",
"received_events_url": "https://api.github.com/users/creese/received_events",
"repos_url": "https://api.github.com/users/creese/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/creese/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/creese/subscriptions",
"type": "User",
"url": "https://api.github.com/users/creese",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1838/reactions"
} | https://api.github.com/repos/psf/requests/issues/1838/timeline | null | completed | null | null | false | [
"You are not checking `response.history` which will undoubtedly show that the original response was a redirect. On redirect, we must change the verb and clear the body per the RFC. I'll wait for you to confirm that you see redirects in your history before closing this.\n",
"I am getting a 301 in `response.history... |
https://api.github.com/repos/psf/requests/issues/1837 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1837/labels{/name} | https://api.github.com/repos/psf/requests/issues/1837/comments | https://api.github.com/repos/psf/requests/issues/1837/events | https://github.com/psf/requests/issues/1837 | 25,000,754 | MDU6SXNzdWUyNTAwMDc1NA== | 1,837 | failed to fetch URL which can be accessed by browser | {
"avatar_url": "https://avatars.githubusercontent.com/u/1005070?v=4",
"events_url": "https://api.github.com/users/hustwj/events{/privacy}",
"followers_url": "https://api.github.com/users/hustwj/followers",
"following_url": "https://api.github.com/users/hustwj/following{/other_user}",
"gists_url": "https://api.github.com/users/hustwj/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/hustwj",
"id": 1005070,
"login": "hustwj",
"node_id": "MDQ6VXNlcjEwMDUwNzA=",
"organizations_url": "https://api.github.com/users/hustwj/orgs",
"received_events_url": "https://api.github.com/users/hustwj/received_events",
"repos_url": "https://api.github.com/users/hustwj/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/hustwj/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/hustwj/subscriptions",
"type": "User",
"url": "https://api.github.com/users/hustwj",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 2 | 2014-01-03T03:55:47Z | 2021-09-09T00:28:19Z | 2014-01-03T07:30:47Z | NONE | resolved | I failed to fetch a web page from the following URL, but this URL is fine in my browser.
http://hkblog.xanga.com/2009/08/17/%E3%80%8A%E6%84%9B%E6%83%85%EF%BC%8C%E6%B2%92%E9%82%A3%E9%BA%BC%E7%BE%8E%E5%A5%BD%E3%80%8B/
The error messages are as follows:
Traceback (most recent call last):
File "test.py", line 4, in <module>
cur_r = requests.get('http://hkblog.xanga.com/2009/08/17/%E3%80%8A%E6%84%9B%E6%83%85%EF%BC%8C%E6%B2%92%E9%82%A3%E9%BA%BC%E7%BE%8E%E5%A5%BD%E3%80%8B/')
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 55, in get
return request('get', url, *_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/api.py", line 44, in request
return session.request(method=method, url=url, *_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 382, in request
resp = self.send(prep, *_send_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/sessions.py", line 485, in send
r = adapter.send(request, *_kwargs)
File "/usr/local/lib/python2.7/dist-packages/requests/adapters.py", line 372, in send
raise ConnectionError(e)
requests.exceptions.ConnectionError: HTTPConnectionPool(host='hkblog.xanga.com', port=80): Max retries exceeded with url: /2009/08/17/%E3%80%8A%E6%84%9B%E6%83%85%EF%BC%8C%E6%B2%92%E9%82%A3%E9%BA%BC%E7%BE%8E%E5%A5%BD%E3%80%8B/ (Caused by <class 'httplib.BadStatusLine'>: '')
| {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1837/reactions"
} | https://api.github.com/repos/psf/requests/issues/1837/timeline | null | completed | null | null | false | [
"I think the host 'http://hkblog.xanga.com' does not accept 'User-Agent' containing 'CPython'.\nWhen i send same request with `header={'User-Agent' : 'python-requests/2.1.0 CPython/2.7.5 Darwin/13.0.0'}` (exactly same user-agent with `requests`), that error also occurs in urllib2.\nBut when i remove 'CPython/2.7.5'... |
https://api.github.com/repos/psf/requests/issues/1836 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1836/labels{/name} | https://api.github.com/repos/psf/requests/issues/1836/comments | https://api.github.com/repos/psf/requests/issues/1836/events | https://github.com/psf/requests/pull/1836 | 24,990,101 | MDExOlB1bGxSZXF1ZXN0MTExOTM3Mzg= | 1,836 | Bump the year ftw | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 8 | 2014-01-02T22:01:41Z | 2021-09-08T23:06:04Z | 2014-01-08T18:44:21Z | CONTRIBUTOR | resolved | s/2013/2014
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1836/reactions"
} | https://api.github.com/repos/psf/requests/issues/1836/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1836.diff",
"html_url": "https://github.com/psf/requests/pull/1836",
"merged_at": "2014-01-08T18:44:21Z",
"patch_url": "https://github.com/psf/requests/pull/1836.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1836"
} | true | [
"May as well update LICENSE. =D\n",
"Hurrah! =D :+1:\n",
"Done. And to quote my commit message:\n\n> No one checks docs or a license\n\n:wink: \n",
"Ooh, ooh, I do!\n",
"You would\n",
"> Bump the year ftw\n\nThe usual practice is to update the list of years each time the file is modified (but never remove... |
https://api.github.com/repos/psf/requests/issues/1835 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1835/labels{/name} | https://api.github.com/repos/psf/requests/issues/1835/comments | https://api.github.com/repos/psf/requests/issues/1835/events | https://github.com/psf/requests/issues/1835 | 24,918,485 | MDU6SXNzdWUyNDkxODQ4NQ== | 1,835 | Set trust_env as an option in request method | {
"avatar_url": "https://avatars.githubusercontent.com/u/922419?v=4",
"events_url": "https://api.github.com/users/V-E-O/events{/privacy}",
"followers_url": "https://api.github.com/users/V-E-O/followers",
"following_url": "https://api.github.com/users/V-E-O/following{/other_user}",
"gists_url": "https://api.github.com/users/V-E-O/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/V-E-O",
"id": 922419,
"login": "V-E-O",
"node_id": "MDQ6VXNlcjkyMjQxOQ==",
"organizations_url": "https://api.github.com/users/V-E-O/orgs",
"received_events_url": "https://api.github.com/users/V-E-O/received_events",
"repos_url": "https://api.github.com/users/V-E-O/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/V-E-O/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/V-E-O/subscriptions",
"type": "User",
"url": "https://api.github.com/users/V-E-O",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-12-31T11:52:38Z | 2021-09-09T00:28:19Z | 2013-12-31T11:55:39Z | NONE | resolved | Hidden set trust_env in class Session aimed to trust the http_proxy env, can we have this as an option in Session.request or request api, for only in request method, this option are read to decide to trust http_proxy env or not.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1835/reactions"
} | https://api.github.com/repos/psf/requests/issues/1835/timeline | null | completed | null | null | false | [
"There's nothing hidden about `trust_env`, it's [documented](http://docs.python-requests.org/en/latest/api/#requests.Session.trust_env). We're not going to change where `trust_env` lives, we're happy with the API as it stands.\n\nThanks for asking though!\n",
"My mistake about unclear expression.\nSometimes we'd ... |
https://api.github.com/repos/psf/requests/issues/1834 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1834/labels{/name} | https://api.github.com/repos/psf/requests/issues/1834/comments | https://api.github.com/repos/psf/requests/issues/1834/events | https://github.com/psf/requests/issues/1834 | 24,892,527 | MDU6SXNzdWUyNDg5MjUyNw== | 1,834 | Provide classifiers for PyPI that specify which Python versions are supported | {
"avatar_url": "https://avatars.githubusercontent.com/u/56778?v=4",
"events_url": "https://api.github.com/users/cool-RR/events{/privacy}",
"followers_url": "https://api.github.com/users/cool-RR/followers",
"following_url": "https://api.github.com/users/cool-RR/following{/other_user}",
"gists_url": "https://api.github.com/users/cool-RR/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/cool-RR",
"id": 56778,
"login": "cool-RR",
"node_id": "MDQ6VXNlcjU2Nzc4",
"organizations_url": "https://api.github.com/users/cool-RR/orgs",
"received_events_url": "https://api.github.com/users/cool-RR/received_events",
"repos_url": "https://api.github.com/users/cool-RR/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/cool-RR/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/cool-RR/subscriptions",
"type": "User",
"url": "https://api.github.com/users/cool-RR",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 3 | 2013-12-30T17:29:34Z | 2021-09-09T00:28:20Z | 2013-12-30T17:31:54Z | NONE | resolved | {
"avatar_url": "https://avatars.githubusercontent.com/u/240830?v=4",
"events_url": "https://api.github.com/users/sigmavirus24/events{/privacy}",
"followers_url": "https://api.github.com/users/sigmavirus24/followers",
"following_url": "https://api.github.com/users/sigmavirus24/following{/other_user}",
"gists_url": "https://api.github.com/users/sigmavirus24/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/sigmavirus24",
"id": 240830,
"login": "sigmavirus24",
"node_id": "MDQ6VXNlcjI0MDgzMA==",
"organizations_url": "https://api.github.com/users/sigmavirus24/orgs",
"received_events_url": "https://api.github.com/users/sigmavirus24/received_events",
"repos_url": "https://api.github.com/users/sigmavirus24/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/sigmavirus24/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/sigmavirus24/subscriptions",
"type": "User",
"url": "https://api.github.com/users/sigmavirus24",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1834/reactions"
} | https://api.github.com/repos/psf/requests/issues/1834/timeline | null | completed | null | null | false | [
"We do: https://github.com/kennethreitz/requests/blob/master/setup.py#L56..L60\n",
"Then why do these don't appear on the PyPI page?\n\nhttps://pypi.python.org/pypi/requests\n\nOn Mon, Dec 30, 2013 at 7:32 PM, Ian Cordasco notifications@github.comwrote:\n\n> We do:\n> https://github.com/kennethreitz/requests/blob... | |
https://api.github.com/repos/psf/requests/issues/1833 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1833/labels{/name} | https://api.github.com/repos/psf/requests/issues/1833/comments | https://api.github.com/repos/psf/requests/issues/1833/events | https://github.com/psf/requests/issues/1833 | 24,845,131 | MDU6SXNzdWUyNDg0NTEzMQ== | 1,833 | UnsupportedContentType | {
"avatar_url": "https://avatars.githubusercontent.com/u/1450977?v=4",
"events_url": "https://api.github.com/users/xjsender/events{/privacy}",
"followers_url": "https://api.github.com/users/xjsender/followers",
"following_url": "https://api.github.com/users/xjsender/following{/other_user}",
"gists_url": "https://api.github.com/users/xjsender/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/xjsender",
"id": 1450977,
"login": "xjsender",
"node_id": "MDQ6VXNlcjE0NTA5Nzc=",
"organizations_url": "https://api.github.com/users/xjsender/orgs",
"received_events_url": "https://api.github.com/users/xjsender/received_events",
"repos_url": "https://api.github.com/users/xjsender/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/xjsender/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/xjsender/subscriptions",
"type": "User",
"url": "https://api.github.com/users/xjsender",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 4 | 2013-12-28T12:15:45Z | 2021-09-09T00:28:21Z | 2013-12-28T12:20:59Z | NONE | resolved | I use below code to post a data from file to salesforce, sometimes, it worked.
``` python
def create_batch(self, job_id):
url = self.base_url + "/job/%s/batch" % job_id
headers = self.headers
headers["Content-Type"] = "text/csv;charset=UTF-8"
if self.operation == "query" and self.records == None:
api = SalesforceApi(self.settings)
self.records = api.combine_soql(self.sobject)
response = requests.post(url, self.records, verify=False, headers=headers)
print (response.content)
if response.status_code == 400:
return self.parse_response(response, url)
batch_id = getUniqueElementValueFromXmlString(response.content, "id")
return batch_id
```
However, sometimes, it may give me below error
```
b'<?xml version="1.0" encoding="UTF-8"?>
<error\n xmlns="http://www.force.com/2009/06/asyncapi/dataload">\n
<exceptionCode>UnsupportedContentType</exceptionCode>\n
<exceptionMessage>
Unsupported content type: application/x-www-form-urlencoded
</exceptionMessage>\n
</error>'
```
Actually, I am very sure my headers content type is "text/csv;charset=UTF-8", however, after requests post is done, my request content type is changed to "application/x-www-form-urlencoded".
So I check the requests source code and I add a print statement in `models.py`,
``` python
else:
# Multi-part file uploads.
if files:
(body, content_type) = self._encode_files(files, data)
else:
if data:
body = self._encode_params(data)
if isinstance(data, str) or isinstance(data, builtin_str) or hasattr(data, 'read'):
content_type = None
else:
content_type = 'application/x-www-form-urlencoded'
self.prepare_content_length(body)
# Add content-type if it wasn't explicitly provided.
if (content_type) and (not 'content-type' in self.headers):
self.headers['Content-Type'] = content_type
print (self.headers)
self.body = body
```
The print result contains two `Content-Type`, can you help me on this problem?
```
CaseInsensitiveDict({
'Content-Length' : '22',
b'Content-Type' : 'text/csv;charset=UTF-8',
b'Accept' : '*/*',
b'Accept-Encoding' : 'gzip, deflate, compress',
'Content-Type' : 'application/x-www-form-urlencoded',
b'X-SFDC-Session' : '00D90000000Y9ll!AQEAQJXx87QsHqdUeBbbw1qCbC0K0a7063VDxwZeYv8ZRgDpnmTcQjdxQL5R3tgumYtqhYz3WYK74QH3_ZJgngFDvdzBHB_G',
b'User-Agent' : 'python-requests/1.2.3 CPython/3.3.0 Windows/7'
})
```
| {
"avatar_url": "https://avatars.githubusercontent.com/u/1382556?v=4",
"events_url": "https://api.github.com/users/Lukasa/events{/privacy}",
"followers_url": "https://api.github.com/users/Lukasa/followers",
"following_url": "https://api.github.com/users/Lukasa/following{/other_user}",
"gists_url": "https://api.github.com/users/Lukasa/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/Lukasa",
"id": 1382556,
"login": "Lukasa",
"node_id": "MDQ6VXNlcjEzODI1NTY=",
"organizations_url": "https://api.github.com/users/Lukasa/orgs",
"received_events_url": "https://api.github.com/users/Lukasa/received_events",
"repos_url": "https://api.github.com/users/Lukasa/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/Lukasa/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/Lukasa/subscriptions",
"type": "User",
"url": "https://api.github.com/users/Lukasa",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1833/reactions"
} | https://api.github.com/repos/psf/requests/issues/1833/timeline | null | completed | null | null | false | [
"What version of Requests are you using?\n",
"```\nCaseInsensitiveDict({\n 'Content-Length' : '22',\n b'Content-Type' : 'text/csv;charset=UTF-8',\n b'Accept' : '*/*',\n b'Accept-Encoding' : 'gzip, deflate, compress',\n 'Content-Type' : 'application/x-www-form-urlencoded',\n b'X-SFDC-Session' : '... |
https://api.github.com/repos/psf/requests/issues/1832 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1832/labels{/name} | https://api.github.com/repos/psf/requests/issues/1832/comments | https://api.github.com/repos/psf/requests/issues/1832/events | https://github.com/psf/requests/pull/1832 | 24,842,972 | MDExOlB1bGxSZXF1ZXN0MTExMjM4NTg= | 1,832 | Fix warnings when building the docs | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [] | closed | true | null | [] | null | 1 | 2013-12-28T08:11:57Z | 2021-09-08T11:00:51Z | 2014-01-08T18:45:33Z | CONTRIBUTOR | resolved | It may be nice to make builds fail if new documentation generates warnings, to
avoid these sorts of problems slipping in in the future.
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1832/reactions"
} | https://api.github.com/repos/psf/requests/issues/1832/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1832.diff",
"html_url": "https://github.com/psf/requests/pull/1832",
"merged_at": "2014-01-08T18:45:33Z",
"patch_url": "https://github.com/psf/requests/pull/1832.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1832"
} | true | [
"One note, otherwise I'm happy with this. =)\n"
] |
https://api.github.com/repos/psf/requests/issues/1831 | https://api.github.com/repos/psf/requests | https://api.github.com/repos/psf/requests/issues/1831/labels{/name} | https://api.github.com/repos/psf/requests/issues/1831/comments | https://api.github.com/repos/psf/requests/issues/1831/events | https://github.com/psf/requests/pull/1831 | 24,842,750 | MDExOlB1bGxSZXF1ZXN0MTExMjM3NzA= | 1,831 | Add more interlinks between the documentation | {
"avatar_url": "https://avatars.githubusercontent.com/u/234019?v=4",
"events_url": "https://api.github.com/users/kevinburke/events{/privacy}",
"followers_url": "https://api.github.com/users/kevinburke/followers",
"following_url": "https://api.github.com/users/kevinburke/following{/other_user}",
"gists_url": "https://api.github.com/users/kevinburke/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kevinburke",
"id": 234019,
"login": "kevinburke",
"node_id": "MDQ6VXNlcjIzNDAxOQ==",
"organizations_url": "https://api.github.com/users/kevinburke/orgs",
"received_events_url": "https://api.github.com/users/kevinburke/received_events",
"repos_url": "https://api.github.com/users/kevinburke/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kevinburke/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kevinburke/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kevinburke",
"user_view_type": "public"
} | [
{
"color": "009800",
"default": false,
"description": null,
"id": 44501218,
"name": "Ready To Merge",
"node_id": "MDU6TGFiZWw0NDUwMTIxOA==",
"url": "https://api.github.com/repos/psf/requests/labels/Ready%20To%20Merge"
},
{
"color": "207de5",
"default": false,
"description... | closed | true | null | [] | null | 3 | 2013-12-28T07:47:48Z | 2021-09-08T11:00:51Z | 2014-01-08T18:48:25Z | CONTRIBUTOR | resolved | Also fixes up tense in a few cases, and adds the `intersphinx` extension so we
can link to the urllib3 documentation when it is called out.
I should probably write documentation for how to do this somewhere as well...
| {
"avatar_url": "https://avatars.githubusercontent.com/u/119893?v=4",
"events_url": "https://api.github.com/users/kennethreitz/events{/privacy}",
"followers_url": "https://api.github.com/users/kennethreitz/followers",
"following_url": "https://api.github.com/users/kennethreitz/following{/other_user}",
"gists_url": "https://api.github.com/users/kennethreitz/gists{/gist_id}",
"gravatar_id": "",
"html_url": "https://github.com/kennethreitz",
"id": 119893,
"login": "kennethreitz",
"node_id": "MDQ6VXNlcjExOTg5Mw==",
"organizations_url": "https://api.github.com/users/kennethreitz/orgs",
"received_events_url": "https://api.github.com/users/kennethreitz/received_events",
"repos_url": "https://api.github.com/users/kennethreitz/repos",
"site_admin": false,
"starred_url": "https://api.github.com/users/kennethreitz/starred{/owner}{/repo}",
"subscriptions_url": "https://api.github.com/users/kennethreitz/subscriptions",
"type": "User",
"url": "https://api.github.com/users/kennethreitz",
"user_view_type": "public"
} | {
"+1": 0,
"-1": 0,
"confused": 0,
"eyes": 0,
"heart": 0,
"hooray": 0,
"laugh": 0,
"rocket": 0,
"total_count": 0,
"url": "https://api.github.com/repos/psf/requests/issues/1831/reactions"
} | https://api.github.com/repos/psf/requests/issues/1831/timeline | null | null | false | {
"diff_url": "https://github.com/psf/requests/pull/1831.diff",
"html_url": "https://github.com/psf/requests/pull/1831",
"merged_at": "2014-01-08T18:48:25Z",
"patch_url": "https://github.com/psf/requests/pull/1831.patch",
"url": "https://api.github.com/repos/psf/requests/pulls/1831"
} | true | [
"This in principle looks fine, though I don't know about about intersphinx to be sure. =) Let's see what @sigmavirus24 thinks.\n",
"FWIW I wrote up docs on how to do this here:\n\nhttp://kev.inburke.com/kevin/sphinx-interlinks/\n",
"Nice dude! Hook up all the intersphinx you want!\n\nOne thing to note — it shou... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.