repo stringclasses 1
value | instance_id stringlengths 22 24 | problem_statement stringlengths 30 24.1k | patch stringlengths 0 1.9M | test_patch stringclasses 1
value | created_at stringdate 2022-11-25 05:12:07 2025-06-13 10:24:29 | hints_text stringlengths 0 228k | base_commit stringlengths 40 40 | test_instructions stringlengths 0 232k | filenames listlengths 0 300 |
|---|---|---|---|---|---|---|---|---|---|
juspay/hyperswitch | juspay__hyperswitch-3818 | Bug: [FEATURE] : [Fiserv] mask pii information in connector request and response
### Feature Description
Mask pii information passed and received in the connector request and response
### Possible Implementation
Refactor all sensitive response and request fields secret
### Have you spent some time checking if t... | diff --git a/crates/router/src/connector/fiserv/transformers.rs b/crates/router/src/connector/fiserv/transformers.rs
index e2511dc8d56..b8dd3c9643f 100644
--- a/crates/router/src/connector/fiserv/transformers.rs
+++ b/crates/router/src/connector/fiserv/transformers.rs
@@ -62,8 +62,8 @@ pub enum Source {
},
#[... | 2024-02-26T09:58:16Z |
## Description
<!-- Describe your changes in detail -->
Mask pii information passed and received in the connector request and response for Fiserv.
## Test case
1. Create a card payment with fiserv
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'A... | 75c633fc7c37341177597041ccbcdfc3cf9e236f | [
"crates/router/src/connector/fiserv/transformers.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-3816 | Bug: [Analytics] - Add error_reason field in clickhouse column
| diff --git a/crates/analytics/docs/clickhouse/cluster_setup/scripts/dispute_analytics.sql b/crates/analytics/docs/clickhouse/cluster_setup/scripts/dispute_analytics.sql
deleted file mode 100644
index 92a748ff489..00000000000
--- a/crates/analytics/docs/clickhouse/cluster_setup/scripts/dispute_analytics.sql
+++ /dev/nul... | 2024-02-26T07:09:51Z |
## Description
<!-- Adding new fields in Kafka struct for analytics usecase -->
This PR adds more fields which we would want to send to Kafka for various usecases of search and analytics from attempts table in PSQL
Fields which have been added are
```
payment_method_data,
error_reason,
multiple_capture_count,... | f4d0e2b441a25048186be4b9d0871e2473a6f357 |
Curl
```curl
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: key' \
--data-raw '{
"amount": 60,
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"capture_on": "2022-09-10T10:... | [
"crates/analytics/docs/clickhouse/cluster_setup/scripts/dispute_analytics.sql",
"crates/analytics/docs/clickhouse/scripts/api_events.sql",
"crates/analytics/docs/clickhouse/scripts/payment_attempts.sql",
"crates/router/src/services/kafka/payment_attempt.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3867 | Bug: [Analytics]/[Dispute] Create API's endpoints for disputes analytics
These are the metrics needed
- Number of disputes
- disputes challenged
- disputes won
- disputes lost
- Total amount disputed
- Total dispute lost amount
## Filters
## Group By Dimensions | diff --git a/crates/analytics/src/clickhouse.rs b/crates/analytics/src/clickhouse.rs
index fed029f2edb..6ebac7c1d92 100644
--- a/crates/analytics/src/clickhouse.rs
+++ b/crates/analytics/src/clickhouse.rs
@@ -23,7 +23,7 @@ use crate::{
metrics::{latency::LatencyAvg, ApiEventMetricRow},
},
connector_e... | 2024-02-25T16:55:50Z |
## Description
adding metric api for dispute analytics
Http Method: ```POST```
URL Path ```/analytics/v1/metric/dispute```
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd re... | 8b32dffe324a4cdbfde173cffe3fad2e839a52aa |
Hit the URL given below and should get sample response mentioned in the comment
| [
"crates/analytics/src/clickhouse.rs",
"crates/analytics/src/disputes.rs",
"crates/analytics/src/disputes/accumulators.rs",
"crates/analytics/src/disputes/core.rs",
"crates/analytics/src/disputes/metrics.rs",
"crates/analytics/src/disputes/metrics/dispute_status_metric.rs",
"crates/analytics/src/disputes... | |
juspay/hyperswitch | juspay__hyperswitch-3806 | Bug: [BUG] collections fail to import if variable is not a string
Newman runner i.e., newman-dir does support dynamic values but only string variables and not other variables say integer. Hence, variables like `"{{value}}"` is the only way for you to export the collection json file to its directory structure and hav... | diff --git a/Cargo.lock b/Cargo.lock
index 2c9293c1701..7823e917ed5 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -4977,14 +4977,14 @@ dependencies = [
[[package]]
name = "regex"
-version = "1.9.6"
+version = "1.10.3"
source = "registry+https://github.com/rust-lang/crates.io-index"
-checksum = "ebee201405406dbf528b8... | 2024-02-24T17:47:27Z |
## Description
<!-- Describe your changes in detail -->
This PR refactors test_utils crate's `newman_runner` to support dynamic values through postman variables.
The main issue with `newman-dir` is that in order to export the collection, the variables must be of type string (Example: Variable value must be of t... | 6b078fa339b5404f7c730322bc8597cd1104ec15 |
In #3805, the tests ran without any issues. Adding the screenshot below:
<img width="485" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/7c925fb8-b6b0-4eac-9657-ee3c181c6b70">
Yet another validation: https://github.com/juspay/hyperswitch/actions/runs/8092287211/job/22112758729?pr=3807 ... | [
"Cargo.lock",
"crates/test_utils/Cargo.toml",
"crates/test_utils/src/main.rs",
"crates/test_utils/src/newman_runner.rs",
"postman/collection-dir/aci/Health check/New Request/request.json",
"postman/collection-dir/adyen_uk/Health check/New Request/request.json",
"postman/collection-dir/airwallex/Health c... | |
juspay/hyperswitch | juspay__hyperswitch-3734 | Bug: [CI] Update NMI postman collection
Existing NMI postman collection is outdated and needs to be updated to the latest one look after regressions | 2024-02-24T17:21:42Z |
## Description
<!-- Describe your changes in detail -->
This PR aims at refactoring NMI collection by bringing it back to life. Added more flows to look after regressions.
Closes #3734
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please ... | 734327a957c216511b182151a2f0b27819e7e3bb |
Ran the collection:
<img width="980" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/9aaad0eb-a4d7-4735-9d8c-303d323fc915">
There is a bug in NMI connector which needs to be addressed.
Created a separate collection to reproduce it.
| [] | ||
juspay/hyperswitch | juspay__hyperswitch-3783 | Bug: [FEATURE] [BOA/Cybersource] Pass commerce indicator using card network for apple pay
### Feature Description
Apple pay transactions via BOA and Cybersource require a specific field `commerce_indicator` which is based on the card network type used during apple pay transactions.
https://docs.cybersource.com/con... | diff --git a/crates/router/src/connector/bankofamerica/transformers.rs b/crates/router/src/connector/bankofamerica/transformers.rs
index 235321f1ac6..0be25b078bc 100644
--- a/crates/router/src/connector/bankofamerica/transformers.rs
+++ b/crates/router/src/connector/bankofamerica/transformers.rs
@@ -330,21 +330,34 @@ i... | 2024-02-23T08:05:13Z |
## Description
<!-- Describe your changes in detail -->
Apple pay transactions via BOA and Cybersource require a specific field `commerce_indicator` which is based on the card network type used during apple pay transactions.
https://docs.cybersource.com/content/dam/documentation/en/apple-pay/fdiglobal/so/applepay-s... | 21d2b6ee2cacecc6da3a3c8ef07dedfb417752b0 |
Apple pay payments need to be tested using simplified and manual flow for connectors BOA and Cybersource.
| [
"crates/router/src/connector/bankofamerica/transformers.rs",
"crates/router/src/connector/checkout/transformers.rs",
"crates/router/src/connector/cybersource/transformers.rs",
"crates/router/src/connector/stripe/transformers.rs",
"crates/router/src/connector/utils.rs",
"crates/router/src/core/payments.rs"... | |
juspay/hyperswitch | juspay__hyperswitch-3793 | Bug: feat: add blacklist for roles
After a role is updated, the users who are using that role at that time should get new tokens. So, the role should be blacklisted.
| diff --git a/crates/router/src/consts.rs b/crates/router/src/consts.rs
index 3c3f01dc5f9..72f160990e5 100644
--- a/crates/router/src/consts.rs
+++ b/crates/router/src/consts.rs
@@ -70,6 +70,8 @@ pub const JWT_TOKEN_TIME_IN_SECS: u64 = 60 * 60 * 24 * 2; // 2 days
pub const USER_BLACKLIST_PREFIX: &str = "BU_";
+pub ... | 2024-02-23T07:21:31Z |
## Description
<!-- Describe your changes in detail -->
This PR adds ability to blacklist roles to stop JWTs after a role is changed.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue,... | 21d2b6ee2cacecc6da3a3c8ef07dedfb417752b0 |
Postman.
To get JWT of admin, you have to singup/create a new account. Or you can use a JWT of org_admin user.
1. Create a role
```
curl --location 'http://localhost:8080/user/role' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer JWT of Admin' \
--data '{
"role_name": "cu... | [
"crates/router/src/consts.rs",
"crates/router/src/core/user_role/role.rs",
"crates/router/src/services/authentication.rs",
"crates/router/src/services/authentication/blacklist.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3740 | Bug: Customer Payment Method List updates for MIT payments
Since we are deprecating Mandates for unscheduled MIT use cases, the customer payment method list will undergo the following changes:
- List only PMs that are in active state
- Add auth support for Ephemeral Key
- Default PM to be communicated in Custom... | diff --git a/config/development.toml b/config/development.toml
index d69719bd419..59d73a4b8b2 100644
--- a/config/development.toml
+++ b/config/development.toml
@@ -71,7 +71,6 @@ mock_locker = true
basilisk_host = ""
locker_enabled = true
-
[forex_api]
call_delay = 21600
local_fetch_retry_count = 5
diff --git a/... | 2024-02-23T04:00:53Z |
## Description
- Add default payment method column in customers table and last used column in payment_methods table.
- Last used would be updated depending on every payment_method usages.
- And the CustomerPaymentMethodList would be sorted on the basis of last_used at.
- A query param was added , to show the lis... | f4d0e2b441a25048186be4b9d0871e2473a6f357 | To test `set_default_payment_method`
- Create an MA and and MCA
- Create an ApiKey and EphemeralKey for that particular customer
- Make a payment , using one card and then do a ListCustomerPaymentMethods
- > Create
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json... | [
"config/development.toml",
"crates/api_models/src/customers.rs",
"crates/api_models/src/events/payment.rs",
"crates/api_models/src/payment_methods.rs",
"crates/diesel_models/src/customers.rs",
"crates/diesel_models/src/payment_method.rs",
"crates/diesel_models/src/query/payment_method.rs",
"crates/die... | |
juspay/hyperswitch | juspay__hyperswitch-3739 | Bug: Support Default Payment Method for customer
Add support for having a default payment method option for a customer. This can be used to increase conversion rates by using the preferred saved payment method for payments, reducing the friction.
Solution:
- Customers table to have a column for 'default_payment_... | diff --git a/config/development.toml b/config/development.toml
index d69719bd419..59d73a4b8b2 100644
--- a/config/development.toml
+++ b/config/development.toml
@@ -71,7 +71,6 @@ mock_locker = true
basilisk_host = ""
locker_enabled = true
-
[forex_api]
call_delay = 21600
local_fetch_retry_count = 5
diff --git a/... | 2024-02-23T04:00:53Z |
## Description
- Add default payment method column in customers table and last used column in payment_methods table.
- Last used would be updated depending on every payment_method usages.
- And the CustomerPaymentMethodList would be sorted on the basis of last_used at.
- A query param was added , to show the lis... | f4d0e2b441a25048186be4b9d0871e2473a6f357 | To test `set_default_payment_method`
- Create an MA and and MCA
- Create an ApiKey and EphemeralKey for that particular customer
- Make a payment , using one card and then do a ListCustomerPaymentMethods
- > Create
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json... | [
"config/development.toml",
"crates/api_models/src/customers.rs",
"crates/api_models/src/events/payment.rs",
"crates/api_models/src/payment_methods.rs",
"crates/diesel_models/src/customers.rs",
"crates/diesel_models/src/payment_method.rs",
"crates/diesel_models/src/query/payment_method.rs",
"crates/die... | |
juspay/hyperswitch | juspay__hyperswitch-3785 | Bug: [FEATURE] : [Cybersource] mask pii information in connector request and response
### Feature Description
Mask pii information passed and received in the connector request and response
### Possible Implementation
Refactor all sensitive response and request fields secret
### Have you spent some time checking... | diff --git a/crates/router/src/connector/cybersource/transformers.rs b/crates/router/src/connector/cybersource/transformers.rs
index 4bb28439b7f..14f8b2a7f99 100644
--- a/crates/router/src/connector/cybersource/transformers.rs
+++ b/crates/router/src/connector/cybersource/transformers.rs
@@ -2,7 +2,7 @@ use api_models:... | 2024-02-22T12:14:42Z |
## Description
<!-- Describe your changes in detail -->
Mask pii information passed and received in the connector request and response for Cybersource.
## Test Case
1.a. Create a 3DS payment
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: a... | 75c633fc7c37341177597041ccbcdfc3cf9e236f | [
"crates/router/src/connector/cybersource/transformers.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-3972 | Bug: [FIX] add doc for merchant KV flip
| diff --git a/crates/openapi/src/openapi.rs b/crates/openapi/src/openapi.rs
index dc38181a683..cb41c8eb05c 100644
--- a/crates/openapi/src/openapi.rs
+++ b/crates/openapi/src/openapi.rs
@@ -90,6 +90,7 @@ Never share your secret api keys. Keep them guarded and secure.
routes::merchant_account::retrieve_merchant_... | 2024-02-22T11:57:57Z |
## Description
<!-- Describe your changes in detail -->
Added API reference for enabling/disabling KV for a merchant
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend st... | bbb3d3d1e26f303964a495606dece7958f6c40fc |
NA
| [
"crates/openapi/src/openapi.rs",
"crates/openapi/src/routes/merchant_account.rs",
"openapi/openapi_spec.json"
] | |
juspay/hyperswitch | juspay__hyperswitch-3772 | Bug: [FEATURE] : [Checkout] mask pii information in connector request and response
### Feature Description
Mask pii information passed and received in the connector request and response
### Possible Implementation
Refactor all sensitive response and request fields secret
### Have you spent some time checking if... | diff --git a/crates/router/src/connector/checkout/transformers.rs b/crates/router/src/connector/checkout/transformers.rs
index f96bd50ffc8..591e1aa31c7 100644
--- a/crates/router/src/connector/checkout/transformers.rs
+++ b/crates/router/src/connector/checkout/transformers.rs
@@ -188,7 +188,7 @@ pub struct CardSource {... | 2024-02-22T10:22:34Z |
## Description
<!-- Describe your changes in detail -->
Mask pii information passed and received in the connector request and response for Checkout.
## Test cases
1. Create a payment with Apple pay
2. Create a payment with Google pay
Generate Google pay token from: https://jsfiddle.net/1agu74ve/
`'gatewa... | d000847b938952de6ff9c2e01bdd06b4ede60e69 | [
"crates/router/src/connector/checkout/transformers.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-3754 | Bug: DB Updates for Payment Methods Table
| diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs
index c3976321f0a..29c416e9a85 100644
--- a/crates/common_enums/src/enums.rs
+++ b/crates/common_enums/src/enums.rs
@@ -1177,6 +1177,32 @@ pub enum PaymentMethodIssuerCode {
JpBacs,
}
+#[derive(
+ Clone,
+ Copy,
+ Debug,
+... | 2024-02-22T07:25:32Z |
## Description
<!-- Describe your changes in detail -->
This PR adds 3 columns to the `payment_methods` table, with the purpose of enabling MIT Transaction Orchestration in the near future.
- `connector_mandate_details`: Intended to store Connector MIT details such as the mandate ID
- `customer_acceptance`: Intend... | 385622678f764b2bdb67423be0e5c8f055dd0b7c |
Local testing, postman tests. The saved card payments flow needs to work as usual which is covered by Postman tests.
When saving a card, the values of the added columns are set to default for now. This is NULL for `connector_mandate_details` and `customer_acceptance`, and `active` for `status`.
<img width="420" a... | [
"crates/common_enums/src/enums.rs",
"crates/diesel_models/src/payment_method.rs",
"crates/diesel_models/src/query/payment_method.rs",
"crates/diesel_models/src/schema.rs",
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/db/kafka_store.rs",
"crates/router/src/db/payment_method.rs",
... | |
juspay/hyperswitch | juspay__hyperswitch-3781 | Bug: create api for custom roles
Create apis for
- create custom role
- update custom role | diff --git a/crates/api_models/src/events/user_role.rs b/crates/api_models/src/events/user_role.rs
index 2b8d0221497..f19ff95f9ed 100644
--- a/crates/api_models/src/events/user_role.rs
+++ b/crates/api_models/src/events/user_role.rs
@@ -1,8 +1,11 @@
use common_utils::events::{ApiEventMetric, ApiEventsType};
use cra... | 2024-02-21T21:19:02Z |
## Description
Add functionality for
- create role api
- update role api
## Motivation and Context
User should be allowed to create/update custom roles.
# | bbb3d3d1e26f303964a495606dece7958f6c40fc | Create role
```
curl --location --request PUT 'http://localhost:8080/user/role' \
--header 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiOGJiZGM4YWUtZDlhYS00NGUxLWFkYzYtYjEyMjZiYjkxZDliIiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNzA4NjAxMTE3Iiwicm9sZV9pZCI6Im9yZ19hZG1pbiIsImV4cCI6MTcwODc3MzkxNy... | [
"crates/api_models/src/events/user_role.rs",
"crates/api_models/src/user_role.rs",
"crates/api_models/src/user_role/role.rs",
"crates/diesel_models/src/role.rs",
"crates/router/src/consts/user_role.rs",
"crates/router/src/core/errors/user.rs",
"crates/router/src/core/user_role.rs",
"crates/router/src/... | |
juspay/hyperswitch | juspay__hyperswitch-3761 | Bug: [BUG] Internal Server Error thrown when updating or deleting non-existent API key
### Bug Description
When a user tries to update or delete a non-existent API key, an internal server error is thrown. The expected behavior is that the server returns a 404 status code, informing that the API key does not exist... | diff --git a/crates/storage_impl/src/errors.rs b/crates/storage_impl/src/errors.rs
index 14d1eb2db63..9e3ef903f5c 100644
--- a/crates/storage_impl/src/errors.rs
+++ b/crates/storage_impl/src/errors.rs
@@ -139,6 +139,7 @@ impl StorageError {
pub fn is_db_not_found(&self) -> bool {
match self {
... | 2024-02-21T20:35:44Z |
## Description
<!-- Describe your changes in detail -->
This PR fixes a bug with the update API key and delete API key endpoints throwing an internal server error when a non-existent API key was provided.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an ope... | ef5e886ab1abdf50254343be8c6c48100ec2ec2d |
Locally. Trying to either update a non-existent API key returns a 404 status code, with an error message stating that the API key does not exist.
1. Update API key (request body may contain data or could just be an empty object):
```shell
curl --location 'http://localhost:8080/api_keys/<merchant_id>/i... | [
"crates/storage_impl/src/errors.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3813 | Bug: Update Hyperswitch Token construction to include MIT details
- To begin with we will store Payment Method ID along with the Locker ID in the token instead | diff --git a/crates/diesel_models/src/payment_method.rs b/crates/diesel_models/src/payment_method.rs
index d8b46c1932e..f9767e2939b 100644
--- a/crates/diesel_models/src/payment_method.rs
+++ b/crates/diesel_models/src/payment_method.rs
@@ -33,6 +33,7 @@ pub struct PaymentMethod {
pub payment_method_issuer_code: O... | 2024-02-21T17:18:08Z |
## Description
<!-- Describe your changes in detail -->
Currently we are mapping `locker_id` from locker to `payment_method_id` in Hyperswitch. This refactor involves changes to store the locker id in the `locker_id` column as opposed to the `payment_method_id` column, and store a unique ID in place of the `payment_... | 75c633fc7c37341177597041ccbcdfc3cf9e236f |
Sandbox testing -
* Should be tested similar to https://github.com/juspay/hyperswitch/pull/3146
* Test it for both old card already saved before this PR went in along with new card
* Both `/payment_methods` and `/payment` card flow has to be tested with metadata changes too. Everything should work fine
Test ca... | [
"crates/diesel_models/src/payment_method.rs",
"crates/diesel_models/src/query/payment_method.rs",
"crates/diesel_models/src/schema.rs",
"crates/router/src/core/customers.rs",
"crates/router/src/core/locker_migration.rs",
"crates/router/src/core/payment_methods.rs",
"crates/router/src/core/payment_method... | |
juspay/hyperswitch | juspay__hyperswitch-3742 | Bug: Locker ID as a soft link for Payment Methods
Decoupling the Payment Method ID and Locker ID to allow more flexibility in PM ID usage for other features/components
- Add Card operation to save the Locker ID in the `locker_id` column of the PM table and generate and add a separate PM ID
- During retrieve, loc... | diff --git a/crates/diesel_models/src/payment_method.rs b/crates/diesel_models/src/payment_method.rs
index d8b46c1932e..f9767e2939b 100644
--- a/crates/diesel_models/src/payment_method.rs
+++ b/crates/diesel_models/src/payment_method.rs
@@ -33,6 +33,7 @@ pub struct PaymentMethod {
pub payment_method_issuer_code: O... | 2024-02-21T17:18:08Z |
## Description
<!-- Describe your changes in detail -->
Currently we are mapping `locker_id` from locker to `payment_method_id` in Hyperswitch. This refactor involves changes to store the locker id in the `locker_id` column as opposed to the `payment_method_id` column, and store a unique ID in place of the `payment_... | 75c633fc7c37341177597041ccbcdfc3cf9e236f |
Sandbox testing -
* Should be tested similar to https://github.com/juspay/hyperswitch/pull/3146
* Test it for both old card already saved before this PR went in along with new card
* Both `/payment_methods` and `/payment` card flow has to be tested with metadata changes too. Everything should work fine
Test ca... | [
"crates/diesel_models/src/payment_method.rs",
"crates/diesel_models/src/query/payment_method.rs",
"crates/diesel_models/src/schema.rs",
"crates/router/src/core/customers.rs",
"crates/router/src/core/locker_migration.rs",
"crates/router/src/core/payment_methods.rs",
"crates/router/src/core/payment_method... | |
juspay/hyperswitch | juspay__hyperswitch-3731 | Bug: [REFACTOR] introduce `locker_id` column in payment_methods table
Currently we are mapping `locker_id` from locker to `payment_method_id` in Hyperswitch. This refactor involves changes to store the locker id in the `locker_id` column as opposed to the `payment_method_id` column, and store a unique ID in place of... | diff --git a/crates/diesel_models/src/payment_method.rs b/crates/diesel_models/src/payment_method.rs
index d8b46c1932e..f9767e2939b 100644
--- a/crates/diesel_models/src/payment_method.rs
+++ b/crates/diesel_models/src/payment_method.rs
@@ -33,6 +33,7 @@ pub struct PaymentMethod {
pub payment_method_issuer_code: O... | 2024-02-21T17:18:08Z |
## Description
<!-- Describe your changes in detail -->
Currently we are mapping `locker_id` from locker to `payment_method_id` in Hyperswitch. This refactor involves changes to store the locker id in the `locker_id` column as opposed to the `payment_method_id` column, and store a unique ID in place of the `payment_... | 75c633fc7c37341177597041ccbcdfc3cf9e236f |
Sandbox testing -
* Should be tested similar to https://github.com/juspay/hyperswitch/pull/3146
* Test it for both old card already saved before this PR went in along with new card
* Both `/payment_methods` and `/payment` card flow has to be tested with metadata changes too. Everything should work fine
Test ca... | [
"crates/diesel_models/src/payment_method.rs",
"crates/diesel_models/src/query/payment_method.rs",
"crates/diesel_models/src/schema.rs",
"crates/router/src/core/customers.rs",
"crates/router/src/core/locker_migration.rs",
"crates/router/src/core/payment_methods.rs",
"crates/router/src/core/payment_method... | |
juspay/hyperswitch | juspay__hyperswitch-3778 | Bug: [FEATURE] : [Braintree] mask pii information in connector request and response
### Feature Description
Mask pii information passed and received in the connector request and response
### Possible Implementation
Refactor all sensitive response and request fields secret
### Have you spent some time checking i... | diff --git a/crates/router/src/connector/braintree/braintree_graphql_transformers.rs b/crates/router/src/connector/braintree/braintree_graphql_transformers.rs
index 436cd8dfa36..190cd276572 100644
--- a/crates/router/src/connector/braintree/braintree_graphql_transformers.rs
+++ b/crates/router/src/connector/braintree/b... | 2024-02-21T15:12:03Z |
## Description
<!-- Describe your changes in detail -->
Mask pii information passed and received in the connector request and response for Braintree.
## Test Case
Check if sensitive fields within connector request and response is masked in the click house for Braintree
Test for both graphQL and the normal versi... | ef5e886ab1abdf50254343be8c6c48100ec2ec2d | [
"crates/router/src/connector/braintree/braintree_graphql_transformers.rs",
"crates/router/src/connector/braintree/transformers.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-3610 | Bug: [FEATURE] Update Payment Connector Create to incorporate recipient creation
### Feature Description
In Open banking payments, some connector offer a recipient creation flow, where a `recipient_id` can be created against merchant's bank account data. The `recipient_id` can be stored in the DB.
Alternatively, ... | diff --git a/config/config.example.toml b/config/config.example.toml
index 9b855b1e956..5b4c1bbd762 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -698,3 +698,6 @@ public = { name = "hyperswitch", base_url = "http://localhost:8080", schema = "p
[user_auth_methods]
encryption_key = "" # ... | 2024-02-21T14:45:22Z |
## Description
<!-- Describe your changes in detail -->
- Added connector call in payment connector create to facilitate merchant recipient creation at connector end.
- Added alternative locker call for creation of recipient at Hyperswitch's end in case the connector does not support it.
- Added validation for mer... | 43741df4a76a66faa472dacd66b396232a2fbdbf |
1. Create an MCA account with `connector_type` as `payment_processor` and an open banking connector
```
curl --location --request POST 'http://localhost:8080/account/merchant_1720607250/connectors' \
--header 'api-key: test_admin' \
--header 'Content-Type: application/json' \
--data-raw '{
"connector_type":... | [
"config/config.example.toml",
"config/deployments/integration_test.toml",
"config/deployments/production.toml",
"config/deployments/sandbox.toml",
"config/development.toml",
"config/docker_compose.toml",
"crates/api_models/src/admin.rs",
"crates/common_enums/src/enums.rs",
"crates/diesel_models/src/... | |
juspay/hyperswitch | juspay__hyperswitch-3756 | Bug: fix(invite): set user status to invitation sent if a registered user is invited
| diff --git a/crates/router/src/core/user.rs b/crates/router/src/core/user.rs
index 54fbecc64f3..96753236c1c 100644
--- a/crates/router/src/core/user.rs
+++ b/crates/router/src/core/user.rs
@@ -666,7 +666,13 @@ async fn handle_existing_user_invitation(
merchant_id: user_from_token.merchant_id.clone(),
... | 2024-02-21T13:40:29Z |
## Description
<!-- Describe your changes in detail -->
This PR will set the status of the user who has been invited but already registered with Hyperswitch as InvitationSent
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the... | 7c63c76011cec5fb398cff90b6237578c132b87d |
Local SES.
```
curl --location 'http://localhost:8080/user/user/invite_multiple \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer JWT' \
--data-raw '{
"email": "email of the registered user“,
"name": "name",
"role_id": "some valid role"
}
```
```
curl --location 'ht... | [
"crates/router/src/core/user.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3733 | Bug: [FIX] Add update mandate config in docker-compose file
### Feature Description
Add update mandate config in docker-compose file
### Possible Implementation
Add update mandate config in docker-compose file
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked ... | diff --git a/config/docker_compose.toml b/config/docker_compose.toml
index 3f7c64624fa..8170132bb85 100644
--- a/config/docker_compose.toml
+++ b/config/docker_compose.toml
@@ -359,6 +359,9 @@ bank_redirect.ideal = {connector_list = "stripe,adyen,globalpay"}
bank_redirect.sofort = {connector_list = "stripe,adyen,globa... | 2024-02-20T17:07:37Z |
## Description
add update mandate config in docker_compose.toml file
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on ... | 6aeb44091b34f202b60868028979b3720e3507ce | Cannot test this PR as this is just a config addition
| [
"config/docker_compose.toml"
] | |
juspay/hyperswitch | juspay__hyperswitch-3729 | Bug: refactor: remove permissions from files and forex apis
| diff --git a/crates/api_models/src/user_role.rs b/crates/api_models/src/user_role.rs
index 78df1d6823e..215227b91a3 100644
--- a/crates/api_models/src/user_role.rs
+++ b/crates/api_models/src/user_role.rs
@@ -29,7 +29,6 @@ pub enum Permission {
MerchantAccountWrite,
MerchantConnectorAccountRead,
Merchant... | 2024-02-20T13:56:27Z |
## Description
<!-- Describe your changes in detail -->
This PR will remove permissions for Files and Forex apis.
It also adds `find_role_by_role_id_in_merchant_scope` db function.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link t... | cf3c66636ffee30cdd4353b276a89a8f9fc2d9d0 |
Postman.
- Files - Read (`/files` POST)
```
curl --location 'http://localhost:8080/files' \
--header 'Accept: application/json' \
--header 'Authorization: Bearer {{user_token}}' \
--form 'purpose="dispute_evidence"' \
--form 'file=@"/Users/mani.dchandra/Pictures/sample.pdf"' \
--form 'dispute_id="{{dis... | [
"crates/api_models/src/user_role.rs",
"crates/common_enums/src/enums.rs",
"crates/diesel_models/src/enums.rs",
"crates/diesel_models/src/query/role.rs",
"crates/router/src/core/user.rs",
"crates/router/src/core/user/dashboard_metadata.rs",
"crates/router/src/core/user_role.rs",
"crates/router/src/db/k... | |
juspay/hyperswitch | juspay__hyperswitch-3726 | Bug: [FEATURE]: [Adyen] populate connector_transaction_id for Adyen Payment Response
### :memo: Feature Description
- populate connector_transaction_id for Adyen Payment Response
### :package: Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't find ... | diff --git a/crates/router/src/connector/adyen/transformers.rs b/crates/router/src/connector/adyen/transformers.rs
index 072b542eee0..d8213e2db98 100644
--- a/crates/router/src/connector/adyen/transformers.rs
+++ b/crates/router/src/connector/adyen/transformers.rs
@@ -3159,9 +3159,11 @@ pub fn get_redirection_response(... | 2024-02-20T13:26:34Z |
## Description
<!-- Describe your changes in detail -->
populate connector_transaction_id for Adyen Payment Response - (RedirectionResponse and QrCodeResponseResponse)
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue he... | cf3c66636ffee30cdd4353b276a89a8f9fc2d9d0 | PIx via Adyen request - (it uses QrCodeResponseResponse)
```
{
"amount": 5000,
"currency": "BRL",
"confirm": true,
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"amount_to_capture": 5000,
"customer_id": "StripeCustomer",
"email": "abcdef123@gmail.com",
... | [
"crates/router/src/connector/adyen/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3725 | Bug: Feat(analytics): dispute filter api
| diff --git a/crates/analytics/src/clickhouse.rs b/crates/analytics/src/clickhouse.rs
index ead3b1699ec..fed029f2edb 100644
--- a/crates/analytics/src/clickhouse.rs
+++ b/crates/analytics/src/clickhouse.rs
@@ -23,6 +23,7 @@ use crate::{
metrics::{latency::LatencyAvg, ApiEventMetricRow},
},
connector_e... | 2024-02-20T10:56:43Z |
## Description
added filter api for dispute analytics
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementat... | cf3c66636ffee30cdd4353b276a89a8f9fc2d9d0 | Hit the curl mentioned in the comment below.
response should be the distinct value of dispute dimension given in request
To get the dispute dimensions hit dispute info api follow the link below
https://github.com/juspay/hyperswitch/pull/3693
| [
"crates/analytics/src/clickhouse.rs",
"crates/analytics/src/disputes.rs",
"crates/analytics/src/disputes/core.rs",
"crates/analytics/src/disputes/filters.rs",
"crates/analytics/src/lib.rs",
"crates/analytics/src/query.rs",
"crates/analytics/src/sqlx.rs",
"crates/api_models/src/analytics.rs",
"crates... | |
juspay/hyperswitch | juspay__hyperswitch-3717 | Bug: feat: change role apis to support custom roles
| diff --git a/crates/api_models/src/user_role.rs b/crates/api_models/src/user_role.rs
index 215227b91a3..1c4c28aa993 100644
--- a/crates/api_models/src/user_role.rs
+++ b/crates/api_models/src/user_role.rs
@@ -1,3 +1,4 @@
+use common_enums::RoleScope;
use common_utils::pii;
use crate::user::DashboardEntryResponse;
@... | 2024-02-20T08:57:15Z |
## Description
<!-- Describe your changes in detail -->
This PR will add checks in authorization to check for custom roles.
This PR also add custom roles functionality to apis which were dealing with roles.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an... | 4ae28e48cd73a9f96b6ae24babf167824fd182a0 |
### Roles
| Group | Org Admin | Merchant Admin | Merchant View Only | Merchant IAM Admin | Merchant Developer | Merchant Operator | Merchant Customer Support |
| ---- | ---- | ---- | ---- | ---- | ---- | ---- | ---- |
| Operations View | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
| Oper... | [
"crates/api_models/src/user_role.rs",
"crates/router/src/analytics.rs",
"crates/router/src/core/user.rs",
"crates/router/src/core/user_role.rs",
"crates/router/src/routes/user.rs",
"crates/router/src/routes/user_role.rs",
"crates/router/src/services/authentication.rs",
"crates/router/src/services/auth... | |
juspay/hyperswitch | juspay__hyperswitch-3718 | Bug: feat: integrate custom roles with authz
| diff --git a/crates/api_models/src/user_role.rs b/crates/api_models/src/user_role.rs
index 215227b91a3..1c4c28aa993 100644
--- a/crates/api_models/src/user_role.rs
+++ b/crates/api_models/src/user_role.rs
@@ -1,3 +1,4 @@
+use common_enums::RoleScope;
use common_utils::pii;
use crate::user::DashboardEntryResponse;
@... | 2024-02-20T08:57:15Z |
## Description
<!-- Describe your changes in detail -->
This PR will add checks in authorization to check for custom roles.
This PR also add custom roles functionality to apis which were dealing with roles.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an... | 4ae28e48cd73a9f96b6ae24babf167824fd182a0 |
### Roles
| Group | Org Admin | Merchant Admin | Merchant View Only | Merchant IAM Admin | Merchant Developer | Merchant Operator | Merchant Customer Support |
| ---- | ---- | ---- | ---- | ---- | ---- | ---- | ---- |
| Operations View | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ | ✓ |
| Oper... | [
"crates/api_models/src/user_role.rs",
"crates/router/src/analytics.rs",
"crates/router/src/core/user.rs",
"crates/router/src/core/user_role.rs",
"crates/router/src/routes/user.rs",
"crates/router/src/routes/user_role.rs",
"crates/router/src/services/authentication.rs",
"crates/router/src/services/auth... | |
juspay/hyperswitch | juspay__hyperswitch-3716 | Bug: [BUG] Payment status changes when capture method validation fails
### Bug Description
If a connector doesn't support a particular capture method, confirm call fails and payment status changes to processing.
### Expected Behavior
If a connector doesn't support a particular capture method, confirm call should ... | diff --git a/crates/router/src/core/payments/flows/authorize_flow.rs b/crates/router/src/core/payments/flows/authorize_flow.rs
index 7842678a92a..d7d122c3252 100644
--- a/crates/router/src/core/payments/flows/authorize_flow.rs
+++ b/crates/router/src/core/payments/flows/authorize_flow.rs
@@ -72,13 +72,6 @@ impl Feature... | 2024-02-20T07:43:54Z |
## Description
<!-- Describe your changes in detail -->
Currently capture method validation is done in `decide_flows`(after update_trackers). Because of this intent status changes to `processing`.
In this PR, I have validated capture method in `build_flow_specific_connector_request`(before udpate_trackers). Henc... | 073310c1f671ccbb71cc5c8725eca9771e511589 |
Manual
1. Create a merchant with stripe connector
2. Create a payment without payment_method_data and confirm: false and capture_method : manual_multiple.
<img width="1728" alt="Screenshot 2024-02-20 at 1 03 21 PM" src="https://github.com/juspay/hyperswitch/assets/61539176/78b52bb8-42a6-499d-b588-3d7dc9cdde3c">
... | [
"crates/router/src/core/payments/flows/authorize_flow.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3770 | Bug: [FEATURE] : [Bluesnap] mask pii information in connector request and response
### Feature Description
Mask pii information passed and received in the connector request and response
### Possible Implementation
Refactor all sensitive response and request fields secret
### Have you spent some time checking if ... | diff --git a/crates/router/src/connector/bluesnap/transformers.rs b/crates/router/src/connector/bluesnap/transformers.rs
index 63ca7750303..201ddc221fc 100644
--- a/crates/router/src/connector/bluesnap/transformers.rs
+++ b/crates/router/src/connector/bluesnap/transformers.rs
@@ -591,7 +591,7 @@ pub struct BluesnapComp... | 2024-02-20T06:20:23Z |
## Description
<!-- Describe your changes in detail -->
Mask pii information passed and received in the connector request and response for Bluesnap.
[Bluesnap Doc](https://developers.bluesnap.com/v8976-JSON/reference/bluesnap-payment-api-json)
## Test Case
Check if sensitive fields within connector request and ... | 5aae1798257b5ee0c5a62104e4711748cdb5f935 | [
"crates/router/src/connector/bluesnap/transformers.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-3711 | Bug: [REFACTOR] Refactor process tracker (scheduler) code to increase code reusability and improve logging
### Description
1. The process tracker (scheduler) code includes some amount of repetitive code, which can be extracted out to functions with suitable parameters to accommodate all usages. One such instance ... | diff --git a/crates/diesel_models/src/process_tracker.rs b/crates/diesel_models/src/process_tracker.rs
index 9e649279f24..76e280d6bc0 100644
--- a/crates/diesel_models/src/process_tracker.rs
+++ b/crates/diesel_models/src/process_tracker.rs
@@ -1,8 +1,10 @@
+use common_utils::ext_traits::Encode;
use diesel::{AsChanges... | 2024-02-19T19:59:37Z |
## Description
<!-- Describe your changes in detail -->
This PR contains changes to address the problems listed in #3711, namely:
1. Updates `ProcessTrackerExt::make_process_tracker_new()` method to accept a `tag` parameter in order to increase reusability.
2. Moves the `PTRunner` enum to the `diesel_models::pro... | fff780218ac356bb9b599896e766dd45266ac34a |
Most of the changes involve moving existing code around, which should not affect the functioning of the scheduler, which I've verified by confirming the correct functioning of the payment sync workflow: the workflow now successfully completes with a business status of `COMPLETED_BY_PT` (only) instead of also includin... | [
"crates/diesel_models/src/process_tracker.rs",
"crates/redis_interface/src/commands.rs",
"crates/router/src/bin/scheduler.rs",
"crates/router/src/configs/validations.rs",
"crates/router/src/core/api_keys.rs",
"crates/router/src/core/payment_methods/vault.rs",
"crates/router/src/core/payments.rs",
"cra... | |
juspay/hyperswitch | juspay__hyperswitch-3706 | Bug: feat(invite): Send email to user if user already exist
| diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs
index d7150af9bc7..ec3e2dce9b2 100644
--- a/crates/api_models/src/events/user.rs
+++ b/crates/api_models/src/events/user.rs
@@ -10,11 +10,12 @@ use crate::user::{
dashboard_metadata::{
GetMetaDataRequest, GetMetaDataR... | 2024-02-19T13:29:01Z |
## Description
<!-- Describe your changes in detail -->
This PR will send an email to the user if the user already exist
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recom... | deec8b4eb5493b072eaef0352a735748979cd95d | 1.
Request:
```
curl --location 'http://localhost:8080/user/user/invite_user \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer JWT of org_admin user' \
--data-raw '{
"email": "email of the user who already signed up“,
"name":"some name",
"role_id":"some valid role"... | [
"crates/api_models/src/events/user.rs",
"crates/api_models/src/user.rs",
"crates/router/src/core/user.rs",
"crates/router/src/routes/app.rs",
"crates/router/src/routes/lock_utils.rs",
"crates/router/src/routes/user.rs",
"crates/router/src/services/email/types.rs",
"crates/router_env/src/logger/types.r... | |
juspay/hyperswitch | juspay__hyperswitch-3870 | Bug: [FEATURE] : [Bitpay] mask pii information in connector request and response
### Feature Description
Mask pii information passed and received in the connector request and response
### Possible Implementation
Refactor all sensitive response and request fields secret
### Have you spent some time checking if ... | diff --git a/crates/router/src/connector/bitpay/transformers.rs b/crates/router/src/connector/bitpay/transformers.rs
index 148a5a45636..74fa0b5c595 100644
--- a/crates/router/src/connector/bitpay/transformers.rs
+++ b/crates/router/src/connector/bitpay/transformers.rs
@@ -140,8 +140,8 @@ pub struct BitpayPaymentRespons... | 2024-02-19T13:20:26Z |
## Description
<!-- Describe your changes in detail -->
Mask pii information passed and received in the connector request and response for Bitpay
## Test Case
Check if sensitive fields within connector request and response is masked in the click house for Bitpay
Sanity test
1. Payment create - card
```
c... | 76ac1a753a08f3ecc8ee264e4bccc47e8b219d1d | [
"crates/router/src/connector/bitpay/transformers.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-3769 | Bug: [FEATURE] : [BOA] mask pii information in connector request and response
### Feature Description
Mask pii information passed and received in the connector request and response
### Possible Implementation
Refactor all sensitive response and request fields secret
### Have you spent some time checking if this ... | diff --git a/crates/router/src/connector/bankofamerica.rs b/crates/router/src/connector/bankofamerica.rs
index 706532c5d18..fefc80f806c 100644
--- a/crates/router/src/connector/bankofamerica.rs
+++ b/crates/router/src/connector/bankofamerica.rs
@@ -1079,8 +1079,10 @@ impl ConnectorIntegration<api::Execute, types::Refun... | 2024-02-19T12:20:16Z |
## Description
<!-- Describe your changes in detail -->
Mask pii information passed and received in the connector request and response for BOA
## Test Case
Check if sensitive fields within connector request and response is masked in the click house for BOA
Sanity test
1. Payment create - card 3ds
```
cur... | cf3c66636ffee30cdd4353b276a89a8f9fc2d9d0 | [
"crates/router/src/connector/bankofamerica.rs",
"crates/router/src/connector/bankofamerica/transformers.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-3768 | Bug: [FEATURE] : [Bambora] mask pii information in connector request and response
### Feature Description
Mask pii information passed and received in the connector request and response
### Possible Implementation
Refactor all sensitive response and request fields secret
### Have you spent some time checking if ... | diff --git a/crates/router/src/connector/bambora.rs b/crates/router/src/connector/bambora.rs
index e2d9e18ce96..d453677deb6 100644
--- a/crates/router/src/connector/bambora.rs
+++ b/crates/router/src/connector/bambora.rs
@@ -228,8 +228,10 @@ impl ConnectorIntegration<api::Void, types::PaymentsCancelData, types::Payment... | 2024-02-19T08:53:46Z |
## Description
<!-- Describe your changes in detail -->
Mask pii information passed and received in the connector request and response for Bambora
## Test Case
Check if sensitive fields within connector request and response is masked in the click house for bambora
Sanity test
1. Payment create -
Card
``... | 073310c1f671ccbb71cc5c8725eca9771e511589 | [
"crates/router/src/connector/bambora.rs",
"crates/router/src/connector/bambora/transformers.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-3694 | Bug: feat(analytics): adding dispute as uri param to analytics info api
| diff --git a/crates/analytics/src/clickhouse.rs b/crates/analytics/src/clickhouse.rs
index 27d42350509..ead3b1699ec 100644
--- a/crates/analytics/src/clickhouse.rs
+++ b/crates/analytics/src/clickhouse.rs
@@ -130,7 +130,8 @@ impl AnalyticsDataSource for ClickhouseClient {
match table {
AnalyticsCo... | 2024-02-19T07:15:26Z |
## Description
added dispute as URI PARAM to info api of analytics
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on th... | df739a302b062277647afe5c3888015272fdc2cf | Hit the curl mentioned below and expected response has posted below
| [
"crates/analytics/src/clickhouse.rs",
"crates/analytics/src/core.rs",
"crates/analytics/src/sqlx.rs",
"crates/analytics/src/types.rs",
"crates/analytics/src/utils.rs",
"crates/api_models/src/analytics.rs",
"crates/api_models/src/analytics/disputes.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3698 | Bug: setup roles table
Setup `roles` table along with db functions to support custom roles. | diff --git a/crates/diesel_models/src/enums.rs b/crates/diesel_models/src/enums.rs
index 7ca65ac4b76..4ca5b4c986c 100644
--- a/crates/diesel_models/src/enums.rs
+++ b/crates/diesel_models/src/enums.rs
@@ -17,7 +17,8 @@ pub mod diesel_exports {
DbProcessTrackerStatus as ProcessTrackerStatus, DbReconStatus as Re... | 2024-02-18T21:15:04Z |
## Description
Setup roles table to support custom roles.
## Motivation and Context
# | 8038b48a54c937b3fe72b36cec5f20ee87309be4 | Will be dependent on one core PR; checked table schema locally by running the migrations.
After core functions micro PR containing Apis to interact with DB this can be tested in other environments as well.
| [
"crates/diesel_models/src/enums.rs",
"crates/diesel_models/src/lib.rs",
"crates/diesel_models/src/query.rs",
"crates/diesel_models/src/query/role.rs",
"crates/diesel_models/src/role.rs",
"crates/diesel_models/src/schema.rs",
"crates/router/src/db.rs",
"crates/router/src/db/kafka_store.rs",
"crates/r... | |
juspay/hyperswitch | juspay__hyperswitch-2863 | Bug: [REFACTOR] : [Stripe] Error Message For Connector Implementation
### :memo: Feature Description
- In terms of errors, we are currently throwing a 'not supported' message, which shouldn't be the case as we are yet to decide on the implementation.
### :hammer: Possible Implementation
- In order to mana... | diff --git a/crates/router/src/connector/stripe/transformers.rs b/crates/router/src/connector/stripe/transformers.rs
index 6a89232d4e8..03c424a219f 100644
--- a/crates/router/src/connector/stripe/transformers.rs
+++ b/crates/router/src/connector/stripe/transformers.rs
@@ -684,10 +684,9 @@ impl TryFrom<enums::PaymentMet... | 2024-02-17T02:18:04Z |
## Description
Should close #2863 by changing `NotSupported` to `NotImplemented` error for Stripe
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one f... | 783fa0b0dff1e157920d683a75fc579942cd9c06 | Test a Payment Method which is not implemented It should give
Not implemented error
This is an Crypto payment request.
```
{
"amount": 6540,
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"amount_to_capture": 6540,
"cus... | [
"crates/router/src/connector/stripe/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3686 | Bug: [FEATURE]: [Adyen] Use connector_response_reference_id as reference to merchant
### :memo: Feature Description
- Reference id are used to map transactions in the connector’s dashboard.
- Hyperswitch manages several reference ids, such as `payment_id`, `attempt_id`, and `connector_transaction_id` for a singl... | diff --git a/crates/router/src/connector/adyen/transformers.rs b/crates/router/src/connector/adyen/transformers.rs
index 072b542eee0..00c6ecbd6ab 100644
--- a/crates/router/src/connector/adyen/transformers.rs
+++ b/crates/router/src/connector/adyen/transformers.rs
@@ -338,6 +338,7 @@ pub struct RedirectionResponse {
... | 2024-02-16T13:05:53Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implement... | cf3c66636ffee30cdd4353b276a89a8f9fc2d9d0 | Payment Request for Cards
```
{
"amount": 6540,
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"amount_to_capture": 6540,
"customer_id": "StripeCustomer",
"email": "guest@example.com",
"name": "John Doe",
"phon... | [
"crates/router/src/connector/adyen/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3685 | Bug: [REFACTOR] Simplify the method signatures of some methods in the `Encode` extension trait
### Description
The definition of the [`common_utils::ext_traits::Encode`](https://github.com/juspay/hyperswitch/blob/fb254b8924808e6a2b2a9a31dbed78749836e8d3/crates/common_utils/src/ext_traits.rs#L21) trait has a gener... | diff --git a/add_connector.md b/add_connector.md
index 57fb6fdfff4..ac9d3f8d847 100644
--- a/add_connector.md
+++ b/add_connector.md
@@ -531,7 +531,7 @@ Within the `ConnectorIntegration` trait, you'll find the following methods imple
let connector_req = checkout::PaymentsRequest::try_from(&connector_router_data)... | 2024-02-16T13:05:34Z |
## Description
<!-- Describe your changes in detail -->
This PR simplifies the definition of the `common_utils::ext_traits::Encode` trait to simplify the invocation of the trait methods.
In addition, this PR addresses a clippy lint introduced in Rust 1.76.
## Motivation and Context
<!--
Why is this change re... | 783fa0b0dff1e157920d683a75fc579942cd9c06 |
The changes in this should work fine as long as the code compiles. However, sanity testing can be performed by running Postman collection(s). I have performed sanity testing locally by successfully creating a payment and refund via Postman.
| [
"add_connector.md",
"crates/api_models/src/payments.rs",
"crates/common_utils/src/ext_traits.rs",
"crates/redis_interface/src/commands.rs",
"crates/router/src/compatibility/stripe/webhooks.rs",
"crates/router/src/connector/adyen/transformers.rs",
"crates/router/src/connector/authorizedotnet/transformers... | |
juspay/hyperswitch | juspay__hyperswitch-3683 | Bug: Handle span closures after request completion or after consolidated log...
Currently some consolidated logs don't have the values propogated all the way to the top,
This seems to be a result of the way we handle the consolidated log & value propogation
In this case the consolidated log line is printed b... | diff --git a/crates/router/src/middleware.rs b/crates/router/src/middleware.rs
index f1a3275ab21..2cab332a677 100644
--- a/crates/router/src/middleware.rs
+++ b/crates/router/src/middleware.rs
@@ -143,7 +143,7 @@ where
Box::pin(
async move {
let response = response_fut.await;
- ... | 2024-02-16T11:10:32Z |
## Description
<!-- Describe your changes in detail -->
- Add `pretty_json` log format for console logs
- Add span end log for root span close as the default behaviour
- move consolidated log from event to span close
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If ... | fb254b8924808e6a2b2a9a31dbed78749836e8d3 |
- running it locally check for the last log line after any request
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_st84Q3ucbQSWWnUbPwQXAyefTD2w5gJsRN8GEQ0shegg1ZomnwsseEdJU3KjVoAp' \
--data-raw '{
... | [
"crates/router/src/middleware.rs",
"crates/router_env/src/logger/config.rs",
"crates/router_env/src/logger/formatter.rs",
"crates/router_env/src/logger/setup.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3765 | Bug: [FEATURE] : mask pii information in connector request and response for stripe, aci, adyen, airwallex and authorizedotnet
### Feature Description
Mask pii information passed and received in the connector request and response
### Possible Implementation
Refactor all sensitive response and request fields... | diff --git a/crates/router/src/connector/aci/transformers.rs b/crates/router/src/connector/aci/transformers.rs
index ed56fc5f524..fe621bccd05 100644
--- a/crates/router/src/connector/aci/transformers.rs
+++ b/crates/router/src/connector/aci/transformers.rs
@@ -3,7 +3,7 @@ use std::str::FromStr;
use api_models::enums::... | 2024-02-16T09:28:14Z |
## Description
<!-- Describe your changes in detail -->
Mask pii information passed and received in the connector request and response for stripe, aci, adyen, airwallex and authorizedotnet
## Test Case
Check if sensitive fields within connector request and response is masked in the click house for all these con... | df739a302b062277647afe5c3888015272fdc2cf | [
"crates/router/src/connector/aci/transformers.rs",
"crates/router/src/connector/adyen.rs",
"crates/router/src/connector/adyen/transformers.rs",
"crates/router/src/connector/airwallex.rs",
"crates/router/src/connector/airwallex/transformers.rs",
"crates/router/src/connector/authorizedotnet.rs",
"crates/r... | ||
juspay/hyperswitch | juspay__hyperswitch-3675 | Bug: [BUG]: [Noon] Payment not reaching terminal state
### Bug Description
If there is a timeout or some other unfortunate instance in the application the payment is put in `pending` state, when we sync the payment with Noon, in some cases it returns 4xx and we do not update the status. But for some status like `or... | diff --git a/crates/router/src/connector/noon.rs b/crates/router/src/connector/noon.rs
index 6e1959b46d0..a055c2eac59 100644
--- a/crates/router/src/connector/noon.rs
+++ b/crates/router/src/connector/noon.rs
@@ -132,14 +132,22 @@ impl ConnectorCommon for Noon {
res.response.parse_struct("NoonErrorResponse... | 2024-02-16T08:44:56Z |
## Description
<!-- Describe your changes in detail -->
Currently in Psync if 4xx or 5xx comes the payment_status is not changed for all the error_codes, for specific error_codes like order does not exist should be failed immediately.
## Motivation and Context
<!--
Why is this change required? What problem doe... | 682f4ede8e957021bf0c01849406d1acd6bc17bb |
- Create a sync with noon for payment that was not registered with noon, it should fail rather than stuck in pending state.
<img width="1124" alt="Screenshot 2024-02-16 at 2 02 08 PM" src="https://github.com/juspay/hyperswitch/assets/55536657/133a10ae-73bd-4fac-a73e-d00775ecad97">
<img width="1115" alt="Screens... | [
"crates/router/src/connector/noon.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3302 | Bug: [REFACTOR] Incorporate `hyperswitch_interface` into router
Refactor router to incorporate the newly added crate `hyperswitch_interface` for secrets decryption | diff --git a/config/config.example.toml b/config/config.example.toml
index 1a132933433..abe3f6b4e08 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -115,12 +115,9 @@ route_to_trace = ["*/confirm"]
# This section provides some secret values.
[secrets]
master_enc_key = "sample_key" ... | 2024-02-15T19:07:44Z |
## Description
<!-- Describe your changes in detail -->
This PR incorporates the `hyperswitch_interface` crate into the router crate. Secondly, all secrets(configs) decryption now happens during application startup, eliminating runtime decryption. Lastly, the addition of an encryption_client in the AppState enable... | 75c633fc7c37341177597041ccbcdfc3cf9e236f |
This PR refactors the way decryption of secrets work in router. So all flows should work fine wherever secrets are being used.
Flows that has secrets decryption involved and requires testing -
* `merchant account` creation
* `api key` creation
* Hit `/health/ready` - Everything should be fine
* `Add card`... | [
"config/config.example.toml",
"config/deployments/env_specific.toml",
"crates/drainer/Cargo.toml",
"crates/drainer/src/main.rs",
"crates/drainer/src/secrets_transformers.rs",
"crates/drainer/src/settings.rs",
"crates/external_services/src/aws_kms.rs",
"crates/external_services/src/aws_kms/core.rs",
... | |
juspay/hyperswitch | juspay__hyperswitch-3667 | Bug: Add migration for IsChangePasswordRequired enum
Add migration for force password reset enum, `IsChangePasswordRequired` | diff --git a/migrations/2024-02-15-153757_add_dashboard_metadata_enum_is_change_password_required/down.sql b/migrations/2024-02-15-153757_add_dashboard_metadata_enum_is_change_password_required/down.sql
new file mode 100644
index 00000000000..c7c9cbeb401
--- /dev/null
+++ b/migrations/2024-02-15-153757_add_dashboard_me... | 2024-02-15T15:45:34Z |
## Description
Add migration for force password enum(`IsChangePasswordRequired`).
## Motivation and Context
For force password enum `isChangePasswordRequired` migration is not present.
# | 9f385008106e1cfca8ded40009b364f97ecf69f2 | Tested locally, for the invite flow, after migration its working fine and value of enum is getting updated correctly.
```
curl --location 'http://localhost:8080/user/user/invite' \
--header 'Authorization: Bearer JWT' \
--header 'Content-Type: application/json' \
--data-raw '{
"email": "cdc@gmail.com",
"na... | [
"migrations/2024-02-15-153757_add_dashboard_metadata_enum_is_change_password_required/down.sql",
"migrations/2024-02-15-153757_add_dashboard_metadata_enum_is_change_password_required/up.sql"
] | |
juspay/hyperswitch | juspay__hyperswitch-3664 | Bug: Add Toml file changes for dashboard origin
| diff --git a/config/development.toml b/config/development.toml
index ad5944c34c3..3a3540da5b6 100644
--- a/config/development.toml
+++ b/config/development.toml
@@ -235,7 +235,7 @@ workers = 1
[cors]
max_age = 30
-origins = "http://localhost:8080"
+origins = "http://localhost:8080,http://localhost:9000"
allowed_me... | 2024-02-15T13:08:31Z |
## Description
For localhost testing added Dashboard Origin in the Toml files.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can... | 0666d814af93045ff23c85d8fd796da08cd5749b | Nothing to test.
| [
"config/development.toml",
"config/docker_compose.toml"
] | |
juspay/hyperswitch | juspay__hyperswitch-3660 | Bug: [REFACTOR]: include api key expiry workflow into process tracker
Currently, `ApiKeyExpiryWorkflow` is not part of the workflows being run in scheduler. Refactor to include it, as well as update the email sending section to the latest email refactor logic | diff --git a/crates/diesel_models/src/api_keys.rs b/crates/diesel_models/src/api_keys.rs
index 6608d4ed2fd..1875fc4dc51 100644
--- a/crates/diesel_models/src/api_keys.rs
+++ b/crates/diesel_models/src/api_keys.rs
@@ -138,7 +138,7 @@ mod diesel_impl {
// Tracking data by process_tracker
#[derive(Default, Debug, Dese... | 2024-02-15T12:37:59Z |
## Description
<!-- Describe your changes in detail -->
Currently, `ApiKeyExpiryWorkflow` is not part of the workflows being run in scheduler. This PR refactors that workflow to be included in the existing workflow list, as well as update the email sending section to the latest email refactor logic.
Includes chang... | 0666d814af93045ff23c85d8fd796da08cd5749b |
1. Locally set up email config
2. Created a merchant
3. Created an api key with some expiry (Locally changed the schedule time to be 3 minutes before the expiry)
Since the email is triggered 7 days before exp... | [
"crates/diesel_models/src/api_keys.rs",
"crates/router/Cargo.toml",
"crates/router/src/bin/scheduler.rs",
"crates/router/src/core/api_keys.rs",
"crates/router/src/services/email/assets/api_key_expiry_reminder.html",
"crates/router/src/services/email/types.rs",
"crates/router/src/types/storage/api_keys.r... | |
juspay/hyperswitch | juspay__hyperswitch-3658 | Bug: feat: Email blacklist
| diff --git a/crates/router/src/core/user.rs b/crates/router/src/core/user.rs
index 002452a8a35..54fbecc64f3 100644
--- a/crates/router/src/core/user.rs
+++ b/crates/router/src/core/user.rs
@@ -311,6 +311,10 @@ pub async fn change_password(
.await
.change_context(UserErrors::InternalServerError)?;
+ ... | 2024-02-15T12:21:20Z |
## Description
- Adding blacklisting for email tokens, this will prevent use of same email token to be used twice.
- Change Password & Reset Password logs out user from all open dashboard sessions.
<!-- Describe your changes in detail -->
## Motivation and Context
Prevention of use of same email link to be u... | 0666d814af93045ff23c85d8fd796da08cd5749b | With Dashboard Frontend.
Following links should not work twice:
- Magic Link
To generate magic link email use dashboard frontend or below curl.
```sh
curl --location --request POST '<URL>/user/connect_account' \
--header 'Content-Type: application/json' \
--data-raw '{
"email": ""
}'
```
- Reset Password... | [
"crates/router/src/core/user.rs",
"crates/router/src/services/authentication/blacklist.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3654 | Bug: [FIX] cors throwing unallowed headers
| diff --git a/crates/router/src/cors.rs b/crates/router/src/cors.rs
index 9baa4484ee4..21293301b95 100644
--- a/crates/router/src/cors.rs
+++ b/crates/router/src/cors.rs
@@ -7,6 +7,7 @@ pub fn cors(config: settings::CorsSettings) -> actix_cors::Cors {
let mut cors = actix_cors::Cors::default()
.allowed_m... | 2024-02-15T07:56:03Z |
## Description
<!-- Describe your changes in detail -->
Allow all headers on CORS
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
ca... | 2d4f6b3fa004a3f03beaa604e2dbfe95fcbe22a6 |
- Do a preflight request to `/user/role`
```bash
curl --location --request OPTIONS 'http://localhost:8080/user/role' \
--header 'authority: sandbox.hyperswitch.io' \
--header 'accept: */*' \
--header 'accept-language: en-GB,en-US;q=0.9,en;q=0.8' \
--header 'access-control-request-headers: api-key,authorization,... | [
"crates/router/src/cors.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3647 | Bug: [FIX] create a CORS rule for hyperswitch
| diff --git a/config/config.example.toml b/config/config.example.toml
index 9551fe4f7a2..2b189ea4022 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -327,6 +327,12 @@ paypal = { currency = "USD,INR", country = "US" }
key_id = "" # The AWS key ID used by the KMS SDK for decrypting data.
regi... | 2024-02-13T19:42:10Z |
## Description
<!-- Describe your changes in detail -->
Adds cors rules to actix
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
ca... | 774a0322aa4b36d87b122e47cd893383e262de12 |
- Configure allowed origins in `ROUTER__CORS__ORIGINS`.
- Add `Origin` header to that configured to your config and the request should return 200
```bash
curl --location 'http://localhost:8080/health' \
--header 'Origin: http://localhost:8080'
```
- And configure origin header to something else like `google.com... | [
"config/config.example.toml",
"config/deployments/env_specific.toml",
"config/development.toml",
"config/docker_compose.toml",
"crates/router/src/configs/defaults.rs",
"crates/router/src/configs/settings.rs",
"crates/router/src/configs/validations.rs",
"crates/router/src/cors.rs",
"crates/router/src... | |
juspay/hyperswitch | juspay__hyperswitch-3643 | Bug: [BUG] Update Iatapay config URL to use sandbox URl instead of production URL
### Bug Description
It bugs out when you try to do a payment with Iatapay and it throws Unauthorized error in Sandbox environment
### Expected Behavior
It should do the payment.
### Actual Behavior
Throws an error
### Steps To Re... | diff --git a/config/deployments/sandbox.toml b/config/deployments/sandbox.toml
index 42588cb7345..564a2d9e984 100644
--- a/config/deployments/sandbox.toml
+++ b/config/deployments/sandbox.toml
@@ -43,7 +43,7 @@ globalpay.base_url = "https://apis.sandbox.globalpay.com/ucp/"
globepay.base_url = "https://pay.globepay.co/... | 2024-02-13T09:39:17Z |
## Description
<!-- Describe your changes in detail -->
This PR updates Iatapay to use Sandbox URL instead of Production URL in Sandbox environment.
Closes #3643
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.... | 6e103cef50fea31d2508880985f80f0fd65cd536 |
Iataoay payments in Sandbox environments should work now:
#### Create - Payment
```curl
curl --location 'https://sandbox.hyperswitch.io/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: snd_oJVcvSxV6aBs3qzsG8en6nVUOMYcczuNBSCaIRToSiHhreVNNOYVm... | [
"config/deployments/sandbox.toml"
] | |
juspay/hyperswitch | juspay__hyperswitch-3642 | Bug: docs(connector): Add wasm docs in connector integration docs
Add connector.md file doesn't have information about connector configs where we add connector to control center from backend configs. Documentation for where to add configs in wasm should be mentioned in add_connector.md | diff --git a/add_connector.md b/add_connector.md
index 7fc3dcb27d1..f859c521f0e 100644
--- a/add_connector.md
+++ b/add_connector.md
@@ -668,6 +668,187 @@ In the `connector/utils.rs` file, you'll discover utility functions that aid in
let json_wallet_data: CheckoutGooglePayData =wallet_data.get_wallet_token_as_json(... | 2024-02-13T08:03:22Z |
## Description
<!-- Describe your changes in detail -->
This PR adds documentation to add_connector.md explaining how to add connectors to the Control Center via Wasm configs.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the ... | 6e103cef50fea31d2508880985f80f0fd65cd536 |
Testing not required
| [
"add_connector.md"
] | |
juspay/hyperswitch | juspay__hyperswitch-3634 | Bug: [FIX] unmask last4 when metadata changed during /payments
When a metadata is changed during /payments and list customer payment method is called, last4 digits is getting masked. Unmask it and respond with raw string. | diff --git a/crates/router/src/core/payments/tokenization.rs b/crates/router/src/core/payments/tokenization.rs
index 9691ea962fa..7cff6263344 100644
--- a/crates/router/src/core/payments/tokenization.rs
+++ b/crates/router/src/core/payments/tokenization.rs
@@ -209,9 +209,7 @@ where
... | 2024-02-12T13:34:27Z |
## Description
<!-- Describe your changes in detail -->
When a metadata is changed during /payments and list customer payment method is called, last4 digits is getting masked. This PR unmasks it
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, ... | cc6759bd2d4207ad874a69546cb0a48db70b8629 |
1. Save a card in locker using /payments
2. Change the metadata of the saved card and try to save it again in locker using /payments
3. Now when list_customer_payment_method is called, the last4_digits field of the updated card has to be unmasked
| [
"crates/router/src/core/payments/tokenization.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3632 | Bug: Add checks in Prod Intent to not sent mail
| diff --git a/crates/router/src/core/user/dashboard_metadata.rs b/crates/router/src/core/user/dashboard_metadata.rs
index 82f95564768..7318f9973f1 100644
--- a/crates/router/src/core/user/dashboard_metadata.rs
+++ b/crates/router/src/core/user/dashboard_metadata.rs
@@ -4,10 +4,10 @@ use diesel_models::{
};
use error_s... | 2024-02-12T12:47:26Z |
## Description
Added some checks so unnecessary biz emails won't be sent.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focu... | 8853a60bf4e2ed2490c60df9eaac2a8e46552b96 | When we hit this URL the email is sent to biz@hyperswitch.io so to restrict the unnecessary test mails added some checks.
```
curl --location 'http://localhost:8080/user/data' \
--header 'api-key: hyperswitch' \
--header 'Content-Type: text/plain' \
--header 'Authorization: Bearer JWT' \
--data-raw '{
"ProdI... | [
"crates/router/src/core/user/dashboard_metadata.rs",
"crates/router/src/utils/user/dashboard_metadata.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3721 | Bug: [Refactor]: Make use of Locker for generating/storing fingerprints
# Description
Previously we were generating the fingerprints on our application end itself after this change we will have the fingerprints generated by our locker.
Fingerprint is generated for each and every card payment. Moreover we are stori... | diff --git a/crates/api_models/src/blocklist.rs b/crates/api_models/src/blocklist.rs
index 9672b6de6ee..2afeb2db4f6 100644
--- a/crates/api_models/src/blocklist.rs
+++ b/crates/api_models/src/blocklist.rs
@@ -1,5 +1,6 @@
use common_enums::enums;
use common_utils::events::ApiEventMetric;
+use masking::StrongSecret;
u... | 2024-02-12T11:07:58Z |
## Description
<!-- Describe your changes in detail -->
After this change we will store the fingerprints on our locker in fingerprints table. No more storing anything related to fingerprints in our DB. There will be only one table usable left for blocklsit which will be `blocklist` (stores all the fingerprints block... | e5e44857d21af9db8dee580e276028de76c7d278 | ### Generating fingerprints
-> Toggle the blocklist guard from merchant account being used using `/blocklist/toggle?status=true`. More about
toggling guard [here](https://github.com/juspay/hyperswitch/issues/3467).
-> We need to create a payment.
-> While trying to confirm the payment it will have the `finger... | [
"crates/api_models/src/blocklist.rs",
"crates/data_models/src/payments/payment_attempt.rs",
"crates/data_models/src/payments/payment_intent.rs",
"crates/diesel_models/src/payment_attempt.rs",
"crates/diesel_models/src/payment_intent.rs",
"crates/diesel_models/src/schema.rs",
"crates/diesel_models/src/us... | |
juspay/hyperswitch | juspay__hyperswitch-3628 | Bug: [REFACTOR] Incorporate `hyperswitch_interface` into drainer
Refactor drainer to incorporate the newly added crate `hyperswitch_interface` for secrets decryption | diff --git a/Cargo.lock b/Cargo.lock
index 4bee1804f4c..dcde5456d7d 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2342,6 +2342,7 @@ dependencies = [
"diesel_models",
"error-stack",
"external_services",
+ "hyperswitch_interfaces",
"masking",
"mime",
"once_cell",
diff --git a/config/deployments/drainer.toml b/... | 2024-02-12T10:38:57Z |
## Description
<!-- Describe your changes in detail -->
Added `AppState` in drainer which now contains `encryption_client` for runtime encryption and decryption of values. This PR also incorporates the newly added `hyperswitch_interface` crate for decrypting the secrets during application startup.
## Motivation ... | 5fb3c001b5dc371f81fe1708fd9a6c6978fb726e |
This PR refactors the way decryption of secrets work in drainer. So this cannot be tested
| [
"Cargo.lock",
"config/deployments/drainer.toml",
"crates/drainer/Cargo.toml",
"crates/drainer/src/connection.rs",
"crates/drainer/src/health_check.rs",
"crates/drainer/src/lib.rs",
"crates/drainer/src/main.rs",
"crates/drainer/src/secrets_transformers.rs",
"crates/drainer/src/services.rs",
"crates... | |
juspay/hyperswitch | juspay__hyperswitch-3627 | Bug: [BUG] Wrong email content in invite users
| diff --git a/crates/router/src/services/email/types.rs b/crates/router/src/services/email/types.rs
index 389979d5723..598a2620937 100644
--- a/crates/router/src/services/email/types.rs
+++ b/crates/router/src/services/email/types.rs
@@ -275,7 +275,7 @@ impl EmailData for InviteUser {
let invite_user_link =
... | 2024-02-12T08:44:37Z |
## Description
Invite users email content was of `magic link`. This PR changed it to `invite users`
## Motivation and Context
Right content in email body of invite users
# | 4ae28e48cd73a9f96b6ae24babf167824fd182a0 | With local SES.
```
curl --location 'http://localhost:8080/user/user/invite' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer JWT' \
--data-raw '{
"email": "new_unregistered_email",
"name": "username",
"role_id": "any role"
}'
```
| [
"crates/router/src/services/email/types.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3618 | Bug: [BUG] unmask last4 digits of card when listing payment methods for customer
When metadata of a saved card is updated and customer payment methods are listed, the updated card's last 4 digit is getting masked in the response. Instead unmask it and return the raw digits. | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index 152232d2dec..4f6d6b4c62b 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -248,11 +248,7 @@ pub async fn add_payment_method(
... | 2024-02-10T16:51:23Z |
## Description
<!-- Describe your changes in detail -->
When metadata of a saved card is updated and customer payment methods are listed, the updated card's last 4 digit is getting masked in the response. This PR unmasks it and returns the raw digits.
Bug: `last4_digits` is masked -
![image](https://github.com... | b9c29e7fd3bdc5e582a2dddbb98f3d2dbda72dd6 |
1. Save a card in locker
2. Change the metadata of the saved card and try to save it again in locker
3. Now when `list_customer_payment_method` is called, the `last4_digits` field of the updated card has to be unmasked
| [
"crates/router/src/core/payment_methods/cards.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3616 | Bug: [DOCS] Update Rustman documentation
The current documentation misses some key points that WILL result in people not being able to run the collections and ask for help.
We would want to update it so that it look cleaner with `Notes` that are highlighted thereby making it more readable and clearer. | diff --git a/crates/test_utils/README.md b/crates/test_utils/README.md
index a82c74cb59f..3c50499adc0 100644
--- a/crates/test_utils/README.md
+++ b/crates/test_utils/README.md
@@ -2,7 +2,8 @@
The heart of `newman`(with directory support) and `UI-tests`
-> If you're developing a collection and you want to learn mo... | 2024-02-09T18:43:21Z |
## Description
<!-- Describe your changes in detail -->
This PR updates the `Rustman` documentation easing the collection development process along with the things to look for before running the collection.
Closes #3616
## Motivation and Context
<!--
Why is this change required? What problem does it solve... | b9c29e7fd3bdc5e582a2dddbb98f3d2dbda72dd6 |
Below 2 files look cleaner and clearer:
- https://github.com/juspay/hyperswitch/blob/af7e39e57fd079bad60d8afed97c74fe633e4645/crates/test_utils/README.md
- https://github.com/juspay/hyperswitch/blob/af7e39e57fd079bad60d8afed97c74fe633e4645/postman/README.md
| [
"crates/test_utils/README.md",
"postman/README.md"
] | |
juspay/hyperswitch | juspay__hyperswitch-3607 | Bug: [FEATURE] Add new column in PaymentAttempt for storing mandate_data
### Feature Description
Add new column in PaymentAttempt for storing mandate_data to be future compatible
### Possible Implementation
Add a column mandate_data which would be a struct , in order to store the mandate details for a mandate i... | diff --git a/crates/data_models/src/mandates.rs b/crates/data_models/src/mandates.rs
index 319a78cf661..b4478f84ee9 100644
--- a/crates/data_models/src/mandates.rs
+++ b/crates/data_models/src/mandates.rs
@@ -13,7 +13,6 @@ use time::PrimitiveDateTime;
#[serde(rename_all = "snake_case")]
pub struct MandateDetails {
... | 2024-02-09T05:57:16Z |
## Description
To make the mandate_details forward compatible , instead of storing update mandate id in mandate details we store it in the new column mandate data. Currently in mandate_data column we only store update_mandate_id
## Motivation and Context
<!--
Why is this change required? What problem does it... | e54b0dd20fabf48cc8f6ea59bb197f05b8b5adeb | - Create an MA and an MCA
- Make a mandate_payment
- And then make an update_mandate_payment with the mandate_id generated in the previous step
- The card would be updated and reflected when we do list mandate
<img width="1728" alt="Screenshot 2024-02-09 at 1 08 48 PM" src="https://github.com/juspay/hyperswitch... | [
"crates/data_models/src/mandates.rs",
"crates/data_models/src/payments/payment_attempt.rs",
"crates/diesel_models/src/enums.rs",
"crates/diesel_models/src/payment_attempt.rs",
"crates/diesel_models/src/schema.rs",
"crates/diesel_models/src/user/sample_data.rs",
"crates/router/src/core/payment_methods/ca... | |
juspay/hyperswitch | juspay__hyperswitch-3604 | Bug: chore: address Rust 1.76 clippy lints
Address the clippy lints occurring due to new rust version 1.76
See #3391 for more information. | diff --git a/crates/router/src/compatibility/wrap.rs b/crates/router/src/compatibility/wrap.rs
index d3ca0172f26..da14475f120 100644
--- a/crates/router/src/compatibility/wrap.rs
+++ b/crates/router/src/compatibility/wrap.rs
@@ -42,7 +42,7 @@ where
let start_instant = Instant::now();
logger::info!(tag = ?Tag:... | 2024-02-08T17:02:07Z |
## Description
<!-- Describe your changes in detail -->
This PR addresses the clippy lints occurring due to new rust version 1.76
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'... | dd5630f070db28051a3dd59a66f0a4ee6777e38f |
Rust updation clippy lints are addressed here. So basic sanity test should suffice
| [
"crates/router/src/compatibility/wrap.rs",
"crates/router/src/db/address.rs",
"crates/router/src/db/merchant_connector_account.rs",
"crates/router/src/db/payment_method.rs",
"crates/router/src/services/api.rs",
"crates/scheduler/src/utils.rs",
"crates/test_utils/src/newman_runner.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3595 | Bug: feat(user_role): Transfer ownership api
| diff --git a/crates/api_models/src/events/user_role.rs b/crates/api_models/src/events/user_role.rs
index 3ec30d6bd97..2b8d0221497 100644
--- a/crates/api_models/src/events/user_role.rs
+++ b/crates/api_models/src/events/user_role.rs
@@ -2,7 +2,7 @@ use common_utils::events::{ApiEventMetric, ApiEventsType};
use crate... | 2024-02-08T13:34:24Z |
## Description
<!-- Describe your changes in detail -->
This PR will add a new api to transfer ownership of an organization to other.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue,... | cfa10aa60ef16d2302787f7ecf7c129228fc0549 |
Postman
```
curl --location 'http://localhost:8080/user/user/transfer_ownership' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer JWT of org_admin user' \
--data-raw '{
"email": "email of the user who is not org_admin"
}'
```
If the api is successful, it will return the follo... | [
"crates/api_models/src/events/user_role.rs",
"crates/api_models/src/user_role.rs",
"crates/diesel_models/src/query/user_role.rs",
"crates/router/src/core/user_role.rs",
"crates/router/src/db/kafka_store.rs",
"crates/router/src/db/user_role.rs",
"crates/router/src/routes/app.rs",
"crates/router/src/rou... | |
juspay/hyperswitch | juspay__hyperswitch-3537 | Bug: [BUG] Nuvei recurring MIT payment is not handled in Authorize flow
### Bug Description
In the Nuvei Authorize flow implementation, the `get_request_body` method currently utilizes `TryFrom` to construct a `NuveiPaymentsRequest` using `RouterData`. To accommodate `NuveiPaymentsRequest` for each payment method... | diff --git a/crates/router/src/connector/nuvei/transformers.rs b/crates/router/src/connector/nuvei/transformers.rs
index d5dd6e813ae..fe17fae8770 100644
--- a/crates/router/src/connector/nuvei/transformers.rs
+++ b/crates/router/src/connector/nuvei/transformers.rs
@@ -20,7 +20,7 @@ use crate::{
consts,
core::... | 2024-02-08T13:05:43Z |
## Description
- Moved mandate logic outside card_info to MandatePayment
- Included Device detail to send IP address to nuvei (mandatory) for both card_info and mandate flow , Ip address is taken from browser info
- Billing address for rawcard payment flow
- Moved broswer info inside three_ds request constructi... | df739a302b062277647afe5c3888015272fdc2cf |
Added screenshots from testing
Recurring pay with mandate
<img width="1127" alt="Screenshot 2024-02-08 at 6 49 58 PM" src="https://github.com/juspay/hyperswitch/assets/97145230/a6c7997d-c98e-4eb1-b5d3-27a71c26f1c4">
Payment With and without IP address
<img width="1400" alt="Screenshot 2024-02-08 at 6 49 08 P... | [
"crates/router/src/connector/nuvei/transformers.rs",
"crates/router/src/connector/utils.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3511 | Bug: [BUG] Nuvei Payment request validation issues
### Bug Description
nuvei payments
- browser_info is validated for both non-3ds and 3ds flows, as per nuvei docs browser_info is mandatory only for 3ds flows. The validation should be thrown by gateway instead
- IP address and billing address not sent to Nuv... | diff --git a/crates/router/src/connector/nuvei/transformers.rs b/crates/router/src/connector/nuvei/transformers.rs
index d5dd6e813ae..fe17fae8770 100644
--- a/crates/router/src/connector/nuvei/transformers.rs
+++ b/crates/router/src/connector/nuvei/transformers.rs
@@ -20,7 +20,7 @@ use crate::{
consts,
core::... | 2024-02-08T13:05:43Z |
## Description
- Moved mandate logic outside card_info to MandatePayment
- Included Device detail to send IP address to nuvei (mandatory) for both card_info and mandate flow , Ip address is taken from browser info
- Billing address for rawcard payment flow
- Moved broswer info inside three_ds request constructi... | df739a302b062277647afe5c3888015272fdc2cf |
Added screenshots from testing
Recurring pay with mandate
<img width="1127" alt="Screenshot 2024-02-08 at 6 49 58 PM" src="https://github.com/juspay/hyperswitch/assets/97145230/a6c7997d-c98e-4eb1-b5d3-27a71c26f1c4">
Payment With and without IP address
<img width="1400" alt="Screenshot 2024-02-08 at 6 49 08 P... | [
"crates/router/src/connector/nuvei/transformers.rs",
"crates/router/src/connector/utils.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3600 | Bug: [Refactor] Send an appropriate error if update_mandate is not supported
### Feature Description
Send an appropriate error if update_mandate is not also add support for allowing the payment with payment_method
_type as None
### Possible Implementation
- Improvise theImplementation if its a Card
- Thorw an ... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index 7b505e7c01c..b8b0fffe339 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -2136,12 +2136,33 @@ pub fn filter_pm_based_on_update_mandat... | 2024-02-08T12:17:35Z |
## Description
Send an appropriate error if update_mandate is not also add support for allowing the payment with payment_method
_type as None and also fix the failing postman collection
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please ... | 96f82cb21233677968aade844db91f91e3918843 | - Create a MA and an MCA with Cybersource
> Make a UpdateMandatePayment with `payment_method_type` as null
>Payment would succeed
- Create a MA and an MCA with Cybersource
- >Mak... | [
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payments/flows/setup_mandate_flow.rs",
"loadtest/config/development.toml",
"postman/collection-dir/adyen_uk/Flow Testcases/Happy Cases/Scenario16-Bank debit-ach/Payments - Create/request.json",
"postman/collection-dir/adyen_uk/Flow T... | |
juspay/hyperswitch | juspay__hyperswitch-3599 | Bug: permission-info Order change
Change the ordering of the [ThreeDsDecisionManagerWrite , ThreeDsDecisionManagerRead] and [SurchargeDecisionManagerWrite, SurchargeDecisionManagerRead] of permissionInfo API.
| diff --git a/crates/router/src/services/authorization/info.rs b/crates/router/src/services/authorization/info.rs
index 99e4f1b6c09..450a5a738c3 100644
--- a/crates/router/src/services/authorization/info.rs
+++ b/crates/router/src/services/authorization/info.rs
@@ -159,8 +159,8 @@ impl ModuleInfo {
modu... | 2024-02-08T09:02:32Z |
## Description
<!-- Describe your changes in detail -->
Change the ordering of the [ThreeDsDecisionManagerWrite , ThreeDsDecisionManagerRead] and [SurchargeDecisionManagerWrite, SurchargeDecisionManagerRead] of permissionInfo API.
## Motivation and Context
<!--
Why is this change required? What problem ... | 3a869a2d5731a2393a687ed7773eda5344bd8e3f |
```
curl --location 'http://localhost:8080/user/permission_info' \
--header 'api-key: hyperswitch' \
--header 'authorization: Bearer <JWT> \
--header 'content-type: application/json' \
```
| [
"crates/router/src/services/authorization/info.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3593 | Bug: [FEATURE]:(doc) Add list mandates for customer in api reference
### Feature Description
Add `list mandates for customer` docs in api reference
### Possible Implementation
Add in open_api spec
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't fi... | diff --git a/crates/openapi/src/openapi.rs b/crates/openapi/src/openapi.rs
index 1936300ee14..dc38181a683 100644
--- a/crates/openapi/src/openapi.rs
+++ b/crates/openapi/src/openapi.rs
@@ -114,6 +114,7 @@ Never share your secret api keys. Keep them guarded and secure.
routes::customers::customers_list,
... | 2024-02-08T07:59:52Z |
## Description
<!-- Describe your changes in detail -->
add list mandates for customer
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the ... | c2b2b65b9cfc43b5999888635c7b03b1d2de78b3 |
Can't be tested as this is a doc update PR
| [
"crates/openapi/src/openapi.rs",
"crates/openapi/src/routes/customers.rs",
"openapi/openapi_spec.json"
] | |
juspay/hyperswitch | juspay__hyperswitch-3585 | Bug: refactor: change list roles api to also send inactive merchants
| diff --git a/crates/router/src/core/user.rs b/crates/router/src/core/user.rs
index 41a407bd670..70c3eb6673b 100644
--- a/crates/router/src/core/user.rs
+++ b/crates/router/src/core/user.rs
@@ -945,10 +945,13 @@ pub async fn create_merchant_account(
pub async fn list_merchant_ids_for_user(
state: AppState,
- ... | 2024-02-07T12:48:41Z |
## Description
<!-- Describe your changes in detail -->
Changed switch list api to also send inactive merchants in the response.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd... | fbe84b2a334cfb744ae4f27b1eadc892c7f9b164 |
```
curl --location 'http://localhost:8080/user/switch/list' \
--header 'Authorization: Bearer JWT'
```
This api will send merchants with `is_active`: `false` in the response from now on.
```
[
{
"merchant_id": "merchant_1",
"merchant_name": null,
"is_active": false
},
... | [
"crates/router/src/core/user.rs",
"crates/router/src/utils/user_role.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3582 | Bug: Logging framework - add connector name for all payment CRUD API calls
Add connector name labels for payment CRUD (create/confirm/void/redirect/update/retrieve) API’s to ES
| diff --git a/crates/router/src/services/api.rs b/crates/router/src/services/api.rs
index 3730c5bf9a4..feaa59485d6 100644
--- a/crates/router/src/services/api.rs
+++ b/crates/router/src/services/api.rs
@@ -265,7 +265,7 @@ pub enum CaptureSyncMethod {
/// Handle the flow by interacting with connector module
/// `connec... | 2024-02-07T12:22:20Z |
## Description
<!-- Describe your changes in detail -->
Adding connector_name from the moment its available into logs for better search on ELS/Loki
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't ... | c5343dfcc20f1000e319c62fa0341c46701595ff |
make a payment confirm api call
check for `connector_name` field in golden_log_line (can search loki with `{golden_log_line="true"}` query and find the log with request_id)
Impacted Area -> Application IO level logs
![image](https://github.com/juspay/hyperswitch/assets/21202349/1fe15d2f-187a-4525-8674-eca6... | [
"crates/router/src/services/api.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3577 | Bug: [BUG] : store connector mandate id in complete auth
### Bug Description
Connector_reference in TransactionResponse of Complete auth call not saved in the DB
### Expected Behavior
Store the connector_reference, when it is sent in Complete auth call.
### Have you spent some time checking if this bug h... | diff --git a/crates/router/src/core/mandate.rs b/crates/router/src/core/mandate.rs
index e564e4a733e..d58eae371e8 100644
--- a/crates/router/src/core/mandate.rs
+++ b/crates/router/src/core/mandate.rs
@@ -1,7 +1,7 @@
pub mod helpers;
pub mod utils;
use api_models::payments;
-use common_utils::{ext_traits::Encode, pi... | 2024-02-07T09:46:28Z |
## Description
<!-- Describe your changes in detail -->
In this PR we store the connector_reference, when it is sent in Complete auth call.
## Test Case
1. Make a 3ds mandate payment with Cybersource
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--heade... | 5fb3c001b5dc371f81fe1708fd9a6c6978fb726e | [
"crates/router/src/core/mandate.rs",
"crates/router/src/core/payments/operations/payment_response.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-3573 | Bug: feat: force password for user
Support to have a check whether for newly invited users, whether the password has been changed once or not. This will be limited to users with email feature flag disabled. | diff --git a/crates/api_models/src/user/dashboard_metadata.rs b/crates/api_models/src/user/dashboard_metadata.rs
index 11588bbfbaf..66831c7aeb8 100644
--- a/crates/api_models/src/user/dashboard_metadata.rs
+++ b/crates/api_models/src/user/dashboard_metadata.rs
@@ -24,6 +24,8 @@ pub enum SetMetaDataRequest {
Config... | 2024-02-07T08:25:39Z |
## Description
For newly invited users, add support to have check for whether password has been changed once or not.
- Use enum `IsChangePasswordRequired` to have this check.
## Motivation and Context
For users with email feature flag disabled, there is no support to know whether the newly invited user has change... | 3af6aaf28e92780679eb0314eb3e95803b9c3113 | For Test
Invite user
```
curl --location 'http://localhost:8080/user/user/invite' \
--header 'Authorization: Bearer JWT' \
--header 'Content-Type: application/json' \
--data-raw '{
"email": "test_force@gmail.com",
"name": "test3",
"role_id": "merchant_admin"
}
'
```
Invited user signin
```
cur... | [
"crates/api_models/src/user/dashboard_metadata.rs",
"crates/diesel_models/src/enums.rs",
"crates/diesel_models/src/query/dashboard_metadata.rs",
"crates/router/src/core/user.rs",
"crates/router/src/core/user/dashboard_metadata.rs",
"crates/router/src/db/dashboard_metadata.rs",
"crates/router/src/db/kafk... | |
juspay/hyperswitch | juspay__hyperswitch-3538 | Bug: [FEATURE] Decide Flow based on setup_future_usage param
### Feature Description
The setup_future_usage has two fields on_session and off_session. The flow, i.e. either SaveCard/Mandate, will be decided on the basis of these fields.
### Possible Implementation
In our current flow there's no specific SaveC... | diff --git a/crates/api_models/src/mandates.rs b/crates/api_models/src/mandates.rs
index b29f4e0d0c3..7c20a902d28 100644
--- a/crates/api_models/src/mandates.rs
+++ b/crates/api_models/src/mandates.rs
@@ -77,6 +77,9 @@ pub struct MandateCardDetails {
pub card_network: Option<api_enums::CardNetwork>,
/// The t... | 2024-02-06T18:00:28Z |
## Description
decide flow based on setup_future_usage
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementa... | 0a97a1eb6382a1aa465ac5a1dc792ea4e763511a | - Create an MA and MCA
- Change the setup future usage field on the basis of following cases :
> If the field is on_session, there would be a normal save card flow
> if the field is off_session and customer_acceptance field is passed , there would be a mandate flow
> If the field is off_session and no customer_acce... | [
"crates/api_models/src/mandates.rs",
"crates/router/src/core/payments/flows/authorize_flow.rs",
"crates/router/src/core/payments/flows/setup_mandate_flow.rs",
"crates/router/src/core/payments/operations/payment_create.rs",
"crates/router/src/core/payments/operations/payment_update.rs",
"crates/router/src/... | |
juspay/hyperswitch | juspay__hyperswitch-3467 | Bug: [FEATURE]: Api for enable/disable Blocklist guard
This Api mentioned will be for toggling the `blocklist-guard` for a particular merchant. So the changes will be as mentioned:
> It will try to find a config associated with that merchant (guard_blocklist_for_{merchant_id}) which in tern is a boolean config.
... | diff --git a/crates/api_models/src/blocklist.rs b/crates/api_models/src/blocklist.rs
index 888b9106ccc..9672b6de6ee 100644
--- a/crates/api_models/src/blocklist.rs
+++ b/crates/api_models/src/blocklist.rs
@@ -22,6 +22,11 @@ pub struct BlocklistResponse {
pub created_at: time::PrimitiveDateTime,
}
+#[derive(Debu... | 2024-02-06T14:08:09Z |
## Description
<!-- Describe your changes in detail -->
This Api mentioned will be for toggling the `blocklist-guard` for a particular merchant. So the changes will be as mentioned:
> It will try to find a config associated with that merchant (guard_blocklist_for_{merchant_id}) which in tern is a boolean config.
... | a15e7ae9b156659e61de752ca94b6f43932d9de5 |
This can be found out in the linked issue.
| [
"crates/api_models/src/blocklist.rs",
"crates/openapi/src/openapi.rs",
"crates/openapi/src/routes/blocklist.rs",
"crates/router/src/core/blocklist.rs",
"crates/router/src/core/blocklist/utils.rs",
"crates/router/src/routes/app.rs",
"crates/router/src/routes/blocklist.rs",
"crates/router/src/routes/loc... | |
juspay/hyperswitch | juspay__hyperswitch-3517 | Bug: feat(EVENT_VIEWER): Add masking for connector responses in connector events
Currently connector responses are being logged without masking.
In order to protect PII data we need to add masking for the connector responses in connector events & logs | diff --git a/.cargo/config.toml b/.cargo/config.toml
index 5b27955262a..c372e06f927 100644
--- a/.cargo/config.toml
+++ b/.cargo/config.toml
@@ -1,6 +1,7 @@
[target.'cfg(all())']
rustflags = [
"-Funsafe_code",
+ "-Aclippy::option_map_unit_fn",
"-Wclippy::as_conversions",
"-Wclippy::expect_used",
... | 2024-02-06T12:12:11Z |
## Description
<!-- Describe your changes in detail -->
Mask connector response in the click house
### Test Case
In click house check if connector response fields are masked
_Note: Only fields that are of type Secret<> is masked_
Test all the flows for all the connectors especially NMI as changes are mad... | 09c2a5c2a90f2773b00ab11ad67ab149f8225e3a | [
".cargo/config.toml",
"add_connector.md",
"connector-template/mod.rs",
"crates/analytics/docs/clickhouse/cluster_setup/README.md",
"crates/analytics/docs/clickhouse/cluster_setup/config/clickhouse_config.xml",
"crates/analytics/docs/clickhouse/cluster_setup/config/clickhouse_metrika.xml",
"crates/analyt... | ||
juspay/hyperswitch | juspay__hyperswitch-3562 | Bug: chore(analytics): create a seperate flow for a force sync
Currently we use PaymentRetrieve for GET /payment/:id call, for force_sync use cases we should have a separate flow since the underlying execution differs significantly... | diff --git a/crates/router/src/compatibility/stripe/payment_intents.rs b/crates/router/src/compatibility/stripe/payment_intents.rs
index d67166c0d04..87560032ea4 100644
--- a/crates/router/src/compatibility/stripe/payment_intents.rs
+++ b/crates/router/src/compatibility/stripe/payment_intents.rs
@@ -71,7 +71,7 @@ pub a... | 2024-02-06T11:17:50Z | Currently we use PaymentRetrieve for GET /payment/:id call, for force_sync use cases we should have a separate flow since the underlying execution differs significantly...
Refs: #3562
## Description
<!-- Describe your changes in detail -->
Currently we don't show payment retrieve call logs in the audit logs but ... | 53559c22527dde9536aa493ad7cd3bf353335c1a |
hit a payment/refunds/dispute retrieve call with a force sync flag as true and in the logs u get to see the enum contains force retrieve in it ex- `RefundsRetriveForceSync`
when we do a refunds or payment retrive call with the force_sync flag as true , the debugger will display the `RefundsRetriveForceSync` in the... | [
"crates/router/src/compatibility/stripe/payment_intents.rs",
"crates/router/src/compatibility/stripe/refunds.rs",
"crates/router/src/compatibility/stripe/setup_intents.rs",
"crates/router/src/routes/lock_utils.rs",
"crates/router/src/routes/payments.rs",
"crates/router/src/routes/refunds.rs",
"crates/ro... | |
juspay/hyperswitch | juspay__hyperswitch-1357 | Bug: [FEATURE] add domain type for client secret
### Feature Description
Create domain type for client secret
### Possible Implementation
Make type `ClietSecret(String)` and use it wherever applicable
### Have you spent some time to check if this feature request has been raised before?
- [X] I checked and didn... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index 6bccfd1124c..1be9762c76c 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -1,4 +1,4 @@
-use std::num::NonZeroI64;
+use std::{fmt, num::NonZeroI64};
use cards::CardNumber;
use common_util... | 2024-02-05T22:29:45Z |
## Description
Implement `ClientSecret` type for payments.
Closes #1357
## Motivation and Context
# | 91cd70a60b89b1c4e868e359a75f4088854562ef | Added and ran unit tests successfully.
_Maintainer edit:_ This PR only adds a newtype and is not being used anywhere in code, this should not affect any existing application behavior.
| [
"crates/api_models/src/payments.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3488 | Bug: [FEATURE] Create a delete endpoint for Config Table
### Feature Description
Add an API for deleting data from config table.
### Possible Implementation
Add the endpoint DELETE `config/{key}` for deleting the config key.
### Have you spent some time checking if this feature request has been raised before?
-... | diff --git a/crates/diesel_models/src/query/configs.rs b/crates/diesel_models/src/query/configs.rs
index 62ed60e3b0a..306fb5e3353 100644
--- a/crates/diesel_models/src/query/configs.rs
+++ b/crates/diesel_models/src/query/configs.rs
@@ -50,8 +50,11 @@ impl Config {
}
#[instrument(skip(conn))]
- pub async... | 2024-02-05T14:59:01Z |
## Description
<!-- Describe your changes in detail -->
Added the api to delete config key
Fixes #3488
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. `crates/router/src/configs`
3. `loadtest/config`
-->
# | 073310c1f671ccbb71cc5c8725eca9771e511589 |
- Create a config.
```bash
curl --location 'http://localhost:8080/configs/' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data '{
"key":"keke",
"value": "keke"
}'
```
- Delete the config
```bash
curl --location --request DELETE 'http://localhost:8080/configs/kek... | [
"crates/diesel_models/src/query/configs.rs",
"crates/router/src/core/configs.rs",
"crates/router/src/db/configs.rs",
"crates/router/src/db/kafka_store.rs",
"crates/router/src/routes/app.rs",
"crates/router/src/routes/configs.rs",
"crates/router/src/routes/lock_utils.rs",
"crates/router_env/src/logger/... | |
juspay/hyperswitch | juspay__hyperswitch-3553 | Bug: [FIX] dont return true in case health check is not done on the component
Whenever a component is disabled we don't have to check for it's health so return false in case if we didn't check it | diff --git a/crates/api_models/src/health_check.rs b/crates/api_models/src/health_check.rs
index 6b0297b655f..29a59df397e 100644
--- a/crates/api_models/src/health_check.rs
+++ b/crates/api_models/src/health_check.rs
@@ -2,7 +2,8 @@
pub struct RouterHealthCheckResponse {
pub database: bool,
pub redis: bool,
... | 2024-02-05T11:48:10Z |
## Description
<!-- Describe your changes in detail -->
Don't return true on the places where checks or not applicable
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend ... | d3fb705ed241a216cbe53de1886d18506bff68bc |
- Disable locker in config
```bash
curl --location 'http://localhost:8080/health/ready'
```
<img width="1305" alt="Screenshot 2024-02-07 at 2 55 21 PM" src="https://github.com/juspay/hyperswitch/assets/43412619/27a2a956-a57a-4a1b-a6cf-d2b0e602017d">
**THIS CANNOT BE TESTED IN SANDBOX**
| [
"crates/api_models/src/health_check.rs",
"crates/router/src/core/health_check.rs",
"crates/router/src/routes/health.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3552 | Bug: feat(analytics): adding kafka dispute events
| diff --git a/config/config.example.toml b/config/config.example.toml
index 3f1e789dd50..611c581a3df 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -559,6 +559,7 @@ refund_analytics_topic = "topic" # Kafka topic to be used for Refund events
api_logs_topic = "topic" # Kafka... | 2024-02-05T11:31:41Z |
## Description
adding dispute events to kafka
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implementation (unl... | fb254b8924808e6a2b2a9a31dbed78749836e8d3 | Create a payment curl commented below, I used checkout connector to create dispute
and check on grafana in explore section, select loki and query as ```{app="bach"} |= dispute_id```
I added SS of local console log in the comment below
| [
"config/config.example.toml",
"config/development.toml",
"config/docker_compose.toml",
"crates/analytics/docs/clickhouse/cluster_setup/scripts/dispute_analytics.sql",
"crates/analytics/docs/clickhouse/scripts/disputes.sql",
"crates/router/src/db/kafka_store.rs",
"crates/router/src/services/kafka.rs",
... | |
juspay/hyperswitch | juspay__hyperswitch-3464 | Bug: [FEATURE] Add the configs for revoking as well as updating the mandates
### Feature Description
Add envs of the connectors that support the revokinga s well as updation of mandates
### Possible Implementation
Make an env that has the list of all the connectors that support revoke as well as mandate flow , a... | diff --git a/config/config.example.toml b/config/config.example.toml
index dd1206b20dc..dda768bec3c 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -391,6 +391,9 @@ bank_redirect.ideal = {connector_list = "stripe,adyen,globalpay"} # Mandate supp
bank_redirect.sofort = {connector_list = "str... | 2024-02-05T07:47:56Z |
## Description
add config for update_mandate_flow and allow only those payment_methods that support update while Listing PaymentMethods For Merchants
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you do... | ef302dd3983674c9df47812d3c398a7e7b423257 | - Create an MA and a MCA for Cybersource
> Create an update_,mandate payment using cyber source it'll be successful
- Create an MA and a MCA forStripe
> Create an update_,mandate payment using cyber source it should throw a 5xx
- Now ListPaymentMethodsForMerchnat in an Update Flow, we only list cards
| [
"config/config.example.toml",
"config/deployments/integration_test.toml",
"config/deployments/production.toml",
"config/deployments/sandbox.toml",
"config/development.toml",
"crates/api_models/src/payments.rs",
"crates/router/src/configs/defaults.rs",
"crates/router/src/configs/settings.rs",
"crates... | |
juspay/hyperswitch | juspay__hyperswitch-3535 | Bug: [REFACTOR] introducing `hyperswitch_interface` crates
Create a new crate `Hyperswitch-interface` containing below modules for now:
`secrets_interface`: Module used for application config `encryption` and `decryption` during startup which will contain its own trait and error types
`encryption_interface`: Modu... | diff --git a/Cargo.lock b/Cargo.lock
index 49ccfc2c645..4bee1804f4c 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2495,6 +2495,7 @@ dependencies = [
"hex",
"hyper",
"hyper-proxy",
+ "hyperswitch_interfaces",
"masking",
"once_cell",
"router_env",
@@ -3214,6 +3215,18 @@ dependencies = [
"tokio-native-tls",
... | 2024-02-02T13:02:25Z |
## Description
<!-- Describe your changes in detail -->
Create a new crate `Hyperswitch-interface` containing below modules for now:
`secrets_interface`: Module used for application config `encryption` and `decryption` during startup which will contain its own trait and error types
`encryption_interface`: Module ... | cfa10aa60ef16d2302787f7ecf7c129228fc0549 |
New crates addition which doesn't integrate with other existing crates yet. So basic sanity testing should suffice
| [
"Cargo.lock",
"crates/drainer/src/connection.rs",
"crates/drainer/src/services.rs",
"crates/drainer/src/settings.rs",
"crates/external_services/Cargo.toml",
"crates/external_services/src/aws_kms.rs",
"crates/external_services/src/aws_kms/core.rs",
"crates/external_services/src/aws_kms/decrypt.rs",
"... | |
juspay/hyperswitch | juspay__hyperswitch-3510 | Bug: [FIX] add a configuration validation for workers
We don't have a validation check
[number of workers in our config](https://github.com/juspay/hyperswitch/blob/94cd7b689758a71e13a3eaa655335e658d13afc8/crates/router/src/configs/settings.rs#L422) . But if the number of workers is zero actix straight out panics. ... | diff --git a/crates/router/src/configs/validations.rs b/crates/router/src/configs/validations.rs
index 910ae754347..69d0274d704 100644
--- a/crates/router/src/configs/validations.rs
+++ b/crates/router/src/configs/validations.rs
@@ -68,10 +68,18 @@ impl super::settings::Locker {
impl super::settings::Server {
p... | 2024-02-02T09:54:18Z |
## Description
<!-- Describe your changes in detail -->
Added validation check on number workers
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one f... | cf0e0b330e4c62860f645bcb61d96b07c9f4fb7b |
Nothing to test in this PR
| [
"crates/router/src/configs/validations.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3534 | Bug: feat(user_role): Update role API - test and finalise
| diff --git a/crates/api_models/src/user.rs b/crates/api_models/src/user.rs
index b29ce811be3..c3e6908c733 100644
--- a/crates/api_models/src/user.rs
+++ b/crates/api_models/src/user.rs
@@ -142,7 +142,6 @@ pub struct GetUsersResponse(pub Vec<UserDetails>);
#[derive(Debug, serde::Serialize)]
pub struct UserDetails {
... | 2024-02-01T14:05:34Z |
## Description
<!-- Describe your changes in detail -->
This PR changes update user role api and the list users api. And fixes a bug in list roles api.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you d... | 014c2d5f555633bc04baca9b4a8c30b9c3534350 |
1. Update user role api
```
curl --location 'http://localhost:8080/user/user/update_role' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer JWT' \
--data '{
"email": "user_email",
"role_id": "merchant_admin"
}'
```
If api is success, it will respond with 200 OK.... | [
"crates/api_models/src/user.rs",
"crates/api_models/src/user_role.rs",
"crates/router/src/core/errors/user.rs",
"crates/router/src/core/errors/utils.rs",
"crates/router/src/core/user.rs",
"crates/router/src/core/user_role.rs",
"crates/router/src/services/authorization/predefined_permissions.rs",
"crat... | |
juspay/hyperswitch | juspay__hyperswitch-3520 | Bug: feat(logging-framework): Add a end log line to print the accumulated log values
Instead of relying on the exit & entry points of root spans,
we should add an explicit log entry at the end of root span | diff --git a/crates/router/src/middleware.rs b/crates/router/src/middleware.rs
index 702c3c70e6c..9205f53a04b 100644
--- a/crates/router/src/middleware.rs
+++ b/crates/router/src/middleware.rs
@@ -141,9 +141,14 @@ where
let response_fut = self.service.call(req);
Box::pin(
- response_fut.i... | 2024-02-01T13:06:05Z |
## Description
<!-- Describe your changes in detail -->
- Add an end request log line for logging keys
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with o... | 54fb61eeebec503f599774fe9e97f6b6ce3f1458 |
make a health API call & check for the following log line
```json
{
"message": "[ROOT_SPAN - EVENT] router::middleware",
"hostname": "sampraslopes-SERIAL.local",
"pid": 78236,
"env": "development",
"level": "INFO",
"target": "router::middleware",
"service": "router",
"line"... | [
"crates/router/src/middleware.rs",
"crates/router/src/routes/customers.rs",
"crates/router/src/routes/mandates.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3524 | Bug: Deep health check for outgoing request in scheduler
| diff --git a/crates/api_models/src/health_check.rs b/crates/api_models/src/health_check.rs
index e4611f43bcf..2c65c7b6d50 100644
--- a/crates/api_models/src/health_check.rs
+++ b/crates/api_models/src/health_check.rs
@@ -13,6 +13,7 @@ impl common_utils::events::ApiEventMetric for RouterHealthCheckResponse {}
pub struc... | 2024-02-01T12:37:02Z |
## Description
<!-- Describe your changes in detail -->
Closes #3524 . Add an outgoing request check for scheduler.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend sta... | 54fb61eeebec503f599774fe9e97f6b6ce3f1458 |
- `curl --location 'http://localhost:3000/health/ready'`
- <img width="1305" alt="Screenshot 2024-02-01 at 6 06 36 PM" src="https://github.com/juspay/hyperswitch/assets/43412619/5d1e1525-a408-484f-9749-6affbad3758c">
**This cannot be tested in sandbox as it's not exposed externally in sandbox**
| [
"crates/api_models/src/health_check.rs",
"crates/router/src/bin/scheduler.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3527 | Bug: [BUG] ListPaymentMethods For Merchant has an empty array of payment_methods_enabled
### Bug Description
While doing a, ListPaymentMethods For Merchant it has an empty array of payment_methods_enabled.
### Expected Behavior
ListPaymentMethods For Merchant should have the payment_methods that has been enab... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index e08dbc61f5e..5797fd60da0 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -1823,7 +1823,6 @@ pub async fn list_payment_methods(
... | 2024-02-01T12:34:32Z |
## Description
ListPaymentMethodsForMerchant was unable to list the payment methods enabled as it was always taking mandate to have Some value even though its respective fields were None. So added a check that, if there's mandate_data present then only any data should be stored in the database
## Motivation and... | 54fb61eeebec503f599774fe9e97f6b6ce3f1458 | - Create MA and MCA
- Do a payment with confirm as false and then ListPaymentMethodsForMerchnats
> Earlier
> After fix
![Screenshot 2024-02-01 at 6 25 21 PM](https://github.com/ju... | [
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payments/operations/payment_create.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3522 | Bug: feat: resend user invite
Add support to resend invites to users. Currently we can invite the user or multiple users, but there is no support to invite the same user again.
The invitation mail will be send to user and user will be able to accept the invitation.
| diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs
index 04aabc071ae..d7150af9bc7 100644
--- a/crates/api_models/src/events/user.rs
+++ b/crates/api_models/src/events/user.rs
@@ -12,8 +12,8 @@ use crate::user::{
},
AuthorizeResponse, ChangePasswordRequest, ConnectAccountR... | 2024-02-01T12:20:14Z |
## Description
The new endpoint `/resend_invite`, add supports to send invitation to user again.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one fir... | 54fb61eeebec503f599774fe9e97f6b6ce3f1458 | To invite user:
```
curl --location 'http://localhost:8080/user/user/invite' \
--header 'Authorization: Bearer JWT' \
--header 'Content-Type: application/json' \
--data-raw '{
"email": "test_2@juspay.in",
"name": "test2",
"role_id": "merchant_admin"
}
'
```
For resend invite:
```
curl --loca... | [
"crates/api_models/src/events/user.rs",
"crates/api_models/src/user.rs",
"crates/router/src/core/user.rs",
"crates/router/src/routes/app.rs",
"crates/router/src/routes/lock_utils.rs",
"crates/router/src/routes/user.rs",
"crates/router_env/src/logger/types.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3518 | Bug: Deep health check for outgoing request
| diff --git a/crates/api_models/src/health_check.rs b/crates/api_models/src/health_check.rs
index 8323f135134..c1ab2a2d757 100644
--- a/crates/api_models/src/health_check.rs
+++ b/crates/api_models/src/health_check.rs
@@ -5,6 +5,7 @@ pub struct RouterHealthCheckResponse {
pub locker: bool,
#[cfg(feature = "ola... | 2024-02-01T06:29:21Z |
## Description
<!-- Describe your changes in detail -->
Closes #3518. Add healthcheck for outgoing calls
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with ... | 20efc3020ac389199eed13154f070685417ef82a |
- `curl --location 'http://localhost:8080/health/ready'`
<img width="907" alt="Screenshot 2024-02-01 at 11 58 57 AM" src="https://github.com/juspay/hyperswitch/assets/43412619/79ebea8f-4ab2-4d35-893d-60974f64b39f">
| [
"crates/api_models/src/health_check.rs",
"crates/router/src/consts.rs",
"crates/router/src/core/errors.rs",
"crates/router/src/core/health_check.rs",
"crates/router/src/routes/health.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3513 | Bug: [CHORE] Add file storage config in env_specific toml
### Feature Description
Add file storage config in env_specific.toml
### Possible Implementation
Add file storage config in env_specific.toml
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn'... | diff --git a/config/deployments/env_specific.toml b/config/deployments/env_specific.toml
index 354c320e8f5..04831376050 100644
--- a/config/deployments/env_specific.toml
+++ b/config/deployments/env_specific.toml
@@ -70,9 +70,13 @@ api_logs_topic = "topic" # Kafka topic to be used for incoming api
connect... | 2024-01-31T16:03:36Z |
## Description
<!-- Describe your changes in detail -->
This PR adds file storage config in `env_specific.toml`
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starti... | 7251f6474fdac3575202971e55638c435ca5c4c8 |
Cannot be tested as this is just a config addition
| [
"config/deployments/env_specific.toml"
] | |
juspay/hyperswitch | juspay__hyperswitch-3509 | Bug: [BUG] : Add noon applepay mandate configs
### Bug Description
Add noon Applepay mandate configs
### Have you spent some time checking if this bug has been raised before?
- [X] I checked and didn't find a similar issue
### Have you read the Contributing Guidelines?
- [X] I have read the [Contrib... | diff --git a/config/config.example.toml b/config/config.example.toml
index f7e9fa70f6e..007c671e9e4 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -383,6 +383,7 @@ bank_debit.becs = { connector_list = "gocardless" } # Mandate supported payment
bank_debit.sepa = { connector_list = "gocardle... | 2024-01-31T13:46:33Z |
##Description
Add Applepay Mandate configs for noon in all environments.
## Test Case
Applepay should appear in the payment method list | 20efc3020ac389199eed13154f070685417ef82a | [
"config/config.example.toml",
"config/deployments/integration_test.toml",
"config/deployments/production.toml",
"config/deployments/sandbox.toml",
"config/docker_compose.toml"
] | ||
juspay/hyperswitch | juspay__hyperswitch-3558 | Bug: feat(analytics): refunds and disputes audit rail
| diff --git a/crates/analytics/src/api_event/events.rs b/crates/analytics/src/api_event/events.rs
index eb9b2d561c5..4be3a3420da 100644
--- a/crates/analytics/src/api_event/events.rs
+++ b/crates/analytics/src/api_event/events.rs
@@ -33,9 +33,30 @@ where
.add_filter_clause("merchant_id", merchant_id)
.... | 2024-01-31T06:47:14Z |
## Description
<!-- Describe your changes in detail -->
added api_logs for refunds and disputes and same for connector_outgoing_events and webhook_events logs.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
... | fbe84b2a334cfb744ae4f27b1eadc892c7f9b164 |
to test api_events for refunds
```curl
curl --location '<base_url>/analytics/v1/api_event_logs?type=Refund&payment_id=<payment_id>&refund_id=<refund_id>' \
--header 'Accept: */*' \
--header 'Accept-Language: en-GB,en-US;q=0.9,en;q=0.8' \
--header 'Connection: keep-alive' \
--header 'Content-Type: application/j... | [
"crates/analytics/src/api_event/events.rs",
"crates/api_models/src/analytics/api_event.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3493 | Bug: [BUG] : Add iDEAL and Sofort mandate configs to env files
### Expected Behavior
payment method list includes iDeal and Sofort for a mandate payment
### Actual Behavior
payment method list don't include iDeal and Sofort for a mandate payment.
### Have you spent some time checking if this bug has... | diff --git a/config/deployments/integration_test.toml b/config/deployments/integration_test.toml
index d377b3359c9..b84546eff34 100644
--- a/config/deployments/integration_test.toml
+++ b/config/deployments/integration_test.toml
@@ -117,6 +117,8 @@ pay_later.klarna.connector_list = "adyen"
wallet.apple_pay.connector_l... | 2024-01-30T09:20:44Z | 87191d687cd66bf096bfb98ffe51a805b4b76a03 | [
"config/deployments/integration_test.toml",
"config/deployments/production.toml",
"config/deployments/sandbox.toml"
] | |||
juspay/hyperswitch | juspay__hyperswitch-3494 | Bug: [FEATURE]: [Noon] Implement Revoke Mandate
### Feature Description
When revoke mandate api is triggered, revoke the existing connector mandate with noon also
### Possible Implementation
Implement Revoke Mandate for Noon
### Have you spent some time checking if this feature request has been raised before?
-... | diff --git a/crates/router/src/connector/noon.rs b/crates/router/src/connector/noon.rs
index 180b4b1485f..6c98a307637 100644
--- a/crates/router/src/connector/noon.rs
+++ b/crates/router/src/connector/noon.rs
@@ -46,6 +46,7 @@ impl api::Refund for Noon {}
impl api::RefundExecute for Noon {}
impl api::RefundSync for N... | 2024-01-30T07:57:22Z |
## Description
<!-- Describe your changes in detail -->
Implement revoke mandate flow for Noon
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first... | 937aea906e759e6e8a76a424db99ed052d46b7d2 |
- Create Mandate with the Noon
- Test Recurring Payment using mandate_id
- Revoke the mandate and check at connector if it is revoked or not.
<img width="928" alt="Screenshot 2024-01-30 at 12 40 51 PM" src="https://github.com/juspay/hyperswitch/assets/55536657/365fd0a3-5992-44ec-a43f-ce2616ad40ba">
<img width... | [
"crates/router/src/connector/noon.rs",
"crates/router/src/connector/noon/transformers.rs",
"crates/router/src/core/payments/flows.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3490 | Bug: Send Email to biz@hyperswitch.io at every prod intent
| diff --git a/crates/router/src/consts/user.rs b/crates/router/src/consts/user.rs
index c570aca7603..1cda969f780 100644
--- a/crates/router/src/consts/user.rs
+++ b/crates/router/src/consts/user.rs
@@ -1,2 +1,3 @@
pub const MAX_NAME_LENGTH: usize = 70;
pub const MAX_COMPANY_NAME_LENGTH: usize = 70;
+pub const BUSINESS... | 2024-01-29T15:48:48Z |
## Description
Sending an email to biz@hyperswitch.io whenever a new Prod Intent will be filled.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one fi... | 58771b8985a53c83185805f770fee26c5836c645 |
```
curl --location 'http://localhost:8080/user/data' \
--header 'api-key: hyperswitch' \
--header 'Content-Type: text/plain' \
--header 'Authorization: Bearer JWT' \
--data-raw '{
"ProdIntent": {
"poc_email": "---",
"is_completed": true,
"legal_business_name": "---",
"... | [
"crates/router/src/consts/user.rs",
"crates/router/src/core/user/dashboard_metadata.rs",
"crates/router/src/services/email/assets/bizemailprod.html",
"crates/router/src/services/email/types.rs",
"crates/router/src/utils/user/dashboard_metadata.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3480 | Bug: fix(invite): change status to active after resetting the password for invitee
| diff --git a/crates/diesel_models/src/query/user.rs b/crates/diesel_models/src/query/user.rs
index b4d5976ba29..6fb5b79ddc1 100644
--- a/crates/diesel_models/src/query/user.rs
+++ b/crates/diesel_models/src/query/user.rs
@@ -3,7 +3,7 @@ use diesel::{
associations::HasTable, debug_query, result::Error as DieselErro... | 2024-01-29T12:53:52Z |
## Description
<!-- Describe your changes in detail -->
This PR will add an optional `merchant_id` field in `EmailToken` struct. And also changes the status of the user from `invitation_sent` to `active` if the `EmailToken` has `merchant_id`.
## Motivation and Context
<!--
Why is this change required? What pro... | dfb14a34c96ba05e7ff1993fdcd97ee294c02d65 |
Postman.
1. Invite a user using this curl
```
curl --location 'http://localhost:8080/user/user/invite' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer JWT' \
--data-raw '{
"email": "new email",
"name": "user name",
"role_id": "merchant_admin"
}'
```
You... | [
"crates/diesel_models/src/query/user.rs",
"crates/router/src/core/user.rs",
"crates/router/src/db/kafka_store.rs",
"crates/router/src/db/user.rs",
"crates/router/src/services/email/types.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3491 | Bug: feat(logging): add flow field to logging framework
Add API Flow field to the root span & persistent keys | diff --git a/crates/router/src/middleware.rs b/crates/router/src/middleware.rs
index 587a15693f2..702c3c70e6c 100644
--- a/crates/router/src/middleware.rs
+++ b/crates/router/src/middleware.rs
@@ -58,7 +58,7 @@ where
let request_id = request_id_fut.await?;
let request_id = request_id.a... | 2024-01-29T11:50:23Z |
## Description
<!-- Describe your changes in detail -->
- Adding flow to the persistent keys in subscriber layer
- Adding flow to the middle ware log
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don... | a9638d118e0b68653fef3bec2ce8aa3c47feedd3 |
run the application locally
all api requests should have the following log line at the end of request
- the fields should be populated when available
- These log line will be generated even for health & non-existent paths (e.g `/` or `/favicon.ico`)
```json
{
"message": "[GOLDEN_LOG_LINE - EVENT] REQUES... | [
"crates/router/src/middleware.rs",
"crates/router_env/src/logger/storage.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3468 | Bug: feat: blacklist user
Setup user blacklisting. | diff --git a/crates/router/src/analytics.rs b/crates/router/src/analytics.rs
index 3f0febcc592..325ca980243 100644
--- a/crates/router/src/analytics.rs
+++ b/crates/router/src/analytics.rs
@@ -21,7 +21,7 @@ pub mod routes {
routes::AppState,
services::{
api,
- authentication::{... | 2024-01-29T10:37:22Z |
## Description
Added blacklist for users.
<!-- Describe your changes in detail -->
## Motivation and Context
Invalidate the token after logout.
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recomme... | d2accdef410319733d6174057bdca468bde1ae83 | Use the below api to logout.
```
curl --location --request POST '<URL>/user/signout' \
--header 'Authorization: Bearer JWT'
```
When you use the same token as above to test any other api then response will be `401`.
| [
"crates/router/src/analytics.rs",
"crates/router/src/consts.rs",
"crates/router/src/core/user.rs",
"crates/router/src/routes/app.rs",
"crates/router/src/routes/lock_utils.rs",
"crates/router/src/routes/user.rs",
"crates/router/src/services/authentication.rs",
"crates/router/src/services/authentication... | |
juspay/hyperswitch | juspay__hyperswitch-3484 | Bug: fix: Change permissions for sample data
Change permission for Sample data to `PaymentWrite` instead of `MerchantAccountWrite` | diff --git a/crates/router/src/routes/lock_utils.rs b/crates/router/src/routes/lock_utils.rs
index 4cd85efe8d5..2837c1defa4 100644
--- a/crates/router/src/routes/lock_utils.rs
+++ b/crates/router/src/routes/lock_utils.rs
@@ -179,7 +179,6 @@ impl From<Flow> for ApiIdentifier {
| Flow::ResetPassword
... | 2024-01-25T14:36:39Z |
## Description
- Change permission for sample data generate and delete. Currently it is Merchants write but is as per new use case it should be Payment Write only.
- Change the flow name for delete user (it is delete user role as per functionality)
## Motivation and Context
Permission for sample data needs to b... | d2accdef410319733d6174057bdca468bde1ae83 | Tested locally
- singup
- generate sample data
- delete sample data
Curl to generate and delete sample data:
```
curl --location 'http://localhost:8080/user/sample_data' \
--header 'Content-Type: application/json' \
--header 'Cookie: token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWZjNzgyOTUtM2JiMy0... | [
"crates/router/src/routes/lock_utils.rs",
"crates/router/src/routes/user.rs",
"crates/router/src/routes/user_role.rs",
"crates/router_env/src/logger/types.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3443 | Bug: [REFACTOR] Inclusion of kill switch in `configs` table
## Description
This refactor will ensure to be presence of a kill switch(merchant-wise) for Blocklist Feature.
We will always check for a Boolean entry in `configs` table i.e `guard_blocklist_for_{merchant_id}` and all the blocklist flows(validation & fin... | diff --git a/crates/router/src/core/payments/operations/payment_confirm.rs b/crates/router/src/core/payments/operations/payment_confirm.rs
index c81145c5de7..eba32ca0a53 100644
--- a/crates/router/src/core/payments/operations/payment_confirm.rs
+++ b/crates/router/src/core/payments/operations/payment_confirm.rs
@@ -719... | 2024-01-25T10:04:30Z |
## Description
<!-- Describe your changes in detail -->
This will allow us to enable and disable the blocklist feature based on each merchant's requirements.
The steps to test out this feature can be found in the mentioned issue.
## Motivation and Context
<!--
Why is this change required? What problem does it... | 61439533594f93287f15aaffb5d65ed12e77e7ec | [
"crates/router/src/core/payments/operations/payment_confirm.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-3457 | Bug: [BUG] [HELCIM] 5XX Error Happening If Wrong Api Key Is Passed
### Bug Description
If wrong `api_key` is passed during `Payment Connector - Create` for connector Helcim then the server throws 5XX error when you create a payment.
### Expected Behavior
The connector should handle the error thrown during ... | diff --git a/crates/router/src/connector/helcim.rs b/crates/router/src/connector/helcim.rs
index c3a6c5e9f50..0b2cac5d766 100644
--- a/crates/router/src/connector/helcim.rs
+++ b/crates/router/src/connector/helcim.rs
@@ -128,9 +128,12 @@ impl ConnectorCommon for Helcim {
.response
.parse_struc... | 2024-01-25T09:51:47Z |
## Description
<!-- Describe your changes in detail -->
Earlier if wrong api_key is passed during Payment Connector - Create for connector Helcim then the server throws 5XX error when you create a payment.
The connector will now handle the error thrown during Payments - Create if wrong api_key is passed during Pa... | c2946cfe05ffa81a66643e04eff5e89b545d2d43 |
1. Testing can be done by creating a payment with wrong api credentials. You should get the following error.
```curl
curl --location 'http://localhost:8080/payments' \
--header 'Con... | [
"crates/router/src/connector/helcim.rs",
"crates/router/src/connector/helcim/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3454 | Bug: fix(connector): fix connector template script
In Recent changes, get_request_body return type was changed and connector template script was not modified .This pr fixes the connector template script.
<img width="824" alt="Screenshot 2024-01-25 at 1 12 36 PM" src="https://github.com/juspay/hyperswitch/assets/... | diff --git a/connector-template/mod.rs b/connector-template/mod.rs
index 6258d437076..c64ce431968 100644
--- a/connector-template/mod.rs
+++ b/connector-template/mod.rs
@@ -167,10 +167,8 @@ impl
req.request.amount,
req,
))?;
- let req_obj = {{project-name | downcase... | 2024-01-25T07:18:33Z |
## Description
<!-- Describe your changes in detail -->
In Recent changes, `get_request_body` return type was changed and connector template script was not modified .This pr fixes the connector template script.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes... | b45e4ca2a3788823701bdeac2e2a8c1147bb071a |
run `sh scripts/add_connector.sh example [<connector-base-url>](https://www.google.com/)` on oss branch and it should compile with no errors.
<img width="1138" alt="Screenshot 2024-01-25 at 12 32 22 PM" src="https://github.com/juspay/hyperswitch/assets/121822803/d4e75efc-5967-4b0f-8bc0-0f3bac0b955b">
| [
"connector-template/mod.rs"
] |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.