repo
stringclasses
1 value
instance_id
stringlengths
22
24
problem_statement
stringlengths
30
24.1k
patch
stringlengths
0
1.9M
test_patch
stringclasses
1 value
created_at
stringdate
2022-11-25 05:12:07
2025-06-13 10:24:29
hints_text
stringlengths
0
228k
base_commit
stringlengths
40
40
test_instructions
stringlengths
0
232k
filenames
listlengths
0
300
juspay/hyperswitch
juspay__hyperswitch-4590
Bug: feat: new apis for accept invite and list merchant - new JWT auth based api for accept invite api - new SPT auth based api for list merchants - send accept invite from email instead of reset password for newly invited users
diff --git a/crates/api_models/src/events/user_role.rs b/crates/api_models/src/events/user_role.rs index 0d42d1de7d6..34375a22848 100644 --- a/crates/api_models/src/events/user_role.rs +++ b/crates/api_models/src/events/user_role.rs @@ -7,7 +7,7 @@ use crate::user_role::{ UpdateRoleRequest, }, Accept...
2024-05-08T13:34:50Z
## Description This PR: - adds new route to accept invite from dashboard with JWT Auth - adds new routes to get list of merchants to select for user, SPT Auth - modifies to send accept invite from email instead of set password for new user in token only flow ## Motivation and Context Closes [#4590](https://...
f386f423c0e5fac55a24756d7ee7a3ce1c20fb13
**To accept invite from inside dashboard** ``` curl --location --request PUT 'http://localhost:8080/user/user/invite/accept' \ --header 'Content-Type: application/json' \ --header 'Authorization: Bearer JWT' \ --data '{ "merchant_ids": [ "merchant_175173995" ] }' ``` Response will be 200 Ok ...
[ "crates/api_models/src/events/user_role.rs", "crates/api_models/src/user_role.rs", "crates/router/src/core/user.rs", "crates/router/src/core/user_role.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "crates/router/src/routes/user_ro...
juspay/hyperswitch
juspay__hyperswitch-4588
Bug: [BUG] A duplicate field exists in authentication table ### Bug Description A duplicate field exists in authentication table(`three_ds_server_trans_id`) which is never populated. But is read during authentication response creation. Which results in null being returned all the time.### ### Expected Behavior S...
diff --git a/crates/diesel_models/src/authentication.rs b/crates/diesel_models/src/authentication.rs index 8840d287e54..ce2f02d087f 100644 --- a/crates/diesel_models/src/authentication.rs +++ b/crates/diesel_models/src/authentication.rs @@ -38,7 +38,6 @@ pub struct Authentication { pub challenge_request: Option<St...
2024-05-08T11:56:22Z
## Description <!-- Describe your changes in detail --> there are two fields in `authentication`(`three_ds_server_trans_id` and `threeds_server_transaction_id`) table that hold the same data. Removed `three_ds_server_trans_id` column which is not being populated at all. This caused confusion and as a result we w...
339da8b0c9a1e388b65ff5d82a162e758c85ec6b
Manual. Create a merchant with netcetera authentication connector and checkout payment connector 1. create a payment with "request_external_three_ds_authentication": true, ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ ...
[ "crates/diesel_models/src/authentication.rs", "crates/diesel_models/src/schema.rs", "crates/router/src/core/authentication/utils.rs", "crates/router/src/db/authentication.rs", "crates/router/src/types/api/authentication.rs", "migrations/2024-05-08-111348_delete_unused_column_from_authentication/down.sql",...
juspay/hyperswitch
juspay__hyperswitch-4586
Bug: [BUG] Fix card expiry for savecard flows in cypresss ### Bug Description -Resolved an issue in the savecard flow where card expiry was incorrectly sourced from the confirmBody.json, resulting in failures. Now, only the payment_token is utilized, ensuring successful payment transactions. ### Expected Behavior ...
2024-05-08T10:40:50Z
## Description -Resolved an issue in the savecard flow where card expiry was incorrectly sourced from the confirmBody.json, resulting in failures. Now, only the payment_token is utilized, ensuring successful payment transactions. -This pull request includes refactoring of the card_pm details to accommodate the add...
339da8b0c9a1e388b65ff5d82a162e758c85ec6b
Ran the test manually <img width="762" alt="Screenshot 2024-05-08 at 3 56 21 PM" src="https://github.com/juspay/hyperswitch/assets/118818938/3981f38d-0276-41c2-9b06-5d5db02f1dc5">
[]
juspay/hyperswitch
juspay__hyperswitch-4579
Bug: fix: verify email in decision manger Currently decision manager is giving verify email flow for users who are already verified but not for users who are not verified. This should be other way around.
diff --git a/crates/router/src/types/domain/user/decision_manager.rs b/crates/router/src/types/domain/user/decision_manager.rs index d635ac064fe..5a0388c7f36 100644 --- a/crates/router/src/types/domain/user/decision_manager.rs +++ b/crates/router/src/types/domain/user/decision_manager.rs @@ -42,7 +42,7 @@ impl SPTFlow ...
2024-05-08T07:09:15Z
## Description <!-- Describe your changes in detail --> - Currently decision manager is giving verify email flow for users who are already verified but not for users who are not verified. This should be other way around, so condition is negated. ## Motivation and Context <!-- Why is this change required? What ...
625b53182e20b50fde5def338e122a43457da0f2
As of now, this is only testable in local env. I've removed TOTP from decision manager and directly went to verify email flow. Previously verify email flow is coming for only verified users, after this change it is coming for only non-verified users. ``` curl --location 'http://localhost:8080/user/from_email' \ ...
[ "crates/router/src/types/domain/user/decision_manager.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4576
Bug: feat: Begin TOTP API There should be an API which should tell whether the TOTP for the user is set or not, if not, the API should respond back with TOTP secrets (url, recovery_codes and secret) which FE uses to help user to setup TOTP in their authenticator application. This API should work with the Decision m...
diff --git a/Cargo.lock b/Cargo.lock index 84fdee38021..b823f9e5c96 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1430,6 +1430,12 @@ dependencies = [ "rustc-demangle", ] +[[package]] +name = "base32" +version = "0.4.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "23ce669cd6c8588f79...
2024-05-07T17:02:03Z
## Description <!-- Describe your changes in detail --> - This PR adds a new table `user_key_store`, which stores the encryption keys for the user's secrets. - A new API `begin_totp` has been added, which will check if the user has setup the TOTP or not, and respond with TOTP secret which user has to scan to setup ...
339da8b0c9a1e388b65ff5d82a162e758c85ec6b
```curl curl --location 'http://localhost:8080/user/totp/begin' \ --header 'Authorization: Bearer SPT with purpose as totp' \ ``` If user hasn't setup TOTP, then the response should be like this: ```json { "secret": { "secret": "EL63X66IYIK2KHIH7DPRYLQTKLUGZMN2", "totp_url": "otpauth://...
[ "Cargo.lock", "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/diesel_models/src/enums.rs", "crates/diesel_models/src/lib.rs", "crates/diesel_models/src/query.rs", "crates/diesel_models/src/query/user_key_store.rs", "crates/diesel_models/src/schema.rs", "crates/diesel...
juspay/hyperswitch
juspay__hyperswitch-4575
Bug: feat: User key store As we are focusing on security aspects of users, we are going to encrypt emails of the users and also create 2FA. For these two, we need to encrypt some data and store it, and to be able to decrypt that data, we need to store the keys. As keys should not be same for all the users, we need ...
diff --git a/Cargo.lock b/Cargo.lock index 84fdee38021..b823f9e5c96 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1430,6 +1430,12 @@ dependencies = [ "rustc-demangle", ] +[[package]] +name = "base32" +version = "0.4.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "23ce669cd6c8588f79...
2024-05-07T17:02:03Z
## Description <!-- Describe your changes in detail --> - This PR adds a new table `user_key_store`, which stores the encryption keys for the user's secrets. - A new API `begin_totp` has been added, which will check if the user has setup the TOTP or not, and respond with TOTP secret which user has to scan to setup ...
339da8b0c9a1e388b65ff5d82a162e758c85ec6b
```curl curl --location 'http://localhost:8080/user/totp/begin' \ --header 'Authorization: Bearer SPT with purpose as totp' \ ``` If user hasn't setup TOTP, then the response should be like this: ```json { "secret": { "secret": "EL63X66IYIK2KHIH7DPRYLQTKLUGZMN2", "totp_url": "otpauth://...
[ "Cargo.lock", "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/diesel_models/src/enums.rs", "crates/diesel_models/src/lib.rs", "crates/diesel_models/src/query.rs", "crates/diesel_models/src/query/user_key_store.rs", "crates/diesel_models/src/schema.rs", "crates/diesel...
juspay/hyperswitch
juspay__hyperswitch-4573
Bug: [REFACTOR] remove `Ctx` generic from payments core Remove the `Ctx` generic being used in payments core as this is not required anymore
diff --git a/.typos.toml b/.typos.toml index 642eaded60e..3223e799cc3 100644 --- a/.typos.toml +++ b/.typos.toml @@ -36,6 +36,7 @@ ws = "ws" # Web socket ws2ipdef = "ws2ipdef" # WinSock Extension ws2tcpip = "ws2tcpip" # WinSock Extension ZAR = "ZAR" # South African Rand currency code +JOD = "JOD" # Jordan currency ...
2024-05-07T15:41:05Z
## Description <!-- Describe your changes in detail --> This PR removes the `Ctx` generic being used in payments core as this is not required anymore. This PR also fixes the failing typos CI check ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issu...
59e79ff205dfc2fded993b7a9130b9953bdd07e2
As this PR just removes the `Ctx` generic, basic sanity testing should suffice
[ ".typos.toml", "crates/router/src/compatibility/stripe/payment_intents.rs", "crates/router/src/compatibility/stripe/setup_intents.rs", "crates/router/src/connector/rapyd/transformers.rs", "crates/router/src/core/fraud_check.rs", "crates/router/src/core/fraud_check/operation/fraud_check_post.rs", "crates...
juspay/hyperswitch
juspay__hyperswitch-4572
Bug: Refactoring card fields in default.rs add missing card default data fields in default.rs
diff --git a/crates/router/src/configs/defaults.rs b/crates/router/src/configs/defaults.rs index 3d4d56b45c5..4fcdd76992e 100644 --- a/crates/router/src/configs/defaults.rs +++ b/crates/router/src/configs/defaults.rs @@ -626,6 +626,53 @@ impl Default for super::settings::RequiredFields { ...
2024-05-07T13:08:12Z
## Description added missing card data fields for connectors Braintree,Square and Billwerk and DummyConnectors , fields are card_number, expiry_month, expiry_year and cvv <!-- Describe your changes in detail --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fi...
cf0e3daeaa1dfdfa00d4cccdff5b845ac368bcb9
1. Create Merchant a Account 2. Create API key 3. Create payout/payment connector 4. check in payment method list for square request: ``` curl --location 'http://127.0.0.1:8080/account/payment_methods' \ --header 'Accept: application/json' \ --header 'api-key: {{apikey}}' ``` response payment method defau...
[ "crates/router/src/configs/defaults.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4567
Bug: Store `card_cvc` in extended_card_info and extend max ttl Currently, the extended_card_info payload that is sent to merchant does not contain cvc. Include cvc too in the payload and extend the max ttl for the feature to be 2 hrs (7200 seconds)
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index 75bd2a31d8e..13ad6b282e6 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -1113,7 +1113,7 @@ pub struct ExtendedCardInfoConfig { #[schema(value_type = String)] pub public_key: Secret<String>, ...
2024-05-07T10:37:43Z
## Description <!-- Describe your changes in detail --> This PR includes `card_cvc` field too to be sent to merchant as part of extended card info. Also extends the maximum ttl for the feature from 1hr to 2hr. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes ...
99bbc3982fa30f6ffd43334b1fa5da963975fe93
1. When tried to configure ttl more than 2 hrs ![image](https://github.com/juspay/hyperswitch/assets/70657455/6d000970-fa1f-452f-8d0a-cd02e6a2c054) 2. Extended card info decrypted after storing cvc ![image](https://github.com/juspay/hyperswitch/assets/70657455/19fd9ce4-e4bb-465f-9df2-b54dc3b59e23)
[ "crates/api_models/src/admin.rs", "crates/api_models/src/payments.rs", "crates/common_utils/src/consts.rs", "openapi/openapi_spec.json" ]
juspay/hyperswitch
juspay__hyperswitch-4566
Bug: Fix deserialization errors for sdk_eligible_payment_methods ### Feature Description fix deserialization errors for sdk_eligible_payment_methods ### Possible Implementation A small fix ### Have you spent some time checking if this feature request has been raised before? - [X] I checked and didn't find a sim...
diff --git a/config/config.example.toml b/config/config.example.toml index b5585a84b32..f0dad483c65 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -615,4 +615,4 @@ refunds = "hyperswitch-refund-events" disputes = "hyperswitch-dispute-events" [saved_payment_methods] -sdk_eligible_payment...
2024-05-07T05:01:17Z
## Description <!-- Describe your changes in detail --> Fix for deployment ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can fo...
76b76eccc6e8e6b9f095c55430a024e1b576bde5
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/router/src/configs/settings.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4411
Bug: Force password reset - Force user to change the password after certain amount of time. - Force user to set password after user lands to dashboard without setting his/her password (invite flow).
diff --git a/config/config.example.toml b/config/config.example.toml index f0dad483c65..c9fb0f34740 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -345,6 +345,9 @@ active_email_client = "SES" # The currently active email client email_role_arn = "" # The amazon resource name...
2024-05-06T19:48:55Z
## Description - Allow users to set password when newly signing in - Allow users to force change password after specified duration of time ## Motivation and Context Closes [#4411](https://github.com/juspay/hyperswitch/issues/4411) #
5ec00d96de49ae0e0f76c5b19e22db11e7db6dd2
Use the curl: ``` curl --location 'http://localhost:8080/user/rotate_password' \ --header 'Content-Type: application/json' \ --header 'Authorization: Bearer JWT' \ --data '{ "password": "new_password" }' ``` Response will 200 Ok for all successful password change. If current password and new password ...
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/common_enums/sr...
juspay/hyperswitch
juspay__hyperswitch-4780
Bug: Creating new email templates for Hyperswitch - Create Email templates as per new figma designs
diff --git a/crates/router/src/services/email/assets/api_key_expiry_reminder.html b/crates/router/src/services/email/assets/api_key_expiry_reminder.html index 772602d71e7..6ebb099ed74 100644 --- a/crates/router/src/services/email/assets/api_key_expiry_reminder.html +++ b/crates/router/src/services/email/assets/api_key_...
2024-05-06T12:17:36Z
## Description <!-- Describe your changes in detail --> - Updated the HTML templates to new designs in backend - Look at the below screenshots - Old ![image](https://github.com/juspay/hyperswitch/assets/96485413/4814c8b8-e23f-4425-873c-7095549df599) ![image](https://github.com/juspay/hyperswitch/assets/96485...
ccee1a9ce9e860bfa04e74329fb47fd73f010b23
- Tested using AWS SES email service & Postdrop, attached the screenshots Please find below curls for same : curl --location 'http://localhost:8080/user/connect_account' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "gitanjli524@gmail.com" }' curl --location 'http://localhos...
[ "crates/router/src/services/email/assets/api_key_expiry_reminder.html", "crates/router/src/services/email/assets/bizemailprod.html", "crates/router/src/services/email/assets/invite.html", "crates/router/src/services/email/assets/magic_link.html", "crates/router/src/services/email/assets/recon_activation.htm...
juspay/hyperswitch
juspay__hyperswitch-4556
Bug: feat: Create new versions of BE pre-login APIs Currently we've made SPT and decision starter APIs. Now we have to integrate SPT into email specific, signin and signup APIs. For backwards compatibility, old version should also need to be kept. So we can do these new APIs accessible with a query param.
diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs index 14676656d0f..b29b28f0136 100644 --- a/crates/api_models/src/events/user.rs +++ b/crates/api_models/src/events/user.rs @@ -14,8 +14,8 @@ use crate::user::{ CreateInternalUserRequest, DashboardEntryResponse, ForgotPassword...
2024-05-06T10:14:19Z
## Description <!-- Describe your changes in detail --> This PR will add new core functions for the following APIs which can be used with SPTs. 1. Accept Invite 2. Sign up 3. Verify Email 4. Accept Invite from Email ## Motivation and Context <!-- Why is this change required? What problem does it solve? If...
df2c2ca22dc4cea986cbbf30850311d3e85000c5
``` curl --location 'http://localhost:8080/user/signup?token_only=true' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "user email", "password": "password" }' ``` ``` curl --location 'http://localhost:8080/user/accept_invite_from_email?token_only=true' \ --header 'Content-Type:...
[ "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/api_models/src/user_role.rs", "crates/router/src/core/user.rs", "crates/router/src/core/user_role.rs", "crates/router/src/routes/user.rs", "crates/router/src/routes/user_role.rs", "crates/router/src/types/domain/user/deci...
juspay/hyperswitch
juspay__hyperswitch-4546
Bug: chore: address Rust 1.78 clippy lints Address the clippy lints occurring due to new rust version 1.78 See https://github.com/juspay/hyperswitch/issues/3391 for more information.
diff --git a/crates/analytics/src/clickhouse.rs b/crates/analytics/src/clickhouse.rs index 4d01c20972c..8f0d00cd799 100644 --- a/crates/analytics/src/clickhouse.rs +++ b/crates/analytics/src/clickhouse.rs @@ -453,7 +453,7 @@ where |(order_column, order)| format!( " ...
2024-05-03T14:36:33Z
## Description <!-- Describe your changes in detail --> This PR addresses the clippy lints occurring due to new rust version 1.78 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'...
71a070e26989f080031d92a88aa0143836d1ea7b
[ "crates/analytics/src/clickhouse.rs", "crates/analytics/src/lib.rs", "crates/analytics/src/payments/accumulator.rs", "crates/analytics/src/query.rs", "crates/analytics/src/refunds.rs", "crates/analytics/src/sdk_events.rs", "crates/analytics/src/sqlx.rs", "crates/analytics/src/types.rs", "crates/api_...
juspay/hyperswitch
juspay__hyperswitch-4543
Bug: Revert "fix(users): add password validations"
diff --git a/crates/router/src/consts/user.rs b/crates/router/src/consts/user.rs index f14610649f4..1cda969f780 100644 --- a/crates/router/src/consts/user.rs +++ b/crates/router/src/consts/user.rs @@ -1,5 +1,3 @@ pub const MAX_NAME_LENGTH: usize = 70; pub const MAX_COMPANY_NAME_LENGTH: usize = 70; pub const BUSINESS...
2024-05-03T13:55:22Z
Reverts juspay/hyperswitch#4489
d5d9006fbd8e32f822f1e84d486b8a4483164baa
[ "crates/router/src/consts/user.rs", "crates/router/src/types/domain/user.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4538
Bug: [BUG] [BAMBORA] Amount not being passed in Decimal format ### Bug Description For connector Bambora, the amount is not being passed in decimal format for Authorize, Capture and Refund requests. ### Expected Behavior For connector Bambora, the amount should be passed in decimal format for Authorize, Capture a...
diff --git a/crates/router/src/connector/bambora.rs b/crates/router/src/connector/bambora.rs index 0717b997bad..7ff352416cd 100644 --- a/crates/router/src/connector/bambora.rs +++ b/crates/router/src/connector/bambora.rs @@ -62,6 +62,10 @@ impl ConnectorCommon for Bambora { "bambora" } + fn get_curre...
2024-05-03T10:28:04Z
## Description <!-- Describe your changes in detail --> This PR contains the following changes for connector Bambora: - Only 2 digit i.e. `25` for `2025` card expiry year will be allowed be pass in Bambora Payments Request. - Amount will be passed in decimal format for Authorize, Capture and Refund requests. - ...
17b369cfabc42d4d06f65b92e967057dba348731
- Payments (Manual): Request: ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data '{ "amount": 2500, "currency": "USD", "confirm": true, "customer_id": "StripeCustomer", ...
[ "crates/router/src/connector/bambora.rs", "crates/router/src/connector/bambora/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4534
Bug: [BUG] [BAMBORA] Payments Failing Due to Wrong Card Expiry Year ### Bug Description Payments are failing for connector Bambora due to wrong format of card expiry year. ### Expected Behavior Only 2 digit i.e. `25` for `2025` card expiry year should be passed in Bambora Payments Request. ### Actual Beh...
diff --git a/crates/router/src/connector/bambora.rs b/crates/router/src/connector/bambora.rs index 0717b997bad..7ff352416cd 100644 --- a/crates/router/src/connector/bambora.rs +++ b/crates/router/src/connector/bambora.rs @@ -62,6 +62,10 @@ impl ConnectorCommon for Bambora { "bambora" } + fn get_curre...
2024-05-03T10:28:04Z
## Description <!-- Describe your changes in detail --> This PR contains the following changes for connector Bambora: - Only 2 digit i.e. `25` for `2025` card expiry year will be allowed be pass in Bambora Payments Request. - Amount will be passed in decimal format for Authorize, Capture and Refund requests. - ...
17b369cfabc42d4d06f65b92e967057dba348731
- Payments (Manual): Request: ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data '{ "amount": 2500, "currency": "USD", "confirm": true, "customer_id": "StripeCustomer", ...
[ "crates/router/src/connector/bambora.rs", "crates/router/src/connector/bambora/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4532
Bug: feat: Create a decision starter API for email flows As we have split the API flows, there is no API to trigger the email specific flows like Verify email, Accept invite from email, etc... For this API to work correctly, email token should have the information about the origin.
diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs index 594b60b5816..14676656d0f 100644 --- a/crates/api_models/src/events/user.rs +++ b/crates/api_models/src/events/user.rs @@ -15,8 +15,8 @@ use crate::user::{ GetUserDetailsResponse, GetUserRoleDetailsRequest, GetUserRoleDet...
2024-05-03T08:52:49Z
## Description <!-- Describe your changes in detail --> - Create a new API `from_email` which will take email token and give the token for the next flow. - Add `flow` field in email token which will help `from_email` API to decide the next flow. ## Motivation and Context <!-- Why is this change required? Wha...
83a192466849c5fd201296e7554644a025ced888
``` curl --location 'http://localhost:8080/user/from_email' \ --header 'Content-Type: application/json' \ --data '{ "token": "email token" }' ``` Response should be like this ``` { "token": "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMDYxNjE1YjAtZjI5Yi00NWIyLWJmNmItODczNTYyYWU1ODhlIiwicHVy...
[ "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "crates/router/src/services/email/types.rs", "crates/router/src/types/domain/user/...
juspay/hyperswitch
juspay__hyperswitch-4523
Bug: [FEATURE] Move struct RouterData to crate hyperswitch_domain_models ### Feature Description RouterData will move to crate `hyperswitch_domain_models`. ### Possible Implementation RouterData will be moved to crate `hyperswitch_domain_models`. ### Have you spent some time checking if this feature requ...
diff --git a/Cargo.lock b/Cargo.lock index b823f9e5c96..5ba2d0dae6d 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3647,6 +3647,7 @@ dependencies = [ "common_utils", "diesel_models", "error-stack", + "http 0.2.12", "masking", "serde", "serde_json", diff --git a/connector-template/mod.rs b/connector-template/m...
2024-05-02T13:10:45Z
## Description <!-- Describe your changes in detail --> RouterData moved to crate `hyperswitch_domain_models`. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend startin...
650f3fa25c4130a2148862863ff444d16b41d2f3
Basic testing is required for all the production connectors(and payment methods) on sandbox.
[ "Cargo.lock", "connector-template/mod.rs", "connector-template/transformers.rs", "crates/hyperswitch_domain_models/Cargo.toml", "crates/hyperswitch_domain_models/src/lib.rs", "crates/hyperswitch_domain_models/src/payment_address.rs", "crates/hyperswitch_domain_models/src/router_data.rs", "crates/route...
juspay/hyperswitch
juspay__hyperswitch-4517
Bug: feat: decision manger for user flows As we are going to split all the APIs, we need a way to get the next API that dashboard should go to using the current flow/origin. We need a decision manager that can take the current flow and origin and give the next flow.
diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs index 8f017ca8c20..594b60b5816 100644 --- a/crates/api_models/src/events/user.rs +++ b/crates/api_models/src/events/user.rs @@ -14,9 +14,9 @@ use crate::user::{ CreateInternalUserRequest, DashboardEntryResponse, ForgotPassword...
2024-05-02T07:47:50Z
## Description <!-- Describe your changes in detail --> - This PR will enable APIs to get the next flow from the current flow. - This PR will also add a query param which will enable to access the new flows. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes a...
6c59d2434ce5067611d85d37b7ec6f551b7ad81a
``` curl --location 'http://localhost:8080/user/v2/signin?token_only=true' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "email", "password": "password" }' ``` Should return with the following response ``` { "token": "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiM...
[ "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/common_enums/src/enums.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/user.rs", "crates/router/src/routes/user_role.rs", "crates/router/src/services/authentication.rs", "crates/router/src/services/authen...
juspay/hyperswitch
juspay__hyperswitch-4496
Bug: [REFACTOR] Update KafkaStore to hold variables for tenant ID Update the [`KafkaStore`](https://github.com/juspay/hyperswitch/blob/c20ecb855aa3c4b3ce1798dcc19910fb38345b46/crates/router/src/db/kafka_store.rs#L75-L79) to hold a variable for tenant-ID. This can be achieved by simply adding a new field in the `K...
diff --git a/crates/router/src/db.rs b/crates/router/src/db.rs index 9f9e61a5ffc..3ac9b3cc371 100644 --- a/crates/router/src/db.rs +++ b/crates/router/src/db.rs @@ -19,7 +19,7 @@ pub mod file; pub mod fraud_check; pub mod gsm; pub mod health_check; -mod kafka_store; +pub mod kafka_store; pub mod locker_mock_up; pu...
2024-05-02T04:45:42Z
#4496 - [ ] Bugfix - [ ] New feature - [ ] Enhancement - [X] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> - Add TenantId field to the KafkaStore struct - Add the tenant_id parameter to the constructor of Kafkastore #...
177fe1b8929260c5ee14f768eae4b7b29ad073ed
- no testable changes except CI checks
[ "crates/router/src/db.rs", "crates/router/src/db/kafka_store.rs", "crates/router/src/routes/app.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4509
Bug: feat(user): get user information (home api) Create new api to get user details.
diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs index 9884dbc4f41..8f017ca8c20 100644 --- a/crates/api_models/src/events/user.rs +++ b/crates/api_models/src/events/user.rs @@ -12,10 +12,11 @@ use crate::user::{ }, AcceptInviteFromEmailRequest, AuthorizeResponse, Change...
2024-04-30T14:02:54Z
## Description Add support to get user details! ## Motivation and Context closes #4509 #
b0133f33693575f2145d295eff78dd07b61efcda
Use the curl to get user info: ``` curl --location 'http://localhost:8080/user' \ --header 'Authorization: Bearer JWT' \ --data '' ``` Response will be, something like: ``` { "merchant_id": "merchant_1714396883", "name": "test1", "email": "apoorvdixit88+555@gmail.com", "verification_days_l...
[ "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "crates/router_env/src/logger/types.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4515
Bug: [FEATURE] Rename crate data_models to hyperswitch_domain_models ### Feature Description Crate `data_models` needs to be renamed to `hyperswitch_domain_models` ### Possible Implementation Rename crate `data_models` to `hyperswitch_domain_models` and update it's references in entire codebase. ### Have you spe...
diff --git a/Cargo.lock b/Cargo.lock index 635edcc995e..00c491d7101 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -337,11 +337,11 @@ dependencies = [ "aws-smithy-types 1.1.8", "bigdecimal", "common_utils", - "data_models", "diesel_models", "error-stack", "external_services", "futures 0.3.30", + "hyperswitch...
2024-04-30T08:58:44Z
## Description <!-- Describe your changes in detail --> This PR contains the following change: - Create `data_models` is renamed to `hyperswitch_domain_models` ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. ...
22cb01ac1ecc90eee464561e4e944aad5cb3ed61
Only crate renamed hence no testing required.
[ "Cargo.lock", "crates/analytics/Cargo.toml", "crates/analytics/src/opensearch.rs", "crates/data_models/Cargo.toml", "crates/data_models/README.md", "crates/data_models/src/errors.rs", "crates/data_models/src/lib.rs", "crates/data_models/src/mandates.rs", "crates/data_models/src/payments.rs", "crat...
juspay/hyperswitch
juspay__hyperswitch-4502
Bug: [BUG] Fix failing postman tests for Paypal ### Bug Description Postman tests for Paypal fail in the access token flow. ### Expected Behavior All postman tests should pass ### Actual Behavior The tests fail ### Steps To Reproduce Run the paypal postman tests ### Context For The Bug _No response_ ### En...
diff --git a/postman/collection-dir/paypal/event.prerequest.js b/postman/collection-dir/paypal/event.prerequest.js index f4c9a764864..944aebeb6ee 100644 --- a/postman/collection-dir/paypal/event.prerequest.js +++ b/postman/collection-dir/paypal/event.prerequest.js @@ -3,25 +3,28 @@ const isPostRequest = pm.request.meth...
2024-04-30T07:39:01Z
## Description <!-- Describe your changes in detail --> This PR fixes a failing Paypal Postman test. The issue occurred because the `merchant_connector_id` was not being passed in the `routing` parameter in the request, which is not compatible with the access token flow currently. This PR adds the `merchant_connecto...
28df646830f544179b7cf00eb8f51de2a606bdbc
Running all Paypal postman tests locally. <img width="518" alt="image" src="https://github.com/juspay/hyperswitch/assets/47862918/48a79b42-2776-4021-86bb-c9137088ddc0">
[ "postman/collection-dir/paypal/event.prerequest.js", "postman/collection-json/paypal.postman_collection.json" ]
juspay/hyperswitch
juspay__hyperswitch-4497
Bug: refactor: use single purpose token and auth for accept invite - use single purpose JWT auth and single purpose token for accept invite - remove user without merchant JWT auth and user auth token
diff --git a/crates/router/src/core/user_role.rs b/crates/router/src/core/user_role.rs index b8399251530..3f913b88a3f 100644 --- a/crates/router/src/core/user_role.rs +++ b/crates/router/src/core/user_role.rs @@ -170,7 +170,7 @@ pub async fn transfer_org_ownership( pub async fn accept_invitation( state: AppStat...
2024-04-29T18:57:48Z
## Description - Use single purpose JWT auth and single purpose token for accept invite - Remove user without merchant JWT auth and user auth token ## Motivation and Context closes [#4497](https://github.com/juspay/hyperswitch/issues/4497) #
c20ecb855aa3c4b3ce1798dcc19910fb38345b46
- Enable email feature flag - Signup/ singin - Invite a new user from multiple accounts - Sign in to newly created user - The response should be merchant select, then do accept invite, it will give dashboard entry response. <img width="1267" alt="Screenshot 2024-04-29 at 9 23 52 PM" src="https://github.com/ju...
[ "crates/router/src/core/user_role.rs", "crates/router/src/routes/user_role.rs", "crates/router/src/services/authentication.rs", "crates/router/src/services/authentication/blacklist.rs", "crates/router/src/types/domain/user.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4482
Bug: Store encrypted raw card info in redis While the customer is making a payment, we’ll check whether the extended card info feature is enabled through profile_id in the business profile. If enabled, we’ll fetch the merchant public_key and ttl from config. We’ll encrypt the card using the public key and store it i...
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index d4d1b3d80b9..fde693a3700 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -1,6 +1,7 @@ use std::collections::HashMap; use common_utils::{ + consts, crypto::{Encryptable, OptionalEncryptableN...
2024-04-29T13:04:31Z
## Description <!-- Describe your changes in detail --> While the customer is making a payment, we’ll check whether the extended card info feature is enabled through `profile_id` in the business profile. If enabled, we’ll fetch the merchant `public_key` and `ttl` from config. We’ll encrypt the card using the public ...
4f4cbdff21b956b5939cdbe6a4f88f663e6b1281
1. Create merchant account (get default profile_id) 2. Create api key 3. Create mca (any connector) 4. Enable extended card info feature ``` curl --location 'http://localhost:8080/account/:merchant_id/business_profile/:profile_id/toggle_extended_card_info' \ --header 'Content-Type: application/json' \ --head...
[ "crates/api_models/src/admin.rs", "crates/api_models/src/payments.rs", "crates/common_utils/src/consts.rs", "crates/openapi/src/openapi.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/operations.rs", "crates/router/src/core/payments/operations/payment_confirm.rs", "openapi/...
juspay/hyperswitch
juspay__hyperswitch-4412
Bug: BE Password specification Make password have Minimum number of characters. At least one number, uppercase & lowercase characters and symbol. (This check is there in FE but not in BE).
diff --git a/crates/router/src/consts/user.rs b/crates/router/src/consts/user.rs index 1cda969f780..f14610649f4 100644 --- a/crates/router/src/consts/user.rs +++ b/crates/router/src/consts/user.rs @@ -1,3 +1,5 @@ pub const MAX_NAME_LENGTH: usize = 70; pub const MAX_COMPANY_NAME_LENGTH: usize = 70; pub const BUSINESS...
2024-04-29T11:12:01Z
## Description <!-- Describe your changes in detail --> Closes #4412 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus o...
86e93cd3a0f050c89a82be409b80dc2894143c9e
1. Signup API ( local testing) ``` curl --location 'http://localhost:8080/user/signup' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "email value", "password": "456667sdvh", "country": "IN" }' ``` Failure case response ``` { "error": { "type": "invalid_re...
[ "crates/router/src/consts/user.rs", "crates/router/src/types/domain/user.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4487
Bug: remove `configs/pg_agnostic_mit` api as it will not be used Remove the configs/pg_agnostic_mit api as there is a new api added to enabled the same feature in this https://github.com/juspay/hyperswitch/pull/4480. Also includes changes to read the is_connector_agnostic_mit flow form the business profile.
diff --git a/crates/api_models/src/routing.rs b/crates/api_models/src/routing.rs index 723e6eccc36..f3d966f3d9d 100644 --- a/crates/api_models/src/routing.rs +++ b/crates/api_models/src/routing.rs @@ -299,13 +299,6 @@ impl From<RoutableConnectorChoice> for ast::ConnectorChoice { } } -#[derive(Debug, Clone, serd...
2024-04-29T10:54:39Z
## Description <!-- Describe your changes in detail --> Remove the `configs/pg_agnostic_mit` api as there is a new api added to enabled the same feature in this [pr](https://github.com/juspay/hyperswitch/pull/4480). Also this pr includes changes to read the `is_connector_agnostic_mit` flow form the business profile....
f63a97024c755fd30a3403e2146812fe4edb8067
1) Creata Merchant account 2) Enable the `connector_agnostic_mit` flow for the `profile_id` ``` curl --location 'http://localhost:8080/account/:merchant_id/business_profile/:profile_id/toggle_connector_agnostic_mit' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'ap...
[ "crates/api_models/src/routing.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/operations.rs", "crates/router/src/core/payments/operations/payment_response.rs", "crates/router/src/core/payments/tokenization.rs", "crates/router/src/core/routing.rs", "crates/router/src/core/rou...
juspay/hyperswitch
juspay__hyperswitch-4488
Bug: [REFACTOR]: Remove payment_method_id from RouterData struct ### Feature Description This will remove the unused payment_method_id field from the Router_data, which is not at all used anywhere in our codebase, as we are storing the pm_id in payment_attempt. ### Possible Implementation Removal of `payment_meth...
diff --git a/crates/router/src/core/authentication/transformers.rs b/crates/router/src/core/authentication/transformers.rs index abefd12c77d..d4cad2fbedb 100644 --- a/crates/router/src/core/authentication/transformers.rs +++ b/crates/router/src/core/authentication/transformers.rs @@ -168,7 +168,6 @@ pub fn construct_ro...
2024-04-29T10:16:53Z
## Description <!-- Describe your changes in detail --> This will remove the unused `payment_method_id` field from the Router_data, which is not at all used anywhere in our codebase, as we are storing the pm_id in `payment_attempt`. ## Motivation and Context <!-- Why is this change required? What problem does ...
ac9d856add0220701f809c8eb0668afe77003ef7
Payment_Method_flows seems working (AE).
[ "crates/router/src/core/authentication/transformers.rs", "crates/router/src/core/fraud_check/flows/checkout_flow.rs", "crates/router/src/core/fraud_check/flows/fulfillment_flow.rs", "crates/router/src/core/fraud_check/flows/record_return.rs", "crates/router/src/core/fraud_check/flows/sale_flow.rs", "crate...
juspay/hyperswitch
juspay__hyperswitch-4483
Bug: extended_card_info API to retrieve encrypted card PAN New endpoint to retrieve the extended card info from redis given payment_id and api_key as auth
diff --git a/crates/api_models/src/events/payment.rs b/crates/api_models/src/events/payment.rs index b8f4a9d6d90..59e65c0605f 100644 --- a/crates/api_models/src/events/payment.rs +++ b/crates/api_models/src/events/payment.rs @@ -8,9 +8,10 @@ use crate::{ PaymentMethodResponse, PaymentMethodUpdate, }, ...
2024-04-29T09:54:36Z
## Description <!-- Describe your changes in detail --> This PR adds a new endpoint to retrieve the extended card info (encrypted) stored in redis under a given merchant and payment. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link...
3077a0d31e8d36f18e359f1edf9a742969601f6b
This PR cannot be tested until https://github.com/juspay/hyperswitch/issues/4482 goes in. For local testing I manually set redis entry and tried to hit this newly added endpoint. 1. Create merchant account and api key 2. Create a payment 3. Got the payment id and merchant id and set the redis entry ``` set mer...
[ "crates/api_models/src/events/payment.rs", "crates/api_models/src/payments.rs", "crates/openapi/src/openapi.rs", "crates/router/src/compatibility/stripe/errors.rs", "crates/router/src/core/errors/api_error_response.rs", "crates/router/src/core/errors/transformers.rs", "crates/router/src/core/payments.rs...
juspay/hyperswitch
juspay__hyperswitch-4479
Bug: Add an api to toggle `connector_agnostic_mit` feature Add api to toggle `connector_agnostic_mit` to enable usage of Network Transaction/Reference ID in recurring mandate payments. This will be a business profile level feature that a merchant specifies.
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index fde693a3700..75bd2a31d8e 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -1100,6 +1100,13 @@ pub struct ExtendedCardInfoChoice { impl common_utils::events::ApiEventMetric for ExtendedCardInfoChoice ...
2024-04-29T07:19:24Z
## Description <!-- Describe your changes in detail --> This pr adds a api to enable usage of Network Transaction/Reference ID in recurring MIT payments. This will be a business profile level feature that a merchant specifies. ## Motivation and Context <!-- Why is this change required? What problem does it sol...
5442574c08fcce57bebad2cfbf6547a9b824da58
1) Create a business profile for a merchant 2) Use the below curl to enable `connector_agnostic_mit` feature for the business profile ``` curl --location 'http://localhost:8080/account/:merchant_id/business_profile/:profile_id/toggle_connector_agnostic_mit' \ --header 'Content-Type: application/json' \ --header ...
[ "crates/api_models/src/admin.rs", "crates/diesel_models/src/business_profile.rs", "crates/diesel_models/src/schema.rs", "crates/router/src/core/admin.rs", "crates/router/src/routes/admin.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/types/api/admi...
juspay/hyperswitch
juspay__hyperswitch-4054
Bug: [REFACTOR]: [Bambora] Remove Default Case Handling ### :memo: Feature Description - We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector. - These conditions generally go hand in hand with enum ...
diff --git a/crates/router/src/connector/bambora/transformers.rs b/crates/router/src/connector/bambora/transformers.rs index 61ed8bd1ee4..a4c377cf9f9 100644 --- a/crates/router/src/connector/bambora/transformers.rs +++ b/crates/router/src/connector/bambora/transformers.rs @@ -6,7 +6,7 @@ use serde::{Deserialize, Deseri...
2024-04-28T17:42:42Z
## Description <!-- Describe your changes in detail --> As described in #4054, this pull request removes the default case handling in `crates/router/src/connector/bambora/transformers.rs`, handling each case explicitly. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If...
a0f11d79add17e0bc19d8677c90f8a35d6c99c97
[ "crates/router/src/connector/bambora/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4478
Bug: Include single purpose token and single purpose JWT auth Create single purpose token and single purpose JWT auth that will server as generic for intermediate tokens and can be used for different cases, during TOTP, change passwords, accept invite etc.
diff --git a/crates/router/src/consts.rs b/crates/router/src/consts.rs index c2a8669030b..2c4ec3f5e70 100644 --- a/crates/router/src/consts.rs +++ b/crates/router/src/consts.rs @@ -68,6 +68,8 @@ pub const LOCKER_REDIS_EXPIRY_SECONDS: u32 = 60 * 15; // 15 minutes pub const JWT_TOKEN_TIME_IN_SECS: u64 = 60 * 60 * 24 *...
2024-04-26T10:52:52Z
## Description Add single purpose token and authentication for single purpose token. This token will serves as a intermediate token and used to perform a certain action only. ## Motivation and Context Closes #4478 #
b2b9fab31dc838958e59a7a6755a0585d5a10302
This can be tested with upcoming PRs for reset password, TOTP, accept invite etc. Single purpose token and auth will be used for that. I also tested this locally, by changing auth type of change passwor and it was working as expected.
[ "crates/router/src/consts.rs", "crates/router/src/services/authentication.rs", "crates/router/src/services/authentication/blacklist.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4467
Bug: [FEATURE] [CRYPTOPAY] Report underpaid/overpaid amount in outgoing webhooks ### Feature Description During settlement, payments processed through the Cryptopay connector may experience underpayment or overpayment, leading to fluctuations in the payment amount. The revised amount must be communicated through ou...
diff --git a/crates/router/src/connector/cryptopay.rs b/crates/router/src/connector/cryptopay.rs index 2f9c996eff4..7245694bd44 100644 --- a/crates/router/src/connector/cryptopay.rs +++ b/crates/router/src/connector/cryptopay.rs @@ -287,11 +287,14 @@ impl ConnectorIntegration<api::Authorize, types::PaymentsAuthorizeDat...
2024-04-26T05:58:20Z
## Description <!-- Describe your changes in detail --> During settlement, payments processed through the Cryptopay connector may experience underpayment or overpayment, leading to fluctuations in the payment amount. The revised amount must be communicated through outgoing webhooks for the respective payment. The...
b2b9fab31dc838958e59a7a6755a0585d5a10302
We need to check for the `amount_received` in outgoing webhook for underpaid/overpaid payments via cryptopay. The `amount_received` should be equal to the `invoice amount` on cryptopay dashboard for that payment. In order to generate an underpaid/overpaid one must let the 10 min timer runout (on the redirection scre...
[ "crates/router/src/connector/cryptopay.rs", "crates/router/src/connector/cryptopay/transformers.rs", "crates/router/src/core/payments/transformers.rs", "crates/router/src/types.rs", "crates/router/tests/connectors/bambora.rs", "crates/router/tests/connectors/forte.rs", "crates/router/tests/connectors/ne...
juspay/hyperswitch
juspay__hyperswitch-4464
Bug: refactor: deprecate V1 signin, verify email and invite APIs Currently the following endpoints are not being used by the dashboard `/user/signin` `/user/verify_email` `/user/invite` New APIs are created for the above APIs which are `/user/v2/signin` `/user/v2/verify_email` `/user/invite_multiple` The old APIs ...
diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs index 4ef04981572..9884dbc4f41 100644 --- a/crates/api_models/src/events/user.rs +++ b/crates/api_models/src/events/user.rs @@ -12,9 +12,9 @@ use crate::user::{ }, AcceptInviteFromEmailRequest, AuthorizeResponse, ChangePa...
2024-04-25T09:18:00Z
## Description <!-- Describe your changes in detail --> This PR will remove the following endpoints and corresponding APIs `/user/signin` `/user/verify_email` `/user/invite` ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the...
2848e0a3e333ef292130abbeec362f092446270c
``` curl --location 'http://localhost:8080/user/signin' \ --header 'Content-Type: application/json' \ --data '{ "email": "user email", "password": "password" }' ``` ``` curl --location 'http://localhost:8080/user/verify_email' \ --header 'Content-Type: application/json' \ --data '{ "token"...
[ "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "crates/router_env/src/logger/types.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4461
Bug: [REFACTOR]: use `merchant_connector_id` for storing `access_token` The access tokens are currently stored in the format of `access_token_{merchant_id}_{connector_name}`. This cannot support multiple connector accounts. In order to store access tokens for multiple connector accounts in a single business profi...
diff --git a/crates/common_utils/src/access_token.rs b/crates/common_utils/src/access_token.rs new file mode 100644 index 00000000000..20bac0dafbb --- /dev/null +++ b/crates/common_utils/src/access_token.rs @@ -0,0 +1,11 @@ +//! Commonly used utilities for access token + +use std::fmt::Display; + +/// Create a key for ...
2024-04-25T08:20:54Z
## Description <!-- Describe your changes in detail --> This PR modifies the way in which access tokens are stored in the redis. The key format is changed to `access_token_{merchant_id}_{merchant_connector_id}` More information can be found in the linked issue. <!-- Provide links to the files with correspondin...
4c793c3c00e93ebf4a4db3439a213474ff57b54d
- Run the Trustpay postman collection locally and check whether the access token is stored in redis <img width="2056" alt="Screenshot 2024-04-25 at 1 56 18 PM" src="https://github.com/juspay/hyperswitch/assets/48803246/f527d6d4-4af9-49cf-8a3f-bf2fa6952d2c">
[ "crates/common_utils/src/access_token.rs", "crates/common_utils/src/lib.rs", "crates/router/src/core/payments/access_token.rs", "crates/router/src/db/kafka_store.rs", "crates/router/src/db/merchant_connector_account.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4491
Bug: [BUG] : update wasm 3ds metadata config ### Bug Description metadata config for 3ds are missing in the wasm. ### Expected Behavior 3ds metadata configs are missing so while updating the 3ds configuration in dashboard the data is not getting reflected in the dashboard ### Actual Behavior 3ds metadata confi...
diff --git a/crates/connector_configs/src/common_config.rs b/crates/connector_configs/src/common_config.rs index 495c0e5b6cc..b11a74a3ca6 100644 --- a/crates/connector_configs/src/common_config.rs +++ b/crates/connector_configs/src/common_config.rs @@ -87,6 +87,9 @@ pub struct ApiModelMetaData { pub merchant_name:...
2024-04-25T08:14:42Z
## Description <!-- Describe your changes in detail --> The dashboard encountered an issue creating a request for 3DS because the metadata configuration for 3DS in the WebAssembly (Wasm) code is missing. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an o...
ac9d856add0220701f809c8eb0668afe77003ef7
[ "crates/connector_configs/src/common_config.rs", "crates/connector_configs/src/response_modifier.rs", "crates/connector_configs/src/transformer.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4421
Bug: Accepting merchant public key and ttl for encrypting payload Collect `public_key` and `raw_card_ttl` and store it in `business_profile` table. Use update endpoint to achieve this
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index cfc9694dda3..d4d1b3d80b9 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -1042,6 +1042,9 @@ pub struct BusinessProfileUpdate { /// External 3DS authentication details pub authentication_con...
2024-04-24T16:14:18Z
## Description <!-- Describe your changes in detail --> This PR adds support for merchant to pass his public key as well as ttl using update endpoint of business profile. The config passed is stored in business profile table as JSONB. ## Motivation and Context <!-- Why is this change required? What problem doe...
c20ecb855aa3c4b3ce1798dcc19910fb38345b46
1. Create a business profile for a merchant (Default one which gets created during merchant account creation works too) 2. Use update endpoint of business profile to pass config. ``` curl --location 'http://localhost:8080/account/:merchant_id/business_profile/:profile_id' \ --header 'Content-Type: application/jso...
[ "crates/api_models/src/admin.rs", "crates/diesel_models/src/business_profile.rs", "crates/diesel_models/src/schema.rs", "crates/router/src/core/admin.rs", "crates/router/src/core/routing/helpers.rs", "crates/router/src/types/api/admin.rs", "migrations/2024-04-24-075735_add-merchant-pkey-ttl-to-business-...
juspay/hyperswitch
juspay__hyperswitch-4450
Bug: [BUG] Audit Wallets for Cybersource ### Bug Description Payment methods apple pay and google pay need to be audited for connector cybersource. ### Expected Behavior https://developer.cybersource.com/content/dam/docs/cybs/en-us/apple-pay/developer/fdiglobal/rest/applepay.pdf - `paymentInformation.flu...
diff --git a/crates/router/src/connector/cybersource.rs b/crates/router/src/connector/cybersource.rs index 5298420cde2..39079fe9f99 100644 --- a/crates/router/src/connector/cybersource.rs +++ b/crates/router/src/connector/cybersource.rs @@ -5,7 +5,7 @@ use std::fmt::Debug; use base64::Engine; use common_utils::reques...
2024-04-24T10:50:44Z
## Description <!-- Describe your changes in detail --> Following connector audit changes are done for wallets for connector Cybersource: - `paymentInformation.fluidData.descriptor` is passed in apple pay payments request - HTML Error Response from connector is handled ## Motivation and Context <!-- Why i...
1d0d94d5e6528534ce461db39620f35490582ecb
Manual flow apple payments need to be tested via cybersource. Request: ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data-raw '{ "amount": 1900, "currency": "USD", "con...
[ "crates/router/src/connector/cybersource.rs", "crates/router/src/connector/cybersource/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4449
Bug: Remove repetitive words ### Bug Description There are some repeated words in the code. Delete them to make the reading smoother and the code more elegant. For https://github.com/juspay/hyperswitch/pull/4448 ### Expected Behavior No ### Actual Behavior remove repetitive words ### Steps To Reproduce r...
diff --git a/config/config.example.toml b/config/config.example.toml index e8f40255697..1076cbdc196 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -286,7 +286,7 @@ cards = [ ] # Scheduler settings provides a point to modify the behaviour of scheduler flow. -# It defines the the streams/...
2024-04-24T07:44:14Z
The related issue: https://github.com/juspay/hyperswitch/issues/4449 ## Description <!-- Describe your changes in detail --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd...
56f14b935d5e9742a894408a714033318ecb6f2a
[ "config/config.example.toml", "config/deployments/scheduler/consumer.toml", "config/deployments/scheduler/producer.toml", "config/tempo.yaml", "crates/external_services/src/email.rs", "crates/router/src/connector/globalpay/requests.rs", "crates/router_env/src/metrics.rs", "loadtest/config/tempo.yaml" ...
juspay/hyperswitch
juspay__hyperswitch-4446
Bug: [FEATURE] Add toggle for extended card bin ### Feature Description Add toggle for displaying extended card bin in PaymentResposne ### Possible Implementation Add toggle for displaying extended card bin in PaymentResposne ### Have you spent some time checking if this feature request has been raised before? ...
diff --git a/crates/router/src/core/fraud_check.rs b/crates/router/src/core/fraud_check.rs index b62d3afd4a8..5e03033977e 100644 --- a/crates/router/src/core/fraud_check.rs +++ b/crates/router/src/core/fraud_check.rs @@ -243,10 +243,11 @@ where }) .colle...
2024-04-23T23:14:57Z
## Description Add profile level config to toggle the display for the extended card bin in Payment Response . ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting ...
5442574c08fcce57bebad2cfbf6547a9b824da58
- Create a MA and an MCA - Make a payment with the toggle for that profile_id as false, as it is default - In the response the card_bin_extended field will be null <img width="1049" alt="Screenshot 2024-04-24 at 4 13 09 AM" src="https://github.com/juspay/hyperswitch/assets/55580080/d1dd3166-de79-49fd-8c03-f115125db0...
[ "crates/router/src/core/fraud_check.rs", "crates/router/src/core/payments/helpers.rs", "crates/router/src/core/payments/operations/payment_confirm.rs", "crates/router/src/core/payments/operations/payment_create.rs", "crates/router/src/core/payments/operations/payment_update.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4420
Bug: System config for enabling this feature for a specific merchant (by business profile) Adding a feature flag at business profile level to enable raw card forwarding. Feature flag to be set using /profile/:id:/extended_card_info with auth as admin api key
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index 88d584b6a71..cfc9694dda3 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -1088,3 +1088,10 @@ pub struct PaymentLinkConfig { /// Enable saved payment method option for payment link pub enabled...
2024-04-23T18:11:17Z
## Description <!-- Describe your changes in detail --> This PR adds an api under `business_profile` domain, to toggle the `extended_card_info` feature with `admin_api_key` as auth. This PR also includes refactoring of `business_profile` updation approach. ## Motivation and Context <!-- Why is this change req...
776c1a7a24b494bf767c5524d1b8ac90472d32e2
1. Create a business profile for a merchant (Default one which gets created during merchant account creation works too) 2. Toggle extended card info feature ``` curl --location 'http://localhost:8080/account/:merchant_id/business_profile/:profile_id/toggle_extended_card_info' \ --header 'Content-Type: applicati...
[ "crates/api_models/src/admin.rs", "crates/diesel_models/src/business_profile.rs", "crates/diesel_models/src/query/business_profile.rs", "crates/diesel_models/src/schema.rs", "crates/router/src/core/admin.rs", "crates/router/src/core/routing/helpers.rs", "crates/router/src/db/business_profile.rs", "cra...
juspay/hyperswitch
juspay__hyperswitch-4437
Bug: [BUG] Failing unit tests for Routing ### Bug Description Certain unit tests in the `euclid` and `kgraph_utils` crates are failing. **euclid** ``` test dssa::analyzer::tests::test_exhaustive_negation_detection ... FAILED test frontend::dir::test::test_consistent_dir_key_naming ... FAILED ``` **kgraph_...
diff --git a/crates/euclid/src/dssa/analyzer.rs b/crates/euclid/src/dssa/analyzer.rs index 149ed1fd79c..4c615e78495 100644 --- a/crates/euclid/src/dssa/analyzer.rs +++ b/crates/euclid/src/dssa/analyzer.rs @@ -304,7 +304,7 @@ mod tests { & payment_method /= reward ...
2024-04-23T08:53:15Z
## Description <!-- Describe your changes in detail --> This PR fixes failing unit tests for routing, either by updating outdated tests, or resolving code discrepancies. See #4437 for more info on failing tests. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixe...
589cb4c9f94d6a410627d569aa5495d60ca763ae
All unit tests pass locally. Does not require any API tests.
[ "crates/euclid/src/dssa/analyzer.rs", "crates/euclid/src/frontend/dir.rs", "crates/kgraph_utils/src/mca.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4415
Bug: cookie implementation
diff --git a/crates/router/src/services/authentication.rs b/crates/router/src/services/authentication.rs index 5203b20c55b..03db3987eaa 100644 --- a/crates/router/src/services/authentication.rs +++ b/crates/router/src/services/authentication.rs @@ -611,19 +611,17 @@ where T: serde::de::DeserializeOwned, A: Ap...
2024-04-23T07:52:23Z
## Description Use cookie if present otherwise use `authorization` header for authentication. <!-- Describe your changes in detail --> ## Motivation and Context Use of cookie for authentication for better security. <!-- Why is this change required? What problem does it solve? If it fixes an open issue, ple...
589cb4c9f94d6a410627d569aa5495d60ca763ae
Use any JWT auth API with cookies. If cookie is present with `login_token` then app will use it for auth otherwise it will fallback to use `Authorization` header. Example curl, ```curl curl --location '<URL>/user/permission_info?groups=true' \ --header 'Cookie: login_token=<JWT>' ``` Above should give `200` wh...
[ "crates/router/src/services/authentication.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4432
Bug: router crate fails to build in WSL unless more memory is added I am part of a student team hoping to contribute to hyperswitch over the next several months. After following the instructions in `docs/try_local_system.md` for setting up a development environment using WSL, all members of my team encountered the s...
2024-04-23T01:50:08Z
## Description <!-- Describe your changes in detail --> This pull request adds a brief note to `docs/try_local_system.md`, under the section titled "Set up dependencies on Windows (Ubuntu on WSL2)," addressing an error that may occur when running `cargo build` from a WSL environment, and providing resources to help ...
589cb4c9f94d6a410627d569aa5495d60ca763ae
[]
juspay/hyperswitch
juspay__hyperswitch-4427
Bug: Blacking token after delete user role Even after deleting the user role, the logged in user is able to perform the JWT operations. Hence these need to be prohibited by adding the token in blacklist.
diff --git a/crates/diesel_models/src/query/user_role.rs b/crates/diesel_models/src/query/user_role.rs index 4cce0d3f800..09a0bbfe300 100644 --- a/crates/diesel_models/src/query/user_role.rs +++ b/crates/diesel_models/src/query/user_role.rs @@ -70,8 +70,8 @@ impl UserRole { conn: &PgPooledConn, user_i...
2024-04-22T14:07:10Z
## Description The PR add support to blocklist JWT token of the deleted user/user role. After delete signined user won't be able to perform any operation as token is blocklisted. ## Motivation and Context closes #4427 #
447655382bcf2fdd69a1ec6a56e5e4df8a8feef2
SignIn/Signup ``` curl --location 'http://localhost:8080/user/signup' \ --header 'Content-Type: application/json' \ --header 'api-key: test_admin' \ --data-raw '{ "email": "test1@gmail.com", "password": "t" }' ``` Invite another user ``` curl --location 'http://localhost:8080/user/user/invite' \ ...
[ "crates/diesel_models/src/query/user_role.rs", "crates/router/src/core/user_role.rs", "crates/router/src/db/kafka_store.rs", "crates/router/src/db/user_role.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4424
Bug: [REFACTOR] store `card_network` in locker We have `card_brand` field in locker which is `None` currently for all cards. When a `card_network` is sent in the request, map it to `card_brand` and store it in locker.
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index 25bb869075c..fb8444f515b 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -1167,7 +1167,7 @@ pub async fn add_card_hs( na...
2024-04-22T11:57:55Z
## Description <!-- Describe your changes in detail --> We have `card_brand` field in locker which is `None` currently for all cards. When a `card_network` is sent in the request, we map it to `card_brand` and store it in locker. ## Motivation and Context <!-- Why is this change required? What problem does it ...
b8be10de52e40d2327819d33c6c1ec40a459bdd5
1. Store a payment method in locker with `card_network` field in request. ``` curl --location 'http://localhost:8080/payment_methods' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: abc' \ --data '{ "payment_method": "card", "payment_method_type...
[ "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payments/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4927
Bug: bug(logging): recording restricted fields via tracing causes a stack overflow We have a set of restricted fields which can't be set by users, We log a small warning each time such field is being used however when such fields are recorded we end up in a self loop where the warning log itself tries to use this ...
diff --git a/crates/router/src/routes/health.rs b/crates/router/src/routes/health.rs index 721dbd6a78d..3e2f42bcc25 100644 --- a/crates/router/src/routes/health.rs +++ b/crates/router/src/routes/health.rs @@ -16,6 +16,7 @@ use crate::{ pub async fn health() -> impl actix_web::Responder { metrics::HEALTH_METRIC.ad...
2024-04-22T11:05:13Z
## Description <!-- Describe your changes in detail --> - Handle stack overflows when restricted keys are being recorded in spans ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'...
7085a46271791ca3f1c7b86afa7c8b199b93c0cd
- enable debug/trace logging and create payments - there shouldn't be anymore stack overflows
[ "crates/router/src/routes/health.rs", "crates/router_env/src/logger/formatter.rs", "crates/router_env/src/logger/storage.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4408
Bug: update refunds filters and list Include filter for amount and merchant connector id in refunds list.
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index bf4eeb79fef..25de8821263 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -523,7 +523,7 @@ pub struct MerchantConnectorWebhookDetails { pub additional_secret: Option<Secret<String>>, } -#[derive...
2024-04-22T07:31:24Z
## Description The PR: - Adds support for new `filter_v2` api to get list of available filters for refunds quickly: connector with their corresponding label with merchant_connector_ids, currency and refund status. This api is quicker than previous one and gives static and dynamic filter. In this list of available va...
2a302eb5973c64d8b77f8110fdbeb536ccbe1488
To get list of filters: ``` curl --location 'http://localhost:8080/refunds/filter_v2' \ --header 'Content-Type: application/json' \ --header 'Cookie: token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWZjNzgyOTUtM2JiMy00OGJjLThlZDgtNzFjMzVjMzMxYWU2IiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNjk3NzE2ODcwIiwicm9sZV9...
[ "crates/api_models/src/admin.rs", "crates/api_models/src/events/refund.rs", "crates/api_models/src/payments.rs", "crates/api_models/src/refunds.rs", "crates/common_enums/src/enums.rs", "crates/openapi/src/openapi.rs", "crates/router/src/core/refunds.rs", "crates/router/src/db/refund.rs", "crates/rou...
juspay/hyperswitch
juspay__hyperswitch-4442
Bug: Remove duplicated card number interface ### Feature Description The CardNumber interface has a duplicated method with the same functionality. ### Possible Implementation Remove one of the duplicated interfaces. ### Have you spent some time checking if this feature request has been raised before? - [X] I ch...
diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs index e045cf2c42d..dd7791ee2d2 100644 --- a/crates/api_models/src/payment_methods.rs +++ b/crates/api_models/src/payment_methods.rs @@ -361,7 +361,7 @@ impl From<CardDetailFromLocker> for payments::AdditionalCardInfo { ...
2024-04-21T02:57:17Z
## Description <!-- Describe your changes in detail --> The CardNumber interface has a duplicated method with the same functionality. Removed one. closes #4442 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If...
4b5b558dae8d2fefb66b8b16c486f07e3e800758
The methods get_extended_card_bin() and get_card_extended_bin() are identical and thus redundant. It is recommended to keep one and remove the other to avoid confusion.
[ "crates/api_models/src/payment_methods.rs", "crates/cards/src/validate.rs", "crates/router/src/core/payments/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4397
Bug: [FEATURE] Implementing iDEAL and Giropay payment methods with Multisafe ### Feature Description Add iDEAL and Giropay payment processors in [Multisafepay](https://docs.hyperswitch.io/hyperswitch-cloud/connectors/available-connectors/multisafepay) connector. Whole description can be found in #4143 discussion...
diff --git a/config/deployments/integration_test.toml b/config/deployments/integration_test.toml index a42a6a8c323..738edcbda84 100644 --- a/config/deployments/integration_test.toml +++ b/config/deployments/integration_test.toml @@ -4,11 +4,12 @@ eps.adyen.banks = "bank_austria,bawag_psk_ag,dolomitenbank,easybank_ag,er...
2024-04-19T08:53:03Z
## Description <!-- Describe your changes in detail --> Add iDEAL and Giropay payment processors in [Multisafepay](https://docs.hyperswitch.io/hyperswitch-cloud/connectors/available-connectors/multisafepay) connector. Whole description can be found in https://github.com/juspay/hyperswitch/discussions/4143 discu...
97e4f1af90134ad733e3c715a954c719e8a2c5fe
I have tested the Multisafe payment connector for Giropay and iDeal methods in Postman suit. You can find my fork of Postman's collection below. In `Payments - Create iDeal Payment` and `Payments - Create Giropay Direct` in `Quick Start` are the requests for the payments. ### iDeal By requesting the iDeal payment...
[ "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "crates/router/src/connector/multisafepay/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4399
Bug: [Refactor] PostAuth FRM flow This issues is regarding implementing revised PostAuth Frm. Below is the revised flow. **PostAuth flow** - The underlying FRM connector is invoked post authentication of the user from the bank. - If a transaction’s capture method was set to automatic, it is updated to manua...
diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs index 0681edbb15a..44e17754696 100644 --- a/crates/common_enums/src/enums.rs +++ b/crates/common_enums/src/enums.rs @@ -2249,7 +2249,7 @@ pub enum FrmSuggestion { #[default] FrmCancelTransaction, FrmManualReview, - FrmAut...
2024-04-18T11:47:13Z
## Description <!-- Describe your changes in detail --> PostAuth flow - The underlying FRM connector is invoked post authentication of the user from the bank. - If a transaction’s capture method was set to automatic, it is updated to manual for avoiding automatic capture. - Once the user completes the authenticat...
cbf7cf4fcfcfe5a993c88bfc49ef6e284046524b
Create merchant connector account with stripe and then create new merchant connector account with signifyd. ``` { "connector_type": "payment_VAS", "connector_name": "signifyd", "connector_account_details": { "auth_type": "HeaderKey", "api_key": "YOUR_API_KEY" }, "test_mode": false, "d...
[ "crates/common_enums/src/enums.rs", "crates/data_models/src/payments/payment_attempt.rs", "crates/data_models/src/payments/payment_intent.rs", "crates/diesel_models/src/fraud_check.rs", "crates/diesel_models/src/payment_attempt.rs", "crates/diesel_models/src/payment_intent.rs", "crates/diesel_models/src...
juspay/hyperswitch
juspay__hyperswitch-4384
Bug: fix merchant_business_country configs of apple pay metadata removing merchant_business_country from the connector configs as enums can not be handled in this toml file
diff --git a/crates/connector_configs/toml/development.toml b/crates/connector_configs/toml/development.toml index ef20aa22513..ee5f3ba749f 100644 --- a/crates/connector_configs/toml/development.toml +++ b/crates/connector_configs/toml/development.toml @@ -246,7 +246,6 @@ merchant_identifier="Apple Merchant Identifier"...
2024-04-17T10:41:12Z
## Description <!-- Describe your changes in detail --> removing `merchant_business_country` from the connector configs as enums can not be handled in this toml file ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here...
ca47ea9b13ff29085f7cc4e408f2b6498b1d6e8a
Can not be tested
[ "crates/connector_configs/toml/development.toml", "crates/connector_configs/toml/production.toml", "crates/connector_configs/toml/sandbox.toml" ]
juspay/hyperswitch
juspay__hyperswitch-4381
Bug: docs(cypress): Update Cypress README Documentation ### Feature Description In this PR, I have updated the README file to include detailed information about Cypress test scenarios and the folder structure . Added detailed instructions for adding new test scenarios to the ConnectorTest directory. Included a c...
2024-04-17T10:21:19Z
## Description In this PR, I have updated the README file to include detailed information about Cypress test scenarios and the folder structure . Added detailed instructions for adding new test scenarios to the ConnectorTest directory. Included a clear explanation of the folder structure, guiding con...
ca47ea9b13ff29085f7cc4e408f2b6498b1d6e8a
[]
juspay/hyperswitch
juspay__hyperswitch-4352
Bug: add filters for amount and label in payments list Add new filters to filters payments list by: - **amount**: filter payments on the basis of amount equal to , less than, greater than and range - **merchant connector id**: filter payments list on the basis of merchant_connector id, which will be unique for every...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index ad882880163..4a871e69ec5 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -3394,6 +3394,8 @@ pub struct PaymentListFilterConstraints { pub limit: u32, /// The starting point within...
2024-04-12T12:40:07Z
## Description This PR add support to filter payments list by amount and merchant connector id. ## Motivation and Context closes #4352 #
5a0a8cee76378b826580fb44f7d6d6a9b254677e
curl to test amount filter ``` curl --location 'http://localhost:8080/payments/list' \ --header 'Content-Type: application/json' \ --header 'Cookie: token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWZjNzgyOTUtM2JiMy00OGJjLThlZDgtNzFjMzVjMzMxYWU2IiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNjk3NzE2ODcwIiwicm9sZV9p...
[ "crates/api_models/src/payments.rs", "crates/common_utils/src/consts.rs", "crates/data_models/src/payments/payment_attempt.rs", "crates/data_models/src/payments/payment_intent.rs", "crates/diesel_models/src/query/payment_attempt.rs", "crates/router/src/core/payments.rs", "crates/router/src/db/kafka_stor...
juspay/hyperswitch
juspay__hyperswitch-4359
Bug: [FIX] Add onboarding_survey enum in dashboard metadata type
diff --git a/crates/api_models/src/user/dashboard_metadata.rs b/crates/api_models/src/user/dashboard_metadata.rs index 66831c7aeb8..b547a61d450 100644 --- a/crates/api_models/src/user/dashboard_metadata.rs +++ b/crates/api_models/src/user/dashboard_metadata.rs @@ -26,6 +26,7 @@ pub enum SetMetaDataRequest { IsMult...
2024-04-12T12:34:36Z
## Description Bug Fix: Add support for onboarding_survey enum ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus on the i...
2d27ebb41f576b4a70fe8ec7a349444c3cfdcdcf
1. Post OnboardingSurvey enum details Request ``` curl --location 'http://localhost:8080/user/data?keys=OnboardingSurvey' \ --header 'Authorization: JWT token' \ --header 'Content-Type: application/json' \ --data '{ "OnboardingSurvey": { "designation": "some designation", "business_webs...
[ "crates/api_models/src/user/dashboard_metadata.rs", "crates/diesel_models/src/enums.rs", "crates/router/src/core/user/dashboard_metadata.rs", "crates/router/src/types/domain/user/dashboard_metadata.rs", "crates/router/src/utils/user/dashboard_metadata.rs", "migrations/2024-04-12-100908_add_dashboard_metad...
juspay/hyperswitch
juspay__hyperswitch-4348
Bug: [FEATURE] Add required fields for Local Bank Transfer ### Feature Description Add Local Bank Transfer required fields ### Possible Implementation Add required fields for Local Bank Transfer ### Have you spent some time checking if this feature request has been raised before? - [X] I checked and didn't f...
diff --git a/crates/router/src/configs/defaults.rs b/crates/router/src/configs/defaults.rs index 7ade016856c..ddf42d0bb6c 100644 --- a/crates/router/src/configs/defaults.rs +++ b/crates/router/src/configs/defaults.rs @@ -6526,14 +6526,26 @@ impl Default for super::settings::RequiredFields { ...
2024-04-12T11:21:10Z
### Test Case 1. Create a merchant ``` curl --location 'http://localhost:8080/accounts' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: "" ' \ --data-raw '{ "merchant_id": "merchant_1712920458", "merchant_name": "NewAge Retailer", "return_url": "ht...
91830f6d7965f1ba9c23925a1399fdf810a7b31a
[ "crates/router/src/configs/defaults.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4343
Bug: [FEATURE] Allow creation of mandates using payment_token ### Feature Description Allow creation of mandates using payment_token, with setup_future_usage and customer_acceptance ### Possible Implementation Decide based on mandate_type if the intention is to Make a recurring mandate with payment_token or to ma...
diff --git a/crates/router/src/core/mandate/helpers.rs b/crates/router/src/core/mandate/helpers.rs index 704b7ae99f5..c15969fd1c8 100644 --- a/crates/router/src/core/mandate/helpers.rs +++ b/crates/router/src/core/mandate/helpers.rs @@ -1,3 +1,4 @@ +use api_models::payments as api_payments; use common_enums::enums; u...
2024-04-10T16:55:55Z
## Description This PR supports creating a mandate by passing `payment_token` with , `setup_future_usage:off_session` and `customer_acceptance` ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't hav...
2bf775a97e331cde2cad3e3d2a325850d969add9
- Create an MA and MCA - `Step 1:`Make a save card payment - `Step 2:` List Customer Payment Method, get the `payment_token` - `Step 3:` Use the `payment token` to create the mandate > Create ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: a...
[ "crates/router/src/core/mandate/helpers.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/helpers.rs", "crates/router/src/core/payments/operations.rs", "crates/router/src/core/payments/operations/payment_approve.rs", "crates/router/src/core/payments/operations/payment_cancel.rs",...
juspay/hyperswitch
juspay__hyperswitch-4340
Bug: [FIX] parsing leap seconds Currently we are facing errors while parsing leap seconds in ISO8601 format, [this commit](https://github.com/time-rs/time/commit/9c15ee34668fc99c918656fb2895b6d0bfdf7d75) fixes it in `time` crate
diff --git a/Cargo.lock b/Cargo.lock index f17cd059480..92a998dbf57 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -6978,9 +6978,9 @@ dependencies = [ [[package]] name = "time" -version = "0.3.34" +version = "0.3.35" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "c8248b6521bb14bc45b4067...
2024-04-10T10:32:16Z
## Description <!-- Describe your changes in detail --> Update the time crate to `0.3.35` version ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one fir...
ce1e165cecade481ce6002795049d6a9ffec96e2
Cannot be tested in sandbox - Ran `cargo test -p common_utils test_leap_second_parse` locally and verify the testcase is running
[ "Cargo.lock", "crates/analytics/Cargo.toml", "crates/api_models/Cargo.toml", "crates/cards/Cargo.toml", "crates/common_utils/Cargo.toml", "crates/common_utils/src/custom_serde.rs", "crates/common_utils/src/lib.rs", "crates/data_models/Cargo.toml", "crates/diesel_models/Cargo.toml", "crates/router/...
juspay/hyperswitch
juspay__hyperswitch-4336
Bug: add `ApiKeyAuth` support for `upsert_connector_agnostic_mandate_config` Add support for api-key auth for pg_agnotic config api enpoint. As it is required by merchant to enable the config until the dashboard changes are done.
diff --git a/crates/router/src/routes/routing.rs b/crates/router/src/routes/routing.rs index 28d65f66a82..5d8330a05b4 100644 --- a/crates/router/src/routes/routing.rs +++ b/crates/router/src/routes/routing.rs @@ -591,14 +591,11 @@ pub async fn upsert_connector_agnostic_mandate_config( mandate_config, ...
2024-04-10T09:39:23Z
## Description <!-- Describe your changes in detail --> Add support for api-key auth for `pg_agnotic` config api enpoint. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recomm...
a2958c33b5c4ed627c97e97e791ca2cfbfcecd5e
``` curl --location 'http://localhost:8080/routing/business_profile/{{business_profile_id}}/configs/pg_agnostic_mit' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: api-key' \ --data '{ "enabled": true }' ``` ![image](https://github.com/juspay/hypers...
[ "crates/router/src/routes/routing.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4097
Bug: Accepting PM ID as PM data in /payments This is to add support for accepting an existing and active PM ID as `payment_method_data` in `/payments` request.
diff --git a/crates/router/src/core/payments/helpers.rs b/crates/router/src/core/payments/helpers.rs index 51b95041898..c3ab9e00c6d 100644 --- a/crates/router/src/core/payments/helpers.rs +++ b/crates/router/src/core/payments/helpers.rs @@ -52,7 +52,9 @@ use crate::{ self, types::{self, AsyncL...
2024-04-08T12:58:14Z
## Description <!-- Describe your changes in detail --> This is to add support for accepting an existing and active PM ID as payment_method_data in /payments request. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue her...
e0e843715cd02ac8b2eff2f645fe8471551ee914
1) Create MCA 2) Copy the profile and hit the below curl to enable pg_agnostic config ``` curl --location 'https://sandbox.hyperswitch.io/routing/business_profile/:business_profile_id/configs/pg_agnostic_mit' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'Authoriza...
[ "crates/router/src/core/payments/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4325
Bug: feat: Role information in list merchants API - HCC FE is building a profile feature where they want to show all the merchants where the current user is part of. - This also includes the role they were assigned in each merchant account. - We have an API which lists merchant accounts but it doesn't send role they...
diff --git a/crates/api_models/src/user.rs b/crates/api_models/src/user.rs index 9b193a9ba12..afe55afb276 100644 --- a/crates/api_models/src/user.rs +++ b/crates/api_models/src/user.rs @@ -190,6 +190,9 @@ pub struct UserMerchantAccount { pub merchant_id: String, pub merchant_name: OptionalEncryptableName, ...
2024-04-08T07:16:14Z
## Description <!-- Describe your changes in detail --> - This PR adds `role_id`, `role_name`, `org_id` fields in list merchants for user API. - New route `/user/merchants/list` which points to the same function as `/user/switch/list`. ## Motivation and Context <!-- Why is this change required? What problem doe...
433b4bbf278b95be6c3f1d5f4749cf765b664e80
Postman. Both the following endpoints should produce the same results. ``` curl --location 'http://localhost:8080/user/merchants/list' \ --header 'Authorization: Bearer JWT' \ --header 'Cookie: login_token=JWT' ``` ``` curl --location 'http://localhost:8080/user/switch/list' \ --header 'Authorization: Bearer...
[ "crates/api_models/src/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/user.rs", "crates/router/src/types/domain/user.rs", "crates/router/src/utils/user.rs", "crates/router/src/utils/user_role.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4378
Bug: [Fix] 3DS mandates, for the connector _mandate_details to be stored in the payment_methods table ### Feature Description After complete_authorize, or Psync the connector_mandate_details wasn't getting stored in the PaymentMethods table. Hence the recurringMandate would fail with the error Payment Methods not ...
diff --git a/crates/router/src/core/payments/helpers.rs b/crates/router/src/core/payments/helpers.rs index 6e8e4e11fdd..48a6d411780 100644 --- a/crates/router/src/core/payments/helpers.rs +++ b/crates/router/src/core/payments/helpers.rs @@ -417,6 +417,7 @@ pub async fn get_token_pm_type_mandate_details( mandate_ty...
2024-04-08T06:09:41Z
## Description After complete_authorize, or Psync the connector_mandate_details wasn't getting stored in the PaymentMethods table. Hence the recurringMandate would fail with the error `Payment Methods not found` In this PR , we fix the 3ds mandate payments ## Motivation and Context <!-- Why is this change requ...
ea0bc1e3f3f9a59531266db4c28c1d0c14ca9075
- Create a 3DS off-session payment/ - > `Create` ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_njRmxwKH6ktMs37HQLB07DhgK1sFgROrpNiUiUgiSKyIzpoz3Wa5vKDCWc6PQlLe' \ --data-raw '{ "amount": 6777, ...
[ "crates/router/src/core/payments/helpers.rs", "crates/router/src/core/payments/operations/payment_complete_authorize.rs", "crates/router/src/core/payments/operations/payment_confirm.rs", "crates/router/src/core/payments/operations/payment_create.rs", "crates/router/src/core/payments/operations/payment_respo...
juspay/hyperswitch
juspay__hyperswitch-4322
Bug: fix(psync): log the error if payment method retrieve fails in the `psync flow` -> When a payment is created with save card we store the card in the locker and also a payment method entry is created in the payment method table. And the corresponding `payment_method_id` will be stored in the `payment_attempt` ta...
diff --git a/crates/router/src/core/payments/operations/payment_status.rs b/crates/router/src/core/payments/operations/payment_status.rs index 7a8f487d73a..f25b89977f6 100644 --- a/crates/router/src/core/payments/operations/payment_status.rs +++ b/crates/router/src/core/payments/operations/payment_status.rs @@ -5,7 +5,...
2024-04-07T15:10:35Z
## Description <!-- Describe your changes in detail --> -> When a payment is created with save card we store the card in the locker and also a payment method entry is created in the payment method table. And the corresponding payment_method_id will be stored in the payment_attempt table. -> And later when that paym...
7c62dd1c4ba3c67ac86d638227f04e4a1ed5db2d
Create a payment with save card <img width="1101" alt="image" src="https://github.com/juspay/hyperswitch/assets/83439957/08e7e91f-c395-49f3-811c-f78fa79e4c92"> ``` { "amount": 100, "amount_to_capture": 100, "currency": "USD", "confirm": true, "capture_method": "automatic", "capture_on...
[ "crates/router/src/core/payments/operations/payment_status.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4319
Bug: store network transaction id only when pg_agnostic config is enabled in the authorize_flow Currently there is no validation while storing the network transaction id in the authorize flow. As network transaction is only being used for the processor agnostic MITs it should be stored only if the `pg_agnostic` flag...
diff --git a/crates/router/src/connector/stripe/transformers.rs b/crates/router/src/connector/stripe/transformers.rs index 7d1862b2068..e22942fecd6 100644 --- a/crates/router/src/connector/stripe/transformers.rs +++ b/crates/router/src/connector/stripe/transformers.rs @@ -2664,12 +2664,23 @@ impl<F, T> ...
2024-04-05T13:00:31Z
## Description <!-- Describe your changes in detail --> Currently there is no validation while storing the network transaction id in the authorize flow. As network transaction is only being used for the processor agnostic MITs it should be stored (in `payment_methods` table) only if the pg_agnostic flag is enabled. ...
669485275db192b0e8e30f3528c0d61150d91847
`payment_method` table where `network_transaction_id` is null as `pg_agnotic` flag is not enabled. <img width="1456" alt="image" src="https://github.com/juspay/hyperswitch/assets/83439957/c2b1971e-97fc-4da2-9d72-df656ae79bf2"> enabled `pg_agnotic` flag ``` curl --location 'https://sandbox.hyperswitch.io/routing...
[ "crates/router/src/connector/stripe/transformers.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/flows.rs", "crates/router/src/core/payments/flows/approve_flow.rs", "crates/router/src/core/payments/flows/authorize_flow.rs", "crates/router/src/core/payments/flows/cancel_flow.rs"...
juspay/hyperswitch
juspay__hyperswitch-4306
Bug: fix(mandate): add validation for currency in MIT recurring payments When a setup_mandate is done with currency say `USD`, When a recurring payment is being made using `payment_method_id` with another currency, the payment should fail saying `cross currency mandates not supported`
diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs index 22f7cb311c6..b8326874abc 100644 --- a/crates/router/src/core/payments.rs +++ b/crates/router/src/core/payments.rs @@ -21,7 +21,7 @@ use api_models::{ use common_utils::{ext_traits::AsyncExt, pii, types::Surcharge}; use data_mod...
2024-04-04T14:54:43Z
## Description <!-- Describe your changes in detail --> When a setup_mandate is done with currency say `USD`, When a recurring payment is being made using `payment_method_id` with another currency, the payment should fail saying `cross currency mandates not supported`. This PR also handles error which could occur...
071462f2af8efeb16e48d351bbae68fd2fd64179
1. Setup mandate with a customer ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: abc' \ --data-raw '{ "amount": 0, "currency": "USD", "confirm": true, "capture_method": "automatic", ...
[ "crates/router/src/core/payments.rs", "crates/router/src/core/payments/operations/payment_create.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4170
Bug: [REFACTOR]: Create a domain function for saving payment method and updating pm_id in attempt <img width="1404" alt="Screenshot 2024-03-21 at 22 08 28" src="https://github.com/juspay/hyperswitch/assets/61520228/c6cdfd23-096a-402b-8449-b7afdd2614de">
diff --git a/crates/data_models/src/payments/payment_attempt.rs b/crates/data_models/src/payments/payment_attempt.rs index ec0e0873168..0c165632047 100644 --- a/crates/data_models/src/payments/payment_attempt.rs +++ b/crates/data_models/src/payments/payment_attempt.rs @@ -338,6 +338,10 @@ pub enum PaymentAttemptUpdate ...
2024-04-04T14:36:07Z
## Description <!-- Describe your changes in detail --> This PR aims to make the locker call async(again). Moreover the main problem this PR solves is to adding `pm_id` in payment_attempt even in an async locker call. This is achieved by adding up a new function in `PostUpdateTracker` trait named as `save_pm_and_man...
9bf16b1a0787f9badb4a6decd38e3e5d69a3ea51
Curls for the test cases: 1. Save Card payment ``` curl --location 'http://127.0.0.1:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_Lhj81dmb5DH3dasSlnRy2LUAHIOc6LJDFSQxyLbrAS7HWS5Hxva2YOJTYea90wXw' \ --data-raw ' { "amount": 150...
[ "crates/data_models/src/payments/payment_attempt.rs", "crates/diesel_models/src/payment_attempt.rs", "crates/router/src/core/mandate.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/flows.rs", "crates/router/src/core/payments/flows/approve_flow.rs", "crates/router/src/core/pay...
juspay/hyperswitch
juspay__hyperswitch-4304
Bug: refactor(payment_methods): revamp payment methods update endpoint `/payment_methods/update` endpoint doesn't currently perform the expected functionality. Revamp the endpoint such that - It deletes the existing entry from locker. - Create a new updated payment method and store it in locker - Update the exis...
diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs index dd6495bb979..7eb7e213e5b 100644 --- a/crates/api_models/src/payment_methods.rs +++ b/crates/api_models/src/payment_methods.rs @@ -76,7 +76,7 @@ pub struct PaymentMethodUpdate { "card_exp_month": "10", "card_...
2024-04-04T13:56:02Z
## Description <!-- Describe your changes in detail --> `/payment_methods/update` endpoint doesn't currently perform the expected functionality. This PR revamps the endpoint such that - Move update endpoint to `/payment_methods/:id/update` - Verify whether update is necessary by comparing request fields with exis...
1b7cde2d1b687e9c5ca8e3c02eef5c7d3fb7da8f
1. Create a customer ``` curl --location 'http://localhost:8080/customers' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_kxFm2YwE2I8srj4W96v9C5XkZl8VputfqADhqdumTgJFLpuXpgU5I2NlTHOM3ply' \ --data-raw '{ "email": "guest@example.com", "name"...
[ "crates/api_models/src/payment_methods.rs", "crates/openapi/src/openapi.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payment_methods/transformers.rs", "crates/router/src/core/payments/helpers.rs", "crates/router/src/core/payments/tokenization.rs", "crates/router/src/co...
juspay/hyperswitch
juspay__hyperswitch-4302
Bug: remove mget from redis interface
diff --git a/crates/redis_interface/src/commands.rs b/crates/redis_interface/src/commands.rs index 21630fc3c08..d9b7072ff8c 100644 --- a/crates/redis_interface/src/commands.rs +++ b/crates/redis_interface/src/commands.rs @@ -306,45 +306,6 @@ impl super::RedisConnectionPool { .await } - #[instrume...
2024-04-04T12:16:31Z
## Description Getting multiple values from Redis at one time was working fine in local environment but was failing when deployed because of mutiple clusters at infra level. ## Motivation and Context closes #4302 #
63d2b6855acee1adeae2efff10f424e056af0bcb
#3945 when deployed, caused sandbox to fail.
[ "crates/redis_interface/src/commands.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4299
Bug: [REFACTOR] : [Stripe] Add support for recurring payments for GooglePay ### Feature Description Add support for recurring payments for GooglePay ### Have you spent some time to check if this feature request has been raised before? - [X] I checked and didn't find similar issue ### Have you read the Co...
diff --git a/crates/router/src/connector/stripe/transformers.rs b/crates/router/src/connector/stripe/transformers.rs index 45aeb1e9074..211ac559fec 100644 --- a/crates/router/src/connector/stripe/transformers.rs +++ b/crates/router/src/connector/stripe/transformers.rs @@ -637,10 +637,11 @@ impl TryFrom<enums::PaymentMe...
2024-04-04T11:14:45Z
## Description Add Support for Google Pay recurring Payments for Stripe Connector ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR ca...
63d2b6855acee1adeae2efff10f424e056af0bcb
TESTING WITH `PAYMENT_METHOD_ID` 1. Create a CIT Gpay Payment vai Stripe ``` { "amount": 6540, "currency": "INR", "confirm": true, "capture_method": "automatic", "capture_on": "2022-09-10T10:11:12Z", "amount_to_capture": 6540, "customer_id": "StripeCustomer", "email": "guest@e...
[ "crates/router/src/connector/stripe/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4297
Bug: feat: Add cookie parsing Parse cookie header to get JWT. Compare with the JWT retrieved from `Authorization` header and log the result.
diff --git a/crates/router/src/compatibility/stripe/errors.rs b/crates/router/src/compatibility/stripe/errors.rs index 0181ec4e799..a7c54ef8f34 100644 --- a/crates/router/src/compatibility/stripe/errors.rs +++ b/crates/router/src/compatibility/stripe/errors.rs @@ -427,6 +427,7 @@ impl From<errors::ApiErrorResponse> for...
2024-04-04T10:50:23Z
## Description This is the second PR for cookie implementation. In this PR, cookie header is parsed to retrieve JWT that was set during dashboard entry. This PR does not remove old auth flow where `Authorization` header was used to retrieve JWT from request. Instead, it compares the JWT retrieved from `Authorizati...
63d2b6855acee1adeae2efff10f424e056af0bcb
No testing required, feature is not complete and hence is not enabled.
[ "crates/router/src/compatibility/stripe/errors.rs", "crates/router/src/core/errors/api_error_response.rs", "crates/router/src/core/errors/transformers.rs", "crates/router/src/services/authentication.rs", "crates/router/src/services/authentication/cookies.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4295
Bug: [Refactor] Log the appropriate error message ### Feature Description Log the appropriate error message when there's an error while saving the card In the locker ### Possible Implementation Log the appropriate error message when there's an error while saving the card In the locker ### Have you spent some tim...
diff --git a/crates/router/src/core/payments/flows/authorize_flow.rs b/crates/router/src/core/payments/flows/authorize_flow.rs index a5132e4a346..f891f44f099 100644 --- a/crates/router/src/core/payments/flows/authorize_flow.rs +++ b/crates/router/src/core/payments/flows/authorize_flow.rs @@ -140,7 +140,7 @@ impl Featur...
2024-04-04T09:11:12Z
## Description log the appropriate error message if the card fails to get saved in locker ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first ...
21e2d78117a9e25708b8c6a2280f6a836ee86072
Cannot be tested , just a log addition
[ "crates/router/src/core/payments/flows/authorize_flow.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4283
Bug: [REFACTOR]: add `updated` field to payments response Add a field called `updated` to the payments response. This field will have the ISO timestamp at which the payment was updated. This field should have the value from `modified_at` column from the `payment_intent` table. The struct that is being used fo...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index de8142ddde2..99ae68c2e7d 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -3196,6 +3196,11 @@ pub struct PaymentsResponse { /// Payment Method Status #[schema(value_type = Option<P...
2024-04-03T19:55:15Z
## Description <!-- --> This change adds the `updated` field to the PaymentResponse. It takes the value from the `payment_intent.modified_at` field. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don...
7b4c4fea332d56f81a73b496fa0fefdbb64b3648
- Create a payment with the below curl ```bash curl --location 'https://integ-api.hyperswitch.io/payments' \ --header 'Content-Type: application/json' \ --header 'api-key: <api_key>' \ --data '{ "amount": 6540, "currency": "USD", "confirm": true, "payment_method": "card", "payment_meth...
[ "crates/api_models/src/payments.rs", "crates/router/src/core/payments/transformers.rs", "openapi/openapi_spec.json" ]
juspay/hyperswitch
juspay__hyperswitch-4290
Bug: [Patch]: make locker call sync to pupulate pm_id Sample curl: ### `Payment Create` with confirm as true: ``` curl --location 'http://127.0.0.1:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_vEXG9ROzIB0Mg0v43nHhIp7yA3zGl6XkiEKd5Rek...
diff --git a/crates/data_models/src/payments/payment_attempt.rs b/crates/data_models/src/payments/payment_attempt.rs index 8984c1caeeb..6c236729de4 100644 --- a/crates/data_models/src/payments/payment_attempt.rs +++ b/crates/data_models/src/payments/payment_attempt.rs @@ -347,7 +347,7 @@ pub enum PaymentAttemptUpdate {...
2024-04-03T12:38:38Z
## Description <!-- Describe your changes in detail --> Making the locker call synchronous in order to update pm_id in payment response. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an iss...
8efd468ac150ff8d28f5b44b25701ba1837f243d
Sample curl: ### `Payment Create` with confirm as true: ``` curl --location 'http://127.0.0.1:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_vEXG9ROzIB0Mg0v43nHhIp7yA3zGl6XkiEKd5RekoXbUUiB9OIF4VRlBWYjdzToU' \ --data-raw '{ "amount...
[ "crates/data_models/src/payments/payment_attempt.rs", "crates/diesel_models/src/payment_attempt.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/flows/authorize_flow.rs", "crates/router/src/core/payments/operations/payment_response.rs", "crates/router/src/core/payments/retry.rs"...
juspay/hyperswitch
juspay__hyperswitch-4288
Bug: refactor: fix typos in stripe transformers Fix typos caught from the new version of typos-cli
diff --git a/crates/router/src/connector/stripe/transformers.rs b/crates/router/src/connector/stripe/transformers.rs index ef613ed7cfe..76733a19ca3 100644 --- a/crates/router/src/connector/stripe/transformers.rs +++ b/crates/router/src/connector/stripe/transformers.rs @@ -2427,12 +2427,12 @@ impl<F, T> ...
2024-04-03T11:18:02Z
## Description <!-- Describe your changes in detail --> This PR fixes typos caught from the new version of typos-cli ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend ...
4051cbb4e7f708267b26439061e001bb00342cad
Local sanity testing
[ "crates/router/src/connector/stripe/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4282
Bug: [REFACTOR] : [Stripe] fix Mandate flow ### Feature Description Earlier the connector_mandate_id was not being populated as expected, instead it was being populated in a separate field as payment_method_id in mandate_reference data. In this PR the flow has been refactored and fixed to send the Response from c...
diff --git a/crates/router/src/connector/stripe/transformers.rs b/crates/router/src/connector/stripe/transformers.rs index 4673cce4d81..18776bcba43 100644 --- a/crates/router/src/connector/stripe/transformers.rs +++ b/crates/router/src/connector/stripe/transformers.rs @@ -124,7 +124,6 @@ pub struct PaymentIntentRequest...
2024-04-03T06:45:52Z
## Description Earlier the connector_mandate_id was not being populated as expected, instead it was being populated in a separate field as `payment_method_id` in mandate_reference data. And earlier if we try to do MIT payment using `payment_method_id` it was not working. In this PR the flow has been refactored and f...
1c63c5268be87124b75cdc2d901a80123996a0a7
1. Create a CIT Card payment via Stripe Connector. ```{ "amount": 6540, "currency": "USD", "confirm": true, "capture_method": "automatic", "capture_on": "2022-09-10T10:11:12Z", "amount_to_capture": 6540, "customer_id": "SWANGI123", "description": "Its my first payment request",...
[ "crates/router/src/connector/stripe/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4276
Bug: [Refactor] fix typos We use typos-cli crate to catch typos in the repo. A new version of the same was released and has caught few new typos in the repo.
diff --git a/.typos.toml b/.typos.toml index 58e48220bd7..642eaded60e 100644 --- a/.typos.toml +++ b/.typos.toml @@ -3,44 +3,62 @@ check-filename = true [default.extend-identifiers] "ABD" = "ABD" # Aberdeenshire, UK ISO 3166-2 code +AER = "AER" # An alias to Api Error Response +ANG = "ANG" # Netherlands Antillean ...
2024-04-02T14:31:10Z
## Description <!-- Describe your changes in detail --> We use typos-cli crate to catch typos in the repo. A new version of the same was released and has caught few new typos in the repo. This PR fixes all the typos that was caught. Reviewers can refer below commits to review easily: Postman - a19fa982546a9919...
1023f46c885dc2b70ccbb3931e667740695f448e
Local sanity testing
[ ".typos.toml", "INSTALL_dependencies.sh", "connector-template/test.rs", "crates/api_models/src/payment_methods.rs", "crates/api_models/src/refunds.rs", "crates/euclid/src/dssa/graph.rs", "crates/router/src/compatibility/stripe/payment_intents/types.rs", "crates/router/src/compatibility/stripe/setup_in...
juspay/hyperswitch
juspay__hyperswitch-4262
Bug: refactor(mandates): add validations for recurring mandates using payment_method_id When a setup mandate is done with customer, when doing recurring payment using `payment_method_id`, add validation to match on customer_id such that they match on setup mandate as well as recurring. Also add validation not to ...
diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs index f08a793ebf5..78140ea2932 100644 --- a/crates/api_models/src/payment_methods.rs +++ b/crates/api_models/src/payment_methods.rs @@ -282,6 +282,28 @@ fn saved_in_locker_default() -> bool { true } +impl From<CardD...
2024-04-01T11:06:37Z
## Description <!-- Describe your changes in detail --> When a setup mandate is done with customer, when doing recurring payment using `payment_method_id`, this PR adds following validation - to match on customer_id such that they match on setup mandate as well as recurring. - to match on merchant_id such that the...
97fbc899c12a0c66ac89a7feaa6d45d39239a746
1. Setup mandate with a customer ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: abc' \ --data-raw '{ "amount": 0, "currency": "USD", "confirm": true, "capture_method": "automatic", ...
[ "crates/api_models/src/payment_methods.rs", "crates/router/src/core/payments/helpers.rs", "crates/router/src/core/payments/operations/payment_complete_authorize.rs", "crates/router/src/core/payments/operations/payment_confirm.rs", "crates/router/src/core/payments/operations/payment_create.rs", "crates/rou...
juspay/hyperswitch
juspay__hyperswitch-4098
Bug: Merchant PML to return only PM API compatible PMs The `/account/payment_methods` should list only the _Add Payment Method_ flow compatible PMs if invoked with the `PM Client Secret` authentication. This is to weed out PMs which cannot be saved without making a payment/setting up a recurring payment/mandate. ...
diff --git a/config/config.example.toml b/config/config.example.toml index b2e1fe3c458..b5585a84b32 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -613,3 +613,6 @@ payment_attempts = "hyperswitch-payment-attempt-events" payment_intents = "hyperswitch-payment-intent-events" refunds = "hype...
2024-03-28T12:24:55Z
## Description <!-- Describe your changes in detail --> This PR builds upon - https://github.com/juspay/hyperswitch/pull/4134 After generating a `pm client_secret`, `/ist_payment_methods` can be altered for vaulting purposes. For saved payment methods, if `pm client_secret` is passed in merchant payment method li...
bcce8b0489aad8455748e0945127f0a7447e8fb1
1. Create a customer ``` curl --location --request POST 'http://localhost:8080/customers' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_y5XDvbHKvRI6K2dAhTgXvNgQykJiqLXeYtSysCQzPGBGz3RZoUPjPcfD1LW8teYO' \ --data-raw '{ "email": "guest@example.com"...
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/diesel_models/src/payment_method.rs", "crates/router/src/configs/secrets_transformers.rs",...
juspay/hyperswitch
juspay__hyperswitch-4246
Bug: [FEATURE] : [Billwerk] Add Payment and Refund Flows ### Feature Description Add all the payment flows for non-3ds cards: Authorise, Capture, Void, Psync And the refund flows: Refund and Rsync ### Possible Implementation Add all the payment flows for non-3ds cards: Authorise, Capture, Void, Psync And th...
diff --git a/config/config.example.toml b/config/config.example.toml index ee868beb092..c1ba88db019 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -171,6 +171,7 @@ authorizedotnet.base_url = "https://apitest.authorize.net/xml/v1/request.api" bambora.base_url = "https://api.na.bambora.com" ...
2024-03-28T10:43:39Z
## Description <!-- Describe your changes in detail --> implement all the basic flows for Billwerk (Reepay): - [Authorise/Charge](https://optimize-docs.billwerk.com/reference/createcharge) - [Capture](https://optimize-docs.billwerk.com/reference/settlecharge) - [Void](https://optimize-docs.billwerk.com/referenc...
a843713126cea102064b342b6fc82429d89d758a
Test all the basic (no-3DS) and error cases for above mentioned flows. Refer to this [link](https://optimize-docs.billwerk.com/reference/testing) for test cards, Visa and MasterCard are not enabled on this account. - ### Create Automatic Charge ``` curl --location 'http://localhost:8080/payments' \ --header 'Ac...
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/enums.rs", "crates/common_enums/src/enums.rs", "crates/connector_configs/...
juspay/hyperswitch
juspay__hyperswitch-4284
Bug: [GLOBALSEARCH] - modular code refactoring with health check - code refactoring for opensearch module - deep health check addition
diff --git a/Cargo.lock b/Cargo.lock index b4819f9f379..635edcc995e 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -337,6 +337,7 @@ dependencies = [ "aws-smithy-types 1.1.8", "bigdecimal", "common_utils", + "data_models", "diesel_models", "error-stack", "external_services", diff --git a/crates/analytics/Cargo....
2024-03-28T08:29:13Z
## Description refactoring opensearch to module structure ## Motivation and Context refactoring #
9bf16b1a0787f9badb4a6decd38e3e5d69a3ea51
test cases added below (verify sanity of all global search endpoints)
[ "Cargo.lock", "crates/analytics/Cargo.toml", "crates/analytics/src/lib.rs", "crates/analytics/src/opensearch.rs", "crates/analytics/src/search.rs", "crates/api_models/src/analytics/search.rs", "crates/api_models/src/health_check.rs", "crates/router/src/analytics.rs", "crates/router/src/configs/setti...
juspay/hyperswitch
juspay__hyperswitch-4235
Bug: add `merchant_business_country` field in apple pay `session_token_data` Merchant business country is mandatory field for confirming a apple pay payment. Till date we were expecting the billing country to be passed in the apple pay payment create call. Instead of collecting it is every payment create call this c...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 6805363b265..097351882c1 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -3799,11 +3799,15 @@ pub struct SessionTokenInfo { pub display_name: String, pub initiative: String, ...
2024-03-27T13:54:29Z
## Description <!-- Describe your changes in detail --> Merchant business country is mandatory field for confirming a apple pay payment. Till date we were expecting the billing country to be passed in the apple pay payment create call. Instead of collecting it is every payment create call this can be collected in th...
433b4bbf278b95be6c3f1d5f4749cf765b664e80
Create MCA with apple pay metadata as shown below ``` { "connector_type": "fiz_operations", "connector_name": "stripe", "business_country": "US", "business_label": "default", "connector_account_details": { "auth_type": "HeaderKey", "api_key": "api_key" }, "test_m...
[ "crates/api_models/src/payments.rs", "crates/connector_configs/toml/development.toml", "crates/connector_configs/toml/production.toml", "crates/connector_configs/toml/sandbox.toml", "crates/router/src/connector/bluesnap/transformers.rs", "crates/router/src/connector/payme/transformers.rs", "crates/route...
juspay/hyperswitch
juspay__hyperswitch-4214
Bug: [Patch]: Remove processing state from payment_method_status This will remove the `processing` status from `payment_method_status` and by default makes everything active or failure. This is a patch to ensure that no payment_method goes to non-terminal.
diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs index 89ca80e72b3..17f0326a84d 100644 --- a/crates/common_enums/src/enums.rs +++ b/crates/common_enums/src/enums.rs @@ -1252,7 +1252,6 @@ pub enum PaymentMethodStatus { impl From<AttemptStatus> for PaymentMethodStatus { fn from(attem...
2024-03-26T16:10:51Z
## Description <!-- Describe your changes in detail --> This will remove the `processing` status from `payment_method_status` and by default makes everything active or failure. This is a patch to ensure that no payment_method goes to non-terminal. ## Motivation and Context <!-- Why is this change required? Wh...
e8289f061d4735478cb1521de50f696d2412ad33
Sample curl: ### `Payment Create` with confirm as false: ``` curl --location 'http://127.0.0.1:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_eZdRVkfE8sbYE7JSzm2Tu0HAca0PHRY6u3JoSFBukHuxoYeXw7bgwr7Gy2DJn1kS' \ --data-raw '{ "amoun...
[ "crates/common_enums/src/enums.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4210
Bug: [Analytics/Payouts] - add kafka events and clickhouse schema for payout analytics add kafka events and clickhouse schema for payout analytics
diff --git a/config/config.example.toml b/config/config.example.toml index 074028c208a..0ed971c18bd 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -568,6 +568,7 @@ connector_logs_topic = "topic" # Kafka topic to be used for connector api outgoing_webhook_logs_topic = "topic" # Kafka...
2024-03-26T14:45:21Z
## Description add kafka events and clickhouse schema for payout analytics ## Motivation and Context add kafka events and clickhouse schema for payout analytics closes [#4210](https://github.com/juspay/hyperswitch/issues/4210) #
1023f46c885dc2b70ccbb3931e667740695f448e
Create a payout -> check for logs in loki `topic: hyperswitch-payout-events` test cases added below
[ "config/config.example.toml", "config/deployments/env_specific.toml", "config/development.toml", "config/docker_compose.toml", "crates/analytics/docs/clickhouse/scripts/payouts.sql", "crates/router/src/db/kafka_store.rs", "crates/router/src/events.rs", "crates/router/src/services/kafka.rs", "crates/...
juspay/hyperswitch
juspay__hyperswitch-4561
Bug: Setup Hyperswitch Web & Control center # Context Developer experience is one of the key tenets at Hyperswitch. Setting up and running Hyperswitch should be fun, fast and easy for all developers out there !! However, when we fully open sourced Hyperswitch in Nov 2023, we had to create three repositories t...
diff --git a/docker-compose.yml b/docker-compose.yml index e55008f1e34..32a7a6ef2f8 100644 --- a/docker-compose.yml +++ b/docker-compose.yml @@ -122,6 +122,39 @@ services: labels: logs: "promtail" +### Web Client + hyperswitch-web: + ports: + - "9050:9050" + - "9060:9060" + - "5252:5252...
2024-03-26T08:35:46Z
## Description Added web client and control center services to docker-compose.yml REF : #4110
b0133f33693575f2145d295eff78dd07b61efcda
[ "docker-compose.yml", "docker/web.Dockerfile" ]
juspay/hyperswitch
juspay__hyperswitch-4195
Bug: Update aws dependencies to latest version Update rust aws dependencies to their latest version
diff --git a/Cargo.lock b/Cargo.lock index 13d6ca93df9..3c344844738 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -9,7 +9,7 @@ source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "5f7b0a21988c1bf877cf4759ef5ddaac04c1c9fe808c9142ecb78ba97d97a28a" dependencies = [ "bitflags 2.6.0", - "bytes 1.7....
2024-03-26T07:34:45Z
## Description <!-- Describe your changes in detail --> This PR updates rust aws dependencies to their latest version ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend ...
4b922e54847c2c0cc0ecf1c17ae84a3db075b989
Deployed the branch in custom pod. Application deployed successfully hence kms feature works fine. Tested email feature too. ``` curl --location 'https://http://localhost:8080/user/signup_with_merchant_id' \ --header 'Content-Type: application/json' \ --header 'api-key: abc' \ --data-raw '{ "email": "te...
[ "Cargo.lock", "crates/analytics/Cargo.toml", "crates/external_services/Cargo.toml", "crates/external_services/src/email.rs", "crates/external_services/src/email/ses.rs", "crates/external_services/src/file_storage/aws_s3.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4192
Bug: Add NTID support for Cybersource Add `NTID` (network transaction id) flow cybersource.
diff --git a/crates/router/src/connector/cybersource/transformers.rs b/crates/router/src/connector/cybersource/transformers.rs index 6a51e1e8cd4..346d2127649 100644 --- a/crates/router/src/connector/cybersource/transformers.rs +++ b/crates/router/src/connector/cybersource/transformers.rs @@ -297,6 +297,7 @@ pub struct ...
2024-03-26T07:11:02Z
## Description <!-- Describe your changes in detail --> Add `NTID` (network transaction id) flow cybersource. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting...
b58d7a8e62eef9880f717731063101bf92af3f34
enabled `pg_agnotic` flag ``` curl --location 'https://sandbox.hyperswitch.io/routing/business_profile/:business_profile_id/configs/pg_agnostic_mit' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'Authorization: Bearer JWT_Token' \ --data '{ "enabled": true }'...
[ "crates/router/src/connector/cybersource/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4173
Bug: feat: get new filters for payments Currently, /filter api for payments takes times to get list of all available filters, moreover it is dependent on time range. Need to extract all the available filters in less time, and these filters should not be dependent on time range.
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index 10a68ef1a44..623abca8143 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -518,6 +518,12 @@ pub struct MerchantConnectorWebhookDetails { pub additional_secret: Option<Secret<String>>, } +#[deriv...
2024-03-21T20:00:45Z
## Description The api is used to get all the available filters that can be applied on payments list. This is filter_v2 api that performs better than the previous payments api and it is not dependent on any time range value. Filters will remain static and won't change as per time range. Though this new api seems stat...
1b7cde2d1b687e9c5ca8e3c02eef5c7d3fb7da8f
Request: ``` curl --location 'http://localhost:8080/payments/filter_v2' \ --header 'Content-Type: application/json' \ --header 'Cookie: token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWZjNzgyOTUtM2JiMy00OGJjLThlZDgtNzFjMzVjMzMxYWU2IiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNjk3NzE2ODcwIiwicm9sZV9pZCI6Im1lcmNoY...
[ "crates/api_models/src/admin.rs", "crates/api_models/src/events/payment.rs", "crates/api_models/src/payments.rs", "crates/common_enums/src/enums.rs", "crates/router/src/core/payments.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/payments.rs...
juspay/hyperswitch
juspay__hyperswitch-4171
Bug: chore: address Rust 1.77 clippy lints Address the clippy lints occurring due to new rust version 1.77 See #3391 for more information.
diff --git a/add_connector.md b/add_connector.md index ac9d3f8d847..96724cb1b01 100644 --- a/add_connector.md +++ b/add_connector.md @@ -514,28 +514,23 @@ Within the `ConnectorIntegration` trait, you'll find the following methods imple } ``` -- `get_request_body` method calls transformers where hyperswitch paymen...
2024-03-21T18:15:20Z
## Description <!-- Describe your changes in detail --> This PR addresses the clippy lints occurring due to new rust version 1.77 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'...
14e1bbaf071d1178f91124fe85580f178cb1cf96
[ "add_connector.md", "crates/common_utils/src/lib.rs", "crates/common_utils/src/request.rs", "crates/diesel_models/src/process_tracker.rs", "crates/router/src/connector/bankofamerica.rs", "crates/router/src/connector/checkout/transformers.rs", "crates/router/src/connector/cryptopay.rs", "crates/router/...
juspay/hyperswitch
juspay__hyperswitch-4017
Bug: [FEATURE] Add user roles for payouts ### Feature Description Add respective variants and modules for managing permissions for payout operations. PayoutRead, PayoutWrite Add these to user roles module. ### Possible Implementation Add it similarly to existing roles. ### Have you spent some time checkin...
diff --git a/crates/api_models/src/user_role.rs b/crates/api_models/src/user_role.rs index 2e3d60024d3..31da8386ab6 100644 --- a/crates/api_models/src/user_role.rs +++ b/crates/api_models/src/user_role.rs @@ -32,6 +32,8 @@ pub enum Permission { UsersWrite, MerchantAccountCreate, WebhookEventRead, + Pa...
2024-03-21T10:46:49Z
## Description <!-- Describe your changes in detail --> This PR introduces user roles for `Payouts`. `PayoutRead` and `PayoutWrite` are added as permission under payout persmissions. This permission are added to list(get/post), retrieval and filter api's for payouts. ## Motivation and Context <!-- Why is this...
5afd2c2a67f325960668f2b27c3519581f5877e1
1) User with `org_admin`, `internal_admin`, `merchant_admin`, `merchant_operator` will have PayoutRead and PayourWrite. All other user roles will have only `PayoutRead`. This below curl will get information of user role permissions. ``` curl --location --request GET '{{base_url}}/user/permission_info' \ --header '...
[ "crates/api_models/src/user_role.rs", "crates/router/src/routes/payouts.rs", "crates/router/src/services/authorization/info.rs", "crates/router/src/services/authorization/permission_groups.rs", "crates/router/src/services/authorization/permissions.rs", "crates/router/src/services/authorization/predefined_...
juspay/hyperswitch
juspay__hyperswitch-4157
Bug: [CI] update hotfix pr check workflow to parse backticks in pr title Currently backticks in hotfix pr title is not being parsed resulting in hotfix-pr-check workflow failing. Update the workflow to parse backticks too
2024-03-20T17:46:28Z
## Description <!-- Describe your changes in detail --> Currently backticks in hotfix pr title is not being parsed resulting in hotfix-pr-check workflow failing. This PR updates the workflow to store pr title in env and make use of it. Failing CI check (example) - https://github.com/juspay/hyperswitch/actions/ru...
7c0e4c7229acacbeb93102bcdc25b74fd7a3314c
[]
juspay/hyperswitch
juspay__hyperswitch-4105
Bug: Update a PM entry with connector_mandate_details when re-used in a payment Update and store connector mandate details when an already saved card is used to make a payment and routed through a different connector
diff --git a/crates/diesel_models/src/payment_method.rs b/crates/diesel_models/src/payment_method.rs index ef153c23a7b..488725f6ae8 100644 --- a/crates/diesel_models/src/payment_method.rs +++ b/crates/diesel_models/src/payment_method.rs @@ -126,6 +126,9 @@ pub enum PaymentMethodUpdate { StatusUpdate { sta...
2024-03-20T11:31:15Z
## Description The connector_mandate_details, were stored in the db earlier. In this PR if two mandates are created with two different connectors, but for same payment_method, We would update the PaymentMethod entry in the db. Also if the expiry was changed then also we would update connector_mandate_details. ...
0f8384dde996a455920bd4127c1d0ce62d5312ba
- Create a MA and an MCA_1 with cyber source. `Scenario 1` - Make an off session payment -> `Create` ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_BgXaGEnYjJ4qj7ko3kJ7Rj40BnLYhYT4IEryQ5f2HP...
[ "crates/diesel_models/src/payment_method.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payments/operations/payment_response.rs", "crates/router/src/core/payments/tokenization.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4153
Bug: make `ApplepayPaymentMethod` in payment_method_data column of `payment_attempt` table as json make `ApplepayPaymentMethod` in payment_method_data column of `payment_attempt` table as json because retrieve payment fails for the old payments for which the `payment_method_data` in the `payment_attempt` table was ...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 40d11543c02..d96616fcaaa 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -1480,12 +1480,6 @@ pub struct AdditionalCardInfo { pub authentication_data: Option<serde_json::Value>, } -#...
2024-03-20T10:54:27Z
## Description <!-- Describe your changes in detail --> make ApplepayPaymentMethod in payment_method_data column of payment_attempt table as json because retrieve payment fails for the old payments for which the payment_method_data in the payment_attempt table was stored as {"wallet": {}} ## Motivation and Conte...
3653c2c108b80a20df6e8a2bf980d48c204376cd
Checkout to old commit where we were storing the `{"wallet": {}}` for apple pay in the `payment_attempt` table <img width="1450" alt="image" src="https://github.com/juspay/hyperswitch/assets/83439957/15cbd523-f2cb-4275-8d61-897ae958d8c5"> Make a payment create call for apple pay ``` { "amount": 650, ...
[ "crates/api_models/src/payments.rs", "crates/router/src/core/payments/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4151
Bug: HOTIFIX - [FIX] update payment method status only if existing status is not active Currently we update the payment method status if the existing status doesn't match the attempt status. Update the status only if the existing status is not active.
diff --git a/crates/router/src/core/payments/operations/payment_response.rs b/crates/router/src/core/payments/operations/payment_response.rs index 447ca14b156..77b72f0fd57 100644 --- a/crates/router/src/core/payments/operations/payment_response.rs +++ b/crates/router/src/core/payments/operations/payment_response.rs @@ ...
2024-03-20T10:14:01Z
## Description <!-- Describe your changes in detail --> Original PR - https://github.com/juspay/hyperswitch/pull/4149 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend ...
f9db641058179b846d4bf3ce69a7679b4e9541fc
[ "crates/router/src/core/payments/operations/payment_response.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4148
Bug: [FIX] update payment method status only if existing status is not active Currently we update the payment method status if the existing status doesn't match the attempt status. Update the status only if the existing status is not active.
diff --git a/crates/router/src/core/payments/operations/payment_response.rs b/crates/router/src/core/payments/operations/payment_response.rs index ae350d6de2b..0167f16cb8a 100644 --- a/crates/router/src/core/payments/operations/payment_response.rs +++ b/crates/router/src/core/payments/operations/payment_response.rs @@ ...
2024-03-20T09:54:03Z
## Description <!-- Describe your changes in detail --> Currently we update the payment method status if the existing status doesn't match the attempt status. Update the status only if the existing status is not active. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If...
3653c2c108b80a20df6e8a2bf980d48c204376cd
1. Create Stripe mca 2. Create normal payment and save the card (payment fails as below used is a failure test card) ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: abc' \ --data-raw '{ "amount": ...
[ "crates/router/src/core/payments/operations/payment_response.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4137
Bug: Fails to build with rust 1.77.0 ### Bug Description I have the following error with rust 1.77.0: ``` --- stderr thread 'main' panicked at crates/router_env/src/cargo_workspace.rs:57:5: Unknown workspace members package ...
diff --git a/Cargo.lock b/Cargo.lock index 03f78686981..33327b71589 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1764,9 +1764,9 @@ dependencies = [ [[package]] name = "cargo_metadata" -version = "0.15.4" +version = "0.18.1" source = "registry+https://github.com/rust-lang/crates.io-index" -checksum = "eee4243f1f26f...
2024-03-19T19:57:43Z
## Description <!-- Describe your changes in detail --> This PR updates the build script code to obtain cargo workspace member package names to use a better and more deterministic way to do so. Previously, we used to perform string manipulation on the package ID format (obtained from the `workspace_members` fiel...
f3141ecbf9cbf5149ab2d17e1e9068ec9f40ef4a
`cargo run` was successful with both Rust 1.76 and 1.77 (although with warnings). I installed the Rust 1.77 toolchain by following the instructions from the [Rust 1.77.0 pre-release testing](https://blog.rust-lang.org/inside-rust/2024/03/17/1.77.0-prerelease.html) blog post.
[ "Cargo.lock", "crates/router_env/Cargo.toml", "crates/router_env/src/cargo_workspace.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4136
Bug: [GlobalSearch] - BE - escape reserved characters in global search query escape these reserved character which will break the search query https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html#_reserved_characters currently when you pass the reserved characters in ...
diff --git a/crates/analytics/src/search.rs b/crates/analytics/src/search.rs index d9b8433ba63..4c42e96250b 100644 --- a/crates/analytics/src/search.rs +++ b/crates/analytics/src/search.rs @@ -81,7 +81,7 @@ pub async fn msearch_results( for index in SearchIndex::iter() { msearch_vector .push(...
2024-03-19T14:36:43Z
## Description escape reserved characters in global search query ## Motivation and Context escape [reserved](https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl-query-string-query.html#_reserved_characters) characters in global search query #
944089d6914cb6bece9056f78b9aabf90e485151
``` curl --location --request POST 'http://localhost:8080/analytics/v1/search/payment_attempts' \ --header 'api-key: hyperswitch' \ --header 'authorization: Bearer *' \ --header 'content-type: application/json' \ --data-raw '{ "query": "Bearer auth (e.g. ", "offset": 0, "count": 10 }' ``` ```json...
[ "crates/analytics/src/search.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4100
Bug: Add Client Secret auth support for accepting PM data from Client For an existing record in the PM table, the saved PM resources viz., Locker ID, MIT Details to be updated with client secret Auth.
diff --git a/crates/api_models/src/events/payment.rs b/crates/api_models/src/events/payment.rs index b27ca142c94..b8f4a9d6d90 100644 --- a/crates/api_models/src/events/payment.rs +++ b/crates/api_models/src/events/payment.rs @@ -90,7 +90,7 @@ impl ApiEventMetric for PaymentMethodResponse { fn get_api_event_type(&s...
2024-03-19T14:34:07Z
## Description <!-- Describe your changes in detail --> **Vaulting without authentication in a non-payments context.** This PR enables - - client_secret auth for `/payment_methods` (Generation and storage of client_secret) - Vaulting of payment_method with client_secret auth using `/payment_methods/:pm_id/save`...
e458e4907e39961f386900f21382c9ace3b7c392
1. Create a customer ``` curl --location --request POST 'http://localhost:8080/customers' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_y5XDvbHKvRI6K2dAhTgXvNgQykJiqLXeYtSysCQzPGBGz3RZoUPjPcfD1LW8teYO' \ --data-raw '{ "email": "guest@example.com"...
[ "crates/api_models/src/events/payment.rs", "crates/api_models/src/payment_methods.rs", "crates/common_enums/src/enums.rs", "crates/diesel_models/src/payment_method.rs", "crates/diesel_models/src/schema.rs", "crates/openapi/src/openapi.rs", "crates/router/src/core/customers.rs", "crates/router/src/core...
juspay/hyperswitch
juspay__hyperswitch-4099
Bug: Generate Client Secret for /payment_methods requests Create a `PM Client Secret` during the `/payment_methods` API request. This would to be stored in the PM Table and used as reference for updating the PM record once the card is saved.
diff --git a/crates/api_models/src/events/payment.rs b/crates/api_models/src/events/payment.rs index b27ca142c94..b8f4a9d6d90 100644 --- a/crates/api_models/src/events/payment.rs +++ b/crates/api_models/src/events/payment.rs @@ -90,7 +90,7 @@ impl ApiEventMetric for PaymentMethodResponse { fn get_api_event_type(&s...
2024-03-19T14:34:07Z
## Description <!-- Describe your changes in detail --> **Vaulting without authentication in a non-payments context.** This PR enables - - client_secret auth for `/payment_methods` (Generation and storage of client_secret) - Vaulting of payment_method with client_secret auth using `/payment_methods/:pm_id/save`...
e458e4907e39961f386900f21382c9ace3b7c392
1. Create a customer ``` curl --location --request POST 'http://localhost:8080/customers' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_y5XDvbHKvRI6K2dAhTgXvNgQykJiqLXeYtSysCQzPGBGz3RZoUPjPcfD1LW8teYO' \ --data-raw '{ "email": "guest@example.com"...
[ "crates/api_models/src/events/payment.rs", "crates/api_models/src/payment_methods.rs", "crates/common_enums/src/enums.rs", "crates/diesel_models/src/payment_method.rs", "crates/diesel_models/src/schema.rs", "crates/openapi/src/openapi.rs", "crates/router/src/core/customers.rs", "crates/router/src/core...
juspay/hyperswitch
juspay__hyperswitch-3814
Bug: Allow off-session payments using Payment Method ID (only with API Key auth) When a mandate is created on connector's end, we store the connector mandate details in our payment methods table. Now in order to make recurring payment with this, we basically have to do a token based payment where set the `setup_futu...
diff --git a/crates/api_models/src/mandates.rs b/crates/api_models/src/mandates.rs index bd5c5b5a1a0..4adda0d9af4 100644 --- a/crates/api_models/src/mandates.rs +++ b/crates/api_models/src/mandates.rs @@ -113,3 +113,10 @@ pub struct MandateListConstraints { #[serde(rename = "created_time.gte")] pub created_ti...
2024-03-19T12:12:06Z
## Description <!-- Describe your changes in detail --> When a mandate is created on connector's end, we store the connector mandate details in our payment methods table. Now in order to make recurring payment with this, we basically have to do a token based payment where set the `setup_future_usage = off_session` a...
0f8384dde996a455920bd4127c1d0ce62d5312ba
1. mca creation - ``` curl --location 'http://localhost:8080/account/merchant_1710841026/connectors' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data '{ "connector_type": "fiz_operations", "business_country": "US", "bus...
[ "crates/api_models/src/mandates.rs", "crates/api_models/src/payments.rs", "crates/openapi/src/openapi.rs", "crates/router/src/core/mandate/helpers.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/helpers.rs", "crates/router/src/core/payments/operations/payment_approve.rs", "...