repo
stringclasses
1 value
instance_id
stringlengths
22
24
problem_statement
stringlengths
30
24.1k
patch
stringlengths
0
1.9M
test_patch
stringclasses
1 value
created_at
stringdate
2022-11-25 05:12:07
2025-06-13 10:24:29
hints_text
stringlengths
0
228k
base_commit
stringlengths
40
40
test_instructions
stringlengths
0
232k
filenames
listlengths
0
300
juspay/hyperswitch
juspay__hyperswitch-4127
Bug: remove mandates from nmi collection and fix assertions in paypal remove mandates from nmi collection and fix assertions in paypal
diff --git a/postman/collection-dir/nmi/Flow Testcases/Happy Cases/.meta.json b/postman/collection-dir/nmi/Flow Testcases/Happy Cases/.meta.json index ad1de26c594..2161cc26a05 100644 --- a/postman/collection-dir/nmi/Flow Testcases/Happy Cases/.meta.json +++ b/postman/collection-dir/nmi/Flow Testcases/Happy Cases/.meta...
2024-03-19T11:03:12Z
## Description <!-- Describe your changes in detail --> touched 2 collections namely, NMI and PayPal: - fixed assertion in PayPal which broke due to [this](https://github.com/juspay/hyperswitch/commit/fc81f90f6168dc6e08cbfacdda0f59e99def07da) commit - removed mandate collection from NMI as it is not supported ...
944089d6914cb6bece9056f78b9aabf90e485151
- NMI <img width="486" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/53f628e9-693f-4794-8ed9-64f53afb82be"> - PayPal <img width="499" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/b6c4f789-1b85-4dbf-bb6d-1dcafc6420b0"> `.json` files are auto-generate fro...
[ "postman/collection-dir/nmi/Flow Testcases/Happy Cases/.meta.json", "postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario12-Add card flow/.meta.json", "postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario10-Create a mandate and recurring payment/Payments - Retrieve-copy/.event.meta.json", ...
juspay/hyperswitch
juspay__hyperswitch-4163
Bug: feat: create an api to get countries and currencies for a connector and pmt Currently there is no way to set countries and currencies for a particular connector and payment method type. This api should give the list of countries and currencies supported by a given connector and payment method type combination. ...
diff --git a/crates/api_models/src/events/payment.rs b/crates/api_models/src/events/payment.rs index 346ee34b2cf..b26ee0ae68e 100644 --- a/crates/api_models/src/events/payment.rs +++ b/crates/api_models/src/events/payment.rs @@ -3,8 +3,9 @@ use common_utils::events::{ApiEventMetric, ApiEventsType}; use crate::{ p...
2024-03-19T09:33:32Z
## Description Make a api to fetch the countries and currencies supported by a particular connector. This api will be used by the dashboard to restrict payment methods to specific countries/currencies. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an ope...
b8c927593a85792588e582bf25f2daadfa5f7fb0
- When the filters are set for the combination of connector and payment method type ``` curl --location 'http://localhost:8080/payment_methods/filter?connector=stripe&paymentMethodType=affirm' \ --header 'Authorization: Bearer JWT' \ ``` ``` { "currencies": [ "USD" ], "countrie...
[ "crates/api_models/src/events/payment.rs", "crates/api_models/src/payment_methods.rs", "crates/common_enums/src/enums.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/payment_methods.rs", "cra...
juspay/hyperswitch
juspay__hyperswitch-4178
Bug: [FIX] fix 404 when not sending payment_id to compatibility layer
diff --git a/crates/router/src/compatibility/stripe/payment_intents.rs b/crates/router/src/compatibility/stripe/payment_intents.rs index 87560032ea4..56bcb2d58d0 100644 --- a/crates/router/src/compatibility/stripe/payment_intents.rs +++ b/crates/router/src/compatibility/stripe/payment_intents.rs @@ -7,7 +7,8 @@ use rou...
2024-03-19T09:18:36Z
## Description <!-- Describe your changes in detail --> Fixed the bug where `compatibility` layer would throw 404 if `payment_id` is not sent. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have a...
a843713126cea102064b342b6fc82429d89d758a
- Create a payment without passing the `payment_id` to stripe compatibility layer ```bash curl --location 'http://localhost:8080/vs/v1/payment_intents' \ --header 'Content-Type: application/x-www-form-urlencoded' \ --header 'User-Agent: helloMozilla/5.0 (Linux; Android 12; SM-S906N Build/QP1A.190711.020; wv) Ap...
[ "crates/router/src/compatibility/stripe/payment_intents.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3227
Bug: [FEATURE] : Billwerk payments integration ### Feature Description Billwerk Payments is a payment gateway provider focused on Northern Europe countries. ### Possible Implementation Product: [https://www.billwerk.plus/payments/](https://www.billwerk.plus/payments/) Docs: [https://docs.reepay.com/](https://do...
diff --git a/config/config.example.toml b/config/config.example.toml index 81cd78f7244..ee868beb092 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -170,6 +170,7 @@ applepay.base_url = "https://apple-pay-gateway.apple.com/" authorizedotnet.base_url = "https://apitest.authorize.net/xml/v1/re...
2024-03-19T05:51:33Z
## Description <!-- Describe your changes in detail --> Add Billwerk Template connector code https://reference.reepay.com/api/ ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd ...
027080683d00a616e6dec40f57a4586951d76b09
Template code added hence no testing required
[ "config/config.example.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/enums.rs", "crates/common_enums/src/enums.rs", "crates/connector_configs/src/connector.rs", "crates/router/src/configs/settings.rs", "crates/router/src/connector.rs", "crates/router/src/conn...
juspay/hyperswitch
juspay__hyperswitch-4121
Bug: [REFACTOR]: update Stripe API version in the API headers ### Bug Description Stripe supports multiple api versions and each stripe merchant account has its own default api version based on the time the account has created. So whenever Hyperswitch calls stripe API, stripe will respond based on merchant's defa...
diff --git a/crates/router/src/connector/stripe/transformers.rs b/crates/router/src/connector/stripe/transformers.rs index dd8fc845e28..b85247607e0 100644 --- a/crates/router/src/connector/stripe/transformers.rs +++ b/crates/router/src/connector/stripe/transformers.rs @@ -34,7 +34,7 @@ use crate::{ pub mod auth_head...
2024-03-18T17:50:58Z
## Description Fixes https://github.com/juspay/hyperswitch/issues/4121 Stripe supports multiple api versions and each stripe merchant account has its own default api version based on the time the account has created. So whenever Hyperswitch calls stripe API, stripe will respond based on merchant's default version wh...
fcfd567bfe55747dcb05c88def96373a707f8c78
1. Run whole Stripe Postman collection 2. Create a stripe Card Payment Request ``` { "amount": 6540, "currency": "INR", "confirm": true, "capture_method": "automatic", "capture_on": "2022-09-10T10:11:12Z", "amount_to_capture": 6540, "customer_id": "StripeCustomer", "email": ...
[ "crates/router/src/connector/stripe/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4117
Bug: Add span metadata to `tokio` spawned futures Add span metadata to `tokio` spawned futures, as logs do not have parent span context.
diff --git a/crates/common_utils/src/macros.rs b/crates/common_utils/src/macros.rs index c07b2112db2..b8d5743d8fe 100644 --- a/crates/common_utils/src/macros.rs +++ b/crates/common_utils/src/macros.rs @@ -47,13 +47,6 @@ macro_rules! newtype { }; } -#[macro_export] -macro_rules! async_spawn { - ($t:block) => ...
2024-03-18T14:41:37Z
## Description <!-- Describe your changes in detail --> Add span metadata to `tokio` spawned futures, as logs do not have parent span context. Also removed unused marco. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue ...
fcfd567bfe55747dcb05c88def96373a707f8c78
Logs of save payment method. Initially the `request_id` was not available for this logs. ![image](https://github.com/juspay/hyperswitch/assets/83439957/ce6f2d8a-de71-44cf-b4a2-67691288f5ab)
[ "crates/common_utils/src/macros.rs", "crates/diesel_models/src/lib.rs", "crates/diesel_models/src/macros.rs", "crates/drainer/src/handler.rs", "crates/drainer/src/lib.rs", "crates/router/src/bin/scheduler.rs", "crates/router/src/core/payments/flows/authorize_flow.rs", "crates/router/src/core/payments/...
juspay/hyperswitch
juspay__hyperswitch-3993
Bug: Route payments across `nrid_supported_connectors` if `pg_agnostic_mit` For the MITs check for the `pg_agnostic_mit` config flag, if it is `enabled` then apply the routing rule for the list of pg_agnostic connectors. In this case we need to apply the same routing rules which is configured for the other payments ...
diff --git a/crates/router/src/connector/stripe/transformers.rs b/crates/router/src/connector/stripe/transformers.rs index 45aeb1e9074..19a37ab0fb7 100644 --- a/crates/router/src/connector/stripe/transformers.rs +++ b/crates/router/src/connector/stripe/transformers.rs @@ -136,6 +136,7 @@ pub struct PaymentIntentRequest...
2024-03-18T03:41:18Z
## Description <!-- Describe your changes in detail --> During the MIT process, there needs to be validation to check the off_session field. If set to true, then check if the pg_agnostic_mit config is enabled. If it is, perform a lookup in the payment methods table with the payment_method_id in the MIT payment reque...
63d2b6855acee1adeae2efff10f424e056af0bcb
Create a Merchant account Create a mca for stripe, adyen or cybersource Enable the pg_agnostic endpoint ``` curl --location 'https://sandbox.hyperswitch.io/routing/business_profile/:business_profile_id/configs/pg_agnostic_mit' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ ...
[ "crates/router/src/connector/stripe/transformers.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/operations/payment_confirm.rs", "crates/router/src/core/payments/operations/payment_response.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3994
Bug: Use NRID in recurring payments if the merchant config is enabled During the MIT process, there needs to be validation to check the off_session field. If set to true, then check if the `pg_agnostic_mit` config is enabled. If it is, perform a lookup in the payment methods table with the `payment_method_id` in the...
diff --git a/crates/router/src/connector/stripe/transformers.rs b/crates/router/src/connector/stripe/transformers.rs index 45aeb1e9074..19a37ab0fb7 100644 --- a/crates/router/src/connector/stripe/transformers.rs +++ b/crates/router/src/connector/stripe/transformers.rs @@ -136,6 +136,7 @@ pub struct PaymentIntentRequest...
2024-03-18T03:41:18Z
## Description <!-- Describe your changes in detail --> During the MIT process, there needs to be validation to check the off_session field. If set to true, then check if the pg_agnostic_mit config is enabled. If it is, perform a lookup in the payment methods table with the payment_method_id in the MIT payment reque...
63d2b6855acee1adeae2efff10f424e056af0bcb
Create a Merchant account Create a mca for stripe, adyen or cybersource Enable the pg_agnostic endpoint ``` curl --location 'https://sandbox.hyperswitch.io/routing/business_profile/:business_profile_id/configs/pg_agnostic_mit' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ ...
[ "crates/router/src/connector/stripe/transformers.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/operations/payment_confirm.rs", "crates/router/src/core/payments/operations/payment_response.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4112
Bug: [BUG] : [Stripe] make name mandatory ### Bug Description Field called name in stripe Shipping address is not an optional at the stripe's end but it is optional in hyperswitch's stripe transformer ### Expected Behavior Stripe transformer must treat name as a mandatory field ### Actual Behavior Stripe trans...
diff --git a/crates/router/src/connector/stripe/transformers.rs b/crates/router/src/connector/stripe/transformers.rs index 45e2c795a0d..82dee21f7e6 100644 --- a/crates/router/src/connector/stripe/transformers.rs +++ b/crates/router/src/connector/stripe/transformers.rs @@ -117,7 +117,7 @@ pub struct PaymentIntentRequest...
2024-03-15T10:41:12Z
## Description <!-- Describe your changes in detail --> Field called `name` in stripe Shipping address is not optional at the stripe's end. This PR makes it a mandatory field. ## Test Case <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provi...
0f6c97c47ddd0980ace13840faadc4b6eefaa48e
[ "crates/router/src/connector/stripe/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4090
Bug: [BUG]: Stripe API version should be passed in the API headers ### Bug Description Stripe supports multiple api versions and each stripe merchant account has its own default api version based on the time the account has created. So whenever Hyperswitch calls stripe API, stripe will respond based on merchant'...
diff --git a/crates/router/src/connector/stripe.rs b/crates/router/src/connector/stripe.rs index 7718c2fc729..958867465f9 100644 --- a/crates/router/src/connector/stripe.rs +++ b/crates/router/src/connector/stripe.rs @@ -7,6 +7,7 @@ use diesel_models::enums; use error_stack::{IntoReport, ResultExt}; use masking::Peek...
2024-03-15T10:16:44Z
## Description Fixes https://github.com/juspay/hyperswitch/issues/4090 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus on ...
0f6c97c47ddd0980ace13840faadc4b6eefaa48e
Create a stripe Card Payment Request ``` { "amount": 6540, "currency": "INR", "confirm": true, "capture_method": "automatic", "capture_on": "2022-09-10T10:11:12Z", "amount_to_capture": 6540, "customer_id": "StripeCustomer", "email": "guest@example.com", "name": "John Doe",...
[ "crates/router/src/connector/stripe.rs", "crates/router/src/connector/stripe/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4106
Bug: [FEATURE] [CYBERSOURCE/BOA] Add support for payment status ACCEPTED and CANCELLED ### Feature Description The payment response must address the `ACCEPTED` and `CANCELLED` payment status from connectors Bankofamerica and Cybersource. ### Possible Implementation Payment status `ACCEPTED` and `CANCELLED` ...
diff --git a/crates/router/src/connector/bankofamerica/transformers.rs b/crates/router/src/connector/bankofamerica/transformers.rs index 8e30e2b0475..b9a14321025 100644 --- a/crates/router/src/connector/bankofamerica/transformers.rs +++ b/crates/router/src/connector/bankofamerica/transformers.rs @@ -896,6 +896,8 @@ pub...
2024-03-15T10:03:52Z
## Description <!-- Describe your changes in detail --> The payment response will also address the `ACCEPTED` and `CANCELLED` payment status from connectors Bankofamerica and Cybersource. ![Screenshot 2024-03-15 at 6 52 36 PM](https://github.com/juspay/hyperswitch/assets/41580413/e1ba2ec2-9ebb-43da-8afe-f20f06ddf6e...
0f6c97c47ddd0980ace13840faadc4b6eefaa48e
Testing can be done by creating a recurring payment of 2USD using a Zero Auth Mandate in Cybersource. 1. Payments Intent Create: Request: ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' ...
[ "crates/router/src/connector/bankofamerica/transformers.rs", "crates/router/src/connector/cybersource/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4103
Bug: fix: populate merchant connector id and profile id in payments list Currently in payments list response, merchant connector id and profile id is not getting populated for payments list response, though the value is present in db.
diff --git a/crates/router/src/core/payments/transformers.rs b/crates/router/src/core/payments/transformers.rs index 315ddd3b39b..313d520fdac 100644 --- a/crates/router/src/core/payments/transformers.rs +++ b/crates/router/src/core/payments/transformers.rs @@ -952,6 +952,8 @@ impl ForeignFrom<(storage::PaymentIntent, s...
2024-03-15T09:14:10Z
## Description `Profile_id` and `merchant_connector_id` is to be populated for payments list response. ## Motivation and Context closes #4103 #
f9db641058179b846d4bf3ce69a7679b4e9541fc
Use the curl to get payments list: ``` curl --location 'http://localhost:8080/payments/list' \ --header 'Content-Type: application/json' \ --header 'Cookie: token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWZjNzgyOTUtM2JiMy00OGJjLThlZDgtNzFjMzVjMzMxYWU2IiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNjk3NzE2ODcwIiwi...
[ "crates/router/src/core/payments/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4084
Bug: [BUG] : payments response has `payment_method_billing` even if not passed in request. ### Bug Description When a payment is created with `payment.billing`, in the response `payment.payment_method_data.billing` is also populated. ### Expected Behavior `payment.pament_method_data.billing` should be empty...
diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs index b8a4c5dfc67..fb53e484afd 100644 --- a/crates/router/src/core/payments.rs +++ b/crates/router/src/core/payments.rs @@ -2122,6 +2122,7 @@ pub mod payment_address { pub struct PaymentAddress { shipping: Option<api::Add...
2024-03-14T04:37:42Z
## Description <!-- Describe your changes in detail --> This PR fixes the inconsistency in payments response. More details can be found in the linked issue. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If ...
74345212ed3052c54323ae143cd89a4b03b23d15
- Added postman test cases - Create a payment without `payment_method_billing`. ```bash curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'api-key: dev_RenK6PvquNMkUrABw8BOK9A8zbl4Zh270G1zjFDc7KMGkc5XJY5mgAnv6iDbnKIn' \ --data-raw '{ "amount": 6540, ...
[ "crates/router/src/core/payments.rs", "crates/router/src/core/payments/transformers.rs", "crates/router/src/types/transformers.rs", "postman/collection-dir/stripe/Flow Testcases/Happy Cases/Scenario29-Create payment with payment method billing/Payments - Create/event.test.js", "postman/collection-dir/stripe...
juspay/hyperswitch
juspay__hyperswitch-4083
Bug: [FEATURE] : [Cybersource] Add Card holder name in dynamic field ### Feature Description Add Card holder name as required field in dynamic field ### Possible Implementation Add Card holder name as required field in dynamic field in `default.rs` ### Have you spent some time checking if this feature request ha...
diff --git a/crates/router/src/configs/defaults.rs b/crates/router/src/configs/defaults.rs index 5c2d62b40b8..f9d98647d1b 100644 --- a/crates/router/src/configs/defaults.rs +++ b/crates/router/src/configs/defaults.rs @@ -757,7 +757,8 @@ impl Default for super::settings::RequiredFields { ...
2024-03-13T19:33:13Z
## Description <!-- Describe your changes in detail --> add card holder name as a required field in dynamic fields for cyber source ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, w...
74345212ed3052c54323ae143cd89a4b03b23d15
- Create a payment for Cybersource with confirm false ``` curl --location 'http://localhost:8080/payments' \ --header 'Accept: application/json' \ --header 'Content-Type: application/json' \ --header 'api-key: dev_NEqxtA08zn0qi3szJqYNmFXpQQt41BfwDpOE1sVucX37yJUN7jpR6QkmrlJCuWf5' \ --data-raw '{ "amount":...
[ "crates/router/src/configs/defaults.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4079
Bug: [FEATURE] [AUTHORIZEDOTNET] Add apple pay manual flow to dashboard ### Feature Description Apple pay manual flow needs to be added for authorizedotnet in the following dashboards: 1. Integ 2. Sandbox 3. Production ### Possible Implementation Apple pay manual flow needs to be added for authorizedotnet in t...
diff --git a/crates/connector_configs/toml/development.toml b/crates/connector_configs/toml/development.toml index 58e54c36220..11025de310a 100644 --- a/crates/connector_configs/toml/development.toml +++ b/crates/connector_configs/toml/development.toml @@ -334,6 +334,8 @@ merchant_secret="Source verification key" pa...
2024-03-13T14:24:05Z
## Description <!-- Describe your changes in detail --> Apple pay manual flow is added for authorizedotnet in the following dashboards: 1. Integ 2. Sandbox 3. Production ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the iss...
a21d6d5e16730e0d12ea924066b4592c76f26bfd
Only Dashboard WASM Changes
[ "crates/connector_configs/toml/development.toml", "crates/connector_configs/toml/production.toml", "crates/connector_configs/toml/sandbox.toml" ]
juspay/hyperswitch
juspay__hyperswitch-4074
Bug: [BUG] `requires_cvv` being sent as `true` in customer payment methods list for off-session payments ### Bug Description When doing a customer payment methods list for an off-session payment, `requires_cvv` is received as `true`. ### Expected Behavior For off-session payments, `requires_cvv` should be false. ...
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index 847950d4f45..4c38e41e9bb 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -2736,6 +2736,16 @@ pub async fn list_customer_payment_metho...
2024-03-13T11:47:24Z
## Description <!-- Describe your changes in detail --> This PR updates the logic to decide the `requires_cvv` parameter in the customer payment methods list api to also depend on whether the payment is an off-session payment. ## Motivation and Context <!-- Why is this change required? What problem does it sol...
d82960c1cca5ae43d1a51f8fff6f7b6b9e016c2b
List Customer Payment Methods for normal payment (requires_cvv = true): <img width="546" alt="image" src="https://github.com/juspay/hyperswitch/assets/47862918/8e72d476-89a8-4e2b-ae11-b9a4074065be"> List Customer Payment Methods for off-session payment (requires_cvv = false): <img width="546" alt="image" src="ht...
[ "crates/router/src/core/payment_methods/cards.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4069
Bug: [BUG] Give higher precedence to connector mandate id over network txn id for mandates ### Bug Description Recurring mandate payments with Adyen fail with a payment method not found error. ### Expected Behavior When doing recurring mandate payments with Adyen, the core should make the payment with the conne...
diff --git a/crates/router/src/connector/cybersource/transformers.rs b/crates/router/src/connector/cybersource/transformers.rs index 2fd559680ea..fb80c0a1c48 100644 --- a/crates/router/src/connector/cybersource/transformers.rs +++ b/crates/router/src/connector/cybersource/transformers.rs @@ -508,8 +508,15 @@ impl ...
2024-03-13T10:30:25Z
## Description <!-- Describe your changes in detail --> Currently in the core, for a recurring mandate payment, if the mandate has both a network transaction ID and a connector mandate ID associated with it, the core picks the network transaction ID for making the recurring payment. This causes mandate payments to f...
fad23ad032971497b07035c530397539413b7653
Recurring Mandate payment with Adyen Initial Mandate Payment: <img width="546" alt="image" src="https://github.com/juspay/hyperswitch/assets/47862918/c9701cef-ca32-4428-bc6a-b91feb026e7c"> Recurring Mandate payment (Succeeding): <img width="546" alt="image" src="https://github.com/juspay/hyperswitch/assets/...
[ "crates/router/src/connector/cybersource/transformers.rs", "crates/router/src/core/payments/operations/payment_create.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4070
Bug: [BUG] Fix postman collections - [x] NMI: Scenarios 10 and 11 are run before 1 - [x] Bluesnap: Inconsistency of payment method being saved in saved card flow - [x] Checkout: Inconsistency of payment method being saved in saved card flow - [x]Adyen: Inconsistency of payment method being saved in saved card flo...
diff --git a/postman/collection-dir/bluesnap/Flow Testcases/Happy Cases/Scenario10-Save card flow/Payments - Create/event.prerequest.js b/postman/collection-dir/bluesnap/Flow Testcases/Happy Cases/Scenario10-Save card flow/Payments - Create/event.prerequest.js new file mode 100644 index 00000000000..27965bb9c01 --- /de...
2024-03-13T10:26:04Z
## Description <!-- Describe your changes in detail --> - NMI: Removed `Copy` from `.meta.json` to fix `Scenario 10` an `11` from running before `Scenario 1` - Bluesnap: Make `customer_id` unique to avoid payment method from being saved Closes #4070 > [!NOTE] > `.json` files are auto-generated ## Motiv...
d82960c1cca5ae43d1a51f8fff6f7b6b9e016c2b
- NMI (mandates are failing. @Aprabhat19 is looking into it) <img width="1240" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/c1493bb8-abc1-4c7b-900a-9910c594ed59"> <img width="1084" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/e3d7e602-891d-4526-9840-ceb41c43...
[ "postman/collection-dir/bluesnap/Flow Testcases/Happy Cases/Scenario10-Save card flow/Payments - Create/event.prerequest.js", "postman/collection-dir/bluesnap/Flow Testcases/Happy Cases/Scenario11-Pass Invalid CVV for save card flow and verify failed payment Copy/Payments - Create/event.prerequest.js", "postman...
juspay/hyperswitch
juspay__hyperswitch-4072
Bug: add dispute events to global search indexes add dispute events to global search indexes
diff --git a/config/config.example.toml b/config/config.example.toml index daf554f00ad..b5344882913 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -599,3 +599,4 @@ region = "eu-central-1" payment_attempts = "hyperswitch-payment-attempt-events" payment_intents = "hyperswitch-payment-intent...
2024-03-13T10:15:27Z
## Description Search APIs for dashboard global search enhancement - adding dispute events index ## Motivation and Context add dispute events index to global-search #
d82960c1cca5ae43d1a51f8fff6f7b6b9e016c2b
tested locally
[ "config/config.example.toml", "config/deployments/env_specific.toml", "config/development.toml", "config/docker_compose.toml", "crates/analytics/src/lib.rs", "crates/analytics/src/search.rs", "crates/api_models/src/analytics/search.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4067
Bug: [BUG] WASM build is failing ### Bug Description WASM build fails when I run `make euclid-wasm` ### Expected Behavior Build should be completed successfully ### Actual Behavior Build Fails ### Steps To Reproduce Provide an unambiguous set of steps to reproduce this bug. Include code or configuration to re...
diff --git a/crates/cards/src/validate.rs b/crates/cards/src/validate.rs index 14d4c6e4c12..08ad127047c 100644 --- a/crates/cards/src/validate.rs +++ b/crates/cards/src/validate.rs @@ -2,7 +2,7 @@ use std::{fmt, ops::Deref, str::FromStr}; use masking::{PeekInterface, Strategy, StrongSecret, WithType}; #[cfg(not(tar...
2024-03-13T09:43:15Z
## Description <!-- Describe your changes in detail --> Fixed `FromStr` implementation on `CardNumber` to work with wasm related feature configs. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't ha...
d82960c1cca5ae43d1a51f8fff6f7b6b9e016c2b
Run `make euclid-wasm` to verify if Wasm build was successful. <img width="1180" alt="Screenshot 2024-03-13 at 3 12 07 PM" src="https://github.com/juspay/hyperswitch/assets/61539176/480b4373-36ba-401a-a18c-849541c524d7">
[ "crates/cards/src/validate.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4020
Bug: [REFACTOR] : Setup payment_method_status from trackers to show in payment repsonse ### Feature Description `payment_method` object from DB will be derived in `get_tracker` . We need to set the `payment_method_status` depending upon the derived status for the payments with no `on_session`. ### Possible Implem...
diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs index b8a4c5dfc67..7f500eeee21 100644 --- a/crates/router/src/core/payments.rs +++ b/crates/router/src/core/payments.rs @@ -2210,7 +2210,6 @@ where pub authorizations: Vec<diesel_models::authorization::Authorization>, pub aut...
2024-03-13T07:52:01Z
## Description <!-- Describe your changes in detail --> `payment_method` object from DB will be derived in `get_tracker` . We need to set the `payment_method_status` depending upon the derived status for the payments with no `on_session`. Moreover removing field `payment_method_status` from `PaymentsData` as it is...
9878fd90660fb14512e7f26f81b70fc4a1f58aa8
Sample curl: ### `Payment Create` with confirm as false: ``` curl --location 'http://127.0.0.1:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_eZdRVkfE8sbYE7JSzm2Tu0HAca0PHRY6u3JoSFBukHuxoYeXw7bgwr7Gy2DJn1kS' \ --data-raw '{ "amoun...
[ "crates/router/src/core/payments.rs", "crates/router/src/core/payments/operations/payment_approve.rs", "crates/router/src/core/payments/operations/payment_cancel.rs", "crates/router/src/core/payments/operations/payment_capture.rs", "crates/router/src/core/payments/operations/payment_complete_authorize.rs", ...
juspay/hyperswitch
juspay__hyperswitch-4053
Bug: [REFACTOR] Enable country currency filter for cards ### Feature Description The functionality to process payments for specific countries and currencies is required for certain connectors. This feature should be implemented based on the connector configurations for cards. ### Possible Implementation The confi...
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index 847950d4f45..765eac93f59 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -2356,15 +2356,27 @@ fn filter_pm_based_on_config<'a>( ...
2024-03-13T07:23:23Z
## Description <!-- Describe your changes in detail --> This PR enables country, currency filter for cards in list payment methods for merchants ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't hav...
5c380def254ddc25aa296fa907734f14cf08694b
Payment Method List needs to be verified for USD and Non-USD payments via BOA: 1. Payments Request(with confirm false): ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data-raw '{ ...
[ "crates/router/src/core/payment_methods/cards.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4051
Bug: [BUG] 3DS Payments through Complete Authorize flow failing ### Bug Description When doing a 3DS payment that proceeds through the Complete Authorize flow, the token data fetch from Redis fails due to a missing `payment_method` parameter. ### Expected Behavior The token data fetch from Redis should succeed wi...
diff --git a/crates/router/src/core/payments/operations/payment_complete_authorize.rs b/crates/router/src/core/payments/operations/payment_complete_authorize.rs index 4e38294d4dd..0f08d14e439 100644 --- a/crates/router/src/core/payments/operations/payment_complete_authorize.rs +++ b/crates/router/src/core/payments/oper...
2024-03-13T07:12:58Z
## Description <!-- Describe your changes in detail --> This PR fixes the issue where token data fetch from Redis was failing for 3DS payments going through the complete authorize flow. The issue being that the payment method was being taken from the request, where it may not be present. The solution was to add the ...
5c380def254ddc25aa296fa907734f14cf08694b
3DS Payments with Cybersource (failing before, passing now) Payment Confirmation: <img width="962" alt="image" src="https://github.com/juspay/hyperswitch/assets/47862918/95baacc2-a53b-4181-9c02-c75d6d404f96"> Payment Redirection (Succeeding): <img width="1128" alt="image" src="https://github.com/juspay/hyperswi...
[ "crates/router/src/core/payments/operations/payment_complete_authorize.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4049
Bug: [BUG] : [Cybersource] Mandate creation condition ### Bug Description Currently mandate gets created if `mandate_data` is passed in the request which is deprecated ### Expected Behavior Create mandate with connector if setup_future_usgae: off_session and customer_acceptance is present ### Actual Behavior Cu...
diff --git a/crates/router/src/connector/cybersource/transformers.rs b/crates/router/src/connector/cybersource/transformers.rs index 60ff508d39c..2fd559680ea 100644 --- a/crates/router/src/connector/cybersource/transformers.rs +++ b/crates/router/src/connector/cybersource/transformers.rs @@ -1,5 +1,6 @@ use api_models...
2024-03-12T17:00:50Z
## Description <!-- Describe your changes in detail --> Create mandate with connector if `setup_future_usgae: off_session` and `customer_acceptance` is present. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. ...
3eff4ebd3a60b5831cbec0158527475c8f7d7eb4
- Create a Mandate Payment ``` curl --location 'http://localhost:8080/payments' \ --header 'Accept: application/json' \ --header 'Content-Type: application/json' \ --header 'api-key: dev_j23UDZ4X6JcYN6Jz3esn78yIMGYYCEjA3oCBvwogG8vqb8AjGnFGRMezdSkxlJDX' \ --data-raw '{ "amount": 2810, "currency": "US...
[ "crates/router/src/connector/cybersource/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4047
Bug: [BUG] : [Adyen] Production URL endpoint ### Bug Description For Adyen production URL endpoint is not correctly configured as compared to how it is used ### Expected Behavior `/` is missing in the end for production endpoint ### Actual Behavior For Adyen production URL endpoint is not correctly configured a...
diff --git a/config/deployments/production.toml b/config/deployments/production.toml index 892f11e9415..a6a37858308 100644 --- a/config/deployments/production.toml +++ b/config/deployments/production.toml @@ -17,7 +17,7 @@ payout_connector_list = "wise" [connectors] aci.base_url = "https://eu-test.oppwa.com/" -adye...
2024-03-12T12:58:21Z
## Description <!-- Describe your changes in detail --> - Update Prod URL endpoint - Handle refunds webhooks using hyperswitch internal refund id - Add card holder name ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the iss...
708cce926125a29b406db48cf0ebd35b217927d4
- Trigger a refunds transaction ``` curl --location 'http://localhost:8080/refunds' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_gwfA0IT4jpKdcUSmJlWMJ0jawjc5ziP6lA91du0gpc9ydEzI5HajDN18Wr72NkS7' \ --data '{ "payment_id": "pay_ow2YSNvgVDZlGTv3o8w...
[ "config/deployments/production.toml", "crates/router/src/connector/adyen.rs", "crates/router/src/connector/adyen/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3891
Bug: Generate and publish Open API specs
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 33d355d255a..dd0c5e4b05c 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -354,6 +354,7 @@ pub struct PaymentsRequest { pub mandate_data: Option<MandateData>, /// Passing this ob...
2024-03-12T09:57:46Z
## Description update open-api spec to have payment changes ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus on the imple...
ac8ddd40208f3da5f65ca97bf5033cea5ca3ebe3
[ "crates/api_models/src/payments.rs", "crates/openapi/src/routes/customers.rs", "crates/openapi/src/routes/payments.rs", "openapi/openapi_spec.json" ]
juspay/hyperswitch
juspay__hyperswitch-3991
Bug: Store Network Reference ID against the Payment Method ID for all off-session payments During the CIT there needs to be a validation which check for the `setup_future_usage` field, if it is set to `off_session` the NRID returned from the connector needs to be stored against the particular `payment_method_id` in ...
diff --git a/crates/diesel_models/src/payment_method.rs b/crates/diesel_models/src/payment_method.rs index 7e8dcb639c3..7c28f4cd281 100644 --- a/crates/diesel_models/src/payment_method.rs +++ b/crates/diesel_models/src/payment_method.rs @@ -126,6 +126,10 @@ pub enum PaymentMethodUpdate { LastUsedUpdate { ...
2024-03-12T08:10:34Z
## Description <!-- Describe your changes in detail --> During the CIT there needs to be a validation which check for the setup_future_usage field, if it is set to off_session the NRID returned from the connector needs to be stored against the particular payment_method_id in the network_transaction_id column of the ...
ad1f74f2c3da9e2a40e8646d8af07081e7ac3ee1
Create a Merchant account Create a mca for stripe, adyen or cybersource Create a mandate payment (Setup mandate) ``` { "amount": 0, "currency": "USD", "confirm": true, "capture_method": "automatic", "capture_on": "2022-09-10T10:11:12Z", "customer_id": "singh", "email": "guest@e...
[ "crates/diesel_models/src/payment_method.rs", "crates/router/src/connector/stripe/transformers.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payments/operations/payment_response.rs", "crates/router/src/core/payments/operations/payment_status.rs", "crates/router/src/core/p...
juspay/hyperswitch
juspay__hyperswitch-4037
Bug: Filter wallet payment method from mca based on customer pm https://github.com/juspay/hyperswitch/issues/3741 Apple pay wallet is getting filtered out from list merchant payment method if the customer has saved it already. This has to be done for all wallets
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index fccacfef45d..985ddcfe849 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -1344,42 +1344,50 @@ pub async fn list_payment_methods( ...
2024-03-11T16:56:04Z
## Description <!-- Describe your changes in detail --> https://github.com/juspay/hyperswitch/pull/3953 Similar to above issue but now the PR refactors to filter out any wallet payment method from mca if it is saved by a customer ## Motivation and Context <!-- Why is this change required? What problem does it...
e87f2ea8c5669473940df8bc2f5c61fdf3f218ff
1. Create mca ``` curl --location 'http://localhost:8080/account/merchant_1709561576/connectors' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data '{ "connector_type": "fiz_operations", "connector_name": "stripe", "connecto...
[ "crates/router/src/core/payment_methods/cards.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4036
Bug: [BUG] [AUTHORIZEDOTNET] Connector Audit ### Bug Description Authorizedotnet Connector Audit fixes. 1. Production endpoint is wrong 2. Connector Transaction ID is not passed in 2XX Error Response 3. Default case handling in code ### Expected Behavior Authorizedotnet Connector Audit fixes. 1. Product...
diff --git a/config/deployments/production.toml b/config/deployments/production.toml index 892f11e9415..6bfcad3ad50 100644 --- a/config/deployments/production.toml +++ b/config/deployments/production.toml @@ -21,7 +21,7 @@ adyen.base_url = "https://{{merchant_endpoint_prefix}}-checkout-live.adyenpaymen adyen.secondary...
2024-03-11T13:26:12Z
## Description <!-- Describe your changes in detail --> Authorizedotnet Connector Audit fixes: 1. Production endpoint fixed. 2. Connector Transaction ID added to 2XX Error Response 3. Default case handling removed ## Motivation and Context <!-- Why is this change required? What problem does it solve? If ...
ce3625cb0cdccc750a073c012f0e541b014c3190
Testing needs to be done by creating a 2XX error for a payment via authorizedotnet. 2XX error can be generated by doing 2 back to back transactions with same request body which will trigger a dupliacte transaction error at connector end. Request: ```curl curl --location 'http://localhost:8080/payments' \ --head...
[ "config/deployments/production.toml", "crates/router/src/connector/authorizedotnet.rs", "crates/router/src/connector/authorizedotnet/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4033
Bug: [FEATURE] Integrate Plaid as an Open Banking Payment connector ### Feature Description Integrate Plaid as an Open Banking Payment connector. Pre-requisite would be the Open Banking payments core Integration - #3612 ### Possible Implementation Similar to regular connector integration ### Have you spent so...
diff --git a/config/config.example.toml b/config/config.example.toml index 2ffb69c3e3d..eab5e84df9c 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -206,6 +206,7 @@ payme.base_url = "https://sandbox.payme.io/" paypal.base_url = "https://api-m.sandbox.paypal.com/" payu.base_url = "https://s...
2024-03-11T09:25:55Z
## Description <!-- Describe your changes in detail --> Webhook Implementation for Plaid ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so ...
7391416e2473eab0474bd01bb155a9ecc96da263
[ "config/config.example.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/admin.rs", "crates/api_models/src/payments.rs", "crates/common_enums/src/enums.rs", "crates/common_enums/src/transformers.rs", "crates/euclid/src/frontend/dir/enums.rs", "crates/euclid/src/f...
juspay/hyperswitch
juspay__hyperswitch-4026
Bug: [REFACTOR] Allow deletion of default payment method for a customer if only one pm exists Currently, we don't delete the default payment method of a customer. But if only one payment method exists for a customer which is also set to default, then we should allow to delete that payment method
diff --git a/crates/diesel_models/src/customers.rs b/crates/diesel_models/src/customers.rs index cefb0c240ec..bda7af157de 100644 --- a/crates/diesel_models/src/customers.rs +++ b/crates/diesel_models/src/customers.rs @@ -52,5 +52,5 @@ pub struct CustomerUpdateInternal { pub modified_at: Option<PrimitiveDateTime>, ...
2024-03-08T19:02:18Z
## Description <!-- Describe your changes in detail --> Currently, we don't delete the default payment method of a customer. But if only one payment method exists for a customer which is also set to default, then we should allow to delete that payment method ## Motivation and Context <!-- Why is this change re...
f5697f372c8e1f27c00f7dd120dc7813bf0e0e8a
1. Store a new card or any other payment method for a customer. (Ensure only one payment method exists for a customer) 2. Set that payment method as default ``` curl --location --request POST 'http://localhost:8080/customers/cus_aXfFGQOFT7JFU47GYhZK/payment_methods/pm_37h7qElY2aTWBEPSgovJ/default' \ --header 'C...
[ "crates/diesel_models/src/customers.rs", "crates/diesel_models/src/query/generics.rs", "crates/diesel_models/src/query/payment_method.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/db/kafka_store.rs", "crates/router/src/db/payment_method.rs", "crates/router/src/types/domain/c...
juspay/hyperswitch
juspay__hyperswitch-3992
Bug: Create a merchant config for enable `pg_agnostic_mit` Create a merchant config (`pg_agnostic_mit`) to enable usage of Network Transaction/Reference ID in recurring mandate payments. This will be a `business profile` level config that a merchant specifies. **API Spec:-** ``` POST /business_profile/{bp_id}/c...
diff --git a/crates/api_models/src/routing.rs b/crates/api_models/src/routing.rs index 4d32f1d0f81..723e6eccc36 100644 --- a/crates/api_models/src/routing.rs +++ b/crates/api_models/src/routing.rs @@ -11,7 +11,7 @@ pub use euclid::{ use serde::{Deserialize, Serialize}; use utoipa::ToSchema; -use crate::enums::{self...
2024-03-08T14:19:25Z
## Description <!-- Describe your changes in detail --> This pr adds a merchant config (`pg_agnostic_mit`) to enable usage of Network Transaction/Reference ID in recurring `MIT` payments. This will be a `business profile` level config that a merchant specifies. ## Motivation and Context <!-- Why is this chang...
aecf4aeacce33c3dc03e089ef6d62af93e29ca9a
Set processor agnostic MIT config as `true` <img width="737" alt="image" src="https://github.com/juspay/hyperswitch/assets/83439957/76c54b6a-888c-42fc-b5b2-024eecabf868"> config status from db ![image](https://github.com/juspay/hyperswitch/assets/83439957/dbcd0961-685d-4e76-92da-48ed7da33756) Set processor agnost...
[ "crates/api_models/src/routing.rs", "crates/router/src/core/routing.rs", "crates/router/src/core/routing/helpers.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/routing.rs", "crates/router_env/src/logger/types.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4021
Bug: [BUG] : error message is different when invalid data is passed for `payment_method_data` ### Bug Description It bugs out when invlaid card data is passed to the `payment_method_data`. The following payment method data contains invalid card number ```json { "payment_method_data": { "card": { ...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index e5882fcb49d..dee5f2d0757 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -1095,12 +1095,19 @@ mod payment_method_data_serde { #[serde(untagged)] enum __Inner { ...
2024-03-08T12:24:17Z
## Description <!-- Describe your changes in detail --> If any invalid payment method data is passed, the error we received was wrong. This PR fixes it. More context can be found in the linked issue. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open is...
f5697f372c8e1f27c00f7dd120dc7813bf0e0e8a
- Postman and unit test cases.
[ "crates/api_models/src/payments.rs", "postman/collection-dir/stripe/Flow Testcases/Happy Cases/Scenario32-Ensure API Contract for Payment Method Data/Payments - Card Payment Method/.event.meta.json", "postman/collection-dir/stripe/Flow Testcases/Happy Cases/Scenario32-Ensure API Contract for Payment Method Data...
juspay/hyperswitch
juspay__hyperswitch-3950
Bug: [REFACTOR] handle payment method duplication in payouts Currently, when same payment method is saved in payouts, duplication logic is not handled. Locker returns `duplication_check` based on which duplication of payment methods has to be handled in Hyperswitch. This issue similar to https://github.com/juspay...
diff --git a/crates/router/src/core/payment_methods/transformers.rs b/crates/router/src/core/payment_methods/transformers.rs index f639aa59218..357f077332d 100644 --- a/crates/router/src/core/payment_methods/transformers.rs +++ b/crates/router/src/core/payment_methods/transformers.rs @@ -27,6 +27,15 @@ pub enum StoreLo...
2024-03-07T16:47:54Z
## Description Explained in #3950 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus on the implementation (unless it is an ...
21e2d78117a9e25708b8c6a2280f6a836ee86072
_**Note -** DM for postman collection_ ![image](https://github.com/juspay/hyperswitch/assets/46213975/a5fe810a-3a32-48dc-a07a-018f77381ea1) For ensuring card duplication is handled in payouts flow, we use below procedure (assuming merchant accounts and connector accounts are created) - Create a new customer -...
[ "crates/router/src/core/payment_methods/transformers.rs", "crates/router/src/core/payouts.rs", "crates/router/src/core/payouts/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3890
Bug: Routing changes to choose between MIT details and raw card Will have to be extended in future to choose between MIT details vs Network Reference ID as well
diff --git a/config/development.toml b/config/development.toml index 6d4914af8b4..6e27e110ee9 100644 --- a/config/development.toml +++ b/config/development.toml @@ -581,4 +581,4 @@ enabled = true file_storage_backend = "file_system" [unmasked_headers] -keys = "user-agent" \ No newline at end of file +keys = "user-a...
2024-03-07T12:39:39Z
## Description <!-- Describe your changes in detail --> This PR adds routing support for token-based MIT payments. Basically, the merchant can have their customers set up their payment method for off session payments with Hyperswitch. Behind the scenes, Hyperswitch sets up an MIT/Mandate with the connector. Now, ...
7391416e2473eab0474bd01bb155a9ecc96da263
1. Create a Merchant Account, and a Merchant Connector Account (preferably Cybersource) 2. Create and Confirm a `Setup Mandate` request ```bash curl --location 'http://127.0.0.1:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_OnB9g3l1v3cq...
[ "config/development.toml", "crates/api_models/src/payments.rs", "crates/router/src/connector/dlocal/transformers.rs", "crates/router/src/core/mandate.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/flows/authorize_flow.rs", "crates/router/src/core/payments/flows/setup_mandate...
juspay/hyperswitch
juspay__hyperswitch-3914
Bug: [FEATURE] statement_descriptor_suffix and statement_descriptor_name not being sent to Adyen. Please implement. ### Feature Description It is important to be able to have custom statements (and also it is available feature on Stripe), so it should be on Adyen as well. ### Possible Implementation It should pro...
diff --git a/config/deployments/production.toml b/config/deployments/production.toml index 382ad018f1d..7c543feed7e 100644 --- a/config/deployments/production.toml +++ b/config/deployments/production.toml @@ -17,7 +17,7 @@ payout_connector_list = "wise" [connectors] aci.base_url = "https://eu-test.oppwa.com/" -adye...
2024-03-07T12:25:27Z
## Description <!-- Describe your changes in detail --> - Add shopper statement and metadata in payments request - Add additional fields and validations over fields like `IP address`, `billing_address`, `Email` and Shopper details ## Motivation and Context <!-- Why is this change required? What problem does...
7391416e2473eab0474bd01bb155a9ecc96da263
- Create Klarna Payment ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_6LLuoNT8iBk4hTwVLSQ6zTJOiBmeuLSJ5NoakZTZItC4IifnHLy7cTWPZXW4uhbq' \ --data-raw '{ "amount": 6540, "currency": "EUR",...
[ "config/deployments/production.toml", "config/development.toml", "crates/router/src/connector/adyen/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4009
Bug: [BUG] Fix failing postman collections ### Feature Description Fix failing postman collections for cybersource, checkout and bluesnap ### Possible Implementation Add customer_acceptance for all the save card flows ### Have you spent some time checking if this feature request has been raised before? - [X...
diff --git a/postman/collection-dir/bankofamerica/Flow Testcases/Happy Cases/Scenario2-Create payment with confirm false/Payments - Confirm/request.json b/postman/collection-dir/bankofamerica/Flow Testcases/Happy Cases/Scenario2-Create payment with confirm false/Payments - Confirm/request.json index 16f6e13983f..3ba8c3...
2024-03-07T12:22:35Z
## Description fix postman collections for saving cards with customer_acceptance ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR c...
f9b6f5da36c3a57da4b89db3151996403e2f3dfd
<img width="1296" alt="Screenshot 2024-03-07 at 6 09 36 PM" src="https://github.com/juspay/hyperswitch/assets/55580080/a2d7f54b-e6b7-403e-982b-41a572ed70be">
[ "postman/collection-dir/bankofamerica/Flow Testcases/Happy Cases/Scenario2-Create payment with confirm false/Payments - Confirm/request.json", "postman/collection-dir/bankofamerica/Flow Testcases/Happy Cases/Scenario4-Create payment with Manual capture/Payments - Create/request.json", "postman/collection-dir/ba...
juspay/hyperswitch
juspay__hyperswitch-3998
Bug: Creating a domain config (ENV) - `nrid_supported_connectors` Create a application level config (`nrid_supported_connectors`) that contains the list of connectors that supports pg agnostic MITs,
diff --git a/config/deployments/integration_test.toml b/config/deployments/integration_test.toml index 77040f79a4a..67dfddd0d55 100644 --- a/config/deployments/integration_test.toml +++ b/config/deployments/integration_test.toml @@ -129,6 +129,9 @@ bank_redirect.giropay.connector_list = "adyen,globalpay" card.credit =...
2024-03-07T11:34:54Z
## Description <!-- Describe your changes in detail --> Add `network_transaction_id` column in the `payment_methods` table as it is required to store the NRID against the respective payment_method_id. This NRID will later be used processor agnostic MITs. This pr also adds application level config (`network_transacto...
aecf4aeacce33c3dc03e089ef6d62af93e29ca9a
columns in the `payment_methods` table ![image](https://github.com/juspay/hyperswitch/assets/83439957/ee1f3540-7c55-4484-b841-9c85696a1a59)
[ "config/deployments/integration_test.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/diesel_models/src/payment_method.rs", "crates/diesel_models/src/schema.rs", "crates/router/src/configs/secrets_transformers.rs", "crates/router/src/configs/se...
juspay/hyperswitch
juspay__hyperswitch-3986
Bug: Create a new column in PM table to store NRID **Schema changes** `network_transaction_id` column needs to be created in the `payment_methods` table to store the NTID / NRID for all the required payment method.
diff --git a/config/deployments/integration_test.toml b/config/deployments/integration_test.toml index 77040f79a4a..67dfddd0d55 100644 --- a/config/deployments/integration_test.toml +++ b/config/deployments/integration_test.toml @@ -129,6 +129,9 @@ bank_redirect.giropay.connector_list = "adyen,globalpay" card.credit =...
2024-03-07T11:34:54Z
## Description <!-- Describe your changes in detail --> Add `network_transaction_id` column in the `payment_methods` table as it is required to store the NRID against the respective payment_method_id. This NRID will later be used processor agnostic MITs. This pr also adds application level config (`network_transacto...
aecf4aeacce33c3dc03e089ef6d62af93e29ca9a
columns in the `payment_methods` table ![image](https://github.com/juspay/hyperswitch/assets/83439957/ee1f3540-7c55-4484-b841-9c85696a1a59)
[ "config/deployments/integration_test.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/diesel_models/src/payment_method.rs", "crates/diesel_models/src/schema.rs", "crates/router/src/configs/secrets_transformers.rs", "crates/router/src/configs/se...
juspay/hyperswitch
juspay__hyperswitch-4002
Bug: ci: add a step in `check-msrv` get the rust version from `Cargo.toml` In the CI-pr workflow we had hardcoded rust-version to be installed for the check-msrv. This pr adds a step to get rust version from Cargo.toml.
2024-03-07T07:54:56Z
## Description <!-- Describe your changes in detail --> In the `CI-pr` workflow we had hardcoded `rust-version` to be installed for the `check-msrv`. This pr adds a step to get rust version from `Cargo.toml`. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes ...
6671bff3b11e9548a0085046d2594cad9f2571e2
`Check compilation on MSRV toolchain (ubuntu-latest)` has run successfully on this pr. No other testing required.
[]
juspay/hyperswitch
juspay__hyperswitch-4000
Bug: fix: revert mget use authorization In the hosted environment, where we have multiple redis clusters `mget` is not working as expected and throwing the following error: `Unknown Error: CROSSSLOT Keys in request don't hash to the same slot`. Temporary fix is to revert the PR which is using `mget`
diff --git a/crates/router/src/services/authentication/blacklist.rs b/crates/router/src/services/authentication/blacklist.rs index b5cdcaf0840..2ee8302be63 100644 --- a/crates/router/src/services/authentication/blacklist.rs +++ b/crates/router/src/services/authentication/blacklist.rs @@ -80,25 +80,19 @@ pub async fn ch...
2024-03-07T07:29:36Z
## Description `mget` is not working in the hosted version. So, this PR will revert the #3945 which uses `mget``. ## Motivation and Context closes #4000 #
6671bff3b11e9548a0085046d2594cad9f2571e2
Authentication and authorization should work as expected. 1. Signin with any user ``` curl --location 'http://localhost:8080/user/signin' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "user email", "password": "password" }' ``` Response: ``` { "token": JWT, ...
[ "crates/router/src/services/authentication/blacklist.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3995
Bug: [BUG] Outgoing webhook retry scheduler tasks remain in pending state if merchant webhook URL is not configured ### Bug Description In the outgoing webhook retry process tracker (scheduler) workflow introduced in #3842, the process tracker entries added before the webhook is attempted to be delivered remain i...
diff --git a/crates/router/src/core/errors.rs b/crates/router/src/core/errors.rs index 968181061a8..609337744d1 100644 --- a/crates/router/src/core/errors.rs +++ b/crates/router/src/core/errors.rs @@ -259,45 +259,44 @@ pub enum WebhooksFlowError { #[error("Webhook details for merchant not configured")] Mercha...
2024-03-06T20:36:25Z
## Description <!-- Describe your changes in detail --> This PR fixes a bug in the outgoing webhook retry workflow where process tracker tasks remained in pending state if merchant webhook URL was not configured in the business profile. For more information, see: #3995. In addition, this PR includes these changes...
0aa40cbae75fd4cf5b13cfc518ff761b2b673246
Locally, by running `router`, `producer` and `consumer`, and testing for these three cases: 1. For a business profile with webhook URL configured, the behavior should remain as before: webhooks should either be delivered successfully in the first attempt, or scheduled for later retries. 1. Screenshot of a we...
[ "crates/router/src/core/errors.rs", "crates/router/src/core/webhooks.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3979
Bug: Setup-future-usage to be defaulted to on-session
diff --git a/crates/router/src/core/payments/helpers.rs b/crates/router/src/core/payments/helpers.rs index 76893659e03..2bcd317bafc 100644 --- a/crates/router/src/core/payments/helpers.rs +++ b/crates/router/src/core/payments/helpers.rs @@ -3865,7 +3865,10 @@ pub fn validate_mandate_data_and_future_usage( setup_fu...
2024-03-06T14:13:15Z
## Description accept customer_acceptance to save the card ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus on the impleme...
9bee5ab3f10d7d7c832c2ba5c4990bd85af32928
- Create an MA and an MCA - Do a save card payment only by passing customer_acceptance -> Create ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_lb8obpTBmS60ZtaXLd4xVGkE69qnZKdEDfCyzM6UDJKVHyg5tEu6Wk...
[ "crates/router/src/core/payments/helpers.rs", "crates/router/src/core/payments/tokenization.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3766
Bug: Insert `payment_method_id` in redis for wallet tokens To be discussed: In case of wallets, banks what should be the Payment Token equivalent? Note: Update last_used field
diff --git a/crates/router/src/core/payment_methods.rs b/crates/router/src/core/payment_methods.rs index df1fb1e358d..220a28771c8 100644 --- a/crates/router/src/core/payment_methods.rs +++ b/crates/router/src/core/payment_methods.rs @@ -192,6 +192,8 @@ impl PaymentMethodRetrieve for Oss { ) ...
2024-03-06T12:54:20Z
## Description <!-- Describe your changes in detail --> This PR adds support for wallet tokens to be inserted in redis with value being `payment_method_id` ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If yo...
d220e815dc81925b205fb57d5d4f05883c1a7cde
1. Create mca with wallets being a payment method ``` curl --location 'http://localhost:8080/account/merchant_1709561576/connectors' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data '{ "connector_type": "fiz_operations", "conne...
[ "crates/router/src/core/payment_methods.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/types/storage/payment_method.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3987
Bug: feat: get specific user role details api Currently frontend is using the user list api to get the details of the users in a particular merchant account. If somebody is in a user details page and refreshes, FE will again call list api to get the details as there is no api to get the details of a specific user.
diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs index ec3e2dce9b2..4ef04981572 100644 --- a/crates/api_models/src/events/user.rs +++ b/crates/api_models/src/events/user.rs @@ -11,11 +11,11 @@ use crate::user::{ GetMetaDataRequest, GetMetaDataResponse, GetMultipleMetaDat...
2024-03-06T12:39:09Z
## Description <!-- Describe your changes in detail --> Currently there is no way to get the details of user and their role directly. This API solves it by taking the email of the user and returns the details. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes ...
2db39e8bb9af3d55e3d075d77ff8616ee2e15f0a
Postman. ``` curl --location 'http://localhost:8080/user/user?email=user@hyperswitch.io' \ --header 'Authorization: Bearer JWT' ``` ``` { "email": "user email", "name": "user name", "role_id": "merchant_view_only", "role_name": "View Only", "status": "Active", "last_modified_at":...
[ "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "crates/router_env/src/logger/types.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3983
Bug: refactor: kms decrypt analytics config Add support for kms decrypting the analytics config
diff --git a/Cargo.lock b/Cargo.lock index 60bc557972c..4571d80fd87 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -349,6 +349,7 @@ dependencies = [ "error-stack", "external_services", "futures 0.3.28", + "hyperswitch_interfaces", "masking", "once_cell", "reqwest", diff --git a/crates/analytics/Cargo.toml b/cr...
2024-03-06T11:53:38Z
## Description <!-- Describe your changes in detail --> This PR adds support for kms decrypting the analytics config ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend s...
2db39e8bb9af3d55e3d075d77ff8616ee2e15f0a
Locally set up aws kms and decryption of analytics config was successful. Currently Sandbox uses clickhouse setup, so this PR cannot be tested. Can be deployed in custom pod by using Sqlx there.
[ "Cargo.lock", "crates/analytics/Cargo.toml", "crates/analytics/src/lib.rs", "crates/router/src/configs/secrets_transformers.rs", "crates/router/src/configs/settings.rs", "crates/router/src/routes/app.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3980
Bug: [FEATURE] [AUTHORIZEDOTNET] Pass billing address details ### Feature Description Billing Address needs to be passed in payments request. ### Possible Implementation Billing Address needs to be passed in BillTo field of payments request for connector authorizedotnet. ### Have you spent some time checking if ...
diff --git a/crates/router/src/connector/authorizedotnet/transformers.rs b/crates/router/src/connector/authorizedotnet/transformers.rs index 8ba610d66d4..2d6f2e040a4 100644 --- a/crates/router/src/connector/authorizedotnet/transformers.rs +++ b/crates/router/src/connector/authorizedotnet/transformers.rs @@ -7,10 +7,17 ...
2024-03-06T11:08:36Z
## Description <!-- Describe your changes in detail --> - If the billing address is included in the payments request, it will be transmitted to the connector. - Additionally, the `connector_request_reference_id` is now transmitted within the order description, making it visible in the transaction details on the c...
a1fd36a1abea4d400386a00ccf182dfe9da5bcda
Test payments (manual and automatic) for authorizedotnet. 1. Automatic: - Request: ```curl curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data '{ "amount": 1234, "currency...
[ "crates/router/src/connector/authorizedotnet/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3977
Bug: [BUG]: [Adyen] Webhook Psync response Handler ### Bug Description Currently the Psync response handler for webhook tightly coupled to payments response which is creating a lot of bugs in status and transaction id updates - Update Psync response handler to consume the incoming webhook response - Handle Webh...
diff --git a/crates/router/src/connector/adyen.rs b/crates/router/src/connector/adyen.rs index 93301364e62..67e319ddc22 100644 --- a/crates/router/src/connector/adyen.rs +++ b/crates/router/src/connector/adyen.rs @@ -403,6 +403,13 @@ impl ) -> CustomResult<types::ErrorResponse, errors::ConnectorError> { s...
2024-03-06T09:30:25Z
## Description <!-- Describe your changes in detail --> - Update Psync response handler to consume the incoming webhook response - Handle Webhook Status Mapping ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. ...
a1fd36a1abea4d400386a00ccf182dfe9da5bcda
For Adyen all the subsequent payments are confirmed via Webhooks, So test Capture, Cancel, Refunds and Wallets payments. Payment Methods Need to be tested - Klarna (Manual Capture) ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/...
[ "crates/router/src/connector/adyen.rs", "crates/router/src/connector/adyen/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-1464
Bug: [BUG] Adyen payment status update for Manual Capture payment ### Bug Description We have to rely on web hooks for status update for manual capture payment. But the problem is in both Auto And Manual capture flow we will receive `Authorized` event web hook, additionally in manual capture we will get one more...
diff --git a/crates/router/src/connector/adyen.rs b/crates/router/src/connector/adyen.rs index 93301364e62..67e319ddc22 100644 --- a/crates/router/src/connector/adyen.rs +++ b/crates/router/src/connector/adyen.rs @@ -403,6 +403,13 @@ impl ) -> CustomResult<types::ErrorResponse, errors::ConnectorError> { s...
2024-03-06T09:30:25Z
## Description <!-- Describe your changes in detail --> - Update Psync response handler to consume the incoming webhook response - Handle Webhook Status Mapping ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. ...
a1fd36a1abea4d400386a00ccf182dfe9da5bcda
For Adyen all the subsequent payments are confirmed via Webhooks, So test Capture, Cancel, Refunds and Wallets payments. Payment Methods Need to be tested - Klarna (Manual Capture) ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/...
[ "crates/router/src/connector/adyen.rs", "crates/router/src/connector/adyen/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3942
Bug: Set the PM as default if there is no Default PM for a customer
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index ce7f48405e2..712b9a0edd7 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -84,7 +84,8 @@ pub async fn create_payment_method( paym...
2024-03-05T19:07:00Z
## Description Set the initial payment method as default until its explicitly set ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR...
1a8056799c7c2b486044b403fff2e74310c98c44
- Create an MA and a MCA - Do a save card payment - Do a ListPaymentMethodsForCustomers the default flag would be set to true for the initial card - Do a save card payment, with other card , its default flag would be set to false, until explicitly set to true , using the endpoint `/customers/:customer_id/payment_met...
[ "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payments/tokenization.rs", "crates/router/src/routes/payment_methods.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3957
Bug: Disallow deletion of default payment method for a customer Should not allow deletion of the default_payment_method of a customer. Error Message: "Cannot delete the default payment method" Merchant Error Handling: "Retry after setting another PM as default"
diff --git a/crates/router/src/compatibility/stripe/errors.rs b/crates/router/src/compatibility/stripe/errors.rs index d28e988a039..c1f8b5e9c75 100644 --- a/crates/router/src/compatibility/stripe/errors.rs +++ b/crates/router/src/compatibility/stripe/errors.rs @@ -251,6 +251,8 @@ pub enum StripeErrorCode { Invalid...
2024-03-05T11:43:51Z
## Description <!-- Describe your changes in detail --> If a payment method is set as a default payment method for a customer and it is tried to be deleted, we throw a invalid request error. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, pl...
c65729adc9009f046398312a16841532fdc177da
1. Store a card or any other payment method 2. Set that payment method as default ``` curl --location --request POST 'http://localhost:8080/customers/cus_aXfFGQOFT7JFU47GYhZK/payment_methods/pm_37h7qElY2aTWBEPSgovJ/default' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --...
[ "crates/router/src/compatibility/stripe/errors.rs", "crates/router/src/core/errors/api_error_response.rs", "crates/router/src/core/errors/transformers.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/routes/payment_methods.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3960
Bug: [FEATURE] Add USD Currency Filter for Bank Of America ### Feature Description The Bankofamerica connector needs to have a currency filter, restricting support exclusively to USD payments. ### Possible Implementation Config changes. ### Have you spent some time checking if this feature request has be...
diff --git a/config/config.example.toml b/config/config.example.toml index dd05eb61d47..e9e80911e84 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -454,6 +454,12 @@ pix = { country = "BR", currency = "BRL" } red_compra = { country = "CL", currency = "CLP" } red_pagos = { country = "UY", c...
2024-03-05T10:20:49Z
## Description <!-- Describe your changes in detail --> The Bankofamerica connector now includes a currency filter, restricting support exclusively to USD payments. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here....
c65729adc9009f046398312a16841532fdc177da
Payment Method List needs to be verified for USD and Non-USD payments via BOA: 1. Payments Request(with confirm false): ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data-raw '{ ...
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml" ]
juspay/hyperswitch
juspay__hyperswitch-3955
Bug: [BUG] [CI] NMI and Stripe CI failing As we can see here in CI's commit, https://github.com/juspay/hyperswitch/commit/cd7040fa8cad2e69a53e3ed609c9eb8a8a17495a, it is clear that NMI and Stripe collection are the ones that are affected which again can be confirmed with https://github.com/juspay/hyperswitch/actions...
diff --git a/crates/test_utils/src/main.rs b/crates/test_utils/src/main.rs index 006075895b5..ba0d2eb358b 100644 --- a/crates/test_utils/src/main.rs +++ b/crates/test_utils/src/main.rs @@ -18,17 +18,21 @@ fn main() { // Filter out None values leaving behind Some(Path) let paths: Vec<String> = runner.modifie...
2024-03-05T04:09:55Z
## Description <!-- Describe your changes in detail --> This PR is a fix for postman CI failing due a bug introduced in https://github.com/juspay/hyperswitch/pull/3807. As we can see here in CI's commit, https://github.com/juspay/hyperswitch/commit/cd7040fa8cad2e69a53e3ed609c9eb8a8a17495a, it is clear that NM...
2b0fbc70749338d5c501bbb782d6fc4747890d61
NMI <img width="478" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/0f1aa4d9-5bf2-4014-9b5d-00ac992ead9e"> Stripe <img width="491" alt="image" src="https://github.com/juspay/hyperswitch/assets/69745008/4c8a2d3b-cd5e-41de-b4aa-d91dc9f00149">
[ "crates/test_utils/src/main.rs", "postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario9-Update amount with automatic capture/Payments - Confirm/request.json", "postman/collection-dir/nmi/Flow Testcases/Happy Cases/Scenario9a-Update amount with manual capture/Payments - Confirm/request.json", "postma...
juspay/hyperswitch
juspay__hyperswitch-3741
Bug: Merchant Payment Method List changes for wallet restrictions Since we are currently not getting any differentiators for multiple mandates set via a single wallet, we will be restricting setting up recurring payment for wallet only once. - In Merchant Payment Method list, wallet types which are already saved ...
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index ce7f48405e2..8d54a6be408 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -1316,6 +1316,47 @@ pub async fn list_payment_methods( ...
2024-03-04T14:39:43Z
## Description <!-- Describe your changes in detail --> Since we are currently not getting any differentiators for multiple mandates set via a single wallet, we will be restricting setting up recurring payment for wallet only once. - In Merchant Payment Method list, wallet types which are already saved and in act...
087932f06044454570c971def0e82dc3d838598c
1. Create mca ``` curl --location 'http://localhost:8080/account/merchant_1709561576/connectors' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data '{ "connector_type": "fiz_operations", "connector_name": "stripe", "connecto...
[ "crates/router/src/core/payment_methods/cards.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3948
Bug: fix: Enforce uniqueness of groups in custom role assignments Permission groups should be unique while creating/updating custom role.
diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs index 6b25b692c12..643d8ac975e 100644 --- a/crates/common_enums/src/enums.rs +++ b/crates/common_enums/src/enums.rs @@ -2327,6 +2327,7 @@ pub enum RoleScope { Debug, Eq, PartialEq, + Hash, serde::Serialize, serd...
2024-03-04T13:37:03Z
## Description Enforce uniqueness of groups while role create or update. ## Motivation and Context Currently duplicate groups are allowed while role create/update. #
f132527490a7d8cd8469573d8e6856f33974959f
Try to create/update role with duplicate groups: Create ``` curl --location 'http://localhost:8080/user/role' \ --header 'Authorization: Bearer JWT' \ --header 'Content-Type: application/json' \ --data '{ "role_name": "test007", "groups": ["operations_view", "operations_manage", "operations_manage"], "ro...
[ "crates/common_enums/src/enums.rs", "crates/router/src/utils/user_role.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3612
Bug: [FEATURE] Incorporate Open Banking flows in Payments Core ### Feature Description Need to support Open banking framework in Payments core to handle integrations of open banking connectors ### Possible Implementation Will be using the payments core for implementation of open banking payment flows ### Have yo...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index bcc67100e1c..f53507fc13a 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -1600,6 +1600,7 @@ mod payment_method_data_serde { | PaymentMethodData::Voucher(_) ...
2024-03-04T13:21:57Z
## Description <!-- Describe your changes in detail --> - Added Post-Processing flows for Open banking connectors - Traits and and type changes - #3758 needs to go in first ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the...
926dcd3a3c0f3c09d39767e2a2c5721a42272322
1. Add Plaid MCA with `payment_method` as `open_banking` and `payment_method_type` as `open_banking_pis` ``` curl --location --request POST 'http://localhost:8080/account/merchant_1720607250/connectors' \ --header 'api-key: test_admin' \ --header 'Content-Type: application/json' \ --data-raw '{ "connector_t...
[ "crates/api_models/src/payments.rs", "crates/common_enums/src/enums.rs", "crates/common_enums/src/transformers.rs", "crates/connector_configs/src/response_modifier.rs", "crates/connector_configs/src/transformer.rs", "crates/euclid/src/dssa/graph.rs", "crates/euclid/src/frontend/ast/lowering.rs", "crat...
juspay/hyperswitch
juspay__hyperswitch-3944
Bug: feat: add caching for roles Currently in authorization, we look at the resource and the role in the JWT to check whether that particular call is valid or not. Upon the introduction of custom roles, this has increased db calls in the authorization phase as we need to get the permissions associated to a particul...
diff --git a/crates/api_models/src/user.rs b/crates/api_models/src/user.rs index 8f77f72aad5..1641c0ae536 100644 --- a/crates/api_models/src/user.rs +++ b/crates/api_models/src/user.rs @@ -128,8 +128,6 @@ pub struct SwitchMerchantIdRequest { pub merchant_id: String, } -pub type SwitchMerchantResponse = Dashboar...
2024-03-04T13:11:08Z
## Description <!-- Describe your changes in detail --> This PR will add caching for custom roles to reduce db calls and improve efficiency. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an...
f132527490a7d8cd8469573d8e6856f33974959f
Postman. This cannot be tested in hosted environment as redis is not accessible directly but can be tested in local environment. So, writing the instructions for local testing here. 1. Signin with a user who has assigned a custom role (not a predefined role) ``` curl --location 'http://localhost:8080/user/sig...
[ "crates/api_models/src/user.rs", "crates/api_models/src/user_role.rs", "crates/router/src/consts.rs", "crates/router/src/core/user.rs", "crates/router/src/core/user_role.rs", "crates/router/src/services/authentication/blacklist.rs", "crates/router/src/services/authorization.rs", "crates/router/src/ser...
juspay/hyperswitch
juspay__hyperswitch-3943
Bug: Use mget to check in Blocklist Kv Use MGet to check whether check multiple values in blocklist.
diff --git a/crates/router/src/services/authentication/blacklist.rs b/crates/router/src/services/authentication/blacklist.rs index 346e563ee32..3a386c7793c 100644 --- a/crates/router/src/services/authentication/blacklist.rs +++ b/crates/router/src/services/authentication/blacklist.rs @@ -66,19 +66,25 @@ pub async fn ch...
2024-03-04T13:00:49Z
## Description Use MGet to check whether role or user is blacklisted in KV. Instead of checking user and role separately, MGet can help to do it in one call. ## Motivation and Context Enhancement #
f132527490a7d8cd8469573d8e6856f33974959f
Singup --> Sigin --> Create a new role --> Invite new user with newly created role --> Sign In new user --> perform some operations which the user with assigned role can perform --> now update the role --> try performing same operation for the newly invited user. It won't be valid since role has been blocklist. Can al...
[ "crates/router/src/services/authentication/blacklist.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3937
Bug: [FEATURE] : [Coinbase][Cryptopay] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time...
diff --git a/crates/router/src/connector/coinbase/transformers.rs b/crates/router/src/connector/coinbase/transformers.rs index 5b3b6f63278..f02984136bd 100644 --- a/crates/router/src/connector/coinbase/transformers.rs +++ b/crates/router/src/connector/coinbase/transformers.rs @@ -21,7 +21,7 @@ pub struct LocalPrice { ...
2024-03-04T10:45:14Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for coinbase and cryptopay. ## Test Case <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provide relevant sc...
8c103c0f8e838a899a0c1207c88fa7617b37f138
[ "crates/router/src/connector/coinbase/transformers.rs", "crates/router/src/connector/cryptopay/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3934
Bug: [FEATURE] : [Worldline][Worldpay][Zen] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent som...
diff --git a/crates/masking/src/serde.rs b/crates/masking/src/serde.rs index a96a87f05c8..94c60eba3cf 100644 --- a/crates/masking/src/serde.rs +++ b/crates/masking/src/serde.rs @@ -27,6 +27,7 @@ pub trait SerializableSecret: Serialize {} impl SerializableSecret for Value {} impl SerializableSecret for u8 {} impl Ser...
2024-03-04T09:40:32Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Worldline, Worldpay and zen. ## Test Case <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provide releva...
ac8ddd40208f3da5f65ca97bf5033cea5ca3ebe3
[ "crates/masking/src/serde.rs", "crates/router/src/connector/utils.rs", "crates/router/src/connector/worldline/transformers.rs", "crates/router/src/connector/worldpay/requests.rs", "crates/router/src/connector/worldpay/response.rs", "crates/router/src/connector/worldpay/transformers.rs", "crates/router/s...
juspay/hyperswitch
juspay__hyperswitch-3933
Bug: [FEATURE] : [Trustpay][Volt] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time chec...
diff --git a/crates/router/src/connector/trustpay/transformers.rs b/crates/router/src/connector/trustpay/transformers.rs index 71286bda3f1..d5b65bb9975 100644 --- a/crates/router/src/connector/trustpay/transformers.rs +++ b/crates/router/src/connector/trustpay/transformers.rs @@ -6,7 +6,7 @@ use common_utils::{ pi...
2024-03-04T09:30:38Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Trustpay, Volt and Wise. ## Test Case <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provide relevant s...
f132527490a7d8cd8469573d8e6856f33974959f
[ "crates/router/src/connector/trustpay/transformers.rs", "crates/router/src/connector/volt/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3931
Bug: [FEATURE] :[Prophetpay][Rapyd][Shift4][Square] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields into a secret ...
diff --git a/crates/router/src/connector/prophetpay/transformers.rs b/crates/router/src/connector/prophetpay/transformers.rs index b3b641b6d24..563438203d8 100644 --- a/crates/router/src/connector/prophetpay/transformers.rs +++ b/crates/router/src/connector/prophetpay/transformers.rs @@ -2,7 +2,7 @@ use std::collection...
2024-03-04T07:08:32Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Prophetpay, rapyd, shift4 and square. ## Test Case <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provi...
5bb67c7dcc22f9cee51adf501bdd8455b41548db
[ "crates/router/src/connector/prophetpay/transformers.rs", "crates/router/src/connector/rapyd/transformers.rs", "crates/router/src/connector/shift4/transformers.rs", "crates/router/src/connector/square/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3929
Bug: [FEATURE] : [Paypal][Payu][Placetopay][PowerTranz] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you ...
diff --git a/crates/router/src/connector/payu/transformers.rs b/crates/router/src/connector/payu/transformers.rs index e3ad6f8b426..e8699a1a0ed 100644 --- a/crates/router/src/connector/payu/transformers.rs +++ b/crates/router/src/connector/payu/transformers.rs @@ -1,4 +1,5 @@ use base64::Engine; +use common_utils::pii...
2024-03-04T06:54:02Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Payu, Placetopay, PowerTranz and Prophetpay. # ## Impacted Area > Payme: Applepay and Googlepay > Placetopay: Card Payment > PowerTranz: Card Payment
13f6d6c10ce421329a7eb8b494fbb3bd31aed91f
1. Create a Payu Google pay payment Generate token from : https://jsfiddle.net/1agu74ve/1/ ``` "gateway": "payu" "gatewayMerchantId": "YOUR_GATEWAY_MERCHANT_ID" ``` ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ ...
[ "crates/router/src/connector/payu/transformers.rs", "crates/router/src/connector/placetopay/transformers.rs", "crates/router/src/connector/powertranz.rs", "crates/router/src/connector/powertranz/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3927
Bug: [FEATURE] : [Payme][Payeezy] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time check...
diff --git a/crates/router/src/connector/payeezy/transformers.rs b/crates/router/src/connector/payeezy/transformers.rs index 90b4b0b0bba..6d5d6db9dcf 100644 --- a/crates/router/src/connector/payeezy/transformers.rs +++ b/crates/router/src/connector/payeezy/transformers.rs @@ -1,7 +1,7 @@ use cards::CardNumber; use co...
2024-03-04T06:33:46Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Payme and Payeezy. ## Test Case <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provide relevant screens...
fee0663d665576cc80e0a8512fd8b36c91850332
[ "crates/router/src/connector/payeezy/transformers.rs", "crates/router/src/connector/payme/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3925
Bug: [FEATURE] : [Nuvei] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time checking if thi...
diff --git a/crates/router/src/connector/nuvei.rs b/crates/router/src/connector/nuvei.rs index 8d3be455d49..0e9a9634402 100644 --- a/crates/router/src/connector/nuvei.rs +++ b/crates/router/src/connector/nuvei.rs @@ -9,6 +9,7 @@ use ::common_utils::{ request::RequestContent, }; use error_stack::{IntoReport, Resu...
2024-03-04T06:23:42Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Nuvie. #
0cb95a4911054e089e6ed3c528645ee1b881ebc6
1. Create a card payment ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key:{{api_key}}' \ --data-raw '{ "amount": 20000, "currency": "USD", "confirm": true, "capture_method": "automatic"...
[ "crates/router/src/connector/nuvei.rs", "crates/router/src/connector/nuvei/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3748
Bug: [FEATURE]: add `offset` field to mandates list ### Feature Description The [mandates list](https://github.com/juspay/hyperswitch/blob/54c0b218d9f20c6388dde0f30ea525011cdad573/crates/router/src/routes/mandates.rs#L114) endpoint currently has no field to specify `offset`, which would skip certain number of ent...
diff --git a/crates/api_models/src/mandates.rs b/crates/api_models/src/mandates.rs index 7c20a902d28..bd5c5b5a1a0 100644 --- a/crates/api_models/src/mandates.rs +++ b/crates/api_models/src/mandates.rs @@ -87,6 +87,8 @@ pub struct MandateCardDetails { pub struct MandateListConstraints { /// limit on the number of ...
2024-03-03T10:30:15Z
## Description <!-- Describe your changes in detail --> Add offset to mandate list endpoint. Closes #3748 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting w...
a2f179350a7e5819db1b6088b75ff3a7b1ad9bad
- Create 10 mandates. - Use the below curl to list the first 5 mandates. ```bash curl --location 'http://localhost:8080/mandates/list?limit=5' \ --header 'api-key: dev_dg0YfZam6V6VM2KBPFLr0olm6kGM3QojUE9Ba6f8Gzzi7IIAnkN4fyfKsyc55pB4' ``` - Use the below curl to list next 5 mandates. ```bash curl --location ...
[ "crates/api_models/src/mandates.rs", "crates/router/src/db/mandate.rs", "crates/router/src/routes/mandates.rs", "crates/router/src/types/storage/mandate.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3920
Bug: [BUG] hotfix: insert locker_id as null in case of payment method not getting stored in locker If the payment is made with payment methods other than card and bank_transfer and is asked to save the payment method, we should store locker_id column as NULL in payment_methods table
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index 8c00938cadc..bea888dcce6 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -351,7 +351,13 @@ pub async fn add_payment_method( ...
2024-03-01T15:28:11Z
## Description <!-- Describe your changes in detail --> Main PR - https://github.com/juspay/hyperswitch/pull/3919 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend star...
0bca3d757c58d425813c051e263febd8d385a587
[ "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payments/tokenization.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3918
Bug: [BUG] insert `locker_id` as null in case of payment method not getting stored in locker If the payment is made with payment methods other than card and bank_transfer and is asked to save the payment method, we should store `locker_id` column as `NULL` in payment_methods table
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index 4f691859215..ce7f48405e2 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -351,7 +351,13 @@ pub async fn add_payment_method( ...
2024-03-01T14:58:08Z
## Description <!-- Describe your changes in detail --> If the payment is made with payment methods other than card and bank_transfer and is asked to save the payment method, we should store `locker_id` column as `NULL` in payment_methods table. ## Motivation and Context <!-- Why is this change required? What...
816266819928477738f70b782eab0e26b600b171
1. Create an MCA ``` curl --location 'http://localhost:8080/account/merchant_1709304245/connectors' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data '{ "connector_type": "fiz_operations", "connector_name": "stripe", "bus...
[ "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payments/tokenization.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3911
Bug: [FEATURE] : Add `WASM` support for `endpoint_prefix` in dashboard ### Feature Description Add WASM configs for dashboard to take `endpoint_prefix` as input for Adyen Connector Create. ### Possible Implementation Add WASM configs for dashboard to take `endpoint_prefix` as input for Adyen Connector Create. ##...
diff --git a/crates/connector_configs/src/common_config.rs b/crates/connector_configs/src/common_config.rs index c3cbaab4ab3..2af5b88b337 100644 --- a/crates/connector_configs/src/common_config.rs +++ b/crates/connector_configs/src/common_config.rs @@ -81,6 +81,7 @@ pub struct ApiModelMetaData { pub google_pay: Op...
2024-03-01T10:37:16Z
## Description <!-- Describe your changes in detail --> - Update Connector Account configs for WASM build - Update Postman Collection test case for Cancelled payments - Make `endpoint_prefix` as Optional in MCA-create - Change `connector_refund_id` to `psp_reference` - Add support to enforce 3DS ## Motivatio...
f95beaa189f17a6e117971a749e2b4595e1e2fc3
- Create a manual capture payment and Cancel it, it should go into processing ``` curl --location 'http://localhost:8080/payments/pay_7RzGoWYbCpeSHynBpytc/cancel' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_LyWBxSXvkIRgcdWNLamgVQul9tMWq2axdKYlmJSw...
[ "crates/connector_configs/src/common_config.rs", "crates/connector_configs/src/connector.rs", "crates/connector_configs/src/response_modifier.rs", "crates/connector_configs/src/transformer.rs", "crates/diesel_models/src/enums.rs", "crates/router/src/connector/adyen.rs", "crates/router/src/connector/adye...
juspay/hyperswitch
juspay__hyperswitch-3747
Bug: Storing MIT details in PM table instead of Mandate table Move the connector recurring payment information (`connector_mandate_id`) to the PM table. - Create a column for storing recurring_payment_details in PM table - The connector_mandate_id to be stored against he merchant_connector_id - This columns wi...
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index 4fdf957c842..5b059f255f9 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -84,6 +84,7 @@ pub async fn create_payment_method( cust...
2024-03-01T07:56:04Z
## Description store connector_mandate_details in PaymentMethods table, if its a MIT payment, i.e, if its off_session and mandate_type is not present. Also If we do the `LIstPaymentMethodforMerchnats` we get the payment_type as setup_mandate ## Motivation and Context <!-- Why is this change required? What prob...
a1fd36a1abea4d400386a00ccf182dfe9da5bcda
- Create an MA and an MCA with cybersource(cause currently creating a mandate with 0 dollars and just off_session,i.e,MIT is just supported by cybersource) -Make a zero dollar payment, with off_session and no mandate_type ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/j...
[ "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payments/tokenization.rs", "crates/router/src/core/payouts/helpers.rs", "crates/router/src/types/storage/payment_method.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3903
Bug: [BUG] : [Adyen] No configuration for production endpoint ### Bug Description There is no configuration for production endpoint, currently only sbx url is added in config files, also there is no provision to input `prefix` provided by Adyen to be added in each url for all the merchants ### Expected Behavior C...
diff --git a/config/config.example.toml b/config/config.example.toml index abe3f6b4e08..760cc2bdd00 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -409,6 +409,10 @@ afterpay_clearpay = { fields = { stripe = [ # payment_method_type = afterpay_cle payout_eligibility = true # Defaults the eli...
2024-02-29T12:17:48Z
## Description <!-- Describe your changes in detail --> - Add production live endpoint for Adyen - Fix webhooks status mapping - Fix redirection data not getting populated in encoded data - Add Live Bank Names for Ideal - Add Currency, Country config for `klarna, ideal, sofort, paypal` ## Motivation and Cont...
7db499d8a9388b9a3674f7fa130bc389151840ec
- All the flows of Adyen are required to be tested as base url and status mapping along with webhooks is changed. - Test Webhooks Extensively, the outgoing webhooks and the status updates webhooks are triggering. Please use the postman collection defined here: `postman/collection-json/adyen_uk.postman_collection....
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/enums.rs", "crates/connector_configs/toml/development.toml", "crates/conn...
juspay/hyperswitch
juspay__hyperswitch-3614
Bug: [BUG] : [Adyen] Handle redirection response incase of no connector_transaction_id ### Bug Description In Adyen, for certain payment methods that involve redirection, the /payments API call doesn't return a psp_reference (Adyen's transaction ID). In such cases, we need to save the redirectResult field from th...
diff --git a/config/config.example.toml b/config/config.example.toml index abe3f6b4e08..760cc2bdd00 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -409,6 +409,10 @@ afterpay_clearpay = { fields = { stripe = [ # payment_method_type = afterpay_cle payout_eligibility = true # Defaults the eli...
2024-02-29T12:17:48Z
## Description <!-- Describe your changes in detail --> - Add production live endpoint for Adyen - Fix webhooks status mapping - Fix redirection data not getting populated in encoded data - Add Live Bank Names for Ideal - Add Currency, Country config for `klarna, ideal, sofort, paypal` ## Motivation and Cont...
7db499d8a9388b9a3674f7fa130bc389151840ec
- All the flows of Adyen are required to be tested as base url and status mapping along with webhooks is changed. - Test Webhooks Extensively, the outgoing webhooks and the status updates webhooks are triggering. Please use the postman collection defined here: `postman/collection-json/adyen_uk.postman_collection....
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/enums.rs", "crates/connector_configs/toml/development.toml", "crates/conn...
juspay/hyperswitch
juspay__hyperswitch-3895
Bug: refactor: change create and update role apis to respond with role info
diff --git a/crates/api_models/src/events/user_role.rs b/crates/api_models/src/events/user_role.rs index aee2b3fb66c..0d42d1de7d6 100644 --- a/crates/api_models/src/events/user_role.rs +++ b/crates/api_models/src/events/user_role.rs @@ -3,7 +3,8 @@ use common_utils::events::{ApiEventMetric, ApiEventsType}; use crate::...
2024-02-29T10:55:41Z
## Description <!-- Describe your changes in detail --> This PR modifies create and update role APIs. The APIs will now respond with the role created/updated respectively. This PR also changes the names of predefined roles to snake case. ## Motivation and Context <!-- Why is this change required? What problem...
de7f400c07d85b97340255556b39383648a0fd9f
1. Create role - `organization_manage` cannot be sent in groups. - `role_name` should not be present in any other roles that merchant has access to. - Non `org_admin` won't be able to create a role with `role_scope` as `organization` - `groups` should not be empty. ``` curl --location 'http://localhost:80...
[ "crates/api_models/src/events/user_role.rs", "crates/router/src/core/user_role/role.rs", "crates/router/src/services/authorization/roles/predefined_roles.rs", "crates/router/src/utils/user_role.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3893
Bug: [FEATURE] [PLACETOPAY] Connector audit ### Feature Description Connector placetopay needs to be audited. ### Possible Implementation Connector placetopay needs to be audited. ### Have you spent some time checking if this feature request has been raised before? - [X] I checked and didn't find a similar issu...
diff --git a/crates/router/src/connector/placetopay.rs b/crates/router/src/connector/placetopay.rs index 81255f450e5..c28fed1fede 100644 --- a/crates/router/src/connector/placetopay.rs +++ b/crates/router/src/connector/placetopay.rs @@ -119,8 +119,8 @@ impl ConnectorValidation for Placetopay { ) -> CustomResult<()...
2024-02-29T10:28:24Z
## Description <!-- Describe your changes in detail --> - The authorization field retrieved during payments for Placetopay is now utilized in refund requests. The following features have been removed as they are not supported by the connector: - Manual authorization - Partial refunds ## Motivation and Con...
f132527490a7d8cd8469573d8e6856f33974959f
The following flows need to be tested for connector placetopay: 1. Authorization(Auto-capture) Request: ```curl curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data '{ "amount":320...
[ "crates/router/src/connector/placetopay.rs", "crates/router/src/connector/placetopay/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3801
Bug: [REFACTOR] provide an identifier for the api key in the expiry reminder email ### Issue Description: Currently, our system sends out reminder emails to merchants when their API key is about to expire. However, since merchants can create multiple API keys, the email lacks clarity on which specific API key is ...
diff --git a/crates/diesel_models/src/api_keys.rs b/crates/diesel_models/src/api_keys.rs index 1875fc4dc51..7676e20d224 100644 --- a/crates/diesel_models/src/api_keys.rs +++ b/crates/diesel_models/src/api_keys.rs @@ -141,6 +141,8 @@ mod diesel_impl { pub struct ApiKeyExpiryTrackingData { pub key_id: String, ...
2024-02-29T08:09:49Z
## Description <!-- Describe your changes in detail --> Refactored the api key expiry reminder workflow to include the name and prefix of the expiring API key in the email ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes the issue #3801 If you don't have ...
6b078fa339b5404f7c730322bc8597cd1104ec15
1. Create a merchant account 2. Create an api key with expiry somewhat closer to 7 days from current time in UTC format. 3. You should get an email something like below once api key expiry is exactly 7 days from current time ![image](https://github.com/juspay/hyperswitch/assets/70657455/41d40ff4-7db4-4d22-bfdd-8...
[ "crates/diesel_models/src/api_keys.rs", "crates/router/src/core/api_keys.rs", "crates/router/src/services/email/assets/api_key_expiry_reminder.html", "crates/router/src/services/email/types.rs", "crates/router/src/workflows/api_key_expiry.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3887
Bug: [Analytics] - Disputes fix psql
diff --git a/crates/diesel_models/src/dispute.rs b/crates/diesel_models/src/dispute.rs index 9bdac332295..eae8281a99d 100644 --- a/crates/diesel_models/src/dispute.rs +++ b/crates/diesel_models/src/dispute.rs @@ -29,6 +29,7 @@ pub struct DisputeNew { pub evidence: Option<Secret<serde_json::Value>>, pub profil...
2024-02-29T08:01:39Z
## Description adding dispute_amount column as int type because amount in dispute table is of string type on which we cannot have aggregation for analytics ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If ...
0936b02ade7f57eaa0213c4f4422bff7c9bb4de2
run the migration, one column will be added to dispute table called dispute_amount as BIGINT type and will backfill from amount column which is string type
[ "crates/diesel_models/src/dispute.rs", "crates/diesel_models/src/schema.rs", "crates/router/src/core/webhooks.rs", "crates/router/src/db/dispute.rs", "migrations/2024-02-28-103308_add_dispute_amount_to_dispute/down.sql", "migrations/2024-02-28-103308_add_dispute_amount_to_dispute/up.sql" ]
juspay/hyperswitch
juspay__hyperswitch-3744
Bug: Setup future usage validations for recurring payments (CIT and MIT) Setup Future Usage parameter to be used for saving PM for both CIT and MIT recurring payments. - If on-session, save card in locker and add PM for future payments based on (payment success + customer acceptance) - If off-session, save card...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 9a3afd2f0ff..d48be04b763 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -348,9 +348,12 @@ pub struct PaymentsRequest { #[remove_in(PaymentsUpdateRequest, PaymentsCreateRequest)] ...
2024-02-29T07:39:24Z
## Description store customer_acceptance in the payment_methods table and some changes to setup_future_usage - setup_future_usage should be inferred from the create and if passed in confirm should override the one in create - If customer_acceptance is passed then only the card will be saved on hyper switch's en...
5eff9d47d3e53d380ef792a8fbdf06ecf78d3d16
-make a on_session payment without customer_acceptance, card will not be saved -> Create ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_O7Znp5PhvGpSeE22Hxn4K8snHW6ObRfbA8R1isvLhUXpJRGHOINvlGufM4mGDAqj'...
[ "crates/api_models/src/payments.rs", "crates/common_enums/src/enums.rs", "crates/data_models/src/mandates.rs", "crates/router/src/core/mandate.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/flows/authorize_flow.rs", "crate...
juspay/hyperswitch
juspay__hyperswitch-3745
Bug: Customer Acceptance to be moved out of Mandate object Customer acceptance needs to be a property of the Payment Method instead of Mandate. - Move the Customer Acceptance object outside of the Mandate object in the payments request - Store the Customer Acceptance data in the PM table
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 9a3afd2f0ff..d48be04b763 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -348,9 +348,12 @@ pub struct PaymentsRequest { #[remove_in(PaymentsUpdateRequest, PaymentsCreateRequest)] ...
2024-02-29T07:39:24Z
## Description store customer_acceptance in the payment_methods table and some changes to setup_future_usage - setup_future_usage should be inferred from the create and if passed in confirm should override the one in create - If customer_acceptance is passed then only the card will be saved on hyper switch's en...
5eff9d47d3e53d380ef792a8fbdf06ecf78d3d16
-make a on_session payment without customer_acceptance, card will not be saved -> Create ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_O7Znp5PhvGpSeE22Hxn4K8snHW6ObRfbA8R1isvLhUXpJRGHOINvlGufM4mGDAqj'...
[ "crates/api_models/src/payments.rs", "crates/common_enums/src/enums.rs", "crates/data_models/src/mandates.rs", "crates/router/src/core/mandate.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/flows/authorize_flow.rs", "crate...
juspay/hyperswitch
juspay__hyperswitch-3878
Bug: [FEATURE] : [Noon] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time checking if thi...
diff --git a/crates/router/src/connector/noon/transformers.rs b/crates/router/src/connector/noon/transformers.rs index fff99109b28..fdcb2ad5afc 100644 --- a/crates/router/src/connector/noon/transformers.rs +++ b/crates/router/src/connector/noon/transformers.rs @@ -1,6 +1,6 @@ use common_utils::{ext_traits::Encode, pii...
2024-02-28T13:57:26Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Noon. ## Test Case 1. Create a mandate payment with Noon ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'A...
032d58cdbbf388cf25cbf2e43b0117b83f7d076d
[ "crates/router/src/connector/noon/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3875
Bug: [FEATURE] : [NMI] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time checking if this...
diff --git a/crates/router/src/connector/nmi/transformers.rs b/crates/router/src/connector/nmi/transformers.rs index 2f8505522b2..efde37d8715 100644 --- a/crates/router/src/connector/nmi/transformers.rs +++ b/crates/router/src/connector/nmi/transformers.rs @@ -258,7 +258,7 @@ pub struct NmiCompleteRequest { transa...
2024-02-28T13:27:17Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for NMI. ## Test Case 1. Create a NMI 3ds payment ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: appli...
44eef46e5d7f0a198be80602ceae1c843449319c
[ "crates/router/src/connector/nmi/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3873
Bug: FEATURE] : [Nexinets] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time checking if ...
diff --git a/crates/router/src/connector/nexinets/transformers.rs b/crates/router/src/connector/nexinets/transformers.rs index 07488271aea..9fdaaa36b36 100644 --- a/crates/router/src/connector/nexinets/transformers.rs +++ b/crates/router/src/connector/nexinets/transformers.rs @@ -3,7 +3,7 @@ use base64::Engine; use ca...
2024-02-28T12:17:11Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Nexinets. ## Test Case <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provide relevant screenshots)? -...
d220e815dc81925b205fb57d5d4f05883c1a7cde
[ "crates/router/src/connector/nexinets/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3871
Bug: feat: add groups for get_role_from_token api
diff --git a/crates/api_models/src/events/user_role.rs b/crates/api_models/src/events/user_role.rs index f46c5cf312b..aee2b3fb66c 100644 --- a/crates/api_models/src/events/user_role.rs +++ b/crates/api_models/src/events/user_role.rs @@ -2,8 +2,8 @@ use common_utils::events::{ApiEventMetric, ApiEventsType}; use crate...
2024-02-28T12:10:44Z
## Description <!-- Describe your changes in detail --> Get role from token will respond with groups if asked. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend startin...
f3931cf484f61a4d9c107c362d0f3f6ee872e0e7
The following api will take a query param called `groups` and if it is set to `true` it will respond with array of groups. This api was already present previously but was responding with permissions. The default behaviour without the `groups` query param is still the same (permissions will be returned). Groups wil...
[ "crates/api_models/src/events/user_role.rs", "crates/api_models/src/user_role/role.rs", "crates/router/src/core/user_role/role.rs", "crates/router/src/routes/user_role.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3868
Bug: [FEATURE] : [Multisafepay] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time checki...
diff --git a/crates/masking/src/serde.rs b/crates/masking/src/serde.rs index bb81717fd67..a96a87f05c8 100644 --- a/crates/masking/src/serde.rs +++ b/crates/masking/src/serde.rs @@ -27,6 +27,7 @@ pub trait SerializableSecret: Serialize {} impl SerializableSecret for Value {} impl SerializableSecret for u8 {} impl Ser...
2024-02-28T11:15:44Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Mulisafepay. ## Test Case <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provide relevant screenshots)?...
53559c22527dde9536aa493ad7cd3bf353335c1a
[ "crates/masking/src/serde.rs", "crates/router/src/connector/multisafepay/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3864
Bug: feat: Add Cookie in response header Using cookies for storing login token instead of local storage. Add `set-cookie` response header with json-web-token as its value.
diff --git a/Cargo.lock b/Cargo.lock index 2e4d3324d2e..7c7b2b9a761 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -224,7 +224,7 @@ dependencies = [ "bytes 1.5.0", "bytestring", "cfg-if 1.0.0", - "cookie", + "cookie 0.16.2", "derive_more", "encoding_rs", "futures-core", @@ -616,7 +616,7 @@ dependencies = [ "...
2024-02-28T09:45:16Z
## Description This is the first PR for cookie implementation. In this pr, `set-cookie` header has been added to response header, where value of the header is jwt. <!-- Describe your changes in detail --> ## Motivation and Context Storing JWT in cookies instead of local storage <!-- Why is this change requ...
e1b894770f3d37c2a255d3cec1d58ec71ba29c78
Following apis should have `set-cookie` header with jwt as value. ``` curl --location '<URL>/user/signup' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "email", "password": "password" }' ``` ``` curl --location '<URL>/user/v2/signin' \ --header 'Content-Type: application/json...
[ "Cargo.lock", "crates/masking/src/maskable.rs", "crates/router/Cargo.toml", "crates/router/src/consts.rs", "crates/router/src/core/payments/transformers.rs", "crates/router/src/core/user.rs", "crates/router/src/core/user_role.rs", "crates/router/src/services/api.rs", "crates/router/src/services/auth...
juspay/hyperswitch
juspay__hyperswitch-3753
Bug: Remove validation for `mandate_data` object in payments create request - Mandate data to be an optional field and not a required param for setup_future_usage:off-session payments
diff --git a/crates/router/src/core/payments/operations/payment_create.rs b/crates/router/src/core/payments/operations/payment_create.rs index 2eaa11f44ee..f4db64dcfb5 100644 --- a/crates/router/src/core/payments/operations/payment_create.rs +++ b/crates/router/src/core/payments/operations/payment_create.rs @@ -8,7 +8,...
2024-02-28T08:00:08Z
## Description <!-- Describe your changes in detail --> This PR removes the validation such that mandate data to be an optional field and not a required param for setup_future_usage: off-session payments ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an ope...
0fa43612c2e6c11d555efecd49e6982403a45000
Before removing validation - ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_nDlEYaebMeZFC4W7OzfK7g3ohwAqztjYxNVk58rg755miOXOFdmB3CBGJzRqvMEs' \ --data-raw '{ "amount": 0, "currency": "US...
[ "crates/router/src/core/payments/operations/payment_create.rs", "crates/router/src/core/payments/operations/payment_update.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3855
Bug: [FEATURE] : [Mollie] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time checking if th...
diff --git a/crates/router/src/connector/mollie/transformers.rs b/crates/router/src/connector/mollie/transformers.rs index af1159cd2c3..be4691341b8 100644 --- a/crates/router/src/connector/mollie/transformers.rs +++ b/crates/router/src/connector/mollie/transformers.rs @@ -64,7 +64,7 @@ pub struct MolliePaymentsRequest ...
2024-02-27T13:26:38Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Mollie. ## Test Case <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provide relevant screenshots)? --> ...
fbe9d2f19e9c0ca3af45a60e3d82b3ea774e11ce
[ "crates/router/src/connector/mollie/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3853
Bug: [FEATURE] : [Klarna] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time checking if th...
diff --git a/crates/router/src/connector/klarna/transformers.rs b/crates/router/src/connector/klarna/transformers.rs index c12f8ed1b10..29dccfbf32b 100644 --- a/crates/router/src/connector/klarna/transformers.rs +++ b/crates/router/src/connector/klarna/transformers.rs @@ -1,6 +1,6 @@ use api_models::payments; use err...
2024-02-27T13:00:03Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Klarna. ## Test Cases <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provide relevant screenshots)? --...
3e13fb908adf84974312c4785cb4ce57e46a496f
[ "crates/router/src/connector/klarna/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3848
Bug: [FEATURE] : [Iatapay] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time checking if...
diff --git a/crates/router/src/connector/iatapay/transformers.rs b/crates/router/src/connector/iatapay/transformers.rs index 55778af882b..b2507661395 100644 --- a/crates/router/src/connector/iatapay/transformers.rs +++ b/crates/router/src/connector/iatapay/transformers.rs @@ -261,7 +261,7 @@ pub struct IatapayPaymentsR...
2024-02-27T12:08:02Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Iatapay. ## Test Case <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provide relevant screenshots)? --> ...
0626ca968576709a3559243f5a64e742201dbf91
[ "crates/router/src/connector/iatapay/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3846
Bug: [BUG] [AUTHORIZEDOTNET] Wrong Status Mapping ### Bug Description The status mapping for connector Authorizdotnet does not mark the payment charged until it is settled. ### Expected Behavior The status mapping for connector Authorizdotnet should mark the payment charged when it is approved even though it is n...
diff --git a/crates/router/src/connector/authorizedotnet.rs b/crates/router/src/connector/authorizedotnet.rs index ba232c01bbf..0aba48fa5e5 100644 --- a/crates/router/src/connector/authorizedotnet.rs +++ b/crates/router/src/connector/authorizedotnet.rs @@ -9,7 +9,10 @@ use transformers as authorizedotnet; use crate:...
2024-02-27T10:08:46Z
## Description <!-- Describe your changes in detail --> - The status mapping for connector `Authorizdotnet` is fixed. - The `ref_id` field being passed in connector contains `connector_request_reference_id`. The max number of characters allowed in ref_id is 20 and hence a check has been added to only pass ref_id ...
0626ca968576709a3559243f5a64e742201dbf91
Following flows should be tested for connector Authorizdotnet: 1. Authorization(Auto Capture): ``` { "payment_id": "abcd1", "amount": 800, "currency": "USD", "confirm": true, "capture_method": "automatic", "customer_id": "StripeCustomer", "payment_method": "card", "payment...
[ "crates/router/src/connector/authorizedotnet.rs", "crates/router/src/connector/authorizedotnet/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3847
Bug: [BUG] [AUTHORIZEDOTNET] REF_ID should only allow strings which have less than 20 charcaters ### Bug Description The ref_id field being passed in connector contains connector_request_reference_id. The max number of characters allowed in ref_id is 20 while the current implementation allows it to be more than 20 ...
diff --git a/crates/router/src/connector/authorizedotnet.rs b/crates/router/src/connector/authorizedotnet.rs index ba232c01bbf..0aba48fa5e5 100644 --- a/crates/router/src/connector/authorizedotnet.rs +++ b/crates/router/src/connector/authorizedotnet.rs @@ -9,7 +9,10 @@ use transformers as authorizedotnet; use crate:...
2024-02-27T10:08:46Z
## Description <!-- Describe your changes in detail --> - The status mapping for connector `Authorizdotnet` is fixed. - The `ref_id` field being passed in connector contains `connector_request_reference_id`. The max number of characters allowed in ref_id is 20 and hence a check has been added to only pass ref_id ...
0626ca968576709a3559243f5a64e742201dbf91
Following flows should be tested for connector Authorizdotnet: 1. Authorization(Auto Capture): ``` { "payment_id": "abcd1", "amount": 800, "currency": "USD", "confirm": true, "capture_method": "automatic", "customer_id": "StripeCustomer", "payment_method": "card", "payment...
[ "crates/router/src/connector/authorizedotnet.rs", "crates/router/src/connector/authorizedotnet/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3843
Bug: [FEATURE] : [Gocardless] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time checking...
diff --git a/crates/router/src/connector/gocardless/transformers.rs b/crates/router/src/connector/gocardless/transformers.rs index d3703bc6bf8..21fc44fe84f 100644 --- a/crates/router/src/connector/gocardless/transformers.rs +++ b/crates/router/src/connector/gocardless/transformers.rs @@ -547,7 +547,7 @@ pub struct Goca...
2024-02-27T10:00:29Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Gocardless. ## Test Case 1. Create a payment intent with Gocardless ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ -...
cd1a17bcd260629aad7548ff274f5512c37bfab7
[ "crates/router/src/connector/gocardless/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-217
Bug: [FEATURE] Schedule webhook for retry ## Description Refactor webhooks core to add retry logic in webhooks core. Currently, we store information about whether we have sent a webhook or not, improving on this we can implement retry logic to make this more reliable
diff --git a/.typos.toml b/.typos.toml index 40acb130589..2d2e165544a 100644 --- a/.typos.toml +++ b/.typos.toml @@ -2,6 +2,7 @@ check-filename = true [default.extend-identifiers] +"ABD" = "ABD" # Aberdeenshire, UK ISO 3166-2 code BA = "BA" # Bosnia and Herzegovina country code CAF = "CAF" # Central African Re...
2024-02-27T08:30:01Z
## Description <!-- Describe your changes in detail --> This PR adds support for automatically retrying outgoing webhook deliveries in case of failed deliveries, with the aid of the scheduler (process tracker). ### Behavior (Initial Delivery) The behavior when an outgoing webhook is being sent is: 1. During...
9917dd065444d66628039b19df7cd8e7d5c107db
As of now, outgoing webhooks are supported for payments, refunds, disputes and mandates. I've extensively tested payments outgoing webhooks for the different cases, and done a sanity testing on disputes and refunds webhooks to verify that they are retried in case the initial delivery attempt fails. Incoming mandate...
[ ".typos.toml", "crates/api_models/src/webhooks.rs", "crates/diesel_models/src/process_tracker.rs", "crates/diesel_models/src/query/events.rs", "crates/router/src/bin/scheduler.rs", "crates/router/src/compatibility/wrap.rs", "crates/router/src/core/errors.rs", "crates/router/src/core/payment_link.rs", ...
juspay/hyperswitch
juspay__hyperswitch-3841
Bug: [FEATURE] : [Globalpay] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time checking i...
diff --git a/crates/router/src/connector/globalpay/requests.rs b/crates/router/src/connector/globalpay/requests.rs index ee62e8c2c2c..1e5413bc838 100644 --- a/crates/router/src/connector/globalpay/requests.rs +++ b/crates/router/src/connector/globalpay/requests.rs @@ -41,7 +41,7 @@ pub struct GlobalpayPaymentsRequest {...
2024-02-27T07:49:58Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Globalpay. ## Test Case 1.a. Card Mandate Payment Create ``` { "amount": 10000, "currency": "USD", "confirm": true, "capture_method": "automatic", "captu...
2b0fbc70749338d5c501bbb782d6fc4747890d61
[ "crates/router/src/connector/globalpay/requests.rs", "crates/router/src/connector/globalpay/response.rs", "crates/router/src/connector/globalpay/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3836
Bug: feat: change list roles, get role, info api to respond with groups
diff --git a/crates/api_models/src/events/user_role.rs b/crates/api_models/src/events/user_role.rs index f19ff95f9ed..f46c5cf312b 100644 --- a/crates/api_models/src/events/user_role.rs +++ b/crates/api_models/src/events/user_role.rs @@ -2,15 +2,15 @@ use common_utils::events::{ApiEventMetric, ApiEventsType}; use cra...
2024-02-27T07:21:21Z
## Description <!-- Describe your changes in detail --> Change `list_roles`, `get_role` and `get_authorization_info` api to respond with groups if asked. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you ...
1c6913be747bd3da53fa2b48e339810bb30226e7
All the following APIs have a query param called groups, setting it to true will return the following response. 1. Get role list ``` curl --location 'http://localhost:8080/user/role/list?groups=true' \ --header 'Authorization: Bearer JWT' ``` Response ``` [ { "role_id": "merchant_iam_...
[ "crates/api_models/src/events/user_role.rs", "crates/api_models/src/user_role.rs", "crates/api_models/src/user_role/role.rs", "crates/common_enums/src/enums.rs", "crates/router/src/core/user.rs", "crates/router/src/core/user_role.rs", "crates/router/src/core/user_role/role.rs", "crates/router/src/rout...
juspay/hyperswitch
juspay__hyperswitch-3833
Bug: [Bug] metadata validation for update payment connector Metadata validation in update payment connector happens even if we don't pass metadata in the request. Instead, if metadata is not present we should consider MCA metadata in update_payment_connector function .
diff --git a/crates/router/src/core/admin.rs b/crates/router/src/core/admin.rs index 2b87d64c6ac..14c88448125 100644 --- a/crates/router/src/core/admin.rs +++ b/crates/router/src/core/admin.rs @@ -1185,6 +1185,7 @@ pub async fn update_payment_connector( field_name: "connector_account_details".to_string(), ...
2024-02-27T05:55:52Z
## Description <!-- Describe your changes in detail --> Metadata validation in update payment connector happens even if we don't pass metadata in the request. This pr fixes metadata validation in update payment connector function. If metadata is not present we consider mca metadata. ## Motivation and Context <!...
2b0fbc70749338d5c501bbb782d6fc4747890d61
**Test case 1 :** step 1 : Create merchant connector account for Fiserv. ``` curl --location --request POST 'https://sandbox.hyperswitch.io/account/<merchant_Id>/connectors' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data-raw '{ "...
[ "crates/router/src/core/admin.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3792
Bug: [BUG] Nuvei payment declined errors are not captured ### Bug Description Nuvei Payments error are captured and handled only for transaction status : "Error" Testing [card declined](https://docs.nuvei.com/documentation/integration/testing/testing-cards/#cards-that-return-declined) is not responding with ex...
diff --git a/crates/router/src/connector/nuvei/transformers.rs b/crates/router/src/connector/nuvei/transformers.rs index 13d522b86cc..bf622d7a077 100644 --- a/crates/router/src/connector/nuvei/transformers.rs +++ b/crates/router/src/connector/nuvei/transformers.rs @@ -1360,7 +1360,7 @@ fn build_error_response<T>( ...
2024-02-27T04:51:25Z
## Description Nuvei error handling for payment declined status ## Motivation and Context https://github.com/juspay/hyperswitch/issues/3792 If you don't have an issue, we'd recommend starting with one first so the PR can focus on the implementation (unless it is an obvious bug or documentation fix that w...
901d61bc0ddb4b2ad742de927126f468629a79af
Tested via postman test and included scripts
[ "crates/router/src/connector/nuvei/transformers.rs", "postman/collection-dir/nuvei/.auth.json", "postman/collection-dir/nuvei/.event.meta.json", "postman/collection-dir/nuvei/.info.json", "postman/collection-dir/nuvei/.meta.json", "postman/collection-dir/nuvei/.variable.json", "postman/collection-dir/nu...
juspay/hyperswitch
juspay__hyperswitch-4030
Bug: [GlobalSearch] - API support for free form text search These would involve getting a string from the user & searching for that string in ES, using the msearch can be considered optional here. (don't build support for specific key/value or time range filters yet) + deployment build msearch API + separate index ...
diff --git a/Cargo.lock b/Cargo.lock index 7c7b2b9a761..e3c39b71842 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -55,7 +55,7 @@ dependencies = [ "flate2", "futures-core", "h2", - "http", + "http 0.2.9", "httparse", "httpdate", "itoa", @@ -128,7 +128,7 @@ source = "registry+https://github.com/rust-lang/crates...
2024-02-26T20:52:19Z
## Description Search APIs for dashboard global search ## Motivation and Context Search APIs for dashboard global search #
45ed56f16516c44acbe75b75c0621b78ccdb9894
[ "Cargo.lock", "config/config.example.toml", "config/deployments/env_specific.toml", "config/development.toml", "config/docker_compose.toml", "crates/analytics/Cargo.toml", "crates/analytics/src/lambda_utils.rs", "crates/analytics/src/lib.rs", "crates/analytics/src/search.rs", "crates/api_models/sr...
juspay/hyperswitch
juspay__hyperswitch-3799
Bug: [BUG]: connector request is being built twice ### Bug Description When a payment is confirmed, the `connector_request` log is being printed twice ### Expected Behavior It should be printed only once ### Actual Behavior Two instances of the log line can be found ### Steps To Reproduce - Create a payment ...
diff --git a/crates/router/src/services/api.rs b/crates/router/src/services/api.rs index 1c4d1810c88..45decfd451d 100644 --- a/crates/router/src/services/api.rs +++ b/crates/router/src/services/api.rs @@ -338,30 +338,31 @@ where ], ); - let connector_request = connector_reques...
2024-02-26T13:04:52Z
## Description <!-- Describe your changes in detail --> This PR fixes the duplicate request that was being constructed even if the connector_request already exists. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here...
75c633fc7c37341177597041ccbcdfc3cf9e236f
- Manual, compiler guided. - Create a payment and check if `connector_request` is logged only once.
[ "crates/router/src/services/api.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3825
Bug: [FEATURE] : [Forte] mask pii information in connector request and response ### Feature Description Mask pii information passed and received in the connector request and response ### Possible Implementation Refactor all sensitive response and request fields secret ### Have you spent some time checking if th...
diff --git a/crates/router/src/connector/forte/transformers.rs b/crates/router/src/connector/forte/transformers.rs index 83bcb2c551b..00efbefe287 100644 --- a/crates/router/src/connector/forte/transformers.rs +++ b/crates/router/src/connector/forte/transformers.rs @@ -240,7 +240,7 @@ pub enum ForteAction { #[derive(De...
2024-02-26T11:15:49Z
## Description <!-- Describe your changes in detail --> Mask pii information passed and received in the connector request and response for Forte. ## Test Case <!-- Did you write an integration/unit/API test to verify the code changes? Or did you test this change manually (provide relevant screenshots)? --> ...
75c633fc7c37341177597041ccbcdfc3cf9e236f
[ "crates/router/src/connector/forte/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-3823
Bug: [FIX] add unit tests to check backwards compatibility of KV types
diff --git a/crates/diesel_models/src/payment_attempt.rs b/crates/diesel_models/src/payment_attempt.rs index 927a05bfa56..cc4f3e5a89a 100644 --- a/crates/diesel_models/src/payment_attempt.rs +++ b/crates/diesel_models/src/payment_attempt.rs @@ -776,3 +776,100 @@ impl From<PaymentAttemptUpdate> for PaymentAttemptUpdateI...
2024-02-26T10:51:09Z
## Description <!-- Describe your changes in detail --> Add Unit tests for testing backwards compatibility ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting wit...
75c633fc7c37341177597041ccbcdfc3cf9e236f
[ "crates/diesel_models/src/payment_attempt.rs", "crates/diesel_models/src/payment_intent.rs", "crates/diesel_models/src/refund.rs" ]