repo stringclasses 1
value | instance_id stringlengths 22 24 | problem_statement stringlengths 30 24.1k | patch stringlengths 0 1.9M | test_patch stringclasses 1
value | created_at stringdate 2022-11-25 05:12:07 2025-06-13 10:24:29 | hints_text stringlengths 0 228k | base_commit stringlengths 40 40 | test_instructions stringlengths 0 232k | filenames listlengths 0 300 |
|---|---|---|---|---|---|---|---|---|---|
juspay/hyperswitch | juspay__hyperswitch-5396 | Bug: refactor: alter query for merchant scoped metadata
Remove `is_null` from `find_merchant_scoped_dashboard_metadata`
This is done to make DB changes and support backward compatibility in next deployment. | diff --git a/crates/diesel_models/src/query/dashboard_metadata.rs b/crates/diesel_models/src/query/dashboard_metadata.rs
index 6f88629d82a..725a95ffef3 100644
--- a/crates/diesel_models/src/query/dashboard_metadata.rs
+++ b/crates/diesel_models/src/query/dashboard_metadata.rs
@@ -87,9 +87,8 @@ impl DashboardMetadata {
... | 2024-07-22T10:06:58Z |
## Description
Alter query in `find_merchant_scoped_dashboard_metadata`
For merchant scoped metadata it need not to be considered whether user_id column is `null` or not
## Motivation and Context
Closes #5396
# | bc19fca1f4e76be6131e9c870b8aa1c709fef578 | To get the metadata use curl:
```
curl --location 'http://localhost:8080/user/data?keys=ProductionAgreement%2CSetupProcessor%2CConfigureEndpoint%2CSetupComplete%2CFirstProcessorConnected%2CSecondProcessorConnected%2CConfiguredRouting%2CTestPayment%2CIntegrationMethod%2CConfigurationType%2CIntegrationCompleted%2CStrip... | [
"crates/diesel_models/src/query/dashboard_metadata.rs",
"crates/router/src/db/dashboard_metadata.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5395 | Bug: refactor: change primary key of payment_methods table for v2
## Description
Previously our payment_methods table had `id` as PKey.
Which needs to be changed to a new Primary key namely `payment_method_id`. | diff --git a/crates/diesel_models/src/schema.rs b/crates/diesel_models/src/schema.rs
index b8c5344cbbb..55f8e935b14 100644
--- a/crates/diesel_models/src/schema.rs
+++ b/crates/diesel_models/src/schema.rs
@@ -934,7 +934,7 @@ diesel::table! {
use diesel::sql_types::*;
use crate::enums::diesel_exports::*;
- ... | 2024-07-22T08:39:07Z |
## Description
<!-- Describe your changes in detail -->
Changing the primary key of the payment_methods table from (id) to the payment_method_id.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't ha... | bc19fca1f4e76be6131e9c870b8aa1c709fef578 |
Just Db id migration, doesn't requires any specific testing
| [
"crates/diesel_models/src/schema.rs",
"crates/diesel_models/src/schema_v2.rs",
"migrations/2024-07-22-082828_change_primary_key_for_payment_methods/down.sql",
"migrations/2024-07-22-082828_change_primary_key_for_payment_methods/up.sql"
] | |
juspay/hyperswitch | juspay__hyperswitch-5364 | Bug: [FEATURE] Sorting POC
Allow sorting on amount and date in tables under Operations
If user clicks on the arrow to sort information being on a page which is not the first one, we will sort the data via backend and redirect them to first page
Performance POC to be done for the same | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index 8433ac43d0c..eb04fe8300e 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -4063,6 +4063,9 @@ pub struct PaymentListFilterConstraints {
pub authentication_type: Option<Vec<enums::Authent... | 2024-07-21T23:14:22Z |
## Description
Support sort criterial for payments list:
- sort on basis of amount (ascending or descending)
- sort on basis of created at time (ascending or descending)
## Motivation and Context
Closes [#5364](https://github.com/juspay/hyperswitch/issues/5364)
# | 074e90c9f9fbc26255ed27400a6a781aa6958339 | Use the curl to sort the list by following order. Order takes `on` (the field which need to be considered) and `by`( ascending or descending)
```
curl --location 'http://localhost:8080/payments/list' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer JWT' \
--data '{
"order": {
... | [
"crates/api_models/src/payments.rs",
"crates/hyperswitch_domain_models/src/payments/payment_intent.rs",
"crates/storage_impl/src/payments/payment_intent.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5070 | Bug: [FEATURE] Populate status code and delivery attempt information in outgoing webhooks ClickHouse events
### Description
As of opening this issue, the outgoing webhooks ClickHouse events contain a few fields:
https://github.com/juspay/hyperswitch/blob/ca61e47585071865cf7df5c05fdbe3f57818ca95/crates/router/s... | diff --git a/crates/analytics/docs/clickhouse/scripts/outgoing_webhook_events.sql b/crates/analytics/docs/clickhouse/scripts/outgoing_webhook_events.sql
index 30f3f293bfa..a104bc506fd 100644
--- a/crates/analytics/docs/clickhouse/scripts/outgoing_webhook_events.sql
+++ b/crates/analytics/docs/clickhouse/scripts/outgoin... | 2024-07-21T10:21:48Z |
## Description
Closes #5070.
This PR enhances the outgoing_webhook_events and outgoing_webhook_events_audit tables by adding three new columns: initial_attempt_id, status_code, and delivery_attempt. These additions are essential for tracking the initial_attempt_id, status_code, and delivery_attempt status for ou... | 1715cf0ed4c67e87fe3ddf9090174fc70d6c9e8c | Tested locally.
<img width="2052" alt="outgoing_webhook_events" src="https://github.com/user-attachments/assets/6f04c804-bfc3-40b8-9d6c-49aca0abadc5">
<img width="2055" alt="outgoing_webhook_events_audit" src="https://github.com/user-attachments/assets/9c453d2f-3cbe-4a9a-88f3-446715115dd9">
| [
"crates/analytics/docs/clickhouse/scripts/outgoing_webhook_events.sql",
"crates/router/src/core/webhooks/outgoing.rs",
"crates/router/src/events/outgoing_webhook_logs.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5381 | Bug: [BUG] Merchant Connector Account uses application decryption which should changed to API
### Bug Description
Due to recent v2 related changes Merchant Connector Account uses application decryption instead it should be changed API call to encryption service
### Expected Behavior
all encryption and decryption ... | diff --git a/crates/hyperswitch_domain_models/src/merchant_account.rs b/crates/hyperswitch_domain_models/src/merchant_account.rs
index a430673c59a..47ced6573f8 100644
--- a/crates/hyperswitch_domain_models/src/merchant_account.rs
+++ b/crates/hyperswitch_domain_models/src/merchant_account.rs
@@ -14,7 +14,7 @@ use error... | 2024-07-19T13:16:25Z |
## Description
encrypt/decrypt should happen only via encryption service and DEK should be same in application and encryption service
## Motivation and Context
encrypt/decrypt should happen only via encryption service and DEK should be same in application and encryption service
# | 476aed5036eb41671c0736887d02dcac7f3573c6 | Changes can be verified only through logs. Look for "Fall back to Application Encryption" or "Fall back to Application Decryption" in the logs post deployment after running below tests. If logs are present encryption/decryption failed with encryption service and fall back to the application encryption which has to be i... | [
"crates/hyperswitch_domain_models/src/merchant_account.rs",
"crates/hyperswitch_domain_models/src/merchant_key_store.rs",
"crates/hyperswitch_domain_models/src/payments/payment_attempt.rs",
"crates/hyperswitch_domain_models/src/type_encryption.rs",
"crates/router/src/core/admin.rs",
"crates/router/src/cor... | |
juspay/hyperswitch | juspay__hyperswitch-5378 | Bug: Email footer icons spacing
Footer icons must be separated for better usability.
| diff --git a/crates/router/src/services/email/assets/api_key_expiry_reminder.html b/crates/router/src/services/email/assets/api_key_expiry_reminder.html
index 9d97d153eb6..3ec51164a50 100644
--- a/crates/router/src/services/email/assets/api_key_expiry_reminder.html
+++ b/crates/router/src/services/email/assets/api_key_... | 2024-07-19T10:58:44Z |
## Description
- Provided spacing between email template footer icons
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on... | bc92e0cccbbc989f3b32ad16cae58a3e47babe8b | Tested locally using AWS SES service
| [
"crates/router/src/services/email/assets/api_key_expiry_reminder.html",
"crates/router/src/services/email/assets/bizemailprod.html",
"crates/router/src/services/email/assets/invite.html",
"crates/router/src/services/email/assets/magic_link.html",
"crates/router/src/services/email/assets/recon_activation.htm... | |
juspay/hyperswitch | juspay__hyperswitch-5377 | Bug: refactor: change primary keys in user, user_roles & roles tables
## Description
Previously our tables namely:
users
user_roles
roles
has primary key as ID.
we are refactoring them as follows:
users => user_id
user_roles => (user_id, merchant_id)
roles => role_id | diff --git a/crates/diesel_models/src/schema.rs b/crates/diesel_models/src/schema.rs
index 4b5f4a8ad49..b8c5344cbbb 100644
--- a/crates/diesel_models/src/schema.rs
+++ b/crates/diesel_models/src/schema.rs
@@ -1168,7 +1168,7 @@ diesel::table! {
use diesel::sql_types::*;
use crate::enums::diesel_exports::*;
-... | 2024-07-19T10:27:39Z |
## Description
<!-- Describe your changes in detail -->
Changing the primary key of the following table from (id) to the specified new keys:
users => user_id
user_roles => (user_id, merchant_id)
roles => role_id
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it f... | 476aed5036eb41671c0736887d02dcac7f3573c6 |
Checked by compiling the code
| [
"crates/diesel_models/src/schema.rs",
"crates/diesel_models/src/schema_v2.rs",
"migrations/2024-07-19-095541_change_primary_key_for_users/down.sql",
"migrations/2024-07-19-095541_change_primary_key_for_users/up.sql",
"migrations/2024-07-19-100016_change_primary_key_for_user_roles/down.sql",
"migrations/20... | |
juspay/hyperswitch | juspay__hyperswitch-5371 | Bug: Make `original_payment_authorized_currency` and `original_payment_authorized_amount` mandatory fields for `Discover` cards and `Cybersource` connector during payment method migration.
Make original_payment_authorized_currency and original_payment_authorized_amount mandatory fields for Discover cards and Cyberso... | diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs
index 7799cc24df2..1ca01114dd5 100644
--- a/crates/api_models/src/payment_methods.rs
+++ b/crates/api_models/src/payment_methods.rs
@@ -1428,12 +1428,8 @@ impl From<PaymentMethodRecord> for PaymentMethodMigrate {
... | 2024-07-19T08:01:57Z |
## Description
<!-- Describe your changes in detail -->
Make `original_payment_authorized_currency` and `original_payment_authorized_amount` mandatory fields for Discover cards and `Cybersource` connector during payment method migration.
## Motivation and Context
<!--
Why is this change required? What problem... | 1c825f465a42c71568db994c5d05ba72d8680564 |
-> Create a merchant connector account for cybersource
-> Create a customer
```
curl --location 'http://localhost:8080/customers' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_1oC3ReWVy4AaGA8ORA6EMm8JHS5WTlsmBtfRnNp2LLemMxZEJXfZ9hLYsd9wmWtg' \
--data... | [
"crates/api_models/src/payment_methods.rs",
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payments/helpers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5368 | Bug: refactor: change primary key of refund table for v2
## Description
Previously our refund table had `id` as PKey.
Which needs to be changed to a composite Primary key as `(merchant_id, refund_id)`. | diff --git a/crates/diesel_models/src/schema.rs b/crates/diesel_models/src/schema.rs
index 171e1cfe2e3..4b5f4a8ad49 100644
--- a/crates/diesel_models/src/schema.rs
+++ b/crates/diesel_models/src/schema.rs
@@ -1099,7 +1099,7 @@ diesel::table! {
use diesel::sql_types::*;
use crate::enums::diesel_exports::*;
-... | 2024-07-19T04:51:07Z |
## Description
<!-- Describe your changes in detail -->
Previously our Refund table had id as PKey.
Which needs to be changed to a composite Primary key as (merchant_id, refund_id).
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link ... | fe14336f78b15e948b10d09b197fb1d529939b5c |
Tested it by compiling the code and checking the file `query/refund.rs`, where id is nowhere being used.
| [
"crates/diesel_models/src/schema.rs",
"crates/diesel_models/src/schema_v2.rs",
"migrations/2024-07-19-044034_change_primary_key_for_refund/down.sql",
"migrations/2024-07-19-044034_change_primary_key_for_refund/up.sql"
] | |
juspay/hyperswitch | juspay__hyperswitch-5360 | Bug: [fix] add offset and limit parameters to key transfer API
| diff --git a/crates/analytics/src/types.rs b/crates/analytics/src/types.rs
index d2d3604661f..6593e5d6eb0 100644
--- a/crates/analytics/src/types.rs
+++ b/crates/analytics/src/types.rs
@@ -3,7 +3,7 @@ use std::{fmt::Display, str::FromStr};
use common_utils::{
errors::{CustomResult, ErrorSwitch, ParsingError},
... | 2024-07-18T08:01:10Z |
## Description
<!-- Describe your changes in detail -->
Add offset and limit to key transfer API
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one firs... | 06f1406cbc350a71f961a19dc2a6cfef2ceeb3a1 |
1. Run `/accounts/transfer` with `from` and `limit` parameters. It should respond with the `total_transferred` same as `limit`.
```bash
curl --location 'http://localhost:8080/accounts/transfer' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data '{
"from": 0,
"limit"... | [
"crates/analytics/src/types.rs",
"crates/api_models/src/admin.rs",
"crates/api_models/src/events.rs",
"crates/api_models/src/events/connector_onboarding.rs",
"crates/api_models/src/events/user.rs",
"crates/api_models/src/events/user_role.rs",
"crates/api_models/src/pm_auth.rs",
"crates/api_models/src/... | |
juspay/hyperswitch | juspay__hyperswitch-5372 | Bug: [FEATURE] provision for secure payment links
### Feature Description
Provide open and secure payment links for different use cases
- Open links
- Accessible by anyone
- Can be opened in new tabs
- Can be iframed by any host
- SPMs are never listed
- Secure links
- Can be opened only in if... | diff --git a/Cargo.lock b/Cargo.lock
index 66b38d09c1f..cf5864e96e7 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2014,6 +2014,7 @@ dependencies = [
"error-stack",
"fake",
"futures 0.3.30",
+ "globset",
"hex",
"http 0.2.12",
"masking",
@@ -6063,7 +6064,6 @@ dependencies = [
"events",
"external_services",... | 2024-07-18T06:54:49Z |
## Description
Described in https://github.com/juspay/hyperswitch/issues/5372
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can ... | 0f89a0acbfc2d55f415e0daeb27e8d9022e6a862 | Tested locally using postman collection. Expectations -
- existing payment links is available as open links (cannot list SPMs or render checkbox to store PM)
- secure links are generated only when allowed_domains are configured
- secure links can only be accessed from within an iframe on the allowed domains
#### ... | [
"Cargo.lock",
"crates/api_models/src/admin.rs",
"crates/api_models/src/payments.rs",
"crates/common_utils/Cargo.toml",
"crates/common_utils/src/consts.rs",
"crates/common_utils/src/validation.rs",
"crates/diesel_models/src/payment_link.rs",
"crates/diesel_models/src/schema.rs",
"crates/diesel_models... | |
juspay/hyperswitch | juspay__hyperswitch-5359 | Bug: refactor: reframe blocklist primary key for v2
## Description
Previously our Blocklist table had `id` as PKey.
Which needs to be changed to a composite Primary key as `(merchant_id, fingerprint_id)`. | diff --git a/crates/diesel_models/src/schema.rs b/crates/diesel_models/src/schema.rs
index a5185dc6076..1242368404a 100644
--- a/crates/diesel_models/src/schema.rs
+++ b/crates/diesel_models/src/schema.rs
@@ -128,7 +128,7 @@ diesel::table! {
use diesel::sql_types::*;
use crate::enums::diesel_exports::*;
- ... | 2024-07-17T18:41:00Z |
## Description
<!-- Describe your changes in detail -->
Previously our Blocklist table had `id` as PKey.
Which needs to be changed to a composite Primary key as `(merchant_id, fingerprint_id)`.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue,... | 67bfb1cfecd4a4ad8503eaf57837073bb1980bdd |
Tested it by running the blocklist Apis, which is performing fine as the id field was no where being used.
| [
"crates/diesel_models/src/schema.rs",
"crates/diesel_models/src/schema_v2.rs",
"migrations/2024-07-17-174449_change_primary_key_for_blocklist_table/down.sql",
"migrations/2024-07-17-174449_change_primary_key_for_blocklist_table/up.sql"
] | |
juspay/hyperswitch | juspay__hyperswitch-5352 | Bug: refactor: migrate user roles table to support v2
- Make org_id and merchant_id nullable.
- Add new nullable columns profile_id, entity_id , entity_type, version | diff --git a/crates/diesel_models/src/enums.rs b/crates/diesel_models/src/enums.rs
index 96678a7a3e1..f0059994cb6 100644
--- a/crates/diesel_models/src/enums.rs
+++ b/crates/diesel_models/src/enums.rs
@@ -19,7 +19,8 @@ pub mod diesel_exports {
DbRequestIncrementalAuthorization as RequestIncrementalAuthorizatio... | 2024-07-17T14:02:50Z |
## Description
### DB changes in user_roles
- New Columns
- `version`
- `entity_id`
- `entity_type`
- `profile_id`
- Changes
- `merchant_id` is now nullable
- `org_id` is now nullable
## Motivation and Context
Closes [#5352](https://github.com/juspay/hyperswitch/issues/5352)
# | 0f89a0acbfc2d55f415e0daeb27e8d9022e6a862 | All these APIs should work without giving 500.
- User - Signup w/ merchant id
- User - Signin
- User - Signin Token Only
- User - Connect Account
- User - Reset Password
- User - Invite Multiple
- User - Resend Invite
- User - Accept Invite from Mail
- User - Accept Invite from Mail Token only
- User - Switch... | [
"crates/diesel_models/src/enums.rs",
"crates/diesel_models/src/query/user_role.rs",
"crates/diesel_models/src/schema.rs",
"crates/diesel_models/src/schema_v2.rs",
"crates/diesel_models/src/user_role.rs",
"crates/router/src/core/user.rs",
"crates/router/src/core/user_role.rs",
"crates/router/src/db/kaf... | |
juspay/hyperswitch | juspay__hyperswitch-5355 | Bug: Remove the locker call in the psync flow
There is a locker call that is happening the psync flow. This pr is to remove that call as it is not required. | diff --git a/crates/router/src/core/payments/operations.rs b/crates/router/src/core/payments/operations.rs
index f5bc4014655..be54ead0ac1 100644
--- a/crates/router/src/core/payments/operations.rs
+++ b/crates/router/src/core/payments/operations.rs
@@ -299,27 +299,18 @@ where
#[instrument(skip_all)]
async fn ... | 2024-07-17T09:52:11Z |
## Description
<!-- Describe your changes in detail -->
There is a locker call that is happening the psync flow. This pr is to remove that call as it is not required.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue her... | ecc862c3543be37e2cc7959f450ca51770978ae5 |
-> Create a merchant connector account
-> Make payment with setup future usage as on_session
```
{
"amount": 100,
"amount_to_capture": 100,
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"customer_id": "cu_{{$timestamp}}",... | [
"crates/router/src/core/payments/operations.rs",
"crates/router/src/core/payments/operations/payment_status.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5354 | Bug: Add support for passing the domain dynamically in the session call
Now the merchant domain is being collected while enabling apple pay for a particular merchant connector account.
Instead this pr is to add support to accept the merchant domain dynamically in the session call.
As this is a test feature we ha... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index c04af204493..619f345a333 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -745,6 +745,7 @@ pub struct HeaderPayload {
pub x_hs_latency: Option<bool>,
pub browser_name: Option<api_e... | 2024-07-17T09:41:06Z |
## Description
<!-- Describe your changes in detail -->
Now the merchant domain is being collected while enabling apple pay for a particular merchant connector account.
Instead this pr is to add support to accept the merchant domain dynamically in the session call.
As this is a test feature we have a fallback in... | 2d204c9f7348c4ed121ab472ef1b5bb8d9d32d24 |
-> Create merchant connector account with apple pay enabled
-> Create a payment with confirm false
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_b7ym5n82JbU8NDduwRHW8QlBYHMR6rXEOCa7m6vEmPImmKbAvZWbf... | [
"crates/api_models/src/payments.rs",
"crates/router/src/core/payments/flows/session_flow.rs",
"crates/router/src/lib.rs",
"crates/router/src/types/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5340 | Bug: feat(globalsearch): Add search_tags based filter for global search in dashboard
Add a filter based on `search_tags` for global search in dashboard
The search_tags must be hashed before pushing them to kafka payment-intent events and opensearch. | diff --git a/crates/analytics/src/search.rs b/crates/analytics/src/search.rs
index 269864bf44a..a5bd117bd63 100644
--- a/crates/analytics/src/search.rs
+++ b/crates/analytics/src/search.rs
@@ -66,6 +66,24 @@ pub async fn msearch_results(
.switch()?;
}
};
+ if let Some(s... | 2024-07-16T12:10:49Z |
## Description
<!-- Describe your changes in detail -->
- Added a filter based on `search_tags` in `feature_metadata` for global search in dashboard
- The `search_tags` are hashed before pushing them to kafka payment-intent events and opensearch.
## Motivation and Context
<!--
Why is this change required? Wh... | 949e84e88fcb58db388bef536e89ab0510f5ede9 |
Tested through curls in postman:
- Payment:
```bash
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_IG9ateOUhGE0KLFEItNN1tsJXcr5M62N7zlbtOlUtStTfPpzSomswbQa4aO2k1B4' \
--data-raw '{
"amount": 6540,
... | [
"crates/analytics/src/search.rs",
"crates/api_models/src/analytics/search.rs",
"crates/api_models/src/payments.rs",
"crates/masking/src/strategy.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5339 | Bug: do not update `perform_session_flow_routing` output if the `SessionRoutingChoice` is none
While performing the session token routing we create an empty vec that will contain the Routing choices for that particular session. In case if there is no connectors that requires session call then the `perform_session_fl... | diff --git a/crates/router/src/core/payments/routing.rs b/crates/router/src/core/payments/routing.rs
index d1a5441d958..d6904e09a3d 100644
--- a/crates/router/src/core/payments/routing.rs
+++ b/crates/router/src/core/payments/routing.rs
@@ -1009,7 +1009,9 @@ pub async fn perform_session_flow_routing(
... | 2024-07-16T10:56:21Z |
## Description
<!-- Describe your changes in detail -->
While performing the session token routing we create an empty vec that will contain the Routing choices for that particular session. In case if there is no connectors that requires session call then the `perform_session_flow_routing` will return the empty vec. ... | 419344eb32cdd206033a64d0e4b53e6382c73a4e |
-> Create mca for stripe with apple pay, google pay and klarna
```
{
"connector_type": "fiz_operations",
"connector_name": "stripe",
"connector_account_details": {
"auth_type": "HeaderKey",
"api_key": ""
},
"test_mode": true,
"disabled": false,
"payment_methods_e... | [
"crates/router/src/core/payments/routing.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5337 | Bug: do not update `perform_session_flow_routing` output if the `SessionRoutingChoice` is none
While performing the session token routing we create an empty vec that will contain the Routing choices for that particular session. In case if there is no connectors that requires session call then the `perform_session_fl... | diff --git a/crates/router/src/core/payments/routing.rs b/crates/router/src/core/payments/routing.rs
index d1a5441d958..d6904e09a3d 100644
--- a/crates/router/src/core/payments/routing.rs
+++ b/crates/router/src/core/payments/routing.rs
@@ -1009,7 +1009,9 @@ pub async fn perform_session_flow_routing(
... | 2024-07-16T09:34:01Z |
## Description
<!-- Describe your changes in detail -->
While performing the session token routing we create an empty vec that will contain the Routing choices for that particular session. In case if there is no connectors that requires session call then the `perform_session_flow_routing` will return the empty vec. ... | 3951ac6578359c62a9b12582f5a5bbeef4c1b769 |
-> Create mca for stripe with apple pay, google pay and klarna
```
{
"connector_type": "fiz_operations",
"connector_name": "stripe",
"connector_account_details": {
"auth_type": "HeaderKey",
"api_key": ""
},
"test_mode": true,
"disabled": false,
"payment_methods_e... | [
"crates/router/src/core/payments/routing.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5285 | Bug: feat(connector): [WELLS FARGO] add Connector Template Code
Add Wellsfargo Connector Template Code | diff --git a/config/config.example.toml b/config/config.example.toml
index aa98c0533e3..941a315aaee 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -251,6 +251,7 @@ trustpay.base_url = "https://test-tpgw.trustpay.eu/"
trustpay.base_url_bank_redirects = "https://aapi.trustpay.eu/"
tsys.base... | 2024-07-16T08:00:52Z |
## Description
<!-- Describe your changes in detail -->
Added Template code for WellsFargo. Ran add_connector.sh script
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommen... | e4b3982c13cedf0f7feaec22df414761e22d98df | [
"config/config.example.toml",
"config/deployments/integration_test.toml",
"config/deployments/production.toml",
"config/deployments/sandbox.toml",
"config/development.toml",
"config/docker_compose.toml",
"crates/api_models/src/enums.rs",
"crates/common_enums/src/enums.rs",
"crates/hyperswitch_interf... | ||
juspay/hyperswitch | juspay__hyperswitch-5332 | Bug: set `requires_cvv` to false when either `connector_mandate_details` or `network_transaction_id` is present during MITs
`requires_cvv` should be false the `recurring_enabled` should be true in the list customer payment method if the `is_connector_agnostic_mit_enabled` is enabled and `network_transaction_id` is p... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index db95b5c838c..24cc9583d90 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -3744,6 +3744,11 @@ pub async fn list_customer_payment_metho... | 2024-07-16T06:07:45Z |
## Description
<!-- Describe your changes in detail -->
`requires_cvv` should be false the `recurring_enabled` should be true in the list customer payment method if the `is_connector_agnostic_mit_enabled` is enabled and `network_transaction_id` is present for that payment method.
## Motivation and Context
<!--
... | 23bfceb6c8d3bc62d1e97f1b5feaba2dbbf9bcde |
-> Create a merchant connector account for cybersource
-> Create a payment with `setup_future_usage: "off_session"`
```
{
"amount": 100,
"payment_type": "setup_mandate",
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"cust... | [
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payments.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5263 | Bug: [Bug] - modified_at not updated for every state change
- [ ] Refunds - https://github.com/juspay/hyperswitch/issues/5266 | diff --git a/crates/diesel_models/src/address.rs b/crates/diesel_models/src/address.rs
index aa1d397797d..d695d2a0e70 100644
--- a/crates/diesel_models/src/address.rs
+++ b/crates/diesel_models/src/address.rs
@@ -1,5 +1,5 @@
use common_utils::id_type;
-use diesel::{AsChangeset, Identifiable, Insertable, Queryable};
+u... | 2024-07-12T12:14:37Z |
## Description
<!-- Describe your changes in detail -->
`modified_at` field is now updated at every state change for:
- Payment Attempts
- Payment Intents
- Refunds
- Disputes
- Payouts
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, plea... | e0b6cbb229f64be7a846b3c1573a6c6f8151b47b |
Just do a Payment Create and Payment Update (or any other kind of update as well to the payment), `modified_at` may get updated at every update
curls:
Payment create:
```bash
curl --location 'http://localhost:8080/payments/pay_mn0Jew5RpmZRG2K1QysX' \
--header 'Content-Type: application/json' \
--header 'Accept:... | [
"crates/diesel_models/src/address.rs",
"crates/diesel_models/src/api_keys.rs",
"crates/diesel_models/src/authentication.rs",
"crates/diesel_models/src/authorization.rs",
"crates/diesel_models/src/blocklist.rs",
"crates/diesel_models/src/blocklist_fingerprint.rs",
"crates/diesel_models/src/blocklist_look... | |
juspay/hyperswitch | juspay__hyperswitch-5317 | Bug: make the `original_authorized_amount` optional for MITs with `connector_mandate_details`
During the MITs with the `connector_mandate_details` the `original_authorized_amount` is made optional. | diff --git a/crates/router/src/connector/cybersource/transformers.rs b/crates/router/src/connector/cybersource/transformers.rs
index 83882b161d2..df890b53056 100644
--- a/crates/router/src/connector/cybersource/transformers.rs
+++ b/crates/router/src/connector/cybersource/transformers.rs
@@ -588,12 +588,30 @@ impl
... | 2024-07-12T12:12:37Z |
## Description
<!-- Describe your changes in detail -->
During the MITs with the `connector_mandate_details` the `original_authorized_amount` is made optional.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
... | 21499947ad229580dd37cbbb22c31c48270bdb29 |
-> Create cybersource merchant connector account
-> Create mandate
```
curl --location 'http://localhost:8080/payments' \
--header 'Accept: application/json' \
--header 'api-key: dev_FZ5RdQNZ944E16z8uT6DrqlkCa2TsEnGBFxdFu6uuNgbwi68PJlvfpYGXmqLFlJa' \
--header 'Content-Type: application/json' \
--data-raw '{
... | [
"crates/router/src/connector/cybersource/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5313 | Bug: Add batch api to migrate multiple payment methods at a time
#5242 In addition to this API, when merchants have multiple payment methods to migrate we are adding support to upload them as CSV and do the migration including below 2 steps
1. Create the customer if it is not already present
2. Create the payme... | diff --git a/Cargo.lock b/Cargo.lock
index 68792185b1b..c0e6b05c845 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2397,6 +2397,27 @@ dependencies = [
"typenum",
]
+[[package]]
+name = "csv"
+version = "1.3.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "ac574ff4d437a7b5ad237ef331c1... | 2024-07-12T07:12:23Z |
## Description
<!-- Describe your changes in detail -->
Merchants who has existing customer payment methods in payment processor can upload a csv file to migrate their customers and their payment methods using this `/migrate-bulk` API
## Motivation and Context
<!--
Why is this change required? What problem doe... | f24a4070c33a435f25be9511fe1b90cf337efa52 |
1. Add below records and see if the new customer and payment methods are created. try making a recurring payment with the payment method saved
```
merchant_id,merchant_connector_id,name,email,phone,phone_country_code,customer_id,subscription_id,payment_method,payment_method_type,nick_name,payment_instrument_id,card... | [
"Cargo.lock",
"crates/api_models/src/payment_methods.rs",
"crates/router/Cargo.toml",
"crates/router/src/core/customers.rs",
"crates/router/src/core/payment_methods.rs",
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payment_methods/migration.rs",
"crates/router/src/routes/... | |
juspay/hyperswitch | juspay__hyperswitch-5300 | Bug: [REFACTOR]: Correct cypress tests env variables for Payment method list testing
### Feature Description
Setting Stripe as Default Pass-by for configs of response in our PaymentMethodList test scenarios.
### Possible Implementation
Refactors in Cypress.
### Have you spent some time checking if this feature r... | 2024-07-11T13:26:00Z |
## Description
<!-- Describe your changes in detail -->
Setting Stripe as Default Pass-by for configs of response in our PaymentMethodList test scenarios.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you... | 43741df4a76a66faa472dacd66b396232a2fbdbf |
Ran Cypress tests on Local:
<img width="423" alt="Screenshot 2024-07-11 at 6 55 48 PM" src="https://github.com/juspay/hyperswitch/assets/61520228/6a8ae2ad-363c-4983-8736-c295010fe500">
| [] | ||
juspay/hyperswitch | juspay__hyperswitch-5298 | Bug: [BUG] : [razorpay] wrong refund webhook reference id
### Bug Description
Because of wrong refund webhook reference id, refund webhooks are failing while received by hyperswitch
### Expected Behavior
Hyperswitch should identify the refund and trigger a Rsync to update the status.
### Actual Behavior
Hypersw... | diff --git a/crates/router/src/connector/razorpay.rs b/crates/router/src/connector/razorpay.rs
index 15fac492120..737ead477c3 100644
--- a/crates/router/src/connector/razorpay.rs
+++ b/crates/router/src/connector/razorpay.rs
@@ -630,7 +630,7 @@ impl api::IncomingWebhook for Razorpay {
let webhook_resource_obje... | 2024-07-11T12:39:58Z |
## Description
<!-- Describe your changes in detail -->
Currently we are passing a wrong refund webhook reference id, hence refund webhooks are failing while received by hyperswitch.
After this PR
Hyperswitch should identify refund webhook and trigger a Rsync to update the status
# | 4e41827ade5a4c844cbc8822618ac2e35c6029e2 |
1. Create a payment with Razorpay UPI Collect
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_UlJFXb4LACytmSXSI3i9J9N6aFzJELAUCypIwcylOhr5nhhGr6wOioIxQ52KGuDb' \
--data-raw '{
"amount": 5000,
"c... | [
"crates/router/src/connector/razorpay.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5288 | Bug: [FEATURE] [BANKOFAMERICA] Remove 3DS Flow
### Feature Description
3DS Flow is not supported on production by Bankofamerica and hence it needs to be removed.
### Possible Implementation
Remove 3DS code from BOA
### Have you spent some time checking if this feature request has been raised before?
- [X] I che... | diff --git a/crates/router/src/connector/bankofamerica.rs b/crates/router/src/connector/bankofamerica.rs
index 19bc3f9875b..daec033f6f3 100644
--- a/crates/router/src/connector/bankofamerica.rs
+++ b/crates/router/src/connector/bankofamerica.rs
@@ -12,7 +12,6 @@ use time::OffsetDateTime;
use transformers as bankofamer... | 2024-07-11T10:23:16Z |
## Description
<!-- Describe your changes in detail -->
Cards 3DS Flow is not supported on production by Bankofamerica and hence it is removed.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have... | 3312e787f9873d10114e6a4ca78a0c3714ab2b1c |
3DS Flow is not supported on production by Bankofamerica hence it is removed. 3DS payments will now go through normal Non-3DS flow.
Request:
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_mF5ApaF7qyl... | [
"crates/router/src/connector/bankofamerica.rs",
"crates/router/src/connector/bankofamerica/transformers.rs",
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/flows.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5307 | Bug: fix(bug): remove extra underscrore character in between email footer icons
remove extra underscrore character in between email footer icons | diff --git a/crates/router/src/services/email/assets/api_key_expiry_reminder.html b/crates/router/src/services/email/assets/api_key_expiry_reminder.html
index 6ebb099ed74..9d97d153eb6 100644
--- a/crates/router/src/services/email/assets/api_key_expiry_reminder.html
+++ b/crates/router/src/services/email/assets/api_key_... | 2024-07-11T09:26:57Z |
## Description
Minor bugfix in Email templates footer icon, an extra character. was appearing that is now removed
Current
New
![image](https://github.com/juspay/hyperswitch/assets/96485413/d43e0947-8455-4a87... | 998ce02ebc1eed10e426987d1af9c02d1f1735fe | [
"crates/router/src/services/email/assets/api_key_expiry_reminder.html",
"crates/router/src/services/email/assets/bizemailprod.html",
"crates/router/src/services/email/assets/invite.html",
"crates/router/src/services/email/assets/magic_link.html",
"crates/router/src/services/email/assets/recon_activation.htm... | ||
juspay/hyperswitch | juspay__hyperswitch-5289 | Bug: [FEATURE] [HELCIM] Move connector code for helcim to crate hyperswitch_connectors
### Feature Description
Connector code for helcim needs to be moved from crate `router` to new crate `hyperswitch_connectors`
### Possible Implementation
Connector code for helcim needs to be moved from crate `router` to new cr... | diff --git a/Cargo.lock b/Cargo.lock
index 66b38d09c1f..c5eac1ef868 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3830,6 +3830,25 @@ dependencies = [
"tokio 1.37.0",
]
+[[package]]
+name = "hyperswitch_connectors"
+version = "0.1.0"
+dependencies = [
+ "api_models",
+ "async-trait",
+ "cards",
+ "common_enums",
+ "... | 2024-07-11T08:53:37Z |
## Description
<!-- Describe your changes in detail -->
Move connector code for `helcim` from crate `router` to new crate `hyperswitch_connectors`.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't ... | 26b878308f7e493d6adb8c08b54a5498406eb28a |
Following flows need to be tested for connector Helcim
1. Authorize:
Request:
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_EvozwXY09n7tTs0SbWXKKGuEBIAtODBGwPTeu4iDlCx8izBWqyOF5QCNjPccy5qV' \
--da... | [
"Cargo.lock",
"crates/analytics/Cargo.toml",
"crates/external_services/Cargo.toml",
"crates/hyperswitch_connectors/Cargo.toml",
"crates/hyperswitch_connectors/src/connectors.rs",
"crates/router/src/connector/helcim.rs",
"crates/router/src/connector/helcim/transformers.rs",
"crates/hyperswitch_connecto... | |
juspay/hyperswitch | juspay__hyperswitch-5455 | Bug: [ENHANCEMENT] update API schema for payouts
### Bug Description
API request / response structure for payouts API hasn't kept up the development pace w payments API. Overtime, some of the fields in payouts API request have been obsoleted, whereas some of the new fields / objects are added for consuming differ... | diff --git a/crates/api_models/src/payouts.rs b/crates/api_models/src/payouts.rs
index c3ae760215b..3333fb6f546 100644
--- a/crates/api_models/src/payouts.rs
+++ b/crates/api_models/src/payouts.rs
@@ -18,7 +18,10 @@ pub enum PayoutRequest {
PayoutRetrieveRequest(PayoutRetrieveRequest),
}
-#[derive(Default, Debu... | 2024-07-11T08:17:38Z |
## Description
This PR includes below set of changes
- move customer specific fields to `customer` object for payout creation (backwards compatible)
- `customer` to be used when creating new customers
- `customer_id` to be used to specify details of an already onboarded customer
- update API reference docs ... | f81416e4df6fa430fd7f6eb910b55464cd72f3f0 | *Backward comptability for customer fields*
<details>
<summary>1. Create a new customer (without passing customer_id)</summary>
curl --location 'http://localhost:8080/payouts/create' \
--header 'Content-Type: application/json' \
--header 'api-key: dev_OkApivBrWlFwhoXRY6Iulr3QONuGY9ZcGrBkXu2T9P0RijlIk... | [
"crates/api_models/src/payouts.rs",
"crates/diesel_models/src/payout_attempt.rs",
"crates/diesel_models/src/payouts.rs",
"crates/diesel_models/src/schema.rs",
"crates/diesel_models/src/schema_v2.rs",
"crates/hyperswitch_domain_models/src/payouts/payout_attempt.rs",
"crates/hyperswitch_domain_models/src/... | |
juspay/hyperswitch | juspay__hyperswitch-5271 | Bug: fix(analytics): Update frm clickhouse script for creating table
https://github.com/juspay/hyperswitch/blob/main/crates/analytics/docs/clickhouse/scripts/fraud_check.sql
In this sql file there is a minor bug while creating the table which needs to be fixed. | diff --git a/crates/analytics/docs/clickhouse/scripts/fraud_check.sql b/crates/analytics/docs/clickhouse/scripts/fraud_check.sql
index 19e535981b6..30788a2a0f7 100644
--- a/crates/analytics/docs/clickhouse/scripts/fraud_check.sql
+++ b/crates/analytics/docs/clickhouse/scripts/fraud_check.sql
@@ -49,7 +49,7 @@ CREATE TA... | 2024-07-10T09:09:05Z |
## Description
<!-- Describe your changes in detail -->
Fixed the issue, a comma was missed in the syntax
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting wit... | 3da93f1f73680cc20313a068aacae3018b067b45 |
Script ran fine, and the fraud check tables were created in clickhouse
| [
"crates/analytics/docs/clickhouse/scripts/fraud_check.sql",
"crates/analytics/docs/clickhouse/scripts/sdk_events.sql"
] | |
juspay/hyperswitch | juspay__hyperswitch-5269 | Bug: Bug(router): [iatapay] make source verification false
### Bug Description
make source verification false
### Expected Behavior
make source verification false
### Actual Behavior
make source verification true
### Steps To Reproduce
Provide an unambiguous set of steps to reproduce this bug. Include code or... | diff --git a/crates/router/src/connector/razorpay.rs b/crates/router/src/connector/razorpay.rs
index 836f71e3c17..195508dffa2 100644
--- a/crates/router/src/connector/razorpay.rs
+++ b/crates/router/src/connector/razorpay.rs
@@ -7,6 +7,7 @@ use common_utils::{
use error_stack::{Report, ResultExt};
use masking::Expose... | 2024-07-10T07:41:12Z |
## Description
<!-- Describe your changes in detail -->
Make source verification false
## Test case
1.Create a payment
```
curl --location '/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'x-feature: router-custom' \
--header 'api-key: dev_apY4Z0ol... | fa7add19eeb09f8ab12970fa8ed66270f45883c3 | [
"crates/router/src/connector/razorpay.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-4818 | Bug: [FEATURE]:Remove Braintree SDK Flow support
Remove the SDK Support for the Braintree
| diff --git a/config/config.example.toml b/config/config.example.toml
index 941a315aaee..a78e5b2c995 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -194,8 +194,7 @@ bitpay.base_url = "https://test.bitpay.com"
bluesnap.base_url = "https://sandbox.bluesnap.com/"
bluesnap.secondary_base_url =... | 2024-07-10T05:35:20Z |
## Description
<!-- Describe your changes in detail -->
Removed Braintree SDK Flow support. Only Graphql Supported now
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend... | a3ad0d92d71f654b3843bff550322f665d26223f | Basic Flow test :
**3DS**
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key:' \
--data '{
"amount": 2500,
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"authent... | [
"config/config.example.toml",
"config/deployments/integration_test.toml",
"config/deployments/production.toml",
"config/deployments/sandbox.toml",
"config/development.toml",
"config/docker_compose.toml",
"crates/router/src/connector/braintree.rs",
"crates/router/src/connector/braintree/braintree_graph... | |
juspay/hyperswitch | juspay__hyperswitch-5259 | Bug: [BUG] Retrieve Payment Id Throwing 4xx
### Bug Description
For MIT transaction, using non MIT payment method Ids, throwing 400. When retreive this payment, it is throwing 422.
### Expected Behavior
https://api-reference.hyperswitch.io/api-reference/payments/payments--retrieve
### Actual Behavior
{
"... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index 97fc20d9444..d63ac8a030f 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -518,6 +518,139 @@ pub struct PaymentsRequest {
pub merchant_order_reference_id: Option<String>,
}
+/// Chec... | 2024-07-09T17:16:39Z |
## Description
<!-- Describe your changes in detail -->
In case we receive a 4xx when creating the payment before calling the connector, we do not save the `customer_id` in payment intent. This PR fixes it
This PR also includes changes to ensure that `customer_id` is always taken from both the places in the Payme... | fdac31324110ebe20ba56dd60cfe8c41dbd309a4 |
- Create a merchant account
```bash
curl --location 'http://localhost:8080/accounts' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '{
"merchant_id": "merchant_1720593206"
}'
```
- Create an api key
```bash
curl --location ... | [
"crates/api_models/src/payments.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/payments/operations/payment_complete_authorize.rs",
"crates/router/src/core/payments/operations/payment_confirm.rs",
"crates/router/src/core/payments/operations/payment_create.rs",
"crates/router/src... | |
juspay/hyperswitch | juspay__hyperswitch-5256 | Bug: refactor: fix auth select flow for default users
When no `id` is passed to auth_select request is should consider default case for user authentication method and give `totp` as the next SPT. | diff --git a/crates/router/src/core/user.rs b/crates/router/src/core/user.rs
index 49993f3873a..2abcb5ea78b 100644
--- a/crates/router/src/core/user.rs
+++ b/crates/router/src/core/user.rs
@@ -27,6 +27,7 @@ use super::errors::{StorageErrorExt, UserErrors, UserResponse, UserResult};
use crate::services::email::types as... | 2024-07-09T09:59:57Z |
## Description
- Populated the User Authentication Method data statically for default users
- Auth select should give next flow as `totp` when no `id` is passed
## Motivation and Context
Closes #5256
# | d6b9151e9edae17e06234c8958170bf38ff060bc | For no id present in the reqeust:
```
curl --location 'http://localhost:8080/user/auth/select' \
--header 'Authorization: Bearer SPT' \
--header 'Content-Type: application/json' \
--data '{
}`
```
Respnse:
```
{
"token": "eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiYjJkNjMxZDUtMGQzMi00Y2Ix... | [
"crates/router/src/core/user.rs",
"crates/router/src/types/domain/user.rs",
"crates/router/src/types/domain/user/user_authentication_method.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5255 | Bug: Removal of routing_metadata Logs
### Bug Description
The logs about the field not being deserialized was being spammed.
### Expected Behavior
It should do a checked deserialization of the metadata.
### Actual Behavior
It is spamming logs for every payments.
### Steps To Reproduce
1. Configure routing rul... | diff --git a/crates/router/src/core/payments/routing.rs b/crates/router/src/core/payments/routing.rs
index 8c27e3b3cac..d1a5441d958 100644
--- a/crates/router/src/core/payments/routing.rs
+++ b/crates/router/src/core/payments/routing.rs
@@ -115,10 +115,7 @@ pub fn make_dsl_input_for_payouts(
.transpose()
... | 2024-07-09T09:37:37Z |
## Description
<!-- Describe your changes in detail -->
Removal of metadata_parsing logs, as it was being spammed a lot of times. Moreover soon a method for proper deserialization by either String match or conversion of the hashMap to typed will be done.
## Motivation and Context
<!--
Why is this change requir... | fa83b697ab104e8e161170c9251c28b1aab1c890 |
We are just removing logs in this PR.
No extra code/flow changes.
| [
"crates/router/src/core/payments/routing.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5254 | Bug: [CI]: set `fail_fast` to false in the CI
Because of this field that was set in the CI-pr.yaml, we were failing the CI being run on github actions if the CI being run on hyperswitch runners fails. | 2024-07-09T09:32:41Z |
## Description
<!-- Describe your changes in detail -->
Set `fail_fast` to false in the Ci
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so... | 071d5345b5801e124da18d679202b0a60033b2f5 | [] | |||
juspay/hyperswitch | juspay__hyperswitch-5261 | Bug: [REFACTOR]: Removal of create_encrypted_data_optional function
### Feature Description
`create_encrypted_data_optional` is a copy of `create_encrypted_data` the only difference being in the params the former takes Option<T> and the latter takes T.
### Possible Implementation
Refactoring the function and plac... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index ee6ac7731c2..33e188b8ca0 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -46,6 +46,8 @@ use super::surcharge_decision_configs::{
};
... | 2024-07-09T08:59:32Z |
## Description
<!-- Describe your changes in detail -->
Made `create_encrypted_data` to accept `T` and refactored the previous function into `create_encrypted_data_optional`, which takes `Option<T>`. This also improves the error propogation of this function.
## Motivation and Context
<!--
Why is this change r... | 42e26e763e47706744b66cf808a158d97c31153b |
### Payment create request with some random `cus_id` and `name`
```
Response should be populated like this
```
"customer_id": "id_12343",
"customer": {
"id": null,
"name": "Light",
"email": null,
"phone": null,
"phone_country_code": null
},
```
curl -... | [
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/payments/operations/payment_confirm.rs",
"crates/router/src/core/payments/operations/payment_create.rs",
"crates/router/src/core/payments/operations/payment_update.rs",
"crates/router/s... | |
juspay/hyperswitch | juspay__hyperswitch-5249 | Bug: [BUG] Payout in stages
### Bug Description
- Default status (based on different conditions) does not update in payouts table
- Payout status updation during confirmation happens prior to validating the request
- Helper functions for deciding whether or not to execute different payout flows does not have th... | diff --git a/crates/router/src/core/payouts.rs b/crates/router/src/core/payouts.rs
index f6f78094943..7d5dd908fdb 100644
--- a/crates/router/src/core/payouts.rs
+++ b/crates/router/src/core/payouts.rs
@@ -368,8 +368,6 @@ pub async fn payouts_confirm_core(
let payout_attempt = payout_data.payout_attempt.to_owned();... | 2024-07-09T05:42:12Z |
## Description
This PR fixes below bugs
- default status (based on different conditions) does not update in `payouts` table
- payout status updation during confirmation happens prior to validating the request
- helper functions for deciding whether or not to execute different payout flows does not have the updat... | ffc79674e44d9b50bddbf4f4ac4aad0895c655db |
1. Create a payout using confirm: false, auto_fulfill: false
```
curl --location 'https://heard-directly-trademarks-diana.trycloudflare.com/payouts/create' \
--header 'x-feature: integ-custom' \
--header 'Content-Type: application/json' \
--header 'api-key: dev_N4b6S09H8f5CHy1vvGEEyvyJcUqcs64R84eVkCtdBr3iTYFOG... | [
"crates/router/src/core/payouts.rs",
"crates/router/src/core/payouts/helpers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5245 | Bug: [BUG]: [Adyen] Remove payment_method_type as required field in MIT
### Bug Description
Currently payment_method_type is a required field in MIT payments, which might not be the case all the time, so we need to handle this scenario
### Expected Behavior
MIT payments should work regardless payment_method... | diff --git a/crates/router/src/connector/adyen/transformers.rs b/crates/router/src/connector/adyen/transformers.rs
index d320475e61c..d56ec571ac6 100644
--- a/crates/router/src/connector/adyen/transformers.rs
+++ b/crates/router/src/connector/adyen/transformers.rs
@@ -2528,16 +2528,14 @@ impl<'a>
let browser_i... | 2024-07-08T14:02:05Z |
## Description
<!-- Describe your changes in detail -->
remove mandatory payment_method_type check in MIT, as we won't necessarily have this in CIT
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't ... | 2d31d38c1e35be99e9b0297b197bab81fa5f5030 |
### CIT payment via Adyen without payment_method_type
```
curl --location 'http://localhost:8080/payments' \
--header 'Accept: application/json' \
--header 'Content-Type: application/json' \
--header 'api-key: dev_FdbwTgkrJgCahVeugTVGJ3KWbS0UiIADoLlJoMfP2gzxicfOqbJ3HXcjoP8fjr8I' \
--data-raw '{
"amount": 1... | [
"crates/router/src/connector/adyen/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5235 | Bug: Docs: Adding More descriptive details in the Payouts module
We have received feedback about the Payout Module in API ref lacking in description of the various fields. | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index a466288b416..37f696e90f3 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -3668,6 +3668,7 @@ pub struct PaymentsResponse {
/// Providing this field will automatically set `capture` to t... | 2024-07-07T22:17:14Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implement... | 2d235a64e9ab66d9fcd75ed121a2401d891b2268 | [
"crates/api_models/src/payments.rs",
"crates/api_models/src/payouts.rs",
"crates/common_enums/src/enums.rs",
"crates/common_utils/src/types.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-5229 | Bug: Pass the shipping email whenever the billing details are included in the session token response
Currently we pass the below fields if the respective fields are enabled in the business profile
if `collect_shipping_details_from_wallet_connector = true`
```
"shipping_address_required": true,
"email_... | diff --git a/crates/router/src/core/payments/flows/session_flow.rs b/crates/router/src/core/payments/flows/session_flow.rs
index b52cf98b287..664038454a4 100644
--- a/crates/router/src/core/payments/flows/session_flow.rs
+++ b/crates/router/src/core/payments/flows/session_flow.rs
@@ -334,6 +334,21 @@ async fn create_ap... | 2024-07-05T14:04:57Z |
## Description
<!-- Describe your changes in detail -->
Currently we pass the below fields if the respective fields are enabled in the business profile
if `collect_shipping_details_from_wallet_connector = true`
```
"shipping_address_required": true,
"email_required": true,
"shipping_address_... | 648cecb204571eb5ac7378d9a217bf74c32a8377 |
-> Create a mca with apple pay and google pay enabled
-> Hit the below curl for the business profile
```
curl --location 'http://localhost:8080/account/merchant_1720188909/business_profile/pro_GXFptNIQjSYqmFij5MpV' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api... | [
"crates/router/src/core/payments/flows/session_flow.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-4986 | Bug: feat(events): forward the tenant configuration as part of the kafka message
In a previous [issue](https://github.com/juspay/hyperswitch/issues/4595) we've added tenant id to kafka events so that it can be used in downstream clickhouse,
But due to recent changes the tenant_id won't be used as a unique identif... | diff --git a/config/config.example.toml b/config/config.example.toml
index aa98c0533e3..83c05c90119 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -698,7 +698,7 @@ sdk_eligible_payment_methods = "card"
[multitenancy]
enabled = false
-global_tenant = { schema = "public", redis_key_prefix... | 2024-07-05T12:28:54Z |
## Description
<!-- Describe your changes in detail -->
Enhance the KafkaProducer struct to include a clickhouse_db_name field. This field is needed for generating audit events that do not use KafkaStore. Additionally, we will implement a method to add tenant details within KafkaProducer and propagate this functiona... | 876eeea0f426f63d0419021ba85372a016d46e27 |
After making a payment, you can observe a new field added at the end: `clickhouse_database = default` for `[Topics]
hyperswitch-payment-attempt-events` for sandbox the `clickhouse_database` should have the `hyperswitch_sandbox` or the current clickhouse db in use.
<img width="949" alt="image" src="https://githu... | [
"config/config.example.toml",
"config/deployments/env_specific.toml",
"config/development.toml",
"config/docker_compose.toml",
"crates/analytics/src/lib.rs",
"crates/router/src/compatibility/wrap.rs",
"crates/router/src/configs/settings.rs",
"crates/router/src/db/kafka_store.rs",
"crates/router/src/... | |
juspay/hyperswitch | juspay__hyperswitch-5221 | Bug: feat(events): add payment feature metadata & customer email to the payment intent events
Add a hashed value of these fields and use them to provide global search | diff --git a/Cargo.lock b/Cargo.lock
index d0b9894970b..d40d7e2ee05 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1577,6 +1577,7 @@ dependencies = [
"cc",
"cfg-if 1.0.0",
"constant_time_eq 0.3.0",
+ "serde",
]
[[package]]
@@ -1958,6 +1959,7 @@ name = "common_utils"
version = "0.1.0"
dependencies = [
"async... | 2024-07-05T11:47:44Z |
## Description
<!-- Describe your changes in detail -->
- Implemented hashing of `customer_email` using `blake3::hash`, and added this to PaymentIntent kafka events
- Enabled search using `customer_email` filter in dashboard globalsearch as well
- Added `feature_metadata` with `search_tags` for dashboard globalsea... | 16e8f4b263842bcf0767ed06ee94d73e02247dd8 |
Tested it using Postman curls:
- Made a payment with the `customer_email` and `search_tags` in `feature_metadata` set
```bash
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_IG9ateOUhGE0KLFEItNN1tsJXcr5M6... | [
"Cargo.lock",
"config/deployments/env_specific.toml",
"crates/analytics/src/search.rs",
"crates/api_models/src/analytics/search.rs",
"crates/api_models/src/payments.rs",
"crates/common_utils/Cargo.toml",
"crates/common_utils/src/hashing.rs",
"crates/common_utils/src/lib.rs",
"crates/common_utils/src... | |
juspay/hyperswitch | juspay__hyperswitch-5240 | Bug: [FEATURE] Add security restrictions on the payout links
### Feature Description
Payout links are public to the internet, anybody can make the GET request to fetch the link's HTML response. This renders the link on the client's browser without any sort of validations. Due to the sensitive nature of payout ope... | diff --git a/Cargo.lock b/Cargo.lock
index b29894b49c3..0188b3d6f1c 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -6129,6 +6129,7 @@ dependencies = [
"events",
"external_services",
"futures 0.3.30",
+ "globset",
"hex",
"http 0.2.12",
"hyper 0.14.28",
diff --git a/crates/api_models/src/admin.rs b/crates/api_mo... | 2024-07-05T11:32:36Z |
## Description
This PR includes below changes -
- adding `allowed_domains` field in payout link config
- this is added at both business profile level and individual payout txns
- business profile config is used as a fallback in case `allowed_domains` are not passed in payout link's create request
- this is ... | ecc862c3543be37e2cc7959f450ca51770978ae5 | **Tested locally using postman**
1. Update business profile's `payout_link_config` to include `allowed_domains`
```
curl --location 'http://localhost:8080/account/merchant_1721206540/business_profile/pro_iMeDAsjCBueHxdjCiZ9I' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data ... | [
"Cargo.lock",
"crates/api_models/src/admin.rs",
"crates/common_utils/src/consts.rs",
"crates/common_utils/src/link_utils.rs",
"crates/hyperswitch_domain_models/src/api.rs",
"crates/hyperswitch_domain_models/src/errors/api_error_response.rs",
"crates/router/Cargo.toml",
"crates/router/src/compatibility... | |
juspay/hyperswitch | juspay__hyperswitch-5217 | Bug: fix(bug): drainer fails to deserialize refund status
it seems due to recent changes that the refund status is encoded in snakecase whereas the older drainer working on PascalCase is failing breaking backwards compatibility | diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs
index 36cc0bcb11c..87b436ca922 100644
--- a/crates/common_enums/src/enums.rs
+++ b/crates/common_enums/src/enums.rs
@@ -1574,11 +1574,16 @@ pub enum PaymentType {
#[strum(serialize_all = "snake_case")]
#[serde(rename_all = "snake_case")]... | 2024-07-05T08:28:57Z |
## Description
<!-- Describe your changes in detail -->
- Add backwards compatibility aliases on refund status
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend startin... | 1904ffad889bbf2c77e959fda60c0c55fd57f596 |
- make refunds with kv mode and check the operations tab for their presence
| [
"crates/common_enums/src/enums.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5212 | Bug: fix(users): make id option in auth select
The id the request body of auth select should be option. It is because list will be empty for hyperswitch authentication method. | diff --git a/crates/api_models/src/user.rs b/crates/api_models/src/user.rs
index 66d4986129a..43b476c9f67 100644
--- a/crates/api_models/src/user.rs
+++ b/crates/api_models/src/user.rs
@@ -377,5 +377,5 @@ pub struct AuthIdQueryParam {
#[derive(Debug, serde::Deserialize, serde::Serialize)]
pub struct AuthSelectReque... | 2024-07-04T14:26:55Z |
## Description
Make id option in auth select. If no id is passed the response should give totp token
## Motivation and Context
Closes [#5212](https://github.com/juspay/hyperswitch/issues/5212)
# | cf5c1041b787ecf74519eb5077ebacd3b1beef67 | request:
```
curl --location 'http://localhost:8080/user/auth/select' \
--header 'Authorization: Bearer eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiYjJkNjMxZDUtMGQzMi00Y2IxLTg2MTQtNWVlNWI2MDczYTVkIiwicHVycG9zZSI6ImF1dGhfc2VsZWN0Iiwib3JpZ2luIjoiYWNjZXB0X2ludml0YXRpb25fZnJvbV9lbWFpbCIsInBhdGgiOltdLCJleHAiOjE4... | [
"crates/api_models/src/user.rs",
"crates/router/src/core/user.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5211 | Bug: pass fields to indicate if the customer address details to be connector from wallets
Currently there are two fields which indicate if the customer address needs to be collected form the wallets like apple pay or google pay. And those fields are `collect_shipping_details_from_wallet_connector` and `collect_billi... | diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs
index 0e2fd7b7039..c8826c02089 100644
--- a/crates/api_models/src/payment_methods.rs
+++ b/crates/api_models/src/payment_methods.rs
@@ -795,6 +795,12 @@ pub struct PaymentMethodListResponse {
/// flag to indicate wheth... | 2024-07-04T12:17:42Z |
## Description
<!-- Describe your changes in detail -->
Currently there are two fields which indicate if the customer address needs to be collected form the wallets like apple pay or google pay. And those fields are `collect_shipping_details_from_wallet_connector` and `collect_billing_details_from_wallet_connector`,... | 755d968c95b8a5287408599de5187e50deac588f |
-> Create stripe mca
-> For the specific business profile set the below fields as ture
```
curl --location 'http://localhost:8080/account/merchant_1720165673/business_profile/pro_6Rcn7QpBhEJ1M76tiD4w' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: admin' \... | [
"crates/api_models/src/payment_methods.rs",
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payments/flows/session_flow.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5201 | Bug: [Event Generation] KafkaTimestamp change from second to millisecond
Kafka timestamp currently is in second * 1000 to convert to millisecond precision
Issue with that is Kafka messages are getting out of order while pushing events as changes are happening in millisecond level
Due to which re-ordering of messages... | diff --git a/crates/router/src/services/kafka.rs b/crates/router/src/services/kafka.rs
index d1abda2105d..baa78339d91 100644
--- a/crates/router/src/services/kafka.rs
+++ b/crates/router/src/services/kafka.rs
@@ -319,11 +319,15 @@ impl KafkaProducer {
BaseRecord::to(topic)
.key(&ev... | 2024-07-04T09:33:39Z |
## Description
<!-- Describe your changes in detail -->
Adds millisecond timestamp to the kafka timestamp, would help in solving the re-ordering of events in kafka while pushing
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to th... | 0796bb3b259c43f1105cf98e3d4407c46f4ca91d |
<img width="1486" alt="Screenshot 2024-07-04 at 3 02 32 PM" src="https://github.com/juspay/hyperswitch/assets/104988143/f25e41af-f74a-4acf-947d-ebe4a6895fe7">
<img width="1486" alt="Screenshot 2024-07-04 at 3 02 50 PM" src="https://github.com/juspay/hyperswitch/assets/104988143/4bc31792-f7d3-4d88-987b-34c7d628... | [
"crates/router/src/services/kafka.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5188 | Bug: [Analytics] - Refund status serialization issue for ckh analytics
```rust
pub enum RefundStatus {
Failure,
ManualReview,
#[default]
Pending,
Success,
TransactionFailure,
}
```
RefundStatus enum is serialized to snake_case but when the same event is pushed to kafka it is retained in came... | diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs
index 2ad0ad35cb3..fdf703dc026 100644
--- a/crates/common_enums/src/enums.rs
+++ b/crates/common_enums/src/enums.rs
@@ -1547,6 +1547,7 @@ pub enum PaymentType {
)]
#[router_derive::diesel_enum(storage_type = "db_enum")]
#[strum(serializ... | 2024-07-04T08:35:57Z |
## Description
<!-- Describe your changes in detail -->
RefundStatus Enum does not support snake_case, so serde directive were added.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue,... | 0796bb3b259c43f1105cf98e3d4407c46f4ca91d |
Run a Query :
```
{topic="hyperswitch-refund-events", source!="vector"} |= `ref_XPgVve1i7ISdDXfnxNy0` | json | line_format `{{.refund_status}}`
```
the Output should be :
2024-07-04 15:37:41.486 failure
2024-07-04 15:37:41.486 pending
2024-07-04 15:37:40.998 pending
| [
"crates/common_enums/src/enums.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5198 | Bug: [FEATURE]: Add support for merchant order reference id
### Feature Description
Add support for merchant order reference id
### Possible Implementation
Add support for merchant order reference id
### Have you spent some time checking if this feature request has been raised before?
- [X] I checked and didn't... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index d8321524a1e..673a5cdae4f 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -506,6 +506,16 @@ pub struct PaymentsRequest {
/// Fee information to be charged on the payment being collect... | 2024-07-03T19:49:18Z |
## Description
<!-- Describe your changes in detail -->
Add support for accepting `merchant_order_reference_id` and subsequently pass it to the connector if connector supports accepting multiple reference.
This is being added for merchant to locate the payment using their id in the connector dashboard
## Motiva... | c8c0cb765e8a511aae0b3a4f94115bb07d122c9d |
### Do Payments Create and Update the `merchant_order_reference_id`, check this in DB
```
curl --location 'http://localhost:8080/payments' \
--header 'Accept: application/json' \
--header 'Content-Type: application/json' \
--header 'api-key: dev_JBNIuXN6ZUGXy4t5xk3btwzLBSxNJTfZHL6sYilDuqYUgMZulcithuwgj0UAYwCc' \... | [
"crates/api_models/src/payments.rs",
"crates/diesel_models/src/payment_intent.rs",
"crates/diesel_models/src/schema.rs",
"crates/hyperswitch_domain_models/src/payments.rs",
"crates/hyperswitch_domain_models/src/payments/payment_attempt.rs",
"crates/hyperswitch_domain_models/src/payments/payment_intent.rs"... | |
juspay/hyperswitch | juspay__hyperswitch-5196 | Bug: `override setup_future_usage` filed to on_session based on merchant config
This is the use case where in which we need if the setup_future_usage is set to off_session in the payment method needs to be just saved at hyperswitch and not at connector. This feature is not working as expected during the pre-routing,... | diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs
index f65cc052eaf..4af5a2ed308 100644
--- a/crates/router/src/core/payments.rs
+++ b/crates/router/src/core/payments.rs
@@ -3279,7 +3279,7 @@ where
&& should_do_retry
{
let retryable_conne... | 2024-07-03T18:05:08Z |
## Description
<!-- Describe your changes in detail -->
This is the use case where in which we need if the setup_future_usage is set to off_session in the payment method needs to be just saved at hyperswitch and not at connector. This is fix to override it during the pre-routing as well.
`skip_saving_wallet_at_co... | f513c8e4daa95a6ceb89ce616e3d55058708fb2a |
-> Create merchant connector account
-> Make a CIT with off_session and customer acceptance
```
{
"amount": 800,
"currency": "USD",
"confirm": true,
"amount_to_capture": 800,
"customer_id": "{{$timestamp}}",
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
... | [
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/payments/operations/payment_complete_authorize.rs",
"crates/router/src/core/payments/operations/payment_confirm.rs",
"crates/router/src/core/payments/operations/payment_create.rs",
"crates/router/sr... | |
juspay/hyperswitch | juspay__hyperswitch-5121 | Bug: [REFACTOR] Move trait IncomingWebhook to crate hyperswitch_interfaces
### Feature Description
trait `IncomingWebhook` needs to be moved to crate `hyperswitch_interfaces`. This is required to move connector code to new crate `hyperswitch_connectors`.
### Possible Implementation
trait `IncomingWebhook` needs t... | diff --git a/Cargo.lock b/Cargo.lock
index 2c339200661..68792185b1b 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -3914,10 +3914,14 @@ dependencies = [
name = "hyperswitch_interfaces"
version = "0.1.0"
dependencies = [
+ "actix-web",
+ "api_models",
"async-trait",
"bytes 1.6.0",
+ "common_enums",
"common_utils",... | 2024-07-03T09:59:10Z |
## Description
<!-- Describe your changes in detail -->
trait `IncomingWebhook` is moved to crate `hyperswitch_interfaces`. This is required for moving connector code to new crate `hyperswitch_connectors`.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an o... | 66ac1584dfd6e8574732cb753bdce0136d36c205 |
Webhooks need to be tested for production connectors like adyen, stripe, cryptopay, etc.
Scenarios like wrong `connector_webhook_details.merchant_secret` also need to be tested.
<img width="1227" alt="Screenshot 2024-07-11 at 4 09 49 PM" src="https://github.com/juspay/hyperswitch/assets/41580413/6f4750f0-5b99-4... | [
"Cargo.lock",
"crates/hyperswitch_domain_models/src/api.rs",
"crates/hyperswitch_domain_models/src/lib.rs",
"crates/hyperswitch_interfaces/Cargo.toml",
"crates/hyperswitch_interfaces/src/authentication.rs",
"crates/hyperswitch_interfaces/src/disputes.rs",
"crates/hyperswitch_interfaces/src/lib.rs",
"c... | |
juspay/hyperswitch | juspay__hyperswitch-5189 | Bug: Add appropriate missing logs for payment methods
Add missing logs for payment methods flow (both merchant and customer). | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index 41007286b83..1523ac18cb5 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -2002,6 +2002,8 @@ pub async fn list_payment_methods(
... | 2024-07-03T09:57:34Z |
## Description
<!-- Describe your changes in detail -->
This PR adds missing logs for payment methods flow (both merchant and customer).
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an iss... | f3fb59ce7448f91b74d0be4a75d82e282f075a66 |
This PR only adds logs so basic sanity tests should suffice
| [
"crates/router/src/core/payment_methods/cards.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5242 | Bug: add an api to migrate the payment method
This is the API that will be used to migrate card details and associated data stored in another service to Hyperswitch.
How does this API differ from the existing payment method creation API?
1. It takes masked card details as input with valid first six and last fo... | diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs
index cb268262fbc..5b360e39956 100644
--- a/crates/api_models/src/admin.rs
+++ b/crates/api_models/src/admin.rs
@@ -1229,6 +1229,8 @@ pub struct ConnectorAgnosticMitChoice {
impl common_utils::events::ApiEventMetric for ConnectorAgnosticMit... | 2024-07-03T09:22:19Z |
## Description
<!-- Describe your changes in detail -->
This is the API that will be used to migrate card details and associated data stored in another service to Hyperswitch.
How does this API differ from the existing payment method creation API?
1. It takes masked card details as input with valid first six a... | 1adcf0150458c4670b81fa8e2307dc0c32aa1ff1 |
-> Create merchant connector account for cybersource
### Test on_session saved payment
-> Crate a payment with `setup_future_usage: on_session`
```
{
"amount": 100,
"amount_to_capture": 100,
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"capture_on": "2022-09-10T... | [
"crates/api_models/src/admin.rs",
"crates/api_models/src/payment_methods.rs",
"crates/router/src/core/locker_migration.rs",
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payment_methods/transformers.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/p... | |
juspay/hyperswitch | juspay__hyperswitch-5025 | Bug: enhancement(logging): Emit a setup error when a restricted keys are used for logging default keys
Currently we have this error enum used for representing setup errors defined in
https://github.com/juspay/hyperswitch/blob/main/crates/storage_impl/src/errors.rs#L158-L175
We can use this to represent the in... | diff --git a/Cargo.lock b/Cargo.lock
index 68792185b1b..61dbacb522e 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2002,6 +2002,7 @@ dependencies = [
"serde",
"serde_json",
"strum 0.26.2",
+ "thiserror",
"utoipa",
]
@@ -6197,6 +6198,7 @@ name = "router_env"
version = "0.1.0"
dependencies = [
"cargo_metadat... | 2024-07-03T08:46:31Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implement... | 35d502e3da6b271452011dfae178108e3ba8c3c7 |
Enable the `level = "TRACE"` and `log_format = "pretty_json"` in development.toml and `cargo run` it will show the logs
| [
"Cargo.lock",
"crates/common_enums/Cargo.toml",
"crates/common_enums/src/enums.rs",
"crates/hyperswitch_interfaces/src/configs.rs",
"crates/router/src/bin/router.rs",
"crates/router/src/bin/scheduler.rs",
"crates/router/src/configs/settings.rs",
"crates/router/src/core/errors.rs",
"crates/router_env... | |
juspay/hyperswitch | juspay__hyperswitch-5344 | Bug: Adding contributors guide
Adding contributors guide | diff --git a/README.md b/README.md
index 62e016d3620..a54c4ea7ea2 100644
--- a/README.md
+++ b/README.md
@@ -9,19 +9,20 @@
The single API to access payment ecosystems across 130+ countries</div>
<p align="center">
- <a href="#%EF%B8%8F-quick-start-guide">Quick Start Guide</a> •
- <a href="/docs/try_local_system.m... | 2024-07-03T08:42:53Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implement... | 95e9c8523544bad4a034e61f62f6a321a8990963 | [
"README.md"
] | ||
juspay/hyperswitch | juspay__hyperswitch-5095 | Bug: fix(analytics): use HashSet to represent the returned metrics
Currently we have 2 sources for analytics Clickhouse & Sqlx
Along with this we have a combined mode which helps compare for any differences in these results
However since currently we return a vector of results this causes an mismatch warning if the... | diff --git a/crates/analytics/src/active_payments/metrics.rs b/crates/analytics/src/active_payments/metrics.rs
index e7b4ff3f5b6..5526f30fd6e 100644
--- a/crates/analytics/src/active_payments/metrics.rs
+++ b/crates/analytics/src/active_payments/metrics.rs
@@ -1,3 +1,5 @@
+use std::collections::HashSet;
+
use api_mode... | 2024-07-02T14:36:19Z |
## Description
<!-- Describe your changes in detail -->
Used hashset instead of vector for representing the returned metrics
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd rec... | 9bc780151c8ff1874d971bf8c79ae53cb6c477d8 |
Using curl requests, expected normal behaviour while perfoming payments, refunds, etc
```bash
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_IG9ateOUhGE0KLFEItNN1tsJXcr5M62N7zlbtOlUtStTfPpzSomswbQa4aO2k1B... | [
"crates/analytics/src/active_payments/metrics.rs",
"crates/analytics/src/active_payments/metrics/active_payments.rs",
"crates/analytics/src/api_event/metrics.rs",
"crates/analytics/src/api_event/metrics/api_count.rs",
"crates/analytics/src/api_event/metrics/latency.rs",
"crates/analytics/src/api_event/met... | |
juspay/hyperswitch | juspay__hyperswitch-5177 | Bug: refactor(reports): Change permissions for report APIs
Currently internal users are unable to use report APIs as some of them require Write permission which internal view only users doesn't have.
We need to change the permission required to access report APIs. | diff --git a/crates/api_models/src/user_role.rs b/crates/api_models/src/user_role.rs
index 6dde3eb888a..089e22a62a4 100644
--- a/crates/api_models/src/user_role.rs
+++ b/crates/api_models/src/user_role.rs
@@ -35,6 +35,7 @@ pub enum Permission {
PayoutWrite,
PayoutRead,
WebhookEventWrite,
+ GenerateRep... | 2024-07-02T12:20:34Z |
## Description
<!-- Describe your changes in detail -->
Currently, internal users are unable to access payment generate report as it requires `PaymentWrite`.
And other reports are having `Analytics` permission, but in the Front-end, the option is in Operations tab and in Analytics tab.
Because Generate reports... | dcc59115f2012d5544d6eb89f676c445a1392e13 |
```
curl 'http://localhost:8080/analytics/v1/report/payments' \
-H 'authorization: Bearer Internal user JWT' \
--data-raw '{"timeRange":{"startTime":"2024-07-01T11:34:38Z","endTime":"2024-07-02T11:34:38.441Z"},"dimensions":[]}'
```
When this API is hit by a internal user, this API should send email with re... | [
"crates/api_models/src/user_role.rs",
"crates/router/src/analytics.rs",
"crates/router/src/services/authorization/permission_groups.rs",
"crates/router/src/services/authorization/permissions.rs",
"crates/router/src/utils/user_role.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5174 | Bug: Updating the API reference documentation - payments
We have had feedback related to the API doc being outdated, and lacking proper visibility of the latest spec of the API collection. | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index cd36c53a12b..2dc51a3783b 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -251,12 +251,12 @@ pub struct PaymentsRequest {
#[mandatory_in(PaymentsCreateRequest = Currency)]
pub curr... | 2024-07-02T07:44:01Z |
## Description
<!-- Describe your changes in detail -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starting with one first so the PR
can focus on the implement... | 7004a802de2d30b97ecd37f57ba0e9c3aa962993 | [
"crates/api_models/src/payments.rs",
"crates/common_enums/src/enums.rs",
"crates/openapi/src/routes/payments.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-5149 | Bug: feat(events): add payment metadata to the payment intent events
We generate payment intent events on db changes,
for this we rely on the database payment intent struct for generating a corresponding struct (`KafkaPaymentIntent`).
we need to add the metadata, hashed customer_email to the generated event as wel... | diff --git a/config/development.toml b/config/development.toml
index 556b2e24afe..31a507a69a2 100644
--- a/config/development.toml
+++ b/config/development.toml
@@ -663,7 +663,7 @@ host = "https://localhost:9200"
[opensearch.auth]
auth = "basic"
username = "admin"
-password = "admin"
+password = "0penS3arc#"
region... | 2024-07-01T13:39:27Z |
## Description
<!-- Describe your changes in detail -->
- `metadata` is marked as `pii::SecretSerdeValue`, now changed it to `serde_json::Value` to remove the masking.
- Added the `metadata` field for `hyperswitch-payment-intent-events` (type - String).
## Motivation and Context
<!--
Why is this change requi... | c642d9dcf5e2bb9a91d543731e33ce5fe3e81b95 |
Make a normal payment through Postman by following the steps:
- Merchant Account - Create
- API Key - Create
- Payment Connector - Create
- Payments - Create
You should now be able to see the `metadata` field in hyperswitch-payment-intent-events when viewed in kafka-ui.
<img width="1495" alt="Screenshot 2024-... | [
"config/development.toml",
"config/docker_compose.toml",
"crates/api_models/src/payments.rs",
"crates/diesel_models/src/payment_intent.rs",
"crates/hyperswitch_domain_models/src/payments.rs",
"crates/hyperswitch_domain_models/src/payments/payment_intent.rs",
"crates/hyperswitch_domain_models/src/router_... | |
juspay/hyperswitch | juspay__hyperswitch-5335 | Bug: [FEATURE]: Integrate encryption service with hyperswitch
### Feature Description
PCI compliance requires application to follow some standards where encryption and decryption should not happen within the application as snapshot might have DEK and data together. So separate service should be used for encryption ... | diff --git a/Cargo.lock b/Cargo.lock
index 193f19453b9..66b38d09c1f 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -2006,6 +2006,7 @@ name = "common_utils"
version = "0.1.0"
dependencies = [
"async-trait",
+ "base64 0.22.0",
"blake3",
"bytes 1.6.0",
"common_enums",
@@ -2704,6 +2705,7 @@ dependencies = [
"maski... | 2024-06-28T14:15:09Z |
## Description
## Motivation and Context
PCI compliance requires application to follow some standards where encryption and decryption should not happen within the application as snapshot might have DEK and data together. So separate service should be used for encryption and decryption. In application wherever... | 7f582e4737c1c7dfe906e7d01de239e131511f84 | Changes can be verified only through logs. Look for "Fall back to Application Encryption" or "Fall back to Application Decryption" in the logs post deployment after running below tests. If logs are present encryption/decryption failed with encryption service and fall back to the application encryption which has to be i... | [
"Cargo.lock",
"crates/api_models/src/customers.rs",
"crates/api_models/src/payments.rs",
"crates/common_utils/Cargo.toml",
"crates/common_utils/src/consts.rs",
"crates/diesel_models/src/encryption.rs",
"crates/common_utils/src/keymanager.rs",
"crates/common_utils/src/lib.rs",
"crates/common_utils/sr... | |
juspay/hyperswitch | juspay__hyperswitch-5163 | Bug: rename the browser name header to `x-browser-name`
Rename the browser name header from `browsername` to `x-browser-name` | diff --git a/crates/router/src/lib.rs b/crates/router/src/lib.rs
index f0d332514d1..7059f0451ba 100644
--- a/crates/router/src/lib.rs
+++ b/crates/router/src/lib.rs
@@ -77,7 +77,7 @@ pub mod headers {
pub const X_CLIENT_SOURCE: &str = "X-Client-Source";
pub const X_PAYMENT_CONFIRM_SOURCE: &str = "X-Payment-Co... | 2024-06-28T13:46:55Z |
## Description
<!-- Describe your changes in detail -->
Rename the browser name header from `browsername` to `x-browser-name`
Our web sdk is currently passing `browsername` also, but this will be removed going forward
<img width="716" alt="image" src="https://github.com/juspay/hyperswitch/assets/83439957/e58c0601... | 910fcc89e24b8accd59a5a30021837222f803fa9 |
-> Create merchant connector account with apple pay manual flow. Below is the metadata for the manual flow.
```
"session_token_data": {
"initiative": "web",
"certificate": "==",
"display_name": "applepay",
"certificate_keys": "",
... | [
"crates/router/src/lib.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5160 | Bug: bug(auth_methods): Create auth methods is allowing auth methods with same type to be inserted multiple times
Currently create will accept and insert auth methods with same type and name, which shouldn't be possible.
Create should have checks for this and block these kind of requests. | diff --git a/crates/api_models/src/user.rs b/crates/api_models/src/user.rs
index 02a4a09dc94..66d4986129a 100644
--- a/crates/api_models/src/user.rs
+++ b/crates/api_models/src/user.rs
@@ -306,7 +306,9 @@ pub struct OpenIdConnectPublicConfig {
pub name: OpenIdProvider,
}
-#[derive(Debug, serde::Deserialize, ser... | 2024-06-28T11:56:19Z |
## Description
<!-- Describe your changes in detail -->
Currently create will accept and insert auth methods with same type and name, which shouldn't be possible. This PR fixes that.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link ... | af2497b5012f048a4cf72b61712812bca534c17c |
```
curl --location 'http://localhost:8080/user/auth' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--data '{
"owner_id": "org_qaamgpukifSyBG0AxtYA2x",
"owner_type": "organization",
"auth_method": {
"auth_type": "open_id_connect",
"private_config":... | [
"crates/api_models/src/user.rs",
"crates/router/src/core/user.rs",
"crates/router/src/utils/user.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5158 | Bug: fix: print x request id for user postman tests
Console log x request id for users postman tests,
- it will help to debug failed tests for user collection | diff --git a/postman/collection-dir/users/Flow Testcases/Sign In/Signin Token Only Wrong/event.test.js b/postman/collection-dir/users/Flow Testcases/Sign In/Signin Token Only Wrong/event.test.js
index 16fca64a141..a9297538452 100644
--- a/postman/collection-dir/users/Flow Testcases/Sign In/Signin Token Only Wrong/event... | 2024-06-28T10:38:31Z |
## Description
For user postman tests log x request id for every request.
## Motivation and Context
Closes #5158
# | d2626fa3fe4216504fd0df216eea8462c87cce07 | Use command
```
cargo run --bin test_utils -- --module-name="users" --base-url="http://localhost:8080" --admin-api-key="admin_api_key"
```
Results will contain x request id for every request:
Local Response in Po... | [
"postman/collection-dir/users/Flow Testcases/Sign In/Signin Token Only Wrong/event.test.js",
"postman/collection-dir/users/Flow Testcases/Sign In/Signin Token Only/event.test.js",
"postman/collection-dir/users/Flow Testcases/Sign In/Signin Wrong/event.test.js",
"postman/collection-dir/users/Flow Testcases/Sig... | |
juspay/hyperswitch | juspay__hyperswitch-5096 | Bug: feat(globalsearch): Implement tag-based filters in global search
Add more explicit filters to global search:
Currently we rely on free form text search where opensearch matches the keywords across the entire document
We want to add a more refined & strict search query where we do exact matches on fields
filter... | diff --git a/crates/analytics/src/opensearch.rs b/crates/analytics/src/opensearch.rs
index b8c582df1bf..05f89b655cf 100644
--- a/crates/analytics/src/opensearch.rs
+++ b/crates/analytics/src/opensearch.rs
@@ -371,7 +371,7 @@ pub struct OpenSearchQueryBuilder {
pub query: String,
pub offset: Option<i64>,
... | 2024-06-27T20:28:54Z |
## Description
<!-- Describe your changes in detail -->
Added more explicit filters to global search:
Currently we rely on free form text search where opensearch matches the keywords across the entire document
Filters added currently:
- payment method
- currency
- status
- customer_email
Can map multi... | 2688d24d4963550ff3efee363194446a3c75cc59 |
Tested using local data by sending cURL requests through Postman.
```bash
curl --location 'http://localhost:8080/analytics/v1/search' \
--header 'Accept: */*' \
--header 'Accept-Language: en-US,en;q=0.9' \
--header 'Connection: keep-alive' \
--header 'Content-Type: application/json' \
--header 'Origin: http://... | [
"crates/analytics/src/opensearch.rs",
"crates/analytics/src/search.rs",
"crates/api_models/src/analytics/search.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5148 | Bug: feat(analytics): Add v2 payment analytics
Add analytics based on the payment intent
since merchants rely on payment intents this would help more closely relate to the merchant facing data.
Currently this will support 4 metrics
- successful smart retries
- total smart retries
- smart retried amount
- payment in... | diff --git a/crates/analytics/src/clickhouse.rs b/crates/analytics/src/clickhouse.rs
index ab47397b8af..b455e79b253 100644
--- a/crates/analytics/src/clickhouse.rs
+++ b/crates/analytics/src/clickhouse.rs
@@ -10,6 +10,7 @@ use super::{
active_payments::metrics::ActivePaymentsMetricRow,
auth_events::metrics::A... | 2024-06-27T19:38:10Z |
## Description
<!-- Describe your changes in detail -->
Added analytics based on `payment intent`
Currently supporting 4 metrics
- successful smart retries
- total smart retries
- smart retried amount
- payment intent count
filters
- status
- currency
group by
- status
- currency
## Motivation a... | 2688d24d4963550ff3efee363194446a3c75cc59 |
Tested using local data by sending cURL requests through Postman.
Tested using Postgres data from `payment_intents` table and also using Clickhouse data from `payment_intent` table.
<img width="959" alt="Screenshot 2024-06-28 at 12 33 21 PM" src="https://github.com/juspay/hyperswitch/assets/83278309/be420744-297d-4... | [
"crates/analytics/src/clickhouse.rs",
"crates/analytics/src/core.rs",
"crates/analytics/src/lib.rs",
"crates/analytics/src/payment_intents.rs",
"crates/analytics/src/payment_intents/accumulator.rs",
"crates/analytics/src/payment_intents/core.rs",
"crates/analytics/src/payment_intents/filters.rs",
"cra... | |
juspay/hyperswitch | juspay__hyperswitch-5146 | Bug: fix: cover sso nitpicks and todo changes
Nitpicks
- change parsing login for configs
- refactor terminate auth select
- clear cookie in rotate and reset password | diff --git a/crates/router/src/core/user.rs b/crates/router/src/core/user.rs
index 3e9145c2d33..ff1477aa3c9 100644
--- a/crates/router/src/core/user.rs
+++ b/crates/router/src/core/user.rs
@@ -4,7 +4,6 @@ use api_models::{
payments::RedirectionResponse,
user::{self as user_api, InviteMultipleUserResponse},
}... | 2024-06-27T13:08:53Z |
## Description
The PR
- removes cookie after rotate password and reset password
- refactor parsing for sso config, now it uses `serde json from value` instead of `parse value`
- refactors terminate auth select
- send bad request instead of internal server error if invalid id is passed to auth/select
## Motiv... | d4dba55fedc37ba9d1d54d28456ca17851ab9881 | For bad request id for in auth select:
```
curl --location 'http://localhost:8080/user/auth/select' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer SPT' \
--data '{
"id":"wrong id"
}'
```
Response
```
{
"error": {
"type": "invalid_request",
"message": ... | [
"crates/router/src/core/user.rs",
"crates/router/src/utils/user.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5141 | Bug: [FEATURE] Add support for changing the decryption scheme of the locker
## Description
Currently, locker uses `RSA_OAEP` for encryption which is deprecated. To allow for seamless migration we are adding a configuration to allow for changing the decryption scheme in hyperswitch side | diff --git a/crates/router/src/configs/defaults.rs b/crates/router/src/configs/defaults.rs
index 35bfbc88f69..95b585d3445 100644
--- a/crates/router/src/configs/defaults.rs
+++ b/crates/router/src/configs/defaults.rs
@@ -69,6 +69,7 @@ impl Default for super::settings::Locker {
locker_enabled: true,
... | 2024-06-27T09:04:31Z | …e used by the locker
## Description
Add support for `RSA-OAEP-256` while decrypting the locker response as a configuration
<!-- Describe your changes in detail -->
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the is... | d4dba55fedc37ba9d1d54d28456ca17851ab9881 | Optional configuration, no tests needed
| [
"crates/router/src/configs/defaults.rs",
"crates/router/src/configs/settings.rs",
"crates/router/src/core/blocklist/transformers.rs",
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payment_methods/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5138 | Bug: Skip session to call pay when the browser is not `Safari`
Currently, the Apple Pay session call is mandatory in all cases. This requirement also mandates configuring the initiative_context, which is the domain name where the Apple Pay payment is being processed. However, in the case of an iOS app, a domain is n... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index 777e876b1b5..bf275a0dd0f 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -20,6 +20,7 @@ use serde::{
ser::Serializer,
Deserialize, Deserializer, Serialize,
};
+use strum::Display... | 2024-06-26T14:53:56Z |
## Description
<!-- Describe your changes in detail -->
Currently, the Apple Pay session call is mandatory in all cases. This requirement also mandates configuring the initiative_context, which is the domain name where the Apple Pay payment is being processed. However, in the case of an iOS app, a domain is not requ... | 9c49ded104b81f1aefcc288e3ded64ebbd4d466f |
-> Create merchant connector account with apple pay manual flow. Below is the metadata for the manual flow.
```
"session_token_data": {
"initiative": "web",
"certificate": "==",
"display_name": "applepay",
"certificate_keys": "",
... | [
"crates/api_models/src/payments.rs",
"crates/common_enums/src/enums.rs",
"crates/openapi/src/openapi.rs",
"crates/router/src/connector/bluesnap/transformers.rs",
"crates/router/src/connector/payme/transformers.rs",
"crates/router/src/connector/trustpay/transformers.rs",
"crates/router/src/core/payments.... | |
juspay/hyperswitch | juspay__hyperswitch-5127 | Bug: feat: add endpoint for terminate auth select
Add support to terminate auth select,
- the api will take Auth Select SPT and
- it will either SSO or TOTP SPT as per requested scenario
| diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs
index 4f5651e0a3c..b357a3389d9 100644
--- a/crates/api_models/src/events/user.rs
+++ b/crates/api_models/src/events/user.rs
@@ -10,16 +10,17 @@ use crate::user::{
dashboard_metadata::{
GetMetaDataRequest, GetMetaDataR... | 2024-06-26T14:13:02Z |
## Description
- Add endpoint `/auth/select` to terminate auth select
- The api will take Auth Select SPT and will give SSO SPT or TOTP SPT based on the choice selected
- SSO SPT if user selects continue with SSO
- TOTP SPT if user selects continue with TOTP
## Motivation and Context
Closes #5127
# | ce7d0d427d817eb4199f2f6ea8ea86a04bd98a26 | If request from id that has auth type as `open_id_connect`:
```
curl --location 'http://localhost:8080/user/auth/select' \
--header 'Content-Type: application/json' \
--header 'Authorization: Bearer SPT' \
--header 'Cookie: Cookie_1=value' \
--data '{
"id":"f20742d2-f1b8-4dad-8b2d-cf8fe6d457eb"
}'
```
r... | [
"crates/api_models/src/events/user.rs",
"crates/api_models/src/user.rs",
"crates/router/src/core/user.rs",
"crates/router/src/routes/app.rs",
"crates/router/src/routes/lock_utils.rs",
"crates/router/src/routes/user.rs",
"crates/router/src/types/domain/user/decision_manager.rs",
"crates/router_env/src/... | |
juspay/hyperswitch | juspay__hyperswitch-5059 | Bug: bug(events): update the ApiEventsType for `PaymentsSessionResponse` to use payments flow
update the `ApiEventMetric` trait for this response to return `ApiEventsType::Payment { payment_id : String}` variant.
based on the payment id stored in its body
This would help for better structuring and help list this... | diff --git a/crates/api_models/src/events.rs b/crates/api_models/src/events.rs
index bed46f01f19..fd974a8b9e2 100644
--- a/crates/api_models/src/events.rs
+++ b/crates/api_models/src/events.rs
@@ -40,7 +40,6 @@ impl ApiEventMetric for TimeRange {}
impl_misc_api_event_type!(
PaymentMethodId,
- PaymentsSession... | 2024-06-26T10:56:39Z |
## Description
<!-- Describe your changes in detail -->
Updated the `ApiEventMetric` trait to return `ApiEventsType::Payment { payment_id : String}` variant.
Fixes #5059
<!--
Provide links to the files with corresponding changes.
Following are the paths where you can find config files:
1. `config`
2. ... | 9c49ded104b81f1aefcc288e3ded64ebbd4d466f | [
"crates/api_models/src/events.rs",
"crates/api_models/src/events/payment.rs"
] | ||
juspay/hyperswitch | juspay__hyperswitch-5125 | Bug: feat: create redirect and sso login api
Required:
- Api that should redirect to openidconnect provider login.
- Api that should accept the `code` and `state` passed by `openidconnect` provider and continue with login flow. | diff --git a/Cargo.lock b/Cargo.lock
index 8c7c88e6196..9b08fcbd57b 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -1430,6 +1430,12 @@ dependencies = [
"rustc-demangle",
]
+[[package]]
+name = "base16ct"
+version = "0.2.0"
+source = "registry+https://github.com/rust-lang/crates.io-index"
+checksum = "4c7f02d4ea65f2c1... | 2024-06-26T10:33:17Z |
## Description
Two new apis give
- generate and redirect to openid provider.
- signin using data given by openid provider.
<!-- Describe your changes in detail -->
## Motivation and Context
Required for users to signin using sso.
<!--
Why is this change required? What problem does it solve?
If it fixes ... | 4ccd25d0dc0703f9ac9ff441bedc8a9ce4ce78c6 | Redirect to sso
```sh
curl --location '<BASE URL>/user/auth/url?id=<>'
```
Signin with sso.
```sh
curl --location --request POST '<BASE URL>/user/oidc' \
--header 'Content-Type: application/json' \
--data-raw '{
"state":"",
"code": ""
}'
```
| [
"Cargo.lock",
"crates/api_models/src/events/user.rs",
"crates/api_models/src/user.rs",
"crates/diesel_models/src/query/user_authentication_method.rs",
"crates/router/Cargo.toml",
"crates/router/src/analytics.rs",
"crates/router/src/consts/user.rs",
"crates/router/src/core/errors/user.rs",
"crates/ro... | |
juspay/hyperswitch | juspay__hyperswitch-5119 | Bug: feat(email): Send `auth_id` in email URLs
Currently links in the emails point to public dashboard. For SSO tenants/orgs, they should point to different url, which has `auth_id`. | diff --git a/config/config.example.toml b/config/config.example.toml
index f29876e648b..10f8ba7a5e7 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -346,7 +346,6 @@ wildcard_origin = false # If true, allows any origin to make req
[email]
sender_email = "example@example.com"... | 2024-06-25T14:33:35Z |
## Description
<!-- Describe your changes in detail -->
This PR will introduce `auth_id` field in email types and also email APIs.
When an email is triggered from a API which gets `auth_id`, then that will be used to construct the email URL as well.
## Motivation and Context
<!--
Why is this change required... | ffe90a41125a0eb1e8a858b336120e355fd3b69e |
All the following APIs will accept a query param called `auth_id`.
1. /user/connect_account
2. /user/forgot_password
3. /user/user/invite_multiple
4. /user/resend_invite
5. /user/verify_email_request
Example:
```
curl --location 'http://localhost:8080/user/connect_account?auth_id=2d784c51-c6ba-4adf-8d9f-407... | [
"config/config.example.toml",
"config/deployments/env_specific.toml",
"config/deployments/integration_test.toml",
"config/deployments/production.toml",
"config/deployments/sandbox.toml",
"config/development.toml",
"config/docker_compose.toml",
"crates/api_models/src/user.rs",
"crates/external_servic... | |
juspay/hyperswitch | juspay__hyperswitch-5117 | Bug: update last used when the customer acceptance is passed in the recurring payment
We need to update the last used for a payment method as whenever a payment is done with that particular saved payment method. Currently we if a customer is making a payment (CIT) with the payment data that is same as the one that i... | diff --git a/crates/diesel_models/src/payment_method.rs b/crates/diesel_models/src/payment_method.rs
index d9c7a66a6b2..16e8ddeb7d5 100644
--- a/crates/diesel_models/src/payment_method.rs
+++ b/crates/diesel_models/src/payment_method.rs
@@ -96,8 +96,13 @@ pub struct TokenizeCoreWorkflow {
#[derive(Debug, Serialize, ... | 2024-06-25T11:49:32Z |
## Description
<!-- Describe your changes in detail -->
We need to update the last used for a payment method as whenever a payment is done with that particular saved payment method. Currently we if a customer is making a payment (CIT) with the payment data that is same as the one that is already saved we are not upd... | ffe90a41125a0eb1e8a858b336120e355fd3b69e |
-> Create mca
-> Save card for customer with setup_future_usage offsession
```
{
"amount": 1000,
"currency": "USD",
"confirm": true,
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"customer_id": "{{$timestamp}}",
"email": "guest@example.com",
"name": ... | [
"crates/diesel_models/src/payment_method.rs",
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payments/operations/payment_response.rs",
"crates/router/src/core/payments/tokenization.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5113 | Bug: Mark retry payment as failure if `connector_tokenization` fails
When a payment confirm call is made the status of the payment would be `requires_payment_method` while performing connector pre-processing steps. If a there is an error during this step then the status remains in `requires_payment_method`. If the p... | diff --git a/crates/router/src/connector/stripe/transformers.rs b/crates/router/src/connector/stripe/transformers.rs
index 10d091a3b84..53850e97afc 100644
--- a/crates/router/src/connector/stripe/transformers.rs
+++ b/crates/router/src/connector/stripe/transformers.rs
@@ -33,7 +33,6 @@ use crate::{
storage::en... | 2024-06-25T07:13:16Z |
## Description
<!-- Describe your changes in detail -->
When a payment confirm call is made the status of the payment would be `requires_payment_method` while performing connector pre-processing steps. If a there is an error during this step then the status remains in `requires_payment_method`. If the pre-processing... | af2497b5012f048a4cf72b61712812bca534c17c |
-> Create MCA of stripe with apple pay simplified flow enabled
-> The connector api in the connector tokenizatoin flow is hardcoded wrongly for test purpose. So in this case if apple pay simplified payment request is made, the error response changes to `Invalid wallet token` from `unimplemented flow`. And also in th... | [
"crates/router/src/connector/stripe/transformers.rs",
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/flows.rs",
"crates/router/src/core/payments/flows/authorize_flow.rs",
"crates/router/src/core/payments/flows/complete_authorize_flow.rs",
"crates/router/src/core/payments/flows/setu... | |
juspay/hyperswitch | juspay__hyperswitch-5069 | Bug: Paypal webhook disputes
| diff --git a/crates/router/src/connector/paypal.rs b/crates/router/src/connector/paypal.rs
index 456332ea0f1..ee6b6c818c5 100644
--- a/crates/router/src/connector/paypal.rs
+++ b/crates/router/src/connector/paypal.rs
@@ -1465,7 +1465,6 @@ impl
self, req, connectors,
)?)
.build... | 2024-06-25T00:11:36Z |
## Description
<!-- Describe your changes in detail -->
This refactored branch resolves the PayPal dispute webhook deserialization issue.
-> It was failing to identify the webhook entity type and object reference ID.
-> I updated the fields accordingly to resolve the deserialization issue.
## Motivation and Co... | ecc6c00d4aaa034f96eae76c64024d56bb5fa173 | I ran the ngrok for frowarding webhook payload to localhost with url (https://697b-219-65-110-2.ngrok-free.app/webhooks/merchant_1719300138/paypal)
I have created dispute webhook through paypal simulator and these are the logs :
Incoming webhook Payload:
```
{
"id": "WH-4M0448861G563140B-9EX36365822141321",
... | [
"crates/router/src/connector/paypal.rs",
"crates/router/src/connector/paypal/transformers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-4372 | Bug: Add vector service to accept events from SDK
Need to add a [vector](https://vector.dev/) service to accept events from SDK & insert them to kafka/clickhouse.
This URL can be configured as an env in SDK container/deployment and it can forward the data to the kafka containers in the stack. | diff --git a/config/dashboard.toml b/config/dashboard.toml
index c00b167315a..142cc966500 100644
--- a/config/dashboard.toml
+++ b/config/dashboard.toml
@@ -25,8 +25,8 @@ test_processors=true
feedback=false
mixpanel=false
generate_report=false
-user_journey_analytics=false
-authentication_analytics=false
+user_journ... | 2024-06-24T11:00:19Z |
## Description
<!-- Describe your changes in detail -->
This PR introduces a real-time analytics feature that allows merchants to track distinct payment IDs on their dashboards. The key components of this feature include a script to create a ClickHouse table with a 1-minute Time-To-Live (TTL) for the data, and an an... | ea74f3e537aca44c42bd1e9c80eb7a1e220c295d |
**1. Start the necessary services using Docker Compose**
```
docker compose up -d kafka-ui clickhouse-server
```
**2. Load the SDK and simulate payments**
**3. Verify Real-Time Analytics**
```
curl --location 'localhost:8080/analytics/v1/metrics/active_payments' \
--header 'Content-Type: application/json' \... | [
"config/dashboard.toml",
"config/vector.yaml",
"crates/analytics/docs/clickhouse/scripts/sdk_events.sql",
"crates/analytics/src/active_payments.rs",
"crates/analytics/src/active_payments/accumulator.rs",
"crates/analytics/src/active_payments/core.rs",
"crates/analytics/src/active_payments/metrics.rs",
... | |
juspay/hyperswitch | juspay__hyperswitch-5000 | Bug: fix(opensearch): show search results only if user has access to the index
/search and /search/{domain} are currently checking for analytics ACL before hitting opensearch and returning results.
we have to change this to check access permissions per index
payments attempts/intents => PaymentRead | PaymentW... | diff --git a/crates/analytics/src/opensearch.rs b/crates/analytics/src/opensearch.rs
index e8f87aaef2e..b8c582df1bf 100644
--- a/crates/analytics/src/opensearch.rs
+++ b/crates/analytics/src/opensearch.rs
@@ -20,7 +20,6 @@ use opensearch::{
};
use serde_json::{json, Value};
use storage_impl::errors::ApplicationError... | 2024-06-24T09:40:15Z |
## Description
<!-- Describe your changes in detail -->
/search and /search/{domain} are currently checking for analytics ACL before hitting opensearch and returning results.
Additionally we have to check access permissions per index:
- payment attempts/intents => PaymentRead | PaymentWrite
- refunds => Refun... | 4ccd25d0dc0703f9ac9ff441bedc8a9ce4ce78c6 |
- Open the dashboard locally and hit the get_global_search_results API through the global search feature (command+k).
- Search using a query (eg: USD), to get the results corresponding to respective indexes (if user has access permission)
- Evaluate and verify the results
![Screenshot 2024-06-24 at 2 09 09 PM]... | [
"crates/analytics/src/opensearch.rs",
"crates/analytics/src/search.rs",
"crates/api_models/src/analytics/search.rs",
"crates/router/src/analytics.rs",
"crates/router/src/consts.rs",
"crates/router/src/consts/opensearch.rs",
"crates/router/src/events.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-3475 | Bug: Support to inject TLS certificate inside Hyperswith App Server
| diff --git a/Cargo.lock b/Cargo.lock
index 9b08fcbd57b..af7b0048355 100644
--- a/Cargo.lock
+++ b/Cargo.lock
@@ -43,6 +43,7 @@ dependencies = [
"actix-codec",
"actix-rt",
"actix-service",
+ "actix-tls",
"actix-utils",
"ahash 0.8.11",
"base64 0.21.7",
@@ -187,8 +188,10 @@ dependencies = [
"http 1.1.0",
"... | 2024-06-23T15:17:58Z |
## Description
<!-- Describe your changes in detail -->
Added support for TLS server within `actix-web` using `rustls`
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recomme... | 57055ecab2300c2284d0e674a22247fa65776ed8 |
Test Parameters:
- HTTP Server: 8080 (default)
- HTTPS Server: 8081
- Cert and Key generated using `mkcert` for `localhost` and `127.0.0.1`: `mkcert -key-file key.pem -cert-file cert.pem 127.0.0.1 localhost`
| [
"Cargo.lock",
"config/config.example.toml",
"config/deployments/env_specific.toml",
"crates/router/Cargo.toml",
"crates/router/src/configs/defaults.rs",
"crates/router/src/configs/settings.rs",
"crates/router/src/lib.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5088 | Bug: updated `last_used_at` field for apple pay and google pay for CITs
updated `last_used_at` field for apple pay and google pay for CITs
Currently, the `last_used_at` field for Apple Pay and Google Pay is not updated when an Apple Pay CIT (Cardholder Initiated Transaction) is made after Apple Pay has been saved... | diff --git a/crates/router/src/core/mandate/helpers.rs b/crates/router/src/core/mandate/helpers.rs
index 7fb0cfa28af..2bb981d03e8 100644
--- a/crates/router/src/core/mandate/helpers.rs
+++ b/crates/router/src/core/mandate/helpers.rs
@@ -70,9 +70,11 @@ pub fn get_mandate_type(
Ok(Some(api::MandateTransactio... | 2024-06-23T15:02:25Z |
## Description
<!-- Describe your changes in detail -->
updated `last_used_at` field for apple pay and google pay for CITs
Currently, the `last_used_at` field for Apple Pay and Google Pay is not updated when an Apple Pay CIT (Cardholder Initiated Transaction) is made after Apple Pay has been saved.
This needs ... | a71fe033e7de75171d140506ff4d51a362c185f4 |
-> Create mca for cybersource
-> Save apple pay for a customer
```
{
"amount": 800,
"currency": "USD",
"confirm": true,
"amount_to_capture": 800,
"customer_id": "testing_123456",
"capture_method": "automatic",
"capture_on": "2022-09-10T10:11:12Z",
"authentication_type": "thr... | [
"crates/router/src/core/mandate/helpers.rs",
"crates/router/src/core/payments/helpers.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5086 | Bug: [REFACTORE] : Connector Metadata,ApplePay and GooglePay
### Feature Description
Current WASM structure for the ApplePay,GooglePay and MetaData was not extendable for the additional fields.
In the case of ApplePay, all user input field changes are happening for **session_token_data**. With the current struct... | diff --git a/crates/connector_configs/src/common_config.rs b/crates/connector_configs/src/common_config.rs
index 837f0985b8f..88b8165853d 100644
--- a/crates/connector_configs/src/common_config.rs
+++ b/crates/connector_configs/src/common_config.rs
@@ -189,34 +189,28 @@ pub struct DashboardPaymentMethodPayload {
pub s... | 2024-06-22T14:29:58Z |
## Description
<!-- Describe your changes in detail -->
**Dashboard Changes**
https://github.com/juspay/hyperswitch-control-center/pull/854
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have... | d65d7b5ccaf3ba0d53a83e1f483a04fc409584c3 | [
"crates/connector_configs/src/common_config.rs",
"crates/connector_configs/src/connector.rs",
"crates/connector_configs/src/response_modifier.rs",
"crates/connector_configs/src/transformer.rs",
"crates/connector_configs/toml/development.toml",
"crates/connector_configs/toml/production.toml",
"crates/con... | ||
juspay/hyperswitch | juspay__hyperswitch-5079 | Bug: avoid considering pre-routing results during `perform_session_token_routing`
avoid considering pre-routing results during `perform_session_token_routing`
As there is a logic to filter out the apple pay payment method if apple pay is already saved. But this should not be the save when performing the session t... | diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs
index a8fe21796b5..fd052163c4b 100644
--- a/crates/router/src/core/payments.rs
+++ b/crates/router/src/core/payments.rs
@@ -3653,57 +3653,61 @@ pub async fn perform_session_token_routing<F>(
where
F: Clone,
{
- let routing_in... | 2024-06-21T16:51:57Z |
## Description
<!-- Describe your changes in detail -->
avoid considering pre-routing results during `perform_session_token_routing`
As there is a logic to filter out the apple pay payment method if apple pay is already saved. But this should not be the save when performing the session token (`perform_session_tok... | ca61e47585071865cf7df5c05fdbe3f57818ca95 |
-> Create mca with apple pay configured
-> Create payment with apple pay
```
{
"amount": 650,
"currency": "USD",
"confirm": true,
"business_country": "US",
"business_label": "default",
"amount_to_capture": 650,
"customer_id": "test_fb",
"capture_method": "automatic",
"c... | [
"crates/router/src/core/payments.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5077 | Bug: avoid considering pre-routing results during `perform_session_token_routing`
avoid considering pre-routing results during `perform_session_token_routing`
As there is a logic to filter out the apple pay payment method if apple pay is already saved. But this should not be the save when performing the session t... | diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs
index a8fe21796b5..fd052163c4b 100644
--- a/crates/router/src/core/payments.rs
+++ b/crates/router/src/core/payments.rs
@@ -3653,57 +3653,61 @@ pub async fn perform_session_token_routing<F>(
where
F: Clone,
{
- let routing_in... | 2024-06-21T15:52:10Z |
## Description
<!-- Describe your changes in detail -->
avoid considering pre-routing results during `perform_session_token_routing`
As there is a logic to filter out the apple pay payment method if apple pay is already saved. But this should not be the save when performing the session token (`perform_session_tok... | 6a07e10af379006c4643bb8f0a9cb2f46813ff8a |
-> Create mca with apple pay configured
-> Create payment with apple pay
```
{
"amount": 650,
"currency": "USD",
"confirm": true,
"business_country": "US",
"business_label": "default",
"amount_to_capture": 650,
"customer_id": "test_fb",
"capture_method": "automatic",
"c... | [
"crates/router/src/core/payments.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5066 | Bug: Collect billing details from wallet connector based on the `collect_billing_details_from_wallet_connector` field
We were always passing in some parameters in the wallet session token in order to collect the billing details form the wallet connectors (like google pay and apple pay) always. Instead of collecting ... | diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs
index 81761fac70d..58e11c4d0d4 100644
--- a/crates/api_models/src/admin.rs
+++ b/crates/api_models/src/admin.rs
@@ -950,9 +950,14 @@ pub struct BusinessProfileCreate {
/// Whether to use the billing details passed when creating the intent... | 2024-06-20T17:11:57Z |
## Description
<!-- Describe your changes in detail -->
We were always passing in some parameters in the wallet session token in order to collect the billing details form the wallet connectors (like google pay and apple pay) always. Instead of collecting it always this feature adds a field (`collect_billing_details_... | 7004a802de2d30b97ecd37f57ba0e9c3aa962993 |
-> Create a merchant connector account
-> Use the below curl to set the `collect_billing_details_from_wallet_connector`
```
curl --location 'http://localhost:8080/account/merchant_1718903636/business_profile/pro_D1HEnlPrKdJ33sefpb8W' \
--header 'Content-Type: application/json' \
--header 'Accept: application/jso... | [
"crates/api_models/src/admin.rs",
"crates/api_models/src/payments.rs",
"crates/diesel_models/src/business_profile.rs",
"crates/diesel_models/src/schema.rs",
"crates/router/src/core/admin.rs",
"crates/router/src/core/payments/flows/session_flow.rs",
"crates/router/src/core/routing/helpers.rs",
"crates/... | |
juspay/hyperswitch | juspay__hyperswitch-5063 | Bug: [REFACTOR] spawn one subscriber thread for handling all the published messages to different channel
In the current Redis pub-sub implementation, a subscriber spawns a thread to handle all messages published to a channel. As a result, if a subscriber is invoked multiple times (even for subscribing to the same ch... | diff --git a/crates/redis_interface/src/lib.rs b/crates/redis_interface/src/lib.rs
index dc4fd3bbc9c..fa35039800b 100644
--- a/crates/redis_interface/src/lib.rs
+++ b/crates/redis_interface/src/lib.rs
@@ -68,6 +68,7 @@ impl RedisClient {
pub struct SubscriberClient {
inner: fred::clients::SubscriberClient,
+ ... | 2024-06-20T15:44:08Z |
## Description
<!-- Describe your changes in detail -->
In the current Redis pub-sub implementation, a subscriber spawns a thread to handle all messages published to a channel. As a result, if a subscriber is invoked multiple times (even for subscribing to the same channel), it creates multiple threads for handling ... | ca61e47585071865cf7df5c05fdbe3f57818ca95 |
In the current implementation, the subscriber has been invoked 2 times thus resulting in 2 threads being spawned. Consequently, cache invalidation attempts occur in both threads, with only one succeeding. With this PR, there'll always be only one subscriber thread responsible for invalidating the cache entry.
* Se... | [
"crates/redis_interface/src/lib.rs",
"crates/router/src/db/configs.rs",
"crates/router/src/services.rs",
"crates/storage_impl/src/redis/cache.rs",
"crates/storage_impl/src/redis/pub_sub.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5055 | Bug: [FEATURE] Add a balance check for bank account during AIS flow
### Feature Description
For the open banking AIS flow, we need to add a check o the available balance in the selected bank account while doing a payment. If the check fails, the payment should not go through.
### Possible Implementation
Just a fe... | diff --git a/crates/pm_auth/src/connector/plaid/transformers.rs b/crates/pm_auth/src/connector/plaid/transformers.rs
index 9d903914483..8ce5aca7b83 100644
--- a/crates/pm_auth/src/connector/plaid/transformers.rs
+++ b/crates/pm_auth/src/connector/plaid/transformers.rs
@@ -1,7 +1,7 @@
use std::collections::HashMap;
... | 2024-06-20T10:40:19Z |
## Description
<!-- Describe your changes in detail -->
have added a balance check that would enable a check on the available amount in the selected bank account while doing a payment.
If the found balance is less than the intent amount, the payment would not go through.
## Motivation and Context
<!--
Why i... | f3fb59ce7448f91b74d0be4a75d82e282f075a66 |
Follow this for TCs - https://github.com/juspay/hyperswitch/pull/3047
In the payment create, use amount greater then 150 USD for the check to work
- Payment create -
```
curl --location --request POST 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application... | [
"crates/pm_auth/src/connector/plaid/transformers.rs",
"crates/pm_auth/src/types.rs",
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/pm_auth.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5047 | Bug: [BUG] Cypress tests are being skipped
This bug came into existence after some of the tests started to fail from server side error.
Commit that caused: [`24217d1` (#4904)](https://github.com/juspay/hyperswitch/pull/4904/commits/24217d132f87c31ecb2a44ac6340425d26750a5f). Reverting this should suffice. | 2024-06-19T16:36:48Z |
## Description
<!-- Describe your changes in detail -->
This PR fixes error introduced in commit [`24217d1` (#4904)](https://github.com/juspay/hyperswitch/pull/4904/commits/24217d132f87c31ecb2a44ac6340425d26750a5f) of PR https://github.com/juspay/hyperswitch/pull/4904 which led to tests getting skipped on single t... | 45a908b4407db160b5f92b0bf84a9612cfaf44ef |
Wrote below script to run tests in parallel (parallel tests require a lot of resource, else, tests become flaky):
```sh
#! /bin/bash
| [] | ||
juspay/hyperswitch | juspay__hyperswitch-5060 | Bug: fix(payment_methods): support last used for off session token payments
### Feature Description
support last used for off session token payments
### Possible Implementation
support last used for off session token payments
### Have you spent some time checking if this feature request has been raised before?
... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index f14997b20aa..b1bb3bb3c56 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -3808,21 +3808,17 @@ pub async fn set_default_payment_method... | 2024-06-19T09:39:56Z |
## Description
Earlier, while doing an off_session payment token , the last used was not getting updated. This PR fixes that issue
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, w... | d76ce2beaedcc09351dcfb70e27940c42a31c35d | - Create a MA and a MCA
- Create a payment with
> One card
> Other card
> then GooglePay
- Now make a off_Session payment_token payment, with the first card, which is `4242`
- List the PM for Customer, you would get the updated list , where card `4242` would come at the top and then the other pm
| [
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/payments/operations/payment_response.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5037 | Bug: [FEATURE] Add logger for sessions call failure
### Feature Description
Add a logger for failure of sessions call when the call fails at connector's end.
### Possible Implementation
Add a logger for failure of sessions call when the call fails at connector's end.
### Have you spent some time checking if this... | diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs
index d459fef935e..8935c3ac0ee 100644
--- a/crates/router/src/core/payments.rs
+++ b/crates/router/src/core/payments.rs
@@ -1740,7 +1740,7 @@ where
if let Ok(router_types::PaymentsResponseData::SessionResponse {
... | 2024-06-19T08:06:59Z |
## Description
<!-- Describe your changes in detail -->
Add a logger for failure of sessions call when the call fails at connector's end.
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an is... | d76ce2beaedcc09351dcfb70e27940c42a31c35d |
The following logs should be checked:
1. Session call fails without calling connector:
- Payments Create(Klarna):
Request:
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_jOiTovkpGinwxAIGAlEyC9... | [
"crates/router/src/core/payments.rs",
"crates/router/src/services/api.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5027 | Bug: feat(connector): [DATATRANS] add Connector Payment Flows Code
Implemented Card Payments for Datatrans
| diff --git a/config/development.toml b/config/development.toml
index b3548b35d06..4965723fb76 100644
--- a/config/development.toml
+++ b/config/development.toml
@@ -191,7 +191,7 @@ checkout.base_url = "https://api.sandbox.checkout.com/"
coinbase.base_url = "https://api.commerce.coinbase.com"
cryptopay.base_url = "htt... | 2024-06-18T12:14:36Z |
## Description
Implemented Card Payments for Datatrans
## Motivation and Context
https://github.com/juspay/hyperswitch/issues/5027
# | 3312e787f9873d10114e6a4ca78a0c3714ab2b1c | Attached Postman Collection `postman/collection-json/datatrans.postman_collection.json`
| [
"config/development.toml",
"crates/api_models/src/enums.rs",
"crates/common_enums/src/enums.rs",
"crates/connector_configs/src/connector.rs",
"crates/connector_configs/toml/development.toml",
"crates/connector_configs/toml/production.toml",
"crates/connector_configs/toml/sandbox.toml",
"crates/router/... | |
juspay/hyperswitch | juspay__hyperswitch-5024 | Bug: Add payment method type duplication check for `google_pay`
Currently there is no duplication check for google pay and we will create a new payment method entry for every google pay payment CIT with `"setup_future_usage": "on_session"`. This is not the case in cards as locker handles the card duplication. Since ... | diff --git a/crates/router/src/core/payments/tokenization.rs b/crates/router/src/core/payments/tokenization.rs
index 2d5d216a856..f05a81b223f 100644
--- a/crates/router/src/core/payments/tokenization.rs
+++ b/crates/router/src/core/payments/tokenization.rs
@@ -515,8 +515,10 @@ where
}
... | 2024-06-18T11:04:10Z |
## Description
<!-- Describe your changes in detail -->
Currently there is no duplication check for google pay and we will create a new payment method entry for every google pay payment CIT with `"setup_future_usage": "on_session"`. This is not the case in cards as locker handles the card duplication. Since we do no... | a7ad7906d7e84fa59df3cfffd16dea8db300e675 |
-> Create a merchant connector account with google pay enabled
-> Do a CIT with `setup_future_usage`
```
curl --location 'http://localhost:8080/payments' \
--header 'Accept: application/json' \
--header 'api-key: dev_rR35w9RzL1WW5hiDN7aF9jZbH6qHzAzW0nb9kB52KAnJDYc5EH3CakFbIje9MpYk' \
--header 'Content-Type: app... | [
"crates/router/src/core/payments/tokenization.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-4987 | Bug: bug(events): api events with event_type `user` aren't parsed correctly in clickhouse
The api events with events type user aren't parsed correctly in the user table,
this happens due to there being duplicate keys in the json representation which is treated as invalid json by clickhouse
```json
{
"key_a... | diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs
index c41f52a93ea..287bafaace8 100644
--- a/crates/api_models/src/events/user.rs
+++ b/crates/api_models/src/events/user.rs
@@ -24,7 +24,6 @@ use crate::user::{
impl ApiEventMetric for DashboardEntryResponse {
fn get_api_even... | 2024-06-18T11:02:12Z |
## Description
fix(events): Correct parsing of API events with user event_type for ClickHouse (#4987)
- Removed redundant `merchant_id` to handle user events correctly in ClickHouse.
- Updated Docker Compose to display times in IST timezone for ClickHouse.
## Motivation and Context
<!--
Why is this change... | d76ce2beaedcc09351dcfb70e27940c42a31c35d | By switching the merchant from localhost dashboard itself.
| [
"crates/api_models/src/events/user.rs",
"crates/common_utils/src/events.rs",
"docker-compose.yml"
] | |
juspay/hyperswitch | juspay__hyperswitch-4879 | Bug: Setup for Opensearch services and global search feature on control center
Add documentation to setup globalsearch & use it in local deployment mode. | diff --git a/config/dashboard.toml b/config/dashboard.toml
index 9bb2b6bf336..c00b167315a 100644
--- a/config/dashboard.toml
+++ b/config/dashboard.toml
@@ -31,7 +31,7 @@ surcharge=false
dispute_evidence_upload=false
paypal_automatic_flow=false
threeds_authenticator=false
-global_search=false
+global_search=true
di... | 2024-06-18T09:59:03Z |
## Description
<!-- Describe your changes in detail -->
- Adding a vector service to handle logs & kafka events
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'd recommend starti... | 91c8af6ef6d74cc3e0cb55c5f26ca1eae6907709 |
- Running it locally to check logs added in loki & opensearch
| [
"config/dashboard.toml",
"config/prometheus.yaml",
"config/vector.yaml",
"crates/analytics/src/clickhouse.rs",
"docker-compose.yml"
] | |
juspay/hyperswitch | juspay__hyperswitch-5018 | Bug: [FIX] populate card fields while saving card again during metadata change condition
When the same card is being saved with metadata changes, the other fields of card like `card_network`, `card_issuer`, `scheme`, `card_type`, `card_isin`, `card_issuing_country` is getting saved with hardcoded value as `None` ins... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index 66940fa9508..ba2de78a6ac 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -653,9 +653,10 @@ pub async fn add_payment_method(
... | 2024-06-16T13:00:58Z |
## Description
<!-- Describe your changes in detail -->
When the same card is being saved with metadata changes, the other fields of card like `card_network`, `card_issuer`, `scheme`, `card_type`, `card_isin`, `card_issuing_country` were getting saved with hardcoded value as `None` instead of getting its value from ... | 40dfad89ac6e70a15321b3711ee4c05c3c2ff201 |
1. Save a card
```
curl --location 'http://localhost:8080/payments' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: dev_bS3Uz99HdVusSOy9rHtZqcevmpHt9L4N6WvNt5d16SwBgz53crKKEd6pCMrvVVbH' \
--data-raw '{
"amount": 499,
"currency": "USD",
"co... | [
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payment_methods/transformers.rs",
"crates/router/src/core/payments/tokenization.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5015 | Bug: Override the `setup_future_usage` field to `on_session` based on merchant config
This is the use case where in which we need if the setup_future_usage is set to off_session in the payment method needs to be just saved at hyperswitch and not at connector.
`skip_saving_wallet_at_connector_<merchant_id>` is the... | diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs
index 50eedcfb568..b4ac878d372 100644
--- a/crates/router/src/core/payments.rs
+++ b/crates/router/src/core/payments.rs
@@ -3558,6 +3558,25 @@ pub async fn decide_multiplex_connector_for_normal_or_recurring_payment<F: Clone
... | 2024-06-15T08:17:20Z |
## Description
<!-- Describe your changes in detail -->
This is the use case where in which we need if the setup_future_usage is set to off_session in the payment method needs to be just saved at hyperswitch and not at connector.
`skip_saving_wallet_at_connector_<merchant_id>` is the config which takes vector of ... | 40dfad89ac6e70a15321b3711ee4c05c3c2ff201 |
-> Create merchant connector account
-> Set below config for the merchant id
```
curl --location 'localhost:8080/configs/' \
--header 'api-key: test_admin' \
--header 'Content-Type: application/json' \
--data '{
"key": "skip_saving_wallet_at_connector_merchant_1718351667",
"value": "[\"apple_pay\"]"
... | [
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/payments/tokenization.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5009 | Bug: Include the pre-routing connectors in apple pay retries
Currently for apple pay pre-routing is done before the session call and only one connector is decided based on the routing logic. Now since we want to enable auto retries for apple pay we need to consider all the connectors form the routing rule and constr... | diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs
index 66a695b2b0c..1ecc7a231ce 100644
--- a/crates/router/src/core/payment_methods/cards.rs
+++ b/crates/router/src/core/payment_methods/cards.rs
@@ -2014,7 +2014,15 @@ pub async fn list_payment_methods(
... | 2024-06-14T06:45:41Z |
## Description
<!-- Describe your changes in detail -->
Currently for apple pay pre-routing is done before the session call and only one connector is decided based on the routing logic. Now since we want to enable auto retries for apple pay we need to consider all the connectors form the routing rule and construct a... | bf239131572f488d5393e9fa932f9987751e0cbc |
-> Create merchant account
-> Enable auto retries for the specific `merchant_id`
```
curl --location 'localhost:8080/configs/' \
--header 'api-key: test_admin' \
--header 'Content-Type: application/json' \
--data '{
"key": "should_call_gsm_merchant_1718202727",
"value": "true"
}'
```
-> Set the max... | [
"crates/router/src/core/payment_methods/cards.rs",
"crates/router/src/core/payments.rs",
"crates/router/src/core/payments/helpers.rs",
"crates/router/src/core/payments/routing.rs",
"crates/router/src/types/storage.rs"
] | |
juspay/hyperswitch | juspay__hyperswitch-5008 | Bug: [FEATURE] Inclusion of customer details in payment_intent column
### Feature Description
This change will insure storage of customer_details in our payment_intent table.
Which will help us to derive the customer_details directly in one db call.
### Possible Implementation
if customer_id alone is passed ->... | diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs
index bf275a0dd0f..d477142fe82 100644
--- a/crates/api_models/src/payments.rs
+++ b/crates/api_models/src/payments.rs
@@ -202,11 +202,11 @@ pub struct CustomerDetails {
pub phone_country_code: Option<String>,
}
-#[derive(Debug, s... | 2024-06-13T20:06:14Z |
## Description
<!-- Describe your changes in detail -->
This change will insure storage of customer_details in our payment_intent table.
if customer_id alone is passed -> Derive customer_details from customer_table and put it in guest_customer_details,
if customer_id is not present -> Put the details in guest_cu... | d4dba55fedc37ba9d1d54d28456ca17851ab9881 |
### Testing Scenarios
### Payment create request with no `cus_id` and fields name, email, phone, phone country code
```
Response should be populated like this
```
"custo... | [
"crates/api_models/src/payments.rs",
"crates/diesel_models/src/payment_intent.rs",
"crates/diesel_models/src/schema.rs",
"crates/hyperswitch_domain_models/src/payments.rs",
"crates/hyperswitch_domain_models/src/payments/payment_attempt.rs",
"crates/hyperswitch_domain_models/src/payments/payment_intent.rs"... | |
juspay/hyperswitch | juspay__hyperswitch-5005 | Bug: [REFACTOR] add basic counter metrics for IMC
Introduce metrics for IMC -
* hits (successful read),
* misses (failed read),
* manual invalidations (done by applications)
Also add eviction listener on moka that can help identify strategy based evictions. | diff --git a/crates/analytics/src/api_event/core.rs b/crates/analytics/src/api_event/core.rs
index 7225a6322d4..c7d6d9ac339 100644
--- a/crates/analytics/src/api_event/core.rs
+++ b/crates/analytics/src/api_event/core.rs
@@ -12,6 +12,7 @@ use common_utils::errors::ReportSwitchExt;
use error_stack::ResultExt;
use rout... | 2024-06-13T19:17:51Z |
## Description
<!-- Describe your changes in detail -->
This PR introduces basic counter metrics for IMC -
* hits (successful read)
* misses (failed read)
* manual invalidations (done by applications) - makes use of eviction listener on moka that can help identify strategy based evictions
This PR also moves ... | 91c8af6ef6d74cc3e0cb55c5f26ca1eae6907709 |
1. Insert new config key value pair. Data is not cached in IMC during insertion
```
curl --location 'http://localhost:8080/configs/' \
--header 'Content-Type: application/json' \
--header 'Accept: application/json' \
--header 'api-key: test_admin' \
--data '{
"key": "test_key",
"value": "test_val_1"... | [
"crates/analytics/src/api_event/core.rs",
"crates/analytics/src/disputes/core.rs",
"crates/analytics/src/metrics/request.rs",
"crates/analytics/src/payments/core.rs",
"crates/analytics/src/refunds/core.rs",
"crates/hyperswitch_interfaces/src/api.rs",
"crates/hyperswitch_interfaces/src/metrics.rs",
"cr... | |
juspay/hyperswitch | juspay__hyperswitch-5002 | Bug: chore: address Rust 1.79 clippy lints
Address the clippy lints occurring due to new rust version 1.79
See https://github.com/juspay/hyperswitch/issues/3391 for more information. | diff --git a/crates/analytics/src/query.rs b/crates/analytics/src/query.rs
index 9a0d4ec62c6..1ab79f07e43 100644
--- a/crates/analytics/src/query.rs
+++ b/crates/analytics/src/query.rs
@@ -317,6 +317,7 @@ impl std::fmt::Display for Order {
// "count",
// Order::Descending,
// )
+#[allow(dead_code)]
#[derive... | 2024-06-13T17:18:25Z |
## Description
<!-- Describe your changes in detail -->
This PR addresses the clippy lints occurring due to new rust version 1.79
## Motivation and Context
<!--
Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
If you don't have an issue, we'... | ad7886a6ff636f99e62601483c907f5c90954eb4 |
Basic sanity testing should suffice
| [
"crates/analytics/src/query.rs",
"crates/router/src/connector/globalpay/response.rs",
"crates/router/tests/connectors/adyen.rs",
"crates/router/tests/connectors/payme.rs",
"crates/router/tests/connectors/square.rs",
"crates/router/tests/connectors/stax.rs",
"crates/router/tests/connectors/utils.rs",
"... | |
juspay/hyperswitch | juspay__hyperswitch-4998 | Bug: feat(users): add schema and apis for org authentication methods
Setup table and end points for org authentication methods
- This will be used to support SSO login
- Orgs can also setup multiple other authentication methods | diff --git a/config/config.example.toml b/config/config.example.toml
index 332ab4bc00b..9bdf0b80723 100644
--- a/config/config.example.toml
+++ b/config/config.example.toml
@@ -644,4 +644,7 @@ enabled = false
global_tenant = { schema = "public", redis_key_prefix = "" }
[multitenancy.tenants]
-public = { name = "hyp... | 2024-06-13T12:10:56Z |
## Description
The PR:
- Sets up schema for user authentication methods
- adds queries to interact with schema
- adds endpoints to create, update and list authentication methods
## Motivation and Context
Closes [#4998](https://github.com/juspay/hyperswitch/issues/4998)
# | f84ed6a8a00cd5f28debfbc1bb1f8dba14eaa387 | To create authentication method, ( auth is admin_api_key only):
```
curl --location 'http://localhost:8080/user/auth' \
--header 'Content-Type: application/json' \
--header 'api-key: test_admin' \
--header 'Cookie: Cookie_1=value' \
--data '
{
"owner_id": "pw",
"owner_type": "tenant",
"auth_method": {... | [
"config/config.example.toml",
"config/deployments/env_specific.toml",
"config/development.toml",
"config/docker_compose.toml",
"crates/api_models/src/events/user.rs",
"crates/api_models/src/user.rs",
"crates/common_enums/src/enums.rs",
"crates/diesel_models/src/lib.rs",
"crates/diesel_models/src/que... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.