repo
stringclasses
1 value
instance_id
stringlengths
22
24
problem_statement
stringlengths
30
24.1k
patch
stringlengths
0
1.9M
test_patch
stringclasses
1 value
created_at
stringdate
2022-11-25 05:12:07
2025-06-13 10:24:29
hints_text
stringlengths
0
228k
base_commit
stringlengths
40
40
test_instructions
stringlengths
0
232k
filenames
listlengths
0
300
juspay/hyperswitch
juspay__hyperswitch-4997
Bug: [FEATURE] Use Ephemeral auth for Customer PM list and PM delete APIs ### Feature Description We want to enable Ephemeral auth for both customer's PM list and PM delete API for the SDK to be able to use these APIs in a non-payments context ### Possible Implementation Implementation would involve changing the ...
diff --git a/crates/router/src/compatibility/stripe/customers.rs b/crates/router/src/compatibility/stripe/customers.rs index 65abb012b9a..264f205c907 100644 --- a/crates/router/src/compatibility/stripe/customers.rs +++ b/crates/router/src/compatibility/stripe/customers.rs @@ -195,6 +195,7 @@ pub async fn list_customer_...
2024-06-13T10:38:24Z
## Description <!-- Describe your changes in detail --> This PR enables - - Ephemeral key auth for customer's pm list - Ephemeral key auth for delete payment method ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issu...
0e059e7d847b0c15ed120c72bb4902ac60e6f955
1. Save a card for a customer 2. Create Ephemeral key for that customer ``` curl --location --request POST 'http://localhost:8080/ephemeral_keys' \ --header 'Content-Type: application/json' \ --header 'api-key: dev_cHN6hMdCFUUrNWjYSxnwhiuMsg83rXTX9jBmtHmCL6sq9a43PswY304MSt3a9blR' \ --data-raw '{ "customer_...
[ "crates/router/src/compatibility/stripe/customers.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/routes/customers.rs", "crates/router/src/routes/payment_methods.rs", "crates/router/src/services/authentication.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4992
Bug: feat(users): Decision manager changes for SSO Flows Because SSO needs new flows and will affect other login flows and email flows like accept invite, we have to change some flows in Decision Manager for SSO flows.
diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs index decbf9fd12a..f6d47f9a638 100644 --- a/crates/common_enums/src/enums.rs +++ b/crates/common_enums/src/enums.rs @@ -2758,6 +2758,10 @@ pub enum BankHolderType { #[strum(serialize_all = "snake_case")] #[serde(rename_all = "snake_case"...
2024-06-13T10:36:24Z
## Description <!-- Describe your changes in detail --> This PR adds SSO flows in login decision flows. Currently they are disabled as we have no APIs for SSO and will be enabled in upcoming PRs which adds SSO APIs. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it ...
e658899c1406225bb905ce4fb76e13fa3609666e
- There should be no changes in any of the flows. - SPT changes can be tested as follows: 1. Generate SPT using any of the token only APIs (I am using Sign in) ```curl curl --location 'http://localhost:8080/user/v2/signin?token_only=true' \ --header 'Content-Type: application/json' \ --data-raw '{ ...
[ "crates/common_enums/src/enums.rs", "crates/router/src/core/user.rs", "crates/router/src/core/user_role.rs", "crates/router/src/services/authentication.rs", "crates/router/src/types/domain/user.rs", "crates/router/src/types/domain/user/decision_manager.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4970
Bug: bug(user): Magic link is not expiring after being used once When a verified user is using magic link, that magic link is not blacklisted after being used once. User is able to use the same magic link to login to dashboard multiple times.
diff --git a/crates/router/src/core/user.rs b/crates/router/src/core/user.rs index c78f2c8080f..7e79e9e2e89 100644 --- a/crates/router/src/core/user.rs +++ b/crates/router/src/core/user.rs @@ -505,10 +505,8 @@ pub async fn reset_password_token_only_flow( let user = state .global_store - .update_u...
2024-06-12T12:43:23Z
## Description <!-- Describe your changes in detail --> Currently verify email API will be picked by the decision manager only if the user is not verified. But this API should be called always in case of verify email and magic link flow. This PR fixes it. ## Motivation and Context <!-- Why is this change re...
4651584ecc25e40a285b3544315901145d8c6b4b
``` curl --location 'http://localhost:8080/user/connect_account' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "user email" }' ``` You will receive a magic link to the email provided. Once the link in the email is used to login to dashboard, the link should not work anymore.
[ "crates/router/src/core/user.rs", "crates/router/src/types/domain/user.rs", "crates/router/src/types/domain/user/decision_manager.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4905
Bug: fix(opensearch): handle index not present errors in search api Currently in the self deployment mode we rely on fluentd to automatically create the index, in this case when we spin up the local setup the msearch API errors out since the index is not present, with the following json response ```json { ...
diff --git a/crates/analytics/docs/README.md b/crates/analytics/docs/README.md index b822edd810e..da9a3c79f1f 100644 --- a/crates/analytics/docs/README.md +++ b/crates/analytics/docs/README.md @@ -101,4 +101,18 @@ Here's an example of how to do this: [default.features] audit_trail=true system_metrics=true -``` \ No ...
2024-06-12T10:13:57Z
## Description <!-- Describe your changes in detail --> - Handled errors when index is not present, by logging the corresponding error message and treating the hits as 0. - Changed the structure of `OpensearchOutput` and corresponding structs which are used to handle the error. ## Motivation and Context <!-- ...
a7ad7906d7e84fa59df3cfffd16dea8db300e675
- Set up the global search locally - Test the global search with any keyword - Go through the log, and `5xx errors` should not be present anymore, with the errors logged, and handling of the index not found errors. ![image](https://github.com/juspay/hyperswitch/assets/83278309/5c7334b3-a9a8-4db8-9d31-447364c2ff0...
[ "crates/analytics/docs/README.md", "crates/analytics/src/opensearch.rs", "crates/analytics/src/search.rs", "crates/api_models/src/analytics/search.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4957
Bug: [BUG] Fix typo in `integration_test.toml` `krungsri_bank` it is.
diff --git a/config/deployments/integration_test.toml b/config/deployments/integration_test.toml index 738edcbda84..5abbc870fd0 100644 --- a/config/deployments/integration_test.toml +++ b/config/deployments/integration_test.toml @@ -9,7 +9,7 @@ online_banking_czech_republic.adyen.banks = "ceska_sporitelna,komercni_bank...
2024-06-12T05:27:16Z
## Description <!-- Describe your changes in detail --> This PR reverts typo introduced in https://github.com/juspay/hyperswitch/pull/4398 in `integration_test.toml` that resulted in deployments to fail. Resolves #4957 ## Motivation and Context <!-- Why is this change required? What problem does it solve?...
5a81b50ae20760ce3c281719e0853c0f60f23734
Deployments should succeed.
[ "config/deployments/integration_test.toml" ]
juspay/hyperswitch
juspay__hyperswitch-5014
Bug: Updating the API reference documentation We have had feedback related to the API doc being outdated, and lacking proper visibility of the latest spec of the API collection.
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index b11037c2a43..e1ebb547f05 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -857,9 +857,11 @@ pub struct ToggleAllKVResponse { #[schema(example = true)] pub kv_enabled: bool, } + +/// Merchant ...
2024-06-11T19:46:00Z
## Description This is regarding the API Reference Doc changes using OpenAPI. This PR just the doc changes for Payments - Create (Including the Payments - Response) ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here....
d2626fa3fe4216504fd0df216eea8462c87cce07
[ "crates/api_models/src/admin.rs", "crates/api_models/src/enums.rs", "crates/api_models/src/ephemeral_key.rs", "crates/api_models/src/mandates.rs", "crates/api_models/src/payments.rs", "crates/common_enums/src/enums.rs", "crates/openapi/src/openapi.rs", "crates/openapi/src/routes/payments.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4975
Bug: Include the pre-routing connectors in apple pay retries Currently for apple pay pre-routing is done before the session call and only one connector is decided based on the routing logic. Now since we want to enable auto retries for apple pay we need to consider all the connectors form the routing rule and constr...
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index 0641c842390..04983ed8b19 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -2085,7 +2085,15 @@ pub async fn list_payment_methods( ...
2024-06-11T16:09:43Z
## Description <!-- Describe your changes in detail --> Currently for apple pay pre-routing is done before the session call and only one connector is decided based on the routing logic. Now since we want to enable auto retries for apple pay we need to consider all the connectors form the routing rule and construct a...
b847606d665388fba898425b31dd5f207f60a56e
-> Create merchant account -> Enable auto retries for the specific `merchant_id` ``` curl --location 'localhost:8080/configs/' \ --header 'api-key: test_admin' \ --header 'Content-Type: application/json' \ --data '{ "key": "should_call_gsm_merchant_1718202727", "value": "true" }' ``` -> Set the max...
[ "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payments.rs", "crates/router/src/core/payments/helpers.rs", "crates/router/src/core/payments/routing.rs", "crates/router/src/types/storage.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4950
Bug: [FEATURE] [BOA/CYB] Make all BillTo fields optional ### Feature Description Make all BillTo fields optional for prod testing ### Possible Implementation Make all BillTo fields optional for prod testing ### Have you spent some time checking if this feature request has been raised before? - [X] I checked and...
diff --git a/crates/router/src/connector/bankofamerica/transformers.rs b/crates/router/src/connector/bankofamerica/transformers.rs index 671cc40e05c..143c1a4c6fa 100644 --- a/crates/router/src/connector/bankofamerica/transformers.rs +++ b/crates/router/src/connector/bankofamerica/transformers.rs @@ -260,15 +260,15 @@ p...
2024-06-11T11:59:38Z
## Description <!-- Describe your changes in detail --> Make billTo fields optional in connector BOA and Cybersource. This change is required for prod testing. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. I...
b705757be37a9803b964ef94d04c664c0f1e102d
Testing should be done for BOA and Cybersource. Payments should work if billing address is passed and payments should be failed at connector if billing address is not passed. Failure Request: ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: ap...
[ "crates/router/src/connector/bankofamerica/transformers.rs", "crates/router/src/connector/cybersource/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4948
Bug: [REFACTOR] wrap the encryption and file storage interface client in appstate with `Arc` as opposed to `Box` Currently, the encryption interface and file storage interface client is wrapped with `Box`. These clients live in AppState. Since state is cloned for each api handler, wrap the clients in `Arc` so that t...
diff --git a/crates/drainer/src/settings.rs b/crates/drainer/src/settings.rs index 311cee0cede..e64b5dbd4ad 100644 --- a/crates/drainer/src/settings.rs +++ b/crates/drainer/src/settings.rs @@ -31,7 +31,7 @@ pub struct CmdLineConf { #[derive(Clone)] pub struct AppState { pub conf: Arc<Settings<RawSecret>>, - p...
2024-06-11T11:33:16Z
## Description <!-- Describe your changes in detail --> Currently, the encryption interface and file storage interface client is wrapped with `Box`. These clients live in `AppState`. Since state is cloned for each api handler, wrapping the clients in Arc will help in not cloning the actual internal data rather maint...
b705757be37a9803b964ef94d04c664c0f1e102d
Basic sanity testing should suffice
[ "crates/drainer/src/settings.rs", "crates/external_services/src/file_storage.rs", "crates/external_services/src/managers/encryption_management.rs", "crates/router/src/routes/app.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4945
Bug: [REFACTOR] Move trait ConnectorIntegration to crate hyperswitch_interfaces ### Feature Description The trait ConnectorIntegration needs to be moved to crate hyperswitch_interfaces from router. This is required to move connector code out from crate router. ### Possible Implementation The trait ConnectorIntegr...
diff --git a/Cargo.lock b/Cargo.lock index 77f9b33ddc4..6ea7937eca6 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3695,11 +3695,22 @@ name = "hyperswitch_interfaces" version = "0.1.0" dependencies = [ "async-trait", + "bytes 1.6.0", "common_utils", "dyn-clone", + "http 0.2.12", + "hyperswitch_domain_models", "...
2024-06-11T09:50:21Z
## Description <!-- Describe your changes in detail --> The trait ConnectorIntegration needs to be moved to crate hyperswitch_interfaces from router. This is required to move connector code out from crate router. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fix...
658272904897f7cbc4d9a349278712f35a8d3e96
Basic testing is required for all the production connectors(and payment methods) on sandbox.
[ "Cargo.lock", "crates/hyperswitch_interfaces/Cargo.toml", "crates/hyperswitch_interfaces/src/api.rs", "crates/hyperswitch_interfaces/src/configs.rs", "crates/hyperswitch_interfaces/src/errors.rs", "crates/hyperswitch_interfaces/src/events.rs", "crates/hyperswitch_interfaces/src/events/connector_api_logs...
juspay/hyperswitch
juspay__hyperswitch-4947
Bug: [REFACTOR] Allow deletion of Default Payment Methods ### Feature Description Allow deletion of Payment Methods , even if there is only one PM for that respective connector ### Possible Implementation Allow deletion of Payment Methods , even if there is only one PM for that respective connector ### Have ...
diff --git a/crates/router/src/core/payment_methods/cards.rs b/crates/router/src/core/payment_methods/cards.rs index 499eddafc1f..0641c842390 100644 --- a/crates/router/src/core/payment_methods/cards.rs +++ b/crates/router/src/core/payment_methods/cards.rs @@ -3993,16 +3993,6 @@ pub async fn delete_payment_method( ...
2024-06-11T08:57:32Z
## Description Previously we did not support the deletion of the Default Payment Method, if it's the only PM for the particular customer. In this PR we enable deletion of default Payment Methods ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, p...
b705757be37a9803b964ef94d04c664c0f1e102d
- Create a MA and a MCA - Do a payment , with `setup_future_usag:off_session`; the card would be saved - Do a List PM for Customers, you'll have only one card , which has been set as default ``` Response { "customer_payment_methods": [ { "payment_token": "token_FC8TupTKMEmhtM69dmYS", ...
[ "crates/router/src/core/payment_methods/cards.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4938
Bug: [FEATURE] Add support for gauge metrics and include IMC metrics Add support for gauge metrics. Additionally also add a background thread, which will be spawned during application startup, that runs for every fixed interval (configurable) of time, collecting the metrics. For now this collector can collect the ga...
diff --git a/config/config.example.toml b/config/config.example.toml index f4a6a66cd61..81516ee8b6b 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -112,6 +112,7 @@ otel_exporter_otlp_endpoint = "http://localhost:4317" # endpoint to send metrics otel_exporter_otlp_timeout = 5000 ...
2024-06-10T18:02:28Z
## Description <!-- Describe your changes in detail --> This PR adds support for gauge metrics. Additionally the pr also adds a background thread, which will be spawned during application startup, that runs for every fixed interval (configurable) of time, collecting the metrics. For now this collector collects the g...
b705757be37a9803b964ef94d04c664c0f1e102d
Hit list payment methods for a merchant endpoint and check for `router_CACHE_ENTRY_COUNT` metric in grafana ![image](https://github.com/juspay/hyperswitch/assets/70657455/7b08c4e5-d7f8-433e-8561-6bdefef039dc)
[ "config/config.example.toml", "config/deployments/env_specific.toml", "config/development.toml", "config/docker_compose.toml", "crates/router/src/bin/router.rs", "crates/router/src/routes/metrics.rs", "crates/router/src/routes/metrics/bg_metrics_collector.rs", "crates/router_env/src/logger/config.rs",...
juspay/hyperswitch
juspay__hyperswitch-4934
Bug: [BUG] 5xx is thrown when invalid certificate and private key is configured in MCA for Netcetera ### Bug Description 5xx is thrown during authentication call when invalid certificate and private key is configured in MCA for Netcetera ### Expected Behavior 4xx should be thrown when invalid certificate or priva...
diff --git a/crates/router/src/core/admin.rs b/crates/router/src/core/admin.rs index f9da9908d95..fc83573e21d 100644 --- a/crates/router/src/core/admin.rs +++ b/crates/router/src/core/admin.rs @@ -858,27 +858,7 @@ pub async fn create_payment_connector( expected_format: "auth_type and api_key".to_string(), ...
2024-06-10T11:13:12Z
## Description <!-- Describe your changes in detail --> Wrote a validation function to validate ConnectorAuthType being passed during MCA create and update. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If...
7085a46271791ca3f1c7b86afa7c8b199b93c0cd
Manual. 1. SignatureKey ``` curl --location 'http://localhost:8080/account/postman_merchant_GHAction_3589e3c3-2b53-4627-b0f9-8449b37a9c07/connectors' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data '{ "connector_type": "fiz_operat...
[ "crates/router/src/core/admin.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4931
Bug: [CHORE] : update apple pay metadata fields ### Feature Description Currently apple pay iOS Certificate flow contains seven fields, in addition to that three more fields needs to be added. ### Possible Implementation update the wasm to accept the fields ### Have you spent some time checking if this feat...
diff --git a/crates/connector_configs/toml/development.toml b/crates/connector_configs/toml/development.toml index 246eb566a91..5d4aea5d5dd 100644 --- a/crates/connector_configs/toml/development.toml +++ b/crates/connector_configs/toml/development.toml @@ -244,6 +244,7 @@ merchant_identifier="Apple Merchant Identifier"...
2024-06-10T10:39:57Z
## Description <!-- Describe your changes in detail --> update apple pay metadata <img width="574" alt="image" src="https://github.com/juspay/hyperswitch/assets/120017870/7ac299bf-99e7-4cfb-b0f4-224a028d3406"> <img width="557" alt="image" src="https://github.com/juspay/hyperswitch/assets/120017870/a5d5826a-7865-44...
7085a46271791ca3f1c7b86afa7c8b199b93c0cd
[ "crates/connector_configs/toml/development.toml", "crates/connector_configs/toml/production.toml", "crates/connector_configs/toml/sandbox.toml" ]
juspay/hyperswitch
juspay__hyperswitch-4929
Bug: [BUG] [CRYPTOPAY] Amount conversion to lower unit causing parsing error ### Bug Description The conversion of a f64 base amount to i64 minor amount is causing parsing error in cryptopay. This needs to be fixed by using decimal type instead of f64. ### Expected Behavior The conversion of a f64 base amount to ...
diff --git a/crates/router/src/connector/cryptopay.rs b/crates/router/src/connector/cryptopay.rs index f7d137eff20..a3e0844842c 100644 --- a/crates/router/src/connector/cryptopay.rs +++ b/crates/router/src/connector/cryptopay.rs @@ -1,13 +1,12 @@ pub mod transformers; -use std::fmt::Debug; - use base64::Engine; us...
2024-06-10T09:46:16Z
## Description <!-- Describe your changes in detail --> The conversion of a f64 base amount to i64 minor amount is causing parsing error in cryptopay. This needs to be fixed by using decimal type instead of f64. Also this Pr adds amount conversion framework to Cryptopay Note: Cryptopay uses String Major Unit ![...
7085a46271791ca3f1c7b86afa7c8b199b93c0cd
We need to test Cryptopay payments for various different amounts. Request: ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data-raw '{ "amount": 115, "currency": "USD", ...
[ "crates/router/src/connector/cryptopay.rs", "crates/router/src/connector/cryptopay/transformers.rs", "crates/router/src/types/api.rs", "crates/router/tests/connectors/cryptopay.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4924
Bug: Add `is_connector_agnostic_mit_enabled` in the business profile APIs `is_connector_agnostic_mit_enabled` this filed is used to make connector agnostic MIT payments. If set to `true` the recurring payments (MIT) can be routed to any other connector which supports network transaction id flow. If it `false` the su...
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index 58cb6fbf3e2..bd569b1febb 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -938,6 +938,12 @@ pub struct BusinessProfileCreate { /// A boolean value to indicate if customer shipping details needs t...
2024-06-10T07:21:03Z
## Description <!-- Describe your changes in detail --> `is_connector_agnostic_mit_enabled` this field is used to make connector agnostic MIT payments. If set to `true` the recurring payments (MIT) can be routed to any other connector which supports network transaction id flow. If it `false` the subsequent MITs need...
ff93981ec776031af1de946cd6e9f90d2f410cd2
-> Create a merchant account -> Create a business profile under the above merchant account ``` curl --location 'http://localhost:8080/account/merchant_1718004259/business_profile' \ --header 'Content-Type: application/json' \ --header 'api-key: test_admin' \ --data '{ "profile_name": "Pg_agnostic_mit", ...
[ "crates/api_models/src/admin.rs", "crates/diesel_models/src/business_profile.rs", "crates/router/src/core/admin.rs", "crates/router/src/core/routing/helpers.rs", "crates/router/src/types/api/admin.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4914
Bug: fix(payments): populate payments method data in list Populate payment method data in payments list to get details of card network.
diff --git a/crates/router/src/core/payments/transformers.rs b/crates/router/src/core/payments/transformers.rs index 49319dff3a2..abc1bdd0a1c 100644 --- a/crates/router/src/core/payments/transformers.rs +++ b/crates/router/src/core/payments/transformers.rs @@ -966,6 +966,15 @@ impl ForeignFrom<(storage::PaymentIntent, ...
2024-06-07T13:24:40Z
## Description Populate payment method data in payments list to get card network details. ## Motivation and Context Closes [#4914](https://github.com/juspay/hyperswitch/issues/4914) #
d784fcb5e65060eb35424448b4762f09f83d532b
Tested with curl for payments list ``` curl --location 'http://localhost:8080/payments/list' \ --header 'Content-Type: application/json' \ --header 'Cookie: token=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJ1c2VyX2lkIjoiMWZjNzgyOTUtM2JiMy00OGJjLThlZDgtNzFjMzVjMzMxYWU2IiwibWVyY2hhbnRfaWQiOiJtZXJjaGFudF8xNjk3NzE2ODcwIiwi...
[ "crates/router/src/core/payments/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4475
Bug: Add tenant_id as a field for data pipeline 1. Add `Tenant_id` as a field for all logs 2. Add `Tenant_id` action for Kafka messages as well , headers to be a combination of ( tenant_id, merchant_id, payment_id ) 3. Make logical databases and physical tables in clickhouse for different tenants
diff --git a/crates/router/src/db/kafka_store.rs b/crates/router/src/db/kafka_store.rs index c360b41a6cf..0545191318d 100644 --- a/crates/router/src/db/kafka_store.rs +++ b/crates/router/src/db/kafka_store.rs @@ -1109,9 +1109,8 @@ impl QueueInterface for KafkaStore { entry_id: &RedisEntryId, fields: V...
2024-06-07T12:32:22Z
## Description <!-- Describe your changes in detail --> As part of multitenancy feature, we added tenant prefix in the redisinterface directly. so this specific handling of tenant id in append_stream function is not required anymore ## Motivation and Context <!-- Why is this change required? What problem does ...
d0fd7095cd4a433aa7eb51258303ef45008e28de
1. Make a payment and see if the entries are added in process tracker 2. Check if the analytics for the payment is visible from the dashboard
[ "crates/router/src/db/kafka_store.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4675
Bug: Add audit events for PaymentCapture update
diff --git a/crates/router/src/core/payments/operations/payment_capture.rs b/crates/router/src/core/payments/operations/payment_capture.rs index 447f7b92906..02c69681a88 100644 --- a/crates/router/src/core/payments/operations/payment_capture.rs +++ b/crates/router/src/core/payments/operations/payment_capture.rs @@ -12,...
2024-06-07T11:15:30Z
## Description <!-- Describe your changes in detail --> Added an event each time a payment capture happens with the relevant contextual info - Pass along request_state to payment_core - Modify the UpdateTracker trait to accept request state - Modify the PaymentCapture implementation of UpdateTracker to generate...
2119de9c1e6b1293a1eeff04010942895d7d5d4e
- Implemented an event trigger that activates whenever the payment capture API is utilized. This event triggers an audit event, the details of which are subsequently reflected in the Kafka UI. - Create a payment & then capture it. - Fields that need to be tested are: `capture_amount`, `multiple_capture_count` and `...
[ "crates/router/src/core/payments/operations/payment_capture.rs", "crates/router/src/events/audit_events.rs", "crates/router/src/services/api.rs" ]
juspay/hyperswitch
juspay__hyperswitch-5237
Bug: [FEAT] add key in keymanager [FEAT] add key in keymanager
diff --git a/config/config.example.toml b/config/config.example.toml index e4a15e7fb12..5a734237513 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -28,6 +28,10 @@ certificate = "/path/to/certificate.pem" idle_pool_connection_timeout = 90 # Timeout for idle pool connections (defaults to 90s...
2024-06-07T09:50:00Z
## Description <!-- Describe your changes in detail --> This PR adds support to - Create Key for every User and Merchant during User and Merchant Account Create. - Add an API to transfer Keys to KeyManager - Add MTLS for KeyManager Client ## Motivation and Context <!-- Why is this change required? What pr...
998ce02ebc1eed10e426987d1af9c02d1f1735fe
### Tests for Create a Merchant - ```bash curl --location 'http://localhost:8080/accounts' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data-raw '{ "merchant_id": "merchant_1720435957", "locker_id": "m0010", "merchant_name": "N...
[ "config/config.example.toml", "config/deployments/env_specific.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/admin.rs", "crates/api_models/src/events.rs", "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/common_utils/Cargo.toml...
juspay/hyperswitch
juspay__hyperswitch-5292
Bug: [REFACTOR] List the Payment Methods Based on the Connector Type ### Feature Description List the Payment Methods Based on the Connector Type being Payment Processor ### Possible Implementation List the Payment Methods Based on the Connector Type being Payment Processor ### Have you spent some time checking...
2024-06-07T09:14:30Z
## Description List the Payment Methods for Merchant , based on the connector type, to differentiate between Payments and Payouts Processors ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have...
37e34e3bfde9281b3a69b0769c901a887dcf400f
- Create a MA - Create two MCA , one with the `connector_type : "payment_processor"` other with the connector type as `payout_processor` - Create a payment - Do a list of Pms for the Merchant Account, BOA would not be here as its connector_type is `payout_processor`, cause here only the PMs with `payment_processor...
[]
juspay/hyperswitch
juspay__hyperswitch-4901
Bug: refactor(user): Make password nullable for `users` Currently `password` is required field in `users` table. This is causing us to create temporary passwords for `users` in some APIs which inserts `users` without password. So, we have to make password nullable to solve this.
diff --git a/crates/diesel_models/src/schema.rs b/crates/diesel_models/src/schema.rs index 15e662fe438..a7d5a8c02bc 100644 --- a/crates/diesel_models/src/schema.rs +++ b/crates/diesel_models/src/schema.rs @@ -1223,7 +1223,7 @@ diesel::table! { #[max_length = 255] name -> Varchar, #[max_length...
2024-06-06T14:12:11Z
## Description <!-- Describe your changes in detail --> This API will make the password column in the `users` table nullable. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd re...
2f12cca7ae5a4875b50ca5ff5068500b5004eb6f
1. Create user with `connect_account` API ``` curl --location 'http://localhost:8080/user/connect_account' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "unregistered email" }' ``` 2. Invite a unregistered user ``` curl --location 'http://localhost:8080/user/user/invite...
[ "crates/diesel_models/src/schema.rs", "crates/diesel_models/src/user.rs", "crates/router/src/core/user.rs", "crates/router/src/db/user.rs", "crates/router/src/types/domain/user.rs", "migrations/2024-06-06-101812_user_optional_password/down.sql", "migrations/2024-06-06-101812_user_optional_password/up.sq...
juspay/hyperswitch
juspay__hyperswitch-4899
Bug: [BUG] : [BOA/CYBS] make AVS code optional ### Bug Description AVS code is mandatory, but in some cases it is not sent ### Expected Behavior AVS code must be optional ### Actual Behavior Incases where, AVS code is not sent results in a de serialization error ### Steps To Reproduce Provide an unambiguous ...
diff --git a/crates/router/src/connector/bankofamerica/transformers.rs b/crates/router/src/connector/bankofamerica/transformers.rs index 7446749e73c..edff5c251a5 100644 --- a/crates/router/src/connector/bankofamerica/transformers.rs +++ b/crates/router/src/connector/bankofamerica/transformers.rs @@ -835,7 +835,7 @@ pub...
2024-06-06T10:39:31Z
## Description <!-- Describe your changes in detail --> Make AVS code optional #
9903119e8b1f2c08ee99e630c1c64cdeb7c34df4
1. Do a non 3ds payment - Sanity ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_K5SsEmIckmis20oeONswdh8Cu58ZuXrNLCLIzyXNhhJLiHeeo600vhMovaKi81F0' \ --data-raw '{ "amount": 10000000, "curren...
[ "crates/router/src/connector/bankofamerica/transformers.rs", "crates/router/src/connector/cybersource/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4896
Bug: ci(postman): add test collection for users Add testcases to test - Singnin flow - Singup flow (magic account) Also include token only cases for sign in signup.
diff --git a/Cargo.lock b/Cargo.lock index 228414c0194..77f9b33ddc4 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -7021,6 +7021,7 @@ dependencies = [ name = "test_utils" version = "0.1.0" dependencies = [ + "anyhow", "async-trait", "base64 0.22.0", "clap", diff --git a/crates/test_utils/Cargo.toml b/crates/test_...
2024-06-06T09:29:26Z
## Description Added test for: **Health check** Health Check: expects 200 Ok Flow Check **Signup** Connect account - checks for 200 Ok, content type application/json, response has json body and is_email sent is true **SignIn** 1. SignIn with correct password: checks for 200 Ok, content type applicatio...
ff93981ec776031af1de946cd6e9f90d2f410cd2
Use command to test user module: ``` cargo run --bin test_utils -- --module-name="users" --base-url="http://localhost:8080" --admin-api-key="admin_api_key" ``` ![Screenshot 2024-06-07 at 2 42 51 PM](https://github.com/juspay/hyperswitch/assets/64925866/89e23626-a167-484d-bbb8-e99b83dfd5d3) ![Screenshot 2024-06-07 ...
[ "Cargo.lock", "crates/test_utils/Cargo.toml", "crates/test_utils/src/connector_auth.rs", "crates/test_utils/src/main.rs", "crates/test_utils/src/newman_runner.rs", "postman/collection-dir/users/.event.meta.json", "postman/collection-dir/users/.info.json", "postman/collection-dir/users/.meta.json", "...
juspay/hyperswitch
juspay__hyperswitch-4893
Bug: Add `collect_shipping_details_from_wallet_connector` in the business profile response Add `collect_shipping_details_from_wallet_connector` in the business profile response
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index dc64947bf08..58cb6fbf3e2 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -936,7 +936,7 @@ pub struct BusinessProfileCreate { /// Whether to use the billing details passed when creating the intent ...
2024-06-05T13:36:45Z
## Description <!-- Describe your changes in detail --> add `collect_shipping_details_from_wallet_connector` in the business profile ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, ...
c5e28f2670d51bf6529eb729167c97ad301217ef
-> Create merchant account -> update the business profile with the below curl ``` curl --location 'http://localhost:8080/account/merchant_1717593917/business_profile/pro_eqCDCAfX7AA2WudlMDYP' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --...
[ "crates/api_models/src/admin.rs", "crates/router/src/types/api/admin.rs", "openapi/openapi_spec.json" ]
juspay/hyperswitch
juspay__hyperswitch-4889
Bug: feat(connector): [DATATRANS] add Connector Template Code
diff --git a/config/config.example.toml b/config/config.example.toml index 81516ee8b6b..7372f93044c 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -186,6 +186,7 @@ checkout.base_url = "https://api.sandbox.checkout.com/" coinbase.base_url = "https://api.commerce.coinbase.com" cryptopay.bas...
2024-06-05T13:30:31Z
## Description <!-- Describe your changes in detail --> Added Template code for Datatrans. Ran add_connector.sh script ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend...
0e059e7d847b0c15ed120c72bb4902ac60e6f955
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/enums.rs", "crates/common_enums/src/enums.rs", "crates/router/src/configs...
juspay/hyperswitch
juspay__hyperswitch-4887
Bug: bug(user): Wrong Internal user `org_id` Currently when an internal user is being created, a new user will be created and a `user_role` with `merchant_id` as `juspay000` will also be inserted. As the merchant `juspay000` already has a `org_id`, we should use that and insert that `org_id` in `user_role`, but cur...
diff --git a/crates/router/src/core/user.rs b/crates/router/src/core/user.rs index cfc01afb91b..65d605b3862 100644 --- a/crates/router/src/core/user.rs +++ b/crates/router/src/core/user.rs @@ -1046,11 +1046,6 @@ pub async fn create_internal_user( state: SessionState, request: user_api::CreateInternalUserReque...
2024-06-05T11:40:33Z
## Description <!-- Describe your changes in detail --> Internal signup will now use the `org_id` of `juspay000` and insert it in `user_roles`. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have...
7ab65ac8834f47c4448b64899ce3e3656132fb63
``` curl --location 'http://localhost:8080/user/internal_signup' \ --header 'api-key: admin-api-key' \ --header 'Content-Type: application/json' \ --data-raw '{ "name" : "name", "email" : "email", "password": "password" }' ``` In `user_roles` table, the `org_id` is the correct one as the `jusp...
[ "crates/router/src/core/user.rs", "crates/router/src/types/domain/user.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4881
Bug: FRM Analytics Add FRM analytics and corresponding endpoints
diff --git a/Cargo.lock b/Cargo.lock index 557504d98b9..cfd0da1eed2 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -340,6 +340,7 @@ dependencies = [ "aws-sdk-lambda", "aws-smithy-types 1.1.8", "bigdecimal", + "common_enums", "common_utils", "diesel_models", "error-stack", @@ -1943,6 +1944,8 @@ name = "common_e...
2024-06-05T06:39:40Z
## Description <!-- Describe your changes in detail --> Added frm dashboard metrics and filters. Filters based on: - frm_status - frm_name - frm_transaction_type Metrics calculated: - frm_triggered_attempts - frm_blocked_rate ## Motivation and Context <!-- Why is this change required? What problem does ...
7004a802de2d30b97ecd37f57ba0e9c3aa962993
Below is the collection for testing : [frms.postman_collection.json](https://github.com/user-attachments/files/15897457/frms.postman_collection.json) Tested using local data by sending cURL requests through Postman. <img width="1287" alt="Screenshot 2024-06-05 at 11 57 32 AM" src="https://github.com/juspay/hyper...
[ "Cargo.lock", "config/config.example.toml", "config/development.toml", "config/docker_compose.toml", "crates/analytics/Cargo.toml", "crates/analytics/docs/clickhouse/scripts/fraud_check.sql", "crates/analytics/src/clickhouse.rs", "crates/analytics/src/core.rs", "crates/analytics/src/frm.rs", "crat...
juspay/hyperswitch
juspay__hyperswitch-4589
Bug: [Feature] Add a cargo binary for running diesel migrations locally ### Objective Add a new binary in the `router` crate that would run migrations locally via cli i.e `cargo run migrations`. ### Context Currently migrations are managed via the diesel_cli which rely on explicitly providing the database usern...
diff --git a/Cargo.lock b/Cargo.lock index 1d6d0fc7511..8249ae4f70b 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -384,12 +384,55 @@ version = "0.1.6" source = "registry+https://github.com/rust-lang/crates.io-index" checksum = "4b46cbb362ab8752921c97e041f5e366ee6297bd428a31275b9fcf1e380f7299" +[[package]] +name = "an...
2024-06-04T20:18:52Z
## Description This PR closes #4589 Created a new Rust binary in the `crates` directory which automates the Diesel migrations with Postgres. The new tool is a CLI tool that takes a path to a TOML file as an argument along with the name of a TOML table to extract Postgres database credentials from. The tool then aut...
2d31d38c1e35be99e9b0297b197bab81fa5f5030
We wrote two units test on the core functionality. We tested it both on a dummy TOML file as well as in Hyperswitch repository. We were able to set up Hyperswitch locally using `hsdev` instead of `diesel_cli`.
[ "Cargo.lock", "crates/hsdev/Cargo.toml", "crates/hsdev/README.md", "crates/hsdev/src/input_file.rs", "crates/hsdev/src/main.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4472
Bug: [FEATURE] Add support for sending additional metadata in the `MessagingInterface` ### Feature Description In the current implementation of message interface I can only send a Message & a timestamp associated with the message, There is no accomodation to send additional metadata about the message which isn't p...
diff --git a/crates/events/src/lib.rs b/crates/events/src/lib.rs index 0136b64a0f6..cef0c8894de 100644 --- a/crates/events/src/lib.rs +++ b/crates/events/src/lib.rs @@ -49,6 +49,11 @@ pub trait Event: EventInfo { /// The class/type of the event. This is used to group/categorize events together. fn class(&se...
2024-06-04T14:21:27Z
## Description <!-- Describe your changes in detail --> - Allow setting kafka headers in message ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one fir...
a2ea0ed19c075fb0e23b16ddc24b5230dc70369b
<img width="1597" alt="image" src="https://github.com/juspay/hyperswitch/assets/21202349/67529c15-c762-465d-a02a-fab090676c3a">
[ "crates/events/src/lib.rs", "crates/router/src/events.rs", "crates/router/src/events/event_logger.rs", "crates/router/src/middleware.rs", "crates/router/src/services/kafka.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4869
Bug: [BUG] Paypal payment experience ### Bug Description Paypal payment experience is getting duplicated <img width="1721" alt="image" src="https://github.com/juspay/hyperswitch/assets/120017870/ec53d1fd-596c-4be3-90c3-3c0f0c06dc50"> ### Expected Behavior Paypal payment experience shouldn't get duplicated ###...
diff --git a/crates/connector_configs/src/transformer.rs b/crates/connector_configs/src/transformer.rs index 87d1e3e810b..976068c98b6 100644 --- a/crates/connector_configs/src/transformer.rs +++ b/crates/connector_configs/src/transformer.rs @@ -71,24 +71,27 @@ impl DashboardRequestPayload { api_models::enu...
2024-06-04T12:22:52Z
## Description <!-- Describe your changes in detail --> <img width="1382" alt="image" src="https://github.com/juspay/hyperswitch/assets/120017870/28dcf3da-317f-4e40-b91f-0197d0db3410"> ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please l...
1d36798399c118f7cb7af93935123634e1afd6a0
[ "crates/connector_configs/src/transformer.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4521
Bug: [REFACTOR] Update AnalyticsPool to hold variables for tenant ID Update the [AnalyticsProvider](https://github.com/juspay/hyperswitch/blob/be44447c09ea8814dc8b88aa971e08cc749db5f3/crates/analytics/src/lib.rs#L67-L72) (or [`AnalyticsConfig`](https://github.com/juspay/hyperswitch/blob/be44447c09ea8814dc8b88aa971e...
diff --git a/config/config.example.toml b/config/config.example.toml index 81516ee8b6b..30f33430378 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -639,6 +639,7 @@ sdk_eligible_payment_methods = "card" [multitenancy] enabled = false +global_tenant = { schema = "public", redis_key_prefix...
2024-06-04T11:18:49Z
## Description <!-- Describe your changes in detail --> Add Tenant_id as a field for all logs Add Tenant_id action for Kafka messages as well , headers to be a combination of ( tenant_id, merchant_id, payment_id ) Make logical databases and physical tables in clickhouse for different tenants ## Motivation and ...
18493bd8f03b933b15bc3c40b3501222587fc59f
Since there is no new changes involved, sanity testing is enough, Check if the payments are going fine and able to see analytics in dashboard
[ "config/config.example.toml", "config/deployments/env_specific.toml", "config/development.toml", "config/docker_compose.toml", "crates/analytics/src/clickhouse.rs", "crates/analytics/src/lib.rs", "crates/common_utils/src/consts.rs", "crates/diesel_models/src/query/user.rs", "crates/drainer/src/setti...
juspay/hyperswitch
juspay__hyperswitch-4860
Bug: [BUG] Avoid overrides in auto generated OpenAPI specification ### Bug Description If there are types defined with duplicate names, the entry which is specified at the end overrides any previous entries with the same name. This is identified for payments and payouts - Card struct. This is being overriden for pa...
diff --git a/crates/api_models/src/payouts.rs b/crates/api_models/src/payouts.rs index 69c50da79c2..2df40bd6757 100644 --- a/crates/api_models/src/payouts.rs +++ b/crates/api_models/src/payouts.rs @@ -153,19 +153,19 @@ pub struct PayoutCreateRequest { #[derive(Debug, Clone, Deserialize, Serialize, ToSchema)] #[serde(...
2024-06-04T06:12:38Z
## Description Fixes https://github.com/juspay/hyperswitch/issues/4860 ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus o...
e9be4e22411d218009e6cd6c1a5ef9dc8fc430b7
[ "crates/api_models/src/payouts.rs", "crates/openapi/src/openapi.rs", "crates/router/src/connector/utils.rs", "crates/router/src/types/api/payouts.rs", "openapi/openapi_spec.json" ]
juspay/hyperswitch
juspay__hyperswitch-4805
Bug: Refactor Customers Payment Method List to support Client as well as S2S calls ### Feature Description For Payment Methods v2, the customers payment method list will be supporting client based as well as S2S calls. We are moving it under two distinct endpoints. ### Possible Implementation The customers...
diff --git a/crates/api_models/Cargo.toml b/crates/api_models/Cargo.toml index f829d2e48fe..e2b9e2d3a55 100644 --- a/crates/api_models/Cargo.toml +++ b/crates/api_models/Cargo.toml @@ -24,6 +24,7 @@ customer_v2 = [] merchant_account_v2 = [] merchant_connector_account_v2 = [] payment_v2 = [] +payment_methods_v2 = [] ...
2024-06-03T13:32:14Z
## Description <!-- Describe your changes in detail --> Refactored customer's pml for v2 The customers Payment method list will be moved under two distinct endpoints: For Client (with payment tokens) - /payments/:id:/saved_payment_methods For Server (without payment token) - /customers/:cust_id:/saved...
537630f00482939d4c0b49c643dee3763fe0e046
- Save a card - Create another payment ``` curl --location --request POST 'http://localhost:8080/v2/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_cHN6hMdCFUUrNWjYSxnwhiuMsg83rXTX9jBmtHmCL6sq9a43PswY304MSt3a9blR' \ --data-raw '{ "amoun...
[ "crates/api_models/Cargo.toml", "crates/api_models/src/events/payment.rs", "crates/api_models/src/payment_methods.rs", "crates/router/Cargo.toml", "crates/router/src/compatibility/stripe/customers/types.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payment_methods/surch...
juspay/hyperswitch
juspay__hyperswitch-4848
Bug: refactor: Home and Sign out API changes for 2FA Phase - II As we are having the reset TOTP and regenerate recovery codes flows in the Phase - II, we need to let FE know whether the user has completed the 2FA or not and also number of recovery codes left for the user, so that FE can show a warning if there are l...
diff --git a/crates/api_models/src/user.rs b/crates/api_models/src/user.rs index ee9498cfeee..a61b9fd7dff 100644 --- a/crates/api_models/src/user.rs +++ b/crates/api_models/src/user.rs @@ -165,7 +165,10 @@ pub struct GetUserDetailsResponse { #[serde(skip_serializing)] pub user_id: String, pub org_id: Str...
2024-06-03T10:06:39Z
## Description <!-- Describe your changes in detail --> After this PR, Home API will send the details about the user's 2FA, specifically weather user has completed 2FA setup and number of recovery codes left for him. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it...
15d6c3e846a77dec6b6a5165d86044a9b9fd52f1
1. Home API ``` curl --location 'http://localhost:8080/user' \ --header 'Authorization: Bearer Login Token' ``` ```json { "merchant_id": "company_name", "name": "name", "email": "email", "verification_days_left": null, "role_id": "org_admin", "org_id": "org_lbZlm2cx4...
[ "crates/api_models/src/user.rs", "crates/router/src/core/user.rs", "crates/router/src/utils/user/two_factor_auth.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4850
Bug: [REFACTOR] use `const` instead of `String` for `business_status` As of now, we've around `9` distinct values for `process_tracker` and all these values are hard coded as Strings in various places. This makes it harder for us to keep track of the values that exist in the code base. As a measure to tack...
diff --git a/crates/diesel_models/src/process_tracker.rs b/crates/diesel_models/src/process_tracker.rs index cd0dbed2c64..135c8e2b055 100644 --- a/crates/diesel_models/src/process_tracker.rs +++ b/crates/diesel_models/src/process_tracker.rs @@ -76,8 +76,6 @@ impl ProcessTrackerNew { where T: Serialize + s...
2024-06-03T09:31:02Z
## Description <!-- Describe your changes in detail --> When below command is executed in sandbox DB, we get a set of "distinct" `business_status`es that is specified for process tracker: ```sql SELECT DISTINCT(business_status) FROM process_tracker; ``` For debugging and fun, execute to learn more about pr...
2852a3ba156e3e2bd89d0a116990134268e7bee8
This should not require any testing as the change done is here just a mere replacement of hardcoded string with `const`s. If needed, the changes can be verified by following #3712's instructions. Reproduced below: Perform PSync call from connector like `Checkout`. Payment Status should go to `processing` state. ...
[ "crates/diesel_models/src/process_tracker.rs", "crates/router/src/bin/scheduler.rs", "crates/router/src/core/api_keys.rs", "crates/router/src/core/payment_methods/vault.rs", "crates/router/src/core/refunds.rs", "crates/router/src/core/webhooks/outgoing.rs", "crates/router/src/db/kafka_store.rs", "crat...
juspay/hyperswitch
juspay__hyperswitch-4840
Bug: [FEATURE] [AUTHORIZEDOTNET] Support payment_method_id in recurring mandate payment ### Feature Description Support `payment_method_id` in recurring mandate payment for connector Authorizedotnet. ### Possible Implementation Support `payment_method_id` in recurring mandate payment for connector Authorizedotnet...
diff --git a/crates/router/src/connector/authorizedotnet/transformers.rs b/crates/router/src/connector/authorizedotnet/transformers.rs index b281d0a0a77..15aedad7599 100644 --- a/crates/router/src/connector/authorizedotnet/transformers.rs +++ b/crates/router/src/connector/authorizedotnet/transformers.rs @@ -1,16 +1,15 ...
2024-05-31T12:00:38Z
## Description <!-- Describe your changes in detail --> Support `payment_method_id` in recurring mandate payment for connector Authorizedotnet. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have...
865007717c5c7e617ca1b447ea5f9bb3d274cac3
- Payment Intent Create (Zero): Request: ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_8aib7npeItergz3tpMqm1iqsMXrAdiw8VjVdjiVUWLMUSRWR34DrRDGJPmy2mcMm' \ --data '{ "amount": 0, "currency...
[ "crates/router/src/connector/authorizedotnet/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4829
Bug: feat: Add new auth type to allow both SPTs and Login Tokens for 2FA APIs The following APIs are needed in both with Sign In and in the dashboard. - `/2fa/totp/verify` - `/2fa/recovery_code/verify` - `/2fa/recovery_code/generate` Currently these APIs use SPT as auth, which makes them unable to access using Logi...
diff --git a/crates/router/src/consts/user.rs b/crates/router/src/consts/user.rs index c7615aa4be4..331c256e8a4 100644 --- a/crates/router/src/consts/user.rs +++ b/crates/router/src/consts/user.rs @@ -18,4 +18,4 @@ pub const MIN_PASSWORD_LENGTH: usize = 8; pub const REDIS_TOTP_PREFIX: &str = "TOTP_"; pub const REDIS_...
2024-05-30T14:55:01Z
## Description <!-- Describe your changes in detail --> This PR adds new auth type `SinglePurposeOrLoginTokenAuth`, which will allow both SPTs and Login Tokens to be used as auth token for APIs. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, ...
ba0a1e95b72c0acf5bde81d424aa8fe220c40a22
1. Verify TOTP ``` curl --location 'http://localhost:8080/user/2fa/totp/verify' \ --header 'Content-Type: application/json' \ --header 'Authorization: Bearer SPT with purpose as TOTP' \ --data '{ "totp": "597760" }' ``` ``` curl --location 'http://localhost:8080/user/2fa/totp/verify' \ --hea...
[ "crates/router/src/consts/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/user.rs", "crates/router/src/services/authentication.rs", "crates/router/src/services/authentication/blacklist.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4834
Bug: [BUG] 5xx during External Authentication through Netcetera Fails ### Bug Description In some very rare scenarios, when external authentication fails from netcetera, hyperswitch throws 5xx because of error message deserialization error. The error object returned by netcetera is inconsistent with their offic...
diff --git a/crates/router/src/connector/netcetera.rs b/crates/router/src/connector/netcetera.rs index 43df87db40f..714873cfb53 100644 --- a/crates/router/src/connector/netcetera.rs +++ b/crates/router/src/connector/netcetera.rs @@ -107,7 +107,7 @@ impl ConnectorCommon for Netcetera { status_code: res.stat...
2024-05-30T13:18:32Z
## Description <!-- Describe your changes in detail --> Few fields in netcetera error object that were marked required in the official api documentation were missing in api response body. This caused deserialization failure at hyperswitch. So made those fields optional. ## Motivation and Context <!-- Why...
21a3a2ea8ada838c67b0e5871f01d09bd5a8b9ed
Manual. Tested sanity of Netcetera Authentication Connector.
[ "crates/router/src/connector/netcetera.rs", "crates/router/src/connector/netcetera/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4820
Bug: feat(users): add endpoint to reset totp Add support to reset TOTP from dashboard!
diff --git a/crates/router/src/core/user.rs b/crates/router/src/core/user.rs index 7b6e8ebd365..9931d450ab9 100644 --- a/crates/router/src/core/user.rs +++ b/crates/router/src/core/user.rs @@ -1634,7 +1634,39 @@ pub async fn begin_totp( let totp = tfa_utils::generate_default_totp(user_from_db.get_email(), None)?...
2024-05-30T08:43:41Z
## Description Add support to reset TOTP ## Motivation and Context Closes [#4820](https://github.com/juspay/hyperswitch/issues/4820) #
bed42ce4be901f2b8f46033dd395dee8dbe807c9
Use the curl to reset TOTP when it is already setup (from inside dashboard): ``` curl --location 'http://localhost:8080/user/2fa/totp/reset' \ --header 'Authorization: Bearer JWT' \ --header 'Cookie: Cookie_1=value' ``` Response: ``` { "secret": { "secret": "VERUDBNHLYZDGFTKNXY2VVP4EQ5GOBUB", ...
[ "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "crates/router_env/src/logger/types.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4883
Bug: [FEATURE] Add Moka Cache instead of Static Cache for 3DS Decision Manager and Surcharge Configs ### Feature Description Add Moka Cache instead of Static Cache for 3DS Decision Manager and Surcharge Configs ### Possible Implementation Add Moka Cache instead of Static Cache for 3DS Decision Manager and Surch...
diff --git a/crates/euclid/src/backend/vir_interpreter.rs b/crates/euclid/src/backend/vir_interpreter.rs index b7be62cf674..b8d14e228aa 100644 --- a/crates/euclid/src/backend/vir_interpreter.rs +++ b/crates/euclid/src/backend/vir_interpreter.rs @@ -1,5 +1,9 @@ pub mod types; +use std::fmt::Debug; + +use serde::{Dese...
2024-05-29T11:36:14Z
## Description refactor conditional_configs to use Moka Cache instead of Static Cache ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the ...
05105321caceb14f99f0ec0f8ccefd9db9b02bb6
Cannot be tested
[ "crates/euclid/src/backend/vir_interpreter.rs", "crates/euclid/src/frontend/vir.rs", "crates/euclid/src/types.rs", "crates/router/src/core/conditional_config.rs", "crates/router/src/core/payment_methods/surcharge_decision_configs.rs", "crates/router/src/core/payments/conditional_configs.rs", "crates/rou...
juspay/hyperswitch
juspay__hyperswitch-4812
Bug: [CHORE] : [Paypal] Add session_token flow for Paypal sdk and update the wasm ### Feature Description - Change payment_experience for paypal via paypal to sdk - update the wasm ### Possible Implementation - update wasm config for paypal https://github.com/juspay/hyperswitch/pull/4697 ### Have you s...
diff --git a/crates/connector_configs/src/transformer.rs b/crates/connector_configs/src/transformer.rs index 94cc06786aa..87d1e3e810b 100644 --- a/crates/connector_configs/src/transformer.rs +++ b/crates/connector_configs/src/transformer.rs @@ -63,6 +63,36 @@ impl DashboardRequestPayload { }, } ...
2024-05-29T11:14:21Z
## Description <!-- Describe your changes in detail --> Allow Paypal Wallet to have both payment_experiences RedirectToUrl and InvokeSdkClient <img width="952" alt="image" src="https://github.com/juspay/hyperswitch/assets/120017870/f7eb2488-bbe2-4e50-bfbd-1d7e3b1dc6ca"> Dashboard Request Payload <img width="137...
7888dd48b2f3da7d3f867369331accee624f2b39
[ "crates/connector_configs/src/transformer.rs", "crates/connector_configs/toml/development.toml", "crates/connector_configs/toml/sandbox.toml" ]
juspay/hyperswitch
juspay__hyperswitch-4809
Bug: feat(users): add support to check 2FA status Add support to check whether the 2FA has been done recently or not. ( For now it will check for last five minutes) Use case: The api will help to check for when was last TOTP done, if user has recently done sign in and trying to do some operation that asks for TOTP...
diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs index a472b3a76e6..c41f52a93ea 100644 --- a/crates/api_models/src/events/user.rs +++ b/crates/api_models/src/events/user.rs @@ -16,8 +16,9 @@ use crate::user::{ GetUserRoleDetailsResponse, InviteUserRequest, ListUsersResponse,...
2024-05-29T11:10:35Z
## Description The api checks whether the 2FA has been done recently or not. It just checks the status in Redis and gives the response. ## Motivation and Context Closes [#4809](https://github.com/juspay/hyperswitch/issues/4809) #
cd9c9b609c8d5d7c77658d973f7922ae71af9a4d
Use the curl to get the status ``` curl --location 'http://localhost:8080/user/2fa' \ --header 'Authorization: Bearer JWT' \ --header 'Cookie: Cookie_1=value' ``` Response will be something like ``` { "totp": true, "recovery_code": false } ```
[ "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "crates/router_env/src/logger/types.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4808
Bug: [BUG] Fixing 3DS payment failure in headless mode ### Bug Description 3DS payments were failing in the refund test in Cypress headless mode. I added the timeout and properly configured the hooks to fetch the redirection URL correctly. ### Expected Behavior It should pass in headless mode ### Actual Behavio...
2024-05-29T10:09:01Z
## Description 3DS payments were failing in the refund test in Cypress headless mode. I added the timeout and properly configured the hooks to fetch the redirection URL correctly. ## Motivation and Context To ensure the test runs successfully without any failures in the CI/CD pipeline. #
b812e596a1bef4cc154f5b925753ad158c9022de
Tested locally in the headless mode Stripe <img width="843" alt="Screenshot 2024-05-29 at 1 41 57 PM" src="https://github.com/juspay/hyperswitch/assets/118818938/b5737099-bf5c-4408-b598-77185c257411"> Cybersource <img width="898" alt="Screenshot 2024-05-29 at 2 45 53 PM" src="https://github.com/juspay/hyp...
[]
juspay/hyperswitch
juspay__hyperswitch-4797
Bug: [Kafka] - Consolidate payment logs into a single topic for sessionizing Consolidate intent, attempt, dispute, refund events into a single topic `hyperswitch-consolidated-events` for sessionizer to consume #### Initial log structure ```json { "log": { "merchant_id": "test", "payment_id": "p1", "at...
diff --git a/config/config.example.toml b/config/config.example.toml index 5433d7a8e46..5d40d0e55ef 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -263,8 +263,7 @@ stripe = { banks = "alior_bank,bank_millennium,bank_nowy_bfg_sa,bank_pekao_sa,ba # This data is used to call respective conn...
2024-05-28T14:10:35Z
## Description - add consolidated payment events to a single topic for sessionizing - add millisecond precision to timestamp fields ## Motivation and Context [#4797](https://github.com/juspay/hyperswitch/issues/4797) #
865007717c5c7e617ca1b447ea5f9bb3d274cac3
- Create payment, refund, dispute - check `topic: hyperswitch-consolidated-events` for combined logs for above events ![Screenshot 2024-05-28 at 7 43 24 PM](https://github.com/juspay/hyperswitch/assets/138492857/9cb3bf17-a0aa-4ce0-9a41-30bde996c3ef) ![Screenshot 2024-05-28 at 7 44 04 PM](https://github.com/juspay/hy...
[ "config/config.example.toml", "config/deployments/env_specific.toml", "config/development.toml", "config/docker_compose.toml", "crates/router/src/events.rs", "crates/router/src/services/kafka.rs", "crates/router/src/services/kafka/dispute_event.rs", "crates/router/src/services/kafka/payment_attempt_ev...
juspay/hyperswitch
juspay__hyperswitch-4796
Bug: [FIX] implement `StrongEq` for `StrongSecre<Vec<u8>>`
diff --git a/crates/masking/src/strong_secret.rs b/crates/masking/src/strong_secret.rs index fd1335f6993..51c0f2cb3fe 100644 --- a/crates/masking/src/strong_secret.rs +++ b/crates/masking/src/strong_secret.rs @@ -117,3 +117,12 @@ impl StrongEq for String { bool::from(lhs.ct_eq(rhs)) } } + +impl StrongEq ...
2024-05-28T14:04:33Z
## Description <!-- Describe your changes in detail --> Implement `StrongEq` for `Vec<u8>` ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so t...
84e032e6c28afc410c82e73e51deb629b0c4a81a
NA. Testing is not needed, compiler guided.
[ "crates/masking/src/strong_secret.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4793
Bug: Filter the apple pay retryable connectors for a specific business profile Currently while fetching the apple pay retry connector list all the enabled merchant connector accounts for that specific merchant id is included. But we need to retry the connector with only the connectors in that specific profile id wit...
diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs index 7bc0b532239..b64e7479c4d 100644 --- a/crates/router/src/core/payments.rs +++ b/crates/router/src/core/payments.rs @@ -3165,11 +3165,11 @@ where routing_data.business_sub_label = choice.sub_label.clone(); ...
2024-05-28T13:56:51Z
## Description <!-- Describe your changes in detail --> Currently while fetching the apple pay retry connector list all the enabled merchant connector accounts for that specific merchant id is included. But we need to retry the connector with only the connectors in that specific profile id with which the payment att...
865007717c5c7e617ca1b447ea5f9bb3d274cac3
-> Create merchant connector accounts with apple pay simplified configured for some of them. -> Use the below curl to set the default connectors ``` curl --location 'https://sandbox.hyperswitch.io/routing/default/profile/pro_SIWKUcl7KWmcoRroVz1r' \ --header 'Content-Type: application/json' \ --header 'Authorizat...
[ "crates/router/src/core/payments.rs", "crates/router/src/core/payments/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4816
Bug: Code changes to get the certificates from the certificates column with fallback The migration api can be run on the deployment environment only after the 100% deployment of the specific version of hyperswitch, because there are probabilities of merchant account being created even during the deployments. Once de...
diff --git a/crates/api_models/src/apple_pay_certificates_migration.rs b/crates/api_models/src/apple_pay_certificates_migration.rs new file mode 100644 index 00000000000..796734f53e4 --- /dev/null +++ b/crates/api_models/src/apple_pay_certificates_migration.rs @@ -0,0 +1,12 @@ +#[derive(Debug, Clone, serde::Serialize)]...
2024-05-28T13:19:09Z
## Description <!-- Describe your changes in detail --> Currently apple pay related details are being stored in the connector metadata, as in future we are going to add apple pay decrypted flow support for ios app we will be collecting the apple pay payment processing certificates as well. As this ppc and ppc key ne...
d242850b63173f314fb259451139464f09e0a9e9
-> Apple pay certificate migration api ``` curl --location 'http://localhost:8080/apple_pay_certificates_migration' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data '{ "merchant_ids": ["merchant_1713176513", "merchant_1714122879"] ...
[ "crates/api_models/src/apple_pay_certificates_migration.rs", "crates/api_models/src/events.rs", "crates/api_models/src/events/apple_pay_certificates_migration.rs", "crates/api_models/src/lib.rs", "crates/api_models/src/payments.rs", "crates/common_enums/src/enums.rs", "crates/common_utils/src/events.rs"...
juspay/hyperswitch
juspay__hyperswitch-4791
Bug: Add a column (connector_wallets_details) in merchant connector account and develop an api (migrate cert) to store the encrypted certificates in the added column. Currently apple pay related details are being stored in the connector metadata, as in future we are going to add apple pay decrypted flow support for...
diff --git a/crates/api_models/src/apple_pay_certificates_migration.rs b/crates/api_models/src/apple_pay_certificates_migration.rs new file mode 100644 index 00000000000..796734f53e4 --- /dev/null +++ b/crates/api_models/src/apple_pay_certificates_migration.rs @@ -0,0 +1,12 @@ +#[derive(Debug, Clone, serde::Serialize)]...
2024-05-28T13:19:09Z
## Description <!-- Describe your changes in detail --> Currently apple pay related details are being stored in the connector metadata, as in future we are going to add apple pay decrypted flow support for ios app we will be collecting the apple pay payment processing certificates as well. As this ppc and ppc key ne...
d242850b63173f314fb259451139464f09e0a9e9
-> Apple pay certificate migration api ``` curl --location 'http://localhost:8080/apple_pay_certificates_migration' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data '{ "merchant_ids": ["merchant_1713176513", "merchant_1714122879"] ...
[ "crates/api_models/src/apple_pay_certificates_migration.rs", "crates/api_models/src/events.rs", "crates/api_models/src/events/apple_pay_certificates_migration.rs", "crates/api_models/src/lib.rs", "crates/api_models/src/payments.rs", "crates/common_enums/src/enums.rs", "crates/common_utils/src/events.rs"...
juspay/hyperswitch
juspay__hyperswitch-4783
Bug: [REFACTOR] retrieve extended card info config during business profile get call During business profile get call, send the extended card info config of merchant in the response so that dashboard can make use of it
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index 12d9832ada6..dc64947bf08 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -1010,6 +1010,9 @@ pub struct BusinessProfileResponse { // Whether to use the billing details passed when creating the in...
2024-05-28T07:55:13Z
## Description <!-- Describe your changes in detail --> During business profile get call, send the extended card info config of merchant (public key and ttl) in the response so that dashboard can make use of it ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes...
c9fa94febe7a1fcd24e8d723d14b78f8a73da0e3
1. Create merchant account (get default profile_id) 2. Create api key 3. Use update endpoint of business profile to pass config. ``` curl --location 'http://localhost:8080/account/merchant_1716883344/business_profile/pro_5PdcjX4zYfC8X2PFjCel' \ --header 'Content-Type: application/json' \ --header 'Accept: appli...
[ "crates/api_models/src/admin.rs", "crates/router/src/types/api/admin.rs", "openapi/openapi_spec.json" ]
juspay/hyperswitch
juspay__hyperswitch-4778
Bug: [FEATURE] [CRYPTOPAY] Pass network details in payment request ### Feature Description The customer should be able to choose the supported network in case of doing cryptocurrency payments via Cryptopay. ### Possible Implementation The supported networks will be shown on SDK and the chosen network will be pas...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index cd405e3ca98..fe46d342161 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -2118,6 +2118,7 @@ pub struct SepaAndBacsBillingDetails { #[serde(rename_all = "snake_case")] pub struct CryptoDat...
2024-05-27T11:46:13Z
## Description <!-- Describe your changes in detail --> The customer will be able to choose the supported network in case of doing cryptocurrency payments via Cryptopay. The supported networks will be shown on SDK and the chosen network will be passed on to Cryptopay. If no network is chosen then Cryptopay will c...
7645edfa2e00500da3f8f117cc1a485fe1f41ab5
Payments Request: ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data-raw '{ "amount": 120, "currency": "USD", "confirm": true, "email": "guest@example.com", "r...
[ "crates/api_models/src/payments.rs", "crates/hyperswitch_domain_models/src/payment_method_data.rs", "crates/router/src/configs/defaults.rs", "crates/router/src/connector/cryptopay/transformers.rs", "crates/router/tests/connectors/bitpay.rs", "crates/router/tests/connectors/coinbase.rs", "crates/router/t...
juspay/hyperswitch
juspay__hyperswitch-4775
Bug: fix: Ability to change TOTP issuer name depending on the env As of now, the issuer name in TOTP is always "Hyperswitch" independent of env. As TOTP will be present in multiple environments, we need to have different issuer names for all the environments, so that user can easily identify the TOTP.
diff --git a/config/config.example.toml b/config/config.example.toml index 8aa0ca9e52f..ac428298e73 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -351,8 +351,9 @@ email_role_arn = "" # The amazon resource name ( arn ) of the role which sts_role_session_name = "" # An identifier for...
2024-05-27T09:50:23Z
## Description <!-- Describe your changes in detail --> This PR adds configs for TOTP Issuer (to easily change issuer name of TOTP) ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, w...
15d6c3e846a77dec6b6a5165d86044a9b9fd52f1
``` curl --location 'http://localhost:8080/user/2fa/totp/begin' \ --header 'Authorization: Bearer SPT with Purpose as TOTP' \ ``` ``` { "secret": { "secret": "INY6LEAFGX3OWJFVBXBUM7OMH4KLNI76", "totp_url": "otpauth://totp/Hyper:mani.dchandra%40juspay.in?secret=INY6LEAFGX3OWJFVBXBUM7OMH4K...
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/router/src/configs/settings.rs", "crates/router/src/consts/user.rs", "crates/router/src/...
juspay/hyperswitch
juspay__hyperswitch-4059
Bug: [REFACTOR]: [Fiserv] Remove Default Case Handling ### :memo: Feature Description - We utilize match statements to make pivotal decisions, such as generating requests based on the payment method type and managing responses received from the connector. - These conditions generally go hand in hand with enum ...
diff --git a/crates/router/src/connector/fiserv/transformers.rs b/crates/router/src/connector/fiserv/transformers.rs index 2dedb92d1dd..8945f7814b2 100644 --- a/crates/router/src/connector/fiserv/transformers.rs +++ b/crates/router/src/connector/fiserv/transformers.rs @@ -386,7 +386,7 @@ impl<F, T> TryFrom<types::Respo...
2024-05-26T16:39:04Z
## Description <!-- Describe your changes in detail --> This PR closes #4059 removes the default case handling in `hyperswitch/crates/router/src/connector/fiserv/transformer.rs`. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to...
b847606d665388fba898425b31dd5f207f60a56e
No testing required
[ "crates/router/src/connector/fiserv/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4764
Bug: feat: Use redis in Begin and Verify TOTP - Currently begin TOTP is directly replacing the secret in the db. This will cause issues when user didn't complete generating recovery codes. So we should keep the new secret in redis temporarily. - And Verify TOTP should not complete the TOTP flow as user should comple...
diff --git a/crates/api_models/src/user.rs b/crates/api_models/src/user.rs index 5423fc830a5..0c8678d2ef8 100644 --- a/crates/api_models/src/user.rs +++ b/crates/api_models/src/user.rs @@ -255,12 +255,11 @@ pub struct BeginTotpResponse { pub struct TotpSecret { pub secret: Secret<String>, pub totp_url: Secre...
2024-05-24T12:57:30Z
## Description <!-- Describe your changes in detail --> - Begin TOTP will now insert the TOTP secret in redis instead of DB directly, which allows the old secret to stay if it exists and recovery codes are also removed from Begin TOTP. - Verify TOTP will now send 200 OK and puts the timestamp in the redis when the ...
d686ec7acda6ce852fac8d7413f9ba903adcee1d
1. TOTP Routes 1. Begin TOTP ```curl curl --location 'http://localhost:8080/user/2fa/totp/begin' \ --header 'Authorization: Bearer SPT with Purpose as TOTP' ``` ``` { "secret": { "secret": "Q54GEKFSVTP4FU3YHDFMEN5KMGD2P3IN", "totp_url": "otpauth://totp/Hyperswitch:mani...
[ "crates/api_models/src/user.rs", "crates/router/src/consts/user.rs", "crates/router/src/core/errors/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "crates/router/src/utils/user.rs", "crates/...
juspay/hyperswitch
juspay__hyperswitch-4673
Bug: Add audit events for PaymentConfirm update
diff --git a/config/development.toml b/config/development.toml index 25fe55e6057..78b10192f1e 100644 --- a/config/development.toml +++ b/config/development.toml @@ -634,4 +634,4 @@ sdk_eligible_payment_methods = "card" enabled = false [multitenancy.tenants] -public = { name = "hyperswitch", base_url = "http://local...
2024-05-24T11:57:10Z
## Description - Pass along request_state to payment_core - Update `updatetrackers` trait to accept request state - Update the paymentconfirm implementation of updatetracker to generate an event ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issu...
ba0a1e95b72c0acf5bde81d424aa8fe220c40a22
### Test Case Description - Implemented an event trigger that activates whenever the payment confirm API is utilized. This event triggers an audit event, the details of which are subsequently reflected in the Kafka UI. - Create a payment & then confirm it - Fields that need to be tested are: `client_src`, `client_v...
[ "config/development.toml", "crates/router/src/core/payments/operations/payment_confirm.rs", "crates/router/src/events/audit_events.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4824
Bug: [BUG] FIx routing field validation in payments request ### Feature Description As of now, routing field in the payments request wasn't being validated, have to add validations for the same ### Possible Implementation Jus have to add validations in payments create, update and confirm ### Have you spent some ...
diff --git a/crates/router/src/core/payments/operations/payment_confirm.rs b/crates/router/src/core/payments/operations/payment_confirm.rs index a3ed16def0c..b8b3ea3a971 100644 --- a/crates/router/src/core/payments/operations/payment_confirm.rs +++ b/crates/router/src/core/payments/operations/payment_confirm.rs @@ -133...
2024-05-24T11:54:21Z
## Description <!-- Describe your changes in detail --> Added validation for straight through routing in payments request ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd reco...
e41d5e25dfd4d3113edac11b249e847f8718b263
1. By using invalid req body for `routing` field (4xx should be thrown instead of 5xx) ``` curl --location --request POST 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_wnIRnsZGiq0NHNq3WskWv4Kw7Eg7InEHASiXrAXA4zM2MoJMvL2...
[ "crates/router/src/core/payments/operations/payment_confirm.rs", "crates/router/src/core/payments/operations/payment_create.rs", "crates/router/src/core/payments/operations/payment_update.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4703
Bug: [FEATURE] [AUTHORIZEDOTNET] Implement non-zero mandates ### Feature Description Non-zero dollar mandates need to be implemented for connector Authorizedotnet. ### Possible Implementation Non-zero dollar mandates need to be implemented for connector Authorizedotnet. ### Have you spent some time checking if t...
diff --git a/crates/router/src/connector/authorizedotnet.rs b/crates/router/src/connector/authorizedotnet.rs index a9e000b82b9..8d0c1db37a2 100644 --- a/crates/router/src/connector/authorizedotnet.rs +++ b/crates/router/src/connector/authorizedotnet.rs @@ -79,6 +79,16 @@ impl ConnectorValidation for Authorizedotnet { ...
2024-05-24T09:28:49Z
## Description <!-- Describe your changes in detail --> Non-zero dollar mandates are implemented for connector Authorizedotnet. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd ...
8d9c7bc45ce2515759b9e2a36eb2d8a8a2c813ad
- Payment Intent Create (Non-Zero Mandate): Request: ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data-raw '{ "amount": 370, "currency": "USD", "confirm": false, ...
[ "crates/router/src/connector/authorizedotnet.rs", "crates/router/src/connector/authorizedotnet/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4757
Bug: [FIX] Fix the functionality to show both the disabled and enabled connectors while List Merchant Connector Account ### Feature Description Fix the functionality to show both the disabled and enabled connectors while List Merchant Connector Account ### Possible Implementation Fix the functionality to show bot...
diff --git a/crates/diesel_models/src/query/merchant_connector_account.rs b/crates/diesel_models/src/query/merchant_connector_account.rs index cc73bd7a532..bd24d12ec22 100644 --- a/crates/diesel_models/src/query/merchant_connector_account.rs +++ b/crates/diesel_models/src/query/merchant_connector_account.rs @@ -124,9 +...
2024-05-24T08:36:45Z
## Description revert the filter for getting the mcas which are disabled, and explicitly get the Mca that are disabled ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommen...
55ccce61898083992afeab03ba1690954b1b45ef
- All the MCA's either disabled/enabled will show in the LIST MCAs ``` Response [ { "connector_type": "fiz_operations", "connector_name": "cybersource", "connector_label": "cybersource_US_default_2", "merchant_connector_id": "mca_JfI8xFhxTnL5q2bFhpUW", "profile_i...
[ "crates/diesel_models/src/query/merchant_connector_account.rs", "crates/router/src/core/payment_methods/cards.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4752
Bug: mask the email address being logged in the payment_method_list response logs As of now the payment method list response logs contains the email address, this needs to be mased <img width="1448" alt="image" src="https://github.com/juspay/hyperswitch/assets/83439957/4c219a49-13d3-4fa1-804a-21c215aa5675">
diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs index dd7791ee2d2..5a19a225dee 100644 --- a/crates/api_models/src/payment_methods.rs +++ b/crates/api_models/src/payment_methods.rs @@ -531,7 +531,8 @@ pub struct RequiredFieldInfo { #[schema(value_type = FieldType)] ...
2024-05-23T14:07:07Z
## Description <!-- Describe your changes in detail --> https://github.com/juspay/hyperswitch/pull/4749 This pr is to mask the email address being logged in the payment method list response. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, ple...
f79c12d4f78ac622300e56f7159ca72d65a4ac0d
-> Create a merchant account and mca -> Create a payment with confirm false ``` curl --location 'http://localhost:8080/account/payment_methods?client_secret=pay_jviyQiUsX9uHI99VXUlF_secret_lHrA6q5GKvNvd5a0blUQ' \ --header 'Accept: application/json' \ --header 'api-key: pk_dev_df002da8beb74682ac3e8677a4b82217' `...
[ "crates/api_models/src/payment_methods.rs", "crates/router/src/core/payment_methods/cards.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4751
Bug: mask the email address being logged in the payment_method_list response logs As of now the payment method list response logs contains the email address, this needs to be mased <img width="1448" alt="image" src="https://github.com/juspay/hyperswitch/assets/83439957/4c219a49-13d3-4fa1-804a-21c215aa5675">
diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs index d26a2deac18..d63d2b085b6 100644 --- a/crates/api_models/src/payment_methods.rs +++ b/crates/api_models/src/payment_methods.rs @@ -531,7 +531,8 @@ pub struct RequiredFieldInfo { #[schema(value_type = FieldType)] ...
2024-05-23T13:36:58Z
## Description <!-- Describe your changes in detail --> This pr is to mask the email address being logged in the payment method list response. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't hav...
42e5ef155128f4df717e8fb101da6e6929659a0a
-> Create a merchant account and mca -> Create a payment with confirm false ``` curl --location 'http://localhost:8080/account/payment_methods?client_secret=pay_jviyQiUsX9uHI99VXUlF_secret_lHrA6q5GKvNvd5a0blUQ' \ --header 'Accept: application/json' \ --header 'api-key: pk_dev_df002da8beb74682ac3e8677a4b82217' `...
[ "crates/api_models/src/payment_methods.rs", "crates/router/src/core/payment_methods/cards.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4748
Bug: log and ignore the apple pay metadata parsing error while fetching apple pay retry connectors For a merchant account there are be n number of connectors and its not mandatory that apple pay needs to be enabled for all of them. So while fetching apple pay retry connectors log the error if the apple pay metadata ...
diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs index a6befa5269e..f760e907288 100644 --- a/crates/router/src/core/payments.rs +++ b/crates/router/src/core/payments.rs @@ -3163,8 +3163,14 @@ where routing_data.business_sub_label = choice.sub_label.clone(); ...
2024-05-23T11:15:20Z
## Description <!-- Describe your changes in detail --> For a merchant account there are be n number of connectors and its not mandatory that apple pay needs to be enabled for all of them. So while fetching apple pay retry connectors log the error if the apple pay metadata parsing fails. This is required as this wil...
ae77373b4cac63979673fdac37c55986d954358e
-> Create a merchant account -> Enable gcm for the `merchant_id` ``` curl --location 'localhost:8080/configs/' \ --header 'api-key: test_admin' \ --header 'Content-Type: application/json' \ --data '{ "key": "should_call_gsm_{merchant_id}", "value": "true" }' ``` -> Set the maximum retries count ``...
[ "crates/router/src/core/payments.rs", "crates/router/src/core/payments/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4742
Bug: [BUG] Failing unit tests for routing and constraint graph ### Bug Description Certain unit tests in the `euclid` and `kgraph_utils` crates are failing. **euclid** ``` FAIL [ 0.032s] euclid frontend::dir::test::test_consistent_dir_key_naming ``` **kgraph_utils** ``` FAIL [ 0.037s] kgraph_utils ...
diff --git a/crates/euclid/src/frontend/dir.rs b/crates/euclid/src/frontend/dir.rs index bc16057fbb5..f2b9ab99049 100644 --- a/crates/euclid/src/frontend/dir.rs +++ b/crates/euclid/src/frontend/dir.rs @@ -809,6 +809,10 @@ mod test { let mut key_names: FxHashMap<DirKeyKind, String> = FxHashMap::default(); ...
2024-05-23T08:01:10Z
## Description <!-- Describe your changes in detail --> This PR fixes a couple of failing unit tests in the `euclid` and `kgraph_utils` crates. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have...
ba624d049840f65fc21a5e578f8d4ba8543e1420
Running unit tests locally. API Tests not required <img width="674" alt="image" src="https://github.com/juspay/hyperswitch/assets/47862918/babeb68b-2e8c-4b9e-925c-08c6ff55a9a9"> <img width="762" alt="image" src="https://github.com/juspay/hyperswitch/assets/47862918/a99b2bc7-57e2-45d6-a8af-754f0da52cbb">
[ "crates/euclid/src/frontend/dir.rs", "crates/kgraph_utils/src/mca.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4740
Bug: Setup for Data services locally targeting clickhouse/ kafka and the relevant features on dashboard
diff --git a/README.md b/README.md index 5bfcfdfd62b..62e016d3620 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ The single API to access payment ecosystems across 130+ countries</div> <p align="center"> <a href="#%EF%B8%8F-quick-start-guide">Quick Start Guide</a> • - <a href="https://github.com/juspay...
2024-05-23T07:33:28Z
## Description <!-- Describe your changes in detail --> Fixes #4740 - Update `docker-compose.yml` profiles to unfiy them - Add steps in `try_local_system.md` to setup data services - Add additional documentation in `analytics` crate to enable features in `control-center` - update architecture diagram to inclu...
13f6efc7e8c01b4a377f627b9cfe2319b518204d
- Don't need to test since doc changes only
[ "README.md", "config/dashboard.toml", "crates/analytics/docs/README.md", "crates/analytics/docs/clickhouse/README.md", "docker-compose.yml" ]
juspay/hyperswitch
juspay__hyperswitch-4736
Bug: feat: add support to verify using recovery code Create a new endpoint that adds, - support to verify 2FA with recovery code - the provided recovery code can be used only once - then verification can be done with the remaining recovery codes only next time ( there are total 8 set of recovery codes that are bein...
diff --git a/config/config.example.toml b/config/config.example.toml index 5d575b5ba09..d5bdfb5a6a7 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -351,7 +351,8 @@ email_role_arn = "" # The amazon resource name ( arn ) of the role which sts_role_session_name = "" # An identifier for...
2024-05-22T19:54:33Z
## Description The PR adds support to verify 2FA using recovery code, in case TOTP is lost ## Motivation and Context Closes [#4736](https://github.com/juspay/hyperswitch/issues/4736) #
42e5ef155128f4df717e8fb101da6e6929659a0a
First Sign in for user for which 2FA is already set. Then to verify 2FA: Use the below curl to test it ``` curl --location 'http://localhost:8080/user/recovery_code/verify' \ --header 'Content-Type: application/json' \ --header 'Authorization: Bearer SPT' \ --header 'Cookie: Cookie_1=value' \ --data '{ "...
[ "config/config.example.toml", "config/deployments/integration_test.toml", "config/deployments/production.toml", "config/deployments/sandbox.toml", "config/development.toml", "config/docker_compose.toml", "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/router/src/conf...
juspay/hyperswitch
juspay__hyperswitch-4734
Bug: [BUG] Decrypt the card without having locker as a fallback ### Feature Description Decrypt the card without having locker as a fallback ### Possible Implementation Decrypt the card without having locker as a fallback ### Have you spent some time checking if this feature request has been raised before? - ...
diff --git a/crates/router/src/core/payments/operations/payment_confirm.rs b/crates/router/src/core/payments/operations/payment_confirm.rs index 8dbef81b906..a3ed16def0c 100644 --- a/crates/router/src/core/payments/operations/payment_confirm.rs +++ b/crates/router/src/core/payments/operations/payment_confirm.rs @@ -3,7...
2024-05-22T16:43:57Z
## Description The token based MIT payments were throwing a 5xx , as this [PR](https://github.com/juspay/hyperswitch/pull/4711) called locker every time as a fallback while trying to decrypt the card . This PR fixes the failing token based MIT payments ## Motivation and Context <!-- Why is this change require...
d942a31d60595d366977746be7215620da0ababd
-Create a MA and a MCA - Create a off_session payment , with google pay token - Create another recurring payment via google pay > ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_QEGuyQGnDNOXysqCH4yETB...
[ "crates/router/src/core/payments/operations/payment_confirm.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4733
Bug: [Refactor] Use recurring enabled flag to decide which payment method supports MIT ### Feature Description Use recurring enabled flag to decide which payment method supports MIT ### Possible Implementation Use recurring enabled flag to decide which payment method supports MIT ### Have you spent some time c...
diff --git a/crates/diesel_models/src/query/merchant_connector_account.rs b/crates/diesel_models/src/query/merchant_connector_account.rs index bd24d12ec22..cc73bd7a532 100644 --- a/crates/diesel_models/src/query/merchant_connector_account.rs +++ b/crates/diesel_models/src/query/merchant_connector_account.rs @@ -124,7 +...
2024-05-22T14:10:18Z
## Description use recurring enabled flag in the lIst Customer Payment Method to decide which payment method supports MIT. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd reco...
8afeda54fc5e3f3d510c48c81c222387e9cacc0e
- Create a MA and a MCA with 2 connectors , cybersource and stripe - Create a mandate payment with one card , lets say using stripe - create a mandate payment with some pm, let's say wallet with the connector cybersource - list the payment methods for the customer, the card which has mandate enabled will have the re...
[ "crates/diesel_models/src/query/merchant_connector_account.rs", "crates/router/src/core/payment_methods/cards.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4730
Bug: refactor: Separate out totp completion from verify Currently,`verify_totp` is the terminating 2fa API and also it was setting the TOTP status as "SET". So , we want to separate the logic of terminating the 2FA to a separate API so that the job of the `verify_totp` API will only be to verify if the totp is val...
diff --git a/crates/api_models/src/user.rs b/crates/api_models/src/user.rs index 7864117856e..6b2748ca344 100644 --- a/crates/api_models/src/user.rs +++ b/crates/api_models/src/user.rs @@ -224,6 +224,11 @@ pub struct TokenOnlyQueryParam { pub token_only: Option<bool>, } +#[derive(Debug, serde::Deserialize, serd...
2024-05-22T12:38:12Z
## Description Currently completion of 2fa and setting the status of the 2fa status as "SET" is handled by `verify_totp` API. We want to remove this from `verify_totp`, so this PR creates a new API to terminate the 2fa flow. ## Motivation and Context This will close the issue #4730 #
8afeda54fc5e3f3d510c48c81c222387e9cacc0e
This can only be tested locally as it requires some changes in the redis. 1. terminate 2fa without skip_two_factor_auth query param a. If the keys with `TOTP_{user_id}` or `RC_{user_id}` is not present in redis Request ``` curl --location 'http://localhost:8080/user/2fa/terminate' \ --header 'Authoriz...
[ "crates/api_models/src/user.rs", "crates/router/src/consts/user.rs", "crates/router/src/core/errors/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "crates/router/src/types/domain/user.rs", "...
juspay/hyperswitch
juspay__hyperswitch-4729
Bug: [FEATURE] [Iatapay] add upi qr support ### Feature Description Add support for Upi QR code through Iatapay ### Possible Implementation 1. Add a upi intent payment id 2. Add a upi_qr payment data type 3. Do necessary contract changes ### Have you spent some time checking if this feature request has been...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index 5f9618738b2..cd405e3ca98 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -1664,7 +1664,10 @@ impl GetPaymentMethodType for CryptoData { impl GetPaymentMethodType for UpiData { fn ge...
2024-05-22T10:09:28Z
## Description <!-- Describe your changes in detail --> This PR introduces a new payment_method_type: `upi_intent` and a new payment_method_data: `upi_qr: {}` along with iatapay qr code implementation. #
b3d4d13db81143cf663142d8bd8fdf95b0882b3f
_Note:Test through stripe compatibility layer_ 1. Create a upi qr payment ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_ZLiIlOCsh5GUTiRJCCSc6lOIXpo0tTGuROyxvZokpKSIl5Lh5mCYwBB9IZV3Jno2' \ --data-r...
[ "crates/api_models/src/payments.rs", "crates/common_enums/src/enums.rs", "crates/common_enums/src/transformers.rs", "crates/euclid/src/frontend/dir/enums.rs", "crates/euclid/src/frontend/dir/lowering.rs", "crates/euclid/src/frontend/dir/transformers.rs", "crates/hyperswitch_domain_models/src/payment_met...
juspay/hyperswitch
juspay__hyperswitch-4722
Bug: Enable auto-retries for apple pay Currently for apple pay pre-routing is done before the session call and a connector is decided based on the routing logic. Because of this we are not able retry the failed apple pay payments. As the certificates use in the simplified flows are same across the connectors the ...
diff --git a/crates/router/src/core/payments.rs b/crates/router/src/core/payments.rs index 175400c54bf..9b2082cf31f 100644 --- a/crates/router/src/core/payments.rs +++ b/crates/router/src/core/payments.rs @@ -3170,6 +3170,28 @@ where { routing_data.business_sub_label = choice.sub_label.clo...
2024-05-21T15:54:52Z
## Description <!-- Describe your changes in detail --> Currently for apple pay pre-routing is done before the session call and a connector is decided based on the routing logic. Because of this we are not able retry the failed apple pay payments. As the certificates use in the simplified flows are same across th...
8afeda54fc5e3f3d510c48c81c222387e9cacc0e
-> Create a merchant account -> Enable gcm for the `merchant_id` ``` curl --location 'localhost:8080/configs/' \ --header 'api-key: test_admin' \ --header 'Content-Type: application/json' \ --data '{ "key": "should_call_gsm_{merchant_id}", "value": "true" }' ``` -> Set the maximum retries count ``...
[ "crates/router/src/core/payments.rs", "crates/router/src/core/payments/flows/session_flow.rs", "crates/router/src/core/payments/helpers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4719
Bug: [ENHANCEMENT] Make `redis_interface` crate agnostic of `router_env` dependencies
diff --git a/Cargo.lock b/Cargo.lock index d5dc4e2ee9f..e6278079b20 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -5365,11 +5365,11 @@ dependencies = [ "error-stack", "fred", "futures 0.3.30", - "router_env", "serde", "thiserror", "tokio 1.37.0", "tokio-stream", + "tracing", ] [[package]] diff --git a/C...
2024-05-21T12:10:21Z
…ndency for redis_interface ## Description This PR removes `router_env` as a dependency of `redis_interface` crate. To accomplish this we declare `tracing` as a workspace dependency and use that individually in `redis_interface` and `router_env`. <!-- Describe your changes in detail --> ## Motivation an...
2e79ee0615292182111586fda7655dd9a796ef4f
This is dependency relocation, no domain logic or framework code was changed
[ "Cargo.lock", "Cargo.toml", "crates/redis_interface/Cargo.toml", "crates/redis_interface/src/commands.rs", "crates/redis_interface/src/lib.rs", "crates/router_env/Cargo.toml" ]
juspay/hyperswitch
juspay__hyperswitch-4718
Bug: [BUG] handle empty string updated_by for soft kill kv ### Bug Description some entries for payment attempt is inserted with '' value in db, in which case we are not sure where the data is present ### Expected Behavior handle these cases in the safest way by having a lookup in redis and deciding the storage s...
diff --git a/crates/storage_impl/src/redis/kv_store.rs b/crates/storage_impl/src/redis/kv_store.rs index 9c429058b70..c39e67eb841 100644 --- a/crates/storage_impl/src/redis/kv_store.rs +++ b/crates/storage_impl/src/redis/kv_store.rs @@ -249,7 +249,9 @@ impl<'a> std::fmt::Display for Op<'a> { match self { ...
2024-05-21T11:59:24Z
## Description <!-- Describe your changes in detail --> there are some entries created with updated_by as '' for payment_attempt, which is causing decide storage scheme to select the configured scheme which is an issue during soft kill with configured scheme as redis_kv as we want db entities to be processed in db ...
2e79ee0615292182111586fda7655dd9a796ef4f
[ "crates/storage_impl/src/redis/kv_store.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4724
Bug: [FEATURE] Add support for external 3ds authentication in cybersource. ### Feature Description Currenctly hyperswitch supports 3ds authenticated payments through cybersource. But we cannot complete 3ds authentication through a separate authentication provider(eg: netcetera). and then do payment authorization th...
diff --git a/crates/api_models/src/enums.rs b/crates/api_models/src/enums.rs index 59a85841212..4d5b709bba3 100644 --- a/crates/api_models/src/enums.rs +++ b/crates/api_models/src/enums.rs @@ -244,10 +244,9 @@ impl Connector { | Self::Riskified | Self::Threedsecureio | Self::Netce...
2024-05-21T11:09:06Z
## Description <!-- Describe your changes in detail --> add support for external authentication for cybersource. After this change is merged, we'll be able to authenticate a payment through an external 3ds authentication(threedsecureio or netcetera) and authorise the same payment through cybersource. Other ch...
dd333298f8b4e8ff3c15fc79fbc528a61fa1b63f
Ran cybersource postman collection to make sure existing 3ds flow is not affected. <img width="785" alt="Screenshot 2024-05-23 at 1 00 07 PM" src="https://github.com/juspay/hyperswitch/assets/61539176/c210e8ce-1864-444d-8f81-2ef3a7133160"> curls: 1. Create a cybersource connector and netcetera authentication con...
[ "crates/api_models/src/enums.rs", "crates/diesel_models/src/authentication.rs", "crates/diesel_models/src/schema.rs", "crates/hyperswitch_domain_models/src/router_request_types.rs", "crates/hyperswitch_domain_models/src/router_response_types.rs", "crates/router/src/connector/checkout/transformers.rs", "...
juspay/hyperswitch
juspay__hyperswitch-4712
Bug: [Refcator] Refactor Payment Response to show the Payment Method Data ### Feature Description Refactor Payment Response to show the Payment Method Data after a recurring payment using payment token ### Possible Implementation Refactor Payment Response to show the Payment Method Data after a recurring payment...
diff --git a/crates/router/src/core/payments/operations/payment_confirm.rs b/crates/router/src/core/payments/operations/payment_confirm.rs index 7d1858bd0d7..6cbdb86a750 100644 --- a/crates/router/src/core/payments/operations/payment_confirm.rs +++ b/crates/router/src/core/payments/operations/payment_confirm.rs @@ -1,6...
2024-05-21T08:22:32Z
## Description add support to enable pm_data and pm_id in payments response ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can f...
44681ab058f081a5621ba147d5491111cfbc55bc
- Create a MA and a MCA - Create a Off session payment with Customer Acceptance > ``` Create curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_Mg6I2ovVxNBp6ZJmf84J2CPS3aDBtKeara9bYS08ep8h8PknW2S8yiprQGw...
[ "crates/router/src/core/payments/operations/payment_confirm.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4706
Bug: [bug]: fix timestamp sent to kafka events rdkafka library expects time in millis but we send seconds. This can be reflected in the kafka-ui at localhost:8090 as well. We can fix this by either truncating the unix_timestamp_nanos or padding the seconds.
diff --git a/crates/router/src/services/kafka.rs b/crates/router/src/services/kafka.rs index 58657c59fd8..6f2aa9fcd10 100644 --- a/crates/router/src/services/kafka.rs +++ b/crates/router/src/services/kafka.rs @@ -259,7 +259,7 @@ impl KafkaProducer { .timestamp( event ...
2024-05-20T14:16:14Z
## Description <!-- Describe your changes in detail --> fixes #4706 Convert secs to millis when sending creation timestamp to kafka ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issu...
ae601e8e1be9215488daaae7cb39ad5a030e98d9
- the timestamp listed in kafka-ui - can't be tested without infra access and no visible changes on UI
[ "crates/router/src/services/kafka.rs", "crates/router/src/services/kafka/dispute.rs", "crates/router/src/services/kafka/payment_attempt.rs", "crates/router/src/services/kafka/payment_intent.rs", "crates/router/src/services/kafka/payout.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4707
Bug: refactor: Separate out recovery codes from TOTP Even though recovery codes is dependent entity on TOTP. But the new findings suggest that TOTP is a part of entity called 2FA and TOTP is depended on the 2FA entity not the TOTP entity. This will be more clear when we add multiple 2FAs like SMS OTP. So, we want ...
diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs index e9eb5157095..b7d7adbf8e3 100644 --- a/crates/api_models/src/events/user.rs +++ b/crates/api_models/src/events/user.rs @@ -14,10 +14,10 @@ use crate::user::{ ConnectAccountRequest, CreateInternalUserRequest, DashboardEntr...
2024-05-20T13:58:53Z
## Description <!-- Describe your changes in detail --> Currently recovery code are being generated in `begin_totp` API. We want to make a separate out recovery codes and TOTP, so this PR creates a new API which generates the recovery codes. This API will also be used to regenerate recovery codes later. ## Mo...
36409bdc9185d4241971a30c55e1e331568abd2f
**This can only be tested locally as it requires some changes in the redis.** ``` curl --location 'http://localhost:8080/user/recovery_codes/generate' \ --header 'Authorization: Bearer SPT with purpose as TOTP' \ ``` ``` { "recovery_codes": [ "w5fM-NLm0", "TumH-oyXE", "wDIr-zEmu"...
[ "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/router/src/consts/user.rs", "crates/router/src/core/errors/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "cr...
juspay/hyperswitch
juspay__hyperswitch-4702
Bug: [FEATURE] [AUTHORIZEDOTNET] Implement zero mandates ### Feature Description Zero dollar mandates need to be implemented for connector Authorizedotnet. ### Possible Implementation Zero dollar mandates need to be implemented for connector Authorizedotnet. ### Have you spent some time checking if this feature ...
diff --git a/crates/router/src/connector/authorizedotnet.rs b/crates/router/src/connector/authorizedotnet.rs index 0eb4297a414..a9e000b82b9 100644 --- a/crates/router/src/connector/authorizedotnet.rs +++ b/crates/router/src/connector/authorizedotnet.rs @@ -121,20 +121,84 @@ impl types::PaymentsResponseData, ...
2024-05-20T10:00:16Z
## Description <!-- Describe your changes in detail --> Zero dollar mandates are implemented for connector Authorizedotnet. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd reco...
0f53f74d26e829602519998c41a460dc9a4809af
_Note: `test_mode` should be set to `true` while testing._ - Create Zero Amount Mandate: Request: ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data-raw '{ "amount": 0, "...
[ "crates/router/src/connector/authorizedotnet.rs", "crates/router/src/connector/authorizedotnet/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4700
Bug: [FEATURE] Constraint Graph visualization (via GraphViz) functionality ### Feature Description It would be good for developers to be able to visualize constraint graphs for intuition and debugging purposes. This can be done by allowing the constraint graph to describe its structure in the form of a DOT program,...
diff --git a/Cargo.lock b/Cargo.lock index abc265ad692..3f9bd9a6303 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2617,6 +2617,21 @@ dependencies = [ "const-random", ] +[[package]] +name = "dot-generator" +version = "0.2.0" +source = "registry+https://github.com/rust-lang/crates.io-index" +checksum = "0aaac7ada45f7...
2024-05-20T09:56:07Z
## Description <!-- Describe your changes in detail --> This PR adds functionality to the constraint graph that allows the graph to describe its structure by generating a DOT program, which can then be visualized by the user through GraphViz. ## Motivation and Context <!-- Why is this change required? What pro...
be9343affeb178e646d4046785a105a9c6040037
compiler guided. No API tests required since this is purely a developer-focused feature and does not touch any business logic code.
[ "Cargo.lock", "crates/euclid/Cargo.toml", "crates/euclid/src/dssa/graph.rs", "crates/euclid/src/frontend/dir.rs", "crates/hyperswitch_constraint_graph/Cargo.toml", "crates/hyperswitch_constraint_graph/src/graph.rs", "crates/hyperswitch_constraint_graph/src/lib.rs", "crates/hyperswitch_constraint_graph...
juspay/hyperswitch
juspay__hyperswitch-4698
Bug: [FEATURE]: Add Session token flow for Paypal Sdk ### Feature Description Add Session token flow for Paypal Sdk ### Possible Implementation - Accept data in `metadata` field of the MCA - create call - Return that data in the sessions call - Change payment_experience for paypal via paypal to sdk ### Have ...
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index f0ce3839fce..5f9618738b2 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -2939,13 +2939,17 @@ pub enum NextActionType { #[serde(tag = "type", rename_all = "snake_case")] pub enum NextActi...
2024-05-19T17:37:00Z
## Description <!-- Describe your changes in detail --> Add session_token flow to enable Paypal via Paypal SDK - Accept data in `metadata` field of the MCA - create call - Return that data in the sessions call - Change payment_experience for paypal via paypal to sdk ## Motivation and Context <!-- Why is ...
1026f4783000a13b43f22e4db0b36c217d39e541
### Create Paypal MCA with payment_experience as `invoke_sdk_client` for Paypal Wallet ``` curl --location 'http://localhost:8080/account/merchant_1716757295/connectors' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: test_admin' \ --data '{ "connector...
[ "crates/api_models/src/payments.rs", "crates/connector_configs/src/common_config.rs", "crates/connector_configs/src/connector.rs", "crates/connector_configs/src/response_modifier.rs", "crates/connector_configs/src/transformer.rs", "crates/connector_configs/toml/development.toml", "crates/connector_confi...
juspay/hyperswitch
juspay__hyperswitch-4689
Bug: [REFACTOR] add support for passing ttl to locker entries Add config support for passing ttl to locker entries. By default keep the ttl to 7 years
diff --git a/config/config.example.toml b/config/config.example.toml index d5bdfb5a6a7..d10e8216e9f 100644 --- a/config/config.example.toml +++ b/config/config.example.toml @@ -124,11 +124,12 @@ recon_admin_api_key = "recon_test_admin" # recon_admin API key for recon authent # PCI Compliant storage entity which stores...
2024-05-17T13:43:49Z
## Description <!-- Describe your changes in detail --> This PR adds config support for passing ttl to locker entries as application config. By default ttl is kept to 7 years. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the ...
8d9c7bc45ce2515759b9e2a36eb2d8a8a2c813ad
TTL assignment in locker cannot be known (unless we access the locker db). Hyperswitch just sends the TTL as 7 years to locker. Hyperswitch doesn't store the TTL. Even during payment methods retrieve in Hyperswitch, the TTL is not fetched from locker. So basic card saving flow has to be tested Local testing - ...
[ "config/config.example.toml", "config/deployments/env_specific.toml", "config/development.toml", "config/docker_compose.toml", "crates/router/src/configs/defaults.rs", "crates/router/src/configs/settings.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payment_methods/tr...
juspay/hyperswitch
juspay__hyperswitch-4691
Bug: [FEATURE] The Eligibility Analysis during payments confirmation makes use of the Constraint Graph framework to carry out checks. ### Feature Description The Eligibility Analysis during payments confirmation makes use of the Constraint Graph framework to carry out checks. ### Possible Implementation We can ...
diff --git a/Cargo.lock b/Cargo.lock index abc265ad692..e3cc2e32387 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -3944,6 +3944,7 @@ dependencies = [ "masking", "serde", "serde_json", + "strum 0.26.2", "thiserror", ] diff --git a/crates/euclid/src/dssa/graph.rs b/crates/euclid/src/dssa/graph.rs index 0ffafe4d4...
2024-05-17T13:14:13Z
## Description Refactor the Knowledge Graph to include configs(pm_filters) check, while eligibility analysis ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting...
be9343affeb178e646d4046785a105a9c6040037
- Wrote unit test - To test it, - You can create MCA for 2 connectors - Do a payment using BOA and with some currency that it doesn't support , for eg:INR ``` Create curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --hea...
[ "Cargo.lock", "crates/euclid/src/dssa/graph.rs", "crates/euclid/src/enums.rs", "crates/euclid/src/frontend/dir/enums.rs", "crates/euclid_wasm/src/lib.rs", "crates/hyperswitch_constraint_graph/src/builder.rs", "crates/hyperswitch_constraint_graph/src/graph.rs", "crates/kgraph_utils/Cargo.toml", "crat...
juspay/hyperswitch
juspay__hyperswitch-4699
Bug: [FEATURE]: Add a new endpoint Complete Authorize ### Feature Description Add a new endpoint Complete Authorize ### Possible Implementation - This will be used in the cases where we get shipping after confirm call and we need to call the connector 2nd time. - Collect shipping address in complete authoriz...
diff --git a/crates/api_models/src/events/payment.rs b/crates/api_models/src/events/payment.rs index 59e65c0605f..cd1671b2b8e 100644 --- a/crates/api_models/src/events/payment.rs +++ b/crates/api_models/src/events/payment.rs @@ -11,10 +11,10 @@ use crate::{ ExtendedCardInfoResponse, PaymentIdType, PaymentListC...
2024-05-17T12:56:33Z
## Description - Add a new end point `/{payment_id}/complete_authorize`. - This will be used in the cases where we get shipping after confirm call and we need to call the connector 2nd time. - Collect shipping address in complete authorize call ## Motivation and Context <!-- Why is this change required? ...
7e44bbca63c1818c0fabdf2734d9b0ae5d639fe1
1. Create a Paypal Payment request via Paypal (without adding shipping in request) ``` { "amount": 6540, "currency": "USD", "confirm": true, "capture_method": "automatic", "capture_on": "2022-09-10T10:11:12Z", "amount_to_capture": 6540, "customer_id": "StripeCustomer223", "email": "abcdef123@g...
[ "crates/api_models/src/events/payment.rs", "crates/api_models/src/payments.rs", "crates/diesel_models/src/payment_intent.rs", "crates/hyperswitch_domain_models/src/payments/payment_intent.rs", "crates/openapi/src/openapi.rs", "crates/openapi/src/routes/payments.rs", "crates/router/src/core/payments/oper...
juspay/hyperswitch
juspay__hyperswitch-4670
Bug: [REFACTOR] remove `deref` impl on `Cache` type Currently `Cache` is a type having inner value as `MokaCache`. ``` pub struct Cache { inner: MokaCache<String, Arc<dyn Cacheable>>, } ``` There's a deref impl for this type which returns the inner `MokaCache`. We should instead have custom methods on `C...
diff --git a/crates/router/src/db/cache.rs b/crates/router/src/db/cache.rs index d9db13dde80..ba0aae55e89 100644 --- a/crates/router/src/db/cache.rs +++ b/crates/router/src/db/cache.rs @@ -88,7 +88,7 @@ where Fut: futures::Future<Output = CustomResult<T, errors::StorageError>> + Send, { let data = fun().awai...
2024-05-17T10:26:23Z
## Description <!-- Describe your changes in detail --> Currently `Cache` is a type having inner value as `MokaCache`. ``` pub struct Cache { inner: MokaCache<String, Arc<dyn Cacheable>>, } ``` There's a deref impl on this type which returns the inner `MokaCache`. We should instead have custom methods on...
a62f69d447245273c73611309055d2341a47b783
Basic sanity tests should suffice
[ "crates/router/src/db/cache.rs", "crates/router/tests/cache.rs", "crates/storage_impl/src/redis/cache.rs", "crates/storage_impl/src/redis/pub_sub.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4773
Bug: [FEATURE] Process tracker flow for PaymentMethod Status update ### Feature Description For vaulting flows, currently, the `PaymentMethodStatus` is kept as `awaiting_data` during the generation of client_secret, we want to implement a process tracker flow to update the status to `inactive` upon session expiry. ...
diff --git a/crates/diesel_models/src/process_tracker.rs b/crates/diesel_models/src/process_tracker.rs index 135c8e2b055..342ad8453af 100644 --- a/crates/diesel_models/src/process_tracker.rs +++ b/crates/diesel_models/src/process_tracker.rs @@ -208,6 +208,7 @@ pub enum ProcessTrackerRunner { ApiKeyExpiryWorkflow, ...
2024-05-17T07:57:24Z
## Description <!-- Describe your changes in detail --> This PR - - Implemented a process tracker workflow for status update after pm client_secret expiry ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If...
f84ed6a8a00cd5f28debfbc1bb1f8dba14eaa387
When vaulting is done within session - 1. Create a Payment_method ``` curl --location --request POST 'http://localhost:8080/payment_methods' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_cHN6hMdCFUUrNWjYSxnwhiuMsg83rXTX9jBmtHmCL6sq9a43PswY304MSt3a9bl...
[ "crates/diesel_models/src/process_tracker.rs", "crates/router/src/bin/scheduler.rs", "crates/router/src/core/payment_methods.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/types/storage/payment_method.rs", "crates/router/src/workflows.rs", "crates/router/src/workflows/payment...
juspay/hyperswitch
juspay__hyperswitch-4663
Bug: refactor session call to remove the shipping and billing parameter fields if null for apple pay and google pay remove the shipping and billing parameter fields if null for apple pay and google pay as it not necessary to pass
diff --git a/crates/api_models/src/payments.rs b/crates/api_models/src/payments.rs index dcabbde7ebe..d7ba24b5a3e 100644 --- a/crates/api_models/src/payments.rs +++ b/crates/api_models/src/payments.rs @@ -3872,6 +3872,7 @@ pub struct GpayAllowedMethodsParameters { /// Is billing address required pub billing_a...
2024-05-16T11:50:28Z
## Description <!-- Describe your changes in detail --> remove the shipping and billing parameter fields if null for apple pay and google pay. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have ...
4b5b558dae8d2fefb66b8b16c486f07e3e800758
-> Apple pay payment create with confirm false ``` { "amount": 650, "currency": "USD", "confirm": false, "business_country": "US", "business_label": "default", "amount_to_capture": 650, "customer_id": "custhype1232", "capture_method": "automatic", "capture_on": "2022-09-...
[ "crates/api_models/src/payments.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4666
Bug: Creating a payment will shutdown the server due to stack overflow ### Discussed in https://github.com/juspay/hyperswitch/discussions/4636 <div type='discussions-op-text'> <sup>Originally posted by **Rudy-Zidan** May 14, 2024</sup> When ever i try to run the hyperswitch-web a call to "create-payment-inten...
diff --git a/Dockerfile b/Dockerfile index e9591e5e9f2..a8697177716 100644 --- a/Dockerfile +++ b/Dockerfile @@ -61,7 +61,8 @@ ENV TZ=Etc/UTC \ RUN_ENV=${RUN_ENV} \ CONFIG_DIR=${CONFIG_DIR} \ SCHEDULER_FLOW=${SCHEDULER_FLOW} \ - BINARY=${BINARY} + BINARY=${BINARY} \ + RUST_MIN_STACK=4194304 R...
2024-05-16T09:43:53Z
## Description <!-- Describe your changes in detail --> - Add a default `RUST_MIN_STACK` size in the docker images for router ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd re...
f79c12d4f78ac622300e56f7159ca72d65a4ac0d
- generating a docker image locally and testing it
[ "Dockerfile" ]
juspay/hyperswitch
juspay__hyperswitch-4651
Bug: Provide access of cypress tests to hyperswitch qa Provide access to Cypress tests for the Hyperswitch QA team. Previously, QA did not have approval access.
2024-05-15T12:02:49Z
## Description <!-- Describe your changes in detail --> ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one first so the PR can focus on the implement...
e79524b295544a959ec4c0dbdb71e5538adebc9d
[]
juspay/hyperswitch
juspay__hyperswitch-4648
Bug: [FIX] address non-digit character cases in card number validation Enforce following validations on the card number - * non-digit characters in card number * invalid card number length * invalid card number (luhn failure) If any of the above validation fails, raise an appropriate error.
diff --git a/Cargo.lock b/Cargo.lock index 5ba2d0dae6d..abc265ad692 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1728,7 +1728,6 @@ version = "0.1.0" dependencies = [ "common_utils", "error-stack", - "luhn", "masking", "router_env", "serde", @@ -2598,12 +2597,6 @@ dependencies = [ "subtle", ] -[[package]...
2024-05-15T09:49:54Z
## Description <!-- Describe your changes in detail --> This PR enforces following validations on the card number - * non-digit characters in card number * invalid card number length * invalid card number (luhn failure) If any of the above validation fails, appropriate error is raised. This PR also fixes the...
0d45f854a2cc18cc421a3d449a6dc2c830ef9dd5
1. Unit tests - ![image](https://github.com/juspay/hyperswitch/assets/70657455/bfa28c38-a208-4e0c-85d1-82402c08e6f8) 2. Invalid card number length - ``` curl --location 'http://localhost:8080/payment_methods' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header '...
[ "Cargo.lock", "crates/cards/Cargo.toml", "crates/cards/src/lib.rs", "crates/cards/src/validate.rs", "crates/router/src/core/blocklist/utils.rs", "crates/router/src/core/payment_methods/cards.rs", "crates/router/src/core/payment_methods/transformers.rs", "crates/router/src/core/payments/helpers.rs", ...
juspay/hyperswitch
juspay__hyperswitch-4647
Bug: [BUG]: 2-Letter State abbreviation is not accepted ### Bug Description Currently 2-Letter State abbreviation is not accepted, in `billing.state` if you pass 2 letter valid state it should not throw an error ### Expected Behavior Both 2 letter and full state name shall be accepted in `billing.state` and shoul...
diff --git a/crates/common_enums/src/enums.rs b/crates/common_enums/src/enums.rs index 8b0974cc4f8..74eb8c048f9 100644 --- a/crates/common_enums/src/enums.rs +++ b/crates/common_enums/src/enums.rs @@ -2010,7 +2010,9 @@ pub enum FileUploadProvider { Checkout, } -#[derive(Debug, Clone, PartialEq, Eq, Serialize, D...
2024-05-15T07:38:22Z
## Description <!-- Describe your changes in detail --> Accept `billing.state` with 2-letter abbreviation for US and CA ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommen...
ff1c2ddf8b9d8f35deee1ab41c2286cc5b349271
### For CA test with `AB` or any other abbreviation it should pass ``` curl --location 'http://localhost:8080/payments' \ --header 'Accept: application/json' \ --header 'Content-Type: application/json' \ --header 'api-key: dev_mFmnWfEBGI9OvZdkWlkrAEcp6PBReLfXynzHIbcl0d2z4bSDvvHIsegcqrCMDDqv' \ --data-raw '{ ...
[ "crates/common_enums/src/enums.rs", "crates/router/src/connector/utils.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4640
Bug: [REFACTOR] update api contract for payment methods update endpoint Remove unused fields from update payment method request and update the open api spec
diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs index b7a58b3b5b6..e045cf2c42d 100644 --- a/crates/api_models/src/payment_methods.rs +++ b/crates/api_models/src/payment_methods.rs @@ -88,24 +88,6 @@ pub struct PaymentMethodUpdate { "card_holder_name": "John Doe"}))]...
2024-05-14T10:10:43Z
## Description <!-- Describe your changes in detail --> This PR updates the api contract for payment methods update endpoint and removes few unused fields. This PR adds the missing client secret validation for update endpoint ## Motivation and Context <!-- Why is this change required? What problem does it solv...
040d85826aea88ff242f59edfcdf59b592c7c956
`/payment_methods/:id/update` endpoint have to be tested 1. Create a customer ``` curl --location 'http://localhost:8080/customers' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_kxFm2YwE2I8srj4W96v9C5XkZl8VputfqADhqdumTgJFLpuXpgU5I2NlTHOM3ply' \ -...
[ "crates/api_models/src/payment_methods.rs", "crates/openapi/src/routes/payment_method.rs", "crates/router/src/core/payment_methods/cards.rs", "openapi/openapi_spec.json" ]
juspay/hyperswitch
juspay__hyperswitch-4659
Bug: [FEATURE] add support for collecting and refunding charges on payments ### Feature Description Charges can be collected on payments for collecting fees for resellers. Adyen, Stripe allows creating charges on payment intents using their marketplace platform. The support for collecting charges on payments ...
diff --git a/connector-template/transformers.rs b/connector-template/transformers.rs index 40e3c2a3665..fb08c1026f2 100644 --- a/connector-template/transformers.rs +++ b/connector-template/transformers.rs @@ -128,7 +128,8 @@ impl<F,T> TryFrom<types::ResponseRouterData<F, {{project-name | downcase | pasca ...
2024-05-13T11:13:35Z
## Description <!-- Describe your changes in detail --> Detailed description - https://github.com/juspay/hyperswitch/issues/4659 This PR adds functionality to create charges on payment intents using Stripe - create `charges` on payment_intent - store `charge_id` in payment_attempt - use `charge_id` for refunds...
ae77373b4cac63979673fdac37c55986d954358e
Tested locally using postman collection. **Steps for testing** - Make sure Stripe Connect is enabled on your Stripe account - Onboard a Standard user by initiating an account link from Stripe's dashboard - Make sure merchant account is created and Stripe is added as a payment connector - Create a direct charge...
[ "connector-template/transformers.rs", "crates/api_models/src/enums.rs", "crates/api_models/src/payments.rs", "crates/api_models/src/refunds.rs", "crates/common_utils/Cargo.toml", "crates/common_utils/src/types.rs", "crates/diesel_models/src/payment_attempt.rs", "crates/diesel_models/src/payment_intent...
juspay/hyperswitch
juspay__hyperswitch-4627
Bug: ci: use git diff to add `M-database-changes` label for pr that contains migrations and schema changes Use git diff to add `M-database-changes` label for pr that contains migrations and schema changes. This helps to identify the pr that has db migrations.
2024-05-13T07:00:48Z
## Description <!-- Describe your changes in detail --> This ps uses git diff to add `M-database-changes` label for pr that contains migrations and schema changes. ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. ...
7085a46271791ca3f1c7b86afa7c8b199b93c0cd
We can see that `M-database-changes` was added for on of the below commits which contained migration changes. <img width="1050" alt="image" src="https://github.com/juspay/hyperswitch/assets/83439957/959f47f3-622b-40ef-a28d-2ba76dd51d9f">
[]
juspay/hyperswitch
juspay__hyperswitch-4612
Bug: [BUG] : QR Code Image Generation Failure ### Bug Description The QR code generation function, 'new_from_data', is not working as expected. It is returning an empty string instead of the encoded image URL , leading to the failure of PIX QR code generation. ### Expected Behavior Fix QR code into image ge...
diff --git a/crates/router/src/utils.rs b/crates/router/src/utils.rs index 87cd95364d5..059278a1b1c 100644 --- a/crates/router/src/utils.rs +++ b/crates/router/src/utils.rs @@ -185,7 +185,7 @@ impl QrImage { let image_data_source = format!( "{},{}", consts::QR_IMAGE_DATA_SOURCE_STRING...
2024-05-10T06:44:48Z
## Description <!-- Describe your changes in detail --> The QR code generation function, 'new_from_data', is not working as expected. It is returning an empty string instead of the encoded image URL , leading to the failure of PIX QR code generation. Earlier <img width="339" alt="Screenshot 2024-05-10 at 12 18 ...
ecdac814d802cfc260a956a77a99f22c5d899ba3
1. Create a PIX payment with Adyen. In response we must get a valid base64 encoded QR Code data ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: dev_Q1XJ407yuiyLeM1BwpMrGJos9JzwwHHztSVIypS3zsMkIYQqf1W7HA2NZ...
[ "crates/router/src/utils.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4463
Bug: [REFACTOR]: handle network delays with expiry of access token It may so happen that there might be a slight delay in the network to receive the access token from connector. So when we store the access token with expiry already few seconds would have elapsed. So the key might expire few seconds before than the a...
diff --git a/crates/router/src/consts.rs b/crates/router/src/consts.rs index 0c9e9443ac9..6d9da8f7bb5 100644 --- a/crates/router/src/consts.rs +++ b/crates/router/src/consts.rs @@ -118,6 +118,8 @@ pub const POLL_ID_TTL: i64 = 900; pub const DEFAULT_POLL_DELAY_IN_SECS: i8 = 2; pub const DEFAULT_POLL_FREQUENCY: i8 = 5;...
2024-05-09T18:56:17Z
## Description <!-- Describe your changes in detail --> There might be some delay in network due to which the access token which was not expired locally, might have expired when it reaches the connector. This PR reduces the expiry of access token in order to account for such delays <!-- Provide links to the file...
4b5b558dae8d2fefb66b8b16c486f07e3e800758
- Create a payment with any connector which supports access token and then check the ttl in redis. <img width="2052" alt="Screenshot 2024-05-10 at 12 24 52 AM" src="https://github.com/juspay/hyperswitch/assets/48803246/1ef1d233-d0c0-4f6d-a511-b80e61805513"> - The below log can also be checked <img width="1284" a...
[ "crates/router/src/consts.rs", "crates/router/src/core/payments/access_token.rs", "crates/router/src/routes/metrics.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4615
Bug: Pass `required_shipping_contact_fields` field in apple pay session call based on `business_profile` config This change is required as part of the one click checkout where in which we expect apple pay to collect the shipping details from the customer and pass it in the confirm call with the payment_data. In ord...
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index 25de8821263..93cf7574d98 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -916,6 +916,9 @@ pub struct BusinessProfileCreate { /// Whether to use the billing details passed when creating the inten...
2024-05-09T18:15:24Z
## Description <!-- Describe your changes in detail --> This change is required as part of the one click checkout where in which we expect apple pay to collect the shipping details from the customer and pass it in the confirm call with the payment_data. In order for apple pay to collect the shipping details from cu...
f5d1201ac9e99ba5f8af7bb44504d6392744eb10
[ "crates/api_models/src/admin.rs", "crates/api_models/src/enums.rs", "crates/api_models/src/payments.rs", "crates/diesel_models/src/business_profile.rs", "crates/diesel_models/src/schema.rs", "crates/openapi/src/openapi.rs", "crates/router/src/configs/defaults.rs", "crates/router/src/connector/bluesnap...
juspay/hyperswitch
juspay__hyperswitch-4606
Bug: fix: Fix bugs caused by token only flows - Password without special characters is not throwing parsing failed error. - Signup is not populating the `last_password_modified_at`. - Verify email is blacklisting all email tokens. - If the SPT token time is less than JWT time, some SPTs issued after that blacklis...
diff --git a/crates/router/src/consts.rs b/crates/router/src/consts.rs index c40d284ee3a..610d8ef8b1f 100644 --- a/crates/router/src/consts.rs +++ b/crates/router/src/consts.rs @@ -70,7 +70,9 @@ pub const LOCKER_REDIS_EXPIRY_SECONDS: u32 = 60 * 15; // 15 minutes pub const JWT_TOKEN_TIME_IN_SECS: u64 = 60 * 60 * 24 *...
2024-05-09T12:46:43Z
## Description <!-- Describe your changes in detail --> This PR fixes the following bugs: - Password without special characters is not throwing parsing failed error. - Signup is not populating the `last_password_modified_at`. - Verify email is blacklisting all email tokens. - If the SPT token time is less than J...
f386f423c0e5fac55a24756d7ee7a3ce1c20fb13
> [!NOTE] > This only works when email feature flag is disabled. - To check the password validation ``` curl --location 'http://localhost:8080/user/signup' \ --header 'Content-Type: application/json' \ --data-raw '{ "email": "unregistered email", "password": "password" }' ``` - If the password is...
[ "crates/router/src/consts.rs", "crates/router/src/core/user.rs", "crates/router/src/types/domain/user.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4605
Bug: [FEATURE] [BAMBORA] Audit Fixes for connector Bambora ### Feature Description Following code improvements need to be done for connector Bambora: - Optional fields that are being passed for payments request need to be removed - 2XX and 4XX Error response should be handled properly - Separate try_from should ...
diff --git a/crates/connector_configs/toml/development.toml b/crates/connector_configs/toml/development.toml index 61d74863422..d9e7ec58f75 100644 --- a/crates/connector_configs/toml/development.toml +++ b/crates/connector_configs/toml/development.toml @@ -398,26 +398,9 @@ merchant_secret="Source verification key" p...
2024-05-09T11:01:36Z
## Description <!-- Describe your changes in detail --> Following code improvements are done for connector Bambora: - Optional fields that are being passed for payments request are removed - 2XX and 4XX Error response are now handled properly - Separate try_from are now used for all the flows - Unwanted configs ...
f386f423c0e5fac55a24756d7ee7a3ce1c20fb13
All the payment flows need to be tested(except void) for cards(Non-3DS) via Bambora. 1. Payments (Automatic): Request - ``` curl --location 'http://localhost:8080/payments' \ --header 'Content-Type: application/json' \ --header 'Accept: application/json' \ --header 'api-key: API_KEY_HERE' \ --data '{ "am...
[ "crates/connector_configs/toml/development.toml", "crates/connector_configs/toml/production.toml", "crates/connector_configs/toml/sandbox.toml", "crates/router/src/connector/bambora.rs", "crates/router/src/connector/bambora/transformers.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4602
Bug: Pass `required_billing_contact_fields` field in apple pay session call based on dynamic fields This change is required as part of the one click checkout where in which we expect apple pay to collect the billing details from the customer and pass it in the confirm call with the `payment_data`. In order for app...
diff --git a/crates/api_models/src/enums.rs b/crates/api_models/src/enums.rs index 884e0fd82f8..37d17dcff17 100644 --- a/crates/api_models/src/enums.rs +++ b/crates/api_models/src/enums.rs @@ -396,13 +396,11 @@ pub struct UnresolvedResponseReason { Clone, Debug, Eq, - PartialEq, serde::Deserializ...
2024-05-09T07:48:31Z
## Description <!-- Describe your changes in detail --> This change is required as part of the one click checkout where in which we expect apple pay to collect the billing details from the customer and pass it in the confirm call with the `payment_data`. In order for apple pay to collect the billing details from c...
2a302eb5973c64d8b77f8110fdbeb536ccbe1488
-> Create a MCA for stripe -> Apple pay payment create with confirm false ``` { "amount": 650, "currency": "USD", "confirm": false, "business_country": "US", "business_label": "default", "amount_to_capture": 650, "customer_id": "custhype1232", "capture_method": "automatic"...
[ "crates/api_models/src/enums.rs", "crates/api_models/src/payment_methods.rs", "crates/api_models/src/payments.rs", "crates/connector_configs/src/transformer.rs", "crates/openapi/src/openapi.rs", "crates/router/src/connector/bluesnap/transformers.rs", "crates/router/src/connector/payme/transformers.rs", ...
juspay/hyperswitch
juspay__hyperswitch-4618
Bug: [FEAT] add an API to toggle KV for all the merchants
diff --git a/crates/api_models/src/admin.rs b/crates/api_models/src/admin.rs index 2e288140a9f..12d9832ada6 100644 --- a/crates/api_models/src/admin.rs +++ b/crates/api_models/src/admin.rs @@ -829,6 +829,22 @@ pub struct ToggleKVRequest { pub kv_enabled: bool, } +#[derive(Debug, Clone, Serialize, Deserialize, T...
2024-05-09T07:02:01Z
## Description <!-- Describe your changes in detail --> Add an API to toggle KV for all merchants ## Motivation and Context <!-- Why is this change required? What problem does it solve? If it fixes an open issue, please link to the issue here. If you don't have an issue, we'd recommend starting with one fi...
5e84855496d80959c1fc43c1efc9bb2a4d802d5a
- Enable KV for all merchants ```bash curl --location 'http://localhost:8080/accounts/kv' \ --header 'Content-Type: application/json' \ --header 'api-key: test_admin' \ --data '{ "kv_enabled": true }' ``` Check if any merchant_account has `postgres_only`. ```sql SELECT storage_scheme from merchant_a...
[ "crates/api_models/src/admin.rs", "crates/api_models/src/events.rs", "crates/diesel_models/src/query/merchant_account.rs", "crates/router/src/core/admin.rs", "crates/router/src/db/kafka_store.rs", "crates/router/src/db/merchant_account.rs", "crates/router/src/routes/admin.rs", "crates/router/src/route...
juspay/hyperswitch
juspay__hyperswitch-4595
Bug: [Feature] Add tenant-ID as a field to all KafkaStore events ### Context In-order to support multi-tenancy we need to store data partioned via tenant-id. In order to do that for kafka events we need to pass tenant-id as a field in the generated kafka events We can use the KafkaStore field added in #4512 to ...
diff --git a/crates/router/src/db/kafka_store.rs b/crates/router/src/db/kafka_store.rs index a64e3cc7e38..15a0b2e2046 100644 --- a/crates/router/src/db/kafka_store.rs +++ b/crates/router/src/db/kafka_store.rs @@ -76,7 +76,7 @@ use crate::{ }, }; -#[derive(Clone, Serialize)] +#[derive(Debug, Clone, Serialize)] ...
2024-05-09T04:56:02Z
#4595 - [ ] Bugfix - [x] New feature - [ ] Enhancement - [ ] Refactoring - [ ] Dependency updates - [ ] Documentation - [ ] CI/CD ## Description <!-- Describe your changes in detail --> - Add TenantID to the KafkaEvent struct and add the extra param to the KafkaEvent constructor - Made changes to the r...
f3115c45114c1445456af229f11ca19459c9536d
<img width="973" alt="image" src="https://github.com/juspay/hyperswitch/assets/21202349/aaed9da0-ab3c-4161-afb2-51a752fdf2f3">
[ "crates/router/src/db/kafka_store.rs", "crates/router/src/services/kafka.rs" ]
juspay/hyperswitch
juspay__hyperswitch-4596
Bug: feat: Create API for TOTP Verification To complete the TOTP Flow, there needs to be an API which needs to verify the totp entered by the user and give the next token and flow that user should go to enter into the dashboard.
diff --git a/crates/api_models/src/events/user.rs b/crates/api_models/src/events/user.rs index 1d91a47bf56..e9eb5157095 100644 --- a/crates/api_models/src/events/user.rs +++ b/crates/api_models/src/events/user.rs @@ -17,7 +17,7 @@ use crate::user::{ ResetPasswordRequest, RotatePasswordRequest, SendVerifyEmailReque...
2024-05-08T18:01:14Z
## Description <!-- Describe your changes in detail --> This PR allows users to complete the TOTP flow. It adds a new api `/user/totp/verify`, which will verify the totp entered by the user and mark the user totp status as set if it is in `InProgress`. ## Motivation and Context <!-- Why is this change require...
ec3b60e37c0b178c3e5e3fe79db88f83fd195722
``` curl --location 'http://localhost:8080/user/totp/verify' \ --header 'Content-Type: application/json' \ --header 'Authorization: Bearer SPT with Purpose as TOTP' \ --data '{ "totp": "189646" }' ``` If the TOTP is correct, the the API should return the next token that is in the current flow. ``` { ...
[ "crates/api_models/src/events/user.rs", "crates/api_models/src/user.rs", "crates/router/src/core/errors/user.rs", "crates/router/src/core/user.rs", "crates/router/src/routes/app.rs", "crates/router/src/routes/lock_utils.rs", "crates/router/src/routes/user.rs", "crates/router/src/types/domain/user.rs",...