patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -127,7 +127,10 @@ public abstract class AbstractConfigItemFacade {
final ConfigItem configFile = new FileConfigItem(VRScripts.CONFIG_PERSIST_LOCATION, remoteFilename, gson.toJson(configuration));
cfg.add(configFile);
- final ConfigItem updateCommand = new ScriptConfigItem(VRScripts.UPDATE_... | [AbstractConfigItemFacade->[generateConfigItems->[appendUuidToJsonFiles]]] | Generates config items for the remote server. | does this mean we now have a processed cache cleaner? |
@@ -151,7 +151,14 @@ class Jetpack_Options {
}
$options[ $name ] = $value;
- return update_option( self::$grouped_options[ $group ], $options );
+ if ( self::is_network_option( $name ) ) {
+ return update_site_option( self::$grouped_options[ $group ], $options );
+ }
+ else {
+ return update_option( sel... | [No CFG could be retrieved] | Update the grouped option with the given name and value. | As prior condition is doing a `return` this doesn't need to be in an `else` |
@@ -924,7 +924,7 @@ class GContact
}
// These fields are having different names but the same content
- $gcontact['server_url'] = $contact['baseurl'];
+ $gcontact['server_url'] = defaults($contact, 'baseurl', ''); // "baseurl" can be null, "server_url" not
$gcontact['nsfw'] = $contact['sensitive'];
$gcon... | [GContact->[fetchGsUsers->[getBody,isSuccess]]] | Updates a user s contact with the given condition. This function is used to populate the content of a single GContact object. if not archived insert it. | If `$contact['baseurl']` is guaranteed to exist at this point, please write `$contact['baseurl'] ?? ''` instead. |
@@ -606,7 +606,7 @@ export class AmpStoryEmbeddedComponent {
*/
updateTooltipBehavior_(target) {
if (matches(target, LAUNCHABLE_COMPONENTS['a'].selector)) {
- addAttributesToElement(devAssert(this.tooltip_),
+ addAttributesToElement(dev().assertElement(devAssert(this.tooltip_)),
dict({'... | [No CFG could be retrieved] | Updates the tooltip for a single component. Gets href from an element containing a url. | This change seems to be everywhere in this PR. Is there a reason that `devAssert` doesn't just do what it's replaced with here? |
@@ -109,7 +109,7 @@ class SwitchingDirectRunner(PipelineRunner):
if isinstance(dofn, CombineValuesDoFn):
args, kwargs = transform.raw_side_inputs
args_to_check = itertools.chain(args,
- kwargs.values())
+ ... | [_StreamingGroupAlsoByWindow->[from_runner_api_parameter->[_StreamingGroupAlsoByWindow]],_get_pubsub_transform_overrides->[ReadFromPubSubOverride->[get_replacement_transform->[_DirectReadFromPubSub]],WriteStringsToPubSubOverride->[get_replacement_transform->[_DirectWriteToPubSub]],ReadFromPubSubOverride,WriteStringsToP... | Runs a pipeline on the FnApiRunner. Check whether all transforms used in the pipeline are supported by the . | While technically this makes equivalent interpretation in Py2 and Py3, I think we can safely skip list conversion here in favor of cleaner code. |
@@ -121,7 +121,7 @@ class SourceRoots:
:return: A SourceRoot instance, or None if the path is not located under a source root
and `unmatched == fail`.
"""
- matched_path = self._pattern_matcher.find_root(path)
+ matched_path = self._find_root(PurePath(path))
if... | [SourceRootPatternMatcher->[find_root->[NoSourceRootError,_match_root_patterns],__post_init__->[InvalidSourceRootPatternError]],SourceRootConfig->[get_source_roots->[SourceRoots],get_pattern_matcher->[SourceRootPatternMatcher]],get_source_root->[OptionalSourceRoot,get_pattern_matcher,SourceRoot],SourceRoots->[get_patte... | Find the source root for the given path relative to the buildroot. | This method won't support this new facility... are we planning to remove it? Or is the idea that this is a v1 only method, effectively? |
@@ -1608,6 +1608,12 @@ func (pt *programTester) prepareGoProject(projinfo *engine.Projinfo) error {
if err != nil {
return err
}
+
+ // skip building if the 'go run' invocation path is requested.
+ if pt.opts.GoRunInvoke {
+ return nil
+ }
+
outBin := filepath.Join(gopath, "bin", string(projinfo.Proj.Name))
... | [testLifeCycleDestroy->[GetStackNameWithOwner,GetDebugUpdates,runPulumiCommand],testEdit->[previewAndUpdate,query],testPreviewUpdateAndEdits->[GetDebugUpdates,runPulumiCommand],prepareNodeJSProject->[runYarnCommand],yarnLinkPackageDeps->[runYarnCommand],installPipPackageDeps->[runPipenvCommand],pipenvCmd->[getPipenvBin... | prepareGoProject prepares a Go project for compilation. | We have a `RunBuild` flag already - make sense to reuse that here? |
@@ -79,6 +79,8 @@ class Zoltan(Package):
.format(spec['metis'].prefix.include))
config_args.append('--with-ldflags=-L{0}'
.format(spec['metis'].prefix.lib))
+ if '+int64' in spec['metis']:
+ config_args.append('--with... | [Zoltan->[install->[,join_path,get_config_flag,basename,satisfies,append,working_dir,Executable,sub,config,glob,format,RuntimeError,join,make,get_mpi_libs,move],get_config_flag->[format],get_mpi_libs->[join_path,group,list,basename,r'^,glob,set,add,match],variant,conflicts,depends_on,version]] | Installs a Zoltan configuration. Add Zoltan specific configuration options. move the shared library files to the output library. | can you handle the -int64 case also explicitly? |
@@ -825,8 +825,8 @@ CY0IMP8pCHUZH9OX/K0N9L+GItqlBK8G4grJ4o43da2x9L0hIrdauPadaGcJalf8k1ymhJ4VDj7t
ueuTl2qTtbBh015GuEld61EBXSBLIUqwOAeFYrNJbC4J2mXgnLTWC380cBf5KWeSdjLYgk2sZ1V4
FKKQecZIhxdlDGzMAbbmEV+2EqS+As2C7+y4dkpG4nnbQe/4AFr8vekHdrI=
-----END CERTIFICATE-----");
- byte[] rootBytes = Encoding.ASCII.GetByt... | [ChainTests->[Create->[Create],BuildChainInvalidValues->[Create]]] | This method is used to chain errors at multiple layers. Certificate that contains a single certificate and a sequence of all of its intermediate certificates. This function is called by the DNA to determine if a sequence is available. | Please revert these unnecessary style changes. |
@@ -419,9 +419,15 @@ class WPSEO_Sitemaps {
}
/**
- * Make a request for the sitemap index so as to cache it before the arrival of the search engines.
+ * Makes a request for the sitemap index so as to cache it before the arrival of the search engines.
+ *
+ * @return void
*/
public function hit_sitemap_... | [WPSEO_Sitemaps->[redirect->[set_n,sitemap_close],refresh_sitemap_cache->[set_n]]] | Hit the sitemap index page. | `Makes a request to the sitemap index to cache it before the arrival of the search engines.` makes for a better sentence. |
@@ -735,7 +735,8 @@ class Resolve(object):
def solve(self, specs, returnall=False, _remove=False):
# type: (List[str], bool) -> List[Dist]
try:
- stdoutlog.info("Solving package specifications: ")
+ if not context.json:
+ stdoutlog.info("Solving package specif... | [Resolve->[generate_removal_count->[push_MatchSpec],install->[restore_bad,install_specs],push_MatchSpec->[ms_to_v,match,push_MatchSpec],dependency_sort->[ms_depends],remove->[restore_bad,remove_specs],generate_feature_count->[push_MatchSpec],verify_specs->[invalid_chains,default_filter],generate_install_count->[push_Ma... | Solves a single package specification. Maximize version and build count of packages. Returns the weak dependency count of a given solution. | Changes here in `resolve.py` are just removing writes to `sys.stdout` when we shouldn't be writing there. |
@@ -0,0 +1,10 @@
+module Mentions
+ class CreateAllJob < ApplicationJob
+ queue_as :mentions_create_all
+
+ def perform(notifiable_id, notifiable_type)
+ notifiable = notifiable_type.constantize.find_by(id: notifiable_id)
+ MentionsCreateAllService.call(notifiable) if notifiable
+ end
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Since `constantize` is used, it's safer to check what class names are allowed here, e.g. return if another notifiable_type is passed |
@@ -1496,6 +1496,9 @@ class Program(object):
>>> with program._optimized_guard([p,g]):
>>> p = p - 0.001 * g
"""
+ tmp_role = self._current_role
+ tmp_var = self._op_role_var
+
OpRole = core.op_proto_and_checker_maker.OpRole
self._current_role = OpR... | [NameScope->[child->[NameScope]],OpProtoHolder->[__init__->[get_all_op_protos]],_full_name_scope->[parent,name],dtype_is_floating->[convert_np_dtype_to_dtype_],get_all_op_protos->[get_all_op_protos],Operator->[attr_type->[attr_type],to_string->[_debug_string_],_block_attr->[_block_attr_id],output->[output],_rename_inpu... | A with guard to set optimization and forward. | lr schedule ops can always be marked as `optimize | lrsched` I think, the learning rate should only be used by optimize ops. |
@@ -103,9 +103,14 @@ public class CookieRetrievingCookieGenerator extends CookieGenerator {
* @return the cookie value
*/
public String retrieveCookieValue(final HttpServletRequest request) {
- final Cookie cookie = org.springframework.web.util.WebUtils.getCookie(
- request, getCo... | [CookieRetrievingCookieGenerator->[addCookie->[addCookie]]] | Retrieves the cookie value. | This change is not related to this PR, isn't it? I guess there was already a fix to trap encoding issue... |
@@ -153,7 +153,7 @@ class Console(gevent.Greenlet):
print("Entering Console" + OKGREEN)
print("Tip:" + OKBLUE)
print_usage()
- IPython.start_ipython(argv=["--gui", "gevent"], user_ns=self.console_locals)
+ IPython.start_ipython(argv=[], user_ns=self.console_locals)
sy... | [ConsoleTools->[wait_for_contract->[time,to_canonical_address,sleep,len,getCode],open_channel_with_funding->[to_canonical_address,TokenAddress,set_total_channel_deposit,channel_open,TokenNetworkRegistryAddress],create_token->[deploy_single_contract,to_canonical_address,Timeout,to_hex_address,print,register_token,get_co... | Run the main loop. Exit if there is no event in console. | nice! ipython now has native gevent support? |
@@ -96,6 +96,8 @@ class Runner {
if ( is_numeric( $user ) ) {
$user_id = (int) $user;
+ } else if ( is_email( $user ) ) {
+ $user_id = email_exists( $user );
} else {
$user_id = (int) username_exists( $user );
}
| [Runner->[_run_command->[run_command],before_wp_load->[wp_exists,init_config,_run_command,find_command_to_run,cmd_starts_with,init_colorization,init_logger,get_wp_config_code,check_wp_version,do_early_invoke],run_command->[find_command_to_run],init_logger->[in_color],after_wp_load->[_run_command],check_wp_version->[wp_... | Sets the current user. | How about using the fetcher here too? |
@@ -976,8 +976,7 @@ namespace Dynamo.Tests
var cbn = nodes.OfType<CodeBlockNodeModel>().FirstOrDefault();
Assert.IsNotNull(cbn);
- var error = "Multiple definitions for 'FFITarget.B.DupTargetTest' are found as FFITarget.C.B.DupTargetTest, FFITarget.B.DupTargetTest";
- A... | [NodeToCodeTest->[TestUsingTypeDependentVariableName02->[SelectAll],GetLibrariesToPreload->[GetLibrariesToPreload],TestNodeToCodeUndo1->[TestNodeToCodeUndoBase],TestNodeToCodeUndo2->[TestNodeToCodeUndoBase],TestNodeToCodeWithPropertyInCodeBlock->[SelectAll],TestUsingTypeDependentVariableName01->[SelectAll]],NodeToCodeS... | Test if a node in the current workspace conflicts with a namespace. Checks if the current connector and node are in the same order as the cur connector. | @aparajit-pratap is there still a test that asserts this error is raised in the correct situation where there actually are conflicts? |
@@ -12,10 +12,11 @@ class PyOpppy(PythonPackage):
output and dump files generated by scientific software packages."""
homepage = "https://github.com/lanl/opppy"
- url = "https://github.com/lanl/OPPPY/archive/OPPPY-0_1_1.tar.gz"
+ url = "https://github.com/lanl/OPPPY/archive/opppy-0_1_2.tar.gz"
gi... | [PyOpppy->[depends_on,version]] | The Output Parse - Plot Python library is a python based data analysis library designed to. | Is setuptools actually needed at runtime? Also, it looks like sphinx is only needed if you build the docs, so that dependency can be dropped. Would you like to add yourself as a maintainer of the package? Just add `maintainers = ['clevelam']` and we'll ping you if anyone else submits a PR or issue related to this packa... |
@@ -289,6 +289,8 @@ public class DeltaSync implements Serializable {
srcRecordsWithCkpt.getRight().getLeft(), metrics, overallTimerContext);
}
+ metrics.updateDeltaStreamerSyncMetrics(System.currentTimeMillis());
+
// Clear persistent RDDs
jssc.getPersistentRDDs().values().forEach(JavaRDD... | [DeltaSync->[getHoodieClientConfig->[getHoodieClientConfig],registerAvroSchemas->[registerAvroSchemas],startCommit->[startCommit],syncMeta->[getSyncClassShortName],syncHive->[syncHive],syncOnce->[refreshTimeline],close->[close]]] | Synchronize the source data with the sink and write the records in one atomic operation. | Just confirming that you don't want to emit a metric if there was an exception and it errored out. |
@@ -178,8 +178,12 @@ class Trainer:
A ``Dataset`` to train on. The dataset should have already been indexed.
validation_dataset : ``Dataset``, optional, (default = None).
A ``Dataset`` to evaluate on. The dataset should have already been indexed.
- patience : int, optional (def... | [Trainer->[_parameter_and_gradient_statistics_to_tensorboard->[add_train_scalar,is_sparse],train->[_enable_activation_logging,_validation_loss,_should_stop_early,_metrics_to_tensorboard,_enable_gradient_clipping,_metrics_to_console,_train_epoch,_get_metrics],_enable_activation_logging->[hook->[add_train_histogram]],_re... | Initialize a new object with the given parameters. Required parameter. This class is called to initialize the object with the given . Initialize the object with a cuda cuda device or cuda device. | in `from_params` the default value is 2 if not specified, so how would patience be `None`? I think that could only be the case if people explicitly put `"patience": null` in the config file? I don't know that I like the idea of having nulls in the config file |
@@ -895,8 +895,7 @@ public class SlaveComputer extends Computer {
} catch (IOException e) {
logger.log(Level.SEVERE, "Failed to terminate channel to " + getDisplayName(), e);
}
- for (ComputerListener cl : ComputerListener.all())
- cl.onOffline(this, ... | [SlaveComputer->[getRetentionStrategy->[getNode,getRetentionStrategy],getEnvVarsFull->[call],LowPermissionResponse->[doJenkinsAgentJnlp->[doJenkinsAgentJnlp],doSlaveAgentJnlp->[doJenkinsAgentJnlp]],setNode->[setNode],getNode->[getNode],grabLauncher->[getLauncher],getDelegatedLauncher->[getLauncher],taskCompleted->[task... | Closes the channel and sets the node. | _Possibly_ solving the problem reported by @rockseisen. |
@@ -43,4 +43,5 @@ type TLSMetadata struct {
}
// NetworkFunc defines callback executed when a new event is received from a network source.
+// data is a safe reference only for the lifespan of this func. Any offline usage should be done on a copy.
type NetworkFunc = func(data []byte, metadata NetworkMetadata)
| [No CFG could be retrieved] | NetworkFunc defines callback executed when a new event is received from a network source. | :+1: I wonder why NetworkFunc is an alias, There is no need for the `=`. Can you remove that as well please? Let's add details about lifetimes to SplitHandlerFactory (as well, or instead). In the end it is the HandlerFactory that governs the lifetime. |
@@ -423,7 +423,9 @@ var VideoLayout = {
* Shows the presence status message for the given video.
*/
setPresenceStatus (id, statusMsg) {
- remoteVideos[id].setPresenceStatus(statusMsg);
+ let remoteVideo = remoteVideos[id];
+ if (remoteVideo)
+ remoteVideo.setPresenceStat... | [No CFG could be retrieved] | Displays a visual indicator for the given video. Create a moderator indicator element. | Not a big deal, but maybe we could add a getter for getting remote video instead of duplicating direct access everywhere ? |
@@ -380,6 +380,13 @@ namespace Microsoft.Xna.Framework
{
_gameWindow.ResetElapsedTime();
}
+
+ public override void Present()
+ {
+ var device = Game.GraphicsDevice;
+ if (device != null)
+ device._graphicsMetrics = new GraphicsMetrics();
+ ... | [MacGamePlatform->[ResetElapsedTime->[ResetElapsedTime],StartRunLoop->[StartRunLoop],EnterBackground->[SuspendUpdatingAndDrawing],EnterFullScreen->[ResumeUpdatingAndDrawing,SuspendUpdatingAndDrawing],ExitFullScreen->[ResumeUpdatingAndDrawing,SuspendUpdatingAndDrawing],Dispose->[Dispose],EnterForeground->[ResumeUpdating... | Reset the elapsed time of this game window. | This is pretty gross... but we plan to kill the `MacGamePlatform` in favor of `OpenTKGamePlatform` soon anyway. |
@@ -49,13 +49,13 @@ public class CopyEventSubmitterHelper {
}
static void submitFailedDatasetPublish(EventSubmitter eventSubmitter,
- CopyableFile.DatasetAndPartition datasetAndPartition) {
+ CopyEntity.DatasetAndPartition datasetAndPartition) {
eventSubmitter.submit(DATASET_PUBLISHED_FAILED_EVEN... | [CopyEventSubmitterHelper->[submitSuccessfulDatasetPublish->[submit],submitFailedDatasetPublish->[getDatasetURN,of,submit],submitSuccessfulFilePublish->[deserializeCopyableFile,getProp,submit]]] | Submits failed dataset publish event. | Should this remain as `CopyableFile`? |
@@ -97,6 +97,18 @@ class CudaArraySlicing(unittest.TestCase):
darr = cuda.to_device(arr)
self.assertTrue(np.all(darr[:1, 1].copy_to_host() == arr[:1, 1]))
+ def test_empty_slice_1d(self):
+ arr = np.arange(5)
+ darr = cuda.to_device(arr)
+ for i in range(darr.shape[0]):
+ ... | [CudaArrayIndexing->[test_index_3d->[arange,range,to_device,assertEqual],test_index_2d->[arange,range,to_device,assertEqual],test_index_1d->[arange,range,to_device,assertEqual]],CudaArraySlicing->[test_prefix_2d->[assertTrue,to_device,all,arange,assertEqual,copy_to_host,range],test_prefix_select->[assertTrue,to_device,... | Test if device has prefix select. | Perhaps test an invalid slice size raises? |
@@ -260,9 +260,7 @@ func (es *Backend) ReindexNodeStateA1(ctx context.Context, a1NodeStateIndexName
}
}
- es.RefreshIndex(ctx, mappings.NodeState.Index)
-
- return err
+ return es.RefreshIndex(ctx, mappings.NodeState.Index)
}
// GetAllTimeseriesIndiceNames - get all the indice names for the givin indexName t... | [GetLatestA1NodeRun->[NewTermQuery,NewFetchSourceContext,Size,Index,Do,FetchSourceContext,Must,Unmarshal,Sort,NewBoolQuery,Include,Type,Search,Query],GetAllTimeseriesIndiceNames->[Index,Do,IndexGetSettings],RefreshIndex->[Do,Refresh],EmptyNodeLatestRunID->[Script,Index,Do,Id,NewScript,Type,Update],ReindexNodeStateA1->[... | ReindexNodeStateA1 rebuilds the node state from the source index GetAllTimeseriesIndiceNames returns a list of all time series indice names in the. | Wasn't sure if we wanted to ignore errors from this refresh or not. |
@@ -1782,6 +1782,16 @@ namespace Dynamo.Models
}
protected bool ShouldDisplayPreviewCore { get; set; }
+
+ public event Action<NodeModel, IEnumerable<IRenderPackage>> UpdatedRenderPackagesAvailable;
+
+ public void OnUpdatedRenderPackagesAvailable(IEnumerable<IRenderPackage> pa... | [NodeModel->[PortDisconnected->[DisconnectOutput,DisconnectInput,ValidateConnections,OnNodeModified],BuildAst->[BuildOutputAst],Warning->[Warning],Deselect->[ValidateConnections],ClearRuntimeError->[ClearTooltipText],RegisterAllPorts->[RegisterInputPorts,ValidateConnections,RegisterOutputPorts],PortModel->[OnNodeModifi... | This method migrates a node from the Ds function to the Ds vararg function This class is a public API and is only used in the UI thread. It is used. | How about simply `RenderPackagesUpdated`? This fits more with the `NodeAdded`, `NodeRemoved` model of naming. I'd prefer if we stored no render package state on `NodeModel` at all and this is the only way that `RenderPackages` were surfaced. Your changes would allow that. |
@@ -1093,6 +1093,11 @@ static void lcd_prepare_menu() {
// Auto Home
//
MENU_ITEM(gcode, MSG_AUTO_HOME, PSTR("G28"));
+ #if ENABLED(INDIVIDUAL_AXIS_HOMING_MENU)
+ MENU_ITEM(gcode, "Home X", PSTR("G28 X"));
+ MENU_ITEM(gcode, "Home Y", PSTR("G28 Y"));
+ MENU_ITEM(gcode, "Home Z", PSTR("G28 Z"));
+ #e... | [No CFG could be retrieved] | Menu for the menu of level - bed or level - bed. Adds menu items for menu items of menu object. | I didn't show it in my original example, but these ought to be translatable strings. |
@@ -2106,7 +2106,7 @@ namespace MonoTests.System.Drawing
new CharacterRange (2, 1)
};
- Region[] Measure(Graphics gfx, RectangleF rect)
+ Region[] Measure_Helper(Graphics gfx, RectangleF rect)
{
using (StringFormat format = StringFormat.Generic... | [GraphicsTest->[TransformPoints->[TransformPoints],VisibleClipBound_BigClip->[Clip,ClipBounds],DrawImage_ImagePoint1RectangleGraphicsUnit->[DrawImage_ImagePointRectangleGraphicsUnit],Compare->[AssertEquals],ClipBounds_Transform_Translation->[Clip,CheckBounds,ClipBounds],CheckForEmptyBitmap->[IsEmptyBitmap],Clip_ScaleTr... | Measure the character ranges of the given graphics object. | Can this be moved to be a local function inside Measure below? |
@@ -1,4 +1,4 @@
-// Copyright 2016-2021, Pulumi Corporation.
+// Copyright 2016-2020, Pulumi Corporation.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
| [RemoveAll,Dir,WriteFile,Walk,IsNotExist,Error,Stat,ReadFile,IsExist,ReadDir,Bytes,Logf,Join,Equal,Contains,Name,ToSlash,NoError,Ext,Base,Rel,Split,MkdirAll,ImportSpec,ReplaceAll,IsDir,Sprintf,Unmarshal,FromSlash,Open,Fail,Getenv,Trim] | GeneratePackageFilesFromSchema loads a schema and generates files using the provided function. LoadFiles loads the list of files from a directory and returns a map of language - >. | Why are we reverting the year? |
@@ -119,7 +119,7 @@
size: 'lg',
resolve: {
entity: ['User', function(User) {
- return User.get({login : $stateParams.login}).$promise;
+ return User.get({login : $stateParams.login});
... | [No CFG could be retrieved] | User - management modal User management detail view. | Changes to this file should be reverted |
@@ -36,7 +36,8 @@ func TestBulletproofTxManager_SendEther_DoesNotSendToZero(t *testing.T) {
to := utils.ZeroAddress
value := assets.NewEth(1)
- _, err := bulletprooftxmanager.SendEther(db, big.NewInt(0), from, to, *value, 21000)
+ q := pg.NewQ(db, logger.NewNullLogger(), cltest.NewTestGeneralConfig(t))
+ _, err :... | [EqualError,NewAddress,AssertCount,MustInsertUnconfirmedEthTxWithInsufficientEthAttempt,MustAddRandomKeyToKeystore,Test,JustError,Exec,CreateEthTransaction,Duration,Close,Eth,AnythingOfType,Greater,Error,MustInsertUnstartedEthTx,TestLogger,MustInsertUnconfirmedEthTxWithBroadcastLegacyAttempt,NewChainKeyStore,NewV4,NewE... | TestBulletproofTxManager_SendEther_DoesNotSendToZero tests if ManagerORM is the main entry point for the bulletprooftxmanager. It is the main. | I think you can reference the `logger.NullLogger` instance instead of making new ones. Although, why suppress these logs at all? What about `logger.TestLogger(t)` so they can be flipped on for debugging? |
@@ -80,7 +80,11 @@ import conda.exceptions # NOQA
from conda.base.context import get_prefix as context_get_prefix, non_x86_linux_machines # NOQA
non_x86_linux_machines = non_x86_linux_machines
-from conda.base.constants import DEFAULT_CHANNELS # NOQA
+from conda.base.constants import DEFAULT_CHANNELS # NOQ... | [list,partial,get_conda_build_local_url,warn,reset_context] | Get a list of version information from the system. Get the conda build local url. | We should be preferring relative imports here. It's probably not done in the whole file. No better time to start though. |
@@ -75,12 +75,12 @@ void ESP8266WiFiClass::printDiag(Print& p) {
char ssid[33]; //ssid can be up to 32chars, => plus null term
memcpy(ssid, conf.ssid, sizeof(conf.ssid));
ssid[32] = 0; //nullterm in case of 32 char ssid
- p.printf_P(PSTR("SSID (%d): %s\n"), strlen(ssid), ssid);
+ p.printf_P(PSTR("S... | [printDiag->[wifi_station_get_auto_connect,wifi_get_phy_mode,wifi_station_get_current_ap_id,print,wifi_get_channel,println,wifi_get_opmode,wifi_station_get_config,memcpy,printf_P,PSTR,wifi_station_get_connect_status,strlen,F]] | Diagnostics for the properties of the WiFi object. | +1 above, headers have size_t so it's also `%zu` |
@@ -277,8 +277,7 @@ namespace System.Security.Cryptography
}
finally
{
- CryptographicOperations.ZeroMemory(decryptedSpan);
- CryptoPool.Return(decrypted.Array!, clearSize: 0);
+ ... | [CngPkcs8->[TryExportEncryptedPkcs8PrivateKey->[TryExportEncryptedPkcs8PrivateKey],AsnWriter->[TryExportEncryptedPkcs8PrivateKey],ExportEncryptedPkcs8PrivateKey->[ExportEncryptedPkcs8PrivateKey]]] | Import encrypted private key. | This had been clearing nothing, and now it's clearing the whole segment. Is that intentional? |
@@ -627,11 +627,12 @@ class Solver(object):
spec_set = (python_spec, ) + tuple(self.specs_to_add)
if ssc.r.get_conflicting_specs(spec_set):
- if self._repodata_fn == REPODATA_FN:
+ if (self._repodata_fn == REPODATA_FN and
+ ... | [diff_for_unlink_link_precs->[_add_to_unlink_and_link],Solver->[get_constrained_packages->[empty_package_list],_add_specs->[_should_freeze,_compare_pools],_post_sat_handling->[solve_final_state]]] | Add a to the system. Add missing missing missing missing missing missing missing missing missing missing missing missing missing missing missing missing missing In UPDATE_ALL mode we need to make sure that the constraints in the spec_map Adds a missing missing node - spec or version to the list of available packages. | If the user passes a different update_modifier on the command line then this will never be triggered and a conflict list is never generated. |
@@ -56,6 +56,9 @@ public class SegmentLoaderConfig
@JsonProperty("numBootstrapThreads")
private Integer numBootstrapThreads = null;
+ @JsonProperty("numCacheLoadThreads")
+ private int numCacheLoadThreads = 5;
+
@JsonProperty
private File infoDir = null;
| [SegmentLoaderConfig->[withInfoDir->[SegmentLoaderConfig],withLocations->[SegmentLoaderConfig]]] | Creates a new object that represents a single segment load configuration. Get the number of non - zero non - zero non - zero non - zero non -. | What is the purpose to make it a configuration item ? I think if we can make it default to the number of CPU cores? Or can we re-use `numBootstrapThreads` because it is defined as: > How many segments to load concurrently during historical startup. |
@@ -117,6 +117,9 @@ func GetLimitsResourceList(limits *pps.ResourceSpec) (*v1.ResourceList, error) {
func GetPipelineInfoAllowIncomplete(pachClient *client.APIClient, ptr *pps.StoredPipelineInfo) (*pps.PipelineInfo, error) {
result := &pps.PipelineInfo{}
buf := bytes.Buffer{}
+ // ensure we are authorized to read ... | [Error->[Sprintf,WriteString,String],NewBranch,ResourceName,FinishCommit,Warnf,WriteByte,Warningf,Now,Clone,ParseQuantity,Info,NewSystemRepo,TagAnySpan,Put,Error,Ctx,VisitInput,Errorf,Bytes,Wrapf,GetFile,Infof,UpdatePipelineJobState,Grow,ToLower,TimestampProto,Get,NewRepo,ReadWrite,Sprintf,NewSQLTx,Unmarshal,Replace,St... | GetLimitsResourceList returns a list of resources from a pipeline or a list of resources from GetPipelineInfo returns the pipeline spec file from the object store. | previously, the (singular) spec repo gave everyone read permissions While this grants more permissions, it seems like limiting the scope to this function call eliminates any issues (especially considering the caller has the pipeline info with the auth token, too) |
@@ -421,7 +421,7 @@ class AddPeopleDialog extends AbstractAddPeopleDialog<Props, State> {
);
}
- _renderInvitedItem: Object => ?React$Element<*>
+ _renderInvitedItem: Object => React$Element<any> | null
/**
* Renders a single item in the invited {@code FlatList}.
| [No CFG could be retrieved] | Performs a search on the UI and returns a list of items that can be rendered. Displays a single object. | Doesn't `?React$Element<any>` work? |
@@ -12,13 +12,10 @@ module Admin
::Settings::UserExperience.primary_brand_color_hex = settings_params[:primary_brand_color_hex]
::Settings::Authentication.invite_only_mode = settings_params[:invite_only]
::Settings::UserExperience.public = settings_params[:public]
+ settings_params[:ch... | [CreatorSettingsController->[extra_authorization->[has_role?],create->[logo_svg,redirect_to,render,transaction,community_name,message,public,now,primary_brand_color_hex,invite_only_mode,update!],settings_params->[permit],freeze]] | This action creates a new missing - user - id object. | Let's remove these two lines of code from here. Initially I didnt notice that these are in an `ActiveRecord::Base.transaction` which allows for protective blocks where SQL statements are only permanent if they can all succeed as one atomic action. All the assignments in the block are assignments to something other than... |
@@ -520,6 +520,7 @@ namespace System.Drawing.Tests
}
[Fact]
+ [ActiveIssue("https://github.com/dotnet/runtime/issues/56048", TestPlatforms.iOS | TestPlatforms.tvOS | TestPlatforms.MacCatalyst)]
public void FromFile_NullFileName_ThrowsArgumentNullException()
{
As... | [ImageTests->[RemovePropertyItem_NoSuchPropertyItemEmptyMemoryBitmap_ThrowsExternalException->[AnyUnix,RemovePropertyItem,IsDrawingSupported,Assert],GetEncoderParameterList_ReturnsExpected->[AnyUnix,Equal,Single,nameof,Guid,GetImageEncoders,Select,IsNetFramework,IsDrawingSupported,GetEncoderParameterList,Clsid,FormatID... | Checks if the image is not found in the image file. | same here, use `[ConditionalFact(Helpers.IsDrawingSupported)]` instead |
@@ -116,6 +116,8 @@ public class JmsMessageDrivenEndpointParser extends AbstractSingleBeanDefinition
builder.addConstructorArgReference(listenerBeanName);
IntegrationNamespaceUtils.setValueIfAttributeDefined(builder, element, IntegrationNamespaceUtils.AUTO_STARTUP);
IntegrationNamespaceUtils.setValueIfAttribut... | [JmsMessageDrivenEndpointParser->[resolveId->[resolveId]]] | Parses the given element and creates a BeanDefinitionBuilder. This method is used to get the destination attribute and destinationName attribute from the element. This method is called to register the managed bean definition. | Whitespace after `,` |
@@ -935,7 +935,6 @@ class MainCoupledFemDem_Solution:
max_id_properties = prop.Id
props = KratosMultiphysics.Properties(max_id_properties + 1)
self.created_props_id = max_id_properties + 1
- props[KratosDEM.FRICTION] = -0.5773502691896257
props[KratosDEM.STATIC_FRICTI... | [MainCoupledFemDem_Solution->[ExecuteBeforeGeneratingDEM->[ExpandWetNodes],FinalizeSolutionStep->[FinalizeSolutionStep],GenerateDEM->[ComputeSkinSubModelPart],Initialize->[Initialize],InitializeSolutionStep->[InitializeSolutionStep],ExecuteAfterGeneratingDEM->[UpdateDEMVariables,ExtrapolatePressureLoad],Finalize->[Fina... | Creates a list of FEM properties for a DEFE contact. | Are you sure that I have to remove the FRICTION? I tried and I got an error I think :S |
@@ -99,7 +99,12 @@ class CelebA(VisionDataset):
mask = slice(None) if split_ is None else (splits.data == split_).squeeze()
- self.filename = splits.index
+ if mask == slice(None): # if split == all
+ self.filename = splits.index
+ elif len(torch.nonzero(mask)) == 1: # che... | [CelebA->[download->[extractall,ZipFile,print,_check_integrity,join,download_file_from_google_drive],_check_integrity->[splitext,isdir,join,check_integrity],__len__->[len],__getitem__->[append,len,target_transform,tuple,ValueError,format,join,open,transform],_load_csv->[list,fn,tensor,reader,partial,CSV,open,map],extra... | Initialize CelebA from CSV. Add an attribute to the end of the list. | How can this branch be triggered? Each split should always have more than one image right? Or is the fake data in the tests setup in a way that one split only has one image? If so, let's change the test data to make it more realistic. |
@@ -12,7 +12,9 @@ class AutotestSpecsJob < ApplicationJob
server_path = MarkusConfigurator.autotest_server_dir
server_username = MarkusConfigurator.autotest_server_username
server_command = MarkusConfigurator.autotest_server_command
- server_params = { markus_address: markus_address, assignment_id: as... | [AutotestSpecsJob->[perform->[capture3,find,start,join,nil?,exec!,autotest_server_dir,relative_url_root,generate,mktmpdir,exitstatus,short_identifier,autotest_server_username,autotest_server_command,autotest_server_host,capture2e,raise,strip,cp_r],autotest_specs_queue,queue_as]] | Perform the action necessary to run the markus - cluster command. Finds and returns the node id from the server. | Security/JSONLoad: Prefer JSON.parse over JSON.load. |
@@ -290,8 +290,8 @@ public class PaneManager
// get the widgets for the extra source columns to be displayed
ArrayList<Widget> sourceColumns = new ArrayList<>();
additionalSourceCount_ = userPrefs_.panes().getValue().getAdditionalSourceColumns();
- if (additionalSourceCount_ != sourceColumnMa... | [PaneManager->[onLayoutZoomCurrentPane->[getActiveLogicalWindow],equals->[equals],toggleWindowZoom->[equals],restoreTwoColumnLayout->[resizeHorizontally,invalidateSavedLayoutState],onNewSourceColumn->[getValue],manageZoomColumnCommands->[getZoomedColumn,equals],zoomTab->[toggleWindowZoom,activateTab],manageLayoutComman... | Creates the components of the n - tuple. region user methods. | Nit: Extra space after `!=`. |
@@ -153,9 +153,12 @@ public class DeployVMCmd extends BaseAsyncCreateCustomIdCmd implements SecurityG
@Parameter(name = ApiConstants.USER_DATA, type = CommandType.STRING, description = "an optional binary data that can be sent to the virtual machine upon a successful deployment. This binary data must be base64 enc... | [DeployVMCmd->[execute->[getStartVm,getCommandName],getAccountName->[getAccountName],getDetails->[getBootType],getDomainId->[getDomainId]]] | Creates a virtual machine group and a list of security groups to be deployed to. | @bicrxm Can you change this back to key pair |
@@ -70,14 +70,12 @@ static int OpenReceiverChannel(void)
if (BINDINTERFACE[0] != '\0')
{
ptr = BINDINTERFACE;
+ query.ai_flags |= AI_NUMERICHOST;
}
- char servname[PRINTSIZE(CFENGINE_PORT)];
- xsnprintf(servname, sizeof(servname), "%d", CFENGINE_PORT);
-
/* Resolve listening ... | [WaitForIncoming->[recv,FD_ZERO,MAX,assert,FD_SET,FD_ISSET,Log,select,GetSignalPipe],InitServer->[OpenReceiverChannel,listen,GetErrorStr,Log,cf_closesocket,exit],int->[setsockopt,freeaddrinfo,PRINTSIZE,getnameinfo,GetErrorStr,bind,gai_strerror,Log,cf_closesocket,assert,xsnprintf,socket,LogGetGlobalLevel,getaddrinfo]] | OpenReceiverChannel opens a receiver channel for receiving packets. Check if the socket option SO_REUSEADDR is accepted and if so return the address. | We/I don't like assignments inside conditions, but you didn't introduce this. |
@@ -334,6 +334,11 @@ const ConditionDataStruct& data)
Matrix lhs_gauss_behr = ZeroMatrix(TNumNodes*LocalSize,TNumNodes*LocalSize);
ComputeGaussPointBehrSlipLHSContribution( lhs_gauss_behr, data );
lhs_gauss += lhs_gauss_behr;
+
+ // Maybe better with "if (FLAG == set){ etc. } ..."
+ ... | [No CFG could be retrieved] | Compute the conditions for a point - wise linear system. - - - - - - - - - - - - - - - - - -. | I think that you can avoid to create this matrix by directly passing the `lhs_gauss` one. |
@@ -252,9 +252,6 @@ describes.realWin('amp-list component', {
element.setAttribute('src', 'https://new.com/list.json');
list.mutatedAttributesCallback({'src': 'https://new.com/list.json'});
});
- listMock.expects('toggleLoading').withExactArgs(false).once();
- listMock.expects('togglePlaceholde... | [No CFG could be retrieved] | It should fetch and render non - array items and render non - array items. Checks that list. layoutCallback is called after list. render. | these `listMock`s were set twice: once in `expectFetchAndRender` and once in the test itself, but they are only called once. when `rendered_()` returns a promise (`measurePromise`), these conditions fail. |
@@ -730,9 +730,12 @@ public abstract class Run <JobT extends Job<JobT,RunT>,RunT extends Run<JobT,Run
* Gets the string that says how long the build took to run.
*/
public @Nonnull String getDurationString() {
- if(isBuilding())
+ if (hasntStartedYet()) {
+ return Messages.Run_... | [Run->[getIconColor->[getIconColor,isBuilding,getResult],getRootDir->[toString],getACL->[getACL],onLoad->[onLoad],getPreviousBuildInProgress->[getPreviousBuild,_this,isBuilding],getPreviousNotFailedBuild->[getPreviousBuild,getResult],writeLogTo->[getLogInputStream],doBuildTimestamp->[getTime],doConsoleText->[writeLogTo... | Get duration string. | Interesting, why this method such named... |
@@ -198,6 +198,12 @@ class FBetaMeasure(Metric):
precision = precision.mean()
recall = recall.mean()
fscore = fscore.mean()
+ elif self._average == "weighted":
+ weights = true_sum
+ weights_sum = true_sum.sum()
+ precision = (weights * prec... | [_prf_divide->[any],FBetaMeasure->[get_metric->[reset,tolist,mean,sum,RuntimeError,_prf_divide,item],__call__->[,ones_like,unwrap_to_tensors,to,size,max,sum,gold_labels,argmax_predictions,float,zeros,bincount,ConfigurationError],__init__->[ConfigurationError,len]],register] | Returns a tuple of the critical count metrics. | It's possible for this value to be zero, if the metric is called with a completely zero mask - you can use the `_prf_divide` function to guard against this |
@@ -98,6 +98,14 @@ class Metric(ABC):
else:
return self.value() < other
+ def __sub__(self, other: Any) -> float:
+ """
+ Used heavily for assertAlmostEqual.
+ """
+ if not isinstance(other, float):
+ raise TypeError('Metrics.__sub__ is intentionally lim... | [RougeMetric->[compute_many->[RougeMetric]],AverageMetric->[__add__->[AverageMetric],__init__->[as_number]],Metric->[__repr__->[value],__lt__->[value],__float__->[value],__eq__->[value],as_float->[as_number],as_int->[as_number],__str__->[value]],ExactMatchMetric->[compute->[ExactMatchMetric]],BleuMetric->[compute->[Ble... | Return True if self is less than other. | why? is this purely because of the `assertAlmostEqual`? |
@@ -148,7 +148,7 @@ def add_parser(subparsers, parent_parser):
"--stdout",
action="store_true",
default=False,
- help="Print plot specification to stdout.",
+ help="Print plot location to stdout.",
)
plot_show_parser.add_argument(
"--no-csv-header",
| [CmdPLot->[run->[_result_file,_revisions]],add_parser->[add_parser]] | Adds a parser to subparsers to generate a single block of metrics. Add command line options for the given . Add command line options for plot diff. | So this option lets user print the plot as a text to stdout. So, plot by default logs plot location to stdout. When using `--stdout` option, it is the plot file content that will be displayed on stdout. |
@@ -141,7 +141,7 @@ def execute_search(args, parser):
ms = None
if args.regex:
if args.spec:
- ms = ' '.join(args.regex.split('='))
+ ms = MatchSpec(arg2spec(args.regex))
else:
regex = args.regex
if args.full_name:
| [execute_search->[CommandArgumentError,stdout_json,get_index,make_icon_url,compile,join,get_all_extracted_entries,Dist,features,ensure_use_local,ensure_override_channels_requires_channel,set,Package,list,error,append,print,update,get_pkgs,sorted,len,json,repr,new_names,ms_depends,split,search,Resolve,get,disp_features,... | Execute a search command. This function is called when a package depends on another package. s Prints information about a single . | Using `arg2spec` is critical for consistency. This is a bug fix we'd need to do even if this particular PR didn't do it. |
@@ -271,7 +271,7 @@ class StorageAppendBlobTest(StorageTestCase):
source_blob_client = self._create_source_blob(source_blob_data)
source_blob_properties = source_blob_client.get_blob_properties()
sas = source_blob_client.generate_shared_access_signature(
- permission=BlobPermission... | [StorageAppendBlobTest->[test_append_block_from_url_with_source_if_match->[_create_source_blob,assertBlobEqual,_create_blob],test_append_blob_from_bytes_chunked_upload->[assertBlobEqual,_create_blob],test_append_blob_from_0_bytes->[assertBlobEqual,_create_blob],test_append_blob_from_text_with_encoding->[assertBlobEqual... | This test tests append block from url with source blob if modified. Method to call when the object is modified. | Should be `read=True, delete=True` |
@@ -107,6 +107,18 @@ func (s *storeInfo) getLabelValue(key string) string {
return ""
}
+func (s *storeInfo) getLocationID(keys []string) string {
+ id := ""
+ for _, k := range keys {
+ v := s.getLabelValue(k)
+ if len(v) == 0 {
+ return ""
+ }
+ id += s.getLabelValue(k)
+ }
+ return id
+}
+
// StoreStatus... | [resourceScores->[leaderRatio,storageRatio],clone->[clone],resourceRatio->[leaderRatio,storageRatio]] | getLabelValue returns the value of the label with the given key. | can we use v here? |
@@ -45,10 +45,15 @@ public final class DiscoveryStrategyFactory {
* @return the discovery strategy
*/
public static DiscoveryStrategy create(ResourceLoader resourceLoader, Bootstrap bootstrap, Set<Class<? extends Annotation>> initialBeanDefiningAnnotations) {
-
- if (Reflections.isClassLoadable(... | [DiscoveryStrategyFactory->[create->[isClassLoadable,usingJandex,ReflectionDiscoveryStrategy,newInstance]]] | Creates a discovery strategy. | We should not need to use SecurityActions here as we are obtaining a public constructor of a public class. |
@@ -3736,10 +3736,12 @@ obj_comp_cb(tse_task_t *task, void *data)
if (daos_handle_is_valid(obj_auxi->th) &&
!(args->extra_flags & DIOF_CHECK_EXISTENCE) &&
(task->dt_result == 0 ||
- task->dt_result == -DER_NONEXIST))
+ task->dt_result == -DER_NONEXIST)) {
+ obj_addref(obj);
/* Cache ... | [No CFG could be retrieved] | This function is called by the DAO to check if the object is in the queue. Dkey - related functions. | this is unrelated to this PR, but seems bad that return values are never checked here and other places in this function? |
@@ -38,7 +38,7 @@ public:
{ "delete", SEC_CONSOLE, true, &HandleCharacterDeletedDeleteCommand, "" },
{ "list", SEC_ADMINISTRATOR, true, &HandleCharacterDeletedListCommand, "" },
{ "restore", SEC_ADMINISTRATOR, true, &HandleCharacterDelet... | [character_commandscript->[bool->[HandleCharacterDeletedListHelper,getIntConfig,uint32,size,GetPreparedStatement,setUInt16,SendSysMessage,playerLink,setString,HasLowerSecurity,extractPlayerNameFromLink,atoi,PlayerDumpWriter,Fetch,SetAtLoginFlag,GetPlayerAccountIdByGUID,strtok,LookupEntry,GetSession,GetDeletedCharacterI... | Get the commands that can be handled by the system. | you could respect the indentation alignment :P |
@@ -140,11 +140,11 @@ public class CombinedHttpHeadersTest {
assertEquals(HeaderValue.EIGHT.subset(6), headers.getAll(HEADER_NAME));
}
- @Test (expected = NullPointerException.class)
+ @Test
public void addCharSequencesCsvNullValue() {
final CombinedHttpHeaders headers = newCombinedH... | [CombinedHttpHeadersTest->[getAllDontCombineSetCookie->[newCombinedHttpHeaders],nonCombinableHeaderIterator->[newCombinedHttpHeaders],owsTrimming->[newCombinedHttpHeaders],testGetAll->[newCombinedHttpHeaders],valueIterator->[newCombinedHttpHeaders]]] | Add the char sequences in CSV with value containing commas. | Add space after `->`. |
@@ -83,6 +83,10 @@ public class GrokPatternRegistry {
reload();
}
+ public boolean grokPatternExists(String patternName) {
+ return grokPatternService.loadByName(patternName).isPresent();
+ }
+
public Grok cachedGrokForPattern(String pattern) {
return cachedGrokForPattern(patt... | [GrokPatternRegistry->[cachedGrokForPattern->[cachedGrokForPattern],GrokReloader->[load->[patterns]]]] | This method is called when a pattern is deleted from the cache. | This is hitting the database for every pipeline function call. The `GrokPatternRegistry` is using a cache for caching `Grok` instances. I think we need to add a cache for this method as well. Otherwise this can put too much load on the database. |
@@ -36,13 +36,12 @@ class CoursierSubsystem(Subsystem):
register('--fetch-options', type=list, fingerprint=True,
help='Additional options to pass to coursier fetch. See `coursier fetch --help`')
register('--bootstrap-jar-url', fingerprint=True,
- default='https://dl.dropboxuserconten... | [CoursierSubsystem->[bootstrap_coursier->[Error]]] | Register options for Coursier. | Please update this to indicate where this artifact is coming from. It's really disconcerting to be relying on anonymous code, and having a complete list of required PRs to get on master releases (here, or via context at the link) would be good. |
@@ -179,6 +179,16 @@ def get_program_cache_key(feed, fetch_list):
return str(feed_var_names + fetch_var_names)
+class PreparedContext(object):
+ def __init__(self, handle, program, fetch_list, feed_var_name,
+ fetch_var_name):
+ self.handle = handle
+ self.program = program
+ ... | [Executor->[run->[global_scope,get_program_cache_key,as_numpy,run,has_feed_operators,has_fetch_operators,aslodtensor],aslodtensor->[accumulate->[accumulate],parselod->[accumulate],parselod],__init__->[Executor]],as_numpy->[as_numpy],fetch_var->[global_scope,as_numpy],scope_guard->[switch_scope]] | Initialize the object with a list of places. | Are all of them public members? |
@@ -558,7 +558,8 @@ public class PubsubIO {
}
return new Read<>(name,
NestedValueProvider.of(subscription, new SubscriptionTranslator()),
- topic, timestampLabel, coder, idLabel, maxNumRecords, maxReadTime, parseFn);
+ null /* reset topic to null */, timestampLabel, coder, idL... | [PubsubIO->[Write->[populateDisplayData->[populateDisplayData,populateCommonDisplayData],topic->[topic,TopicTranslator],expand->[apply,TopicPathTranslator],PubsubBoundedWriter->[populateDisplayData->[populateDisplayData],publish->[publish,getTopic],processElement->[getAttributeMap,getMessage,apply,getCoder]]],Subscript... | Returns a new read instance with the specified subscription. | Can you format these lines? |
@@ -17,6 +17,10 @@
package readjson
+var (
+ parserCount = 1
+)
+
// Config holds the options a JSON reader.
type Config struct {
MessageKey string `config:"message_key"`
| [No CFG could be retrieved] | Validate validates the given configuration object. | can we remove this? |
@@ -470,6 +470,8 @@ export class AmpIframe extends AMP.BaseElement {
/*opt_allowOpaqueOrigin*/ true
);
+ addEventListener('message', this.listenForPymMessage_.bind(this));
+
if (this.isClickToPlay_) {
listenFor(iframe, 'embed-ready', this.activateIframe_.bind(this));
}
| [No CFG could be retrieved] | Sets the sandbox of the iframe. private private static final int MAX_LENGTH = 1000 ;. | This seems not ideal. There should rather be one single `message` event handler that all of the iframes share. It seems rather that `listenFor` should be used, but the problem is that the Pym.js `event.data` is a string and not an object with any `sentinel`. So there isn't an easy way to integrate with this existing ev... |
@@ -197,3 +197,10 @@ class MockConsole:
def red(self, text):
return self._safe_color(text, red)
+
+
+def mock_goal_options(goal: Type[Goal], scoped_options: Dict[str, Any]) -> Goal.Options:
+ options_container = OptionValueContainer()
+ for option, val in scoped_options.items():
+ setattr(options_contain... | [run_rule->[get],MockConsole->[green->[_safe_color],blue->[_safe_color],red->[_safe_color]],create_scheduler->[init_native]] | Colorized text with red color. | Goal.Options is an (untyped) function, this returns the return type of Goal.Options (which is not a function). Type checking is surely wrong here. |
@@ -359,6 +359,17 @@ class TestBook(unittest.TestCase):
self.assertIsNotNone(indices)
print(str(program))
+ def test_roi_pool(self):
+ print("test_roi_pool")
+ program = Program()
+ with program_guard(program):
+ x = layers.data(name="x", shape=[10, 256, 30, 30... | [TestBook->[test_fit_a_line->[square_error_cost,fc,print,mean,data,str,assertIsNotNone,program_guard,Program],test_get_places->[get_places,print,str,assertIsNotNone,program_guard,Program],test_multiplex->[multiplex,print,data,str,assertIsNotNone,program_guard,Program],test_recognize_digits_conv->[cross_entropy,simple_i... | Test topk of a network. | Remove this line. |
@@ -204,6 +204,7 @@ func Provider() terraform.ResourceProvider {
"aws_ec2_transit_gateway_vpn_attachment": dataSourceAwsEc2TransitGatewayVpnAttachment(),
"aws_ecr_image": dataSourceAwsEcrImage(),
"aws_ecr_repository": dataSourceAwsEcrReposito... | [Printf,Expand,GetOk,Client,List,MultiEnvDefaultFunc,Get,NewMutexKV] | This function is called by the DynamoDbDataSource when it finds a resource in the D Data Source Methods. | Nit: do you mind adding this entry to the list in alphabetical order? |
@@ -126,10 +126,6 @@ module Proofing
end
# rubocop:enable Metrics/MethodLength, Metrics/AbcSize
- def uuid
- SecureRandom.uuid
- end
-
def timeout
(config.verification_request_timeout || 5).to_i
end
| [VerificationRequest->[uuid->[uuid],verification_url->[verification_url]]] | Generate a unique identifier for the current request. | This private method is unused |
@@ -8,9 +8,10 @@ class WatchedWord < ActiveRecord::Base
censor: 2,
require_approval: 3,
flag: 4,
+ link: 8,
replace: 5,
tag: 6,
- silence: 7
+ silence: 7,
)
end
| [WatchedWord->[create_or_update_word->[normalize_word],actions]] | Enumerates all actions that are not in the list of actions. | I think we should order the hash here by the number representing the action code. Another developer might come along and incorrectly use `8` if they do not notice that it has already exists. |
@@ -60,11 +60,14 @@ public class DefaultMultifactorAuthenticationContextValidator implements Authent
LOGGER.debug("No multifactor authentication providers are configured");
return Pair.of(Boolean.FALSE, Optional.empty());
}
- final Optional<MultifactorAuthenticationProvider> re... | [DefaultMultifactorAuthenticationContextValidator->[validate->[toCollection,toArray,equals,getAttributes,findFirst,sortIfNecessary,toString,locateRequestedProvider,containsKey,of,handleUnsatisfiedAuthenticationContext,getSatisfiedAuthenticationProviders,empty,isEmpty,isNotBlank,values,count,debug,isPresent,cast,get,get... | Validate the given authentication. Checks if the requested context is satisfied by the authentication attempt. If it is satisfied the requested. | Needed to unwrap providers if Variegated Provider is found. |
@@ -442,7 +442,7 @@ static int edma_remove(struct dma *dma)
static int edma_interrupt(struct dma_chan_data *channel, enum dma_irq_cmd cmd)
{
- if (channel->status != COMP_STATE_INIT)
+ if (channel->status == COMP_STATE_INIT)
return 0;
switch (cmd) {
| [dma_chan_data->[trace_edma_error,spin_unlock_irq,spin_lock_irq,atomic_add,tracev_edma],void->[trace_edma,spin_lock_irq,spin_unlock_irq,atomic_sub],int->[SGN,edma_encode_tcd_attr,trace_edma_error,MIN,edma_validate_nonsg_config,dma_chan_reg_update_bits,edma_setup_tcd,rzalloc,cb,trace_edma,rfree,timer_get_system,dma_chan... | This function handles the interrupt of the specified channel. | I wonder why do we get an interrupt when state is COMP_STATE_INIT? |
@@ -71,6 +71,7 @@ namespace Dynamo
public CustomNodeManager CustomNodeManager { get; internal set; }
public SearchViewModel SearchViewModel { get; internal set; }
public DynamoViewModel DynamoViewModel { get; internal set; }
+ public PopupViewModel PopupViewmodel { get; internal set; }... | [DynamoController->[RequestRedraw->[OnRequestsRedraw],ClearLog->[ClearLog],DispatchOnUIThread->[OnDispatchedToUI],RunExpression->[RunExpression],EvaluationThread->[RunExpression,OnRunCompleted],Context]] | A DynamoController is a controller for handling the creation of a new . Get the built - in types and functions. | Are these really popups? |
@@ -54,7 +54,16 @@ func bold(v interface{}) string {
return "\033[1m" + toString(v) + "\033[0m"
}
-func convertEnv(env []api.EnvVar) map[string]string {
+// DEPRECATED:
+func convertEnvInternal(env []api.EnvVar) map[string]string {
+ result := make(map[string]string, len(env))
+ for _, e := range env {
+ result[e... | [ParseDockerImageReference,PrioritizeTags,FollowTagReference,Now,IsZero,Set,PathUnescape,Has,Flush,Error,MatchString,Init,NewString,Len,HumanDuration,MustCompile,Sub,NewWriter,Join,Fprintln,WebHookURL,LatestObservedTagGeneration,Split,Fprintf,NewWebhookURLClient,Sprintf,List,String,Insert] | returns a string representation of the unique identifier. formatTime formats the label and the time of the last label in the table. | Is this still used by something? Do we need to keep it? |
@@ -290,6 +290,7 @@ namespace System.Net.Sockets.Tests
Task.Run(() => s.Receive((Span<byte>)buffer, SocketFlags.None));
public override Task<int> SendAsync(Socket s, ArraySegment<byte> buffer) =>
Task.Run(() => s.Send((ReadOnlySpan<byte>)buffer, SocketFlags.None));
+ public ove... | [SocketHelperBase->[Listen->[Listen]],SocketHelperEap->[ReceiveFromAsync->[ReceiveFromAsync],AcceptAsync->[AcceptAsync],InvokeAsync->[Task],SendAsync->[SendAsync],SendToAsync->[SendToAsync],ReceiveAsync->[ReceiveAsync]],SocketHelperApm->[ReceiveFromAsync->[Task]],SocketTestHelperBase->[ReceiveFromAsync->[ReceiveFromAsy... | Send a message asynchronously. | I guess this was missing by mistake. The property seemed useful for my tests. |
@@ -20,10 +20,8 @@ public class CreateProjectCommandHandler implements QuarkusCommand {
@Override
public QuarkusCommandOutcome execute(QuarkusCommandInvocation invocation) throws QuarkusCommandException {
- final ProjectWriter projectWriter = invocation.getProjectWriter();
- if (projectWriter ... | [CreateProjectCommandHandler->[execute->[getBomArtifactId,getBomGroupId,toString,getStringValue,getQuarkusVersion,init,failure,readQuarkusProperties,QuarkusCommandException,replace,setValue,success,completeFile,getProjectWriter,getBomVersion,generate,getBuildFile,IllegalStateException,stripExtensionFrom,substring,getPl... | Execute the add - node command. Returns a new instance of the class that will be used to create the class. | Just a note, previously a single invocation could have been passed to multiple handlers (e.g. create followed by add extensions) that would use the same project writer instance. It doesn't mean it has to stay that way. |
@@ -455,7 +455,12 @@ class ASTConverter:
elif len(current_overload) > 1:
ret.append(OverloadedFuncDef(current_overload))
- if isinstance(stmt, Decorator):
+ # If we have multiple decorated functions named "_" next to each, we want to treat
+ ... | [parse_type_string->[parse_type_comment],parse_type_comment->[parse_type_ignore_tag,ast3_parse],stringify_name->[stringify_name],TypeConverter->[visit_UnaryOp->[invalid_type,visit],visit_Num->[numeric_type],visit_Str->[parse_type_string],visit_Attribute->[invalid_type,visit],_extract_argument_name->[fail],visit_Subscri... | Fix function overloads. | I'm starting to get squeamish about `!= "_"` in a bunch of places. Could you add a function to `sharedparse` named `unnamed_function` or something that does the check? |
@@ -1143,12 +1143,15 @@ int
obj_reply_get_status(crt_rpc_t *rpc)
{
void *reply = crt_reply_get(rpc);
-
+
switch (opc_get(rpc->cr_opc)) {
case DAOS_OBJ_RPC_UPDATE:
case DAOS_OBJ_RPC_TGT_UPDATE:
case DAOS_OBJ_RPC_FETCH:
- return ((struct obj_rw_out *)reply)->orw_ret;
+ {
+ D_DEBUG(DB_IO,"crt_reply: %d, D... | [No CFG could be retrieved] | This function is called from the server to get the status of a specific object. DAO - RPC - ENUMERATE - GET - RPC - GET - RPC - GET. | (style) trailing whitespace |
@@ -37,6 +37,7 @@ import java.util.Arrays;
import java.util.List;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;
+import org.apache.commons.lang3.StringUtils;
public final class IpmitoolOutOfBandManagementDriver extends AdapterBase implements OutOfBandManagementDriver, Configu... | [IpmitoolOutOfBandManagementDriver->[start->[initDriver],execute->[getIpmiUserId,execute],stop->[stopDriver]]] | Imports the ipmitool interface. The IpmiToolRetrrr key is the name of the Ipmi. | please use our own (cloudstack) Stringutils as proxy, even when calling the apache.commons |
@@ -230,7 +230,7 @@ public class ApexGroupByKeyOperator<K, V> implements Operator {
}
StateInternals<K> stateInternals = perKeyStateInternals.get(keyBytes);
if (stateInternals == null) {
- stateInternals = InMemoryStateInternals.forKey(key);
+ stateInternals = stateInternalsFactory.stateInterna... | [ApexGroupByKeyOperator->[processElement->[processElement],ProcessContext->[sideOutputWithTimestamp->[sideOutput]],GroupByKeyStateInternalsFactory->[stateInternalsForKey->[getStateInternalsForKey]],ApexTimerInternals->[setTimer->[registerActiveTimer],deleteTimer->[unregisterActiveTimer]],processWatermark->[getTimersRea... | Get the state internals for the given key. | This is definitely the right place to call this, so presumably having it transient would be fine? But also fine to leave it as-is, because the logic is fine. Just foolproof to make sure you don't accidentally ship up the `StateInternals` with the operator. |
@@ -423,6 +423,8 @@ func (am *MultitenantAlertmanager) setConfig(cfg alerts.AlertConfigDesc) error {
}
func (am *MultitenantAlertmanager) newAlertmanager(userID string, amConfig *amconfig.Config) (*Alertmanager, error) {
+ reg := prometheus.NewRegistry()
+ am.metrics.addUserRegistry(userID, reg)
newAM, err := New... | [Stop->[Stop],syncConfigs->[Stop],setConfig->[createTemplatesFile,transformConfig],ServeHTTP->[ServeHTTP],RegisterFlags->[RegisterFlags]] | newAlertmanager creates a new alert manager with the given configuration. | We need to remove the registry when an alert manager is stopped, otherwise it will leak forever. This could be done in the `deleteUser()`. |
@@ -1,8 +1,13 @@
package util
import (
+ "errors"
+ "net/url"
"reflect"
"strconv"
+ "strings"
+
+ jsoniter "github.com/json-iterator/go"
)
func IsSimpleType(f reflect.Value) bool {
| [FormatBool,Int,FormatInt,FormatUint,Kind,Uint,String,Bool] | IsSimpleTypeimport imports the given reflection type into the parameter list. | This is technically an API break. While I doubt anybody is using it, I would sleep better keeping the two functions exported. Retrospectively, it may should have been an `pkg/bindings/*internal*/util` where we can change whenever we want to. |
@@ -248,7 +248,8 @@ class SessionController < ApplicationController
user = User.find_by_username_or_email(params[:login])
user_presence = user.present? && user.id > 0 && !user.staged
if user_presence
- email_token = user.email_tokens.create(email: user.email)
+ user_agent = request.user_agent |... | [SessionController->[login->[sso_provider],forgot_password->[create]]] | forgot password action. | `(unidentified browser)` should probably be translated using `I18n` here |
@@ -350,7 +350,12 @@ exit:
if (rc == 0) {
/* Exec passed application with rest of arguments */
- execve(g_opt.app_to_exec, &argv[g_opt.app_args_indx], environ);
+ rc = execve(g_opt.app_to_exec, &argv[g_opt.app_args_indx], environ);
+ if (rc == -1)
+ D_ERROR("execve('%s') failed: %s; rc=%d\n",
+ g_opt.a... | [main->[D_GOTO,setenv,MPI_Comm_rank,MPI_Barrier,fprintf,MPI_Comm_size,MPI_Allgather,calloc,show_usage,MPI_Init,MPI_Finalize,parse_args,sprintf,execve,D_ERROR,free,get_self_uri,generate_group_file,access],void->[printf],int->[crt_context_destroy,D_GOTO,strerror,setenv,atoi,getopt_long,crt_finalize,printf,fprintf,strlen,... | This is the entry point for the command line interface. This function is called from the command line. It will retrieve the self uri and generate the. | (style) line over 80 characters |
@@ -1,11 +1,12 @@
from django.contrib import messages
from django.contrib.auth.decorators import permission_required
+from django.contrib.sites.models import Site
from django.contrib.sites.shortcuts import get_current_site
from django.shortcuts import get_object_or_404, redirect
from django.template.response impor... | [index->[get_current_site,redirect],update->[SiteForm,all,TemplateResponse,_,redirect,filter,success,AuthorizationKeyFormSet,SiteSettingForm,save,is_valid,get_object_or_404],permission_required] | Provides a view to edit a single site s authorization key. Show a list of sites. | These messages here are from somewhere else :) |
@@ -39,6 +39,7 @@ import java.util.*;
/**
* Notebook repository sync with remote storage
*/
+@Immediate
public class NotebookRepoSync implements NotebookRepoWithVersionControl {
private static final Logger LOGGER = LoggerFactory.getLogger(NotebookRepoSync.class);
private static final int maxRepoNum = 2;
| [NotebookRepoSync->[deleteNotes->[remove],setNoteRevision->[setNoteRevision,getRepoCount,isRevisionSupportedInRepo,getMaxRepoNum],get->[get,isRevisionSupportedInDefaultRepo],remove->[remove],pushNotes->[save,get],close->[close],move->[move],notesCheckDiff->[get],checkpoint->[getRepoCount,isRevisionSupportedInRepo,get,c... | Package private for testing purposes. Initializes the object with the given configuration. | What is this annotation used for ? |
@@ -0,0 +1,10 @@
+// Copyright 2021 The Gitea Authors. All rights reserved.
+// Use of this source code is governed by a MIT-style
+// license that can be found in the LICENSE file.
+
+package user
+
+const (
+ // SettingsKeyHiddenCommentTypes is the settings key for hidden comment types
+ SettingsKeyHiddenCommentTypes... | [No CFG could be retrieved] | No Summary Found. | I don't think we should use constants, at least, I haven't seen them being used in this way(translation key). |
@@ -12,8 +12,12 @@ module RememberDeviceConcern
def check_remember_device_preference
return unless authentication_context?
return if remember_device_cookie.nil?
- return unless remember_device_cookie.valid_for_user?(current_user)
- handle_valid_otp
+ return unless remember_device_cookie.valid_for_... | [remember_device_cookie_expiration->[from_now],check_remember_device_preference->[authentication_context?,valid_for_user?,nil?],save_remember_device_preference->[encrypted,to_json],remember_device_cookie->[from_json,encrypted,blank?],extend] | check if the user has a lease for remember_device. | This was changed since now `handle_valid_otp` removes the `mfa_device_remembered` flag. |
@@ -25,12 +25,13 @@ from pip._vendor.requests.utils import get_netrc_auth
from pip._vendor.six.moves import xmlrpc_client # type: ignore
from pip._vendor.six.moves.urllib import parse as urllib_parse
from pip._vendor.six.moves.urllib import request as urllib_request
-from pip._vendor.urllib3.util import IS_PYOPENSS... | [PipSession->[__init__->[MultiDomainBasicAuth,SafeFileCache,InsecureHTTPAdapter,LocalFSAdapter,user_agent]],_download_url->[resp_read,written_chunks],MultiDomainBasicAuth->[_get_new_credentials->[_get_keyring_auth,_get_index_url],_get_url_and_credentials->[_get_new_credentials],_prompt_for_password->[_get_keyring_auth]... | Imports the given package. Get a single node from the system. | I'd move it to `src/pip/_internal/utils/compat.py`, just like `WINDOWS` |
@@ -34,7 +34,7 @@ class Services(object):
@staticmethod
def start():
- url = config.get('messaging', 'url')
+ url = Services.get_url()
Services.reply_handler = ReplyHandler(url)
Services.reply_handler.start()
log.info(_('AMQP reply handler started'))
| [Services->[start->[start]],ReplyHandler->[start->[start],succeeded->[_bind_failed,_bind_succeeded,_unbind_succeeded],rejected->[_bind_failed],failed->[_bind_failed]]] | Start the broker reply handler. | Using get_url() is a temporary work around until pulp 3.0 when we can change the pulp configuration files. |
@@ -18,7 +18,7 @@ describe Analytics do
it 'identifies the user and sends the event to the backend' do
user = build_stubbed(:user, uuid: '123')
- analytics = Analytics.new(user, FakeRequest.new)
+ analytics = Analytics.new(user: user, request: FakeRequest.new, sp: 'http://localhost:3000')
... | [user_agent,to,it,new,let,track_event,describe,build_stubbed,host,uuid,before,merge,instance_double,pid,with,remote_ip,require,and_return] | Describe the neccesary conditions for the event tracking. | service_provider from L10 isn't in scope here, right? (learning) |
@@ -10,6 +10,9 @@ if (\LibreNMS\Config::get('enable_bgp')) {
if (!empty($peers)) {
if ($device['os'] == 'junos') {
$peer_data_check = snmpwalk_cache_long_oid($device, 'jnxBgpM2PeerIndex', '.1.3.6.1.4.1.2636.5.1.1.2.1.1.1.14', $peer_data_tmp, 'BGP4-V2-MIB-JUNIPER', 'junos');
+ } elseif ... | [addDataset,getFamily,uncompressed,toSnmpIndex,compressed] | Get the BGP network index for a given device. Collect BGP data from SNMP. | You probably have a typo here. $peer_data_checki is wrong and gives you an empty array. (and you anyway empty the array after). |
@@ -103,7 +103,7 @@ public abstract class AbstractTableFileSystemView implements SyncableFileSystemV
* @param visibleActiveTimeline Visible Active Timeline
*/
protected void refreshTimeline(HoodieTimeline visibleActiveTimeline) {
- this.visibleCommitsAndCompactionTimeline = visibleActiveTimeline.getCommit... | [AbstractTableFileSystemView->[getLatestFileSlicesBeforeOrOn->[ensurePartitionLoadedCorrectly],getBaseFileOn->[ensurePartitionLoadedCorrectly],fetchMergedFileSlice->[getPendingCompactionOperationWithInstant,mergeCompactionPendingFileSlices],getLatestBaseFile->[ensurePartitionLoadedCorrectly],getLatestBaseFilesBeforeOrO... | Refresh the visible commit timeline. | This name irks me `getCommitsReplaceAndCompactionTimeline`..we should introduce another hierarchy to group our actions, {commit, delta, compaction, replace} introduce new file groups, {rollback, restore, clean} remove file groups etc. Need to think more |
@@ -50,8 +50,6 @@ namespace System.Text.Tests
[InlineData('\u0130', '\u0130', '\u0130')] // U+0130 LATIN CAPITAL LETTER I WITH DOT ABOVE
[InlineData('\u0131', '\u0131', '\u0131')] // U+0131 LATIN SMALL LETTER DOTLESS I
[InlineData('\u1E9E', '\u1E9E', '\u1E9E')] // U+1E9E LATIN CAPITAL LETTER ... | [RuneTests->[GetNumericValue->[GetNumericValue],GetUnicodeCategory_AllInputs->[GetUnicodeCategory],IsLetter->[IsLetter],IsSeparator->[IsSeparator],IsWhiteSpace_AllInputs->[IsWhiteSpace],GetUnicodeCategory->[GetUnicodeCategory],IsLetterOrDigit->[IsLetterOrDigit],IsLower->[IsLower],IsDigit->[IsDigit],DecodeFromUtf16->[De... | Tests that the given unicode sequence is within the range [ 0 - 9 ). | Should we move this to `MemberData` and condition these two test cases to run when `!IsNlsGlobalization` |
@@ -113,7 +113,7 @@ namespace Microsoft.Xna.Framework.Graphics
Attributes[a].location = reader.ReadInt16();
}
- PlatformConstruct(isVertexShader, shaderBytecode);
+ PlatformConstruct(Stage, shaderBytecode);
}
internal protected override void Grap... | [Shader->[GraphicsDeviceResetting->[PlatformGraphicsDeviceResetting],PlatformProfile,MaxMipLevel,samplerSlot,parameter,textureSlot,Vertex,name,location,Filter,AddressV,ReadBoolean,ReadBytes,Pixel,type,ReadByte,ReadString,PlatformConstruct,BorderColor,MipMapLevelOfDetailBias,index,state,usage,ReadInt16,ReadInt32,Address... | Override this method to reset the state of the graphics device. | This was a convenient change which seemed good for future support of other shader stages. |
@@ -50,7 +50,9 @@ $params = array(
'content' => $content,
'sidebar' => $sidebar,
'title' => $group->name,
+ 'entity' => $group,
+ 'filter' => '',
);
-$body = elgg_view_layout('one_sidebar', $params);
+$body = elgg_view_layout('content', $params);
echo elgg_view_page($group->name, $body);
\ No newline at end o... | [getMethodsAsDeprecatedGlobal] | View one sidebar. | We definitely can't switch a layout in a minor release. |
@@ -174,4 +174,10 @@ public class DefaultTriggerTest {
public void testContinuation() throws Exception {
assertEquals(DefaultTrigger.of(), DefaultTrigger.of().getContinuationTrigger());
}
+
+ @Test
+ public void testToString() {
+ Trigger trigger = DefaultTrigger.of();
+ assertEquals("Repeatedly.fore... | [DefaultTriggerTest->[testDefaultTriggerFixedWindows->[assertTrue,Instant,injectElements,of,IntervalWindow,isMarkedFinished,fireIfShouldFire,forTrigger,millis,advanceInputWatermark,shouldFire,assertFalse],testContinuation->[assertEquals,of,getContinuationTrigger],testDefaultTriggerSessions->[assertTrue,Instant,injectEl... | Test continuation trigger. | This could just be `"DefaultTrigger.of()"`? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.