patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -1500,6 +1500,15 @@ define([
}
this._pickIds = undefined;
+ //These objects may be fairly large and reference other large objects (like Entities)
+ //We explicitly set them to undefined here so that the memory can be freed
+ //even if a reference to the destroyed Primitive ha... | [No CFG could be retrieved] | Destroy the object and all of its child objects. | I wonder if `destroyObject` should wipe out all keys in any destroyed object. Performance hit but potential GC gain? |
@@ -98,6 +98,15 @@ registries = ['{{.Host}}:{{.Port}}']`
Expect(search.LineInOutputContains("quay.io/libpod/gate")).To(BeTrue())
})
+ It("podman search image with description", func() {
+ search := podmanTest.Podman([]string{"search", "quay.io/libpod/whalesay"})
+ search.WaitWithDefaultTimeout()
+ Expect(sear... | [Address->[Sprintf],setRegistriesConfigEnv,Unlock,ErrorToString,Podman,Exit,ShouldNot,Atoi,WriteFile,WaitWithDefaultTimeout,Should,New,To,SeedImages,Address,Bytes,OutputToStringArray,Cleanup,ExitCode,Execute,Must,ErrorGrepString,RestoreArtifact,PodmanNoCache,GrepString,Sprintf,OutputToString,Parse,LineInOutputContains,... | NumberOfImages - > sequence number There are many cases where the user does not want to see the number of unique identifiers in. | nit: we could avoid the Sprintf here right? |
@@ -164,11 +164,6 @@ func (c *RouterController) HandleRoute() {
c.lock.Lock()
defer c.lock.Unlock()
- // Change the local sync state within the lock to ensure that all
- // event handlers have the same view of sync state.
- c.routesListConsumed = c.RoutesListConsumed()
- c.updateLastSyncProcessed()
-
glog.V(4).... | [HandleNode->[HandleNode],watchForFirstSync->[handleFirstSync],HandleRoute->[HandleRoute],HandleNamespaces->[HandleNamespaces],HandleEndpoints->[HandleEndpoints]] | HandleRoute is the main entry point for the router controller. It is called by the router. | Maybe move the `[defer] c.lock.{Lock,UnLock}` to after the Info log messages. |
@@ -36,6 +36,8 @@ import java.util.concurrent.ConcurrentMap;
*/
public class ConsistentHashLoadBalance extends AbstractLoadBalance {
+ public static final String NAME = "consistenthash";
+
private final ConcurrentMap<String, ConsistentHashSelector<?>> selectors = new ConcurrentHashMap<String, ConsistentHas... | [ConsistentHashLoadBalance->[ConsistentHashSelector->[select->[toKey,getArguments,selectForKey,hash,md5],md5->[reset,getMessage,digest,IllegalStateException,update,getInstance,getBytes],toKey->[append,toString,StringBuilder],selectForKey->[firstKey,get,isEmpty,tailMap,containsKey],getMethodParameter,split,getAddress,pa... | Select an invocation from the given list of invokers. | Is this line you added is useless? @dchack |
@@ -198,8 +198,12 @@ public class BytecodeVisitor extends ClassVisitor {
Preconditions.checkNotNull(desc);
if (isNotSynthetic(flags)) {
//Flags from asm lib are defined in Opcodes class and map to flags defined in Flags class
- final JavaSymbol.VariableJavaSymbol symbol = new JavaSymbol.VariableJa... | [BytecodeVisitor->[defineOuterClass->[getClassSymbol],convertAsmType->[getClassSymbol,convertAsmType],ReadGenericSignature->[boundVisitor->[visitEnd->[visitEnd]],visitClassType->[getClassSymbol],visitSuperclass->[visitEnd->[visitEnd]],visitInterface->[visitEnd->[visitEnd]]],visitMethod->[isNotSynthetic],ReadType->[visi... | Visits a field. | it should be dropped and GC anyway, but I would avoid creating a variable if it is of no use. |
@@ -86,7 +86,7 @@ func getNotifications(c *context.Context) {
// redirect to last page if request page is more than total pages
pager := context.NewPagination(int(total), perPage, page, 5)
if pager.Paginater.Current() < page {
- c.Redirect(fmt.Sprintf("/notifications?q=%s&page=%d", c.FormString("q"), pager.Pagin... | [GetNotificationCount,LoadAttributes,Redirect,HasPrefix,FormInt,HTML,Error,New,SetDefaultParams,FormString,LoadComments,FormInt64,Tr,ServerError,PostFormValue,Written,Current,FormTrim,UpdateNotificationStatuses,LoadIssues,Sprintf,LoadRepos,SetNotificationStatus,NotificationsForUser,Without,FormBool,NewPagination] | getNotifications retrieves the notification object from the request. missing parts - check the logs. | And now it suddenly hasn't anymore? At least one of the two is going to cause problems. |
@@ -1270,7 +1270,12 @@ define([
corridor.material = Color.WHITE;
corridor.width = 1.0;
}
+ corridor.zIndex = zIndex;
} else {
+ if (defined(zIndex)) {
+ oneTimeWarning('kml-gx:drawOrder', 'KML - gx:drawOrder is not supported in... | [No CFG could be retrieved] | Creates a position property from a position property array and a altitude mode. create a single label and a single billboard. | Maybe extend this message to say "when clampToGround is false". |
@@ -91,12 +91,15 @@ public final class MaterializationInfo {
/**
* Adds an aggregate map transform for mapping final result of complex aggregates (e.g. avg)
*
- * @param aggregatesInfo descriptor of aggregation functions.
+ * @param aggregator descriptor of aggregation functions.
* @param... | [MaterializationInfo->[SqlPredicateInfo->[visit->[visit]],AggregateMapInfo->[visit->[visit]],Builder->[build->[MaterializationInfo]],ProjectInfo->[visit->[visit]]]] | Maps aggregates. | nit: description should be updated |
@@ -1100,7 +1100,7 @@ var inputType = {
* Can be interpolated.
* @param {string=} step Sets the `step` validation to ensure that the value entered matches the `step`
* Can be interpolated.
- * @param {string=} ngChange AngularJS expression to be executed when the ngModel ... | [No CFG could be retrieved] | Reserved element type. Requires a form with a single national number. | Nit: Can you align this line right under `ngChange` (to be consistent with the rest)? |
@@ -81,7 +81,7 @@ feature 'LOA1 Single Sign On' do
it 'user can view and confirm personal key during sign up', :js do
allow(FeatureManagement).to receive(:prefill_otp_codes?).and_return(true)
user = create(:user, :with_phone)
- code = 'ABC1-DEF2-GHI3-JKL4'
+ code = 'ABC1-DEF2-GH13-JK14'
... | [sign_in_and_require_viewing_personal_key->[visit,env,login_as,on_next_request],enter_personal_key_words_on_modal->[fill_in],stub_personal_key->[to,instance_double,and_return],visit,email,password,create,let,to_not,feature,join,it,fill_in_credentials_and_submit,enter_personal_key_words_on_modal,friendly_name,root_url,t... | shows user the start page without accordion and requires user to view and confirm personal after session timeout. | What was the reason for changing this? |
@@ -167,9 +167,10 @@ def test_invalid_package(rule_runner) -> None:
)
assert maybe_info.info is None
assert maybe_info.exit_code == 1
- assert maybe_info.stderr == "bad.go:1:1: expected 'package', found invalid\n"
+ assert "bad.go:1:1: expected 'package', found invalid\n" in maybe_info.stderr
+... | [rule_runner->[QueryRule,rules,set_options,RuleRunner],test_package_info->[assert_info->[request,PathGlobs,tuple,FirstPartyPkgInfoRequest,Address],write_files,assert_info,dedent],test_invalid_package->[dedent,request,write_files,FirstPartyPkgInfoRequest,Address],test_cgo_not_supported->[dedent,request,write_files,engin... | Test if package is invalid. | I've made the analyzer ignore cgo for now. I plan to address cgo analysis in a separate PR. |
@@ -52,15 +52,13 @@ public class RootUrlNotSetMonitor extends AdministrativeMonitor {
@Override
public boolean isActivated() {
JenkinsLocationConfiguration loc = JenkinsLocationConfiguration.get();
- return loc != null && (
- loc.getUrl() == null || !UrlHelper.isValidRootUrl(loc... | [RootUrlNotSetMonitor->[isActivated->[isValidRootUrl,get,getUrl],getDisplayName->[RootUrlNotSetMonitor_DisplayName],isUrlNull->[get,getUrl]]] | Checks if the configuration is activated. | If you don't need the null check on `loc` here than can you remove it from `isActivated` as well? Looks like it is `@CheckForNull` so I think you want to add it back. |
@@ -69,6 +69,8 @@ def plot_epochs_image(epochs, picks=None, sigma=0., vmin=None,
Figure instance to draw the image to. Figure must contain two axes for
drawing the single trials and evoked responses. If None a new figure is
created. Defaults to None.
+ logscale : bool
+ Plots logar... | [_plot_onkey->[_plot_traces,_plot_window],_mouse_click->[plot_epochs_image,_pick_bad_epochs,_plot_window],_toggle_labels->[_plot_vert_lines],_epochs_navigation_onclick->[_draw_epochs_axes]] | Plots a series of epochs on a single - channel image. Plots a list of matplotlib figures and plots a single channel displayed . Plot the nanoseconds of the data. Plots the missing - block block layout. | add: Defaults to False. |
@@ -109,4 +109,4 @@ class ShellTask(prefect.Task):
if self.return_all:
return lines
else:
- return line
+ return lines[-1]
| [ShellTask->[__init__->[super],run->[TypeError,NamedTemporaryFile,write,debug,error,append,flush,FAIL,update,copy,decode,wait,Popen,iter,format,encode],defaults_from_attrs]] | Runs a shell command and returns the result of the shell command. | Hey @RoyalTS ! Good catch -> I think the appropriate fix here is to pre-define the `line` variable in line 95, prior to the iteration. The reason this is failing tests is because the `lines` list is _only_ appended to whenever `return_all` is `True`. |
@@ -69,7 +69,7 @@ export class LogsPage extends React.Component<ILogsPageProps, ILogsPageState> {
const loggers = logs ? logs.loggers : {};
return (
<div>
- <h2><Translate contentKey="logs.title">Logs</Translate></h2>
+ <h2 id="page-heading"><Translate contentKey="logs.title">Logs</... | [No CFG could be retrieved] | Displays a dropdown of the n - tuple of log - n - tuple of loggers that can Displays debug info warning or error log messages. | since we are using a generic id on all pages may better to use it as className rather than id |
@@ -1,5 +1,6 @@
package migrations_test
+/*
import (
"fmt"
"testing"
| [Before,Exec,BootstrapThrowawayORM,RawDB,MigrateTo,Now,Find,Migrate,Error,NewTime,New,NewV4,NewLink,Skip,After,HasTable,Create,Equal,Hex,NoError,Where,NewBytes32ID,Update,Sprintf,Table,NewID,String,Model,True] | TestMigrate_Migrations tests that the specified migrations are run. TestMigrate_Migration1560881855 tests migration for 1560924400 migration. | doesn't make sense to spend the effort to migrate the v1 migrations to gorm v2 (we'd also need a parallel set of test utilities like BootstrapThrowawayORM etc.), perhaps I just remove this file? |
@@ -116,6 +116,10 @@ public final class RequestConnectionParams {
return connectionIdleTimeout;
}
+ public Integer getResponseBufferSize() {
+ return responseBufferSize;
+ }
+
public TcpClientSocketProperties getClientSocketProperties() {
return clientSocketProperties;
}
| [No CFG could be retrieved] | This method is used to set the connection idle timeout. | Can't `int` be used? |
@@ -731,7 +731,7 @@ namespace Content.Server.GameTicking
if (LobbyEnabled && _roundStartCountdownHasNotStartedYetDueToNoPlayers)
{
_roundStartCountdownHasNotStartedYetDueToNoPlayers = false;
- _roundStartTimeUtc = DateTime.UtcNow ... | [GameTicker->[ToggleDisallowLateJoin->[UpdateLateJoinStatus],SetStartPreset->[SetStartPreset,TryGetPreset,StartRound],SpawnPlayer->[SpawnPlayer,ApplyCharacterProfile,MakeObserve],Initialize->[Initialize],PlayerStatusChanged->[PlayerStatusChanged],TogglePause->[PauseStart],StartRound->[RestartRound,ReqWindowAttentionAll... | Override this method to handle the case where the player is left or left. | [same thing as before] |
@@ -20,11 +20,11 @@ jetpack_register_block(
*
* @return string
*/
-function jetpack_business_hours_render( $attributes, $content ) {
+function jetpack_business_hours_render( $attributes ) {
global $wp_locale;
if ( empty( $attributes['days'] ) || ! is_array( $attributes['days'] ) ) {
- return $content;
+ $... | [jetpack_business_hours_render->[get_weekday]] | Renders the jetpack - business - hours tag Displays a Business Hours block. | Since you are removing this parameter, you'll want to update the docblock as well. |
@@ -77,7 +77,7 @@ public class EntrySetCommand<K, V> extends AbstractLocalCommand implements Visit
@Override
public CloseableIterator<CacheEntry<K, V>> iterator() {
Iterator<CacheEntry<K, V>> iterator = new DataContainerRemoveIterator<>(cache);
- return new EntryWrapperIterator<>(cache, ... | [EntrySetCommand->[EntryWrapper->[setValue->[setValue]],BackingEntrySet->[size->[size],stream->[getConsistentHash,stream],spliterator->[spliterator,iterator],remove->[remove],parallelStream->[getConsistentHash,stream]],EntryWrapperIterator->[remove->[remove],next->[next],hasNext->[hasNext]]]] | Iterator for the entries in the cache. | What happened to the forwarding entry? |
@@ -47,9 +47,7 @@ public class FileNamespaceHandlerTestCase extends AbstractServiceAndFlowTestCase
@Override
protected void doTearDown() throws Exception
{
- File workDir = new File(".mule");
- assertTrue(FileUtils.deleteTree(workDir));
-
+ assertTrue(FileUtils.deleteTree(getWorkingD... | [FileNamespaceHandlerTestCase->[doTearDown->[doTearDown]]] | Test if the configuration is not null. | This should not longer be necessary, as it's already done on when destroying the context |
@@ -1514,9 +1514,10 @@ public class TriggerAttachment extends AbstractTriggerAttachment {
change.add(
ChangeFactory.attachmentPropertyChange(attachment, newValue, property.getFirst(), clearFirst));
}
- bridge.getHistoryWriter().startEvent(MyFormatter.attachmentN... | [TriggerAttachment->[prodFrontierEditMatch->[getProductionRule],triggerVictory->[getVictory,getPlayers],techAvailableMatch->[getAvailableTech],triggerResourceChange->[getPlayers,getResourceCount,triggerResourceChange,getResource],triggerProductionChange->[getPlayers,getFrontier],territoryEffectPropertyMatch->[getTerrit... | Triggers a relationship type property change. This method is called when a territory is being changed. | `String.format()` would help here as well, even though this line doesn't really have anything to do with the rest of the refatoring |
@@ -1,8 +1,6 @@
# -*- coding: utf-8 -*-
from settings import * # noqa
-from django.utils.functional import lazy
-
# Make sure the app needed to test translations is present.
INSTALLED_APPS += TEST_INSTALLED_APPS
| [MockProductDetails->[__init__->[update],dict,now],MockProductDetails,get] | Creates a new object. This function is used to set the default values for the given unittefacts. | ugh, we should add this file to the pep8 checking command |
@@ -5969,7 +5969,7 @@ uint64_t wallet2::balance(uint32_t index_major, bool strict) const
return amount;
}
//----------------------------------------------------------------------------------------------------
-uint64_t wallet2::unlocked_balance(uint32_t index_major, bool strict, uint64_t *blocks_to_unlock, uint64_... | [No CFG could be retrieved] | cache_file_data - optional cache file data return the number of blocks to unlock for a given subaddress. | Why was const removed from all of these functions? |
@@ -39,3 +39,4 @@ class PyPylint(PythonPackage):
depends_on('py-configparser', when='^python@:2.8', type=('build', 'run'))
depends_on('py-backports-functools-lru-cache', when='^python@:2.8', type=('build', 'run'))
depends_on('py-singledispatch', when='^python@:3.3.99', type=('build', 'run'))
+ depends... | [PyPylint->[depends_on,version,extends]] | This is a hack to allow the build to be run on the same machine as the build. | Need setuptools-scm build dep |
@@ -46,6 +46,7 @@ public class HoodieLogFormatReader implements HoodieLogFormat.Reader {
this.readBlocksLazily = readBlocksLazily;
this.reverseLogReader = reverseLogReader;
this.bufferSize = bufferSize;
+ this.prevReadersInOpenState = new ArrayList<>();
if (logFiles.size() > 0) {
HoodieLog... | [HoodieLogFormatReader->[close->[close],getLogFile->[getLogFile],next->[next],hasNext->[hasNext]]] | PUBLIC METHODS For reading a list of Hoodie log files. This method is called when there is no next log record in the log file. | @bvaradar We cannot have a list of these readers here. Each reader opens a BufferedInputStream, in the event of a large number of readers (for many log files), the wrapper will hold a reference to all these readers and eventually this results in OOM. |
@@ -104,7 +104,8 @@ public class Preferences extends AppCompatPreferenceActivity implements Preferen
private static final String [] sCollectionPreferences = {"showEstimates", "showProgress",
"learnCutoff", "timeLimit", "useCurrent", "newSpread", "dayOffset", "schedVer"};
-
+ private static int RE... | [Preferences->[initSubscreen->[getCol,getPreferenceScreen,addPreferencesFromResource,getPreferenceSubscreenIntent],getCol->[getCol],getCustomFonts->[getCustomFonts],SettingsFragment->[onPause->[onPause],onCreate->[onCreate,getPreferenceScreen,initSubscreen,initAllPreferences],onResume->[onResume,updatePreference],onSha... | Override onCreate to enable the theme legacy button and display home button. | What's the purpose of this? Mostly the `static` declaration and the default value? Feels like it'd be better as an instance variable |
@@ -149,9 +149,6 @@ func TestSeitanKnownSamples(t *testing.T) {
require.Equal(t, "Edwin Powell Hubble", labelSms.F)
require.Equal(t, "+48123ZZ3045", labelSms.N)
- // Packing struct is non-deterministic as far as field ordering is
- // concerned, so we will not be able to get same ciphertext here.
-
peiKey2, _, ... | [GetUID,Now,False,decryptIKeyAndLabelWithSecretKey,generatePackedEncryptedIKeyWithSecretKey,GenerateTeamInviteID,GenerateAcceptanceKey,Logf,EqualValues,Unix,Equal,Cleanup,V1,PerTeamKeyGeneration,V,NoError,NewSeitanIKeyLabelWithSms,DecodeString,NotZero,Sms,DecryptIKeyAndLabel,GenerateSIKey,String,GeneratePackedEncrypted... | Check that all the fields of a SeitanIKey and SeitanIKey TestIsSeitanyAndAlphabetCoverage tests two unrelated things at once. | ciphertext is compared at line 160 `require.Equal(t, peiKey.EncryptedIKeyAndLabel, peiKey2.EncryptedIKeyAndLabel)` |
@@ -4,6 +4,8 @@
// Changes to this file must follow the https://aka.ms/api-review process.
// ------------------------------------------------------------------------------
+using System.Diagnostics.CodeAnalysis;
+
namespace System.Diagnostics
{
public partial class Activity : IDisposable
| [Activity->[SetParentId->[None]],ActivitySource->[StartActivity->[Internal]]] | Creates an object that represents an activity in the system. - > string?. | Is it typical to add `using` statements in `ref` files? I thought we left everything fully-qualified. |
@@ -516,7 +516,10 @@ class SignupView(BaseSignupView):
label = _('%(email)s Unverified')
next_email = email_address['email']
choices.append((next_email, label % {'email': next_email}))
- choices.append((form.other_email_value, _('Other:')))
+ ... | [revision_by_distinct_doc->[sorted,setdefault],user_detail->[render,get_object_or_404],my_detail_page->[redirect],ban_user_and_cleanup_summary->[revision_by_distinct_doc,filter,delete_document,timedelta,refresh_from_db,defer,prefetch_related,revert_document,list,RevisionAkismetSubmissionSpamForm,UserBan,append,getlist,... | Returns a form object that can be used to sign up a user. Build the choice list with the given email addresses. | I think we should require that users signing up with github have at least one verified email, and present a message to them asking that they go verify their email with github in order to sign up for MDN if there aren't any. Ideally a user signing up with github should never type an email address into an MDN form. |
@@ -8,11 +8,15 @@ using System.Diagnostics;
using System.Runtime.CompilerServices;
using System.Runtime.InteropServices;
using System.Text.Unicode;
+
+#if SYSTEM_PRIVATE_CORELIB
using Internal.Runtime.CompilerServices;
+#endif
#pragma warning disable 0809 //warning CS0809: Obsolete member 'Utf8Span.Equals(objec... | [No CFG could be retrieved] | Creates a new object that represents a well - formed UTF - 8 string or UTF - 8 region Private methods. | These same defines exist in a bunch of the _Utf8Utility.\*.cs_ and _Utf8.\*.cs_ files. Are we sure the behavior will be correct for all bitnesses when running on .NET Framework? |
@@ -14,14 +14,13 @@ describe GradeEntryFormsController do
context 'CSV_Uploads' do
before :each do
@file_without_extension =
- fixture_file_upload('files/grade_entry_upload_empty_file',
- 'text/xml')
+ fixture_file_upload('files/empty_file','text/xml')
@fil... | [create,let,to_not,describe,fixture_file_upload,first,it,to,before,post,second,with,require,puts,redirect_to,short_identifier,context,render,build,grades_grade_entry_form_path,get,get_csv_grades_report,eq,and_return] | Creates a list of all grade entry forms and files. accepts valid file and does not accept csv file with an invalid username. | Space missing after comma. |
@@ -166,7 +166,7 @@ oauthConfig:
name: ""
provider:
apiVersion: v1
- attributes:
+ attributeMappings:
email: null
id: null
name: null
| [JSONToYAML,Fatal,Errorf,StringDiff,Encode] | This function is used to provide a list of all the possible configuration options for a cluster. A list of all of the information in the NI - NI - NI -. | the serialized field should not have been renamed... need to revert |
@@ -158,6 +158,17 @@ class RaidenService(object):
private_key = PrivateKey(private_key_bin)
pubkey = private_key.public_key.format(compressed=False)
+ protocol = RaidenProtocol(
+ transport,
+ discovery,
+ self,
+ config['protocol']['retry_interval'... | [RaidenMessageHandler->[message_secret->[register_secret,handle_secret],message_mediatedtransfer->[mediate_mediated_transfer,target_mediated_transfer],message_revealsecret->[register_secret]],StateMachineEventHandler->[handle_tokenadded->[register_channel_manager],handle_settled->[find_channel_by_address],handle_withdr... | Initialize the object. Initialize the object with a object. | Wouldn't it be nice to reduce the number of arguments here by providing `config['protocol']` as the only config argument and then inside the `RaidenProtocol` `init()` function just read the config dictionary? |
@@ -12,10 +12,10 @@ class NotesController < ApplicationController
@highlight_field = params[:highlight_field]
@number_of_notes_field = params[:number_of_notes_field]
- @notes = Note.all(:conditions => {:noteable_id => @noteable.id,
- :noteable_type => @noteable.class.... | [NotesController->[destroy->[destroy],retrieve_groupings->[new],new_retrieve->[retrieve_groupings],create->[new],new->[new]]] | This action is called when the user clicks on a new node in the notes dialog. It. | Align the elements of a hash literal if they span more than one line.<br>Space inside } missing. |
@@ -1230,10 +1230,11 @@ class DataflowRunner(PipelineRunner):
if transform.source.id_label:
step.add_property(
PropertyNames.PUBSUB_ID_LABEL, transform.source.id_label)
- if transform.source.with_attributes:
- # Setting this property signals Dataflow runner to return full
- ... | [_DataflowIterableAsMultimapSideInput->[__init__->[_side_input_data]],_DataflowIterableSideInput->[__init__->[_side_input_data]],DataflowRunner->[run_Flatten->[_get_encoded_output_coder,_add_step],run_Impulse->[_get_encoded_output_coder,_add_step],poll_for_job_completion->[rank_error],run_Read->[_get_cloud_encoding,_ad... | Runs a read - node validation step. Add missing properties to BigQuery source. Adds missing properties to the next transform step. | Do you know if there's any significant perf hit due to pulling in full messages instead of just data ? |
@@ -79,13 +79,14 @@ class AmpFitText extends AMP.BaseElement {
}
/** @override */
- prerenderAllowed() {
+ isRelayoutNeeded() {
return true;
}
/** @override */
- isRelayoutNeeded() {
- return true;
+ prerenderCallback() {
+ this.updateFontSize_();
+ return Promise.resolve();
}
... | [No CFG could be retrieved] | Creates the content and measurer elements. Calculates the font size of an element in the DOM. | In other words, you just want to call `this.layoutCallback` from here, right? I think it's better to be explicit here. |
@@ -155,5 +155,6 @@ var (
mainnetV1_3 = MustNewInstance(4, 250, 170, numeric.OneDec(), genesis.HarmonyAccounts, genesis.FoundationalNodeAccountsV1_3, mainnetReshardingEpoch, MainnetSchedule.BlocksPerEpoch())
mainnetV1_4 = MustNewInstance(4, 250, 170, numeric.OneDec(), genesis.HarmonyAccounts, genesis.FoundationalNo... | [EpochLastBlock->[BlocksPerEpoch],CalcEpochNumber->[BlocksPerEpoch],IsLastBlock->[BlocksPerEpoch],BlocksPerEpoch] | Version 1. 0 - > 1. 0 - > 1. 0 - > 1. | shall we use prestaking epoch here? |
@@ -73,8 +73,6 @@ type Host interface {
// EnsurePlugins ensures all plugins in the given array are loaded and ready to use. If any plugins are missing,
// and/or there are errors loading one or more plugins, a non-nil error is returned.
EnsurePlugins(plugins []workspace.PluginInfo, kinds Flags) error
- // GetRe... | [GetRequiredPlugins->[LanguageRuntime,GetRequiredPlugins],EnsurePlugins->[LanguageRuntime,Analyzer,Provider],LanguageRuntime->[loadPlugin],SignalCancellation->[SignalCancellation,loadPlugin],CloseProvider->[loadPlugin],Close->[Close],Analyzer->[loadPlugin],Provider->[loadPlugin],PolicyAnalyzer->[loadPlugin]] | Returns the server address of the host that the is associated with. A simple helper to create a new instance of the class. | Do you have any ideas on how we could integrate automatic plugin acquisition with the new world? Today, it's annoying but I think most users will be able to bear. As multi-lang and component consumption become more common, hand managing dependencies in this execution mode becomes problematic. |
@@ -6220,7 +6220,7 @@ import(""FFITarget.dll"");
TestFrameWork.Verify(mirror, "v", 3);
TestFrameWork.Verify(mirror, "w", 3);
TestFrameWork.Verify(mirror, "x", new object[] { 1, 1 });
- TestFrameWork.Verify(mirror, "y", 3);
+ TestFrameWork.Verify(mirror, "y", ... | [TypeSystemTests->[TS038_Param_single_AlltypeTo_UserDefined->[RunScriptSource,Verify],TS0198_method_resolution_1467273_3->[RunScriptSource,Verify],TS0160_Param_eachType_Heterogenous_Array_To_VarArray->[RunScriptSource,Verify],TS019_conditional_cantevaluate_1465293_3->[RunScriptSource,Verify],TS200_memberproperty_146748... | TS0198_method_resolution_1467273_3 Test method for replication. | Is this a change in behavior here? |
@@ -92,6 +92,7 @@ func AutodiscoverBuilder(bus bus.Bus, uuid uuid.UUID, c *common.Config) (autodis
builders: builders,
appenders: appenders,
discovery: discovery,
+ keystore: keystore,
}, nil
}
| [Start->[Start,BusEvent,Events,publish],Stop->[Stop],publish->[GetConfig,Publish,Append],Unpack,NewAppenders,NewConfigMapper,AddProvider,NewBuilders,Errorf,Wrap] | Start starts the discovery service. | you are not passing the keystore in jolokia events, should we add that too? |
@@ -41,7 +41,13 @@ public class Main
builder.withDescription("Druid command-line runner.")
.withDefaultCommand(Help.class)
- .withCommands(Help.class);
+ .withCommands(Help.class, Version.class);
+
+ Runnable cmd = builder.build().parse(args);
+ if (cmd instanceof Version) {... | [Main->[main->[getMessage,getFromExtensions,build,parse,println,addCommands,getInstance,run,withCommands,injectMembers,builder,makeStartupInjector]]] | Entry point for the Druid command - line tool. if the command fails print the error message. | This type of logic should exist within the Version class and not here |
@@ -127,10 +127,10 @@ bool GameEventMgr::StartEvent(uint16 event_id, bool overwrite)
if (data.end <= data.start)
data.end = data.start + data.length;
}
-#ifdef ELUNA
+
if (IsActiveEvent(event_id))
- sEluna->OnGameEventStart(event_id);
-#endif
+ sScri... | [No CFG could be retrieved] | This function is called from the start of a game event. It is called from the start - - - - - - - - - - - - - - - - - -. | eluna hook got moved below hmm |
@@ -34,12 +34,14 @@
#include <bootstrap.h>
#include <string_lib.h>
#include <loading.h>
+#include <regex.h> /* CompileRegex */
+#include <match_scope.h>
#include <time.h>
static GenericAgentConfig *CheckOpts(int argc, char **argv);
-static void ShowContextsFormatted(EvalC... | [main->[GenericAgentConfigApply,EvalContextNew,GetInputDir,SetupSignalsForAgent,PolicyToString,LoadPolicy,PolicyDestroy,PolicyToJson,Cf3ParseFile,GenericAgentFinalize,GenericAgentTagReleaseDirectory,GenericAgentPostLoadInit,WriterClose,GenericAgentConfigSetInputFile,GenericAgentDiscoverContext,ShowContextsFormatted,Sho... | The main entry point for the CFEngine policy. Options for the given n - node. | Style. Should be `char *regexp`. |
@@ -5461,7 +5461,13 @@ void home_all_axes() { gcode_G28(true); }
#if ENABLED(PROBE_MANUALLY)
z_at_pt[axis] += lcd_probe_pt(cos(a) * r, sin(a) * r);
#else
- z_at_pt[axis] += probe_pt(cos(a) * r + dx, sin(a) * r + dy, stow_after_each, 1, false);
+ ... | [No CFG could be retrieved] | Probe the center of the points on the screen. finds the offset points for the given number of circles. | The repetition of these three lines indicates potential design flaw. Probably this whole function needs to be refactored into some smaller functions. At the least, this set of three lines should be a separate function. |
@@ -24,7 +24,7 @@ namespace Microsoft.Win32.SafeHandles
// Process.{Safe}Handle to initalize and use a WaitHandle to successfully use it on
// Unix as well to wait for the process to complete.
- private readonly SafeWaitHandle _handle;
+ private readonly SafeWaitHandle? _handle;
... | [SafeProcessHandle->[ReleaseHandle->[DangerousRelease],DangerousAddRef,DangerousGetHandle]] | Creates a new instance of SafeProcessHandle that wraps a given process handle. | NIT: Seems all constructors setting it with `SetHandle(existingHandle);` helper, which we normally leave as non null and initialize with `null!`. Just for consistency |
@@ -70,15 +70,12 @@ class AlgorithmSteepestDescent( OptimizationAlgorithm ) :
self.__analyzeShape()
- if self.projectionOnNormalsIsSpecified:
- self.__projectSensitivitiesOnSurfaceNormals()
-
- if self.dampingIsSpecified:
+ if self.isDampingSpecified:
... | [AlgorithmSteepestDescent->[RunOptimizationLoop->[__projectSensitivitiesOnSurfaceNormals,__dampShapeUpdate,GetTotalTime,Timer,__determineAbsoluteChanges,print,StartTimer,GetTimeStamp,__analyzeShape,__logCurrentOptimizationStep,__dampSensitivities,GetLapTime,__isAlgorithmConverged,__computeShapeUpdate,range,__initialize... | Run the optimization loop. | damping is done one a different level in the penalized_projection algorithm |
@@ -18,12 +18,14 @@ class Content(MasterModel):
Relations:
notes (GenericKeyValueRelation): Arbitrary information stored with the content.
+ artifacts (models.ManyToManyField): Artifacts related to Content through ContentArtifact
"""
TYPE = 'content'
natural_key_fields = ()
... | [Content->[natural_key->[tuple,getattr],GenericKeyValueRelation],Artifact->[storage_path->[get_artifact_path],CharField,FileField,IntegerField]] | Get the natural key based on natural_key_fields. | Docstring should be updated to reflect this change |
@@ -43,6 +43,9 @@ def analyze_type_alias(node: Expression,
# that we don't support straight string literals as type aliases
# (only string literals within index expressions).
if isinstance(node, RefExpr):
+ # Note that this misses the case where someone tried to use a
+ # class-referenced t... | [TypeAnalyser->[anal_var_defs->[anal_array],visit_unbound_type->[visit_unbound_type,no_subscript_builtin_alias],get_type_var_names->[get_type_var_names],replace_alias_tvars->[get_tvar_name,replace_alias_tvars],tuple_type->[builtin_type]]] | Analyze a type alias. | small typo: checkmember.py |
@@ -131,8 +131,11 @@ class AccountQueries(graphene.ObjectType):
)
user = graphene.Field(
User,
- id=graphene.Argument(graphene.ID, description="ID of the user.", required=True),
- description="Look up a user by ID.",
+ id=graphene.Argument(graphene.ID, description="ID of the user... | [AccountQueries->[resolve_user->[resolve_user],resolve_permission_groups->[resolve_permission_groups],resolve_address_validation_rules->[resolve_address_validation_rules],resolve_staff_users->[resolve_staff_users],resolve_customers->[resolve_customers],resolve_address->[resolve_address],StaffUserInput,CustomerFilterInp... | Resolve address validation rules for a given NCBI object. | "Look up a user by ID or email address." |
@@ -301,7 +301,7 @@ function createBaseCustomElementClass(win) {
return this.upgradeState_ == UpgradeState.UPGRADED;
}
- /** @return {!Promise} */
+ /** @return {!Promise<!Object>} */
whenUpgraded() {
return this.signals_.whenSignal(CommonSignals.UPGRADED);
}
| [No CFG could be retrieved] | Gets the resources manager. The delay delay in milliseconds when an upgrade is performed. | I think this one will still say `!Promise` based on the `whenSignal` API. You'd have to call `.then(() => x)` to change the response. But I don't see yet that we need to modify this API. |
@@ -257,6 +257,11 @@ func (t *TeamsNameInfoSource) DecryptionKey(ctx context.Context, name string, te
keyGeneration int, kbfsEncrypted bool) (res types.CryptKey, err error) {
defer t.Trace(ctx, func() error { return err },
fmt.Sprintf("DecryptionKeys(%s,%s,%v,%d,%v)", name, teamID, public, keyGeneration, kbfsEnc... | [EphemeralEncryptionKey->[ephemeralLoadAndIdentify],ephemeralLoadAndIdentify->[loadTeam,identify],EncryptionKey->[loadTeam,identify],DecryptionKey->[identify],EphemeralDecryptionKey->[ephemeralLoadAndIdentify],LookupName->[identify],LookupID->[transformTeamDoesNotExist,identify],LookupIDUntrusted->[transformTeamDoesNot... | DecryptionKey implements the KeybaseService interface for TeamsNameInfoSource. | Don't need to care about KBFS encrypted here |
@@ -127,6 +127,13 @@ var _ = Describe("Podman top", func() {
session.WaitWithDefaultTimeout()
Expect(session.ExitCode()).To(Equal(0))
+ for i := 0; i < 10; i++ {
+ fmt.Println("Waiting for containers to be running .... ")
+ if podmanTest.NumberOfContainersRunning() == 2 {
+ break
+ }
+ time.Sleep(1 ... | [Write,WaitWithDefaultTimeout,OutputToStringArray,RestoreAllArtifacts,ExitCode,Sprintf,Seconds,OutputToString,To,Podman,CleanupPod,CreatePod,Exit] | Expect that the session exit code is equal to 0 or 3. | If tests are running in parallel, this loop seems ripe for causing headaches. Would it make sense to setup and wait for some test-specified or random-named containers instead? Unless there's zero chance this will ever be able to count another test's containers. Also, when the wait is successful, it might be handy to to... |
@@ -55,7 +55,9 @@ type Provider struct {
MarathonLBCompatibility bool `description:"Add compatibility with marathon-lb labels" export:"true"`
FilterMarathonConstraints bool `description:"Enable use of Marathon constraints in constraint filtering" export:"true"`
TLS ... | [getApplications->[Add,Applications],Provide->[CreateTLSConfig,OperationWithRecover,CustomWriterLevel,Go,Duration,AddEventsListener,NewDefaultConfig,NewClient,Errorf,Debugf,getConfiguration,RetryNotify,NewBackOff,NewExponentialBackOff,Debug],getConfiguration->[getApplications,buildConfiguration,Errorf]] | Provide provides a description of a Marathon specific configuration that can be used to configure a. | Do we need to use the phrase "non-default"? Isn't it kind of assumed that defaults will be used unless specified? |
@@ -29,7 +29,11 @@ func isServerUp(secure bool, host string, numRetries int, retryInterval time.Dur
for i := 0; i <= numRetries; i++ {
if check() {
- logp.Info("HTTP Server ready")
+ secureInfo := ""
+ if secure {
+ secureInfo = " (secure mode activated)"
+ }
+ logp.Info("HTTP Server ready" + secure... | [Get,Info,Sleep,String] | Check if the URL is available and if so return true. | building `secureInfo` can be done outside the for loop. Also good with removing it altogether. |
@@ -242,6 +242,10 @@ class ServiceProvider extends \Elgg\Di\DiContainer {
});
$this->setClassName('widgets', '\Elgg\WidgetsService');
+
+ $this->setFactory('uploads', function(ServiceProvider $c) {
+ return $c->request->files;
+ });
}
| [ServiceProvider->[resolveLoggerDependencies->[setValue,setLogger],__construct->[getTablePrefix,getRootPath,get,getRoot,setFactory,setValue,setClassName,resolveLoggerDependencies,setBaseUrl]]] | Initialize the class Initialize the database. Register all services Create all the modules that are available in the application. Initialize the service. | Why do we need a separate entry for this? If we moved some uploads-related functions into a new UploadsService we could return that here. |
@@ -55,11 +55,17 @@ class MyModuleTagsController < ApplicationController
end
def create
+ unless mt_params[:tag_id]
+ render_403
+ return false
+ end
+
@mt = MyModuleTag.new(mt_params.merge(my_module: @my_module))
@mt.created_by = current_user
@mt.save
my_module = @mt.my_mo... | [MyModuleTagsController->[destroy->[destroy],destroy_by_tag_id->[destroy]]] | create a new tag in the system. | you can simply 'return render_403' |
@@ -88,10 +88,17 @@ namespace Dynamo.Models
RunSettings = new RunSettings(info.RunType, info.RunPeriod);
PreloadedTraceData = traceData;
+
this.scheduler = scheduler;
this.verboseLogging = verboseLogging;
IsTestMode = isTestMode;
EngineCont... | [HomeWorkspaceModel->[Clear->[Clear],RequestRun->[RequestRun],ResetEngine->[LibraryLoaded],MarkNodesAsModifiedAndRequestRun->[RequestRun],OnPreviewGraphCompleted->[OnSetNodeDeltaState],GetExecutingNodes->[OnSetNodeDeltaState],NodeModified->[NodeModified,RequestRun],PopulateXmlDocument->[PopulateXmlDocument],Dispose->[D... | Dispose of the object. | See below - I think this could possibly use a rename |
@@ -33,7 +33,10 @@ class WPSEO_Configuration_Page {
* Check if the configuration is finished. If so, just remove the notification.
*/
public function catch_configuration_request() {
- if ( filter_input( INPUT_GET, 'configuration' ) !== 'finished' ) {
+ $configuration_page = filter_input( INPUT_GET, 'configura... | [WPSEO_Configuration_Page->[remove_notification->[remove_notification],add_notification->[add_notification],show_wizard->[enqueue_assets]]] | Catch configuration request. | This should be the identifier of the `WPSEO_Admin` because after finishing the wizard the user will be redirected to the dashboard. |
@@ -195,9 +195,14 @@ router.post('/', (req, res) => {
process.env.TWITTER_ORIGINPROTOCOL_USERNAME.toLowerCase()
) {
followCount++
- const key = `twitter/follow/${event.source.screen_name}`
- redisBatch.set(key, JSON.stringify(event), 'EX', 60 * 30)
- logger.debug(`Pushing t... | [No CFG could be retrieved] | POST a single Pushes a single to the Redis batch. | Do you know what is the max number of events Twitter may send at once ? Not awaiting will cause as many DB connections to get created so that could potentially overload the DB if it is a very large number (like thousands). Could be safer to process in batches of X events on our side to control. |
@@ -156,7 +156,13 @@ const serverFiles = {
{
file: 'package/domain/Entity.java',
renameTo: generator => `${generator.packageFolder}/domain/${generator.asEntity(generator.entityClass)}.java`
- },
+ }
+ ]
+ },
+ ... | [No CFG could be retrieved] | Recent for Liquibase. Package paths for the entities that need to be generated. | `generator => ! generator.embedded` isn't enough? |
@@ -116,7 +116,10 @@ public class ProtonServerReceiverContext extends AbstractProtonReceiverContext {
receiver = ((Receiver) delivery.getLink());
if (!delivery.isReadable()) {
- System.err.println("!!!!! Readable!!!!!!!");
+ return;
+ }
+
+ if (delivery.isPart... | [ProtonServerReceiverContext->[initialise->[initialise]]] | Called when a message is received from the client. | This was supopsed to be logger.trace()... can you do a logger.trace instead of removing it? |
@@ -186,6 +186,9 @@ type SessionConfig struct {
Restart bool `vic:"0.1" scope:"read-only" key:"restart"`
+ // StopSignal is the signal name or number used to stop container session
+ StopSignal string `vic:"0.1" scope:"read-only" key:"stopSignal"`
+
// Diagnostics holds basic diagnostics data
Diagnostics Diag... | [No CFG could be retrieved] | SessionConfig defines the content of a session - this maps to the root of a process tree vic 0. 1 scope. | Moving anything in the ExecutorConfig requires a corresponding change in lib/tether/config.go - unfortunately until we add #1145 it's awkward to extend existing config structures using structure composition (the serialization/deserialization assumes the structure layout is symmetric). |
@@ -145,7 +145,8 @@ class TrainLoop():
valid_report, self.valid_world = run_eval(
self.agent, opt, 'valid', opt['validation_max_exs'],
valid_world=self.valid_world)
- if valid_report[opt['validation_metric']] > self.best_valid:
+ if valid_report[opt['validation_metric']]... | [TrainLoop->[validate->[run_eval],train->[run_eval,validate,log]],TrainLoop] | Validate a single . | hm this shouldn't be necessary, I think. The first time that it hits 1, it should stop on line 156 when the cutoff is achieved. |
@@ -27,6 +27,8 @@ from .. import compat as cpt
__all__ = ['Executor', 'global_scope', 'scope_guard']
g_scope = core.Scope()
+InferNativeConfig = core.NativeConfig
+InferAnalysisConfig = core.AnalysisConfig
def global_scope():
| [Executor->[_run->[_add_feed_fetch_ops,_add_program_cache,_get_program_cache,as_numpy,run,_get_program_cache_key,_fetch_data,_feed_data],_add_feed_fetch_ops->[has_feed_operators,has_fetch_operators],run->[global_scope,Executor,_run_parallel],_run_parallel->[as_numpy],close->[close],_feed_data->[_as_lodtensor]],_fetch_v... | Get the global scope instance. | What do you need 2 Config? Can it be done in one config? |
@@ -610,11 +610,17 @@ public:
bool enable_shaders = g_settings->getBool("enable_shaders");
bool enable_bumpmapping = g_settings->getBool("enable_bumpmapping");
bool enable_parallax_occlusion = g_settings->getBool("enable_parallax_occlusion");
+ bool enable_water_surface_shader = g_settings->getBool("enable_wa... | [serialize->[serialize], reset->[reset],deSerialize->[reset,deSerialize],serializeOld->[serialize],CNodeDefManager->[void->[clear],content_t->[allocateId],serialize->[serialize],deSerialize->[deSerialize,clear],clear->[clear], clear->[clear]],deSerializeOld->[deSerialize,clear]] | This method is called when textures are updated. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - This function is used to initialize the material for the j - th tile in the list of region TileDefinition FEC u32 Description = 0 - 9 - 15. | This only allows one water source and flowing. Better than before, but still bad. Add a nodedef field such as `use_water_shader = true/false`. |
@@ -79,7 +79,7 @@ public class OpenIdServiceResponseBuilder extends AbstractWebApplicationServiceR
Assertion assertion = null;
try {
- if (associated && associationValid) {
+ if (associated && associationValid || !associated) {
assertion = centralAuthentication... | [OpenIdServiceResponseBuilder->[build->[getMessage,debug,error,validateServiceTicket,isAssociationValid,getAssociation,buildRedirect,getBean,determineIdentity,warn,buildAuthenticationResponse,isBlank,put],isAssociationValid->[hasExpired],getAssociation->[getMessage,error,createAuthRequest,get,getRealmVerifier,isEmpty,l... | Build a response with an OpenID 2. 0 authentication. | I would put in parenthesis to make the order of operations clear |
@@ -288,6 +288,10 @@ class Boost(Package):
# https://svn.boost.org/trac/boost/ticket/12496
if spec.satisfies('%clang'):
options.extend(['pch=off'])
+ if '+clanglibcpp' in spec:
+ options.extend(['toolset=clang',
+ 'cxxflags="-stdl... | [Boost->[determine_bootstrap_options->[determine_toolset,bjam_python_line],install->[determine_bootstrap_options,add_buildopt_symlinks,determine_b2_options],determine_b2_options->[determine_toolset]]] | Determine options for B2 - based BZIP2. A buildopt option that creates symlink to the base lib. | Would that overwrite user defined `CFLAGS`? |
@@ -27,7 +27,7 @@ class DependencyAwarePruner(Pruner):
"""
def __init__(self, model, config_list, optimizer=None, pruning_algorithm='level', dependency_aware=False,
- dummy_input=None, **algo_kwargs):
+ dummy_input=None, global_sort=False, **algo_kwargs):
super().__i... | [DependencyAwarePruner->[_dependency_update_mask->[_dependency_calc_mask],_dependency_calc_mask->[calc_mask],calc_mask->[calc_mask]]] | Initialize the object with a base configuration of a node. | Do all the dependency pruners support `global_sort` mode? If not, I'm a little concerned. |
@@ -1,8 +1,12 @@
module ProfilesHelper
- def profile_background_image_url(model)
- size = browser.mobile? ? '640x650e' : '500x325e'
- accessor_name = model.background_image.present? ? :background_image : :avatar
+ def profile_background_image_url(profile, mini: false)
+ size = if mini
+ browser.mobile?... | [profile_background_image_url->[present?,thumb_url,mobile?]] | Returns profile background image url. | `end` at 7, 4 is not aligned with `if` at 3, 11 |
@@ -76,10 +76,14 @@ public class ActiveDirectoryGroupRealm extends AbstractLdapRealm {
* group names (e.g. CN=Group,OU=Company,DC=MyDomain,DC=local)
* as returned by the active directory LDAP server to role names.
*/
- private Map<String, String> groupRolesMap;
+ private Map<String, String> groupRolesMap ... | [ActiveDirectoryGroupRealm->[doGetAuthenticationInfo->[getLdapContextFactory],onInit->[onInit],getSystemPassword->[getSystemPassword],doGetAuthorizationInfo->[getLdapContextFactory]]] | Method called to set the groupRolesMap. | I think it is not necessary to add this method `getGroupRolesMap()`, we could still use the field groupRolesMap since it would be never be null IIUC. |
@@ -803,6 +803,7 @@ define([
uniformState._inverseProjectionDirty = true;
uniformState._inverseProjectionOITDirty = true;
uniformState._viewProjectionDirty = true;
+ uniformState._inverseViewProjectionDirty = true;
uniformState._modelViewProjectionDirty = true;
unifor... | [No CFG could be retrieved] | The position of the sun in the 3D scene. A 3x3 matrix that transforms from True Equator Mean Equinox and the . | These changes in `UniformState` didn't affect the issue at hand, but they may be good changes to make. |
@@ -8,6 +8,10 @@ class GroupPermissionsForm(forms.ModelForm):
class Meta:
model = Group
fields = ['name', 'permissions']
+ labels = {
+ 'name': _('name'),
+ 'permissions': _('permissions'),
+ }
permissions = forms.ModelMultipleChoiceField(
query... | [GroupPermissionsForm->[get_permissions,ModelMultipleChoiceField]] | Create a form to show the permissions of a group. | We should consistently use `pgettext_lazy` here. |
@@ -1,4 +1,6 @@
class UsersController < ApplicationController
+ before_action :ensure_in_setup
+
def destroy
track_account_deletion_event
url_after_cancellation = decorated_session.cancel_link_url
| [UsersController->[destroy_user->[destroy!,find_by],track_account_deletion_event->[call,track_event],destroy->[redirect_to,t,cancel_link_url]]] | destroy_nag - Deletes the nag and redirects to the cancel link. | ~Unrelated to this change, but worth noting that moving this into the account reset namespace may be a good refactor. Confusing to have this controller out here, makes you think this is the controller for the "delete account" button on the account page.~ |
@@ -35,10 +35,7 @@
public int NumberOfTimesInvoked { get; set; }
- public DateTime TimeOfFirstAttempt { get; set; }
- public DateTime TimeOfSecondAttempt { get; set; }
-
- public int NumberOfDelayedRetriesPerformed { get; set; }
+ public int NumberOfRetriesAt... | [When_immediate_retries_fail->[Task->[GreaterOrEqual,NumberOfDelayedRetriesPerformed,TimeOfSecondAttempt,TimeOfFirstAttempt,Run],DelayedRetryEndpoint->[MessageToBeRetriedHandler->[Task->[UtcNow,TryGetValue,NumberOfTimesInvoked,NumberOfDelayedRetriesPerformed,FromResult,TimeOfSecondAttempt,Id,TimeOfFirstAttempt,Parse,De... | NServiceBusAcceptanceTests. missing message in the current context. | The formatting of this looks wrong. Shouldn't there be spaces around the `-` signs? |
@@ -212,13 +212,10 @@ module Opus::Types::Test
assert_equal(Integer, type.type.raw_type)
end
- it 'fails if an element of the array is the wrong type' do
+ it 'does not fail if an element of the array is the wrong type' do
type = T::Array[Integer]
value = [true]
- ms... | [TypesTest->[all->[all],assert_subtype->[subtype_of?],refute_subtype->[subtype_of?],any->[any],subtype?->[subtype_of?],all,assert_subtype,good_return,refute_subtype,any,foo,subtype?,bad_return,make_type_alias]] | it fails validation if a field is missing and an extra field is present proposes a simple type if only one type exists. | @aisamanra What does it mean for `error_message_for_obj` to be `nil`? Do we still show an "expected / actual" error message? |
@@ -170,6 +170,9 @@ public final class ScmBlockLocationProtocolClientSideTranslatorPB
requestBuilder.setFactor(
((RatisReplicationConfig) replicationConfig).getReplicationFactor());
break;
+ case EC:
+ requestBuilder.setEcReplicationConfig(
+ ((ECReplicationConfig)replicationCo... | [ScmBlockLocationProtocolClientSideTranslatorPB->[addSCM->[submitRequest,handleError],getScmInfo->[submitRequest,handleError],allocateBlock->[submitRequest,handleError],sortDatanodes->[submitRequest,handleError],deleteKeyBlocks->[submitRequest,handleError],close->[close]]] | Allocate a block. | Looks like we missed break here. Sorry missed this in previous review. |
@@ -1,9 +1,11 @@
/* global APP */
-import UIEvents from '../../../../service/UI/UIEvents';
-
+import { CONFERENCE_JOINED } from '../conference';
+import { processExternalDeviceRequest } from '../../device-selection';
import { MiddlewareRegistry } from '../redux';
+import UIEvents from '../../../../service/UI/UIEven... | [No CFG could be retrieved] | Provides the middleware of the feature base devices. | style: sort these as usual |
@@ -1174,7 +1174,12 @@ namespace Microsoft.Xna.Framework
return matrix1;
}
-
+ /// <summary>
+ /// Divides the components of a <see cref="Matrix"/> by a scalar.
+ /// </summary>
+ /// <param name="matrix1">Source <see cref="Matrix"/>.</param>
+ /// <param name="divid... | [Matrix->[GetHashCode->[GetHashCode],Equals->[Equals],CreateFromYawPitchRoll->[CreateFromQuaternion,CreateFromYawPitchRoll],CreateScale->[CreateScale],Add]] | Creates a new matrix that is the sum of all elements of the given matrix divided by the Creates a new matrix with all elements of the named order that are not missing. | Use `elements` instead of `components`. |
@@ -485,7 +485,12 @@ public class Cli implements Closeable, AutoCloseable {
private String readLine() throws IOException {
while (true) {
try {
- return Optional.ofNullable(lineReader.readLine(primaryPrompt)).map(String::trim).orElse("");
+ String result = lineReader.readLine(primaryPrompt)... | [Cli->[registerDefaultCliSpecificCommands->[execute->[printHelp],registerCliSpecificCommand],handleLine->[execute],handlePrintedTopic->[handle->[handle],close,handle],handleStreamedQuery->[handle->[handle]],close->[close],printAsTable->[printErrorMessage]]] | read a line from the input stream until a user interruptes or a line is reached. | This has no effect on non-windows platforms compared to the previous version that didn't throw? |
@@ -63,8 +63,12 @@ var defaultConfig = harmonyconfig.HarmonyConfig{
},
Sync: getDefaultSyncConfig(defNetworkType),
Pprof: harmonyconfig.PprofConfig{
- Enabled: false,
- ListenAddr: "127.0.0.1:6060",
+ Enabled: false,
+ ListenAddr: "127.0.0.1:6060",
+ Folder: "./profiles",
+ ... | [No CFG could be retrieved] | Get the default configuration for the given object. Get the default configuration for the . | Adding some default value? Do you think 600 is a good number to start? |
@@ -120,7 +120,12 @@ public class TaskAction implements CeWsAction {
private void checkPermission(Optional<ComponentDto> component) {
if (component.isPresent()) {
- userSession.checkComponentPermission(SCAN_EXECUTION, component.get());
+ if (!userSession.hasOrganizationPermission(component.get().get... | [TaskAction->[getFromRequest->[toSet,collect,paramAsStrings,emptySet],possibleValues->[toList,values,collect],loadComponent->[selectByUuid,absent],extractScannerContext->[contains,orElse],maskErrorStacktrace->[contains,setErrorStacktrace],checkPermission->[isPresent,checkComponentPermission,get,checkIsRoot],define->[se... | check permission for scan execution. | put `component.get().getOrganizationUuid()` into a variable for readability, perf and to ensure the same default organization is checked (even though the implementation is cached, it's not in the contract of the interface) |
@@ -482,7 +482,7 @@ func TestGasUpdater_Recalculate(t *testing.T) {
config.On("GasUpdaterTransactionPercentile").Return(uint16(50))
config.On("ChainID").Return(big.NewInt(0))
- guIface := gasupdater.NewGasUpdater(ethClient, config)
+ guIface := gasupdater.NewGasUpdater(ethClient, config, headtracker.NewHeadBr... | [EqualError,NewHash,MatchedBy,RollingBlockHistory,Error,NewGasUpdater,FetchBlocks,New,SetRollingBlockHistory,Start,HexToHash,Len,Recalculate,On,Equal,TypeOf,Head,Parallel,NoError,FetchBlocksAndRecalculate,Int64,Get,AssertExpectations,TransactionsFromGasPrices,Sprintf,Return,Background,Unmarshal,NewInt,GasUpdaterToStruc... | gasupdater. Block returns a struct with all the block objects that are needed to be Adds a new block to the list of blocks. | Does it work if we use the null pattern to pass in a null head broadcaster? Or perhaps a mock? |
@@ -198,10 +198,12 @@ func (acts *deployActions) Run(step deploy.Step) (resource.Status, error) {
}
// Write out the current snapshot. Note that even if a failure has occurred, we should still have
- // a safe checkpoint.
- //
- // TODO[pulumi/pulumi#388] stop dropping this error on the floor!
- _ = acts.Engine.E... | [Run->[Logical,Colorize,Sprintf,Fprint,Apply,Failf,SaveEnvironment,Diag,Snap,Iterator,Op,Errorf,WriteString],Deploy->[deployLatest,planContextFromEnvironment,InitDiag,QName,Require],deployLatest->[plan,IgnoreClose,Success,Colorize,Sprintf,Fprint,SaveEnvironment,Snap,New,Now,Diag,Assert,printPlan,WriteString,Since,Walk]... | Run executes a single deploy step Saves the current checkpoint of the current step. | In case this doesn't error (the norm), won't this overwrite the actual error from the `Apply` with `nil`, causing that to get lost? |
@@ -17,7 +17,7 @@
# index_syobocal_alerts_on_sc_prog_item_id (sc_prog_item_id)
#
-class Syobocal::Alert < ActiveRecord::Base
+class Syobocal::Alert < ApplicationRecord
extend Enumerize
enumerize :kind, in: { special_program: 0 }, scope: true
| [new_special_program?->[blank?,find_by],enumerize,belongs_to,extend] | Creates a new SyobocalAlert object for a given sc_prog_item_id. | Use nested module/class definitions instead of compact style. |
@@ -719,7 +719,13 @@ public abstract class HoodieTable<T extends HoodieRecordPayload, I, K, O> implem
return metaClient.getTableConfig().getLogFileFormat();
}
- public HoodieLogBlockType getLogDataBlockFormat() {
+ public HoodieLogBlockType getLogDataBlockType() {
+ HoodieLogBlock.HoodieLogBlockType logB... | [HoodieTable->[getSliceView->[getFileSystemView],rollbackInflightCompaction->[scheduleRollback,rollback],deleteInvalidFilesByPartitions->[delete],getRollbackTimeline->[getRollbackTimeline],getBaseFileOnlyView->[getFileSystemView],getHoodieView->[getFileSystemView],validateSchema->[getMetaClient],validateUpsertSchema->[... | get log file format. | We need to move the log block format away from the table config |
@@ -352,7 +352,7 @@ type StepOp string
const (
OpSame StepOp = "same" // nothing to do.
OpCreate StepOp = "create" // creating a new resource.
- OpUpdate StepOp = "update" // updating an existing resource.
+ OpUpdate StepOp = "modi... | [Skip->[Done],Color->[Failf],Apply->[Done,Create,All,AppendStateSnapshot,Delete,MarkStateSnapshot,Assert,URN,AllInputs,Update],Prefix->[Failf,Color],Package,Provider,Assert,Type,Plan] | Plan returns a Plan that can be used to iterate over the replace step. Color returns a color string for the given op type. | I vaguely recall we may blindly append a "d" for past tense ("modifyd"). That's why I suggested maybe "change", but if you've verified it looks ok, I'm good with "modify" (and slightly prefer it). |
@@ -1,4 +1,6 @@
module ApplicationHelper
+ include CloudinaryHelper
+
def user_logged_in_status
user_signed_in? ? "logged-in" : "logged-out"
end
| [cloudinary->[exclude?,development?,blank?,positive?],view_class->[action_name],render_js?->[action_name,include?],org_bg_or_white->[bg_color_hex],user_colors_style->[darker_color],icon_url->[fetch],cloud_cover_url->[test?,cl_image_path,asset_path,blank?,development?],title_with_timeframe->[fetch,title,blank?],sanitize... | Returns the nag - status string for the user. | It's a little bit weird to see an helper included in another one, can I ask you why? |
@@ -66,8 +66,8 @@ import {
<%_ if (authenticationType !== 'oauth2') { _%>
<%=angularXAppName%>AccountModule,
<%_ } _%>
- <%=angularXAppName%>EntityModule,
// jhipster-needle-angular-add-module JHipster will add new module here
+ <%=angularXAppName%>EntityModule
],
... | [No CFG could be retrieved] | JHipster - needle - angular - add - module - import The base module for all components that implement the necessary dependencies. | Can we put it just above the <%=angularXAppName%>EntityModule so that these are logically grouped? |
@@ -2,11 +2,12 @@
// The .NET Foundation licenses this file to you under the MIT license.
using System;
+using System.Diagnostics.CodeAnalysis;
using System.Threading.Tasks;
public class Test
{
-
+ [DynamicDependency(DynamicallyAccessedMemberTypes.All, "System.Runtime.InteropServices.JavaScript.Runtime", "S... | [Test->[Main->[Length,Delay,WriteLine]]] | This method is a utility method that prints out the number of arguments passed to the command. | This should probably be handled somewhere else. |
@@ -53,7 +53,7 @@ class AzureAuthError(DvcException):
pass
-class AzureFileSystem(FSSpecWrapper):
+class AzureFileSystem(FSSpecWrapper): # pylint:disable=abstract-method
scheme = Schemes.AZURE
PATH_CLS = CloudURLInfo
PARAM_CHECKSUM = "etag"
| [AzureFileSystem->[fs->[_temp_event_loop,AzureAuthError],open->[_temp_event_loop,open]]] | A context manager that creates a temporary event loop for Azure filesystem instances. Get login info from config. | There is a less dangerous way: you could add `walk` to `FSSpecWrapper`. EDIT: on the other hand we've been using it in other FileSystems for awhile :slightly_frowning_face: |
@@ -48,7 +48,7 @@ class ACMEServer(object):
self._acme_type = 'pebble' if acme_server == 'pebble' else 'boulder'
self._proxy = http_proxy
self._workspace = tempfile.mkdtemp()
- self._processes = []
+ self._processes = [] # type: List
self._stdout = sys.stdout if stdout... | [ACMEServer->[__exit__->[stop],__enter__->[start]],main->[ACMEServer],main] | Initialize the object. | Is this typing really needed? |
@@ -90,3 +90,8 @@ def get_menus_that_needs_update(collection=None, categories=None, page=None):
menus_to_be_updated = MenuItem.objects.filter(q).distinct().values_list(
'menu', flat=True)
return menus_to_be_updated
+
+
+def get_menu_obj_text(obj):
+ return str(obj) + ('' if obj.is_published else p... | [get_menu_as_json->[get_menu_item_as_dict],update_menu->[get_menu_as_json]] | Returns list of menu instances that needs to be updated by deleting one of the listed objects. | So I have a doubt if that would work properly (Adding a translated string to nontranslated one), it might be not clear for the translators. I'd say we need 3 cases here: - Regular menu item - Menu item available on a certain date (from the future) - Menu item not published and I'd add individual translation for 2nd and... |
@@ -395,7 +395,17 @@ func (o CreateNodeConfigOptions) MakeNodeConfig(serverCertFile, serverKeyFile, n
return err
}
- content, err := latestconfigapi.WriteYAML(config)
+ // Roundtrip the config to v1 and back to ensure proper defaults are set.
+ ext, err := configapi.Scheme.ConvertToVersion(config, "v1")
+ if err... | [UseNodeClientCA->[UseTLS],Validate->[IsCreateClientCertificate,IsCreateServerCertificate],CreateNodeFolder->[UseNodeClientCA,UseTLS],MakeClientCert->[IsCreateClientCertificate,Validate],MakeNodeConfig->[UseTLS],MakeServerCert->[IsCreateServerCertificate,Validate],MakeKubeConfig->[Validate]] | MakeNodeConfig creates a node config based on the given options get an object from the network. | @deads2k with @liggitt's help we discovered we need to add this to get defaulting of the NodeConfig. He suggested I let you know as we should probably unify this and BuildSerializeableNodeConfig |
@@ -46,7 +46,9 @@ function MainCtrl ($scope, $rootScope, $window, arrayOrderingSrv) {
$rootScope.noteName = function (note) {
if (!_.isEmpty(note)) {
- return arrayOrderingSrv.getNoteName(note)
+ let name = arrayOrderingSrv.getNoteName(note)
+ name = name.substr(name.lastIndexOf('/') + 1, name.... | [No CFG could be retrieved] | Set the lookAndFeel to default on every page. | is this going to work on Windows? |
@@ -134,7 +134,6 @@ def test_calculate_order_line_total(
order_line.unit_price = unit_price
total_price = unit_price * order_line.quantity
order_line.total_price = total_price
- order_line.save(update_fields=["unit_price", "total_price"])
total = manager.calculate_order_line_total(
ord... | [test_plugin_uses_configuration_from_db->[fetch_checkout_info,setattr,get_plugins_manager,get,plugin_configuration,preprocess_order_creation,_update_config_items,raises,save,fetch_checkout_lines],test_calculate_order_shipping->[get_plugins_manager,get_copy,get,Money,plugin_configuration,calculate_order_shipping,TaxedMo... | This function test calculate order line total for order_line. | Why you remove save from these tests? |
@@ -270,10 +270,10 @@ if (empty($reshook))
{
$object->fetch($id);
- // On verifie signe facture
+ // We check sign of amount
if ($object->type == Facture::TYPE_CREDIT_NOTE) {
- // Si avoir, le signe doit etre negatif
- if ($object->total_ht >= 0) {
+ // If credit note, the total amount must be negatif... | [update_price,create,form_multicurrency_rate,setRetainedWarrantyDateLimit,jdate,getLinesArray,setValueFrom,getVentilExportCompta,getNomUrl,getSellPrice,select_incoterms,begin,select_comptes,insert_discount,getLibType,setProject,add_contact,getOutstandingBills,showOptionals,printOriginLinesList,textwithpicto,fetch_optio... | Creates a new object - > - > - > - > - > - > - > - > - >. | You say "To allow making credit note which only pay back tax amount." What are price without, vat and price including tax for such invoice ? |
@@ -135,6 +135,8 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) {
cfg.LifecyclerConfig.RegisterFlags(f)
f.IntVar(&cfg.MaxTransferRetries, "ingester.max-transfer-retries", 10, "Number of times to try and transfer chunks before falling back to flushing. Negative value or zero disables hand-over.")
+ f.IntVar(... | [LabelNames->[LabelNames],ShutdownHandler->[Shutdown],LabelValues->[LabelValues],RegisterFlags->[RegisterFlags],Shutdown->[Shutdown]] | RegisterFlags registers flags for the config - user ingestion rates. | This should be a `DurationVar`. Same for the next one. |
@@ -6,3 +6,6 @@ from .enas import EnasTrainer
from .proxyless import ProxylessTrainer
from .random import SinglePathTrainer, RandomTrainer
from .utils import replace_input_choice, replace_layer_choice
+from .differentiable import DartsModel, ProxylessModel
+from .sampling import EnasModel,RandomSampleModel
+from .ba... | [No CFG could be retrieved] | Trainer for the random layer. | Suggest calling them `DartsModule`, `ProxylessModule`... |
@@ -45,12 +45,12 @@ class GetDetailedDiagnosticsInformationSampleAsync(object):
]
def callback(resp):
- _LOGGER.info("document_count: {}".format(resp.statistics["document_count"]))
- _LOGGER.info("valid_document_count: {}".format(resp.statistics["valid_document_count"]))
- ... | [main->[GetDetailedDiagnosticsInformationSampleAsync,get_detailed_diagnostics_information_async],main] | Get detailed diagnostic information for a single node. | Can we retrieve the response out of the callback function so a user can use it below? I think it makes sense to log the other pieces, but if someone goes through the trouble of passing the response hook to get the JSON response, I imagine it's because they want to use it, not just print it. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.