patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -16,6 +16,9 @@ namespace Microsoft.Xna.Framework.Media
private void PlatformInitialize(string fileName)
{
+ // init OpenAL if need be
+ var inst = OpenALSoundController.GetInstance;
+
stream = new OggStream(fileName, OnFinishedPlaying);
stream.Prepa... | [Song->[Play->[Play],Resume->[Resume],Pause->[Pause],Stop->[Stop]]] | PlatformInitialize - initialize OggStream with a file name. | Should call OpenALSoundController.EnsureInitialized() too. |
@@ -825,8 +825,9 @@ void Peer::DecUseCount()
delete this;
}
-void Peer::RTTStatistics(float rtt, const std::string &profiler_id,
- unsigned int num_samples) {
+void Peer::RTTStatistics(float rtt, const std::string &profiler_id)
+{
+ static const float avg_factor = 0.1f / MAX_RELIABLE_WINDOW_SIZE;
if (m_last_r... | [No CFG could be retrieved] | private int m_usage = 0 ; al value at beginning of loop. | seems to be constexpr const instead of just const |
@@ -615,7 +615,7 @@ static void dt_camctl_camera_destroy(dt_camera_t *cam)
gp_camera_unref(cam->gpcam);
gp_widget_unref(cam->configuration);
- for(GList *it = g_list_first(cam->open_gpfiles); it != NULL; it = g_list_delete_link(it, it))
+ for(GList *it = cam->open_gpfiles; it != NULL; it = g_list_delete_link(... | [void->[dt_camctl_have_cameras,dt_camctl_have_locked_cameras]] | dt_camera_destroy - Destroy the camera control structures. | `it != NULL` can be just `it` for consistency with all other loops. Some more instances below. |
@@ -390,6 +390,8 @@ class EpollEventLoop extends SingleThreadEventLoop {
//increase the size of the array as we needed the whole space for the events
events.increase();
}
+ } catch (ThreadDeath td) {
+ throw (ThreadDeath) td;
... | [EpollEventLoop->[epollWaitNow->[epollWait],newTaskQueue->[newTaskQueue],cleanup->[epollWaitTimeboxed],run->[get,epollWaitNoTimerChange,epollWaitTimeboxed,epollWait,epollBusyWait],afterScheduledTaskSubmitted->[get],epollWaitTimeboxed->[epollWait],remove->[remove],epollWaitNoTimerChange->[epollWait],processReady->[get],... | This method is called from the event loop. This method is called from the main thread. It runs all tasks in the queue. | Right below these catch clauses it says "Always handle shutdown even if the loop processing threw an exception." Should that perhaps be moved into a finally clause? It's the same deal in all of the event loops modified in this PR. |
@@ -57,6 +57,18 @@ func ExecuteJobWithRunRequest(
return run, createAndTrigger(run, store)
}
+// MeetsMinimumPayment is a helper that returns true if jobrun received
+// sufficient payment (more than jobspec's MinimumPayment) to be considered successful
+func MeetsMinimumPayment(
+ expectedMinJobPayment *assets.Li... | [Ended,Now,Duration,Finished,Merge,Uint32From,Wrap,Add,NewRun,MinimumContractPayment,PendingConfirmations,NewBig,ToInt,Started,MinContractPayment,Errorw,Unconfirmed,Cmp,GetTxReceipt,PendingBridge,NewLink,PendingConnection,Errorf,ApplyResult,CreateJobRun,After,Sub,SetError,Text,NextTaskRun,Hex,MinConfs,MinBigs,MaxUint32... | NewRun creates a new run from a job spec and a run request. Job runner - Creates a new run with the minimum contract payment for each task run. | `expectedMinJobPayment != nil` is redundant here ;) |
@@ -0,0 +1,5 @@
+class AddOnlyRequiredFilesToAssignments < ActiveRecord::Migration
+ def change
+ add_column :assignments, :only_required_files, :boolean, default: 'false'
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | I don't think you need to put `false` in a string here. |
@@ -55,6 +55,12 @@ func main() {
default:
log.Fatal("parse cmd flags error", zap.Error(err))
}
+
+ if cfg.ConfigCheck {
+ fmt.Println("config check successful")
+ exit(0)
+ }
+
// New zap logger
err = cfg.SetupLogger()
if err == nil {
| [ReplaceGlobals,InitLogger,Warn,Close,PrepareJoinCluster,NewConfig,CreateServer,Info,Exit,Done,SetupLogger,LogPanic,Error,Cause,Notify,PrintPDInfo,InitHTTPClient,EnableHandlingTimeHistogram,Sync,Background,WithCancel,GetZapLogProperties,String,Parse,Fatal,GetZapLogger,LogPDInfo,Run,Push] | Reads the n - tuple from the command line and creates a n - tuple from the n is the main entry point for the server. | I think better to check `cfg.WarningMsgs` here. See L83 below. |
@@ -324,7 +324,7 @@ func (td *OsmTestData) InstallOSM(instOpts InstallOSMOpts) error {
return errors.Wrap(err, "failed to run osm install")
}
- return nil
+ return td.WaitForPodsRunningReady(td.osmNamespace, 90*time.Second, 1)
}
// GetConfigMap is a wrapper to get a config map by name in a particular namespa... | [CreateNs->[AreRegistryCredsPresent,GetTestNamespaceSelectorMap],Cleanup->[DeleteNs,GetTestNamespaceSelectorMap]] | InstallOSM installs the OSM test data GetConfigMap gets a ConfigMap from the cluster. | We should keep the expected number of pods in a variable that gets updated to reflect the options since installing vault adds a pod, cert-manager adds 3, etc. |
@@ -1293,7 +1293,7 @@ class NewSemanticAnalyzer(NodeVisitor[None],
for base, base_expr in bases:
if isinstance(base, TupleType):
- if info.tuple_type:
+ if info.tuple_type and info.tuple_type != base:
self.fail("Class has two incompatible bases ... | [names_modified_in_lvalue->[names_modified_in_lvalue],NewSemanticAnalyzer->[analyze_comp_for->[analyze_lvalue],name_not_defined->[is_incomplete_namespace,add_fixture_note,record_incomplete_ref,lookup_fully_qualified_or_none],check_classvar->[is_self_member_ref],visit_lambda_expr->[analyze_function],visit_for_stmt->[fai... | Configures the base classes. Check for explicit base class. | Is there any case where `info.tuple_type` and `base` would be equal? I'd expect that at least the fallbacks would be different. Also, we usually use `is_same_type` instead of equality. |
@@ -1,4 +1,8 @@
+from ..checkout.error_codes import CheckoutErrorCode
+
+
class InsufficientStock(Exception):
def __init__(self, item):
super().__init__("Insufficient stock for %r" % (item,))
self.item = item
+ self.code = CheckoutErrorCode.INSUFFICIENT_STOCK
| [InsufficientStock->[__init__->[super]]] | Insufficient stock for an item. | Core module should not take any dependencies from other Saleor's module. |
@@ -30,4 +30,4 @@ SomeBaseElementLikeClass.prototype.defaultActionAlias_;
// Externed explicitly because this private property is read across
// binaries.
-Element.prototype.implementation_ = {};
+Element.prototype.impl_ = {};
| [No CFG could be retrieved] | Externed explicitly because it is read across the binaries. | unrelated: can we delete `amp.multipass.extern.js` seeing as multipass has been abandoned? |
@@ -10,6 +10,7 @@ module.exports = {
deploy_tag: false,
// Equals about 10MB.
max_buffer: 10000 * 1024,
+ tmp_dir: "<%= paths.svnCheckoutDir %>",
},
},
master: {
| [No CFG could be retrieved] | JS module containing the configuration of the . | Is there a specific reason to have `tmp_dir` with `_` and `svnCheckoutDir` having camelcased? |
@@ -1163,7 +1163,11 @@ class WPSEO_Replace_Vars {
* @return array The formatted replacement variable.
*/
private function format_replacement_variable( $replacement_variable ) {
- return array( 'name' => $replacement_variable, 'value' => '' );
+ $label = '';
+ if ( ! $this->is_not_prefixed( $replacement_varia... | [WPSEO_Replace_Vars->[retrieve_page->[determine_pagenumbering,retrieve_sep],retrieve_pt_plural->[determine_pt_names],retrieve_pt_single->[determine_pt_names],retrieve_caption->[retrieve_excerpt_only],retrieve_pagetotal->[determine_pagenumbering],retrieve_pagenumber->[determine_pagenumbering]]] | Format the replacement variable. | This line is pretty hard to read. It says: `if not is not prefixed`. Can you change this somehow. |
@@ -352,6 +352,17 @@ class _GeneralizationAcrossTime(object):
'epochs to score()')
# Check scorer
+ if self.score_mode not in ('fold-wise', 'mean-fold-wise',
+ 'sample-wise'):
+ raise ValueError("`score_mode` must be 'fol... | [_GeneralizationAcrossTime->[score->[predict,is_regressor],predict->[_DecodingTime],__init__->[_DecodingTime]],_sliding_window->[_DecodingTime,find_t_idx],TimeDecoding->[score->[predict],_prep_times->[_DecodingTime]],_fit_slices->[fit]] | Score across all epochs by comparing the prediction estimated for each epoch to its true value. Compute the score of a missing node in the model. Get the scores of missing key - value pairs. | No need for back tick in error message, they don't render |
@@ -116,9 +116,9 @@ static const unsigned char digestinfo_mdc2_der[] = {
# ifndef OPENSSL_NO_RMD160
/* RIPEMD160 (1 3 36 3 3 1 2) */
static const unsigned char digestinfo_ripemd160_der[] = {
- ASN1_SEQUENCE, 0x0c + RIPEMD160_DIGEST_LENGTH,
+ ASN1_SEQUENCE, 0x0e + RIPEMD160_DIGEST_LENGTH,
ASN1_SEQUENCE, ... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - IPEMD160_DIGEST_LENGTH - IPEMD160_DIGEST_. | This still is not right.. |
@@ -732,11 +732,10 @@ public class NetworkServiceImpl extends ManagerBase implements NetworkService {
}
try {
- if (ipv4Address != null) {
- ipaddr = _ipAddrMgr.allocatePublicIpForGuestNic(network, podId, ipOwner, ipv4Address);
- }
... | [NetworkServiceImpl->[addDefaultBaremetalProvidersToPhysicalNetwork->[addProviderToPhysicalNetwork],areServicesSupportedInNetwork->[areServicesSupportedInNetwork],addDefaultVirtualRouterToPhysicalNetwork->[addProviderToPhysicalNetwork],addDefaultOvsToPhysicalNetwork->[addProviderToPhysicalNetwork],addConfigDriveToPhysi... | allocate a secondary ip to a nic This method allocates an IP to a guest nic. This method is used to add an ip to a VM NIC. | I'm a bit confused, the null check for ipv4address is gone and it is not assigned (even when not null) when it isn't but ipv6Address is not null. This means that if both are available ipv6 is the *only one* used. Is that what you intend @ustcweizhou ? I see how this fixes backwards compatibility btw, just wondering if ... |
@@ -74,6 +74,10 @@ def build_wheels(
builder, # type: WheelBuilder
pep517_requirements, # type: List[InstallRequirement]
legacy_requirements, # type: List[InstallRequirement]
+ wheel_cache, # type: WheelCache
+ build_options, # type: List[str]
+ global_options, ... | [build_wheels->[is_wheel_installed],InstallCommand->[run->[build_wheels,get_check_binary_allowed]],site_packages_writable->[get_lib_location_guesses],decide_user_install->[site_packages_writable],warn_deprecated_install_options->[format_options]] | Build wheels for requirements depending on whether wheel is installed. | nit: type annotations aren't aligned anymore |
@@ -151,8 +151,8 @@ public class SCMConnectionManager
RetryPolicy retryPolicy =
RetryPolicies.retryUpToMaximumCountWithFixedSleep(
- getScmRpcRetryCount(conf),
- 1000, TimeUnit.MILLISECONDS);
+ getScmRpcRetryCount(conf), getScmRpcRetryInterval(conf),
+ ... | [SCMConnectionManager->[removeSCMServer->[writeLock,writeUnlock],getSCMServers->[readUnlock,readLock],addSCMServer->[writeLock,writeUnlock],getValues->[readUnlock,readLock],addReconServer->[writeLock,writeUnlock]]] | Add a new SCM server to the list of available SCMs. | Can we just reuse default DN heartbeat interval(HddsConfigKeys#HDDS_HEARTBEAT_INTERVAL_DEFAULT, 30s) rather than defined a new rpc retry interval here? Would this a better way? |
@@ -158,6 +158,14 @@ def test_make_field_map_meg():
assert_raises(ValueError, make_field_map, evoked, ch_type='foobar')
+ # now test the make_field_map on head surf for MEG
+ evoked.pick_types(meg=True, eeg=False)
+ fmd = make_field_map(evoked, trans_fname, meg_surf='head',
+ s... | [test_legendre_val->[rand,legval,fun,_get_legen_table,partial,_comp_sum_eeg,arange,cumprod,empty,_comp_sums_meg,flatten,linspace,legvander,zip,zeros,range,assert_allclose],test_make_field_map_eeg->[make_field_map,assert_array_equal,read_evokeds,assert_true,len,assert_raises,get_head_surf,pick_types],test_make_field_map... | Test interpolation of MEG field onto helmet . Get args dictionary for . | This now requires `trans_fname`, which in turn requires the testing dataset, which in turn means this test needs the `requires_testing_data` decorator (it's why Travis is angry). Then we can merge! |
@@ -168,8 +168,8 @@ public class LogicalPlannerTest {
Assert.assertTrue(aggregateNode.getGroupByExpressions().size() == 1);
Assert.assertTrue(aggregateNode.getGroupByExpressions().get(0).toString().equalsIgnoreCase("TEST1.COL0"));
Assert.assertTrue(aggregateNode.getRequiredColumnList().size() == 2);
- ... | [LogicalPlannerTest->[testSimpleLeftJoinFilterLogicalPlan->[buildLogicalPlan],testSimpleAggregateLogicalPlan->[buildLogicalPlan],testComplexAggregateLogicalPlan->[buildLogicalPlan],shouldCreatePlanWithTableAsSource->[buildLogicalPlan],testSimpleQueryLogicalPlan->[buildLogicalPlan],testSimpleLeftJoinLogicalPlan->[buildL... | This method test simple aggregate logical plan. This method checks if the aggregate node is valid. | can we change these to use `assertThat(..)` |
@@ -31,14 +31,12 @@ namespace Microsoft.NET.HostModel.AppHost
/// <param name="appBinaryFilePath">Full path to app binary or relative path to the result apphost file</param>
/// <param name="windowsGraphicalUserInterface">Specify whether to set the subsystem to GUI. Only valid for PE apphosts.</param>... | [HostWriter->[CodeSign->[OSX,WaitForExit,Exists,IsOSPlatform,ExitCode,Start,Assert,ReadToEnd],IsBundle->[RetryOnIOError,SearchInFile,CreateFromFile,ReadInt64,CreateViewAccessor],CreateAppHost->[OSX,RetryOnWin32Error,Delete,SearchAndReplace,CreateViewAccessor,IsOSPlatform,Windows,GetBytes,CreateFromFile,IsSupportedOS,Cr... | Create an apphost with the given parameters. This method checks if there is a missing apphost file in - memory and if so writes. | If we change the call in the SDK first we can avoid breaking the runtime -> SDK flow |
@@ -557,7 +557,15 @@ class StandaloneValidationForm(AddonUploadForm):
u'your own and only need it to be signed by Mozilla.'))
-class NewVersionForm(NewAddonForm):
+class NewVersionForm(AddonUploadForm):
+ supported_platforms = forms.TypedMultipleChoiceField(
+ choices=amo.SUPPORTED_PLATFORMS_... | [CheckCompatibilityForm->[clean_application->[version_choices_for_app_id]],CompatForm->[AppVersionChoiceField],ProfileForm->[_Form],check_paypal_id->[check_paypal_id],NewVersionForm->[clean->[_clean_upload]],NewAddonForm->[clean->[_clean_upload]],LicenseForm->[LicenseRadioSelect]] | Create a form to upload a new version. Check if a version already exists. | Why ? When should this happen ? This seem like a bad idea. |
@@ -192,7 +192,7 @@ public abstract class HttpClientTracer<REQUEST, CARRIER, RESPONSE> extends BaseT
URI url = url(request);
if (url != null) {
netPeerAttributes.setNetPeer(setter, url.getHost(), null, url.getPort());
- final URI sanitized;
+ URI sanitized;
if (url.getUserI... | [HttpClientTracer->[inject->[getSetter,inject],endMaybeExceptionally->[end,endExceptionally],onResponse->[status],setUrl->[url],internalStartSpan->[startSpan],shouldStartSpan->[shouldStartSpan],end->[end],endExceptionally->[endExceptionally],onRequest->[onRequest,method,requestHeader],setFlavor->[flavor],spanNameForReq... | Sets the url attribute. | Why this is bad? If I want to guarantee that local variable is read-only, why is it bad to do so? |
@@ -53,6 +53,7 @@ public class ExpressionFilter implements Filter, MuleContextAware
private ExpressionConfig config;
private String fullExpression;
private boolean nullReturnsTrue = false;
+ private boolean nonBooleanReturnsTrue = parseBoolean(getProperty(MULE_EXPRESSION_FILTER_DEFAULT_BOOLEAN_VALUE, ... | [ExpressionFilter->[setCustomEvaluator->[setCustomEvaluator],accept->[accept],setEvaluator->[setEvaluator],getCustomEvaluator->[getCustomEvaluator],getFullExpression->[getFullExpression],getExpression->[getExpression],getEvaluator->[getEvaluator],setExpression->[setExpression]]] | ExpressionFilter provides a way to specify a boolean expression when using an expression filter or to use Constructor for ExpressionFilter. | Remember to remove this from the 3.x solution, you can directly modify the `expression-filter` XSD to allow the new attribute there (you'll need a functional test there to validate it works). |
@@ -237,6 +237,8 @@ define([
* The expression must return or convert to a <code>Boolean</code>.
* </p>
*
+ * Applicable to all tile formats.
+ *
* @memberof Cesium3DTileStyle.prototype
*
* @type {StyleExpression}
| [No CFG could be retrieved] | Provides a property that can be used to evaluate the style s <code > show property. Provides a custom show expression that can be used to show a feature in a cesium. | To be consistent with the other descriptions, adjust to: `This expression is applicable to all tile formats` Wrap with `<p> </p>` like the others. Add this note to `color` as well. |
@@ -5631,12 +5631,10 @@ namespace ProtoCore.DSASM
if (instruction.op1.IsStaticVariableIndex)
{
- FX = svData;
-
if (0 == dimensions)
{
StackValue coercedValue = TypeSystem.Coerce(svData, staticType, rank, core);
- ... | [No CFG could be retrieved] | Get the original value of variable. Pop the next block of data from the stack and return the list of values. | Yea retaining makes sense if its static, not sure how we missed this. |
@@ -19,7 +19,14 @@ use Sulu\Component\Content\Compat\PropertyInterface;
*/
interface ContentTypeInterface
{
+ /**
+ * @deprecated All the ContentTypes should be of this type, so declaring it explicitly is not necessary
+ */
const PRE_SAVE = 1;
+
+ /**
+ * @deprecated This type is not supporte... | [No CFG could be retrieved] | Reads the content type of a node and sets the value of the Sulu property. Writes the value from given node and property. | If it is not used can we not remove it? |
@@ -112,13 +112,15 @@ public class ZeppelinConfiguration extends XMLConfiguration {
if (properties == null || properties.size() == 0) {
return d;
}
+ StringBuilder allvalues = new StringBuilder(); // comma separated values for same name
for (ConfigurationNode p : properties) {
if (p.getC... | [ZeppelinConfiguration->[getLong->[getLong,getLongValue],useClientAuth->[getBoolean],getRelativeDir->[getRelativeDir,getString],useSsl->[getBoolean],getInt->[getIntValue,getInt],getServerAddress->[getString],getUser->[getString],getEndpoint->[getString],getNotebookDir->[getString],isType->[checkType],getTrustStorePassw... | getStringValue - Gets the string value of the property with the given name. | In case of non-empty `allvalues`, doesn't this code just remove the comma, added by line #120? |
@@ -242,3 +242,9 @@ def load_data(subject, path=None, force_update=False, update_path=None,
epochs.info['bads'] = missing_chans # missing channels are marked as bad.
return epochs
+
+###############################################################################
+# References
+# ----------
+#
+# .. footbib... | [load_data->[make_standard_montage,transpose,join,loadmat,DataFrame,enumerate,EpochsArray,empty,startswith,_check_pandas_installed,zeros,list,data_path,len,ValueError,isinstance,arange,create_info,array],data_path->[splitext,any,ZipFile,write,extractall,namelist,isdir,_fetch_file,endswith,len,_do_path_update,join,close... | Load all epochs data for a given subject. max max n - events - max n - events - max n - events - max n -- 5 ) Create custom info for mne epochs structure . | remove the blank line here. Otherwise our style checker will complain that "docstring sections should not start with a blank line" |
@@ -51,6 +51,8 @@ class SemanticRoleLabeler(Model):
self.stacked_encoder = stacked_encoder
self.tag_projection_layer = TimeDistributed(Linear(self.stacked_encoder.get_output_dim(),
self.num_classes))
+ initializer(self.stacked_encoder)... | [SemanticRoleLabeler->[tag->[forward],from_params->[from_params]]] | Initialize the SequelizeRoleLabeler class. A function to perform the unnormalised unnormalised log probabilities of the tag classes. Output a dictionary of logits and class probabilities for a . | Would calling `initializer(self)` accomplish the same thing here? |
@@ -716,6 +716,18 @@ void Server::handleCommand_ClientReady(NetworkPacket* pkt)
peer_id, major_ver, minor_ver, patch_ver,
full_ver);
+ std::vector<std::string> players = m_clients.getPlayerNames();
+ NetworkPacket list_pkt(TOCLIENT_UPDATE_PLAYER_LIST, 0, peer_id);
+ list_pkt << (u8) PLAYER_LIST_INIT << (u16) ... | [handleCommand_Interact->[process_PlayerPos],handleCommand_PlayerPos->[process_PlayerPos]] | Handle client ready in order to send a shutdown message to the client. | Space here too much, missing one before `:`. |
@@ -84,7 +84,8 @@ class QuantizeTranspiler(object):
activation_bits=8,
activation_quantize_type='abs_max',
weight_quantize_type='abs_max',
- window_size=10000):
+ window_size=10000,
+ moving_rate=0.9):
"""
... | [BNFuseTranspiler->[_fuse_param->[_load_param,_update_param,_original_var_name]],QuantizeTranspiler->[training_transpile->[_transpile_backward,_transpile_forward],_insert_quant_range_abs_max_op->[_quantized_var_name,_quantized_scale_name],_insert_dequant_op->[_dequantized_var_name],convert_to_int8->[convert_to_int8],_i... | Convert and rewrite the fluid Program according to weight and activation quantization type. Initialize the object with weight quantize type and window size. | Because Transpilers are deprecated. I think these changes about QuantizeTranspiler in this PR should update on `QuantizationTransformPass` and `QuantizationFreezePass` first. After that, you can choose to make the same update on `QuantizeTranspiler`. |
@@ -44,9 +44,11 @@ def pyunit_mean_per_class_error():
mpce = gbm.mean_per_class_error(train=True)
assert( mpce == 0 )
mpce = gbm.mean_per_class_error(valid=True)
- assert(abs(mpce - 0.207142857143 ) < 1e-5)
+ # assert(abs(mpce - 0.207142857143 ) < 1e-5)
+ assert(abs(mpce - 0.407142857143 ) < 1e-... | [pyunit_mean_per_class_error->[import_file,train,list,mean_per_class_error,int,get_grid,print,scoring_history,H2OGridSearch,model_performance,log,H2OGradientBoostingEstimator,range,cars,abs],standalone_test,insert] | This function is a utility function to estimate the mean per class error of a single class. This function is used to train a column of the BeamMoment model. Train a H2O regression grid and return the mean of the missing components. | To make this test pass I had to almost double the expected mean per class error. I don't like it but since this test probably wasn't run anywhere outside Arno's computer it is hard to say when did this happen. (I could `git bisect` it but I am not sure if there would be any benefit in knowing when did the error rate in... |
@@ -627,7 +627,13 @@ class Trainer:
"""
Trains the supplied model with the supplied parameters.
"""
- epoch_counter, validation_metric_per_epoch = self._restore_checkpoint()
+ try:
+ epoch_counter, validation_metric_per_epoch = self._restore_checkpoint()
+ exce... | [Trainer->[train->[_enable_activation_logging,_validation_loss,_update_learning_rate,_should_stop_early,_metrics_to_tensorboard,_enable_gradient_clipping,_metrics_to_console,_train_epoch,_get_metrics],_enable_activation_logging->[hook->[add_train_histogram]],_rescale_gradients->[sparse_clip_norm],_validation_loss->[_ge... | Trains the model with the supplied parameters. Get the n - node node - metrics for a given epoch. | The stack trace from the `raise` below will bury this message. I'd probably print the stack trace, then raise a new error with this nicer message (also saying that the `restore_checkpoint` stack trace is available above, in case it is needed for some reason). |
@@ -45,8 +45,7 @@ namespace System.Tests
[Fact]
[SkipOnPlatform(TestPlatforms.Browser, "throws pNSE")]
- [ActiveIssue("https://github.com/dotnet/runtime/issues/49868", TestPlatforms.Android)]
- [ActiveIssue("https://github.com/dotnet/runtime/issues/36896", TestPlatforms.iOS | TestPlatf... | [AppDomainTests->[IsFullyTrusted->[IsFullyTrusted],LoadBytes->[Load],AssemblyResolve_ExceptionPropagatesCorrectly->[AssemblyResolve],ExecuteAssembly->[ExecuteAssembly],Load->[Load],ApplyPolicy->[ApplyPolicy],ShadowCopyFiles->[ShadowCopyFiles],FriendlyName->[FriendlyName],IsFinalizingForUnload->[IsFinalizingForUnload],M... | Tests that the target system is running on a host machine. | Nit: Something's off in the grammar of the justification. |
@@ -63,6 +63,16 @@ static int pkey_sm2_copy(EVP_PKEY_CTX *dst, EVP_PKEY_CTX *src)
return 0;
}
}
+ if (sctx->id != NULL) {
+ dctx->id = OPENSSL_malloc(sctx->id_len);
+ if (dctx->id == NULL) {
+ pkey_sm2_cleanup(dst);
+ return 0;
+ }
+ memcpy... | [int->[sm2_ciphertext_size,sm2_plaintext_size,sm2_decrypt,EC_GROUP_new_by_curve_name,OBJ_sn2nid,pkey_sm2_init,OBJ_ln2nid,EC_GROUP_dup,EC_GROUP_free,sm2_sign,OPENSSL_zalloc,sm2_encrypt,SM2err,strcmp,EVP_PKEY_CTX_set_ec_paramgen_curve_nid,EVP_PKEY_CTX_set_ec_param_enc,pkey_sm2_cleanup,EC_curve_nist2nid,EC_GROUP_set_asn1_... | if src is not in dst return 1 ; else return 0 ;. | Probably you need to copy `id_len` unconditionally to pick up the `-1` initialisation |
@@ -9,7 +9,11 @@ import (
)
// Diff provides the changes between two container layers
-func Diff(ctx context.Context, nameOrID string) ([]archive.Change, error) {
+func Diff(ctx context.Context, nameOrID string, options *DiffOptions) ([]archive.Change, error) {
+ if options == nil {
+ options = new(DiffOptions)
+ ... | [DoRequest,GetClient,Process] | Diff provides the changes between two container layers. | Great idea to allow `nil`! I think it's a nice compromise between avoiding future breaking changes (if we have the need to at fields to the currently empty struct) and being easy to use: `Diff(a, b, nil)` is nicer than `Diff(a, b, &images.DiffOptions)`. |
@@ -32,7 +32,7 @@ class TestModifiedHuberLossOp(OpTest):
self.check_output()
def test_check_grad(self):
- self.check_grad(['X'], 'Out', max_relative_error=0.005)
+ self.check_grad(['X'], 'Out', max_relative_error=0.01)
if __name__ == '__main__':
| [TestModifiedHuberLossOp->[test_check_output->[check_output],test_check_grad->[check_grad],setUp->[uniform,vectorize,reshape,choice]],main] | Check the gradient of the test. | Just a random question: could we have a systematic way to set the error tolerance? |
@@ -181,8 +181,8 @@ module BootstrapFormHelper
id = "#{@object_name}_#{name.to_s}"
input_name = "#{@object_name}[#{name.to_s}]"
- icon_str = '<span class="glyphicon glyphicon-ok" aria-hidden="true"></span>'
- icon_str_hidden = '<span class="glyphicon glyphicon-ok" aria-hidden="true" style="dis... | [color_picker_btn_group->[html_safe,to_s,humanize,each_with_index],datetime_picker->[to_s,to_i,html_safe,humanize,t],tiny_mce_editor->[text_area,merge!],smart_text_area->[nil?,join,text_area,try,delete],color_picker_select->[each,html_safe,to_s],enum_btn_group->[send,to_s,new,pluralize,humanize,collect,each,html_safe]] | Displays a button group with a single node with a color picker. missing node - color - picker. | Metrics/LineLength: Line is too long. [102/80] |
@@ -443,12 +443,14 @@ class PythonPackage(PackageBase):
ignore_namespace = True
bin_dir = self.spec.prefix.bin
- global_view = self.extendee_spec.prefix == view.root
+ globl_view = self.extendee_spec.prefix == view.get_projection_for_spec(
+ self.spec
+ )
... | [PythonPackage->[install->[setup_py],sdist->[setup_py],_setup_command_available->[setup_file,python],build_scripts->[setup_py],register->[setup_py],setup_py->[setup_file,python],upload->[setup_py],install_headers->[setup_py],build_ext->[setup_py],check->[setup_py],build_py->[setup_py],bdist->[setup_py],bdist_dumb->[set... | Remove files from view that are not in merge_map. | (minor - consistency) IMO this variable should be called the same thing in both methods where the concept applies (so users can grep for one having seen the other). |
@@ -175,7 +175,7 @@ spring:
database-platform: tech.jhipster.domain.util.FixedH2Dialect
<%_ } _%>
<%_ } _%>
- <%_ if (databaseType === 'mongodb' || databaseType === 'cassandra' || searchEngine === 'elasticsearch') { _%>
+ <%_ if (databaseType === 'mongodb' || databaseType === 'cassandra' || (searchEngine... | [No CFG could be retrieved] | Configuration for missing configuration for missing configuration. Return a serializable representation of the n - tuple. | With these changes, line 199 to 203 will never be filled. |
@@ -318,6 +318,14 @@ func convertStringSet(set *schema.Set) []string {
return s
}
+func convertStringMap(v map[string]interface{}) map[string]string {
+ m := make(map[string]string)
+ for k, val := range v {
+ m[k] = val.(string)
+ }
+ return m
+}
+
func convertArrToMap(ifaceArr []interface{}) map[string]struct{... | [GetType,Printf,LastIndex,MatchString,GetOk,Do,Contains,Sprintf,Split,List,Errorf,Len,ContainsType,SetId,Get,HasPrefix,MustCompile] | convertArrToMap converts an array of interfaces to a map of strings. | expandStringMap does the same as this i believe |
@@ -190,6 +190,10 @@ func (d *decoder) Read(p []byte) (int, error) {
d.nbuf -= numBytesToDecode
copy(d.buf[0:d.nbuf], d.buf[numBytesToDecode:numBytesToDecode+d.nbuf])
+ if ret == 0 && d.err == nil && len(p) != 0 {
+ return 0, io.EOF
+ }
+
return ret, d.err
}
| [Write->[Encode,Write],Close->[EncodedLen,Encode,Write],Read->[Decode,ReadAtLeast,DecodedLen,getByteType,Read],EncodeToString->[EncodedLen,Encode],DecodeString->[Decode,DecodedLen],hasSkipBytes] | Read reads bytes from the stream. This function is called when we have too many bytes for the given buffer. It will buffer. | Did this fix a bug you ran into? |
@@ -271,7 +271,12 @@ TAGSPUBKEY
$signature = json_decode($signature, true);
$signature = base64_decode($signature['sha384']);
$verified = 1 === openssl_verify(file_get_contents($tempFilename), $signature, $pubkeyid, $algo);
- openssl_free_key($pubkeyid);
+
+ ... | [SelfUpdateCommand->[setLocalPhar->[getMessage,isInteractive,validatePhar,tryAsWindowsAdmin,isWindowsNonAdminUser,writeError,getIO],configure->[setHelp],rollback->[setLocalPhar,getIO,writeError,getLastBackupVersion],validatePhar->[getMessage],getLastBackupVersion->[sortByName,getOldInstallationFinder],tryAsWindowsAdmin... | Executes the command. Get the user s UID and the name of the user who owns composer. Checks if a new major version is available and if so updates it. Downloads a new version of the Composer and updates it if necessary. | I suggest using `\PHP_VERSION_ID` which resolves the version check at compile time. |
@@ -2,14 +2,12 @@ package file
import (
"os"
- "sync"
"time"
-
- "github.com/elastic/beats/libbeat/logp"
)
// State is used to communicate the reading state of a file
type State struct {
+ Id string `json:"-"` // local unique id for comparison and indexing states.
Source string `js... | [Copy->[GetStates],FindPrevious->[Lock,Unlock,findPrevious],Cleanup->[Unlock,Now,Lock,Sub,Err,Debug],findPrevious->[IsSame],Count->[Lock,Unlock],GetStates->[Lock,Unlock],SetStates->[Lock,Unlock],Update->[Unlock,findPrevious,Now,Lock,Debug],Now] | NewState imports a state from a file. findPreviousState returns the previous state of the given state. | struct field Id should be ID |
@@ -531,9 +531,11 @@ func (r *Ruler) newManager(ctx context.Context, userID string) (*promRules.Manag
return nil, err
}
- // Wrap registerer with userID and cortex_ prefix
- reg := prometheus.WrapRegistererWith(prometheus.Labels{"user": userID}, r.registry)
- reg = prometheus.WrapRegistererWithPrefix("cortex_", ... | [Rules->[getLocalRules],newManager->[getOrCreateNotifier],Validate->[Validate],ServeHTTP->[ServeHTTP],RegisterFlags->[RegisterFlags],loadRules->[ownsRule]] | newManager creates a new manager for the given user. | If registry for same user is added twice (because user is removed from `r.userManagers` and later added again), it will break all reported counters, as they will suddenly drop in value. :-( |
@@ -180,9 +180,10 @@ module ApplicationHelper
html = if skip_avatar
''
else
- raw("<span class=\"global-avatar-container smart-annotation\"><img src='#{user_avatar_absolute_url(user, :icon_small)}'" \
- "alt='avatar' class='atwho-user-img-popover'" \
- ... | [project_page?->[in?],display_tooltip->[truncate,length,sanitize_input,strip],sample_groups_page_my_module?->[nil?],smart_annotation_filter_resources->[html],sample_groups_page_project?->[nil?],popover_for_user_name->[email,created_at,t,include?,user_avatar_absolute_url,attached?,first,name,full_name,capitalize,raw,l],... | Displays a popover for a user. \ n + 1. | Rails/OutputSafety: Tagging a string as html safe may be a security risk. |
@@ -63,10 +63,14 @@ public abstract class AbstractAddVariablePropertyTransformer<T> extends Abstract
}
else
{
- if (!StringUtils.isEmpty(returnType.getMimeType()) || !StringUtils.isEmpty(returnType.getEncoding()))
+ if (!StringUtils.isEmpty(returnType... | [AbstractAddVariablePropertyTransformer->[initialise->[initialise],clone->[clone]]] | This method is called to transform the message. | Move empty test to builder itself and simplify this here. |
@@ -131,7 +131,7 @@ module TwoFactorAuthenticatable
end
def assign_phone
- @updating_existing_number = old_phone.present?
+ @updating_existing_number = session[:phone_id].present?
if @updating_existing_number && confirmation_context?
phone_changed
| [handle_invalid_otp->[handle_second_factor_locked_user],generic_data->[personal_key_unavailable?]] | if there is no phone number in the system we can t do anything. | Shouldn't this be `user_session[:phone_id]`? |
@@ -371,15 +371,13 @@ static INPUT_PORTS_START( spacewar )
PORT_BIT( 0x08, IP_ACTIVE_LOW, IPT_BUTTON3 ) PORT_PLAYER(2)
PORT_BIT( 0x10, IP_ACTIVE_LOW, IPT_BUTTON1 ) PORT_PLAYER(1)
PORT_BIT( 0x20, IP_ACTIVE_LOW, IPT_BUTTON3 ) PORT_PLAYER(1)
- PORT_DIPNAME( 0x40, 0x40, DEF_STR( Unknown ) )
- PORT_DIPSETTING( 0x40... | [No CFG could be retrieved] | Options 7 - 7 - 5 - 2 - 2 - 3 - 2 - 2 - 3 PORT_PLAYER 1 - > PORT_PLAYER2 - > PORT_PLAYER. | You should really avoid `IPT_OTHER` with overridden assignments in the driver. Remember people use MAME with input devices other than keyboards, and people do use general input assignments. Is this a player input or an operator input? If it's a player input, it should probably be a button. If it's an operator input, us... |
@@ -455,9 +455,11 @@ def read_dig_montage(hsp=None, hpi=None, elp=None, point_names=None,
point_names : None | list
If list, this corresponds to a list of point names. This must be
specified if elp is defined.
- unit : 'm' | 'cm' | 'mm'
- Unit of the input file. If not 'm', coordinates ... | [read_dig_montage->[_check_frame,DigMontage],read_montage->[Montage]] | Read subject - specific digitization montage from a file. This function returns a list of all digitized points and the corresponding FITS data in the missing - return False if no missing - return True if no missing - return False if no Diagonal and non - trivial version of the DigMontage function. | Thanks @agramfort ! This here would be the API change (default to `unit="auto"` instead of `unit="mm"`). It does not change the behavior for previously possible argument combination because "auto" amounts to "mm" for *.txt files and arrays. Currently (as well as before this PR) `hsp` and `elp` provided as arrays also g... |
@@ -107,4 +107,13 @@ public abstract class ServletHttpServerTracer<RESPONSE>
protected String requestHeader(HttpServletRequest httpServletRequest, String name) {
return httpServletRequest.getHeader(name);
}
+
+ private static String getSpanName(HttpServletRequest request) {
+ String spanName = request.ge... | [ServletHttpServerTracer->[unwrapThrowable->[unwrapThrowable],onRequest->[onRequest]]] | Get the value of the request header with the given name. | Technically, this is a duplication with `ServletContextPath.prepend` |
@@ -747,7 +747,10 @@ static inline void loop_switch(const float *const restrict in, float *const rest
/* FROM HERE WE ARE MANDATORILY IN XYZ - DATA IS IN temp_one */
// Gamut mapping happens in XYZ space no matter what
- gamut_mapping(temp_one, gamut, clip, temp_two);
+ if(do_gamut_mapping)
+ gam... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -. | Why not use `for_each_channel`, or even more succinctly, `copy_pixel(temp_two,temp_one)`? Copying three elements won't vectorize. |
@@ -109,7 +109,9 @@ class DygraphToStaticAst(gast.NodeTransformer):
self.visit(node.node)
# Transform basic api of dygraph to static graph
- BasicApiTransformer(node).ast_visit()
+ basic_api_trans = BasicApiTransformer(node)
+ basic_api_trans.ast_visit()
+ self.feed_name_... | [DygraphToStaticAst->[transfer_from_node_type->[IfElseTransformer]]] | Transfer from Dygraph to Static Graph. | Sub-function may be defined in the decorated function and it will override the index information. Currentlythe decorated function is `forward` at most time. You should consider to handle these cases in next PR. |
@@ -39,6 +39,11 @@ public class LegacyHadoopConfigurationSource implements ConfigurationSource {
return configuration.getRaw(key);
}
+ @Override
+ public char[] getPassword(String key) throws IOException {
+ return configuration.getPassword(key);
+ }
+
@Override
public Collection<String> getConfig... | [LegacyHadoopConfigurationSource->[asHadoopConfiguration->[IllegalArgumentException],set->[set],get->[getRaw],getConfigKeys->[keySet]]] | Get the raw value of the configuration with the given key. | Should we also remove the deault method on ConfigurationSource for getPassword, and have the get() method in OzoneConfiguration and the new method in LegacyHadoopConfig ? |
@@ -40,9 +40,10 @@ img {
border-width:0;
border-color:transparent;
}
+/* keep focus styles for a11y
:focus {
outline: 0 none;
-}
+}*/
ol, ul {
list-style: none;
}
| [No CFG could be retrieved] | ****************************************** CSS CSS - related functions Demonstrates how to display an array of objects. | This is the most important change. Why we reset this, I don't know |
@@ -86,8 +86,14 @@ def generate_news(session: Session, version: str) -> None:
def update_version_file(version: str, filepath: str) -> None:
+ with open(filepath, "r", encoding="utf-8") as f:
+ content = list(f)
with open(filepath, "w", encoding="utf-8") as f:
- f.write('__version__ = "{}"\n'.... | [get_version_from_arguments->[all,isdigit,split,len],generate_news->[install,run],get_author_list->[append,add,sorted,strip,set,run,splitlines,lower],update_version_file->[open,format,write],get_next_development_version->[split,map],modified_files_in_git->[run],generate_authors->[open,join,get_author_list,write],create... | Update version file with new version. | Ideally, we'd want to have an assertion to ensure that this line was actually run (basically, set a flag and assert it at the end?). |
@@ -268,11 +268,14 @@ func defaultConfig(beatVersion string) *Config {
Register: ®isterConfig{
Ingest: &ingestConfig{
Pipeline: &pipelineConfig{
+ Enabled: &pipeline,
+ Overwrite: &pipeline,
Path: paths.Resolve(paths.Home,
filepath.Join("ingest", "pipeline", "definition.json")),
... | [setSmapElasticsearch->[isEnabled],Unpack->[ToLower],memoizedSmapMapper->[isEnabled,NewSmapMapper,isSetup],Join,Unpack,Error,Resolve,MustNewConfigFrom,Sprintf,ReplaceAllLiteralString,New,HasField,isEnabled,JoinHostPort,Child,Compile,Wrap,SetString,MustCompile] | Register config for the application. | ideally the pipeline name is a const (also in beater_test) |
@@ -0,0 +1,14 @@
+// This file is executed via Puppeteer's page.evaluate on a document to copy the
+// current image data of the canvas to an attribute so that it will be passed in the
+// snapshots to Percy.
+
+const canvases = document.querySelectorAll('canvas');
+canvases.forEach((canvas) => {
+ const parentNode = ... | [No CFG could be retrieved] | No Summary Found. | nit: `parentNode.replaceChild(img, canvas)` (or maybe even `canvas.replaceWith(img)` and completely skip the parentNode, if `canvas` is a ChildNode instance, dunno if that's true though) |
@@ -2665,6 +2665,7 @@ class Spec(object):
return [spec for spec in self.traverse() if spec.virtual]
@property
+ @memoized
def patches(self):
"""Return patch objects for any patch sha256 sums on this Spec.
| [colorize_spec->[insert_color],DependencySpec->[copy->[DependencySpec]],ConflictsInSpecError->[__init__->[format,tree]],SpecParser->[check_identifier->[format],spec->[_dup,_add_version,_set_compiler,satisfies,Spec,_add_flag,spec_by_hash,dag_hash],version_list->[version],compiler->[version_list,_add_version],do_parse->[... | Return patches for any sha256 sums on this Spec. . | @michaelkuhn Do you remember if there was an inherent reason to add memoization here? |
@@ -896,11 +896,13 @@ export function onAdLoad(global) {
/**
* Called intermittently as the ad plays, allowing us to display ad counter.
- * @param {!Object} global
+ * @param {!Object} unusedEvent
* @visibleForTesting
*/
-export function onAdProgress(global) {
- const {adPosition, totalAds} = global.getAdDat... | [No CFG could be retrieved] | Adds hover events to the video element. This function is called by the google. ima. SDK to start the ADC. | Shall we remove the `unusedEvent` from code? |
@@ -235,6 +235,13 @@ public class LocalChannel extends AbstractChannel {
}
}
+ private void doPeerClose(LocalChannel peer, boolean peerWriteInProgress) {
+ if (peerWriteInProgress) {
+ finishPeerRead0(this);
+ }
+ peer.unsafe().close(peer.unsafe().voidPromise());
+ ... | [LocalChannel->[LocalUnsafe->[connect->[doBind]],doRegister->[parent,localAddress],doClose->[isActive,parent],remoteAddress->[remoteAddress],parent->[parent],localAddress->[localAddress]]] | Override to close the channel. | `peer.unsafe()` could be extracted into a local final variable. |
@@ -256,6 +256,10 @@ func (p CommandLine) GetTorProxy() string {
return p.GetGString("tor-proxy")
}
+func (p CommandLine) GetMountDir() string {
+ return p.GetGString("mountdir")
+}
+
func (p CommandLine) GetBool(s string, glbl bool) (bool, bool) {
var v bool
if glbl {
| [Parse->[ParseArgv,Run,GetRunMode],GetGpg->[GetGString],GetLinkCacheSize->[GetGInt],GetTimers->[GetGString],GetLocalTrackMaxAge->[GetGDuration],GetTorProxy->[GetGString],GetUserCacheMaxAge->[GetGDuration],getKIDs->[GetGString],GetCodeSigningKIDs->[getKIDs],GetSecretKeyringTemplate->[GetGString],GetProofCacheSize->[GetG... | GetTorProxy returns the TorProxy if it exists otherwise it returns the string. | Change this to "mount-dir"? |
@@ -147,6 +147,16 @@ public final class RayNativeRuntime extends AbstractRayRuntime {
nativeSetResource(nativeCoreWorkerPointer, resourceName, capacity, nodeId.getBytes());
}
+ @Override
+ public Object getAsyncContext() {
+ throw new UnsupportedOperationException();
+ }
+
+ @Override
+ public void se... | [RayNativeRuntime->[resetLibraryPath->[error,getProperty,isNullOrEmpty,setAccessible,setProperty,getDeclaredField,set,join,isEmpty],setResource->[checkArgument,compare,getBytes,nativeSetResource],run->[nativeRunTaskExecutor],registerWorker->[RedisClient,getProperty,String,hmset,currentTimeMillis,getBytes,put,valueOf,ge... | This method is called by the worker thread that sets the resource. | We can't just throw exceptions here. Because, in drivers, the runtime is `RayNativeRuntime`. |
@@ -221,7 +221,7 @@ def test_uninstall_before_upgrade_from_url(script):
)
result2 = script.pip(
'install',
- 'https://pypi.python.org/packages/source/I/INITools/INITools-'
+ 'https://files.pythonhosted.org/packages/source/I/INITools/INITools-'
'0.3.tar.gz',
expect_erro... | [test_eager_does_upgrade_dependecies_when_currently_satisfied->[pip_install_local],test_upgrade_to_specific_version->[pip],test_no_upgrade_unless_requested->[pip],test_uninstall_before_upgrade->[sorted,pip,assert_all_changes,keys],TestUpgradeDistributeToSetuptools->[prep_ve->[insert,pip_install_local,run]],test_uninsta... | Test uninstall - before - upgrade from URL. | What's the reference to pythonhosted.org? Why are we depending on files hosted there, rather than on PyPI like we did previously? Who will be maintaining those files (and who even has access to them)? I'd prefer to continue getting our test files from PyPI, if we're not bundling them with the test suite. |
@@ -1804,15 +1804,6 @@ def md5sum(fname, block_size=1048576): # 2 ** 20
return md5.hexdigest()
-def _sphere_to_cartesian(theta, phi, r):
- """Transform spherical coordinates to cartesian"""
- z = r * np.sin(phi)
- rcos_phi = r * np.cos(phi)
- x = rcos_phi * np.cos(theta)
- y = rcos_phi * np.sin... | [set_config->[get_config_path],get_config->[get_config_path],object_diff->[_sort_keys,object_diff],_get_stim_channel->[get_config],_chunk_write->[update_with_increment_value],_get_ftp->[ProgressBar],object_hash->[object_hash,_sort_keys],md5sum->[update],_check_mayavi_version->[check_version],set_log_file->[WrapStdOut],... | Transform spherical coordinates to cartesian. | This was a duplicate function that was never used. See `mne.transforms` line 543. It was also reducing coverage. |
@@ -21,12 +21,10 @@ const keyPrefix = angularAppName + '.'+ entityTranslationKey + '.';
_%>
<form name="editForm" role="form" novalidate (ngSubmit)="save()" #editForm="ngForm">
- <div class="modal-header">
- <h4 class="modal-title" id="my<%= entityClass %>Label" jhiTranslate="<%= keyPrefix %>home.createOr... | [No CFG could be retrieved] | Displays a modal window that displays a single unique identifier. field type is text number local date datetime - local datetime. | the classes and filenames needs to be changed to remove dialog from it |
@@ -473,11 +473,12 @@ function profiles_post(App $a) {
intval(local_user())
);
- if($r)
+ if ($r) {
info( t('Profile updated.') . EOL);
+ }
- if($namechanged && $is_default) {
+ if ($namechanged && $is_default) {
$r = q("UPDATE `contact` SET `name` = '%s', `name-date` = '%s' WHERE `self` = 1 A... | [profile_activity->[get_hostname],profiles_content->[remove_baseurl]] | POST a profile Parse the user s profile and return a link to the relationship target. - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - This function is used to convert the user s tags into a human readable format. | You missed several of them ;.) |
@@ -901,8 +901,8 @@ class TaskRunner(Runner):
except signals.LOOP as exc:
new_state = exc.state
assert isinstance(new_state, Looped)
- new_state.result = Result(
- value=new_state.result, result_handler=self.result_handler
+ new_state.result = Resu... | [TaskRunner->[run_mapped_task->[run_fn->[run]],run->[initialize_run],get_task_run_state->[run]]] | Runs the task and traps any signals or errors or raises a . Get state of object. | Sounded from the call today that these need to be instantiated as `JSONResult` objects here as an internal implementation detail for looping. |
@@ -69,7 +69,7 @@ func AddOrgHook(ctx *context.APIContext, form *api.CreateHookOption) {
org := ctx.Org.Organization
hook, ok := addHook(ctx, form, org.ID, 0)
if ok {
- ctx.JSON(200, convert.ToHook(org.HomeLink(), hook))
+ ctx.JSON(201, convert.ToHook(org.HomeLink(), hook))
}
}
| [GetWebhookByOrgID,Status,JSON,Error,CreateWebhook,GetWebhookByRepoID,Marshal,UpdateWebhook,UpdateEvent,IsErrWebhookNotExist,ToHookContentType,ToHookTaskType,HomeLink,IsValidHookTaskType,IsSliceContainsStr,ToHook,IsValidHookContentType] | CheckCreateHookOption check if a CreateHookOption is valid. If it is valid it w creates a new webhook with the given form. | maybe change to `http.StatusCreated` for readable. |
@@ -587,10 +587,7 @@ async function buildExtensionCss(extDir, name, version, options) {
const parallel = [mainCssBinaryPromise];
- // Currently JSON.stringifying to allow arrays and strings:
- // {"wrapper": "bento"} and {"wrapper": ["bento"]}
- // TODO(https://go.amp.dev/issue/36351): Use a `bento` flag inst... | [No CFG could be retrieved] | Writes the extension s CSS binaries and the main JS and CSS binaries. This function is not cached. | Do we need a separate `bento` option, or can building `bento-*.js` be included with `options.npm`? |
@@ -1590,7 +1590,7 @@ namespace Microsoft.Extensions.Primitives
private static StringSegment MakePaddedStringSegment(string input)
{
- return (input is null) ? new StringSegment() : new StringSegment("xx" + input + "zzz", 2, input.Length);
+ return (input is null) ? new StringS... | [StringSegmentTest->[StringSegment_AsSpanStartLength_NoValue->[AsSpan,Assert],StringSegment->[Length],StringSegment_EndsWith_Valid->[EndsWith,Equal,nameof],StringSegment_CreateEmptySegment->[HasValue,True],StringSegment_StartsWith_Globalized->[Equal,nameof,NetFramework,MakePaddedStringSegment,StartsWith],GetHashCode_Re... | Returns a StringSegment with the given input padded if necessary. | Why is this being changed? |
@@ -1621,7 +1621,6 @@ class State:
"""Marks this module as having a stale public interface, and discards the cache data."""
self.meta = None
self.externally_same = False
- self.has_errors = on_errors
if not on_errors:
self.manager.stale_modules.add(self.id)
| [find_modules_recursive->[BuildSource,find_module,find_modules_recursive],process_graph->[add_stats,trace,log],BuildManager->[all_imported_modules_in_file->[correct_rel_imp,import_priority],get_stat->[maybe_swap_for_shadow_path],report_file->[is_source]],process_fresh_scc->[add_stats,trace],load_plugins->[plugin_error]... | Marks this module as having a stale public interface and discards the cache data. | Why is this no longer needed? |
@@ -327,7 +327,7 @@ class ConnectionManager:
return False
# if we didn't, but there's no nonfunded channels and no available partners
# it means the network is smaller than our target, so we should also break
- if not nonfunded_channels and not possible_new_partners:
+ if no... | [ConnectionManager->[_open_channels->[_find_new_partners],connect->[log_open_channels]]] | Open channels until there are enough channels open. if any of the join_partners race return True else return False. | this will never trigger as there's a test for `possible_new_partners == 0` couple of lines above |
@@ -323,8 +323,10 @@ public class KafkaStreamingExtractor<S> extends FlushingExtractor<S, DecodeableK
@Override
public S getSchema() {
try {
- Schema schema = (Schema) this._schemaRegistry.get().getLatestSchemaByTopic(this.topicPartitions.get(0).getTopicName());
- return (S) schema;
+ if(this.... | [KafkaStreamingExtractor->[shutdown->[shutdown],KafkaWatermark->[hashCode->[hashCode],compareTo->[compareTo],equals->[compareTo]],generateTags->[generateTags],readRecordEnvelopeImpl->[KafkaWatermark],getTopicPartitionWatermarks->[getLwm],onWorkUnitAdd->[getTopicPartitionsFromWorkUnit,getTopicPartitionWatermarks],close-... | Returns the latest schema in the partition. | return null? Don't understand why we are returning topic name. |
@@ -59,7 +59,7 @@ def assert_transfer_values(identifier, token, recipient):
def decode(data):
- klass = CMDID_TO_CLASS[data[0]]
+ klass = CMDID_TO_CLASS[data[0:1]]
return klass.decode(data)
| [Secret->[unpack->[Secret],__init__->[assert_envelope_values]],Ack->[unpack->[Ack]],RefundTransfer->[unpack->[Lock,RefundTransfer]],EnvelopeMessage->[sign->[packed,sign],message_hash->[packed]],Message->[__ne__->[__eq__]],Lock->[from_bytes->[Lock],as_bytes->[Lock],__ne__->[__eq__]],SignedMessage->[sign->[packed,sign]],... | Decode a sequence of bytes into a sequence of commands. | Same as above, using the slice notation can lead to an empty return value |
@@ -76,7 +76,7 @@ type Workspace interface {
// This customizes the location of $PULUMI_HOME where metadata is stored and plugins are installed.
PulumiHome() string
// PulumiVersion returns the version of the underlying Pulumi CLI/Engine.
- PulumiVersion() semver.Version
+ PulumiVersion() string
// WhoAmI retur... | [No CFG could be retrieved] | GetEnvVars - Get all environment variables scoped to the current workspace and all stacks - Get. | Can the import at to the top of the file be removed? |
@@ -82,6 +82,17 @@ public class JdbcPollingChannelAdapter extends AbstractMessageSource<Object> {
this(new JdbcTemplate(dataSource), selectQuery);
}
+ /**
+ * Constructor taking {@link DataSource} from which the DB Connection can be
+ * obtained and the select query to execute to retrieve new rows.
+ * @param... | [JdbcPollingChannelAdapter->[getPreparedStatementCreator->[getPreparedStatementCreator],PreparedStatementCreatorWithMaxRows->[getSql->[getSql],cleanupParameters->[cleanupParameters],createPreparedStatement->[setMaxRows,createPreparedStatement],setValues->[setValues]]]] | Creates a polling channel adapter that polls the database for a single . | `5.2.1` then, but I'm a bit reluctant to do all this `Supplier`-based stuff. Why then don't allow to configure a `DataSource` the same way? What would be a problem to have just a simple setter for this `selectQuery` instead? So, you still be able to change a query at runtime, but that is going to be in more cleaner way... |
@@ -39,6 +39,10 @@ class EigenSolver(MechanicalSolver):
this_defaults.AddMissingParameters(super(EigenSolver, cls).GetDefaultSettings())
return this_defaults
+ @classmethod
+ def ListOfParametersNotRecursivelyValidated(cls):
+ return ["eigensolver_settings"]
+
#### Private function... | [EigenSolver->[_create_solution_scheme->[settings,EigensolverDynamicScheme,Exception],_create_mechanical_solution_strategy->[GetComputingModelPart,get_builder_and_solver,get_solution_scheme,EigensolverStrategy],_create_linear_solver->[ConstructSolver],GetDefaultSettings->[super,Parameters,AddMissingParameters],__init__... | Returns the default settings for the Eigensolver. | you forgot to remove this |
@@ -260,3 +260,7 @@ RAVEN_ALLOW_LIST = ['addons-dev.allizom.org', 'addons-dev-cdn.allizom.org']
GITHUB_API_USER = env('GITHUB_API_USER')
GITHUB_API_TOKEN = env('GITHUB_API_TOKEN')
+
+FXA_SQS_AWS_QUEUE_URL = (
+ 'https://sqs.us-east-1.amazonaws.com/927034868273/'
+ 'amo-account-change-dev')
| [email_url,env,list,bool,LOGGING,get_redis_settings,lazy,cors_endpoint_overrides,dict,join,items,cache,lower,db] | END OF FUNCTION GITHUB_API_USER GITHUB_API_TOKEN END. | Can't we make this an environment variable and let ops configure the queues? |
@@ -106,6 +106,13 @@ public class TaskSpec {
this.newActorHandles = newActorHandles;
this.args = args;
this.numReturns = numReturns;
+
+ if (dynamicWorkerOptions == null) {
+ this.dynamicWorkerOptions = new ArrayList<>();
+ } else {
+ this.dynamicWorkerOptions =dynamicWorkerOptions;
+ ... | [TaskSpec->[getJavaFunctionDescriptor->[checkState],toString->[toString],isActorCreationTask->[isNil],isActorTask->[isNil],getPyFunctionDescriptor->[checkState],checkArgument,getClass,computeReturnId]] | Creates a new TaskSpec object. The function descriptor that is returned by the task. | just pass in an empty list? It's better to always use empty collections, instead of nulls. |
@@ -188,12 +188,16 @@ class VoucherCustomer(models.Model):
class SaleQueryset(models.QuerySet):
- def active(self, date):
+ def active(self, date=None):
+ if date is None:
+ date = timezone.now().date()
return self.filter(
Q(end_date__isnull=True) | Q(end_date__gte=dat... | [Voucher->[validate_once_per_customer->[NotApplicable],get_discount_amount_for->[get_discount],validate_min_amount_spent->[NotApplicable],validate_min_checkout_items_quantity->[NotApplicable]]] | Return all items that are active for a given date. | Start and End date in Sale model are DateTimeField we should use `timezone.now()` instead of `timezone.now().date()` |
@@ -80,9 +80,9 @@ public class ChannelParserTests {
assertEquals(DirectChannel.class, channel.getClass());
DirectFieldAccessor accessor = new DirectFieldAccessor(channel);
Object dispatcher = accessor.getPropertyValue("dispatcher");
- assertThat(dispatcher, is(UnicastingDispatcher.class));
+ assertThat(dispa... | [ChannelParserTests->[testChannelWithoutId->[getClass,ClassPathXmlApplicationContext],testChannelInteceptorInnerBean->[send,receive,getBean,getPayload,assertEquals,getClass,ClassPathXmlApplicationContext],testMultipleDatatypeChannelWithIncorrectType->[getBean,getClass,send,ClassPathXmlApplicationContext],testChannelInt... | This method is used to test the direct channel by default. | I'm not well with hamcrest, but why here it isn't wrapped with `is()`? Or from other side: does it make sense ot wrap `instanceOf()` with `is()` ? |
@@ -115,10 +115,8 @@ public class ClusterStatsService {
public LdapStats ldapStats() {
int numberOfRoles = 0;
LdapSettings ldapSettings = null;
- try {
- numberOfRoles = roleService.loadAll().size();
- ldapSettings = ldapSettingsService.load();
- } catch (NotFo... | [ClusterStatsService->[elasticsearchStats->[elasticsearchStats],mongoStats->[mongoStats]]] | This method returns the LdapStats for this application. | We can join the declaration and assignment of these two. |
@@ -145,6 +145,7 @@ func (a *Apiloader) LoadContainerServiceForAgentPoolOnlyCluster(
hasExistingCS := existingContainerService != nil
IsSSHAutoGenerated := false
hasWindows := false
+ onAzureStack := false
switch version {
case v20170831.APIVersion:
managedCluster := &v20170831.ManagedCluster{}
| [LoadContainerServiceFromFile->[DeserializeContainerService,Errorf,Error,ReadFile],SerializeContainerService->[JSONMarshalIndent,Errorf,serializeHostedContainerService],LoadAgentpoolProfileFromFile->[LoadAgentPoolProfile,Errorf,Error,ReadFile],LoadContainerService->[TypeOf,Validate,Unmarshal,Errorf,Merge],LoadContainer... | LoadContainerServiceForAgentPoolOnlyCluster loads a container service from the specified contents. This function is used to validate the input and create a managed cluster object. LoadContainerServiceForAgentPoolOnlyCluster loads the managed cluster from the agent pool. | I think variable name `isAzureStack` would align better with the code base |
@@ -305,6 +305,11 @@ public class InteractiveStatementExecutor implements KsqlConfigurable {
final Optional<PersistentQueryMetadata> query = ksqlEngine.getPersistentQuery(queryId.get());
query.ifPresent(PersistentQueryMetadata::close);
+
+ if (!query.isPresent()) {
+ final Optional<QueryMetadata> ... | [InteractiveStatementExecutor->[handleStatementWithTerminatedQueries->[putStatus],executePlan->[putFinalStatus,putStatus],executeStatement->[putFinalStatus]]] | Checks if the given terminate query is valid and if so closes it. | I believe this is invoked from reading the command from the command topic, which we're not planning on doing, so this shouldn't be required. |
@@ -819,7 +819,7 @@ define([
return;
}
- ellipseGeometry._center = ellipseGeometry._ellipsoid.scaleToGeodeticSurface(ellipseGeometry._center, ellipseGeometry._center);
+ ellipseGeometry._center = ellipseGeometry._ellipsoid.scaleToGeocentricSurface(ellipseGeometry._center, ellipseGe... | [No CFG could be retrieved] | Computes the geometric representation of a single element of an ellipsoid including its vertices indices and Extruded ellipse is a geometry with the attributes and indices. | I don't think we want to make this change. I'm pretty sure this will produce a different position than `scaleToGeodeticSurface`. The problem needs to be fixed at the Entity level. |
@@ -143,6 +143,9 @@ export class AmpLightboxViewer extends AMP.BaseElement {
/** @private {?UnlistenDef} */
this.unlistenClick_ = null;
+
+ /** @private {!string} */
+ this.currentLightboxGroupId_ = 'default';
}
/** @override */
| [No CFG could be retrieved] | Initializes the objects that are used to build the lightbox. Initializes the lightbox - viewer if it doesn t have any children. | nit: strings are primitives and are non nullable by default |
@@ -158,6 +158,15 @@ def _finalize_checkout(
)
+def _get_checkout(payment_id: int) -> Optional[Checkout]:
+ return (
+ Checkout.objects.prefetch_related("payments")
+ .select_for_update(of=("self",))
+ .filter(payments__id=payment_id, payments__is_active=True)
+ .first()
+ )
+... | [handle_refund->[_get_payment,_update_payment_with_new_transaction],handle_failed_payment_intent->[_get_payment,_update_payment_with_new_transaction],handle_processing_payment_intent->[_get_payment,_process_payment_with_checkout],handle_authorized_payment_intent->[_get_payment,_update_payment_with_new_transaction,_proc... | Helper function to update a payment with a new transaction. | I believe a name should be changed. Previously we always upade a payment with new transaction. Currently only when condition inside a function is true |
@@ -71,9 +71,15 @@ class WPSEO_GooglePlus {
* Output the Google+ specific title
*/
public function google_plus_title() {
+ $title = '';
if ( is_singular() ) {
$title = WPSEO_Meta::get_value( 'google-plus-title' );
+ }
+ elseif ( is_category() || is_tag() || is_tax() ) {
+ $title = WPSEO_Taxonomy_Met... | [No CFG could be retrieved] | Show the Google + title. | The empty check seems not necessary when you use is_string |
@@ -449,6 +449,7 @@ public class ByteUtil {
i++;
}
- return String.format("%.1f%sB", bytes / BYTE_MAGNITUDES[i], BYTE_SUFFIXES[i]);
+ // Set locale to language/country neutral to avoid different behavior for non-US users
+ return String.format(Locale.ROOT, "%.1f%sB", bytes / BYTE_MAGNI... | [ByteUtil->[equals->[equals],doubleLongToBytes->[longToBytes],longToBytes->[longToBytes]]] | Get the human readable byte count. | Nice!!! @ehsavoie you posted about this on the dev list the other day, right? |
@@ -11,7 +11,7 @@ using System.Text;
namespace System.Data.OleDb
{
- public sealed class OleDbException : System.Data.Common.DbException
+ public sealed partial class OleDbException : System.Data.Common.DbException
{
private readonly OleDbErrorCollection oledbErrors;
| [OleDbException->[GetObjectData->[GetObjectData],ErrorCodeConverter->[ConvertTo->[ConvertTo]]]] | Creates an exception that is specific to the OLE database. Get the object from the HResult object. | Does this need to be partial? I don't see the other side of the partial class. |
@@ -35,6 +35,7 @@ class PyVmdPython(PythonPackage):
depends_on('python@2.7:2.8')
depends_on('py-numpy')
+ depends_on('py-setuptools', type='run')
depends_on('tcl')
depends_on('netcdf')
depends_on('expat')
| [PyVmdPython->[depends_on,version]] | This function is a hack to work around the problem of the problem that is not a problem. | are you sure that it is a `run` but not a `build` dependency? |
@@ -82,12 +82,12 @@ func (mc *Cluster) IsRegionHot(region *core.RegionInfo) bool {
}
// RegionReadStats returns hot region's read stats.
-func (mc *Cluster) RegionReadStats() map[uint64][]*statistics.HotSpotPeerStat {
+func (mc *Cluster) RegionReadStats() map[uint64][]*statistics.HotPeerStat {
return mc.HotSpotCa... | [GetReplicaScheduleLimit->[GetReplicaScheduleLimit],AllocPeer->[allocID],RandHotRegionFromStore->[RandHotRegionFromStore],GetHotRegionScheduleLimit->[GetHotRegionScheduleLimit],UpdateStoreRegionWeight->[GetStore],UpdateStorageWrittenBytes->[GetStore],GetMergeScheduleLimit->[GetMergeScheduleLimit],UpdateStoreLeaderSize-... | RegionReadStats - returns read and write statistics for all regions in the hot spot cache. | It seems that most places replace "hotSpot" with "hot". Needs to be changed here? |
@@ -138,6 +138,11 @@ func (d *Service) Run() (err error) {
}
}
+ // Explicitly set fork type here based on KEYBASE_LABEL
+ if len(d.G().Env.GetLabel()) > 0 {
+ d.ForkType = keybase1.ForkType_LAUNCHD
+ }
+
if err = d.GetExclusiveLock(); err != nil {
return
}
| [GetExclusiveLock->[GetExclusiveLockWithoutAutoUnlock,ReleaseLock],writeServiceInfo->[ensureRuntimeDir],GetExclusiveLockWithoutAutoUnlock->[ensureRuntimeDir],Handle->[RegisterProtocols],ListenLoop->[Handle]] | Run starts the service. | I realize you suggested testing whether ForkType was set, but most commands set it to Auto already, which would seem to clash. |
@@ -57,6 +57,7 @@ public abstract class ArchiverFactory implements Serializable {
/**
* Zip format.
*/
+ @SuppressFBWarnings("MS_SHOULD_BE_FINAL")
public static ArchiverFactory ZIP = new ZipArchiverFactory();
/**
| [ArchiverFactory->[ZipArchiverFactory->[create->[ZipArchiver]],TarArchiverFactory->[create->[TarArchiver,compress]],ZipWithoutSymLinksArchiverFactory->[create->[ZipArchiver]],createZipWithoutSymlink->[ZipWithoutSymLinksArchiverFactory],ZipArchiverFactory,TarArchiverFactory]] | PUBLIC METHODS This abstract class is used to create a new archive from a given input stream ArchiverFactory for zip archive without symbolic links. | This looks like something that should be final. |
@@ -13,7 +13,9 @@ describe('StatefulPopoverContainer', () => {
test('basic render', () => {
const props = {
components: {
- Body: () => <span />,
+ Body: function CustomBody() {
+ return <span />;
+ },
},
content: jest.fn(),
onMouseEnterDelay: 100,
| [No CFG could be retrieved] | Component that is rendered by a Popover is rendered by a Popover and is rendered by state of an element. | This is rather weird... what rule requires changes like that? |
@@ -42,6 +42,9 @@ public class UpdatingJpaOutboundGatewayParser extends AbstractJpaOutboundGateway
final BeanDefinitionBuilder jpaExecutorBuilder = JpaParserUtils.getOutboundGatewayJpaExecutorBuilder(gatewayElement, parserContext);
IntegrationNamespaceUtils.setValueIfAttributeDefined(jpaExecutorBuilder, gateway... | [UpdatingJpaOutboundGatewayParser->[parseHandler->[parseHandler]]] | Override to add the JPA executor to the outbound gateway. | To be more explicit, should we throw an error here if "clean-on-flush" is specified without neither "flush" nor "flush-size" being present? |
@@ -153,7 +153,7 @@ namespace DotNetNuke.Web.Common.Internal
if (Logger.IsInfoEnabled && !e.FullPath.EndsWith(".log.resources"))
Logger.Info($"Watcher Activity: {e.ChangeType}. Path: {e.FullPath}");
- if (_handleShutdowns && !_shutdownInprogress && (e.FullPath ?? "").ToLower()... | [DotNetNukeShutdownOverload->[WatcherOnCreated->[ShceduleShutdown],WatcherOnRenamed->[ShceduleShutdown],WatcherOnDeleted->[ShceduleShutdown],WatcherOnChanged->[ShceduleShutdown]]] | called when file changes. | Please use `String#StartsWith(String, StringComparison)` |
@@ -1,2 +1 @@
-Dir[Rails.root.join('lib', 'proofer_mocks', '*')].sort.each { |file| require file }
Idv::Proofer.validate_vendors!
| [each,require,validate_vendors!] | Require all required mock files. | did this get replaced by something? Or is it that the directory doesn't exist anymore? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.