patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -302,7 +302,9 @@ class AbstractVariant(object):
"""
# If names are different then `self` does not satisfy `other`
# (`foo=bar` will never satisfy `baz=bar`)
- return other.name == self.name
+ # Otherwise we want all the values in `other` to be also in `self`
+ return o... | [VariantMap->[copy->[copy,VariantMap]],disjoint_sets->[DisjointSetsOfValues],_a_single_value_or_a_combination->[DisjointSetsOfValues],any_combination_of->[_a_single_value_or_a_combination],substitute_abstract_variants->[make_variant,validate_or_raise,substitute],auto_or_any_combination_of->[_a_single_value_or_a_combina... | Checks if this VariantSpec satisfies another. | The docstring is no longer correct for this function. Is it possible that this could be `NotImplemented` and this definition could be pushed down to `MultiValuedVariant`? Actually it looks like that's how it was initially and then that definition was pulled up to here - why? Is there another subclass of variant which b... |
@@ -193,7 +193,7 @@ public class TestTopNRowNumberOperator
public void testMemoryReservationYield()
{
Type type = BIGINT;
- List<Page> input = createPagesWithDistinctHashKeys(type, 6_000, 600);
+ List<Page> input = createPagesWithDistinctHashKeys(type, 1_000, 500);
OperatorFa... | [TestTopNRowNumberOperator->[testPartitioned->[rowPagesBuilder,assertOperatorEquals,of,build,TopNRowNumberOperatorFactory,empty,PlanNodeId,asList],testMemoryReservationYield->[getYieldCount,finishOperatorWithYieldingGroupByHash,getChannelCount,of,getMaxReservedBytes,TopNRowNumberOperatorFactory,createPagesWithDistinctH... | This test method is used to test memory reservation with yield. | Should this decrease `1_000_000` later in the test body:? |
@@ -419,11 +419,12 @@ Js::CharClassifier::CharClassifier(ScriptContext * scriptContext)
}
#endif
-#if ENABLE_UNICODE_API
// If we're in ES6 mode, and we have full support for Unicode character classification
// from an external library, then use the ES6/Surrogate pair supported versions of the functio... | [No CFG could be retrieved] | This function is called by the JS code base class when a character is identified by a sequence - > Void methods. | Curious, why did you chose to use the ES6 functions instead of the default functions if ENABLE_UNICODE_API is not enabled? |
@@ -94,13 +94,13 @@ int slave_core_init(struct sof *sof)
if (err < 0)
panic(SOF_IPC_PANIC_ARCH);
- trace_point(TRACE_BOOT_SYS_NOTE);
+ trace_point(TRACE_BOOT_SYS_NOTIFIER);
init_system_notify(sof);
/* interrupts need to be initialized before any usage */
platform_interrupt_init();
- trace_point(TRACE_B... | [slave_core_init->[arch_init,init_system_notify,trace_point,panic,platform_interrupt_init,idc_init,do_task_slave_core,scheduler_init],void->[cpu_write_threadptr,arch_cpu_get_id],arch_init->[initialize_pointers_per_core,register_exceptions,arch_assign_tasks]] | This function is called from slave_core_init. It is called from slave_core. | Also, please specify in this commit that we are actually also renumbering the tracepoints in order to make place for new tracepoints. |
@@ -59,12 +59,4 @@ SecureHeaders::Configuration.default do |config|
# }
end
-SecureHeaders::Configuration.override(:saml) do |config|
- provider_attributes = SERVICE_PROVIDERS.values
-
- acs_urls = provider_attributes.map { |hash| hash['acs_url'] }.compact
-
- whitelisted_domains = acs_urls.map { |url| url.spl... | [x_frame_options,override,split,to_i,compact,x_content_type_options,x_permitted_cross_domain_policies,merge,csp,default,map,x_xss_protection,production?,each,hsts,values,cookies,x_download_options] | Adds the form action to the SAML response for the . | Doesn't this mean `SecureHeadersWhitelister` will run twice if `FeatureManagement.use_dashboard_service_providers?` returns true since `ServiceProviderUpdater` also calls `SecureHeadersWhitelister.new.run`? |
@@ -1772,14 +1772,14 @@ func TestCanceledRefresh(t *testing.T) {
deploytest.NewProviderLoader("pkgA", semver.MustParse("1.0.0"), func() (plugin.Provider, error) {
return &deploytest.Provider{
ReadF: func(urn resource.URN, id resource.ID,
- state resource.PropertyMap) (resource.PropertyMap, resource.Stat... | [NewProviderURN->[NewURN],GetTarget->[getNames],Run->[GetProject,Run,GetTarget],RunWithContext->[Snap],NewURN->[NewURN,getNames],GetProject->[getNames],NewProviderURN,GetTarget,Run,RunWithContext,NewURN,SuccessfulSteps,Snap,GetProject] | requires that the old resources are updated. This is a helper function that checks that all entries in the journal are updated and that the. | same, re: inputs being passed along |
@@ -174,14 +174,14 @@ class ExtrasCandidate(LinkCandidate):
)
deps = [
- self.base._make_install_req(str(r))
+ factory.make_install_req(str(r), self.base._ireq)
for r in self.base.dist.requires(valid_extras)
]
# Add a dependency on the exact b... | [LinkCandidate->[__ne__->[__eq__],__init__->[make_install_req_from_link]]] | Returns a list of dependencies of the candidate. | Also here - make the requirement in one step... |
@@ -200,6 +200,7 @@ func (oc *ovsController) SetupOVS(clusterNetworkCIDR []string, serviceNetworkCID
otx.AddFlow("table=90, priority=0, actions=drop")
// Table 100: egress routing; edited by SetNamespaceEgress*()
+ otx.AddFlow("table=100, priority=300,udp,udp_dst=%d,actions=drop", vxlanPort)
otx.AddFlow("table=... | [UpdatePod->[cleanupPodFlows,getPodDetailsBySandboxID,setupPodFlows],AddHostSubnetRules->[NewTransaction],SetPodBandwidth->[getInterfacesForSandbox,ClearPodBandwidth],AddServiceRules->[NewTransaction],UpdateEgressNetworkPolicyRules->[NewTransaction],DeleteHostSubnetRules->[NewTransaction],DeleteServiceRules->[NewTransa... | SetupOVS setup OVS Network network flow for NX - M Table 0 - > VXLAN ingress filtering ; filled in by AddHostSubnetRules Add flow to the network network table for all cluster network Table 40 - filled in by AddHostSubnetRules Table 8 - > Flow mapping of network related rules to the corresponding corresponding table - >... | Just the vxlan port decides that the packet is vxlan? |
@@ -197,6 +197,7 @@ func TestWatchPrefix(t *testing.T) {
}
require.NoError(t, err)
}
+ fmt.Println("Generator finished in", time.Since(start))
}
go gen(prefix)
| [Close,CAS,WatchKey,Atoi,Strings,Itoa,Errorf,Run,After,NewInMemoryClient,factory,EqualValues,Equal,NoError,Get,Err,WatchPrefix,Sprintf,Background,WithCancel,List,Fatal,Sleep,Mock] | TestWatchPrefix tests if a given prefix of a given type has observed values. TestList checks that all the keys in observedKeys are reported once. | If you need to keep these `fmt.Println()`, what do you think about `t.Log()` instead? Otherwise I would drop them. |
@@ -43,11 +43,7 @@ class Relion(CMakePackage, CudaPackage):
depends_on('fltk', when='+gui')
depends_on('libtiff')
- # relion 3 supports cuda 9
- # relion < 3 does not
depends_on('cuda', when='+cuda')
- depends_on('cuda@9:', when='@3: +cuda')
- depends_on('cuda@8.0:8.99', when='@:2 +cuda')
... | [Relion->[cmake_args->[ValueError],variant,depends_on,version]] | Return the list of arguments for the C - MKE command. | You say you remove the old versions because they are unstable, but what if someone only has CUDA 8 installed on their cluster? Will the latest version only work with CUDA 9+? |
@@ -110,10 +110,10 @@ namespace System.Drawing.Internal
}
}
- if (elements != null)
+ if (offset != default)
{
// elements (XFORM) = [eM11, eM12, eM21, eM22, eDx, eDy], eDx/eDy specify the translation offset.
- wg.DeviceC... | [WindowsGraphics->[ReleaseHdc->[Dispose],Dispose->[Dispose]]] | Creates a WindowsGraphics object from a graphics object. necessary because the device context is not a translation. | What happens if the offset was retrieved and actually equals default, i.e. 0/0. Presumably that doesn't matter since TranslateTransform(0, 0) would be a nop? |
@@ -31,8 +31,6 @@ def AssembleTestSuites():
# smallSuite will contain the following tests:
# - testSmallExample
smallSuite = suites['small']
- smallSuite.addTest(PotentialFlowTests('test_SmallLiftJumpTest'))
- smallSuite.addTest(PotentialFlowTests('test_LiftAndMoment'))
smallSuite.addTest(Pote... | [AssembleTestSuites->[PotentialFlowTests,addTest,addTests],AssembleTestSuites,PrintInfo,runTests,run] | Assemble a test suite with the specified test cases. | Are you checking everything in one test now? We could then rename it to "test_Naca0012Small", right? |
@@ -72,9 +72,9 @@ class RecognizeIdDocumentsSampleAsync(object):
address = id_document.fields.get("Address")
if address:
print("Address: {} has confidence: {}".format(address.value, address.confidence))
- country = id_document.fields.get("Country")
+... | [main->[recognize_identity_documents,RecognizeIdDocumentsSampleAsync],main] | This method is used to recognize identity documents. \ [ START recognize_identity_documents ]. | Do we need to add a slash here? Or join the words like the field name? |
@@ -697,10 +697,12 @@ namespace System.Windows.Forms
LB_SETSEL = 0x0185,
LB_SETCURSEL = 0x0186,
LB_GETSEL = 0x0187,
+ LB_SETCARETINDEX = 0x019E,
LB_GETCARETINDEX = 0x019F,
LB_GETCURSEL = 0x0188,
LB_GETTEXT = 0x0189,
LB_GETTEXTLEN = 0x018A,
+ L... | [NativeMethods->[SYSTEMTIME->[ToString->[ToString]],Util->[LOWORD->[LOWORD],SignedHIWORD->[SignedHIWORD],HIWORD->[HIWORD],SignedLOWORD->[SignedLOWORD],GetEmbeddedNullStringLengthAnsi->[GetEmbeddedNullStringLengthAnsi]],VARIANT->[ToObject->[ToString,ToObject],Clear],DeleteObject->[IntDeleteObject],LVGROUP->[ToString->[T... | Keyevents for the STG library are defined as 0x0001 - 0x0002 - ECMA - 262 12. 2. 2. 2. | I can't find where these are referenced.... :( |
@@ -201,12 +201,17 @@ update_read_timestamps(struct vos_ts_set *ts_set, daos_epoch_t epoch,
entry->te_ts_rl = MAX(entry->te_ts_rl, epoch);
return;
}
+ if (entry->te_punch_propagated)
+ entry->te_ts_rl = MAX(entry->te_ts_rl, epoch);
entry = vos_ts_set_get_entry_type(ts_set, VOS_TS_TYPE_DKEY, 0);
entry->te_t... | [int->[dbtree_iter_empty,dbtree_iter_probe,ci_set_null,vos_ilog_check,evt_iter_delete,recx_get_flags,key_iter_match,vos_cont2hdl,vos_oi_punch,vos_ilog_punch,evt_iter_empty,D_ERROR,dbtree_iter_fetch,evt_extent_width,key_iter_fetch_helper,singv_iter_probe_epr,recx_iter_fini,vos_obj_release,recx_iter_next,key_iter_fetch,e... | read timestamp update VOS_TS_TYPE_AKEY - > VOS_TS_TYPE_. | Do we need to change line 262 to 264 (after applying this PR) too? |
@@ -196,6 +196,9 @@ class SubmissionCollector < ActiveRecord::Base
remove_grouping_from_queue(grouping)
grouping.save
new_submission = Submission.create_by_revision_number(grouping, rev_num)
+ new_submission = apply_penalty_or_add_grace_credits(grouping,
+ ... | [SubmissionCollector->[collect_next_submission->[instance,remove_grouping_from_queue],start_collection_process->[instance],manually_collect_submission->[start_collection_process,remove_grouping_from_queue]]] | This method is called by the child process when it is able to collect a specific from. | Trailing whitespace detected. |
@@ -32,6 +32,8 @@ Rails.application.routes.draw do
as: :voice_otp,
defaults: { format: :xml }
+ post '/api/usps_upload' => 'usps_upload#create'
+
get '/openid_connect/authorize' => 'openid_connect/authorization#index'
get '/openid_connect/logout' => 'openid_connect/logout#index'
| [new,piv_cac_enabled?,redirect,devise_scope,mount,join,put,draw,root,scope,post,require,enable_usps_verification?,enable_identity_verification?,rotation_path_suffix,enable_saml_cert_rotation?,patch,devise_for,match,delete,namespace,get,enable_test_routes] | The routes that can be handled by the OpenID Connect API. A list of all the users that have a login session. | My preference would be to have a `/v1/` in there so we can version endpoints if we need to. Helps us avoid at the api level what we ran into with routes changing between deploys. |
@@ -41,6 +41,11 @@ public interface PriorityLinkedList<T> {
*/
void setIDSupplier(ToLongFunction<T> supplier);
+ /**
+ * Use non zeroed IDs. 0 is reserved for null values and it should return always null.
+ * @param id
+ * @return
+ */
T removeWithID(long id);
/**
| [No CFG could be retrieved] | setIDSupplier - set the supplier to be called when the ID of the object is not. | LinkedList#setIDSupplier(ToLongFunction) needs updated too, it says these values must be positive. |
@@ -0,0 +1,16 @@
+package insecure
+
+import (
+ "github.com/keybase/client/go/libkb"
+ insecureTriplesec "github.com/keybase/go-triplesec-insecure"
+)
+
+func InstallInsecureTriplesec(g *libkb.GlobalContext) {
+ g.NewTriplesec = func(passphrase []byte, salt []byte) (libkb.Triplesec, error) {
+ warner := func() { g.Lo... | [No CFG could be retrieved] | No Summary Found. | you should add // +build !production to this file |
@@ -166,7 +166,7 @@ def plot_epochs_image(epochs, picks=None, sigma=0., vmin=None,
if combine is not None:
ts_args["show_sensors"] = False
- if picks is None:
+ if picks is None or not _is_numeric(picks):
picks = _picks_to_idx(epochs.info, picks)
if group_by is None:
... | [_mouse_click->[plot_epochs_image,_pick_bad_epochs,_plot_window],_toggle_labels->[_plot_vert_lines],_epochs_navigation_onclick->[_draw_epochs_axes],_pick_and_combine->[pair_and_combine->[combine],pair_and_combine,combine],_prepare_epochs_image_axes->[_make_epochs_image_axis_grid],_plot_onkey->[_plot_traces,_plot_update... | Plots a series of event related potentials in an image. Parameters for the plot. Returns a list of figure and units that are shown over a specific block of pick. Get the base key for a . Plot a single in the plot. | This is so that you don't get 300 epochs images if you do `epochs.plot_image(picks=["grad", "mag"])` |
@@ -27,7 +27,8 @@ public class LobbyServerProperties {
/** The port the lobby is listening on. */
@Nonnull private final Integer port;
- @Nullable private final String version;
+ /** URI the http lobby server. */
+ @Nullable private final URI httpServerUri;
@Nullable private final String serverErrorMess... | [LobbyServerProperties->[isServerAvailable->[isEmpty],getServerMessage->[nullToEmpty],getServerErrorMessage->[nullToEmpty]]] | LobbyServerProperties provides a class that represents the server properties of a lobby server. | `The http lobby server URI.` ? |
@@ -47,6 +47,9 @@ public final class EnvironmentOptions
@Option(name = "--debug", description = "open Java debug ports")
public boolean debug;
+ @Option(name = "--hadoop-init-script", description = "Hadoop init script")
+ public String hadoopInitScript = "";
+
public Module toModule()
{
... | [EnvironmentOptions->[toModule->[toInstance],toBoolean->[toLowerCase,IllegalArgumentException,requireNonNull],getOrDefault,firstNonNull,getenv,File,toBoolean]] | Returns a module that injects the environment options. | When I see `copyOf` I expect it to be static factory method taking argument. Alternatively you may rename the method to `getCopy()` or just `copy()` but I prefere static factory. |
@@ -49,8 +49,7 @@ class DefaultMethodInvokingMethodInterceptor implements MethodInterceptor {
private final MethodHandleLookup methodHandleLookup = MethodHandleLookup.getMethodHandleLookup();
- private final Map<Method, MethodHandle> methodHandleCache =
- new ConcurrentReferenceHashMap<>(10, ReferenceType.WEAK)... | [DefaultMethodInvokingMethodInterceptor->[getMethodHandleLookup->[isAvailable],lookup->[lookup],getLookup->[invoke,lookup]]] | This method is called by the proxy to invoke the method. | Why? It's now 121 chars. |
@@ -11,6 +11,8 @@ namespace Content.Client.GameObjects.Components.Construction
[RegisterComponent]
public class ConstructionGhostComponent : Component, IExamine
{
+ [Dependency] private readonly IPrototypeManager _prototypeManager = default!;
+
public override string Name => "Construction... | [ConstructionGhostComponent->[Examine->[AddText,DoExamine,Name,GetString]]] | Examines a construction GhostComponent. | Doesn't this need IoCManager.InjectDependencies(this); ? |
@@ -272,7 +272,7 @@ public class RedisQueueMessageDrivenEndpoint extends MessageProducerSupport impl
protected void doStop() {
try {
this.active = false;
- this.lifecycleCondition.await(Math.min(this.stopTimeout, this.receiveTimeout), TimeUnit.MICROSECONDS);
+ this.lifecycleCondition.await(Math.min(this.st... | [RedisQueueMessageDrivenEndpoint->[onInit->[onInit],setErrorChannel->[setErrorChannel],ListenerTask->[run->[popMessageAndSend,restart]]]] | Stop the endpoint. | `max` ? This could be bad if there are a lot of these endpoints. I wonder if we should really be blocking here; `SmartLifecycle` has stop with callback. |
@@ -41,6 +41,12 @@ export function adsense(global, data) {
if (data['adHost']) {
i.setAttribute('data-ad-host', data['adHost']);
}
+ if (data['adtest']) {
+ i.setAttribute('data-adtest', data['adtest']);
+ }
+ if (data['tagOrigin']) {
+ i.setAttribute('data-tag-origin', data['tagOrigin']);
+ }
i... | [No CFG could be retrieved] | missing slot and host. | As these attributes accumulate, would it be worth factoring this away from a bunch of individual 'if' statements and to a foreach over a list of input/output name pairs? |
@@ -27,7 +27,7 @@ class CoreferenceResolver(Model):
<https://www.semanticscholar.org/paper/End-to-end-Neural-Coreference-Resolution-Lee-He/3f2114893dc44eacac951f148fbff142ca200e83>
by Lee et al., 2017.
The basic outline of this model is to get an embedded representation of each span in the
- document.... | [CoreferenceResolver->[forward->[_compute_negative_marginal_log_likelihood,_compute_pairwise_inputs,_generate_antecedents,_prune_and_sort_spans,_compute_span_representations,_compute_antecedent_gold_labels,_compute_antecedent_scores],from_params->[from_params],_compute_span_representations->[_compute_head_attention]]] | The base model for the given . This function is used to score a linear layer. It is used to score the embedded features. | `s/and use/and used/` |
@@ -558,7 +558,7 @@ namespace System.Reflection.Metadata.Ecma335
String(serializedTypeName);
}
- private void String(string value)
+ private void String(string? value)
{
Builder.WriteSerializedString(value);
}
| [SignatureTypeEncoder->[Single->[Single,WriteTypeCode],Int16->[Int16,WriteTypeCode],Double->[Double,WriteTypeCode],Int32->[Int32,WriteTypeCode],GenericTypeParameter->[GenericTypeParameter],PrimitiveType->[Int32,Object,IntPtr,UInt32,Boolean,Single,Int64,UIntPtr,Int16,Byte,UInt64,Double,UInt16,TypedReference,String,Char,... | System type. | Above row 551 `serializedTypeName` is nullable |
@@ -1931,7 +1931,7 @@ def _plot_dipole(ax, data, points, idx, dipole, gridx, gridy, ori, coord_frame,
zdir='y', cmap='gray', zorder=0, alpha=.5)
plt.suptitle('Dipole %s, Time: %.3fs, GOF: %.1f, Amplitude: %.1fnAm\n' % (
- idx, dipole.times[idx], dipole.gof[idx], dipole.amplitude[idx] * 1e... | [_plot_mpl_stc->[_handle_time,_limits_to_control_points,_smooth_plot],plot_source_estimates->[_plot_mpl_stc,_limits_to_control_points,_handle_time],_sensor_shape->[_make_tris_fan],_dipole_changed->[_plot_dipole],plot_trans->[_fiducial_coords,_create_mesh_surf]] | Plot dipoles. Plots a hole on the specified axis. | we could alternatively write idx or index in the title. |
@@ -260,9 +260,15 @@ EOT
$io->write(' ' . str_pad($package->getFullPrettyVersion(), $versionLength, ' '), false);
}
+ if ($writeLatest) {
+ $latestVersion = $this->findBestVersionForPackage($package->getName());
+ ... | [ShowCommand->[displayTree->[displayTree,getPackage]]] | Executes the command. Show a single package or a single version of a package. Display packages packages packages packages packages packages installed packages and repositories. Writes the packages and packages in order to the console. | This line is too long, and (not your fault), there is a magic number. Why `4`? Should it be `strlen(' ...')`? |
@@ -875,12 +875,12 @@ func buildServerTimeouts(globalConfig configuration.GlobalConfiguration) (readTi
return readTimeout, writeTimeout, idleTimeout
}
-func (s *Server) buildEntryPoints(globalConfiguration configuration.GlobalConfiguration) map[string]*serverEntryPoint {
+func (s *Server) buildEntryPoints() map[st... | [Stop->[Wait],stopLeadership->[Stop],throttleProviderConfigReload->[Close],buildInternalRouter->[addACMERoutes,addInternalRoutes,addInternalPublicRoutes],prepareServer->[createTLSConfig],StartWithContext->[Start],createTLSConfig->[SetOnDemandListener],Close->[Stop,Close],loadConfig->[loadHTTPSConfiguration,getRoundTrip... | buildEntryPoints builds a map of serverEntryPoints from the given globalConfiguration. | I think that you could directly use `s.buildDefaultHTTPRouter()` in the `middlewares.NewHandlerSwitcher` function instead of creating a variable. |
@@ -159,6 +159,8 @@ namespace Tpetra {
(out_.is_null (), std::logic_error, "Tpetra::Distributor::init: debug_ "
"is true but out_ (pointer to the output stream) is NULL. Please "
"report this bug to the Tpetra developers.");
+ }
+ if (verbose) {
Teuchos::OSTab tab (out_);
... | [doReverseWaits->[is_null,doWaits],createReverseDistributor->[begin,getRank,end],doWaits->[waitAll,requests_,size,resize,end,str,getRank,begin,TEUCHOS_TEST_FOR_EXCEPTION,is_null],getReverse->[createReverseDistributor,is_null,TEUCHOS_TEST_FOR_EXCEPTION]] | Initializes a single node of type which is either a FancyOStream or a Parameter. | Line 158: `if (debug_)` needs to read `if (verbose)`. Ditto for the error message. The issue is that the error messages need to print based on `verbose`. |
@@ -322,7 +322,7 @@ if (empty($reshook))
}
if ($search_status=='') $search_status=1; // always display active thirdparty first
-
+if ($search_type_thirdparty=='') $search_type_thirdparty='0'; // use unknown if the thirdparty type is not set
/*
| [fetch,selectMassAction,select_country,fetch_object,jdate,selectProspectCustomerType,order,select_salesrepresentatives,getNomUrl,getLibProspLevel,selectarray,initHooks,typent_array,effectif_array,load,plimit,transnoentities,executeHooks,loadCacheOfProspStatus,loadLangs,update,select_categories,escape,showCheckAddButton... | Load user object from DB Get all the objects. | I don't understand : if $search_type_thirdparty is '', then later nothing will be added as search criteria. So it does what we want to. |
@@ -479,6 +479,10 @@ class Solver
}
}
+ if (!isset($literal)) {
+ throw new \InvalidArgumentException("Solver: \$literal is not defined. Please report at https://github.com/composer/composer/issues/new.");
+ }
+
un... | [Solver->[analyzeUnsolvableRule->[analyzeUnsolvableRule],solve->[makeAssertionRuleDecisions,checkForRootRequireProblems,setupInstalledMap],runSat->[propagate,selectAndInstall,analyzeUnsolvable,setPropagateLearn,revert],resetSolver->[makeAssertionRuleDecisions],selectAndInstall->[setPropagateLearn],analyzeUnsolvable->[a... | Analyzes a rule and returns the most likely decision id. Returns an array of learned literals and a new rule. | this looks like a bug in phpstan. A `while (true)` will *always* enter the loop. |
@@ -369,12 +369,14 @@ bool ESP8266WiFiSTAClass::getAutoReconnect() {
* returns the status reached or disconnect if STA is off
* @return wl_status_t
*/
-uint8_t ESP8266WiFiSTAClass::waitForConnectResult() {
+uint8_t ESP8266WiFiSTAClass::waitForConnectResult(uint32_t wait_secs) {
//1 and 3 have STA enabled
... | [begin->[begin],_smartConfigCallback->[stopSmartConfig],hostname->[hostname],beginWPSConfig->[disconnect]] | Wait for a connection with the server to complete. | This line is difficult to read. * `!status()` tests whether the status is non-zero, but status is an enum and it's unobvious which value is zero. * The part after && is really complicated. How about: ``` for (int timeout = wait_secs * 10; wait_secs == 0 || timeout > 0; --timeout) { auto st = status(); switch (st) { cas... |
@@ -194,6 +194,15 @@ public class PutEmail extends AbstractProcessor {
.allowableValues("true", "false")
.defaultValue("false")
.build();
+ public static final PropertyDescriptor CONTENT_AS_MESSAGE = new PropertyDescriptor.Builder()
+ .name("email-ff-content-as-messa... | [PutEmail->[customValidate->[customValidate],send->[send]]] | This class is used to create a PropertyDescriptors that will be evaluated at runtime. Set the SMTP host to use for the SMTP server. | With this, we can set `MESSAGE.required()` can be set to `false`, right? |
@@ -291,6 +291,10 @@ class GlobalOptionsRegistrar(SubsystemClientMixin, Optionable):
help='Path to a PEM file containing CA certificates used for verifying secure '
'connections to --remote-execution-server and --remote-store-server. '
'If not specified, TLS will not ... | [GlobalOptionsRegistrar->[register_options->[register_bootstrap_options]],ExecutionOptions] | Register bootstrap options. Register all plugin requirements. Register options for a specific . Registers options for a single unique identifier. This function is used to configure the native engine and rule graphs. | Would it be worth writing up a very quick README about how to use these options together to hit GCP/RBE? It's not clear whether they are mutually exclusive. |
@@ -224,6 +224,9 @@ public class <%= entityClass %> implements Serializable {
return false;
}
<%= entityClass %> <%= entityInstance %> = (<%= entityClass %>) o;
+ if(<%= entityInstance %>.id == null || id == null) {
+ return false;
+ }
return Objects.equa... | [No CFG could be retrieved] | Set all relationships in this entity. } } ;. | Doesn't it break a contract? Two objects with null IDs should be equal if ID is a part of equals and hashcode. With this implementation it is false. |
@@ -196,4 +196,18 @@ export class BaseSlides extends BaseCarousel {
this.autoplayTimeoutId_ = null;
}
}
+
+ /**
+ * Remove autoplay.
+ * @protected
+ */
+ removeAutoplay() {
+ this.clearAutoplay();
+ this.hasAutoplay_ = false;
+ this.shouldAutoplay_ = this.hasAutoplay_ && this.isLoopingElig... | [No CFG could be retrieved] | This method is called when the autoplay timeout expires. | we should not disable `loop` unless it was forced by autoplay in the first place. If author has `loop` specified, after autoplay ends, user should still manually loop. |
@@ -431,6 +431,6 @@ func (ui *unparsedImage) Manifest() ([]byte, string, error) {
}
// Signatures is like ImageSource.GetSignatures, but the result is cached; it is OK to call this however often you need.
-func (ui *unparsedImage) Signatures() ([][]byte, error) {
+func (ui *unparsedImage) Signatures(context.Context... | [PolicyConfigurationNamespaces->[DockerReferenceNamespaces],Validate->[ParseDockerImageReference,New],StringWithinTransport->[FamiliarString],PolicyConfigurationIdentity->[Sprintf,DockerReferenceIdentity],Run->[Fprintf,Sprintf,Images,Now,NewPRMMatchRepoDigestOrExact,NewPRSignedByKeyPath,Errorf,NewPolicyContext,Destroy,... | Signatures returns the signature of the image. | you going ot use this to pass a timeout or something? |
@@ -47,10 +47,11 @@ except ImportError: # Python <= 3.5
class PipelineContext(dict):
- def __init__(self, transport, **kwargs):
+ def __init__(self, session, transport, **kwargs):
+ self.session = session
self.transport = transport
self.options = kwargs
- self._protected = ['t... | [PipelineContext->[__setitem__->[super,ValueError,format],pop->[super,ValueError,format],update->[TypeError],__delitem__->[super,ValueError,format],clear->[TypeError]],append,ABCMeta] | Initialize PipelineContext with a sequence number. | I cannot find out the reason that we need to expose session to outside of the transport |
@@ -14,7 +14,9 @@ def order_status_change(sender, instance, **kwargs):
order.create_history_entry(
content=pgettext_lazy(
'Order status history entry', 'Order fully paid'))
- instance.send_confirmation_email()
+ email_data = collect_data_for_email(order)
+ ema... | [order_status_change->[report_order,is_fully_paid,pgettext_lazy,create_history_entry,exception,send_confirmation_email],getLogger] | Handle payment status change and set suitable order status. | If `order` is already passed to `collect_data_for_email`, is `email_data.update()` outside of it necessary? |
@@ -50,9 +50,11 @@ public class BasicQueryStats
private final int runningDrivers;
private final int completedDrivers;
- private final DataSize rawInputDataSize;
- private final long rawInputPositions;
private final DataSize physicalInputDataSize;
+ private final long physicalInputPositions;
+
... | [BasicQueryStats->[immediateFailureQueryStats->[BasicQueryStats]]] | Creates a new BasicQueryStats with all of the fields named consistently across all of the. | make this separate commit |
@@ -75,6 +75,7 @@ namespace System.Text.Json.SourceGeneration
private readonly Type _booleanType;
private readonly Type _charType;
+ private readonly Type _timeSpanType;
private readonly Type _dateTimeType;
private readonly Type _nullableOfTType;
... | [JsonSourceGenerator->[Parser->[PropertyIsOverridenAndIgnored->[Type],GetSerializerOptions->[GetJsonSourceGenerationModeEnumVal],PopulateKnownTypes->[PopulateNumberTypes]]]] | private class DictionaryType = ( Required for validation. | nit: this should be nullable since the type is not included in the `SpecialType` enum. |
@@ -0,0 +1,8 @@
+# ------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for
+# license information.
+# -----------------------------------------------------------------... | [No CFG could be retrieved] | No Summary Found. | the _shared folder is shared between all service SDKs, like SMS SDK has the same folder and same files/methods. Which means adding one method/module to this folder, other teams must do the same. So I suggest: 1. Talk to Tural to ask if above is the same case, if yes, ask if this will become a common method that other t... |
@@ -51,7 +51,7 @@ function wpcom_load_event( $access_token_source ) {
if ( defined( 'IS_WPCOM' ) && IS_WPCOM ) {
jetpack_require_lib( 'tracks/client' );
tracks_record_event( wp_get_current_user(), $event_name );
- } elseif ( jetpack_is_atomic_site() && Jetpack::is_active() ) {
+ } elseif ( jetpack_is_atomic_sit... | [wpcom_load_event->[record_user_event],render_single_block_page->[item,saveHTML,do_items,loadHTML]] | This function is used to record a key load event for wpcom. | I'm not sure about this one. Are we only tracking when the user is present? If the idea is to track visits by other users, we can't use this. I would go on the safe side here and use `is_connection_ready` |
@@ -3,6 +3,7 @@ package api
import (
"net/http"
+ "github.com/pingcap/pd/v4/server"
"github.com/unrolled/render"
)
| [ServeHTTP->[JSON]] | api import imports a single render. Render object from the given object. | v4 should be changed |
@@ -56,6 +56,8 @@ class Hypre(Package):
variant('openmp', default=False, description='Enable OpenMP support')
variant('debug', default=False,
description='Build debug instead of optimized version')
+ variant('blas', default=True, description='Use external BLAS library')
+ variant('lapack', ... | [Hypre->[install->[join_path,append,working_dir,Executable,sstruct,join,configure,make],url_for_version->[Version,format],headers->[find_headers],libs->[find_libraries],depends_on,conflicts,version,patch,variant]] | Version 2. 12. 1 and later can be patched to build shared libraries on Darwin Patch to build shared libraries on Darwin and not on LAPACK. | If these are disabled, does hypre build with internal copies of blas/lapack? I don't think we want that, as we could end up with different blas/lapack libraries in the DAG. |
@@ -170,9 +170,9 @@ func (s *testBalanceLeaderSchedulerSuite) TestBalanceLimit(c *C) {
c.Check(s.schedule(nil), IsNil)
// Stores: 1 2 3 4
- // Leaders: 10 0 0 0
+ // Leaders: 16 0 0 0
// Region1: L F F F
- s.tc.updateLeaderCount(1, 10)
+ s.tc.updateLeaderCount(1, 1... | [TestLeaderWeight->[schedule],TestBalanceLimit->[schedule],TestBalanceFilter->[schedule],TestScheduleWithOpInfluence->[schedule],TestBalanceSelector->[schedule]] | TestBalanceLimit tests the limit of the leader store. | Why change to 16? |
@@ -1885,8 +1885,8 @@ namespace DotNetNuke.Entities.Users
//Log event
EventLogController.Instance.AddLog("Username", user.Username, portalSettings, user.UserID, EventLogController.EventLogType.USER_RESTORED);
- DataCache.ClearPortalCache(portalId, false);
- ... | [UserController->[IsMemberOfPortalGroup->[IsMemberOfPortalGroup],ApproveUser->[AutoAssignUsersToRoles],UpdateDisplayNames->[GetEffectivePortalId],UnLockUser->[UnLockUser,GetEffectivePortalId],GetPassword->[GetPassword],UserInfo->[CheckInsecurePassword,FixMemberPortalId,GetEffectivePortalId,GetUserLookupDictionary,AddEv... | Restore a user from the system. | I don't understand. Why is this diff not showing changes from #2274 on the left? |
@@ -1003,6 +1003,17 @@ $config['os'][$os]['over'][1]['text'] = 'Current';
$config['os'][$os]['over'][2]['graph'] = 'device_frequency';
$config['os'][$os]['over'][2]['text'] = 'Frequencies';
+$os = 'eatonups';
+$config['os'][$os]['text'] = 'Eaton UPS';
+$config['os'][$os]['type'] = 'power';... | [addServer] | Config for a single node. UI - specific configuration for a single node. | Should probably be eatonups as the new icon uploaded? |
@@ -53,9 +53,9 @@ class Terms_Of_Service {
* Returns whether the master user has agreed to the terms of service.
*
* The following conditions have to be met in order to agree to the terms of service.
- * 1. The master user has gone though the connect flow.
+ * 1. The master user has gone though the connect f... | [Terms_Of_Service->[is_offline_mode->[is_offline_mode],is_active->[is_active]]] | Has this user agreed?. | This part is not deprecated, it means that the user has started the flow and went down the funnel towards the connection. In this case we mean that we're checking whether the local option is set to `true`. |
@@ -287,11 +287,6 @@ func (h *FileClientHandler) HasAlias(name string) (bool, error) {
// avail: indicates whether version supports ILM
// probe: in case version potentially supports ILM, check the combination of mode + version
// to indicate whether or not ILM support should be enabled or disabled
-func checkILMVer... | [CheckILMEnabled->[GetVersion,String,checkILMSupport],HasAlias->[Request],CreateILMPolicy->[Write,Join,Request,Sprintf,StringToPrint,Errorf],CreateAlias->[HasAlias,Sprintf,Request,PathEscape],queryFeatures->[Request,Unmarshal],HasILMPolicy->[Request,Join],checkILMSupport->[queryFeatures],LessThan,MustNewVersion] | checkILMVersion returns whether or not the version of the ILM supports ILM. | Just checked in the code what `esMinILMVersion` and it is 6.6.0, so we will also be able to get rid of this code |
@@ -37,6 +37,9 @@ const COOKIE_EXPIRATION_INTERVAL = COOKIE_MAX_AGE_DAYS * 24 * 60 * 60 * 1000;
/** @type {Object<string, boolean>} */
let toggles_ = null;
+/** @type {!Promise} */
+const originTrialsPromise = enableExperimentsForOriginTrials(self);
+
/**
* @typedef {{
* isTrafficEligible: !function(!Window)... | [No CFG could be retrieved] | Provides a function to test if a specific object is in canary. Checks if the experiment is on or off. | We should avoid competing with startup tasks. The non-startup flavor of `chunk` may be a good fit here. How long does it take to verify a single token? That should decide the granularity of the chunk. |
@@ -106,7 +106,13 @@ func editFile(ctx *context.Context, isNewFile bool) {
ctx.NotFound("blob.Data", err)
return
}
- defer dataRc.Close()
+ closed := false
+
+ defer func() {
+ if !closed {
+ dataRc.Close()
+ }
+ }()
ctx.Data["FileSize"] = blob.Size()
ctx.Data["FileName"] = blob.Name()
| [IsErrRepoFileDoesNotExist,Dir,Size,Status,IsErrLFSFileLocked,Verify,SubTree,NotFoundOrServerError,Close,DeleteRepoFile,PathEscapeSegments,Redirect,IsErrPushOutOfDate,CanCommitToBranch,RenderWithErr,GetDefinitionForFilename,IsErrPushRejected,PlainText,GetBranchCommit,HTML,GetTreeEntryByPath,Error,UnitEnabled,Clean,List... | cleanUploadFileName - clean upload file name and redirect to _new or _edit redirect to v - Get unique patch branch name. | It's unnecessary to check this because `Close` could be invoked many times, just add a line in 131 is OK. This of course is no problem, but the code is a little ugly and not readable. You could find many simliar codes on golang standard liberary. |
@@ -11,6 +11,10 @@ module View
BACKGROUND_COLOR = '#FFFFFF'
BACKGROUND_OPACITY = '0.5'
+ def edge_at_bottom?(edge = nil)
+ edge&.zero? || edge == 5 || edge == 5.5
+ end
+
def preferred_render_locations
return [l_center, l_up24, l_down24] if @tile.offboards.... | [LocationName->[load_from_tile->[location_name,name_segments],name_segments->[join,split,size,map],l_top->[size],l_bottom->[size],preferred_render_locations->[empty?,size,one?,slots,any?],delta_y->[size],render_part->[h,with_index],render_background_box->[h],box_dimensions->[max,size]],require] | Returns an array of possible possible render locations for a . | how about edge.to_i == 5 |
@@ -104,6 +104,8 @@ def jit(func_or_sig=None, device=False, inline=False, link=[], debug=None,
debug=debug)
if device:
+ msg = ("Eager compilation of device functions is deprecated")
+ warn(NumbaDeprecationWarning(msg))
return device_jit
... | [declare_device->[declare_device_function,normalize_signature],jit->[device_jit->[compile_device],kernel_jit->[copy,Dispatcher],jitwrapper->[FakeCUDAKernel],autojitwrapper->[jit,FakeCUDAKernel],TypeError,is_signature,normalize_signature,NotImplementedError,Dispatcher,FakeCUDAKernel,get,copy,format,jitdevice,Deprecation... | JIT compile a python function conforming to the CUDA Python specification. Decorator to create a function that returns a object. A wrapper for functions that return a object. | Should this message also remind users that the eagerness is due to signature(s) being provided? |
@@ -645,7 +645,7 @@ func (pkg *pkgContext) genInputTypes(w io.Writer, t *schema.ObjectType, details
}
fmt.Fprintf(w, "}\n\n")
- genInputMethods(w, name, name+"Args", name, details.ptrElement)
+ genInputMethods(w, name, name+"Args", name, details.ptrElement, false)
// Generate the pointer input.
if details.p... | [genResource->[getConstValue,plainType,outputType,getDefaultValue,inputType],tokenToEnum->[tokenToPackage],genType->[genInputTypes,genOutputTypes,genPlainType,detailsForType,tokenToType],plainType->[tokenToType,tokenToResource,plainType],genFunction->[genPlainType],outputType->[tokenToType,tokenToResource,outputType],g... | genInputTypes generates the input types for the given object type. if details. mapElement is true generate input interface and input methods. | Should the `resourceType` parameter be `true` here? I think that `genInputTypes` is called for non-resource types as well. |
@@ -981,7 +981,7 @@ func (a *apiServer) pipelineManager(ctx context.Context, pipelineInfo *pps.Pipel
}
// Start worker pool
- a.workerPool(ctx, PipelineRcName(pipelineInfo.Pipeline.Name, pipelineInfo.Version))
+ a.workerPool(ctx, PipelineRcName(pipelineInfo.Pipeline.Name, pipelineInfo.Version), RetriesPerDatu... | [AddShard->[pipelineWatcher,jobWatcher],jobManager->[updateJobState,InspectJob],CreatePipeline->[validatePipeline],pipelineWatcher->[setPipelineCancel,deletePipelineCancel],pipelineManager->[CreateJob],jobWatcher->[setJobCancel,deleteJobCancel],DeleteAll->[DeletePipeline,DeleteJob,ListJob,ListPipeline],CreateJob->[vali... | pipelineManager creates a k8s replication controller and worker pool for the given pipeline This function is used to create a JobInput for a single input and a single output commit create a new job with the given inputs and run it. | It seems strange that we pass this constant into every invocation of `workerPool`. Could `newWorkerPool` simply use this constant itself? |
@@ -15,14 +15,13 @@ namespace System.Text.Json.SourceGeneration
/// Generates source code to optimize serialization and deserialization with JsonSerializer.
/// </summary>
[Generator]
- public sealed class JsonSourceGenerator : ISourceGenerator
+ public sealed partial class JsonSourceGenerator : IS... | [JsonSourceGenerator->[Initialize->[RegisterForSyntaxNotifications],Execute->[RegisterRootSerializableType,ConvertedType,NullableOfTType,GenerateSerializationMetadata,SyntaxReceiver,SyntaxTree,First,ContainingType,ElementAtOrDefault,Namespace,Compilation,ValueText,Default,Where,CompilationUnits,Symbol,Single,Resolve,Ge... | Creates a class which generates JSON code for a single object type. | This is a property, but it calls a Linq method, which will create a new Dictionary every time. This can be a perf trap, since properties should have field-access like performance. |
@@ -781,6 +781,7 @@ $config['poller_modules']['cisco-asa-firewall'] = false;
$config['poller_modules']['cisco-voice'] = false;
$config['poller_modules']['cisco-cbqos'] = false;
$config['poller_modules']['cisco-otv'] = false;
+$config['poller_modules']['cisco... | [No CFG could be retrieved] | Config for all NI - NI - NI - NI - NI - This function is used to configure the configuration of the . | I think this should just be `nac` as I'm sure cisco won't be the only ones to implement network access control support. |
@@ -62,11 +62,10 @@ class FileEntriesSerializer(FileSerializer):
filename = serializers.SerializerMethodField()
class Meta:
- fields = FileSerializer.Meta.fields + (
- 'content', 'entries', 'selected_file', 'download_url',
- 'uses_unknown_minified_code', 'mimetype', 'sha256', 's... | [DraftCommentSerializer->[validate->[get_or_default],AddonBrowseVersionSerializer,CannedResponseSerializer],AddonBrowseVersionSerializer->[FileEntriesSerializer],FileEntriesSerializer->[_get_entries->[_get_hash_for_selected_file],get_content->[_get_blob_for_selected_file],_get_hash_for_selected_file->[_get_blob_for_sel... | Returns the AddonGitRepository object for this addon. | so, maybe `FileEntriesSerializer` shouldn't inherit from `FileSerializer` any longer if it's not using any of it's fields or methods? |
@@ -182,8 +182,11 @@ export class Bind {
Object.keys(parseErrors).forEach(expressionString => {
const elements = this.expressionToElements_[expressionString];
if (elements.length > 0) {
- const err = user().createError(parseErrors[expressionString]);
- reportError(err, element... | [No CFG could be retrieved] | Initializes the bindings and creates the expression evaluator. Reads the given body and returns a tuple containing the bound elements and bindings. | Nit: You can pass `parseError.message` directly into `#createError`, and set `#stack` on the returned error. |
@@ -651,12 +651,9 @@ public class DeckOptions extends AppCompatPreferenceActivity implements OnShared
finish();
return;
}
- Bundle extras = getIntent().getExtras();
- if (extras != null && extras.containsKey("did")) {
- mDeck = mCol.getDecks().get(extras.getLo... | [DeckOptions->[onPreferenceTreeClick->[onPreferenceTreeClick],updateSummaries->[contains,getString],ConfChangeHandler->[actualOnPostExecute->[cacheValues],actualOnPreExecute->[getDeckOptions,getString]],getSubdeckCount->[getLong],onDestroy->[onDestroy],onCreate->[getLong,contains,registerOnSharedPreferenceChangeListene... | This method is called when the activity is created. | I added a "deepClone" into DeckConfig, so you can use it directly. `toString` is relatively quick, but parsing from string is slow, it should be avoided |
@@ -182,11 +182,10 @@ public class SqlAnalyzer {
return resolvedStatement;
}
- static AnalyzerOptions initAnalyzerOptions() {
+ static AnalyzerOptions baseAnalyzerOptions() {
AnalyzerOptions options = new AnalyzerOptions();
options.setErrorMessageMode(ErrorMessageMode.ERROR_MESSAGE_MULTI_LINE_WITH... | [SqlAnalyzer->[extractTableNames->[isEndOfInput],Builder->[analyze->[analyze],build->[SqlAnalyzer]],initAnalyzerOptions->[initAnalyzerOptions],analyzeNextStatement->[analyzeNextStatement]]] | Analyze the next statement in the sequence. Returns a set of options that can be used to generate a new feature. | nit: I'd prefer if you didn't rename this method, there are a bunch of references to it inside google. (Alternatively please rename the method of the same name in the C++ validator to match.) |
@@ -49,6 +49,9 @@ public final class LogoutManagerImpl implements LogoutManager {
/** The logger. */
private static final Logger LOGGER = LoggerFactory.getLogger(LogoutManagerImpl.class);
+ /** The parameter name that contains the logout request. */
+ public static final String LOGOUT_PARAMETER_NAME =... | [LogoutManagerImpl->[LogoutHttpMessage->[formatOutputMessageInternal->[formatOutputMessageInternal]]]] | Implementation of the LogoutManager class. The LogoutManagerImpl class. | does this need to be public? |
@@ -460,6 +460,7 @@ class Article < ApplicationRecord
def update_score
self.score = reactions.sum(:points) + Reaction.where(reactable_id: user_id, reactable_type: "User").sum(:points)
update_columns(score: score,
+ privileged_users_reaction_points_sum: reactions.privileged_category.sum(:p... | [Article->[username->[username],update_notifications->[update_notifications],readable_edit_date->[edited?],evaluate_front_matter->[set_tag_list],update_notification_subscriptions->[update_notification_subscriptions]]] | Update the score of the record based on the number of points in the user s reactions. | Wondering about a guard clause to not do this if the column doesn't exist. |
@@ -112,6 +112,7 @@ namespace Kratos
integration_weight *= dArea;
direction = g3 / dArea;
+ //KRATOS_WATCH(direction)
}
else if (SURFACE_DEAD == 1)
{
| [No CFG could be retrieved] | Calculate the local system of the - - - - - - - - - - - - - - - - - -. | why using capitals here? (we normally use capitals only for kratos variables) |
@@ -209,6 +209,10 @@ func TestEgressRouterBad(t *testing.T) {
}
out, err := cmd.CombinedOutput()
out_lines := strings.Split(string(out), "\n")
+
+ if len(out_lines) < 2 {
+ continue
+ }
got := out_lines[len(out_lines)-2]
if err == nil {
t.Fatalf("test %d expected error %q but got output %q", n+1,... | [CombinedOutput,Sprintf,Fatalf,Split,Command] | egress - router. sh. | If we're expecting output in order to test it is likely that this should be erroring the test before continue. |
@@ -1618,6 +1618,12 @@ module.exports = EntityGenerator.extend({
});
}
+ },
+
+ writeEntitiesFiles: function() {
+ var entities = new Set(this.config.get('entities'));
+ entities.add(_s.capitalize(this.name));
+ this.config.set('entities', A... | [No CFG could be retrieved] | The main method of the class that creates the necessary entity configuration. Get all fields that are not owned by the entity. | can we rename this to `updateEntityToConfig` |
@@ -60,6 +60,7 @@ func CorsHandler() func(next http.Handler) http.Handler {
AllowedOrigins: setting.CORSConfig.AllowDomain,
//setting.CORSConfig.AllowSubdomain // FIXME: the cors middleware needs allowSubdomain option
AllowedMethods: setting.CORSConfig.Methods,
+ AllowedHeaders: []string{"*"},
All... | [NewCollector,GitHookService,Auth,AssetsHandler,IsProd,Mailer,RequireRepoReader,ServeFile,RepoRef,Delete,Redirect,GetBranchCommit,Put,RequireRepoReaderOr,Handler,RequireRepoWriterOr,Error,Stat,Seconds,Post,NotFound,Captchaer,Route,Methods,AddBindingRules,ServerError,Any,Join,Mount,Toggle,RequireRepoAdmin,Sessioner,MinS... | corsHandler returns a http. Handler who set CORS options if enabled by config routes is a list of routes that will be used to serve the application s static assets. | Mostly we've just added the correct headers we need so in general I think this is a mistake. |
@@ -165,7 +165,7 @@ func (p *portMapper) forward(action iptables.Action, ip net.IP, port int, proto,
}
return fmt.Errorf("Failed to find unmap data for %s:%d", ipStr, port)
- case iptables.Append:
+ case Map:
var savedArgs [][]string
args := []string{"VIC", "-t", string(iptables.Nat),
| [UnmapPort->[forward,Unlock,Infof,Lock,Errorf],isPortAvailable->[IsUnspecified,Itoa,Dial,JoinHostPort,Close,String],forward->[IsUnspecified,Itoa,Warnf,JoinHostPort,String,Errorf],MapPort->[forward,Unlock,Infof,Lock,Errorf,isPortAvailable],Raw,Errorf] | forward forwards the specified port mapping to the specified ip run iptables checks and saves flags for the next iptables operation. | I am not happy to see such large chunk of logic within Switch/case clause, can it be extracted out? |
@@ -9,6 +9,8 @@
/**
* Helper function to register a Jetpack Gutenberg block
*
+ * @deprecated 7.1.0 Use (Gutenberg's) register_block_type() instead
+ *
* @param string $slug Slug of the block.
* @param array $args Arguments that are passed into register_block_type.
*
| [Jetpack_Gutenberg->[get_availability->[is_registered]]] | Registers a single block type with Jetpack Gutenberg. Returns a list of all available extensions and plugins for a given block name. | Lets also use `_deprecated_function( __FUNCTION__, '7.1', 'register_block_type' ); ` inside the function call so that we throw PHP Notices errors when someone used it. The same should be applied to the other deprecated functions |
@@ -51,7 +51,7 @@ module RepositoryActions
Activities::CreateActivityService
.call(activity_type: type,
owner: @user,
- subject: row,
+ subject: row.repository,
team: @team,
message_items: {
repository_row: row.id
| [ArchiveRowsBaseService->[log_activity->[call],valid?->[succeed?]]] | Logs an activity with a if it exists. | Is the subject repository? |
@@ -134,7 +134,7 @@ public abstract class Actionable extends AbstractModelObject implements ModelObj
*/
@Nonnull
public <T extends Action> List<T> getActions(Class<T> type) {
- List<T> _actions = Util.filter(getActions(), type);
+ List<T> _actions = Util.filter(getPersistedActions(), type)... | [Actionable->[getActions->[getActions,createFor],replaceActions->[addAction,getActions],getDynamic->[getAllActions],removeActions->[getActions],createFor->[createFor],getAction->[getActions,createFor],addOrReplaceAction->[addAction,getActions],getAllActions->[getActions]]] | Get actions of a given type. | I think this should be reverted, so it would still take into account additions from pre-`TransientActionFactory` implementations. |
@@ -461,7 +461,7 @@ class Queue {
return new \WP_Error( 'buffer_not_checked_out', 'There are no checked out buffers' );
}
- if ( $checkout_id != $buffer->id ) {
+ if ( intval( $checkout_id ) !== intval( $buffer->id ) ) {
return new \WP_Error( 'buffer_mismatch', 'The buffer you checked in was not checked ... | [Queue->[validate_checkout->[get_checkout_id],lock->[has_any_items],flush_all->[reset],get_next_data_row_option_name->[generate_option_name_timestamp]]] | Validate that the buffer is checked out. | Do we have a test to verify this change won't break anything? |
@@ -359,7 +359,9 @@ class OrderHistoryEntry(models.Model):
class OrderNote(models.Model):
user = models.ForeignKey(
- settings.AUTH_USER_MODEL, on_delete=models.CASCADE)
+ settings.AUTH_USER_MODEL, blank=True, null=True,
+ verbose_name=pgettext_lazy('Order note field', 'user'),
+ on_... | [DeliveryGroup->[can_ship->[is_shipping_required]],Payment->[get_purchased_items->[get_lines],send_confirmation_email->[get_user_current_email]],Order->[send_confirmation_email->[get_user_current_email],get_subtotal_without_voucher->[get_lines],is_shipping_required->[is_shipping_required]]] | Return a string representation of the object. | We have an issue (#1465) for removing verbose names from models in favor of explicit labels in forms, so we could also remove this `verbose_name`. |
@@ -689,7 +689,13 @@ var modules = map[moduleName]module{
stop: (*Cortex).stopCompactor,
},
+ DataPurger: {
+ deps: []moduleName{Store, Server},
+ init: (*Cortex).initDataPurger,
+ stop: (*Cortex).stopDataPurger,
+ },
+
All: {
- deps: []moduleName{Querier, Ingester, Distributor, TableManager},
+ deps: []m... | [initServer->[Set],MarshalYAML->[String],UnmarshalYAML->[Set]] | stopCompactor - stop compactor. | Can multiple data-purgers run at the same time? (If someone runs multiple single-binary instances of Cortex) |
@@ -931,6 +931,7 @@ public:
sLog->outString("Re-Loading Page Texts...");
sObjectMgr->LoadPageTexts();
handler->SendGlobalGMSysMessage("DB table `page_texts` reloaded.");
+ handler->SendGlobalGMSysMessage("You will need to delete your client cache to see the changes.");
return ... | [reload_commandscript->[bool->[HandleReloadPointsOfInterestCommand,LoadReputationSpilloverTemplate,HandleReloadGameGraveyardZoneCommand,LoadSpellPetAuras,LoadSpellScripts,HandleReloadBroadcastTextCommand,HandleReloadAchievementCriteriaDataCommand,LoadGossipMenuItems,LoadItemSetNameLocales,HandleReloadSkillDiscoveryTemp... | HandleReloadPageTextsCommand - Reload Page Texts and Item Random Enchantments Table. | why not put it on the same line? seems more fitting to me because when u reload all tables, you will have tons of lines |
@@ -3317,7 +3317,7 @@ int tls_choose_sigalg(SSL *s, int fatalerrs)
if (i == sent_sigslen) {
if (!fatalerrs)
return 1;
- SSLfatal(s, SSL_AD_ILLEGAL_PARAMETER,
+ SSLfatal(s, SSL_AD_HANDSHAKE_FAILURE,
... | [No CFG could be retrieved] | check signature type set max fragment length. | This one seems like a good change; we are doing a negotiation, just using the protocol default for the peer's offer, and found no overlap. That's a handshake failure, not an illegal parameter. |
@@ -250,14 +250,16 @@ class InstallRequirement(object):
if req is not None:
try:
req = Requirement(req)
- except InvalidRequirement:
+ except InvalidRequirement as e:
if os.path.sep in req:
add_msg = "It looks like a path... | [parse_editable->[_strip_postfix,_strip_extras],InstallRequirement->[from_path->[from_path],from_line->[_strip_extras],get_dist->[egg_info_path],install->[prepend_root],_correct_build_location->[build_location],move_wheel_files->[move_wheel_files],run_egg_info->[_correct_build_location],archive->[pkg_info],pkg_info->[e... | Creates an InstallRequirement object from a line of setup. py or setup. py. txt A WheelFilenameMissingException is raised if the filename is not a valid WheelFilename. | This `replace()` seems brittle and hacky to me, but I'll let others weigh in. The `packaging` project probably shouldn't be including this string to begin with since it's redundant with the exception class being `InvalidRequirement`. |
@@ -23,6 +23,7 @@ module View
needs :reservation, default: nil
needs :game, default: nil, store: true
needs :city_render_location, default: nil
+ needs :player_colors, default: nil
RESERVATION_FONT_SIZE = {
1 => 22,
| [CitySlot->[render_part->[h,on_click],on_click->[available_tokens,actions,empty?,cheater,new,size,is_a?,active_step,stopPropagation,include?,type,hex,process_action,store,coordinates,current_entity,can_replace_token?],reservation->[h,size,corporation?,coordinates,id],needs,freeze,include],require] | Creates a component with a base class for a space in a city. Displays a link to the neccessary company. | why don't you just make this a store, then you don't have to pass it down everywhere it's unnneded? |
@@ -343,7 +343,7 @@ func (i SomeOtherObjectArgsArrayArray) ToSomeOtherObjectArgsArrayArrayOutputWith
type SomeOtherObjectArgsArrayArrayOutput struct{ *pulumi.OutputState }
func (SomeOtherObjectArgsArrayArrayOutput) ElementType() reflect.Type {
- return reflect.TypeOf((*SomeOtherObjectArgsArray)(nil)).Elem()
+ retur... | [Others->[ApplyT],ToSomeOtherObjectArgsArrayArrayOutput->[ToSomeOtherObjectArgsArrayArrayOutputWithContext,Background],Index->[ApplyT,All],ElementType->[Elem,TypeOf],ToObjectOutputWithContext->[ToOutputWithContext],Foo->[ApplyT],ToSomeOtherObjectArgsArrayArrayOutputWithContext->[ToOutputWithContext],Baz->[ApplyT],ToOth... | ElementType returns the type of the SomeOtherObjectArgsArrayArrayOutput as a reflect. Type. | This (and other nested container types) look like were just plain wrong, thanks for catching this. |
@@ -376,7 +376,7 @@ public class SubscriptionsResource implements TimeoutTask.Callback {
if (subscriptionExists(subscriptionId)) {
QueueConsumer tmp = null;
try {
- tmp = createConsumer(true, autoAck, subscriptionId, null, consumerTimeoutSeconds * 1000, false);
+ tmp = c... | [SubscriptionsResource->[internalDeleteSubscription->[shutdown],shutdown->[shutdown],stop->[shutdown],recreateTopicConsumer->[shutdown,subscriptionExists,createConsumer],createSubscription->[generateSubscriptionName]]] | Recreates a topic consumer for the given subscription. | I thought the compiler would solve this by converting it to long. The outcome is a long. |
@@ -57,11 +57,13 @@ func newTestKafkaClient(t *testing.T, topic string) *client {
func newTestKafkaOutput(t *testing.T, topic string, useType bool) outputs.Outputer {
+ if useType {
+ topic = "%{[type]}"
+ }
config := map[string]interface{}{
- "hosts": []string{getTestKafkaHost()},
- "timeout": "1s",
- "... | [NewConfigFrom,Now,Close,Itoa,Int,New,Short,Nanosecond,Len,Skip,After,Logf,Debug,Time,ConsumePartition,Contains,Messages,LogInit,NewConsumer,NewSource,Sprintf,Fatal,PublishEvent,Getenv,Verbose] | requires that the caller has already initialized the nagios object testReadFromKafkaTopic is a function that returns a consumer that reads nMessages messages. | Is this to test BC compatibility? I assume it is just a simplification to keep the tests the same. |
@@ -650,7 +650,7 @@ class ArchiveChecker:
def report_progress(self, msg, error=False):
if error:
self.error_found = True
- print(msg, file=sys.stderr if error else sys.stdout)
+ logger.log(logging.ERROR if error else logging.WARNING, msg)
def identify_key(self, repository... | [ArchiveChecker->[check->[load],rebuild_manifest->[report_progress],rebuild_refcounts->[mark_as_possibly_superseded->[add],verify_file_chunks->[report_progress,add_reference],robust_iterator->[report_progress,resync,RobustUnpacker,feed],mark_as_possibly_superseded,verify_file_chunks,robust_iterator,report_progress,Chun... | Report progress for the next key in the sequence. | is everything a warning when error is False? I would have expected rather INFO stuff when error is False. |
@@ -68,7 +68,7 @@ if ( is_admin() ) {
require_once JETPACK__PLUGIN_DIR . 'class.jetpack-admin.php';
require_once JETPACK__PLUGIN_DIR . 'class.jetpack-affiliate.php';
$jitm = new Automattic\Jetpack\JITM();
- $jitm->register();
+ add_action( 'plugins_loaded', array( $jitm, 'register' ) );
jetpack_require_lib( 'de... | [register] | Load all of the plugin files. Add a filter to the list of modules that can be called from Jetpack. | I am not sure this should live here as well. I would probably move it somewhere where it makes more sense but am not sure where. |
@@ -3,6 +3,9 @@
module GobiertoCommon
class Scope < ApplicationRecord
include GobiertoCommon::Sortable
+ include GobiertoCommon::Sluggable
+ include GobiertoCommon::ActsAsCollectionContainer
+ include User::Subscribable
translates :name, :description
| [Scope->[include,belongs_to,scope,translates,validates,has_many,order]] | A simple way to create a single object from a ApplicationRecord. | This method is only used in the tests? Could we remove it? The same happens in the `Issue class`. |
@@ -55,6 +55,16 @@ func (es *Client) ExpectMinDocs(t testing.TB, min int, index string, query inter
result.Hits.MinHitsCondition(min),
result.Hits.TotalHitsCondition(req),
)))
+
+ // Refresh the indices before issuing the search request.
+ refreshReq := esapi.IndicesRefreshRequest{
+ Index: strings.S... | [UnmarshalJSON->[Unmarshal],ExpectMinDocs->[WithSize,Do,Background,WithQuery,Fatal,MinHitsCondition,Search,TotalHitsCondition,Helper],Do->[Do],UnmarshalSource->[Unmarshal],WithQuery->[NewJSONReader],NonEmptyCondition->[MinHitsCondition],Search->[Split],ExpectDocs->[ExpectMinDocs,Helper]] | ExpectMinDocs expects min documents in an index. | This could just be a warning, or be ignored completely. |
@@ -97,6 +97,9 @@
NODE_TYPE_DOCUMENT,
NODE_TYPE_DOCUMENT_FRAGMENT
*/
+/* global
+ console
+*/
////////////////////////////////////
| [No CFG could be retrieved] | Provides a list of all of the high level breakdowns of all of the components available A function to convert manual lowercase and uppercase to lowercase. | You can avoid this by accessing `console` off `window` (not sure what is better). |
@@ -3,7 +3,7 @@
<header class="p-2 pr-0 flex items-center justify-between">
<h3 class="crayons-subtitle-3">My Tags</h3>
<a id="tag-priority-link" href="/dashboard/following_tags" class="crayons-btn crayons-btn--icon crayons-btn--ghost-dimmed" aria-label="Customize tag priority" title="Customize tag p... | [No CFG could be retrieved] | A sidebar nav showing the top - level tags in the sidebar. Nav >. | This is just to be consistent with other cog icons we used elsewhere. |
@@ -84,6 +84,7 @@ class TableClient(TablesBaseClient):
raise ValueError("Please specify a table name.")
_validate_table_name(table_name)
self.table_name = table_name
+ self.prepare_key = _prepare_key
super(TableClient, self).__init__(endpoint, **kwargs)
def _format_... | [TableClient->[update_entity->[update_entity],delete_entity->[delete_entity],upsert_entity->[update_entity]]] | Create a TableClient from a Credential. . | Shouldn't the value be `None or _prepare_key`? Otherwise, why you are not using _prepare_key directly. |
@@ -245,6 +245,13 @@ module Email
# can debug deliverability issues.
email_log.smtp_group_id = smtp_group_id
+ # Store contents of all outgoing emails for greater visibility. Not
+ # really required by default, but a good idea to turn on for SMTP
+ # and IMAP sending.
+ if SiteSettin... | [Sender->[to_address->[first,presence,try],header_value->[header,value],send->[header_value,post_id,bounceable_reply_address?,end_with?,new,text_part,smtp_group_id,topic,staff?,strip_avatars_and_emojis,base_url,charset,first,order,name,inline_secure_images,map,html_part,bounce_address,trigger,nil?,add_attachments,deliv... | Sends a single node in the chain. Add a message in the log if it is not already there. Checks if there is a node with a node with a node with a node with a message The next two methods are called from the message handler. | I'm not sure if we should be storing this in the table because I don't think this site settings can be enabled for a long duration. On sites where alot of emails are sent, storing the raw in the database is going to make the `email_logs` table take up more disk space. Instead, could we just log the raw if a dev really ... |
@@ -150,7 +150,9 @@ class Jetpack_Connection_Banner {
$jetpackApiUrl = parse_url( Jetpack::connection()->api_url( '' ) );
- if ( Constants::is_true( 'JETPACK_SHOULD_USE_CONNECTION_IFRAME' ) ) {
+ if ( wp_is_mobile() ) {
+ $force_variation = 'original';
+ } else if ( Constants::is_true( 'JETPACK_SHOULD_USE_C... | [Jetpack_Connection_Banner->[render_banner->[get_ab_banner_top_bar,build_connect_url_for_slide]]] | Enqueue Jetpack connect button scripts. | Instead of relying on `wp_is_mobile()`, what do you think about using our own `jetpack_is_mobile()`, which is a bit more detailed? |
@@ -1306,6 +1306,13 @@ class Jetpack_Tweetstorm_Helper {
* appears in the HTML blob, including nested tags.
*/
private static function extract_tag_content_from_html( $tags, $html ) {
+ // Serialised blocks will sometimes wrap the innerHTML in newlines, but those newlines
+ // are removed when in... | [Jetpack_Tweetstorm_Helper->[gather->[is_offline_mode],extract_tag_content_from_html->[isValidURL]]] | Extracts the content of a tag from a given HTML string. This function is called to parse the content of a tag. It will check if the tag This function is called to add a tag to the right list of tags. Undefined object - not implemented. | I ran across this issue while writing unit tests for this change: as far as I can tell, it has no effect on the tweets produced, it was only showing up as an inconsistency when calculating where the split indicator should appear in the editor. I've also altered a couple of the block generators in the unit tests to cove... |
@@ -61,7 +61,7 @@ class SpanConstituencyParser(Model):
encoder : ``Seq2SeqEncoder``, required.
The encoder that we will use in between embedding tokens and
generating span representations.
- feedforward_layer : ``FeedForward``, required.
+ feedforward : ``FeedForward``, required.
T... | [SpanConstituencyParser->[construct_trees->[SpanInformation],from_params->[from_params],construct_tree_from_spans->[assemble_subtree->[assemble_subtree],assemble_subtree]]] | A class that can be used to parse a sequence of text and produce a label for each Initialize the SpanConstituencyParser. | This will break existing models in the demo - you'll need to update it manually |
@@ -149,8 +149,6 @@ def main():
pip_version = StrictVersion(check_output(['pip', '--version'])
.decode('utf-8').split()[1])
min_pip_version = StrictVersion(PIP_VERSION)
- if pip_version >= min_pip_version:
- return 0
has_pip_cache = pip_version >= StrictVersion(... | [hashed_download->[HashError,read_chunks,opener],main->[get_index_base,hashed_download,check_output],main] | Check if a node - package - id is available. | Might as well delete this line too, with its now-unread variable. |
@@ -50,6 +50,17 @@ namespace Dynamo.Wpf.UI.GuidedTour
private const string mainGridName = "mainGrid";
private const string libraryViewName = "Browser";
+ /// <summary>
+ /// This property will be used for getting the current guide being executed in other assemblies like LibraryViewExte... | [GuidesManager->[LaunchTour->[Initialize],ExitTourButton_Click->[ExitTour],TourStarted->[Initialize],CreateGuideSteps->[ReadGuides]]] | This property contains the list of Guides being played. This is an initializer that will read all the guides and steps from a json file and. | Can it be an internal property? |
@@ -228,16 +228,13 @@ class LobbyGamePanel extends JPanel {
// we sort the table, so get the correct index
final GameDescription description =
gameTableModel.get(gameTable.convertRowIndexToModel(selectedIndex));
- GameRunner.joinGame(description, messengers);
+ GameRunner.joinGame(description, ... | [LobbyGamePanel->[bootPlayerInHeadlessHostBot->[getLobbyWatcherNodeForTableRow,hashPassword],mouseOnGamesList->[isAdmin],isAdmin->[isAdmin],joinGame->[joinGame],hostGame->[hostGame],shutDownHeadlessHostBot->[getLobbyWatcherNodeForTableRow,shutDownHeadlessHostBot,hashPassword],stopGameHeadlessHostBot->[getLobbyWatcherNo... | Join the game. | Off-Topic: I have been thinking about what needs to be done in order to move more classes up to `game-headed`, and one of the first things that need to be done is getting rid of all the static helper methods in `GameRunner` because this class is the root of all the headed code. Besides that, spawning a new JVM to launc... |
@@ -112,12 +112,16 @@ class RuleRunner:
options_bootstrapper = create_options_bootstrapper()
global_options = options_bootstrapper.bootstrap_options.for_global_scope()
- local_store_dir = global_options.local_store_dir
+ local_store_dir = (
+ os.path.realpath(safe_mkdtemp())... | [MockConsole->[green->[_safe_color],cyan->[_safe_color],red->[_safe_color],magenta->[_safe_color],blue->[_safe_color],yellow->[_safe_color]],GoalRuleResult->[noop->[GoalRuleResult]],run_rule_with_mocks->[get],RuleRunner->[make_snapshot_of_empty_files->[make_snapshot],add_to_build_file->[create_file],create_dir->[_inval... | Initialize a new Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested This method is called by the scheduler when a node is missing a node. | Without this, the folder shows up in `PathGlobs` for `**/*`. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.