patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -38,6 +38,7 @@ public class ErrorTypeRepositoryFactory {
errorTypeRepository.addErrorType(RETRY_EXHAUSTED, connectivityErrorType);
errorTypeRepository.addErrorType(ROUTING, errorTypeRepository.getAnyErrorType());
errorTypeRepository.addErrorType(SECURITY, errorTypeRepository.getAnyErrorType());
+ e... | [ErrorTypeRepositoryFactory->[createDefaultErrorTypeRepository->[getAnyErrorType,addErrorType,ErrorTypeRepository]]] | Creates a default error type repository. | Use CRITICAL if you don't want it to be handled by users. |
@@ -46,6 +46,14 @@ module CategoryGuardian
nil
end
+ def can_see_serialized_category?(category_id:, read_restricted: true)
+ # Guard to ensure only a boolean is passed in
+ read_restricted = true unless !!read_restricted == read_restricted
+
+ return true if !read_restricted
+ secure_category_ids... | [can_delete_category?->[can_edit_category?],topic_create_allowed_category_ids->[topic_create_allowed_category_ids],secure_category_ids->[secure_category_ids]] | Returns a string that can be used to display the error message if the given category is not. | Extra guard here by always defaulting to read_restricted true. |
@@ -394,6 +394,16 @@ ActiveRecord::Schema.define(version: 20171220101924) do
t.datetime "updated_at", null: false
end
+ create_table "gi_indicators", force: :cascade do |t|
+ t.string "name", default: "", null: false
+ t.date "year"
+ t.jsonb "indicator_response"
+ t.bigint "site_id"
+ t.datet... | [jsonb,bigint,decimal,string,text,date,hstore,add_foreign_key,datetime,integer,enable_extension,create_table,boolean,index,define,inet] | Create the tables for the given object Table for people in a group. | It's very weird to be calling this attribute as `.year.year` in all the code. A year is a year, and a date, is a date. If you just want to store the year, I don't think `date` is the proper type here. I'd make it to be a integer. |
@@ -311,6 +311,10 @@ func TestSyncContexts(t *testing.T) {
"clusterId", newClusterId,
"userAddress", "grpc://pachd.default:700",
).Run())
+
+ // make sure that the cluster with id = 'localhost' does not get synched.
+ // it's used by the License Server to identify itself
+ require.YesError(t, tu.BashCmd(`pachct... | [YesError,InspectCluster,DoOAuthExchange,HasPrefix,SetAuthToken,Start,DeleteAllEnterprise,NewForTest,Ctx,Wait,NewScanner,TrimSpace,Text,NoError,StdoutPipe,Scan,DeleteAll,Command,NewEnterpriseClientForTest,GetAddress,BashCmd,GetTestEnterpriseCode,UniqueString,Run] | TestRegisterDefaultArgs registers a new cluster with the system register a new cluster. | I think the metric we care about for filtering is actually `EnterpriseServer` being true? The idea is that an org has one enterprise server, and that's where we're getting the info from? |
@@ -621,8 +621,7 @@ class InstallRequirement(object):
vcs_backend.export(self.source_dir, url=hidden_url)
else:
assert 0, (
- 'Unexpected version control type (in %s): %s'
- % (self.link, vc_type))
+ 'Unexpected version control type (in... | [InstallRequirement->[from_path->[from_path],prepare_metadata->[warn_on_mismatching_name,_set_requirement],_get_archive_name->[_clean_zip_name],get_dist->[_get_dist],install->[prepend_root],load_pyproject_toml->[load_pyproject_toml],archive->[_get_archive_name],ensure_has_source_dir->[ensure_build_location]]] | Updates the editable flag of a node. | This should be split across multiple lines. |
@@ -87,7 +87,12 @@ class DeviceNDArrayBase(object):
strides = (strides,)
dtype = np.dtype(dtype)
self.ndim = len(shape)
- if len(strides) != self.ndim:
+ if strides is None:
+ strides = [dtype.itemsize]
+ for s in shape[:0:-1]:
+ strides.... | [DeviceNDArray->[reshape->[reshape],_do_setitem->[reshape,_assign_kernel,__getitem__,_default_stream,view],ravel->[ravel,_default_stream],__array__->[copy_to_host],_do_getitem->[__getitem__,view,_default_stream]],from_array_like->[DeviceNDArray],check_array_compatibility->[squeeze],DeviceNDArrayBase->[copy_to_host->[_d... | Initialize an array with a specific shape strides and data type. | This is incorrect if `shape == ()`, when the correct output is `strides == ()` |
@@ -543,6 +543,10 @@ namespace Dynamo.Models
InitializeNodeLibrary(preferences);
LogWarningMessageEvents.LogWarningMessage += LogWarningMessage;
+
+ var renderPackageFactoryAsm = config.PackageManagerAddress ??
+ AssemblyConfiguration.Instance.GetAppSetting("r... | [DynamoModel->[InitializeNodeLibrary->[InitializeIncludedNodes],ForceRun->[ResetEngine],Paste->[Copy],RemoveWorkspace->[Dispose],ResetEngine->[ResetEngine],ShutDown->[OnShutdownStarted,OnShutdownCompleted],DumpLibraryToXml->[DumpLibraryToXml],ResetEngineInternal->[RegisterCustomNodeDefinitionWithEngine,Dispose],AddWork... | UpdateManager_Log - log message and level. | This is not the `config` field you are looking for. :) |
@@ -134,6 +134,12 @@ public class DefaultDomainFactory extends AbstractDeployableArtifactFactory<Doma
@Override
protected Domain doCreateArtifact(File domainLocation, Optional<Properties> deploymentProperties) throws IOException {
+ return createArtifact(domainLocation, deploymentProperties, null);
+ }
+
+ ... | [DefaultDomainFactory->[doCreateArtifact->[findDomain,createArtifactPluginList]]] | Creates a new Mule domain. | what's the purpose of this split? where is this new method called? |
@@ -24,10 +24,9 @@ import (
"sync"
"time"
- "golang.org/x/net/context"
-
log "github.com/Sirupsen/logrus"
"github.com/golang/groupcache/lru"
+ "golang.org/x/net/context"
"github.com/vmware/govmomi/vim25/types"
"github.com/vmware/vic/lib/config/executor"
| [SetSpec->[Errorf],Create->[SetSpec,Error,Begin,Sprintf,NewLinuxGuest,New,Name,End,Spec,Errorf,LookupIP,Debugf],Commit->[SetSpec,Unix,Commit,MapSink,Now,UTC,OptionValueFromMap,Spec,Encode],Unlock,ReadFull,Begin,New,Remove,End,Lock,Errorf,String,Get,EncodeToString,Add] | Creates a new container with a specific configuration. Mutex const is a helper function that initializes a new Handle object. | doesn't have to be in this PR but we should start switching to "context" |
@@ -5272,7 +5272,7 @@ func TestValidateAzureStackSupport(t *testing.T) {
cs.Properties.OrchestratorProfile.OrchestratorVersion = "1.16.11"
if err := cs.Validate(false); !helpers.EqualError(err, test.expectedErr) {
t.Logf("scenario %q", test.name)
- t.Errorf("expected error: %v, got: %v", test.expectedEr... | [EqualError,validateNetworkPlugin,validateNetworkMode,validateMasterProfile,validateAgentPoolProfiles,BoolPtr,Error,Sprint,GetVersionsGt,IsKubernetesVersionGe,Validate,validateContainerRuntime,New,validateZones,validateAADProfile,validateKubernetesImageBaseType,validateWindowsProfile,Errorf,Make,Logf,validateCustomClou... | TestGetClusterConfig returns a container config with default values for master and agent availability profiles. Check if the given value is valid kubernetesImageBaseType. | @jadarsie if I follow our usual process, this leaves Azure Stack without a supported 1.16.x version, so I disabled this test. But let me know if you prefer a different approach--we can be flexible about version support if need be. |
@@ -106,13 +106,13 @@ public class ReconnectionTestCase extends AbstractExtensionFunctionalTestCase {
public void reconnectAfterConnectionExceptionOnFirstPage() throws Exception {
resetCounters();
Iterator<ReconnectableConnection> iterator = getCursor("pagedOperation", 1, CONNECTIVITY);
- ReconnectableC... | [ReconnectionTestCase->[assertRetryTemplate->[isAsync,getFieldValue,is,toMillis,createRetryInstance,assertThat],getInlineRetryPolicyTemplate->[getValue,assertRetryTemplate],reconnectAfterConnectionExceptionOnFirstPage->[getCursor,getDisconnectCalls,resetCounters,is,assertThat,next],getCursor->[getValue,openCursor],getR... | This method reconnects after a connection exception on the first page. | use the ExpectedException rule and assert on the cause being THE SAME instance you are expecting and the actual exception being of the correct type |
@@ -268,6 +268,7 @@ namespace System.Data.Odbc
[System.ComponentModel.DefaultValueAttribute(System.Data.Odbc.OdbcType.NChar)]
[System.Data.Common.DbProviderSpecificTypePropertyAttribute(true)]
public System.Data.Odbc.OdbcType OdbcType { get { throw null; } set { } }
+ public int Offset... | [OdbcConnection->[Hidden],OdbcCommand->[Never,Both,Content,Hidden,Text],OdbcParameterCollection->[Add->[Never],Hidden],OdbcParameter->[Advanced,NChar]] | Creates a new OdbcParameter object. The object that is returned by the database. | What is going on with this addition? |
@@ -35,6 +35,11 @@ import org.nuxeo.runtime.model.DefaultComponent;
public class ShibbolethAuthenticationServiceImpl extends DefaultComponent implements ShibbolethAuthenticationService {
+ /**
+ * @since 8.4
+ */
+ private static final String REDIRECT_URL = "redirect_url";
+
public static final ... | [ShibbolethAuthenticationServiceImpl->[getLogoutURL->[getLogoutURL,getRedirectUrl],getLoginURL->[getLoginURL,getRedirectUrl],getUserMetadata->[getUserID]]] | Register a contribution for the given extension point. | Why initializing REDIRECT_URL with "redirect_url"? Is it a wanted fallback redirect url? |
@@ -22,6 +22,17 @@ const reducer = ReducerRegistry.combineReducers({
routing: routerReducer
});
+const additionalMiddlewares = [
+ Thunk,
+ routerMiddleware(browserHistory)
+];
+
+// Enable logger for development environment
+if (process.env.NODE_ENV !== 'production') {
+ additionalMiddlewares.push(cre... | [No CFG could be retrieved] | Imports a single component from the main DOM. Find the react element in the DOM. | I do not want 2 empty lines. Please leave 1 empty line. |
@@ -16,11 +16,7 @@
// Project includes
#include "includes/process_info.h"
#include "testing/testing.h"
-
-// Application includes
-
-// Contitutive Law
-#include "custom_constitutive/elastic_isotropic_3d.h"
+#include "utilities/math_utils.h"
#include "custom_utilities/tangent_operator_calculator_utility.h"
names... | [Set->[SetValue,C,SetProcessInfo,Tangent,SetStressVector,SetDeformationGradientF,SetOptions,GetConstitutiveMatrix,CalculateElasticMatrix,SetMaterialProperties,ZeroVector,SetStrainVector,KRATOS_CHECK_NEAR,ZeroMatrix,IdentityMatrix,SetConstitutiveMatrix,Set,ElasticIsotropic3D],CalculateElasticMatrix->[size1,size2,resize,... | The main function of the functions that calculate the elastic matrix of the . Checks the correct calculation of the uniaxial stress of the yield surfaces. | Doing this C will be exactly the same as r_tangent_moduli, because we work with references |
@@ -19,7 +19,9 @@
package org.apache.druid.indexing.overlord;
+import com.google.common.collect.ImmutableList;
import org.junit.Assert;
+import org.junit.Before;
import org.junit.Test;
import java.io.IOException;
| [PortFinderTest->[testUsedPort->[findUnusedPort,ServerSocket,assertNotEquals,markPortUnused,close,assertEquals],PortFinder]] | Test the usage of a specific . | I would avoid environment dependent code in unit tests, it can interfere with another process or test. It's better to mock `canBind`, ie if you want to check the class doesn't provide occupied *1024* port, make the method stub of `canBind(1024)` return `false`. |
@@ -346,8 +346,14 @@ defineSuite([
primitives.add(p0);
primitives.add(p1);
- var pickedObject = pick(context, frameState, primitives, 0, 0);
- expect(pickedObject).toEqual(p1);
+ waitsFor(function() {
+ return render(context, frameState, primitives) > 0;
+ });
... | [No CFG could be retrieved] | Determines that a primitive is selected from the context. Picks a primitive from a list of primitives. | Can we factor this `waitsFor` and `runs` into a common function that all these specs can call? In general, can we do this throughout the test suites for the common cases? Also, how did this impact the time for running all tests? I assume/hope not at all. |
@@ -46,6 +46,9 @@ import (
"github.com/pulumi/pulumi/pkg/workspace"
)
+// BeginningOfSession is the time at which the current CLI command began executing.
+var BeginningOfSession time.Time
+
// NewPulumiCmd creates a new Pulumi Cmd instance.
func NewPulumiCmd() *cobra.Command {
var cwd string
| [StringVar,RawMessage,Dir,Colorize,Executable,Warningf,Now,Encode,HasPrefix,Add,IsTruthy,IgnoreClose,Flush,Stat,ParseTolerant,NewEncoder,New,RunFunc,Diag,StringVarP,NewClient,InitLogging,Run,After,Chdir,AddCommand,LookPath,GetCachedVersionFilePath,Bytes,TrimSpace,InitProfiling,Join,Wrapf,Infof,Current,EvalSymlinks,Read... | NewPulumiCmd creates a new command object from a cobra. Command. - > Pulumi new. | Wiring this `BeginningOfSession` value seems unfortunate. An alternate proposal would be to store a value in the `context.Context` that is already wired via `commandContext()`. That could carry this additional information. Or, when it is finally used, just subtracting 5 seconds from ~`time.Now` or some similar heuristi... |
@@ -39,7 +39,17 @@ public class KsqlBareOutputNode extends OutputNode {
final OptionalInt limit,
final TimestampExtractionPolicy extractionPolicy
) {
- super(id, source, schema, limit, extractionPolicy);
+ super(
+ id,
+ source,
+ // KSQL internally copies the implicit and ke... | [KsqlBareOutputNode->[buildStream->[buildStream]]] | Gets the next query id. | Don't think adding this was intentional.... we shouldn't be doing this. |
@@ -44,6 +44,15 @@ namespace System
_objectName = info.GetString("ObjectName");
}
+ [StackTraceHidden]
+ [DoesNotReturn]
+ public static void Throw(object? instance) =>
+ Throw(instance?.GetType());
+
+ [DoesNotReturn]
+ public static void Throw(Type... | [ObjectDisposedException->[GetObjectData->[GetObjectData]]] | Add the object name to the serialization info. | Should this be nullable? |
@@ -56,6 +56,7 @@ public class QueryRegistryImpl implements QueryRegistry {
private final Map<QueryId, PersistentQueryMetadata> persistentQueries;
private final Set<QueryMetadata> allLiveQueries;
+ private final Map<QueryId, QueryMetadata> allQueries;
private final Map<SourceName, QueryId> createAsQueries;
... | [QueryRegistryImpl->[close->[close,getAllLiveQueries],createSandbox->[QueryRegistryImpl],ListenerImpl->[onClose->[onClose,unregisterQuery],onError->[onError],onStateChange->[onStateChange]]]] | Creates a new instance of the query registry. Sets the query registry to be used by the given executor. | Let's see if we can get rid of allLiveQueries, since this is a bit redundant and `allQueries` an presumably be used for the same purposes. |
@@ -2156,7 +2156,10 @@ define([
}
};
- var scratchBackBufferArray = [WebGLRenderingContext.BACK];
+ var scratchBackBufferArray;
+ if (defined(window.WebGLRenderingContext)) {
+ scratchBackBufferArray = [window.WebGLRenderingContext.BACK];
+ }
function beginDraw(context, framebu... | [No CFG could be retrieved] | Initializes the clear command. Need a way for a command to give what draw buffers are active?. | Do we really need to use `window.` everywhere when using `WebGLRenderingContext`? If so, I need to update the glTF branch. |
@@ -4908,8 +4908,13 @@ p {
return $secrets;
}
+ /**
+ * @deprecated 7.5
+ * @param $action
+ * @param $user_id
+ */
public static function delete_secrets( $action, $user_id ) {
- return self::init()->connection_manager->delete_secrets( $action, $user_id );
+ return self::connection()->delete_secrets( ... | [Jetpack->[generate_secrets->[generate_secrets],verify_json_api_authorization_request->[add_nonce],get_locale->[guess_locale_from_lang],authenticate_jetpack->[verify_xml_rpc_signature],wp_rest_authenticate->[verify_xml_rpc_signature],admin_page_load->[disconnect,unlink_user],jetpack_getOptions->[get_connected_user_data... | Get the secrets for a user. | some indentation weirdness in this method |
@@ -513,11 +513,14 @@ def sequence_last_step(input):
x = fluid.data(name='x', shape=[None, 10], dtype='float32', lod_level=1)
x_last_step = fluid.layers.sequence_last_step(input=x)
"""
+ check_variable_and_dtype(input, 'input', ['float32'], 'sequence_last_step')
return sequence_... | [sequence_first_step->[sequence_pool],sequence_last_step->[sequence_pool]] | This operator applies pooling on last time - step feature of each sequence. This function creates a sequence_slice function that crops a subsequence from given sequence with This function creates a Variable that represents a sequence of length 4 with offset and length 4 with. | Actually, `sequence_first_step `, `sequence_last_step `, `sequence_pool ` support both float32 and float64. Maybe we can change these checks and docs |
@@ -1424,7 +1424,7 @@ def test_staff_create(
)
-@patch("saleor.dashboard.emails._send_set_user_password_email_with_url.delay")
+@patch("saleor.core.emails._send_set_user_password_email_with_url.delay")
def test_staff_create_send_password_with_url(
_send_set_user_password_email_with_url_mock,
staff_a... | [test_password_reset_email_non_existing_user->[post_graphql,get_graphql_content,assert_not_called],test_password_change_incorrect_old_password->[check_password,post_graphql,get_graphql_content,refresh_from_db],test_user_with_cancelled_fulfillments->[upper,len,post_graphql,to_global_id,get_graphql_content,add],test_me_q... | Test staff create send password with url mock. | All the above: maybe it would be better to move those tasks to `saleor.account.emails`? |
@@ -80,6 +80,7 @@ std::map<size_t, std::vector<FeatureDef>> kCPUFeatures{
}}};
static inline void cpuid(size_t eax, size_t ecx, int regs[4]) {
+#if defined(__x86_64__)
#if defined(WIN32)
__cpuidex(
static_cast<int*>(regs), static_cast<int>(eax), static_cast<int>(ecx));
| [No CFG could be retrieved] | Private functions for accessing CPUID. region Private API Methods. | Would it make sense to disable this table from the SQLiteDBManager constructor in `osquery/osquery/sql/sqlite_util.cpp` when compiling on Aarch64? |
@@ -16,13 +16,14 @@
*/
package org.apache.nifi.cluster.protocol.spring;
-import java.util.concurrent.TimeUnit;
import org.apache.nifi.io.socket.ServerSocketConfiguration;
import org.apache.nifi.security.util.StandardTlsConfiguration;
import org.apache.nifi.util.FormatUtils;
import org.apache.nifi.util.NiFiProp... | [ServerSocketConfigurationFactoryBean->[getObject->[setReuseAddress,ServerSocketConfiguration,getClusterNodeReadTimeout,getProperty,setNeedClientAuth,fromNiFiProperties,setSocketTimeout,parseBoolean,setTlsConfiguration,getPreciseTimeDuration]]] | Creates a ServerSocketConfiguration object that can be used to create a new instance of a N Parse the TLS configuration from the properties file. | It looks like this change could be reverted since it is just reordering imports. |
@@ -598,6 +598,12 @@ namespace System
buffer[15] = (byte)(d.flags >> 24);
}
+ internal static void GetBytes(in decimal d, byte[] buffer)
+ {
+ Debug.Assert(buffer != null, "[GetBytes]buffer != null");
+ GetBytes(in d, buffer.AsSpan());
+ }
+
in... | [Decimal->[TypeCode->[Decimal],ToUInt16->[ToUInt16],ToInt64->[ToInt64],GetHashCode->[GetHashCode],ToUInt64->[ToUInt64],OnDeserialization->[IsValid],Round->[Round],ToBoolean->[ToBoolean],ToSByte->[ToSByte],ToInt32->[ToInt32],Truncate->[Truncate],ToByte->[ToByte],ToInt16->[ToInt16],ToUInt32->[ToUInt32],ToUInt16,ToInt64,I... | This method gets the bytes of a binary number from a read - only block. | Despite being internal, I did not remove it out of fear of breaking anything. We can mark it as obsolete or entirely remove it though, if nothing else breaks. |
@@ -0,0 +1,17 @@
+import { ReducerRegistry } from '../../base/redux';
+
+import {
+ _SET_CALLKIT_LISTENERS
+} from './actionTypes';
+
+ReducerRegistry.register('features/callkit', (state = {}, action) => {
+ switch (action.type) {
+ case _SET_CALLKIT_LISTENERS:
+ return {
+ ...state,
+ ... | [No CFG could be retrieved] | No Summary Found. | If `CallKit` is unsupported, then the reducer is unnecessary. |
@@ -77,4 +77,10 @@ export class HomeComponent implements OnInit {
this.loginService.login();
<%_ }_%>
}
+
+ <%_ if (authenticationType !== 'oauth2') { _%>
+ ngOnDestroy() {
+ this.eventManager.destroy(this.eventSubscriber);
+ }
+ <%_ }_%>
}
| [No CFG could be retrieved] | Login to the server. | would be safe to add a null check on `this.eventSubscriber` |
@@ -39,8 +39,10 @@ class Meson(object):
cmd += ' -Dprefix="{}"'.format(self._conanfile.package_folder)
self._run(cmd)
- def build(self):
- cmd = 'meson compile -C "{}"'.format(self._build_dir)
+ def build(self, target=None):
+ cmd = 'meson compile -C "{}" -j {}'.format(self._... | [Meson->[install->[_run],test->[_run],configure->[_run],build->[_run]]] | Configures the Meson toolchain with the specified parameters. | Looks good, in the close future we will move the cpu_count to the new [conf] configuration, but this is good now, thanks. |
@@ -78,9 +78,11 @@ func StandardizeEvent(ms mb.MetricSet, e mb.Event, modifiers ...mb.EventModifier
}
e.Timestamp = startTime
- e.Namespace = ms.Registration().Namespace
e.Took = 115 * time.Microsecond
e.Host = ms.Host()
+ if e.Namespace == "" {
+ e.Namespace = ms.Registration().Namespace
+ }
fullEvent :... | [Registration,WriteFile,BeatEvent,Name,Host,MarshalIndent,Errorf,Module,Parse,Skip,Fatal,Fetch,Getwd,Bool,TransformMapStrToEvent] | StandardizeEvent creates a full event given the data generated by a MetricSet. WriteEventToDataJSON writes a full event to the data. json file. | @andrewkroh Can you check if this change has unintended side effects on the auditbeat side? |
@@ -227,6 +227,11 @@ namespace Microsoft.Xna.Framework.Graphics
"MonoGame requires either ARB_framebuffer_object or EXT_framebuffer_object." +
"Try updating your graphics drivers.");
}
+
+ // Force reseting states
+ this.BlendState.PlatformApp... | [GraphicsDevice->[PlatformDrawIndexedPrimitives->[PlatformApplyState],PlatformDrawUserPrimitives->[PlatformApplyState,GraphicsDevice],PlatformApplyState->[PlatformApplyState,ActivateShaderProgram],RenderTargetBindingArrayComparer->[GetHashCode->[GetHashCode]],PlatformDrawPrimitives->[PlatformApplyState],PlatformDrawUse... | Initializes the objects that need to be cleared. Clear all colors stencil depth and stencil buffers. | I think it would be better to change these to `_actualBlendState`, etc. That will use the `GraphicsDevice`-specific instances of static state objects. I can see why it works, as it is now - because it happens that we don't create any device-specific objects in `BlendState.OpenGL.cs`. But that might change in the future... |
@@ -0,0 +1,10 @@
+<?php
+
+echo 'Dlink AP CPU Usage';
+
+$processor_oid=$device['sysObjectID'].'.5.1.3.0';
+$usage = snmp_get($device, $processor_oid, '-OvQ', '');
+
+if (is_numeric($usage)) {
+ $proc = $usage;
+}
| [No CFG could be retrieved] | No Summary Found. | You shouldn't need this file. You're registering the oid already in discovery. |
@@ -0,0 +1,11 @@
+// +build !distro
+
+package distro
+
+// Resource declared the distro brand information
+var Resource = map[string]interface{}{
+ "tidb": "TiDB",
+ "tikv": "TiKV",
+ "tiflash": "TiFlash",
+ "pd": "PD",
+}
| [No CFG could be retrieved] | No Summary Found. | BTW why do we use `interface{}` instead of `string` here? |
@@ -534,8 +534,9 @@ def maxwell_filter(raw, origin='auto', int_order=8, ext_order=3,
# first position in this interval is the same as last of the
# previous interval)
if trans is not None:
- S_decomp, pS_decomp, reg_moments, n_use_in = \
- ... | [_trans_sss_basis->[_sss_basis],_get_grad_point_coilsets->[_prep_mf_coils],_regularize_in->[_get_degrees_orders,_regularize_out],_sss_basis_basic->[_get_mag_mask,_concatenate_sph_coils,_sph_harm_norm],_compute_sphere_activation_in->[_sq],_overlap_projector->[_orth_overwrite]] | Maxwell filter data using multipole moments. This function is used to handle a high - pass filter where a block of data is not Check if a is in the output data. Details of a node with a Maxwell filtering applied. | This is an interesting construct I haven't seen before. Why not `elif reconstruct == 'orig'` and have an `else` at the bottom? |
@@ -74,10 +74,14 @@ class _OpenContextManager(GCM):
def _open(path, repo=None, rev=None, remote=None, mode="r", encoding=None):
with _make_repo(repo, rev=rev) as _repo:
- with _repo.open_by_relpath(
- path, remote=remote, mode=mode, encoding=encoding
- ) as fd:
- yield fd
+ ... | [UrlNotDvcRepoError->[__init__->[super]],_open->[open_by_relpath,_make_repo],_make_repo->[exists,external_repo,getcwd,Repo],get_url->[UrlNotDvcRepoError,get_remote,_make_repo,hash_to_path_info,str,isinstance,find_out_by_relpath],read->[open,read],_OpenContextManager->[__getattr__->[AttributeError],__init__->[func]],ope... | Open a file and return a sequence of objects. | Doesn't look like there is a need for this change. Repo.open_by_relpath already does all of this. |
@@ -42,4 +42,13 @@ public class ObjectId extends BaseId implements Serializable {
return LENGTH;
}
+ /**
+ * Generate a nil ObjectId.
+ */
+ private static ObjectId genNil() {
+ byte[] b = new byte[LENGTH];
+ Arrays.fill(b, (byte) 0xFF);
+ return new ObjectId(b);
+ }
+
}
| [ObjectId->[fromRandom->[ObjectId],fromByteBuffer->[ObjectId]]] | Returns the number of objects. | Nit: better avoid exposing nil ID in the Java API module. I think we can pass a null into `nativeRegisterObjectRef` instead, and convert null to nil ID in C++. |
@@ -139,12 +139,14 @@ class AtticRepositoryUpgrader(Repository):
`Cache.open()`, edit in place and then `Cache.close()` to
make sure we have locking right
"""
- caches = []
transaction_id = self.get_index_transaction_id()
if transaction_id is None:
lo... | [AtticKeyfileKey->[find_key_file->[get_keys_dir]],AtticRepositoryUpgrader->[convert_cache->[copy_cache_file,header_replace]]] | convert caches from attic to borg Returns the borg file that was created or None if no borg file was created. | this is the repository index, cache sounds a bit misleading. |
@@ -22,7 +22,7 @@ class VtkM(CMakePackage, CudaPackage):
git = "https://gitlab.kitware.com/vtk/vtk-m.git"
version('master', branch='master')
- version('1.5.0', sha256="cd38957bb552e28b5197e4f738d5bb0b2c6f4025c3e17a66c8b19ee501273fbe")
+ version('1.5.0', sha256="b1b13715c7fcc8d17f5c7166ff5b3e9025f... | [VtkM->[cmake_args->[satisfies,append,working_dir,print,format,InstallError],variant,conflicts,depends_on,version]] | VTK - m is a toolkit of scientific visualization algorithms for all of Create a sequence of functions that can be used to build CMake objects. | Did you investigate this checksum change? |
@@ -514,7 +514,7 @@ void Initializer::initActivePlugin(const std::string& type,
}
// The plugin is not local and is not active, wait and retry.
delay += kExtensionInitializeLatencyUS;
- sleepFor(kExtensionInitializeLatencyUS / 1000);
+ sleepFor(static_cast<unsigned int>(kExtensionInitializeLatencyU... | [No CFG could be retrieved] | Initializes a plugin. Initializes the database plugin. | Don't we control this method, can't it use a `size_t`? |
@@ -348,12 +348,10 @@ trait DataProviderRepositoryTrait
/**
* Extension point to append order.
*
- * @param array $sortBy
+ * @param string $sortBy
* @param string $sortMethod
* @param string $alias
* @param string $locale
- *
- * @return array parameters for query
... | [appendRelationOr->[andWhere],appendRelation->[appendRelationOr,appendRelationAnd],findByFiltersIds->[orderBy,addSelect,getQuery,setParameter,appendDatasource,appendCategoriesRelation,append,setMaxResults,getScalarResult,appendRelation,getBoolean,appendTargetGroupRelation,setFirstResult,appendTagsRelation,appendSortBy]... | Append sort by to QueryBuilder. | This function also contains some array specific code. |
@@ -53,7 +53,9 @@ RETURN_VALUE: Final[ErrorCode] = ErrorCode(
ASSIGNMENT: Final = ErrorCode(
"assignment", "Check that assigned value is compatible with target", "General"
)
-TYPE_ARG: Final = ErrorCode("type-arg", "Check that generic type arguments are present", "General")
+TYPE_ARG: Final[ErrorCode] = ErrorCod... | [ErrorCode->[__str__->[format]],ErrorCode] | Check that the n - tuple is valid. Check that the module can be imported or has stubs. | Why some consts are `: Final = ErrorCode()` and some are `: Final[ErrorCode] = ErrorCode()`? |
@@ -263,12 +263,14 @@ function VirtualBackground({ _selectedThumbnail, dispatch, t }: Props) {
* @param {Object} state - The Redux state.
* @private
* @returns {{
- * _selectedThumbnail: string
+ * _selectedThumbnail: string,
+ * _jitsiTrack: Object
* }}
*/
function _mapStateToProps(state): Objec... | [No CFG could be retrieved] | Map the state of the to the props of the virtual - background. | Just say `{Props}` here, we started simplifying. |
@@ -196,6 +196,7 @@ define([
errorBox.setAttribute('data-bind', 'text: editorError');
stylePanelContents.appendChild(errorBox);
+ tileDebugLabelsPanelContents.appendChild(makeCheckbox('showOnlyPickedTileDebugLabel', 'Show Only Picked Tile Label'));
tileDebugLabelsPanelContents.append... | [No CFG could be retrieved] | Creates the panel and the dropdowns for the color blend modes. appends the element. | The text could be simplified to `Show Picked Only` |
@@ -367,7 +367,7 @@ class FulfillmentLine(models.Model):
OrderLine, related_name='+', on_delete=models.CASCADE)
fulfillment = models.ForeignKey(
Fulfillment, related_name='lines', on_delete=models.CASCADE)
- quantity = models.IntegerField(validators=[MinValueValidator(1)])
+ quantity = mode... | [Order->[can_capture->[can_capture,get_last_payment],get_payment_status_display->[get_last_payment],can_charge->[can_charge,get_last_payment],can_void->[can_void,get_last_payment],total_authorized->[get_last_payment],total_captured->[get_last_payment],can_refund->[can_refund,get_last_payment],get_payment_status->[get_l... | Returns an iterator over the objects in the order. The order event class. | With this change, this field basically becomes a `PositiveIntegerField`. |
@@ -681,6 +681,7 @@ func Provider() terraform.ResourceProvider {
"aws_service_discovery_private_dns_namespace": resourceAwsServiceDiscoveryPrivateDnsNamespace(),
"aws_service_discovery_public_dns_namespace": resourceAwsServiceDiscoveryPublicDnsNamespace(),
"aws_service_discovery_ser... | [Printf,Expand,GetOk,Client,List,MultiEnvDefaultFunc,Get,NewMutexKV] | This function returns a dictionary of all the possible rules that are defined in the Ssm spec Only for internal use. | I know we generally use the AWS service name for the resource name, but this name has a bit of a stutter. What do you about just using `aws_service_quotas`? |
@@ -71,6 +71,10 @@ class PodcastEpisode < ApplicationRecord
podcast_title
end
+ def podcast_image
+ ProfileImage.new(podcast).get(width: 90)
+ end
+
def comments_blob
comments.pluck(:body_markdown).join(" ")
end
| [PodcastEpisode->[class_name->[name],path->[slug],comments_blob->[join],tag_keywords_for_search->[join],process_html_and_prefix_all_images->[attr,processed_html,include?,cl_image_path,blank?,each,gsub],bust_cache->[perform_async],body_text->[sanitize],description->[sanitize],published_at_int->[to_i],published,searchabl... | user_name - user_title - user_name - user_title. | as this is only called in the serializer, would it make sense to keep it there in a block? |
@@ -23,6 +23,9 @@ class FileChunkMapper {
this.cache = cache;
}
+ /**
+ * Guaranteed to be a power of two
+ */
public int getChunkSize() {
return file.getChunkSize();
}
| [FileChunkMapper->[getChunkKey->[getChunkKey],getChunkSize->[getChunkSize]]] | fetchChunk - get the chunk number from cache. | not sure, but I think this is not true when `ModularArithmetic.CANNOT_ASSUME_DENOM_IS_POWER_OF_TWO` is true |
@@ -131,10 +131,9 @@ public class CachingClusteredClient<T> implements QueryRunner<T>
return Sequences.empty();
}
- byte[] queryCacheKey = null;
- if (strategy != null) {
- queryCacheKey = strategy.computeCacheKey(query);
- }
+ Map<Pair<ServerSelector, SegmentDescriptor>, Pair<String, Byt... | [CachingClusteredClient->[run->[addSequencesFromServer->[run]]]] | Runs the query and returns a sequence of the results. Returns a sequence that can be used to generate a sequence. Adds all the sequences from the cache to the list of sequences. This method is used to merge the list of sequences. | A Map of Pair<> to Pair<> can get a little unwieldy for the understanding of the code. How about we introduce holder classes with meaningful names for each of the Pair<>s? |
@@ -338,6 +338,16 @@ func (o *Operator) getMonitoringFilebeatConfig(outputType string, output interfa
"output": map[string]interface{}{
outputType: output,
},
+ "processors": []map[string]interface{}{
+ {
+ "add_fields": map[string]interface{}{
+ "target": "agent",
+ "fields": map[string]interfa... | [getMonitoringMetricbeatConfig->[ReplaceAll,getMetricbeatEndpoints,AgentPrefixedMonitoringEndpoint,Sprintf,Version,AgentID,OS,Snapshot,Debugf],getMetricbeatEndpoints->[ReplaceAll,Unlock,Monitor,MetricsPathPrefixed,Name,Lock,Spec],handleStartSidecar->[M,Append,start,stop,New,handleStopSidecar,markStopMonitoring,Info,get... | getMonitoringFilebeatConfig returns a config map with the configuration of the monitoring filebe This function returns a snapshot of the state of the agent. Monitoring configuration for filebeat. | out of curiosity, why is this processor not part of the input processors above? |
@@ -214,9 +214,7 @@ int OBJ_NAME_add(const char *name, int type, const char *data)
if (!OBJ_NAME_init())
return 0;
- CRYPTO_THREAD_write_lock(lock);
-
- alias = type & OBJ_NAME_ALIAS;
+ alias = type & OBJ_NAME_ALIAS;
type &= ~OBJ_NAME_ALIAS;
onp = OPENSSL_malloc(sizeof(*onp));
| [void->[OBJ_NAME_remove],OBJ_NAME_add->[OBJ_NAME_init],OBJ_NAME_remove->[OBJ_NAME_init],char->[OBJ_NAME_init],OBJ_NAME_do_all_sorted->[OBJ_NAME_do_all],OBJ_NAME_new_index->[OBJ_NAME_init]] | Adds a new object name and type. | Nit: Something strange is happening to indentation here! |
@@ -408,6 +408,18 @@ func (t *tether) launch(session *SessionConfig) error {
log.Debugf("Resolved %s to %s", session.Cmd.Path, resolved)
session.Cmd.Path = resolved
+ // block until we have a connection
+ if session.RunBlock {
+ log.Debugf("Waiting clear signal to launch %s", session.ID)
+ select {
+ case <-t.... | [Register->[Infof],launch->[Join,Unlock,Error,Begin,WriteFile,Sprintf,New,SessionLog,End,ProcessEnv,Start,MultiReader,Lock,Errorf,Base,MkdirAll,EncodeWithPrefix,Debugf],handleSessionExit->[Join,Unlock,Unix,Begin,Sprintf,Now,Remove,End,Close,UTC,Lock,HandleSessionExit,Base,Wait,EncodeWithPrefix],Flush->[End,Encode,Begin... | launch launches the session This function is the main function that is called when a child process is launched. It is. | I think session.RunBlock should only apply once - if we've got restart set then this will cause issues, as will the repeated closing of ClearToLaunch in handleSessionExit. Could we close and nil ClearToLaunch in here after it's used given session is locked? |
@@ -1,3 +1,14 @@
frappe.ready(function() {
- // bind events here
-});
\ No newline at end of file
+ frappe.web_form.after_load = () => {
+ frappe.call({
+ method: "frappe.website.doctype.website_settings.website_settings.get_account_deletion_sla",
+ callback: (data) => {
+ if (data.message) {
+ const intro... | [No CFG could be retrieved] | This is called when the Frappe instance is ready to be used. | Make string translatable since this is user-facing text. |
@@ -24,7 +24,7 @@ use Symfony\Component\Validator\Constraints as Assert;
* @author Vincent Chalamon <vincentchalamon@gmail.com>
*
* @ApiResource(attributes={
- * "order"={"name", "DESC"}
+ * "order"={"bar": "ASC", "name": "DESC"}
* })
* @ORM\Entity
*/
| [No CFG could be retrieved] | Creates an object that represents a single non - empty . | Just some nitpicking : it would be great to also allow `"order"={"bar", "name"}` (that would be equivalent to ` "order"={"bar": "ASC", "name": "ASC"}`. It's just some syntactic sugar but it improves the overall DX. |
@@ -316,7 +316,7 @@ uint16_t ossl_ifc_ffc_compute_security_bits(int n)
/*
* Look for common values as listed in standards.
- * These values are not exactly equal to the results from the foruml� in
+ * These values are not exactly equal to the results from the formulae in
* the standards but a... | [No CFG could be retrieved] | r - r of the maximum security strength estimate for a given number of bits. 8 - 7 - 8 - 8 - 8 - 8 - 8 - 8 - 8 -. | Why not "formulas"? |
@@ -164,6 +164,15 @@ namespace System.Net
{
state.RegisterForCancellation(cancellationToken);
}
+ else if (errorCode == SocketError.TryAgain)
+ {
+ // WSATRY_AGAIN indicates possible problem with reachability according to docs.
+ ... | [NameResolutionPal->[Task->[Task],GetAddrInfoExState->[Execute->[SetResult],Task]]] | Asynchronously gets the address info for the given host name. | Doesn't this now end up leaking resources that would have been freed by ProcessResult? |
@@ -730,7 +730,9 @@ func (d *Dealer) handleMessageStart(ctx context.Context, msg *GameMessageWrapped
// with our commitment. We are now in the inner loop of the Dealer, so we
// have to do this send in a Go-routine, so as not to deadlock the Dealer.
if !isLeader {
- go d.sendCommitment(ctx, md, me)
+ if d.dh.Sh... | [handleMessage->[RevealEndTime,handleMessageOthers,finishGame,GameMetadata,handleCommitment,handleCommitmentComplete,ToKey,isForwardable,Encode,handleMessageStart,setSecret],doFlip->[GameMetadata],startFlipWithGameID->[newPlayerControl],handleCommitment->[ToKey,GameMetadata,getPlayerState],sendOutgoingChat->[sendOutgoi... | handleMessageStart is called when a message is received from a user. It will create a handleMessageOthers is the main loop for the game. It is called by the game. | @mlsteele will we get warnings in the log about the fact that we weren't included in the flip but we should have been? |
@@ -203,6 +203,16 @@ class StateManager:
self.current_state = iteration.new_state
events = iteration.events
+ # check state serialization
+ state = self.current_state
+ if state is not None:
+ json = JSONSerializer.serialize(state)
+ restored = JSONSerializ... | [TransitionResult->[__ne__->[__eq__]],StateManager->[__ne__->[__eq__]],ContractReceiveStateChange->[__ne__->[__eq__]],SendMessageEvent->[__ne__->[__eq__]],ContractSendExpirableEvent->[__ne__->[__eq__]]] | Dispatch the state change in the current machine and return the resulting events. | Keep this? vs create a follow up issue for next week's release to remove? |
@@ -140,13 +140,15 @@ class AmpAccordion extends AMP.BaseElement {
// for details.
});
+ const isExpanded = section.hasAttribute('expanded');
const header = sectionComponents[0];
header.classList.add('i-amphtml-accordion-header');
header.setAttribute('role', 'button');
... | [No CFG could be retrieved] | Adds accessibility audits to the accordion. Adds a header to the list of headers and registers click and keydown events. | I think canonically we usually do `String(x)` |
@@ -147,14 +147,16 @@ class FilesystemRepository extends WritableArrayRepository
}
$versions['versions'][$package->getName()] = array(
+ 'name' => $package->getName(),
'pretty_version' => $package->getPrettyVersion(),
'vers... | [FilesystemRepository->[write->[write],reload->[initialize]]] | Writes the packages and versions to the file. Adds a package to the list of packages that can be found. Adds a package version to the list of aliases. | I don't think this makes sense. This is something derived from the version (note that this is **not** telling you whether it is a dev requirement) |
@@ -52,7 +52,17 @@ public class StartMain {
* @param args the command line arguments
*/
public static void main(String[] args) {
- new StartMain(args).go();
+ try {
+ new StartMain(args).go();
+ System.exit(0);
+ } catch (Throwable t) {
+ StreamSupp... | [StartMain->[getParameters->[arraycopy],shutdownNow->[shutdown],main->[go],go->[initialize],containerId]] | This method is the entry point for the main method of the class. | I think there is no need to use streams here... |
@@ -355,12 +355,13 @@ func (r *careReconciler) care(ctx context.Context, gardenClientSet kubernetes.In
},
)(careCtx)
- updatedConditions = append(updatedConditions, seedConditions...)
-
// Update Shoot status (conditions, constraints) if necessary
if gardencorev1beta1helper.ConditionsNeedUpdate(conditions, u... | [shootCareUpdate->[Add,MetaNamespaceKeyFunc],Reconcile->[ForGarden,Infof,Client,ShootIsManagedByThisGardenlet,care,String,Errorf,GetClient,IsNotFound,Get,WithField],care->[ComputeStatus,ConditionsNeedUpdate,ForSeedWithName,Error,InitializeSeedClients,Collect,WithTimeout,Client,ComputeGardenNamespace,Parallel,StaleExten... | care creates a new client for the given shoot client. Initialize a new operation with the given conditions and constraints. Parallel runs the logic that runs the shoot status and updates the shoot conditions and constraints Patch the Shoot status label according to the status of the last operation and the last errors. | Earlier, `seedConditions` contributed to calculation of the shoot status label. I would argue that this was wrong and it is now corrected. However, I want to double-check that we don't see a problem in changing the logic in this regard. |
@@ -82,6 +82,15 @@
<p>You can also use the category and slug like this:</p>
<code>{% listing collabs/dev-is-open-source-823 %}</code>
<p>Note: Expired listings will raise an error. Make sure the listing is published or recently bumped.</p>
+ <h3><strong>Details Embed</strong></h3>
+ <p>You can embe... | [No CFG could be retrieved] | All you need is the unique id of the object. Displays a list of all possible tags that can be found in the tag. | When I went to test this out locally I wrote some text and then put an image in the details tag and noticed the image will not load inside the tag. Should we mention something about that here? |
@@ -186,6 +186,7 @@ public class DefaultDimensionSpec implements DimensionSpec
public int hashCode()
{
int result = dimension != null ? dimension.hashCode() : 0;
+ result = 31 * result + (dataSourceName != null ? dataSourceName.hashCode() : 0);
result = 31 * result + (outputName != null ? outputName.... | [DefaultDimensionSpec->[hashCode->[hashCode],of->[DefaultDimensionSpec],toSpec->[apply->[DefaultDimensionSpec],toSpec],equals->[equals]]] | Returns the hashCode of this node. | Please follow the same order in fields, toString, hashCode and equals |
@@ -54,6 +54,11 @@ const cssEntryPoints = [
// than the JS file to avoid loading CSS as JS
outCss: 'video-autoplay-out.css',
},
+ {
+ path: 'amp-story-player.css',
+ outJs: 'amp-story-player.css.js',
+ outCss: 'amp-story-player-out.css',
+ },
];
/**
| [No CFG could be retrieved] | Provides a function to compile all the css and the JS files. Writes a CSS file if it s not already present. | What's the `outJs` for? Can we rename the `outCss` to have something more publisher friendly? |
@@ -25,7 +25,6 @@ class AssignModulusAndDirectionToNodesProcess(BaseProcess.AssignVectorComponents
{
"help" : "This process assigns a modulus and direction value to a vector variable",
"model_part_name": "MODEL_PART_NAME",
- "mesh_id": 0,
"variable_name": "... | [AssignModulusAndDirectionToNodesProcess->[__init__->[__init__]]] | Initialize the object with a model and a list of parameters. This method is called from the KratosMultiphysics class. It is called. | can be replaced by the one in the core? |
@@ -488,7 +488,8 @@ namespace Dynamo.Models
///
public NodeModel AddNode(
Guid nodeId, string nodeName, double x, double y,
- bool useDefaultPos, bool transformCoordinates, XmlNode xmlNode = null)
+ bool useDefaultPos, bool transformCoordinates, XmlNode xmlNode = nu... | [WorkspaceModel->[NodeModel->[OnRequestNodeCentered],Save->[SaveAs],OnWorkspaceSaved->[OnWorkspaceSaved],ReloadModel->[Undo],GetStringRepOfWorkspaceSync->[PopulateXmlDocument],EnableReporting->[EnableReporting],DisableReporting->[DisableReporting],Undo->[Undo],Redo->[Redo],NoteModel->[OnRequestNodeCentered],PopulateXml... | Adds a node in this model if it does not exist in the DynamoDb. | for creating a proxy node we need to know its displayed name and number of its inputs and outputs |
@@ -98,11 +98,6 @@ class NoVarySessionMiddleware(SessionMiddleware):
We skip the cache in Zeus if someone has an AMOv3 cookie, so varying on
Cookie at this level only hurts us.
"""
-
- def process_request(self, request):
- if not getattr(request, 'API', False):
- super(NoVarySessionM... | [NoAddonsMiddleware->[process_view->[get_name]],CommonMiddleware->[process_request->[safe_query_string]]] | Process the request and return a response object with a if the request is not an API. | This never did anything in AMO, which does not set this property. |
@@ -40,6 +40,8 @@ void genShadowForAccount(const struct spwd* spwd, QueryData& results) {
r["password_status"] = "not_set";
} else if (password[0] == '!' || password[0] == '*' || password[0] == 'x') {
r["password_status"] = "locked";
+ } else if (password == "") {
+ r["password_status"] = "em... | [genShadow->[genShadowForAccount,c_str,constraints,getspnam,endspent,getspent],genShadowForAccount->[TEXT,push_back,BIGINT]] | This method generates shadow data for an account. | nitpick, can you use `password.empty()`? |
@@ -873,6 +873,7 @@ static int test_set_get_raw_keys_int(int tst, int pub)
}
if (!TEST_ptr(pkey)
+ || !TEST_int_eq(EVP_PKEY_cmp(pkey, pkey), 1)
|| (!pub && !TEST_true(EVP_PKEY_get_raw_private_key(pkey, NULL, &len)))
|| (pub && !TEST_true(EVP_PKEY_get_raw_public_key(pkey,... | [No CFG could be retrieved] | Determine the size of the signature. Check if the signature round - trips are valid. | This should use EVP_PKEY_eq().. |
@@ -604,7 +604,7 @@ def yaxis():
p = curplot()
if p is None:
return None
- axis = [obj for obj in p.renderers if isinstance(obj, Axis) and obj.location in ("left", "right")]
+ axis = [obj for obj in p.left + p.right if isinstance(obj, Axis)]
return _list_attr_splat(axis)
def axis():
| [curplot->[curdoc],load_object->[curdoc,cursession],output_server->[curdoc],output_notebook->[output_server],circle_x->[_plot_function],push->[curdoc,cursession],_plot_function->[push,curdoc,cursession,save],circle_cross->[_plot_function],x->[_plot_function],line->[_plot_function],square_cross->[_plot_function],grid->[... | Get the current y - axis object or splattable list of x - axis objects on. | Please create a method that does the job instead of repeating the same code. |
@@ -85,7 +85,7 @@ class Conduit(Package):
# CMake
#######################
# cmake 3.8.2 or newer
- depends_on("cmake@3.8.2:", type='build')
+ depends_on("cmake@3.8.2:3.17.9999", type='build')
#######################
# Python
| [Conduit->[install->[install],create_host_config->[cmake_cache_entry]]] | Creates a single variant object that can be used to build a single non - existent HDF5 - 1. 8. 19. | We can now update this to `3.8.2:3.17.9999,3.18.2:` again :) |
@@ -377,12 +377,13 @@ func TestPollingDeviationChecker_BuffersLogs(t *testing.T) {
func TestPollingDeviationChecker_TriggerIdleTimeThreshold(t *testing.T) {
tests := []struct {
- name string
- idleThreshold models.Duration
- expectedToSubmit bool
+ name string
+ idleTimerDisabled b... | [MustNewTaskType,AddJob,NewFromFloat,DeepEqual,NewStore,ExportedPollIfEligible,RemoveJob,MinimumContractPayment,Stop,MakeDuration,New,Len,SufficientFunds,ExportedSetStoredReportableRoundID,MustHash,Authenticate,MustParseURL,Parallel,NoError,NewStoreWithConfig,HasAccounts,Helper,Mul,Value,MatchedBy,Now,NewConfig,Eventua... | TestPollingDeviationChecker_TriggerIdleTimeThreshold tests that run on a single node. This is a mock. | Why does this need to be so much longer? |
@@ -412,6 +412,10 @@ class TestAddonIndexer(TestCase):
def test_extract_persona(self):
# Override self.addon with a persona.
self.addon = addon_factory(persona_id=42, type=amo.ADDON_PERSONA)
+ # Delete any files so that we can be sure that compat info is entirely
+ # done automatica... | [TestAddonIndexer->[test_extract_attributes->[_extract,expected_fields],test_extract_eula_privacy_policy->[_extract],test_extract_version_and_files->[_extract],test_version_compatibility_with_strict_compatibility_enabled->[_extract],test_extract_persona->[_extract],test_extract_previews->[_extract],test_extract_transla... | Test to extract persona. | I thought you fixed `addon_factory` to not add files for persona type addons? |
@@ -27,9 +27,10 @@ class Super_Admin_Command extends WP_CLI_Command {
* <user>...
* : One or more user IDs, user emails, or user logins.
*/
- public function add( $args, $_ ) {
+ public function add() {
+ $request = \WP_CLI\Request::get_from_argv();
- $users = $this->fetcher->get_many( $args );
+ $users =... | [Super_Admin_Command->[add->[get_many],remove->[get_many]]] | Add a user to the site. | One potential problem is that if something calls this method directly, `$args` don't get considered in `get_positional_args()` |
@@ -37,15 +37,9 @@ class Help_Command extends WP_CLI_Command {
self::show_help( $command );
exit;
}
-
- // WordPress is already loaded, so there's no chance we'll find the command
- if ( function_exists( 'add_filter' ) ) {
- $command_string = implode( ' ', $args );
- \WP_CLI::error( sprintf( "'%s' is n... | [Help_Command->[find_subcommand->[find_subcommand]]] | Find the first command that can be invoked. | Why is this removed? |
@@ -316,7 +316,7 @@ func TestSwarmBuildConfiguration(t *testing.T) {
for _, test := range testCases {
test := test
t.Run(test.desc, func(t *testing.T) {
- t.Parallel()
+ //t.Parallel()
var dockerDataList []dockerData
for _, service := range test.services {
dData := parseService(service, test.ne... | [EqualValues,Itoa,containerFilter,getIPAddress,buildConfiguration,getFrontendRule,Duration,Parallel,NotNil,Errorf,getFrontendName,Run] | expectedBackends tests the expected backends for the given services. TestSwarmTraefikFilter tests that the specified services have the correct number of networks. | could you restore this line. |
@@ -56,7 +56,6 @@ import io.confluent.ksql.physical.PhysicalPlanBuilder;
import io.confluent.ksql.planner.LogicalPlanner;
import io.confluent.ksql.planner.plan.KsqlStructuredDataOutputNode;
import io.confluent.ksql.planner.plan.PlanNode;
-import io.confluent.ksql.util.KsqlConfig;
import io.confluent.ksql.util.KsqlE... | [QueryEngine->[buildLogicalPlans->[info,add,clone,getLeft,getRight,buildQueryLogicalPlan],handleDdlStatement->[create,getStatementText,getStatement,maybeAddFieldsFromSchemaRegistry,isEmpty,KsqlException,execute],getResultDatasource->[schema,KsqlTopic,getSelectItems,get,KsqlStream,field,name],buildPhysicalPlans->[handle... | Package that imports all packages that are part of the Analysis Engine. Creates a QueryEngine for the given query object. | @dhruvilshah3 removed the other instance of this in his PR. We should only merge one of these. |
@@ -26,12 +26,12 @@ spec:
selector:
matchLabels:
app: <%= app.baseName.toLowerCase() %>
- version: "1.0"
+ version: "v1"
template:
metadata:
labels:
app: <%= app.baseName.toLowerCase() %>
- version: "1.0"
+ version: "v1"
spec:
initContainers:
... | [No CFG could be retrieved] | This function returns a representation of the given n - tuple. Check if a database is reachable and if so return it. | any reason to change this? |
@@ -906,6 +906,8 @@ class FileSink(iobase.Sink):
logging.warning(('Exception in _rename_batch. src: %s, '
'dest: %s, err: %s'), src, dest, exception)
exceptions.append(exception)
+ else:
+ logging.info('Rename successful: %s -> %s', src, dest)
... | [TextFileReader->[read_records->[readline],seek_to_true_start_offset->[readline,is_compressed]],_CompressionType->[__ne__->[__eq__]],CompressionTypes->[_CompressionType],FileSink->[close->[close],__init__->[is_valid_compression_type],initialize_write->[ChannelFactory],display_data->[format],finalize_write->[_rename_bat... | Finalize write. Yields final_name_n_shards final_name_n_shards. | Probably should be logging.debug to avoid spamming. |
@@ -72,6 +72,8 @@ type ProvisionConfig struct {
// RegisterFlags adds the flags required to config this to the given FlagSet.
func (cfg *TableManagerConfig) RegisterFlags(f *flag.FlagSet) {
f.BoolVar(&cfg.ThroughputUpdatesDisabled, "table-manager.throughput-updates-disabled", false, "If true, disable all changes to... | [updateTables->[Set,Equals],loop->[Stop],RegisterFlags->[RegisterFlags],Equals] | RegisterFlags registers flags for table manager. | Why do we need both (a boolean flag to enable) and (0 duration to disable) ? |
@@ -1570,7 +1570,7 @@ func TestSetCertDefaults(t *testing.T) {
t.Errorf("expected last IP of master vm from SetDefaultCerts %d, actual %d", expectedLastIP, ips[len(ips)-2])
}
- if cs.Properties.MasterProfile.Count > 1 {
+ if cs.Properties.MasterProfile.HasMultipleNodes() {
expectedILBIP := net.IP{firstMa... | [PutUint32,DeepEqual,IsAvailabilitySets,Activate,NewStringResponse,Diff,IsManagedDisks,setOrchestratorDefaults,SetCustomCloudProfileEnvironment,BoolPtr,Error,RegisterResponder,New,Errorf,HasAvailabilityZones,Logf,IsVirtualMachineScaleSets,Bool,setAgentProfileDefaults,To4,setKubeletConfig,Fatalf,DecodeString,ParseIP,Uin... | Construct a container service object. LastIP returns last IP of master ILB. | Replaced a bunch of manual "is count > 1" implementations with the new method |
@@ -226,6 +226,13 @@ namespace System.Globalization
return null;
}
+ [MethodImpl(MethodImplOptions.AggressiveInlining)]
+ internal static bool IcuIsEnsurePredefinedLocaleName(string name)
+ {
+ Debug.Assert(!GlobalizationMode.UseNls);
+ return Interop.G... | [CultureData->[GetDefaultLocaleName->[GetDefaultLocaleName],GetLocaleName->[GetLocaleName],IcuGetLanguageDisplayName->[IcuGetLocaleInfo],IcuGetTimeFormatString->[IcuGetTimeFormatString],IcuGetLocaleInfo->[IcuGetLocaleInfo]]] | Convert the string to a human - readable string if it is a reserved word. | Does this really need `AggressiveInlining`? This JIT should be able to inline a method that is this simple just fine. |
@@ -47,6 +47,15 @@ func (pc *Client) restCall(method, path string, queryObj, reqObj, respObj interf
return pulumiRESTCall(pc.apiURL, method, path, queryObj, reqObj, respObj, pc.apiToken)
}
+// updateRESTCall makes a REST-style request to the Pulumi API using the given method, path, query object, and request
+// ob... | [CreateStack->[restCall],GetUpdateEvents->[restCall],CreateUpdate->[restCall],ImportStackDeployment->[restCall],ExportStackDeployment->[restCall],GetStackLogs->[restCall],EncryptValue->[restCall],ListStacks->[restCall],DownloadTemplate->[apiCall],DeleteStack->[restCall],DecryptValue->[restCall],DescribeUser->[restCall]... | restCall is the internal method that calls the REST API. | Do we need the `updateAccessToken` parameter since the `Client` struct can now just have an `accessToken` instance? Same feedback for all of the newer API client methods like `PatchUpdateCheckpoint`. It seems strange to require threading through the update access token when we could just set it once when constructing t... |
@@ -339,6 +339,8 @@ define([
* @param {Number} [options.colorBlendAmount=0.5] Value used to determine the color strength when the <code>colorBlendMode</code> is <code>MIX</code>. A value of 0.0 results in the model's rendered color while a value of 1.0 results in a solid color, with any value in-between resulting... | [No CFG could be retrieved] | The object that is returned when the model is picked. The model is drawn relative to terrain. | Remove this line |
@@ -666,7 +666,7 @@ namespace Dynamo.Models
/// </summary>
protected virtual void NodeModified(NodeModel node)
{
-
+ HasUnsavedChanges = true;
}
/// <summary>
| [WorkspaceModel->[SaveAs->[OnWorkspaceSaved],Clear->[ClearNodes,Clear,Dispose],AddNode->[OnNodeAdded,AddNode,OnRequestNodeCentered],SaveInternal->[Save],DeleteModel->[Dispose,RemoveNode],ReloadModel->[Undo],Save->[SaveAs],Log->[Log],Undo->[Undo],NoteModel->[AddNote],AddNote->[OnRequestNodeCentered],DisposeNode->[Dispos... | NodeModified is called when a node is modified. | What if a workspace overrides this method? Wouldn't it make more sense to have a private method that does this? |
@@ -363,6 +363,18 @@ namespace Microsoft.WebAssembly.Diagnostics
StartLocation = new SourceLocation(this, start);
EndLocation = new SourceLocation(this, end);
+
+ foreach (var cattr in methodDef.GetCustomAttributes())
+ {
+ var ctorHan... | [AssemblyInfo->[PopulateEnC->[UpdateEnC],ProcessSourceLink->[ToString]],SourceFile->[HashAlgorithm->[Equals],GetSourceAsync->[CheckPdbHash,ComputePdbHash],ToScriptSource->[ToString],ComputePdbHash->[HashAlgorithm],ToString],SourceId->[TryParse->[TryParse],GetHashCode->[GetHashCode],Equals],DebugStore->[FindBreakpointLo... | Updates the enc method. | is it missing break? |
@@ -111,6 +111,9 @@ public class LifecycleManager extends AbstractModuleLifecycle {
}
private void addCacheDependencyIfNeeded(String cacheStarting, EmbeddedCacheManager cacheManager, Properties properties) {
+ if (!ClusterRegistryImpl.GLOBAL_REGISTRY_CACHE_NAME.equals(cacheStarting)) {
+ cacheMan... | [LifecycleManager->[cacheStopping->[getQueryGroupName]]] | Adds a cache dependency if the cache is not in the default cache. | The `addCacheDependency` will enforce order only during cache stop, but caches are started in parallel. Are the random failures caused by stopping the registry before the indexed/data caches? |
@@ -254,11 +254,13 @@ function item_post(App $a) {
} else {
- // if coming from the API and no privacy settings are set,
- // use the user default permissions - as they won't have
- // been supplied via a form.
+ /*
+ * if coming from the API and no privacy settings are set,
+ * use the user default permi... | [item_post->[get_hostname]] | item post action This function is used to find the post that is a child of the parent of the conversation multi - level threading - preserve the info but re - parent to our single level threading This function is called when a user is redirected to a comment in a contact. | Standards: Please add a space after commas. |
@@ -0,0 +1,8 @@
+package com.baeldung.codecoverage.sonarqubeandjacoco;
+
+
+public class App {
+ public static void main(String[] args) {
+ System.out.println("Hello World!");
+ }
+}
| [No CFG could be retrieved] | No Summary Found. | Use spaces instead of tabs to indent |
@@ -428,15 +428,10 @@ Service_Participant::get_domain_participant_factory(int &argc,
#endif
if (DCPS_debug_level > 0) {
- String version_string = OPENDDS_VERSION;
- const char* const version_metadata = "-" OPENDDS_VERSION_METADATA;
- if (version_metadata[1] != '\0') {
- version_s... | [No CFG could be retrieved] | This function is called to load the configuration file and initialize the domain participant. Open DDS Reactor Task. | Do we want to normalize these to the approach that `be_init.cpp` uses where strings that are known at compile time (and known not have special characters) are directly part of the format string and not a separate parameter? |
@@ -169,7 +169,9 @@ class IAuthenticator(IPlugin):
Authenticator will never be able to perform (error).
:rtype: :class:`list` of
- :class:`acme.challenges.ChallengeResponse`
+ :class:`acme.challenges.ChallengeResponse`,
+ where responses are required to be retu... | [IConfig->[Attribute],AccountStorage->[save->[NotImplementedError],load->[NotImplementedError],find_all->[NotImplementedError]],IPluginFactory->[Attribute],IReporter->[Attribute]] | Perform the given achallenges. | "as corresponding input challenges" might be less confusing |
@@ -31,6 +31,12 @@ deprecate.warn = (oldName, newName) => {
return deprecate.log(`'${oldName}' is deprecated. Use '${newName}' instead.`)
}
+deprecate.warnDefault = (propName, oldDefault, newDefault) => {
+ return deprecate.log(`The default value of '${propName}' is changing from \
+'${oldDefault}' to '${newDefa... | [No CFG could be retrieved] | Deprecated method. Deprecated event. | There's no need to use `\ ` at the end of line. |
@@ -629,6 +629,7 @@ ds_mgmt_join_handler(struct mgmt_join_in *in, struct mgmt_join_out *out)
uint32_t rank;
uint32_t rank_next;
uint32_t map_version;
+ struct server_entry entry = {};
int rc;
rc = ds_mgmt_svc_lookup_leader(&svc, &out->jo_hint);
| [No CFG could be retrieved] | Adds an entry in the list of known server records to the list of known servers. This function is called to start a transaction to find the server record in the database. | just to confirm that the above is same as "= {0}"? |
@@ -93,6 +93,10 @@ module Engine
false
end
+ def rect?
+ false
+ end
+
def visit_cost
0
end
| [Base->[hex->[hex],inspect->[name],id->[id],include,class,attr_accessor,num,edge?],require_relative] | Initialize a new object. | does this need to be in the base? should it only be on nodes? |
@@ -188,9 +188,16 @@ func (d *DockerBuilder) addBuildParameters(dir string) error {
}
envVars := getBuildEnvVars(d.build)
+ first := true
for k, v := range envVars {
- newFileData = newFileData + fmt.Sprintf("ENV %s %s\n", k, v)
+ if first {
+ newFileData += fmt.Sprintf("ENV %s=\"%s\"", k, v)
+ first = fa... | [addBuildParameters->[Join,ReadFile,Sprintf,Lstat,WriteFile,Mode],Build->[addBuildParameters,ParseDockerImageReference,Infof,TempDir,V,dockerBuild,Errorf,Fatalf,fetchSource,GetDockerAuth,NewHelper],dockerBuild->[Join],checkSourceURI->[ValidCloneSpec,Dial,Index,Sprintf,Close,Errorf,Parse,HasPrefix],fetchSource->[Checkou... | addBuildParameters adds build parameters to the dockerfile. | The same problem as with previous, use `k`, don't introduce new vars. |
@@ -93,7 +93,7 @@ d_rank_list_dup(d_rank_list_t **dst, const d_rank_list_t *src)
D_ALLOC_ARRAY(rank_list->rl_ranks, rank_list->rl_nr);
if (rank_list->rl_ranks == NULL) {
- D_FREE_PTR(rank_list);
+ D_FREE(rank_list);
D_GOTO(out, rc = -DER_NOMEM);
}
| [d_rank_list_realloc->[d_rank_list_alloc],d_rank_list_append->[d_rank_list_realloc],d_rank_list_identical->[d_rank_list_sort],uint32_array_to_rank_list->[d_rank_list_alloc],d_rank_list_copy->[d_rank_list_realloc],d_rank_list_del->[d_rank_list_realloc,d_rank_list_find],d_rank_list_dup_sort_uniq->[d_rank_list_dup]] | Duplicate src into dst. | Are we generally trying to use D_FREE instead of D_FREE_PTR? |
@@ -51,6 +51,9 @@ type Allocator interface {
Reset()
}
+// TODO: make enableGlobalTSOEstimation become a config field.
+const enableGlobalTSOEstimation = true
+
// GlobalTSOAllocator is the global single point TSO allocator.
type GlobalTSOAllocator struct {
// for global TSO synchronization
| [Reset->[ResetTimestamp],SetTSO->[resetUserTimestamp],checkSyncedDCs->[NoneOf,Strings,Debug],Initialize->[SyncTimestamp],IsInitialize->[isInitialized],getCurrentTSO->[FastGenByArgs,getTSO,GenerateTimestamp],UpdateTSO->[UpdateTimestamp],GenerateTSO->[getTS,differentiateLogical,resetUserTimestamp,GenerateTS,Warn,Sprintf,... | tso import imports a single point TSO allocator. NewGlobalTSOAllocator creates a new global TSO allocator. | Seem we can't disable it once we start the cluster. It's better to remove it until we add a real switch. |
@@ -55,3 +55,12 @@ def summary_view(request, checkout):
return summary_without_shipping(request, checkout)
else:
return anonymous_summary_without_shipping(request, checkout)
+
+
+@validate_cart
+def login(request, checkout):
+ if request.user.is_authenticated:
+ return redirect('checkou... | [shipping_method_view->[is_valid,TemplateResponse,redirect,ShippingMethodForm],index_view->[redirect],shipping_address_view->[anonymous_user_shipping_address_view,user_shipping_address_view,is_authenticated],summary_view->[is_authenticated,anonymous_summary_without_shipping,validate_shipping_address,summary_without_shi... | Summary view for a single node. | What's the idea behind having a second login page? I would expect at least a docstring with a good explanation of why and how it works. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.