patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -140,7 +140,7 @@ module.exports = options => ({
new ForkTsCheckerWebpackPlugin({ eslint: true }),
new CopyWebpackPlugin([
<%_ if (!reactive && (applicationType === 'gateway' || applicationType === 'monolith')) { _%>
- { from: './node_modules/swagger-ui-dist/*.{js,css,html,png}', to: 'swagger-ui... | [No CFG could be retrieved] | Config for the missing - API - related tasks. Requires JHipster - needle - add - assets - to - webpack - add. | it shouldn't be changed in react as the library version is not upgraded |
@@ -37,7 +37,8 @@ def mock_print(monkeypatch, info_lines):
monkeypatch.setattr(spack.cmd.info.color, 'cprint', _print, raising=False)
-@pytest.mark.skipif(sys.platform == 'win32', reason="Error on Win")
+@pytest.mark.skipif(str(spack.platforms.host()) == 'windows',
+ reason="Install hangs on... | [parser->[ArgumentParser,setup_parser],test_is_externally_detectable->[info,parse_args,next,__iter__],test_info_fields->[info,parse_args],test_it_just_runs->[info],mock_print->[_print->[extend],setattr],skipif,usefixtures,fixture,SpackCommand,parametrize] | Test that the given package has the correct version. Test the info of a package. | Is the reason "Install hangs on windows" accurate or a copy + paste error? Similar for other tests in this file |
@@ -72,7 +72,8 @@ public class ListFTP extends ListFileTransfer {
final PropertyDescriptor port = new PropertyDescriptor.Builder().fromPropertyDescriptor(UNDEFAULTED_PORT).defaultValue("21").build();
final List<PropertyDescriptor> properties = new ArrayList<>();
- properties.add(LISTING_STRAT... | [ListFTP->[getFileTransfer->[getLogger,FTPTransfer],customValidate->[validateProxySpec],getSupportedPropertyDescriptors->[build,add]]] | Replies the list of supported property descriptors. | As mentioned above: I think this should be lower in the list |
@@ -270,6 +270,7 @@ public class SecurityConfiguration {
.pathMatchers("/services/**", "/swagger-resources/**").authenticated()
<%_ } _%>
.pathMatchers("/management/health").permitAll()
+ .antMatchers("/management/health/**").permitAll()
.pathMatchers("/man... | [No CFG could be retrieved] | The application - level and - level middleware. This bean is used to provide a converter for the ID Token. | Are you sure it should not be `pathMatchers` here? |
@@ -853,12 +853,17 @@ CHAKRA_API JsPointerToString(_In_reads_(stringLength) const wchar_t *stringValue
PARAM_NOT_NULL(stringValue);
PARAM_NOT_NULL(string);
+ PERFORM_JSRT_TTD_RECORD_ACTION_WRESULT(scriptContext, scriptContext->GetThreadContext()->TTDLog->RecordJsRTCreateString(scriptContext, ... | [No CFG could be retrieved] | Gets the next unique name in a string. Determines the length of the unique string in the string. | This should be after IsValidCharCount check? |
@@ -6394,7 +6394,7 @@ float getProbabilityOfLevelUp(uint32 SkillValue)
return 0.0f;
}
- std::array bounds{ 115, 135, 160, 190, 215, 295, 315, 355, 425, 450 };
+ std::array<uint32, 10> bounds{ 115, 135, 160, 190, 215, 295, 315, 355, 425, 450 };
std::array<float, 11> dens{ 1.0f, 2.0f, 3.0f, 4.0... | [No CFG could be retrieved] | Get the probability of a skill level up. Checks if a specific skill should be updated based on the probability of the level up skill. | Why are you using the `float` type here? What prevents you from using the `uint32` type |
@@ -9,7 +9,7 @@ describe Users::ConfirmationsController, devise: true do
it 'tracks nil email confirmation token' do
analytics_hash = {
success: false,
- error: "Confirmation token can't be blank",
+ error: 'Confirmation token Please fill in this field.',
user_id: nil,
... | [to,create,days,generate,describe,uuid,before,get,update,current,eq,instance_double,with,patch,it,require,and_return] | missing confirmation tokens expects confirmation token has expired. | How is this error generated? Is it correct? |
@@ -73,6 +73,7 @@ Route::group(['prefix' => 'v0', 'namespace' => '\App\Api\Controllers'], function
Route::put('rules', 'LegacyApiController@add_edit_rule')->name('edit_rule');
Route::delete('rules/{id}', 'LegacyApiController@delete_rule')->name('delete_rule');
Route::post('services/{hostname}... | [group,where,name] | Register routes for legacy API. Get all routes for the Nova API. | Any reason why you added this under the admin middleware? As far as I know you don't need admin in the web interface for oxidized |
@@ -27,12 +27,13 @@ def product_class_list(request):
(pc.pk, pc.name, pc.has_variants, pc.product_attributes.all(),
pc.variant_attributes.all())
for pc in classes.object_list]
+
ctx = {'form': form, 'product_classes': classes}
- return TemplateResponse(
- request, 'dashboard/p... | [attribute_edit->[all,pgettext_lazy,ProductAttribute,ProductAttributeForm,TemplateResponse,redirect,AttributeChoiceValueFormset,success,is_valid,save,get_object_or_404],product_detail->[all,get_gross_price_range,get_availability,none,first,prefetch_related,TemplateResponse,get_object_or_404],attribute_list->[prefetch_r... | View of product class list. | I would remove this empty line (and in other views you've added it as well). It is useful in complex functions but in most of our views it's unnecessary. |
@@ -88,6 +88,7 @@ Seq2SeqEncoder.register("rnn")(_Seq2SeqWrapper(torch.nn.RNN))
Seq2SeqEncoder.register("augmented_lstm")(_Seq2SeqWrapper(AugmentedLstm))
Seq2SeqEncoder.register("alternating_lstm")(_Seq2SeqWrapper(StackedAlternatingLstm))
Seq2SeqEncoder.register("stacked_bidirectional_lstm")(_Seq2SeqWrapper(StackedB... | [_Seq2SeqWrapper->[__call__->[from_params,Params],from_params->[pop_bool,as_dict,PytorchSeq2SeqWrapper,ConfigurationError,_module_class]],_Seq2SeqWrapper,debug,getLogger,is_available,register] | PytorchSeq2SeqWrapper for all - torch - seq2 - encoder. | IMHO `BidirectionalTransformerEncoder` (and `bidirectional_transformer`) is a very misleading name for this encoder as it is different then the standard bidirectional transformer most people are familiar with. This encoder applies LM masking in both directions, so something like `BidirectionalLanguageModelTransformer` ... |
@@ -429,7 +429,7 @@ class Protocol < ActiveRecord::Base
if kw.blank?
kw = ProtocolKeyword.create(
name: kw_name,
- organization: self.organization
+ team: self.team
)
end
self.protocol_keywords << kw
| [Protocol->[deep_clone->[clone_contents],destroy_contents->[space_taken],clone_contents->[deep_clone_assets],space_taken->[space_taken],in_repository?->[in_repository_active?],load_from_repository->[clone_contents],update_parent->[clone_contents],update_from_parent->[clone_contents],deep_clone_my_module->[new_blank_for... | Update the protocol keywords with the given list of keywords. | Redundant self detected. |
@@ -63,10 +63,10 @@ module FirstTimeDataGenerator
for i in 1..5
samples << Sample.create(
name: sample_name + i.to_s,
- organization: org,
+ team: team,
user: user,
- sample_type: rand < 0.8 ? pluck_random(org.sample_types) : nil,
- sample_group: rand < 0.8 ? pl... | [generate_step_comment->[generate_random_time],generate_module_comment->[generate_random_time],generate_project_comment->[generate_random_time],generate_result_comment->[generate_random_time],generate_module_steps->[generate_random_time]] | Seed demo data from a user - private organization. Creates a new project module group and a new project module group. Creates all the modules that are responsible for generating the necessary information. | Line is too long. [83/80] |
@@ -69,5 +69,6 @@ setup(
'azure-core<2.0.0,>=1.14.0',
"isodate>=0.6.0",
"six>=1.11.0",
+ "typing-extensions>=3.7.4.3",
]
)
| [find_packages,setup,search,replace,read,format,RuntimeError,join,open] | Microsoft Azure Core. | qq @annatisch: is this the right place to put this? or should this be elsewhere? |
@@ -40,7 +40,8 @@ class Api::V0::ApiController < ApplicationController
@user = User.find(doorkeeper_token.resource_owner_id)
return error_unauthorized unless @user
elsif request.headers["api-key"]
- authenticate_with_api_key!
+ @user = authenticate_with_api_key
+ return error_unauthori... | [authenticate!->[authenticate_with_api_key!,headers,find,resource_owner_id],authenticate_with_api_key!->[headers,secure_compare,user,secret,find_by],error_not_found->[render],authenticate_with_api_key_or_current_user!->[authenticate_with_api_key!,headers],error_unprocessable_entity->[render],error_unauthorized->[render... | authenticate! - checks if the current user has a lease and if so returns the user. | There's now two `#authenticate_with_api_key_or_current_user`? see line:59 |
@@ -567,9 +567,9 @@ static void makeFastFace(const TileSpec &tile, u16 li0, u16 li1, u16 li2, u16 li
}
f32 abs_scale = 1.0;
- if (scale.X < 0.999 || scale.X > 1.001) abs_scale = scale.X;
- else if(scale.Y < 0.999 || scale.Y > 1.001) abs_scale = scale.Y;
- else if(scale.Z < 0.999 || scale.Z > 1.001) abs_scale ... | [getInteriorLight->[getInteriorLight], m_minimap_mapblock->[final_color_blend,get_sunlight_color],void->[getNodeTile,getFaceLight,getSmoothLight],append->[append],final_color_blend->[final_color_blend,get_sunlight_color],getNodeTile->[getNodeTileN],getFaceLight->[getFaceLight],fill->[fillBlockDataBegin,fillBlockData],a... | This method creates a fast face from a vertex of a given tile. This function is used to compute the unnormalized state of a node in the tree. - - - - - - - - - - - - - - - - - - region video - specific functions PRIVATE METHODS of the NestedCollection. | can you add f to float values please ? |
@@ -48,6 +48,13 @@ type PerTeamKey struct {
EncKID KID `codec:"encKID" json:"encKID"`
}
+type TeamMembers struct {
+ Owners []string `codec:"owners" json:"owners"`
+ Admins []string `codec:"admins" json:"admins"`
+ Writers []string `codec:"writers" json:"writers"`
+ Readers []string `codec:"readers" json:"read... | [TeamGet->[Call],TeamCreate->[Call],TeamGet,NewTypeError,TeamCreate] | IMPORTS - Import a package containing all of the types of the n - th PerTeam Create - creates a new object for the ID. | does this conflict with what miles was doing? |
@@ -1,7 +1,7 @@
module CastCommon
extend ActiveSupport::Concern
- DIFF_FIELDS = %i(person_id name part)
+ DIFF_FIELDS = %i(person_id name part sort_number)
PUBLISH_FIELDS = DIFF_FIELDS + %i(work_id)
included do
| [to_diffable_hash->[delete_if,each_with_object,send,blank?],included,belongs_to,validates,extend] | Creates a diffable hash from the object. | Freeze mutable objects assigned to constants. |
@@ -86,11 +86,13 @@ class ExamTemplatesController < ApplicationController
flash_message(:success, t('exam_templates.generate.generate_job_started',
exam_name: exam_template.assignment.short_identifier))
current_job = exam_template.generate_copies(copies, index)
+ current_job.... | [ExamTemplatesController->[destroy->[destroy],fix_error->[fix_error],update->[update]]] | This action generates a in a template. | Space before the `}` |
@@ -9,6 +9,7 @@ import (
"time"
"github.com/alecthomas/units"
+ errors2 "github.com/pkg/errors"
"github.com/thanos-io/thanos/pkg/store"
"github.com/cortexproject/cortex/pkg/storage/backend/azure"
| [String->[String],RegisterFlags->[RegisterFlags],Validate->[Validate]] | Imports a single config object from Centralized Messages. YAML representation of an unknown configuration. | Can we remove the import of `"errors"` in this file so that we don't have to name it `errors2`? |
@@ -252,7 +252,7 @@ class EntityGenerator extends BaseBlueprintGenerator {
},
validateReactiveCompatibility() {
- if (this.context.reactive && !['mongodb', 'cassandra', 'couchbase', 'neo4j'].includes(this.context.databaseType)) {
+ if (this.context.reactive && !... | [No CFG could be retrieved] | Creates a shared config object for the entity generator. Missing context. | All database are now supported, the `validateReactiveCompatibility` function can be removed. |
@@ -633,7 +633,7 @@ public class KafkaIndexTaskClient
}
catch (Exception e) {
log.warn(e, "Exception while sending request");
- throw e;
+ throw new RuntimeException(e);
}
}
}
| [KafkaIndexTaskClient->[getStatusAsync->[call->[getStatus]],pause->[pause],resumeAsync->[call->[resume]],getStartTimeAsync->[call->[getStartTime]],getCurrentOffsetsAsync->[call->[getCurrentOffsets]],getCheckpointsAsync->[getCheckpoints],setEndOffsetsAsync->[call->[setEndOffsets]],submitRequest->[TaskNotRunnableExceptio... | Submits a request to the chat service for the given task. Gets a from the response. This method is called by the submitRequest method to send a request to the server and check. | doh... another `Exception` catch |
@@ -102,7 +102,10 @@ public class DefaultDataContainer implements DataContainer {
default:
throw new IllegalArgumentException("No such eviction strategy " + strategy);
}
- entries = new BoundedConcurrentHashMap<Object, InternalCacheEntry>(maxEntries, concurrencyLevel, eviction, evicti... | [DefaultDataContainer->[size->[size],boundedDataContainer->[DefaultDataContainer],EntryIterator->[next->[next],hasNext->[hasNext]],ValueIterator->[hasNext->[hasNext]],keySet->[keySet],unBoundedDataContainer->[DefaultDataContainer],DefaultEvictionListener->[onEntryRemoved->[remove],onEntryEviction->[onEntryEviction]],Va... | Initializes the cache manager. | shouldn't you use the constructor with `concurrencyLevel`? |
@@ -194,7 +194,7 @@ class TorchAgent(Agent):
padded_ys[i, :y.shape[0]] = y
ys = padded_ys
- return Batch(xs, ys, labels, valid_inds)
+ return Batch(xs, torch.LongTensor(x_lens), ys, labels, valid_inds)
def unmap_valid(self, predictions, valid_inds, batch_size):
... | [TorchAgent->[shutdown->[save],save->[save],load->[load],maintain_dialog_history->[parse]]] | Maps a batch of valid observations from an unchecked batch where a valid observation is one that This function creates a batch of the n - tuple of tensors that can be used to train. | I'd prefer this to be put into a longtensor earlier in the function |
@@ -257,11 +257,7 @@ SimpleProcStat::SimpleProcStat(const std::string& pid) {
this->system_time = details.at(12);
this->nice = details.at(16);
this->threads = details.at(17);
- try {
- this->start_time = TEXT(AS_LITERAL(BIGINT_LITERAL, details.at(19)) / 100);
- } catch (const boost::bad_lexica... | [deletedMatchesInode->[stat],genProcess->[getOnDisk],genProcesses->[getProcList,genProcess],genProcessNamespaces->[getProcList,genNamespaces],genProcessEnvs->[getProcList,genProcessEnvironment],getOnDisk->[deletedMatchesInode],genProcessMemoryMap->[genProcessMap,getProcList]] | SimpleProcStat - Simple proc stat. This method is called to set the resident_size and total_size fields from the. | Same problem with exceptions from `std::stol`. |
@@ -4403,13 +4403,13 @@ std::string GUIFormSpecMenu::getNameByID(s32 id)
}
-FormspecFieldType GUIFormSpecMenu::getTypeByID(s32 id)
+GUIFormSpecMenu::FieldSpec *GUIFormSpecMenu::getSpecByID(s32 id)
{
for (FieldSpec &spec : m_fields) {
if (spec.fid == id)
- return spec.ftype;
+ return &spec;
}
- return f... | [parseLabel->[getElementBasePos,getRealCoordinateBasePos],parseList->[getElementBasePos,getRealCoordinateBasePos],parseScrollBar->[getElementBasePos,getRealCoordinateGeometry,getRealCoordinateBasePos],parseItemImageButton->[getElementBasePos,getRealCoordinateGeometry,getRealCoordinateBasePos],parseElement->[parseLabel,... | Get the type of the field with the given ID. | should return const pointer |
@@ -251,6 +251,10 @@ func (k *kubernetesAnnotator) Run(event *beat.Event) (*beat.Event, error) {
if !k.kubernetesAvailable {
return event, nil
}
+ if kubernetesMetadataExist(event) {
+ k.log.Debug("Skipping add_kubernetes_metadata processor as kubernetes metadata already exist")
+ return event, nil
+ }
index... | [init->[GetDefaultResourceMetadataConfig,GetKubernetesClient,IsInCluster,AddEventHandler,Do,addPod,Empty,removePod,NewWatcher,DiscoverKubernetesNode,GetPodMetaGen,GetName,Start,Errorf,GetNamespace,Getenv,updatePod,Debugf],addPod->[GetName,set,GetNamespace,GetMetadata,Debugf],removePod->[GetIndexes,delete],Close->[stop,... | Run runs the annotation on the given event. | This will be reporting the log for every single event, means that even if it is in `debug` level it could become quite overwhelming. |
@@ -371,6 +371,17 @@ define([
* @default false
*/
this.debugShowBoundingVolume = defaultValue(options.debugShowBoundingVolume, false);
+
+ this._removeEventFunc = undefined;
+ if (defined(this._globe)) {
+ var that = this;
+ this._removeEventFunc = this._... | [No CFG could be retrieved] | Displays the number of labels in the bounding sphere. The label that was added to the collection. | Are we sure about this name? Nothing is being removed. |
@@ -36,9 +36,12 @@ public class MathJaxClozeTest extends RobolectricTest {
assertEquals(original_s, Template.removeFormattingFromMathjax(original_s, "4"));
assertEquals(original_s, Template.removeFormattingFromMathjax(original_s, "5"));
- final String escaped_s = "{{c1::ok}} \\(2^2\\) {{C2::n... | [MathJaxClozeTest->[removeFormattingFromMathjax->[removeFormattingFromMathjax],textContainsMathjax->[textContainsMathjax]]] | Tests if there is a bug in Mathjax that removes formatting from the notes. Assert that the list of cards is empty. | It looks like before my PR, this actually behaved differently than expected (based on upstream Anki code). The function is only supposed to add the upper-case C to the currently active Cloze deletion - not to other Cloze deletions. This is also wrong because the "not ok" Cloze deletion is not part of MathJax inline/dis... |
@@ -24,11 +24,12 @@ import org.apache.druid.query.filter.BloomKFilter;
import org.apache.druid.segment.ColumnValueSelector;
import javax.annotation.Nullable;
+import java.nio.ByteBuffer;
-public class BloomFilterAggregateCombiner extends ObjectAggregateCombiner<BloomKFilter>
+public class BloomFilterAggregateComb... | [BloomFilterAggregateCombiner->[reset->[fold],fold->[getObject,merge,BloomKFilter]]] | Creates an aggregate combiner which combines two BloomKFilters. Get the object of the object. | AggregateCombiner is only used at ingestion time AFAIK. Since this aggregator isn't meant to be used at ingestion time, you might as well delete this and make `makeAggregateCombiner` throw an UnsupportedOperationException. |
@@ -468,8 +468,8 @@ class Optimizer(object):
if isinstance(self._learning_rate, float):
return self._learning_rate
- elif isinstance(self._learning_rate, _LearningRateEpochDecay):
- step_lr = self._learning_rate()
+ elif isinstance(self._learning_rate, _LRScheduler):
+ ... | [Optimizer->[apply_gradients->[_create_optimization_pass],step->[_apply_optimize],state_dict->[state_dict],_create_param_lr->[_global_learning_rate],_apply_optimize->[apply_gradients,_create_optimization_pass],_create_optimization_pass->[_update_param_device_map,_append_optimize_op,_finish_update,_create_accumulators,_... | Get learning rate of the current step. Returns the last non - zero value if the current learning rate or the learning rate is not. | should be self._learning_rate() |
@@ -975,12 +975,17 @@ int
bio_iod_post(struct bio_desc *biod)
{
struct bio_dma_buffer *bdb;
+ D_DEBUG(DB_IO,"biod->bd_buffer_prep %d", (int)biod->bd_buffer_prep);
if (!biod->bd_buffer_prep)
- return -DER_INVAL;
+ {
+ D_DEBUG(DB_IO, "here");
+ return -DER_INVAL;
+ }
/* No more actions for SCM IOVs */
... | [No CFG could be retrieved] | finds the first non - zero object in the buffer list that can be done by the finds the first object in the bio tree that matches the name specified by the user. | (style) space required after that ',' (ctx:VxV) |
@@ -242,7 +242,9 @@ public class StreamerUtil {
properties.put(option.key(), option.defaultValue());
}
}
- return new TypedProperties(properties);
+ TypedProperties typeProps = new TypedProperties();
+ typeProps.putAll(typeProps);
+ return typeProps;
}
public static void checkRe... | [StreamerUtil->[getHoodieClientConfig->[getHoodieClientConfig],getSourceSchema->[getSourceSchema],createWriteClient->[getHadoopConf,getHoodieClientConfig],getTablePath->[getTablePath],initTableIfNotExists->[getHadoopConf],getHadoopConf->[getHadoopConf]]] | This method is used to convert Flink configuration to TypedProperties. | hi, @hk-lrzy thanks for your contribution. There might be a mistake here , do you mean ` typeProps.putAll(properties)`? BTW, I tried this method, it seems ok? you can try `org.apache.hudi.common.config.TypedProperties#getString(java.lang.String)`, the value you set do exists. the problem might be the `toString()` metho... |
@@ -34,11 +34,13 @@ class Graphviz(AutotoolsPackage):
version('2.38.0', '5b6a829b2ac94efcd5fa3c223ed6d3ae')
+ # Swig can be enabled on it's own, though it doesn't do much. It
+ # will also be enabled if any of the languages are enabled.
+ variant('swig', default=False,
+ description='Enabl... | [Graphviz->[configure_args->[append,copyfile,SpackException],variant,depends_on,version]] | Creates a object with all of the possible values set to true. Magic number of optional language bindings. | I wonder whether or not we should just remove this variant. I don't want someone to install `graphviz~swig+python` and find that it was built with swig support. Thoughts? |
@@ -158,7 +158,10 @@ export class AmpSlideScroll extends BaseCarousel {
// (which is at scrollLeft 0) when slide 0 is requested - for all other
// instances we show the second slide (middle slide at
// scrollLeft = slide's width).
- const newScrollLeft = (newIndex == 0) ? 0 : this.slideWidth_;
+ le... | [No CFG could be retrieved] | Hides rest of the slides that are not needed. Remove the shoWN_CSS_CLASS from the list of slides. | `hasLooping_ && noOfSlides == 1` still means that `newScrollLeft == 0` |
@@ -157,7 +157,6 @@ namespace Dynamo.PackageManager
private bool ExecuteTermsOfUseCall(bool queryAcceptanceStatus)
{
- return true;
return FailFunc.TryExecute(() =>
{
var request = new TermsOfUse(queryAcceptanceStatus);
| [PackageManagerClient->[GetKnownHosts->[content,client,TryExecute],PackageUploadHandle->[StartNew,Publish,NewRequestBody],DoesCurrentUserOwnPackage->[Any,Name,GetPackageMaintainers,VersionName,Equals],SetTermsOfUseAcceptanceStatus->[ExecuteTermsOfUseCall],ListAll->[ByEngine,content,client,TryExecute],PackageVersion->[N... | Execute Terms Of Use call. | I noticed your base is wrong right away after seeing this. I would try to cherry-pick your changes into a clean branch based on top of master |
@@ -11,9 +11,11 @@ class RPlogr(RPackage):
'LinkingTo: plogr' to 'DESCRIPTION', and '#include <plogr.h>'
in your C++ modules to use it."""
- homepage = "https://cran.r-project.org/package=plogr"
- url = "https://cran.r-project.org/src/contrib/plogr_0.2.0.tar.gz"
- list_url = "https://cran.r-pr... | [RPlogr->[version]] | LinkingTo - LinkingTo - LinkingTo - LinkingTo - Linking. | Suggested, not required, remove |
@@ -483,6 +483,7 @@ common_op_parse_hdlr(int argc, char *argv[], struct cmd_args_s *ap)
{"user", required_argument, NULL, 'u'},
{"group", required_argument, NULL, 'g'},
{"principal", required_argument, NULL, 'P'},
+ {"name", required_argument, NULL, 'n'},
{NULL, 0, NULL, 0}
};
int rc;
| [int->[obj_op_parse,D_GOTO,tobytes,uuid_is_null,cont_set_attr_hdlr,cont_get_acl_hdlr,cmd_args_print,cont_delete_acl_hdlr,uuid_generate,strdup,ARGS_VERIFY_PUUID,cont_list_attrs_hdlr,cont_create_hdlr,cont_update_acl_hdlr,getopt_long,daos_prop_free,pool_query_hdlr,cont_get_prop_hdlr,daos_pool_connect,fprintf,cont_get_attr... | Parse the arguments of a command - line option - set and return the values of the option - - - - - - - - - - - - - - - - - - Parse command - line options and parse resource - related objects. optarg - optarg for the option - - - - - - - - - - - - - - - - - - parse options that are not set at the start of create time if... | Some option name reflecting the fact it is a property could be better, like for attr ? |
@@ -229,7 +229,10 @@ int dmic_set_config_nhlt(struct dai *dai, void *spec_config)
return -EINVAL;
}
- for (n = 0; n < num_fifos; n++) {
+ for (n = 0; n < DMIC_HW_FIFOS_MAX; n++) {
+ if (!(channel_ctrl_mask & (1 << n)))
+ continue;
+
val = *(uint32_t *)p;
out_control[n] = val;
bf1 = OUTCONTROL0_TIE_GE... | [dmic_get_hw_params_nhlt->[dai_get_drvdata],int->[OUTCONTROL0_OF_GET,dai_get_drvdata,OUTCONTROL0_IPM_SOURCE_2_GET,MIC_CONTROL_PDM_CLK_EDGE_GET,OUTCONTROL0_IPM_SOURCE_1_GET,OUTCONTROL0_IPM_SOURCE_3_GET,OUTCONTROL0_IPM_GET,OUTCONTROL0_IPM_SOURCE_4_GET,FIR_CONTROL_A_STEREO_GET,ipm_source_to_enable,dai_err],dmic_set_config... | This function is used to set the NHLT configuration for a DMI. This function is called to set the NHLT configuration in the DMIC. - - - - - - - - - - - - - - - - - - Set the NHLT configuration registers. | actually do we need this loop - do we need to verify both FIFOs? Shouldn't we only verify the one for `dai->index`? |
@@ -11,6 +11,7 @@ namespace Dynamo.Extensions
public ExtensionCommandExecutive(DynamoModel model)
{
dynamoModel = model;
+ //TODO cleanup.
MessageLogged += (message) => { dynamoModel.Logger.Log(message); };
}
| [ExtensionCommandExecutive->[ExecuteCommand->[ExecuteCommand]]] | Execute a command in the DynamoDb. | Is this something you still need to work on? If not please don't add it, otherwise we'll keep piling up these smells. |
@@ -10,17 +10,7 @@ namespace System.Text.Json.Nodes
{
public partial class JsonObject : IDictionary<string, JsonNode?>
{
- private const int ListToDictionaryThreshold = 9;
-
- private Dictionary<string, JsonNode?>? _dictionary;
- private List<KeyValuePair<string, JsonNode?>>? _list;
-
- ... | [JsonObject->[SetNode->[Add,CreateList],ContainsNode->[ContainsKey,CreateList],TryRemoveNode->[TryGetValue,Remove,CreateList],VerifyListItemMissing->[ContainsNode],AddNode->[Add],Add->[Add],FindNode->[CreateList],CreateList->[CreateStringComparer,Add],TryGetValue->[TryGetValue],Remove->[Remove]]] | Creates a new object - level object which contains all the properties of a JSON object. - An element with the same property name already exists in the JSON object. | nit: could we call this `_propertyDictionary`? |
@@ -6,8 +6,9 @@
*/
package org.mule.runtime.core.internal.util;
+import static java.lang.Boolean.*;
+import static java.lang.System.getProperty;
import static org.apache.commons.lang3.SystemUtils.JAVA_VENDOR;
-
import org.mule.runtime.core.api.config.MuleManifest;
import org.mule.runtime.core.api.util.SystemUti... | [JdkVersionUtils->[isRecommendedJdkVersion->[createJdkVersionRanges,getRecommendedJdks,getJdkVersion],createJdkVersionRanges->[JdkVersionRange],isJdkInRange->[contains],isJdkAboveRange->[isUnder],isSupportedJdkVersion->[getSupportedJdks,createJdkVersionRanges,getJdkVersion],JdkVersionRange->[contains->[compareTo],isUnd... | Creates a new version object from a string. The version of the jdk package is the last group of the version string. | explicitly import, no * |
@@ -744,10 +744,14 @@ foreach ($ports as $port) {
$fields['ifOutErrors_rate'] = $port['ifOutErrors_rate'];
$fields['ifInOctets_rate'] = $port['ifInOctets_rate'];
$fields['ifOutOctets_rate'] = $port['ifOutOctets_rate'];
+ $fields['ifInBits'] = $port['stats']['ifInBits_rate'];
+ $... | [addDataset] | Updates the data fields of all the NICs in the RRD file. Update the network interface tags and the PAgP. | Why are these needed? If you want bits, you can just take ifOutOctets_rate / 8 when graphing the data. |
@@ -1462,7 +1462,10 @@ describe('browser-window module', function () {
describe('window.webContents.executeJavaScript', function () {
var expected = 'hello, world!'
+ var expectedErrorMsg = 'woops!'
var code = '(() => "' + expected + '")()'
+ var asyncCode = '(() => new Promise(r => setTimeout(() =... | [No CFG could be retrieved] | The main function of the script. executes after page load. | Maybe we should switch these two new code strings and the existing `code` variable to use template strings for clarity. |
@@ -342,6 +342,8 @@ def _create_order(
"""
from ..order.utils import add_gift_card_to_order
+ Allocation.objects.select_for_update(of=("self",))
+
order = Order.objects.filter(checkout_token=checkout.token).first()
if order is not None:
return order
| [_process_payment->[release_voucher_usage],complete_checkout->[_process_payment,_create_order,release_voucher_usage,_get_order_data,_prepare_checkout],_prepare_order_data->[_process_user_data_for_order,_create_lines_for_order,_process_shipping_data_for_order,_get_voucher_data_for_order,_validate_gift_cards],_create_lin... | Create an order from the given order_data and user. Missing order object - send the order confirmation email and the staff order confirmation. | Have you tried locking allocation inside `allocate_stocks`? This is the function that is supposed to handle that, so it would be nice to have this logic there. |
@@ -236,6 +236,14 @@ if (empty($reshook))
}
}
+ foreach ($amounts as $key => $value) // How payment is dispatch
+ {
+ $invoice = new Facture($db);
+ $invoice->fetch($key);
+ if ($invoice->paye) unset($amounts[$key]);
+
+ }
+
if (! empty($conf->b... | [fetch,addPaymentToBank,create,formconfirm,fetch_object,getSommePaiement,jdate,select_date,getNomUrl,rollback,begin,initHooks,select_comptes,load,plimit,getSumCreditNotesUsed,transnoentities,executeHooks,select_types_paiements,close,free,query,trans,num_rows,fetch_thirdparty,commit,getSumDepositsUsed] | Create a new payment line. Create a new invoice payment and add it to the bank. | May be a warning report would be better ? setEventMessages(..., ..., 'warnings'); If we just clean, it mean, user may ask a payment of 100 euros on 4 invoices of 25, and at the end dolibarr record only 75 euros because the invoice 4 was already paid. Users has made a check of Also sometimes, we pay twice. it was an err... |
@@ -0,0 +1,15 @@
+using System;
+using System.Collections.Generic;
+using System.Linq;
+using System.Runtime.InteropServices;
+using System.Text;
+
+namespace Microsoft.Xna.Framework.Internal {
+ public static class UnsafeExtensions {
+ public static IntPtr AddressWithOffset (this GCHandle handle, int offset... | [No CFG could be retrieved] | No Summary Found. | I suspect this should technically be `long offsetInBytes` as that is what `ToInt64()` returns. See the note below first. |
@@ -688,6 +688,15 @@ public class KafkaIO {
private Instant curTimestamp;
private Iterator<PartitionState> curBatch = Collections.emptyIterator();
+ private final Counter messagesConsumed = Metrics.counter("io", "messagesConsumed");
+ private final Counter bytesConsumed = Metrics.counter("io", "bytesC... | [KafkaIO->[TypedWithoutMetadata->[expand->[apply]],KafkaWriter->[setup->[getProducerFactoryFn,apply],teardown->[close],processElement->[getTopic],getKeyCoder,getProducerConfig,getValueCoder],UnboundedKafkaSource->[generateInitialSplits->[getConsumerConfig,getTopics,build,apply,getTopicPartitions],validate->[validate],g... | Validates the input. The offsetConsumer is used to consume the offset from the offsetQueue. | Since the metrics type currently supported are `Counter` and `Distribution`, I used `Distribution` for backlog metrics. But since the most important thing to monitor regarding backlog is the current backlog, I believe something more along the lines of Codahale's `Gauge` is appropriate here. @bjchambers WDYT? Should I o... |
@@ -317,10 +317,9 @@ class Yoast_Form {
$help_class = ! empty( $help ) ? ' switch-container__has-help' : '';
echo "<div class='switch-container$help_class'>",
- "<span class='switch-light-visual-label'>{$label}</span>" . $help,
+ "<span class='switch-light-visual-label' id='{$id}'>{$label}</span>" . $help,
... | [Yoast_Form->[checkbox->[label],textinput->[label],index_switch->[toggle_switch],textarea->[label],radio->[label,legend],get_disabled_note->[is_control_disabled],show_hide_switch->[toggle_switch],media_input->[label],file_upload->[label,hidden],select->[label]]] | Renders a light switch Renders the n - block block page that is used to show the n - block block header. | When touching this, please use the double quotes on HMTL attributes for consistency. |
@@ -82,6 +82,11 @@ class Git(Storage):
"Please provide only one of the following parameters: `branch_name`, `tag`, `commit`"
)
+ if repo is None and git_clone_url_secret_name is None:
+ raise ValueError(
+ "One of `repo` or `git_clone_url_secret_name` mus... | [Git->[git_clone_url->[Secret],git_token_secret->[str,Secret],add_flow->[ValueError,format],__init__->[bool,split,any,sum,super,ValueError,warning],get_flow->[ValueError,TemporaryGitRepo,join,extract_flow_from_file]]] | Initialize a Secret object. The organization that owns the node_id. | "Either" makes more sense to me than "One of" since there are only two options, but I don't feel strongly. |
@@ -476,13 +476,10 @@ namespace Dynamo.Engine
{
string fullLibraryName = library;
- if (!pathManager.ResolveLibraryPath(ref fullLibraryName))
- return;
-
string migrationsXMLFile = Path.Combine(Path.GetDirectoryName(fullLibraryName),
Path.G... | [LibraryServices->[AddAdditionalAttributesToNode->[FunctionSignatureNeedsAdditionalAttributes],AddAdditionalElementsToNode->[FunctionSignatureNeedsAdditionalElements],ImportLibrary->[UpdateLibraryCoreData],TryGetFunctionGroup->[CanbeResolvedTo],PopulatePreloadLibraries->[LoadLibraryMigrations],PopulateBuiltIns->[AddBui... | LoadLibraryMigrations loads the migrations from the specified library. add names to priorNameHints if any. | Built in nodes also don't have assembly, that they came from. That's why `ResolveLibraryPath` won't give any result. |
@@ -439,6 +439,8 @@ class XmlMaterialProfile(InstanceContainer):
meta_data["base_file"] = self.id
meta_data["status"] = "unknown" # TODO: Add material verfication
+ global_setting_values = {}
+
inherits = data.find("./um:inherits", self.__namespaces)
if inherits is not None... | [_indent->[_indent],XmlMaterialProfile->[_resolveInheritance->[_resolveInheritance],setMetaDataEntry->[setMetaDataEntry],_combineElement->[_createKey,_combineElement],_mergeXML->[_expandMachinesXML],setDirty->[setDirty],setName->[setName],deserialize->[xmlVersionToSettingVersion,_resolveInheritance,XmlMaterialProfile,_... | Deserialize a serialized object into this object. Get all the meta data for a given object. This method copies the contents of this object into a new object. Add a new hotend material to this profile. | Global?! You should be changing only the settings of the extruder in which this material is loaded! This is either a bug or a rather unfortunate name for a variable.... Or is it? |
@@ -283,8 +283,10 @@ class ModelChatResultsCompiler(AbstractTurnAnnotationResultsCompiler):
f'Got long dialogue of {len(data["dialog"])} utterances, hit id: {info_dict["hit_id"]}, model_nickname: {model_nickname}.'
)
- dialog_has_problems = False
+ ... | [ModelChatResultsCompiler->[setup_args->[super,add_argument],compile_results->[all,find,sum,to_csv,DataFrame,join,enumerate,d,int,sort_values,extend,load,count,df,problem_counts,append,print,strftime,len,sorted,now,ValueError,items,open,check_messages,average,split,fullmatch,isdir,listdir],__init__->[AcceptabilityCheck... | Compile the results of a single chunk of a block. Check if a n - word message is missing from the dialog. If it is block the Check if a single is present in the HIT. Add missing missing values to the df. | As a note, I'm finding the numerous portions that are gated by `use_problem_buckets` throughout to be somewhat hard to follow. In this case, we're even creating variable to be used by other scopes only if the attribute is set. It could be that the overall `compile_results()` code is rather monolithic, so I have a hard ... |
@@ -28,7 +28,13 @@ $yform->light_switch( 'enablexmlsitemap', __( 'XML sitemap functionality', 'word
$tabs = new WPSEO_Option_Tabs( 'sitemaps' );
$tabs->add_tab( new WPSEO_Option_Tab( 'general', __( 'General', 'wordpress-seo' ), array( 'video_url' => 'https://yoa.st/screencast-sitemaps' ) ) );
-$tabs->add_tab( new W... | [admin_header,add_tab,admin_footer,light_switch,display] | Displays the Yoast administration header and the options for the Sitemap Fires at the end of XML Sitemaps configuration form. | It it possible to use WPSEO_Options::get_option() instead of get_all(). It seems to only be used for disable-author? |
@@ -249,7 +249,9 @@ export class SubscriptionService {
user().assert(this.pageConfig_, 'Page config is null');
if (this.doesViewerProvideAuth_) {
- return this.delegateAuthToViewer_();
+ this.delegateAuthToViewer_();
+ this.startAuthorizationFlow_();
+ return;
}
... | [No CFG could be retrieved] | Fetches entitlements from the platform and stores them in the platform store. Get product id and publication id for a given page. | Overall this makes sense. But we can't actually activate the local platform. We are expecting all paywall features to be provided by the viewer in this scenario. The grant state stuff is good though. |
@@ -41,7 +41,7 @@ const skip = process.platform !== 'linux' || !process.env.DBUS_SYSTEM_BUS_ADDRES
before((done) => {
logindMock.on('MethodCalled', onceMethodCalled(done))
// lazy load powerMonitor after we listen to MethodCalled mock signal
- powerMonitor = require('electron').remote.powerMonit... | [No CFG could be retrieved] | describe - powerMonitor On Windows the OnWindows console will emit the event PrepareForSleep. | @tarruda Is it required to lazy initialize the module ? I was hoping we can just initialize the module only once for all the specs here. |
@@ -235,6 +235,15 @@ class Paraview(CMakePackage, CudaPackage):
'-DMPI_Fortran_COMPILER:PATH=%s' % spec['mpi'].mpifc
])
+ if '+shared' in spec:
+ cmake_args.extend([
+ '-DPARAVIEW_BUILD_SHARED_LIBS:BOOL=ON'
+ ])
+ else:
+ cmak... | [Paraview->[cmake_args->[nvariant_bool->[variant_bool],nvariant_bool,variant_bool]]] | Populate cmake arguments for ParaView. Add flags to the list of commands to use for the next version of the system. Add command line options to cmake_args if is not set. | If you're only adding a single string, you can use `append()` instead of `extend([])` |
@@ -1140,11 +1140,12 @@ UI.notifyFocusLeft = function () {
* @param {string} [login] current login
*/
UI.updateAuthInfo = function (isAuthEnabled, login) {
+ let showAuth = isAuthEnabled && UIUtil.isAuthenticationEnabled();
let loggedIn = !!login;
- Toolbar.showAuthenticateButton(isAuthEnabled);
+ ... | [No CFG could be retrieved] | Displays a dialog with a message to show if the user has focus on the UI and if onAvailableDevicesChanged - This function is called when the list of available devices is changed. | Why do you get rid of isAuthEnabled and replace it by showAuth? isAuthEnabled is set with a other variables and events in mind and should NOT be replaced by a merely UI property. Have a look at conference.js: room.on( ConferenceEvents.AUTH_STATUS_CHANGED, function (authEnabled, authLogin) { APP.UI.updateAuthInfo(authEn... |
@@ -13,6 +13,7 @@ import (
"code.gitea.io/gitea/cmd"
"code.gitea.io/gitea/modules/log"
"code.gitea.io/gitea/modules/setting"
+
// register supported doc types
_ "code.gitea.io/gitea/modules/markup/csv"
_ "code.gitea.io/gitea/modules/markup/markdown"
| [NewApp,Run,Fatal,Replace] | Creates a new instance of the Gitea CLI. runBuiltWith runs the app with the given tags. | Would you be able to remove this newline? |
@@ -42,6 +42,7 @@ Commands:
globalcommunitysilence Silence remote profile from global community page
help Show help about a command, e.g (bin/console help config)
maintenance Set maintenance mode for this node
+ newpassword Set an new password for a given user
php2po ... | [Console->[getSubConsole->[out,setOption,getOption],doExecute->[getHelp,getOption,getArgument,out,getSubConsole,setOption,execute]]] | Get help message for node command. | "a new password" |
@@ -99,7 +99,11 @@ public class SparkHoodieBackedTableMetadataWriter extends HoodieBackedTableMetad
@Override
protected void commit(List<HoodieRecord> records, String partitionName, String instantTime) {
ValidationUtils.checkState(enabled, "Metadata table cannot be committed to as it is not enabled");
- m... | [SparkHoodieBackedTableMetadataWriter->[prepRecords->[create],create->[SparkHoodieBackedTableMetadataWriter]]] | Commits the records in the given partition to the given time. | moving this to `initTableMetadata()` |
@@ -342,13 +342,15 @@ def _fit_Q(fwd_data, whitener, proj_op, B, B2, B_orig, rd):
return Q, gof, B_residual
-def _fit_dipoles(data, times, rrs, guess_fwd_svd, fwd_data, whitener,
+def _fit_dipoles(min_dist_to_inner_skull, data, times, rrs, guess_fwd_svd,
+ fwd_data, whitener,
... | [_fit_Q->[_dipole_forwards,_dipole_gof],fit_dipole->[copy,_fit_dipoles,_make_guesses,Dipole,_dipole_forwards],_fit_eval->[_dipole_forwards],_fit_dipole->[_fit_Q,_fit_eval],Dipole->[plot_locations->[copy],__getitem__->[copy,Dipole]],read_dipole->[copy,Dipole],_dipole_forwards->[copy]] | Fit a single dipole to the given whitened projected data. | nitpick but arguments would fit on 2 lines only |
@@ -96,9 +96,15 @@ public class DubboBeanDefinitionParser implements BeanDefinitionParser {
generatedBeanName = beanClass.getName();
}
id = generatedBeanName;
- int counter = 2;
- while (parserContext.getRegistry().containsBeanDefinition(id)) {
- ... | [DubboBeanDefinitionParser->[parseArguments->[parse,addPropertyValue],addPropertyValue->[addPropertyValue],parseMethods->[parse],isPrimitive->[isPrimitive],parse->[parse],parseNested->[parse]]] | Parse the given element into a BeanDefinition. Parses the bean definition. Determines if a property is a reference or a reference to a service bean. This method is called to find a bean reference that can be used to create a bean reference. | According to issue #7478, ignoring the duplicate service bean is not a good solution. Don't avoid the error. The problem of duplicate definition should be prompted to the user to deal with. |
@@ -39,6 +39,7 @@ class AbstractHuggingFaceTeacher(DialogTeacher):
self.hf_split = self.hf_splits_mapping[self.fold]
self.data_path = self._path(opt)
opt['datafile'] = self.data_path
+ make_dir(opt['datafile'])
self.id = "huggingface"
super().__init__(opt, shared)
| [AbstractHuggingFaceTeacher->[setup_data->[_get_text_value,_get_label_candidates,_get_label_value]]] | Initialize a object. | Added this so the .lengths files would be saved properly- can leave this here or for consistency do we want to move this into a new build.py file? |
@@ -108,15 +108,9 @@ class PullQueryPublisher implements Flow.Publisher<Collection<StreamedRow>> {
true
);
- result.onCompletionOrException((v, t) -> decrementer.decrementAtMostOnce());
- result.onCompletion(v -> {
- pullQueryMetrics.ifPresent(p -> p.recordLatency(startTimeNanos));
... | [PullQueryPublisher->[subscribe->[recordLatency,of,onCompletionOrException,decrementAtMostOnce,onCompletion,executePullQuery,PullQuerySubscription,onSubscribe,PullQueryConfigRoutingOptions,ifPresent,PullQueryConfigPlannerOptions,getConfig,increment,getOverrides,checkRateLimit],PullQuerySubscription->[poll->[toCollectio... | Subscribes to the given subscriber. | This seems changing the behavior that even if the result contains an error, we would still record latency. Is it intentional? |
@@ -10,3 +10,9 @@ arrowParens: avoid
# jsx and tsx rules:
jsxBracketSameLine: false
+
+# java rules:
+overrides:
+ - files: "*.java"
+ options:
+ tabWidth: 4
| [No CFG could be retrieved] | JSX and TSX rules. | This should be added conditionally: it's not useful if skipServer is true |
@@ -138,15 +138,7 @@ public class TerritoryAttachment extends DefaultAttachment {
* Convenience method. Can return null.
*/
public static TerritoryAttachment get(final Territory t) {
- return get(t, false);
- }
-
- public static TerritoryAttachment get(final Territory t, final boolean allowNull) {
- ... | [TerritoryAttachment->[getUnitProduction->[getUnitProduction,get],getWhatTerritoriesThisIsUsedInConvoysFor->[getConvoyRoute,get],getProduction->[getProduction,get],get->[get],toStringForInfo->[getOriginalOwner,getWhatTerritoriesThisIsUsedInConvoysFor],setTerritoryEffect->[get]]] | Get the territory attachment. | Doesn't this change functionality for null territories since we are passing false? |
@@ -114,6 +114,9 @@ type NodeAPI interface {
GetConfig() commonRPC.Config
ShutDown()
GetLastSigningPower() (float64, error)
+
+ // mmr APIs
+ GetProof(txHash common.Hash, blockHash common.Hash, blockNumber, withRespectTo uint64) mmr.MmrProof
}
// New creates a new Harmony object (including the
| [SingleFlightRequest->[Do],BloomStatus->[Sections],IsLeader->[IsCurrentlyLeader],GetEVM->[SetBalance,NewEVM,From,GetVMConfig,Config,NewEVMContext],GetNodeMetadata->[ShardID,PeerConnectivity,GetPeerID,SyncPeers,IsBackup,GetShardConfig,BlocksPerEpoch,GetConsensusInternal,Role,Hex,Uint64,IsLeader,GetNodeBootTime,GetVersio... | New creates a new Harmony object with the given parameters. Returns a channel that will receive boolean values indicating whether a block has been requested. | GetProof is too generic. Can have a more descriptive name? GetMMRProof? |
@@ -4531,8 +4531,11 @@ class NewSemanticAnalyzer(NodeVisitor[None],
self.patches.append((priority, patch))
def report_hang(self) -> None:
+ print('Deferral trace:')
+ for mod, line in self.deferral_debug_context:
+ print(' {}: {}'.format(mod, line))
self.errors.repor... | [has_placeholder->[HasPlaceholders,accept],names_modified_in_lvalue->[names_modified_in_lvalue],NewSemanticAnalyzer->[analyze_comp_for->[analyze_lvalue],attribute_already_defined->[already_defined],name_not_defined->[is_incomplete_namespace,add_fixture_note,record_incomplete_ref,lookup_fully_qualified_or_none],check_cl... | Report a warning that the maximum semantic analysis iteration count has reached. | Maybe leave out the space after `:`, for consistency with mypy error message formatting. |
@@ -2,6 +2,11 @@ class User < ApplicationRecord
include CloudinaryHelper
attr_accessor :scholar_email
+ attr_accessor :add_mentor
+ attr_accessor :add_mentee
+ attr_accessor :mentorship_note
+ attr_accessor :ban_from_mentorship
+
rolify
include AlgoliaSearch
include Storext.model
| [User->[conditionally_resave_articles->[resave_articles],send_welcome_notification->[send_welcome_notification],resave_articles->[path]]] | A class that represents a single user in a given organization. Reserved words. | You can keep them all in oneline, like so: `attr_accesor :who, :what, :where, :when, :why` |
@@ -139,6 +139,8 @@ namespace Dynamo.Logging
}
}
+ internal HashSet<NotificationMessage> Notifications { get; }
+
/// <summary>
/// Initializes a new instance of <see cref="DynamoLogger"/> class
/// with specified debug settings and directory where to write logs... | [DynamoLogger->[LogWarning->[Log],Log->[Log],LogNotification->[Log],LogError->[Log],LogInfo->[Log],Dispose->[Dispose,Log]]] | Creates a new instance of DynamoLogger which logs a message with a specific warning level. This function logs a message with a specific log level. | this definitely seems weird - so it's a cache of notifications and only useful if the notifications extension is not loaded? |
@@ -17,14 +17,15 @@ class VersionAdmin(admin.ModelAdmin):
js = ('js/admin/l10n.js',)
view_on_site = False
- readonly_fields = ('version', 'channel', 'recommendation_approved')
+ readonly_fields = ('id', 'created', 'version', 'created', 'channel',
+ 'recommendation_approved')
... | [register] | The version admin class. | Do you need `created` twice? |
@@ -38,7 +38,11 @@ public class AlphaNumericTopNMetricSpec extends LexicographicTopNMetricSpec
{
int[] pos = {0, 0};
- if (str1.length() == 0) {
+ if (str1 == null) {
+ return -1;
+ } else if (str2 == null) {
+ return 1;
+ } else if (str1.length() == 0) {
return ... | [AlphaNumericTopNMetricSpec->[compareNonNumeric->[isDigit,compare]]] | Compares two strings. | Can we use Ordering with nullsFirst or nullsLast here? |
@@ -61,6 +61,16 @@ public final class LogicalSchema {
SchemaUtil.ROWKEY_NAME
);
+ private static final Schema IMPLICIT_SCHEMA = SchemaBuilder
+ .struct()
+ .field(SchemaUtil.ROWTIME_NAME, Schema.OPTIONAL_INT64_SCHEMA)
+ .build();
+
+ private static final Schema KEY_SCHEMA = SchemaBuilder
+ ... | [LogicalSchema->[withoutImplicitFields->[fields,of],of->[LogicalSchema],fieldIndex->[of],withoutAlias->[fields,of],schemasAreEqual->[equals],fields->[fields],validateArray->[validate],validateMap->[validate],validateStruct->[validate],withAlias->[fields,of],withImplicitFields->[fields,of]]] | KSQL s logical schema. Creates a new instance of LogicalSchema. | just some musings that I think you can ignore: I feel like this (and `IMPLICIT_SCHEMA`) makes more sense as `List<Field>` because it is often that the key schema itself is not a single field wrapped with a struct but rather just a single field. |
@@ -49,13 +49,13 @@ export function calculateExtensionScriptUrl(location, extensionId, isLocalDev) {
* @param {string} entryPoint
* @param {boolean=} isLocalDev
* @param {boolean=} opt_rtv
+ * @param {boolean=} opt_minifed
* @return {string}
*/
export function calculateEntryPointScriptUrl(
- location, ent... | [No CFG could be retrieved] | Calculates the script url for an entry point. | Do you think opt_minified should be changed to opt_notMinified so that the non-max url is returned by defaukt? |
@@ -2279,6 +2279,7 @@ public class UserVmManagerImpl extends ManagerBase implements UserVmManager, Vir
return false;
}
+ unassignBackupOffering(vm.getId());
_vmDao.remove(vm.getId());
}
| [UserVmManagerImpl->[removeInstanceFromInstanceGroup->[expunge],applyUserData->[getName],moveVMToUser->[doInTransactionWithoutResult->[getName,resourceCountIncrement,resourceCountDecrement],removeInstanceFromInstanceGroup,resourceLimitCheck,getName,getVmId,getSecurityGroupIdList],getNetworkForOvfNetworkMapping->[getDef... | ExpungeThis method is called when a user expungeThis method is called from. | @Pearl1594 possible to call remove / unassign backup from backup manager here? unassign offering code will be at single place, easy to maintain. |
@@ -1243,6 +1243,10 @@ public class DefaultChannelPipeline implements ChannelPipeline {
@Override
public void channelRead(ChannelHandlerContext ctx, Object msg) throws Exception {
+ if (logger.isDebugEnabled()) {
+ logger.debug("Reached end of the pipeline for handlers : {}... | [DefaultChannelPipeline->[destroyUp->[run->[destroyUp]],connect->[connect],write->[write],addAfter->[newContext,filterName,addAfter],remove->[remove],close->[close],TailContext->[channelRead->[onUnhandledInboundMessage],exceptionCaught->[onUnhandledInboundException]],decrementPendingOutboundBytes->[decrementPendingOutb... | This method is called when a message is received from the channel. | Can we also include the Channel itself. |
@@ -11,6 +11,10 @@ IdentityDecorator = Struct.new(:identity) do
end
def happened_at
- EasternTimePresenter.new(identity.last_authenticated_at).to_s
+ identity.last_authenticated_at
+ end
+
+ def happened_at_in_words
+ EasternTimePresenter.new(happened_at).to_s
end
end
| [happened_at->[to_s],return_to_sp_url->[sp_metadata],new,delegate] | Returns the last logged in user s unique identifier. | Do we want to inherit these two decorators (user, identity) from a common ancestor and place the shared `happened_at_in_words` method there to remove duplication, or is that overkill and/or not appropriate for Structs? |
@@ -192,10 +192,6 @@ func determineSeed(shoot *garden.Shoot, seedLister gardenlisters.SeedLister, sho
}
}
- if bestCandidate == nil {
- return nil, errors.New("no adequate seed cluster found for this cloud profile and region")
- }
-
return bestCandidate, nil
}
| [Admit->[GetKind,GetObject,WaitForReady,New,NewForbidden,Kind,AssignReadyFunc,GetOperation,Get,NewBadRequest,GroupKind],ValidateInitialization->[New],AssignReadyFunc->[SetReadyFunc],SetInternalGardenInformerFactory->[Informer,Lister,Garden,Shoots,InternalVersion,Seeds],GetCondition,NewHandler,New,List,GetK8SNetworks,Wa... | Map seeds to number of managed shoots. Checks if there are any k8s networks in the seed. | Why is this removed? I guess we need to keep it (to not `return nil, nil`), and maybe just improve the error message? |
@@ -38,8 +38,8 @@ export default class Avatar extends React.Component<PropsT, StateT> {
}
componentDidUpdate(prevProps: PropsT, prevState: StateT) {
- if (prevProps.src !== this.props.src && prevState.noImageAvailable) {
- this.setState({noImageAvailable: false});
+ if (prevProps.src != this.props.sr... | [No CFG could be retrieved] | Creates a component that is a component that is rendered when the component is rendered. Displays a hidden element with no image available. | is strict equality possible? |
@@ -1452,7 +1452,10 @@ public class BigQueryIO {
}
@VisibleForTesting
- Write<T> withTestServices(BigQueryServices testServices) {
+ /**
+ * This method is for test usage only
+ */
+ public Write<T> withTestServices(BigQueryServices testServices) {
checkArgument(testServices != null,... | [BigQueryIO->[getExtractFilePaths->[build],write->[build],TableRowParser->[TableRowParser],Write->[withMethod->[build],withNumFileShards->[build],withFormatFunction->[build],withMaxFilesPerBundle->[build],withLoadJobProjectId->[withLoadJobProjectId,build],expand->[getJsonSchema,getTableDescription,getDynamicDestination... | withMaxFilesPerBundle sets the BigQueryServices for this write. | I think it's fine to make BigQueryServices public but add "@Experimental(Experimental.Kind.SOURCE_SINK)" so that we can remove it in the future if needed. |
@@ -174,6 +174,15 @@ frappe.views.BaseList = class BaseList {
});
}
+ set_actions_menu_items() {
+ this.actions_menu_items.map(item => {
+ const $item = this.page.add_actions_menu_item(item.label, item.action, item.standard);
+ if (item.class) {
+ $item.addClass(item.class);
+ }
+ });
+ }
+
set_brea... | [No CFG could be retrieved] | Create the page and menu items This method is called from the constructor of the main section. It sets up the list -. | move to ListView |
@@ -246,7 +246,7 @@ def test_mediated_transfer_messages_out_of_order( # pylint: disable=unused-argu
app2.raiden.message_handler = app2_wait_for_message
secret = factories.make_secret(0)
- secrethash = sha256(secret).digest()
+ secrethash = SecretHash(sha256(secret).digest())
# Save the message... | [test_mediated_transfer_with_fees->[set_fee_schedule,assert_balances]] | This test is used to test if a message is repeated in a locked transfer. This function waits until the message of type is received from the network. | Also please use `sha256_secrethash` |
@@ -1417,6 +1417,8 @@ func bindSpec(spec PackageSpec, languages map[string]Language, loader Loader) (*
} else {
version = &v
}
+ } else {
+ diags = diags.Append(errorf("#/version", "No version provided"))
}
// Parse the module format, if any.
| [marshalResource->[marshalObjectData,marshalObject],bindProperties->[newOptionalType,bindType],bindResourceType->[bindResourceTypeDetails],MarshalYAML->[MarshalSpec],bindEnumTypeDetails->[bindPrimitiveType],marshalType->[marshalType],bindObjectType->[bindObjectTypeDetails],marshalFunction->[marshalObject],bindType->[ne... | bindSpec is the main entry point for the binding of a package type. It returns the if returns a context for the next generation of the plugin. | This will not work without downstream code changes. We allow schemas to elide the version argument to handle situations where the version is not known at the time the schema is generated, which is the case in ~all of our providers. All of our providers pull their version from a git tag, which is not available at the ti... |
@@ -29,7 +29,7 @@ foreach ($steps as $index => $step) {
echo '</ol>';
$options_values = [];
-foreach (get_installed_translations() as $key => $value) {
+foreach (elgg()->translator->getInstalledTranslations() as $key => $value) {
$options_values[elgg_http_add_url_query_elements(current_page_url(), ['hl' => $key])... | [No CFG could be retrieved] | Displays the install language select field. | I believe it's more efficient to first store the result in a var and loop through that. don't know for sure though |
@@ -112,7 +112,11 @@ func fieldValue(rval reflect.Value, p string) (interface{}, error) {
fields := strings.Split(p, ".")
for i, name := range fields {
- if rval.Type().Kind() == reflect.Ptr {
+ kind := rval.Type().Kind()
+ if kind == reflect.Ptr || kind == reflect.Interface {
+ if rval.IsNil() {
+ contin... | [RetrievePropertiesEx->[collect],WaitForUpdatesEx->[collect],collectAll->[collectAll],RetrieveProperties->[RetrievePropertiesEx],collect->[collect,collectAll,collectFields]] | fieldValueInterface returns the field value of the given type if it is embedded in the given fieldRefs returns a slice of types. ManagedObjectReference for the given fields. | ^^copyright needs a range :) |
@@ -52,8 +52,15 @@ class CartQueryset(models.QuerySet):
def save(self):
self.update(status=Cart.SAVED)
+ def with_products_data(self):
+ return self.prefetch_related(
+ 'lines', 'lines__variant', 'lines__variant__product__attributes',
+ 'lines__variant__product__attribute... | [ProductGroup->[is_shipping_required->[is_shipping_required]],CartLine->[get_price_per_item->[get_price_per_item],is_shipping_required->[is_shipping_required]],Cart->[is_shipping_required->[is_shipping_required],change_user->[save,change_status],partition->[partition,is_shipping_required],update_quantity->[save],add->[... | Save the cart item. | Correct name would be `with_product_data` but I'd prefer to have it named after the purpose rather than its implementation detail. What would be a better name? `for_display`? |
@@ -123,10 +123,13 @@ def _check_one_ch_type(info, picks, noise_cov):
info['comps'] = comps
ch_types =\
[_contains_ch_type(info_pick, tt) for tt in ('mag', 'grad', 'eeg')]
- if sum(ch_types) > 1 and noise_cov is None:
+ if beamformer == 'lcmv' and sum(ch_types) > 1 and noise_cov is None:
... | [_prepare_beamformer_input->[_get_vertno,reshape,pick_channels_forward,min,repeat,sqrt,sum,norm,ValueError,make_projector,ix_,label_src_vertno_sel,index,dot,ravel],_setup_picks->[info,set,_compare_ch_names,len],_eig_inv->[svd,zeros,dot],_check_proj_match->[array_equal,ValueError,make_projector],_check_one_ch_type->[_co... | Check number of sensor types and presence of noise covariance matrix. | This will `warn` even for mag+grad, right? This doesn't seem right since @wmvanvliet's pipeline was developed on Neuromag systems. It might even be tested on mag+grad+eeg already, not sure. |
@@ -246,7 +246,7 @@ define([
}
function requestMetadata() {
- var metadata = loadJson(metadataUrl);
+ var metadata = RequestScheduler.request(metadataUrl, loadJson);
when(metadata, metadataSuccess, metadataFailure);
}
| [No CFG could be retrieved] | Enumerates unique identifiers for each type of extension data that has been appended to the standard The request header for a specific object. | Looking at this now, I suspect this is a better approach than doing this implicitly/explicitly in the utility functions. It's explicit to the user, should extend well to new request functions, and I imagine is what a typical game engine's "resource manager" looks like. |
@@ -68,6 +68,7 @@ class WPSEO_Metabox_Formatter {
'contentAnalysisActive' => $analysis_readability->is_enabled() ? 1 : 0,
'keywordAnalysisActive' => $analysis_seo->is_enabled() ? 1 : 0,
'cornerstoneActive' => WPSEO_Options::get( 'enable_cornerstone_content', false ) ? 1 : 0,
+ 'semrushInte... | [WPSEO_Metabox_Formatter->[get_values->[get_values]]] | Returns the default settings for the metabox Checks if the word form recognition is active. description of the translations for the missing readability metabox Displays a list of possible translations for a collapsible metabox. | Minor: Naming is hard I see other settings that enable / disable features have their option name starting with `enable`, for example `enable_cornerstone_content`. Has this been considered for consistency? Why `semrush_integration_active` instead of `enable_semrush_integration`? |
@@ -85,8 +85,6 @@ after_initialize do
available_options = poll.poll_options.map { |o| o.digest }.to_set
options.select! { |o| available_options.include?(o) }
- raise StandardError.new I18n.t("poll.requires_at_least_1_valid_option") if options.empty?
-
new_option_ids = poll.po... | [vote->[vote],create!->[create!],voters->[serialized_voters,voters],grouped_poll_results->[transform_for_user_field_override,grouped_poll_results],toggle_status->[toggle_status],create!,schedule_jobs] | vote a poll in a post Find missing poll votes by user. | I think we still need this since we should be using a different route for the vote removal |
@@ -200,9 +200,9 @@ const (
// PdhFmtDouble returns data as a double-precision floating point real.
PdhFmtDouble PdhCounterFormat = C.PDH_FMT_DOUBLE
// PdhFmtLarge returns data as a 64-bit integer.
- PdhFmtLarge = C.PDH_FMT_LARGE
+ PdhFmtLarge PdhCounterFormat = C.PDH_FMT_LARGE
// PdhFmtLong returns data as a l... | [No CFG could be retrieved] | The basic information about the counter. | Looks like other formatters below also should have the same `PdhCounterFormat` type applied. |
@@ -119,7 +119,8 @@ public class TimerReceiver {
String timerId = timerSpec.timerId();
TimerInternals timerInternals = stepContext.namespacedToUser().timerInternals();
- timerInternals.setTimer(namespace, timerId, timer.getTimestamp(), timeDomain);
+ timerInternals.setTimer(
+ ... | [TimerReceiver->[create->[receive],createTimerOutputIdToSpecMap->[forEach,values,put,outputCollectionId],getTimerWindowingCoder->[getWindowingStrategyId,getWindowCoderId,get],fireTimer->[accept,getBundle,close],createTimerIdToSpecMap->[forEach,values,put,timerId],receive->[getValue,getTimeDomain,debug,getWindows,getTim... | This method is called when a new element is received from a timer. | the second timer.getTimestamp() should be timer.getOutputTimestamp() |
@@ -307,11 +307,11 @@ if ($resql)
print '<tr class="liste_titre">';
if (! empty($arrayfields['aa.account_number']['checked'])) print_liste_field_titre($arrayfields['aa.account_number']['label'], $_SERVER["PHP_SELF"], "aa.account_number", "", $param, '', $sortfield, $sortorder);
if (! empty($arrayfields['aa.lab... | [fetch,plimit,query,getNomUrl,executeHooks,loadLangs,trans,formconfirm,num_rows,fetch_object,account_activate,account_desactivate,close,multiSelectArrayWithCheckbox,showFilterAndCheckAddButtons,order] | Print the list of all fields that are checked. This function prints the list of accounting accounts. | Can you check that space is after after and not before in last param |
@@ -49,4 +49,17 @@ public class PackageConfig {
*/
@ConfigItem(defaultValue = "-runner")
public String runnerSuffix;
+
+ /**
+ * The output folder in which to place the output, this is resolved relative to the build
+ * systems target directory.
+ */
+ @ConfigItem
+ public Optional<... | [No CFG could be retrieved] | The runner suffix for the . | I'm a bit concerned about the consequences of this on the ``Dockerfile``s we provide. I'm more and more thinking that having some templates for these files is probably not a good idea and they shoud be generated by the build. Do my interrogations make sense? |
@@ -0,0 +1,12 @@
+using Content.Shared.GameObjects.Components.Damage;
+using Robust.Shared.GameObjects;
+
+namespace Content.Client.GameObjects.Components.Damage
+{
+ [RegisterComponent]
+ [ComponentReference(typeof(IDamageableComponent))]
+ [ComponentReference(typeof(SharedDamageableComponent))]
+ public ... | [No CFG could be retrieved] | No Summary Found. | Can't this be deleted if it doesn't do anything differently from shared? |
@@ -116,6 +116,10 @@ class Coder(object):
self.estimate_size)
def get_impl(self):
+ """For internal use only; no backwards-compatibility guarantees.
+
+ Returns the CoderImpl backing this Coder.
+ """
if not hasattr(self, '_impl'):
self._impl = self._cr... | [IterableCoder->[_create_impl->[get_impl],as_cloud_object->[as_cloud_object],is_deterministic->[is_deterministic],from_type_hint->[IterableCoder]],StrUtf8Coder->[decode->[decode],encode->[encode]],WindowedValueCoder->[key_coder->[key_coder],as_cloud_object->[as_cloud_object,_get_component_coders],is_deterministic->[is_... | Returns the coder_impl. CoderImpl object for this object. | Can you please also mark `as_cloud_object()`, `get_estimated_size_and_observables()` and the `*_runner_api()` functions in this way? |
@@ -1289,6 +1289,15 @@ DataReaderImpl::enable()
XTypes::TypeInformation type_info;
typesupport->to_type_info(type_info);
+ XTypes::TypeIdentifierTypeObjectPairSeq ti_to_pair_seq;
+ XTypes::TypeIdentifierTypeObjectPair ti_to_pair;
+ ti_to_pair.type_identifier = type_info.minimal.typeid_with_size.typ... | [No CFG could be retrieved] | This function is called by DDS to enable the Transport. This function checks if the topic servant is enabled and if so it checks if the reader. | I'm not sure what implementation this is talking about. |
@@ -621,7 +621,7 @@ namespace VMAP
{
//if (fread(&chunkSize, sizeof(uint32), 1, rf) != 1) result = false;
- if (result && fread(&count, sizeof(uint32), 1, rf) != 1) { result = false; }
+ if (fread(&count, sizeof(uint32), 1, rf) != 1) { result = false; }
if (res... | [writeFile->[writeToFile],GetLiquidLevel->[GetLiquidHeight],writeToFile->[writeToFile,GetFileSize],readFromFile->[readFromFile],IsInsideObject->[IntersectRay],GModelRayCallback->[operator->[IntersectTriangle]],WModelRayCallBack->[operator->[models]],WModelAreaCallback->[operator->[prims]],readFile->[readFromFile]] | read file in file system. | The condition for this if statement is also redundant as we're already inside the `if (result && readChunk(rf, chunk, "GMOD", 4))` if statement |
@@ -4431,7 +4431,7 @@ function print_barre_liste($titre, $page, $file, $options = '', $sortfield = '',
if ($picto == 'setup') $picto = 'title_setup.png';
if (($conf->browser->name == 'ie') && $picto == 'generic') $picto = 'title.gif';
if ($limit < 0) $limit = $conf->liste_limit;
- if ($savlimit != 0 && (($num > $... | [dolGetCountryCodeFromIp->[getCountryCodeFromIP],complete_head_from_modules->[executeHooks,trans,load],addSummaryTableLine->[trans],dol_print_error->[transnoentities,loadLangs,trans,setDefaultLang,lasterror,lastqueryerror,lasterrno,lastquery,load],dol_print_phone->[executeHooks,fetch_clicktodial,trans],dol_print_url->[... | Prints barre liste Displays a table of content for a single block of a file. This function will generate the pagination list for the given number of pages. Dump a page number list. | num = -1 when parm is not provided (so for backward compatibility). This means navigation will be broken for all use of this method. For new usage, it is never -1. |
@@ -2561,6 +2561,7 @@ class ArchiverTestCase(ArchiverTestCaseBase):
archives_after = self.cmd('list', self.repository_location + '::test')
assert archives_after == archives_before
+
def test_recreate_skips_nothing_to_do(self):
self.create_regular_file('file1', size=1024 * 80)
... | [ArchiverCorruptionTestCase->[test_cache_files->[corrupt,cmd],setUp->[create_test_files,cmd],test_cache_chunks->[corrupt,cmd],test_chunks_archive->[corrupt,cmd],test_old_version_interfered->[cmd]],test_disk_full->[make_files,cmd],get_all_parsers->[discover_level->[discover_level],discover_level],RemoteArchiverTestCase-... | Test if recreate is not run. | remove accidental change, please. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.