patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -73,6 +73,13 @@ export class UserManagement extends React.Component<IUserManagementProps, IPagin
this.props.getUsers(activePage - 1, itemsPerPage, `${sort},${order}`);
}
+ toggleActive = ({ user }) => () => {
+ this.props.updateUser({
+ ...user,
+ activated: !user.activated
+ });
+ };
+
... | [No CFG could be retrieved] | The state of the nagination component. Displays the missing - column errors in the table. | unnecessary destructing, pass the user directly `toggleActive = user => () => {..}` and `onClick={this.toggleActive(user) ` |
@@ -849,7 +849,8 @@ class Output:
try:
objects.check(self.odb, obj)
except FileNotFoundError:
- remote = self.repo.cloud.get_remote_odb(self.remote)
+ if self.remote:
+ kwargs["remote"] = self.remote
self.repo.cloud.pull([obj.hash_info], o... | [Output->[isfile->[_is_path_dvcignore,isfile],_check_can_merge->[dumpd],unprotect->[unprotect],transfer->[isdir],changed_checksum->[get_hash],set_exec->[set_exec,isfile],remove->[ignore_remove,remove],move->[move,ignore,commit,save,ignore_remove],download->[download],exists->[exists,_is_path_dvcignore],status->[changed... | Get dir cache object. | This is getting irritating, will need to look into getting rid of `get_dir_cache` soon. :disappointed: |
@@ -64,6 +64,11 @@ namespace Microsoft.Xna.Framework
get { return _handle; }
}
+ private bool HasNativeWindow
+ {
+ get { return Handle != IntPtr.Zero; }
+ }
+
public override string ScreenDeviceName
{
get { return _screenDeviceName;... | [SdlGameWindow->[Dispose->[Dispose],SetTitle->[SetTitle]]] | Creates a new SdlWindow object. The is the object that contains the screen device name and width and height. | Pointless helper property, the code behind it is simple enough that you should that code. |
@@ -267,10 +267,17 @@ func resourceAwsSubnetRead(d *schema.ResourceData, meta interface{}) error {
d.Set("arn", subnet.SubnetArn)
- if err := d.Set("tags", keyvaluetags.Ec2KeyValueTags(subnet.Tags).IgnoreAws().IgnoreConfig(ignoreTagsConfig).Map()); err != nil {
+ tags := keyvaluetags.Ec2KeyValueTags(subnet.Tags).... | [GetChange,IgnoreAws,Ec2KeyValueTags,Set,Ec2UpdateTags,GetOk,HasChange,HasChanges,Errorf,DescribeSubnets,SetId,Bool,Timeout,IgnoreConfig,DisassociateSubnetCidrBlock,Id,CreateSubnet,SubnetMapCustomerOwnedIpOnLaunchUpdated,Get,Map,SubnetMapPublicIpOnLaunchUpdated,ModifySubnetAttribute,Printf,DefaultTimeout,StringValue,De... | Set all the values of the subnet Updates the tags of the subnet. | We can figure out how to adjust this linter after this pull request, even if that means creating a separate function to bundle this code up -- I personally really like the split here so `tags` and `tags_all` values are straightforward to in the `d.Set()` calls. |
@@ -642,6 +642,12 @@ func UserSignIn(username, password string) (*User, error) {
}
if hasUser {
+ if !user.IsActive {
+ return nil, ErrUserInactive{user.ID, user.Name}
+ } else if user.ProhibitLogin {
+ return nil, ErrUserProhibitLogin{user.ID, user.Name}
+ }
+
switch user.LoginType {
case LoginNoTyp... | [HasTLS->[IsSMTP,IsLDAP,IsDLDAP],OAuth2,IsLDAP,IsOAuth2,LDAP] | UserSignIn attempts to sign in a user with the given username and password. If the Login a user via a login source. | This should be checked only after username&password is validated otherwise usernames can be leaked/guessed from private servers |
@@ -308,6 +308,10 @@ export class AbstractAmpContext {
this.tagName = context.tagName;
this.embedType_ = dataObject.type || null;
+
+ if (context.initialConsentValue) {
+ this.initialConsentValue = context.initialConsentValue;
+ }
}
/**
| [No CFG could be retrieved] | This is the main entry point for the host window. Checks if the context data is set on window and if so sets the metadata. | Do we need a check here? Wouldn't this just return undefined anyways? |
@@ -45,7 +45,7 @@ class _BinaryPackageMetadata(object):
@revision.setter
def revision(self, r):
- self._revision = DEFAULT_REVISION_V1 if r is None else r
+ self._revision = r
@property
def recipe_revision(self):
| [_BinaryPackageMetadata->[loads->[_BinaryPackageMetadata]],_RecipeMetadata->[loads->[_RecipeMetadata]],PackageMetadata->[dumps->[dumps,to_dict],loads->[loads,PackageMetadata],__eq__->[dumps],clear->[_RecipeMetadata],__str__->[dumps]]] | Set the revision of the recipe. | A ``assert r is not None`` here is the typical thing that can be useful to spot errors quickly |
@@ -175,7 +175,8 @@ public class RunNiFi {
System.out.println("Status : Determine if there is a running instance of Apache NiFi");
System.out.println("Dump : Write a Thread Dump to the file specified by [options], or to the log if no file is given");
System.out.println("Diagnostics : Write di... | [RunNiFi->[loadProperties->[getStatusFile],getStatus->[isProcessRunning,loadProperties,isPingSuccessful],sendRequest->[loadProperties],main->[RunNiFi,printUsage],start->[getCurrentPort,getStatusFile,getLockFile,start,isAlive,savePidProperties,getHostname],env->[getStatus],status->[isProcessRunning,getStatus],savePidPro... | Prints the command line usage. | Please specify, which log (bootstrap) |
@@ -207,6 +207,9 @@ async function reportBundleSize() {
}
}
+/**
+ * @return {Promise<void>}
+ */
async function getLocalBundleSize() {
if (globby.sync(fileGlobs).length === 0) {
log('Could not find runtime files.');
| [No CFG could be retrieved] | Report the size of the current bundle to the GitHub App to determine size changes. Get the bundle size for the minified AMP binary. | Re: this change, @samouri is gonna say _"I told you so"_. And I will sheepishly look away and whistle a tune. |
@@ -359,7 +359,7 @@ def unpack_file_url(link, location):
# delete the location since shutil will create it again :(
if os.path.isdir(location):
rmtree(location)
- shutil.copytree(source, location)
+ shutil.copytree(source, location, symlinks=True)
else:
unpack_... | [PipSession->[__init__->[LocalFSAdapter,MultiDomainBasicAuth,user_agent]],LocalFSResponse->[_original_response->[FakeResponse->[msg->[FakeMessage]],FakeResponse],read->[read]],_download_url->[close],_get_hash_from_file->[close,read],is_vcs_url->[_get_used_vcs_backend],unpack_http_url->[PipSession,_get_hash_from_file,_c... | Unpack a file from a URL into a location. | Presumably this works on Windows? Is it ignored, or does it attempt to copy symlinks? If the latter, then it may fail because the pip process is not elevated (creating symlinks needs an elevated process on Windows). |
@@ -549,11 +549,8 @@ namespace Dynamo.Views
try
{
- UserControl uc = grid.Parent as UserControl;
- if (null == uc)
- continue;
+ PortViewModel pvm = (PortViewModel)grid.DataContext;
- ... | [dynWorkspaceView->[vm_ZoomToFitView->[vm_ZoomChanged,vm_CurrentOffsetChanged],ZoomAtViewportPoint->[vm_ZoomChanged,vm_CurrentOffsetChanged]]] | GetSnappedPort gets the nearest port view model that is snapped to the mouse cursor. | This won't result in pvm being null, it'll result in a class cast exception if it fails. Either we're confident it never will, in which case remove the null check, or we're not confident in which case use 'x as y' |
@@ -29,7 +29,7 @@ namespace System.Runtime.Serialization
public CodeTypeReference this[int index]
{
- get { return ((CodeTypeReference)(List[index])); }
+ get { return ((CodeTypeReference)(List[index]!)); }
set { List[index] = value; }
}
| [No CFG could be retrieved] | Creates an instance of CodeTypeReferenceCollection that contains all of the CodeTypeReference objects in the System Add or remove a CodeTypeReference from the List. | there is nothing really guarding setter against null |
@@ -36,6 +36,7 @@ public class OneTimeTokenAccount implements Serializable, Comparable<OneTimeToke
private static final long serialVersionUID = -8289105320642735252L;
@Id
+ @org.springframework.data.annotation.Id
@GeneratedValue(strategy = GenerationType.AUTO)
private long id = Integer.MAX_VALU... | [OneTimeTokenAccount->[toString->[toString],compareTo->[build],hashCode->[toHashCode],equals->[getClass,isEquals]]] | Package private for testing purposes. One - Time Token Validation Code. | Remove the default value. |
@@ -372,6 +372,12 @@ class pdf_einstein extends ModelePDFCommandes
if (!empty($salerepobj->signature)) $notetoshow = dol_concatdesc($notetoshow, $salerepobj->signature);
}
}
+ // Extrafields in note
+ $extranote = $this->getExtrafieldsInHtml($object, $outputlangs);
+ ... | [pdf_einstein->[_tableau_info->[fetch,convToOutputCharset,SetXY,transnoentities,SetTextColor,GetY,getFullAddress,MultiCell,load,SetFont],_tableau->[printRect,transnoentitiesnoconv,SetXY,transnoentities,SetDrawColor,SetTextColor,Rect,MultiCell,GetStringWidth,line,SetFont],_tableau_tot->[SetFillColor,SetXY,transnoentitie... | Writes a single file from the multidir output Create a PDF from a single object Adds a new page to the PDF This function is called when a template is not available replaces a user with a user object This function is used to edit the top margin of the multipage and the bottom margin of Adds a page to the current page an... | The template pdf_einstein.modules.php , crabe and azur will be abandonned and replaced with cyan, eratosthen, ... So can you also publish this in the new templates so we won't loose this when we will remove the file einstein, crabe, azur ? |
@@ -38,13 +38,13 @@ namespace Kratos {
const double radius_sum_inv = 1.0 / radius_sum;
const double equiv_radius = my_radius * other_radius * radius_sum_inv;
const double contact_radius = sqrt(equiv_radius * indentation);
- const double cohesive_force = equiv_young * sqrt(8.0 * equiv... | [CalculateCohesiveNormalForce->[GetParticleCohesion,GetPoisson,sqrt,GetYoung,GetRadius],CalculateCohesiveNormalForceWithFEM->[GetParticleCohesion,GetPoisson,sqrt,GetYoung,GetProperties,GetRadius],SetConstitutiveLawInProperties->[KRATOS_INFO,Id,SetValue,Clone]] | This function calculates the cohesive normal force of a particle. - - - - - - - - - - - - - - - - - -. | Wow! This is a big change/bugfix!! |
@@ -62,7 +62,9 @@ const config = {
// Transpile ES2015 (aka ES6) to ES5. Accept the JSX syntax by React
// as well.
- exclude: node_modules, // eslint-disable-line camelcase
+ exclude: [
+ new RegExp(`${__dirname}/node_modules/(?!js-utils)`)
+ ... | [No CFG could be retrieved] | The base Webpack configuration to bundle the JavaScript artifacts of a jitsi - meet Requires a module to be executed by a JIT - Meet. | Why is this change necessary? |
@@ -90,7 +90,8 @@ public class TaskToolbox
MonitorScheduler monitorScheduler,
SegmentLoader segmentLoader,
ObjectMapper objectMapper,
- final File taskWorkDir
+ final File taskWorkDir,
+ ColumnConfig columnConfig
)
{
this.config = config;
| [TaskToolbox->[getTaskActionClient->[create],pushSegments->[apply->[getInterval],copyOf,SegmentInsertAction,values,index,submit],fetchSegments->[getSegmentFiles,newLinkedHashMap,put]]] | Creates a class that can be used to run a task. missing. dataSegmentMover dataSegmentArchiver and missing. segmentAnnouncer. | can this be a part of the task config? |
@@ -97,6 +97,13 @@ public class PolicyTestCase extends MuleArtifactFunctionalTestCase {
assertThat(schedulerService.getSchedulers().size(), is(0));
}
+ @Test
+ public void policyCacheEntryGetsEvictedOnFlowDisposal() throws Exception {
+ Thread.sleep(2000);
+ ((Flow) getFlowConstruct("main")).dispose()... | [PolicyTestCase->[addBuilders->[addBuilders],TestPolicyProvider->[start->[getPolicyFromRegistry]]]] | This method is called when the application is stopped with a generated . | if you need to wait for the flow to have kicked in some times, use a latch instead of sleep |
@@ -137,7 +137,7 @@ func (r *PolicyBindingRegistry) DeletePolicyBinding(ctx kapi.Context, id string)
}
func (r *PolicyBindingRegistry) WatchPolicyBindings(ctx kapi.Context, label labels.Selector, field fields.Selector, resourceVersion string) (watch.Interface, error) {
- return nil, errors.New("unsupported")
+ retu... | [CreatePolicyBinding->[GetPolicyBinding],UpdatePolicyBinding->[GetPolicyBinding]] | WatchPolicyBindings returns a watch. Interface that watches the policy bindings for changes. | this will make future debugging much easier ;-) |
@@ -907,3 +907,11 @@ def need_mercurial(fn):
return pytest.mark.mercurial(need_executable(
'Mercurial', ('hg', 'version')
)(fn))
+
+
+def is_svn_installed():
+ try:
+ subprocess.check_output(('svn', '--version'))
+ except OSError:
+ return False
+ return True
| [_create_test_package_with_subdirectory->[_create_main_file,run,_git_commit],_git_commit->[run],need_mercurial->[need_executable],_change_test_package_version->[_create_main_file,_git_commit],TestPipResult->[assert_installed->[TestFailure]],need_bzr->[need_executable],_vcs_add->[run,_git_commit],TestData->[backends->[p... | Check if a file is mercurial. | Can you put this after `is_bzr_installed()` since the functions have the same structure? |
@@ -273,12 +273,11 @@ public final class KsqlRestApplication extends ExecutableApplication<KsqlRestCon
this.configurables = requireNonNull(configurables, "configurables");
this.rocksDBConfigSetterHandler =
requireNonNull(rocksDBConfigSetterHandler, "rocksDBConfigSetterHandler");
+ this.pullQueryEx... | [KsqlRestApplication->[onShutdown->[triggerShutdown],buildApplication->[buildApplication,KsqlRestApplication],displayWelcomeMessage->[getListeners,displayWelcomeMessage],loadSecurityExtension->[initialize],checkPreconditions->[KsqlFailedPrecondition]]] | Setup resources. | how are the other executors created? are we departing from any pattern.. |
@@ -20,11 +20,16 @@ class CmdDataBase(CmdBase):
ret = 1
return ret
+ @staticmethod
+ def check_up_to_date(processed_files_count, message):
+ if processed_files_count == 0:
+ logger.info(message)
+
class CmdDataPull(CmdDataBase):
def do_run(self, target=None):
... | [CmdDataBase->[run->[do_run]],add_parser->[add_parser,shared_parent_parser]] | Run the task. | We can safely use `logger.info(self.UP_TO_DATE_MSG)` here, without passing it explicitly. Sorry, looks like I've confused you by mentioning `staticmethod` in my previous review :slightly_frowning_face: |
@@ -22,16 +22,11 @@ package <%= packageName %>.web.rest;
<%_ if (databaseType === 'cassandra') { _%>
import <%= packageName %>.AbstractCassandraTest;
<%_ } _%>
-<%_ if (databaseType === 'neo4j') { _%>
-import <%= packageName %>.AbstractNeo4jIT;
-<%_ } _%>
-<%_ if (cacheProvider === 'redis') { _%>
-import <%= package... | [No CFG could be retrieved] | Package name is required Imports a single - valued property from the System. | remove this, no need anymore |
@@ -364,7 +364,7 @@ func (ctx *Context) Call(tok string, args Input, output Output, self Resource, o
// If we have a value for self, add it to the arguments.
if self != nil {
var deps []URN
- resolvedSelf, selfDeps, err := marshalInput(self, nil, true)
+ resolvedSelf, selfDeps, err := marshalInput(self, a... | [Call->[Call],ReadResource->[ReadResource],RegisterComponentResource->[RegisterResource],collapseAliases->[Project,Stack],registerResource->[RegisterResource,getResource],Invoke->[Invoke],resolve->[DryRun,resolve],RegisterRemoteComponentResource->[registerResource],withKeepOrRejectUnknowns->[DryRun],RegisterResourceOut... | Call invokes a remote function with the given arguments. Encode all the dependencies for a call and return a call request. Call a protected object via RPC. Call returns a list of dependency resources that can be used to call a single object. | Feels like we ought to have a better type than `anyType` for `resolvedSelf`. Is there a reason that we can't use the type of the resource itself? |
@@ -2304,14 +2304,14 @@ namespace Internal.JitInterface
blockType = BlockType.Unknown;
}
- private HRESULT allocMethodBlockCounts(uint count, ref BlockCounts* pBlockCounts)
+ private unsafe HRESULT allocPgoInstrumentationBySchema(CORINFO_METHOD_STRUCT_* ftnHnd, PgoInstrumentationSc... | [CorInfoImpl->[classMustBeLoadedBeforeCodeIsRun->[classMustBeLoadedBeforeCodeIsRun],VerifyMethodSignatureIsStable->[MethodSignatureIsUnstable],EncodeFieldBaseOffset->[HasLayoutMetadata,PreventRecursiveFieldInlinesOutsideVersionBubble],getFieldInfo->[IsClassPreInited],getCallInfo->[ceeInfoGetCallInfo,UpdateConstLookupWi... | findKnownBBCountBlock - finds a block in the block code tree that is known for. | We will want to support this for inlinees, eventually (#44372). |
@@ -248,6 +248,10 @@ class RemoteManager(object):
raise ConanException(exc, remote=remote)
+def calc_files_checksum(files):
+ return {file: {"md5": md5sum(path), "sha1": sha1sum(path)} for file, path in files.items()}
+
+
def is_package_snapshot_complete(snapshot):
integrity = True
for ke... | [RemoteManager->[_resolve_latest_ref->[get_latest_recipe_revision],_resolve_latest_pref->[get_latest_package_revision]],unzip_and_get_files->[check_compressed_files,remove]] | Check if the package snapshot is complete. | ``file`` shadows built-in, better use another name |
@@ -897,6 +897,10 @@ class MessageBuilder:
def type_arguments_not_allowed(self, context: Context) -> None:
self.fail('Parameterized generics cannot be used with class or instance checks', context)
+ def disallowed_any_type(self, typ: Type, context: Context) -> None:
+ self.fail('Expressions of... | [make_inferred_type_note->[format],temp_message_builder->[MessageBuilder],pretty_or->[format],MessageBuilder->[return_type_incompatible_with_supertype->[format,fail],read_only_property->[format,fail],forward_operator_not_callable->[format,fail],unsupported_left_operand->[format,fail],too_many_arguments->[format,fail],u... | Type arguments cannot be used with class or instance checks. | This is a bit confusing, as the expression may not have the type "Any". |
@@ -259,9 +259,7 @@ describe Users::SessionsController do
it "should ask you to confirm your email if it isn't confirmed, after log in" do
post_redirect = FactoryBot.create(:post_redirect, uri: '/list')
- post :create, { :user_signin => { :email => 'unconfirmed@localhost', :password => 'jonespassword... | [do_signin->[post],email,create,let,describe,first,it,email_token,to,before,month,pending,post,with,require,to_s,now,allow_forgery_protection,match,id,do_signin,deliveries,redirect_to,context,token,request_list_path,get,not_to,eq,after,months,render_template,and_return] | It re - renders the form allows the signup and sends an exception notification when spam_ To where you were after you click an email link. | Line is too long. [146/80] |
@@ -52,7 +52,7 @@ class RetiariiExeConfig(ConfigBase):
nni_manager_ip: Optional[str] = None
debug: bool = False
log_level: Optional[str] = None
- experiment_working_directory: Optional[PathLike] = None
+ experiment_working_directory: Optional[PathLike] = '~/nni-experiments'
# remove configurat... | [RetiariiExperiment->[start->[start,_start_strategy],_start_strategy->[preprocess_model],run->[start]],debug_mutated_model->[preprocess_model]] | Initialize the object with a missing training service. | I'm not sure. What will happen if it's none? |
@@ -591,10 +591,11 @@ int CmdLineArgsParser::Parse(__in LPWSTR oneArg) throw()
PrintUsage();
return -1;
}
- else
+ else if ('-' == CurChar())
{
- ParseFlag();
+ NextChar();
}
+ ParseFl... | [No CFG could be retrieved] | Parse - command line arguments and constructor Table - the flag table that is used to populate the configuration. | we will going to support '/-' as well - is that intended? |
@@ -106,9 +106,14 @@ module Users
end
def process_invalid_submission
- clear_piv_cac_information
- flash[:error_type] = user_piv_cac_form.error_type
- redirect_to setup_piv_cac_url
+ if user_piv_cac_form.name_taken
+ flash.now[:error] = t('errors.webauthn_setup.unique_name')
+ ... | [PivCacAuthenticationSetupController->[render_error->[new],user_piv_cac_form->[new],render_prompt->[new],authorize_piv_cac_disable->[piv_cac_enabled?]]] | process invalid submission nag record. | Should we copy this translation to a new key. Something under `errors.piv_cac_setup.unique_name` |
@@ -199,7 +199,11 @@ public class RemoteSyncHandler implements Handler<HttpServerRequest> {
event.bodyHandler(new Handler<Buffer>() {
@Override
public void handle(Buffer buffer) {
- hotReplacementContext.updateFile(event.path(), buffer.getBytes());
+ try ... | [RemoteSyncHandler->[doPreScan->[wait,error,notifyAll],handleConnect->[resume],handlePut->[checkSession,resume],handleRequest->[handleConnect,equals,handlePut,handleDelete,end,handleDev],handleDelete->[checkSession,path,updateFile,end],handleDev->[checkSession,resume],run->[doPreScan],checkSession->[end,error,get,equal... | Handle PUT requests. | Stupid question: will the filename be in the exception for sure? Or do we need to include it in the error message? |
@@ -8,10 +8,10 @@ import json
class TestStructuralMechanicsStaticHROM(StructuralMechanicsAnalysisROM):
def __init__(self,model,project_parameters):
- super(TestStructuralMechanicsStaticHROM,self).__init__(model,project_parameters)
+ super().__init__(model,project_parameters)
def ModifyIniti... | [TestStructuralMechanicsStaticHROM->[EvaluateQuantityOfInterest2->[GetSolutionStepValue,Execute,append,GetComputingModelPart,CalculateNodalAreaProcess,_GetSolver],__init__->[super],ModifyInitialGeometry->[GetCondition,HR_data,GetComputingModelPart,super,open,GetElement,load],EvaluateQuantityOfInterest->[append,_GetSolv... | Initialize the TestStructuralMechanicsStaticHROM object. | Shouldn't this be `ModifyAfterSolverInitialize` after what we spoke before? |
@@ -5,10 +5,10 @@
package io.opentelemetry.javaagent.instrumentation.jedis.v1_4;
-import io.opentelemetry.instrumentation.api.instrumenter.net.NetAttributesExtractor;
+import io.opentelemetry.instrumentation.api.instrumenter.net.NetAttributesServerExtractor;
import org.checkerframework.checker.nullness.qual.Nulla... | [JedisNetAttributesExtractor->[peerPort->[getPort],peerName->[getHost]]] | Returns the transport identifier for the given request. | Should we use a client extractor here? It's a redis client library after all (even if the net info is available on start) |
@@ -27,11 +27,3 @@ echo elgg_view('object/widget/edit/num_display', [
'entity' => $widget,
'default' => 8,
]);
-
-// pass the context so we have the correct output upon save.
-$context = elgg_in_context('dashboard') ? 'dashboard' : 'profile';
-
-echo elgg_view('input/hidden', [
- 'name' => 'context',
- 'value' => ... | [No CFG could be retrieved] | Print hidden input for the node with the context. | why would this even be necessary????? |
@@ -12,6 +12,12 @@ class PyS3transfer(PythonPackage):
homepage = "https://github.com/boto/s3transfer"
pypi = "s3transfer/s3transfer-0.2.1.tar.gz"
+ depends_on('python@3.6:', when='@0.5.0', type=('build', 'run'))
+ depends_on('python@2.7:2.8,3.6:', when='@0.4.2', type=('build', 'run'))
+ depends_on(... | [PyS3transfer->[depends_on,version]] | S3transfer is a Python library for managing Amazon S3 transfers. | I usually like to put all the `depends_on` below the `version` |
@@ -665,6 +665,16 @@ angular.module('zeppelinWebApp').controller('ParagraphCtrl', function($scope, $r
$scope.editor.commands.bindKey('ctrl-.', 'startAutocomplete');
$scope.editor.commands.bindKey('ctrl-space', null);
+ $scope.keyBindingEditorFocusAction = function(moveTarget, scrollValue) {
+ ... | [No CFG could be retrieved] | Adds key bindings and commands to the editor. keyup and keydown. | This should be `var`, not $scope |
@@ -293,13 +293,13 @@ namespace DotNetNuke.Services.Installer
Name = fileName.Substring(10, fileName.Length - 10);
Path = fileName.Substring(0, 10);
}
- if (Name.ToLower() == "manifest.xml")
+ if (Name.ToLowerInvariant() == "manifest.xml")
... | [InstallFile->[ParseFileName->[AppCode,Ordinal,Substring,StartsWith,Resources,IsMatch,LastIndexOf,CleanUp,Language,Script,EndsWith,IsNullOrEmpty,ToLower,Other,Ascx,Replace,Manifest,Length,Assembly],ReadZip->[WriteStream,Name,ParseFileName,SetLastWriteTime,DateTime],TempInstallFolder,ParseFileName,ReadZip,Combine,IsNull... | Parse fileName and determine the type of file. | Please use `String#Equals(String, StringComparison)` |
@@ -321,7 +321,7 @@ public class IndexGeneratorJob implements Jobby
List<QueryableIndex> indexes = Lists.newArrayListWithCapacity(indexCount);
final File mergedBase;
- if (toMerge.size() == 0) {
+ if (toMerge.size() == 0 && !index.isEmpty()) {
mergedBase = new File(baseFlushFile, "mer... | [IndexGeneratorJob->[IndexGeneratorReducer->[serializeOutIndex->[progress],reduce->[progress->[progress]],copyFile->[progress]]]] | Reduce the data. private finalFile = null ;. | The case where there is just no data at all should probably be an exception and checked before this persist block. It is never "supposed" to happen given how the index generator job is set up, but in the event that it does occur, this condition will be false, so execution will fall through to mergeQueryableIndexes belo... |
@@ -20,11 +20,12 @@ namespace System
{
// We impose limits on maximum array length in each dimension to allow efficient
// implementation of advanced range check elimination in future.
- // Keep in sync with vm\gcscan.cpp and HashHelpers.MaxPrimeArrayLength.
- // The constants are d... | [Array->[IndexOf->[IndexOf,GetValue,Equals,Add],Clear->[Clear],GetValue->[GetValue],LastIndexOf->[GetValue,Equals,LastIndexOf,Add],GetHashCode->[GetValue,Add,GetHashCode],CopyTo->[Copy,CopyTo],Reverse->[SetValue,Reverse,GetValue,Add],BinarySearch->[GetMedian,GetValue,BinarySearch],Copy->[Copy],FindLastIndex->[FindLastI... | Abstract class for creating a new array of objects with a maximum length of 1. This method is called to resize an array of objects to a new size. | > We impose limits on maximum array length in each dimension to allow efficient implementation of advanced range check elimination in future. @dotnet/jit-contrib Do you believe that artificially limiting array length to `0X7FEFFFFF` (instead of `0x7FFFFFC7` that is the natural GC limit) will be ever useful to enable th... |
@@ -97,7 +97,7 @@ public abstract class AbstractTransactionBoundaryCommand implements TransactionB
* Returning a null usually means the transactional command succeeded.
* @return return value to respond to a remote caller with if the transaction context is invalid.
*/
- protected Object invalidRemoteTx... | [AbstractTransactionBoundaryCommand->[hashCode->[hashCode],perform->[invalidRemoteTxReturnValue],equals->[equals]]] | This method is called by the invocation point when a remote transaction is invalid. | shall we delete it if no longer used? |
@@ -12,7 +12,7 @@ namespace Dynamo.Wpf
customizations = customizationMap ?? new Dictionary<Type, IEnumerable<Type>>();
}
- public IDictionary<Type, IEnumerable<Type>> GetCustomizations()
+ public IDictionary<Type, IEnumerable<Type>> GetCustomizations(ILogger logger)
{
... | [No CFG could be retrieved] | Get customizations for this type. | I guess this feels a little funny - that we don't do anything with the logger here... |
@@ -29,6 +29,7 @@ type Metadata struct {
UserAgent UserAgent
Client Client
Cloud Cloud
+ Message Message
Labels common.MapStr
}
| [set->[fields,maybeSetMapStr,Fields]] | set sets the metadata fields. | Our "Metadata" is roughly equivalent to OpenTelemetry's "Resource" - information about the service, or the environment in which the service is operating. Message details don't belong here, as they're operation-specific. |
@@ -461,8 +461,10 @@ namespace System.Runtime.Serialization
_helper.EnsureMethodsImported();
}
- public override void WriteXmlValue(XmlWriterDelegator xmlWriter, object obj, XmlObjectSerializerWriteContext context)
+ public override void WriteXmlValue(XmlWriterDelegator xmlWriter, ... | [No CFG could be retrieved] | Replies the base object that this class is declared in. AccessPermission for deserialization. | most of the time when writing any objects they're nullable, please double check this should be non-null |
@@ -12,10 +12,11 @@ class Uploader(object):
self.requester = requester
self.verify = verify
- def post(self, url, content):
+ def post(self, url, content, auth=None):
self.output.info("")
it = upload_in_chunks(content, self.chunk_size, self.output)
- return self.reques... | [print_progress->[rewrite_line],progress_units->[int],Uploader->[post->[info,upload_in_chunks,put,IterableToFileAdapter]],chunker->[range,len],IterableToFileAdapter->[read->[next],__init__->[iter,len],__iter__->[__iter__]],Downloader->[download->[print_progress,progress_units,int,debug,ConanException,get,extend,len,Con... | Initialize the object. | I know it was already like this, but I would like to rename the "post" method to upload. It's weird a post method doing a put |
@@ -50,6 +50,12 @@ installVariableService(AMP.win);
const MAX_REPLACES = 16; // The maximum number of entries in a extraUrlParamsReplaceMap
+const BLACKLIST_EVENT_IN_SANDBOX = [
+ AnalyticsEventType.CLICK,
+ AnalyticsEventType.TIMER,
+ AnalyticsEventType.SCROLL,
+];
+
export class AmpAnalytics extends AMP.Base... | [No CFG could be retrieved] | The AMP Analytics class. The predefined type associated with the tag. If not specified the inline config is merged with the. | shall we do whitelist instead? |
@@ -62,7 +62,7 @@ public class DefaultEmbeddedContainerBuilder implements EmbeddedContainer.Embedd
@Override
public EmbeddedContainer.EmbeddedContainerBuilder withApplicationConfiguration(ApplicationConfiguration applicationConfigruation) {
- this.applicationConfigruation = applicationConfigruation;
+ thi... | [DefaultEmbeddedContainerBuilder->[createEmbeddedImplClassLoader->[build]]] | Allows to override the application configuration and log4j configuration file. | the param has the same typo |
@@ -146,13 +146,13 @@ var uppercase = function(string) {return isString(string) ? string.toUpperCase()
var manualLowercase = function(s) {
- /* jshint bitwise: false */
+ /* JSHint bitwise: false */
return isString(s)
? s.replace(/[A-Z]/g, function(ch) {return String.fromCharCode(ch.charCodeAt(0) | 32)... | [No CFG could be retrieved] | Provides a function to convert a string to lowercase. Converts a string to uppercase. | This capitalization of `JSHint` is not recognized and the code below generates a lint error. Same below |
@@ -88,7 +88,7 @@ func (c *NameLookupCache) GetImageStore(ctx context.Context, storeName string) (
// Add Scratch
scratch, err := c.DataStore.GetImage(ctx, store, Scratch.ID)
if err != nil {
- log.Errorf("Error looking up scratch on %s: %s", store.String(), err)
+ log.Errorf("ImageCache Error: looking up s... | [GetImage->[GetImage,GetImageStore],ListImages->[GetImage,GetImageStore],WriteImage->[WriteImage],GetImageStore->[GetImageStore],CreateImageStore->[CreateImageStore,GetImageStore]] | GetImageStore returns the URL of the image in the given store. This function is called when an image is found on the datastore. It will insert the image. | should be using the `errorf` function? |
@@ -267,10 +267,13 @@ READ8_MEMBER( towns_state::towns_video_cff80_r )
else
return 0x00;
case 0x06:
+ ret |= 0x10;
+ xpos = machine().first_screen()->hpos();
+ if(xpos < m_video.towns_crtc_layerscr[0].max_x && xpos > m_video.towns_crtc_layerscr[0].min_x)
+ ret |= 0x80;
if(m_video.towns_vblank_f... | [ switch->[towns_update_palette,towns_crtc_refresh_mode,towns_update_kanji_offset],ir3_w->[ir3_w,draw_sprites,draw_text_layer],pointer->[base,pointer],towns_crtc_draw_layer->[towns_crtc_draw_scan_layer_hicolour,towns_crtc_draw_scan_layer_16,towns_crtc_draw_scan_layer_256],draw_sprites->[render_sprite_4,render_sprite_16... | read from memory - mapped port 0xcff80 - read from towns_state. | Any particular reason you're using machine().first_screen() instead of m_screen? |
@@ -102,6 +102,15 @@ verbose = partial(
help='Give more output. Option is additive, and can be used up to 3 times.'
)
+no_color = partial(
+ Option,
+ '--no-color',
+ dest='no_color',
+ action='store_true',
+ default=False,
+ help="Suppress colored output"
+)
+
version = partial(
Option,... | [only_binary->[Option,set,FormatControl],_handle_only_binary->[getattr,fmt_ctl_handle_mutual_exclude],exists_action->[Option],trusted_host->[Option],extra_index_url->[Option],make_option_group->[add_option,option,OptionGroup],constraints->[Option],check_install_build_global->[getname->[getattr],any,fmt_ctl_no_binary,wa... | Add additional options to the command line. Create a command line option that displays a single non - terminal error in the console. | nit: a final comma will prevent the need to change this line if anything is added |
@@ -164,8 +164,9 @@ module.exports = {
};
// Mark standard asynchronous functions.
-ref1 = ['showMessageBox', 'showOpenDialog', 'showSaveDialog'];
+var ref1 = ['showMessageBox', 'showOpenDialog', 'showSaveDialog'];
+var j, len
for (j = 0, len = ref1.length; j < len; j++) {
- api = ref1[j];
+ var api = ref1[j];
... | [No CFG could be retrieved] | Mark standard asynchronous functions. | The var should be declared outside of the loop. If you look for "for (" you'll find it happening in a couple extra places. You will also find some loops written in a single long line. ESLint can detect both of this issues and more, so maybe we should run it over the generated code to spot common issues. |
@@ -211,13 +211,14 @@ module.exports = class extends Generator {
* @param languages
*/
updateLanguagesInLanguagePipe(languages) {
- if (this.clientFramework !== 'angularX') {
+ if (!['angularX', 'react'].includes(this.clientFramework)) {
return;
}
- const full... | [No CFG could be retrieved] | Creates a language - specific key file with the given languages in the language pipe. Update Languages In Webpack. | I think this check can be removed as we only have angularX and react now |
@@ -58,7 +58,7 @@ function insertExtensionBundlesConfig(bundle) {
})
);
- execOrThrow(`npx prettier --write ${extensionBundlesJson}`);
+ execOrThrow(`npx prettier --write ${extensionBundlesJson}`, '');
}
module.exports = {insertExtensionBundlesConfig};
| [No CFG could be retrieved] | Create an extension bundles config file. | Same as before, make this an explicit message like `Could not format extension bundle`. |
@@ -1422,10 +1422,15 @@ public abstract class NiFiProperties {
public static NiFiProperties createBasicNiFiProperties(final String propertiesFilePath, final Map<String, String> additionalProperties) {
final Map<String, String> addProps = (additionalProperties == null) ? Collections.EMPTY_MAP : additionalP... | [NiFiProperties->[getComponentDocumentationWorkingDirectory->[getProperty],getKerberosSpnegoKeytabLocation->[getProperty],getFlowConfigurationFile->[getProperty],getAutoResumeState->[getProperty],getOidcClientId->[getProperty],getEmbeddedZooKeeperPropertiesFile->[getProperty],getHttpNetworkInterfaces->[getPropertyKeys,... | Creates basic NiFiProperties. | Was this included on accident? Does not seem relevant to your ticket. |
@@ -90,8 +90,8 @@ class Seacas(CMakePackage):
depends_on('adios2@develop~mpi', when='+adios2 ~mpi')
depends_on('adios2@develop+mpi', when='+adios2 +mpi')
depends_on('matio', when='+matio')
- depends_on('metis+int64+real64', when='+metis ~mpi')
- depends_on('parmetis+int64+real64', when='+metis +mpi... | [Seacas->[setup_run_environment->[prepend_path],cmake_args->[append,Version,extend,from_variant,macos_version],variant,depends_on,version]] | description = Sets all required attributes of a single object. Run the environment for C ++. | Why did you drop `~mpi`? Do you want both metis and parmetis when `+mpi`? |
@@ -237,11 +237,11 @@ def _check_outlines(pos, outlines, head_scale=0.85):
ear_y = np.array([.0555, .0775, .0783, .0746, .0555, -.0055, -.0932,
-.1313, -.1384, -.1199])
x, y = pos[:, :2].T
- x_range = np.abs(x.max() - x.min())
- y_range = np.abs(y.max() - y.min... | [plot_ica_components->[_make_image_mask,plot_ica_components,_check_outlines,_prepare_topo_plot,plot_topomap],_plot_topomap_multi_cbar->[plot_topomap],plot_evoked_topomap->[_make_image_mask,_prepare_topo_plot,plot_topomap,_check_outlines],plot_tfr_topomap->[_prepare_topo_plot,plot_topomap],plot_topomap->[show_names,_gri... | Check or create the outlines for topoplot . Returns the position and outlines of the image. | how is this stuff related? |
@@ -20,8 +20,14 @@ EXPECTED_HEADER = dedent("""\
EXPECTED_NUM_LINES = 3
-_current_year = str(datetime.datetime.now().year)
-_current_century_regex = re.compile(r'20\d\d')
+CURRENT_YEAR = str(datetime.datetime.now().year)
+CURRENT_CENTURY_REGEX = re.compile(r'20\d\d')
+
+PY2_DIRECTORIES = {
+ Path("contrib/python/... | [check_copyright_year->[HeaderCheckFailure],check_matches_header->[HeaderCheckFailure],check_header_present->[HeaderCheckFailure],get_header_lines->[HeaderCheckFailure],check_dir->[check_header],main] | Check that all. py files in dirs start with the correct header. Raises HeaderCheckFailure if the header doesn t match. | This all looks good but if I haven't pointed it out already, we already have a rule that does all this introduced in #7515. It already has enough flexibility to apply header checks to subsets of paths although it uses whitelists and could stand support for blacklists to make path specification more concise and less bri... |
@@ -116,7 +116,13 @@ namespace Content.Server.GameObjects.Components.Interactable
if (_solutionComponent == null)
return false;
- return _solutionComponent.TryRemoveReagent("chem.WeldingFuel", ReagentUnit.New(value));
+ bool succeeded = _solutionComponent.TryRemoveR... | [WelderComponent->[UseEntity->[ToggleWelderStatus],OnUpdate->[ToggleWelderStatus],Initialize->[Initialize],ToggleWelderStatus->[CanLitWelder],UseTool->[UseTool],SuicideKind->[TryWeld]]] | Try to find a fuel in the welder. | Maybe add a serialized data field for this instead of hardcoding it |
@@ -47,6 +47,7 @@ func init() {
flags.BoolVarP(&execCommand.Tty, "tty", "t", false, "Allocate a pseudo-TTY. The default is false")
flags.StringVarP(&execCommand.User, "user", "u", "", "Sets the username or UID used and optionally the groupname or GID for the specified command")
+ flags.IntVar(&execCommand.Preserv... | [Exec,SetInterspersed,JoinNS,SetUsageTemplate,Exit,PID,StringVarP,GetRuntime,Errorf,Wrapf,StringSliceVarP,SetSkipStorageSetup,Shutdown,GetLatestContainer,Sprintf,LookupContainer,BoolVarP,Flags,BoolVar] | execDescription is a description of a process in a running container Yields the container object from the command line. | I think flatpak passes in the specific numbers of the FDs in question, and allows the flag to be specified multiple times. Not sure if compatibility with them is important here. |
@@ -15,8 +15,6 @@
// specific language governing permissions and limitations
// under the License.
-// +build !integration
-
package status
import (
| [Context,Unlock,RemoteAddr,HandlerFunc,NewUnstartedServer,Now,Close,Fetch,Set,Done,Error,NewTestModule,Start,Lock,Len,Logf,Since,NewScanner,EqualValues,Equal,Contains,Name,NoError,Module,Header,Write,NewServer,NewEventFetcher,Glob,String,StringToPrint,Open,WriteHeader,True,FailNow] | Creates a response object from a non - empty object. Returns a list of all the number of total accesses in a system. | Why was this removed? |
@@ -71,3 +71,16 @@ func (m *SmapMapper) NewSourcemapAdded(id Id) {
}
m.Accessor.Remove(id)
}
+
+func subSlice(from, to int, content []string) []string {
+ if from > len(content) {
+ return content
+ }
+ if from < 0 {
+ from = 0
+ }
+ if to > len(content) {
+ to = len(content)
+ }
+ return content[from:to]
+}
| [NewSourcemapAdded->[Fetch,Remove,Warnf,NewLogger],Apply->[Sprintf,Fetch,Source,String]] | NewSourcemapAdded is called when a new sourcemap has been added to the mapper. | If I read correct, then in this case we would store the whole `content`. I suggest to return an empty array and to log an error. |
@@ -93,6 +93,18 @@ if (defined('SHOW_SETTINGS')) {
$host_down_count++;
}
+ if ($config['force_ip_to_sysname'] === true) {
+ $deviceDisplay = $device["sysName"];
+ } elseif ($config['webui']['availability_map_sysname_mix'] == 1) {
+ if (... | [No CFG could be retrieved] | Get all device availability counts. Show the nexus device. | I'm not really sure what all of this if/elseif/else statement is doing but surely you can just do: `$deviceDisplay = ip_to_sysname($device['hostname']);` |
@@ -117,6 +117,11 @@ class Geant4(CMakePackage):
'-DXERCESC_ROOT_DIR={0}'.format(spec['xerces-c'].prefix)
]
+ # Don't install the package cache file as Spack will set
+ # up CMAKE_PREFIX_PATH etc for the dependencies
+ if spec.version > Version('10.5.99'):
+ optio... | [Geant4->[cmake_args->[join_path,append,Version,format,define_from_variant],depends_on,extends,conflicts,version,patch,variant]] | Return a list of CMake command line options for the object. Get options for . | Just out of curiosity: Why are you not using `spec.satisfies('@10.5.99:')`? or even `spec.satisfies('@10.6:')`? |
@@ -161,6 +161,8 @@ class DOIExportPlugin extends ImportExportPlugin {
case 'suppFiles':
// Test mode.
$templateMgr->assign('testMode', $this->isTestMode($request)?array('testMode' => 1):array());
+ $filter = $request->getUserVar('filter');
+ $templateMgr->assign('filter', $request->getUserVar('filt... | [DOIExportPlugin->[_prepareArticleDataByArticleId->[getCache],_instantiateSettingsForm->[getSettingsFormClassName],_getUnregisteredArticles->[getPluginId],_prepareGalleyData->[prepareArticleFileData],exportObjects->[getPluginId],_prepareArticleData->[getCache],displayArticleList->[registerDaoHook,getTemplatePath,getAll... | Display the specified objects in the journal. | Is this line dead code? The line below gets from the request again. |
@@ -154,7 +154,7 @@ int tls_parse_ctos_srp(SSL *s, PACKET *pkt, unsigned int context, X509 *x,
* upon resumption. Instead, we MUST ignore the login.
*/
if (!PACKET_strndup(&srp_I, &s->srp_ctx.login)) {
- *al = TLS1_AD_INTERNAL_ERROR;
+ *al = SSL_AD_INTERNAL_ERROR;
return 0;
... | [tls_construct_stoc_etm->[SSLerr,WPACKET_put_bytes_u16],tls_parse_ctos_supported_groups->[OPENSSL_free,PACKET_remaining,PACKET_memdup,PACKET_as_length_prefixed_2],tls_parse_ctos_ems->[PACKET_remaining],tls_construct_stoc_psk->[WPACKET_close,SSLerr,WPACKET_put_bytes_u16,WPACKET_start_sub_packet_u16],tls_parse_ctos_statu... | Parse a CTCP SRP packet. | Why the many changes from TLS1_AD_FOO to SSL_AD_FOO? |
@@ -13,6 +13,9 @@ frappe.ui.form.Attachments = Class.extend({
this.parent.find(".add-attachment").click(function() {
me.new_attachment();
});
+ this.parent.find(".add-gsuite").click(function() {
+ me.new_gsuite();
+ });
this.add_attachment_wrapper = this.parent.find(".add_attachment").parent();
this... | [No CFG could be retrieved] | Component that provides a list of attachments. Add attachment to the attachment table. | This should be in the attachment popup, we can directly have an option to upload to GSuite or any other service in a generic way. Can you do that? |
@@ -58,12 +58,12 @@ export class Home extends React.Component<IHomeProp, IHomeState> {
return (
<Row>
<Col md="9">
- <h2><Translate contentKey="home.title">Welcome, Java Hipster!</Translate></h2>
+ <h2 id="home.title"><Translate contentKey="home.title">Welcome, Java Hipster!</Tran... | [No CFG could be retrieved] | A component that displays a user s home page. Reads the from the System. | dot case in id is weird, can we use dash case |
@@ -184,7 +184,7 @@ public class SimpleChannelPool implements ChannelPool {
assert ch.eventLoop().inEventLoop();
if (future.isSuccess()) {
- if (future.getNow() == Boolean.TRUE) {
+ if (future.getNow()) {
try {
ch.attr(POOL_KEY).set(this);
... | [SimpleChannelPool->[acquire->[acquire],notifyHealthCheck->[acquireHealthyFromPoolOrNew],release->[release],closeAndFail->[closeChannel],close->[close,pollChannel]]] | Notify the health check. | @windie actually I think this should stay like it was as getNow() really return a Boolean. |
@@ -154,6 +154,17 @@ func (s *BoltState) getDBCon() (*bolt.DB, error) {
return db, nil
}
+// Close a connection to the database.
+// MUST be used in place of `db.Close()` to ensure proper unlocking of the
+// state.
+func (s *BoltState) closeDBCon(db *bolt.DB) error {
+ err := db.Close()
+
+ s.dbLock.Unlock()
+
+ ... | [addContainer->[ID,Wrapf,Bucket,Equal,Get,Marshal,Update,Put,Name,CreateBucket,Close,Dependencies,Namespace,setNamespaceStatePath,getDBCon],getPodFromDB->[Wrapf,Join,Equal,Bucket,Unmarshal,GetLockfile,Get],removeContainer->[ID,Wrapf,Join,Bucket,ForEach,Name,Dependencies,Delete,Errorf,Get,DeleteBucket],getDBCon->[Wrapf,... | getDBCon returns a bolt. DB connection to the database. | Should we unlock if err != nil? |
@@ -319,6 +319,9 @@
<div className={'col-right'}>
<div className={'tab-pane ui-tabs ui-widget ui-widget-content ui-corner-all'} id='groups-tabs'>
<AddGroupButton refresh={this.props.refresh} />
+ <% if @assignment.group_max == 1 %>
+ <%= button_to "Add all groups... | [No CFG could be retrieved] | Renders the group missing items in the group table. Hides the hidden input and renders the nag group modal. | "Add all groups" should be in the language files. |
@@ -633,11 +633,14 @@ function $CompileProvider($provide) {
if (NG_ATTR_BINDING.test(ngAttrName)) {
name = ngAttrName.substr(6).toLowerCase();
}
- if ((index = ngAttrName.lastIndexOf('Start')) != -1 && index == ngAttrName.length - 5) {
+
+ var dir... | [No CFG could be retrieved] | Collects directives for a given node. directive add directives add textInterpolateDirectives addComment. | I get that `attr{Start,End}Name` should be set back to false, but why change this condition and involve a regex? What's wrong with using `lastIndexOf` here? If this way is the way to go, then remove the `index` variable (L626) since it's no longer used, and also cache the regex |
@@ -126,6 +126,11 @@ public class ArtifactArchiver extends Recorder {
return true;
}
+ if (build.getResult().isWorseThan(Result.UNSTABLE) && onlyIfSuccessful) {
+ listener.getLogger().println(Messages.ArtifactArchiver_SkipBecauseOnlyIfSuccessful());
+ return true;
+ ... | [ArtifactArchiver->[perform->[listenerWarnOrError]]] | Checks if the build has a matching artifact. | I'd say that such check can confuse users. "UNSTABLE" is not successful in Jenkins terms. What about the approach from Run Conditions? In this plugin users can determine upper and lower bounds for the build's status |
@@ -126,12 +126,16 @@ public class Orchestrator implements SpecCatalogListener, Instrumentable {
this.flowOrchestrationFailedMeter = Optional.of(this.metricContext.meter(ServiceMetricNames.FLOW_ORCHESTRATION_FAILED_METER));
this.flowOrchestrationTimer = Optional.of(this.metricContext.timer(ServiceMetricNa... | [Orchestrator->[onAddSpec->[onAddSpec],onUpdateSpec->[onAddSpec,onDeleteSpec],onDeleteSpec->[onDeleteSpec]]] | Creates an instance of the Orchestrator class. Constructor with no logging. | Not sure gauge is the right choice. Let's discuss this. |
@@ -367,7 +367,7 @@ namespace System.IO
/// not work, we simply return the char associated with that
/// key with ConsoleKey set to default value.
/// </summary>
- public unsafe ConsoleKeyInfo ReadKey(out bool previouslyProcessed)
+ private unsafe ConsoleKeyInfo ReadKeyCore(bool... | [StdInReader->[ReadOrPeek->[Peek,ReadLine],ConsoleKeyInfo->[IsUnprocessedBufferEmpty,MapBufferToConsoleKey,AppendExtraBuffer,ReadStdin],ReadLine->[ReadLine],AppendExtraBuffer->[IsUnprocessedBufferEmpty],MapBufferToConsoleKey->[IsUnprocessedBufferEmpty,MapBufferToConsoleKey],ReadStdin->[ReadStdin]]] | Reads a key from the console. | This method can return cached keys. Probably that means values pushed into this cache should be read under convertCrToNl: false, so we may/may not convert them when popping them here? |
@@ -7,5 +7,3 @@
* @TODO consider merge into core files
*/
define('ASK_A_QUESTION', 'Ask a question about this product');
-define('BUTTON_IMAGE_ASK_A_QUESTION','button_ask_a_question.gif');
-define('BUTTON_ASK_A_QUESTION_ALT', 'Ask a Question');
| [No CFG could be retrieved] | END of function check_common_properties. | I guess this single remaining constant should be moved into `english.php` and this file deleted. |
@@ -43,7 +43,8 @@ public class EventBenchmark extends AbstractBenchmark {
flow = createFlow(muleContext);
muleContext.getRegistry().registerFlowConstruct(flow);
Message.Builder messageBuilder = Message.builder().payload(PAYLOAD);
- Event.Builder eventBuilder = Event.builder(DefaultEventContext.create(... | [EventBenchmark->[createMuleEventWithFlowVarsAndProperties->[createMuleEvent]]] | Setup the Mule context. | you changed the used constant in this class |
@@ -495,7 +495,7 @@ type Tx struct {
}
// NewTx builds a transaction presenter.
-func NewTx(tx *models.Tx) Tx {
+func NewTx(tx *models.Tx) (Tx, error) {
return Tx{
Confirmed: tx.Confirmed,
Data: hexutil.Bytes(tx.Data),
| [FriendlyPayment->[String],FriendlyParams->[String],FriendlyTasks->[String],GetID->[String],String->[String],String] | NewAccount is a jsonapi wrapper for an Ethereum account. SetID sets the ID of the transaction. | Optional: This no longer needs to return a tuple with an error. |
@@ -55,6 +55,18 @@ class PexRuntimeEnvironment(Subsystem):
"`[python-setup]` to influence where interpreters are searched for."
),
)
+ register(
+ "--verbosity",
+ advanced=True,
+ type=int,
+ default=0,
+ help=(
+ ... | [rules->[rules],PexRuntimeEnvironment->[path->[iter_path_entries]],find_pex_python->[first_python_binary,PexEnvironment]] | Register options for a specific a . | See above about a proposal to remove this mapping. If we do that, we can simplify this to something like: > Set the verbosity level of PEX logging, from 0 (no logging) up to 9 (max logging). |
@@ -17,7 +17,8 @@
import {BrowserController, RequestBank} from '../../testing/test-helper';
import {parseQueryString} from '../../src/url';
-// TODO(wg-analytics): These tests cause SauceLabs disconnections.
+// TODO(wg-analytics): These tests time out on Firefox and Safari
+// (locally too) which causes browser di... | [No CFG could be retrieved] | Displays a pageview with a specific client ID and a request to the AMP HTML Auth A function to test if a specific request is not found in the request bank. | Is there a tracking issue we could link to here? |
@@ -138,7 +138,7 @@ public class XsltPayloadTransformer extends AbstractTransformer implements BeanC
this.templates = templates;
this.resultTransformer = resultTransformer;
}
-
+
/**
* Sets the SourceFactory.
*
| [XsltPayloadTransformer->[transformUsingResultFactory->[createSource,transformSource,DOMSource,StringSource],createStreamSourceOnResource->[StreamSource,getInputStream,toString],setBeanClassLoader->[notNull],onInit->[newInstance,createStreamSourceOnResource,onInit,getBeanFactory,createStandardEvaluationContext,newTempl... | Creates a payload transformer. Use source factory if not explicitly set. | Please, be carefull with code before push. |
@@ -350,7 +350,7 @@ public class MatcherJsonIO {
// add SUSE Manager entitlements
return concat(
- products.stream().map(SUSEProduct::getProductId),
+ server.isPayg() ? Stream.empty() : products.stream().map(SUSEProduct::getProductId),
entitlementIdsFor... | [MatcherJsonIO->[jsonSystemForSelf->[computeSelfProductIds],generateMatcherInput->[getJsonSubscriptions,getJsonSystems,getJsonMatches,getJsonProducts]]] | Returns a Stream of product ids for the given server. | @hustodemon this means that those systems will get no product rather than free products from the matcher's POV. Are you explicitly OK with that? |
@@ -155,6 +155,12 @@ class LocalDynamicFiltersCollector
return futuresLeft == 0;
}
+ @Override
+ public synchronized boolean isAwaitable()
+ {
+ return futuresLeft > 0;
+ }
+
@Override
public synchronized TupleDomain<ColumnHandle> getCurre... | [LocalDynamicFiltersCollector->[collectDynamicFilterDomains->[getValue,verify,get,getKey,set,forEach],register->[forEach,create,verify,put],createDynamicFilter->[toImmutableSetMultimap,getInput,from,TableSpecificDynamicFilter,collect,toImmutableList],TableSpecificDynamicFilter->[isBlocked->[unmodifiableFuture],update->... | Returns true if the current predicate is complete. | or `!isBlocked.isDone()` ? |
@@ -136,6 +136,8 @@
it appears to be a 4-dword FIFO or something along those lines.
*/
+#include <cmath>
+
#include "emu.h"
#include "bus/ata/ataintf.h"
| [No CFG could be retrieved] | The MIDI system has a bunch of different ways to set up the base framebuffer pointer List of objects that contain a sequence of strings representing a sequence of strings. | Please include standard library headers includes after all the MAME headers (this would go between wdlfft/fft.h and firebeat.lh). |
@@ -863,10 +863,7 @@ namespace ProtoAssociative
SymbolNode classSymbol = new SymbolNode();
classSymbol.name = className;
classSymbol.classScope = classIndex;
-
- GraphNode dependentNode = new GraphNode();
- dependentNod... | [CodeGen->[EmitDependency->[SetEntry],GetFirstSymbolFromIdentList->[GetFirstSymbolFromIdentList],DFSEmitSSA_AST->[EmitSSALHS,DFSEmitSSA_AST,SSAIdentList,GetReplicationGuides,EmitSSAArrayIndex],CyclicDependencyTest->[StrongConnectComponent],DfsSSAIeentList->[DfsSSAIeentList],EmitGetterSetterForIdentList->[EmitIdentifier... | Traverse a dot - call. Check if a node can be assigned a type. This method is called when a node is missing a node in the list of nodes. It DfsTraverse - Traverse the tree and emit a node if it is not in the DfsTraverse - Traverse the DfsNode and add the n - th node to. | Seems for all `PushSymbolAsDependentToGraphNode()` calls, the second parameters are all `UpdateNodeType.kSymbol`. Is it coincident? If not, we may remove the second parameter. |
@@ -138,8 +138,7 @@ _MethodDescriptorType = type(str.upper)
_ANY_VAR_POSITIONAL = typehints.Tuple[typehints.Any, ...]
_ANY_VAR_KEYWORD = typehints.Dict[typehints.Any, typehints.Any]
-# TODO(BEAM-8280): Remove this when from_callable is ready to be enabled.
-_enable_from_callable = False
+_disable_from_callable = Fa... | [with_output_types->[annotate_output_types->[with_output_types,empty]],IOTypeHints->[with_output_types->[annotate_output_types->[],_make_origin],with_input_types->[_make_origin],from_callable->[get_signature,IOTypeHints,_make_origin],with_defaults->[IOTypeHints,_make_origin],debug_str->[__repr__],__eq__->[same],empty->... | Adds a type - hint to the type - hint list. Return an ArgSpec with at least one positional argument and any number of other arguments. | Should this be True? (based on the check in line 234) |
@@ -368,6 +368,11 @@ def ast_to_func(ast_root, dyfunc, delete_on_exit=True):
TODO: If only decorate one of inner function instead of decorating the main
function, the other inner functions are invisible for the decorated function.
"""
+
+ def remove_file(filepath):
+ if os.path.exists(filepath)... | [is_dygraph_api->[is_api_in_module],RenameTransformer->[visit_Attribute->[get_attribute_full_name]],ForNodeVisitor->[_get_iter_var_name->[is_for_iter,is_for_enumerate_iter,is_for_range_iter],_parse_for_stmts->[NameNodeReplaceTransformer],_build_var_len_assign_node->[parse,ast_to_source_code],_get_enum_idx_name->[is_for... | Transform modified AST of decorated function into python callable object. | Rename it to "remove_if_exit" to increase readability if you have time. Since this PR is small, I can approve it and you can choose to change it in this PR or in the future. |
@@ -44,6 +44,7 @@ class RegistrationsController < Devise::RegistrationsController
resource.add_role(:super_admin)
resource.add_role(:trusted)
+ resource.skip_confirmation!
Settings::General.waiting_on_first_user = false
Users::CreateMascotAccount.call
end
| [RegistrationsController->[build_devise_resource->[check_allowed_email]]] | Checks if the user has permission to do something. | This looks pretty reasonable. If they're `trusted` and a `super_admin` because they're the first user, it probably makes a lot of sense to just ignore the confirmation. When I set up my own Forem without SendGrid or anything like that after I first started here, I had to get the confirmation URL from the Rails logs fro... |
@@ -0,0 +1,11 @@
+# typed: true
+
+extend T::Sig
+
+sig {returns(T.nilable(T::Array[Integer]))}
+def foo
+ nil
+end
+
+T.reveal_type((a, b = foo)) # error: Revealed type: `T.nilable(T::Array[Integer])`
+T.reveal_type((c, *, d = 100)) # error: Revealed type: `Integer(100)`
| [No CFG could be retrieved] | No Summary Found. | Can you make an `ast.exp` snapshot for this test? I'd like to see what the desugared output looks like. |
@@ -60,6 +60,10 @@ public class ManagedUserDTO extends UserDTO {
this.lastModifiedDate = lastModifiedDate;
}<% } %>
+ public String getPassword() {
+ return password;
+ }
+
@Override
public String toString() {
return "ManagedUserDTO{" +
| [No CFG could be retrieved] | Gets the last modified date of the managed user. | I don't think it's a good idea to append the encrypted password in the toString method, it could easily be printed in application logs by mistake. |
@@ -59,6 +59,7 @@ public class RegisterQualityGates implements Startable {
QualityGateDto builtin = qualityGates.create(BUILTIN_QUALITY_GATE);
qualityGates.createCondition(builtin.getId(), CoreMetrics.BLOCKER_VIOLATIONS_KEY, QualityGateConditionDto.OPERATOR_GREATER_THAN, null, "0", null);
qualityGates.cr... | [RegisterQualityGates->[start->[shouldRegisterBuiltinQualityGate,registerBuiltinQualityGate,createBuiltinQualityGate],shouldRegisterBuiltinQualityGate->[countByTypeAndKey],registerBuiltinQualityGate->[insert,LoadedTemplateDto],createBuiltinQualityGate->[create,createCondition,getId]]] | Creates the builtin quality gate. | I didn't test that limit is 5 (%) but not 0.05. |
@@ -34,7 +34,7 @@ public final class DataflowReleaseInfo extends GenericJson {
private static final Logger LOG = LoggerFactory.getLogger(DataflowReleaseInfo.class);
private static final String DATAFLOW_PROPERTIES_PATH =
- "/org.apache.beam/sdk/sdk.properties";
+ "/org/apache/beam/sdk/sdk.properties";
... | [DataflowReleaseInfo->[LazyInit->[DataflowReleaseInfo]]] | Creates a new instance of a DataflowReleaseInfo class. Reads the Properties from the specified resource path. | Please rename file to BeamReleaseInfo or just ReleaseInfo |
@@ -674,6 +674,14 @@ EOT;
'title' => $this->_to_utf8( $this->_get_title( $post->post_title, $post->post_content ) ),
'date' => get_the_date( '', $post->ID ),
'format' => get_post_format( $post->ID ),
+ /**
+ * Filters the rel attribute for the Related Posts' links.
+ *
+ * @since 3.7.0
+ *
+ ... | [Jetpack_RelatedPosts->[_generate_related_post_image_params->[get_options],_get_related_posts->[_get_related_post_data_for_post],_enabled_for_request->[get_options],_action_frontend_init_ajax->[get_for_post_id,get_options],get_for_post_id->[get_options],parse_options->[get_options],print_setting_html->[get_options]],Je... | Returns an array of related post data for a post. | Why not just have rel be the actual rel value on the anchor and allow developers to filter on `nofollow` directly rather then have a bool flag add it in JS? |
@@ -1,8 +1,9 @@
from tempfile import TemporaryDirectory
-from typing import Any
+from typing import Any, TYPE_CHECKING
-from dulwich.index import build_index_from_tree
-from dulwich.porcelain import clone
+if TYPE_CHECKING:
+ from dulwich.index import build_index_from_tree
+ from dulwich.porcelain import clone... | [TemporaryGitRepo->[checkout_ref->[build_index_from_tree,index_path,get_tree_id_for_branch_or_tag],__enter__->[checkout_ref,TemporaryDirectory,clone],branch_or_tag_ref->[encode,ValueError],get_tree_id_for_branch_or_tag->[encode,get_refs],__exit__->[cleanup],__init__->[ValueError]]] | Creates a temporary git repository that clones a branch and a tag. Checkout a specific ref from the repo. | This will break your `TemporaryGitRepo` class |
@@ -128,10 +128,6 @@ namespace RevitServices.Persistence
TransactionManager.Instance.EnsureInTransaction(
DocumentManager.Instance.CurrentDBDocument);
Instance.CurrentDBDocument.Regenerate();
- // To ensure the transaction is closed in the idle proce... | [DocumentManager->[Regenerate->[Regenerate,EnsureInTransaction,DoAssertInIdleThread,ForceCloseTransaction,CurrentDBDocument,ExecuteOnIdleSync],ElementsOfCategory->[OfCategory],ElementExistsInDocument->[TryGetElement,UUID],ElementsOfType->[OfClass],DeleteElement->[TransactionTaskDone,GetIdForUUID,Delete,EnsureInTransact... | Regenerate the object if it is in the idle thread. | Yes, I'm not quite sure why this is here. Can you explain why it was here before? |
@@ -0,0 +1,10 @@
+// Copyright 2016-2017, Pulumi Corporation. All rights reserved.
+
+package resource
+
+import (
+ "github.com/pulumi/pulumi/pkg/tokens"
+)
+
+// RootStackType is the type name that will be used for the root component in the Pulumi resource tree.
+const RootStackType tokens.Type = "pulumi:pulumi:Stac... | [No CFG could be retrieved] | No Summary Found. | Note that we already had this constant in `pkg/resource/stack/deployment.go#RootPulumiStackTypeName`. Can we use one of these for both use cases? |
@@ -112,12 +112,6 @@ public interface Expr
*/
String stringify();
- /**
- * Programmatically inspect the {@link Expr} tree with a {@link Visitor}. Each {@link Expr} is responsible for
- * ensuring the {@link Visitor} can visit all of its {@link Expr} children before visiting itself
- */
- void visit(Vi... | [BindingAnalysis->[withScalarArguments->[BindingAnalysis,getIdentifierExprIfIdentifierExpr],with->[analyzeInputs,BindingAnalysis,with],withArrayArguments->[BindingAnalysis,getIdentifierExprIfIdentifierExpr],withArrayOutput->[BindingAnalysis],removeLambdaArguments->[BindingAnalysis],withArrayInputs->[BindingAnalysis]],c... | String representation of a node. | Can you remove `Visitor` as well? |
@@ -1,7 +1,12 @@
"""ParserNode utils"""
+from typing import Dict
+from typing import Any
+from typing import List
+from typing import Optional
+from typing import Tuple
-def validate_kwargs(kwargs, required_names):
+def validate_kwargs(kwargs: Dict[str, Any], required_names: List[str]) -> Dict[str, Any]:
"""
... | [parsernode_kwargs->[validate_kwargs],directivenode_kwargs->[validate_kwargs],commentnode_kwargs->[validate_kwargs]] | Validates that the kwargs dict has all the expected values. | `required_name` could be an `Iterable[str]`. |
@@ -904,6 +904,7 @@ class FreqtradeBot:
logger.info('Buy order %s for %s.', reason, trade)
if corder.get('remaining', order['remaining']) == order['amount']:
+ logger.info('Buy order removed from database %s', trade)
# if trade is not partially completed, just delete the ... | [FreqtradeBot->[execute_buy->[get_buy_rate,_get_min_pair_stake_amount],_check_available_stake_amount->[_get_available_stake_amount],get_sell_rate->[_order_book_gen],_notify_buy_cancel->[get_buy_rate],_notify_sell->[get_sell_rate],_notify_sell_cancel->[get_sell_rate],cleanup->[cleanup],handle_trailing_stoploss_on_exchan... | Handle a timeout for the order to buy. This method is called when a partial buy order timeout occurs. | should this message be better placed after session.delete()? |
@@ -123,6 +123,7 @@ public class Jsr223ServiceActivatorTests {
}
@Test
+ @EnabledOnJre(JRE.JAVA_8)
public void inlineScript() throws Exception {
QueueChannel replyChannel = new QueueChannel();
| [Jsr223ServiceActivatorTests->[testDuplicateVariable->[getMessage,assertThat,close,containsString,fail],inlineScript->[assertTrue,send,build,matches,assertNull,receive,getPayload,setBeanName,assertThat,startsWith,QueueChannel],variablesAndScriptVariableGenerator->[getMessage,assertThat,close,containsString,fail],Sample... | Inline script. | What's wrong here, please ? |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.