patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -169,7 +169,7 @@ func (rs *RegistrySynchronizer) newRegistryFromChain() (Registry, error) {
}
// the positioning constant is fixed because upkeepID and registryAddress are immutable
-func calcPositioningConstant(upkeepID int64, registryAddress models.EIP55Address) (int32, error) {
+func CalcPositioningConstant(u... | [addNewUpkeeps->[Wrapf,GetUpkeepCount,New,DefaultQueryCtx,Int64,Wrap,batchSyncUpkeepsOnRegistry,LowestUnsyncedID],syncUpkeepWithCallback->[ErrorIf,syncUpkeep,Sprintf,Hex],syncUpkeep->[DefaultQueryCtx,GetUpkeep,NewInt,UpsertUpkeep],syncRegistry->[DefaultQueryCtx,UpsertRegistry,newRegistryFromChain],deleteCanceledUpkeeps... | Calculate the positioning constant for a given upkeep ID and a given registry address. | Why not make it return the uint32 instead? |
@@ -490,7 +490,7 @@ async function buildExtension(
}
}
- await compileJison(path.join(extDir, '**', '*.jison'));
+ await compileJison(`${extDir}/**/*.jison`);
if (name === 'amp-bind') {
await doBuildJs(jsBundles, 'ww.max.js', options);
}
| [No CFG could be retrieved] | Builds the extension. Writes a single extension s CSS to its npm dist folder. | Was this the problem line? Globby requires a unix-formatted path? |
@@ -691,13 +691,13 @@ err:
return 0;
}
-/* TODO(3.0): An arbitrary amount for now. Take another look at this */
-# define MAX_GROUPLIST 40
+# define GROUPLIST_INCREMENT 40
# define GROUP_NAME_BUFFER_LENGTH 64
typedef struct {
SSL_CTX *ctx;
size_t gidcnt;
- uint16_t gid_arr[MAX_GROUPLIST];
+ ... | [No CFG could be retrieved] | - - - - - - - - - - - - - - - - - - This function is only called by the user code. It is called by the user code when. | Why not a stack of gids? |
@@ -13,6 +13,7 @@ class UserNotifyEvent:
ORDER_PAYMENT_CONFIRMATION = "order_payment_confirmation"
ORDER_CANCELED = "order_canceled"
ORDER_REFUND_CONFIRMATION = "order_refund_confirmation"
+ SEND_GIFT_CARD = "send_gift_card"
CHOICES = [
ACCOUNT_CONFIRMATION,
| [No CFG could be retrieved] | UserNotifyEvent - Class to handle UserNotifyEvents Enumerate all Notify Events of a user. | I would rename it to something like gift_card_confirmation or something. What do you think? |
@@ -437,7 +437,8 @@ def _find_events(data, first_samp, verbose=None, output='onset',
@verbose
def find_events(raw, stim_channel=None, verbose=None, output='onset',
- consecutive='increasing', min_duration=0):
+ consecutive='increasing', min_duration=0,
+ short_event_war... | [_find_events->[_find_stim_steps],read_events->[pick_events,_read_events_fif],find_stim_steps->[_find_stim_steps],find_events->[_find_events]] | This function finds events in a sequence of events in a stimulated time series or a stim Find events at a specific node in a stim channel. | I would name it shortest_event warn suggests a warning and I am happy with the value error. |
@@ -30,7 +30,7 @@
</tr>
</thead>
<tbody class="crayons-card">
- <% @privileged_reactions.each do |reaction| %>
+ <% @privileged_reactions.select(&:reactable).each do |reaction| %>
<tr>
<td class="whitespace-nowrap"><%= reaction.id %></td>
<td><%= link_to reaction.user.username,... | [No CFG could be retrieved] | list of users who have a specific reaction on it. | all of the "Content" possibilities link to an object via the `reactable` - if that's null this is unsafe to link to, filter that out here. |
@@ -76,8 +76,6 @@ class CookedPostProcessor
limit_size!(img)
convert_to_link!(img)
end
-
- update_post_image
end
def extract_images
| [CookedPostProcessor->[grant_badges->[has_emoji?],convert_to_link!->[get_size],post_process_oneboxes->[limit_size!]]] | Extracts images with a and updates the post_image! and add_post_image. | Is there a reason we need this to be in the mutex? I'm assuming there must be a reason it was placed out of the mutex in the first place. |
@@ -14,11 +14,6 @@ class GobiertoBudgets::BudgetsController < GobiertoBudgets::ApplicationControlle
@place_budget_lines = GobiertoBudgets::BudgetLine.all(where: { site: current_site, place: @place, level: 1, year: @year, kind: @kind, area_name: @area_name })
@interesting_expenses = GobiertoBudgets::BudgetLine... | [guide->[last,new],load_year->[gobierto_budgets_budgets_path,redirect_to,nil?,to_i,last],index->[all,new,any_data?,index_forecast,main_budget_lines_summary,budgets_data_updated_at,sample,area_name],load_place->[nil?,place],before_action] | This method is called by the index_forecast method of all GobiertoBudget Initialize a new budget line object. | @ferblape Why remove this? |
@@ -39,6 +39,18 @@ namespace System.Reflection
return ((Pointer)ptr)._ptr;
}
+ public override unsafe bool Equals(object? obj)
+ {
+ if (obj is Pointer pointer)
+ {
+ return _ptr == pointer._ptr;
+ }
+
+ return false;
+ ... | [Pointer->[Box->[IsPointer,nameof,Arg_MustBePointer,IsRuntimeImplemented,Arg_MustBeType],Unbox->[_ptr,Arg_MustBePointer,nameof],IsRuntimeImplemented,Assert]] | Unbox an object. | Is comparison of the pointer Type intentionally omitted here? Either way, this case should be covered by the tests. |
@@ -59,6 +59,9 @@ namespace System.Net.Quic.Implementations.MsQuic
SetCallbackHandler();
SetIdleTimeout(TimeSpan.FromSeconds(120));
if (NetEventSource.IsEnabled) NetEventSource.Exit(this);
+
+ // Don't create security configuration on msquic thread, start in the backgro... | [MsQuicConnection->[NativeCallbackHandler->[HandleEvent],Dispose->[Dispose],Dispose]] | Endpoint to connect to or shutdown. Create a security config. | Why don't we want to run it on msquic thread? |
@@ -2407,7 +2407,7 @@ namespace DotNetNuke.Data
isApproved,
refreshRoles,
lastIpAddress,
- passwordResetToken,
+ GetNull(password... | [DataProvider->[UpdatePortalAliasInfo->[GetNull,ExecuteNonQuery],EnsureNeutralLanguage->[ExecuteNonQuery],CreatePortal->[GetNull,CreatePortal],DeleteTabSettings->[ExecuteNonQuery],UpdateAuthCookie->[ExecuteNonQuery],UpdateUserLastIpAddress->[ExecuteNonQuery],UpdateIPFilter->[ExecuteNonQuery],AddDesktopModulePermission-... | UpdateUser - Updates a user. | Was this a "bug fix" along the way? |
@@ -141,13 +141,14 @@ class PdfDocTest extends PHPUnit\Framework\TestCase
$db=$this->savdb;
$localproduct=new Product($this->savdb);
- $result = $localproduct->fetch(0, 'PIDRESS');
+ $localproduct->initAsSpecimen();
+ $result = $localproduct->fetch(0, 'PRODUCT_SPEC');
if ($result < 0) {
- print "\n".__M... | [PdfDocTest->[testPdfDocGetLineDesc->[fetch,initAsSpecimen,assertEquals],testPdfGetHeightForLogo->[assertEquals],setUpBeforeClass->[begin],tearDownAfterClass->[rollback]],fetch,getrights] | This method is used to test the PDF document get line description Country of origin. | Why a initAsSpecimen() to set dummy properties if just after there is a fetch to load real data from database ? |
@@ -397,7 +397,7 @@ class LayerHelper(object):
act = self.kwargs.get('act', None)
if act is None:
return input_var
- if isinstance(act, basestring):
+ if isinstance(act, six.string_types):
act = {'type': act}
if 'use_cudnn' in self.kwargs and self.kwa... | [LayerHelper->[create_parameter->[_create_weight_normalize],append_bias_op->[create_tmp_variable,append_op,create_parameter],input_dtype->[multiple_input],_create_weight_normalize->[__reshape_op->[append_op],__norm_op->[append_op],__transpose_op->[append_op],__norm_except_dim->[__reshape_op,__transpose_op,__norm_op],__... | Append an activation to the network. | doesn't cover bytes in py3? |
@@ -874,7 +874,15 @@ class Jetpack_Search {
$args = wp_parse_args( $args, $defaults );
- $parser = new Jetpack_WPES_Search_Query_Parser( $args['query'], array( get_locale() ) );
+ /**
+ * Filter the languages used by Jetpack Search's Query Parser.
+ * @module search
+ *
+ * @since 7.9.0
+ *
+ * @p... | [Jetpack_Search->[get_active_filter_buckets->[get_filters],get_search_aggregations_results->[get_search_result],get_search_facets->[get_search_aggregations_results],do_search->[search],get_filters->[get_search_aggregations_results],get_search_facet_data->[get_filters],get_current_filters->[get_active_filter_buckets],up... | Convert WP_ESS_Query_Builder arguments to ES query arguments. This function is called to search for a search query. It will return the search query and This function is called to add the boost on the fields in the query. | What do you think about moving the docblock to right before the `apply_filters` call, to make sure the parser can catch it? I'm not 100% sure this is necessary, but it seems cleaner that way? |
@@ -73,7 +73,9 @@ class Listing < ApplicationRecord
end
def modify_inputs
- ActsAsTaggableOn.default_parser = ActsAsTaggableOn::TagParser
+ temp_tags = tag_list
+ self.tag_list = [] # overwrite any existing tag with those from the front matter
+ tag_list.add(temp_tags, parser: ActsAsTaggableOn::TagP... | [Listing->[create_slug->[to_s,slug,delete],modify_inputs->[body_markdown,default_parser,gsub],validate_tags->[add,length],natural_expiration_date->[days],category->[slug],evaluate_markdown->[processed_html,evaluate_listings_markdown],restrict_markdown_input->[add,to_s,include?,count],include,belongs_to,delegate,before_... | This method is called when the user is trying to access the tag with a missing key. | Setting the default_parser caused conflict in testing so I have to change how Tag is parsed in Listing. |
@@ -294,12 +294,13 @@ class ElggFile extends \ElggObject {
/**
* Delete this file.
*
+ * @param bool $follow_symlinks If true, will also delete the target file if the current file is a symlink
* @return bool
*/
- public function delete() {
+ public function delete($follow_symlinks = true) {
$fs = $thi... | [ElggFile->[getFilenameOnFilestore->[getFilenameOnFilestore],size->[getSize],grabFile->[grabFile],tell->[tell],setModifiedTime->[getFilenameOnFilestore],detectMimeType->[getFilenameOnFilestore],write->[write],getSimpleType->[getMimeType],seek->[seek],exists->[exists],save->[getFilestore],delete->[delete],close->[close]... | Delete the object from the Filestore. | ~~We don't get an E_STRICT error here, from not matching ElggEntity?~~ |
@@ -8,6 +8,10 @@ EventDecorator = Struct.new(:event) do
end
def happened_at
- EasternTimePresenter.new(event.created_at).to_s
+ event.created_at
+ end
+
+ def happened_at_in_words
+ EasternTimePresenter.new(happened_at).to_s
end
end
| [happened_at->[to_s],event_type->[t,event_type],new] | Returns the timestamp of the last happened event. | Changing this method to return a datetime value for comparison purposes, otherwise the string value was being used for comparisons. |
@@ -175,8 +175,8 @@ public class CodeGenRunner {
@Override
public Void visitLikePredicate(final LikePredicate node, final TypeContext context) {
- process(node.getValue(), null);
- process(node.getPattern(), null);
+ process(node.getValue(), context);
+ process(node.getPattern(), context... | [CodeGenRunner->[cook->[cook],compileExpressions->[CodeGenRunner],buildCodeGenFromParseTree->[getCodeGenSpec],compileExpression->[CodeGenRunner,compileExpression]]] | Visit a LikePredicate node. Find the KsqlScalarFunction that is registered in the U. | nit: I think this is cleaner to just use `resolvedArgType` as the second parameter, which will be the same as `childContext.getSqlType()`. Ditto on other two classes. |
@@ -281,6 +281,10 @@ class TorchGeneratorAgent(TorchAgent):
self.beam_min_n_best = opt.get('beam_min_n_best', 3)
self.beam_min_length = opt.get('beam_min_length', 3)
self.beam_block_ngram = opt.get('beam_block_ngram', 0)
+ self.beam_num_iterations = opt.get('beam_num_iterations', 1)
+ ... | [TorchGeneratorAgent->[beam_search->[reorder_encoder_states,reorder_decoder_incremental_state],_write_beam_dots->[_v2t],eval_step->[_write_beam_dots,_v2t,reorder_encoder_states,decode_forced],train_step->[_init_cuda_buffer,update_params,zero_grad],zero_grad->[zero_grad]],Beam->[get_beam_dot->[get_hyp_from_finished,get_... | Initialize the object with the specified options. Load model parameters if available and initialize optimizer if necessary. | I'm actually thinking `eval_batchsize` is the correct choice here. |
@@ -21,10 +21,14 @@ use Sulu\Bundle\MediaBundle\Media\Storage\StorageInterface;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\File\File;
use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\ResponseHeaderBag;
use Symfony\Component\HttpF... | [MediaStreamController->[getImageAction->[getPathInfo,returnImage,createNotFoundException,getMediaProperties,getCode],downloadAction->[getCode,getMessage,getFileResponse,get,createNotFoundException,getFileVersion,getId,increaseDownloadCounter],getStorage->[get],getFileResponse->[getName,getMimeType,set,getStorageOption... | This method is used to handle the image action of a specific node. Download a single . | Remove this `const`s |
@@ -17,10 +17,10 @@ class Identity < ApplicationRecord
CONSENT_EXPIRATION = 1.year
- IAL_MAX = 0
- IAL1 = 1
- IAL2 = 2
- IAL2_STRICT = 22
+ IAL_MAX = Idp::Constants::IAL_MAX
+ IAL1 = Idp::Constants::IAL1
+ IAL2 = Idp::Constants::IAL2
+ IAL2_STRICT = Idp::Constants::IAL2_STRICT
def deactivate
up... | [Identity->[decorate->[new],agency_name->[name],deactivate->[update!],piv_cac_enabled?->[enabled?],sp->[from_issuer],display_name->[name],include,belongs_to,delegate,scope,year,validates,where]] | Deactivates a lease. | What if we removed the constants definitions here and updated refs to `Identity::IAL1` etc to `Idp::Constants::IAL1`? |
@@ -185,6 +185,11 @@ class ProductVariant(models.Model):
Product, related_name='variants', on_delete=models.CASCADE)
attributes = HStoreField(default={}, blank=True)
images = models.ManyToManyField('ProductImage', through='VariantImage')
+ handle_stock = models.BooleanField(
+ default=True,... | [ProductVariant->[get_absolute_url->[get_slug],get_ajax_label->[display_product,get_price],get_first_image->[get_first_image]],Product->[is_in_stock->[is_in_stock]]] | Returns the first image in the list of images. Get the quantity of an object. | Although I understood the purpose of this field from reading the code, this name sounds a bit too general to me. What about `track_inventory`? I think it would be more understandable. |
@@ -14,7 +14,6 @@
/*-
* RC2 as implemented frm a posting from
* Newsgroups: sci.crypt
- * Sender: pgut01@cs.auckland.ac.nz (Peter Gutmann)
* Subject: Specification for Ron Rivests Cipher No.2
* Message-ID: <4fk39f$f70@net.auckland.ac.nz>
* Date: 11 Feb 1996 06:45:03 GMT
| [RC2_ecb_encrypt->[RC2_decrypt,RC2_encrypt,l2c,c2l]] | ECC - ECC - ECC - DECRYPT. | Hmmm, I find it odd to edit news post headers like this... |
@@ -8,6 +8,11 @@
if (elgg_is_sticky_form('register')) {
$values = elgg_get_sticky_values('register');
+
+ // Add the sticky values to $vars so views extending
+ // register/extend also get access to them.
+ $vars = array_merge($vars, $values);
+
elgg_clear_sticky_form('register');
} else {
$values = array();
| [No CFG could be retrieved] | Egg input for user name password and action View to extend to add more fields to the registration form. | Are we sure it's safe to plow these values in `$vars`? I.e. should they instead go into `$vars['sticky_values']`? |
@@ -400,10 +400,12 @@ public class ConversionServiceImpl extends DefaultComponent implements Conversio
String srcMt = blobHolder.getBlob().getMimeType();
String converterName = translationHelper.getConverterName(srcMt, destinationMimeType);
if (converterName == null) {
- throw new ... | [ConversionServiceImpl->[getConverterNames->[getConverterNames],isCacheEnabled->[isCacheEnabled],getAdapter->[getAdapter],isConverterAvailable->[isConverterAvailable],getConverterName->[getConverterNames],convertToMimeType->[convert],convert->[isCacheEnabled,convert],activate->[ReloadListener]]] | Convert the given blobHolder to the given destinationMimeType. | While you're editing this file, is it possible to rename `srcMt` to `srcMimeType` to improve readability ? |
@@ -836,7 +836,7 @@ export default Component.extend(
this.clearErrors();
const inModal = this.element.closest("#discourse-modal");
- if (inModal && this.site.mobileView) {
+ if (inModal && this?.site?.mobileView) {
const modalBody = inModal.querySelector(".modal-body");
modal... | [No CFG could be retrieved] | This method is called when the user selects an item in the main collection. Create a popper that displays a header and a body element. | site is not defined in wizard |
@@ -1034,6 +1034,15 @@ public class SymbolTableTest {
JavaSymbol bar1 = result.symbol("bar1");
assertThat(bar1.usages()).hasSize(2);
+
+ JavaSymbol bar = result.symbol("bar");
+ assertThat(bar.usages()).hasSize(1);
+
+ MethodReferenceTree methodRef = (MethodReferenceTree) bar.usages().get(0).parent... | [SymbolTableTest->[ConstructorDeclaration->[isNull,reference,isFalse,type,isEqualTo,hasSize,createFor,containsExactly,symbol,isSameAs],FieldTypes->[isEqualTo,createFor,isNotNull],Lambdas->[symbolType,type,parent,isTrue,isEqualTo,expression,hasSize,createFor,declaration,symbol,isSameAs],MethodReference->[isTrue,isEqualT... | MethodReferenceUsingThis test method. | not really required given the following test. |
@@ -237,3 +237,7 @@ class HashMismatch(HashError):
self.gots[hash_name].hexdigest())
prefix = ' or'
return '\n'.join(lines)
+
+
+class UnsupportedPythonVersion(InstallationError):
+ """Unsupported python version (related to PEP 345 Requires-Python)."""
| [HashErrors->[append->[append],__bool__->[__nonzero__],__str__->[append]],HashMismatch->[_hash_comparison->[hash_then_or,append],body->[_requirement_name]],HashError->[__str__->[body]]] | Return a comparison of actual and expected hash values. | "related to PEP 345 Requires-Python" sounds a bit clumsy. Maybe "according to Requires-Python package metadata"? |
@@ -148,10 +148,9 @@ class ModelTester(TestCase):
set_rng_seed(0)
kwargs = {}
if "retinanet" in name:
- kwargs["score_thresh"] = 0.013
+ # Reduce the default threshold to ensure the returned boxes are not empty.
+ kwargs["score_thresh"] = 0.01
model =... | [do_test->[_test_classification_model,_test_detection_model,_test_video_model,_test_segmentation_model],ModelTester->[_test_classification_model->[set_rng_seed,checkModule],test_googlenet_eval->[checkModule],test_fasterrcnn_switch_devices->[checkOut],_test_detection_model->[set_rng_seed,check_out,checkModule],_test_seg... | Test detection model for missing missing values. Check if a missing missing value is present in the model. | Use a threshold that will produce many more boxes and make things more interesting. |
@@ -22,7 +22,7 @@ int asn1_generalizedtime_to_tm(struct tm *tm, const ASN1_GENERALIZEDTIME *d)
static const int min[9] = { 0, 0, 1, 1, 0, 0, 0, 0, 0 };
static const int max[9] = { 99, 99, 12, 31, 23, 59, 59, 12, 59 };
char *a;
- int n, i, l, o;
+ int n, i, l, o, min_l = 13, strict = 0;
if (d... | [ASN1_GENERALIZEDTIME_check->[asn1_generalizedtime_to_tm],ASN1_GENERALIZEDTIME_set_string->[ASN1_GENERALIZEDTIME_check]] | ASN. 1 generalized time to tm. Check if the next non - zero digit is missing. | I had never tried this before, but 23:59:60 is a valid time, so max[6] should be 60. |
@@ -542,6 +542,16 @@ class ApplicationController < ActionController::Base
end
end
+ def rate_limit_second_factor!(user)
+ return if params[:second_factor_token].blank?
+
+ RateLimiter.new(nil, "second-factor-min-#{request.remote_ip}", 3, 1.minute).performed!
+
+ if user
+ RateLimiter.new(nil, "... | [ApplicationController->[authorize_mini_profiler->[mini_profiler_enabled?],json_result->[render_json_error],set_layout->[use_crawler_layout?],preload_anonymous_data->[store_preloaded],render_serialized->[serialize_data],banner_json->[banner_json_cache],rescue_discourse_actions->[redirect_with_client_support],apply_cdn_... | Checks if a permalink exists and redirects to it if it exists. | Not sure if we want to do `RateLimiter.new(nil, "second-factor-min-anonymous", 3, 1.minute).performed!` if the user does not exist? |
@@ -628,6 +628,10 @@ class BaseZincCompile(JvmCompile):
class ZincCompile(BaseZincCompile):
"""Compile Scala and Java code to classfiles using Zinc."""
+ deprecated_module(
+ removal_version='1.19.0.dev0',
+ hint_message="compile.zinc task is being phased out. Use compile.rsc:zinc-only option instead."
+ ... | [BaseZincCompile->[_maybe_get_plugin_name->[process_info_file],__init__->[validate_arguments],compile->[post_compile_extra_resources,javac_classpath,relative_to_exec_root,_get_zinc_arguments,scalac_classpath_entries],_compile_nonhermetic->[ZincCompileError],_verify_zinc_classpath->[is_outside],validate_arguments->[vali... | Return list of product types. | Should remove this: it will fire on every import. |
@@ -266,7 +266,7 @@ import {zen} from '../ads/zen';
import {zergnet} from '../ads/zergnet';
import {zucks} from '../ads/zucks';
import {speakol} from '../ads/speakol';
-
+import {lentainform} from '../ads/lentainform';
/**
* Whether the embed type may be used with amp-embed tag.
| [No CFG could be retrieved] | Imports an object that is a part of the ADS library. Check if the tag type can be used with amp - embed. | Can we put this (and the one above, my apologies), in alphabetical order? |
@@ -1102,6 +1102,12 @@ def _from_merged_attrs(fetcher, pkg, version):
def for_package_version(pkg, version):
"""Determine a fetch strategy based on the arguments supplied to
version() in the package description."""
+
+ # No-code packages have a custom fetch strategy since there is no
+ # URL to proc... | [SvnFetchStrategy->[_remove_untracked_files->[svn],fetch->[svn],reset->[svn,_remove_untracked_files],get_source_id->[svn]],for_package_version->[_check_version_attributes,_extrapolate,_from_merged_attrs,check_pkg_attributes],from_list_url->[URLFetchStrategy],_extrapolate->[URLFetchStrategy],HgFetchStrategy->[fetch->[hg... | Determine a fetch strategy based on the arguments supplied to the package and version. | Would something go wrong if `Package.fetcher` was updated to return `None` for a `BundlePackage`, vs. implementing a fetcher that always raises an error? If I understand correctly, the `do_fetch` function is not called at all for a `BundlePackage`. If that creates many errors, I could imagine it's on account of cruft i... |
@@ -1592,7 +1592,10 @@ public final class InfinispanSubsystemXMLReader implements XMLElementReader<List
break;
}
case ADDRESS_COUNT: {
- MemoryOffHeapConfigurationResource.ADDRESS_COUNT.parseAndSetParameter(value, offHeap, reader);
+ ... | [InfinispanSubsystemXMLReader->[parseClusterLoader->[setStoreOperationAddress],parseRemoteStore->[setStoreOperationAddress],parseInvalidationCache->[validateClusteredCacheAttributes,addCacheConfiguration,parseClusteredCacheAttribute],parseReplicatedCache->[validateClusteredCacheAttributes,addCacheConfiguration,parseClu... | Parse the memory off - heap configuration. | We should warn that the attribute has been ignored via `ignoreAttribute`. |
@@ -85,7 +85,8 @@ public class AppScriptServlet extends DefaultServlet {
int endIndex = script.indexOf(endReplaceString, startIndex);
if (startIndex >= 0 && endIndex >= 0) {
- String replaceString = "this.getPort=function(){return " + websocketPort + "};";
+ String replaceString = "this.getPort=fu... | [AppScriptServlet->[doGet->[getResource,append,indexOf,getRequestURI,getInputStream,println,doGet,available,read,String,contains,StringBuffer,replace,toString,length],asList]] | This method is overridden to read the script file chunk by chunk by chunk and write the script. | This will set an incorrect internal local port of the zeppelin instance (e.g. 8080) where it is possible that there is a reverse proxy (nginx with HTTPS for example) in front of zeppelin. Actually I think this whole Servlet is no longer needed since the websocket port is now the http port, so the browser can simply ass... |
@@ -1090,7 +1090,12 @@ class TokenNetwork:
f'new={onchain_channel_identifier}',
)
- def _get_channel_state(self, participant1, participant2, channel_identifier):
+ def _get_channel_state(
+ self,
+ participant1: typing.Address,
+ participant2: typin... | [TokenNetwork->[all_events_filter->[events_filter],_check_channel_state_for_deposit->[_get_channel_state,detail_participants],unlock->[channel_is_settled],detail_participant->[ParticipantDetails,_call_and_check_result],can_transfer->[channel_is_opened,detail_participant],set_total_deposit->[token_address,detail_partici... | Checks whether an operation is being executed on a channelbetween two participants using an old channel identifier. | Why was this default added? From the diff in this PR it's not used. |
@@ -888,10 +888,15 @@ public class KafkaSupervisor implements Supervisor
@VisibleForTesting
String generateSequenceName(int groupId)
{
+ TaskGroup taskGroup = taskGroups.get(groupId);
+ if (taskGroup == null) {
+ log.error("group id: %s not found in taskGroups, cannot generate sequence name", groupI... | [KafkaSupervisor->[updateCurrentAndLatestOffsets->[updateCurrentOffsets,updateLatestOffsetsFromKafka],emitLag->[getHighestCurrentOffsets],checkpointTaskGroup->[apply->[taskIds],taskIds],createKafkaTasksForGroup->[generateSequenceName,getRandomId],discoverTasks->[apply->[generateSequenceName,TaskGroup,TaskData]],addDisc... | Generate a random sequence name. | How about having this accept TaskGroup object instead of a groupId? Then having a null-check on that argument will achieve much the same thing, but leaves more control in the hands of the caller as to what exact group gets passed in. It also makes bugs less likely, since a caller must have a real, live TaskGroup object... |
@@ -253,7 +253,7 @@ class Label(dict):
on the new surface are required, consider using mne.read_surface
with label.vertices.
"""
- self.morph(subject, subject, grade, smooth, subjects_dir, n_jobs)
+ self.morph(subject, subject, smooth, grade, subjects_dir, n_jobs)
@verbos... | [BiHemiLabel->[__add__->[BiHemiLabel]],label_time_courses->[read_label],write_label->[_aslabel],stc_to_label->[Label],label_sign_flip->[_aslabel],Label->[set->[_update_attr_from_dict],update->[_update_attr_from_dict],__add__->[Label],__setitem__->[_update_attr_from_dict]],labels_from_parc->[Label,_read_annot],read_labe... | Smooth the label by smoothing the vertices of the a managed object. - The name of the subject to morph the label to. Find missing components in the data. | Was this a bug? |
@@ -20,6 +20,7 @@ except ImportError:
from uamqp import AMQPClient, Message, authentication, constants, errors, compat, utils
import six
+from azure.core.utils import parse_connection_string as core_parse_connection_string
from azure.core.credentials import AccessToken, AzureSasCredential
from .exceptions impor... | [EventHubSharedKeyCredential->[get_token->[_generate_sas_token]],ConsumerProducerMixin->[_do_retryable_operation->[_handle_exception,_backoff],_handle_exception->[_handle_exception],_close_connection->[_close_handler],_open->[_create_auth,_create_handler],close->[_close_handler]],ClientBase->[_from_connection_string->[... | Creates an object from a given token. Get the eventhub_name from conn_str. | can we double check the azure-core dependency version is right (>= the version we introduced this `parse_connection_string` method)? |
@@ -90,6 +90,8 @@ func (r *RuleList) MarshalYAML() (interface{}, error) {
name = "fix_stream"
case *InsertDefaultsRule:
name = "insert_defaults"
+ case *InjectCustomHeadersRule:
+ name = "inject_custom_headers"
default:
return nil, fmt.Errorf("unknown rule of type %T", rule)
}
| [Apply->[ReplaceAllString,Value,MatchString,Sprintf,Version,Apply,New,Find,ValueOf,AgentID,String,Clone,Errorf,InjectItem,Snapshot,Inject,Map],MarshalYAML->[String,Errorf,MarshalYAML],UnmarshalYAML->[Marshal,New,Unmarshal,Compile,Errorf],Value,Apply,Find,String,Errorf] | MarshalYAML marshals a RuleList to a YAML document. The n - node document. | How about just `inject_headers`? |
@@ -104,6 +104,18 @@ namespace DotNetNuke.Entities.Modules
[EditorBrowsable(EditorBrowsableState.Never)]
[Obsolete("Deprecated in DNN 7.3. Please use the ModuleSettings property of the ModuleInfo object")]
public Hashtable GetModuleSettings(int ModuleId)
+ {
+ var cacheKey ... | [ModuleController->[DeleteModuleSettings->[DeleteModuleSettings],DeleteAllModules->[DeleteAllModules],DeleteTabModuleSettings->[DeleteTabModuleSettings]]] | Get the module settings. | Why there is a check for ModuleId <= 0 is there any difference with positive ModuleId? |
@@ -284,6 +284,8 @@ const AMP_EMBED_ALLOWED = {
'mantis-recommend': true,
miximedia: true,
mywidget: true,
+ lentainform: true,
+ opinary: true,
outbrain: true,
plista: true,
postquare: true,
| [No CFG could be retrieved] | Imports a specific type of a tag and determines if it can be used with amp - embed Check if a list of objects is unique. | nit: sort alphabetically please. |
@@ -33,8 +33,10 @@ type projectAndRuleReq struct {
var createRuleReqGen, createProjectReqGen, createProjectAndRulesGen, createProjectsAndRulesGen = getGenerators()
func TestCreateRuleProperties(t *testing.T) {
- ctx := context.Background()
- cl, testDB, store, seed := testhelpers.SetupProjectsAndRulesWithDB(t)
+ ct... | [UnicodeString,AssertCode,TestingRun,OneConstOf,Close,CreateProject,Merge,XXX_Size,SliceOf,Const,Flush,CombineGens,Error,Min,DefaultTestParametersWithSeed,CreateRule,Logf,Bool,TypeOf,CloseDB,ForAll,RegexMatch,Map,GetRule,Struct,NewProperties,Sprintf,Background,SetupProjectsAndRulesWithDB,StructPtr,Helper,Property] | v2_test imports a single v2 object and creates a list creates a list of projects and rules with non - unique IDs. | Renamed `cl` to `projectClient` because I needed to add `policyClient` as another return value. `policyClient` is needed to create the default system roles which are now needed when creating projects, because projects create policies, and those policies use roles. |
@@ -41,12 +41,6 @@
#include "obj_rpc.h"
#include "obj_internal.h"
-static inline struct obj_tls *
-obj_tls_get()
-{
- return dss_module_key_get(dss_tls_get(), &obj_module_key);
-}
-
/**
* After bulk finish, let's send reply, then release the resource.
*/
| [No CFG could be retrieved] | PUBLIC FUNCTIONS For a single object that is related to a single object in the DSS Get the object read out. | why do we bother to allocate struct srv_profile for the TLS? we could just embedded in the TLS data structure, and provide a function like srv_profile_get() to return it. Profile_start only needs to switch one bit to enable it. |
@@ -1,3 +1,12 @@
+''' An plot of two interactive sliders. The values are updated simultaneously as the slider bars are dragged to different values.
+This example demonstrates how ``CustomJS`` callbacks react to user interaction events.
+
+.. bokeh-example-metadata::
+ :apis: bokeh.layouts.column, bokeh.models.callba... | [show,js_on_change,dict,output_file,Div,CustomJS,column,Slider] | Show the list of all the n - th element in the header. | I missed this earlier, it would also be preferred t shorten these lines, then I think the PR is ready to merge |
@@ -192,7 +192,15 @@ func (bt *beater) Run(b *beat.Beat) error {
return nil
}
- bt.server = newServer(bt.config, tracer, pub.Send)
+ var kb *kibana.Client
+ if bt.config.Kibana.Enabled() {
+ kb, err = kibana.NewKibanaClient(bt.config.Kibana)
+ if err != nil {
+ bt.logger.Error(err.Error())
+ }
+ }
+
+ bt.se... | [Run->[listen,Stop,Error,Unlock,Infof,Client,Go,Close,NewPublisher,Lock,Wait,Serve],registerPipelineCallback->[NewConnectedClient,shouldOverwrite,RegisterConnectCallback,RegisterPipelines],listen->[Listen,Infof,SplitHostPort,JoinHostPort,Addr,String],Stop->[Seconds,Lock,Unlock,Infof],Warn,Close,Setenv,Enabled,SetSecret... | Run starts the beacon server. | Why not return the error here? With the current logic, `kb` should be set to nil if `err != nil`, to ensure you aren't passing a faulty or half initialized Kibana client on to `newServer`. |
@@ -71,7 +71,7 @@ class LocalizationFinder implements LocalizationFinderInterface
return;
}
- return $resultLocalization->getLocalization();
+ return $resultLocalization->getLocale();
}
/**
| [LocalizationFinder->[findAvailableChildLocalization->[findAvailableChildLocalization],findAvailableLocalization->[findAvailableLocalization]]] | Finds a locale in the given list of locales. | Just fixed all of these calls because the deprecation messages were annoying during debugging. |
@@ -425,6 +425,13 @@ public class DnsNameResolver extends InetNameResolver {
return resolveCache;
}
+ /**
+ * Returns the cname cache.
+ */
+ public CnameCache cnameCache() {
+ return cnameCache;
+ }
+
/**
* Returns the cache used for authoritative DNS servers for a do... | [DnsNameResolver->[toArray->[toArray],trySuccess->[trySuccess],doResolveAllCached->[tryFailure,trySuccess],doResolveAllUncached->[resolve],query0->[query0,query],doResolveAll->[doResolveAll,loopbackAddress,resolveHostsFileEntry],resolve->[resolve],executor->[executor],doResolve->[doResolve,loopbackAddress,resolveHostsF... | Resolves the DNS cache. | - cname cache -> `{@link CnameCache}`? |
@@ -0,0 +1,15 @@
+class ManifestJsonController < ApplicationController
+ layout false
+ skip_before_filter :preload_json, :check_xhr
+
+ def index
+ manifest = {
+ short_name: SiteSetting.title,
+ display: 'browser',
+ orientation: 'portrait',
+ start_url: "#{Discourse.base_uri}/"
+ }
+
+ ... | [No CFG could be retrieved] | No Summary Found. | should be `"#{Discourse.base_uri}/"` |
@@ -9,7 +9,9 @@ module Users
user = User.find(user_id)
if goal == "user_views_article_four_days_in_week"
- determine_pageview_goal(user, experiment)
+ determine_weekly_pageview_goal(user, experiment)
+ elsif goal == "user_views_article_four_of_past_7_hours"
+ determine_past_sev... | [RecordFieldTestEventWorker->[determine_pageview_goal->[field_test_converted,values,size,delete],perform->[determine_pageview_goal,find,field_test_converted],sidekiq_options,include]] | Check if a user has a necessary tag and if so return it. | Something I thought about looking at this, my DEV usage is usually split throughout the day. I like to do a morning check and then an after-work check which means I am likely getting in 4 posts but not within 7 hours. I feel like that might be common for people that choose not to check it during the work day. What do y... |
@@ -92,7 +92,7 @@ namespace Microsoft.Extensions.DependencyInjection.ServiceLookup
private object VisitCache(ServiceCallSite callSite, RuntimeResolverContext context, ServiceProviderEngineScope serviceProviderEngine, RuntimeResolverLock lockType)
{
bool lockTaken = false;
- Dic... | [CallSiteRuntimeResolver->[VisitScopeCache->[VisitRootCache]]] | Visit a cache entry and resolve a service if it can be found. | This should be `IDictionary<ServiceCacheKey, object>`. |
@@ -0,0 +1,15 @@
+
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+
+namespace Microsoft.Extensions.Logging.Generators.Tests.TestClasses
+{
+ internal static partial class SkipEnabledCheckExtensions
+ {
+ [LoggerMes... | [No CFG could be retrieved] | No Summary Found. | `SkipEnabledCheck=true` seems like a good candidate for a baseline test - since that way you can verify the IsEnabled check isn't there. |
@@ -196,7 +196,15 @@ class _PredictManager:
elif self._dataset_reader is None:
raise ConfigurationError("To generate instances directly, pass a DatasetReader.")
else:
- yield from self._dataset_reader.read(self._input_file)
+ if isinstance(self._dataset_reader, Multi... | [_predict->[_get_predictor,run,_PredictManager],_PredictManager->[run->[_predict_json,_get_instance_data,_maybe_print_to_console_and_file,_get_json_data,_predict_instances]]] | Get the instance data. | Why do we check this again? |
@@ -92,5 +92,15 @@ namespace Dynamo.UI.Prompts
base.OnClosed(e);
viewModel = null;
}
+
+ private void configure_adp_button_Click(object sender, RoutedEventArgs e)
+ {
+ IntPtr handle = new IntPtr();
+ if (Owner != null)
+ {
+ ... | [UsageReportingAgreementPrompt->[OnClosed->[OnClosed]]] | Override OnClosed to clear the viewModel after the component is closed. | do we always need an owner handle ? should this be initialized to null ? |
@@ -207,7 +207,8 @@ var (
}
psDescription = "Prints out information about the containers"
psCommand = cli.Command{
- Name: "ps",
+ Name: "list",
+ Aliases: []string{"ls", "ps"},
Usage: "List containers",
Description: psDes... | [headerMap->[Field,ValueOf,ToUpper,NumField,Type,Indirect],Less->[After],Before,GetContainers,StringSlice,MarshalIndent,StringInSlice,IsSet,Flush,Int,Args,New,GetRuntime,Errorf,ParseInt,GlobalInt,After,Labels,Bool,Parallelize,SplitN,Debugf,State,NewWriter,ID,Wrapf,Join,Execute,ExitCode,Fprint,Contains,Name,Sort,Shutdow... | Commands for the list - containers command psCmd handles the list - all - the - n option for the ps command. | does this need to change to list? Couldn't it stay as ps? |
@@ -14,9 +14,11 @@
* limitations under the License.
*/
+import {AmpStoryPlayer} from './amp-story-player-impl';
import {AmpStoryPlayerManager} from './amp-story-player-manager';
-self.onload = () => {
+self.addEventListener('load', () => {
+ customElements.define('amp-story-player', AmpStoryPlayer);
const ... | [No CFG could be retrieved] | Load AmpStoryPlayers from an AmpStoryPlayerManager. | This works, but maybe is a little weird? Shouldn't each custom element manage its own loading when it's connected? |
@@ -62,11 +62,11 @@ class TestRegistrable(AllenNlpTestCase):
# Registering under a name that already exists should overwrite
# if exist_ok=True.
@base_class.register("fake", exist_ok=True) # noqa
- class FakeAlternate(base_class):
+ class FakeAlternate2(base_class):
... | [TestRegistrable->[test_registry_has_builtin_text_field_embedders->[by_name],test_registry_has_builtin_tokenizers->[by_name],test_registry_has_builtin_token_indexers->[by_name],test_implicit_include_package->[,push_python_path,raises,write,getabsfile,str,read,join,mkdir,by_name,open],test_registry_has_builtin_regulariz... | This function tests that the basic functionality works. | Python 3.8 flake8 complained about this for some reason |
@@ -763,11 +763,18 @@ class RevisionForm(AkismetCheckFormMixin, forms.ModelForm):
based_on = self.cleaned_data.get('based_on')
assert based_on, 'Expected a new translation.'
document = based_on.document
+ # print("INPUT:", repr(document))... | [AkismetRevisionData->[set_by_edit_request->[set_blog],set_blog_lang->[akismet_lang]],RevisionAkismetSubmissionAdminForm->[akismet_parameters->[AkismetHistoricalData]],AkismetNewTranslationData->[__init__->[set_by_edit_request,set_blog_lang,content_from_document,set_content,content_from_form]],AkismetNewDocumentData->[... | Returns the parameters for Akismet s check - comment API endpoint. | Can we remove these now? |
@@ -1622,6 +1622,12 @@ function elgg_view_list_item($item, array $vars = array()) {
return elgg_view_river_item($item, $vars);
}
+ $view = elgg_extract('item_view', $vars);
+ if ($view && elgg_view_exists($view)) {
+ $vars['item'] = $item;
+ return elgg_view($view, $vars);
+ }
+
return '';
}
| [elgg_does_viewtype_fallback->[doesViewtypeFallback],elgg_view_resource->[renderView,error],elgg_list_views->[listViews],elgg_view_entity->[getType,getSubtype],elgg_get_form_footer->[getFooter],elgg_register_viewtype_fallback->[registerViewtypeFallback],elgg_view_layout->[end,begin,hasEnded,getUrlSegments,getFirstUrlSe... | elgg_view_list_item - view list item. | If `item_view` is set to an existing view, shouldn't we use it instead of calling the type-specific functions? So this would come first in the function. |
@@ -158,13 +158,15 @@ public class UnicastSendingMessageHandler extends
this.waitForAck = acknowledge;
this.mapper.setAcknowledge(acknowledge);
this.mapper.setAckAddress(ackHost + ":" + ackPort);
+ this.ackHost = ackHost;
this.ackPort = ackPort;
if (ackTimeout > 0) {
this.ackTimeout = ackTimeout;
... | [UnicastSendingMessageHandler->[onInit->[onInit],send->[send]]] | Set the reliability attributes. | This is redundant as well. Why the `if` expression above has been inverted? |
@@ -28,6 +28,12 @@
#include "nvme_control.h"
#include "nvme_control_common.h"
+struct wipe_sequence {
+ struct ns_entry *ns_entry;
+ char *buf;
+ int is_completed;
+};
+
static void
get_spdk_log_page_completion(void *cb_arg, const struct spdk_nvme_cpl *cpl)
{
| [int->[spdk_nvme_ctrlr_cmd_get_log_page,spdk_nvme_ctrlr_process_admin_completions],nvme_wipe_first_ns->[spdk_nvme_qpair_process_completions,spdk_nvme_ctrlr_get_next_active_ns,printf,spdk_nvme_ctrlr_get_first_active_ns,spdk_nvme_ctrlr_alloc_cmb_io_buffer,spdk_nvme_ctrlr_get_ns,spdk_nvme_ns_cmd_write,snprintf,get_control... | This method is called when SPDK log page is complete. It is called by the SP. | (style) please, no space before tabs |
@@ -663,12 +663,8 @@ func (mod *modContext) genResource(w io.Writer, r *schema.Resource) error {
switch len(r.Aliases) {
case 0:
fmt.Fprintf(w, "\n")
- case 1:
- fmt.Fprintf(w, " Aliases = { ")
- genAlias(w, r.Aliases[0])
- fmt.Fprintf(w, " },\n")
default:
- fmt.Fprintf(w, " A... | [genResource->[genInputType,typeString,propertyName],gen->[genResource,genType,genFunction,details,genPulumiHeader,add,genConfig,genUtilities],genType->[genInputType,details,genOutputType],genFunction->[genInputType,tokenToNamespace,genOutputType],genInputType->[genInputProperty,propertyName],genOutputType->[typeString... | genResource generates the JS code for a resource Print a protected constructor for the resource Write the method that will calculate the resource options Write the Get method for reading a resource in a state. | This is the only change that affects TF providers. I prefer this alignment over existing one. |
@@ -196,15 +196,16 @@ func NewConfig() *Config {
fs.StringVar(&cfg.Security.KeyPath, "key", "", "path of file that contains X509 key in PEM format")
fs.BoolVar(&cfg.ForceNewCluster, "force-new-cluster", false, "force to create a new one-member cluster")
+ cfg.EnableServiceMiddleware = true
return cfg
}
cons... | [MigrateDeprecatedFlags->[migrateConfigurationMap],Parse->[Parse],IsDefined->[IsDefined],migrateConfigurationFromFile->[IsDefined],Adjust->[CheckUndecoded,Parse,IsDefined,Validate,Adjust,Child],parseDeprecatedFlag->[IsDefined],adjustLog->[IsDefined],adjust->[Child,Validate,adjust,IsDefined],Parse] | Configuration variables for the cluster. missing - node - id - default - cluster - token - default - tick - interval -. | I prefer to move it to another place and change the default value to false. |
@@ -5,9 +5,13 @@ namespace NServiceBus
static class PerformanceCounterHelper
{
-
public static PerformanceCounter InstantiateCounter(string counterName, string endpointName)
{
+ if (endpointName.Length > SByte.MaxValue)
+ {
+ throw new Exception(string.... | [PerformanceCounterHelper->[PerformanceCounter->[CounterType,Format]]] | Instantiate a new NServiceBus PerformanceCounter. | is the cast required in `(int)SByte.MaxValue` ? |
@@ -1688,8 +1688,9 @@ void GenericAgentConfigApply(EvalContext *ctx, const GenericAgentConfig *config)
switch (config->agent_type)
{
case AGENT_TYPE_COMMON:
- ctx->eval_options = EVAL_OPTION_NONE;
- ctx->eval_options |= config->agent_specific.common.eval_functions ? EVAL_OPTION_EVAL_FUNCTIO... | [No CFG could be retrieved] | This function is called to add a class to the context. It is called by the command cinputs - Input file - Input directory - Input directory - Input bundles - Input bundles -. | Options were previously being cleared when this condition failed; am I to take it they are clear already ? |
@@ -155,6 +155,13 @@ class AssetsController < ApplicationController
render layout: false
end
+ def start_edit
+ asset = Asset.find_by_id(params[:id])
+ return render_403 unless asset
+
+ create_edit_image_activity(asset, current_user, true)
+ end
+
def update_image
@asset = Asset.find(param... | [AssetsController->[append_wd_params->[to_query],load_vars->[step,protocol,repository_cell,my_module,class,result,repository,find_by_id],edit->[append_wd_params,to_s,render,token,zero?,get_action_url,update,create_wopi_file_activity,locked?,favicon_url,now,get_wopi_token],check_read_permission->[can_read_experiment?,ca... | view a single node node - tag. | we could just use the `load_vars` in `before_action` as it is used for other actions as well. Then we should additionally check for permissions if `current_user` even has permissions to add activity. |
@@ -128,6 +128,13 @@ class Catalyst(CMakePackage):
paraview_version))
run_env.prepend_path('LD_LIBRARY_PATH', join_path(lib_dir,
paraview_version))
+ if '+python' in self.spec:
+ run_env.prepend_path('PYTHONPATH', join_path(lib_dir,
... | [Catalyst->[url_for_version->[Version,up_to,format],cmake->[abspath,working_dir,check_call,join,cmake_args],setup_environment->[prepend_path,join_path,up_to,isdir],build_directory->[join_path,abspath],cmake_args->[str],root_cmakelists_dir->[str,join],do_stage->[abspath,append,msg,isdir,str,super,join,mkdir,check_call],... | Setup environment variables for Catalyst. | Do all 3 of these really need to be in `PYTHONPATH`? It's usually just `lib/<whatever>/site-packages` that is necessary. |
@@ -202,6 +202,7 @@ func (s *Session) Connect(ctx context.Context) (*Session, error) {
}
soapClient := soap.NewClient(soapURL, s.Insecure)
+
soapClient.Version = "6.0" // Pin to 6.0 until we need 6.5+ specific API
var login func(context.Context) error
| [Connect->[Vim25],IsVC->[IsVC],Populate->[IsVC],RoundTrip] | Connect connects to the service and returns a new Session object. Keep alive handler. | Minor: unneeded whitespace. |
@@ -0,0 +1,11 @@
+<?php
+
+$oids = array('netspireDeviceModelName.0', 'netSpireDeviceDeviceSerialNo.0');
+
+$data = snmp_get_multi_oid($device, $oids, '-OUQs', 'OACOMMON-MIB', 'openaccess');
+
+$hardware = $data[$oids[0]];
+$serial = $data[$oids[1]];
+
+unset($data);
+unset($oids);
| [No CFG could be retrieved] | No Summary Found. | This is easily broken I think. Take a look at how it's done in `includes/polling/os/ipolis.inc.php` |
@@ -41,6 +41,10 @@ class BaseDocumentManager(models.Manager):
def filter_for_list(self, locale=None, tag=None, tag_name=None,
errors=None, noparent=None, toplevel=None):
+ """
+ Returns a filtered queryset for a list of names and urls.
+ """
+
docs = (self.f... | [DeletedDocumentManager->[get_queryset->[super]],BaseDocumentManager->[clean_content->[parse_content,clean],filter_for_list->[exclude,defer,filter],get_by_natural_key->[get],filter_for_review->[filter],filter_with_localization_tag->[filter],get_queryset->[QuerySet],get_by_stale_rendering->[exclude,now]],DocumentManager... | Filter the queryset for a list of items. | I think `Template_talk` and `Project_talk` can be removed from here. Did not see `User_talk` anywhere in MDN |
@@ -358,7 +358,7 @@ class Jetpack_Photon {
// WP Attachment ID, if uploaded to this site
if (
preg_match( '#class=["|\']?[^"\']*wp-image-([\d]+)[^"\']*["|\']?#i', $images['img_tag'][ $index ], $attachment_id ) &&
- 0 === strpos( $src, $upload_dir['baseurl'] ) &&
+ self::is_local_upload( $sr... | [Jetpack_Photon->[setup->[enable_noresize_mode],should_rest_photon_image_downsize->[get_route],filter_photon_norezise_maybe_inject_sizes->[generate_sizes_meta],instance->[setup]]] | Filters the content of a page. This function is called when an image is loaded from the page. This function filter whether an image using an attachment ID in the class has to go through through This function is used to determine the size of an image and apply a transform to it This function is called to determine the w... | Since we don't use it anymore in that function, maybe we could remove `$upload_dir = wp_get_upload_dir();` from `filter_the_content`? |
@@ -20,7 +20,7 @@ def apply_trans(trans, pts):
Parameters
----------
- trans : array, shape = (4, 4)
+ trans : array, shape = (4, 4) or (3, 3)
Transform matrix.
pts : array, shape = (3,) | (n, 3)
Array with coordinates for one or n points.
| [transform_source_space_to->[invert_transform],transform_coordinates->[invert_transform]] | Apply a transform matrix to an array of points with coordinates for one or n points. | what is the motivation for supporting (3,3) matrices? |
@@ -662,7 +662,10 @@ def show_backtest_results(config: Dict, backtest_stats: Dict):
if len(backtest_stats['strategy']) > 1:
# Print Strategy summary table
+ first_strat_stats = next(iter(backtest_stats['strategy'].items()))[1]
table = text_table_strategy(backtest_stats['strategy_comparis... | [text_table_bt_results->[_get_line_header,_generate_wins_draws_losses,_get_line_floatfmt],show_backtest_results->[text_table_strategy,show_backtest_result],generate_pair_metrics->[_generate_result_line],generate_strategy_stats->[generate_sell_reason_stats,generate_daily_stats,generate_pair_metrics,generate_trading_stat... | Prints backtest results for all possible backtests. | I think this should be simplified to simply (reuse) `results` from the above loop (maybe not here but using results directly down below). In python - the variable in a for loop will keep the value of the last loop. It will not have the first strategy results but the last ones - but i don't think that'll be a problem. |
@@ -38,9 +38,9 @@ use Psr\Log\LoggerInterface;
*/
class Emailer
{
- /** @var IConfig */
+ /** @var \Friendica\Core\Config\Capability\IManageConfigValues */
private $config;
- /** @var IPConfig */
+ /** @var \Friendica\Core\PConfig\Capability\IManagePersonalConfigValues */
private $pConfig;
/** @var LoggerInte... | [Emailer->[newSystemMail->[getSiteEmailAddress,getSiteEmailName],newNotifyMail->[getSiteEmailAddress,getSiteEmailName]]] | Creates an emailer object that can be used to send a user to the user. Initializes the object. | You can use the shorthand since there is a `use` statement. |
@@ -12,6 +12,7 @@ import java.util.Set;
*/
public interface ConsistentHash {
+ @Deprecated
void init(Map<SocketAddress, Set<Integer>> servers2Hash, int numKeyOwners, int hashSpace);
SocketAddress getServer(byte[] key);
| [No CFG could be retrieved] | Initializes the hash table with the given key. | If ConsistentHash is a public API then it is in the wrong package (impl). Otherwise it is an implementation detail and we don't need to mark methods as deprecated: just remove them. |
@@ -1902,4 +1902,15 @@ module.exports = class Exchange {
}
return [ tag, params ]
}
+
+ getSupportedMapping (key, mapping = {}) {
+ // Takes a key and a dictionary, and returns the dictionary's value for that key
+ // :throws:
+ // NotSupported if the dictionary does ... | [No CFG could be retrieved] | get the last n - tuple of tag and params. | I don't think we should add the `mapping` (associative array) to a string here, and if we do, there has to be a space before it. |
@@ -4121,6 +4121,13 @@ namespace System.Net.Sockets
// Prepare for and make the native call.
e.StartOperationCommon(this, SocketAsyncOperation.SendTo);
+
+ EndPoint oldEndPoint = _rightEndPoint;
+ if (_rightEndPoint == null)
+ {
+ _rightEndPoin... | [Socket->[DoBeginSendTo->[SocketError],SetIPProtectionLevel->[SetIPProtectionLevel],SetLingerOption->[SetLingerOption],DoBind->[Bind],Send->[Send],ConnectAsync->[Connect,ConnectAsync,CanTryAddressFamily],Shutdown->[Shutdown],UpdateStatusAfterSocketError->[SetToDisconnected,UpdateStatusAfterSocketError],ReceiveAsync->[R... | Send to the remote end point asynchronously. | I have no idea what black magic could trigger the catch block here, on the other hand `socketError == AccessDenied` is something we can actually hit, see my test cases. Like in `DoBeginSendTo` I'm resetting `_rightEndPoint` when hitting a non-success & non-pending case. |
@@ -1902,7 +1902,7 @@ public final class Matches {
/**
* Check if unit meets requiredUnitsToMove criteria and can move into territory.
*/
- public static Match<Unit> unitHasRequiredUnitsToMove(final Territory t) {
+ public static Match<Unit> unitHasRequiredUnitsToMove(final Territory t, final GameData data... | [Matches->[territoryHasEnemyLandUnits->[enemyUnit],territoryHasEnemySeaUnits->[unitIsSea,enemyUnit],territoryHasUnitsOwnedBy->[unitIsOwnedBy],unitCanProduceUnitsAndIsInfrastructure->[unitCanProduceUnits,unitIsInfrastructure],unitHasRequiredUnitsToMove->[unitIsNotDisabled,unitIsOfType,unitIsOwnedBy],unitCanProduceUnitsA... | unitHasRequiredUnitsToMove returns a match of units that require units to be moved. | Just curious because I've seen this pattern used a lot throughout the codebase... Why can't we use the `GameData` instance associated with the `Territory` (or the `Unit`) instead of passing it as a separate parameter? Won't `t.getData()` (or `unit.getData()`) refer to the same `GameData` instance that is ultimately bei... |
@@ -173,7 +173,7 @@ def add_email_to_activity_log(parser):
'You don\'t have permission to reply to this add-on. You '
'have to be a listed developer currently, or an AMO reviewer.')
else:
- log.warn('%s tried to use an invalid activity email token for '
+ log.warning... | [notify_about_activity_log->[template_from_user],ActivityEmailParser->[get_uuid->[ActivityEmailToNotificationsError,ActivityEmailUUIDError],__init__->[ActivityEmailEncodingError]],add_email_to_activity_log_wrapper->[ActivityEmailParser],add_email_to_activity_log->[ActivityEmailTokenError,ActivityEmailUUIDError,get_uuid... | Add an email to the activity log. | That one messed up the indent :) |
@@ -265,9 +265,9 @@ var NgModelController = ['$scope', '$exceptionHandler', '$attrs', '$element', '$
};
ngModelSet = function($scope, newValue) {
if (isFunction(parsedNgModel($scope))) {
- invokeModelSetter($scope, {$$$p: ctrl.$modelValue});
+ invokeModelSetter($scope, {$$$p: ne... | [No CFG could be retrieved] | Provides a way to access the ng - model attribute of a given element. The view is only invoked if the values of the model and the view are different from the. | @lgalfaso are these two changes correct? |
@@ -279,6 +279,8 @@ window.draw3p = function(opt_configCallback, opt_allowed3pTypes,
window.context.data = data;
window.context.noContentAvailable = triggerNoContentAvailable;
window.context.requestResize = triggerResizeRequest;
+ window.context.renderStart = triggerRenderStart;
+ window.context.is... | [No CFG could be retrieved] | Displays a in the window. Initialize the window context. | This is probably not needed. But I still haven't figure out what value would Javascript script assign to a new declared value. Is it always guaranteed to be `undefined`? |
@@ -195,9 +195,11 @@ type StakeInfoFinder interface {
// New creates a new Consensus object
// TODO: put shardId into chain reader's chain config
-func New(host p2p.Host, ShardID uint32, leader p2p.Peer, blsPriKey *bls.SecretKey) (*Consensus, error) {
+func New(host p2p.Host, ShardID uint32, leader p2p.Peer, blsPri... | [FindStakeInfoByNodeKey->[New,GetLogInstance,FromLibBLSPublicKey,Log15,WithCause],IndexEnabled,GetDefaultConfig,Info,SerializeToHexStr,GetSelfPeer,GetBlsAddress,Add,ToLibBLSPublicKey,WithCallerSkip,SetMask,Cmp,New,GetLogInstance,AddBalance,FromLibBLSPublicKey,FindCommitteeByID,Logger,Debug,Store,Hex,Uint64,GetHeaderByH... | WaitForSyncing returns a new consensus object that can be used to wait for syncing. This function is used to populate the consensus fields of the consensus object. | Since a non-zero `delayCommit` is a special case, please consider not giving it as a mandatory argument, but introduce `SetCommitDelay` instead as a method that can be optionally called if delay behavior is needed. |
@@ -1,6 +1,13 @@
-<?php
+<?php //phpcs:ignore WordPress.Files.FileName.InvalidClassFilename
+/**
+ * Jetpack Network Manager class file.
+ *
+ * @package jetpack
+ */
+use Automattic\Jetpack\Connection\Manager;
use Automattic\Jetpack\Connection\Client;
+use Automattic\Jetpack\Constants;
/**
* Used to manage Jet... | [Jetpack_Network->[jetpack_sites_list->[get_url],render_network_admin_settings_page->[network_admin_page_header],network_admin_page->[get_url],do_subsiteregister->[get_url]]] | Creates a new Jetpack_Network object. Add Jetpack admin bar actions. | Uber nitpick: maybe alphabetically sort the `use` clauses? (or maybe not, if you don't want to ) |
@@ -2556,6 +2556,10 @@ def batch_norm(input,
helper = LayerHelper('batch_norm', **locals())
dtype = helper.input_dtype()
+ # use fp32 for bn parameter
+ if dtype == core.VarDesc.VarType.FP16:
+ dtype = core.VarDesc.VarType.FP32
+
input_shape = input.shape
if data_layout == 'NCHW':
... | [ctc_greedy_decoder->[topk],image_resize->[_is_list_or_turple_],sequence_first_step->[sequence_pool],logical_xor->[_logical_op],elementwise_pow->[_elementwise_op],elementwise_min->[_elementwise_op],elementwise_max->[_elementwise_op],logical_not->[_logical_op],conv2d->[_get_default_param_initializer],logical_and->[_logi... | Batch normalization of a single node - wise network. The statistics of a single node - level training or training. This function creates a hidden variable which is the result after applying batch normalization on the input. | I don't like this hardcode. For now, we should change the model and add cast op before bn. |
@@ -330,8 +330,13 @@ func extractAggs(searchResult *elastic.SearchResult) []*SearchResultLanguages {
}
// Search searches for codes and language stats by given conditions.
-func (b *ElasticSearchIndexer) Search(repoIDs []int64, language, keyword string, page, pageSize int) (int64, []*SearchResult, []*SearchResultLa... | [Index->[addUpdate,addDelete,Index],init->[realIndexerName],Search->[Index,Search],Index] | Search searches for content in the specified languages and repositories. get all content in the index. | Are there constants for these somewhere? If not in the library, could we perhaps make some for our own reference? Might make it easier if/when this ever gets changed again. |
@@ -183,7 +183,7 @@ class FormatOptions
*
* @return FileVersion
*/
- public function getFileVersion()
+ public function getFileVersion(): FileVersion
{
return $this->fileVersion;
}
| [No CFG could be retrieved] | get fileVersion - null if not set. | same as above we can from bc not add new typehints. |
@@ -10,8 +10,9 @@ import { toState } from '../base/redux';
* @returns {boolean}
*/
export function isToolboxVisible(stateful: Object | Function) {
- const { alwaysVisible, enabled, visible }
- = toState(stateful)['features/toolbox'];
+ const state = toState(stateful);
+ const { alwaysVisible, enabl... | [No CFG could be retrieved] | Checks if the toolbox is enabled or not. | What controls the 'visible' flag now? Is it being adjusted anywhere on mobile? Does it default to `true`? |
@@ -536,9 +536,9 @@ public abstract class TripleAPlayer extends AbstractHumanPlayer<TripleAFrame> im
}
@Override
- public int[] selectFixedDice(final int numDice, final int hitAt, final boolean hitOnlyIfEquals, final String title,
+ public int[] selectFixedDice(final int numDice, final int hitAt, final String... | [TripleAPlayer->[move->[move],pickTerritoryAndUnits->[pickTerritoryAndUnits],tech->[tech],userActions->[userActions],selectTerritoryForAirToLand->[selectTerritoryForAirToLand],selectKamikazeSuicideAttacks->[selectKamikazeSuicideAttacks],selectUnitsQuery->[selectUnitsQuery],selectFixedDice->[selectFixedDice],politics->[... | Select fixed dice. | Would you mind de-wrapping this parameter list now that it should all fit on one line? Ditto for the similar methods in `AbstractUi`, `DiceChooser`, and `TripleAFrame` below. |
@@ -4,6 +4,7 @@
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
+using System.Text.Json.SourceGeneration;
namespace System.Text.Json.Reflection
{
| [TypeExtensions->[GetTypeInfoPropertyName->[GetTypeInfoPropertyName],GetCompilableName->[GetCompilableName]]] | This class is used to provide a more detailed description of a type that can be compil Replies the name of the type that is used to create the type identifier. | Is this change necessary? |
@@ -31,6 +31,7 @@ import (
"github.com/vmware/vic/lib/install/data"
"github.com/vmware/vic/lib/install/management"
"github.com/vmware/vic/lib/install/validate"
+
"github.com/vmware/vic/pkg/errors"
"github.com/vmware/vic/pkg/trace"
)
| [Run->[logArguments,processParams],Flags->[Flags],logArguments->[SetFields]] | Creates a new object with all the necessary variables and values defined in the n - von Create a new vic - machine instance from a single object. | nit: I don't think this line should be here |
@@ -92,7 +92,9 @@ class MechanicalSolver(PythonSolver):
"analysis_type": "non_linear",
"model_import_settings": {
"input_type": "mdpa",
- "input_filename": "unknown_name"
+ "input_filename": "unknown_name",
+ "physics_input_type": "... | [MechanicalSolver->[AddDofs->[AddDofs],_create_convergence_criterion->[_get_convergence_criterion_settings],_create_builder_and_solver->[get_linear_solver],_execute_after_reading->[import_constitutive_laws],Initialize->[Initialize],_create_line_search_strategy->[GetComputingModelPart,get_solution_scheme,get_builder_and... | Returns the default settings for the KratosMultiphysics class. | please remove those, the parameters are not validated recursively, hence this is not used in any case |
@@ -465,13 +465,13 @@ function elgg_get_file_simple_type($mime_type) {
}
/**
- * Initialize the file library.
- * Listens to system init and configures the default filestore
+ * Listens to system init and configures the default filestore
*
* @return void
* @access private
*/
-function _elgg_filestore_init(... | [_elgg_filestore_detect_mimetype->[fixDetectionErrors],get_resized_image_from_uploaded_file->[getPathname,has,get,getError],file_delete->[delete,setFilename,canEdit],elgg_get_download_url->[bindSession,setDisposition,setFile,getURL,setExpires],elgg_get_inline_url->[bindSession,setDisposition,setFile,getURL,setExpires],... | Initialize filestore object. | ~~You may want to look at this file in master to avoid giant conflicts here.~~ no big deal. |
@@ -178,7 +178,6 @@ func (m *commonMetric) GetValue(metric *dto.Metric) interface{} {
key := strconv.FormatFloat(bucket.GetUpperBound(), 'f', -1, 64)
bucketMap[key] = bucket.GetCumulativeCount()
}
-
if len(bucketMap) != 0 {
value["bucket"] = bucketMap
}
| [GetValue->[GetCumulativeCount,GetCounter,GetQuantile,IsNaN,GetUpperBound,GetBucket,GetSampleSum,FormatFloat,GetSampleCount,GetValue,GetHistogram,GetSummary,GetGauge],Process->[ToLower,FormatFloat,ParseFloat],GetLabel,GetName,GetValue] | GetValue returns the value of a metric. | Nit: Unrelated to this PR ;-) |
@@ -31,13 +31,13 @@ func NewImageStreamEvaluator(isNamespacer osclient.ImageStreamsNamespacer) kquot
ConstraintsFunc: generic.ObjectCountConstraintsFunc(imageapi.ResourceImageStreams),
UsageFunc: generic.ObjectCountUsageFunc(imageapi.ResourceImageStreams),
ListFuncByNamespace: func(namespace st... | [ImageStreams,Kind,List,ObjectCountConstraintsFunc,ObjectCountUsageFunc] | MatchedResourceNames returns a list of all resources that match the filter. | Is it necessary to deep-copy here? |
@@ -46,6 +46,7 @@ func createRouter(prefix string, svr *server.Server) *mux.Router {
router.HandleFunc("/api/v1/schedulers/{name}", schedulerHandler.Delete).Methods("DELETE")
router.Handle("/api/v1/cluster", newClusterHandler(svr, rd)).Methods("GET")
+ router.HandleFunc("/api/v1/raft/bootstrap/time", newClusterHa... | [Handle,NewRouter,New,Subrouter,GetHandler,HandleFunc,PathPrefix,Methods] | Create a router for the list of all the n - node resources. StoreHandler - A router for all store endpoints. | How about 'bootstrap_time', consistent with the key below. |
@@ -346,8 +346,8 @@ namespace ProtoCore.Utils
if (!sv.IsArray)
return core.TypeSystem.GetType(sv) == (int)PrimitiveType.kTypeDouble;
- StackValue[] svArray = core.Rmem.GetArrayElements(sv);
- foreach (var item in svArray)
+ var values = ArrayUtils.GetValu... | [ArrayUtils->[GetFullSize->[GetElementSize,GetValueSize],TryGetValueFromNestedDictionaries->[TryGetValueFromNestedDictionaries],ContainsNonArrayElement->[ContainsNonArrayElement],GetMaxRankForArray->[GetMaxRankForArray],ContainsKey->[ContainsKey],StackValue->[GetElementSize,GetZippedIndices],GetTypeStatisticsForArray->... | Checks if the double element in the stack is a member of the double array. | You can do away with this for loop using values.Any(v => ContainsDoubleElement(v, core)); |
@@ -195,6 +195,11 @@ class APIServer(object):
assert file
web3 = self.flask_app.config.get('WEB3_ENDPOINT')
if web3 and 'config.' in file and file.endswith('.json'):
+ host = request.headers.get('Host')
+ if any(h in web3 for h in ('localhost', '127.0... | [RestAPI->[register_token->[register_token,jsonify_with_response],get_connection_managers_list->[get_connection_managers_list],patch_channel->[deposit,close,get_channel],get_partners_by_token->[get_channel_list],get_channel_events->[get_channel_events,normalize_events_list],get_connection_manager_funds->[get_connection... | Serve a webui file. | I'm not sure this will be useful in practice. We can't just assume that the eth node will be available (and accept connections) on port 8545 of whatever the `Host` header points to. |
@@ -325,14 +325,6 @@ out:
static void
mgmt_svc_step_down_cb(struct ds_rsvc *rsvc)
{
- struct mgmt_svc *svc = mgmt_svc_obj(rsvc);
- int rc;
-
- svc->ms_step_down = true;
- ABT_cond_broadcast(svc->ms_distribute_cv);
- rc = ABT_thread_join(svc->ms_distributord);
- D_ASSERTF(rc == 0, "%d\n", rc);
- ABT_thread_f... | [No CFG could be retrieved] | This function finds the in the system map and attempts to find it. Management Service Management Service Management Service Management Service Management Service Management Service Management Service Management Service Management Service. | Just asking are lines 368-438 here not new - just moving existing code earlier in the file? |
@@ -4181,8 +4181,9 @@ def beam_search(step,
- machine translation : demo/seqToseq/translation/gen.conf \
demo/seqToseq/seqToseq_net.py
- :param name: Name of the recurrent unit that generates sequences.
- :type name: base string
+ :param name: The name of the recurrent unit ... | [seq_concat_layer->[LayerOutput],out_prod_layer->[LayerOutput],img_pool_layer->[LayerOutput],multiplex_layer->[LayerOutput],cross_entropy->[LayerOutput,__cost_input__],multibox_loss_layer->[LayerOutput],gated_unit_layer->[fc_layer,dotmul_operator,mixed_layer],lstm_step_layer->[LayerOutput],clip_layer->[LayerOutput],Mix... | A beam search algorithm that uses a simple RNN algorithm. This function is used to create a LayerOutput from a sequence of Candidates. Missing node - level layer group set. | that generates sequences. --> that is responsible for generating sequences. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.