patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -520,6 +520,7 @@ class KafkaExactlyOnceSink<K, V>
}
}
+ @SuppressFBWarnings("REC_CATCH_EXCEPTION")
private ShardWriter<K, V> initShardWriter(
int shard, ValueState<String> writerIdState, long nextId) throws IOException {
| [KafkaExactlyOnceSink->[ExactlyOnceWriter->[setup->[ensureEOSSupport],ShardWriter->[commitTxn->[ShardMetadata]]]]] | Initializes a ShardWriter for the given shard. This method is called when a partition is being created. | The goal of the JIRA is to fix the warnings, in this case deal with the different exceptions. Can't this be fixed? If it is really impossible to fix, prefer using the `findbugs-filter.xml` (or `spotbugs-filter.xml`) file to do the exclusions. |
@@ -140,7 +140,7 @@ public final class ContainerBalancerConfiguration {
// greater than container size
long size = (long) ozoneConfiguration.getStorageSize(
ScmConfigKeys.OZONE_SCM_CONTAINER_SIZE,
- ScmConfigKeys.OZONE_SCM_CONTAINER_SIZE_DEFAULT, StorageUnit.GB) +
+ ScmConfigKeys.OZONE_... | [ContainerBalancerConfiguration->[getThreshold->[parseDouble],setMaxDatanodesRatioToInvolvePerIteration->[IllegalArgumentException,valueOf],getMoveTimeout->[ofMillis],getIncludeNodes->[toSet,collect,emptySet,isEmpty],getBalancingInterval->[ofMillis],getExcludeContainers->[toSet,collect,isEmpty],setThreshold->[IllegalAr... | Container Balancer configuration. Sets the threshold for the container allocation. | @siddhantsangwan Another issue is the StorageUnit here. The value from Unit.GB is "5 + 1GB", need to changed to Unit.BYTES. |
@@ -57,6 +57,7 @@ public class StringInputRowParser implements ByteBufferInputRowParser
this.parseSpec = parseSpec;
this.mapParser = new MapInputRowParser(parseSpec);
this.parser = parseSpec.makeParser();
+ parser.startFileFromBeginning();
if (encoding != null) {
this.charset = Charset.f... | [StringInputRowParser->[withParseSpec->[getEncoding,StringInputRowParser],parse->[parseString],parseMap->[parse],parseString->[parse]]] | Package for parsing a string input row. This is a private utility method that creates a Map of String keys and values from a ByteBuffer. | StringInputRowParser is used by parser options that aren't file-oriented (you can use it on streams etc) so this isn't a good place to put this. imo, this should replace `reset()` and be called in places that `reset()` is currently called (like FileIteratingFirehose). With one addition: it needs to be called before the... |
@@ -81,9 +81,13 @@ class SCMBase(object):
class Git(SCMBase):
cmd_command = "git"
+ @property
def _configure_ssl_verify(self):
- # TODO: This should be a context manager
- return self.run("config http.sslVerify %s" % ("true" if self._verify_ssl else "false"))
+ return "-c http.sslVe... | [_check_repo->[_run_muted],Git->[check_repo->[_check_repo],get_remote_url->[run,_remove_credentials_url],get_branch->[run],get_tag->[run],_configure_ssl_verify->[run],is_local_repository->[get_remote_url],get_commit_message->[run],get_repo_root->[run],checkout->[run],is_pristine->[run],get_commit->[run],clone->[_config... | Configure SSL verify on a node. | Do all git commads have the possibility to use ``-c http.sslVerify=``? I am not sure. Take into account that this ``run()`` method will be used to run different git commands as a tool, not only the commands performed for SCM as we have this class exposed in ``conans.tools`` |
@@ -222,8 +222,7 @@ uint8_t matrix_scan(void) {
debounce(raw_matrix, matrix, MATRIX_ROWS, changed);
- // Read encoder switches, already debounced
- changed |= read_encoder_values(matrix, 4);
+ changed |= read_encoder_switches(matrix, 4);
matrix_scan_quantum();
return (uint8_t)changed;
| [bool->[unselect_col,select_col,wait_us,select_row,readPin,unselect_row],matrix_init_kb->[setPinInput],matrix_scan->[matrix_scan_quantum,read_rows_on_col,read_cols_on_row,debounce,read_encoder_values],matrix_init->[matrix_init_quantum,init_pins,debounce_init],void->[setPinInputHigh,writePinLow,unselect_rows,unselect_co... | This function scans the matrix for missing values. | As you have removed the debounce logic, wouldnt the reading need to be moved before the `debounce()` call? |
@@ -82,12 +82,6 @@ public abstract class AbstractRegisteredService implements RegisteredService, Co
@Column(name = "proxy_policy", nullable = false)
private RegisteredServiceProxyPolicy proxyPolicy = new RefuseRegisteredServiceProxyPolicy();
- @Column(name = "enabled", nullable = false)
- private bool... | [AbstractRegisteredService->[toString->[toString],copyFrom->[getDescription,getName,getLogoutType,getProxyPolicy,getUsernameAttributeProvider,setLogoutType,isEnabled,setSsoEnabled,getId,setName,isSsoEnabled,setDescription,setTheme,setProxyPolicy,getTheme,getEvaluationOrder,setId,setServiceId,getServiceId,setUsernameAtt... | The unique identifier for a service. region AttributeReleasePolicy Provides a list of AttributeReleasePolicy objects that can be used to release. | people are going to have to change their local DB DDL since these were not nullable and now they'll never be set. |
@@ -122,7 +122,7 @@ class FileMixin:
if self._is_git_ignored():
raise FileIsGitIgnored(self.path)
- def _load(self):
+ def _load(self, use_pydantic: bool = False):
# it raises the proper exceptions by priority:
# 1. when the file doesn't exists
# 2. filename is n... | [check_dvc_filename->[is_valid_filename],Lockfile->[load->[_load],_load->[LockfileCorruptedError,_check_gitignored],validate->[get_lockfile_schema],remove_stage->[exists,validate,remove],dump->[migrate_lock_v1_to_v2]],SingleStageFile->[merge->[merge,dump],stages->[_load],stage->[_load],remove_stage->[remove],dump->[rel... | Checks if the file is git ignored or not. | To test new schema, you can toggle this to `True`, and it should start using the new schema for validation. |
@@ -30,6 +30,10 @@ class Article < ApplicationRecord
counter_culture :user
counter_culture :organization
+ MAX_USER_MENTIONS = 7 # Explicitly set to 7 to accommodate DEV Top 7 Posts
+ # The date that we began limiting the number of user mentions in an article.
+ MAX_USER_MENTION_LIVE_AT = Time.utc(2021, 4, 7... | [Article->[username->[username],evaluate_front_matter->[set_tag_list],update_notifications->[update_notifications],readable_edit_date->[edited?]]] | Includes the ModelViewModelSerializer and DataSyncModelSerializer classes. The default configuration for the tag validator. | I chose this somewhat randomly -- I was operating under the assumption that if this were merged tomorrow, we could set this to be live on Wednesday at midnight UTC (which would be tomorrow/Tuesday, April 6th at 4pm PT / 7pm ET) |
@@ -23,7 +23,9 @@ class ArgSplitterError(Exception):
class SplitArgs:
"""The result of splitting args."""
+ builtin_goals: list[str] # Requested builtin goals (explicitly or implicitly).
goals: list[str] # Explicitly requested goals.
+ unknown_goals: list[str] # Any unknown goals.
scope_to_fl... | [ArgSplitter->[_check_for_help_request->[VersionHelp,ThingHelp,AllHelp],_consume_flags->[_check_for_help_request],split_args->[UnknownGoalHelp,SplitArgs,NoGoalHelp,add_scope,assign_flag_to_scope,_check_for_help_request]]] | Provides a description of the given sequence of flags and optional requirements. The command line tool for the . | We need to expose these now, in order for built in goals to be able to act upon them. |
@@ -126,6 +126,17 @@ async def generate_lockfile(
input_digest=pyproject_toml_digest,
output_files=("poetry.lock", "pyproject.toml"),
description=req.description,
+ # Instead of caching lockfile generation with LMDB, we instead use the invalidation
+ # scheme... | [generate_lockfiles_goal->[GenerateLockfilesGoal],generate_lockfile->[PythonLockfile]] | Generate a lockfile from a Poetry or Pex. Get a single node in the lockfile. | It seems like the oddness would all be solved if the inputs to a lock rule were (`<resolve inputs>`, `<lockfile snapshot from FS if it exists>`): 1. lockfile snapshot DNE: generate using resolve inputs. 2. lockfile snapshot does exist: compare resolve inputs to snapshot header and only resolve if diff unless --force, i... |
@@ -53,6 +53,11 @@ module Users
end
end
+ def process_locked_out_user
+ render 'two_factor_authentication/shared/max_login_attempts_reached'
+ sign_out
+ end
+
def now
@_now ||= Time.zone.now
end
| [SessionsController->[cache_active_profile->[new],track_authentication_attempt->[new],now->[now]]] | Checks if the user needs a redirect. If it does it redirects to after_sign_. | do you think we should sign out then render? Not sure if it matters, just wondering if the page might render different content based on signed in / out status. |
@@ -3,8 +3,10 @@ module Articles
include Rails.application.routes.url_helpers
include CloudinaryHelper
- def initialize(article)
+ def initialize(article, **options)
@article = article
+ @height = options[:height] || 420
+ @width = options[:width] || 1000
end
SOCIAL_PREVIE... | [SocialImage->[url->[present?,article_social_preview_url,use_new_social_url?,cl_image_path],legacy_article_social_image->[comments_count,fetch,social_image,rfc3339,hour,cl_image_path,start_with?],use_new_social_url?->[updated_at],user_defined_image->[video_thumbnail_url,present?,main_image,social_image],parse,attr_read... | Initialize a new object with a single article and a sequence of options. | I just noticed, this is 420, but on line 18, it was 500. Intentional change? |
@@ -0,0 +1,8 @@
+using System;
+
+namespace LibraryWithResources
+{
+ public class Class1
+ {
+ }
+}
| [No CFG could be retrieved] | No Summary Found. | this is missing the license header |
@@ -96,7 +96,8 @@ class TestOneHotOp_exception(OpTest):
block.append_op(
type='one_hot',
inputs={'X': x},
- attrs={'depth': self.depth},
+ attrs={},
+ inputs_or_attr={'depth': self.depth},
outputs={'Out': one_ho... | [TestOneHotOp_exception->[test_check_output->[run->[run]]]] | Checks that the output of the n - hot filter is met. | What's the meaning of `inputs_or_attr `? |
@@ -37,6 +37,7 @@ def setup_parser(subparser):
cd_group = subparser.add_mutually_exclusive_group()
arguments.add_common_arguments(cd_group, ['clean', 'dirty'])
+ subparser.epilog = 'DEPRECATED: use `spack build-env` instead'
def write_spconfig(package, dirty):
| [setup->[msg,DIYStage,setup_parser,write_spconfig,die,set,write_transaction,getcwd,ArgumentParser,parse_args,concretize,len,format,isinstance,exists,install,deepcopy,parse_specs,get],write_spconfig->[set_executable,list,split,environ,write,find,keys,dict,which,str,sorted,repr,join,setup_package,open,cmake_args],setup_p... | Setup the parser for the cmake - cmake package. n - Prints missing node - uuid in environment variables. | I think this should be dev-build |
@@ -50,7 +50,7 @@ public interface ResourceService {
Host cancelMaintenance(CancelMaintenanceCmd cmd);
- Host reconnectHost(ReconnectHostCmd cmd);
+ Host reconnectHost(ReconnectHostCmd cmd) throws CloudRuntimeException, AgentUnavailableException;
/**
* We will automatically create a cloud.co... | [No CFG could be retrieved] | for unit testing only. | The `CloudRuntimeException` is a `RuntimeException` you do not need to declare it in the method signature. |
@@ -136,7 +136,13 @@ class Optimizer(object):
self._dtype = None
# Infer the dtype form parameter
if self._parameter_list:
- self._dtype = self._parameter_list[0].dtype
+ if isinstance(self._parameter_list[0], dict):
+ for param_group in self._parameter_li... | [Optimizer->[apply_gradients->[_create_optimization_pass],step->[_apply_optimize],state_dict->[state_dict],set_state_dict->[set_state_dict],_create_param_lr->[_global_learning_rate],_apply_optimize->[apply_gradients,_create_optimization_pass],_create_optimization_pass->[_update_param_device_map,_append_optimize_op,_fin... | Initializes the object with the given parameters and weight decay and gradient clipping. Reset all objects to zero. | do we need check whether `self._parameter_list` only hold one dict? |
@@ -22,13 +22,13 @@ class Config
'vendor-dir' => 'vendor',
'bin-dir' => '{$vendor-dir}/bin',
'notify-on-install' => true,
- 'github-protocols' => array('git', 'https', 'http'),
+ 'github-protocols' => array('https', 'git'),
);
public static $defaultRepositories = arr... | [Config->[process->[get],get->[process]]] | Creates an instance of Config class. Get a repository list. | Why that? The Git protocol works way better/faster for many people, so that'd be quite annoying. |
@@ -408,7 +408,7 @@ public class TestOzoneTenantShell {
executeHA(tenantShell, new String[] {"create", "finance"});
checkOutput(out, "", true);
checkOutput(err, "Failed to create tenant 'finance':"
- + " Tenant already exists\n", true);
+ + " Tenant 'finance' already exists\n", true);
... | [TestOzoneTenantShell->[testAssignAdmin->[executeHA,checkOutput],getHASetConfStrings->[getSetConfStringFromConf,generateSetConfString,getHASetConfStrings],testTenantSetSecret->[executeHA,checkOutput],shutdown->[shutdown],reset->[reset],checkOutput->[reset,checkOutput],execute->[execute],testListTenantUsers->[executeHA,... | Checks if the tenant exists in the audit log and if it does creates it. Check if the user has accessId or secret and if it does try to assign it to Get user info bob and assign admin to dev Look for a user with accessId and revokes it. | Side note: we should have a jira for the fixme above so we don't forget about it. Or change it to say TODO so we can grep and fix all the TODOs our final merge. Unrelated but I just happened to see it. |
@@ -253,6 +253,7 @@ namespace ProtoCore
public RuntimeData RuntimeData { get; set; }
#endregion
+
// This flag is set true when we call GraphUtilities.PreloadAssembly to load libraries in Graph UI
public bool IsParsingPreloadedAssembly { get; set; }
| [Core->[BfsBuildInstructionStreams->[BfsBuildInstructionStreams],BfsBuildSequenceTable->[BfsBuildSequenceTable],BfsBuildProcedureTable->[BfsBuildProcedureTable],GenerateExecutable->[GenerateExprExe,BfsBuildInstructionStreams,RuntimeData,BfsBuildSequenceTable,BfsBuildProcedureTable],ResetAll]] | The base class for all of the components of a CBN. region Message object. | Please revert white space changes to make the code easier to reivew |
@@ -29,7 +29,7 @@ public class FileStorageConfiguration implements StoreConfiguration {
@Override
public StoreType getStoreType() {
- return StoreType.DATABASE;
+ return StoreType.FILE;
}
public String getMessageTableName() {
| [FileStorageConfiguration->[getDefaultBindingsTableName,getDefaultDatabaseUrl,getDefaultMessageTableName]] | Returns the store type of the database. | @mtaylor this was a bug, right? |
@@ -30,7 +30,7 @@ def assert_sqlite_version() -> bool:
class SQLiteStorage:
def __init__(self, database_path, serializer):
- conn = sqlite3.connect(database_path)
+ conn = sqlite3.connect(database_path, detect_types=sqlite3.PARSE_DECLTYPES)
conn.text_factory = str
conn.execute('P... | [SQLiteStorage->[get_latest_state_change_by_data_field->[StateChangeRecord],get_events->[_query_events],get_latest_event_by_data_field->[EventRecord],get_events_with_timestamps->[_query_events]]] | Initialize the object with the given database path and serializer. | I don't think adding `PARSE_DECLTYPES` is really required but it does not seem to break anything. |
@@ -630,9 +630,9 @@ public class UserVmManagerTest {
when(vlan.getVlanNetmask()).thenReturn("255.255.255.0");
when(_ipAddrMgr.allocatePublicIpForGuestNic(Mockito.eq(_networkMock), nullable(Long.class), Mockito.eq(_accountMock), anyString())).thenReturn("10.10.10.10");
- lenient().when(_ipAddr... | [UserVmManagerTest->[testValidateRootDiskResize->[thenReturn,mock,validateRootDiskResize,instanceOf,assertThat,containsKey,put,valueOf,fail],testMoveVmToUser2->[setState,moveVMToUser,thenReturn,checkAccess,UserVmVO,setAccessible,nullable,unregister,register,getDeclaredField,set,AccountVO,toString,setId,UserVO,AssignVMC... | test update vmnic ip success 2 This method is called when the user is not able to find a matching user in the system. | Sorry I hope I'm wrong here, but isn't this too specific, looks like hardcoded to me? |
@@ -91,6 +91,15 @@ public class OnHeapNamespaceExtractionCacheManager extends NamespaceExtractionCa
return new CacheHandler(this, cache, cacheRef);
}
+ @Override
+ public CacheHandler createCache(ConcurrentMap<String, String> cache)
+ {
+ WeakReference<ConcurrentMap<String, String>> cacheRef = new WeakR... | [OnHeapNamespaceExtractionCacheManager->[cacheCount->[expungeCollectedCaches],createCache->[expungeCollectedCaches],monitor->[expungeCollectedCaches]]] | Creates a new cache. | This logic disturbs the logic of `monitor()` which may now count the same cache several times. Even if you do proper filtering in `monitor()`, if there is a leak of `CacheHandler` objects then this logic (wrapping existing cache into another a new `WeakReference`) will create a leak in `caches` and will defeat the orig... |
@@ -79,11 +79,18 @@ class Telegram extends Transport
'name' => 'telegram-token',
'descr' => 'Telegram Token',
'type' => 'text',
+ ],
+ [
+ 'title' => 'Format',
+ 'name' => 'telegram-format'... | [Telegram->[deliverAlertOld->[contactTelegram],deliverAlert->[deliverAlertOld,contactTelegram]]] | Template for config array. | You shouldn't make this required as it's an optional field to telegram. |
@@ -27,8 +27,8 @@ func main() {
}
opt0 := true
ami, err := aws.GetAmi(ctx, &GetAmiArgs{
- Filters: []GetAmiFilter{
- GetAmiFilter{
+ Filters: []GetAmiFilterArgs{
+ &GetAmiFilterArgs{
Name: "name",
Values: []string{
"amzn-ami-hvm-*-x86_64-ebs",
| [GetAmi,Int,Sprintf,Export,NewSecurityGroup,NewInstance,String,Run] | main import imports the given object and imports it into the context. export publicIp publicHostName. | This is a regression I am introducing... Patch likely needs a little more work. |
@@ -277,7 +277,14 @@ export function selectGptExperiment(data) {
*/
export function writeAdScript(global, data, gptFilename) {
const url =
- `https://www.googletagservices.com/tag/js/${gptFilename || 'gpt.js'}`;
+ `https://www.googletagservices.com/tag/js/${gptFilename || 'gpt.js'}`;
+ const hasUSDRD = d... | [No CFG could be retrieved] | Writes an ad script to the specified file. | I think you only need do this in doubleclick config otherwise it will appear twice |
@@ -218,6 +218,12 @@ namespace Js
{
Assert(!this->isDetached);
+ if (this->IsProjectionArrayBuffer())
+ {
+ Recycler* recycler = GetType()->GetLibrary()->GetRecycler();
+ recycler->ReportExternalMemoryFree(bufferLength);
+ }
+
this->buffer = nullptr;
... | [No CFG could be retrieved] | This function is called by the ArrayBuffer when it is detached from its parent. ArrayBufferParent - Add parent method. | why only projection array buffer? #Resolved |
@@ -74,5 +74,7 @@ export function shouldDisplayTileView(state: Object = {}) {
state['features/video-layout']
&& state['features/video-layout'].tileViewEnabled
&& !state['features/etherpad'].editing
+ && (typeof interfaceConfig === 'undefined'
+ || !interfaceC... | [No CFG could be retrieved] | Check if the video layout is enabled and the ethernet pad is not editing or not. | This basically means that if interface config is undefined we default to tile view. Is there any reason to do that? |
@@ -226,12 +226,10 @@ public class ReactiveInterceptorAdapter extends AbstractInterceptorAdapter
resolvedParameters.putAll(params.entrySet().stream()
.collect(toMap(e -> e.getKey(),
e -> new DefaultProcessorParameterValue(e.getKey(), null, () -> e.getValue().get()... | [ReactiveInterceptorAdapter->[removeResolvedParameters->[removeResolvedParameters],setInternalParamsForNotParamResolver->[resolveParameters,setInternalParamsForNotParamResolver]]] | This method is overridden to add the necessary parameters to the event. | this does not belong in this PR |
@@ -673,7 +673,7 @@ namespace System.Globalization
return CultureData.Invariant;
}
- if (GlobalizationMode.PredefinedCulturesOnly && !GlobalizationMode.Invariant)
+ if (GlobalizationMode.PredefinedCulturesOnly)
{
if (GlobalizationMode.U... | [CultureData->[CreateCultureData->[NormalizeCultureName],GetSeparator->[UnescapeNlsString],DateSeparator->[ShortDates]]] | Returns the culture data for the given culture name. | could you please add assert here for !GlobalizationMode.Invariant? |
@@ -117,6 +117,14 @@ public class BigQueryHelpers {
}
static String jobToPrettyString(@Nullable Job job) throws IOException {
+ if (job != null && job.getConfiguration().getLoad() != null) {
+ // Removing schema and sourceUris from error messages for load jobs since these fields can be
+ // quite l... | [BigQueryHelpers->[verifyTablePresence->[toTableSpec],JsonTableRefToTableRef->[apply->[fromJsonString]],TableRefToJson->[apply->[toJsonString]],JsonSchemaToTableSchema->[apply->[fromJsonString]],TableSchemaToJsonSchema->[apply->[toJsonString]],verifyTableNotExistOrEmpty->[toTableSpec],verifyDatasetPresence->[toTableSpe... | Returns job or status as String if job or status is null. | Do you know how expensive this operation is? If this gets called in a crash-loop the cost could add up quick. If it is expensive, we could consider caching the `job.toPrettyString()` output, assuming the Job object is immutable. But, if performance isn't a concern, then better to keep the code simple and leave as-is. |
@@ -16,6 +16,8 @@ class IntelOneapiMpi(IntelOneApiLibraryPackage):
homepage = 'https://software.intel.com/content/www/us/en/develop/tools/oneapi/components/mpi-library.html'
+ executables = [r'^mpiicpc$'] # one should be sufficient
+
if platform.system() == 'Linux':
version('2021.4.0',
... | [IntelOneapiMpi->[install->[join_path,filter_file,super],headers->[join_path,find_headers],libs->[join_path,find_libraries,find_system_libraries],setup_dependent_build_environment->[join_path,set],setup_dependent_package->[join_path],system,depends_on,version,provides,variant]] | Creates a new object of type n_n_n_n_n_n_ Add a dependency to the component. | How does this differentiate between the old, non-oneapi intel mpi compiler? Or does that not matter in this case. Is it the version, ie. 2021.x.y? |
@@ -210,6 +210,17 @@ public class VaultBootstrapConfig {
@ConfigItem(defaultValue = DEFAULT_READ_TIMEOUT)
public Duration readTimeout;
+ /**
+ * List of remote hosts that are not proxied when the client is configured to use a proxy. This
+ * list serves the same purpose as the JVM {@code nonProxy... | [VaultBootstrapConfig->[getAuthenticationType->[isUserpass,isPresent,isAppRole],KvPathConfig->[emptyList],toString->[maskWithTolerance,orElse]]] | This class defines the logic that should be applied to Vault. A VaultRuntimeConfig is a VaultRuntimeConfig that contains the information about the Vault authentication type. | if this was just a `List`, and the property was not defined, would that end up being an empty list? if so do we need an optional around the list? |
@@ -71,6 +71,18 @@ shared_examples_for 'recovery code page' do
expect(page).not_to have_xpath("//#{invisible_selector}[@id='recovery-code']")
end
+ scenario 'focus is on first input and is trapped in modal' do
+ click_acknowledge_recovery_code
+
+ expect(page.evaluate_script('docume... | [have_xpath,let,to_not,have_current_path,it,to,have_content,before,click_link,generate_class_selector,shared_examples_for,scenario,t,click,include,recovery_code,click_on,context,not_to,eq] | context modal content missing - actions. | would it make sense to also test that closing the modal does not "trap" the focus? I think that is what you are setting up when you have ` this.trap[showing ? 'activate' : 'deactivate']();` so would be good to have test coverage for that, too! |
@@ -1205,11 +1205,11 @@ akey_update_recx(daos_handle_t toh, uint32_t pm_ver, daos_recx_t *recx,
biov = iod_update_biov(ioc);
ent.ei_addr = biov->bi_addr;
- ent.ei_addr.ba_dedup = 0; /* Don't make this flag persistent */
+ ent.ei_addr.ba_dedup = false; /* Don't make this flag persistent */
rc = evt_insert(toh, &... | [No CFG could be retrieved] | Updates the extent of a DOS record. region DAOS Key Update. | (style) 'ba' may be misspelled - perhaps 'by'? |
@@ -137,14 +137,10 @@ namespace Microsoft.Xna.Framework.Input
unchecked
{
var hashCode = _x;
- hashCode = (hashCode*397) ^ _y;
- hashCode = (hashCode*397) ^ _scrollWheelValue;
- hashCode = (hashCode*397) ^ _horizontalScrollWheelValu... | [MouseState->[_xButton1,_rightButton,_scrollWheelValue,_middleButton,_horizontalScrollWheelValue,_leftButton,_y,_xButton2,_x]] | Returns a hashCode for this button. | A few of the property declarations are using tabs instead of spaces for indenting. |
@@ -534,6 +534,14 @@ class FetchResponseHeaders {
get(name) {
return this.xhr_.getResponseHeader(name);
}
+
+ /**
+ * @param {string} name
+ * @return {boolean}
+ */
+ has(name) {
+ return !!this.xhr_.getResponseHeader(name);
+ }
}
| [No CFG could be retrieved] | Gets an XHR header from the browser or window. | Is `''` a valid "I have this header"? We could test for `== null` instead. |
@@ -159,6 +159,9 @@ public class FlinkSavepointTest implements Serializable {
// Initial parallelism
options.setParallelism(2);
options.setRunner(FlinkRunner.class);
+ // Enable checkpointing interval for streaming non portable pipeline to avoid
+ // checkpointCoordinator shutdown
+ if (!isPorta... | [FlinkSavepointTest->[getJobGraph->[getJobGraph],restoreFromSavepointPortable->[executePortable]]] | Runs a savepoint and restores the job. | Why is this not a problem for portable pipelines? |
@@ -83,8 +83,9 @@ func (p *cniPlugin) doCNI(url string, req *cniserver.CNIRequest) ([]byte, error)
// Send the ADD command environment and config to the CNI server, returning
// the IPAM result to the caller
-func (p *cniPlugin) CmdAdd(args *skel.CmdArgs) (types.Result, error) {
- body, err := p.doCNI("http://dummy... | [skelCmdAdd->[CmdAdd],CmdDel->[doCNI],CmdAdd->[doCNI]] | CmdAdd is the main function for the CNI plugin. It is called by the plugin. | Any reason to do this in the environment rather than just stuff it into the JSON by extending CNIRequest? |
@@ -17,4 +17,5 @@ class Libxdmcp(AutotoolsPackage):
depends_on('xproto', type='build')
depends_on('pkgconfig', type='build')
depends_on('util-macros', type='build')
- depends_on('libbsd')
+ depends_on('libbsd', when='platform=linux')
+ depends_on('libbsd', when='platform=cray')
| [Libxdmcp->[depends_on,version]] | requires_on - returns all packages that are required to build the package. | I recently added this dependency in #10122 because I couldn't get `libxdmcp` to build without it on Cray, but now it's causing problems on macOS. |
@@ -496,6 +496,8 @@ public class ThriftCodec implements Codec2 {
protocol.writeByte(VERSION);
// service name
protocol.writeString(serviceName);
+ // path
+ protocol.writeString(inv.getAttachment(Constants.PATH_KEY));
// dubbo request id
... | [ThriftCodec->[encodeRequest->[nextSeqId],RequestData->[create->[RequestData]],decode->[decode]]] | Encodes the specified request into a message. Gets the method that sets the specified object. Returns a sequence of bytes that can be used to create a new object. | It seems that we should adjust ThriftCodecTest to make the UT pass. |
@@ -850,9 +850,10 @@ class _BaseRaw(ProjMixin, ContainsMixin, UpdateChannelsMixin,
for p in picks)
for pp, p in enumerate(picks):
self._data[p, :] = data_picks_new[pp]
+ return self
@verbose
- def apply_hilbert(self, picks, envelope=F... | [_start_writing_raw->[append],ToDataFrameMixin->[to_data_frame->[_get_check_picks]],_check_update_montage->[append],_write_raw->[_write_raw],_BaseRaw->[notch_filter->[notch_filter],apply_function->[_check_fun],_preload_data->[_read_segment],crop->[_update_times],__setitem__->[_parse_get_set_params],resample->[_update_t... | Applies a function to a subset of channels. Apply a function to the base object and store the result in self. _data. The base method for the base class. missing - node - pick - n - nanomorphs. | where do you check that the passed dtype is ok? |
@@ -489,8 +489,12 @@
}
$new_products_price = zen_get_products_base_price($product_id);
- $new_special_price = zen_get_products_special_price($product_id, true);
$new_sale_price = zen_get_products_special_price($product_id, false);
+ if ($new_sale_price !== false) {
+ $new_special_price = zen... | [zen_get_buy_now_qty->[in_cart_mixed],zen_get_products_price_is_free->[Execute],zen_get_products_discount_price_qty->[in_cart_mixed_discount_quantity,Execute],zen_get_products_actual_price->[Execute],zen_get_products_quantity_order_min->[Execute],zen_update_salemaker_product_prices->[MoveNext,Execute],zen_get_products_... | Calculate discount for a given product ID Checks if the discount quantity is not priced and if it is an attribute - if it calculate the amount of a node in order to apply the discount on the sale and the checks for the number of non - specials and the amount of the sale and the This function is used to calculate the am... | Curiously, `$new_sale_price` isn't used in this function anywhere. Let's revert this section (line 492) back, and then this new if/else can be removed too. |
@@ -311,3 +311,14 @@ func getNotificationByID(notificationID int64) (*Notification, error) {
return notification, nil
}
+
+// SwapNotificationStatuses swaps the statuses of all of a user's notifications that are of the currentStatus type
+func SwapNotificationStatuses(user *User, currentStatus NotificationStatus, ... | [BeforeUpdate->[Unix,Now],GetRepo->[Get,Where],BeforeInsert->[Unix,Now],GetIssue->[Get,Where],ID,Commit,Begin,Limit,Count,Find,OrderBy,Close,Where,Insert,Errorf,And,Get,NewSession,In,Update] | Notification object. | Maybe `UpdateNotificationStatuses` is a better name? My first thought when I saw the name was that it replaced all occurrences of status A with status B, __and__ replaced all occurrences of status B with status A. |
@@ -1394,7 +1394,7 @@ int dt_ioppr_transform_image_colorspace_cl(struct dt_iop_module_t *self, const i
else
{
// no matrix, call lcms2
- src_buffer = dt_alloc_align(64, width * height * ch * sizeof(float));
+ src_buffer = dt_alloc_align_float((size_t) ch * width * height);
if(src_buffer == NULL)
... | [No CFG could be retrieved] | set the kernel and memory for the image colorspace transform This function copies the image from the source buffer to the host device. | Or define ch as `const size_t ch = 4;` above? |
@@ -105,6 +105,10 @@ module RepositoryHelper
end
current_path = Pathname.new path
+ relative_path = Pathname.new(files[0])
+ abs_path = File.join(current_path, relative_path)
+
+ return [true, [:file_not_exist]] unless repo.get_latest_revision.path_exists?(abs_path)
current_revision = repo.g... | [remove_files->[nil?,revision_identifier,new,user_name,split,to_s,sanitize_file_name,get_transaction,join,remove,each,commit_transaction],add_files->[revision_identifier,new,size,original_filename,join,nil?,replace,sanitize_file_name,commit_transaction,to_s,read,get_transaction,each,present?,split,get_latest_revision,p... | Remove files from the repository. | This is only checking if the first file in `files` doesn't exist. What happens if there are multiple files in `files` and the second, third, etc. file doesn't exist? |
@@ -339,12 +339,17 @@ func (c *Conn) pollLoop(poll time.Duration) (msgs [][]byte, err error) {
var totalWaitTime time.Duration
+ c.setPollLoopRunning(true)
+ defer func() {
+ c.setPollLoopRunning(false)
+ }()
+
start := time.Now()
for {
newPoll := poll - totalWaitTime
msgs, err = c.router.Get(c.session... | [decryptIncomingMessages->[decryptIncomingMessage],decryptIncomingMessage->[Eq],Read->[readBufferedMsgsIntoBytes,pollLoop,setReadError,decryptIncomingMessages,getErrorForRead],writeWithLock->[nextWriteSeqno,setWriteError,getErrorForWrite,encryptOutgoingMessage],encryptOutgoingMessage->[Read],Close->[setWriteError,write... | pollLoop polls the network for a single message. | this is for testing, but i abandoned the tests since I couldn't get them to work. when tests are put back in this will be useful. |
@@ -2367,7 +2367,7 @@ public class VirtualMachineManagerImpl extends ManagerBase implements VirtualMac
/**
* We use {@link StoragePoolAllocator} objects to find local storage pools connected to the targetHost where we would be able to allocate the given volume.
*/
- private List<StoragePool> getCand... | [VirtualMachineManagerImpl->[handleVmWorkJob->[handleVmWorkJob],plugNic->[findById],handlePowerOffReportWithNoPendingJobsOnVM->[sendStop,stateTransitTo,getVmGuru],migrateWithStorage->[expunge],orchestrateMigrateAway->[migrate,orchestrateMigrateAway,findById,advanceStop],CleanupTask->[runInContext->[cleanup]],orchestrat... | Get the list of candidate storage pools to migrate from a local volume to a remote host. | Not sure if we want to use the word "Local" in this volume name. |
@@ -522,7 +522,11 @@ func (a *APIServer) runUserCode(ctx context.Context, logger *taggedLogger, envir
// cmd.Process.Wait() then cmd.Wait() will produce an error. So instead we
// close the IO using this helper
err = cmd.WaitIO(state, err)
- if err != nil {
+ // We ignore broken pipe errors, these occur very occa... | [userLogger->[clone],cancelCtxIfJobFails->[Logf],worker->[Logf,acquireDatums,Close,cancelCtxIfJobFails],acquireDatums->[Logf],Write->[Logf,Write],getTaggedLogger->[DatumID],downloadData->[Logf,downloadGitData],uploadOutput->[Logf,Close],processDatums->[DatumID,getTaggedLogger,Logf,downloadData,userCodeEnv,uploadOutput,... | runUserCode runs the user code isDone is called by the command loop when the process is done. | This should probably be re-worded. |
@@ -552,6 +552,16 @@ class RemoveError(CondaError):
super(RemoveError, self).__init__(msg)
+class DisallowedError(CondaError):
+ def __init__(self, package_ref, **kwargs):
+ from .models.index_record import PackageRef
+ package_ref = PackageRef.from_objects(package_ref)
+ message = ... | [conda_exception_handler->[ExceptionHandler],ExceptionHandler->[handle_exception->[EncodingError,_format_exc,CondaMemoryError,NoSpaceLeftError],get_error_report->[_format_exc],_print_conda_exception->[print_conda_exception]]] | Initialize CondaIndexError with a message. | DisallowedPackagesError would make it more explicit? or do we plan to use it for disallowing other things? |
@@ -168,6 +168,7 @@ namespace System.Windows.Forms
{
if (patternId == UiaCore.UIA.LegacyIAccessiblePatternId ||
patternId == UiaCore.UIA.InvokePatternId ||
+ patternId == UiaCore.UIA.ScrollItemPatternId ||
patternId == UiaCore.UI... | [ComboBox->[ComboBoxItemAccessibleObject->[SelectItem->[GetCurrentIndex],FragmentNavigate->[FragmentNavigate],GetChildId->[GetCurrentIndex],IsPatternSupported->[IsPatternSupported],GetPropertyValue->[GetCurrentIndex,GetPropertyValue],AddToSelection->[SelectItem],SetFocus->[SetFocus],GetChildId]]] | IsPatternSupported override. | Is this pattern always available in 4.7.2, or only when the scroll bar is displayed? |
@@ -160,7 +160,6 @@ namespace DateTime
// tm doesn't have milliseconds
int milliseconds = local->time % 1000;
- tzset();
time_t utime = timelocal(&local_tm);
if (local_tm.tm_isdst)
{
| [LocalToUtc->[YMDLocalToUtc],UtcToLocal->[YMDUtcToLocal],inline->[NormalizeYMDYear,abs],WCHAR->[timelocal,GetStandardName,CopyTimeZoneName,YMD_TO_TM,AssertMsg],void->[timelocal,TM_TO_YMD,tzset,gmtime_r,IsLeap,strlen,localtime_r,YMD_TO_TM,timegm,NormalizeYMDYear,UpdateToYMDYear,AssertMsg]] | YMDLocalToUtc - converts YMD - like object to UTC - like object. | This won't have much of an impact since the other time functions like `timelocal` implicitly invoke `tzset`-like functionality when called. |
@@ -15,6 +15,9 @@ namespace Microsoft.Extensions.Configuration
public static class ConfigurationBinder
{
private const BindingFlags DeclaredOnlyLookup = BindingFlags.Public | BindingFlags.NonPublic | BindingFlags.Instance | BindingFlags.Static | BindingFlags.DeclaredOnly;
+ private const strin... | [ConfigurationBinder->[ConvertValue->[TryConvertValue],GetValue->[GetValue],Array->[BindInstance,CreateInstance],Get->[Get],AttemptBindToCollectionInterfaces->[BindToCollection],BindDictionary->[BindInstance],BindCollection->[BindInstance],BindInstance->[AttemptBindToCollectionInterfaces,BindNonScalar],BindProperty->[G... | Creates a helper class that allows binding strongly typed objects to configuration values. | If I understand the code correctly it will recursively walk properties, so any type is problematic. It doesn't matter if it's generic or not. It's basically a deserializer - having the same issues with trimming as other deserializers. The support for collections just makes this a harder problem - since it will recursiv... |
@@ -44,9 +44,9 @@ os.environ['AZURE_SKIP_LIVE_RECORDING'] = os.environ.get('AZURE_SKIP_LIVE_RECORD
os.environ['PROTOCOL'] = PROTOCOL
os.environ['ACCOUNT_URL_SUFFIX'] = ACCOUNT_URL_SUFFIX
-os.environ['AZURE_TENANT_ID'] = os.environ.get('AZURE_TENANT_ID', None) or TENANT_ID
-os.environ['AZURE_CLIENT_ID'] = os.environ... | [not_for_emulator->[skip_test_if_targeting_emulator->[test]],partial,get] | Creates a logging object that can be used to log the error in the console. | it looks like these changes were also in your 79 pr, let's merge this first and update the 79 pr with main. |
@@ -46,7 +46,7 @@ def can_edit_address(context, address):
requester = get_user_or_app_from_context(context)
if requester.has_perm(AccountPermissions.MANAGE_USERS):
return True
- if not context.app and not context.user.is_anonymous:
+ if not context.app:
return requester.addresses.filte... | [BaseAddressUpdate->[perform_mutation->[clean_input],clean_input->[can_edit_address]],ConfirmAccount->[perform_mutation->[ConfirmAccount]],PasswordChange->[perform_mutation->[PasswordChange]],BaseAddressDelete->[clean_instance->[can_edit_address],perform_mutation->[clean_instance,check_permissions]],RequestPasswordRese... | Determine whether the user or app can edit the given address. | Looks like this is a change introduced in different PR |
@@ -176,8 +176,10 @@ public class LinksApi {
@ApiIgnore
HttpServletRequest request
) throws IOException, JDOMException {
+ MAnalyseProcess registredMAnalyseProcess = getRegistredMAnalyseProcess();
+
if (removeFirst) {
- urlAnalyser.deleteAll();
+ registre... | [LinksApi->[purgeAll->[ResponseEntity,deleteAll],analyzeRecordLinks->[forEach,newHashSet,findAll,getMetadataId,ResponseEntity,isNotEmpty,processMetadata,getUserSession,getUuidsParameterOrSelection,findOne,getXmlData,getId,add,deleteAll,valueOf],getRecordLinks->[findAll,PageRequest,getUserSession,add,Sort,createPath,for... | Analyze records links. Checks if all links are in the repository and returns a response entity. | @cmangeat, can you indicate what would be the result of issuing this API method while already been executed while a previous request? Seem to me that removes previous execution, but not very clear really. |
@@ -192,9 +192,13 @@ module.exports = class bigone extends Exchange {
const base = this.safeCurrencyCode (baseId);
const quote = this.safeCurrencyCode (quoteId);
const symbol = base + '/' + quote;
+ const amountPrecisionString = this.safeString (market, 'base_scale');
+... | [No CFG could be retrieved] | Get asset pair pair data by ID base_asset quote_asset and base_scale. Load a list of all possible markets with a specific ID. | What if we introduce a helper base method for this ternary conditional to avoid code clutter? |
@@ -245,6 +245,9 @@ func WithAdditionalPachdCert() Option {
func getCertOptionsFromEnv() ([]Option, error) {
var options []Option
if certPaths, ok := os.LookupEnv("PACH_CA_CERTS"); ok {
+ if pachdAddress, ok := os.LookupEnv("PACHD_ADDRESS"); !ok || !strings.HasPrefix(pachdAddress, "grpcs") {
+ return nil, error... | [Ctx->[AddMetadata],Close->[Close],DeleteAll->[DeleteAll]] | WithDialTimeout is a functional option that sets dial timeout for the connection to pachd getUserMachineAddrAndOpts returns the address and options for a user - specified . | Nit: should we put "grpcs" in a constant at the top of the file? |
@@ -139,7 +139,7 @@ public class IssueWorkflowTest {
}
@Test
- public void do_automatic_transition() {
+ public void automatically_close_resolved_issue() {
workflow.start();
DefaultIssue issue = new DefaultIssue()
| [IssueWorkflowTest->[fail_if_unknown_status_on_automatic_trans->[doAutomaticTransition,hasMessage,start,setBeingClosed,Date,createScan,fail],do_automatic_transition->[doAutomaticTransition,isNotNull,start,isEqualTo,setBeingClosed,Date,createScan,truncate],list_out_transitions_from_status_open->[outTransitions,start,con... | Method that does automatic transition. | I find it odd to see only formatting changes in the unit test. There does not seem to be a test covering closing an issue for a manual rule (which might explain why the bug existed, if I understood correctly the fix). |
@@ -267,6 +267,10 @@ func ToUTF8WithErr(content []byte) (string, error) {
if err != nil {
return "", err
} else if charsetLabel == "UTF-8" {
+ if len(content) > 2 && bytes.Equal(content[0:3], base.UTF8BOM) {
+ log.Debug("Removing BOM from UTF-8 string")
+ return string(content[3:]), nil
+ }
return strin... | [Title,Nanoseconds,LastIndex,Indent,DetectEncoding,Sanitize,Count,Front,HasPrefix,FileSize,GetDefinitionForFilename,EncodeSha1,HTML,Error,Format,Sprint,New,NewPushCommits,GetContent,RenderCommitMessage,Errorf,Bytes,Since,TrimSpace,Join,Next,HTMLEscapeString,Lookup,Ext,NewReplacer,NewDecoder,Split,EscapeString,Sprintf,V... | SafeJS renders a string as JS and HTML renders a string as HTML and returns a channel ToUTF8 converts content to UTF8 if charset label is UTF - 8. | How about to create a function named `RemoveUTF8BOM(content string) string`. |
@@ -0,0 +1,18 @@
+# Copyright (c) 2020 PaddlePaddle Authors. All Rights Reserved.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+... | [No CFG could be retrieved] | No Summary Found. | Better use absolute import, eg, `form paddle.fluid.contrib import mixed_precision ` |
@@ -100,6 +100,10 @@ namespace Dynamo.UI.Controls
{
searchElement.CreateAndConnectCommand.Execute(port.PortModel);
}
+ Analytics.TrackEvent(
+ Dynamo.Logging.Actions.Select,
+ Dynamo.Logging.Categories.NodeAutoCompleteOp... | [NodeAutoCompleteSearchControl->[OnMouseLeftButtonUp->[OnRequestShowNodeAutoCompleteSearch],OnInCanvasSearchKeyDown->[ExecuteSearchElement,OnRequestShowNodeAutoCompleteSearch,UpdateHighlightedItem]]] | Execute the node search element if it exists. | This can be put into the condition above I think |
@@ -80,6 +80,7 @@ public final class Row implements TableRow {
}
@Override
+ @SuppressFBWarnings(value = "EI_EXPOSE_REP", justification = "should be mutable")
public GenericRow value() {
return value;
}
| [Row->[of->[Row],withValue->[Row],equals->[equals]]] | Returns a new row with a sequence number and a new sequence number. | If not mutable, `KsqlMaterializationTest` breaks. (Wondering is this is really intentional?) |
@@ -109,11 +109,15 @@ public class BlockInputStream extends InputStream
private int chunkIndexOfPrevPosition;
private final Function<BlockID, Pipeline> refreshPipelineFunction;
+ private boolean smallBlock = false;
+ private final OzoneClientConfig clientConfig;
+ @SuppressWarnings("parameternumber")
pu... | [BlockInputStream->[releaseClient->[releaseClient],unbuffer->[unbuffer,releaseClient],readWithStrategy->[getRemaining,initialize],seek->[seek],handleReadError->[releaseClient,refreshPipeline],getPos->[getPos],close->[close],storePosition->[getPos],read->[read]]] | Creates a new BlockInputStream object. This method is called before the stream is intialized. | Can we pass `new OzoneClientConfig()` instead of `null`? This way we can avoid null checks and use the default configuration seamlessly. |
@@ -382,6 +382,7 @@ public class NotebookServer extends WebSocketServlet implements
for (String id : ids) {
if (id.equals(interpreterGroupId)) {
broadcast(note.getId(), m);
+ broadcastToWatchers(note.getId(), StringUtils.EMPTY, m);
}
}
}
| [NotebookServer->[multicastToUser->[serializeMessage],pushAngularObjectToRemoteRegistry->[broadcastExcept],broadcastInterpreterBindings->[broadcast],onRemove->[broadcast,notebook],generateNotesInfo->[notebook],updateParagraph->[permissionError,getOpenNoteId,broadcast],onLoad->[broadcast],unicastNoteList->[generateNotes... | Broadcast to note binded interpreter. | Looks like `broadcastToWatchers()` is called inside of `broadcast(String noteId, Message m)` in one line above already. Isn't it? |
@@ -245,6 +245,9 @@ type UpdateOptions struct {
AutoApprove bool
// SkipPreview, when true, causes the preview step to be skipped.
SkipPreview bool
+
+ // WatchPaths, allows specifying paths that need to be watched (instead of the whole project).
+ WatchPaths []string
}
// QueryOptions configures a query to o... | [GetStackResourceOutputs->[ParseStackReference,NewObjectProperty,PropertyKey,Errorf,Snapshot,NewStringProperty,GetStack],GetStackOutputs->[ParseStackReference,GetRootStackResource,Wrap,Errorf,Snapshot,GetStack],Error->[Sprintf,Replace],New] | returns a new instance of the type that can be used to create a new stack. | Instead of putting this on `UpdateOption`, let's put this as a separate argument to `Watch` on the backend interface. This option isn't relevant to most updates, and is really not about the update part of the watch operation at all - so will be easier to keep it watch-specific. |
@@ -315,9 +315,10 @@ func (c *Container) WaitForState(s State) <-chan struct{} {
func (c *Container) NewHandle(ctx context.Context) *Handle {
// Call property collector to fill the data
if c.vm != nil {
+ op := trace.FromContext(ctx, "NewHandle")
// FIXME: this should be calling the cache to decide if a refres... | [OnEvent->[onStop,refresh,Remove,String,updateState],refresh->[refresh],stop->[transitionState,stop,SetState],LogReader->[Error],start->[start,SetState,transitionState],Error->[Error],Remove->[Remove,updateState],String] | NewHandle returns a handle that represents zero changes over the current configuration of the container. | Why NewOperation instead of pass one in? |
@@ -116,14 +116,14 @@ public class ProAI extends AbstractAI {
public static void gameOverClearCache() {
// Are static, clear so that we don't keep the data around after a game is exited
- ProBattleUtils.clearData();
+ concurrentCalc.setGameData(null);
ProLogUI.clearCachedInstances();
}
@Ove... | [ProAI->[selectCasualties->[initializeData],showSettingsWindow->[showSettingsWindow],move->[initializeData],selectAttackSubs->[initializeData],initializeData->[initialize],initialize->[initialize],scrambleUnitsQuery->[initializeData,scrambleUnitsQuery],politicalActions->[politicalActions,initializeData],stopGame->[stop... | This is a static method that clears the cache and then clears the data. | Please do not use 'null' values, causes NPE. Optional.empty(), or better yet, add a "clearGameData()" method so no null needs to be passed in. |
@@ -1245,8 +1245,8 @@ class DistributeTranspiler:
# ops, we may get the output of clip op. Use syntax "@GRAD"
# and op_role_var to get the pair.
for input_name in op.input_arg_names:
- if input_name.find("@GRAD") != -1 and \
- ... | [split_variable->[VarBlock],DistributeTranspiler->[_is_op_connected->[_append_inname_remove_beta],_append_pserver_ops->[_get_optimizer_input_shape,same_or_split_var],get_startup_program->[_get_splited_name_and_shape->[same_or_split_var],_get_splited_name_and_shape],_create_ufind->[_is_op_connected],_orig_varname->[_get... | Get optimizer operators paramters and gradients from origin_program . | This may not be the correct fix I suppose, this line was not trying to find the optimizer ops like "sgd", but to find any op that have the "optimizer" role and to get the original gradient variable name out of it. |
@@ -324,9 +324,9 @@ public class UnboundedSourceWrapper<
List<KV<? extends UnboundedSource<OutputT, CheckpointMarkT>, CheckpointMarkT>> checkpoints =
new ArrayList<>();
- for (int i = 0; i < splitSources.size(); i++) {
- UnboundedSource<OutputT, CheckpointMarkT> source = splitSources.get(i);
- ... | [UnboundedSourceWrapper->[trigger->[emitWatermark,getWatermark,min,setNextWatermarkTimer,getCheckpointLock,getMillis,Watermark],restoreState->[decode,ByteArrayInputStream],setNextWatermarkTimer->[getTimeToNextWatermark,getAutoWatermarkInterval,registerTimer],run->[apply->[getKey],getValue,size,start,getIndexOfThisSubta... | This method is called to snapshot the state of the checkpoint. | FYI: This is where the IndexOutOfBoundsException occurred. |
@@ -149,11 +149,14 @@ def main(args):
print("Loading validation data")
cache_path = _get_cache_path(valdir)
- if not args.weights:
- transform_test = presets.VideoClassificationPresetEval((128, 171), (112, 112))
+ if not args.prototype:
+ transform_test = presets.VideoClassificationPrese... | [parse_args->[parse_args],main->[_get_cache_path,evaluate,train_one_epoch],main,parse_args] | Main function for training and validation. Train and test data loader. Create a model with a single node. Train a single node in the model. Print the last time the training time has not been reached. | I confirm that the arguments in the two classes take the parameters in different order. We are going to remove the old presets anyway and stick with the second one. |
@@ -1348,7 +1348,7 @@ $a->strings["Beginning of week:"] = "";
$a->strings["Don't show notices"] = "";
$a->strings["Infinite scroll"] = "";
$a->strings["Automatic updates only at the top of the network page"] = "";
-$a->strings["Bandwith Saver Mode"] = "";
+$a->strings["Bandwidth Saver Mode"] = "";
$a->strings["When... | [No CFG could be retrieved] | Adds some strings to the header of an object. Показа в п Name of the user. | Same goes for any of the `string.php` files in the `view/lang` directories, they are generated from the translation work at Transifex. |
@@ -22,6 +22,7 @@ def get_best_routes(
amount: int,
previous_address: typing.Optional[typing.Address],
config: Dict[str, Any],
+ privkey: bytes = None,
) -> List[RouteState]:
services_config = config.get('services', None)
| [get_best_routes_internal->[list,get_distributable,pex,heappop,get_channelstate_by_token_network_and_partner,append,shortest_path_length,get_status,RouteState,warning,get_token_network_by_identifier,info,all_neighbors,heappush],get_best_routes_pfs->[to_canonical_address,pex,get_channelstate_by_token_network_and_partner... | Get the best routes for a given node. | This is a required argument as far as i can see |
@@ -435,7 +435,7 @@ namespace System.Reflection.Emit
#region MemberInfo Overrides
public override string Name => m_strName;
- internal int MetadataTokenInternal => GetToken().Token;
+ public override int MetadataToken => GetToken().Token;
public override Module Module => m_c... | [ExceptionHandler->[Equals->[Equals],Equals],MethodBuilder->[SetSignature->[ThrowIfGeneric],ILGenerator->[ThrowIfGeneric],GetHashCode->[GetHashCode],GetParameters->[GetParameters],SetCustomAttribute->[ThrowIfGeneric],SetImplementationFlags->[ThrowIfGeneric],Equals->[Equals],ToString->[ToString],ParameterBuilder->[Throw... | region Field Overrides This is a public method that can be called by a dynamic module. | It would be nice to delete the unused `struct MethodToken` and `GetToken` methods. |
@@ -194,7 +194,7 @@ def get_default_folder(folder_type):
:rtype: str
"""
- if 'fcntl' in sys.modules:
+ if fcntl:
# Linux specific
return LINUX_DEFAULT_FOLDERS[folder_type]
# Windows specific
| [release_locked_file->[remove,close],compare_file_modes->[oct,S_IMODE],lock_file->[locking,lockf],raise_for_non_administrative_windows_rights->[hasattr,Error,getattr,IsUserAnAdmin,format],os_rename->[getattr,rename,hasattr,RuntimeError],readline_with_timeout->[Error,format,readline,select,rlist],os_geteuid->[geteuid]] | Returns the default folder for the current OS. | Instead of this can we do something like `if os.name != 'nt'`? |
@@ -581,7 +581,7 @@ describes.realWin('AccessServerJwtAdapter', {amp: true}, env => {
beforeEach(() => {
jwt = {
'exp': Math.floor((Date.now() + 10000) / 1000),
- 'aud': 'ampproject.org',
+ 'aud': 'amp.dev',
};
});
| [No CFG could be retrieved] | Reads a token from AMP Project and verifies it is a valid JWT. should fail when token is invalid. | this needs to be ampproject.org (for the whole file) |
@@ -287,6 +287,7 @@ class RemoteFilesystem
}
$errorMessage .= preg_replace('{^file_get_contents\(.*?\): }', '', $msg);
});
+ $http_response_header = array();
try {
$result = $this->getRemoteContents($originUrl, $fileUrl, $ctx, $http_response_header);
| [RemoteFilesystem->[handleRedirect->[get,findHeaderValue],get->[findStatusMessage,get,findHeaderValue,findStatusCode]]] | Get a file URL from the repository. Downloads a file from the server and returns the contents as a string. Checks if a response is a response of a single type of response. If so it checks Checks if a file can be opened. | This is also an error IMO as we always check if it's been set below. Shouldn't need to be pre-set. |
@@ -425,7 +425,7 @@ func (s *Server) Close() {
s.hbStreams.Close()
}
if err := s.storage.Close(); err != nil {
- log.Error("close storage meet error", zap.Error(err))
+ log.Error("close storage meet error", errs.ZapError(err))
}
// Run callbacks
| [SetLabelPropertyConfig->[SetLabelPropertyConfig],GetReplicationModeConfig->[GetReplicationModeConfig],campaignLeader->[createRaftCluster,Name,stopRaftCluster],GetClusterVersion->[GetClusterVersion],SetClusterVersion->[SetClusterVersion],DeleteLabelProperty->[DeleteLabelProperty,SetLabelProperty],Close->[Close],SetSche... | Close closes the server. | need to be handled in the lower level |
@@ -1,8 +1,8 @@
require "rails_helper"
RSpec.describe "Views an article", type: :system do
- let_it_be(:user) { create(:user) }
- let_it_be_changeable(:article) do
+ let(:user) { create(:user) }
+ let(:article) do
create(:article, :with_notification_subscription, user: user)
end
let(:timestamp) { "20... | [visit,create,all,let,describe,ago,it,map,to,have_content,update_columns,have_selector,save!,before,let_it_be,paragraph_by_chars,require,parse,update,body_markdown,url,let_it_be_readonly,title,each,length,id,path,context,build,let_it_be_changeable,eq,sign_in,create_list,raise_error] | Views an article shows the identical readable publish dates in each page. | For more information on this spec fix checkout #9512 |
@@ -1747,16 +1747,7 @@ class NodeControllerTest extends SuluTestCase
public function testOrderNonExistingSource()
{
- $data = [
- [
- 'title' => 'test1',
- 'url' => '/test1',
- ],
- ];
-
$client = $this->createAuthenticatedClient();
... | [NodeControllerTest->[testCopyNonExistingSource->[createAuthenticatedClient,getResponse,request,assertHttpStatusCode,import],testPutNotExisting->[getResponse,request,assertHttpStatusCode,createAuthenticatedClient],testGetShadowContent->[setTitle,createAuthenticatedClient,getContent,flush,persist,request,bind,setShadowL... | Order a node in the order of a non existing source. | This request was erroneous already before, but the type of error changed. The error it threw before was somehow caught by symfony internals, but it also didn't work, because the `template` parameter was missing. However, I have seen that to cover this test the first request was not necessary at all. |
@@ -345,7 +345,7 @@ public class Strings {
if (s.endsWith(suffix))
return s;
- return s + suffix;
+ return s;
}
public static String ensurePrefix(String s, String prefix) {
| [Strings->[makePrintable->[makePrintableArray],splitLinesAsStream->[splitAsStream],to->[substring],last->[substring],stripSuffix->[stripSuffix,substring],format->[format],join->[join],getLastSegment->[getLastSegment],splitQuotedAsStream->[splitQuotedAsStream],substring->[charAt,substring],stripPrefix->[stripPrefix,subs... | This method ensures that a string has a suffix and that it starts with a prefix. | This seems to defeat the purpose of the method since it now always returns `s`. |
@@ -328,6 +328,9 @@ func (h *chatLocalHandler) GetThreadNonblock(ctx context.Context, arg chat1.GetT
SessionID: arg.SessionID,
Thread: remoteThread,
})
+
+ // This means we transmitted with success, so cancel local thread
+ cancel()
}()
wg.Wait()
| [Sign->[remoteClient],postAttachmentPlaceholder->[PostLocal],GetInboxSummaryForCLILocal->[GetInboxAndUnboxLocal],PreviewMetadata->[Empty],postAttachmentLocal->[PostLocal,getChatUI],GetThreadNonblock->[getChatUI],GetInboxNonblockLocal->[getChatUI],BaseMetadata->[Empty],postAttachmentLocalInOrder->[PostLocal,PostDeleteNo... | GetThreadNonblock implements keybase. chatLocal. GetThreadNonblock. This is a non - blocking call that will pull a thread from the server. | What's the difference calling `cancel` here? |
@@ -756,7 +756,13 @@ public class HiveAvroORCQueryGenerator {
if (optionalPartitionDMLInfo.isPresent()) {
if (optionalPartitionDMLInfo.get().size() > 0) {
dmlQuery.append("WHERE ");
+ boolean isFirstPartitionSpec = true;
for (Map.Entry<String, String> partition : optionalPartitionDM... | [HiveAvroORCQueryGenerator->[escapeHiveType->[escapeHiveType],generateAvroToHiveColumnMapping->[generateAvroToHiveColumnMapping]]] | Generate a DML table mapping for the given schema. Generate DML using optional partition spec. This method is used to build the DML query for all columns that can be queried. Returns a string representation of a object. | `AND` we use upper case everywhere else |
@@ -303,7 +303,14 @@ public class OperationMessageProcessor extends ExtensionComponent<OperationModel
@Override
public ProcessingType getProcessingType() {
- return asProcessingType(operationModel.getExecutionType());
+ ProcessingType processingType = asProcessingType(operationModel.getExecutionType());
+... | [OperationMessageProcessor->[getEntityMetadata->[getEntityMetadata],createExecutionContext->[createExecutionContext],getTarget->[isTargetPresent],getEntityKeys->[getEntityKeys],resolveParameters->[apply,createExecutionContext],apply->[process]]] | Returns processing type for the given event. | Is this something we want to do? didn't we originally intend to avoid the thread change when going back to the flow after a cpu-light process? |
@@ -2575,6 +2575,15 @@ define([
var newEntity = newEntities[i];
if (!defined(newEntity.parent)) {
newEntity.parent = networkLinkEntity;
+
+ if (defined(networkLinkAvailability)) {
+ var childAvailability = newEntity.availab... | [No CFG could be retrieved] | On refresh of the NetworkLinkControl this function is called when the NetworkLinkControl expires. The function that handles the case where the clock is not the same as the start and stop. | @tfili You have essentially the same block of code copy and pasted 3 times, can you please turn this into a helper function instead. |
@@ -186,6 +186,14 @@ final class Methods {
classLevelBindings, bytecodeTransformerConsumer, transformUnproxyableClasses));
}
}
+ for (DotName i : classInfo.interfaceNames()) {
+ ClassInfo interfaceInfo = getClassByName(beanDeployment.getIndex(), i);
+ ... | [Methods->[isTypeEqual->[equals],skipForSubclass->[equals],matchesSignature->[equals],addDelegatingMethods->[addDelegatingMethods],addInterceptedMethodCandidates->[apply->[visitMethod->[visitMethod]],addInterceptedMethodCandidates],NameAndDescriptor->[fromMethodInfo->[NameAndDescriptor],equals->[equals]],MethodKey->[ha... | Add intercepted method candidates. Checks if any of the methods from whoToRemoveFinal are found and if so adds the method. | OK, my bad, I didn't know interceptors also applied to superclass methods, otherwise I'd have suggested to handle interface default methods too. Great move. |
@@ -111,10 +111,10 @@ public class GrokResource extends RestResource {
}
grokPatternService.saveAll(GrokPatterns.fromSummarySet(patternList.patterns()), replace);
-
+ clusterBus.post(GrokPatternsChangedEvent.create(Collections.emptySet(), updatedPatternNames));
return Response.accept... | [GrokResource->[listGrokPatterns->[create,toSummarySet,checkPermission,loadAll],removePattern->[NotFoundException,checkPermission,delete],createPattern->[build,save,checkPermission,fromSummary],bulkUpdatePatterns->[fromSummarySet,build,validate,checkPermission,saveAll,ValidationException,patterns,fromSummary],listPatte... | Bulk update a list of patterns. | It looks like `updatedPatternNames` is never updated. |
@@ -358,6 +358,9 @@ public final class StorageContainerManager extends ServiceRuntimeInfoImpl
eventQueue.addHandler(SCMEvents.PIPELINE_ACTIONS, pipelineActionHandler);
eventQueue.addHandler(SCMEvents.PIPELINE_REPORT, pipelineReportHandler);
eventQueue.addHandler(SCMEvents.SAFE_MODE_STATUS, safeModeHandle... | [StorageContainerManager->[getDatanodeRpcAddress->[getDatanodeRpcAddress],stop->[unregisterMXBean,getSecurityProtocolServer,stop],createSCM->[StorageContainerManager],join->[getSecurityProtocolServer,join],getClientRpcPort->[getClientRpcAddress],start->[getSecurityProtocolServer,getDatanodeRpcAddress,start,buildRpcServ... | This function initializes the event queue for the specified object. Initializes system managers. | We can save this step as most likely it's still in safe mode at the time. |
@@ -69,12 +69,12 @@ class Console:
self,
*objects: Any,
style: str = None,
- sep: str = SEP,
- end: str = NEWLINE,
+ sep: str = None,
+ end: str = None,
file: TextIO = None,
flush: bool = False,
) -> None:
- if self.disabled:
+ ... | [Console->[table->[write],write->[format],__init__->[Formatter],rich_console->[Console],prompt->[write],confirm->[prompt]],success,table,Console,warn,write,error] | Writes a sequence of objects to a file. | Q: How important is thread-safety for us while printing? `logger` is thread safe, but this is not. |
@@ -633,7 +633,9 @@ zfs_znode_alloc(zfs_sb_t *zsb, dmu_buf_t *db, int blksz,
SA_ADD_BULK_ATTR(bulk, count, SA_ZPL_UID(zsb), NULL, &zp->z_uid, 8);
SA_ADD_BULK_ATTR(bulk, count, SA_ZPL_GID(zsb), NULL, &zp->z_gid, 8);
- if (sa_bulk_lookup(zp->z_sa_hdl, bulk, count) != 0 || zp->z_gen == 0) {
+ if (sa_bulk_lookup(zp->... | [No CFG could be retrieved] | Get the object of type Iobject_znode. count - number of unique parent objects - number of objects to hold a reference on - -. | style: Although checkstyle doesn't enforce it, the style elsewhere is to not use a space following a type cast. |
@@ -212,6 +212,9 @@ public class AnkiDroidApp extends Application {
}
+
+
+
/**
* Get the ACRA ConfigurationBuilder - use this followed by setting it to modify the config
* @return ConfigurationBuilder for the current ACRA config
| [AnkiDroidApp->[sendExceptionReport->[sendExceptionReport],updateContextWithLanguage->[sendExceptionReport,getSharedPrefs,getInstance],attachBaseContext->[attachBaseContext],ProductionCrashReportingTree->[getTag->[createStackElementTag],log->[getTag]],getResourceAsStream->[getResourceAsStream],onCreate->[onCreate],setD... | Get the acraCoreConfigBuilder. | Could you revert changes to this file - unnecessary |
@@ -21,6 +21,7 @@ ORDERTYPE_POSSIBILITIES = ['limit', 'market']
ORDERTIF_POSSIBILITIES = ['gtc', 'fok', 'ioc']
AVAILABLE_PAIRLISTS = ['StaticPairList', 'VolumePairList']
DRY_RUN_WALLET = 999.9
+DEFAULT_DOWNLOAD_TICKER_INTERVALS = '1m 5m'
TICKER_INTERVALS = [
'1m', '3m', '5m', '15m', '30m',
| [No CFG could be retrieved] | This function is used to set the default values for the bot class. Schema for a . | isn't the correct syntax 1m,5m for the download script ... ? |
@@ -169,7 +169,6 @@ func ethLogJSON(el types.Log) (models.JSON, error) {
return out, err
}
- delete(middle, "removed") // some rando attribute from geth
b, err = json.Marshal(middle)
if err != nil {
return out, err
| [listenToLogs->[Errorw,receiveLog,Error],Stop->[unsubscribe],unsubscribe->[Unsubscribe,Lock,Unlock,Err],AddJob->[Sprintf,InitiatorsFor,Debugw,String,Subscribe,addSubscription],Start->[listenToLogs,Append,AddJob,listenToSubscriptionErrors,Jobs],receiveLog->[Error,Append,Errorw,Sprintf,Debugw,String,initrsWithLogAndAddre... | FormatLogJSON formats a log object into a JSON object. initrsWithLogAndAddress returns a list of initiators that can be used to. | If we don't need to delete the `removed` key, we can actually nuke that whole `json.Marshal` on the `map[string]interface{}` section |
@@ -410,6 +410,8 @@ public class RealtimeIndexTask extends AbstractTask
plumber.finishJob();
}
}
+
+ FileUtils.forceDelete(firehoseTempDir);
}
catch (InterruptedException e) {
log.debug(e, "Interrupted while finishing the job");
| [RealtimeIndexTask->[getQueryRunner->[getQueryRunner],makeTaskId->[makeTaskId],run->[unannounceSegment->[unannounceSegment],announceSegment->[announceSegment],isAnnounced->[isAnnounced],unannounceSegments->[unannounceSegments],announceSegments->[announceSegments],getMetadata->[getMetadata],getVersion->[getVersion]],isF... | This method is called when the main thread is running. Get a that can be used to block the next time a new segment is announced This method is called by the Segment tuning system to determine if a new segment should be check if we have finished the job and if so do it. | Should this be moved to the outer finally block? If an exception occurs after firehoseTempDir is created (normalExit is false), it looks like firehoseTempDir won't be deleted here. |
@@ -129,8 +129,7 @@ namespace System
internal bool IsEndDateMarkerForEndOfYear() =>
!NoDaylightTransitions &&
DaylightTransitionEnd.Month == 1 && DaylightTransitionEnd.Day == 1 &&
- DaylightTransitionEnd.TimeOfDay.TimeOfDay.Ticks < TimeSpan.TicksPerSecond &&... | [TimeZoneInfo->[AdjustmentRule->[OnDeserialization->[ValidateAdjustmentRule],Equals->[Equals],GetHashCode->[GetHashCode],ValidateAdjustmentRule->[Equals]]]] | Checks if a given date is a valid end - of - year marker for a given date Missing time range. | Do you know why this extra check was there in the first place / what it was trying to prevent? |
@@ -267,7 +267,7 @@ class Scaffold(object):
return op
@staticmethod
- def _default_local_init_op():
+ def default_local_init_op():
return control_flow_ops.group(
variables.local_variables_initializer(),
lookup_ops.tables_initializer(),
| [_HookedSession->[run->[should_stop,run],__init__->[__init__]],SingularMonitoredSession->[raw_session->[_tf_sess],__init__->[ChiefSessionCreator]],WorkerSessionCreator->[create_session->[finalize,_get_session_manager],__init__->[Scaffold]],_RecoverableSession->[_check_stop->[close,_create_session,_check_stop],run->[clo... | Default local initialization operation. | Please add a docstring. |
@@ -12,6 +12,7 @@
//
// System includes
+#include <ctime>
// External includes
| [PrintInfo->[Info]] | Provides a basic object that can be logged with a message. Adds the category to the message. | I am quite convinced that there is a more "C++" way of doing this with `std::chrono` (haven't checked though :) ) |
@@ -240,6 +240,7 @@ namespace Microsoft.Xna.Framework.Content.Pipeline.Graphics
var compressionOptions = new CompressionOptions();
compressionOptions.SetFormat(outputFormat);
+ compressionOptions.SetQuality(Quality.Fastest);
_dxtCompressor.Compress(inputOptions, com... | [GraphicsUtil->[GetNextPowerOfTwo->[IsPowerOfTwo],CompressPVRTC->[CompressTexture],Resize->[GetData],CompressDXT->[IsPowerOfTwo,BGRAtoRGBA]]] | Compress DXT textures. | Just noticed this, there is a Quality.Highest enum value that can be used here. Did you test the difference between the two? |
@@ -137,6 +137,16 @@ export class AmpSelector extends AMP.BaseElement {
this.toggle_(args['index'], args['value']);
}
}, ActionTrust.LOW);
+
+ // Listening to this event
+ // Simply listening for mutation would not work
+ this.element.addEventListener(AmpEvents.DOM_UPDATE, unusedEvent => {... | [No CFG could be retrieved] | Handles the mutation of the selected attribute. Get the first value if multiple selection is disabled. | to prevent unnecessary work, we should check if existing `this.options_` array is different than `querySelectorAll('[option]')`, if the same, break. Would be a nice util to add in `array.js` ( `areEqual(arr1, arr2)` ) . This is important to do because majority of `amp-list`s or other components inside `amp-selector` wo... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.