patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -52,6 +52,18 @@ public class DataSegmentPusherUtil
* path names. So we format paths differently for HDFS.
*/
public static String getHdfsStorageDir(DataSegment segment)
+ {
+ return JOINER.join(
+ getHdfsStorageDirUptoVersion(segment),
+ segment.getShardSpec().getPartitionNum()
+ );
+... | [DataSegmentPusherUtil->[getHdfsStorageDir->[replaceAll,getPartitionNum,basicDateTime,format,toString,getDataSource,join],getStorageDir->[getPartitionNum,getEnd,format,getDataSource,join,getStart,getVersion],skipNulls]] | Get HDFS storage directory for given segment. | `getHdfsStorageDir` seems unused now, why not replace it with the code from `getHdfsStorageDirUptoVersion`? |
@@ -98,7 +98,6 @@ public class BasicAuthenticationFilter implements Filter {
}
@Override
- @SuppressWarnings("ACL.impersonate")
public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain) throws IOException, ServletException {
HttpServletRequest req = (HttpServ... | [BasicAuthenticationFilter->[doFilter->[doFilter]]] | This method checks if the user is authenticated and if so performs the appropriate authentication. This method is called when the user is authenticated and the user is not authenticated. | `ACL.impersonate` seems unlikely to be a warning. Seems the author thought that this was a justification rather than a value. |
@@ -44,7 +44,7 @@ class Search(object):
remote = RemoteRegistry(self._client_cache.registry, self._user_io.out).remote(remote)
packages_props = self._remote_manager.search_packages(remote, reference, query)
ordered_packages = OrderedDict(sorted(packages_props.items()))
- ... | [Search->[search_packages->[search_packages],search_recipes->[search_recipes]]] | Search for packages in the registry. | Because of the `b)`, the server always returns the resolved reference now (from remote manager) |
@@ -51,6 +51,8 @@ class PretrainedTransformerIndexer(TokenIndexer[int]):
self.tokenizer = AutoTokenizer.from_pretrained(model_name, do_lower_case=do_lowercase)
self._namespace = namespace
self._added_to_vocabulary = False
+ self._padding_value = self.tokenizer.convert_tokens_to_ids([se... | [PretrainedTransformerIndexer->[tokens_to_indices->[_add_encoding_to_vocabulary]]] | Initialize a new token sequence. | So I'm trying this PR out, and in the case where model name isn't loadable from `AutoTokenizer.from_pretrained`, it returns None. Maybe consider catching that and throwing a more informative error message here? (instead, it errors when you try to use `self.tokenizer` to get the id of the token. |
@@ -13,7 +13,8 @@ define([
'../Core/WebMercatorTilingScheme',
'../ThirdParty/Uri',
'./GetFeatureInfoFormat',
- './UrlTemplateImageryProvider'
+ './UrlTemplateImageryProvider',
+ '../Scene/TimeDynamicImagery'
], function(
combine,
defaultValue,
| [No CFG could be retrieved] | Constructor for the ImageryProvider class. Picking features without communicating with the server. | `TimeDynamicImagery.js` is in the same directory. No need to the `../Scene` |
@@ -27,11 +27,16 @@ from action_recognition_demo.result_renderer import ResultRenderer
from action_recognition_demo.steps import run_pipeline
from os import path
+sys.path.append(str(Path(__file__).resolve().parent.parent / 'common'))
+import monitors
-def video_demo(encoder, decoder, videos, no_show, fps=30, lab... | [build_argparser->[add_argument_group,ArgumentParser,add_argument],video_demo->[run_pipeline,ResultRenderer],main->[add_extension,splitext,basename,set_config,replace,strip,read,ValueError,IECore,video_demo,build_argparser,open,IEModel],exit,main] | Continuously run demo on provided video list. | I'm `pathlib`'s biggest fan, but IMO, we shouldn't import it just for this. A total switch to `pathlib` would be nice, but if the rest of the demo's still using `os.path`, this should use it too. |
@@ -188,14 +188,16 @@ class RecognizedForm(object):
class FormField(object):
"""Represents a field recognized in an input form.
+ :ivar type: The type of the value found on FormField. Possible types include: 'string',
+ 'date', 'time', 'phoneNumber', 'number', 'integer', 'object', or 'array'.
+ :va... | [TrainingDocumentInfo->[_from_generated->[_from_generated]],FormField->[_from_generated->[get_field_value,_from_generated,adjust_confidence],_from_generated_unlabeled->[adjust_confidence,_from_generated_unlabeled]],FormWord->[_from_generated->[Point,adjust_confidence]],FormLine->[_from_generated->[_from_generated,Point... | Creates a new object containing the first and last page number of the input form. Creates a object from a generated field name value and read_result. | nit: I would somehow link this to the variable `type`. Something along the lines of "The value for the recognized field. It's data type is described in `type`" |
@@ -192,7 +192,7 @@ class InterpreterConstraints(FrozenOrderedSet[Requirement], EngineAwareParameter
"""
if self.includes_python2():
return "2.7"
- max_expected_py3_patch_version = 15 # The current max is 3.6.12.
+ max_expected_py3_patch_version = 15 # The current max is 3... | [InterpreterConstraints->[includes_python2->[_includes_version],merge_constraint_sets->[and_constraints,parse_constraint],minimum_python_version->[includes_python2,_includes_version],requires_python38_or_newer->[_requires_python3_version_or_newer],create_from_compatibility_fields->[merge_constraint_sets,InterpreterCons... | Find the lowest major. minor Python version that will work with these constraints. | Can we automate a test for this in case the number is exceeded? They got to 2.7.16 at one point. |
@@ -212,4 +212,13 @@ class UserController extends Controller
return false;
}
+
+ public function authlog()
+ {
+ $this->authorize('manage', User::class);
+
+ return view('user.authlog', [
+ 'authlog' => AuthLog::orderBy('datetime', 'DESC')->get(),
+ ]);
+ }
}
| [UserController->[create->[authorize,canUpdatePasswords,get],show->[authorize],edit->[authorize,get],update->[isDirty,all,user,get,back,fill,has,setPassword,save,canSetPassword,updateDashboard],store->[getUserid,get,back,only,setPassword,save,updateDashboard],destroy->[authorize,json,delete],index->[authorize,get,count... | Updates the dashboard of a user. | Should this use the same authorization, or should it be a new one? |
@@ -33,6 +33,12 @@ class SamlIdpController < ApplicationController
return sign_out_with_flash if raw_saml_request.nil?
decode_request(raw_saml_request)
+
+ # Plumb the fingerprint through to the internal service_provider representation
+ if saml_request && matching_cert
+ saml_request.service_pro... | [SamlIdpController->[saml_metadata->[saml_metadata]]] | Logout the user if there is no user with a node id that matches the filter criteria. | Is this not done within the `matching_cert` call? |
@@ -0,0 +1,17 @@
+package io.quarkus.logging.json.deployment;
+
+import io.quarkus.deployment.annotations.BuildStep;
+import io.quarkus.deployment.annotations.ExecutionTime;
+import io.quarkus.deployment.annotations.Record;
+import io.quarkus.deployment.builditem.LogConsoleFormatBuildItem;
+import io.quarkus.logging.js... | [No CFG could be retrieved] | No Summary Found. | Maybe call it `*Processor`? It's the generally used name. There are a few different ones but let's try to settle on one convention. |
@@ -0,0 +1,8 @@
+FactoryGirl.define do
+ factory :draft_work do
+ sequence(:title) { |n| "#{n}人はプリキュア" }
+ media :tv
+ official_site_url 'http://example.com'
+ wikipedia_url 'http://example.com'
+ end
+end
| [No CFG could be retrieved] | No Summary Found. | Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping. |
@@ -40,7 +40,7 @@ class DevicesController < ApplicationController
user: current_user,
token: params[:token],
platform: params[:platform],
- app_bundle: params[:app_bundle]
+ app_integration: AppIntegration.find_by(app_bundle: params[:app_bundle])
}
end
| [DevicesController->[create->[persisted?,render,find_or_create_by,errors_as_sentence,head],destroy->[render,errors_as_sentence,find_by,destroy,head,destroyed?],render,rescue_from,skip_before_action,before_action,message]] | device params that are not missing return nil. | what happens if this returns nil? can it be nil? |
@@ -707,6 +707,16 @@ class PostsController < ApplicationController
find_post_using(by_number_finder)
end
+ def find_post_from_params_by_date
+ by_date_finder = Post
+ .where(topic_id: params[:topic_id])
+ .where("created_at >= ?", Time.zone.parse(params[:date]))
+ .order("created_at ASC")
+... | [PostsController->[destroy->[destroy],cooked->[cooked],recover->[recover],reply_history->[reply_history],destroy_many->[destroy],raw_email->[raw_email]]] | Find a post based on a sequence of post numbers. | You'll need to initialize an instance of a `TopicView` here and pass it the current filters for the topic. Otherwise, this query may return a post that is not within the stream. |
@@ -95,7 +95,7 @@ public class RegexFilteredDimensionSpec extends BaseFilteredDimensionSpec
@Override
public int getValueCardinality()
{
- return bitSetOfIds.cardinality();
+ return selector.getValueCardinality();
}
@Override
| [RegexFilteredDimensionSpec->[getCacheKey->[getCacheKey],hashCode->[hashCode],decorate->[lookupId->[lookupId],lookupName->[lookupName],getRow->[getRow]],equals->[equals]]] | Decorate a DimensionSelector to filter out any missing values. | this breaks contract of getValueCardinality(), this should return cardinality "after" filtering. |
@@ -11,9 +11,8 @@ import (
func NewCmdTeam(cl *libcmdline.CommandLine, g *libkb.GlobalContext) cli.Command {
return cli.Command{
- Name: "team",
- // Hide it:
- // Usage: "Manage teams.",
+ Name: "team",
+ Usage: "Manage teams.",
ArgumentHelp: "[arguments...]",
Subcommands: []cli.C... | [No CFG could be retrieved] | NewCmdTeam returns a new cli. Command that creates a new team. | one small detail: the other usages don't have a period at the end, do they? anyway this all looks good to me. |
@@ -35,7 +35,7 @@ PreactDef.VNode = function () {};
PreactDef.Context = function () {};
/**
- * @param {!JsonObject} props
+ * @param {{value: ?}} props
* @return {PreactDef.Renderable}
*/
PreactDef.Context.prototype.Provider = function (props) {};
| [No CFG could be retrieved] | The base preact definition for the n - node objects. | I think this can also take `children` |
@@ -172,4 +172,9 @@ public interface ActiveWindowSet<W extends BoundedWindow> {
* ACTIVE windows {@code toBeMerged} have been merged into {@code mergeResult}.
*/
W mergedWriteStateAddress(Collection<W> toBeMerged, W mergeResult);
+
+ /**
+ * Return {@literal true} if active window set has any non-empty st... | [No CFG could be retrieved] | Write - state address for a merged write - state collection. | Noting that `ReadableState<Boolean>` might make sense here, but since `isEmpty()` |
@@ -218,15 +218,15 @@ class ToolbarButton extends AbstractToolbarButton {
const { button, tooltipPosition } = this.props;
const name = button.buttonName;
- if (UIUtil.isButtonEnabled(name)) {
+ if (isButtonEnabled(name)) {
if (!button.unclickable) {
if (... | [No CFG could be retrieved] | Sets shortcut and tooltip for current toolbar button. | Why did you move tooltips? Again, I'm not against this but I don't understand what it gives you, especially with reactification of tooltips in review. |
@@ -150,6 +150,13 @@ TransportRegistry::load_transport_configuration(const OPENDDS_STRING& file_name,
transport_id.c_str()),
-1);
}
+
+ // store the transport info
+ TransportEntry entry;
+ entry.transport_nam... | [No CFG could be retrieved] | Load the transport configuration. Check if the section exists in the configuration. If it does it checks if there are any. | Would any of the failure cases below require us to purge / skip this transport, or are they all severe enough it won't matter that we're modifying transports_ here? |
@@ -873,11 +873,13 @@ def is_valid_withdraw_request(
def is_valid_withdraw_confirmation(
- channel_state: NettingChannelState, withdraw: ReceiveWithdraw
+ channel_state: NettingChannelState, withdraw: ReceiveWithdrawConfirmation
) -> SuccessOrError:
result: SuccessOrError
+ withdraw_exists = wit... | [get_current_balanceproof->[get_amount_locked],is_valid_withdraw_confirmation->[is_valid_signature],register_secret_endstate->[is_lock_locked],handle_action_withdraw->[is_valid_action_withdraw,send_withdraw_request],handle_block->[is_deposit_confirmed,get_status],send_withdraw_request->[get_next_nonce,get_status],send_... | Checks if a withdrawn confirmation is valid. | The withdraw *MUST* have the expiration as part of the signature. Otherwise this attack is possible: Alice has balance 50 Bob has balance 0 Alice requests withdraw of 50 Bob sends confirmation Alice waits for the withdraw to expire Alice sends the withdraw expired message, Bob accepts Alice sends a payment through Bob ... |
@@ -875,6 +875,7 @@ function PMA_isJustBrowsing($analyzed_sql_results, $find_real_end)
&& (empty($analyzed_sql_results['analyzed_sql'][0]['where_clause'])
|| $analyzed_sql_results['analyzed_sql'][0]['where_clause'] == '1 ')
&& ! isset($find_real_end)
+ && !$analyzed_sql_results['is_sub... | [PMA_getDefaultSqlQueryForBrowse->[addParam,addMessage],PMA_getNumberOfRowsAffectedOrChanged->[affectedRows,numRows],PMA_countQueryResults->[tryQuery,fetchValue],PMA_setColumnOrder->[getString,addJSON,isSuccess,setUiProp],PMA_handleQueryExecuteError->[isSuccess,addJSON],PMA_getHtmlForSqlQueryResults->[getDisplay],PMA_s... | Checks if a node is just browsing or not. | PMA_isJustBrowsing() function wasn't checking if a query was a subquery. If query is a subquery then it couldn't be "just Browsing" and the function should return false. Before changing this, when a query like "SELECT COUNT(*) FROM (SELECT 1) AS TB" runs, it made the "$justBrowsing" input parameter of the function PMA_... |
@@ -49,6 +49,13 @@ abstract class CommittedResult {
*/
public abstract Iterable<? extends CommittedBundle<?>> getOutputs();
+ /**
+ * Returns if the transform that produced this result produced outputs.
+ *
+ * <p>Transforms that produce output via modifying the state of the runner (e.g.
+ * {@link Cr... | [CommittedResult->[create->[AutoValue_CommittedResult,getTransform]]] | This method creates a new committed result from a transform result. | This seems like a good candidate for the mantra that booleans rarely stay boolean. In particular, you already have three cases: 1. Produced elements 2. Wrote to a side input area (which is probably subject to change as the runner evolves, and just means "created some work somewhere that isn't new elements) 3. Did nothi... |
@@ -223,11 +223,11 @@ function setupJson_(init) {
init.headers = init.headers || {};
init.headers['Accept'] = 'application/json';
- if (init.method == 'POST') {
+ if (init.method == 'POST' && !isFormData(init.body)) {
// Assume JSON strict mode where only objects or arrays are allowed
// as body.
... | [No CFG could be retrieved] | Creates a promise for the given method name. Fetches a single object from the server. | I don't understand why this is needed. |
@@ -188,6 +188,13 @@ func (ir *ImageEngine) Inspect(ctx context.Context, namesOrIDs []string, opts en
}
func (ir *ImageEngine) Load(ctx context.Context, opts entities.ImageLoadOptions) (*entities.ImageLoadReport, error) {
+ pathInfo, err := os.Stat(opts.Input)
+ if err != nil {
+ return nil, err
+ }
+ if pathInfo.... | [Save->[Remove],Push->[Push],List->[List],Load->[Load],History->[History],Exists->[Exists],Prune->[Prune],Tag->[Tag],Search->[Search],Build->[Build],Tree->[Tree],Import->[Import],Pull->[Pull],Diff->[Diff],Untag->[Untag,Tag]] | Load loads an image from the remote server. | That's redundant to line 207. |
@@ -67,7 +67,8 @@ static void do_notify(void)
/* copy the data returned from DSP */
if (msg->rx_size && msg->rx_size < SOF_IPC_MSG_MAX_SIZE)
- mailbox_dspbox_read(msg->rx_data, 0, msg->rx_size);
+ mailbox_dspbox_read(msg->rx_data, SOF_IPC_MSG_MAX_SIZE,
+ 0, msg->rx_size);
/* any callback ? */
if (m... | [No CFG could be retrieved] | The main entry point for the notification. The main entry point for the interrupt handler. | You have changed the number of function parameters, but haven't changed function definition. |
@@ -75,7 +75,7 @@ led_config_t g_led_config = { {
#ifdef USB_LED_INDICATOR_ENABLE
void rgb_matrix_indicators_kb(void)
{
- md_rgb_matrix_indicators();
+ md_rgb_matrix_indicators_advanced(0, ISSI3733_LED_COUNT);
}
#endif // USB_LED_INDICATOR_ENABLE
| [rgb_matrix_indicators_kb->[md_rgb_matrix_indicators]] | read rgb_matrix_indicators_kb. | @ash0x0 will have to sign off this change, or it will have to go via develop |
@@ -34,7 +34,14 @@ public final class ServerVersionUtil {
}
public static ServerInfo getServerInfo(final Client ksqlClient, final String ksqlServerUrl) {
- final CompletableFuture<ServerInfo> response = ksqlClient.serverInfo();
+ final CompletableFuture<ServerInfo> response;
+
+ try {
+ response =... | [ServerVersionUtil->[serverVersionCompatible->[isSupportedVersion,getServerInfo]]] | Get the server info. | Why would an IllegalArgumentException be thrown? |
@@ -316,8 +316,14 @@ final class OpenTelemetryTracing implements Tracing {
}
}
- private static void fillEndpoint(AttributeSetter span, OpenTelemetryEndpoint endpoint) {
- span.setAttribute(SemanticAttributes.NET_TRANSPORT, IP_TCP);
- NetPeerAttributes.INSTANCE.setNetPeer(span, endpoint.name, endpoint.... | [OpenTelemetryTracing->[OpenTelemetrySpan->[start->[start,name],finish->[finish]],OpenTelemetryTracer->[nextSpan->[nextSpan,getSpanContext]]]] | Fill the endpoint attribute. | nit: I would invert the if. |
@@ -275,12 +275,14 @@ class SearchQueryFilter(BaseFilterBackend):
(query.Match, {
'query': search_query, 'boost': 3,
'analyzer': 'standard'}),
- (query.Match, {
- 'query': search_query, 'boost': 2,
- 'prefix_length': 4, 'fuzziness':... | [AddonTagQueryParam->[get_es_query->[get_value]],AddonExcludeAddonsQueryParam->[get_es_query->[get_value]],AddonAppVersionQueryParam->[get_es_query->[get_values],get_values->[AddonAppQueryParam]],AddonQueryParam->[get_value_from_object_from_reverse_dict->[get_object_from_reverse_dict],get_es_query->[get_value]],SearchP... | Return the primary should rules for the query. name_l10n_1 - name_l10n_2 - name_. | I switched to `match` with `fuzziness` instead of actual `fuzzy` queries in 7cd7b7c049ec2207a622839835915c251d2d5a1f There are quite a few places around the interweb where they advice that for both query-performance and cluster-health reasons. |
@@ -49,11 +49,15 @@ func (c cloudBackendReference) String() string {
curUser = ""
}
- if c.owner == curUser {
+ if c.owner == curUser && c.b.currentProject != nil && c.project == string(c.b.currentProject.Name) {
return string(c.name)
}
- return fmt.Sprintf("%s/%s", c.owner, c.name)
+ if c.b.currentProjec... | [ExportDeployment->[ExportStackDeployment],LastUpdate->[Unix],Name->[QName],Remove->[RemoveStack],String->[Sprintf,Background,GetPulumiAccountName],GetLogs->[GetStackLogs],Preview->[PreviewStack],Destroy->[DestroyStack],ConsoleURL->[StackConsoleURL],Snapshot->[getSnapshot],ImportDeployment->[ImportStackDeployment],Refr... | String returns the string representation of a cloudBackendReference. | Can we combine both of these if-expressions together, just for clarity? ``` // If the project names match, we can elide them. if c.b.currentProject != nil && c.project == string(c.b.currentProject.Name) { if c.owner == curUser { return string(c.name) // Elide owner too, if it is the current user. } return fmt.Sprintf("... |
@@ -44,7 +44,7 @@ public class RuleWsSupport {
this.defaultOrganizationProvider = defaultOrganizationProvider;
}
- public void checkQProfileAdminPermission() {
+ public void checkQProfileAdminPermissionOnDefaultOrganization() {
userSession
.checkLoggedIn()
.checkPermission(ADMINISTER_QUAL... | [RuleWsSupport->[getOrganizationByKey->[selectByKey,orElseGet,checkFoundWithOptional,get],checkQProfileAdminPermission->[checkPermission,getUuid]]] | check if the user has permission to view the qProfile administration. | If I understand correctly, this renaming is not fixing the problem, it's just here to make things clearer I agree on the change but it should be a dedicated commit |
@@ -223,7 +223,11 @@ def plot_drop_log(drop_log, threshold=0, n_max_plot=20, subject='Unknown',
if perc < threshold or len(ch_names) == 0:
plt.text(0, 0, 'No drops')
return fig
- counts = 100 * np.array(list(scores.values()), dtype=float) / len(drop_log)
+ n_used = 0
+ for d in drop_log:... | [plot_drop_log->[_drop_log_stats],_mouse_click->[plot_epochs_image,_pick_bad_epochs,_plot_window],_toggle_labels->[_plot_vert_lines],_epochs_navigation_onclick->[_draw_epochs_axes],_plot_onkey->[_plot_traces,_plot_window]] | Plot the channel stats based on a drop_log from Epochs. drop_log Plots the nanoseconds that have been rejected. | this would be a Bug fix, no? I would add it somewhere in the whats_new.rst |
@@ -219,10 +219,10 @@ public final class TestRun
InspectContainerResponse containerInfo = container.getCurrentContainerInfo();
ContainerState containerState = containerInfo.getState();
- Integer exitCode = containerState.getExitCode();
+ Long exitCode = ... | [TestRun->[TestRunOptions->[toModule->[toInstance],File],run->[build,runCommand],Execution->[cleanUp->[info,pruneEnvironment],getEnvironment->[configureContainer,getOrDefault,splitToList,toArray,build,get,exposePort,add,withCommand,addExposedPort],runTests->[UncheckedIOException,checkState,getCurrentContainerInfo,getSt... | This method runs tests in the container. | Why was this needed? |
@@ -185,9 +185,13 @@ func (c *Container) generateSpec(ctx context.Context) (*spec.Spec, error) {
// If network namespace was requested, add it now
if c.config.CreateNetNS {
if c.config.PostConfigureNetNS {
- g.AddOrReplaceLinuxNamespace(spec.NetworkNamespace, "")
+ if err := g.AddOrReplaceLinuxNamespace(spec... | [checkpoint->[exportCheckpoint,checkpointRestoreSupported,checkpointRestoreLabelLog],restore->[checkpointRestoreSupported,prepare,importCheckpoint,checkpointRestoreLabelLog]] | generateSpec generates a spec from the container s config and the container s mount point. Add options to a container Add the necessary namespaces to the container Add namespaces for containers If runc is set to use Systemd as a cgroup manager it expects cgroups to AddMount adds a mount to g. | Wait, these return errors? News to me... |
@@ -4,9 +4,8 @@ module ImageHelper
def ann_image_url(record, field, options = {})
path = image_path(record, field)
size = options[:size]
- ratio = options[:ratio].presence || "1:1"
- width, height = size.split("x").map do |s|
+ width, _ = size.split("x").map do |s|
s.present? ? (s.to_i * ... | [ann_api_assets_background_image_url->[ann_api_assets_url],api_user_avatar_url->[ann_image_url],ann_image_tag->[ann_image_url],profile_background_image_url->[ann_image_url]] | Returns an image_url for the given record field and size. | Style/TrailingUnderscoreVariable: Do not use trailing _s in parallel assignment. Prefer width, = size.split("x").map do |s| |
@@ -345,6 +345,9 @@ export class Vsync {
}
// Schedule actual animation frame and then run tasks.
this.scheduled_ = true;
+ if (this.jankRateDisplay_) {
+ this.scheduledTime_ = this.win.performance.now();
+ }
this.forceSchedule_();
}
| [No CFG could be retrieved] | Runs a series of tasks and schedules them if necessary. Call all the tasks and states in order to call the measure. | `this.scheduledTime_` needs to be added in the constructor. |
@@ -183,7 +183,7 @@ maven-compile:
maven-test:
stage: test
script:
- - ./mvnw -ntp verify -Dmaven.repo.local=$MAVEN_USER_HOME
+ - ./mvnw verify -P-webpack -Dmaven.repo.local=$MAVEN_USER_HOME
artifacts:
reports:
junit: target/test-results/**/TEST-*.xml
| [No CFG could be retrieved] | Exports all of the dependencies of the given package manager. Maven agent reports. | Did the `-ntp` got lost on purpose here? |
@@ -0,0 +1,11 @@
+using System;
+using System.Reflection;
+using System.Runtime.CompilerServices;
+using System.Runtime.InteropServices;
+using System.Resources;
+
+// Specific platform information about an assembly is controlled through the following
+// set of attributes. Change these attribute values to modify the ... | [No CFG could be retrieved] | No Summary Found. | Remove not used usings. |
@@ -442,10 +442,14 @@ const Composer = RestModel.extend({
@discourseComputed("canCategorize", "categoryId")
requiredCategoryMissing(canCategorize, categoryId) {
+ const hasTopicTemplates = this.site.categories.some(
+ (c) => c.topic_template
+ );
return (
canCategorize &&
!category... | [No CFG could be retrieved] | Checks if a reply is required. The original title is the title of the page. | I don't think we should run this check every single time the property is computed (looks like whenever the current category is changed). Can you memoize it in the model? |
@@ -214,7 +214,11 @@ public class HoodieAvroUtils {
GenericRecord newRecord = new GenericData.Record(newSchema);
for (Schema.Field f : fieldsToWrite) {
if (record.get(f.name()) == null) {
- newRecord.put(f.name(), f.defaultVal());
+ if (f.defaultVal() instanceof Null) {
+ newReco... | [HoodieAvroUtils->[getCombinedFieldsToWrite->[isMetadataField],createHoodieWriteSchema->[createHoodieWriteSchema],addMetadataFields->[isMetadataField]]] | Rewrite the record with the fields written to the new schema. | Why do you need this? If f.defaultVal() is null, it will be automatically populated like that. |
@@ -229,15 +229,14 @@ export default class Avatar extends Component<Props, State> {
// regular Image, so we need to wrap it in a view to make it round.
// https://github.com/facebook/react-native/issues/3198
- const { backgroundColor, useDefaultAvatar } = this.state;
+ const { backgrou... | [No CFG could be retrieved] | Renders a local or remote avatar image. Renders an avatar using a remote image. | Why is there a check for the truthiness of "useDefaultAvatar" in the method renderDefaultAvatar? Should it not always be true? |
@@ -209,8 +209,7 @@ public class NacosDynamicConfiguration implements DynamicConfiguration {
@Override
public Object getInternalProperty(String key) {
try {
- String[] keyAndGroup = getKeyAndGroup(key);
- return configService.getConfig(keyAndGroup[0], keyAndGroup[1], 5000L);
+ ... | [NacosDynamicConfiguration->[getInternalProperty->[getConfig,getKeyAndGroup],addListener->[createTargetListener,getKeyAndGroup,addListener],removeListener->[removeListener,generateKey],getConfig->[generateKey],getConfigs->[getConfig]]] | Gets the internal property. | why ignore the group specified by user |
@@ -114,7 +114,6 @@ async def serialize_property(value: 'Input[Any]',
if known_types.is_resource(value):
resource = cast('Resource', value)
- deps.append(resource)
is_custom = known_types.is_custom_resource(value)
resource_id = cast('CustomResource', value).id if is_custom els... | [register_resource_module->[version,_module_key,same_version],serialize_property->[serialize_property,isLegalProtobufValue],resolve_properties->[unwrap_rpc_secret,is_rpc_secret],wrap_rpc_secret->[is_rpc_secret],unwrap_rpc_secret->[is_rpc_secret],translate_output_properties->[unwrap_rpc_secret,is_rpc_secret,translate_ou... | Serializes a single Input into a form suitable for remoting to the engine. Serializing a weakly typed object requires a key. Serialize a object. | What's the context for this change? |
@@ -14,11 +14,8 @@ StepFunctionTypeNoTimestep = Callable[[torch.Tensor, StateType], Tuple[torch.Ten
class BeamSearch:
"""
Implements the beam search algorithm for decoding the most likely sequences.
-
[0]: https://arxiv.org/abs/1702.01806
-
# Parameters
-
end_index : `int`
The index o... | [BeamSearch->[search->[new_step->[old_step],,step,size,topk,where,reversed,warn,gather,view,ConfigurationError,cat,range,predictions,list,append,cast,len,items,reconstruct_sequences,float,isfinite,signature,reshape,new_full,unsqueeze],reconstruct_sequences->[predictions,append,len,range,gather],no_grad]] | Initialize a BeamSearch object from a sequence of predicted sequences. Reconstruct the sequences of the given . | All of the blank lines are here for a reason. The API docs won't render properly without them. |
@@ -96,7 +96,7 @@ public class Chat implements ChatClient {
@Override
public void slappedBy(final PlayerName from) {
final String message = "You were slapped by " + from;
- chatHistory.add(new ChatMessage(message, from));
+ chatHistory.add(new ChatMessage(from, message));
chatMessageListeners.forE... | [Chat->[participantRemoved->[updateConnections],participantAdded->[updateConnections],sendMessage->[sendMessage],addChatListener->[updateConnections],messageReceived->[messageReceived],updateStatus->[updateStatus]]] | Called when a player is slapped by another player. | Why is the new ChatMessage object not passed to the listener? |
@@ -343,6 +343,11 @@ public class SinglePhaseParallelIndexTaskRunner extends ParallelIndexPhaseRunner
interval = granularitySpec.getSegmentGranularity().bucket(timestamp);
version = ParallelIndexSupervisorTask.findVersion(versions, interval);
if (version == null) {
+ final int maxAllowedLock... | [SinglePhaseParallelIndexTaskRunner->[newTaskSpec->[SinglePhaseSubTaskSpec,ParallelIndexIngestionSpec,isDropExisting,isAppendToExisting,getContext,getTuningConfig,getDataSchema,getBaseSubtaskSpecName,getTaskId,getGroupId,ParallelIndexIOConfig,withSplit,getAndIncrementNextSpecId,getInputFormat],getSubtaskCompletionCallb... | Find the interval and version associated with the given timestamp. Find the next version of the interval. | Would change to `locks.size() >= maxAllowedLockCount` just for safety |
@@ -1924,6 +1924,7 @@ public class VolumeApiServiceImpl extends ManagerBase implements VolumeApiServic
throw new InvalidParameterValueException("Cannot migrate ROOT volume of a stopped VM to a storage pool in a different VMware datacenter");
}
... | [VolumeApiServiceImpl->[handleVmWorkJob->[handleVmWorkJob],orchestrateExtractVolume->[orchestrateExtractVolume],attachVolumeToVmThroughJobQueue->[VmJobVolumeOutcome],createVolumeFromSnapshot->[createVolumeFromSnapshot],migrateVolumeThroughJobQueue->[VmJobVolumeOutcome],detachVolumeFromVmThroughJobQueue->[VmJobVolumeOut... | Checks if a volume can be migrated. Checks if a node in the VM can migrate to a different volume. If the volume is This method is called when a VM is migrated to a different VM in a different VM datacenter. | What about extracting lines 1939-1954 to a method? This can really help us to work on that code and the unit tests it deserves. |
@@ -260,11 +260,13 @@ public class CreateExecutableStageNodeFunction
e);
}
+ // TODO(BEAM-6275): Set correct IsBounded on generated PCollections
String pcollectionId = node.getPcollectionId();
RunnerApi.PCollection pCollection =
RunnerApi.PCollection.newBuilder()
... | [CreateExecutableStageNodeFunction->[getEnvironmentFromPTransform->[forComponents,orElse],registerWindowingStrategy->[getCodersMap,putAllEnvironments,putWindowingStrategies,getEnvironmentsMap,getWindowingStrategy,toMessageProto,putAllCoders],transformCombineValuesFnToFunctionSpec->[parseFrom,getUrn,RuntimeException,equ... | This method is called to find a node that has a named node and that has no edges This method is used to create a new proto with a sequence of Coder objects. Returns a coder that can be used to encode the output. | The function here is bonkers long. Not your responsibility but if your hacking lent you any insight, please do split it into pieces like 1/10 the size. |
@@ -416,13 +416,13 @@ func TestAccessController(t *testing.T) {
expectedActions = []string{}
}
if !reflect.DeepEqual(actions, &expectedActions) {
- t.Errorf("%s: expected\n\t%#v\ngot\n\t%#v", k, &expectedActions, actions)
+ t.Errorf("\n%s:\n expected:\n\t%#v\ngot:\n\t%#v", k, &expectedActions, actions)
... | [NewRequest,HandlerFunc,DeepEqual,Close,SetHeaders,Set,WithRequest,Error,New,GroupOrDie,NewRecorder,Errorf,Authorized,Fprintln,Fatalf,Get,Header,NewServer,Sprintf,Background,EncodeOrDie,LegacyCodec,Fatal,Parse,WriteHeader,GetLogger] | if tests if the given tokens are valid continue returns false if there are no more errors. | > @miminar but it will increase the number of packages we import from kube into registry :-) not sure if it is worth. Every project is allowed to depend on `k8s.io/apimachinery`. |
@@ -999,6 +999,9 @@ export class AmpStory extends AMP.BaseElement {
setAttributeInMutate(oldPage, Attributes.VISITED);
}
+ // Start progress bar update for target page.
+ this.advancement_.updateProgress(targetPageId);
+
this.storeService_.dispatch(Action.CHANGE_PAGE, {
... | [AmpStory->[pauseCallback->[TOGGLE_PAUSED,PAUSED_STATE],buildSystemLayer_->[element],onPausedStateUpdate_->[ACTIVE,PAUSED],registerAndPreloadBackgroundAudio_->[upgradeBackgroundAudio,childElement,tagName],constructor->[documentStateFor,timerFor,getStoreService,registerServiceBuilder,platformFor,for,createPseudoLocale],... | Switches to a specific page. This method is called when a page is on screen to left in desktop view. It is StepInRAF - StepInRAF. | While I understand why you want to keep updating the progress this way, as it keeps the page-advancement code working as before, the logic becomes a bit weird: 1. `amp-story` triggers `advancement.updateProgress` 2. `advancement.updateProgress` triggers `amp-story` callback What do you think of calling `story.emitProgr... |
@@ -9,6 +9,7 @@ class CheckboxCriterion < Criterion
has_many :test_groups, as: :criterion
validate :visible?
+ validate :results_unreleased?
DEFAULT_MAX_MARK = 1
| [CheckboxCriterion->[add_tas->[create,size,where,each,assignment],load_from_yml->[nil?,max_mark,new,peer_visible,ta_visible,description,name],update_assigned_groups_count->[get_groupings_by_assignment,concat,assigned_groups_count,each,length],get_ta_names->[user_name,collect],create_or_update_from_csv_row->[position,ni... | Symbolize checkbox or not. | Oh, you can move the validation line into `criterion.rb` as well. |
@@ -338,7 +338,7 @@ public final class LibvirtMigrateCommandWrapper extends CommandWrapper<MigrateCo
String path = getPathFromSourceText(migrateStorage.keySet(), sourceText);
if (path != null) {
- MigrateCommand.MigrateDiskInfo migrateDiskIn... | [LibvirtMigrateCommandWrapper->[execute->[createMigrationURI]]] | Replace the storage in the given xml description with the new one. This method is called when the migrateDiskInfo is passed into the command. It will add. | Was this a bug, to get and not remove a path. Can you send any bugfix PR towards 4.11? |
@@ -319,7 +319,9 @@ OPENEXCHANGERATES_API_KEY = os.environ.get('OPENEXCHANGERATES_API_KEY')
# VAT configuration
# Enabling vat requires valid vatlayer access key.
+# If you are subscribed to a paid vatlayer plan, you can enable HTTPS.
VATLAYER_ACCESS_KEY = os.environ.get('VATLAYER_ACCESS_KEY')
+VATLAYER_USE_HTTPS ... | [get_list->[strip,split],get_bool_from_env->[literal_eval,ValueError,format],get_host->[get_current],get_currency_fraction,bool,int,pgettext_lazy,_,parse,append,get_list,dirname,insert,get,getenv,config,setdefault,join,normpath,get_bool_from_env,CACHES] | Config for a single user - specified object. VARIANTS - Declarative description of parameters. | Can we use `ENABLE_SSL` variable here? |
@@ -157,9 +157,11 @@ public class FuzzyHashContent extends AbstractProcessor {
}
final ComponentLog logger = getLogger();
+ String algorithm = context.getProperty(HASH_ALGORITHM).getValue();
// Check if content matches minimum length requirement
- if (context.getProperty(HAS... | [FuzzyHashContent->[init->[add,unmodifiableList,unmodifiableSet],onTrigger->[process->[getValue,equals,copy,hash,ByteArrayOutputStream,set,toString,HashString],getValue,modifyAttributes,error,equals,getLogger,get,transfer,putAttribute,read,info,InputStreamCallback,getSize],build,AllowableValue]] | On trigger. | Use the value of `algorithm` instead of hardcoded **TLSH** in the message, and we probably don't want to write the entire flowfile content to the log -- use the unique ID for traceability instead. |
@@ -29,5 +29,5 @@ import java.util.Map;
public interface SegmentPuller
{
public File getSegmentFiles(DataSegment loadSpec) throws StorageAdapterLoadingException;
- public boolean cleanSegmentFiles(DataSegment loadSpec) throws StorageAdapterLoadingException;
+ long getLastModified(DataSegment segment) throws Stor... | [No CFG could be retrieved] | Returns the files that are needed to load the given segment. | make method public pls |
@@ -28,9 +28,9 @@ module Idv
def link(token)
if request.path.include?('doc_auth_v2')
- idv_doc_auth_v2_step_url(step: :scan_id, token: token)
+ idv_doc_auth_v2_step_dashes_url(step: :scan_idto_s.dasherize, token: token)
else
- idv_capture_doc_step_url(step: :mobile_... | [SendLinkStep->[throttled_else_increment->[call],send_link->[call]]] | link to user s IDV page if token is found. | Was this supposed to be `scan_id.to_s.dasherize`? |
@@ -172,7 +172,7 @@ public class SqlFormatterTest {
ORDERS_SCHEMA,
SerdeOption.none(),
KeyField.of(ColumnRef.withoutSource(ColumnName.of("ORDERTIME"))),
- new MetadataTimestampExtractionPolicy(),
+ Optional.empty(),
false,
ksqlTopicOrders
);
| [SqlFormatterTest->[shouldFormatInsertValuesNoSchema->[assertThat,formatSql,parseSingle,is],shouldFormatShowStreams->[ListStreams,formatSql,empty,is,assertThat],shouldFormatExplainStatement->[assertThat,formatSql,parseSingle,is],shouldFormatCreateStreamStatementWithImplicitKey->[CreateStream,assertThat,formatSql,is],sh... | Sets up the table aliases and fields. region MetadataTimestampExtractionPolicy Implementation. | Is it worth having at least one test that has column and testing its formatted correctly? |
@@ -518,7 +518,7 @@ func renderFile(ctx *context.Context, entry *git.TreeEntry, treeLink, rawLink st
Metas: ctx.Repo.Repository.ComposeDocumentMetas(),
GitRepo: ctx.Repo.GitRepo,
}, rd, &result)
- if err != nil {
+ if err != nil && err != io.EOF {
ctx.ServerError("Render", err)
return
... | [IsReadmeFile,IsRegular,Redirect,GetOwner,Itoa,ListEntries,GetTreeEntryByPath,IsAudio,FormString,HasSuffix,ServerError,DisplayName,Render,ToUTF8WithFallbackReader,IsRepresentableAsText,CalcCommitStatus,Split,DetectContentType,IsValid,DataAsync,GetLatestCommitStatus,Dir,ValidateCommitWithEmail,GetTopLanguageStats,Close,... | Renders a blob in the form of a string. content file content. | This may be wrong for other renderers. You could check in the csv renderer for `io.EOF` and treat it as no error. |
@@ -17,8 +17,9 @@ import {
SET_AUDIO_ONLY,
SET_DESKTOP_SHARING_ENABLED,
SET_FOLLOW_ME,
+ SET_MAX_RECEIVER_VIDEO_QUALITY,
SET_PASSWORD,
- SET_RECEIVE_VIDEO_QUALITY,
+ SET_PREFERRED_RECEIVER_VIDEO_QUALITY,
SET_ROOM,
SET_SIP_GATEWAY_ENABLED,
SET_START_MUTED_POLICY
| [No CFG could be retrieved] | Register a redux action that can be used to create a new conference object. Set action on all the components of the system. | Don't you wanna persist these? |
@@ -5,6 +5,8 @@ class StoreSpMetadataInSession
end
def call
+ return unless sp_request
+
session[:sp] = {
issuer: sp_request.issuer,
loa3: loa3_requested?,
| [StoreSpMetadataInSession->[call->[requested_attributes,issuer,uuid,url,loa3_requested?],loa3_requested?->[loa],sp_request->[find_by],attr_reader]] | Stores the nack in the session for later retrieval. | This PR gives me a little heartburn. If this is a genuine problem, we should at least *log* something about it so we know when it happens (and how often), and possibly enough information that we can identify what user is in this state. Returning this error to the user with a 500 might be reasonable until we figure out ... |
@@ -363,7 +363,9 @@ class BaseZincCompile(JvmCompile):
"""An exception type specifically to signal a failed zinc execution."""
def _compile_nonhermetic(self, jvm_options, ctx, classes_directory):
- exit_code = self.runjava(classpath=self.get_zinc_compiler_classpath(),
+ exit_code = self.runjava(
+ ... | [BaseZincCompile->[_maybe_get_plugin_name->[process_info_file],__init__->[validate_arguments],compile->[javac_classpath,_get_zinc_arguments,scalac_classpath_entries,relative_to_exec_root],_compile_nonhermetic->[ZincCompileError],_verify_zinc_classpath->[is_outside],validate_arguments->[validate]]] | Compile the non - hermetic classes. | used to test with the adhoc zinc wrapper from #7917 |
@@ -378,9 +378,9 @@ public class IndexGeneratorJob implements Jobby
Set<String> allDimensionNames = Sets.newHashSet();
final ProgressIndicator progressIndicator = makeProgressIndicator(context);
- for (final Text value : values) {
+ for (final Writable value : values) {
cont... | [IndexGeneratorJob->[IndexGeneratorReducer->[makeProgressIndicator->[progress->[progress]],mergeQueryableIndex->[mergeQueryableIndex],persist->[persist],serializeOutIndex->[progress],reduce->[persist,makeProgressIndicator,mergeQueryableIndex,progress],copyFile->[progress]],setReducerClass->[setReducerClass],run->[setRe... | Reduce the given values into a single node. This method will take the index and make a new one. If the index is empty it. | parseInputrow seems to more suited to a helper util class instead of mapper. |
@@ -49,6 +49,11 @@ process.argv.forEach(arg => {
})
const config = {
+ // URL for messaging on dapp
+ dappMessagesUrl:
+ args['--dapp-messages-url'] ||
+ process.env.DAPP_MESSAGES_URL ||
+ 'https://dapp.originprotocol.com/#/messages',
// Override email. All emails will be sent to this address, regardl... | [No CFG could be retrieved] | Create an instance of the VAPID app. limit request to one per minute. | Do we want this default value ? Is there a risk it could cause messages to be sent to production when developers test on their local environment ? |
@@ -170,6 +170,8 @@ namespace NServiceBus
readonly IContainSagaData data;
static JsonMessageSerializer serializer = new JsonMessageSerializer(null);
+ static ConcurrentDictionary<Type, bool> canBeClonedShallowlyCache = new ConcurrentDictionary<Type, bool>();
+ static Fu... | [InMemorySagaPersister->[CorrelationId->[Equals->[Equals],GetHashCode->[GetHashCode]]]] | Creates a CorrelationId object that can be used to reference a saga s data. Equals - returns true if the object is equal to this correlation id. | How about `shallowCopy` instead? |
@@ -681,8 +681,8 @@ namespace System.Net.Quic.Implementations.MsQuic
_configuration?.Dispose();
if (releaseHandles)
{
- _state!.Handle?.Dispose();
- if (_state.StateGCHandle.IsAllocated) _state.StateGCHandle.Free();
+ _state!.Handle.Dis... | [MsQuicConnection->[Task->[Dispose],NativeCallbackHandler->[HandleEventConnected,HandleEventStreamsAvailable,HandleEventShutdownInitiatedByTransport,HandleEventPeerCertificateReceived,HandleEventShutdownComplete,HandleEventShutdownInitiatedByPeer,HandleEventNewStream],Dispose->[Dispose,SetClosing],HandleEventNewStream-... | Disposes of the state. | `_state` cannot be `null` so the `!` here is not necessary. But the other checks were necessary (the ? in `Handle?.Dispose();` and `if (_state.StateGCHandle.IsAllocated)` bellow since the ctors might throw an exception and since the class has a finalizer it'll be queued for finalization. Thus, invoking `Dispose` with p... |
@@ -318,7 +318,16 @@ export function getParentWindow(win) {
* @return {!Window}
*/
export function getTopWindow(win) {
- return win.__AMP_TOP || win;
+ const top = win.__AMP_TOP;
+ if (top === null) {
+ return win;
+ }
+ if (top != null) {
+ return top;
+ }
+ // Make this defined but null to speed up ... | [No CFG could be retrieved] | Returns the service promise for the given element or a child window. Get the AMPDoc object for the given node or document. | We could set this to `win` instead? Then keep the same `||`: `win.__AMP_TOP || (win.__AMP_TOP = win)` |
@@ -42,7 +42,6 @@ class PageControllerTest extends SuluTestCase
public function setUp(): void
{
- parent::setUp();
$this->client = $this->createAuthenticatedClient();
$this->initPhpcr();
$this->session = $this->getContainer()->get('sulu_document_manager.default_session');
| [PageControllerTest->[testGetAnotherTemplate->[setTitle,getContent,assertArrayNotHasKey,flush,persist,request,bind,getUuid,setStructureType,createPageDocument,setResourceSegment,assertEquals],testCopyNonExistingSource->[getResponse,import,request,assertHttpStatusCode],testPutNotExisting->[getResponse,request,assertHttp... | Initializes the object. | Aren't we missing something because of that? |
@@ -625,14 +625,14 @@ check_access(dfs_t *dfs, uid_t uid, gid_t gid, mode_t mode, int mask)
static int
open_file(dfs_t *dfs, daos_handle_t th, dfs_obj_t *parent, int flags,
- daos_oclass_id_t cid, daos_size_t chunk_size, dfs_obj_t *file)
+ daos_oclass_id_t cid, daos_size_t chunk_size, dfs_obj_t *file,
+ size_... | [dfs_mount_root_cont->[dfs_cont_create,dfs_mount],dfs_umount_root_cont->[dfs_umount],dfs_lookup->[dfs_lookup],dfs_obj_local2global->[dfs_get_chunk_size],dfs_chmod->[dfs_lookup,dfs_release],dfs_access->[dfs_lookup,dfs_release]] | Open a file or directory object. This function is used to insert a new file or directory entry into the file system. open array with attribute. | minor: but the in/out param is usually the last, so maybe just swap file and len. same for open_dir, open_symlink |
@@ -296,6 +296,10 @@ public class SparkInterpreter extends Interpreter {
return (DepInterpreter) p;
}
+ private boolean isYarnMode() {
+ return getProperty("master").equals("yarn-client") || getProperty("master").equals("yarn");
+ }
+
/**
* Spark 2.x
* Create SparkSession
| [SparkInterpreter->[createSparkSession->[useHiveContext,hiveClassesArePresent],interpretInput->[interpret],getProgress->[getJobGroup],getSQLContext_1->[useHiveContext,getSparkContext],populateSparkWebUrl->[toString,getSparkUIUrl],getCompletionTargetString->[toString],getProgressFromStage_1_0x->[getProgressFromStage_1_0... | Returns an instance of the dep interpreter that can be used to create the dependency interpreter. getOrCreate - Gets or creates a Spark session with the appropriate configuration. | is this because we don't support master == "yarn-cluster"? |
@@ -4,6 +4,7 @@
using System;
using System.Collections.Generic;
using System.Diagnostics;
+using System.Diagnostics.CodeAnalysis;
namespace Microsoft.CSharp.RuntimeBinder.Semantics
{
| [EXPRExtensions->[isNull->[IsNullRef,FT_REF,FundamentalType],ToEnumerable->[OptionalElement,OptionalNextListNode],AssertIsBin->[Flags,TypeLimit,Assert,EXF_BINOP],isChecked->[EXF_CHECKOVERFLOW,Flags],isLvalue->[EXF_LVALUE,Flags],Expr->[ToEnumerable,Constant,OptionalRightChild,ZeroInit,f,GetSeqVal,Kind,Sequence,Assert,Ap... | Creates an expression that can be mapped to a constant or a list of expressions. Get the real value of the expression if it is a constant or a sequence. | Is this necessary? |
@@ -27,6 +27,11 @@ import {urls} from './config';
import {setStyle} from './style';
import {domFingerprint} from './utils/dom-fingerprint';
+/**
+ * If true, then in experiment where the passing of context metadata
+ * has been moved from the iframe src hash to the iframe name attribute.
+ */
+const nameExpOn = isE... | [No CFG could be retrieved] | Creates a new object containing all attributes of a given type width height and data - attributes of Get attributes of an element. | suggested naming: '3p-iframe-context-in-name' |
@@ -534,7 +534,8 @@ export class ImageViewer {
const newPosX = this.boundX_(this.startX_ + deltaX * newScale, false);
const newPosY = this.boundY_(this.startY_ + deltaY * newScale, false);
- return this.set_(newScale, newPosX, newPosY, animate);
+ return /** @type {!Promise} */ (
+ this.set_(ne... | [No CFG could be retrieved] | Performs a one - step or an animated zoom action. Handles a single on zoom release. | Likewise, `!Promise|undefined`. Also I don't think you need type conversion here. |
@@ -0,0 +1,11 @@
+import sys
+import os.path
+import runpy
+
+target = sys.argv[1]
+relpath = os.path.relpath(target)
+root, ext = os.path.splitext(relpath)
+modpath = root.replace(os.path.sep, '.')
+
+del sys.argv[1]
+runpy.run_module(modpath, run_name="__main__", alter_sys=True)
\ No newline at end of file
| [No CFG could be retrieved] | No Summary Found. | Might be nice to explain the purpose of this? |
@@ -41,6 +41,9 @@ import java.util.HashMap;
import java.util.List;
import java.util.Map;
+/**
+ * TODO rewrite to use JMH and move to the benchmarks project
+ */
public class TopNBinaryFnBenchmark extends SimpleBenchmark
{
@Param({"1", "5", "10", "15"})
| [TopNBinaryFnBenchmark->[timeMerge->[apply],main->[main],setUp->[ConstantPostAggregator,TopNBinaryFn,newArrayList,nowUtc,LongSumAggregatorFactory,TopNResultValue,ArithmeticPostAggregator,CountAggregatorFactory,NumericTopNMetricSpec,FieldAccessPostAggregator,add,DefaultDimensionSpec,put]]] | Creates a benchmark that runs a TopN binary function. Post - aggregators for the constant field. | Would you open a new issue for this? |
@@ -313,6 +313,16 @@ func (sc *scaleCmd) run(cmd *cobra.Command, args []string) error {
}
return err
}
+ if sc.nodes != nil {
+ nodes, err := operations.GetNodes(sc.client, sc.logger, sc.apiserverURL, sc.kubeconfig, time.Duration(5)*time.Minute, sc.agentPoolToScale, sc.newDesiredAgentCount)
+ if e... | [drainNodes->[Wrapf,SafelyDrainNode,Sprintf,Duration,Errorf,HasPrefix],saveAPIModel->[LoadContainerServiceFromFile,SerializeContainerService,Split,SaveFile],validate->[LoadTranslations,NormalizeAzureRegion,Infoln,New,Usage,Wrap],run->[PrettyPrintArmTemplate,drainNodes,Errorln,GetAvailabilitySetFaultDomainCount,Values,N... | run runs the scale command This function is used to initialize a new cluster with the given parameters. ScaleDownVMs scale down VMs in the specified resource group. This function is used to generate a template for a single agent This method is used to deploy the template to the agent pool. | is there a missing word here? "in pool myagentpool cluster"? |
@@ -62,7 +62,8 @@ class ZipExport < ActiveRecord::Base
CSV.open(file, 'wb') do |csv|
csv << attributes
records.find_each do |entity|
- csv << entity.audit_record.values_at(*attributes.map(&:to_sym))
+ csv << entity.audit_record(formated: false)
+ .values_at(*attribut... | [ZipExport->[generate_papertrail_csv->[fetch,find_each,first,open,values_at,order,map],generate_notification->[t,create,zip_exports_download_path],generate_exportable_zip->[path,new,to_i,root,generate_notification,zip_file,fill_content,zip!,join,first,open,mkdir_p],fill_content->[generate_papertrail_csv],stored_on_s3?-... | generate papertrail csv. | Align .values_at with entity.audit_record(formated: false) on line 65. |
@@ -1,5 +1,6 @@
package org.ray.runtime;
+import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableList;
import java.util.ArrayList;
import java.util.Arrays;
| [AbstractRayRuntime->[createTaskSpec->[put],loop->[loop],wait->[wait],putSerialized->[putSerialized],get->[put,get],put->[put]]] | Package private for testing purposes. AbstractRayRuntime constructor. | this isn't needed? |
@@ -32,7 +32,7 @@ import java.util.Set;
import java.util.UUID;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.AtomicLong;
-
+import java.util.jar.Attributes;
import org.apache.commons.io.IOUtils;
import org.apache.commons.lang.StringUtils;
import org.apache.nifi.annotation.behavior.Event... | [SelectHiveQL->[setup->[isSet,ProcessException,hasIncomingConnection,error],onTrigger->[getValue,create,onTrigger,size,equals,forName,getElapsed,toString,warn,StringBuilder,info,countMatches,executeQuery,CsvOutputOptions,put,remove,yield,getLocalizedMessage,add,modifyContent,putAllAttributes,AtomicLong,hasIncomingConne... | Imports a single object from a NIHAR file. Imports all the fields from the NIFC processor. | I think this import is unused. |
@@ -25,3 +25,4 @@ class PyAbslPy(PythonPackage):
depends_on('py-setuptools', type=('build'))
depends_on('py-six', type=('build', 'run'))
depends_on('py-enum34', type=('build', 'run'), when='^python@:3.3.99')
+ depends_on('py-setuptools', type='build')
| [PyAbslPy->[depends_on,version]] | Requires all of the dependencies of the build. | The setuptools dep was already added on this line. |
@@ -68,6 +68,14 @@ public final class MongoQueryRunner
}
}
+ private static void createNativeTables(MongoServer server)
+ {
+ MongoClient client = new MongoClient(server.getAddress().getHost(), server.getAddress().getPort());
+ MongoCollection<Document> collection = client.getDatabas... | [MongoQueryRunner->[createMongoQueryRunner->[createMongoQueryRunner],main->[createMongoQueryRunner]]] | Creates a DistributedQueryRunner for the given server and tables. | TestMongoIntegrationSmokeTest already has MongoClient object. Please move this body to testCaseInsensitive. Also, I would recommend renaming `Camel` to `TestCaseInsensitive` or something. |
@@ -98,10 +98,10 @@ class Jetpack_Podcast_Helper {
/**
* Gets a specific track from the supplied feed URL.
*
- * @param string $guid The GUID of the track.
- * @return array|WP_Error The track object or an error object.
+ * @param {string=} $guid The GUID of the track. Omit or pass a falsey value to ... | [Jetpack_Podcast_Helper->[setup_tracks_callback->[get_html_text,get_plain_text]]] | Get the track data for a given track ID. | I wouldn't except `get_track_data` to work like this, falling back to the most recent episode--that feels a bit like a "magic" API for the podcast helper that's likely to cause confusion or bugs down the road. |
@@ -70,6 +70,13 @@ const VENDOR_ANIMATIONEND_EVENTS = ['animationend', 'webkitAnimationEnd'];
*/
const GOTO_AND_PAUSE_DELAY = 40;
+/**
+ * Property name used to store pending goto counters on an element.
+ * @const {string}
+ * Exported for test only.
+ */
+export const GOTO_COUNTER_PROP = 'gwdGotoCounters';
+
/*... | [No CFG could be retrieved] | Provides a function to export a GWD counter value. Sets the given counter on the given receiver. | Nit: We aim to use element properties defined under `__AMP_THIS_FORMAT__`. Could you use `__AMP_GWD_GOTO_COUNTERS__`? |
@@ -131,6 +131,10 @@ class Jetpack_Podcast_Helper {
set_transient( $transient_key, $track_data, HOUR_IN_SECONDS );
}
+ if ( true === $force_refresh ) {
+ remove_action( 'wp_feed_options', array( __CLASS__, 'reset_simplepie_cache' ) );
+ }
+
return $track_data;
}
| [Jetpack_Podcast_Helper->[setup_tracks_callback->[get_html_text,get_plain_text]]] | Get the track data for a given track ID. | It's unlikely to be an issue, but we may have returned from the function already with an error in the previous block. This would mean that the hook would not get removed. Could we pass the `force_refresh` value to `load_feed` and add/remove the action in there? |
@@ -2002,6 +2002,11 @@ public class BigQueryIO {
return toBuilder().setFormatFunction(formatFunction).build();
}
+ /** Formats the user's type into a {@link TableRow} to be written to an error collector. */
+ public Write<T> withFailsafeFormatFunction(SerializableFunction<T, TableRow> formatFunctio... | [BigQueryIO->[getExtractFilePaths->[build],write->[build],TableRowParser->[TableRowParser],Write->[skipInvalidRows->[build],withMethod->[build],withMaxBytesPerPartition->[build],withNumFileShards->[build],withFormatFunction->[build],useBeamSchema->[build],ignoreInsertIds->[build],continueExpandTyped->[getMaxBytesPerPar... | Adds a format function to the write. | Does this have to write TableRows? Why not also have the option to return the user type itself? (perhaps it's a lot of trouble to implement given the existing types?) What are some examples where users may want to recover a different tablerow than the one that was sent to BQ? |
@@ -939,7 +939,7 @@ func (s *HybridConversationSource) GetMessagesWithRemotes(ctx context.Context,
}
if len(merges) > 0 {
sort.Sort(ByMsgID(merges))
- if err = s.mergeMaybeNotify(ctx, convID, uid, merges); err != nil {
+ if err := s.mergeMaybeNotify(ctx, convID, uid, merges); err != nil {
return res, err
... | [Push->[Acquire,Release],GetMessagesWithRemotes->[Error,identifyTLF,Acquire,Release],resolveHoles->[GetMessages],Release->[key],GetMessages->[Error,identifyTLF,Acquire,Release],PullLocalOnly->[postProcessThread,Error,Acquire,Release],Pull->[resolveHoles,Release,identifyTLF,Acquire,postProcessThread],Expunge->[Expunge,A... | GetMessagesWithRemotes gets all messages from the given conversation that have a remote message. identify the last message in the chain. | Curious why this change? |
@@ -20,6 +20,9 @@ class Jetpack_Sync_Actions {
if ( self::sync_via_cron_allowed() ) {
self::init_sync_cron_jobs();
+ } else if ( wp_next_scheduled( 'jetpack_sync_cron' ) ) {
+ wp_clear_scheduled_hook( 'jetpack_sync_cron' );
+ wp_clear_scheduled_hook( 'jetpack_sync_full_cron' );
}
// On jetpack aut... | [Jetpack_Sync_Actions->[do_cron_full_sync->[do_full_sync]]] | Initializes the sync site This method is called to check if sync sender code should be loaded for this request. | this will be executed on every request I think it should be fast as far as the`cron` option is autoloaded, is it? |
@@ -1042,7 +1042,12 @@ public class IntegrationMBeanExporter extends MBeanExporter implements BeanPostP
}
if (name == null) {
- name = monitor.getMessageHandler().toString();
+ if (monitor.getMessageHandler() instanceof NamedComponent) {
+ name = ((NamedComponent) monitor.getMessageHandler()).getComponen... | [IntegrationMBeanExporter->[registerSources->[registerBeanInstance],destroy->[destroy],setBeanClassLoader->[setBeanClassLoader],stopActiveChannels->[stop],setBeanFactory->[setBeanFactory],stop->[stop],enhanceHandlerMonitor->[extractTarget],registerChannels->[registerBeanInstance],stopMessageSources->[stop],registerHand... | This method is used to enhance a message handler monitor. This function is used to create a message handler object that can be used to send a message. | Update Copyright, please |
@@ -63,6 +63,11 @@ public class AssertionArgumentOrderCheck extends AbstractMethodDetection {
MethodMatchers.create().ofTypes(ORG_JUNIT5_ASSERTIONS)
.names("assertArrayEquals", "assertEquals", "assertIterableEquals", "assertLinesMatch", "assertNotEquals", "assertNotSame", "assertSame")
.withAny... | [AssertionArgumentOrderCheck->[reportIssue->[reportIssue],isExpectedPattern->[isNewArrayWithConstants,isCollectionCreationWithConstants]]] | check if a method invocation is ambiguous. | we should also support `assertThatObject` |
@@ -79,9 +79,9 @@ namespace System.Net
}
private static WaitCallback s_invokeCB = new WaitCallback(InvokeCallback);
- private static void InvokeCallback(object o)
+ private static void InvokeCallback(object? o)
{
- ListenerAsyncResult ares = (ListenerAsyncResult)o;
... | [ListenerAsyncResult->[InvokeCallback->[InvokeCallback],Complete->[Complete]]] | Invoke callback if object is not null. | The argument is nullable but we allow null dereference later by `!`. In this case I would propose make the argument non nullable and use `!` in the `InvokeCallback` invocation (`InvokeCallback(o!)`). It will highlight problematic usage of this method. |
@@ -514,7 +514,7 @@ class FormDisplay
);
}
- /**
+ /**
* Displays errors
*
* @return string|null HTML for errors
| [FormDisplay->[getDisplay->[_validate,_displayForms],save->[_validate,_validateSelect],fixErrors->[_validate],displayErrors->[_validate,displayErrors]]] | Displays a field input for a missing node. Displays a single missing block element Displays errors for all form fields. | This change is strange |
@@ -49,7 +49,9 @@ public class FlinkUpgradeDowngrade extends AbstractUpgradeDowngrade {
return new ZeroToOneUpgradeHandler().upgrade(config, context, instantTime);
} else if (fromVersion == HoodieTableVersion.ONE && toVersion == HoodieTableVersion.TWO) {
return new OneToTwoUpgradeHandler().upgrade(co... | [FlinkUpgradeDowngrade->[run->[run],upgrade->[upgrade],downgrade->[downgrade]]] | Override to upgrade or downgrade the given configuration. | lets add a jira to track what all needs to be finally done for an upgrade-downgrade story here |
@@ -125,8 +125,9 @@ public class QueryEngine {
AggregateAnalysis aggregateAnalysis = new AggregateAnalysis();
AggregateAnalyzer aggregateAnalyzer = new
- AggregateAnalyzer(aggregateAnalysis, analysis);
- AggregateExpressionRewriter aggregateExpressionRewriter = new AggregateExpressionRewriter();
+... | [QueryEngine->[buildLogicalPlans->[info,add,clone,getLeft,getRight,buildQueryLogicalPlan],getBareQueryApplicationId->[nextLong,abs],buildPlanForStructuredOutputNode->[putTopic,getSchema,KsqlStream,getKafkaTopicName,getTimestampField,isWindowed,toString,getKeyField,KsqlTable,getTopic,getNextQueryId,buildStreams,getKsqlT... | Builds a logical plan node from the given query. missing field in the source node. | as mentioned above, should just pass `KSqlFuntionRegistry` into `QueryEngine` |
@@ -893,7 +893,8 @@ function shouldMutationBeRerendered(Ctor, m) {
const def = /** @type {!AmpElementPropDef} */ (props[name]);
if (
m.attributeName == def.attr ||
- (def.attrs && def.attrs.includes(devAssert(m.attributeName)))
+ (def.attrs && def.attrs.includes(devAssert(m.attribut... | [No CFG could be retrieved] | Checks if a mutation should be rerendered. | Ditto: `startsWith` from `string.js`. And the same question is what should we do about `attrib.name === def.attrPrefix`. |
@@ -33,6 +33,7 @@ RESOURCE_SCHEDULE_TYPE = 'schedule'
RESOURCE_USER_TYPE = 'user'
ACTION_SYNC_TYPE = 'sync'
+ACTION_AUTO_PUBLISH_TYPE = 'auto_publish'
ACTION_PUBLISH_TYPE = 'publish'
# -- public -------------------------------------------------------------------
| [parse_resource_tag->[is_resource_tag],is_resource_tag->[is_action_tag]] | Generate a pulp name - spaced tag for a given action. . | I went back and forth in my head as to whether or not I liked the auto publishes being tagged differently, but I think I do. Could we tag them twice, to mark as both a publish and an auto publish? I may be going overboard, but fundamentally it's still the same publish and if I wanted to see all publishes it should show... |
@@ -55,7 +55,8 @@ public class TaskReportSerdeTest
ImmutableMap.of(
"number", 1234
),
- "an error message"
+ "an error message",
+ false
)
);
String report1serialized = jsonMapper.writeValueAsString(report1);
| [TaskReportSerdeTest->[testSerde->[of,IngestionStatsAndErrorsTaskReportData,writeValueAsString,IngestionStatsAndErrorsTaskReport,readValue,assertEquals,buildTaskReports],getTestObjectMapper,TestUtils]] | This test serde test method. | Testing with `true` would be better because missing booleans are defaulted to false by Jackson in Druid. |
@@ -142,7 +142,10 @@ namespace Content.Client.UserInterface
foreach (var (slot, itemType) in gear.Equipment)
{
- var item = entityMan.SpawnEntity(itemType, MapCoordinates.Nullspace);
+ var itemTypeModified = itemType;
+ if (slot == Slots.INNERCLOT... | [LobbyCharacterPreviewPanel->[Dispose->[Dispose]]] | Give dummy job clothes. | I would prefer if you refactored this into a general-purpose system on `StartingGearPrototype` taking in the profile directly. We will also want other preferences like backpack type (satchel/backpack/etc) in the future that could make use of this. |
@@ -169,3 +169,14 @@ describe('base64EncodeFromBytes', () => {
.to.equal('/+8=');
});
});
+
+describe('base64EncodeFromString', () => {
+ it('should handle unicode and non-unicode strings', () => {
+ expect(base64UrlEncodeFromString('')).to.equal('');
+ expect(base64UrlEncodeFromString('helloworld')... | [No CFG could be retrieved] | Test if the number of bytes is equal to 8. | also add cases like: - ` `: spaces - ` hello word ` leading, ending spaces - ` $#!@#$%^&*() ` url unsafe symbols |
@@ -305,13 +305,13 @@ export function createAmpElementProto(win, name, implementationClass) {
this.isInViewport_ = false;
/** @private {string|null|undefined} */
- this.mediaQuery_;
+ this.mediaQuery_ = undefined;
/** @private {!SizeList|null|undefined} */
- this.sizeList_;
+ this.sizeLis... | [No CFG could be retrieved] | Creates a new instance of a specific object. Creates a new overflow element. | ~~couldnt we just assign `null` as the default then to simplify the types on these? (im ok w/ not changing these if it affects the actual code)~~ |
@@ -76,10 +76,10 @@ GLOBAL_ENV_VARS = [
# mitigate risk.
"BOOTSTRAPPED_PEX_KEY_PREFIX=daily/${TRAVIS_BUILD_NUMBER}/${TRAVIS_BUILD_ID}/pants.pex",
"NATIVE_ENGINE_SO_KEY_PREFIX=monthly/native_engine_so",
- "PYENV_PY27_VERSION=2.7.18",
- "PYENV_PY36_VERSION=3.6.10",
- "PYENV_PY37_VERSION=3.7.7",
- ... | [linux_shard->[default_stage,_linux_before_install],Stage->[all_entries->[condition]],_osx_smoke_test->[safe_append,osx_shard],osx_10_13_smoke_test->[_osx_smoke_test],build_wheels_linux->[_build_wheels_env,safe_extend,linux_shard,docker_build_travis_ci_image,docker_run_travis_ci_image,_build_wheels_command],build_wheel... | Environment variables related to the CI bucket. This function is called when deploying to S3. | Thales pointed out that it was confusing that this is only used by macOS. I agree. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.