patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -23,6 +23,7 @@ asdf_cpp_lib_path = get_generated_shared_lib('asdf-cpp')
asdf_c_lib = ctypes.CDLL(asdf_c_lib_path)
asdf_cpp_lib = ctypes.CDLL(asdf_cpp_lib_path)
+
def f(x):
added = asdf_c_lib.add_three(x)
multiplied = asdf_cpp_lib.multiply_by_three(added)
| [get_generated_shared_lib->[dirname,format,normpath,join],f->[multiply_by_three,add_three],CDLL,get_generated_shared_lib] | Add a sequence of three - bit integers and multiply by three - bit integers. | can leave this file untouched. |
@@ -40,6 +40,7 @@ import {
import * as dom from './dom';
import {setStyle, setStyles} from './style';
import {LayoutDelayMeter} from './layout-delay-meter';
+import {ResourceState} from './service/resource';
const TAG_ = 'CustomElement';
| [No CFG could be retrieved] | Imports a single element from the DOM. Provides a list of constants that represent the given template tag. | @dvoytenko PTAL as you may not like this . This passed dep-check, but I am not sure it is a good idea to import something from `resource` to `customElement` |
@@ -367,6 +367,8 @@ class CsIP:
if self.config.is_vpc():
return
+ self.fw.append(["", "front","-A INPUT -i %s -s %s/24 -p tcp -m tcp -m state --state NEW --dport 443 -j ACCEPT" % (self.dev, self.address['public_ip'])])
+
self.fw.append(["mangle", "front", "-A PREROUTING " +
... | [CsAddress->[get_guest_if->[get_interfaces],compare->[compare],get_control_if->[get_interfaces],get_guest_netmask->[get_guest_if],get_guest_ip->[get_guest_if]],CsInterface->[ip_in_subnet->[get_ip],is_added->[get_attr],get_gateway_cidr->[get_gateway]],CsIP->[get_gateway->[CsInterface,get_gateway],delete->[post_config_ch... | Add a list of commands to the FW router. Mark all network - related flags in the FW. - A filter - A input - A output - A forward - A forward - A forward. | @Spaceman1984 please refer to the rules for port 80 and port 8080 (line 419 to line 422). |
@@ -280,6 +280,9 @@ class Scheduled(Pending):
):
super().__init__(message=message, result=result, cached_inputs=cached_inputs)
self.start_time = pendulum.instance(start_time or pendulum.now("utc"))
+ run_count = prefect.context.get("task_run_count")
+ if run_count is not None:
+ ... | [Skipped->[__init__->[super]],Scheduled->[__init__->[super,now,instance]],Retrying->[__init__->[super,get]],Paused->[__init__->[super,now]],Pending->[__init__->[super]],Looped->[__init__->[super,get]],TimedOut->[__init__->[super]],Queued->[__init__->[super,now]],_MetaState->[__init__->[super]],State->[is_failed->[isins... | Initialize a NoResult object with the specified message result and start time. | This "feels" like a very fragile thing but I can't think of a better way to do it |
@@ -300,6 +300,13 @@ func resourceAwsCloudTrailUpdate(d *schema.ResourceData, meta interface{}) error
}
}
+ if d.HasChange("event_selector") {
+ log.Printf("[DEBUG] Updating event selector on CloudTrail: %s", input)
+ if err := cloudTrailSetEventSelectors(conn, d); err != nil {
+ return err
+ }
+ }
+
log.... | [StopLogging,UpdateTrail,StartLogging,Set,NonRetryableError,GetOkExists,CreateTrail,GetOk,DescribeTrails,HasChange,Errorf,SetId,RetryableError,Bool,Id,Get,GetTrailStatus,Printf,ListTags,String,DeleteTrail,Retry] | Update a cloudtrail object cloudTrailSetLogging sets logging on a CloudTrail object. | `d.HasChange` here will return true on resource creation (as `resourceAwsCloudTrailCreate` calls `resourceAwsCloudTrailUpdate`), so that means `PutEventSelectors` is called twice. You can use `!d.IsNewResource() && d.HasChange("event_selector")` to prevent that |
@@ -0,0 +1,5 @@
+<?php
+echo 'Pool StoneOs memory';
+$mempool['total'] = (snmp_get($device, 'HILLSTONE-SYSTEM-MIB::sysTotalMemory.0', '-OvQU') * 1024);
+$mempool['used'] = (snmp_get($device, 'HILLSTONE-SYSTEM-MIB::sysCurMemory.0', '-OvQU') * 1024);
+$mempool['free'] = ($mempool['total'] - $mempool['used']);
| [No CFG could be retrieved] | No Summary Found. | Please switch to using `snmp_get_multi_oid` instead of separate `snmp_get` calls. Also, pass the MIB name rather than `HILLSTONE-SYSTEM-MIB::` as before. |
@@ -361,7 +361,15 @@ public class AsynchronousUntilSuccessfulProcessingStrategy extends AbstractUntil
{
final MuleEvent persistedEvent = getUntilSuccessfulConfiguration().getObjectStore().retrieve(eventStoreKey);
final MuleEvent mutableEvent = threadSafeCopy(persistedEvent);
- processEvent... | [AsynchronousUntilSuccessfulProcessingStrategy->[retrieveAndProcessEvent->[removeFromStore],incrementProcessAttemptCountAndRescheduleOrRemoveFromStore->[scheduleForProcessing],storeEvent->[storeEvent]]] | Retrieve and process an event. | the caller of this maethod already handles exceptions. Why not handle this tehre? |
@@ -12,7 +12,7 @@ var $compileMinErr = minErr('$compile');
* of the HTTP request is empty, a `$compile` error will be thrown (the exception can be thwarted
* by setting the 2nd parameter of the function to true).
*
- * @param {string} tpl The HTTP request template URL
+ * @param {string|TrustedResourceUrl} tpl Th... | [No CFG could be retrieved] | Provides a service to retrieve the provided template and store the contents inside of the template cache. Handle a neccesary . | nit: an update on the description would be nice |
@@ -69,7 +69,7 @@ class ApplicationDataOperations:
max_last_modified_date_time: Optional[datetime.datetime] = None,
max_page_size: Optional[int] = 50,
skip_token: Optional[str] = None,
- **kwargs
+ **kwargs: Any
) -> AsyncIterable["_models.ApplicationDataListResponse"]:
... | [ApplicationDataOperations->[get->[get],delete->[delete],list_by_farmer_id->[get_next->[prepare_request]],list->[get_next->[prepare_request]]]] | Returns a paginated list of application data resources under a particular farm. Average amount of material applied during the application . Returns an iterator of all application data objects in the sequence. | the `**kwargs` -> `**kwargs: Any` changes are due to an autorest version bump |
@@ -147,9 +147,15 @@ int X509_REQ_print_ex(BIO *bp, X509_REQ *x, unsigned long nmflags,
case V_ASN1_NUMERICSTRING:
case V_ASN1_UTF8STRING:
case V_ASN1_IA5STRING:
- if (BIO_write(bp, (char *)bs->data, bs->length)
- != bs->le... | [X509_REQ_print_fp->[X509err,X509_REQ_print,BIO_new,BIO_s_file,BIO_free,BIO_set_fp],X509_REQ_print->[X509_REQ_print_ex],X509_REQ_print_ex->[X509_EXTENSION_get_data,X509_ATTRIBUTE_count,X509_REQ_get_attr_count,X509_PUBKEY_get0_param,X509_EXTENSION_get_object,X509_NAME_print_ex,EVP_PKEY_print_public,X509_REQ_get_extensio... | prints a certificate request in the BIO format read private key and attributes from BIO read all the attributes from the request and check if they can be read. Check if extension is critical or not. | RFC2985 defines the challengePassword as follows: "The challengePassword attribute type specifies a password by which an entity may request certificate revocation." RFC2985 does not define any encryption or other protection for the challengePassword while it is in the CSR. The CA when it receives the CSR will need to a... |
@@ -41,9 +41,13 @@ namespace NServiceBus.Unicast.Transport.Monitoring
}
}
-
public void Initialize()
{
+ if (receiveAddress.Queue.Length > SByte.MaxValue)
+ {
+ throw new Exception(string.Format("The queue name ('{0}') is too long (longer th... | [ReceivePerformanceDiagnostics->[DisposeManaged->[Dispose]]] | Dispose managed. | The only thing is that we are now throwing here, while before we were swallowing all exceptions! |
@@ -85,11 +85,13 @@ public class ShellInterpreter extends Interpreter {
try {
DefaultExecutor executor = new DefaultExecutor();
executor.setStreamHandler(new PumpStreamHandler(
- contextInterpreter.out, contextInterpreter.out));
+ new HtmlAnsiOutputStream(contextInterpreter.out), contex... | [ShellInterpreter->[cancel->[remove,getParagraphId,destroyProcess],open->[info,isAnyEmpty,getProperty,createSecureConfiguration],interpret->[getMessage,ByteArrayOutputStream,setStreamHandler,join,toString,info,remove,put,getProperty,ExecuteWatchdog,setWatchdog,valueOf,DefaultExecutor,debug,error,parse,InterpreterResult... | Runs the command and returns the exit value. | if we are writing out html, do we need to escape the original output which might have `<` and so on? |
@@ -7,15 +7,9 @@ if ($bg == $list_colour_a) {
}
unset($icon);
-$icon_returned = geteventicon($entry['message']);
-$icon_type = $icon_returned['icon'];
-$icon_colour = $icon_returned['colour'];
+$severity_colour = eventlog_severity($entry['severity']);
-if ($icon_type) {
- $icon = "<i class='fa $icon_type fa-lg... | [No CFG could be retrieved] | Output a list of all events. | actually sorry to be a pain, one last change. Rather than doing style='color' can you not just create styles in styles.css called log-$colourname and then tack log-darkgrey on the end of fa-lg? |
@@ -204,7 +204,7 @@ public class HelixUtils {
} else {
// We have waited for WorkflowContext to get initialized,
// so it is found null here, it must have been deleted in job cancellation process.
- log.info("WorkflowContext not found. Job is probably cancelled.");
+ log.info("Wor... | [HelixUtils->[submitJobToWorkFlow->[waitJobInitialization],createGobblinHelixCluster->[createGobblinHelixCluster]]] | Waits for a job to complete. check if timeout is expired. | Seems unrelated to the change proposed in this PR. Can we remove this? |
@@ -362,11 +362,14 @@ def transfer_properties(res: 'Resource', props: 'Inputs') -> Dict[str, Resolver]
return resolvers
-def translate_output_properties(res: 'Resource', output: Any) -> Any:
+def translate_output_properties(res: 'Resource', output: Any, typ: Optional[type] = None) -> Any:
"""
Recursi... | [serialize_property->[serialize_property,isLegalProtobufValue],unwrap_rpc_secret->[is_rpc_secret],translate_output_properties->[translate_output_properties],contains_unknowns->[impl->[impl],impl],deserialize_property->[deserialize_properties,unwrap_rpc_secret,is_rpc_secret,deserialize_property],resolve_outputs->[deseri... | Recursively rewrite keys of objects returned by the engine to conform with a naming convention specified by the. | Should we report an error if the origin is not a list? |
@@ -155,7 +155,7 @@ namespace System.Net.Http
}
}
- public override async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, bool async, CancellationToken cancellationToken)
+ public async Task<HttpResponseMessage> SendAsync(HttpRequestMessage request, bool async, Canc... | [Http3Connection->[RemoveStream->[CheckForShutdown],Exception->[CheckForShutdown],OnServerGoAway->[CheckForShutdown],Trace->[Trace],SendAsync->[SendAsync],CheckForShutdown->[Dispose],Task->[Dispose,OnServerGoAway]]] | This method checks for shutdown. Returns a task that will block if the resource is available. | Why was `SendAsync` made not-virtual? |
@@ -261,6 +261,8 @@ func NewDeleteReplacementStep(plan *Plan, old *resource.State, pendingReplace bo
func (s *DeleteStep) Op() StepOp {
if s.replacing {
return OpDeleteReplaced
+ } else if s.old.External {
+ return OpReadRemove
}
return OpDelete
}
| [Apply->[URN],Prefix->[Color],Plan,Type,Provider,URN] | Op returns the step operation that should be performed on the delete step. | If we delete an `External` replacement by replacing it with a non-`External` replacement, does that show up as a `OpDeleteReplaced` here or `OpReadRemove`? |
@@ -143,6 +143,7 @@ public class MySQLConnector extends SQLMetadataConnector
datasource.setConnectionInitSqls(ImmutableList.of("SET sql_mode='ANSI_QUOTES'"));
this.dbi = new DBI(datasource);
+ this.dbi.setSQLLog(new SQLProfileLogger());
log.info("Configured MySQL as metadata storage");
}
| [MySQLConnector->[insertOrUpdate->[withHandle->[execute],withHandle],connectorIsTransientException->[getErrorCode],tableExists->[equals,warn,isEmpty,first,ISE,startsWith],isVerifyServerCertificate,getClientCertificateKeyStorePassword,getClientCertificateKeyStoreType,forName,setDriverClassLoader,getEnabledTLSProtocols,t... | Returns the payload type of the node. | don't use `new` inside a constructor. This makes it difficult to test. Guice inject the logger instead. Should the logger be a singleton? |
@@ -3901,9 +3901,13 @@ class BatchDataset(UnaryDataset):
self._drop_remainder = ops.convert_to_tensor(
drop_remainder, dtype=dtypes.bool, name="drop_remainder")
- constant_drop_remainder = tensor_util.constant_value(self._drop_remainder)
# pylint: disable=protected-access
- if constant_drop_r... | [_OptionsDataset->[__init__->[wrapper_fn->[],merge]],from_variant->[_VariantDataset],StructuredFunctionWrapper->[output_types->[_to_legacy_output_types],output_classes->[_to_legacy_output_classes],output_shapes->[_to_legacy_output_shapes],__init__->[wrapper_fn->[_wrapper_helper],_warn_if_collections]],make_one_shot_ite... | Initialize BatchDataset with a sequence of elements. | It's tricky how sometime batch_modulo is a number and sometimes a bool. Can we call it `evenly_divisible` and set it to `self._input_dataset.__len__() % self._batch_size == 0`? |
@@ -209,6 +209,15 @@ func absent(key string) etcd.Cmp {
}
func (d *driver) createRepo(ctx context.Context, repo *pfs.Repo, description string, update bool) error {
+ // Check that the user is logged in (user doesn't need any access level to
+ // create a repo, but they must be authenticated if auth is active)
+ who... | [upsertPutFileRecords->[scratchFilePrefix],deleteFile->[inspectCommit,checkIsAuthorized],listRepo->[getAccessLevel],scratchFilePrefix->[scratchCommitPrefix],checkIsAuthorized->[initializePachConn],getTreeForFile->[scratchFilePrefix,inspectCommit,getTreeForCommit],listBranch->[checkIsAuthorized],createRepo->[initializeP... | createRepo creates a new repository create ACL for a new repository. | I don't think there's a test case for this behavior included. We should have a test for this change. |
@@ -53,7 +53,7 @@ public class HiveLocationService
}
@Override
- public LocationHandle forNewTable(SemiTransactionalHiveMetastore metastore, ConnectorSession session, String schemaName, String tableName, Optional<Path> externalLocation)
+ public LocationHandle forNewTable(SemiTransactionalHiveMetastor... | [HiveLocationService->[forNewTable->[PrestoException,pathExists,LocationHandle,HdfsContext,shouldUseTemporaryDirectory,createTemporaryPath,getTableDefaultLocation,format,orElseGet],getTableWriteInfo->[PrestoException,getWriteMode,getTargetPath,getWritePath,WriteInfo],shouldUseTemporaryDirectory->[isPresent,isS3FileSyst... | Returns a LocationHandle for a new table. | It is not the first time when "WITH NO DATA" is overlooked and causes problems. @martint Why isn't `CREATE TABLE AS ... WITH NO DATA` simply translated into `CREATE TABLE` for connector's sake? |
@@ -0,0 +1,17 @@
+/*
+ * Copyright (c) MuleSoft, Inc. All rights reserved. http://www.mulesoft.com
+ * The software in this package is published under the terms of the CPAL v1.0
+ * license, a copy of which has been included with this distribution in the
+ * LICENSE.txt file.
+ */
+package org.mule.module.oauth2.inte... | [No CFG could be retrieved] | No Summary Found. | Class name is misleading. Change to Authorization.... Or remove the class altogether. There should be a better place to put this functionality. |
@@ -328,8 +328,8 @@ class CarInterface(CarInterfaceBase):
ret.longitudinalTuning.kpV = [1.3, 1.0, 0.7]
ret.longitudinalTuning.kiBP = [0., 5., 12., 20., 27.]
ret.longitudinalTuning.kiV = [.35, .23, .20, .17, .1]
- ret.stoppingBrakeRate = 0.1 # reach stopping target smoothly
- ret.starting... | [CarInterface->[apply->[update],update->[update]]] | Get the standard parameters for a toyota car. Returns information about the n - th node in the system. Returns the total mass and tire_stiffness_factor for all components of the This function returns information about the current configuration of a single branch. | Why a factor of 4 here? Shouldn't it be 3 for toyota since that's the `ACCEL_SCALE`? |
@@ -95,9 +95,6 @@ func getTransactionType(header *types.Header, tx *types.Transaction) types.Trans
if tx.ShardID() != tx.ToShardID() && header.ShardID == tx.ShardID() {
return types.SubtractionOnly
}
- if tx.ShardID() != tx.ToShardID() && header.ShardID == tx.ToShardID() {
- return types.AdditionOnly
- }
retu... | [Process->[Header,Hash,Finalize,AddGas,Transactions,Prepare,New,GasLimit,WithCause],ShardID,Value,CreateAddress,Hash,CreateBloom,IsByzantium,MakeSigner,To,Errorf,Bytes,Finalise,ToShardID,NewEVM,NewReceipt,From,IsEIP158,IntermediateRoot,Nonce,AsMessage] | ApplyTransaction attempts to apply a transaction to the given state database and returns the receipt the C returns a new EVM environment and a context for the . | Why only this is deleted? |
@@ -228,8 +228,7 @@ namespace Kratos
{
// creating the regex pattern replacing * with ".*"
-#if defined(__GNUC__) &&( __GNUC__ < 4 || \
- (__GNUC__ == 4 && (__GNUC_MINOR__ < 9)))
+#if __cplusplus <= 199711L
KRATOS_ERROR << "This method is not compiled well. You should use a GCC 4.9 or higher"... | [RunTestSuite->[ResetAllTestCasesResults],HasTestSuite->[GetInstance],StartShowProgress->[GetInstance],NumberOfSelectedTestCases->[GetInstance],PrintInfo->[Info],UnSelectAllTestCases->[GetInstance],RunSelectedTestCases->[GetInstance],ReportFailures->[GetInstance],HasTestCase->[GetInstance],ProfileAllTestCases->[ResetAl... | Select all test cases that match the given pattern. | Is this also visual studio compatible? |
@@ -270,13 +270,11 @@ public class HiveOrcSerDeManager extends HiveSerDeManager {
*/
protected void addSchemaPropertiesHelper(Path path, HiveRegistrationUnit hiveUnit) throws IOException {
TypeInfo schema;
- if(!Strings.isNullOrEmpty(props.getProp(AvroSerdeUtils.AvroTableProperties.SCHEMA_LITERAL.getProp... | [HiveOrcSerDeManager->[getSchemaFromLatestFile->[getSchemaFromLatestFile],addSchemaPropertiesHelper->[getSchemaFromLatestFile]]] | Adds schema properties to HiveRegistrationUnit. | this line seems too long? |
@@ -383,9 +383,13 @@ void BattlegroundAV::PostUpdateImpl(uint32 diff)
for (uint8 i = 0; i <= 1; i++) //0=alliance, 1=horde
{
if (!m_CaptainAlive[i])
+ {
continue;
+ }
if (m_CaptainBuffTimer[i] > diff)
+ {
m_Ca... | [EventPlayerDefendsPoint->[UpdatePlayerScore,GetNodeThroughObject,PopulateNode],EventPlayerAssaultsPoint->[DePopulateNode,UpdatePlayerScore,GetNodeThroughObject],ResetBGSubclass->[InitNode],EventPlayerDestroyedPoint->[UpdateScore],resize->[resize],ChangeMineOwner->[AddAVCreature],PostUpdateImpl->[UpdateScore],SetupBatt... | This method is called after a update of the battleground. if we have a timer of 0 cause we need to update the mines timer. | Should use creature_text instead |
@@ -261,7 +261,8 @@ public class IPC {
static String getTmpDir() {
String tmpDir = getTempDirImpl();
if (null == tmpDir) {
- tmpDir = com.ibm.oti.vm.VM.getVMLangAccess().internalGetProperties().getProperty("java.io.tmpdir"); //$NON-NLS-1$
+ IPC.logMessage("Could not get system temporary directory. Trying "+... | [IPC->[printMessageWithHeader->[tracepoint],printLogMessage->[printMessageWithHeader],logMessage->[printMessageWithHeader],syncObject]] | This method returns the path to the temporary directory. | will this default to /tmp if not set? |
@@ -42,7 +42,10 @@ type OpStep interface {
// TransferLeader is an OpStep that transfers a region's leader.
type TransferLeader struct {
+ // Compatible with old TiKV's TransferLeader.
FromStore, ToStore uint64
+ // Multi-target transfer leader.
+ ToStores []uint64
}
// ConfVerChanged returns the delta value ... | [ConfVerChanged->[ConfVerChanged],IsFinish->[IsFinish,String],String->[String]] | ConfVerChanged returns 0 if the conf version has changed. | Perhaps, we can remove ToStore? |
@@ -124,9 +124,9 @@ int RAND_load_file(const char *file, long bytes)
for ( ; ; ) {
if (bytes > 0)
- n = (bytes < RAND_FILE_SIZE) ? (int)bytes : RAND_FILE_SIZE;
+ n = (bytes <= RAND_LOAD_BUF_SIZE) ? (int)bytes : RAND_BUF_SIZE;
else
- n = RAND_FILE_SIZE;
+ ... | [RAND_load_file->[fstat,ferror,OPENSSL_cleanse,openssl_fopen,setbuf,fclose,clearerr,S_ISREG,RANDerr,RAND_add,fread,fileno,ERR_add_error_data],RAND_write_file->[OPENSSL_cleanse,RAND_priv_bytes,fwrite,openssl_fopen,fclose,S_ISREG,chmod,RANDerr,fdopen,open,stat,ERR_add_error_data],char->[strcat,strlen,ossl_safe_getenv,Get... | RAND_load_file - load file with bytes Random file read. | did you mean `? (int)bytes : RAND_BUF_SIZE;` ? |
@@ -0,0 +1,14 @@
+from django.conf import settings
+from django.db import models
+
+
+class BaseNote(models.Model):
+ user = models.ForeignKey(
+ settings.AUTH_USER_MODEL, blank=True, null=True,
+ on_delete=models.SET_NULL)
+ date = models.DateTimeField(db_index=True, auto_now_add=True)
+ content... | [No CFG could be retrieved] | No Summary Found. | This model has to be abstract. We don't want to save instances of `BaseNote` in the database, but only the derived models such as `OrderNote` or `CustomerNote`. |
@@ -27,6 +27,7 @@ import games.strategy.debug.ClientLogger;
import games.strategy.triplea.ui.screen.TileManager;
import games.strategy.ui.Util;
import games.strategy.util.PointFileReaderWriter;
+import javax.swing.filechooser.FileFilter;
/**
* For taking a folder of basetiles and putting them back together into... | [TileImageReconstructor->[handleCommandLineArgs->[getValue]]] | This class is used to reconstruct a tile image from a base image. This method is called when a new map image is reconstructed from a folder full of tiles. | I think this is the Checkstyle violation causing the build break: "Import statement for 'javax.swing.filechooser.FileFilter' is in the wrong order. Should be in the 'STANDARD_JAVA_PACKAGE' group, expecting not assigned imports on this line." |
@@ -832,12 +832,14 @@ namespace System.Windows.Forms
IAccessible? UiaCore.ILegacyIAccessibleProvider.GetIAccessible() => AsIAccessible(this);
- object?[] UiaCore.ILegacyIAccessibleProvider.GetSelection()
+ object[]? UiaCore.ILegacyIAccessibleProvider.GetSelection()
{
- ret... | [AccessibleObject->[GetItem->[GetItem],ScrollIntoView->[ScrollIntoView],GetPropertyValue->[GetPropertyValue],GetSelected->[GetChild,GetChildCount],accDoDefaultAction->[accDoDefaultAction,DoDefaultAction],get_accRole->[GetAccessibleChild,get_accRole],get_accState->[GetAccessibleChild],get_accDescription->[get_accDescrip... | IAccessible? IAccessible? IAccessible? IAccessible? IAccessible? IAccessible?. | This one worries me- it was clearly `object?[]` historically. That may have been wrong, but I would want the functional change taken out of this so we discuss and track for regression purposes if we take this change. |
@@ -75,6 +75,14 @@ class CreatePex:
input_files_digest: Optional[Digest] = None
+@dataclass(frozen=True)
+class CreatePexFromTargetClosure:
+ """Represents a request to create a PEX from the closure of a set of targets."""
+ build_file_addresses: BuildFileAddresses
+ output_filename: str
+ entry_point: Optio... | [CreatePex->[PexInterpreterConstraints,PexRequirements],PexInterpreterConstraints->[create_from_adaptors->[PexInterpreterConstraints]],PexRequirements->[create_from_adaptors->[PexRequirements]],create_pex->[generate_pex_arg_list,Pex]] | Creates a PEX from a given list of constraints. Adds the necessary arguments to the if command line. | Why plural? It feels like I'd expect the structure of "stuff that should go in a single pex" to be fully represented in BUILD files and modelled as dependencies? What's your use-case here? |
@@ -218,7 +218,10 @@ class KubernetesAgent(Agent):
"""
Check status of jobs created by this agent, delete completed jobs and failed containers.
"""
- self.manage_jobs()
+ try:
+ self.manage_jobs()
+ except Exception:
+ self.logger.error("Error while ... | [KubernetesAgent->[heartbeat->[manage_jobs],generate_job_spec_from_run_config->[_get_or_create]],KubernetesAgent] | Check status of jobs created by this agent delete completed jobs and failed containers. | I did not know about `exc_info` -- that's handy! |
@@ -320,6 +320,14 @@ frappe.views.ListView = class ListView extends frappe.views.BaseList {
sort_by: this.sort_selector.sort_by,
sort_order: this.sort_selector.sort_order
});
+
+ if(frappe.route_options) {
+ let filters = this.parse_filters_from_route_options();
+ if(filters.length && !this.filter_area.... | [No CFG could be retrieved] | Get the args for the view. Renders count and tags. | `exists` method can only check if _a_ filter exists or not, it cannot tell whether an array of filter exists, and `filters` here is an array of filters. |
@@ -9,11 +9,11 @@ import (
// ValidateRunOnceDurationConfig validates the RunOnceDuration plugin configuration
func ValidateRunOnceDurationConfig(config *api.RunOnceDurationConfig) field.ErrorList {
allErrs := field.ErrorList{}
- if config == nil || config.ActiveDeadlineSecondsOverride == nil {
+ if config == nil |... | [Invalid,NewPath] | ValidateRunOnceDurationConfig validates a RunOnceDuration config. | field name should still be activeDeadlineSecondsOverride |
@@ -711,7 +711,7 @@ if ($dirins && $action == 'initobject' && $module && GETPOST('createtablearray',
$notnull = ($obj->Null == 'YES' ? 0 : 1);
if ($fieldname == 'fk_user_modif') $notnull = -1;
// label
- $label = preg_replace('/_/', ' ', ucfirst($fieldname));
+ $label = $fieldname;
if ($fieldname ==... | [getMessage,getProperties,getTriggersList,formconfirm,fetch_object,getFile,lasterrno,getVersion,DDLDropTable,select_language,getDesc,getDefaultProperties,generateDoc,getChangeLog,load,Create,transnoentities,loadLangs,getDescLong,close,getFullName,textwithpicto,query,getName,DDLDescTable,trans,getLine] | Generate a string representation of a single node in the system. DateValidation - DateValidation. | I think the preg_replace was introduce to be compatible with old field name likes 'date_creation' to have a label that looks good for such cases. In which cas did this annoy you ? |
@@ -886,7 +886,7 @@ namespace MueLuTests {
RCP<RepartitionHeuristicFactory> RepHeuFact = Teuchos::rcp(new RepartitionHeuristicFactory);
RepHeuFact->SetFactory("A",AcFact);//MueLu::NoFactory::getRCP());
RepHeuFact->SetParameter("repartition: start level",Teuchos::ParameterEntry(0));
- RepHeuFact->SetParameter(... | [MUELU_TESTING_LIMIT_SCOPE->[MUELU_TESTING_LIMIT_SCOPE]] | TEUCHOS_UNIT_TEST_TEMPLATE_4_DECL |TEUCH Generate problem matrices for all partitions RCP - > VectorFactory - > Build - > RCP - > VectorFactory - This function will create a new Hierarchy object and add it to the Hierarchy object. | Why did this need to be changed? |
@@ -23,6 +23,7 @@ import UserCard from 'components/user-card'
import TransactionEvent from 'pages/purchases/transaction-event'
import { getListing } from 'utils/listing'
+import { offerStatusToStep } from '../utils/offer'
import origin from '../services/origin'
| [No CFG could be retrieved] | Create a component that will display a message with the order and purchase status. A description of the methods that are defined on the Purchases. | Pro Tip: this parent directory path reference (`../`) is not necessary. |
@@ -34,11 +34,14 @@ import org.apache.hadoop.ozone.container.keyvalue.KeyValueContainerData;
import org.apache.hadoop.ozone.container.common.volume.HddsVolume;
import org.apache.hadoop.ozone.container.common.volume.VolumeIOStats;
import org.apache.hadoop.ozone.container.keyvalue.helpers.ChunkUtils;
+import org.apach... | [FilePerChunkStrategy->[getChunkFile->[getChunkFile],deleteChunks->[deleteChunk],deleteChunk->[checkLayoutVersion],readChunk->[checkLayoutVersion],writeChunk->[checkLayoutVersion]]] | Reads and imports a single node node. This class is used to perform file per chunk operations. | Nit: Can we please avoid this dependency? I think it's better to use `StringUtils` from Apache Commons Lang, or even simply check explicitly both for null and empty string. |
@@ -73,7 +73,9 @@ public class RetryHttpRequestInitializer implements HttpRequestInitializer {
if (willRetry) {
LOG.debug("Request failed with IOException, will retry: {}", request.getUrl());
} else {
- LOG.warn("Request failed with IOException, will NOT retry: {}", request.getUrl());
+ ... | [RetryHttpRequestInitializer->[LoggingHttpBackoffUnsuccessfulResponseHandler->[handleResponse->[handleResponse]],initialize->[LoggingHttpBackoffUnsuccessfulResponseHandler,LoggingHttpBackOffIOExceptionHandler],LoggingHttpBackOffIOExceptionHandler->[handleIOException->[handleIOException]]]] | Override handleIOException to log a warning if the request failed with an IOException. | It would be good if we could log how many times we retried in the low level loop here (maybe not practical for this PR). Also, the wording I would put is that the "caller is responsible for retry" which tells the user that someone else is responsible which automatically moves them up the stack. |
@@ -145,7 +145,12 @@ class _CppInfo(object):
@property
def build_modules_paths(self):
if self._build_modules_paths is None:
- if isinstance(self.build_modules, list): # FIXME: This should be just a plain dict
+ # FIXME: This should be just a plain dict
+ if isinstanc... | [CppInfo->[__getattr__->[_get_cpp_info->[_CppInfo,append],_get_cpp_info],_raise_incorrect_components_definition->[_check_components_requires_instersection],__init__->[append,Component,DefaultOrderedDict]],Component->[__init__->[append]],DepCppInfo->[defines->[_aggregated_values],__getattr__->[_get_cpp_info->[],__getatt... | Return list of absolute paths of build modules. | Shall I open a different PR with this change? I'm not sure if we want to cover this scenario (maybe not), but the current error is very ugly... I preferred to implement it than to raise. wdyt? |
@@ -587,8 +587,12 @@ namespace Js
});
if (FAILED(hr))
{
- JavascriptError *error = scriptContext->GetLibrary()->CreateError();
- JavascriptError::SetErrorMessageProperties(error, hr, _u("fetch import module failed"), scriptContext);
+ i... | [No CFG could be retrieved] | This function is called by the ModuleRecordSet when it finds a module record that can be Check if the script context has been initialized. | when the error is not nullptr? |
@@ -169,8 +169,8 @@ mutation voucherCreate(
def test_create_voucher(staff_api_client, permission_manage_discounts):
- start_date = date(day=1, month=1, year=2018)
- end_date = date(day=1, month=1, year=2019)
+ start_date = timezone.now() - timedelta(days=365)
+ end_date = timezone.now() + timedelta(da... | [test_voucher_add_no_catalogues->[exists,post_graphql,to_global_id,get_graphql_content],voucher_countries->[save],test_query_vouchers_with_filter_discount_type->[Voucher,len,post_graphql,get_graphql_content,bulk_create],test_create_voucher->[upper,isoformat,post_graphql,get_graphql_content,date],test_sale_add_no_catalo... | Test create voucher. | `start_date` and `end_date` are almost equal. Previously, the difference was 1 year. Same commet for the rest of tests |
@@ -19,8 +19,6 @@ namespace HttpStress
{
public class StressClient : IDisposable
{
- private const string UNENCRYPTED_HTTP2_ENV_VAR = "DOTNET_SYSTEM_NET_HTTP_SOCKETSHTTPHANDLER_HTTP2UNENCRYPTEDSUPPORT";
-
private readonly (string name, Func<RequestContext, Task> operation)[] _clientOperations... | [StressClient->[Stop->[Stop],Start->[Start],StructuralEqualityComparer->[Equals->[Equals,StructuralEqualityComparer],GetHashCode->[GetHashCode,StructuralEqualityComparer]],Dispose->[Stop],Task->[Start]]] | Creates a new instance of the HTTPStress class. This method is called by the StressClient when it is not running. | This is being removed because #987 got implemented right? |
@@ -92,6 +92,18 @@ describe TopicView do
expect(tv.filtered_post_ids).to match_array([post.id, post2.id, post3.id, post4.id])
end
end
+
+ describe "when a staff user is ignored" do
+ let!(:admin) { Fabricate(:user, admin: true) }
+ let!(:admin_ignored_user) { Fa... | [topic_view_near->[id,new,post_number],create_topic_view->[id,new],new,let,ignore_user_enabled,describe,match_array,update_attributes,slug,freeze_time,ago,stub,end_with,subject,eql,chunk_size,trash!,it,name,topic_page_title_includes_category,should,recent_posts,to,update_column,print_chunk_size,before,save!,topic_view_... | includes some basic checks on the post object with a few sample posts it can find the best responses. | You don't need to test the size if you're testing the whole array |
@@ -213,10 +213,13 @@ public class MavenBndRepository extends BaseRepository
}
}
}
- if (!binaryArchive.isSnapshot())
+ if (configuration.noupdateOnRelease() == false && !binaryArchive.isSnapshot())
index.add(binaryArchive);
}
return result;
+ } catch (Exception e) {
+ result.fa... | [MavenBndRepository->[tooltip->[getName,toString],findProviders->[init,findProviders],getDescriptor->[getDescriptor],versions->[list],title->[getBundleDescriptor,getName,isLocal,toString],init->[getName],refresh->[refresh],get->[get],doSearchMaven->[get],getMapFromQuery->[put],toPom->[init],getBundleDescriptor->[getDes... | This method is used to put a binary into the repository. This method is called to release a POM. Get the source from the binary archive. | Can't this just be `!configuration.noupdateOnRelease()` instead of the `== false`? |
@@ -133,7 +133,7 @@ require('react-styl')(`
cursor: pointer
.main-pic
- padding-top: 66.6%
+ padding-top: 75%
background-size: cover
background-repeat: no-repeat
background-position: center
| [No CFG could be retrieved] | The listing - cards module Displays a list of missing - variable values. | I have to update #2630 to keep this same ratio for those CTA listing cards before it gets merged. |
@@ -46,9 +46,13 @@ let inProgress = 0;
const MAX_PARALLEL_CLOSURE_INVOCATIONS =
parseInt(argv.closure_concurrency, 10) || cpus().length;
-// Compiles AMP with the closure compiler. This is intended only for
-// production use. During development we intend to continue using
-// babel, as it has much faster increme... | [No CFG could be retrieved] | The main entry point for the task. Resolves a promise that is resolved when the next process in the queue is finished. | Pretty sure these are (in order): `string`, `string`, `string`, `Object`, and `Object`. (You'll need to figure out the shapes of the two objects.) |
@@ -147,7 +147,11 @@ namespace Microsoft.Xna.Framework
/// <returns>Distance between the two values.</returns>
public static float Distance(float value1, float value2)
{
- return Math.Abs(value1 - value2);
+ return
+#if AGENT
+ (float)
+#endif
+ ... | [MathHelper->[SmoothStep->[Hermite,Clamp],Max->[Max],Min->[Min]]] | Distance - 1 if both values are equal or negative if both values are. | You should be able to just put the float cast in there for all platforms. Just leave a note that the redundant cast is there for AGENT support. That is better than an #if. |
@@ -61,6 +61,12 @@ class CrfTagger(Model):
Used to initialize the model parameters.
regularizer : ``RegularizerApplicator``, optional (default=``None``)
If provided, will be used to calculate the regularization penalty during training.
+ top_k : ``int``, optional (default=``None``)
+ If... | [CrfTagger->[decode->[get_token_from_index],forward->[_feedforward,text_field_embedder,tag_projection_layer,metric,_f1_metric,viterbi_tags,get_text_field_mask,crf,encoder,float,enumerate,values,dropout],__init__->[get_index_to_token_vocabulary,SpanBasedF1Measure,CategoricalAccuracy,ConditionalRandomField,get_input_dim,... | Initialize a sequence tag model from a sequence of tags. This method converts a sequence of tags into a vocabulary. | The default here should match the constructor below. |
@@ -154,6 +154,7 @@ class Qt(Package):
# Dependencies, then variant- and version-specific dependencies
depends_on("icu4c")
depends_on("jpeg")
+ depends_on('gmake')
depends_on("libmng")
depends_on("libtiff")
depends_on("libxml2")
| [Qt->[common_config_args->[use_spack_dep,get_mkspec],configure->[configure],patch->[get_mkspec,conf]]] | Patches a QTI - QOS system. Creates a new object with all of the required dependencies. | Should this have a version constraint? Qt has always worked for me with BSD `make`. |
@@ -101,8 +101,11 @@ public class TechAbilityAttachment extends DefaultAttachment {
private IntegerMap<UnitType> m_defenseRollsBonus = new IntegerMap<>();
private IntegerMap<UnitType> m_bombingBonus = new IntegerMap<>();
+ private final String mapName;
+
public TechAbilityAttachment(final String name, final... | [TechAbilityAttachment->[getRocketDistance->[getRocketDistance,get],getAirAttackBonus->[get],getAttackRollsBonus->[get],getAirborneTargettedByAA->[get,getAirborneTargettedByAA],getAttackBonus->[get],getRadarBonus->[get],getAllowAirborneForces->[get,getAirborneForces],getRepairDiscount->[get,getRepairDiscount],getAirbor... | The TechAbilityAttachment class. Check if the unit is valid and if so add it to the attack bonus. | Is this field needed? Looks like some of the exception calls pass data and others pass mapName? |
@@ -258,7 +258,7 @@ namespace System.Collections
public Hashtable(int capacity, float loadFactor)
{
if (capacity < 0)
- throw new ArgumentOutOfRangeException(nameof(capacity), SR.ArgumentOutOfRange_NeedNonNegNum);
+ ThrowHelper.ThrowArgumentOutOfRangeExceptio... | [Hashtable->[HashtableDebugView->[ToKeyValuePairsArray],rehash->[UpdateVersion,rehash],KeyCollection->[CopyTo->[CopyKeys]],CopyTo->[CopyEntries],SyncHashtable->[Clear->[Clear],Clone->[Clone],ContainsValue->[ContainsValue],CopyTo->[CopyTo],ContainsKey->[ContainsKey],Add->[Add],ToKeyValuePairsArray->[ToKeyValuePairsArray... | Construct a new hashtable with the given initial capacity and load factor. Creates a new Hashtable with the specified capacity and load factor. | What's wrong with keeping `nameof` as the argument? |
@@ -10,7 +10,7 @@ import org.kohsuke.accmod.restrictions.NoExternalUse;
*
* @author Kohsuke Kawaguchi
*/
-@Extension
+@Extension @Symbol("about")
public class AboutJenkins extends ManagementLink {
@Override
public String getIconFileName() {
| [AboutJenkins->[getDescription->[AboutJenkins_Description],getDisplayName->[AboutJenkins_DisplayName],getLicensesURL->[getResource]]] | Returns the help icon file name. | It is pointless to be applying symbols to random extensions like this. We only care about `Descriptor`s. So polluting the codebase with symbols with no known use. |
@@ -74,10 +74,10 @@ public class ResourceNameEndpointURIBuilder extends AbstractEndpointURIBuilder
{
userInfo = credentials;
}
-
- int x = address.indexOf(":", y);
- if (x > -1)
+
+ if (address.substring(y).matches(REGEX_SEPARATOR))
{
+ int... | [ResourceNameEndpointURIBuilder->[setEndpoint->[getHost,getUserInfo,equals,indexOf,substring,setProperty,length,getPath,getAuthority],getLog]] | Method to set the endpoint. | use the group obtained with the regex instead of using substring |
@@ -608,7 +608,8 @@ class Resource:
props: Optional['Inputs'] = None,
opts: Optional[ResourceOptions] = None,
remote: bool = False,
- dependency: bool = False) -> None:
+ dependency: bool = False,
+ urn: Optional[str] ... | [ResourceOptions->[merge->[ResourceOptions]],CustomResource->[__init__->[__init__]],ProviderResource->[__init__->[__init__]],Resource->[_convert_providers->[_convert_providers],__init__->[ResourceTransformationArgs,ResourceOptions,inherited_child_alias,collapse_alias_to_urn]],ComponentResource->[__init__->[__init__]]] | Initializes a new object with the specified base key. In the case of a parent resource the parent is not the parent. The base class method for the we class. | I think I'll need to move this into `ResourceOptions`. |
@@ -138,6 +138,13 @@ func NewNS() (ns.NetNS, error) {
if err != nil {
err = fmt.Errorf("failed to bind mount ns at %s: %v", nsPath, err)
}
+
+ // mount sysfs so the process running in the container can see the
+ // correct /sys/class/net entries
+ err = unix.Mount("sysfs", "/sys", "sysfs", unix.MS_RDONLY, ... | [RemoveAll,Path,Close,GetNS,HasPrefix,Set,Done,Add,Unshare,LockOSThread,Errorf,Wait,Create,Join,Mount,Gettid,Remove,Read,MkdirAll,Sprintf,Unmount,Getpid] | UnmountNS unmounts the current thread s netns object and releases the lock on the getCurrentThreadNetNSPath returns the net namespace path of the current thread. | The goroutine is running in a new network namespace but it is sharing the mount namespace with the host. How is the new mount visible from the container? |
@@ -122,6 +122,10 @@ class RemovePath(NameValueModifier):
if x != os.path.normpath(self.value)]
os.environ[self.name] = self.separator.join(directories)
+class PushEnv(NameValueModifier):
+
+ def execute(self):
+ pass
class EnvironmentModifications(object):
"""Keeps ... | [EnvironmentModifications->[append_path->[AppendPath,_get_outside_caller_attributes],append_flags->[AppendFlagsEnv,_get_outside_caller_attributes],from_sourcing_file->[set_intersection->[set],return_separator_if_any,append_path,prepend_path,remove_path,EnvironmentModifications,set,unset,extend,set_intersection],set_pat... | Execute the in the environment. | I don't think `PushEnv` belongs to the commands here, as it is specific to `lmod` (while `EnvironmentModifications` represents a *generic* list of commands to modify the environment). |
@@ -130,12 +130,12 @@ Rails.application.configure do
config.action_mailer.perform_deliveries = true
config.action_mailer.default_url_options = { host: protocol + ENV["APP_DOMAIN"].to_s }
ActionMailer::Base.smtp_settings = {
- address: "smtp.sendgrid.net",
- port: "587",
- authentication: :plain,
- ... | [perform_deliveries,new,formatter,log_tags,compile,headers,consider_all_requests_local,asset_host,log_formatter,cache_classes,use,deprecation,disallowed_deprecation,dump_schema_after_migration,logger,require,disallowed_deprecation_warnings,fallbacks,to_s,enabled,to_i,force_ssl,delivery_method,eager_load,default_url_opt... | The configuration for a single object. This middleware is used to set the # timestamps for the primary node. | I purposely allow the domain to have a fallback to minimize the configuration we need to do. On a different note, Mailgun's free tier doesn't support "custom" domain" and provides you a domain name consist of a random hash. I'm not fully clear how that works and and how other SMTP providers could be different, so provi... |
@@ -0,0 +1,18 @@
+<% unless @grade_entry_forms.nil? && @assignments.nil? %>
+ <div class='assignment_summary'>
+ <h2 class='title'>
+ <%= link_to t(:course_summary_link,
+ short_id: 'summary',
+ description: 'Course Summary'),
+ cours... | [No CFG could be retrieved] | No Summary Found. | Always use 2 spaces for indentation (fix the other files too). Also each file should end with exactly one blank line. |
@@ -312,7 +312,7 @@ function wpseo_init() {
$GLOBALS['wpseo_sitemaps'] = new WPSEO_Sitemaps();
}
- if ( ! defined( 'DOING_AJAX' ) || ! DOING_AJAX ) {
+ if ( ! wp_doing_ajax() ) {
require_once WPSEO_PATH . 'inc/wpseo-non-ajax-functions.php';
}
| [_wpseo_activate->[install,manage_notification,schedule_flush,add,activate_hooks],_wpseo_deactivate->[remove],wpseo_init->[register_hooks,load],wpseo_init_rest_api->[register,initialize],wpseo_network_activate_deactivate->[prepare,get_col],register_hooks] | Initializes the WordPress SEO plugin Register the core integration. | Worth noting that when using `!` the behavior is slightly different because previously it was an OR and now it's an AND. For example, try to add the filter `add_filter( 'wp_doing_ajax', '__return_true' );` before this condition and see the different behavior with the previous and new syntax (e.g. observe the toolbar me... |
@@ -375,11 +375,15 @@ class FakeQAT2MkldnnINT8PerfPass(object):
if op.name() in self._fake_quantize_types:
op_out = graph._find_node_by_name(op.outputs,
op.output("Out")[0])
- self._remove_fake_quantize(graph, op)
+ ... | [FakeQAT2MkldnnINT8PerfPass->[_dequantize_conv_weights->[_load_param,_restore_var],_apply_pass->[_remove_unused_var_nodes,apply],_dequantize_mul_weights->[_load_param,_restore_var],_gather_scales->[_convert_scale2tensor],_compute_weight_scales->[_compute_var_scales->[_load_param,_convert_scale2tensor],_compute_var_scal... | Remove all nodes in the graph that have fake quantize. | What is this ` if next_op.name() not in self._mul_ops` for? |
@@ -7,5 +7,8 @@ READTHIS_POOL = ConnectionPool.new(size: 10) do
end
REDIS_POOL = ConnectionPool.new(size: 10) do
- Redis.new(url: IdentityConfig.store.redis_url)
+ Redis::Namespace.new(
+ 'redis-pool',
+ redis: Redis.new(url: IdentityConfig.store.redis_url),
+ )
end
| [to_i,new,redis_url] | Get the list of unique id s for the user. | today this is only used in the (unlaunched in prod) RISC rate limiting, and that data is keys that expire every ~60 seconds, so there is no risk of data loss updating this now |
@@ -4346,6 +4346,17 @@ out:
return rc;
}
+/* Wrapper function, only permit oid as a input parameter and return if it has data */
+int
+dfs_move(dfs_t *dfs, dfs_obj_t *parent, char *name, dfs_obj_t *new_parent,
+ char *new_name, daos_obj_id_t *oid)
+{
+ if (oid && (oid->lo || oid->hi))
+ return EINVAL;
+
+ return... | [dfs_mount_root_cont->[dfs_cont_create,dfs_mount],dfs_umount_root_cont->[dfs_umount],dfs_obj_local2global->[dfs_get_chunk_size],dfs_chmod->[dfs_release],dfs_access->[dfs_release]] | Move an object from one parent to another. fetch_entry fetches the entry from the index and checks if the new entry is a directory remove entry in new parent object insert new entry in new parent object copy extended attributes from parent to new parent D - A - B B - C C - D A - D A - F A D - A - D - F F - I O F F - I ... | same issue as remove. this check breaks bwd compatibility IMO and should not be here. a dfs_move_internal + flag should handle the 2 variations of the function. |
@@ -56,15 +56,9 @@ class MeshSolverLaplacian(mesh_solver_base.MeshSolverBase):
self.neighbour_search = FindNodalNeighboursProcess(model_part, number_of_avg_elems, number_of_avg_nodes)
# definition of the solvers
- tol = 1e-8
- max_it = 1000
- verbosity = 1
- m = 100
- ... | [CreateSolver->[MeshSolverLaplacian],MeshSolverLaplacian->[Initialize->[,print,LaplacianMeshMovingStrategy],__init__->[FindNodalNeighboursProcess,custom_settings,AMGCLSolver,ValidateAndAssignDefaults,Parameters]],CheckForPreviousImport] | Initialize the object with the parameters necessary to run the Laplacian mesh algorithm. | i think it is called "new_linear_solver_factory". Indeed it is a todo (mine) to replace the old one by the new one ... |
@@ -1229,6 +1229,13 @@ class DocumentationNormalizerTest extends TestCase
'required' => false,
'strategy' => 'partial',
]]),
+ 'f3' => new DummyFilter(['toto' => [
+ 'property' => 'name',
+ 'type' => 'array',
+ 'is_co... | [DocumentationNormalizerTest->[testNormalizeWithNormalizationAndDenormalizationGroups->[normalize,willReturn,prophesize,reveal,assertEquals],testFilters->[reveal,normalizeWithFilters,shouldBeCalled,prophesize],testNormalizeWithSubResource->[normalize,willReturn,prophesize,add,reveal,assertEquals],testNormalizeWithPrope... | This method checks if there are filters in the filter locator. | Not a fault of this PR, but `->shouldBeCalled()` should only be used when we actually want to check that a method is called. If the intention is only to mock the return value of the method, `->willReturn(...)` should suffice. |
@@ -450,7 +450,7 @@ namespace HttpStress
}
- private class StructuralEqualityComparer<T> : IEqualityComparer<T> where T : IStructuralEquatable
+ private class StructuralEqualityComparer<T> : IEqualityComparer<T> where T : class, IStructuralEquatable
{
public bool Equals(... | [StressClient->[Stop->[Stop],Start->[Start],StructuralEqualityComparer->[Equals->[Equals,StructuralEqualityComparer],GetHashCode->[GetHashCode,StructuralEqualityComparer]],Dispose->[Stop],Task->[Start]]] | Compares two objects for equality. | I assume you were getting a warning about GetHashCode? Instead of adding a class constraint, it would have [DisallowNull] on the T argument to GetHashCode. |
@@ -63,11 +63,15 @@ public class SchedulerFactory implements SchedulerListener {
}
public Scheduler createOrGetFIFOScheduler(String name) {
+ return createOrGetFIFOScheduler(name, this.executor);
+ }
+
+ public Scheduler createOrGetFIFOScheduler(String name, ExecutorService executor) {
synchronized (s... | [SchedulerFactory->[singleton->[SchedulerFactory]]] | Create or get a FIFO scheduler. | This would affect all the other interpreters. Since this is only for spark interpreter, we can create a specific scheduler for spark interpreter, and not change the existing `createOrGetFIFOScheduler`, `createOrGetParallelScheduler` and `createOrGetRemoteScheduler` |
@@ -240,8 +240,7 @@ namespace Microsoft.Xna.Framework.Content.Pipeline.Audio
using (var encoder = new MediaFoundationEncoder (mediaType)) {
encoder.Encode (targetFileName, reader);
}
-#else
- if (!ConvertAudio.Convert(fileName, targetFileName, AudioFormatType.MPEG4AAC, MonoMac.AudioToolbox.Aud... | [AudioContent->[ConvertFormat->[ConvertWav,QualityToBitRate,QualityToSampleRate],Dispose->[Dispose],Read->[Read]]] | Converts the audio to a specific format. This function is used to convert a single audio file to a specific format. | Something looks to have gone wrong here. The first part of the line has been removed. |
@@ -15,6 +15,9 @@ package statistics
import (
"fmt"
+
+ "github.com/tikv/pd/server/core"
+
)
const (
| [Sprintf] | storeTag returns the name of the given tag in the system. | remove the empty line |
@@ -22,6 +22,9 @@
@if(\LibreNMS\Authentication\LegacyAuth::getType() == 'mysql')
<th data-column-id="enabled" data-formatter="enabled">@lang('Enabled')</th>
@endif
+ @if(\LibreNMS\Config::get('twofactor'))
+ <th data-co... | [No CFG could be retrieved] | Displays a list of users that have a unique identifier. section 1. section 2. section 3. section 4. section 5. section 5. | You can just use `@config('twofactor')` and `@endconfig` (They are custom directives LibreNMS has) |
@@ -122,7 +122,7 @@ public class LdapPasswordPolicyEnforcer extends AbstractPasswordPolicyEnforcer {
(YEARS_FROM_1601_1970 * 365 + YEARS_FROM_1601_1970 / 4 - 3) * 24 * 60 * 60;
/** The list of valid scope values. */
- private static final int[] VALID_SCOPE_VALUES = new int[] { SearchControls.OBJE... | [LdapPasswordPolicyEnforcer->[getExpirationDateToUse->[formatDateByPattern,convertDateToActiveDirectoryFormat],getNumberOfDaysToPasswordExpirationDate->[getNoWarnAttributeResult,getUserId,getValidDaysResult,getDateResult,getWarnDaysResult],getResultsFromLdap->[mapFromAttributes->[setWarnDaysResult,setValidDaysResult,se... | The default time zone used in calculations. The search base to search for the user under. | Minor fix here, removed the space to make the IDE happy! |
@@ -307,7 +307,8 @@ class RtEpochs(_BaseEpochs):
"""
verbose = 'ERROR'
sfreq = self.info['sfreq']
- n_samp = len(self._raw_times)
+ n_samp = len(self._raw_times)
+ prev_samp = 5 # how many trigger samples to check from previous buffer
# relative start and st... | [RtEpochs->[_get_data->[append,list,array],_process_raw_buffer->[round,list,int,sort,append,_find_events,extend,len,atleast_2d,values,where,RuntimeError,zip,_append_epoch_to_queue,abs],events->[array],start->[start_receive_thread,register_receive_callback],stop->[stop_receive_thread,unregister_receive_callback],__repr_... | Process raw buffer and find missing missing events. if event_samp < = last_samp and tmax_samp < =. | So, basically this should be `int(min_duration * sfreq) - 1` I think? In the example you gave: [... 0 0 0 0 1 1][1 1 1 1 0 0 0 ... ] if your `min_duration` is `5 / sfreq`, then you need at least 5 samples for it to be considered an event. So, if add 4 samples from the previous buffer, you are good. |
@@ -837,7 +837,8 @@ def _generic_array(context, builder, shape, dtype, symbol_name, addrspace,
lmod = builder.module
# Create global variable in the requested address space
- gvmem = lmod.add_global_variable(laryty, symbol_name, addrspace)
+ gvmem = cgutils.add_global_variable(lmod, la... | [cuda_blockIdx->[initialize_dim3],cuda_gridsize->[_nthreads_for_dim],cuda_shared_array_integer->[_get_unique_smem_id],cuda_shared_array_tuple->[_get_unique_smem_id],_generic_array->[_get_target_data],cuda_gridDim->[initialize_dim3],cuda_threadIdx->[initialize_dim3],_atomic_dispatcher->[imp->[_normalize_indices]],cuda_b... | Internal function for creating generic NVVM objects. Missing object - memory block - related objects. Missing data. | Wonder if the `enum` in `llvmlite` ought to be moved out of `llvmpy` and into the `llvmlite` API such that reliance on strings is reduced? (Not for this PR!). |
@@ -2089,4 +2089,18 @@ module.exports = class Exchange {
params = this.omit (params, 'type');
return [ type, params ];
}
+
+ yearMonthDay (dateStr) {
+ const date = new Date (dateStr);
+ let month = '' + (date.getMonth () + 1);
+ let day = '' + date.getDate ();
+ co... | [No CFG could be retrieved] | omit type and params. | We don't need this method, cause we have yyyymmdd, yymmdd, ymd in the base classes. |
@@ -139,6 +139,10 @@ func (s *authzServer) FilterAuthorizedPairs(
func (s *authzServer) FilterAuthorizedProjects(
ctx context.Context,
req *api.FilterAuthorizedPairsReq) (*api.FilterAuthorizedProjectsResp, error) {
+
+ // Introspection needs unfiltered access.
+ ctx = auth_context.ContextWithoutProjects(ctx)
+
r... | [FilterAuthorizedPairs->[V2FilterAuthorizedPairs,Error,Subjects],getAllProjects->[Error,ListProjects],Interceptor->[New,WithDetails,Errorf,HasPrefix,Err],FilterAuthorizedProjects->[Error,ListProjects,SliceContains,Subjects,V2FilterAuthorizedProjects],ProjectsAuthorized->[V2IsAuthorized,getAllProjects,Action,Error,logQu... | FilterAuthorizedProjects returns a list of authorized projects. | Consider moving this to just after 155 since that's where we use it (I got confused and thought `V2FilterAuthorizedProjects` |
@@ -9309,9 +9309,11 @@ EXPORT_SYMBOL(spa_event_notify);
#endif
#if defined(_KERNEL)
-module_param(spa_load_verify_maxinflight, int, 0644);
-MODULE_PARM_DESC(spa_load_verify_maxinflight,
- "Max concurrent traversal I/Os while verifying pool during import -X");
+/* BEGIN CSTYLED */
+module_param(spa_load_verify_shift... | [No CFG could be retrieved] | ZFS Pool Export ----------- Module_PARM_DESC - description of params. | I think in ZoL all the tunables are listed in the zfs-params man page, so I think you may have to change the name of the tunable on that file too (or introduce it if it doesn't exist). |
@@ -2497,7 +2497,7 @@ public class ResourceManagerImpl extends ManagerBase implements ResourceManager,
}
if (s_logger.isDebugEnabled()) {
- s_logger.debug("Propagating agent change request event:" + event.toString() + " to agent:" + agentId);
+ s_logger.debug("Propagating resou... | [ResourceManagerImpl->[getGPUDevice->[listAvailableGPUDevice],updateClusterPassword->[doUpdateHostPassword],createHostAndAgentDeferred->[markHostAsDisconnected,getNewHost,isFirstHostInCluster,createHostVO],setHostIntoMaintenance->[resourceStateTransitTo],propagateResourceEvent->[getPeerName],createHostVOForConnectedAge... | Propagates a resource change event to the specified agent. | Can you remove this IF check ? I mean, removing only the IF and maintaining the logging. |
@@ -36,9 +36,16 @@ import org.apache.hadoop.security.token.Token;
import com.google.common.annotations.VisibleForTesting;
/**
- * Helper class used inside {@link BlockOutputStream}.
+ * A BlockOutputStreamEntry manages the data writes into the DataNodes.
+ * It wraps BlockOutputStreams that are connecting to the Da... | [BlockOutputStreamEntry->[getTotalAckDataLength->[getTotalAckDataLength],Builder->[build->[BlockOutputStreamEntry]],writeOnRetry->[writeOnRetry,checkStream],isClosed->[isClosed],write->[write,checkStream],getFailedServers->[getFailedServers],cleanup->[cleanup,checkStream],getWrittenDataLength->[getWrittenDataLength],cl... | Creates a new BlockOutputStreamEntry object. Creates a BlockOutputStreamEntry from the given ethernet block ID and key. | Let's avoid to have EC related docs in master code. |
@@ -219,8 +219,7 @@ function isArrayLike(obj) {
// NodeList objects (with `item` method) and
// other objects with suitable length characteristics are array-like
- return isNumber(length) &&
- (length >= 0 && ((length - 1) in obj || obj instanceof Array) || typeof obj.item === 'function');
+ return isNumbe... | [No CFG could be retrieved] | Checks if a given object is array - like or array - like and if it is an ``` js For all values in the object it will return the value provided. | We are relaxing the condition a bit, but it is OK imo. |
@@ -17,6 +17,9 @@ MAX_ITERATIONS = 10
def semantic_analysis_for_scc(graph: 'Graph', scc: List[str]) -> None:
# Assume reachability analysis has already been performed.
+ #
+ # Note that functions can't define new module-level attributes,
+ # since module top levels are fully processed before functions.... | [semantic_analysis_for_scc->[process_top_levels,process_functions],process_top_levels->[semantic_analyze_target,pop,update,prepare_file,discard,clear],semantic_analyze_target->[refresh_partial,file_context,set],get_all_leaf_targets->[fullname,append,isinstance,items,get_all_leaf_targets],process_functions->[get_all_lea... | Perform semantic analysis for a given SCC. | Sorry for being annoying, but maybe explicitly mention `global x` here? (and clarify whether it is a temporary or principal limitation?) |
@@ -690,11 +690,11 @@ def is_shipping_required(lines: Iterable["CheckoutLineInfo"]):
def validate_variants_in_checkout_lines(lines: Iterable["CheckoutLineInfo"]):
variants_listings_map = {line.variant.id: line.channel_listing for line in lines}
- not_available_variants = [
- variant_id
- for va... | [change_shipping_address_in_checkout->[_check_new_checkout_address],add_voucher_to_checkout->[get_voucher_discount_for_checkout],get_prices_of_discounted_specific_product->[get_discounted_lines],add_variant_to_checkout->[check_variant_in_stock],get_voucher_discount_for_checkout->[_get_products_voucher_discount,_get_shi... | Validate that there are no unavailable variants in the line. | Can we revert those changes and left this file unchanged. |
@@ -204,6 +204,15 @@ class Delivery extends BaseObject
return;
}
+ private static function setFailedQueue($cmd, $id)
+ {
+ if (!in_array($cmd, [Delivery::POST, Delivery::POKE])) {
+ return;
+ }
+
+ Model\ItemDeliveryData::incrementQueueFailed($id);
+ }
+
/**
* @brief Deliver content via DFRN
*
| [Delivery->[deliverMail->[getHostName],execute->[getHostName]]] | Execute a command on a contact. This function is used to create a list of items in the queue. This function is used to check if a message is a top level post or a message of This function is used to deliver items to blocked or pending contacts. | Typehint `string` and `int` |
@@ -50,6 +50,7 @@ public class JacksonConfigManager
this.configManager = configManager;
this.jsonMapper = jsonMapper;
this.auditManager = auditManager;
+ this.jsonMapperSkipNull = jsonMapper.copy().setSerializationInclusion(JsonInclude.Include.NON_NULL);
}
public <T> AtomicReference<T> watch(S... | [JacksonConfigManager->[set->[set],watch->[watch]]] | watch - watch a key and return a AtomicReference of the object that was watched. | I think this object should be bound in the `JacksonModule` as a singleton. Even though JacksonConfigManager is a singleton, if this binding changes in the future, we could inadvertently create an ObjectMapper per JacksonConfigManager instead of a singleton that can be shared across the process. ~~Otherwise, each time w... |
@@ -260,4 +260,17 @@ public class UnitImageFactory {
}
return name.toString();
}
+
+ public Dimension getImageDimensions(final UnitType type, final PlayerId player) {
+ final String baseName = getBaseImageName(type, player, false, false);
+ final Image baseImage =
+ getBaseImage(baseName, pla... | [UnitImageFactory->[getBaseImage->[getImage,getBaseImageUrl],getIcon->[getBaseImage],getBaseImageUrl->[getBaseImageUrl]]] | This method returns the base image name for a given type. Private method to find the name of the unit that is not in the cache. | ditto on the exception type |
@@ -254,7 +254,9 @@ module Repository
end
# NOTE: this will allow graders to access the files in the entire repository
# even if they are the grader for only a single assignment
- graders_info = TaMembership.joins(:user, grouping: :group).pluck(:repo_name, :user_name)
+ graders_info = TaM... | [AbstractRepository->[redis_exclusive_lock->[to_s],update_permissions_after->[update_permissions],get_users->[get_full_access_users]]] | Get all permissions for all the repos and groups. | Unrelated to this PR but we should deal with this note eventually. Especially in this context where one assignment could have anonymization enabled and the other has it disabled. |
@@ -26,7 +26,7 @@ module Exporter
zipped_exports = zip_exports(exports)
- send_exports_by_email(zipped_exports) if send_email
+ send_exports_by_email(zipped_exports, send_to_admin: send_to_admin)
update_user_export_fields
| [Service->[send_exports_by_email->[deliver_now,rewind],zip_exports->[write_buffer,new,write,put_next_entry,each],export->[fetch,send_exports_by_email,to_sym,export,rewind,each,zip_exports],update_user_export_fields->[update!,current],attr_reader,freeze],require] | Exports the user s neccesary content as a JSON object. | Mentioning again that this removes the option to _not_ send an email. I don't think we ever had a case where we did that, except within console. |
@@ -14,7 +14,6 @@ class Profile < ApplicationRecord
encryption_error: 2,
verification_pending: 3,
verification_cancelled: 4,
- in_person_pending: 5,
}
attr_reader :personal_key
| [Profile->[encrypt_compound_pii_fingerprint->[build_compound_pii_fingerprint]]] | Profile class for all application records. This method is called to encrypt the pii and the pii_recovery pii. | I think we should leave this just in case there is existing data out there, maybe rename it to `_deprecated` or something? But the risk of a collision when we do have a new event 5 make me hesitate |
@@ -31,7 +31,6 @@ module Db
count(COALESCE(back_image_view_at,mobile_back_image_view_at,capture_mobile_back_image_view_at,present_cac_view_at)) as back_image,
count(COALESCE(ssn_view_at,enter_info_view_at)) as ssn,
count(verify_view_at) as verify_info,
- count(COALESCE(doc_succ... | [piv_cac_submitted->[join],drop_off_rates->[quote],calc_percent_left->[round,zero?],print_report->[calc_percent_left,calc_dropoff,format,join,each_with_index],generate_report->[format,print_report],drop_offs_in_range->[execute],images_submitted->[join],verified_profiles_count_for_issuer->[execute],calc_dropoff->[round,... | Select counts from the doc_auth_logs table. | Do we know if any of our reporting consumers rely on this column? Or rely on a specified # of columns? If so, should we put a 0, -1 or "N/A" there? |
@@ -38,6 +38,7 @@ export class BaseCarousel extends AMP.BaseElement {
/** @override */
buildCallback() {
+ observe(this.element, (inViewport) => this.viewportCallback_(inViewport));
const input = Services.inputFor(this.win);
const doc = /** @type {!Document} */ (this.element.ownerDocument);
th... | [No CFG could be retrieved] | Creates an abstract base class for a carousel. Adds a carousel button to the element. | Let's drop from here. `layoutCallback` is enough. |
@@ -53,7 +53,8 @@ module Dependabot
"requirements" => requirements,
"previous_version" => previous_version,
"previous_requirements" => previous_requirements,
- "package_manager" => package_manager
+ "package_manager" => package_manager,
+ "metadata" => metadata
}
... | [Dependency->[hash->[hash],display_name->[display_name_builder_for_package_manager],production?->[top_level?],to_h]] | Returns a hash of all the keys of the object that represents a lockfile. | Might want to call `compact` here, so that setups without metadata don't include that key. |
@@ -76,6 +76,7 @@ public class DownloadRunnable implements Runnable {
}
} catch (final Exception e) {
error = e.getMessage();
+ ClientLogger.logError("Error while Parsing:", e);
}
}
}
| [DownloadRunnable->[readLocalFile->[getContents],downloadFile->[getContents,downloadFile]]] | Download the file and read it from the local file system. | It's good practice to keep bug fixes minimized and on their own commit. Plays well with commit history/rollbacks, etc.. This one line IMO ideally would have been the only item in this PR. Note that above we are talking about assumptions of the structure, which in terms of PRs is unrelated to how we handle the case when... |
@@ -206,6 +206,7 @@ type AWSClient struct {
athenaconn *athena.Athena
dxconn *directconnect.DirectConnect
mediastoreconn *mediastore.MediaStore
+ wsconn *workspaces.WorkSpaces
}
func (c *AWSClient) S3() *s3.S3 {
| [ValidateCredentials->[GetCallerIdentity],ValidateAccountId->[Errorf,Println],Client->[NewSessionWithOptions,PushBack,PushBackNamed,HasPrefix,Code,Copy,Int,ValidateAccountId,PushFrontNamed,New,DefaultClient,Errorf,Bool,Wrapf,ValidateCredentials,IsDebugOrHigher,Get,ValidateRegion,Printf,LogLevel,Println,String,Getenv],I... | S3 returns the s3 connection for the current connection. | Minor nitpick: to prevent any confusion with other services, we should probably name this `workspacesconn` |
@@ -293,6 +293,16 @@ export class SubscriptionService {
entitlement =
entitlement ||
Entitlement.empty(subscriptionPlatform.getServiceId());
+ if (this.checkEntitlementsAndEncryptionInvalid_(entitlement)) {
+ const userOrDevLog =
+ subscriptionPlatfo... | [No CFG could be retrieved] | Resolves the given entitlement to the store of the given service. Checks if the user has granted permissions to the service. | Can't we just wrap the whole thing in the function and return the entitlement or log an error? This still looks like most of shared code is repeated. |
@@ -31,14 +31,9 @@ import java.util.Set;
public class ConnectionCountServerSelectorStrategy implements ServerSelectorStrategy
{
- private static final Comparator<QueryableDruidServer> comparator = new Comparator<QueryableDruidServer>()
- {
- @Override
- public int compare(QueryableDruidServer left, Queryabl... | [ConnectionCountServerSelectorStrategy->[compare->[compare]]] | Pick the first server in the set that is not in the list of servers. | Could use `Comparator.comparingInt()` |
@@ -250,7 +250,9 @@ class V00_MarkeplaceAdapter {
if (event.event === 'ListingCreated') {
ipfsHash = event.returnValues.ipfsHash
} else if (event.event === 'ListingUpdated') {
- ipfsHash = event.returnValues.ipfsHash
+ if (!offerBlockNumber || offerBlockNumber < event.blockNumber) {... | [No CFG could be retrieved] | Get the raw listing data for a given listingId. Returns a raw listing along with its associated events and offers. | @wanderingstan - this is the code that enables us to show the listing data as it was when the listing was created for "my purchases" and "my sales" |
@@ -34,7 +34,9 @@ import org.sonar.api.config.Settings;
* A class that manipulates Projects in the Sonar way.
*
* @since 1.10
+ * @deprecated since 5.6 should not be used in any API
*/
+@Deprecated
public class Project extends Resource implements Component {
/**
| [Project->[createFromMavenIds->[createFromMavenIds,Project],qualifier->[getQualifier],getQualifier->[isRoot],longName->[getLongName],name->[getName],isModule->[isRoot],toString->[toString],getRoot->[getRoot]]] | Creates a class that implements the Project interface. Check if the given is a dynamic or a report reuse. | what is the alternative ? |
@@ -58,8 +58,8 @@ type displayNode struct {
SourceFqdn string `csv:"Source FQDN" json:"source_fqdn"`
IpAddress string `csv:"IP Address" json:"ip_address"`
Deprecations []backend.Deprecation `csv:"-" json:"deprecations"`
- Error backend.ChefEr... | [NodeExport->[Context,exportNodes],exportNodes->[Error,GetSortableFieldValue,Errorf,GetParameters,GetNodesPageByCurser,FormatNodeFilters,ConvertParamToNodeRunBackend],NewWriter,Error,NewReader,Sprintf,Marshal,ExpandedRunList,ChefError,MarshalString,SplitAfterN,Deprecation,String,Errorf,Send,CopyBuffer,ParseIP] | NodeExport handles export of a single node - id getExportHandler - get export handler for node. | This was removed because the node-state currently does not fill the error struct. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.