patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -211,10 +211,12 @@ static inline v2f dir(const v2f &pos_dist)
return v2f(std::fabs(x), std::fabs(y));
}
-void Camera::addArmInertia(f32 player_yaw, f32 frametime)
+void Camera::addArmInertia(f32 player_yaw)
{
- m_cam_vel.X = std::fabs((m_last_cam_pos.X - player_yaw) / frametime) * 0.01f;
- m_cam_vel.Y = std::f... | [step->[event,my_modf,setItem,MYMIN,fabs],successfullyCreated->[empty,getBool,clear,getScript],f32->[modf],drawNametags->[getProjectionMatrix,unescape_enriched,getAlpha,utf8_to_wide,multiplyWith1x4Matrix,end,get_video_driver,begin,getFont,getAbsolutePosition,v3f,getViewMatrix],inline->[v2f],removeNametag->[remove],addA... | V2 direction. This is the main entry point for the camera. direction of the arm. | maybe add macros for 55.0f and -35.0f to define textualy what it is (it's used in two places) |
@@ -64,7 +64,7 @@ async function postClosureBabel(file) {
const {compressed, terserMap} = await terserMinify(code);
await fs.outputFile(file, compressed);
- const closureMap = await fs.readJson(`${file}.map`, 'utf-8');
+ const closureMap = await fs.readJson(`${file}.map`, {encoding: 'utf8'});
const sourceM... | [No CFG could be retrieved] | Debug function for the compilation of a single file. | Looks like we're passing in the full options object `{encoding: 'utf8'}` for some operations and the `'utf8'` shorthand for others. Can we standardize to one or the other for consistency and maintainability? |
@@ -720,8 +720,8 @@ class ExpressionChecker(ExpressionVisitor[Type]):
res = res.copy_modified(from_type_type=True)
return expand_type_by_instance(res, item)
if isinstance(item, UnionType):
- return UnionType([self.analyze_type_type_callee(item, context)
- ... | [ExpressionChecker->[visit_star_expr->[accept],analyze_ordinary_member_access->[analyze_ref_expr],check_overload_call->[check_call],visit_await_expr->[accept],erased_signature_similarity->[check_argument_count,check_argument_types],check_op->[check_op_local_by_name,check_op_reversible],visit_enum_call_expr->[accept],in... | Analyze the callee in X where X is Type [ item. | I would use a bit more descriptive name like `tp` instead of just `x`. |
@@ -51,6 +51,7 @@ namespace DotNetNuke.Entities.Users
public void UserApproved(object sender, UserEventArgs args)
{
+ if (!args.SendNotification) return;
Mail.SendMail(args.User, MessageType.UserRegistrationPublic, PortalSettings.Current);
DeleteAllNotifications(... | [UserEventHandlers->[UserRemoved->[DeleteAllNotifications,UserID],DeleteAllNotifications->[GetNotificationByContext,NotificationTypeId,GetNotificationType,NotificationID,ToString,InvariantCulture,DeleteNotification],UserApproved->[DeleteAllNotifications,SendMail,Current,User,UserRegistrationPublic,UserID]]] | This method is called when a user is approved. It deletes all notifications for the given user. | Does `DeleteAllNotifications` not need to happen if we aren't sending a new notification? |
@@ -107,7 +107,12 @@ public class ModuleDelegatingEntityResolver implements EntityResolver {
}
if (inputSource == null) {
if (checkedEntities.get(systemId) != null) {
- throw new MuleRuntimeException(createStaticMessage("Can't resolve %s %s", publicId == null ? "" : publicId, systemId));
+ ... | [ModuleDelegatingEntityResolver->[resolveEntity->[resolveEntity]]] | Resolve an entity. | an extension -> `a dependency` or `a plugin`. |
@@ -1075,6 +1075,7 @@ public class DefaultCacheManager implements EmbeddedCacheManager {
@Override
public ClusterExecutor executor() {
+ authzHelper.checkPermission(AuthorizationPermission.EXEC);
// Allow INITIALIZING state so ClusterExecutor can be used by components in a @Start method.
if... | [DefaultCacheManager->[startCaches->[run->[createCache]],removeCache->[removeCache],isRunning->[getStatus],addListener->[addListener],getAddress->[getAddress],executor->[getStatus],removeListener->[removeListener],close->[stop],getCacheConfiguration->[getDefaultCacheConfiguration,cacheExists],isCoordinator->[isCoordina... | Returns a ClusterExecutor that is responsible for submitting tasks to the cluster. | `master` requires `ADMIN`, we should sync them |
@@ -85,7 +85,7 @@ foreach ($linkedObjectBlock as $key => $objectlink)
}
}
print '</td>';
- print '<td class="linkedcol-statut right">'.$objectlink->getLibStatut(3).'</td>';
+ print '<td class="linkedcol-statut right">'.$objectlink->getLibStatut(3, $objectlink->getSommePaiement()).'</td>';
print ... | [transnoentitiesnoconv,getNomUrl,getLibStatut,trans,load] | Print a list of objects that are linked. Easy way to get a list of all the possible values for a given type. | I think $objectlink can be an object of any type and ->getSommePaiement does not exists for mots of them |
@@ -147,10 +147,10 @@ public class DatasourcesResource
)
{
if (!databaseSegmentManager.enableDatasource(dataSourceName)) {
- return Response.status(Response.Status.NOT_FOUND).build();
+ return Response.noContent().build();
}
- return Response.status(Response.Status.OK).build();
+ retur... | [DatasourcesResource->[getDataSources->[apply->[getDataSources]],getDataSource->[apply->[getDataSource]]]] | Method to enable or remove a data source. | Seems that `Response.serverError().build()` makes more sense here |
@@ -359,7 +359,8 @@ dsl_pool_close(dsl_pool_t *dp)
}
dsl_pool_t *
-dsl_pool_create(spa_t *spa, nvlist_t *zplprops, uint64_t txg)
+dsl_pool_create(spa_t *spa, nvlist_t *zplprops, dsl_crypto_params_t *dcp,
+ uint64_t txg)
{
int err;
dsl_pool_t *dp = dsl_pool_open_impl(spa, txg);
| [No CFG could be retrieved] | Creates a new unused object. Create the MOS and the MOS directories. | How are the crypto params specified from the CLI? I didn't see anything about this in the zpool.8 manpage. |
@@ -210,6 +210,7 @@ class Transaction(models.Model):
max_length=256,
null=True,
)
+ customer_id = models.CharField(max_length=256, null=True)
gateway_response = JSONField(encoder=DjangoJSONEncoder)
class Meta:
| [Transaction->[get_amount->[Money],CharField,JSONField,DateTimeField,ForeignKey,DecimalField,Decimal,BooleanField],Payment->[get_last_transaction->[all,attrgetter,max],can_capture->[get_payment_gateway],get_total->[Money],is_authorized->[all,any],get_authorized_amount->[Money,all,any,zero_money],get_captured_amount->[M... | Creates a CharField for the object that represents a single transaction. | I am not sure that we should store it here also. What is the reason for that? |
@@ -1332,7 +1332,7 @@ public class DoFnOperator<InputT, OutputT>
keyedStateBackend.setCurrentKey(internalTimer.getKey());
TimerData timer = internalTimer.getNamespace();
checkInvokeStartBundle();
- fireTimer(timer);
+ fireTimerInternal((ByteBuffer) internalTimer.getKey(), timer)... | [DoFnOperator->[FlinkTimerInternals->[deleteTimerInternal->[onFiredOrDeletedTimer],deleteTimer->[deleteTimer,cancelPendingTimerById],onFiredOrDeletedTimer->[onRemovedEventTimer],currentSynchronizedProcessingTime->[currentProcessingTime],currentProcessingTime->[currentProcessingTime],processPendingProcessingTimeTimers->... | Process pending processing time timers. | I'm assuming this was a bug? |
@@ -199,9 +199,7 @@ export class AmpAd3PImpl extends AMP.BaseElement {
if (!this.iframeLayoutBox_) {
this.measureIframeLayoutBox_();
}
- // If the iframe is full size, we avoid an object allocation by moving box.
- return moveLayoutRect(box, this.iframeLayoutBox_.left,
- this.iframeLayoutB... | [No CFG could be retrieved] | Measure the layout box of the iframe if it is rendered already. Get the from the iframe and initialize it. | `measureIframeLayoutBox_()` returns iframe layoutRect relative to the `amp-ad` or `amp-iframe` element. However I searched our code and it seems to me the `this.iframeLayoutBox_` is only used here. So instead of applying box offset and apply it back here. Why don't we just return layoutRect relative to doc in `#measure... |
@@ -19,7 +19,7 @@ import (
var (
nameRegex = regexp.MustCompile("^[a-zA-Z0-9][a-zA-Z0-9_.-]*$")
- regexError = errors.Wrapf(ErrInvalidArg, "names must match [a-zA-Z0-9][a-zA-Z0-9_.-]*")
+ regexError = errors.Wrapf(config2.ErrInvalidArg, "names must match [a-zA-Z0-9][a-zA-Z0-9_.-]*")
)
// Runtime Creation Opti... | [WithPod->[ID],ID,Wrapf,Join,IsRootless,Stat,MatchString,InfraContainerID,Wrap,ProcessOptions,MustCompile,ParseIP,NetworkMode,GetRootlessUID,DefaultStoreOptions] | WithStorageConfig creates a new runtime option that sets up the container storage configuration. Adds the required fields to the configuration object. | Perhaps lack of tea, but should this be config and not config2? |
@@ -16,7 +16,7 @@ if ($device['os_group'] == "cisco") {
$total = snmpwalk_cache_oid_num($device, "1.3.6.1.4.1.9.9.86.1.7.1.0", null);
$total = $total['1.3.6.1.4.1.9.9.86.1.7.1.0'][''];
- if (isset($total) && ($total != "") && ($total != 0)) {
+ if (isset($total) && $total > 0) {
// Available
... | [No CFG could be retrieved] | - > Load a NMS resource from a Cisco Voice Router - > Transcoder Unset the from the given structures. | You didnt change it, but down below I spot a bug: dat_update($device, 'cisco-iosxcode', $tags, $fields); should be: **data_update**($device, 'cisco-iosxcode', $tags, $fields); No one will be hitting this bug as on the calling code, the include is wrong: includes/polling/cisco-voice.inc.php include "cisco-voice/cisco-xc... |
@@ -633,9 +633,6 @@ static int destroy_shortcut_event(lua_State *L)
// remove the accelerator from the lua shortcuts
dt_accel_deregister_lua(tmp);
- // free temporary buffer
- free(tmp);
-
return result;
}
| [dt_lua_event_trigger_wrapper->[dt_lua_event_trigger],int->[dt_lua_event_keyed_destroy,dt_lua_event_keyed_register],dt_lua_init_events->[dt_lua_event_add]] | This function destroyes the shortcut event pushcfunction - push callback for multiinstance - trigger. | In contrast to the situation above, the `free` _is_ needed here (as far as I can see) as there is closure that takes care for freeing `tmp`. |
@@ -45,7 +45,7 @@ namespace Content.Shared.GameObjects.Components.Observer
{
public EntityUid PlayerTarget;
public string WarpName;
- public GhostWarpRequestMessage(EntityUid playerTarget = default, string warpTarget = default)
+ public GhostWarpRequestMessage(EntityUid playerTarget... | [SharedGhostComponent->[GHOST],GhostComponentState->[GHOST]] | A base class for all Ghost components that are part of the game. Contains the data for the WAR and PLAYER names. | Should be handled |
@@ -6,6 +6,7 @@ module Admin
id supported rules_markdown short_summary pretty_name bg_color_hex
text_color_hex user_id alias_for badge_id requires_approval
category social_preview_template wiki_body_markdown submission_template
+ name
].freeze
before_action :set_default_options, on... | [TagsController->[new->[new],create->[new],update->[update]]] | Controller for a single tag missing_tags = true. | By not including `name` within the `ALLOWED_PARAMS` constant, Admins were unable to `create` and `update` tags via `/admin/content_manager/tags`. The logs would silently spit out an `Unpermitted param :name` error, but there was no indication that the creation or updating of the tag had failed--it just appeared that th... |
@@ -480,6 +480,8 @@ class ICA(ContainsMixin):
del self.pca_mean_
if hasattr(self, 'drop_inds_'):
del self.drop_inds_
+ if hasattr(self, 'reject_'):
+ del self.reject_
def _fit_raw(self, raw, picks, start, stop, decim, reject, flat, tstep,
reject_... | [_find_sources->[get_score_funcs],run_ica->[fit,ICA,_detect_artifacts],get_score_funcs->[_make_xy_sfunc],corrmap->[get_components,_find_max_corrs],_sort_components->[copy],ICA->[_fit->[fit],_sources_as_evoked->[_transform_evoked],_apply_epochs->[_pre_whiten,_check_exclude],_transform_raw->[_pre_whiten,_transform],_fit_... | Private method to reset ICA data. return the last object in the chain. | this is not cover. I'm not sure if you need to. |
@@ -7,12 +7,14 @@
</div>
<% end %>
+ <%# it's highly unlikely a single org will have so many users to slow down
+ this fetch, thus we can safely use the .present?/.each pattern to load them %>
<% if @organization.users.present? %>
<div class="widget">
<div class="widget-sugg... | [No CFG could be retrieved] | Renders the sponsor - hierarchy. | I think this may happen sooner than you think. You get one large org added right now and this will break. I think I would prefer to stick with the safety of `find_each` rather than risking it for a small speed up from using `.present?/each` |
@@ -11,11 +11,12 @@ module Integration
sign_out_admin
end
- def with_signed_in_user(user)
+ def with_signed_in_user(user, logout=true)
with_current_site(user.site) do
sign_in_user(user)
yield
- sign_out_user
+ # permits skipping logout on some pages that don't ... | [with_signed_in_admin->[sign_in_admin],sign_in_user->[email,post],with_signed_in_user->[with_current_site,site,sign_in_user],sign_out_user->[delete],sign_in_admin->[email,post],sign_out_admin->[delete]] | Yields all user and admin objects that have not been signed in. | Line is too long. [91/80] |
@@ -38,4 +38,9 @@ public class AboutJenkins extends ManagementLink {
return AboutJenkins.class.getResource("/META-INF/licenses.xml");
}
+ @Override
+ public Permission getRequiredPermission() {
+ return Jenkins.MANAGE;
+ }
+
}
| [AboutJenkins->[getDescription->[AboutJenkins_Description],getDisplayName->[AboutJenkins_DisplayName],getLicensesURL->[getResource]]] | Get the URL of the license file. | Should it be replaced by read-only access in JEP-224? |
@@ -11,8 +11,8 @@ function writeFiles() {
this.app = this.appConfigs[i];
this.template('_deployment.yml', `${appName}/${appName}-deployment.yml`);
this.template('_service.yml', `${appName}/${appName}-service.yml`);
-
- if (this.app.prodDatabaseType) {
+ ... | [No CFG could be retrieved] | Create a function to write the list of files to the console. | I think it might be better to & this with the original as we dont want to move the file when the property is undefined as well. @PierreBesson am I right or is there no way for this to be undefined? |
@@ -35,6 +35,7 @@ import {LoadingSpinner} from './loading-spinner';
import {MediaPool} from './media-pool';
import {PageScalingService} from './page-scaling';
import {Services} from '../../../src/services';
+import {VideoServiceSync} from '../../../src/service/video-service-sync-impl';
import {
closestBySelector... | [No CFG could be retrieved] | Package that imports a single object into the system. This function upgrades the AMPHTML background audio library to the new AMPHTML story page. | This is okay if it somehow makes your life easier, but generally speaking only P0 issues need to be resolved in 0.1. Any new features and fixes can happen in 1.0. |
@@ -31,10 +31,10 @@ from conda.instructions import (FETCH, EXTRACT, UNLINK, LINK, RM_EXTRACTED,
SYMLINK_CONDA)
# Silence pyflakes
-(FETCH, EXTRACT, UNLINK, LINK, RM_EXTRACTED,
- RM_FETCHED, PREFIX, PRINT, PROGRESS,
- SYMLI... | [add_defaults_to_specs->[dist2spec3v],execute_plan->[update_old_plan],revert_actions->[add_unlink,ensure_linked_actions],remove_features_actions->[add_unlink,ensure_linked_actions],execute_actions->[plan_from_actions],display_actions->[format->[format],format,print_dists],remove_actions->[ensure_linked_actions,get_pinn... | Print the list of packages and build - tags. | I _really_ don't like stuff like this. Doesn't `# NOQA` on the import silence pyflakes? Let's just do that... |
@@ -1813,7 +1813,7 @@ class Brain(object):
filepath = label
label = read_label(filepath)
hemi = label.hemi
- label_name = os.path.basename(filepath).split('.')[1]
+ label_name = os.path.basename(filepath).split('.')[0]
else:
... | [Brain->[add_label->[_iter_views],screenshot->[screenshot],close->[close],enable_depth_peeling->[enable_depth_peeling],_add_volume_data->[_iter_views],_update_glyphs->[_iter_views],scale_data_colormap->[_update_fscale],_advance->[toggle_playback],reset_view->[_iter_views],_make_movie_frames->[set_time_interpolation,scr... | Add a label to the image. Generate a sequence of objects representing a single critical point. Add label data for all missing missingfaces. | Most are named things like `lh.BA1.label`, this seems wrong? |
@@ -229,7 +229,17 @@ namespace System.Text.RegularExpressions
if (CaseInsensitive)
{
- return string.Compare(Pattern, 0, text, index, Pattern.Length, ignoreCase: true, _culture) == 0;
+ TextInfo textinfo = _culture.TextInfo;
+
+ for (int i = 0; i ... | [RegexBoyerMoore->[IsMatch->[AsSpan,Compare,SequenceEqual,Length],Scan->[ToLower,Length],ToString->[Dump,Empty],Dump->[AppendLine,Append,Escape,ToString,Length],ToLower,Copy,Length,Assert]] | Checks if the given text matches the pattern at the given index. | >textinfo.ToLower(text[index + i]) [](start = 38, length = 33) wouldn't be faster if we convert the whole text (with the length of pattern) to lowercase as one shot? calling ToLower with every character can be very expensive if the character is not ASCII. The other idea is to call CharUnicodeInfo.GetUnicodeCategory on ... |
@@ -192,9 +192,9 @@ def is_overlapping_tuples(t: Type, s: Type, use_promotions: bool) -> Optional[bo
if all(is_overlapping_types(ti, si, use_promotions)
for ti, si in zip(t.items, s.items)):
return True
- # TupleType and non-tuples do not overlap
... | [is_overlapping_types->[is_overlapping_types],is_overlapping_tuples->[is_overlapping_types],narrow_declared_type->[narrow_declared_type,meet_types],meet_similar_callables->[meet_types],is_partially_overlapping_types->[is_object],TypeMeetVisitor->[meet->[meet_types],visit_union_type->[meet_types],visit_tuple_type->[meet... | Check if two types are overlapping. | Does it still make sense to return `None` here instead of `False` here? |
@@ -1016,6 +1016,7 @@ public class DeckPicker extends NavigationDrawerActivity implements
super.onSaveInstanceState(savedInstanceState);
savedInstanceState.putLong("mContextMenuDid", mContextMenuDid);
savedInstanceState.putBoolean("mClosedWelcomeMessage", mClosedWelcomeMessage);
+ save... | [DeckPicker->[handleDbError->[showDatabaseErrorDialog],undo->[undoTaskListener],mediaCheck->[mediaCheckListener],MediaCheckListener->[actualOnPostExecute->[showMediaCheckDialog]],updateDeckList->[updateDeckListListener,updateDeckList],onDestroy->[onDestroy],onOptionsItemSelected->[onOptionsItemSelected],onCreate->[onCr... | Override to store the context menu did and the closed welcome message. | I don't think this works any more - you have two variables: one in the class, and one here |
@@ -190,7 +190,10 @@ def default_log_file(spec):
"""
fmt = 'test-{x.name}-{x.version}-{hash}.xml'
basename = fmt.format(x=spec, hash=spec.dag_hash())
- dirname = fs.os.path.join(spack.paths.var_path, 'junit-report')
+ dirname = spack.config.get(
+ 'config:misc_cache', spack.paths.var_path)
+... | [install->[default_log_file,install_specs,get_tests,update_kwargs_from_args],install_specs->[install_specs]] | Computes the default log file for the test. Add a to the environment. Raise an exception if there is no such exception. | I'm not sure we want to clear this every time we clear the misc cache. Reports are really less transient than what we usually put in there. Can you make it so that these have their own directory within `~/.spack`? I'd recommend putting them in `~/.spack/reports/junit`, and adding `~/.spack/reports` to `spack.paths`. |
@@ -790,7 +790,7 @@ forEach({
},
find: function(element, selector) {
- return element.getElementsByTagName(selector);
+ return (element.querySelectorAll || element.getElementsByTagName).call(element, selector);
},
clone: JQLiteClone,
| [No CFG could be retrieved] | Creates a new object with the same properties as the original object. returns a copy of the array if value is not undefined. | we can drop the `getElementsByTagName` fallback since all browsers that we care about already support this. |
@@ -20,11 +20,16 @@ namespace Microsoft.Extensions.Configuration
/// <returns>Immediate children sub-sections of section specified by key.</returns>
internal static IEnumerable<IConfigurationSection> GetChildrenImplementation(this IConfigurationRoot root, string? path)
{
- return r... | [InternalConfigurationRootExtensions->[GetChildrenImplementation->[Select,Combine,GetSection]]] | Get children implementation. | I wonder if this code makes sense here. What if the "special" logic here was moved into `ConfigurationManager` - calling `GetProvidersReference()` and `ToList()`? We could still share the inner logic here, we just wouldn't be paying the cost nor complexity in code paths outside of ConfigurationManager. This would also ... |
@@ -828,6 +828,8 @@ func resourceAwsDbInstanceRead(d *schema.ResourceData, meta interface{}) error {
d.Set("replicate_source_db", v.ReadReplicaSourceDBInstanceIdentifier)
+ d.Set("ca_cert_identifier", v.CACertificateIdentifier)
+
return nil
}
| [UniqueId,Message,SetPartial,IsNewResource,Partial,Set,Code,NonRetryableError,Add,ModifyDBInstance,PromoteReadReplica,MatchString,GetOk,HasChange,ListTagsForResource,DescribeDBInstances,DeleteDBInstance,Errorf,Len,SetId,MustCompile,RetryableError,Bool,Timeout,Contains,PrefixedUniqueId,ToLower,Id,RestoreDBInstanceFromDB... | This function is used to create an empty schema. Set to hold all the tags for the Destroy DB Instance. | Could we also check in the acctest that the attribute is set? |
@@ -755,6 +755,15 @@ def _get_entries(fid, evoked_node):
return comments, aspect_kinds, t
+def _get_evoked_info(fname):
+ """Helper to get info in evoked file"""
+ f, tree, _ = fiff_open(fname)
+ with f as fid:
+ _, meas = read_meas_info(fid, tree)
+ evoked_node = dir_tree_find(meas, FIF... | [Evoked->[detrend->[detrend],resample->[resample]],read_evoked->[Evoked]] | Merge and concat evoked data . | you have an mne.fiff.read_info that does this already |
@@ -3513,7 +3513,7 @@ static int tls_decrypt_ticket(SSL *s, const unsigned char *etick,
int rv = tctx->tlsext_ticket_key_cb(s, nctick, nctick + 16,
&ctx, &hctx, 0);
if (rv < 0)
- return -1;
+ goto err;
if (rv == 0)
... | [No CFG could be retrieved] | This function is called to decrypt a ticket from the input buffer. Check if the session ticket is valid. | Contexts are not cleaned up in this case as well. |
@@ -9,7 +9,7 @@ import java.util.Map;
public class ActorCreationOptions extends BaseTaskOptions {
public static final int NO_RECONSTRUCTION = 0;
- public static final int INFINITE_RECONSTRUCTIONS = (int) Math.pow(2, 30);
+ public static final int INFINITE_RECONSTRUCTION = (int) Math.pow(2, 30);
// DO NOT set... | [ActorCreationOptions->[Builder->[createActorCreationOptions->[ActorCreationOptions]]]] | Creates a base class for creating actors. Creates an actor that will be created when the actor is created. | This was inconsistent between Python and Java. |
@@ -151,6 +151,9 @@ public abstract class AbstractJobLauncher implements JobLauncher {
taskExecutor.submit(task);
}
+ new EventSubmitter.Builder(JobMetrics.get(jobId).getMetricContext(), "gobblin.runtime").build().
+ submit("TasksSubmitted", "tasksCount", Integer.toString(workUnits.size()));
+
... | [AbstractJobLauncher->[commitJob->[close],tryLockJob->[getJobLock],startCancellationExecutor->[run->[executeCancellation]]]] | Submit a list of work units to the task executor. | Why not use `this.eventSubmitter`? |
@@ -1869,10 +1869,15 @@ namespace {
bool
is_bit(const char* topic_name) {
+#if !defined (DDS_HAS_MINIMUM_BIT)
return strcmp(topic_name, BUILT_IN_PARTICIPANT_TOPIC) == 0
|| strcmp(topic_name, BUILT_IN_TOPIC_TOPIC) == 0
|| strcmp(topic_name, BUILT_IN_PUBLICATION_TOPIC) == 0
|| strcmp(top... | [No CFG could be retrieved] | Get the next instance of a handle in this participant. - - - - - - - - - - - - - - - - - -. | Could this be refactored to use the existing function topicIsBIT in dds/DCPS/BuiltInTopicUtils.h? |
@@ -55,7 +55,12 @@ public class InvokerInvocationHandler implements InvocationHandler {
return invoker.equals(args[0]);
}
RpcInvocation rpcInvocation = new RpcInvocation(method, invoker.getInterface().getName(), args);
- rpcInvocation.setTargetServiceUniqueName(invoker.getUrl().get... | [InvokerInvocationHandler->[invoke->[getDeclaringClass,getName,equals,getServiceKey,setTargetServiceUniqueName,recreate,invoke,toString,getParameterTypes,destroy,RpcInvocation,hashCode],getLogger]] | This method is called by the proxy to invoke the method. | I think it would be better to put ConsumerModel in the constructor,because it wouldn't change and will get better performance |
@@ -10229,6 +10229,11 @@ void Emit(ParseNode *pnode, ByteCodeGenerator *byteCodeGenerator, FuncInfo *func
byteCodeGenerator->EmitPropStore(pnode->location, sym, nullptr, funcInfo, true, false);
}
+ if (pnode->sxClass.IsDefaultModuleExport())
+ {
+ byteCodeGenerator->Emit... | [No CFG could be retrieved] | Emit all the static and instance methods of a given class node. copies the return register if necessary and if necessary the register is initialized at the top. | What's the syntax that would get us here? |
@@ -248,9 +248,13 @@ class CertificateClientTests(KeyVaultTestCase):
self.assertEqual(cert.id, cert_bundle.id)
self.assertNotEqual(cert.properties.updated_on, cert_bundle.properties.updated_on)
+ polling_interval = 0 if self.is_playback() else 2
+
# delete certificate
- delete... | [CertificateClientTests->[test_crud_operations->[_validate_certificate_bundle],test_backup_restore->[_validate_certificate_bundle],_validate_certificate_issuer->[_admin_detail_equal],test_crud_issuer->[_validate_certificate_issuer,_validate_certificate_issuer_properties],__init__->[RetryAfterReplacer],test_list_certifi... | This test tests CRUD operations on Vault. Get certificate version if it exists. | Is there a reason not to test the client method's default interval, i.e. use `None` in live tests instead of 2? |
@@ -59,7 +59,7 @@ import java.util.function.Function;
*/
public class HoodieActiveTimeline extends HoodieDefaultTimeline {
- public static final SimpleDateFormat COMMIT_FORMATTER = new SimpleDateFormat("yyyyMMddHHmmss");
+ public static final SimpleDateFormat COMMIT_FORMATTER = new SimpleDateFormat("yyyyMMddHHmm... | [HoodieActiveTimeline->[saveToCompactionRequested->[saveToCompactionRequested,createFileInAuxiliaryFolder],deleteCompactionRequested->[deleteInstantFile],transitionRequestedToInflight->[transitionRequestedToInflight,transitionState],transitionState->[transitionState],revertReplaceCommitInflightToRequested->[deleteInfli... | Provides a base class for the Hoodie Active Timeline. Creates a new instant time string. | IIRC there is just one place where we assume something about the time format. its for scheduling compactions every N minutes i.e by elapsed time since last compaction. Might want to check that. Other thing to consider, is how this formatter parses existing `yyyyMMddHHmmss` events in timeline? Also worth checking out ar... |
@@ -21,15 +21,15 @@ namespace Content.Server.Chemistry.Components
protected override void UpdateVisuals()
{
if (Owner.TryGetComponent(out AppearanceComponent? appearance) &&
- SolutionContainerComponent != null)
+ EntitySystem.Get<SolutionContainerSystem>().T... | [FoamSolutionAreaEffectComponent->[ReactWithEntity->[TryTransferSolution,POCKET1,SplitSolution,BACKPACK,Min,EmptyVolume,POCKET2,TryGetSlotItem,Clone,IDCARD,TryGetComponent,TotalVolume,Slots],UpdateVisuals->[TryGetComponent,Color,WithAlpha,SetData],OnKill->[Deleted,Coordinates,SpawnEntity,SetData,IsNullOrEmpty,QueueDele... | Override to update the visibility of an entity. | As elsewhere, const string. I won't spot all of these but it should be done IMO. |
@@ -56,6 +56,12 @@ type ErrParentCommitNotFound struct {
Commit *pfs.Commit
}
+// ErrOutputCommitNotFinished represents an error where the commit has not
+// been finished
+type ErrOutputCommitNotFinished struct {
+ Commit *pfs.Commit
+}
+
func (e ErrFileNotFound) Error() string {
return fmt.Sprintf("file %v no... | [Error->[Sprintf],ScrubGRPC,MustCompile,Error,MatchString] | Error returns error message for ErrFileNotFound. | Nice, I like adding this to the enumerated pfs erors. |
@@ -1041,6 +1041,11 @@ class Link(object):
def __init__(self, url, comes_from=None, internal=None, trusted=None,
_deprecated_regex=False):
+
+ # url can be a UNC windows share
+ if hasattr(url, 'startswith') and url.startswith('\\\\'):
+ url = path_to_url(url)
+
... | [PackageFinder->[find_requirement->[_sort_locations,_validate_secure_origin,_sort_versions,mkurl_pypi_url],_sort_locations->[sort_path],_link_package_versions->[_known_extensions],_package_versions->[_sort_links]],Link->[splitext->[splitext],ext->[splitext]],Link] | Initialize a new object with the specified properties. | Should this be conditional on os.name as well? (os.name=='nt' directly implies os.path==ntpath, which would seem to be more relevant than sys.platform here) |
@@ -260,7 +260,7 @@ class O4DOIXmlFilter extends NativeExportFilter {
}
// ISSN
if (!empty($issn)) {
- $issn = PKPString::regexp_replace('/[^0-9]/', '', $issn);
+ // $issn = PKPString::regexp_replace('/[^0-9]/', '', $issn); There is no more need to remove character that is NOT in 0-9
$serialVersionNod... | [O4DOIXmlFilter->[createSerialPublicationNode->[isWork],getDOIStructuralType->[isWork]]] | Creates a serialVersion node. | This line can just be removed. |
@@ -459,11 +459,15 @@ Service_Participant::parse_args(int &argc, ACE_TCHAR *argv[])
arg_shifter.consume_arg();
got_info = true;
- } else if ((currentArg = arg_shifter.get_the_parameter(ACE_TEXT("-DCPSRTISerialization"))) != 0) {
- Serializer::set_use_rti_serialization(ACE_OS::atoi(currentArg));
... | [No CFG could be retrieved] | Parse command line arguments and return the index of the last found index. Reads the arguments from the command line and checks if the command line argument is a single -. | This line and the next are modified, but only the spacing and placement of `}` changed, let's try to avoid that. |
@@ -183,8 +183,12 @@ public abstract class KafkaSource<S, D> extends EventBasedSource<S, D> {
}
private void createEmptyWorkUnitsForSkippedPartitions(Map<String, List<WorkUnit>> workUnits,
- Map<String, State> topicSpecificStateMap) {
+ Map<String, State> topicSpecificStateMap, SourceState state) {
... | [KafkaSource->[getWorkUnitForTopicPartition->[getWorkUnitForTopicPartition],createEmptyWorkUnit->[getWorkUnitForTopicPartition],getFilteredTopics->[getFilteredTopics]]] | Create empty work units for skipped partitions. | Why do you need this check? Isn't this check already in `getAllPreviousOffserts(state)`? |
@@ -1764,9 +1764,12 @@ func (e *Env) ModelessWantsSystemd() bool {
os.Getenv("KEYBASE_SYSTEMD") != "0")
}
-func (e *Env) DarwinForceSecretStoreFile() bool {
- return (e.GetRunMode() == DevelRunMode &&
- os.Getenv("KEYBASE_SECRET_STORE_FILE") == "1")
+func (e *Env) ForceSecretStoreFile() bool {
+ // By default us... | [GetGpgHome->[GetGpgHome,GetString,GetConfig,GetHome],GetInfoDir->[GetString],GetPvlKitFilename->[GetString,GetConfig,GetPvlKitFilename],GetLevelDBNumFiles->[getEnvInt,GetConfig,GetInt],GetGpg->[GetString,GetConfig,GetGpg],GetExtraNetLogging->[GetBool,GetConfig,getEnvBool],GetLogFormat->[GetString,GetLogFormat,GetConfi... | ModelessWantsSystemd returns true if the user is running on a system and is. | Can we put this in config as well? So if a user has an issue with their keychain we can tell them to just flip the config flag on and not worry about env vars |
@@ -24,11 +24,13 @@ import java.sql.Timestamp;
@UdfDescription(
name = "from_unixtime",
category = FunctionCategory.DATE_TIME,
- description = "Converts a BIGINT millisecond timestamp value into a TIMESTAMP value.",
+ description = "Converts a number of millisecond 1970-01-01 00:00:00 UTC/GMT into "
+ ... | [FromUnixTime->[fromUnixTime->[Timestamp]]] | Converts a BIGINT millisecond timestamp value into a TIMESTAMP value. | "the number of milliseconds"? |
@@ -57,6 +57,8 @@ namespace System.IO.Pipelines
public System.Threading.Tasks.ValueTask<System.IO.Pipelines.ReadResult> ReadAtLeastAsync(int minimumSize, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
protected virtual System.Threadi... | [No CFG could be retrieved] | abstract class readAtLeastAsyncCore. | You shouldn't need to expose anything here. |
@@ -938,6 +938,14 @@ namespace System.Collections.Generic
{
return keyComparer.Compare(x.Key, y.Key);
}
+
+ public override bool Equals(object? obj)
+ {
+ return obj is KeyValuePairComparer otherComparer &&
+ otherCompare... | [SortedDictionary->[Clear->[Clear],KeyCollection->[Enumerator->[MoveNext->[MoveNext],Dispose->[Dispose],Reset->[Reset],GetEnumerator],Contains->[ContainsKey],CopyTo->[CopyTo]],CopyTo->[CopyTo],ContainsKey->[Contains],Add->[Add],Enumerator->[MoveNext->[MoveNext],Dispose->[Dispose],Reset->[Reset],GetEnumerator],KeyValueP... | Compare two key - value pairs. | Couple of issues with this change: 1. This changes the equality semantics of a public class, which is technically a breaking change. While `KeyValuePairComparer` is probably not a very commonly used type and I would not expect existing users to rely on its current behaviour. Still, I don't trust that the risk is worth ... |
@@ -64,9 +64,9 @@ class Assignment < ActiveRecord::Base
# For those, please refer to issue #1126
# Because of app/views/assignments/_list_manage.html.erb line:13
- validates :description, presence: true
+ validates_presence_of :description
# Because of app/views/main/_grade_distribution_graph.html.erb:25
-... | [Assignment->[get_detailed_csv_report_rubric->[total_mark],group_by->[group_assignment?],grade_distribution_as_percentage->[total_mark],get_simple_csv_report->[total_mark],get_detailed_csv_report_flexible->[total_mark],section_past_due_date?->[past_due_date?],reset_collection_time->[reset_collection_time],median->[aver... | This function accepts nested attributes for a section and returns a Model object. Export the rubric_criteria of a given object. | I'd not change these because the `presence: true` style is actually the new recommended style since Rails 3. |
@@ -1349,6 +1349,15 @@ function get_oxidized_nodes_list()
}
echo "
</td>
+ ";
+ if (!Config::get('force_ip_to_sysname')) {
+ echo "
+ <td>
+ " . $device['sysName'] . "
+ </td>
+ ";
+ }
+ echo "
<td>
... | [getlocations->[hasGlobalRead],get_postgres_databases->[getFirstComponentID,getComponents],get_zfs_pools->[getFirstComponentID,getComponents],get_fail2ban_jails->[getFirstComponentID,getComponents],get_dashboards->[all],get_portactivity_ports->[getFirstComponentID,getComponents],bill_permitted->[hasGlobalRead],device_p... | Get oxidized nodes list Print a list of all nodes that have a device id. | There should be no if statement here, just output the column |
@@ -35,4 +35,16 @@ public final class MathUtil {
assert value > Integer.MIN_VALUE && value < 0x40000000;
return 1 << (32 - Integer.numberOfLeadingZeros(value - 1));
}
+
+ /**
+ * Determine if the requested {@code index} and {@code length} will fit within {@code capacity}.
+ * @param in... | [MathUtil->[findNextPositivePowerOfTwo->[numberOfLeadingZeros]]] | Find the next non - zero value after the given value. | +1 I thought this should have been a utility :) |
@@ -128,5 +128,3 @@ def validate_all_content(experiment_config, config_path):
if 'maxExecDuration' in experiment_config:
experiment_config['maxExecDuration'] = parse_time(experiment_config['maxExecDuration'])
- if 'maxTrialDuration' in experiment_config:
- experiment_config['maxTrialDuration']... | [validate_all_content->[parse_time,set_default_values,parse_path],parse_path->[parse_relative_path,expand_path]] | Validate whether all the content of the experiment_config is valid. | why remove "maxTrialDuration" here? |
@@ -157,7 +157,11 @@ module Engine
end
def floated?
- @floated ||= percent_of(self) <= 100 - @float_percent
+ @floatable && (@floated ||= percent_of(self) <= 100 - @float_percent)
+ end
+
+ def floatable?
+ @floatable
end
def percent_to_float
| [Corporation->[buy_multiple?->[buy_multiple?],counts_for_limit->[counts_for_limit],remove_ability->[remove_ability]]] | Returns 0 if the sequence is floated. | why does this need to check floatable also if it does it should probably check floatable? |
@@ -1205,7 +1205,7 @@ class ModelBase(backwards_compatible(Keyed)):
print("Numpy not found. Cannot plot 2D partial plots.")
ycol = colPairs[1]
nBins = nbins
- if ycol in user_cols:
+ if not(user_cols==None) and (ycol in user_cols):
ind = user_cols.index(ycol)
... | [ModelBase->[download_pojo->[download_pojo],aic->[aic],mean_residual_deviance->[mean_residual_deviance],score_history->[scoring_history],_plot->[show,scoring_history],mse->[mse],gini->[gini],std_coef_plot->[coef_norm,show],varimp_plot->[show,varimp],auc->[auc],rmsle->[rmsle],logloss->[logloss],model_performance->[type]... | Predict for 3D plot. | I think `if user_cols is not None` looks more Python-y |
@@ -2384,10 +2384,10 @@ namespace System.Windows.Forms
if (IsHandleCreated && Visible)
{
- IntPtr hWnd = Handle;
switch (value)
{
case FormWindowState.Normal:
+ formStateE... | [Form->[WmSize->[UpdateMdiControlStrip],UpdateMdiControlStrip->[ToString,Dispose],AdjustSystemMenu->[AdjustSystemMenu],ApplyAutoScaling->[AdjustScale],OnFontChanged->[OnFontChanged],FocusInternal->[FocusInternal],ResetIcon->[Dispose],ProcessDialogChar->[ProcessDialogChar,ProcessMnemonic],WmEnterMenuLoop->[OnMenuStart],... | The main entry point for the system. This is a private method that is called when the form is hidden. | Consider adding dedicates Get/Set state methods to improve readability. |
@@ -31,6 +31,7 @@ import com.google.common.collect.ImmutableMap;
import com.google.common.collect.Iterators;
import com.google.common.collect.Lists;
import com.google.common.io.Closeables;
+
import java.io.IOException;
import java.io.InputStream;
import java.io.OutputStream;
| [KafkaIO->[TypedWithoutMetadata->[populateDisplayData->[populateDisplayData],expand->[apply]],KafkaWriter->[setup->[getProducerFactoryFn,apply],teardown->[close],processElement->[getTopic],getKeyCoder,getProducerConfig,getValueCoder],UnboundedKafkaSource->[generateInitialSplits->[getConsumerConfig,getTopics,build,apply... | Imports a single version of a n - tuple. MISSING - METHODS. | Nit: you have a bunch of newlines added in-between imports that probably the IDE's "auto-indent" added, they are unnecessary. |
@@ -174,8 +174,8 @@ namespace Microsoft.Xna.Framework.Content
RemoveContentManager(this);
}
- // If disposing is true, it was called explicitly.
- // If disposing is false, it was called by the finalizer.
+ // If disposing is true, it was called explicitly and we should dispose managed objects.
+ ... | [ContentManager->[ReloadAsset->[Dispose],T->[Dispose],ContentReader->[Dispose],Normalize->[Normalize],Unload->[Dispose],Dispose->[RemoveContentManager,Dispose],AddContentManager]] | Dispose the content manager. | I think you really mean "unmanaged resources" and not "managed objects" right? |
@@ -14,7 +14,12 @@ internal static partial class Interop
internal delegate bool ConsoleCtrlHandlerRoutine(int controlType);
+#if DLLIMPORTGENERATOR_ENABLED
+ [GeneratedDllImport(Libraries.Kernel32, SetLastError = true)]
+ internal static partial bool SetConsoleCtrlHandler(ConsoleCtrlHandlerRo... | [Interop->[Kernel32->[SetConsoleCtrlHandler->[Kernel32]]]] | Opens a console handler for control - lines. | Who is setting this define? I don't see it set anywhere. |
@@ -170,11 +170,12 @@ func (u *Type) CanBeDefault() bool {
// Unit is a section of one repository
type Unit struct {
- Type Type
- NameKey string
- URI string
- DescKey string
- Idx int
+ Type Type
+ NameKey string
+ URI string
+ DescKey string
+ Idx int
+ MaxPerms perm.AccessMode
}
/... | [ColorFormat->[ColorFprintf,NewColoredIDValue],CanDisable->[CanDisable],String->[Sprintf],CanDisable,CanBeDefault,EqualFold,Warn,String] | CanDisable returns true if the unit can be disabled. | So MaxPerms = max(Authorize,Authorize) which are AccessModes? Why not just AccessMode? |
@@ -55,13 +55,9 @@ class _NoOpContextManager(object):
pass
-if sys.version_info[0] > 2:
- # Pickling, especially unpickling, causes broken module imports on Python 3
- # if executed concurrently, see: BEAM-8651, http://bugs.python.org/issue38884.
- _pickle_lock_unless_py2 = threading.RLock()
-else:
- # Avo... | [dumps->[dumps],loads->[loads],_find_containing_class->[_find_containing_class_inner->[_find_containing_class_inner],_find_containing_class_inner],load_session->[load_session],dump_session->[dump_session],_nested_type_wrapper->[wrapper->[_is_nested_class,_find_containing_class]],_NoOpContextManager,_nested_type_wrapper... | description. Given a single object return a pickle object. Returns a class object that appears to be nested. | we could call it _pickle_lock now |
@@ -53,6 +53,7 @@ class Perl(Package): # Perl doesn't use Autotools, it should subclass Package
version('5.25.11', '37a398682c36cd85992b34b5c1c25dc1')
# Maintenance releases (even numbers, recommended)
+ version('5.28.0', sha256='7e929f64d4cb0e9d1159d4a59fc89394e27fa1f7004d0836ca0d514685406ea8')
ve... | [Perl->[activate->[perl_ignore],deactivate->[perl_ignore],configure->[configure_args,configure]]] | Create a new object of type n - length with version numbering. Creates a version of a single object given a sequence number. | why is this still the preferred version? |
@@ -528,13 +528,6 @@ func (c *Container) ContainerCreate(config types.ContainerCreateConfig) (contain
var err error
- // bail early if container name already exists
- if exists := cache.ContainerCache().GetContainerByName(config.Name); exists != nil {
- err := fmt.Errorf("Conflict. The name %q is already in use ... | [ContainerRm->[Handle],ContainerExecStart->[Handle,TaskWaitToStart,TaskInspect],TaskWaitToStart->[Handle],findPortBoundNetworkEndpoint->[defaultScope],ContainerExecInspect->[TaskInspect],containerAttach->[Handle],ContainerExecCreate->[Handle,TaskInspect],TaskInspect->[Handle],containerStart->[Handle,cleanupPortBindings... | ContainerCreate creates a container Add a container to the cache and return a ContainerCreateCreatedBody. | If you remove the check for name conflict, what do we report when someone does docker create --name "..." that conflicts? |
@@ -381,6 +381,11 @@ class PostCreator
locale: SiteSetting.default_locale
)
)
+
+ if SiteSetting.auto_close_topics_create_linked_topic?
+ # enqueue a job to create a linked topic
+ Jobs.enqueue_in(5.seconds, :create_linked_topic, post_id: @post.id)
+ end
end
en... | [PostCreator->[save_post->[skip_validations?],draft_key->[draft_key],build_post_stats->[track_post_stats],update_uploads_secure_status->[update_uploads_secure_status],store_unique_post_key->[store_unique_post_key],create!->[create!],create->[create,valid?],handle_spam->[skip_validations?,create],ensure_in_allowed_users... | auto_close_n_posts - if we have a post number with no gaps in. | Question: Why in 5 seconds? |
@@ -265,11 +265,11 @@ class Example(object):
def upload_imgs(self):
if isfile(self.img_path):
- trace("%s Uploading image to S3 to %s" % (green(">>>"), self.img_url_path))
- upload_file_to_s3(self.img_path, self.img_url_path, "image/png")
+ trace("%s Uploading image to S... | [add_examples->[Example,add_examples],Example->[relpath->[relpath],baseline_path->[relpath],image_diff->[image_diff]],collect_examples->[add_examples]] | Upload images to S3 if they exist. | I believe the paths here are the local file paths, which is why the uploads are not happening correctly |
@@ -56,12 +56,6 @@ public interface MapState<K, V> extends State {
* <p>Changes will not be reflected in the results returned by previous calls to {@link
* ReadableState#read} on the results any of the reading methods ({@link #get}, {@link #keys},
* {@link #values}, and {@link #entries}).
- *
- * <p>Sin... | [putIfAbsent->[computeIfAbsent]] | The default implementation of putIfAbsent. | We should also update the contract for `SetState#contains` to say that it also returns whether the value is there on the return of `#read`. Similar to the `#isEmpty` contract. |
@@ -1241,7 +1241,7 @@ function photos_content(App $a) {
}
$r = q("SELECT `resource-id`, `id`, `filename`, type, max(`scale`) AS `scale`, `desc` FROM `photo` WHERE `uid` = %d AND `album` = '%s'
- AND `scale` <= 4 $sql_extra GROUP BY `resource-id` ORDER BY `created` $order LIMIT %d , %d",
+ AND `scale` <= 4 $... | [photos_content->[set_pager_itemspage,set_pager_total],photos_post->[scaleImage,getExt,getWidth,rotate,getHeight,get_hostname,orient,imageString,store,is_valid]] | Photos content action if the user is a community page and the user is a community page and the user is This function is called to display a user s contact. This function is used to display a list of photos that can be uploaded. | This one shows more rows than expected. Since all the fields but `scale` are identical for the same `resource-id`, `MIN()` can be safely used. |
@@ -21,6 +21,14 @@ class Jetpack_Network {
*/
private static $instance = null;
+ /**
+ * An instance of the connection manager object.
+ *
+ * @since 7.6
+ * @var Automattic\Jetpack\Connection\Manager
+ */
+ private $connection;
+
/**
* Name of the network wide settings
*
| [Jetpack_Network->[jetpack_sites_list->[get_url],render_network_admin_settings_page->[network_admin_page_header],network_admin_page->[get_url],do_subsiteregister->[get_url]]] | Creates a new Jetpack_Network object. Add Jetpack admin bar actions. | Seems like it's 7.7 already, no? |
@@ -126,9 +126,9 @@ class TestTransposeOpError(unittest.TestCase):
self.assertRaises(TypeError, test_x_Variable_check)
def test_x_dtype_check():
- # the Input(x)'s dtype must be one of [float16, float32, float64, int32, int64]
+ # the Input(x)'s dtype must be on... | [TestTransposeOpError->[test_errors->[test_each_elem_value_check->[transpose],test_x_dtype_check->[transpose,data],test_x_Variable_check->[transpose],test_x_dimension_check->[],test_perm_length_and_x_dim_check->[transpose],test_perm_list_check->[transpose],data,assertRaises,enable_static,program_guard,Program]],TestTra... | Checks that errors in the sequence are raised. | bool int8 ? bool ? |
@@ -419,7 +419,7 @@ public class LibvirtVMDef {
public static class DiskDef {
public enum DeviceType {
- FLOPPY("floppy"), DISK("disk"), CDROM("cdrom");
+ FLOPPY("floppy"), DISK("disk"), CDROM("cdrom"), LUN("lun");
String _type;
DeviceType(String type) {... | [LibvirtVMDef->[HyperVEnlightenmentFeatureDef->[toString->[toString]],VirtioSerialDef->[toString->[toString]],ClockDef->[toString->[toString],setTimer->[setTimer]],FilesystemDef->[toString->[toString]],addComp->[toString],VideoDef->[toString->[toString]],GraphicDef->[toString->[toString]],CpuTuneDef->[toString->[toStri... | Method to create a GuestDef object that represents a single . This method returns a string representation of the object. | So why is the LUN type added here? |
@@ -207,6 +207,10 @@ public abstract class AbstractTestRestApi {
LOG.info("Staring test Zeppelin up...");
ZeppelinConfiguration conf = ZeppelinConfiguration.create();
+ if (withDynamicPool) {
+ System.setProperty("org.quartz.properties", "./quartz.properties");
+ }
+
if (withAuth... | [AbstractTestRestApi->[startUp->[start],isNotAllowed->[responsesWith],isCreated->[responsesWith],isNotFound->[responsesWith],httpDelete->[httpDelete],isBadRequest->[responsesWith],shutDown->[shutDown],startUpWithAuthenticationEnable->[start],httpPut->[httpPut],isForbidden->[responsesWith],startUpWithKnoxEnable->[start]... | Starts the Zeppelin server. This method creates a test environment and starts Zeppelin server if it is not. | just to check, is `./` going to the right path? |
@@ -38,7 +38,7 @@ frappe.views.CommunicationList = Class.extend({
clear_list: function() {
this.body.remove();
$("<p class='text-muted'>" + __("No Communication tagged with this ")
- + this.doc.doctype +" yet.</p>").appendTo(this.wrapper);
+ + __(this.doc.doctype) + __(" yet.") + "</p>").appendTo(this.wrapp... | [No CFG could be retrieved] | Communication List Class create a comment composer. | `+ __("No Communication tagged with this {0} yet.", [__(this.doc.doctype)]) + "</p>"` |
@@ -53,12 +53,12 @@ if ($vars['view'] == 'prefixes_ipv4unicast') {
echo ' | ';
-if ($vars['view'] == 'prefixes_vpnv4unicast') {
+if ($vars['view'] == 'prefixes_ipv4vpn') {
echo "<span class='pagemenu-selected'>";
}
-echo generate_link('VPNv4', $link_array, array('view' => 'prefixes_vpnv4unicast'));
-if ($v... | [No CFG could be retrieved] | Generate a link to a specific BGP node. Print the header for a network network network network network network network network network network network network network. | How come you've changed the names of these? |
@@ -1644,7 +1644,11 @@ static int ocsp_server_cb(SSL *s, void *arg)
if (!TEST_ptr(copy = OPENSSL_memdup(orespder, sizeof(orespder))))
return SSL_TLSEXT_ERR_ALERT_FATAL;
- SSL_set_tlsext_status_ocsp_resp(s, copy, sizeof(orespder));
+ if (!TEST_true(SSL_set_tlsext_status_ocsp_resp(s, copy, sizeof(or... | [No CFG could be retrieved] | The client side of the server side. This function returns 1 if the server has the tlsext_status_type and 2. | Two more spaces, both lines |
@@ -78,7 +78,7 @@ class SeoTwigExtension extends \Twig_Extension
public function renderSeoTags(array $seoExtension, array $content, array $urls, $shadowBaseLocale)
{
$request = $this->requestStack->getCurrentRequest();
- $requestSeo = $request->get('_seo', []);
+ $requestSeo = $request-... | [SeoTwigExtension->[renderCanonicalTag->[getContentPath],renderAlternateLink->[getContentPath],renderMetaTags->[renderMetaTag],renderAlternateLinks->[getLocalization,getResourceLocator,getPortal,renderAlternateLink],renderSeoTags->[renderTitle,getScheme,renderCanonicalTag,renderMetaTags,getCurrentRequest,get,getKey,ren... | Renders SEO tags. | We should be more explicit about where to get our request data from in general. |
@@ -54,6 +54,8 @@ class JvmPlatform(Subsystem):
help='Compile settings that can be referred to by name in jvm_targets.')
register('--default-platform', advanced=True, type=str, default=None, fingerprint=True,
help='Name of the default platform to use if none are specified.')
+ regist... | [JvmPlatform->[default_platform->[IllegalDefaultPlatform],platforms_by_name->[_parse_platform],get_platform_by_name->[UndefinedJvmPlatform],get_platform_for_target->[get_platform_by_name]],JvmPlatformSettings->[_validate_source_target->[IllegalSourceTargetCombination],__init__->[parse_java_version]]] | Register options for the command line tool. | Would be good to expand the help here to better differentiate it from the runtime platform. |
@@ -96,6 +96,7 @@ export let InteractiveReactData;
* canShowSharingUis: boolean,
* canShowSystemLayerButtons: boolean,
* customControls: !Array<!Object>,
+ * playerHasNextStoryState: boolean,
* accessState: boolean,
* adState: boolean,
* pageAttachmentState: boolean,
| [No CFG could be retrieved] | Component configuration for AMP story. The state of the story. | As seen offline, let's get the Player to send a new configuration that can add/remove/enable/disable buttons. |
@@ -146,12 +146,12 @@ func (esprofile *ESInspecProfile) parseInspecProfile(profile inspec.Profile) err
}
var refs string
byteRefs, _ := json.Marshal(control.Refs)
- json.Unmarshal(byteRefs, refs) // nolint: errcheck
+ json.Unmarshal(byteRefs, &refs) // nolint: errcheck
esControl.Refs = refs
var tags ... | [StoreProfile->[parseInspecProfile],parseInspecProfile->[setDefaultValues],GetProfile->[convertToInspecProfile]] | parseInspecProfile parses an inspec profile into an ES profile This function is used to populate the object that contains all the data that can be read from. | All these nolint: errcheck's make me nervous but it is existing code so I think we should leave it. |
@@ -1195,12 +1195,12 @@ export class AmpAdNetworkDoubleclickImpl extends AmpA4A {
});
}
+ /** @override */
getPreconnectUrls() {
- const urls = ['https://partner.googleadservices.com'];
if (this.preloadSafeframe_) {
- urls.push(SAFEFRAME_ORIGIN);
+ this.preconnect.preload(this.getSaf... | [AmpAdNetworkDoubleclickImpl->[postTroubleshootMessage->[dev,dict,stringify,now,userAgent],extractSize->[height,extractAmpAnalyticsConfig,get,setGoogleLifecycleVarsFromHeaders,width],getBlockParameters_->[serializeTargeting_,dev,user,isInManualExperiment,Number,assign,join,googleBlockParameters,getMultiSizeDimensions,m... | Initialize SRA requests. Retrieve a single n - block from the SRA and stream the response into a promise chain Get non - ad - creative rendering method. | Why do we have both `getSafeframePath_` and `SAFEFRAME_ORIGIN`? |
@@ -5,6 +5,13 @@ def main() -> None:
import gevent.monkey
gevent.monkey.patch_all()
+
+ import asyncio # isort:skip # noqa
+ import raiden.network.transport.matrix.rtc.aiogevent as aiogevent # isort:skip # noqa
+
+ asyncio.set_event_loop_policy(aiogevent.EventLoopPolicy()) # isort:skip # noqa
+ ... | [main->[patch_all,run],main] | Run the command line interface. | This code is repeated a lot in the `tools`. Sounds like a good candidate to move to a utility function. |
@@ -47,7 +47,10 @@ func NewRepoRedirect(ownerID, repoID int64, oldRepoName, newRepoName string) err
LowerName: oldRepoName,
RedirectRepoID: repoID,
}); err != nil {
- sess.Rollback()
+ err = sess.Rollback()
+ if err != nil {
+ return err
+ }
return err
}
return sess.Commit()
| [Rollback,Commit,Begin,ToLower,Close,Delete,Insert,Get,NewSession] | deleteRepoRedirect deletes any redirect from the specified owner to the specified repo name to any other. | This if statement is not necessary because no matter the outcome err will be returned |
@@ -174,7 +174,7 @@ type logMsg struct {
// it can contain several providers and log message into all providers.
type Logger struct {
adapter string
- lock sync.Mutex
+ lock sync.RWMutex
level int
msg chan *logMsg
outputs map[string]LoggerInterface
| [Flush->[Flush],Fatal->[Close,writerMsg],Trace->[writerMsg],Info->[writerMsg],Critical->[writerMsg],Error->[writerMsg],Warn->[writerMsg],Close->[Flush],Debug->[writerMsg]] | Fatal is a fatal function that logs a message at the given level skipping the given number of newLogger creates a new logger instance with given buffer. | Is this the lock for the logger struct or for outputs? |
@@ -33,15 +33,10 @@ public class TerritoryAttachment extends DefaultAttachment {
final PlayerAttachment pa = PlayerAttachment.get(player);
if (pa == null) {
- if (!capitalsListOriginal.isEmpty() && capitalsListOwned.isEmpty()) {
- return false;
- }
+ return capitalsListOriginal.isEmpty... | [TerritoryAttachment->[getUnitProduction->[getUnitProduction,get],setChangeUnitOwners->[add],getWhatTerritoriesThisIsUsedInConvoysFor->[getConvoyRoute,get,add],setWhenCapturedByGoesTo->[add],setCaptureUnitOnEnteringBy->[add],getProduction->[getProduction,get],setConvoyAttached->[add],toStringForInfo->[getOriginalOwner,... | Checks if we have enough capitals to produce. | The explicit else becomes redundant here as well. |
@@ -313,5 +313,10 @@ func dataSourceAwsDbInstanceRead(d *schema.ResourceData, meta interface{}) error
return fmt.Errorf("Error setting vpc_security_groups attribute: %#v, error: %#v", vpcSecurityGroups, err)
}
+ // Fetch and save tags
+ if err := saveTagsRDS(conn, d, aws.StringValue(dbInstance.DBInstanceArn)); e... | [Printf,StringValueSlice,Sprintf,DescribeDBInstances,String,Errorf,SetId,Get,Set] | vpc_security_groups attribute returns nil if error. | Nit: In the future we will be requiring returning an error instead of just logging these |
@@ -4,6 +4,7 @@ from conans.client.command import main
def run():
+ input("Attach the debugger and press a key")
main(sys.argv[1:])
| [run->[main],run] | Run the command line interface. | Forget this. for debugging purpose. |
@@ -1082,7 +1082,8 @@ ring_obj_layout_fill(struct pl_map *map, struct daos_obj_md *md,
layout->ol_shards[k].po_target = tgt->ta_comp.co_id;
layout->ol_shards[k].po_fseq = tgt->ta_comp.co_fseq;
- if (pool_target_unavail(tgt)) {
+ if (pool_target_unavail(tgt) && !(ignore_up == true &&
+ tgt->ta_comp.c... | [No CFG could be retrieved] | return - 1 if no match function to find the object in the ring. | (style) line over 80 characters |
@@ -218,15 +218,15 @@ public abstract class AbstractListenerImpl {
this.subject = subject;
}
- public void invoke(final Object event) {
+ public void invoke(final T event) {
invoke(event, false, true);
}
- public void invoke(final Object event, boolean isLocalNodePri... | [AbstractListenerImpl->[removeListenerInvocation->[getListenerCollectionForAnnotation],getRealException->[getRealException],validateAndAddListenerInvocation->[getAllowedMethodAnnotations],ListenerInvocation->[invoke->[run->[invoke,removeListener,suspendIfNeeded,resumeIfNeeded],invoke]],addListener->[addListener],addLis... | Invokes the method. check if there is a race condition. | why `T` and not `Event<K,V>`? |
@@ -1044,6 +1044,18 @@ int ssl_add_clienthello_tlsext(SSL *s, WPACKET *pkt, int *al)
break;
}
}
+ } else if (s->version >= TLS1_3_VERSION) {
+ /*
+ * TODO(TLS1.3): We always use ECC for TLSv1.3 at the moment. This will
+ * change if we implement DH key sh... | [No CFG could be retrieved] | Checks if a given key is not disabled on the connection. This function checks if the given extension block contains duplicate extensions. | We could make Configure enable-tls1_3 force enable-ec |
@@ -440,7 +440,6 @@ const htmlFixtureGlobs = [
'!examples/visual-tests/amp-story/amp-story-grid-layer-template-horizontal.html',
'!examples/visual-tests/amp-story/amp-story-grid-layer-template-thirds.html',
'!examples/visual-tests/amp-story/amp-story-grid-layer-template-vertical.html',
- '!examples/visual-tes... | [No CFG could be retrieved] | Renders the AMP story player. Renders the AMP story. | Since these tests are specifically for `amp-story-outlink-page-attachment-v2` I think it is worth making a new html template for these tests and leaving the original `amp-story-page-attachment.html` template untouched. |
@@ -15,9 +15,9 @@
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
GNU General Public License for more details.
- You should have received a copy of the GNU General Public License
- along with PHP-gettext; if not, write to the Free Software
- Foundation, Inc., 59 Temple Place, Suite 330, Bo... | [gettext_reader->[get_plural_forms->[get_translation_string,extract_plural_forms_header_from_po_header,sanitize_plural_expression,load_tables],load_tables->[readintarray,read],pgettext->[translate],ngettext->[find_string,select_string,get_translation_string],translate->[find_string,get_translation_string,load_tables],f... | This class is used to read a single non - empty n - ary object from a file region PluralFormTranslation functions. | This is third party library, please do not change it. |
@@ -113,4 +113,13 @@ public final class MigrationsUtil {
}
return options;
}
+
+ public static KsqlRestClient createRestClient(final MigrationConfig config) {
+ return KsqlRestClient.create(
+ config.getString(MigrationConfig.KSQL_SERVER_URL),
+ Collections.EMPTY_MAP,
+ Collections... | [MigrationsUtil->[getKsqlClient->[getKsqlClient]]] | Creates a client options object with the specified parameters. | We need to support auth here. |
@@ -153,7 +153,7 @@ module View
end
@revenue =
- if revenues.values.uniq.size == 1
+ if revenues.values.uniq.one?
revenues.values.uniq.first
else
revenues
| [Revenue->[load_from_tile->[empty?,size,uniq,sum,first,name,puts],preferred_render_locations->[multi_revenue?],should_render?->[include?],render_part->[h,multi_revenue?],multi_revenue?->[is_a?]],require] | Load the data from a in the current Tile object. | did you miss this? values uniq twice |
@@ -93,6 +93,18 @@ public interface FlowFileQueue {
QueueSize size();
+ /**
+ * @param fromTimestamp The timestamp in milliseconds from which to calculate durations. This will typically be the current timestamp.
+ * @return the sum in milliseconds of how long all FlowFiles within this queue have cur... | [No CFG could be retrieved] | Returns true if queue is empty. | I'm not sure what exactly it means for the max active queued duration to take into account a timestamp... it makes a lot more sense to me to accept no arguments here at all, and to instead just use the current time. Or, alternatively, to return the timestamp of the longest-queued FlowFile. |
@@ -326,8 +326,8 @@ void ossl_provider_free(OSSL_PROVIDER *prov)
* When the refcount drops below two, the store is the only
* possible reference, or it has already been taken away from
* the store (this may happen if a provider was activated
- * because it's a fallback, but isn't c... | [No CFG could be retrieved] | Frees all the memory associated with an OSSL provider. Frees all the memory associated with an object. | _deactivated_ instead of _inactivated_? It could also be _made inactive_. |
@@ -113,7 +113,10 @@ module.exports = webpackMerge(commonConfig({ env: ENV }), {
parallel: true,
cache: true,
terserOptions: {
+ ecma: 6,
ie8: false,
+ toplevel: true,
+ module: true,
... | [No CFG could be retrieved] | Configures the plugin to use the given filter for missing dependencies. Plugins for the module. | why are we adding those two options ? |
@@ -325,7 +325,7 @@ module GobiertoBudgets
query = {
sort: [
{ code: { order: 'asc' } },
- { ine_code: { order: 'asc' }}
+ { organization_id: { order: 'asc' }}
],
query: {
filtered: {
| [all->[functional_codes_for_economic_budget_line],compare->[search],any_data?->[search],budget_line_query->[search,for_ranking],top_differences->[search],search->[search]] | Compare the missing missing terms with the missing terms in the order they appear in the index. | Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.<br>Space inside } missing. |
@@ -71,7 +71,9 @@ func (e *TrackEngine) Run(ctx *Context) error {
upk := ieng.Result().Upk
var err error
- e.them, err = libkb.LoadUser(libkb.NewLoadUserByUIDArg(ctx.GetNetContext(), e.G(), upk.Uid))
+ loadarg := libkb.NewLoadUserByUIDArg(ctx.GetNetContext(), e.G(), upk.Uid)
+ loadarg.PublicKeyOptional = true
+ e... | [Run->[NewLoadUserByUIDArg,Result,G,New,GetNetContext,ConfirmResult,LoadUser,TrackToken,Debug],NewContextified] | Run executes the TrackEngine. | Make a helper for this --- `NewLoadUserByUIDOptionalPublicKeyArg` ? |
@@ -150,7 +150,11 @@ public class FnHarness {
RegisterHandler fnApiRegistry = new RegisterHandler();
BeamFnDataGrpcClient beamFnDataMultiplexer =
- new BeamFnDataGrpcClient(options, channelFactory::forDescriptor, outboundObserverFactory);
+ new BeamFnDataGrpcClient(
+ opti... | [FnHarness->[main->[getApiServiceDescriptor,main]]] | Main entry point for the BeamFn API. | We should set channelFactory.withInterceptors earlier and share it across all our services. This will allow us to clean up BeamFnControlClient and stop passing in the id as the channelFactory will already have it. |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.