patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -135,6 +135,9 @@ public class ArtifactArchiver extends Recorder implements SimpleBuildStep {
if (defaultExcludes == null){
defaultExcludes = true;
}
+ if (caseSensitive == null) {
+ caseSensitive = true;
+ }
return this;
}
| [ArtifactArchiver->[perform->[perform,listenerWarnOrError],Migrator->[onLoaded->[setFingerprint]]]] | readResolve - This method is called by the readResolve method of the artifact manager. | The same patch should be applied to <code>readResolve()</code>. De-serialization from XML does not call constructor, hence <code>caseSensitive</code> may be null in such case |
@@ -222,7 +222,7 @@ namespace System.Drawing.Printing
}
}
public
- string PrintFileName
+ string? PrintFileName
{
get { return print_filename; }
set { print_filename = value; }
| [PrinterSettings->[PaperSourceCollection->[Clear->[Clear],Add->[Add],CopyTo->[CopyTo]],StringCollection->[Add->[Add],CopyTo->[CopyTo],Add],PrinterResolutionCollection->[Clear->[Clear],Add->[Add],CopyTo->[CopyTo],Add],PaperSizeCollection->[Clear->[Clear],Add->[Add],CopyTo->[CopyTo],Add]]] | Replies the set of all the properties of the object. Replies if the print_tofile and print_tofile attributes are set. | NIT: maybe delete the new line? |
@@ -135,7 +135,17 @@ int RelayHandler::handle_output(ACE_HANDLE)
int idx = 0;
for (ACE_Message_Block* block = out.second.get(); block && idx < BUFFERS_SIZE; block = block->cont(), ++idx) {
buffers[idx].iov_base = block->rd_ptr();
+#ifdef _MSC_VER
+#pragma warning(push)
+ // iov_len is 32-bit on 64... | [No CFG could be retrieved] | Handle incoming and outgoing ethernet messages. Enqueue message on the network. | Is there something still TODO here? |
@@ -1478,12 +1478,14 @@ func processVolumeParam(volString string) (volumeFields, error) {
func processVolumeFields(volumes []string) (map[string]volumeFields, error) {
volumeFields := make(map[string]volumeFields)
- for _, v := range volumes {
+ for i, v := range volumes {
fields, err := processVolumeParam(v)
... | [Stop->[Handle,CommitContainerHandle],Rename->[Handle],Signal->[State],exitCode->[State],Wait->[State],AttachStreams->[Wait],State] | processVolumeFields parses the volume parameters specified in a create or run - v and returns a over anonymous volumes returns a list of all anonymous volumes and nil if there are no anonymous volumes. | this should be deleted |
@@ -548,10 +548,7 @@ class TransformerEncoder(nn.Module):
return output
elif self.reduction_type is None or 'none' in self.reduction_type:
output = tensor
- ret = (output, mask)
- if self.reduction_type == 'none_with_pos_embs':
- ret = (output, mas... | [TransformerEncoderLayer->[forward->[_normalize]],MultiHeadAttention->[forward->[prepare_head]],TransformerEncoder->[forward->[_normalize],__init__->[create_position_codes]],TransformerGeneratorModel->[reorder_decoder_incremental_state->[reorder_incremental_state],__init__->[_build_decoder,_build_encoder,_create_embedd... | Forward pass of the embedding model. Returns the output of the n - node tensor and the mask. | might as well make it `return tensor, mask` and delete the line above i reckon |
@@ -277,6 +277,10 @@ def main(args):
model_ema.load_state_dict(checkpoint["model_ema"])
if args.test_only:
+ # We disable the cudnn benchmarking because it can noticeably affect the accuracy
+ torch.backends.cudnn.benchmark = False
+ torch.backends.cudnn.deterministic = True
+
... | [load_data->[_get_cache_path],main->[load_data,evaluate,train_one_epoch],get_args_parser,main] | Main function for training a single . Add a cross entropy loss criterion to the model. Train a single node in the model. Evaluate the non - zero NK node in the model. | I deliberately choose not to set `torch.use_deterministic_algorithms(True)` here because: - just removing the cudnn bencharmking is enough to get constant results, at least for resnet18 (maybe not for others) - using `torch.use_deterministic_algorithms(True)` forces the user to set some env variables like `CUBLAS_WORKS... |
@@ -11,10 +11,6 @@ module Verify
finish_proofing_success
end
- def continue
- redirect_to after_sign_in_path_for(current_user)
- end
-
private
def track_final_idv_event
| [ConfirmationsController->[track_final_idv_event->[track_event,present?],continue->[redirect_to,after_sign_in_path_for],finish_proofing_success->[recovery_code,complete_profile,clear,reset],before_action,include]] | checks if a user has a missing idv_event object and if so redirects to the. | my memory is that this route was here to provide a target for after a user has confirmed receipt of their personal key (recovery code) after finishing the IdV process. Are we handling that personal key process differently now? |
@@ -383,14 +383,11 @@ static void find_modes(struct decim_modes *modes, uint32_t fs, int di)
* is possible. Then check that CIC decimation constraints
* are met. The passed decimation modes are added to array.
*/
- j = 0;
- /* Loop until NULL */
- while (fir_list[j]) {
+ for (j = 0; fir_list[j]; j++) {
... | [No CFG could be retrieved] | Checks that the specified is met by checking that the specified CIC and FIR Match the given modes. | I suppose this works but what is the improvement? |
@@ -229,12 +229,13 @@ async function executeTransfer(transfer, opts) {
const event = {
userId: user.id,
action: eventAction,
- data: JSON.stringify({
- transferId: transfer.id
- })
+ data: {
+ transferId: transfer.id,
+ failureReason: failureReason
+ }
}
... | [No CFG could be retrieved] | Updates the status of the in the transfer table. | this is conditionally set at line 23 below so remove? |
@@ -376,7 +376,7 @@ func (s *state) GetRule(ctx context.Context, req *api.GetRuleReq) (*api.GetRuleR
"error retrieving rule with ID %q: %s", req.Id, err.Error())
}
if resp.Deleted {
- return nil, status.Errorf(codes.NotFound, "could not find rule with ID %q", req.Id)
+ return nil, status.Errorf(codes.NotFound... | [ListProjects->[ListProjects],DeleteRule->[DeleteRule],DeleteProject->[DeleteProject],CreateProject->[CreateProject],UpdateRule->[UpdateRule],CreateRule->[CreateRule],ListRules->[ListRules],ListProjectsForIntrospection->[ListProjects],GetProject->[GetProject],ListRulesForProject->[ListRulesForProject],UpdateProject->[U... | GetRule returns a single rule from the store. | We updated the error in `UpdateRule` to be more transparent-- a rule marked for deletion is essentially "Not Found" (cannot be deleted, will not be displayed on the UI), so we backtracked and modified `CreateRule` as well. |
@@ -84,6 +84,8 @@ def pick_channels(ch_names, include, exclude=[]):
sel : array of int
Indices of good channels.
"""
+ if len(np.unique(ch_names)) != len(ch_names):
+ raise RuntimeError('ch_names is not a unique list, picking is unsafe')
sel = []
for k, name in enumerate(ch_names)... | [pick_types_forward->[pick_types,pick_channels_forward],pick_channels_cov->[pick_channels],channel_indices_by_type->[channel_type],pick_channels_forward->[pick_channels],pick_channels_evoked->[pick_info,pick_channels],pick_types->[pick_channels],pick_types_evoked->[pick_channels_evoked,pick_types]] | Pick channels by names . | Turns out this was my error, because I ended up making non-unique channel names. This saves other users from the same potential pain later. (`pick_types` even runs through this function, so it should be caught there as well.) |
@@ -202,6 +202,13 @@ function jetpack_load_xsl( $type = '' ) {
$transient_xsl = empty( $type ) ? 'jetpack_sitemap_xsl' : "jetpack_{$type}_sitemap_xsl";
+ /**
+ * Filter transient name.
+ *
+ * @module sitemaps
+ */
+ $transient_xsl = apply_filters( 'jetpack_sitemap_xsl_transient', $transient_xsl );
+
$xsl =... | [jetpack_sitemap_array_to_simplexml->[addChild,getDocNamespaces],jetpack_sitemap_initstr->[using_index_permalinks,using_permalinks],jetpack_news_sitemap_uri->[using_index_permalinks,using_permalinks],jetpack_sitemap_uri->[using_index_permalinks,using_permalinks],jetpack_print_sitemap->[asXML,prepare,get_results],jetpac... | Load the XSL for the current page. | The `$transient_xsl` parameter must be added in the inline doc. |
@@ -38,6 +38,16 @@ func doTest(bldPrefix, debugStr string, same bool, oc *exutil.CLI) {
// corrupt the builder image
exutil.CorruptImage(fullImageName, corruptor)
+ if bldPrefix == buildPrefixFC || bldPrefix == buildPrefixTC {
+ // grant access to the custom build strategy
+ err := oc.AsAdmin().Run("adm").Args(... | [Context,By,DumpAndReturnTagging,StartBuildAndWait,Expect,HaveOccurred,FixturePath,VerifyImagesSame,ResetImage,It,Args,CorruptImage,ExpectWithOffset,CreateResource,Namespace,VarSubOnFile,ArtifactPath,Output,NewCLI,BeforeEach,AssertSuccess,ServiceAccounts,JustBeforeEach,PullImage,WaitForBuilderAccount,AdminKubeREST,NotT... | doTest - test for missing tagging This is a quick fix for the case where we build a specific builder image only once. | that is, put the defer right here. |
@@ -49,11 +49,11 @@ class PasswordForm(SignupForm):
self.fields['email'].widget = forms.HiddenInput()
-class OrderNoteForm(forms.ModelForm):
+class CustomerNoteForm(forms.ModelForm):
+ customer_note = forms.CharField(
+ max_length=250, required=False, strip=True, label=False,
+ widget=form... | [PasswordForm->[__init__->[HiddenInput,super]],PaymentDeleteForm->[save->[save],clean->[pgettext_lazy,error_class,get,filter,super],__init__->[super,pop],HiddenInput,IntegerField],PaymentMethodsForm->[ChoiceField,pgettext_lazy],OrderNoteForm->[Meta->[Textarea,pgettext_lazy]]] | Form for a OrderNote. | Aren't we missing a label here? |
@@ -8,10 +8,8 @@ describe "pro request list" do
let!(:pro_user_session) { login(pro_user) }
let!(:info_requests) do
requests = []
- TestAfterCommit.with_commits(true) do
- requests = FactoryBot.create_list(:info_request, 3, user: pro_user,
- :public_body => publ... | [visit,awaiting_response,create,let,describe,with_commits,create_batch!,check,first,it,name,show_request_path,using_pro_session,to,have_content,have_field,before,click_link,let!,require,last,l,strftime,dirname,have_link,update,now,each,title,id,have_css,within,not_to,login,url_title,eq,sent_at,create_list,reload,expand... | shows requests that have been made includes batch requests alongside other requests. | Align the elements of a hash literal if they span more than one line.<br>Use the new Ruby 1.9 hash syntax. |
@@ -133,4 +133,17 @@ public class Debug
}
devlog(format);
}
+
+ public static void logToRConsole(String message)
+ {
+ Element consoleEl = Document.get().getElementById("rstudio_console_output");
+ if (consoleEl == null)
+ return;
+
+ Element textEl = Document.get()... | [Debug->[logAttachDetachException->[logAttachDetachException,devlog],logException->[log],printValue->[log],logError->[log],printStackTrace->[log],devlog->[devlog,log],devlogf->[devlog],log->[log],dump->[log]]] | Devlogf with format string. | Nice! I've wanted this one for a long time :-) |
@@ -174,12 +174,13 @@ func NewPipelineInput(repoName string, glob string) *pps.PipelineInput {
// CreateJob creates and runs a job in PPS.
// This function is mostly useful internally, users should generally run work
// by creating pipelines as well.
-func (c APIClient) CreateJob(pipeline string, outputCommit *pfs.C... | [FlushJob->[FlushJob],GetLogs->[GetLogs],DeleteJob->[DeleteJob],InspectJob->[InspectJob],InspectPipeline->[InspectPipeline],RestartDatum->[RestartDatum],RunPipeline->[RunPipeline],ListPipeline->[ListPipeline],InspectJobOutputCommit->[InspectJob],GarbageCollect->[GarbageCollect],StopJob->[StopJob],CreatePipeline->[Creat... | CreateJob creates a new job in the pipeline. | The parameters would be a little cleaner like this `outputCommit, statsCommit *pfs.Commit`. |
@@ -26,8 +26,11 @@ final class TracingInterceptor implements Interceptor {
@Override
public Response intercept(Chain chain) throws IOException {
- Context parentContext = Context.current();
Request request = chain.request();
+ Context parentContext = TracingCallFactory.getCallingContextForRequest(req... | [TracingInterceptor->[intercept->[request,start,proceed,injectContextToRequest,current,shouldStart,end,makeCurrent],injectContextToRequest->[build,inject,newBuilder]]] | Intercepts a chain of requests. | does this seem like the right default, or should we not try to propagate at all if we don't have one in the cache? |
@@ -183,6 +183,7 @@ func ExtensionInit(homeDir string, mobileSharedHome string, logFile string, runM
PayloadCacheSize: 50,
ProofCacheSize: 50,
OutboxStorageEngine: "files",
+ EnableBotLiteMode: true,
}
if err = kbCtx.Configure(config, usage); err != ni... | [OnConnect->[AuthenticateSessionToken,Token,ToBytes,UID,GetUID,G,New,GetEnv,SessionToken,String,Eq],trigger->[String,Lock,Unlock],listenFor->[String,Lock,Unlock],NewChatActivity->[trigger,FailedMessage,Background,New,ActivityType,G,IncomingMessage,String,GetOutboxID,IsOutbox,Debug],NewOutboxID,ReadShared,GetServers,Flu... | Initialize the context for a unique identifier. UIRouter sets up UIRouter and sets up all the necessary components for the . | Is this turning on the botlite mode for mobile? |
@@ -856,8 +856,16 @@ func (display *ProgressDisplay) processNormalEvent(event engine.Event) {
// Note: we should probably make sure we don't get any prelude events
// once we start hearing about actual resource events.
- payload := event.Payload.(engine.PreludeEventPayload)
- display.writeSimpleMessage(render... | [filterOutUnnecessaryNodesAndSetDisplayTimes->[filterOutUnnecessaryNodesAndSetDisplayTimes],processEvents->[processNormalEvent,processEndSteps,processTick],processEndSteps->[refreshAllRowsIfInTerminal,writeSimpleMessage,refreshSingleRow,writeBlankLine],handleSystemEvent->[refreshAllRowsIfInTerminal,writeSimpleMessage],... | processNormalEvent processes a normal event and renders it to the console. This is a hack to make sure that the stack is not running and that the user doesn Handles the event that is generated by the resource output table. | another option is to forward this as an ephemeral message to the root resource. so it still shows up somewhere, but doesn't impact the display. But this is a reasonable place to start. |
@@ -38,10 +38,11 @@ type Config struct {
OutputDirectory string
Concurrency int
- ChunkCacheConfig cache.Config
- UploadBlock bool
- DeleteLocalBlock bool
- SeriesBatchSize int
+ ChunkCacheConfig cache.Config
+ UploadBlock bool
+ DeleteLocalBlock bool
+ SeriesBatchSize int
+ TimestampToler... | [cleanupFn->[RemoveAll,Wrapf,Join,IsDir,Name,ReadDir,Log,Info,HasSuffix],ProcessPlanEntries->[finishBlock,RemoveAll,Join,Stop,Warn,NewUserBucketClient,Wait,Go,WithContext,createChunkClientForDay,String,Log,Wrap,Info,Set,Add],createChunkClientForDay->[Unix,Format,NewChunkClient,Errorf,Wrap],RegisterFlags->[StringVar,Reg... | RegisterFlags registers flags for the config. | I would make it a `time.Duration`. Would be easier to understand how to use it. |
@@ -730,6 +730,11 @@ KRATOS_TEST_CASE_IN_SUITE(DataCommunicatorSendRecv, KratosMPICoreFastSuite)
std::vector<double> send_buffer_double = {2.0*world_rank, 2.0*world_rank};
std::vector<double> recv_buffer_double = {0.0, 0.0};
+ std::string send_buffer_string = "test";
+ std::string recv_buffer_string;
... | [mpi_world_communicator->[KRATOS_CHECK_EQUAL],mpi_self_communicator->[KRATOS_CHECK_EQUAL],KRATOS_CHECK_EQUAL->[KRATOS_CHECK_EQUAL]] | This function does a simple case of testing that the data communicator is in a fast if there is no match in the buffer return the missing object. | I do not resize the buffers for you (since MPI also doesn't). You need to allocate it explicitly. |
@@ -218,7 +218,7 @@ beforeEach(function() {
};
var classes = clazz.trim().split(/\s+/);
for (var i = 0; i < classes.length; ++i) {
- if (!jqLiteHasClass(actual[0], classes[i])) {
+ if (!angular.element(actual[0]).hasClass(classes[i])) {
return { pass... | [No CFG could be retrieved] | Replies the expectation that a spy was called with the specified arguments. - javascript - regex. | I guess this is a bit heavier than calling jqLiteHasClass directly, so it might make the tests run slower. |
@@ -30,6 +30,8 @@ import java.io.IOException;
*/
public class DatanodeStoreSchemaTwoImpl extends AbstractDatanodeStore {
+ private TypedTable<Long, DeletedBlocksTransaction> txnTable;
+
/**
* Constructs the datanode store and starts the DB Services.
*
| [DatanodeStoreSchemaTwoImpl->[DatanodeSchemaTwoDBDefinition]] | Construct a datanode store in accordance with schema version 2 which uses the three. | Let's rename it to deleteTransactionTable and similarly the getter can be renamed as well. |
@@ -530,8 +530,8 @@ class IStrategy(ABC):
current_time=date))
if (ask_strategy.get('sell_profit_only', False)
- and trade.calc_profit(rate=rate) <= ask_strategy.get('sell_profit_offset', 0)):
- # Negative profits and sell_profit_only ... | [IStrategy->[lock_pair->[lock_pair],is_pair_locked->[is_pair_locked],_analyze_ticker_internal->[analyze_ticker],should_sell->[SellCheckTuple],advise_indicators->[populate_indicators],analyze->[analyze_pair],advise_buy->[populate_buy_trend],unlock_pair->[unlock_pair],advise_sell->[populate_sell_trend],stop_loss_reached-... | Checks if a given node in the order should be sell or not. Return the next non - None node if the current sequence is not sell - signal or. | a probably better way would be to use `current_profit` - which is the already calculated version of this. |
@@ -40,6 +40,14 @@ type UpdateExistingConfig struct {
UpdateExisting bool
}
+// CleanupHookTaskConfig represents a cron task with settings to cleanup hook_task
+type CleanupHookTaskConfig struct {
+ BaseConfig
+ CleanupType string
+ OlderThan time.Duration
+ NumberToKeep int
+}
+
// GetSchedule returns the sc... | [FormatMessage->[Tr]] | GetSchedule returns the schedule. | As this is not used anywhere else I'd say that this could just go in to the registerCleanupHookTaskTable function (similar to the RepoHealthCheckConfig struct in registerRepoHealthCheck.) |
@@ -64,10 +64,11 @@ public class ShibbolethIdPEntityIdAuthenticationServiceSelectionStrategy impleme
final URIBuilder builder = new URIBuilder(service.getId());
final Optional<NameValuePair> param = builder.getQueryParams()
.stream()
- .filter(p -> p.get... | [ShibbolethIdPEntityIdAuthenticationServiceSelectionStrategy->[resolveServiceFrom->[debug,isPresent,get,getEntityIdAsParameter,createService,getId],supports->[concat,isPresent,matches],getEntityIdAsParameter->[getValue,split,getMessage,of,error,isPresent,findFirst,getHttpServletRequestFromExternalWebflowContext,URIBuil... | Gets entityId as parameter. | `LOGGER.debug("Found Entity Id in Service id = [{}]", param.get().getValue());` |
@@ -137,8 +137,9 @@ func (f *Field) array() common.MapStr {
func (f *Field) object() common.MapStr {
+ dynProperties := f.getDefaultProperties()
+
if f.ObjectType == "text" {
- dynProperties := f.getDefaultProperties()
dynProperties["type"] = "text"
if f.esVersion.IsMajor(2) {
| [other->[getDefaultProperties],ip->[getDefaultProperties,IsMajor],text->[process,getDefaultProperties,IsMajor],halfFloat->[getDefaultProperties,IsMajor],integer->[getDefaultProperties],object->[getDefaultProperties,IsMajor,addDynamicTemplate],keyword->[getDefaultProperties,IsMajor],scaledFloat->[getDefaultProperties,Is... | object returns the default object properties. | Each of these cases are mutually exclusive so I think a switch (or if/elseif) would be better. |
@@ -20,6 +20,7 @@ class CustomerEvents:
EMAIL_ASSIGNED = "email_assigned" # the staff user assigned a email to the customer
NAME_ASSIGNED = "name_assigned" # the staff user added set a name to the customer
NOTE_ADDED = "note_added" # the staff user added a note to the customer
+ CUSTOMER_NOTE_ADDED... | [CustomerEvents->[pgettext_lazy]] | The events of different customer events. Unhandled events are translated by the system in the case of a missing event. | This is unused now |
@@ -183,6 +183,12 @@ module Idv
client.device_type != 'desktop'
end
+ def log_document_error(get_results_response)
+ return unless get_results_response.class == Acuant::Responses::GetResultsResponse
+ Funnel::DocAuth::LogDocumentError.call(user_id,
+ ... | [DocAuthBaseStep->[post_front_image->[post_front_image],liveness_checking_enabled?->[liveness_checking_enabled?],post_images->[post_images],add_costs->[add_cost],idv_failure->[attempter_throttled?],post_back_image->[post_back_image]]] | Check if the user is a mobile device. | Direct class checks are bad IMO. I would do either: - a subclass check (`.is_a?(Acuant::Responses::GetResultsResponse)` - a `.respond_to?(:result_code)` check |
@@ -7,6 +7,8 @@ namespace System.Security.Cryptography.X509Certificates.Tests
{
internal static class TestData
{
+ private static readonly bool IsRC2Supported = !PlatformDetection.IsAndroid;
+
public static byte[] MsCertificate = (
"308204ec308203d4a003020102021333000000b011af0a8... | [TestData->[SecureString->[AppendChar,ToCharArray],DSAParameters->[X,G,Y,Q,P,HexToByteArray],AsciiBytes,HexToByteArray]] | This class returns a list of all possible certificate identifiers in a MSSQL - style manner A list of all possible tokens that can be used to generate a unique identifier. A list of all possible errors. | Could we use the existing check we have in RC2Factory, or would it be impractical to do so? |
@@ -5,8 +5,11 @@ using System.Reflection;
using ProtoCore.DSASM;
using ProtoCore.Utils;
using Autodesk.DesignScript.Runtime;
+using DesignScript.Builtin;
using ProtoCore.Properties;
using ProtoCore.Exceptions;
+using IndexOutOfRangeException = DesignScript.Builtin.IndexOutOfRangeException;
+using KeyNotFoundExcept... | [FFIConstructorInfo->[Invoke->[Invoke]],DisposeFunctionPointer->[Execute->[InvokeFunctionPointerNoThrow,IsWrapperOf]],CLRFFIFunctionPointer->[Execute->[InvokeFunctionPointerNoThrow,GetParameters],GetHashCode->[GetHashCode],InvokeFunctionPointerNoThrow->[ReduceReturnedCollectionToSingleton,InvokeFunctionPointer],InvokeF... | FFIParameterInfo provides a class which provides the FFI parameters and attributes that apply to Returns the object that can be used to generate the rank of the object. | Can you make sure the usings are sorted? |
@@ -915,6 +915,10 @@ Spdp::handle_auth_request(const DDS::Security::ParticipantStatelessMessage& msg)
if (iter != participants_.end()) {
if (msg.message_identity.sequence_number <= iter->second.auth_req_sequence_number_) {
+ if (DCPS::security_debug.auth_debug) {
+ ACE_DEBUG((LM_DEBUG, ACE_TEXT("(... | [No CFG could be retrieved] | Notify Sedp of association private static int param_list = array. length - 1. | Log the sequence numbers? |
@@ -42,4 +42,8 @@ public interface ConfigurationField {
List<String> getAttributes();
Map<String, Map<String, String>> getAdditionalInformation();
+
+ default int getPosition() {
+ return 100;
+ }
}
| [No CFG could be retrieved] | Get additional information about the resource. | I think we should return `DEFAULT_POSITION` here instead. |
@@ -5305,10 +5305,14 @@ class Form
// Note: We don't need monthNames, monthNamesShort, dayNames, dayNamesShort, dayNamesMin, they are set globally on datepicker component in lib_head.js.php
if (empty($conf->global->MAIN_POPUP_CALENDAR_ON_FOCUS))
{
- $retstring.="
- showOn: 'button',... | [Form->[form_users->[select_dolusers],textwithpicto->[textwithtooltip],select_dolusers_forevent->[select_dolusers],formSelectAccount->[select_comptes],formInputReason->[selectInputReason,loadCacheInputReason],form_availability->[load_cache_availability,selectAvailabilityDelay],showFilterAndCheckAddButtons->[showFilterB... | select date based on a date set time Dolfin dolfin dolfin dolfin date - time dolfin Dodaje d ajout d un calendar JS - Calendar datepicker buttons Diese une datepicker This function is used to render a calendar. | Using dol_buildpath each time we need to show an image or change a CSS lead to slowly dramatically pages generation. Being able to have an external module to change the look of a button must be addressed with CSS. So you should find a way to add a css or id on the object so external module can overload it ith CSS. |
@@ -176,7 +176,11 @@ func (o *RemoveFromProjectOptions) Run() error {
}
if !o.DryRun {
- _, err = o.Client.RoleBindings(o.BindingNamespace).Update(&currBinding)
+ if len(currBinding.Subjects) > 0 {
+ _, err = o.Client.RoleBindings(o.BindingNamespace).Update(&currBinding)
+ } else {
+ err = o.Client.... | [Validate->[Errorf],Run->[SubjectsStrings,Fprintf,Difference,RoleBindingSorter,Reverse,BuildSubjects,Sprintf,RoleBindings,Sort,List,Insert,NewString,PrintObject,Update],Complete->[DefaultNamespace,Object,Authorization,GetFlagString,GetFlagBool,PrintObject,Errorf,OpenshiftInternalAuthorizationClient],Error,AddOutputFlag... | Run executes the removeFromProject action Removes the specified roles from the current project. from subjects and roles in the project. | These delete options should include the UID as a precondition (same with the other delete added in the last PR). |
@@ -329,16 +329,8 @@ func (ir *Runtime) LoadAllImagesFromDockerArchive(ctx context.Context, fileName
return nil, err
}
- newImages := make([]*Image, 0, len(imageNames))
- for _, name := range imageNames {
- newImage, err := ir.NewFromLocal(name)
- if err != nil {
- return nil, errors.Wrapf(err, "error retrie... | [ParentID->[ID,GetParent],LoadFromArchiveReference->[NewFromLocal],RepoDigests->[Names,Digest,Digests],InputIsID->[ID],NewFromLocal->[newImage],ImageNames->[getImage],ociv1Image->[toImageRef],LoadAllImagesFromDockerArchive->[NewFromLocal],toImageSourceRef->[ID],newFromStorage->[newImage],GetConfigBlob->[ID,toImageRef],... | LoadAllImagesFromDockerArchive loads all images from a Docker archive FromArchiveReference pulls an image from the given srcRef and writes it to the given. | Nice. Absolutely non-blocking: If I'm checking correctly, doing the same to `LoadFromArchiveReference` would allow most of the `Load` functions involved in this PR to return `[]string`, and two of the callers of `Runtime.LoadImage` would eliminate a `strings.Split` (and the third one would now contain the only `strings... |
@@ -80,7 +80,7 @@ public class DeactivateAction implements UsersWsAction {
@Override
public void handle(Request request, Response response) throws Exception {
- userSession.checkLoggedIn().checkPermission(SYSTEM_ADMIN);
+ userSession.checkLoggedIn().checkIsRoot();
String login = request.mandatoryPa... | [DeactivateAction->[selectOrganizationByUuid->[IllegalStateException,getLogin,orElseThrow],selectOrganizationsWithNoMoreAdministrators->[add,selectOrganizationUuidsOfUserWithGlobalPermission,countUsersWithGlobalPermissionExcludingUser,getId],writeResponse->[newHashSet,checkFound,write,selectByLogin,get,addAll,close,ope... | This method deactivates a user. | description should be fixed, root is now required, not 'Administer System' permission... or is that the name we give to root? |
@@ -642,3 +642,6 @@ def cbranch_or_continue(builder, cond, bbtrue):
builder.cbranch(cond, bbtrue, bbcont)
builder.position_at_end(bbcont)
return bbcont
+
+__all__ = """
+""".split()
| [for_range_slice->[append_basic_block,terminate,goto_block],if_likely->[set_branch_weight],if_unlikely->[set_branch_weight],ifelse->[append_basic_block,set_branch_weight],is_not_null->[get_null_value],ifthen->[append_basic_block,terminate,goto_block],IfBranchObj->[__exit__->[terminate]],get_strides_from_slice->[unpack_... | Branch conditionally or continue. | This looks like kind of a strange idiom... Wouldn't `__all__ = []` be more straightforward? Also, I would not bother setting **all** on modules that we don't tell people to import. There is not really any motivation for someone to write `from numba.cgutils import *`. |
@@ -1599,8 +1599,8 @@ class ICA(ContainsMixin):
ecg_ch=None, ecg_score_func='pearsonr',
ecg_criterion=0.1, eog_ch=None,
eog_score_func='pearsonr',
- eog_criterion=0.1, skew_criterion=-1,
- kurt_... | [_find_sources->[get_score_funcs],run_ica->[fit,ICA,_detect_artifacts],get_score_funcs->[_make_xy_sfunc],corrmap->[get_components,_find_max_corrs],_sort_components->[copy],ICA->[_fit->[fit],_sources_as_evoked->[_transform_evoked],_apply_epochs->[_pre_whiten,_check_exclude],_transform_raw->[_pre_whiten,_transform],_fit_... | This function is a wrapper for the ICA detection workflow. This function is used to determine which components of the CV - CAP are supported by This method detects the ICA objects that are marked for a missing node and returns them. | Why do we change the default criteria here? This would change the behavior of `detect_artifacts` between versions without any warning. |
@@ -204,6 +204,14 @@ export class ViewportImpl {
// Ignore errors.
}
}
+
+ // BF-cache navigation sometimes breaks clicks in an iframe on iOS. See
+ // https://github.com/ampproject/amphtml/issues/30838 for more details.
+ // The solution is to make a "fake" scrolling API call.
+ const ... | [No CFG could be retrieved] | Updates the visibility of the AMPDocument. Sets the visibility of the resource. | Does this run when loading from bf-cache? LGTM assuming it does. |
@@ -165,6 +165,16 @@ class WriteTables<DestinationT>
+ "but %s returned null for destination %s",
dynamicDestinations,
destination);
+ boolean destinationCoderSupportsClustering =
+ !(dynamicDestinations.getDestinationCoder() instanceof TableDestinationCoderV2);
+ ... | [WriteTables->[expand->[GarbageCollectTemporaryFiles],WriteTablesDoFn->[processElement->[PendingJobData]]]] | Processes an element of the window. Adds a pending job to load a missing key from the table. | This check will cause a runtime failure for BatchLoads if a clustered destination is produced without the relevant configuration to use the newer destination coder. |
@@ -300,7 +300,7 @@ func New(cfg Config, clientConfig ingester_client.Config, limits *validation.Ove
Namespace: "cortex",
Name: "distributor_ingester_append_failures_total",
Help: "The total number of failed batch appends sent to ingesters.",
- }, []string{"ingester", "type"}),
+ }, []string{"in... | [AllUserStats->[AllUserStats],MetricsForLabelMatchers->[ForReplicationSet,MetricsForLabelMatchers],Push->[tokenForLabels,validateSeries,tokenForMetadata,checkSample],UserStats->[ForReplicationSet,UserStats],Validate->[Validate],MetricsMetadata->[MetricsMetadata,ForReplicationSet],LabelNames->[ForReplicationSet,LabelNam... | A list of metrics that can be distributed to a user. Provides a gauge for the given node ID. | [nit] I would just call it status. |
@@ -1010,7 +1010,7 @@ public class DeckPicker extends NavigationDrawerActivity implements
@Override
public void onPostExecute(TaskData result) {
hideProgressBar();
- if (isReview) {
+ if (isReview || isBury || isSuspend) {
ope... | [DeckPicker->[handleDbError->[showDatabaseErrorDialog],exit->[exit],mediaCheck->[onPostExecute->[showMediaCheckDialog]],updateDeckList->[onPostExecute->[onCollectionLoadError,scrollDecklistToDeck]],onDestroy->[onDestroy],onOptionsItemSelected->[onOptionsItemSelected],onCreate->[onCreate],openStudyOptions->[loadStudyOpt... | This method launches a task which will undo the currently selected action. | It's not that simple.... The user could do the following steps: 1. Open browser from DeckPicker 2. Long-tap item to suspend a card 3. Press back button to return to DeckPicker 4. Press "Undo suspend" from the overflow menu If we were to accept this PR then step 4 above would lead to the Reviewer opening, which doesn't ... |
@@ -272,15 +272,6 @@ func validateBinarySource(source *buildapi.BinaryBuildSource) fielderrors.Valida
return allErrs
}
-func validateRevision(revision *buildapi.SourceRevision) fielderrors.ValidationErrorList {
- allErrs := fielderrors.ValidationErrorList{}
- if len(revision.Type) == 0 {
- allErrs = append(allErr... | [ValidatePodLogOptions,ParseDockerImageReference,DeepEqual,GetImageStreamForStrategy,SplitImageStreamTag,HasPrefix,IsDNS1123Subdomain,NewFieldRequired,BuildToPodLogOptions,Clean,Prefix,IsBuildComplete,Contains,ValidateObjectMeta,PrefixIndex,Sprintf,ValidateObjectMetaUpdate,TrimPrefix,Parse,NewFieldInvalid] | validateBinarySource validates binary build source and revision and returns validation errors. Check if the namespace is valid. | Are we giving up validating the "other stuff"? |
@@ -105,10 +105,10 @@ public final class BufferingStreamObserver<T> implements StreamObserver<T> {
// We check to see if we were able to successfully insert the poison pill at the front of
// the queue to cancel the processing thread eagerly or if the processing thread is done.
try {
- ... | [BufferingStreamObserver->[onError->[onError],onCompleted->[onCompleted]]] | This method is called when an error occurs while processing the outbound queue. It will block until. | Seems like there could be a tiny race here if the queue becomes done after checking but before offering, right? |
@@ -0,0 +1,4 @@
+#include "romac_plus.h"
+
+#ifdef __attribute__((weak)) OLED_DRIVER_ENABLE
+void oled_task_user(void)
\ No newline at end of file
| [No CFG could be retrieved] | No Summary Found. | How should this be formatted? |
@@ -36,4 +36,15 @@ class Taxonomy_Helper {
public function is_indexable( $taxonomy ) {
return ! $this->options_helper->get( 'noindex-tax-' . $taxonomy, false );
}
+
+ /**
+ * Retrieves the term description (without tags).
+ *
+ * @param int $term_id Term ID.
+ *
+ * @return string Term description (without ... | [Taxonomy_Helper->[is_indexable->[get]]] | Check if the given taxonomy is indexable. | Have you considered moving the `wp_strip_all_tags` to a string helper class? |
@@ -149,6 +149,12 @@ class Fftw(AutotoolsPackage):
options.append('--enable-mpi')
# SIMD support
+ if 'default' in self.spec.variants['simd'].value:
+ if 'x86_64' in spec.architecture.target.lower():
+ self.spec.variants['simd'].value = 'sse2,avx,avx2'
+ ... | [Fftw->[autoreconf->[autoreconf],configure->[configure]]] | Configures the object with the given options. Directory with quad. | @tkameyama this will likely cause problems: generally we cannot set variants outside of concretization, since that can lead to changing Spec hashes. Currently, there isn't support for converting a list of values to configure options so you would have to replicate the `Autotools` logic here. It can also be problematic t... |
@@ -179,6 +179,16 @@ def get_program_cache_key(feed, fetch_list):
return str(feed_var_names + fetch_var_names)
+class PreparedContext(object):
+ def __init__(self, handle, program, fetch_list, feed_var_name,
+ fetch_var_name):
+ self.handle = handle
+ self.program = program
+ ... | [Executor->[run->[global_scope,get_program_cache_key,as_numpy,run,has_feed_operators,has_fetch_operators,aslodtensor],aslodtensor->[accumulate->[accumulate],parselod->[accumulate],parselod],__init__->[Executor]],as_numpy->[as_numpy],fetch_var->[global_scope,as_numpy],scope_guard->[switch_scope]] | Initialize the object with a list of places. | Are all of them public members? |
@@ -29,8 +29,8 @@
definitions.Reverse();
- var availableStorages = Reflect<Storage>.GetEnumValues();
- var resultingSupportedStorages = new List<Storage>();
+ var availableStorages = StorageType.GetAvailableStorageTypes(); //Reflect<Storage>.GetEnumValues();
+ ... | [PersistenceStartup->[HasSupportFor->[Contains],Run->[ApplyDefaults,InfoFormat,GetSupportedStorages,ApplyActionForStorage,Reverse,Add,Contains,Name,Remove,GetEnumValues,settings,DefinitionType,Settings,Set,TryGet,SelectedStorages],GetLogger]] | Runs the action. | whats with the `//Reflect<Storage>.GetEnumValues();` ? |
@@ -118,8 +118,8 @@ class Result < ActiveRecord::Base
if marks.where(mark: nil).first &&
marking_state == Result::MARKING_STATES[:complete]
errors.add(:base, I18n.t('common.criterion_incomplete_error'))
- false
+ return false
end
- true
+ return true
end
end
| [Result->[unrelease_partial_results->[released_to_students],check_for_nil_marks->[first,t,add],get_negative_extra_points->[sum],get_total_extra_percentage_as_points->[total_mark],unrelease_results->[released_to_students,save],get_subtotal->[each,get_mark],mark_as_partial->[released_to_students,save,marking_state],stude... | Check if the result is not nil and has a non - nil or . | Redundant `return` detected. |
@@ -26,7 +26,9 @@ def main():
act=paddle.activation.Softmax())
cost = paddle.layer.classification_cost(input=inference, label=label)
- parameters = paddle.parameters.create(cost)
+ topology = paddle.topology.Topology(cost)
+
+ parameters = paddle.parameters.create(topolo... | [train_reader->[read_from_mnist],main->[event_handler->[get,mean,isinstance],train,create,keys,init,fc,classification_cost,Adam,integer_value,get,data,uniform,set,Softmax,SGD,dense_vector],main] | Main function of paddle. | Topology classmethods global functions with cost as the parameter? |
@@ -141,8 +141,14 @@ const CLOSURE_SRC_GLOBS = [
'!node_modules/core-js/modules/library/**.js',
].concat(COMMON_GLOBS);
+const THIRD_PARTY_TRANSFORM_DIRS = [
+ // JSX syntax should undergo usual transforms
+ 'third_party/optimized-svg-icons/social-share-svgs.js',
+];
+
module.exports = {
BABEL_SRC_GLOBS,
... | [No CFG could be retrieved] | The functions below are exported to the module. | For more accuracy, let's call this `THIRD_PARTY_TRANSFORM_GLOBS` |
@@ -53,9 +53,11 @@ public class HeaderExchangeServer implements ExchangeServer {
private int idleTimeout;
private AtomicBoolean closed = new AtomicBoolean(false);
- private static HashedWheelTimer idleCheckTimer = new HashedWheelTimer(new NamedThreadFactory("dubbo-server-idleCheck", true), 1,
+ privat... | [HeaderExchangeServer->[getLocalAddress->[getLocalAddress],isClosed->[isClosed],getChannelHandler->[getChannelHandler],getChannel->[getExchangeChannel],reset->[reset],getUrl->[getUrl],startClose->[startClose],startIdleCheckTask->[calculateLeastDuration,getChannels],isBound->[isBound],getChannels->[getExchangeChannels],... | Creates a header exchange server. This is a public interface to the server interface. | is an array list here a little bit over-kill? |
@@ -101,6 +101,7 @@ class PipelineClient(PipelineClientBase):
if policies is None: # [] is a valid policy list
policies = [
+ RequestIdPolicy(),
config.headers_policy,
config.user_agent_policy,
config.proxy_policy,
| [PipelineClient->[close->[__exit__],__exit__->[__exit__],__enter__->[__enter__]]] | Build a Pipeline object from the given configuration. | Please pass the kwargs to it |
@@ -175,8 +175,9 @@ public final class JRadiusServerImpl implements RadiusServer {
attributeList);
try {
+ RadiusAuthenticator thisAuth = getNewRadiusAuthenticator();
final RadiusPacket response = radiusClient.authenticate(request,
- this.radiusAuth... | [JRadiusServerImpl->[authenticate->[authenticate]]] | Authenticate the user. | this can just be named something like radiusAuthenticator |
@@ -254,7 +254,12 @@ func TestHeadTracker_StartConnectsFromLastSavedHeader(t *testing.T) {
t.Parallel()
g := gomega.NewGomegaWithT(t)
- store, cleanup := cltest.NewStore(t)
+ // Need separate db because ht.Stop() will cancel the ctx, causing a db connection
+ // close and go-txdb rollback.
+ config, _, cleanupDB ... | [EqualError,NewHash,Unlock,Order,EarliestInChain,MatchedBy,HighestSeenHead,NewGomegaWithT,Backfill,Now,NewStore,NewHeadTracker,Eventually,Set,ConnectedCount,ToInt,DisconnectedCount,Stop,Save,First,Should,ChainID,Error,New,ChainLength,UTC,LastHead,Start,IdempotentInsertHead,NotNil,Lock,Len,Run,Nil,OnNewLongestChainCount... | TestHeadTracker_StartConnectsFromLastSavedHeader test - start connect to the last saved Return returns the latest header of the chain. | Urgh. Do you think we should use channels instead of contexts for closing? Would that help? |
@@ -139,6 +139,15 @@ public class StandaloneExecutorTest {
verify(udfLoader).load();
}
+ @Test
+ public void shouldCreateProcessingLogTopic() {
+ // When:
+ standaloneExecutor.start();
+
+ // Then
+ verify(kafkaTopicClient).createTopic(eq(PROCESSING_LOG_TOPIC_NAME), anyInt(), anyShort());
+ }
+... | [StandaloneExecutorTest->[shouldLoadQueryFile->[start,parseStatements,givenQueryFileContains],shouldRunCtasStatements->[of,thenReturn,start,CreateTableAsSelect,emptyMap,execute],givenFileDoesNotExist->[getMessage,fail,delete],shouldThrowIfCanNotLoadQueryFile->[expectMessage,start,givenFileDoesNotExist,expect],shouldFai... | Checks if a missing udfs file is loaded. | Be good to have another test that proves the topic is _not_ created if the config doesn't ask for it. |
@@ -49,12 +49,6 @@ class Jetpack_Google_Analytics_Universal {
return;
}
- // At this time, we only leverage universal analytics for enhanced ecommerce. If WooCommerce is not
- // present, don't bother emitting the tracking ID or fetching analytics.js
- if ( ! class_exists( 'WooCommerce' ) ) {
- return;
- ... | [Jetpack_Google_Analytics_Universal->[maybe_track_purchases->[get_product_from_item,get_total,get_order_number,get_total_tax,get_total_shipping,get_item_total,get_currency,get_items],remove_from_cart_attributes->[get_id,get_sku,get_cart_item],listing_click->[get_id,get_title],listing_impression->[get_title],add_to_cart... | This function is called by the WordPress script to display the header of a page. async code callback. | Why remove this? Although the other change you made will prevent this class from being instantiated unless WooCommerce is active, this is a nice extra layer of protection that avoids this class becoming dependent on another class for sanity. |
@@ -32,6 +32,7 @@ def require_active_plugin(fn):
class BraintreeGatewayPlugin(BasePlugin):
+ PLUGIN_ID = "mirumee.gateway.braintree"
PLUGIN_NAME = GATEWAY_NAME
DEFAULT_CONFIGURATION = [
{"name": "Public API key", "value": None},
| [BraintreeGatewayPlugin->[refund_payment->[_get_gateway_config],capture_payment->[_get_gateway_config],get_client_token->[get_client_token,_get_gateway_config],get_payment_config->[get_client_token,_get_gateway_config],list_payment_sources->[_get_gateway_config],authorize_payment->[_get_gateway_config],void_payment->[_... | Decorator to wrap a Braintree gateway plugin. Missing parameters in order to provide a more detailed description of the configuration that Saleor should. | A gateway can be many things, maybe "mirumee.payments.braintree" (and similarly for other payment plugins)? |
@@ -94,7 +94,7 @@ func NewClientFromBytes(kubeconfig []byte, fns ...ConfigFunc) (Interface, error)
// be used.
func NewClientFromSecret(ctx context.Context, c client.Client, namespace, secretName string, fns ...ConfigFunc) (Interface, error) {
secret := &corev1.Secret{}
- if err := c.Get(ctx, kutil.Key(namespace, s... | [RESTClient,ClientConfig,RawConfig,DiscoverVersion,CompareVersions,New,NewForConfig,NewClientConfigFromBytes,Discovery,Errorf,NewNonInteractiveDeferredLoadingClientConfig,Get,InClusterConfig,Key] | NewClientFromSecret creates a new client object for a given Kubernetes Secret object. Get the rest. Config object for a given componentbaseconfig. ClientConnectionConfiguration. | Why was it changed? |
@@ -597,11 +597,11 @@ def angle(input, name=None):
For example:
- ```
- input = tf.constant([-2.25 + 4.75j, 3.25 + 5.75j], dtype=tf.complex64)
- tf.math.angle(input).numpy()
- # ==> array([2.0131705, 1.056345 ], dtype=float32)
- ```
+ >>> input = tf.constant([-2.25 + 4.75j, 3.25 + 5.75j], dtype=tf.complex6... | [reduce_max->[_ReductionDims],to_double->[cast],reduce_sum->[_ReductionDims],reciprocal_no_nan->[div_no_nan],scalar_mul_v2->[scalar_mul],tensor_equals->[equal],_ReductionDims->[range],reduce_std->[reduce_variance],reduce_all->[_may_reduce_to_scalar,_ReductionDims],accumulate_n->[add_n,_input_error],truediv->[_truediv_p... | r Returns the element - wise argument of a complex or real tensor. | I would recommend using `tf.constant([-1 + j, 2 + 2j], dtype=tf.complex64)` instead as the angles (+/- 45 degrees) are easier to recognize. Plus, then the line won't be extremely long. |
@@ -287,7 +287,6 @@ class ElggCoreGetEntitiesFromAnnotationsTest extends \ElggCoreGetEntitiesBaseTes
break;
}
- $this->assertEqual($e->guid, $order[$i]);
$this->assertEqual($values[$e->guid], $calc_value);
}
| [ElggCoreGetEntitiesFromAnnotationsTest->[testElggGetAnnotationsAnnotationNames->[createRandomAnnotations],testElggGetAnnotationsAnnotationValues->[createRandomAnnotations],testElggGetAnnotationsAnnotationOwnerGuids->[createRandomAnnotations]]] | This function is used to test the Elegg entities from the annotations calculate X Check that all the entities in an annotation are present. | Not sure what this is supposed to test, but it did break the tests. Seems like order has changed somehow. |
@@ -153,10 +153,10 @@ module Engine
neighbor.paths[np_edge].each do |np|
next if on && !on[np]
next unless lane_match?(@exit_lanes[edge], np.exit_lanes[np_edge])
- next unless tracks_match?(np, dual_ok: true)
+ next unless any_track || tracks_match?(np, dual_ok... | [Path->[rotate->[rotate],make_lanes->[decode_lane_spec],walk->[walk,tracks_match?],inspect->[single?],select->[select]]] | Walks through the network object looking for a object. | don't use unless with multiple statements |
@@ -435,7 +435,9 @@ ASN1_OCTET_STRING *X509_digest_sig(const X509 *cert)
int X509_CRL_digest(const X509_CRL *data, const EVP_MD *type,
unsigned char *md, unsigned int *len)
{
- if (type == EVP_sha1() && (data->flags & EXFLAG_SET) != 0
+ if (type != NULL
+ && EVP_MD_is_a(type, SN_... | [X509_digest_sig->[X509_digest],i2d_PKCS8PrivateKeyInfo_fp->[i2d_PKCS8_PRIV_KEY_INFO_fp],i2d_PKCS8PrivateKeyInfo_bio->[i2d_PKCS8_PRIV_KEY_INFO_bio],X509_REQ_verify->[X509_REQ_verify_ex]] | Check if a node in the CRL has a node that has a SHA1 hash. If. | Drop the outer parenthesis? |
@@ -1546,6 +1546,10 @@ else if ($id || $ref)
{
print '<div class="tabsAction">';
+ $parameters = array();
+ // Note that $action and $object may have been
+ $reshook = $hookmanager->executeHooks('addMoreActionsButtons', $parameters, $object, $action);
+
if ($object->statut == 0 && $num_prod > 0)
{
i... | [fetch,create,setDefaultLang,formconfirm,jdate,addline,create_delivery,insertExtraFields,confirmMessage,select_date,fetchObjectLinked,select_measuring_units,getNomUrl,rollback,loadExpeditions,display_incoterms,setDocModel,select_incoterms,valid,get_sousproduits_arbo,begin,addline_batch,initHooks,editfieldval,getLabelFr... | Print a list of all possible conditions for a single object. Print a list of all rights that can be granted to the creer. | Add hooks may change behaviour of application and external module. Can you add it into dev branch ? |
@@ -1247,10 +1247,11 @@ export class AmpLightboxGallery extends AMP.BaseElement {
/**
* Close gallery view
+ * @returns {!Promise}
* @private
*/
closeGallery_() {
- this.vsync_.mutate(() => {
+ return this.vsync_.mutatePromise(() => {
this.container_.removeAttribute('gallery-view');
... | [No CFG could be retrieved] | Private methods for handling keycodes. Updates timestamps for all videos in gallery thumbnails. | Should this be `this.mutateElement`? /cc @jridgewell |
@@ -27,9 +27,10 @@
<div class="row">
<div class="col-xs-12 ql-editor">
<% if strip_tags(step.description).present? %>
- <%= auto_link(step.description,
- link: :urls,
- html: { target: '_blank' }).html_safe %>
+ <%= auto_link(smart_ann... | [No CFG could be retrieved] | This is an example of how to render a step s . | Forgot the simple_format. Actually, I suggest to embed simple_format call into the smart_annotation_parser, as it should be used everytime. |
@@ -3,12 +3,17 @@
#
# SPDX-License-Identifier: (Apache-2.0 OR MIT)
+import platform
from spack.architecture import Platform, Target
from spack.architecture import OperatingSystem
class Test(Platform):
priority = 1000000
+
+ if platform.system().lower() == 'darwin':
+ binary_formats = ['mach... | [Test->[__init__->[add_target,Target,super,OperatingSystem,add_operating_system]]] | Creates a test object from a national sequence. | Shouldn't this have an `else` case to set it to `elf`? |
@@ -328,8 +328,7 @@ class User extends CommonObject
// fetch optionals attributes and labels
require_once(DOL_DOCUMENT_ROOT.'/core/class/extrafields.class.php');
$extrafields=new ExtraFields($this->db);
- $extralabels=$extrafields->fetch_name_optionals_label($this->table_element,true);
- $this->fet... | [User->[get_children->[fetch],setCategories->[fetch],create_from_member->[create],get_full_tree->[load_parentof],update->[fetch,update],create_from_contact->[create],create->[create],fetch_clicktodial->[error],_load_ldap_info->[fetch],load_state_board->[error],getNbOfEMailings->[error],getAllChildIds->[get_full_tree],g... | Fetch user by ID login and sid This function is used to query the user s database to find all the user s user - D ajout d un user d un nationau avec le user du SID Active private function to initialize all properties of a specific object Initialize the object This function will load all the options and values for the u... | Usage without $extralabels parameter needs to have $extrafields->attributes loaded. But if fetch_name_optionals_label is not called, array is not loaded because extrafields is a new object, so we can't make call without a parameter here. Current code in v7 seems ok and new one seems to introduce bugs. |
@@ -48,4 +48,10 @@ namespace System.Net.Http
protected override void Dispose(bool disposing) { }
protected override System.Threading.Tasks.Task<System.Net.Http.HttpResponseMessage> SendAsync(System.Net.Http.HttpRequestMessage request, System.Threading.CancellationToken cancellationToken) { throw null;... | [No CFG could be retrieved] | Override this method to allow subclasses to override. | This is weird. This enum is there as it is used in HttpHandlerDefaults. Only way how to prevent it what I have in my mind is make HttpHandlerDefaults partial and move SocketsHttpHandler related properties to System.Net.Http only. Any thought? |
@@ -43,6 +43,8 @@ public class ThrottledUseAndTimeoutExpirationPolicy extends AbstractCasExpiratio
private long timeInBetweenUsesInSeconds;
+ private Clock clock = Clock.systemUTC();
+
@JsonCreator
public ThrottledUseAndTimeoutExpirationPolicy(@JsonProperty("timeToLive") final long timeToKillInSec... | [ThrottledUseAndTimeoutExpirationPolicy->[isExpired->[isExpired]]] | This expiration policy is used to prevent a client from consuming resources in a case where a ticket Check if ticket is expired. | This should be removed as a class field; it will mess with serialization of objects. |
@@ -2606,6 +2606,15 @@ int s_client_main(int argc, char **argv)
SSL_renegotiate(con);
cbuf_len = 0;
}
+
+ if ((!c_ign_eof) && ((cbuf[0] == 'K' || cbuf[0] == 'k' )
+ && cmdletters)) {
+ BIO_printf(bio_err, "KEYUPDATE... | [No CFG could be retrieved] | function to handle errors in the command line Reads the neccesary message from the socket and sends it to the server. | Sigh. I should have fixed up that stuff before (extra parens). Rats. |
@@ -377,7 +377,11 @@ class RaidenService(Runnable):
# node with the blockchain, including the channel's state (if the channel
# is closed on-chain new messages must be rejected, which will not be the
# case if the node is not synchronized)
- self.transport.start(self, self.message_hand... | [RaidenService->[_register_payment_status->[PaymentStatus],_callback_new_block->[handle_state_change],handle_state_change->[_redact_secret],on_message->[on_message],leave_all_token_networks->[handle_state_change],stop->[stop],_initialize_messages_queues->[_register_payment_status,start_health_check_for],start->[start],... | Start the node synchronously. Restore the state of the node from WAL and update the state of the blockchain. This method is called when a node is started and the chain state is not yet synced. | can you please add kwargs here? |
@@ -136,6 +136,16 @@ public class ParseCEF extends AbstractProcessor {
.defaultValue("true")
.build();
+ public static final PropertyDescriptor INCLUDE_CUSTOM_EXTENSIONS = new PropertyDescriptor.Builder()
+ .name("INCLUDE_CUSTOM_EXTENSIONS")
+ .displayName("Include c... | [ParseCEF->[onTrigger->[process->[BufferedOutputStream,write,writeValueAsBytes,fillBuffer],getValue,put,getSize,getKey,putAllAttributes,modifyContent,set,OutputStreamCallback,prettyResult,InputStreamCallback,transfer,error,asBoolean,parse,route,CEFParser,read,getExtension,entrySet,write,get,putAttribute,key,forLanguage... | This method is used to create a PropertyDescriptor for the destination field. The default value is generally safe. | As a new property, should required be set to `false` to maintain backward compatibility? |
@@ -1606,7 +1606,7 @@ dc_pool_evict(tse_task_t *task)
ep.ep_grp = state->sys->sy_group;
rc = dc_pool_choose_svc_rank(args->uuid, &state->client,
- NULL /* mutex */, state->sys, &ep);
+ NULL , state->sys, &ep);
if (rc != 0) {
D_ERROR(DF_UUID": cannot find pool service: "DF_RC"\n",
DP_UUID(... | [No CFG could be retrieved] | This function is called from DF_DSMC_DUMP to evict a task from find the n - ary entry in the pool. | (style) space prohibited before that ',' (ctx:WxW) |
@@ -279,12 +279,13 @@ export default class Marketplace {
throw new Error('Invalid offer: currency does not match listing')
}
- if (BigNumber(listingPrice).isGreaterThan(BigNumber(chainOffer.value))) {
+ const expectedValue = BigNumber(listingPrice).multipliedBy(ipfsOffer.unitsPurchas... | [No CFG could be retrieved] | Load an offer from on - chain and off - chain data. Creates a new listing in the system. | In general, I'm not totally sure why this check uses isGreaterThan rather than isEqual ? I thought for now the DApp does not allow the buyer to specify the commission amount as part of an offer(it is always set to whatever commission is specified in the listing). Also, for the case of a multi-units listing, should the ... |
@@ -491,7 +491,7 @@ pool_properties(void **state)
rc = daos_pool_query(arg->pool.poh, NULL, NULL, prop_query, NULL);
assert_int_equal(rc, 0);
- assert_int_equal(prop_query->dpp_nr, 5);
+ assert_int_equal(prop_query->dpp_nr, 7);
/* set properties should get the value user set */
entry = daos_prop_entry_get(pro... | [bool->[daos_acl_validate,daos_acl_dump,daos_acl_get_ace_for_principal,print_message,ace_has_default_permissions,daos_ace_dump,daos_ace_get_size],void->[handle_share,uuid_generate,daos_pool_set_attr,strdup,daos_fini,daos_event_init,daos_prop_free,test_teardown,daos_pool_connect,daos_init,test_setup_next_step,WAIT_ON_AS... | create pool with properties and query it check if the rc is equal to 1 if the properties should get default value. | I know these magic numbers were already there and you were incrementing them but is there a define we could use instead somewhere? |
@@ -149,5 +149,15 @@ define([
return Cartesian2.fromCartesian4(positionWC, result);
};
+ /**
+ * @private
+ */
+ SceneTransforms.transformWindowToDrawingBuffer = function(context, windowPosition) {
+ var canvas = context.getCanvas();
+ var xScale = context.getDrawingBufferWid... | [No CFG could be retrieved] | The scene transforms are defined by the positionWC and the result is returned. | Use a `result` parameter so we don't have to allocate each time this is called. We are being mindful of this throughout Cesium for performance. See #1161. |
@@ -49,9 +49,13 @@ raw.plot(block=True, events=events)
# We can check where the channels reside with ``plot_sensors``. Notice that
# this method (along with many other MNE plotting functions) is callable using
# any MNE data container where the channel information is available.
-raw.plot_sensors(kind='3d', ch_type='... | [read_events,plot,plot_sensors,data_path,plot_projs_topomap,read_layout,plot_psd_topo,read_raw_fif,join,read_proj,plot_psd,add_proj] | This method is called when a user hits a channel type that is not available in the data Click the proj button at the lower right corner of the browser. | It's probably worth doing `raw.plot(order='selection')` below to show it to people. Plus MNE-C people might like seeing it. |
@@ -773,7 +773,9 @@ define([
var evaluate = unaryFunctions[call];
return function(feature) {
var left = this._left.evaluate(feature);
- if (typeof left === 'number') {
+ if (call === 'noise' && left instanceof Cartesian3) {
+ return Cartesian3.fromElem... | [No CFG could be retrieved] | Evaluates a unary function call on the given node and returns the result. Get the evaluation function for a binary or ternary function. | The validation check would be better below since noise with the wrong argument type deserves its own error message. |
@@ -37,7 +37,7 @@ func GetConfig() *cobra.Command {
fmt.Println("no auth config set")
return nil
}
- output, err := json.Marshal(resp.Configuration)
+ output, err := json.MarshalIndent(resp.Configuration, "", " ")
if err != nil {
return fmt.Errorf("could not marshal response:\n%v\ndue to: %v... | [RunFixedArgs,NewOnUserMachine,Println,ReadFile,Marshal,JSONToYAML,New,Unmarshal,Ctx,StringVarP,Errorf,SetConfiguration,ScrubGRPC,ReadAll,Flags,GetConfiguration] | GetConfig returns a command that gets the current auth configuration SetConfig returns a cobra command that configures the auth . | Is there a reason we don't want to indentation? Seems like it makes it more readable which is what this command is meant for. |
@@ -35,7 +35,7 @@ def _reproduce_stage(stages, node, force, dry, interactive, no_commit):
def reproduce(
self,
target=None,
- recursive=True,
+ single_item=False,
force=False,
dry=False,
interactive=False,
| [_reproduce_stages->[_reproduce_stage],_reproduce->[_reproduce_stage]] | Reproduce a sequence of objects from this Dvc object. | This is breaking the backward compatibility, but it is fine since our API is not officially released yet and this change is indeed worthy. |
@@ -40,8 +40,8 @@ type OAuthServerConfig struct {
// KubeClient is kubeclient with enough permission for the auth API
KubeClient kclientset.Interface
- // OpenShiftClient is osclient with enough permission for the auth API
- OpenShiftClient osclient.Interface
+ // RouteClient provides a client for OpenShift route... | [New->[SkipComplete,New],EnsureBootstrapOAuthClients->[New],Complete->[Complete]] | NewOAuthServerConfig creates a new OAuthServerConfig object. Auth is the main entry point for the authentication process. It is called by the client when. | Same `routeclient.RouteInterface`, see below how we use specific interfaces as well. |
@@ -79,6 +79,10 @@ class ClassMapGenerator
$classes = self::findClasses($filePath);
foreach ($classes as $class) {
+ if (array_key_exists($class, $map)) {
+ throw new \RuntimeException('Ambiguous class "'.$class.'" resolution; defined in "'.$map[$class].'" a... | [ClassMapGenerator->[createMap->[in,getRealPath],findClasses->[getMessage]]] | Creates a map of classes found in a given path. | should be `files` as you have 2 files |
@@ -50,8 +50,9 @@ public class BoundDimFilter implements DimFilter
@JsonProperty("upper") String upper,
@JsonProperty("lowerStrict") Boolean lowerStrict,
@JsonProperty("upperStrict") Boolean upperStrict,
- @JsonProperty("alphaNumeric") Boolean alphaNumeric,
- @JsonProperty("extractionFn")... | [BoundDimFilter->[getCacheKey->[getCacheKey,isAlphaNumeric,getUpper,getDimension,isLowerStrict,isUpperStrict,getLower],getDimensionRangeSet->[getExtractionFn,getUpper,getDimension,isLowerStrict,isUpperStrict,getLower],hashCode->[getExtractionFn,getLower,isAlphaNumeric,hashCode,isLowerStrict,isUpperStrict,getUpper],equa... | Produces a BoundDimFilter for a given dimension lower and upper bounds. Get the dimension of the array. | can we make this into an enum that has a method fromString(String ordering)? |
@@ -21,6 +21,12 @@
var directoryToScan = AppDomain.CurrentDomain.RelativeSearchPath ?? AppDomain.CurrentDomain.BaseDirectory;
assemblyScanner = new AssemblyScanner(directoryToScan);
+
+ if (!string.IsNullOrWhiteSpace(assemblyScannerSettings.AdditionalAssemblyScanningPa... | [AssemblyScanningComponent->[Configuration->[SetDefaultAvailableTypes->[SetDefault],settings]]] | Initializes the assembly scanning component. | Since you are validating the value in the scanner, I don't think this needs to be done here, so this code can be simplified, and the setting can move down to where the others are. |
@@ -411,6 +411,7 @@ public class WebApplicationHeader extends Composite
usernameLabel.setTitle(userIdentity);
userIdentity = userIdentity.split("@")[0];
usernameLabel.setText(userIdentity);
+ Roles.getPresentationRole().setAriaLabelProperty(usernameLabel.getElement(), "Username");
... | [WebApplicationHeader->[addCommandSeparator->[createCommandSeparator],focusGoToFunction->[focusGoToFunction],addProjectCommandSeparator->[createCommandSeparator],addRightCommandSeparator->[createCommandSeparator],advertiseEditingShortcuts->[setCommandShortcut],addLeftCommand->[addLeftCommand]]] | Initializes the commands panel. | I know this is duplicated because that's how the code is now, but out of curiosity is there any way that we can refactor some of the code in this file and DesktopApplicationHeader.java so that the common parts aren't duplicated? Not suggesting you do it in this PR, just a thought I had. |
@@ -180,10 +180,10 @@ void pipeline_schedule_triggered(struct pipeline_walk_context *ctx,
p = container_of(tlist, struct pipeline, list);
if (pipeline_is_timer_driven(p)) {
/* Use the first of connected pipelines to trigger */
- if (cmd >= 0) {
+ if (cmd >= 0 && !first_pipe) {
p->trigger.cmd = ... | [No CFG could be retrieved] | The following functions are used to set the values of the struct. find the next unused node in the list of tasks. | Why the cmd is being checked for >= 0 here? control won't come here if the switch case doesn't match |
@@ -564,3 +564,16 @@ func (r *Runtime) Export(name string, path string) error {
return ctr.Export(path)
}
+
+// RemoveContainersFromStorage attempt to remove containers from storage that do not exist in libpod database
+func (r *Runtime) RemoveContainersFromStorage(ctrs []string) {
+ for _, i := range ctrs {
+ //... | [GetRunningContainers->[GetContainers],LookupContainer->[LookupContainer],removeContainer->[RemoveContainer],HasContainer->[HasContainer],GetContainersByList->[LookupContainer],GetLatestContainer->[GetAllContainers],Export->[Export,LookupContainer]] | Export exports the container with the given name to the given path. | I think returning ErrContainerUnknown is probably better than dropping it - useful to know if we did nothing in these cases, I think. |
@@ -229,8 +229,8 @@ func (o *RollbackOptions) Run() error {
// A specific deployment was used.
target = r
- configName = appsinternalutil.DeploymentConfigNameFor(obj)
- case *appsapi.DeploymentConfig:
+ configName = appsutil.DeploymentConfigNameFor(obj)
+ case *appsv1.DeploymentConfig:
if r.Spec.Paused {
... | [Validate->[Errorf],findResource->[Object,NamespaceParam,Index,Do,ResourceTypeOrNameArgs,SingleResourceType,Errorf,IsNotFound,WithScheme,ResourceMapping,Err,builder],findTargetDeployment->[IsCompleteDeployment,ByLatestVersionDesc,Sort,List,Core,ConfigSelector,String,ReplicationControllers,DeploymentVersionFor,Errorf],R... | Run performs the rollback action Rollback rolls back to the latest version of the config missing - node - node - node - node - node - node - node - node -. | @deads2k @juanvallejo can you confirm this will work? :-) |
@@ -473,7 +473,14 @@ public class DefaultMuleMessage implements MutableMuleMessage, ThreadSafeAccess,
public void setCorrelationSequence(int sequence)
{
assertAccess(WRITE);
- setOutboundProperty(MULE_CORRELATION_SEQUENCE_PROPERTY, sequence);
+ if (sequence >= 0)
+ {
+ ... | [DefaultMuleMessage->[addOutboundProperties->[assertAccess,addOutboundProperties],equals->[equals],hashCode->[hashCode],clearInboundProperties->[clearInboundProperties],copyMessageProperties->[getOutboundProperty,getInboundPropertyNames,getOutboundPropertyNames,setOutboundProperty,getOutboundPropertyDataType,setInbound... | Sets the sequence number for the MULE correlation. | Wouldn't it be better to use nullable Integer or better Optional here? Also this assumes 0 is not a valid sequence number doesn't it? |
@@ -893,6 +893,10 @@ func (p *PollingDeviationChecker) respondToNewRoundLog(log flux_aggregator_wrapp
return
}
+ if !p.isValidSubmission(logger.Default.SugaredLogger, polledAnswer) {
+ return
+ }
+
var payment assets.Link
if roundState.PaymentAmount == nil {
logger.Error("roundState.PaymentAmount shouldn... | [isValidSubmission->[JobID],Stop->[Stop],consume->[setIsHibernatingStatus],processLogs->[reactivate,hibernate,isFlagLowered],SetOracleAddress->[New],pollIfEligible->[checkEligibilityAndAggregatorFunding,JobID],resetHibernationTimer->[Stop],resetIdleTimer->[Stop],setInitialTickers->[initialRoundState,resetTickers],serve... | respondToNewRoundLog is called when a new round log is received from the aggregator. This function is called when a new round is submitted to another node. It also sets the This function is called when a new round is requested. | Why is this new check necessary? |
@@ -254,12 +254,7 @@ public class JerseyService extends AbstractIdleService {
XHRFilter.class,
NotAuthorizedResponseFilter.class,
WebAppNotFoundResponseFilter.class)
- .register(new ContextResolver<ObjectMapper>() {
- ... | [JerseyService->[prefixPluginResources->[toSet,collect],buildSslEngineConfigurator->[CertificateException,isRegularFile,setKeyStoreBytes,createSSLContext,toArray,setEnabledProtocols,InvalidKeyException,isReadable,SSLEngineConfigurator,setKeyStorePass,isEmpty,getBytes,toCharArray,SSLContextConfigurator,buildKeyStore],in... | Build a resource config with the specified configuration. | I did the same change in the past and it resulted in missing JSON subtypes in the `ObjectMapper`. :sweat_smile: I forgot the details but it had to do with how closures work. It needs to stay as it is. |
@@ -55,6 +55,7 @@ class WPSEO_Option_Wpseo extends WPSEO_Option {
],
'access_tokens' => [],
],
+ 'started_configuration_wizard' => false,
];
/**
| [WPSEO_Option_Wpseo->[validate_option->[validate_verification_string],add_option_filters->[get_verify_features_option_filter_hook],verify_features_against_network->[prevent_disabled_options_update],add_default_filters->[get_verify_features_default_option_filter_hook],remove_option_filters->[get_verify_features_option_f... | Provides a list of options that can be used to provide a WordPress SEO page. Provides a list of possible values for the site_type option and environment types. | Please evaluate with product whether this option should be added to `WPSEO_Tracking_Settings_Data` |
@@ -203,10 +203,13 @@ class CI_Security {
if ($exclude_uris = config_item('csrf_exclude_uris'))
{
$uri = load_class('URI', 'core');
- if (in_array($uri->uri_string(), $exclude_uris))
- {
- return $this;
- }
+ foreach ($exclude_uris as $excluded) {
+ $excluded = str_replace(array(':... | [CI_Security->[_csrf_set_hash->[csrf_set_cookie],xss_clean->[xss_clean],_decode_entity->[entity_decode,xss_hash]]] | Verify the CSRF token. | I don't like these custom-made wildcards ... if somebody wants to use regular expressions, better learn them. We don't need to invent new ones. |
@@ -1482,6 +1482,7 @@ class PackageBase(with_metaclass(PackageMeta, PackageViewMixin, object)):
# Spawn a daemon that reads from a pipe and redirects
# everything to log_path
with log_output(self.log_path, echo, True) as logger:
+ ... | [PackageBase->[do_patch->[do_stage],_if_make_target_execute->[_has_make_target],check_for_unfinished_installation->[remove_prefix],do_stage->[do_fetch],dependency_activations->[extends],do_deactivate->[is_activated,_sanity_check_extension,do_deactivate],do_install->[build_process->[do_stage,_stage_and_write_lock,do_fak... | Installs a single package and its dependencies. Installs a package and its dependencies. This function is called by the parent process when a new node is created. It is called This function is called by the phase of the package. | Setting the `self.logger` attribute for the first time out of `PackageBase.__init__` might be confusing - if we start doing this it means we need to inspect all the flow of a program to understand when an instance starts to have a given attribute. |
@@ -42,7 +42,7 @@ public class HdfsConfig
private int fileSystemMaxCacheSize = 1000;
@NotNull
- public List<String> getResourceConfigFiles()
+ public List<File> getResourceConfigFiles()
{
return resourceConfigFiles;
}
| [HdfsConfig->[setResourceConfigFiles->[copyOf,splitToList],of,Duration]] | Sets the list of resource config files. | as you're changing this, why not `Path`? (i'm not sure the change is needed thought) |
@@ -174,11 +174,8 @@ public class Main {
con.setFixedLengthStreamingMode((int)tmpFile.length());
con.connect();
// send the data
- FileInputStream in = new FileInputStream(tmpFile);
- try {
+ try (Inp... | [Main->[getHudsonHome->[get],remotePost->[getResponseCode,getLocation,EncodingStream,setRequestProperty,getUserInfo,toArray,flush,setDoOutput,OutputStreamWriter,setFixedLengthStreamingMode,join,URL,name,LocalProc,readFirstLine,copyStream,endsWith,replace,getErrorStream,println,currentTimeMillis,getHeaderField,getBytes,... | This method is used to post a token to a Hudson job. This method is used to send a command to the Jenkins server to retrieve a specific node ID if e is a location not null and it is not a duplicate throw it. | We're no longer closing quietly here... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.